Re: [PR] AMBARI-26061 : Add password validation criteria for ambari local users [ambari]
himanshumaurya09876 commented on PR #3776: URL: https://github.com/apache/ambari/pull/3776#issuecomment-2157447095 Hi @brahmareddybattula @arshadmohammad @vishalsuvagia @JiaLiangC Kindly review and merger this PR Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25289 Upgrade Jquery and Bootstrap to latest versions [ambari]
smileyboy2019 commented on PR #3770: URL: https://github.com/apache/ambari/pull/3770#issuecomment-2154219882 Can the front-end upgrade the charts to the latest ones? The old charts have outdated colors and can support more graphics, making page customization more flexible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26049: Fix type error in ambari port alert [ambari]
JiaLiangC commented on PR #3772: URL: https://github.com/apache/ambari/pull/3772#issuecomment-2132468820 @Danori I haven't had time to continue working on this because I'm too busy. Could you please open a new PR to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26049: Fix type error in ambari port alert [ambari]
Danori commented on PR #3772: URL: https://github.com/apache/ambari/pull/3772#issuecomment-2129938525 @JiaLiangC , I ran into this bug as well with the Zookeeper port alert in Bigtop. Any reason you closed this PR? I was planning on fixing this but saw you had this out here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25289 Upgrade Jquery and Bootstrap to latest versions [ambari]
zRains commented on PR #3770:
URL: https://github.com/apache/ambari/pull/3770#issuecomment-2114558783
@vanshuhassija Your PR still has some issues, and I'm not sure if they only
occur when using **Yarn** separately. Here are some notable problems:
1. **backbone.js** isn't placed in the **vendor** folder. According to the
configuration in the brunch file `'javascripts/vendor.js': /^vendor/`, it won't
be included in the final build result(vendor.js), leading to the **Uncaught
ReferenceError: Backbone is not defined** error still occurring.
2. The issue of **vendor/scripts/bootstrap-popover.js** and
**vendor/scripts/bootstrap-tooltip.js** having identical content persists. Is
this in reference to
[bootstrap-popover](https://getbootstrap.com/docs/5.3/components/popovers/#enable-popovers)
and
[bootstrap-tooltip](https://getbootstrap.com/docs/5.3/components/tooltips/#enable-tooltips)?
3. There's a misalignment in the UI after running:
You can build and preview it follow the `ambari-web/pom.xml` and serve
**public** folder by [vite](https://vitejs.dev/), my **vite.config.js**:
```js
import { defineConfig } from 'vite'
export default defineConfig({
server: {
proxy: {
'/api': {
target: 'http://Your server addr',
changeOrigin: true
},
'/api/stomp/v1/websocket': {
target: 'ws://Your server addr',
changeOrigin: true,
ws: true
}
}
}
})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
JiaLiangC commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-2113757101 @arshadmohammad Your error appears to be related to PhantomJS. In my branch, I have already included the previous PR that removed PhantomJS. Removing PhantomJS can simplify the compilation process significantly. However, the previous PR for PhantomJS caused CI/CD to fail, so it was reverted. Even after reverting, CI/CD still did not recover. You can merge the changes that remove PhantomJS dependencies, and the compilation should succeed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
JiaLiangC commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-2113743446 I tested the compilation on Rocky8, and it was successful. The test commands and results are shown in the figure belowhttps://github.com/apache/ambari/assets/18082602/ff0bb2a4-521c-4e48-af6c-03ae259bd98b;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25289 Upgrade Jquery and Bootstrap to latest versions [ambari]
vanshuhassija commented on PR #3770: URL: https://github.com/apache/ambari/pull/3770#issuecomment-2113536046 @zRains I have upgraded the Backbone to latest version now. Can you please recheck once? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
arshadmohammad commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-2111551986 earlier i was able to build ambari on rocky linux 8. But now the build is failing. May be the impacts other changes `[INFO] Running 'yarn install --ignore-engines --pure-lockfile' in /home/code/forked/ambari/ambari-web [INFO] yarn install v0.23.2 [ERROR] warning Ambari@2.4.0: No license field [INFO] [1/4] Resolving packages... [ERROR] error An unexpected error occurred: "https://registry.yarnpkg.com/phantomjs: connect ENETUNREACH 104.16.3.35:443". [INFO] info If you think this is a bug, please open a bug report with the information provided in "/home/code/forked/ambari/ambari-web/yarn-error.log". [INFO] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. [INFO] [INFO] Reactor Summary for Ambari Main 3.0.0.0-SNAPSHOT: [INFO] [INFO] Ambari Main SUCCESS [ 2.738 s] [INFO] Apache Ambari Project POM .. SUCCESS [ 0.127 s] [INFO] Ambari Web . FAILURE [ 3.139 s] [INFO] Ambari Views ... SKIPPED [INFO] Ambari Admin View .. SKIPPED [INFO] ambari-utility . SKIPPED [INFO] Ambari Server SPI .. SKIPPED [INFO] Ambari Service Advisor . SKIPPED [INFO] Ambari Server .. SKIPPED [INFO] Ambari Functional Tests SKIPPED [INFO] Ambari Agent ... SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 01:20 min [INFO] Finished at: 2024-05-15T09:47:30+05:30 [INFO] [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.4:yarn (yarn install) on project ambari-web: Failed to run task: 'yarn install --ignore-engines --pure-lockfile' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :ambari-web [root@rocky1 ambari]# mvn clean install rpm:rpm -DskipTests` I will check more what is cuasing this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25289 Upgrade Jquery and Bootstrap to latest versions [ambari]
zRains commented on PR #3770: URL: https://github.com/apache/ambari/pull/3770#issuecomment-2106775737 @vanshuhassija After applying this patch, running into errors (OS: Win10 PowerShell, Node: v4.5.0, Yarn: v0.23.2), seems to encounter some minor issues. Below are the steps I followed: 1. `cd ambari-web` 2. `yarn install --ignore-engines --pure-lockfile` 3. `yarn build` (use the script **brunch build** specified in package.json). 4. Use [Live Server](https://marketplace.visualstudio.com/items?itemName=ritwickdey.LiveServer) to serve the `public` directory. Encountered errors include: ```text Uncaught ReferenceError: Backbone is not defined ... ... Uncaught SyntaxError: Identifier 'tooltipTriggerList' has already been declared ``` The second error is likely caused by the similarity in content between `ambari-web/vendor/scripts/bootstrap-popover.js` and `ambari-web/vendor/scripts/bootstrap-tooltip.js`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
arshadmohammad commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-2106200332 > Overall looks good. @arshadmohammad any more review from your side? sure, I will review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
virajjasani commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-2105403235 Overall looks good. @arshadmohammad any more review from your side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
JiaLiangC commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-2104319372 @virajjasani @arshadmohammad @brahmareddybattula could u help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
virajjasani commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2099632063 Now you should be able to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
zRains commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2097518487 @virajjasani Thanks, but it seems I don't have the permission to assign this task to myself, and others can't find me either. Possible solution: [Cannot Find Users in Assignee or Reporter Fields](https://confluence.atlassian.com/jirakb/cannot-find-users-in-assignee-or-reporter-fields-779158856.html). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
virajjasani commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2097406958 Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
zRains commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2097381658 Id is `zrain` and gmail prefix with `zrainfun` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
virajjasani commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2097358196 What is the Apache Jira id used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
zRains commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2097352607 > I have submitted a request for creation, but it appears it has not yet been approved. @virajjasani I still haven't received any updates on my application, Could you check on its status? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
[PR] AMBAR-26075: Wrong datanode pid file when security enabled and unprivileged port is used [ambari]
eubnara opened a new pull request, #3784: URL: https://github.com/apache/ambari/pull/3784 ## What changes were proposed in this pull request? fix bugs when detecting datanode pid file ## How was this patch tested? manual tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26059: Update builder and resource provider [ambari]
tarihub commented on PR #3773: URL: https://github.com/apache/ambari/pull/3773#issuecomment-2095032514 Hi @brahmareddybattula , I add Unit Test for this problem which would be `fail` if takes the origin unpatch code  After patch, Unit Test will run successfully.  Validation for this fix: script.filename can't be injectable. https://github.com/apache/ambari/assets/39155974/75038f7e-615a-4c9b-9b7f-653899484e16;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26061 : Add password validation criteria for ambari local users [ambari]
himanshumaurya09876 commented on PR #3776: URL: https://github.com/apache/ambari/pull/3776#issuecomment-2089853878 Hi @JiaLiangC This will add password validation criteria for ambari local users 1. Password should not contain the user name 2. Password should not be same as previous n passwords Like shown in below screenshots https://github.com/apache/ambari/assets/54660538/9dc93c60-182a-4698-b488-ee1c57972c86;> https://github.com/apache/ambari/assets/54660538/38b9a593-07c6-4d93-be8c-eaffaa01f401;> https://github.com/apache/ambari/assets/54660538/1ebc0606-4bd4-4f52-8b68-4305e505e298;> https://github.com/apache/ambari/assets/54660538/612a78ed-384a-4537-a793-56aae56a76ab;> https://github.com/apache/ambari/assets/54660538/001b1fe5-40ec-4c33-8228-d0ca0d8bff4a;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] Remove google analytics, as per ASF Privacy Policy. [ambari]
JiaLiangC commented on PR #3764: URL: https://github.com/apache/ambari/pull/3764#issuecomment-2080326883 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25289 Upgrade Jquery and Bootstrap to latest versions [ambari]
JiaLiangC commented on PR #3770: URL: https://github.com/apache/ambari/pull/3770#issuecomment-2080324961 @vanshuhassija Great work. Due to many of Ambari's front-end libraries being outdated and no longer maintained, there's a need for gradual iteration and updating to newer versions. This PR is excellent. I'll first test this PR in my environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26061 : Add password validation criteria for ambari local users [ambari]
JiaLiangC commented on PR #3776: URL: https://github.com/apache/ambari/pull/3776#issuecomment-2080322959 @himanshumaurya09876 I don't quite understand this PR. Could you please explain the use case for this feature? It would be great if you could provide some screenshots or similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
virajjasani merged PR #3783: URL: https://github.com/apache/ambari/pull/3783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
virajjasani commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2080322869 No worries, it will get approved soon. Let me merge this PR and once your jira account is ready, assign the jira to yourself and we can close it. Thanks, once again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
zRains commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2080321888 @virajjasani I have submitted a request for creation, but it appears it has not yet been approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
virajjasani commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2080318407 @zRains your jira account is created? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26065: Add Hadoop Federation Router Service support [ambari]
JiaLiangC commented on PR #3782: URL: https://github.com/apache/ambari/pull/3782#issuecomment-2080308226 @AnanyaSingh2121 I believe decoupling is necessary, and I'm not clear how you enabled federation, whether modifying the Hadoop configuration or restarting the cluster is required. However, by making the router standalone, testing does not require any changes to the current Hadoop cluster configuration to enable federation. 1. First, we can enable federation on an existing cluster without altering any Hadoop cluster configurations, making federation implementation impact-free for this cluster. It only requires modifying the router to monitor this Hadoop. Therefore, to enable federation for a cluster, one just needs to deploy a router, monitor the NameNode address, set up a common zookeeper and namespace, and then mount it. If we want to separate this cluster from the federated cluster for independent use, only uninstalling this router is needed, likewise without any modifications or restarts required for this existing Hadoop cluster. I think we should distinguish between client and server configurations. Ambari lacks a feature, which is differentiating Hadoop's client configurations from server configurations. After enabling federation, only client configurations need to be modified without conflicting, as the server-side configurations remain unchanged. Client configurations are provided to other big data components for reading. Alternatively, maintain a separate set of federated client configurations manually for other components. After enabling federation, server-side configurations remain unchanged: I provide a client configuration: dfs.nameservices=ns-fed dfs.namenode.rpc-address.ns-fed.r1=your router1 address dfs.namenode.rpc-address.ns-fed.r2=your router2 address dfs.namenode.rpc-address.ns-fed.rn=your routern address fs.defaultFS=hdfs://ns-fed This way, all users utilizing this client configuration will access the federation. If enabling or disabling federation requires restarting the entire cluster, it would be intolerable for an existing cluster running a significant volume of business. It seems you have developed a more comprehensive router solution. You can open a new issue and submit a PR. I will consider closing this PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26065: Add Hadoop Federation Router Service support [ambari]
AnanyaSingh2121 commented on PR #3782: URL: https://github.com/apache/ambari/pull/3782#issuecomment-2079794895 Hi @JiaLiangC , Thank you for addressing the points in detail. I have some more feedback. - Ideally we will not have a federated cluster without Router as to manage Federation we will be using Router only. So installing it as a separate separate does not provide the required decoupling. Once federation is enabled Router is a requirement. So it does not make sense to just delete Router. If Router needs to be uninstalled then federation also will have to disabled. We cannot separate the two in my opinion. - About the client requests, yes you are correct we will have to eventually modify the core-site and hdfs-site. So better to have all the conf files at one place. Also my concern was regarding managing multiple Routers as in that case you will not be able to modify the default Fs to one Router rpc. For this purpose Hadoop community proposes ns-fed a logical namespace for router. That will require testing in Ambari as those configurations will give rise to conflict. Hadoop community has also raised a jira for the same. - Also we have developed and tested the Router based federation with Router as component of HDFS. We have also included several UI changes where Router can be enabled as part of Federation flow. Will be raising a jira for the same and submit a patch. Request your inputs also on the same. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
JiaLiangC commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-2078402333 > @JiaLiangC I'm planning on opening a JIRA soon for Rocky9 support, and I don't want my changes to conflict with yours here since there will be a bit of overlap (e.g. the os_check.py & the metainfo.xml changes). Any plans on merging these changes? Thank you for your feedback. I will request a review from the community members again. @vanshuhassija Could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
Danori commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-2077459915 @JiaLiangC I'm planning on opening a JIRA soon for Rocky9 support, and I don't want my changes to conflict with yours here since there will be a bit of overlap (e.g. the os_check.py & the metainfo.xml changes). Any plans on merging these changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
JiaLiangC commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2076110226 @zRains Thanks man, LGTM. This indeed solved the issue with the frontend websocket leading to endless growth and freezing the page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
virajjasani commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2075998014 Thanks @zRains You can create jira account using https://selfserve.apache.org/jira-account.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
zRains commented on PR #3783: URL: https://github.com/apache/ambari/pull/3783#issuecomment-2074578464 Ref to issue: [AMBARI-25928](https://issues.apache.org/jira/browse/AMBARI-25928). @virajjasani Could you help review this pr? and create a jira account with this issue assigned for me? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
[PR] AMBARI-25928: Continuous increase of websocket connections in Ambari web UI [ambari]
zRains opened a new pull request, #3783: URL: https://github.com/apache/ambari/pull/3783 ## What changes were proposed in this pull request? Added debounce to `reconnect` and invoked `disconnect` to disconnect the previous connection instance when websocket performs reconnection. ## How was this patch tested? Tested manually by comparison. Before applying this fix, websocket reconnection would create multiple active connections (Time pending):  After a while (approximately 5 minutes), more connections would be created, causing page blockage or even crashes:  The fix will maintain one active websocket connection:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26065: Add Hadoop Federation Router Service support [ambari]
JiaLiangC commented on PR #3782: URL: https://github.com/apache/ambari/pull/3782#issuecomment-2073814703 @AnanyaSingh2121 Thank you for your feedback. Let me address your questions: 1. **Why treat the router as a separate service?** Although the router is part of the Hadoop source code, from an architectural standpoint, in a federated cluster, the router cluster operates independently from any specific Hadoop cluster, representing a routing layer. Thus, I believe it's inappropriate to associate the router with any particular Hadoop cluster during deployment. Moreover, having the router deployed independently allows for more flexible and clearer scalability and maintenance. To transition a cluster into a federated cluster, one simply needs to add a router and modify a few configurations. If a cluster with a router wishes to dismount from a federated setup and return to being an independent cluster, this can easily be done by uninstalling the router service and adjusting the current Hadoop configurations, which keeps the coupling low. 2. **About routing client requests to clusters and the configuration:** After deploying the router and configuring it to monitor the current cluster, along with modifying the cluster's hdfs-site, then you can perform directory mounts using `dfsrouteradmin` from the command line. Clients access using the `core-site` and `hdfs-site` configurations. By modifying the configuration, all client configurations can point to the router cluster. 3. **On your third point:** That's a great idea. It requires coordination with the frontend. Perhaps we can iterate over it step by step; achieving perfection right away is challenging. 4. **Regarding the router `service_advisor` you mentioned:** If you're interested, you might consider submitting a PR to address this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26065: Add Hadoop Federation Router Service support [ambari]
AnanyaSingh2121 commented on PR #3782: URL: https://github.com/apache/ambari/pull/3782#issuecomment-2072920519 Hi @JiaLiangC , Thank you for initiating the integration of dfsrouter with Ambari. I was going through the PR and had a few suggestions/ doubts. I see that you are adding Router as a separate service in Ambari. Essentially Router is a HDFS component only. Could you please tell the reason for this approach. Because we are still going to store the configuration file for Router under hadoop_conf directory only. Also if you could please tell how the following things will be taken care of in your approach: - how is it being made sure that client requests are being routed via the Router in single and multi router setup - there are a certain set of configurations that are required as per the hadoop community for managing multi-router setup. How will we support those configurations - Router is made a master so the cardinality will be +1. But the user should not have the ability to add router without enabling multiple namespaces. Don't you think this should be integrated as part of Ambari federation setup only as Router installation then can be controlled. - Some router based configurations like the registering nameservice should be and can done automatically by Ambari as it is aware of the multiple namespaces in the cluster. Then why do we need to include those configurations in the hdfs-rbf-site. These configurations should only be loaded when multiple namespaces exist in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26065: Add Hadoop Federation Router Service support [ambari]
JiaLiangC commented on PR #3782: URL: https://github.com/apache/ambari/pull/3782#issuecomment-2068305909 @brahmareddybattula Certainly, multiple routers have been tested. Specific test screenshots have been added to the PR description above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26065: Add Hadoop Federation Router Service support [ambari]
brahmareddybattula commented on PR #3782: URL: https://github.com/apache/ambari/pull/3782#issuecomment-2068068858 @JiaLiangC thanks for reporting this and working on this which is very much required feature. Did you test with multiple routers also.? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26065: Add Hadoop Federation Router Service support [ambari]
JiaLiangC commented on PR #3782: URL: https://github.com/apache/ambari/pull/3782#issuecomment-2066120022 @virajjasani Could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
[PR] AMBARI-26065: Add Hadoop Federation Router Service support [ambari]
JiaLiangC opened a new pull request, #3782: URL: https://github.com/apache/ambari/pull/3782 ## What changes were proposed in this pull request? Add management for Hadoop RBF (Router-Based Federation) router service, facilitating the setup and management of multiple Hadoop federation clusters. ## How was this patch tested? manual test router service check  router web ui  router web service  (Please explain how this patch was tested. Ex: unit tests, manual tests) (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this) Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25882: Fix clusterId NPE error on service operation execution [ambari]
JiaLiangC closed pull request #3663: AMBARI-25882: Fix clusterId NPE error on service operation execution URL: https://github.com/apache/ambari/pull/3663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
virajjasani commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065295488 Alright, I have taken care of this, no worries. Thank you everyone, once again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
virajjasani commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065284513 If you want to create the PR again, let me revert the commit first and then you can re-create the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
virajjasani commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065282760 Looks like my bad, i did squash & merge, not sure why the PR title was not retained. Sorry about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
virajjasani commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065280503 @Danori are you referring to (#2) reference in the commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
Danori commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2065062641 Oh looks like my commit didn't follow the typical conventions; would you guys like me to amend my commit before we merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
virajjasani commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2064614592 Thank you @JiaLiangC @Danori @wenwj0, merging the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
virajjasani merged PR #3781: URL: https://github.com/apache/ambari/pull/3781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
wenwj0 commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2063971242 Thanks @Danori, I encountered these warnings too. It appears in python 3.8+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
JiaLiangC commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2063030800 @virajjasani I encountered a similar warning message, and this modification looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26070: Ambari throws SyntaxWarnings after moving to Python3 [ambari]
virajjasani commented on PR #3781: URL: https://github.com/apache/ambari/pull/3781#issuecomment-2063026503 The changes look good overall. @JiaLiangC you also want to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26059: Update builder and resource provider [ambari]
tarihub commented on PR #3773: URL: https://github.com/apache/ambari/pull/3773#issuecomment-2061074389 I've been a little busy lately, it might take a while -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26068: Fix python3 type error on trunk reader and collections… [ambari]
virajjasani merged PR #3780: URL: https://github.com/apache/ambari/pull/3780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26068: Fix python3 type error on trunk reader and collections… [ambari]
JiaLiangC commented on PR #3780: URL: https://github.com/apache/ambari/pull/3780#issuecomment-2060236109 @virajjasani Could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
[PR] AMBARI-26068: Fix python3 type error on trunk reader and collections… [ambari]
JiaLiangC opened a new pull request, #3780: URL: https://github.com/apache/ambari/pull/3780 ….Mapping ## What changes were proposed in this pull request? 1.in Python 3, collections.Mapping has been moved. The correct import path is now collections.abc.Mapping. 2.Because all subprocess child processes have universal_newlines=True, all outputs are strings. However, os.read returns bytes, so str_buffer += data_chunk will result in an error. ## How was this patch tested? (Please explain how this patch was tested. Ex: unit tests, manual tests) (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this) Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25478. Badly formatted request may cause Ambari to crash. [ambari]
RCQE-bot commented on PR #3179: URL: https://github.com/apache/ambari/pull/3179#issuecomment-2058845966 ## RCQE-bot: Commit Quality Assessment I've carefully evaluated the recent commits, and here's the current state of the commit quality: ### Metrics - Previous Commits: diff hunk in file [...i-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java](https://github.com/apache/ambari/pull/3179/files/5f6fb25b6c1c54368702c106baea93314509015a#diff-384f562a6ccf3dd83b1fe9fa27405d36844d2c792c2c9446917723a4b53310c6) in commit [ae3cb1d3cde73cbd61e5c71d1fbdde4a53997a8b](https://github.com/apache/ambari/pull/3179/commits/ae3cb1d3cde73cbd61e5c71d1fbdde4a53997a8b) - Code Review: @dvitiiuk nah, please add "start < end" check here as well ### Suggestions - Need Review Again : The commits do not currently meet the quality standards. I recommend not merging them into the main branch until the above suggestions have been implemented and a subsequent review confirms the quality. Please address the points mentioned and submit the commits for another round of review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25724 : Bump up jetty to 9.4.48.v20220622 to resolve CVEs [ambari]
RCQE-bot commented on PR #3356: URL: https://github.com/apache/ambari/pull/3356#issuecomment-2058843615 ## RCQE-bot: Commit Quality Assessment I've carefully evaluated the recent commits, and here's the current state of the commit quality: ### Metrics - Previous Commits: diff hunk in file [ambari-server/src/main/java/org/apache/ambari/server/api/AmbariViewErrorHandlerProxy.java](https://github.com/apache/ambari/pull/3356/files#diff-44abc51f9065b53dfc758ad6c989a8755c1192b90a833c5fc4b2a037aad5ca3b) in commit [a3bad3d1767513026c376db3a7ff69529e1d406f](https://github.com/apache/ambari/pull/3356/commits/a3bad3d1767513026c376db3a7ff69529e1d406f) - Code Review: I thought @brahmareddybattula 's comment was to catch ServletException. Perhaps also encaupsulate the exception with an IOException and then throw it out? ### Suggestions - Need Review Again : The commits do not currently meet the quality standards. I recommend not merging them into the main branch until the above suggestions have been implemented and a subsequent review confirms the quality. Please address the points mentioned and submit the commits for another round of review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26059: Update builder and resource provider [ambari]
tarihub commented on PR #3773: URL: https://github.com/apache/ambari/pull/3773#issuecomment-2055538474 of course～ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26059: Update builder and resource provider [ambari]
brahmareddybattula commented on PR #3773: URL: https://github.com/apache/ambari/pull/3773#issuecomment-2054789162 @tarihub thanks for reporting and working on this. Could you please one Unit Test case for this and attach the validation snapshots after fixing this.? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25929: Add ranger 2.4 support in ambari bigtop 3.3 stack [ambari]
virajjasani merged PR #3778: URL: https://github.com/apache/ambari/pull/3778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25929: Add ranger 2.4 support in ambari bigtop 3.3 stack [ambari]
virajjasani commented on PR #3778: URL: https://github.com/apache/ambari/pull/3778#issuecomment-2052242653 This looks good overall, unless there is any objection, let me merge this after 24 hr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] Rocky9 [ambari]
mgsorigo closed pull request #3771: Rocky9 URL: https://github.com/apache/ambari/pull/3771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
[PR] AMBARI-26066: Add ambari mpack tools support [ambari]
JiaLiangC opened a new pull request, #3779: URL: https://github.com/apache/ambari/pull/3779 ## What changes were proposed in this pull request? In day-to-day operations, 99% of changes usually occur under the Ambari Stack rather than the Ambari Server itself. In such circumstances, using MPack to solely update the stack's content becomes highly essential. For instance, when updating the Ambari service code in an already existing environment, like the management code for the HDFS service, there's no need for manual distribution or synchronization, just package it into an MPack for the update. While MPacks are convenient, manually packaging an MPack can be cumbersome, hence a tool is proposed to automate the packaging of existing services into an MPack. ## How was this patch tested? manual test  after install the stack mpack ,all service linked to the installed mpack  (Please explain how this patch was tested. Ex: unit tests, manual tests) (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this) Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26066: Add ambari mpack tools support [ambari]
JiaLiangC commented on PR #3779: URL: https://github.com/apache/ambari/pull/3779#issuecomment-2046631937 @virajjasani Could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25929: Add ranger 2.4 support in ambari bigtop 3.3 stack [ambari]
JiaLiangC commented on code in PR #3778: URL: https://github.com/apache/ambari/pull/3778#discussion_r1556997735 ## ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml: ## @@ -0,0 +1,72 @@ + + + + +xasecure.policymgr.clientssl.keystore + +Java Keystore files + + true + + + + +xasecure.policymgr.clientssl.keystore.password +myKeyFilePassword Review Comment: thanks ,already changed to empty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25929: Add ranger 2.4 support in ambari bigtop 3.3 stack [ambari]
virajjasani commented on code in PR #3778: URL: https://github.com/apache/ambari/pull/3778#discussion_r1556966864 ## ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml: ## @@ -0,0 +1,72 @@ + + + + +xasecure.policymgr.clientssl.keystore + +Java Keystore files + + true + + + + +xasecure.policymgr.clientssl.keystore.password +myKeyFilePassword Review Comment: Or perhaps empty? Some places like external admin password values in xml are kept empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25929: Add ranger 2.4 support in ambari bigtop 3.3 stack [ambari]
virajjasani commented on code in PR #3778: URL: https://github.com/apache/ambari/pull/3778#discussion_r1556965399 ## ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml: ## @@ -0,0 +1,72 @@ + + + + +xasecure.policymgr.clientssl.keystore + +Java Keystore files + + true + + + + +xasecure.policymgr.clientssl.keystore.password +myKeyFilePassword Review Comment: Shall we keep this changeit to align with other password values? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25929: Add ranger 2.4 support in ambari bigtop 3.3 stack [ambari]
JiaLiangC commented on PR #3778: URL: https://github.com/apache/ambari/pull/3778#issuecomment-2043940626 @virajjasani Could you help review this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26062: Fix python3 type encoding error on configs script [ambari]
virajjasani merged PR #3777: URL: https://github.com/apache/ambari/pull/3777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-2041275778 Thanks @JiaLiangC, let me see if i can make changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26001: Ambari 2.8 Release [ambari]
JiaLiangC closed pull request #3756: AMBARI-26001: Ambari 2.8 Release URL: https://github.com/apache/ambari/pull/3756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25929: Add ranger 2.4 support in ambari bigtop stack [ambari]
JiaLiangC closed pull request #3697: AMBARI-25929: Add ranger 2.4 support in ambari bigtop stack URL: https://github.com/apache/ambari/pull/3697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
[PR] AMBARI-25929: Add ranger 2.4 support in ambari bigtop 3.3 stack [ambari]
JiaLiangC opened a new pull request, #3778: URL: https://github.com/apache/ambari/pull/3778 ## What changes were proposed in this pull request? Main logic and changes of the commit: Desc: Ambari Ranger adaptation Ambari 2.8 uses bigtopstack 3.2.0, which corresponds to apache bigtop version 3.2.0 1.All components lack corresponding ranger property files. Therefore, all ranger-related configuration files for all components are added. 2.There is a lack of ranger integration, and here we integrate the ranger service. This ranger service is ported from hdp3.1.5's ranger service. The difference is that some initialization content in the install method is referenced to the /usr/bigtop/current directory, but this directory will only be linked with the "bigtop-select distro-select set component version" command in the post-hook after the install method is completed. Therefore, the initialization logic in the install method is moved to the configure method, and a mark file is set. Once the initialization is completed, a mark file is generated, and subsequent initialization will not be performed if the mark file exists. 3. Bug fix for ranger advisor not working After integrating Ranger, most of the component advisors were not functioning properly due to the presence of ambari/ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/stack_advisor.py in the 2.8.0 branch. The working logic of stack_advisor is such that ambari/ambari-server/src/main/resources/scripts/stack_advisor.py, as the starting point, loads all advisors, including stack_advisor.py and service_advisor.py under ambari/ambari-server/src/main/resources/stacks directory. service_advisor.py loads all service_advisor.py under each component directory and retrieves the recommended configuration, such as ambari/ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/HDFS/service_advisor.py, which contains all recommended HDFS configurations. However, in the 2.8.0 branch, ambari/ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/stack_advisor.py hardcodes to only return a few service advisors, causing all other component service advisors to not work properly. Furthermore, ambari/ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/stack_advisor.py is redundant, and the configurations are scattered in each service advisor. Therefore, removing this file fixed the issue. The fix can be found in this PR: https://github.com/apache/ambari/pull/3677. ## How was this patch tested? manual test before enable kerberos all compoent works smoonthly   after enable kerberos all compoent works smoonthly   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
JiaLiangC commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-2038584528 @virajjasani hello, i created a separate Jira fir CI/CD failed issue : https://issues.apache.org/jira/browse/AMBARI-26064 could you help try fix this issue, I would like to try solving this issue, but I am not a committer and do not have access to view the CI/CD. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
[PR] AMBARI-26062: Fix python3 type encoding error on configs script [ambari]
shubhluck opened a new pull request, #3777: URL: https://github.com/apache/ambari/pull/3777 ## What changes were proposed in this pull request? Fix python3 type encoding error on configs script ## How was this patch tested? Tested the patch with python v3.9.18 and able to modify config changes with configs.py script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
JiaLiangC commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-2005509129 @virajjasani Thanks for your patient review. Of course, I can create a Jira, but I don't have the permissions to modify or view Jenkins, so this issue can only be resolved by a committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-2004165682 Thanks @JiaLiangC For chromium-browser plugin, please feel free to create separate Jira as per your convenience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani merged PR #3775: URL: https://github.com/apache/ambari/pull/3775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
JiaLiangC commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-2003008910 @virajjasani agree, the CI/CD can be fixed separately. This PR itself has passed all the unit tests, and the failure of the CI/CD is solely due to the chromium-browser. As for the support for Ranger KMS services, there are no additional tests needed, and it can be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-2002998779 Sure we can try these options. I wonder if we strictly need the jenkins build to pass for this PR though. Perhaps we can fix the build separately. For Ranger support, is there any additional testing you would like to do? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
JiaLiangC commented on PR #3775:
URL: https://github.com/apache/ambari/pull/3775#issuecomment-1999127109
@virajjasani thanks for your effort
In Ubuntu, the installation location of `chromium-browser` can vary
depending on the method used for installation, such as directly from the Ubuntu
repositories or through a snap package. Common installation locations include:
1. **Installed via apt** (Ubuntu repositories):
- `/usr/bin/chromium-browser`
2. **Installed via snap**:
- `/snap/bin/chromium`
For modifying the Jenkins script, there are two suggested approaches:
### Approach 1: Limit the Search Scope
Since `chromium-browser` is most likely installed in `/usr/bin/` or
`/snap/bin/` for snap installations, you can directly check these locations
instead of the entire filesystem to avoid unnecessary permission issues. The
modified Jenkins script could look like this:
```groovy
stage('Parallel Unit Tests') {
parallel {
stage('Ambari WebUI Tests') {
steps {
sh 'lsb_release -a'
sh 'ls /usr/bin'
// Directly check possible installation locations
sh 'if [ -f /usr/bin/chromium-browser ]; then export
CHROME_BIN=/usr/bin/chromium-browser; fi'
sh 'if [ -f /snap/bin/chromium ]; then export
CHROME_BIN=/snap/bin/chromium; fi'
sh 'mvn -X -T 2C -am test -pl ambari-web,ambari-admin
-Dmaven.artifact.threads=10 -Drat.skip'
}
}
// Other test stages...
}
}
```
### Approach 2: Using sudo
If you need to search the entire filesystem for `chromium-browser` and you
have permissions to use `sudo` in Jenkins scripts, you can run the `find`
command with `sudo`. However, this is generally not recommended for security
reasons, as it could expose sensitive parts of the system or unnecessarily
elevate script permissions. If you decide to use `sudo`, ensure the Jenkins
user has appropriate `sudo` privileges and the `sudoers` configuration is
correct. The modified command might look like:
```sh
sh 'sudo find / -name "chromium-browser" 2>/dev/null'
```
Here, `2>/dev/null` is used to ignore error output, such as permission
denied messages.
**Security Tip**: In production environments, avoid using `sudo` for
commands that could affect system security and stability. Approach 1 is a
safer, more focused method and should be considered first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani commented on PR #3775:
URL: https://github.com/apache/ambari/pull/3775#issuecomment-1999033931
@JiaLiangC I do see this in the configs
```
stage('Parallel Unit Tests') {
parallel {
stage('Ambari WebUI Tests') {
steps {
sh 'lsb_release -a'
sh 'ls /usr/bin'
sh 'find / -name "chromium-browser"'
sh 'export CHROME_BIN=/usr/bin/chromium-browser'
sh 'mvn -X -T 2C -am test -pl
ambari-web,ambari-admin -Dmaven.artifact.threads=10 -Drat.skip'
}
}
stage('Ambari Agent Tests') {
steps {
sh 'pip3 install distro'
sh 'mvn -Dmaven.test.failure.ignore=true -am test
-pl ambari-agent -Dmaven.artifact.threads=10 -Drat.skip'
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-1989769089 @brahmareddybattula @arshadmohammad are you aware of this by any chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
JiaLiangC commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-1987512138 @virajjasani The CI failure has nothing to do with this PR. According to the logs, it's still a UI failure, unable to find Chrome. It seems that besides the PhantomJS PR, there was an impact on CI/CD. It appears that the CI/CD scripts were also modified, causing the failure. I don't have permission to view the CI/CD configuration files. Can you compare the recent changes in the CI/CD configuration files to see if Chrome installation has been removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-1987144960 Let's re-trigger the build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-1987144680 The commit has been reverted https://github.com/apache/ambari/commit/35fbf98b501c0aa535e07a7b243092bbad4969ae -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
virajjasani commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-1985191182 @arshadmohammad are you fine with reverting #3760? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
JiaLiangC commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-1982273698 @virajjasani CI/CD failures for all Ambari PRs, attributed to a recent merge that removed PhantomJS in PR #3760. In order to ensure the smooth execution of CI for future PRs, could you help check and considering a revert of this PR. Here is the link to the problematic PR: [PR #3760](https://github.com/apache/ambari/pull/3760) The detailed discussion on the failure reasons can be found here: [PR #3751 - Comment](https://github.com/apache/ambari/pull/3751#issuecomment-1950684972) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26055: Add alluxio support [ambari]
JiaLiangC commented on PR #3774: URL: https://github.com/apache/ambari/pull/3774#issuecomment-1978046989 @arshadmohammad Could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26056: Add ranger kms support [ambari]
JiaLiangC commented on PR #3775: URL: https://github.com/apache/ambari/pull/3775#issuecomment-1977766243 @virajjasani Could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
[PR] AMBARI-26056: Add ranger kms support [ambari]
JiaLiangC opened a new pull request, #3775: URL: https://github.com/apache/ambari/pull/3775 ## What changes were proposed in this pull request? Add ranger kms support to ambari (Please fill in changes proposed in this fix) ## How was this patch tested? Manual test   (Please explain how this patch was tested. Ex: unit tests, manual tests) (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this) Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25926: Ambari Metrics Storm Sink (Legacy) Build Failure [ambari]
wangzheyuan closed pull request #3686: AMBARI-25926: Ambari Metrics Storm Sink (Legacy) Build Failure URL: https://github.com/apache/ambari/pull/3686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25919: Avoid notifications overwhelming the dev list [ambari]
tisonkun commented on PR #3666: URL: https://github.com/apache/ambari/pull/3666#issuecomment-1963918452 No feedback. Seems uninteresting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-25919: Avoid notifications overwhelming the dev list [ambari]
tisonkun closed pull request #3666: AMBARI-25919: Avoid notifications overwhelming the dev list URL: https://github.com/apache/ambari/pull/3666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26008: Add openEuler operating system support [ambari]
wenwj0 commented on PR #3757: URL: https://github.com/apache/ambari/pull/3757#issuecomment-1962918716 > @MacChen01 @brahmareddybattula > > This PR is somewhat disruptive as it changes a lot of content. Essentially, the limitation of Ambari's support for multiple operating systems is just to ensure the use of the correct package management tool during installation. Therefore, after upgrading to Python 3, supporting different operating systems becomes easy. It only requires modifying the OS check logic to categorize operating systems based on the package manager. For instance, operating systems like Red Hat 7, 8, 9, and openEuler would return 'redhat', thus uniformly using YUM as the package manager. On the other hand, those using APT would be classified as 'ubuntu'. Our production environment has already adopted this new approach, making support for new operating systems extremely convenient, requiring changes to just one file, oscheck.py. Adding support for new operating systems in the future will become very easy. Therefore, I am still considering whether to close this PR and discuss on the mailing list whether we need to change so much code to add a new operating system or if there is a simpler way to extend support for other operating systems. > > As shown in the following image: support for many operating systems has been added by merely changing this code.  +1 for this idea. Many operating systems now use YUM as the package manager. If these OS can be grouped into one category, it will be much simpler to add similar operating systems in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
JiaLiangC commented on PR #3758: URL: https://github.com/apache/ambari/pull/3758#issuecomment-1960594176 @vanshuhassija Could you help review this pr? This CI error is not related to this PR. it's an issue with the trunk branch. @arshadmohammad @vanshuhassija @brahmareddybattula CI failed details : https://github.com/apache/ambari/pull/3751#issuecomment-1950684972 The CI failure is due to the PR （https://github.com/apache/ambari/pull/3760）that was merged earlier. Can we first revert it to solve all the CI failure issues, and then merge it again after the PR-related CI failure issue is resolved? Otherwise, all PRs are affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26008: Add openEuler operating system support [ambari]
timyuer commented on PR #3757: URL: https://github.com/apache/ambari/pull/3757#issuecomment-1958986006 > @MacChen01 @brahmareddybattula > > This PR is somewhat disruptive as it changes a lot of content. Essentially, the limitation of Ambari's support for multiple operating systems is just to ensure the use of the correct package management tool during installation. Therefore, after upgrading to Python 3, supporting different operating systems becomes easy. It only requires modifying the OS check logic to categorize operating systems based on the package manager. For instance, operating systems like Red Hat 7, 8, 9, and openEuler would return 'redhat', thus uniformly using YUM as the package manager. On the other hand, those using APT would be classified as 'ubuntu'. Our production environment has already adopted this new approach, making support for new operating systems extremely convenient, requiring changes to just one file, oscheck.py. Adding support for new operating systems in the future will become very easy. Therefore, I am still considering whether to close this PR and discuss on the mailing list whether we need to change so much code to add a new operating system or if there is a simpler way to extend support for other operating systems. > > As shown in the following image: support for many operating systems has been added by merely changing this code.  @JiaLiangC This is a good idea, but this approach is not very standardized. Do you think we may need to consider restructuring the structure of ambari? Welcome to open the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
