Ivy 2.5 and generics
During a discussion about goals for Ivy 2.5, I mentioned generics [1]. I was looking into the matter because I was investigating how IvyDE hooks into Ivy and I didn't quite like what I saw. I'd like to generify Ivy as much as possible for 2.5 (staying binary compatible, of course) so that decisions for the next release could be more informed. Should you agree, I'd finish the work with two more commits (one for core and one for plugins package) -- I pushed two commits already that ended up in PR #45. Now, I'll digress, but I believe it's worth mentioning. Apart from generics, there's one last thing I'd like to have in Ivy 2.5, and that's SVG in Ivy reports. I only heard one opinion (which was positive) about the non-limbless ant in vectorised Ivy logo, and no protests, so I take it as a silent approval :-) BTW I hope asciidoc can inline SVG in HTML, although some repeating icons would better be placed in CSS (as mentioned in comments to PR #39). [1] http://mail-archives.apache.org/mod_mbox/ant-dev/201705.mbox/%3CCALVNWHXiZPVJmKimTB9Qxo9u6%2BNX%2Br7Kpmk3uvZvqtUxLQpekQ%40mail.gmail.com%3E Gintas
Process for handling GitHub PRs and closing them
We have (read only) github repos which back our main ASF git repos (consider the github ant-ivy repo which is a read-only mirror of ASF git repo). Users submit pull requests to our github repos and the process I follow for merging such PRs is the “rebase” approach which looks something like this: - Fetch the PR locally (git fetch github pull/45/head:pr-45) - Checkout to that branch locally (git checkout pr-45) - Rebase that PR on top of latest ASF (upstream) repo (git rebase asf/master) - Run a short build, verify and push to ASF repo (git push asf pr-45:master) (assume 45 is the pull request id). So essentially, I rebase the commits from the PR on top of the latest master and then push to the ASF repos. All this works fine and the ASF repos get those changes. However, this doesn’t “close” the pull request on github. Apparently, the way to have the pull request closed is doing a actual “merge” of the pull request commits into the ASF repo instead of rebasing the commits. Then the other approach, which isn’t that clean IMO, is to push a commit to the ASF repo with a commit message which includes “This closes #X” where X is the pull request id. The ASF github bot then notices this commit messages and goes and closes the open PR. I usually prefer the rebase approach (the one I outlined above) for dealing with pull requests, since it gives a clean git commit tree. But clearly that doesn’t have a way to close the PR. Is there any preferred approach that we should follow with PRs? The other thing I had in mind, if we agree upon, is to have an enhancement raised with the ASF infra team to allow adding some specific comment on the open PR by a *committer* which then auto-closes the PR. Some comment like “This PR is merged”. Any thoughts? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Ivy - we have now moved to asciidoc for docs
The documentation for ant-ivy project has now been migrated to asciidoc. The migration used a tool developed by Nicolas to migrate the xooki backed HTML docs to asciidoc. This tool auto-generated the asciidoc text and for most part no other changes were needed. However, there are some fixes the generated asciidoc will need which I’m doing and will continue to do in the coming days to fix any issues with the generated doc. Once the fixes are done, soon, we’ll remove the xooki backed documentation completely from our git repo. For now though, any new documentation or changes should go into the asciidoc files. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #47: Move to asciidoc for documentation
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/45 I pushed new commits which ended up in this PR ð This adds more generics in ant and tools, only core and plugins left ð To dispel all scares about generics I added a binary compatibility test. My choice was between japicmp and revapi. The latter has an Ant task (with broken dependencies), but requires Java 8. The former works with Java 7 (thanks to Guava), but my JavaScript hack requires Nashorn. Therefore, the target is standalone and can be run as 'ant revapi' (a wink to my first choice). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/45 Thanks for the PR. Merged. P.S: Someone else will have to close this PR, till I understand how I can auto-close this or get access to a close button. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Bug report for Ant [2017/06/18]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 5003|Opn|Blk|2001-11-21|exec task does not return after executed command f| | 6606|Opn|Enh|2002-02-21|META-BUG problems with delegating classloaders| | 7552|Opn|Cri|2002-03-28|Invalid task cache in targets | | 7712|New|Enh|2002-04-03|Provide patternset support for VSSGET task? | | 8294|New|Enh|2002-04-19|: Allow and to app| | 8866|New|Enh|2002-05-07|Signal handling in java task | | 8895|New|Enh|2002-05-08|ant and/or antcall should support forking | | 8972|New|Enh|2002-05-10|allow property expansion in property v| | 8981|New|Enh|2002-05-10|Tar task command additional features | | 9294|New|Enh|2002-05-21|[PATCH] optional/j2ee/ServerDeploy OC4J Support | | 9995|Ass|Enh|2002-06-19|MKS Source Integrity tasks| |10020|New|Enh|2002-06-19|'s dependency behaviour should be more con| |10231|New|Enh|2002-06-25|Need access to current file in SQLExec| |10283|New|Enh|2002-06-27|Add a destfile to the uptodate task | |10402|New|Enh|2002-07-02|adding the ability of html like whitespace preserv| |3|New|Enh|2002-07-24|keytool task | |11560|Opn|Enh|2002-08-08|Taskdef does not apply reverseLoader policy on sta| |12267|New|Enh|2002-09-03|Add ability to unzip into separate folders| |12292|New|Enh|2002-09-04|[PATCH] enable tag inside tar| |12334|New|Enh|2002-09-05|REQUEST: Ant task doesn't allow attachment of a bu| |12518|New|Enh|2002-09-11|Gunzip & BUnZip2 add filesets, patternsets, and ov| |12765|New|Enh|2002-09-18|"rmdir" and "deltree" patches for ftp task enhance| |12964|New|Enh|2002-09-24|ANTLR only takes one input file at a time | |13047|Inf|Enh|2002-09-26|Support for and on O| |13371|New|Enh|2002-10-07|[PATCH] Contributed new CvsExportDiff task| |13847|New|Nor|2002-10-22|pvcs task: wrong option (-r) specified for get (sh| |13934|New|Enh|2002-10-24|Translate task shouldn't load default locale prope| |13939|New|Enh|2002-10-24|Translate task should have better key matching cap| |14320|New|Enh|2002-11-06|copy fileset followsymlinks="false" does not copy | |14393|New|Enh|2002-11-08|Support use of jndi within ant| |14512|New|Enh|2002-11-13|Allow creating database connection similar to
