[GitHub] ant pull request #:

[bodewig]

Github user bodewig commented on the pull request:


https://github.com/apache/ant/commit/b7461ce2e43bda44a1ba5355f78288c85da773bc#commitcomment-29586480
  
In manual/install.html:
In manual/install.html on line 931:
I'll change it tomorrow.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

[twogee]

Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/b7461ce2e43bda44a1ba5355f78288c85da773bc#commitcomment-29585155
  
In manual/install.html:
In manual/install.html on line 931:
Sorry about nitpicking: I would prefer a space between Java and the version.
java.activation.jmod is still there in Java 10, but must be activated by a 
command-line option.
It will be gone completely in Java 11, I suppose.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Jenkins-Builds failing

[Gintautas Grigelionis]

Ant nightly is stuck on archiving for 30 hours now.
It should be escalated, I believe that could have something to do with the
last upgrade of Jenkins.

Gintas

On Mon, 2 Jul 2018 at 14:18, Jan Matèrne  wrote:

> Several of our Jenkins builds are failing:
>
>
>
> IvyDE:
>
> https://builds.apache.org/view/A/view/Ant/job/IvyDE/
>
> https://builds.apache.org/view/A/view/Ant/job/IvyDE/lastBuild/console
>
> Can't get
>
> http://download.eclipse.org/webtools/downloads/drops/R3.4.2/R-3.4.2-20130208
> 151217/wtp4x-R-3.4.2-20130208151217.zip
> 
> to
>
> /home/jenkins/jenkins-slave/workspace/IvyDE/dependencies/wtp4x-R-3.4.2-20130
> 208151217.zip
>
>
>
> The source URL gives a 404.
>
>
>
>
>
> AntLib - AntUnit
>
> https://builds.apache.org/view/A/view/Ant/job/AntLib-antunit/
>
>
> https://builds.apache.org/view/A/view/Ant/job/AntLib-antunit/lastBuild/conso
> le
>
> [ivy:resolve]   Server access error at url
>
> https://repo1.maven.org/maven2/org/apache/ant/ant-testutil/1.8.1/ant-testuti
> l-1.8.1.pom
> 
> (javax.net.ssl.SSLException: Received fatal alert:
> protocol_version)
>
>
>
>
>
> AntLib - SVN
>
> same problem as for AU
>
>
>
>
>
> Ivy
>
> https://builds.apache.org/view/A/view/Ant/job/Ivy/
>
> https://builds.apache.org/view/A/view/Ant/job/Ivy/lastBuild/console
>
> same problem as for AU
>
>
>
>
>
> Ant Nightly
>
> https://builds.apache.org/view/A/view/Ant/job/Ant_Nightly/
>
> https://builds.apache.org/view/A/view/Ant/job/Ant_Nightly/lastBuild/console
>
> all runs fine, but "Archiving artifacts" requires lt of time …
>
>
>
>
>
> Ideas?
>
>
>
> Jan
>
>

Re: FileUtils.normalize/isLeadingPath have bitten me

[Stefan Bodewig]

On 2018-07-03, Jaikiran Pai wrote:

> I did some testing manually for this new method, with both symlinks
> and non-symlinks with both the string check version and the
> getParent() version. In both of those, I couldn't get it to break in
> any odd ways (which is a good thing). It also means that my theory
> that the string comparison may not always be a best idea is just
> theoretical. However, I just feel a bit more comfortable seeing the
> getParent() version since that then removes any kind of file separator
> or odd backslash/frontslash permutations that we may not have thought
> of and instead leaves it to the JRE implementation to deal with
> it. Again, this is me being a bit paranoid than any real demoable
> issue with the string comparison code.

I welcome paranoia in particular if security is involved. :-)

> At this point, I think these commits address the issue that we sought
> out to fix. So unless someone else sees any issues, I think we can go
> ahead and do the release that you had planned for.

Thanks. I'll let it sit for a bit longer and will cut release candidates
later the coming days.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: FileUtils.normalize/isLeadingPath have bitten me

[Jaikiran Pai]

Hi Stefan,

I did some testing manually for this new method, with both symlinks and 
non-symlinks with both the string check version and the getParent() 
version. In both of those, I couldn't get it to break in any odd ways 
(which is a good thing). It also means that my theory that the string 
comparison may not always be a best idea is just theoretical. However, I 
just feel a bit more comfortable seeing the getParent() version since 
that then removes any kind of file separator or odd backslash/frontslash 
permutations that we may not have thought of and instead leaves it to 
the JRE implementation to deal with it. Again, this is me being a bit 
paranoid than any real demoable issue with the string comparison code. 
So thank you for using the getParent() call in this implementation.


At this point, I think these commits address the issue that we sought 
out to fix. So unless someone else sees any issues, I think we can go 
ahead and do the release that you had planned for.


-Jaikiran


On 03/07/18 1:16 PM, Stefan Bodewig wrote:

On 2018-07-02, Stefan Bodewig wrote:


On 2018-07-02, Jaikiran Pai wrote:

I just checked the commits related to this and it looks mostly
correct. However, I am still not 100% sure we have covered it all with
this new method that was introduced[1] and used in the unzip
part. What I mean is, the API expectations are right. However the
implementation _might_ need a bit of rethink since it still relies on
path string comparison (checks like endsWith) instead of a getParent()
check.

I mostly kept the string comparison for performance reasons, but maybe
that point is moot and performance should not be a concern
here. Rewriting it to use getParent is no problem at all.

Done

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks + Common...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/54
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/65/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks + Common...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/54
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/59/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: ant task mail fails on jdk10

[Stefan Bodewig]

On 2018-07-03, Jan Matèrne (jhm) wrote:

> We already have something:
> mail: "This task may depend on external libraries that are not included in
> the Ant distribution. See Library Dependencies for more information."
> dependencies:
> "mail.jar Mail task with Mime encoding, and the MimeMail task
> http://www.oracle.com/technetwork/java/index-138643.html
>  activation.jar   Mail task with Mime encoding, and the MimeMail task
> http://www.oracle.com/technetwork/java/javase/jaf-135115.html";

Well at least we should update the links :-)

Given javax.activation has been part of the core lib for a few releases
(IIRC it was added in Java6 and now gets removed again) people will not
have installed it and now are caught by surprise. Therefore I suggest to
create a FAQ entry for it and add an additional hint to the mail task
manual.

> So what changed with Java10?

The blurb about activation.jar being an external library has become true
again. It is false when using Java6 to 9.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: FileUtils.normalize/isLeadingPath have bitten me

[Stefan Bodewig]

On 2018-07-02, Stefan Bodewig wrote:

> On 2018-07-02, Jaikiran Pai wrote:

>> I just checked the commits related to this and it looks mostly
>> correct. However, I am still not 100% sure we have covered it all with
>> this new method that was introduced[1] and used in the unzip
>> part. What I mean is, the API expectations are right. However the
>> implementation _might_ need a bit of rethink since it still relies on
>> path string comparison (checks like endsWith) instead of a getParent()
>> check.

> I mostly kept the string comparison for performance reasons, but maybe
> that point is moot and performance should not be a concern
> here. Rewriting it to use getParent is no problem at all.

Done

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: ant task mail fails on jdk10

[Gintautas Grigelionis]

libraries.properties for Ant 1.10.x specify javax.mail 1.6.1 which pulls in
activation 1.1

Gintas

On Tue, 3 Jul 2018 at 08:19, Jan Matèrne (jhm)  wrote:

> Did my own test:
>
>   password="${mail.pwd}" from="${from}" subject="Testemail">
>  
>  
> Ant-Version:  ${ant.version}
> Java-Version: ${java.version}
>  
>  
>
> Running with Java8 + Java10, and I got my two mails:
>
> Ant-Version:  Apache Ant(TM) version 1.10.1 compiled on
> February
> 2 2017
> Java-Version: 1.8.0_171
>
> respectively
>
> Ant-Version:  Apache Ant(TM) version 1.10.1 compiled on
> February
> 2 2017
> Java-Version: 10.0.1
>
>
> I contrast to my last mail, I could install activation via fetch.xml.
> I had run "ant -f fetch -Ddest=system" before.
>
>
> Jan
>
>
>
> > -Ursprüngliche Nachricht-
> > Von: Jan Matèrne (jhm) [mailto:apa...@materne.de]
> > Gesendet: Dienstag, 3. Juli 2018 07:43
> > An: 'Ant Developers List'
> > Betreff: AW: ant task mail fails on jdk10
> >
> > We already have something:
> > mail: "This task may depend on external libraries that are not included
> > in the Ant distribution. See Library Dependencies for more
> > information."
> > dependencies:
> > "mail.jar Mail task with Mime encoding, and the MimeMail task
> > http://www.oracle.com/technetwork/java/index-138643.html
> >  activation.jar   Mail task with Mime encoding, and the MimeMail task
> > http://www.oracle.com/technetwork/java/javase/jaf-135115.html";
> >
> > mail.jar could be downloaded via "ant -f fetch.xml javamail", but
> > activation has to be installed.
> >
> >
> > So what changed with Java10?
> >
> >
> > Jan
> >
> >
> > > -Ursprüngliche Nachricht-
> > > Von: Stefan Bodewig [mailto:bode...@apache.org]
> > > Gesendet: Montag, 2. Juli 2018 18:00
> > > An: dev@ant.apache.org; Simon IJskes - QCG
> > > Betreff: Re: ant task mail fails on jdk10
> > >
> > > Thank you, Simon
> > >
> > > On 2018-07-02, Simon IJskes - QCG wrote:
> > >
> > > > As bugzilla is unreachable for now:
> > >
> > > > 
> > > >  > > > subject="Testemail"  >
> > > > 
> > > > 
> > > > 
> > >
> > > > $ JAVA_HOME=/usr/lib/jvm/java-8-oracle/
> > > > ~/opt/apache-ant-1.10.4/bin/ant _testmail
> > >
> > > > runs ok.
> > >
> > > > _testmail:
> > > >  [mail] Sending email: Testemail
> > > >  [mail] Sent email with 0 attachments
> > >
> > >
> > > > $ JAVA_HOME=/usr/lib/jvm/java-10-oracle/
> > > > ~/opt/apache-ant-1.10.4/bin/ant _testmail
> > >
> > > > _testmail:
> > > >  [mail] Failed to send email: javax.activation.DataHandler
> > >
> > > JAF has been removed from Java 10, so now you need to provide its
> > > replacement https://github.com/javaee/activation when starting Ant.
> > >
> > > I don't really think we need to change anything inside of Ant but
> > > should document the fact and likely add something to the FAQ in
> > > addition to the mail task's manual page.
> > >
> > > Stefan
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> > > commands, e-mail: dev-h...@ant.apache.org
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> > commands, e-mail: dev-h...@ant.apache.org
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>