[GitHub] ant pull request #:
Github user janmaterne commented on the pull request: https://github.com/apache/ant/commit/ca98cc50364f694e1642f84a0c43d0134098ed30#commitcomment-29497107 In manual/credits.html: In manual/credits.html on line 49: acute for Antoine and grave for me. ;) Never learnd french neither ... --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #62: Use char notation to represent a character to improve perform...
Github user janmaterne commented on the issue: https://github.com/apache/ant/pull/62 These changes might improve performance, but do you have a testsuite with validates that? Most of the changes are done on places which are rarely invoked in a build (without having tested that ;-) --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #55: use the vectorised logo
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/55
Still open are:
IvyLogo.java
JavaDoc of the parameters of IvyLogo(int width, int height) are bad
("ditto")
test the report
But a simple ivy:report didnt work, I changed build.xml:500 to use
explicitly the new xsl
Maybe my local environment ...
--> does the fresh built Ivy use the SVG graphics?
Violations of the license header:
ivy-lierre.svg (header missing, remove the generator comment)
IvyLogo (header missing)
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #36: Allow faking of zip entry modification times.
Github user janmaterne commented on the issue: https://github.com/apache/ant/pull/36 ant-unit-1.3 is in the repo (https://github.com/apache/ant/blob/master/lib/optional/ant-antunit-1.3.jar). It seems that you use an Ant version for building this which does not contain this jar. If you are building Ant itself I recommend cleaning the environment before (unset ANT_HOME) and bootstrap Ant by itself. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #55: use the vectorised logo
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/55 Violations of the license header: * ivy-lierre.svg (missing, remove the generator comment) * IvyLogo (missing) --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #55: use the vectorised logo
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/55
ivy-lierre.svg:
- looks good
- havent compared, I think asciidoc/images and doc/images are the same?
- why this name? why not simply logo.svg? (ok, I see: ivy-lierre.png ...)
But there is logo.png with same content (only smaller borders)
ivy-report.css
- seems that here is only different formatting
ivy-report.xsl
- formatting
- changed to
- translated img/@art->svg//title and img/@title->svg//title
! couldnt see the content of the grafik (where is defined that
searched/downloaded svg should be used?)
IvyLogo.java
- havent tested that generated code
- JavaDoc of the parameters of IvyLogo(int width, int height) are bad
("ditto")
- I am thinking about the code generation ...
a) include the flamingo task into our build and remove the generated code
(= keep the model (svg) and the generator)
b) just keep that generated code
c) reuse the svg (Java reads the svg-resource and interpretes the drawing)
Because this is one-shot we could go with b) ...
Checked out the code and the report looks fine.
But a simple ivy:report didnt work, I changed build.xml:500 to use
explicitly the new xsl
Maybe my local environment ...
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 Merged that, thanks. Hint for future PRs: smaller are better (easier to review) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 Nop ... yes. You're right with 'null instanceof SomeClass'==true. But the two assertions are different: moduleId = null; assertFalse(moduleId.equals(null);; --> this will throw a NullPointerException --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 I wont split this PR. Adress these in this PR: - diamond operator - renaming - ModuleIdTest The other things should be done in a new PR (PRs shouldnt be too big ;) I wouldnt remove commons-collections as it is an example how to use external libs with Ivy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/38 All fine with me. Maybe we could extract the method into FileUtil later. I'll merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/38 requireCommonBaseDir: - could we replace firstPath by base==null? - line 115: additional comment: 'fail fast: ...' - line 117: 'finally we got ...' getBaseDir: - Rename parameter to file1 and file2. For me it seems that both parameters are indepent from each other. 'base' implies that it's itself a parent of the other. - you changed the semantic of the method: base==null && file==null --> old=NPE, new=null (ok with me ;) base==null && file!=null --> old=file.paren, new=null (incompatible change) base!=null && file==null --> both=null base!=null && file!=null --> both=commonBase - could be static, maybe moved to a FileUtil-class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #44: IVY-1561 - Enhancement to take into account environment a...
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/44 merged, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 Java7 supports the diamond operator and Ivy's baseline is now Java7. So you could use that (e.g. CCFilter.java). HMFilter: one advantage of foreach is having a meaningful iterator name. So renaming s/string/value/ would be more readable. HelloIvy: maybe you could change the hello-message: s/hello ivy !/Hello Ivy!/ src/example/multi-project/projects/find/src/find/Main.java: maybe also change from raw Collection to Collection, so the foreach could also be typed. This would impact FindFile. --> better in a separate PR Same for src/example/multi-project/projects/list/src/list/Main.java --> better in a separate PR Same src/example/multi-project/projects/size/src/size/FileSize.java --> better in a separate PR test/java/org/apache/ivy/core/module/id/ModuleIdTest.java You changed the semantics: assertFalse(moduleId.equals(null)) --> asserts that moduleId is not null (otherwise a NPE would be thrown) and it's equal-comparison returns false assertNotNull(moduleId) --> 'just' assert that moduleId is not null --> maybe just place the notnull before the assertfalse? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #34: eblikstad
Github user janmaterne commented on the issue: https://github.com/apache/ant/pull/34 Thanks for the PR. The first view: * there isnt any test (not sure it would be possible) * baseline is Ant_1.8, which is not maintained any more. Current Ant is 1.9 for Java5 and Ant 1.10 for Java8, see http://ant.apache.org/faq.html#java-version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #39: first batch of SVG replacements
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/39 Ok, license debate finished. I think its ok. Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #41: Checkstyle
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/41 I found a comment in hibgraph.svg: "Helvetica is a registered trademark of Linotype AG". I am not sure about using that in an Apache project ... I'll forward this to the dev llist. Maybe to legal@a.o later ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #41: Checkstyle
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/41 There a bunch of new image files (svg, ...) I dont think that this is related to 'checkstyle'. The other files: - remove trailing spaces - add required 'final' to parameters - add javadoc - ordering of modifiers Have to think about the images. The rest is fine for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #36: Replace emma with jacoco
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/36 Adressed the deletion by myself. Left the ASM over for another time. Merge all ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #36: Replace emma with jacoco
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/36 While not having the result of the clean-run, what about deleting the jacoco.data file just before running ? With ASM I could spend a little bit to do a check before ... (something like: rc = all jars with name = *asm*.jar and a loadable ASM.class; if rc.length>1 fail) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #36: Replace emma with jacoco
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/36 Stacktrace is: C:\projekte\apache-ant\ivy-core\build.xml:492: Error while creating report at org.jacoco.ant.ReportTask.execute(ReportTask.java:501) Caused by: java.io.IOException: Error while analyzing org\apache\ivy\Ivy$1.class. at org.jacoco.core.analysis.Analyzer.analyzerError(Analyzer.java:155) Caused by: java.lang.IllegalStateException: Can't add different class with same name: org/apache/ivy/Ivy$1 at org.jacoco.core.analysis.CoverageBuilder.visitCoverage(CoverageBuilder.java:107) I'll try a clean+test-report ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #36: Replace emma with jacoco
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/36 First progress: found an old ASM on Ant's own classpath. Ant 1.9.6 loads that via fetch.xml. Different topic ... JaCoCo runs fine. Report generation failed without any hint. Try running with -debug ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #34: Fix IVY-1528
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/34 Thanks. It was the most common error: the user error :) Used the GUI "git history" not on the top folder ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #36: Replace emma with jacoco
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/36 The JaCoCo 'logfile' seems to be a binary one. So it should not be named '*.log'. Maybe 'jacoco-log.bin'? In 'test-report' the should be the last statement, so we get the report created. Running the jacoco:report gives me an error: java.lang.IncompatibleClassChangeError: class org.jacoco.core.internal.flow.ClassProbesVisitor has interface org.objectweb.asm.ClassVisitor as super class ... at org.apache.tools.ant.AntClassLoader.defineClassFromData(AntClassLoader.java:1149) at java.lang.ClassLoader.loadClass(Unknown Source) at org.jacoco.ant.ReportTask.createBundle(ReportTask.java:563) at org.jacoco.ant.ReportTask.createReport(ReportTask.java:542) at org.jacoco.ant.ReportTask.execute(ReportTask.java:495) Sync: we should think about having not only the xsl in sync. Also the checkstyle rules. Finding the CS rules: I also used trial: deactivate all rules and activate one after the other. (maybe several at once). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #34: Fix IVY-1528
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/34 - we dont use @author - TestXmlHelper -- if xPathExpression would be a String and the method compiles that for itself, reuse would be easier -- XmlHelper would be a better name, because does not work only on tests. -- result could be inlined - IvyMakePomTest#testClassifier() -- you dont use expectedPomArtifactIds for assertions. Do you want to check emptyness after the loop? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #35: Use Java 7 as the minimum required Java version
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/35 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #33: More code cleanup
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 You're right. I looked at a dictionary. I'll change that, so haven't to think about that in the future. ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #33: More code cleanup
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 merged, thanks for the huge work. What about the "iff"? I am not a native speaker and dont want to judge ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #33: More code cleanup
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 Because of the problems I dont merge this ATM. We should discuss them on the dev list before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #33: More code cleanup
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/33
build.xml
- Nice idea with the copyright statement in Javadoc ( (c)${years} ;
years=tstamp("2007-") ).
You found a lot of spell errors ;)
MatcherLookup.java#get(Map<String,String>): new Javadoc is:
'@return a list of matchers that can apply to module withs specified
attributes'
I am not sure about 'withs' or 'with' ...
Nice rewrites of
"myBoolean == null : false = myBoolean.booleanValue()" (and opposite) to
"myBoolean != null && myBoolean"
For Discussion:
---
ModuleInSort.java, class javadoc, "is sorted": I think the 'iff' has a 'f'
too much.
Problems:
-
Fixing the spell error in DelegateHandler$ChildElementHandler
(s/childHanlded/childHandled/) means breaking beakward compatiblity.
We could introduce a delegetate for that:
/** for BC */
@Deprecated
public void childHanlded(DH child) throws SAXParseException {
childHandled(DH child);
}
While refactoring you have renamed all occurences in the Ivy codebase.
On the other hand I don't know the impact (maybe outside of Ivy). I'll
bring that to the dev-list.
src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
public constant DEFAULT_BUNLDE_FILTER also means breaking BC.
src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the
(IMO unneccessary) ParseException. But because it is a checked Exception we
break BC.
renaming EncrytedProperties to EncryptedProperties means breaking BC. If
required we could introduce a delegating class or a subclass.
ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
required we could introduce a delegating method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #33: More code cleanup
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 start reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/31 merged, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/31 Nice idea to use the old fail-Message as new method comment to document why the exception is expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/31 That was a lot of work (or writing/using a transformator ;) Basically it - removes the "extends TestCase" and - uses JUnit annotations - change string.indexOf()!=-1 to string.contains() - use foreach instead of for-i - small improvements - spell check test/java/org/apache/ivy/ant/IvyCacheFilesetTest.java In testFailure() you use @Test(expect=BuildException.class). Therefor the last fail() statement is obsolete. This pattern occurs several more times. Could you change that? Nice use of @Rule ExpectedException in IvyCleanCacheTest. Could you use that in IvyConfigureTest#testOverrideNotAllowed() and Co? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #29: DontMerge-testing-Github-integration2
Github user janmaterne closed the pull request at: https://github.com/apache/ant-ivy/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #28: DontMerge-testing-Github-integration
Github user janmaterne closed the pull request at: https://github.com/apache/ant-ivy/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #29: DontMerge-testing-Github-integration2
GitHub user janmaterne reopened a pull request: https://github.com/apache/ant-ivy/pull/29 DontMerge-testing-Github-integration2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/janmaterne/ant-ivy patch-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit 1461defef7163a3774ca5a47d698e8635902d8ba Author: janmaterne <janmate...@users.noreply.github.com> Date: 2017-05-24T10:20:01Z Update README --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #29: DontMerge-testing-Github-integration2
Github user janmaterne closed the pull request at: https://github.com/apache/ant-ivy/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #29: DontMerge-testing-Github-integration2
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/29 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #29: DontMerge-testing-Github-integration2
GitHub user janmaterne opened a pull request: https://github.com/apache/ant-ivy/pull/29 DontMerge-testing-Github-integration2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/janmaterne/ant-ivy patch-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit 1461defef7163a3774ca5a47d698e8635902d8ba Author: janmaterne <janmate...@users.noreply.github.com> Date: 2017-05-24T10:20:01Z Update README --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #28: DontMerge-testing-Github-integration
GitHub user janmaterne opened a pull request: https://github.com/apache/ant-ivy/pull/28 DontMerge-testing-Github-integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/janmaterne/ant-ivy patch-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 9d1ed4d981f3cc277fd4ba320b2939a56a897ff5 Author: janmaterne <janmate...@users.noreply.github.com> Date: 2017-05-24T09:31:25Z Update README --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivyde issue #4: Update the year in copyright messages
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivyde/pull/4 merged that to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivyde issue #5: DontMerge-Test-Github-Integration
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivyde/pull/5 Jenkins/Github-Integrationtest finished --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivyde pull request #5: DontMerge-Test-Github-Integration
Github user janmaterne closed the pull request at: https://github.com/apache/ant-ivyde/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivyde pull request #5: DontMerge-Test-Github-Integration
GitHub user janmaterne opened a pull request: https://github.com/apache/ant-ivyde/pull/5 DontMerge-Test-Github-Integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/janmaterne/ant-ivyde patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivyde/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit 9a4c6b54eff134ad44904c206ed1928988e7b38a Author: janmaterne <janmate...@users.noreply.github.com> Date: 2017-05-24T06:06:36Z Update README.txt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #15: Create just-test-github-integration
Github user janmaterne closed the pull request at: https://github.com/apache/ant-ivy/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #15: Create just-test-github-integration
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/15 close test-PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #15: Create just-test-github-integration
GitHub user janmaterne opened a pull request: https://github.com/apache/ant-ivy/pull/15 Create just-test-github-integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/janmaterne/ant-ivy patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit 648235b057d3ef7a51d0d711b7cd2e9493aeb572 Author: janmaterne <janmate...@users.noreply.github.com> Date: 2017-05-17T11:58:51Z Create just-test-github-integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #14: Create just-test-github-integration
Github user janmaterne closed the pull request at: https://github.com/apache/ant-ivy/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #14: Create just-test-github-integration
GitHub user janmaterne opened a pull request: https://github.com/apache/ant-ivy/pull/14 Create just-test-github-integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/janmaterne/ant-ivy patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 425ac7e2c3130aa4efdf1a42078b9be329d4600d Author: janmaterne <janmate...@users.noreply.github.com> Date: 2017-05-17T10:37:55Z Create just-test-github-integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #31: Feature/bugzilla bug 60628 ant get task to accept arbitrary h...
Github user janmaterne commented on the issue: https://github.com/apache/ant/pull/31 committed to master branch (Ant 1.10.x). thanks for the patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #31: Feature/bugzilla bug 60628 ant get task to accept arbitrary h...
Github user janmaterne commented on the issue: https://github.com/apache/ant/pull/31 Haven't done a deep check, but first comments: - overall it seems to be ok - get.html: maybe a hint that key and value are trimmed and must not be null or empty string - get.html, example: value has doubled equals sign - get.xml/GetTest.java: method name doesn't match target name - Get.java: nice to reuse email.Header - Get.java: trimToNull() could be moved to org.apache.tools.ant.util.StringUtils - Get.java:764: the if(isEmpty) is not required @mbenson: Are you reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
