Re: Review Request 67082: ATLAS-2672: Change primitive map type storage in vertex

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67082/#review202985
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 11, 2018, 7:03 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67082/
> ---
> 
> (Updated May 11, 2018, 7:03 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2672
> https://issues.apache.org/jira/browse/ATLAS-2672
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently primitive map type in atlas is stored in vertex as:
> 
> typeName.mapAttr  = [key1, key2, key3]
> typeName.mapAttr.key1 = value1
> typeName.mapAttr.key2 = value2
> typeName.mapAttr.key3 = value3
> Since JanusGraph supports Map datatype, we can store map value within a 
> single vertex property.
> 
> Also we need to create edge label and property key for array and map 
> primitive types.
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  3636ca65a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java f48ccef05 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  f75f7862d 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 7490a15b1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  d285e6964 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  cd00639de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  183a2f6c0 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasComplexAttributesTest.java
>  e4947282a 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityTestBase.java
>  56dc5bdaf 
> 
> 
> Diff: https://reviews.apache.org/r/67082/diff/3/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/385/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Jenkins build is back to normal : PreCommit-ATLAS-Build-Test #392-master-ATLAS-2637-Data-Migration-Infer-types-that-store-edg.patch

[Apache Jenkins Server]

See 

Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids

[Ashutosh Mestry]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66928/
---

(Updated May 11, 2018, 10:27 p.m.)


Review request for atlas, Madhan Neethiraj, Ruchi Solani, and Sarath 
Subramanian.


Changes
---

Updates include:
- Refactoring.
- Minor modification to post processing.
- Fix to new attribute assignment.


Bugs: ATLAS-2637
https://issues.apache.org/jira/browse/ATLAS-2637


Repository: atlas


Description
---

**Approach**
New class: _TypesStoringEdgeIds_: Navigates through all the types in the 
_typeRegistry_, returns map of entity type and properties that store edge ids.
Modified: _DataMigrationService_: Uses output from class above and passes it 
down to migration.
Modified: _PostProcessManager_: Uses the map generated above and uses it for 
post processing.
Modified: _GraphSONUtility_: Improvement to check for vertex of type. This 
avoids potential exeception when a non-existent property is checked for 
presence.

Added PostProcess framework.
Added logic for handling new Array and Map representation.


Diffs (updated)
-

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
607baf664 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 c0b9c1741 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
 3636ca65a 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java
 aa0b6375d 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtility.java
 ec320b03e 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessManager.java
 d0a65f7b1 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/RelationshipTypeCache.java
 e4e82649b 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/postProcess/PostProcessListProperty.java
 PRE-CREATION 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/postProcess/PostProcessMapProperty.java
 PRE-CREATION 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/postProcess/PostProcessor.java
 PRE-CREATION 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java
 de43e0f41 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityPostProcessTest.java
 4d73c78ef 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityTest.java
 794b5471e 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/MappedElementCacheTest.java
 cac09d229 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessListPropertyTest.java
 PRE-CREATION 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessMapPropertyTest.java
 PRE-CREATION 
  graphdb/janus/src/test/resources/col-2-legacy.json PRE-CREATION 
  graphdb/janus/src/test/resources/edge-legacy-col.json PRE-CREATION 
  graphdb/janus/src/test/resources/edge-legacy-col2.json PRE-CREATION 
  graphdb/janus/src/test/resources/table-v-147504.json 898dce5df 
  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java b05754f4b 
  
repository/src/main/java/org/apache/atlas/repository/migration/DataMigrationService.java
 22cd55217 
  
repository/src/main/java/org/apache/atlas/repository/migration/TypesStoringEdgeIds.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 3c84e3c22 
  
repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java
 ec6e64a25 
  
repository/src/test/java/org/apache/atlas/repository/migration/TypesStoringEdgeIdsTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/66928/diff/8/

Changes: https://reviews.apache.org/r/66928/diff/7-8/


Testing
---

**Unit tests**

Additional tests added.

**Functional tests**

Regular flow verified.

**[Pre-commit 
build](https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/382/)**


Thanks,

Ashutosh Mestry

Build failed in Jenkins: PreCommit-ATLAS-Build-Test #391-master-ATLAS-2672-Change-primitive-map-type-storage-in-vert.2.patch

[Apache Jenkins Server]

See 


--
[...truncated 228.78 KB...]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 9 resources
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
atlas-repository ---
[INFO] 
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 132 source files to 

[INFO] 
:
 Some input files use or override a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 35 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 45 source files to 

[INFO] 
:
 

 uses or overrides a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-repository 
---
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider

---
 T E S T S
---
Running org.apache.atlas.repository.userprofile.UserProfileServiceTest
Running org.apache.atlas.repository.migration.PathTest
Running org.apache.atlas.repository.audit.CassandraAuditRepositoryTest
Running org.apache.atlas.repository.migration.HiveParititionTest
Running org.apache.atlas.repository.audit.InMemoryAuditRepositoryTest
Running org.apache.atlas.repository.migration.RelationshipMappingTest
Running org.apache.atlas.repository.impexp.ImportTransformsTest
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateHardDeleteV1Test
Running org.apache.atlas.services.MetricsServiceTest
Running org.apache.atlas.repository.migration.HiveStocksTest
Running org.apache.atlas.repository.store.graph.v1.AtlasComplexAttributesTest
Running org.apache.atlas.repository.impexp.ZipSinkTest
Running org.apache.atlas.repository.migration.MigrationProgressServiceTest
Running org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreV1Test
Running org.apache.atlas.repository.impexp.ExportServiceTest
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1Test
Running org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
Running org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStoreTest
Running org.apache.atlas.repository.store.graph.v1.AtlasEntityDefStoreV1Test
Running 

Build failed in Jenkins: PreCommit-ATLAS-Build-Test #390-master-ATLAS-2672-Change-primitive-map-type-storage-in-vert.2.patch

[Apache Jenkins Server]

See 


--
[...truncated 230.57 KB...]
[INFO] Copying 35 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 45 source files to 

[INFO] 
:
 

 uses or overrides a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-repository 
---
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider

---
 T E S T S
---
Running org.apache.atlas.repository.migration.RelationshipMappingTest
Running org.apache.atlas.repository.migration.HiveStocksTest
Running org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
Running org.apache.atlas.repository.migration.HiveParititionTest
Running org.apache.atlas.repository.migration.MigrationProgressServiceTest
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1Test
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreHardDeleteV1Test
Running org.apache.atlas.repository.userprofile.UserProfileServiceTest
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateHardDeleteV1Test
Running org.apache.atlas.repository.impexp.ImportTransformsTest
Running org.apache.atlas.repository.audit.InMemoryAuditRepositoryTest
Running org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStoreTest
Running org.apache.atlas.repository.impexp.ExportServiceTest
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreSoftDeleteV1Test
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateSoftDeleteV1Test
Running org.apache.atlas.repository.store.graph.v1.AtlasEntityStoreV1Test
Running org.apache.atlas.repository.impexp.ZipSinkTest
Running org.apache.atlas.repository.migration.PathTest
Running org.apache.atlas.repository.store.graph.v1.AtlasEntityDefStoreV1Test
Running org.apache.atlas.repository.impexp.TypeAttributeDifferenceTest
Running org.apache.atlas.repository.impexp.ImportTransformerTest
Running org.apache.atlas.repository.impexp.UniqueListTest
Running org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreV1Test
Running org.apache.atlas.repository.impexp.ImportServiceTest
Running 
org.apache.atlas.repository.store.graph.v1.AtlasEntityStoreV1BulkImportPercentTest
Running org.apache.atlas.repository.store.graph.v1.AtlasComplexAttributesTest
Running org.apache.atlas.repository.audit.CassandraAuditRepositoryTest
Running org.apache.atlas.repository.impexp.ImportTransformerJSONTest
Running org.apache.atlas.services.MetricsServiceTest
Running org.apache.atlas.repository.impexp.ZipSourceTest
Running org.apache.atlas.repository.impexp.AtlasImportRequestTest
Running org.apache.atlas.repository.tagpropagation.ClassificationPropagationTest
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.977 sec - in 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreV1Test
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.179 sec - in 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.102 sec - in 
org.apache.atlas.repository.impexp.ImportTransformerTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.926 sec - in 
org.apache.atlas.repository.audit.InMemoryAuditRepositoryTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.235 sec - in 
org.apache.atlas.repository.impexp.UniqueListTest
Running org.apache.atlas.query.GremlinQueryComposerTest
Running org.apache.atlas.query.DSLParsingTest
Running org.apache.atlas.glossary.PaginationHelperTest

[jira] [Assigned] (ATLAS-2665) Add OMAG-API in Atlas

[David Radley (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley reassigned ATLAS-2665:
---

Assignee: Bogdan Sava

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Assignee: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67082: ATLAS-2672: Change primitive map type storage in vertex

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67082/
---

(Updated May 11, 2018, 12:03 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Changes
---

addressed review comments.


Bugs: ATLAS-2672
https://issues.apache.org/jira/browse/ATLAS-2672


Repository: atlas


Description
---

Currently primitive map type in atlas is stored in vertex as:

typeName.mapAttr  = [key1, key2, key3]
typeName.mapAttr.key1 = value1
typeName.mapAttr.key2 = value2
typeName.mapAttr.key3 = value3
Since JanusGraph supports Map datatype, we can store map value within a single 
vertex property.

Also we need to create edge label and property key for array and map primitive 
types.


Diffs (updated)
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
 3636ca65a 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java f48ccef05 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 f75f7862d 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
7490a15b1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 d285e6964 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
 cd00639de 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 183a2f6c0 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasComplexAttributesTest.java
 e4947282a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityTestBase.java
 56dc5bdaf 


Diff: https://reviews.apache.org/r/67082/diff/2/

Changes: https://reviews.apache.org/r/67082/diff/1-2/


Testing
---

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/385/console


Thanks,

Sarath Subramanian

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: (was: 0003-ATLAS-2665-comments-fixed.patch)

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: (was: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch)

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: (was: 
0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch)

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 67089: ATLAS-2674 Unable to set an array value for an attribute in the open metadata

[David Radley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67089/
---

Review request for atlas, Graham Wallis and MandyDW MandyDW.


Bugs: ATLAS2674
https://issues.apache.org/jira/browse/ATLAS2674


Repository: atlas


Description
---

Unable to set an array value for an attribute in the open metadata


Diffs
-

  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java
 154eb16c9 
  
omrs/src/test/java/org/apache/atlas/omrs/metadatacollection/properties/instances/TestArrayPropertyValue.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/67089/diff/1/


Testing
---

Ran junits- that failed without the fix.


Thanks,

David Radley

Re: please add me as a contributor

[Madhan Neethiraj]

Bogdan Sava,

You have been added as a contributor in Apache Atlas. Welcome to Apache Atlas 
community!
 
Regards,
Madhan





On 5/11/18, 2:05 AM, "Sava, B.M. (Bogdan - Mihail)" 
 wrote:

Hello All,

Please add me as a contributor to Apache Atlas project. My username and 
email are bogdan.sava and 
bogdan-mihail.s...@ing.com .
I would like to be able to assign jira ticket to myself and others and be 
able to attach patches to jira.

Thank you,
Bogdan Sava


---
ATTENTION:
The information in this electronic mail message is private and
confidential, and only intended for the addressee. 

The information in this e-mail does not constitute 
Investment Advice as defined in Art 4 of the Markets
in Financial Instruments Directive 2004/39/EC. The Markets
in Financial Instruments Directive 2004/39/EC is not applicable to 
Life insurance and Private pensions products.

Should you receive this message by mistake, you are hereby 
notified that any disclosure, reproduction, distribution or use of this
message is strictly prohibited. Please inform the sender by
reply transmission and delete the message without copying or
opening it.

Messages and attachments are scanned for all viruses known.
If this message contains password-protected attachments, the
files have NOT been scanned for viruses by the ING mail domain.
Always scan attachments before opening them.

---

[jira] [Created] (ATLAS-2674) Unable to set an array value for an attribute in the open metadata

[David Radley (JIRA)]

David Radley created ATLAS-2674:
---

 Summary: Unable to set an array value for an attribute in the open 
metadata
 Key: ATLAS-2674
 URL: https://issues.apache.org/jira/browse/ATLAS-2674
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Reporter: David Radley
Assignee: David Radley


Unable to set an array value for an attribute in the open metadata



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/#review202937
---




webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
Lines 116 (patched)


In ATLAS-2310, use of URLDecoder.decode() was replaced wito use 
UriUtils.encodeQuery() in ActiveServerFilter. Please review this patch 
https://reviews.apache.org/r/64538/.


- Madhan Neethiraj


On May 11, 2018, 11 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67085/
> ---
> 
> (Updated May 11, 2018, 11 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2673
> https://issues.apache.org/jira/browse/ATLAS-2673
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles decoding of encoded query string for DSL search.
> 
> Use case:-
> 
> DSL query :
> 
> /api/atlas/v2/search/dsl?typeName=hive_table=name="weather2"
> fired on PASSIVE server redirects to ACTIVE server as
> 
> /api/atlas/v2/search/dsl?limit=25=0=name=%2522weather2%2522=hive_table
> fails with
> 
> {
> errorCode: "ATLAS-400-00-059",
> errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
> DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
> type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 
> 22 type not found. Please refer to Atlas DSL grammar for more information"
> }
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 
> 
> 
> Diff: https://reviews.apache.org/r/67085/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by accessing URL 
> /api/atlas/v2/search/dsl?typeName=Table=name="sales_fact" on passive 
> which redirects on active node now working properly.
> 
> And also on Active node.
> 
> Added few encode queryparam in ITs
> 
> Integration testcase working
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console
> 
> 2018-05-11 10:39:16,828  
> 2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=DB+where+name%3D%22Reporting%22=10|200|262
> 2018-05-11 10:39:17,089  
> 2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=DB+where+name%3D%22encode_db_name%22=10|200|257
> 2018-05-11 10:39:17,351  
> 2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=Table+where+name%3D%2522sales_fact%2522=10|200|258
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

[jira] [Commented] (ATLAS-2665) Add OMAG-API in Atlas

[David Radley (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471885#comment-16471885
 ] 

David Radley commented on ATLAS-2665:
-

Hi Bogdan - please can you combine the patches so they can be git pushed as one 
commit. 

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch, 
> 0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch, 
> 0003-ATLAS-2665-comments-fixed.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: 0003-ATLAS-2665-comments-fixed.patch

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch, 
> 0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch, 
> 0003-ATLAS-2665-comments-fixed.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: 0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch, 
> 0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

REMINDER: Apache EU Roadshow 2018 schedule announced!

[sharan]

Hello Apache Supporters and Enthusiasts

This is a reminder that the schedule for the Apache EU Roadshow 2018 in 
Berlin has been announced.


http://apachecon.com/euroadshow18/schedule.html

Please note that we will not be running an ApacheCon in Europe this year 
which means that this Apache EU Roadshow will be the main Apache event 
in Europe for 2018.


The Apache EU Roadshow tracks take place on the 13th and 14th June 2018, 
and will feature 28 sessions across the following themes; Apache Tomcat, 
IoT , Cloud Technologies, Microservices and Apache Httpd Server.


Please note that the Apache EU Roadshow is co-located with FOSS 
Backstage and their schedule (https://foss-backstage.de/sessions) 
includes many Apache related sessions such as Incubator, Apache Way, 
Open Source Governance, Legal, Trademarks as well as a full range 
community related presentations and panel discussions.


One single registration gives you access to both events - the Apache EU 
Roadshow and FOSS Backstage.


Registration includes catering (breakfast & lunch both days) and also an 
attendee evening event. And if you want to have a project meet-up, hack 
or simply spend time and relax in our on-site Apache Lounge between 
sessions, then you are more than welcome.


We look forward to seeing you in Berlin!

Thanks
Sharan Foga, VP Apache Community Development

PLEASE NOTE: You are receiving this message because you are subscribed 
to a user@ or dev@ list of one or more Apache Software Foundation projects.

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/
---

(Updated May 11, 2018, 12:58 p.m.)


Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
Mandy Chessell.


Changes
---

removed *.patch files erroneously added when recreating to remove whitespace. 
SHould be good now. Tested build, launch. All clean.


Repository: atlas


Description
---

Added OMAG Server to distribution with an easy to launch jar
(See JIRA for more information)


Diffs (updated)
-

  distro/pom.xml 6431fd86d 
  distro/src/main/assemblies/omag-server.xml PRE-CREATION 
  omag-server/README.md PRE-CREATION 
  omag-server/pom.xml 4c1c98aa3 


Diff: https://reviews.apache.org/r/67060/diff/5/

Changes: https://reviews.apache.org/r/67060/diff/4-5/


Testing
---

Built atlas
Checked correct files in distribution archive
Checked OMAG server launches with default config


Thanks,

Nigel Jones

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

> On May 11, 2018, 12:30 p.m., Nigel Jones wrote:
> > ATLAS-2668a.patch
> > Lines 1 (patched)
> > 
> >
> > !! Patch is still in the diff. inadvertently must have added when 
> > trying to fix whitespace. Original patch was otherwise good.
> > 
> > Now will update to remove file from patch
> > 
> > Hold off from test/ship for now

resolved


- Nigel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202926
---


On May 11, 2018, 12:58 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 11, 2018, 12:58 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/5/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202926
---




ATLAS-2668a.patch
Lines 1 (patched)


!! Patch is still in the diff. inadvertently must have added when trying to 
fix whitespace. Original patch was otherwise good.

Now will update to remove file from patch

Hold off from test/ship for now


- Nigel Jones


On May 11, 2018, 12:26 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 11, 2018, 12:26 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   ATLAS-2668a.patch PRE-CREATION 
>   ATLAS-2668b.patch PRE-CREATION 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/4/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/
---

(Updated May 11, 2018, 12:26 p.m.)


Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
Mandy Chessell.


Changes
---

updated without patch file


Repository: atlas


Description
---

Added OMAG Server to distribution with an easy to launch jar
(See JIRA for more information)


Diffs (updated)
-

  ATLAS-2668a.patch PRE-CREATION 
  ATLAS-2668b.patch PRE-CREATION 
  distro/pom.xml 6431fd86d 
  distro/src/main/assemblies/omag-server.xml PRE-CREATION 
  omag-server/README.md PRE-CREATION 
  omag-server/pom.xml 4c1c98aa3 


Diff: https://reviews.apache.org/r/67060/diff/4/

Changes: https://reviews.apache.org/r/67060/diff/3-4/


Testing
---

Built atlas
Checked correct files in distribution archive
Checked OMAG server launches with default config


Thanks,

Nigel Jones

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

> On May 11, 2018, 10:39 a.m., David Radley wrote:
> > omag-server/README.md
> > Lines 25 (patched)
> > 
> >
> > If you lose this whitespace - then we will not get thew white space 
> > warning on patch apply
> 
> Nigel Jones wrote:
> Odd. hadn't noticed that. I still need to understand how it gets there. 
> Will do.

Difficult to eliminate completely especially in README.md as intellij likes 
adding space indentation to match prior line even at end of file - in my case 
indentation was to get block quoting.

Trying to fix this has led to other errors so I propose we leave this as-is for 
now (at least as per current patch). Perhaps there are some intellij settings 
we can tweak to reduce the likelihood of whitespace


- Nigel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202903
---


On May 11, 2018, 12:26 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 11, 2018, 12:26 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   ATLAS-2668a.patch PRE-CREATION 
>   ATLAS-2668b.patch PRE-CREATION 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/4/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

> On May 11, 2018, 12:20 p.m., David Radley wrote:
> > ATLAS-2668a.patch
> > Lines 1 (patched)
> > 
> >
> > looks like a patch has got into the diff

Yes. My bad. I forgot to delete the patch when making the followon diff (it's 
not in the local git commit, so git-wise I look ok). Realised before the 
comment but you were too quick :-)  Removed now. It's quite easy to make little 
mistakes like this with the tool but practice should help ...


- Nigel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202921
---


On May 11, 2018, 12:18 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 11, 2018, 12:18 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   ATLAS-2668a.patch PRE-CREATION 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/3/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[David Radley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202921
---




ATLAS-2668a.patch
Lines 1 (patched)


looks like a patch has got into the diff


- David Radley


On May 11, 2018, 11:18 a.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 11, 2018, 11:18 a.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   ATLAS-2668a.patch PRE-CREATION 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/3/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[David Radley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202920
---


Ship it!




Please make the changes then ship it

- David Radley


On May 11, 2018, 11:18 a.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 11, 2018, 11:18 a.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   ATLAS-2668a.patch PRE-CREATION 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/3/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/
---

(Updated May 11, 2018, 12:18 p.m.)


Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
Mandy Chessell.


Changes
---

updated again as I noticed rogue whitespace in readme


Repository: atlas


Description
---

Added OMAG Server to distribution with an easy to launch jar
(See JIRA for more information)


Diffs (updated)
-

  ATLAS-2668a.patch PRE-CREATION 
  distro/pom.xml 6431fd86d 
  distro/src/main/assemblies/omag-server.xml PRE-CREATION 
  omag-server/README.md PRE-CREATION 
  omag-server/pom.xml 4c1c98aa3 


Diff: https://reviews.apache.org/r/67060/diff/3/

Changes: https://reviews.apache.org/r/67060/diff/2-3/


Testing
---

Built atlas
Checked correct files in distribution archive
Checked OMAG server launches with default config


Thanks,

Nigel Jones

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/
---

(Updated May 11, 2018, 12:15 p.m.)


Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
Mandy Chessell.


Changes
---

Updated as per comments


Repository: atlas


Description
---

Added OMAG Server to distribution with an easy to launch jar
(See JIRA for more information)


Diffs (updated)
-

  distro/pom.xml 6431fd86d 
  distro/src/main/assemblies/omag-server.xml PRE-CREATION 
  omag-server/README.md PRE-CREATION 
  omag-server/pom.xml 4c1c98aa3 


Diff: https://reviews.apache.org/r/67060/diff/2/

Changes: https://reviews.apache.org/r/67060/diff/1-2/


Testing
---

Built atlas
Checked correct files in distribution archive
Checked OMAG server launches with default config


Thanks,

Nigel Jones

Re: Review Request 67061: ATLAS-2670: Check validity of entity guid when dissociating term

[David Radley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67061/#review202918
---




repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 103 (patched)


should we check that the associated entity and relationship are not deleted?


- David Radley


On May 10, 2018, 5:07 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67061/
> ---
> 
> (Updated May 10, 2018, 5:07 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2670
> https://issues.apache.org/jira/browse/ATLAS-2670
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> See JIRA
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5e3d81846 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> 5400b77c3 
> 
> 
> Diff: https://reviews.apache.org/r/67061/diff/1/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/377/
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

[jira] [Updated] (ATLAS-2673) DSL query fired on PASSIVE server redirects to ACTIVE server with wrong encoding

[Nixon Rodrigues (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-2673:
---
Attachment: ATLAS-2673.patch

> DSL query fired on PASSIVE server redirects to ACTIVE server with wrong 
> encoding
> 
>
> Key: ATLAS-2673
> URL: https://issues.apache.org/jira/browse/ATLAS-2673
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 1.0.0-alpha
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2673.patch
>
>
> DSL query :
> {code}
> /api/atlas/v2/search/dsl?typeName=hive_table=name="weather2"
> {code}
> fired on PASSIVE server redirects to ACTIVE server as
> {code}
> /api/atlas/v2/search/dsl?limit=25=0=name=%2522weather2%2522=hive_table
> {code}
> fails with
> {code}
> {
> errorCode: "ATLAS-400-00-059",
> errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
> DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
> type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 
> 22 type not found. Please refer to Atlas DSL grammar for more information"
> }
> {code}
> Attaching the complete exception stack trace from ACTIVE server logs .
> Issue not seen with Basic search.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2673
https://issues.apache.org/jira/browse/ATLAS-2673


Repository: atlas


Description
---

This patch handles decoding of encoded query string for DSL search.

Use case:-

DSL query :

/api/atlas/v2/search/dsl?typeName=hive_table=name="weather2"
fired on PASSIVE server redirects to ACTIVE server as

/api/atlas/v2/search/dsl?limit=25=0=name=%2522weather2%2522=hive_table
fails with

{
errorCode: "ATLAS-400-00-059",
errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 22 
type not found. Please refer to Atlas DSL grammar for more information"
}


Diffs
-

  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
  webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 


Diff: https://reviews.apache.org/r/67085/diff/1/


Testing
---

Tested by accessing URL 
/api/atlas/v2/search/dsl?typeName=Table=name="sales_fact" on passive 
which redirects on active node now working properly.

And also on Active node.

Added few encode queryparam in ITs

Integration testcase working
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console

2018-05-11 10:39:16,828  
2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=DB+where+name%3D%22Reporting%22=10|200|262
2018-05-11 10:39:17,089  
2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=DB+where+name%3D%22encode_db_name%22=10|200|257
2018-05-11 10:39:17,351  
2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=Table+where+name%3D%2522sales_fact%2522=10|200|258


Thanks,

Nixon Rodrigues

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[David Radley]

Hi Nigel,
Thanks for the explanations. I have indicated ship it! Once you make your 
amendments - I intend to commit this tomorrow if there are no further 
issues raised today, 

fyi - I notice you copied the dev list with incubator in the name - I have 
copied the non-incubator dev list. 
all the best, David. 


From:   Nigel Jones 
To: Mandy Chessell , Graham Wallis 
, Madhan Neethiraj , David 
Radley 
Cc: atlas 
Date:   11/05/2018 10:51
Subject:Re: Review Request 67060: ATLAS-2668: Add OMAG Server to 
distribution
Sent by:Nigel Jones 



This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/67060/ 

On May 11th, 2018, 10:39 a.m. BST, David Radley wrote:

distro/src/main/assemblies/omag-server.xml (Diff revision 1) 


29

I am wondering if you should add   and 
 like KafkaHook does. We should ensure that the jar and sh 
files are executable and the readme is not.


I see
-rw-r--r--  1 david  staff  1080 11 May 09:48 README.md
-rw-r--r--  1 david  staff  8022 11 May 09:55 
omag-server-1.0.0-SNAPSHOT-sources.jar
-rw-r--r--  1 david  staff  6561 11 May 09:55 
omag-server-1.0.0-SNAPSHOT-test-sources.jar
-rw-r--r--  1 david  staff  17222951 11 May 09:55 
omag-server-1.0.0-SNAPSHOT.jar


It doesn to look like the jar is executable.
Also why have we got the sources and test sources jar files?
On May 11th, 2018, 10:41 a.m. BST, David Radley wrote:
As it works - I guess we do not need to make it executable. Please could 
you review deleting the otehr jars
Intriguingly when I build it I do not see those jars in the distribution 
which only contains the files as per the jira ie
? 
~/src/atlas/distro/target/apache-atlas-1.0.0-SNAPSHOT-omag-server/omag-server-1.0.0-SNAPSHOT
 
[master ?·3?·1|…1? 3]
10:49 $ ls
README.md  omag-server-1.0.0-SNAPSHOT.jar


I did check this beforehand.. I'll do a clean build again to double check


Note I am referring here to what goes in the distribution (under 
distro/target)... I think I'd leave what's in the component build 
(omag-server/target)

On May 11th, 2018, 10:39 a.m. BST, David Radley wrote:

distro/src/main/assemblies/omag-server.xml (Diff revision 1) 


38
../omag-server
I see none of the other assemblies use ../ I am not sure why we need to?
This is the link to the location of the artifacts we want to pull into the 
distibution . Others do use it such as atlas-storm-hook-bridge.xml, so 
does hbase. Ok?

On May 11th, 2018, 10:39 a.m. BST, David Radley wrote:

omag-server/README.md (Diff revision 1) 


22
**Launching the standalone server**
I suggest changing this to be launching the standalone Open Metadata And 
Governance (OMAG) Server.
Fair comment, though as there's no regression here could do in another 
jira for expediency? Can remake patch once we are happy with other issues?

On May 11th, 2018, 10:39 a.m. BST, David Radley wrote:

omag-server/README.md (Diff revision 1) 


25
 
If you lose this whitespace - then we will not get thew white space 
warning on patch apply
Odd. hadn't noticed that. I still need to understand how it gets there. 
Will do.

On May 11th, 2018, 10:39 a.m. BST, David Radley wrote:

omag-server/pom.xml (Diff revision 1) 
124
org.apache.maven.plugins
124
org.springframework.boot
I do not understand this change. How does this effect the Atlas build?
It's to do with making an executable jar. Previously the maven-jar-plugin 
was being used, but would not build a jar you could run - nor did it 
include dependencies. To do that you can normally use the 
maven-shade-plugin instead (as we see elsewhere in atlas, and as I used 
for the gaian ranger plugin). Here you can built a composite jar with 
dependencies, and can also set the main class in the manifest. However in 
a spring environment this fails as additional configuration data is 
needed. This is where the spring maven plugin comes to the rescue and 
builds a correct jar so you can just now run the omag server as per the 
readme. The JIRA has a little more explanation

- Nigel

On May 10th, 2018, 5:23 p.m. BST, Nigel Jones wrote:

Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, 
and Mandy Chessell.
By Nigel Jones.
Updated May 10, 2018, 5:23 p.m.
Repository: atlas 
Description 

Added OMAG Server to distribution with an easy to launch jar
(See JIRA for more information)
Testing 

Built atlas
Checked correct files in distribution archive
Checked OMAG server launches with default config
Diffs 
distro/pom.xml (6431fd86d)
distro/src/main/assemblies/omag-server.xml (PRE-CREATION)
omag-server/README.md (PRE-CREATION)
omag-server/pom.xml (4c1c98aa3)
View Diff



Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and 

[jira] [Created] (ATLAS-2673) DSL query fired on PASSIVE server redirects to ACTIVE server with wrong encoding

[Nixon Rodrigues (JIRA)]

Nixon Rodrigues created ATLAS-2673:
--

 Summary: DSL query fired on PASSIVE server redirects to ACTIVE 
server with wrong encoding
 Key: ATLAS-2673
 URL: https://issues.apache.org/jira/browse/ATLAS-2673
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Affects Versions: 1.0.0-alpha
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues
 Fix For: 1.0.0


DSL query :
{code}
/api/atlas/v2/search/dsl?typeName=hive_table=name="weather2"
{code}

fired on PASSIVE server redirects to ACTIVE server as
{code}
/api/atlas/v2/search/dsl?limit=25=0=name=%2522weather2%2522=hive_table
{code}

fails with
{code}
{
errorCode: "ATLAS-400-00-059",
errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 22 
type not found. Please refer to Atlas DSL grammar for more information"
}
{code}

Attaching the complete exception stack trace from ACTIVE server logs .

Issue not seen with Basic search.





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

> On May 11, 2018, 10:39 a.m., David Radley wrote:
> > omag-server/README.md
> > Lines 22 (patched)
> > 
> >
> > I suggest changing this to be launching the standalone Open Metadata 
> > And Governance (OMAG) Server.
> 
> Nigel Jones wrote:
> Fair comment, though as there's no regression here could do in another 
> jira for expediency? Can remake patch once we are happy with other issues?

On reflection I propose leaving as is for the following reasons
 * The title of the readme already uses the full name 'Open Metadata and 
Governance Server'
 * OMAG is already referred to in the readme as the abbreviation
 * The launching ... is only a sub heading within the tiny document
 * This is a placeholder for a more complete readme we should add about how to 
use the omag server - so consider it a bootstrap to get started (and an 
improvement on not having anything)
 * We should ultimately likely have full start/stop scripts, which should use 
the wording you describe. However we need to talk a little more on a jira/lists 
about what that might entail, so I decided to omit for expediency - and I think 
what we have here offers value now


- Nigel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202903
---


On May 10, 2018, 5:23 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 10, 2018, 5:23 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/1/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

> On May 11, 2018, 10:39 a.m., David Radley wrote:
> > distro/src/main/assemblies/omag-server.xml
> > Lines 29 (patched)
> > 
> >
> > I am wondering if you should add   and 
> >  like KafkaHook does. We should ensure that the jar and 
> > sh files are executable and the readme is not.
> > 
> > I see
> > -rw-r--r--  1 david  staff  1080 11 May 09:48 README.md
> > -rw-r--r--  1 david  staff  8022 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT-sources.jar
> > -rw-r--r--  1 david  staff  6561 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT-test-sources.jar
> > -rw-r--r--  1 david  staff  17222951 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT.jar
> > 
> > 
> > It doesn to look like the jar is executable.
> > Also why have we got the sources and test sources jar files?
> 
> David Radley wrote:
> As it works - I guess we do not need to make it executable. Please could 
> you review deleting the otehr jars
> 
> Nigel Jones wrote:
> Intriguingly when I build it I do not see those jars in the distribution 
> which only contains the files as per the jira ie
> ? 
> ~/src/atlas/distro/target/apache-atlas-1.0.0-SNAPSHOT-omag-server/omag-server-1.0.0-SNAPSHOT
>  [master ?·3?·1|…1? 3]
> 10:49 $ ls
> README.md  omag-server-1.0.0-SNAPSHOT.jar
> 
> I did check this beforehand.. I'll do a clean build again to double check
> 
> Note I am referring here to what goes in the distribution (under 
> distro/target)... I think I'd leave what's in the component build 
> (omag-server/target)

On the permissions, I can add those, as it makes sense, but the jar was tested 
and does work


- Nigel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202903
---


On May 10, 2018, 5:23 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 10, 2018, 5:23 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/1/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[Nigel Jones]

> On May 11, 2018, 10:39 a.m., David Radley wrote:
> > distro/src/main/assemblies/omag-server.xml
> > Lines 29 (patched)
> > 
> >
> > I am wondering if you should add   and 
> >  like KafkaHook does. We should ensure that the jar and 
> > sh files are executable and the readme is not.
> > 
> > I see
> > -rw-r--r--  1 david  staff  1080 11 May 09:48 README.md
> > -rw-r--r--  1 david  staff  8022 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT-sources.jar
> > -rw-r--r--  1 david  staff  6561 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT-test-sources.jar
> > -rw-r--r--  1 david  staff  17222951 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT.jar
> > 
> > 
> > It doesn to look like the jar is executable.
> > Also why have we got the sources and test sources jar files?
> 
> David Radley wrote:
> As it works - I guess we do not need to make it executable. Please could 
> you review deleting the otehr jars

Intriguingly when I build it I do not see those jars in the distribution which 
only contains the files as per the jira ie
? 
~/src/atlas/distro/target/apache-atlas-1.0.0-SNAPSHOT-omag-server/omag-server-1.0.0-SNAPSHOT
 [master ?·3?·1|…1? 3]
10:49 $ ls
README.md  omag-server-1.0.0-SNAPSHOT.jar

I did check this beforehand.. I'll do a clean build again to double check

Note I am referring here to what goes in the distribution (under 
distro/target)... I think I'd leave what's in the component build 
(omag-server/target)


> On May 11, 2018, 10:39 a.m., David Radley wrote:
> > distro/src/main/assemblies/omag-server.xml
> > Lines 38 (patched)
> > 
> >
> > I see none of the other assemblies use ../ I am not sure why we need to?

This is the link to the location of the artifacts we want to pull into the 
distibution . Others do use it such as atlas-storm-hook-bridge.xml, so does 
hbase. Ok?


> On May 11, 2018, 10:39 a.m., David Radley wrote:
> > omag-server/README.md
> > Lines 22 (patched)
> > 
> >
> > I suggest changing this to be launching the standalone Open Metadata 
> > And Governance (OMAG) Server.

Fair comment, though as there's no regression here could do in another jira for 
expediency? Can remake patch once we are happy with other issues?


> On May 11, 2018, 10:39 a.m., David Radley wrote:
> > omag-server/README.md
> > Lines 25 (patched)
> > 
> >
> > If you lose this whitespace - then we will not get thew white space 
> > warning on patch apply

Odd. hadn't noticed that. I still need to understand how it gets there. Will do.


> On May 11, 2018, 10:39 a.m., David Radley wrote:
> > omag-server/pom.xml
> > Line 124 (original), 124 (patched)
> > 
> >
> > I do not understand this change. How does this effect the Atlas build?

It's to do with making an executable jar. Previously the maven-jar-plugin was 
being used, but would not build a jar you could run - nor did it include 
dependencies. To do that you can normally use the maven-shade-plugin instead 
(as we see elsewhere in atlas, and as I used for the gaian ranger plugin). Here 
you can built a composite jar with dependencies, and can also set the main 
class in the manifest. However in a spring environment this fails as additional 
configuration data is needed. This is where the spring maven plugin comes to 
the rescue and builds a correct jar so you can just now run the omag server as 
per the readme. The JIRA has a little more explanation


- Nigel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202903
---


On May 10, 2018, 5:23 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 10, 2018, 5:23 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/1/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG 

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[David Radley]

> On May 11, 2018, 9:39 a.m., David Radley wrote:
> > distro/src/main/assemblies/omag-server.xml
> > Lines 29 (patched)
> > 
> >
> > I am wondering if you should add   and 
> >  like KafkaHook does. We should ensure that the jar and 
> > sh files are executable and the readme is not.
> > 
> > I see
> > -rw-r--r--  1 david  staff  1080 11 May 09:48 README.md
> > -rw-r--r--  1 david  staff  8022 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT-sources.jar
> > -rw-r--r--  1 david  staff  6561 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT-test-sources.jar
> > -rw-r--r--  1 david  staff  17222951 11 May 09:55 
> > omag-server-1.0.0-SNAPSHOT.jar
> > 
> > 
> > It doesn to look like the jar is executable.
> > Also why have we got the sources and test sources jar files?

As it works - I guess we do not need to make it executable. Please could you 
review deleting the otehr jars


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202903
---


On May 10, 2018, 4:23 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 10, 2018, 4:23 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/1/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution

[David Radley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review202903
---




distro/src/main/assemblies/omag-server.xml
Lines 29 (patched)


I am wondering if you should add   and 
 like KafkaHook does. We should ensure that the jar and sh 
files are executable and the readme is not.

I see
-rw-r--r--  1 david  staff  1080 11 May 09:48 README.md
-rw-r--r--  1 david  staff  8022 11 May 09:55 
omag-server-1.0.0-SNAPSHOT-sources.jar
-rw-r--r--  1 david  staff  6561 11 May 09:55 
omag-server-1.0.0-SNAPSHOT-test-sources.jar
-rw-r--r--  1 david  staff  17222951 11 May 09:55 
omag-server-1.0.0-SNAPSHOT.jar

It doesn to look like the jar is executable.
Also why have we got the sources and test sources jar files?



distro/src/main/assemblies/omag-server.xml
Lines 38 (patched)


I see none of the other assemblies use ../ I am not sure why we need to?



omag-server/README.md
Lines 22 (patched)


I suggest changing this to be launching the standalone Open Metadata And 
Governance (OMAG) Server.



omag-server/README.md
Lines 25 (patched)


If you lose this whitespace - then we will not get thew white space warning 
on patch apply



omag-server/pom.xml
Line 124 (original), 124 (patched)


I do not understand this change. How does this effect the Atlas build?


- David Radley


On May 10, 2018, 4:23 p.m., Nigel Jones wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> ---
> 
> (Updated May 10, 2018, 4:23 p.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and 
> Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/1/
> 
> 
> Testing
> ---
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Jenkins build is back to normal : PreCommit-ATLAS-Build-Test #386-master-0001-Decode-DSL-query-param.patch

[Apache Jenkins Server]

See 

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: (was: 0001-ATLAS-2665-running-OMAG-API-in-ATLAS.patch)

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

please add me as a contributor

[Sava, B.M. (Bogdan - Mihail)]

Hello All,

Please add me as a contributor to Apache Atlas project. My username and email 
are bogdan.sava and 
bogdan-mihail.s...@ing.com .
I would like to be able to assign jira ticket to myself and others and be able 
to attach patches to jira.

Thank you,
Bogdan Sava

---
ATTENTION:
The information in this electronic mail message is private and
confidential, and only intended for the addressee.

The information in this e-mail does not constitute
Investment Advice as defined in Art 4 of the Markets
in Financial Instruments Directive 2004/39/EC. The Markets
in Financial Instruments Directive 2004/39/EC is not applicable to
Life insurance and Private pensions products.

Should you receive this message by mistake, you are hereby
notified that any disclosure, reproduction, distribution or use of this
message is strictly prohibited. Please inform the sender by
reply transmission and delete the message without copying or
opening it.

Messages and attachments are scanned for all viruses known.
If this message contains password-protected attachments, the
files have NOT been scanned for viruses by the ING mail domain.
Always scan attachments before opening them.
---

[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

[Bogdan Sava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Issue Type: Improvement  (was: Bug)

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-running-OMAG-API-in-ATLAS.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata/access-services" 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67082: ATLAS-2672: Change primitive map type storage in vertex

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67082/#review202898
---




graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
Lines 50 (patched)


this class doesn't seem to be used here. Please review and remove this 
import.



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 334 (patched)


Property-key is not needed if attribute is array or array - 
right?



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Line 330 (original), 339 (patched)


Property-key is not needed if attribute is map or 
map - right?



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Line 700 (original), 725 (patched)


cleanupIndex() needs to be callec for primitive array & maps type 
attribuges as well - to delete the propertyKey (line #742 below).



repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Line 1581 (original), 1581 (patched)


Instead of calling GraphHelper.encodePropertyKey() on every read, consider 
using the encoded name in 'attribute'. Same for line #1571 above.


- Madhan Neethiraj


On May 11, 2018, 6:49 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67082/
> ---
> 
> (Updated May 11, 2018, 6:49 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2672
> https://issues.apache.org/jira/browse/ATLAS-2672
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently primitive map type in atlas is stored in vertex as:
> 
> typeName.mapAttr  = [key1, key2, key3]
> typeName.mapAttr.key1 = value1
> typeName.mapAttr.key2 = value2
> typeName.mapAttr.key3 = value3
> Since JanusGraph supports Map datatype, we can store map value within a 
> single vertex property.
> 
> Also we need to create edge label and property key for array and map 
> primitive types.
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  3636ca65a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java f48ccef05 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  f75f7862d 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 7490a15b1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  d285e6964 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  cd00639de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  183a2f6c0 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasComplexAttributesTest.java
>  e4947282a 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityTestBase.java
>  56dc5bdaf 
> 
> 
> Diff: https://reviews.apache.org/r/67082/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/385/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Review Request 67082: ATLAS-2672: Change primitive map type storage in vertex

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67082/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2672
https://issues.apache.org/jira/browse/ATLAS-2672


Repository: atlas


Description
---

Currently primitive map type in atlas is stored in vertex as:

typeName.mapAttr  = [key1, key2, key3]
typeName.mapAttr.key1 = value1
typeName.mapAttr.key2 = value2
typeName.mapAttr.key3 = value3
Since JanusGraph supports Map datatype, we can store map value within a single 
vertex property.

Also we need to create edge label and property key for array and map primitive 
types.


Diffs
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
 3636ca65a 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java f48ccef05 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 f75f7862d 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
7490a15b1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 d285e6964 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
 cd00639de 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 183a2f6c0 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasComplexAttributesTest.java
 e4947282a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityTestBase.java
 56dc5bdaf 


Diff: https://reviews.apache.org/r/67082/diff/1/


Testing
---

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/385/console


Thanks,

Sarath Subramanian

Build failed in Jenkins: PreCommit-ATLAS-Build-Test #385-master-0001-Change-primitive-map-storage-in-vertex.patch

[Apache Jenkins Server]

See 


Changes:

[madhan] ATLAS-2649: updated Hive Hook to create lineage between HBase table and

--
[...truncated 231.44 KB...]
[INFO] Copying 35 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 45 source files to 

[INFO] 
:
 

 uses or overrides a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-repository 
---
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider

---
 T E S T S
---
Running org.apache.atlas.repository.migration.RelationshipMappingTest
Running org.apache.atlas.repository.userprofile.UserProfileServiceTest
Running org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreV1Test
Running org.apache.atlas.repository.migration.HiveParititionTest
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1Test
Running 
org.apache.atlas.repository.store.graph.v1.AtlasEntityStoreV1BulkImportPercentTest
Running org.apache.atlas.repository.migration.PathTest
Running org.apache.atlas.repository.store.graph.v1.AtlasComplexAttributesTest
Running org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStoreTest
Running org.apache.atlas.repository.impexp.UniqueListTest
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateHardDeleteV1Test
Running org.apache.atlas.repository.impexp.ImportTransformerJSONTest
Running org.apache.atlas.repository.audit.CassandraAuditRepositoryTest
Running org.apache.atlas.repository.migration.MigrationProgressServiceTest
Running org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
Running org.apache.atlas.repository.store.graph.v1.AtlasEntityStoreV1Test
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreSoftDeleteV1Test
Running org.apache.atlas.repository.impexp.ImportServiceTest
Running org.apache.atlas.repository.migration.HiveStocksTest
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateSoftDeleteV1Test
Running org.apache.atlas.repository.store.graph.v1.AtlasEntityDefStoreV1Test
Running org.apache.atlas.repository.impexp.TypeAttributeDifferenceTest
Running org.apache.atlas.repository.impexp.ZipSourceTest
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreHardDeleteV1Test
Running org.apache.atlas.repository.audit.InMemoryAuditRepositoryTest
Running org.apache.atlas.repository.impexp.ImportTransformerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.172 sec - in 
org.apache.atlas.repository.impexp.UniqueListTest
Running org.apache.atlas.repository.impexp.ExportServiceTest
Running org.apache.atlas.repository.tagpropagation.ClassificationPropagationTest
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.45 sec - in 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.488 sec - in 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreV1Test
Running org.apache.atlas.repository.impexp.AtlasImportRequestTest
Running org.apache.atlas.services.MetricsServiceTest
Running org.apache.atlas.repository.impexp.ImportTransformsTest
Running org.apache.atlas.repository.impexp.ZipSinkTest
Running org.apache.atlas.query.DSLParsingTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.946 sec - in 
org.apache.atlas.repository.audit.InMemoryAuditRepositoryTest
Running org.apache.atlas.query.DSLQueriesTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.948 sec - in 

[jira] [Created] (ATLAS-2672) Change primitive map type storage in vertex

[Sarath Subramanian (JIRA)]

Sarath Subramanian created ATLAS-2672:
-

 Summary: Change primitive map type storage in vertex
 Key: ATLAS-2672
 URL: https://issues.apache.org/jira/browse/ATLAS-2672
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Affects Versions: 1.0.0
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian
 Fix For: 1.0.0


Currently primitive map type in atlas is stored in vertex as:
 * typeName.mapAttr         = [key1, key2, key3]
 * typeName.mapAttr.key1 = value1
 * typeName.mapAttr.key2 = value2
 * typeName.mapAttr.key3 = value3

Since JanusGraph supports Map datatype, we can store map value within a single 
vertex property.

Also we need to create edge label and property key for array and map primitive 
types.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)