Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids

2018-05-15 Thread Ashutosh Mestry

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66928/
---

(Updated May 16, 2018, 5:58 a.m.)


Review request for atlas, Madhan Neethiraj, Ruchi Solani, and Sarath 
Subramanian.


Changes
---

Updates include:
- Removed commented code block from _GraphBackedIndexer_.
- Updated logic for _TypeStoringEdgeIds_.


Bugs: ATLAS-2637
https://issues.apache.org/jira/browse/ATLAS-2637


Repository: atlas


Description
---

**Approach**
New class: _TypesStoringEdgeIds_: Navigates through all the types in the 
_typeRegistry_, returns map of entity type and properties that store edge ids.
Modified: _DataMigrationService_: Uses output from class above and passes it 
down to migration.
Modified: _PostProcessManager_: Uses the map generated above and uses it for 
post processing.
Modified: _GraphSONUtility_: Improvement to check for vertex of type. This 
avoids potential exeception when a non-existent property is checked for 
presence.

Added PostProcess framework.
Added logic for handling new Array and Map representation.


Diffs (updated)
-

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
607baf664 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 c0b9c1741 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
 16aecd5e2 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java
 ae119b0bc 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtility.java
 ec320b03e 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessManager.java
 d0a65f7b1 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/RelationshipTypeCache.java
 e4e82649b 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/postProcess/PostProcessListProperty.java
 PRE-CREATION 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/postProcess/PostProcessMapProperty.java
 PRE-CREATION 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/postProcess/PostProcessor.java
 PRE-CREATION 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java
 e863d9fae 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityPostProcessTest.java
 4d73c78ef 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityTest.java
 794b5471e 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/MappedElementCacheTest.java
 cac09d229 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessListPropertyTest.java
 PRE-CREATION 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessMapPropertyTest.java
 PRE-CREATION 
  graphdb/janus/src/test/resources/col-2-legacy.json PRE-CREATION 
  graphdb/janus/src/test/resources/edge-legacy-col.json PRE-CREATION 
  graphdb/janus/src/test/resources/edge-legacy-col2.json PRE-CREATION 
  graphdb/janus/src/test/resources/table-v-147504.json 898dce5df 
  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java b05754f4b 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 886ce77f5 
  
repository/src/main/java/org/apache/atlas/repository/migration/DataMigrationService.java
 22cd55217 
  
repository/src/main/java/org/apache/atlas/repository/migration/TypesStoringEdgeIds.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 3c84e3c22 
  
repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java
 ec6e64a25 
  
repository/src/test/java/org/apache/atlas/repository/migration/TypesStoringEdgeIdsTest.java
 PRE-CREATION 
  repository/src/test/resources/parts_db/atlas-migration-data.json 1414ea160 


Diff: https://reviews.apache.org/r/66928/diff/10/

Changes: https://reviews.apache.org/r/66928/diff/9-10/


Testing
---

**Unit tests**

Additional tests added.

**Functional tests**

Regular flow verified.

**[Pre-commit 
build](https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/404/)**


Thanks,

Ashutosh Mestry



Re: Review Request 67148: ATLAS-2685: Impose displayName restrictions on Glossary, Term & Category

2018-05-15 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/#review203200
---




repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 70 (patched)


Restricting names with this pattern wouldn't allow international characters 
- which may not be desirable. I would suggest to only disallow specific 
characters that are interpretted by Atlas - for example '@' and '.', which are 
used to form qualifiedName for terms/categories/glossaries.


- Madhan Neethiraj


On May 16, 2018, 5:16 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67148/
> ---
> 
> (Updated May 16, 2018, 5:16 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2685
> https://issues.apache.org/jira/browse/ATLAS-2685
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Glossary & term name can only have letters, spaces, underscores and dashes
> Category can only have letters and spaces
> 
> Added appropriate error codes around this check
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> bc9fe2a2e 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
> f66165050 
> 
> 
> Diff: https://reviews.apache.org/r/67148/diff/1/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>



Review Request 67148: ATLAS-2685: Impose displayName restrictions on Glossary, Term & Category

2018-05-15 Thread Apoorv Naik

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/
---

Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Bugs: ATLAS-2685
https://issues.apache.org/jira/browse/ATLAS-2685


Repository: atlas


Description
---

Glossary & term name can only have letters, spaces, underscores and dashes
Category can only have letters and spaces

Added appropriate error codes around this check


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
bc9fe2a2e 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
f66165050 


Diff: https://reviews.apache.org/r/67148/diff/1/


Testing
---

PreCommit: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console


Thanks,

Apoorv Naik



[jira] [Comment Edited] (ATLAS-2671) Dependency version upgrade to latest stable release

2018-05-15 Thread Madhan Neethiraj (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476848#comment-16476848
 ] 

Madhan Neethiraj edited comment on ATLAS-2671 at 5/16/18 5:15 AM:
--

Committed to following branches:
  master: http://git-wip-us.apache.org/repos/asf/atlas/commit/f65aecee
  branch-1.0: http://git-wip-us.apache.org/repos/asf/atlas/commit/05d50359



was (Author: apoorvnaik):
Committed on master:

https://git-wip-us.apache.org/repos/asf?p=atlas.git;a=commit;h=f65aeceeb97156ff9e26f1352a6da4100845cb7a

> Dependency version upgrade to latest stable release
> ---
>
> Key: ATLAS-2671
> URL: https://issues.apache.org/jira/browse/ATLAS-2671
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: 0001-ATLAS-2671-Dependency-upgrades.patch
>
>
> Spring, Jackson and Lucene upgrades



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2685) [Glossary] Impose displayName restiction for Glossary, term & category

2018-05-15 Thread Apoorv Naik (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-2685:
---
Attachment: 0001-ATLAS-2685-Impose-displayName-restrictions-for-Gloss.patch

> [Glossary] Impose displayName restiction for Glossary, term & category
> --
>
> Key: ATLAS-2685
> URL: https://issues.apache.org/jira/browse/ATLAS-2685
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Attachments: 
> 0001-ATLAS-2685-Impose-displayName-restrictions-for-Gloss.patch
>
>
> As per ATLAS-1410 discussions, there certain restriction in place for the 
> displayName of the Glossary, term and category. This patch enforces those 
> naming restrictions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2679) [Glossary] Derive category's qualifiedName using hierarchy

2018-05-15 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj resolved ATLAS-2679.
-
   Resolution: Fixed
Fix Version/s: 1.0.0

Committed to following branches:
 - master: http://git-wip-us.apache.org/repos/asf/atlas/commit/66f8ae16
 - branch-1.0: http://git-wip-us.apache.org/repos/asf/atlas/commit/65e3a114

> [Glossary] Derive category's qualifiedName using hierarchy
> --
>
> Key: ATLAS-2679
> URL: https://issues.apache.org/jira/browse/ATLAS-2679
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
>
> Currently the qualifiedName is derived using displayName and Glossary's 
> qualifiedName.
>  
> In this patch, the qualifiedName is derived from it's Hierarchy and any 
> changes in the hierarchy itself will trigger a cascaded update of all 
> children.
>  
> E.g. Cat1 is parent category, Cat2 is child category
>  
> Derived qualfiedName of Cat2 = Cat2.Cat1@
>  
> The following actions trigger a cascaded update of the children categories
>  
>  # Change of anchor
>  # Change of Parent
>  # Removal of children from a parent (similar to #2)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Jenkins build is back to normal : PreCommit-ATLAS-Build-Test #408-master-0001-ATLAS-2685-Impose-displayName-restrictions-for-Gloss.patch

2018-05-15 Thread Apache Jenkins Server
See 




[jira] [Updated] (ATLAS-2671) Dependency version upgrade to latest stable release

2018-05-15 Thread Apoorv Naik (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-2671:
---
Attachment: 0001-ATLAS-2671-Dependency-upgrades.patch

> Dependency version upgrade to latest stable release
> ---
>
> Key: ATLAS-2671
> URL: https://issues.apache.org/jira/browse/ATLAS-2671
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: 0001-ATLAS-2671-Dependency-upgrades.patch
>
>
> Spring, Jackson and Lucene upgrades



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2671) Dependency version upgrade to latest stable release

2018-05-15 Thread Apoorv Naik (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-2671:
---
Attachment: (was: 0001-Dependency-upgrades.patch)

> Dependency version upgrade to latest stable release
> ---
>
> Key: ATLAS-2671
> URL: https://issues.apache.org/jira/browse/ATLAS-2671
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: 0001-ATLAS-2671-Dependency-upgrades.patch
>
>
> Spring, Jackson and Lucene upgrades



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2689) Change version from 1.0.0-SNAPSHOT to 1.0.0

2018-05-15 Thread Apoorv Naik (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476843#comment-16476843
 ] 

Apoorv Naik commented on ATLAS-2689:


+1

> Change version from 1.0.0-SNAPSHOT to 1.0.0
> ---
>
> Key: ATLAS-2689
> URL: https://issues.apache.org/jira/browse/ATLAS-2689
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2689.patch
>
>
> Update pom.xml files to replace version 1.0.0-SNAPSHOT to 1.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2671) Dependency version upgrade to latest stable release

2018-05-15 Thread Apoorv Naik (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476842#comment-16476842
 ] 

Apoorv Naik commented on ATLAS-2671:


*Version*

Spring: 4.3.8 => 4.3.17

Spring security: 4.2.4 => 4.2.6

Jackson: 2.9.2 => 2.9.5

Tinkerpop: 3.2.6 => 3.3.3

Lucene upgrade to 7.3.0

 

> Dependency version upgrade to latest stable release
> ---
>
> Key: ATLAS-2671
> URL: https://issues.apache.org/jira/browse/ATLAS-2671
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: 0001-Dependency-upgrades.patch
>
>
> Spring, Jackson and Lucene upgrades



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2689) Change version from 1.0.0-SNAPSHOT to 1.0.0

2018-05-15 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2689:

Attachment: ATLAS-2689.patch

> Change version from 1.0.0-SNAPSHOT to 1.0.0
> ---
>
> Key: ATLAS-2689
> URL: https://issues.apache.org/jira/browse/ATLAS-2689
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Attachments: ATLAS-2689.patch
>
>
> Update pom.xml files to replace version 1.0.0-SNAPSHOT to 1.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2679) [Glossary] Derive category's qualifiedName using hierarchy

2018-05-15 Thread Apoorv Naik (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476809#comment-16476809
 ] 

Apoorv Naik commented on ATLAS-2679:


Committed to master

 

https://git-wip-us.apache.org/repos/asf?p=atlas.git;a=commit;h=66f8ae16045b79d8839ee2088fc5cc64ffa2fa5d

> [Glossary] Derive category's qualifiedName using hierarchy
> --
>
> Key: ATLAS-2679
> URL: https://issues.apache.org/jira/browse/ATLAS-2679
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
>
> Currently the qualifiedName is derived using displayName and Glossary's 
> qualifiedName.
>  
> In this patch, the qualifiedName is derived from it's Hierarchy and any 
> changes in the hierarchy itself will trigger a cascaded update of all 
> children.
>  
> E.g. Cat1 is parent category, Cat2 is child category
>  
> Derived qualfiedName of Cat2 = Cat2.Cat1@
>  
> The following actions trigger a cascaded update of the children categories
>  
>  # Change of anchor
>  # Change of Parent
>  # Removal of children from a parent (similar to #2)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2691) Update Atlas website for 1.0.0 release

2018-05-15 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-2691:
---

 Summary: Update Atlas website for 1.0.0 release
 Key: ATLAS-2691
 URL: https://issues.apache.org/jira/browse/ATLAS-2691
 Project: Atlas
  Issue Type: Sub-task
Affects Versions: 1.0.0
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2690) Publish release artifacts

2018-05-15 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-2690:
---

 Summary: Publish release artifacts
 Key: ATLAS-2690
 URL: https://issues.apache.org/jira/browse/ATLAS-2690
 Project: Atlas
  Issue Type: Sub-task
Affects Versions: 1.0.0
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2689) Change version from 1.0.0-SNAPSHOT to 1.0.0

2018-05-15 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-2689:
---

 Summary: Change version from 1.0.0-SNAPSHOT to 1.0.0
 Key: ATLAS-2689
 URL: https://issues.apache.org/jira/browse/ATLAS-2689
 Project: Atlas
  Issue Type: Sub-task
Affects Versions: 1.0.0
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Update pom.xml files to replace version 1.0.0-SNAPSHOT to 1.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2688) Release Atlas 1.0.0

2018-05-15 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-2688:
---

 Summary: Release Atlas 1.0.0
 Key: ATLAS-2688
 URL: https://issues.apache.org/jira/browse/ATLAS-2688
 Project: Atlas
  Issue Type: Task
Affects Versions: 1.0.0
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj
 Fix For: 1.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 67144: ATLAS-2687: Create twiki documentation about classification propagation

2018-05-15 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67144/#review203187
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 15, 2018, 11:30 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67144/
> ---
> 
> (Updated May 15, 2018, 11:30 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2687
> https://issues.apache.org/jira/browse/ATLAS-2687
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> twiki documentation about classification propagation
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/images/twiki/classification-propagation-1.png 
> PRE-CREATION 
>   docs/src/site/resources/images/twiki/classification-propagation-2.png 
> PRE-CREATION 
>   docs/src/site/resources/images/twiki/classification-propagation-3.png 
> PRE-CREATION 
>   docs/src/site/resources/images/twiki/classification-propagation-4.png 
> PRE-CREATION 
>   docs/src/site/resources/images/twiki/classification-propagation-5.png 
> PRE-CREATION 
>   docs/src/site/resources/images/twiki/classification-propagation-6.png 
> PRE-CREATION 
>   docs/src/site/resources/images/twiki/classification-propagation-7.png 
> PRE-CREATION 
>   docs/src/site/resources/images/twiki/classification-propagation-8.png 
> PRE-CREATION 
>   docs/src/site/twiki/ClassificationPropagation.twiki PRE-CREATION 
>   docs/src/site/twiki/index.twiki 4f74702c4 
> 
> 
> Diff: https://reviews.apache.org/r/67144/diff/1/
> 
> 
> Testing
> ---
> 
> Validated in html doc the classification propagation pages are rendered fine.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



Review Request 67144: ATLAS-2687: Create twiki documentation about classification propagation

2018-05-15 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67144/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2687
https://issues.apache.org/jira/browse/ATLAS-2687


Repository: atlas


Description
---

twiki documentation about classification propagation


Diffs
-

  docs/src/site/resources/images/twiki/classification-propagation-1.png 
PRE-CREATION 
  docs/src/site/resources/images/twiki/classification-propagation-2.png 
PRE-CREATION 
  docs/src/site/resources/images/twiki/classification-propagation-3.png 
PRE-CREATION 
  docs/src/site/resources/images/twiki/classification-propagation-4.png 
PRE-CREATION 
  docs/src/site/resources/images/twiki/classification-propagation-5.png 
PRE-CREATION 
  docs/src/site/resources/images/twiki/classification-propagation-6.png 
PRE-CREATION 
  docs/src/site/resources/images/twiki/classification-propagation-7.png 
PRE-CREATION 
  docs/src/site/resources/images/twiki/classification-propagation-8.png 
PRE-CREATION 
  docs/src/site/twiki/ClassificationPropagation.twiki PRE-CREATION 
  docs/src/site/twiki/index.twiki 4f74702c4 


Diff: https://reviews.apache.org/r/67144/diff/1/


Testing
---

Validated in html doc the classification propagation pages are rendered fine.


Thanks,

Sarath Subramanian



[jira] [Created] (ATLAS-2687) Create twiki documentation about classification propagation

2018-05-15 Thread Sarath Subramanian (JIRA)
Sarath Subramanian created ATLAS-2687:
-

 Summary: Create twiki documentation about classification 
propagation
 Key: ATLAS-2687
 URL: https://issues.apache.org/jira/browse/ATLAS-2687
 Project: Atlas
  Issue Type: Task
  Components:  atlas-core
Affects Versions: 1.0.0
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian
 Fix For: 1.0.0


twiki documentation about classification propagation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66879: ATLAS-2632: Tag Propagation : Tag is added to propagatedClassification twice when relationship is updated to BOTH.

2018-05-15 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66879/#review203163
---


Ship it!




Ship It!

- Madhan Neethiraj


On April 30, 2018, 11:33 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66879/
> ---
> 
> (Updated April 30, 2018, 11:33 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2632
> https://issues.apache.org/jira/browse/ATLAS-2632
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1.Create a lineage like the following :
> 
> employee -- 1 --> process --- 2 -> employee_ctas
> 
> 2.Add tag1 to employee table with propagate set to True.
> 3.Edit edge2 and set propagateTags to BOTH.
> 4.Now , in the relationship definition of edge2 , there are 2 tags "tag1" in 
> "propagatedClassifications".
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> d04daa5d 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
>  91c97776 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  3b9a287f 
>   
> repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java
>  51e40f0a 
> 
> 
> Diff: https://reviews.apache.org/r/66879/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/320/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



[jira] [Commented] (ATLAS-2638) Disabling tag propagation at an edge : Switching propagate flag after adding tag to blockedPropagatedClassifications

2018-05-15 Thread Madhan Neethiraj (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476470#comment-16476470
 ] 

Madhan Neethiraj commented on ATLAS-2638:
-

+1 for the patch. Thanks [~sarath.ku...@gmail.com]!

> Disabling tag propagation at an edge : Switching propagate flag after adding 
> tag to blockedPropagatedClassifications
> 
>
> Key: ATLAS-2638
> URL: https://issues.apache.org/jira/browse/ATLAS-2638
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2638.1.patch
>
>
> 1. Created a database db1 and table db1.table1.
> 2. Updated the relationship between db1 and table1 to TWO_TO_ONE.
> 3.Added tag1 to db1. Tag is propagated to table1.
> 4. Updated relationship between db1 and table1 and added tag1 to 
> blockedPropagatedClassifications.
> 5. now , tag1 is removed from table1.
> 6. Now switched propagate flag value of tag1 at db1 from True to False.
> 7. In relationship definition between db1 and table1 , tag1 is removed from 
> blockedPropagatedClassifications.
> 8. Now switched propagate flag value of tag1 at db1 from False to True.
> 9. In relationship definition between db1 and table1 , tag1 is added back 
> automatically to blockedPropagatedClassifications.
> 10. Now, though tag1 is in blockedPropagatedClassifications , tag1 is still 
> propagated to table1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2686) [Glossary] Restrict Term deletion if it's assigned to any entity

2018-05-15 Thread Apoorv Naik (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-2686:
---
Summary: [Glossary] Restrict Term deletion if it's assigned to any entity  
(was: [Glossary] Term can't be deleted if it's assigned to any entity)

> [Glossary] Restrict Term deletion if it's assigned to any entity
> 
>
> Key: ATLAS-2686
> URL: https://issues.apache.org/jira/browse/ATLAS-2686
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2686) [Glossary] Term can't be deleted if it's assigned to any entity

2018-05-15 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-2686:
--

 Summary: [Glossary] Term can't be deleted if it's assigned to any 
entity
 Key: ATLAS-2686
 URL: https://issues.apache.org/jira/browse/ATLAS-2686
 Project: Atlas
  Issue Type: Improvement
Reporter: Apoorv Naik
Assignee: Apoorv Naik
 Fix For: 1.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Jenkins build is back to normal : Atlas-master-UnitTests #1371

2018-05-15 Thread Apache Jenkins Server
See 




[jira] [Commented] (ATLAS-2671) Dependency version upgrade to latest stable release

2018-05-15 Thread Sarath Subramanian (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476286#comment-16476286
 ] 

Sarath Subramanian commented on ATLAS-2671:
---

+1

> Dependency version upgrade to latest stable release
> ---
>
> Key: ATLAS-2671
> URL: https://issues.apache.org/jira/browse/ATLAS-2671
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: 0001-Dependency-upgrades.patch
>
>
> Spring, Jackson and Lucene upgrades



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Build failed in Jenkins: PreCommit-ATLAS-Build-Test #407-master-0001-ATLAS-2679-Update-qualifiedName-category-hierarchy-c.patch

2018-05-15 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2463: documentation of Atlas authorization model

[madhan] ATLAS-2676 : UI fix to address basic-search handling of term input in 
IE

--
[...truncated 225.72 KB...]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 9 resources
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
atlas-repository ---
[INFO] 
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 132 source files to 

[INFO] 
:
 Some input files use or override a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 35 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 45 source files to 

[INFO] 
:
 

 uses or overrides a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-repository 
---
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider

---
 T E S T S
---
Running org.apache.atlas.repository.impexp.ExportServiceTest
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1Test
Running org.apache.atlas.repository.migration.HiveParititionTest
Running org.apache.atlas.repository.store.graph.v1.AtlasComplexAttributesTest
Running org.apache.atlas.repository.migration.HiveStocksTest
Running 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipStoreHardDeleteV1Test
Running org.apache.atlas.repository.impexp.AtlasImportRequestTest
Running org.apache.atlas.repository.store.graph.v1.AtlasEntityDefStoreV1Test
Running org.apache.atlas.repository.migration.PathTest
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateHardDeleteV1Test
Running org.apache.atlas.repository.userprofile.UserProfileServiceTest
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateSoftDeleteV1Test
Running org.apache.atlas.repository.audit.InMemoryAuditRepositoryTest
Running org.apache.atlas.repository.migration.RelationshipMappingTest
Running org.apache.atlas.repository.impexp.UniqueListTest
Running org.apache.atlas.repository.impexp.ImportTransformerTest
Running 

[jira] [Created] (ATLAS-2685) [Glossary] Impose displayName restiction for Glossary, term & category

2018-05-15 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-2685:
--

 Summary: [Glossary] Impose displayName restiction for Glossary, 
term & category
 Key: ATLAS-2685
 URL: https://issues.apache.org/jira/browse/ATLAS-2685
 Project: Atlas
  Issue Type: Improvement
Reporter: Apoorv Naik
Assignee: Apoorv Naik


As per ATLAS-1410 discussions, there certain restriction in place for the 
displayName of the Glossary, term and category. This patch enforces those 
naming restrictions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 67089: ATLAS-2674 Unable to set an array value for an attribute in the open metadata

2018-05-15 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67089/#review203141
---



Hi David,
I think what you have here will work correctly. Personally I find the 'rules' 
to be quite difficult to parse and correlate with the logic in the comments.
Would it be possible to lay out the predicates more clearly, e.g. range 
checking 'element' within the array bounds and current size?

- Graham Wallis


On May 11, 2018, 2:56 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67089/
> ---
> 
> (Updated May 11, 2018, 2:56 p.m.)
> 
> 
> Review request for atlas, Graham Wallis and MandyDW MandyDW.
> 
> 
> Bugs: ATLAS2674
> https://issues.apache.org/jira/browse/ATLAS2674
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Unable to set an array value for an attribute in the open metadata
> 
> 
> Diffs
> -
> 
>   
> omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java
>  154eb16c9 
>   
> omrs/src/test/java/org/apache/atlas/omrs/metadatacollection/properties/instances/TestArrayPropertyValue.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67089/diff/1/
> 
> 
> Testing
> ---
> 
> Ran junits- that failed without the fix.
> 
> 
> Thanks,
> 
> David Radley
> 
>



Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

2018-05-15 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203132
---




omag-api/pom.xml
Line 42 (original), 42 (patched)


Atlas (built with embedded hbase) fails to start with this in the 
application.log:

2018-05-15 16:56:33,093 INFO  - [main:] ~ Loading 
atlas-application.properties from 
file:/Users/david/atlasreview/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/conf/atlas-application.properties
 (ApplicationProperties:98)
2018-05-15 16:56:33,100 INFO  - [main:] ~ Property (set to default) 
atlas.graph.cache.db-cache = true (ApplicationProperties:242)
2018-05-15 16:56:33,100 INFO  - [main:] ~ Property (set to default) 
atlas.graph.cache.db-cache-clean-wait = 20 (ApplicationProperties:242)
2018-05-15 16:56:33,102 INFO  - [main:] ~ Property (set to default) 
atlas.graph.cache.db-cache-size = 0.5 (ApplicationProperties:242)
2018-05-15 16:56:33,102 INFO  - [main:] ~ Property (set to default) 
atlas.graph.cache.tx-cache.size = 15000 (ApplicationProperties:242)
2018-05-15 16:56:33,102 INFO  - [main:] ~ Property (set to default) 
atlas.graph.cache.tx-dirty-size = 120 (ApplicationProperties:242)
2018-05-15 16:56:33,116 INFO  - [main:] ~ 


   Atlas Server (STARTUP)

project.name:   apache-atlas
project.description:Metadata Management and Data Governance 
Platform over Hadoop
build.user: david
build.epoch:1526398417725
project.version:1.0.0-SNAPSHOT
build.version:  1.0.0-SNAPSHOT-r7e70b1e76324305fb1cd50302206c9d135b2be53
vc.revision:7e70b1e76324305fb1cd50302206c9d135b2be53
vc.source.url:  scm:git:git://git.apache.org/atlas.git/atlas-webapp


 (Atlas:215)
2018-05-15 16:56:33,117 INFO  - [main:] ~ > 
(Atlas:216)
2018-05-15 16:56:33,117 INFO  - [main:] ~ Server starting with TLS ? false 
on port 21000 (Atlas:217)
2018-05-15 16:56:33,117 INFO  - [main:] ~ < 
(Atlas:218)
2018-05-15 16:56:33,694 INFO  - [main:] ~ No authentication method 
configured.  Defaulting to simple authentication (LoginProcessor:102)
2018-05-15 16:56:33,806 INFO  - [main:] ~ Logged in user david 
(auth:SIMPLE) (LoginProcessor:77)
2018-05-15 16:56:34,210 INFO  - [main:] ~ Not running setup per 
configuration atlas.server.run.setup.on.start. (SetupSteps$SetupRequired:189)


- David Radley


On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> ---
> 
> (Updated May 15, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy 
> Chessell, and Ruxandra Rosu.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Create configuration for OMAG API in Atlas
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/pom.xml 8b1cefd 
>   omag-api/pom.xml 2338286 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java
>  dd19018 
>   omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java 
> PRE-CREATION 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
>  PRE-CREATION 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java
>  ebc9f2a 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
>  PRE-CREATION 
>   
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java
>  1a15215 
>   
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java
>  c2950c4 
>   omag-server/pom.xml 527c5c3 
>   
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java
>  88397de 
>   omag-server/src/main/resources/application.properties PRE-CREATION 
>   omas-assetconsumer/pom.xml 29935e7 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java
>  80a98f5 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
>   
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
>  967be5a 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java
>  

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

2018-05-15 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203130
---




omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java
Line 180 (original), 181 (patched)


you have remove the throws clause in the latest patch but the javadoc is 
left in. I suggest leaving in the throws clause. I think they are there to 
indicate these are the exceptions that any validation code we add in the future 
might throw



omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
Lines 1143 (patched)


javadoc of exceptions mismatches the code. It is important this matches as 
it will be the basis of the the swagger. This is the same for many methods



omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java
Line 28 (original), 27 (patched)


what about omrs?



omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
Line 230 (original), 211 (patched)


this change have removed the PathVariable and RequestParam annotations, it 
looks like we have lost inforration about which parameters are PathVariables 
and which are RequestParams



omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java
Line 306 (original), 306 (patched)


shouldn't this url include the open-metadata segment?



webapp/src/main/webapp/WEB-INF/openMetadataContext.xml
Lines 2 (patched)


this licenses has bad characters that are casing git rebase errors when I 
apply the patch.


- David Radley


On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> ---
> 
> (Updated May 15, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy 
> Chessell, and Ruxandra Rosu.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Create configuration for OMAG API in Atlas
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/pom.xml 8b1cefd 
>   omag-api/pom.xml 2338286 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java
>  dd19018 
>   omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java 
> PRE-CREATION 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
>  PRE-CREATION 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java
>  ebc9f2a 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
>  PRE-CREATION 
>   
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java
>  1a15215 
>   
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java
>  c2950c4 
>   omag-server/pom.xml 527c5c3 
>   
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java
>  88397de 
>   omag-server/src/main/resources/application.properties PRE-CREATION 
>   omas-assetconsumer/pom.xml 29935e7 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java
>  80a98f5 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
>   
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
>  967be5a 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java
>  PRE-CREATION 
>   omas-connectedasset/README.md 2f431df 
>   omas-connectedasset/pom.xml 219c972 
>   
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java
>  8ae6c37 
>   
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java
>  PRE-CREATION 
>   omrs/pom.xml 50b9898 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> 7ae87c6 
>   
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
>  5948482 
>   
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java
>  PRE-CREATION 
>   
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java
>  3f85317 
>   
> 

Build failed in Jenkins: Atlas-master-UnitTests #1370

2018-05-15 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2463: documentation of Atlas authorization model

[madhan] ATLAS-2676 : UI fix to address basic-search handling of term input in 
IE

--
[...truncated 171.55 KB...]
[INFO] Exclude: **/public/js/external_lib/**
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/public/js/libs/**
[INFO] Exclude: **/atlas.data/**
[INFO] Exclude: **/${sys:atlas.data}/**
[INFO] Exclude: **/policy-store.txt
[INFO] Exclude: **/*rebel*.xml
[INFO] Exclude: **/*rebel*.xml.bak
[INFO] Exclude: **/test/resources/**
[INFO] 174 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 174 licenses.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources-solr) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 9 resources
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
atlas-repository ---
[INFO] 
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 132 source files to 

[INFO] 
:
 Some input files use or override a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 35 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 45 source files to 

[INFO] 
:
 

 uses or overrides a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-repository 
---
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider

---
 T E S T S
---
Running org.apache.atlas.repository.impexp.AtlasImportRequestTest
Running org.apache.atlas.services.MetricsServiceTest
Running org.apache.atlas.repository.impexp.ExportServiceTest
Running org.apache.atlas.repository.impexp.TypeAttributeDifferenceTest
Running org.apache.atlas.repository.impexp.ZipSourceTest
Running org.apache.atlas.query.GremlinQueryComposerTest
Running org.apache.atlas.repository.audit.InMemoryAuditRepositoryTest
Running org.apache.atlas.repository.store.graph.v1.AtlasComplexAttributesTest
Running org.apache.atlas.query.DSLQueriesTest
Running 

[jira] [Commented] (ATLAS-2676) UI - (IE-11) - If an entity is search through Basic search by Type then it show "undefined: Unknown/invalid glossary term" error

2018-05-15 Thread Madhan Neethiraj (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475976#comment-16475976
 ] 

Madhan Neethiraj commented on ATLAS-2676:
-

[~tejas_rawool] - thanks for the details. It helps understand the issue better.

+1 for the patch from [~kevalbhatt]. Thanks!


> UI -  (IE-11) - If an entity is search through Basic search by Type then it 
> show "undefined: Unknown/invalid glossary term" error
> -
>
> Key: ATLAS-2676
> URL: https://issues.apache.org/jira/browse/ATLAS-2676
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Tejas Rawool
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2676.patch, ATLAS-2676BugVideo.webm, SS8.jpg
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.

2018-05-15 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67114/#review203126
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 15, 2018, 12:22 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67114/
> ---
> 
> (Updated May 15, 2018, 12:22 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2463
> https://issues.apache.org/jira/browse/ATLAS-2463
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch adds documentation to Atlas authorization at entity level for 
> simple authorizer.
> 
> 
> Diffs
> -
> 
>   docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION 
>   docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 
>   docs/src/site/twiki/Configure-simple-authorizer.twiki PRE-CREATION 
>   docs/src/site/twiki/index.twiki 258dfbb7f 
> 
> 
> Diff: https://reviews.apache.org/r/67114/diff/2/
> 
> 
> Testing
> ---
> 
> Tested the documentation after running mvn site
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>



Re: Review Request 66064: ATLAS-2478 Elasticsearch support broken with JanusGraph 0.2.0

2018-05-15 Thread Pierre Padovani


> On May 7, 2018, 11:41 p.m., Ashutosh Mestry wrote:
> > On executing ./bin/atlas_start.py displays these messages:
> > ./target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/conf/atlas-env.sh:
> >  line 65: MANAGE_EMBEDDED_CASSANDRA=${cassandra.embedded}: bad substitution
> > ./target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/conf/atlas-env.sh:
> >  line 68: MANAGE_LOCAL_ELASTICSEARCH=${elasticsearch.managed}: bad 
> > substitution
> > Exception: ('Could not find hbase-site.xml in %s. Please set env var 
> > HBASE_CONF_DIR to the hbase client conf dir', 
> > './target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/hbase/conf')
> > Traceback (most recent call last):
> >   File "./bin/atlas_start.py", line 163, in 
> >   File "./bin/atlas_start.py", line 92, in main
> > Exception: ('Could not find hbase-site.xml in %s. Please set env var 
> > HBASE_CONF_DIR to the hbase client conf dir', 
> > './target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/hbase/conf')
> 
> Pierre Padovani wrote:
> Fixed in the updated patch.

Any updates on this review?


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66064/#review202603
---


On May 8, 2018, 3 p.m., Pierre Padovani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66064/
> ---
> 
> (Updated May 8, 2018, 3 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2478
> https://issues.apache.org/jira/browse/ATLAS-2478
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch fixes the Elasticsearch support for JanusGraph 0.2.0 and updates 
> documentation.
> 
> Included with this patch is an update to the berkley-elasticsearch profile to 
> automatically download and include elasticsearch as a side application much 
> like solr is. Updates to the start/stop/conf scripts are included as well.
> 
> NOTE: This patch includes a **BACKWARDS INCOMPATIBLE** change to 
> /atlas/common/src/main/java/org/apache/atlas/repository/Constants.java. There 
> are six constants that are incorrectly named with a '.' (dot). This is not 
> supported in Elasticsearch 5 and beyond when defining a mapping **UNLESS** 
> the field names can be collectively thought of as an object. In the case of 
> the fields defined in the Constants.java file, 'type' is defined as a string 
> field, and 'type.name' is also defined as a string field. Elasticsearch sees 
> this as an error, since it cannot convert type to an object. The fix included 
> simply changes the field names from using a '.' (dot) to an '_' (underscore). 
> This should NOT affect compatibility with hbase/solr for new installs. For 
> existing installations, a reindex will be required as the field names will 
> have changed.
> 
> **Query**: There is a way we can simplify integration/unit tests for the 
> in-memory graph store by using a maven plugin that will download and run an 
> elasticsearch node. This is nothing more than a maven change, and change to 
> the atlas-application.properties to switch to elasticsearch from solr. I did 
> not implement this, but am curious if this change would be desired. If so, 
> this can be done with a separate ticket.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 16a3aaa15 
>   distro/pom.xml 6431fd86d 
>   distro/src/bin/atlas_config.py 9062da649 
>   distro/src/bin/atlas_start.py 61d69eb21 
>   distro/src/bin/atlas_stop.py 94c3d6d46 
>   distro/src/conf/atlas-env.sh 053cbd500 
>   distro/src/main/assemblies/standalone-package.xml dc88add56 
>   docs/src/site/twiki/Configuration.twiki 63c3fce96 
>   docs/src/site/twiki/HighAvailability.twiki 4270d0974 
>   docs/src/site/twiki/InstallationSteps.twiki dca0618e3 
>   graphdb/janus/pom.xml 016a09c33 
>   pom.xml 3469a393a 
>   webapp/pom.xml 03b84087f 
> 
> 
> Diff: https://reviews.apache.org/r/66064/diff/4/
> 
> 
> Testing
> ---
> 
> We currently use this fix with our Atlas setup in a fork of the Atlas code, 
> and have found no issues with it. Additionally, with the update to the 
> berkley-elasticsearch profile, I have extensively tested that profile to make 
> sure that management of Elasticsearch functioned correctly.
> 
> 
> Thanks,
> 
> Pierre Padovani
> 
>



Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

2018-05-15 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/#review203116
---




webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
Lines 116 (patched)


Nixon - sorry, my earlier comment was incorrect. What I meant to say was:
  ATLAS-2310 replaced use of URLDecoder.encode() with 
UriUtils.encodeQuery(). Perhaps the decoding should be done by corresponding 
UriUtils method - UriUtils.decode()?


- Madhan Neethiraj


On May 11, 2018, 11 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67085/
> ---
> 
> (Updated May 11, 2018, 11 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2673
> https://issues.apache.org/jira/browse/ATLAS-2673
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles decoding of encoded query string for DSL search.
> 
> Use case:-
> 
> DSL query :
> 
> /api/atlas/v2/search/dsl?typeName=hive_table=name="weather2"
> fired on PASSIVE server redirects to ACTIVE server as
> 
> /api/atlas/v2/search/dsl?limit=25=0=name=%2522weather2%2522=hive_table
> fails with
> 
> {
> errorCode: "ATLAS-400-00-059",
> errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
> DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
> type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 
> 22 type not found. Please refer to Atlas DSL grammar for more information"
> }
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 
> 
> 
> Diff: https://reviews.apache.org/r/67085/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by accessing URL 
> /api/atlas/v2/search/dsl?typeName=Table=name="sales_fact" on passive 
> which redirects on active node now working properly.
> 
> And also on Active node.
> 
> Added few encode queryparam in ITs
> 
> Integration testcase working
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console
> 
> 2018-05-11 10:39:16,828  
> 2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=DB+where+name%3D%22Reporting%22=10|200|262
> 2018-05-11 10:39:17,089  
> 2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=DB+where+name%3D%22encode_db_name%22=10|200|257
> 2018-05-11 10:39:17,351  
> 2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=Table+where+name%3D%2522sales_fact%2522=10|200|258
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>



Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

2018-05-15 Thread Bogdan Sava

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/
---

(Updated May 15, 2018, 1:35 p.m.)


Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy 
Chessell, and Ruxandra Rosu.


Repository: atlas


Description
---

Create configuration for OMAG API in Atlas


Diffs (updated)
-

  om-fwk-ocf/pom.xml 8b1cefd 
  omag-api/pom.xml 2338286 
  
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java
 dd19018 
  omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java 
PRE-CREATION 
  
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
 PRE-CREATION 
  
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java
 ebc9f2a 
  
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
 PRE-CREATION 
  
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java
 1a15215 
  
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java
 c2950c4 
  omag-server/pom.xml 527c5c3 
  
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java
 88397de 
  omag-server/src/main/resources/application.properties PRE-CREATION 
  omas-assetconsumer/pom.xml 29935e7 
  
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java
 80a98f5 
  
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
  
  
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
 967be5a 
  
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java
 PRE-CREATION 
  omas-connectedasset/README.md 2f431df 
  omas-connectedasset/pom.xml 219c972 
  
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java
 8ae6c37 
  
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java
 PRE-CREATION 
  omrs/pom.xml 50b9898 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
7ae87c6 
  
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
 5948482 
  
omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java
 PRE-CREATION 
  
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java
 3f85317 
  
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java
 ccf0de6 
  webapp/pom.xml 03b8408 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1 
  webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml 23dc063 


Diff: https://reviews.apache.org/r/67083/diff/3/

Changes: https://reviews.apache.org/r/67083/diff/2-3/


Testing
---

Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.


Change base URL for the API to "/open-metadata/access-services" 


Clean maven unused dependenies

The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665


File Attachments


Added apache licence to a properties file
  
https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
0003-ATLAS-2665-comments-fixed.patch
  
https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
  
https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch


Thanks,

Bogdan Sava



[jira] [Updated] (ATLAS-2665) Add OMAG-API in Atlas

2018-05-15 Thread Bogdan Sava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Sava updated ATLAS-2665:
---
Attachment: ATLAS-2665-Add-OMAG-API-in-Atlas-v3.patch

> Add OMAG-API in Atlas
> -
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Assignee: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch, 
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch, 
> ATLAS-2665-Add-OMAG-API-in-Atlas-v3.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> Change base URL for the API to "/open-metadata" 
>  
> The review board is: [https://reviews.apache.org/r/67083/]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2682) Atlas startup fails when configuring External HBase.

2018-05-15 Thread Graham Wallis (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475788#comment-16475788
 ] 

Graham Wallis commented on ATLAS-2682:
--

Hi [~lks21c],

Just out of interest - what profile options did you use when you built Atlas?

Cheers

  Graham

> Atlas startup fails when configuring External HBase.
> 
>
> Key: ATLAS-2682
> URL: https://issues.apache.org/jira/browse/ATLAS-2682
> Project: Atlas
>  Issue Type: Bug
>Reporter: Kwangsik Lee
>Priority: Major
>
> Hi, guys. 
> I'm trying to set Atlas with our existing Hbase which is 1.0.0.
> I used Atlas-1.0.0-SNAPSHOT, but I encountered the error message with below 
> settings.
> Can you help me out to figure out what I can fix this issue?
> Thanks.
> {code:java}
> atlas.graph.storage.backend=hbase
> atlas.graph.storage.hbase.table=apache_atlas_janus
> #Hbase
> #For standalone mode , specify localhost
> #for distributed mode, specify zookeeper quorum here
> #atlas.graph.storage.hostname=localhost
> atlas.graph.storage.hostname=server:2181,server:2181,server:2181,server:2181,server:2181
> atlas.graph.storage.hbase.regions-per-server=1
> atlas.graph.storage.lock.wait-time=1
> {code}
> {code:java}
> export HBASE_CONF_DIR=/home/user/hbase/conf
> {code}
> {code:java}
> 2018-05-15 12:29:42,838 ERROR - [main:] ~ Context initialization failed 
> (ContextLoader:350) org.springframework.beans.factory.BeanCreationException: 
> Error creating bean with name 
> 'org.springframework.context.event.internalEventListenerProcessor': 
> BeanPostProcessor before instantiation of bean failed; nested exception is 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'graphTransactionAdvisor' defined in URL 
> [jar:file:/home/suser/apache-atlas-1.0.0-SNAPSHOT/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0-SNAPSHOT.jar!/org/apache/atlas/GraphTransactionAdvisor.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'graphTransactionInterceptor' defined in URL 
> [jar:file:/home/suser/apache-atlas-1.0.0-SNAPSHOT/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0-SNAPSHOT.jar!/org/apache/atlas/GraphTransactionInterceptor.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is org.springframework.beans.factory.BeanCreationException: Error 
> creating bean with name 'get' defined in 
> org.apache.atlas.repository.graph.AtlasGraphProvider: Bean instantiation via 
> factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.atlas.repository.graphdb.AtlasGraph]: Factory method 'get' threw 
> exception; nested exception is java.lang.IllegalArgumentException: Could not 
> instantiate implementation: 
> org.janusgraph.diskstorage.hbase.HBaseStoreManager at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:479)
>  at 
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
>  at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
>  at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
>  at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
>  at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:761)
>  at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:866)
>  at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:542)
>  at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:443)
>  at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:325)
>  at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:107)
>  at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:843)
>  at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:533)
>  at 
> org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:816)
>  at 
> 

Build failed in Jenkins: Atlas-master-UnitTests #1369

2018-05-15 Thread Apache Jenkins Server
See 

--
[...truncated 171.45 KB...]
[INFO] Exclude: **/public/js/external_lib/**
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/public/js/libs/**
[INFO] Exclude: **/atlas.data/**
[INFO] Exclude: **/${sys:atlas.data}/**
[INFO] Exclude: **/policy-store.txt
[INFO] Exclude: **/*rebel*.xml
[INFO] Exclude: **/*rebel*.xml.bak
[INFO] Exclude: **/test/resources/**
[INFO] 174 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 174 licenses.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources-solr) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 9 resources
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
atlas-repository ---
[INFO] 
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 132 source files to 

[INFO] 
:
 Some input files use or override a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 35 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 45 source files to 

[INFO] 
:
 

 uses or overrides a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-repository 
---
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider

---
 T E S T S
---
Running org.apache.atlas.repository.impexp.ExportServiceTest
Running org.apache.atlas.repository.tagpropagation.ClassificationPropagationTest
Running org.apache.atlas.repository.userprofile.UserProfileServiceTest
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateHardDeleteV1Test
Running org.apache.atlas.repository.impexp.TypeAttributeDifferenceTest
Running org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
Running org.apache.atlas.repository.impexp.ImportTransformerJSONTest
Running org.apache.atlas.repository.impexp.ImportTransformerTest
Running org.apache.atlas.glossary.PaginationHelperTest
Running org.apache.atlas.query.DSLParsingTest
Running 

Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

2018-05-15 Thread Nixon Rodrigues


> On May 11, 2018, 1:54 p.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
> > Lines 116 (patched)
> > 
> >
> > In ATLAS-2310, use of URLDecoder.decode() was replaced wito use 
> > UriUtils.encodeQuery() in ActiveServerFilter. Please review this patch 
> > https://reviews.apache.org/r/64538/.

In ATLAS-2310 the special characters in URL querystring were encoded using 
UriUtils.encodeQuery(), now in ATLAS-2673 this encoded queryString need to be 
decoded when it is read in DSL API.  This patch handles this fix.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/#review202937
---


On May 11, 2018, 11 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67085/
> ---
> 
> (Updated May 11, 2018, 11 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2673
> https://issues.apache.org/jira/browse/ATLAS-2673
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles decoding of encoded query string for DSL search.
> 
> Use case:-
> 
> DSL query :
> 
> /api/atlas/v2/search/dsl?typeName=hive_table=name="weather2"
> fired on PASSIVE server redirects to ACTIVE server as
> 
> /api/atlas/v2/search/dsl?limit=25=0=name=%2522weather2%2522=hive_table
> fails with
> 
> {
> errorCode: "ATLAS-400-00-059",
> errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
> DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
> type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 
> 22 type not found. Please refer to Atlas DSL grammar for more information"
> }
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 
> 
> 
> Diff: https://reviews.apache.org/r/67085/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by accessing URL 
> /api/atlas/v2/search/dsl?typeName=Table=name="sales_fact" on passive 
> which redirects on active node now working properly.
> 
> And also on Active node.
> 
> Added few encode queryparam in ITs
> 
> Integration testcase working
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console
> 
> 2018-05-11 10:39:16,828  
> 2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=DB+where+name%3D%22Reporting%22=10|200|262
> 2018-05-11 10:39:17,089  
> 2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=DB+where+name%3D%22encode_db_name%22=10|200|257
> 2018-05-11 10:39:17,351  
> 2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0=Table+where+name%3D%2522sales_fact%2522=10|200|258
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>



Re: Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.

2018-05-15 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67114/
---

(Updated May 15, 2018, 12:22 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patches includes changes to fix typo error, changes and review comments by 
Nigel & David R.


Bugs: ATLAS-2463
https://issues.apache.org/jira/browse/ATLAS-2463


Repository: atlas


Description
---

This patch adds documentation to Atlas authorization at entity level for simple 
authorizer.


Diffs (updated)
-

  docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION 
  docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 
  docs/src/site/twiki/Configure-simple-authorizer.twiki PRE-CREATION 
  docs/src/site/twiki/index.twiki 258dfbb7f 


Diff: https://reviews.apache.org/r/67114/diff/2/

Changes: https://reviews.apache.org/r/67114/diff/1-2/


Testing
---

Tested the documentation after running mvn site


Thanks,

Nixon Rodrigues



[jira] [Updated] (ATLAS-2676) UI - (IE-11) - If an entity is search through Basic search by Type then it show "undefined: Unknown/invalid glossary term" error

2018-05-15 Thread Keval Bhatt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-2676:
---
Attachment: ATLAS-2676.patch

> UI -  (IE-11) - If an entity is search through Basic search by Type then it 
> show "undefined: Unknown/invalid glossary term" error
> -
>
> Key: ATLAS-2676
> URL: https://issues.apache.org/jira/browse/ATLAS-2676
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Tejas Rawool
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2676.patch, ATLAS-2676BugVideo.webm, SS8.jpg
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2681) Atlas startup fails when configuring ES 5.5 as index backend.

2018-05-15 Thread Graham Wallis (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475717#comment-16475717
 ] 

Graham Wallis commented on ATLAS-2681:
--

Hi [~lks21c]. 

>From the [JanusGraph configuration 
>reference|http://docs.janusgraph.org/0.1.0/config-ref.html#_index] it looks 
>like changing the configured indexing backend has mutability of GLOBAL_OFFLINE 
>- which would mean that provided JanusGraph is fully offline then it should be 
>possible to restart it with the new configuration. 

But I notice that Atlas checks whether the configured indexing backend has 
changed and throws a RuntimeException. I am not sure of the reasons for this 
checking by Atlas. Others may be able to advise. If not, then it may be worth 
relaxing the constraint and testing to see what happens.

The constraint is in AtlasJanusGraphDatabase.java at line 157:
{code:java}
if (!configuredIndexBackend.equals(currentIndexBackend)) {
 throw new RuntimeException("Configured Index Backend " + configuredIndexBackend
 + " differs from earlier configured Index Backend " + currentIndexBackend + ". 
Aborting!");
}{code}
 

> Atlas startup fails when configuring ES 5.5 as index backend.
> -
>
> Key: ATLAS-2681
> URL: https://issues.apache.org/jira/browse/ATLAS-2681
> Project: Atlas
>  Issue Type: Bug
>Reporter: Kwangsik Lee
>Priority: Major
>
> Hi, guys.
> I'm setting up Apache atlas with our ES 5.5 cluster instead of using Solr.
> So I tried to switch indexing backend into ES with 
> atlas-application.properties as below.
> I used Atlas-1.0.0-SNAPSHOT. 
> {code:java}
> atlas.graph.index.search.backend=elasticsearch
> atlas.graph.index.search.elasticsearch.interface=REST_CLIENT
> atlas.graph.index.search.hostname=ES_URL:PORT
> atlas.graph.index.search.elasticsearch.client-only=true
> {code}
> Howerv, error log was found when I tried to start up. I used embedded Hbase 
> and Kafka except ES backend. Atlas runs well with embedded legacies.
> {code:java}
> 2018-05-15 11:24:43,828 ERROR - [main:] ~ Context initialization failed 
> (ContextLoader:350)
> org.springframework.beans.factory.BeanCreationException: Error creating bean 
> with name 'org.springframework.context.event.internalEventListenerProcessor': 
> BeanPostProcessor before instantiation of bean failed; nested exception is 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'graphTransactionAdvisor' defined in URL 
> [jar:file:/home/suser/atlas_standalone/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0-SNAPSHOT.jar!/org/apache/atlas/GraphTransactionAdvisor.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'graphTransactionInterceptor' defined in URL 
> [jar:file:/home/suser/atlas_standalone/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0-SNAPSHOT.jar!/org/apache/atlas/GraphTransactionInterceptor.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is org.springframework.beans.factory.BeanCreationException: Error 
> creating bean with name 'get' defined in 
> org.apache.atlas.repository.graph.AtlasGraphProvider: Bean instantiation via 
> factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.atlas.repository.graphdb.AtlasGraph]: Factory method 'get' threw 
> exception; nested exception is java.lang.RuntimeException: Configured Index 
> Backend elasticsearch differs from earlier configured Index Backend solr. 
> Aborting!
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:479)
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:761)
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:866)
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:542)
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:443)
> at 
> 

[jira] [Created] (ATLAS-2684) UI - User can not create more than 20 sub-categories within category which is incorrect

2018-05-15 Thread Tejas Rawool (JIRA)
Tejas Rawool created ATLAS-2684:
---

 Summary: UI - User can not create more than 20 sub-categories 
within category which is incorrect
 Key: ATLAS-2684
 URL: https://issues.apache.org/jira/browse/ATLAS-2684
 Project: Atlas
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Tejas Rawool
 Fix For: 1.0.0
 Attachments: SS3.png

If the sub categories start point reaches till 500 in left menu then this issue 
occurs. To reproduce this issue keep on creating Sub category within its Sub 
category and at some point of time user doesn't gets option to add more sub 
category.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Build failed in Jenkins: Atlas-master-UnitTests #1368

2018-05-15 Thread Apache Jenkins Server
See 

--
[...truncated 171.43 KB...]
[INFO] Exclude: **/public/js/external_lib/**
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/public/js/libs/**
[INFO] Exclude: **/atlas.data/**
[INFO] Exclude: **/${sys:atlas.data}/**
[INFO] Exclude: **/policy-store.txt
[INFO] Exclude: **/*rebel*.xml
[INFO] Exclude: **/*rebel*.xml.bak
[INFO] Exclude: **/test/resources/**
[INFO] 174 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 174 licenses.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources-solr) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 9 resources
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
atlas-repository ---
[INFO] 
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 132 source files to 

[INFO] 
:
 Some input files use or override a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 35 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 45 source files to 

[INFO] 
:
 

 uses or overrides a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-repository 
---
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider

---
 T E S T S
---
Running org.apache.atlas.utils.TestResourceFileUtils
Running org.apache.atlas.repository.impexp.ImportServiceTest
Running org.apache.atlas.repository.store.graph.v1.AtlasEntityDefStoreV1Test
Running org.apache.atlas.repository.store.graph.v1.AtlasEntityStoreV1Test
Running org.apache.atlas.repository.migration.PathTest
Running org.apache.atlas.repository.impexp.ImportTransformerTest
Running org.apache.atlas.repository.audit.CassandraAuditRepositoryTest
Running org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStoreTest
Running org.apache.atlas.repository.audit.InMemoryAuditRepositoryTest
Running org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateV1Test
Running 

[jira] [Created] (ATLAS-2683) UI - Delete term option appears for glossary which is incorrect

2018-05-15 Thread Tejas Rawool (JIRA)
Tejas Rawool created ATLAS-2683:
---

 Summary: UI - Delete term option appears for glossary which is 
incorrect
 Key: ATLAS-2683
 URL: https://issues.apache.org/jira/browse/ATLAS-2683
 Project: Atlas
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Tejas Rawool
 Fix For: 1.0.0
 Attachments: SS4.png

Steps to reproduce:-
1.Go to glossary tab
2.Now update any glossary
3.Now click on its options (3 dots)
 
Error:-
*Delete Term* option appears instead of *Create Term* and *Delete Glossary* 
which is incorrect



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

2018-05-15 Thread Nigel Jones


> On May 14, 2018, 11:25 a.m., Nigel Jones wrote:
> > omag-api/pom.xml
> > Line 46 (original)
> > 
> >
> > I wonder why we went with 1.5.7 of springboot? I know we want to match 
> > up SPRING versions (which maps to 4.x)
> > 
> > Using the same version as atlas seems a good move, and this is 4.3.8 as 
> > defined in the top level pom.xml
> > 
> > However 1.5.7 (used in this patch) of springbook maps to spring 4.3.11, 
> > whilst 1.5.3 maps to 4.3.8 (used in Atlas).
> > 
> > I wonder if to eliminate issues we should match more closely - for 
> > example go with 1.5.3 of springboot. Alternatively bring Atlas up to the 
> > most current 1.5/4.x versions initially, maybe even 2.x/5.2 in the next 
> > release?
> 
> Bogdan Sava wrote:
> Springboot is now a dependency only on omag-server. It is not needed in 
> Atlas (I have removed all unused springboot dependencies).
> As omag-server is independent of Atlas, I plan to upgrade to psringboot 
> 2.x
> 
> omag-api, omases and omrs are using spring-web which is inherited from 
> atlas parent pom.

Ok, thanks, will check in next patch


- Nigel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203003
---


On May 14, 2018, 8 p.m., Bogdan Sava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> ---
> 
> (Updated May 14, 2018, 8 p.m.)
> 
> 
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy 
> Chessell, and Ruxandra Rosu.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Create configuration for OMAG API in Atlas
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/pom.xml 8b1cefd 
>   omag-api/pom.xml 2338286 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java
>  dd19018 
>   omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java 
> PRE-CREATION 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
>  PRE-CREATION 
>   
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java
>  ebc9f2a 
>   
> omag-api/src/main/java/org/apache/atlas/omag/api/OMAGServerAdminResource.java 
> PRE-CREATION 
>   omag-server/pom.xml 527c5c3 
>   
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java
>  88397de 
>   omag-server/src/main/resources/application.properties PRE-CREATION 
>   omas-assetconsumer/pom.xml 29935e7 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/api/AssetConsumerOMASResource.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java
>  80a98f5 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
>   
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
>  967be5a 
>   omas-connectedasset/README.md 2f431df 
>   omas-connectedasset/pom.xml 219c972 
>   
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/api/ConnectedAssetOMASResource.java
>  PRE-CREATION 
>   
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java
>  8ae6c37 
>   omrs/pom.xml 50b9898 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> 7ae87c6 
>   omrs/src/main/java/org/apache/atlas/omrs/api/OMRSRepositoryResource.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
>  5948482 
>   
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java
>  3f85317 
>   
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java
>  ccf0de6 
>   webapp/pom.xml 03b8408 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1 
>   webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml 23dc063 
> 
> 
> Diff: https://reviews.apache.org/r/67083/diff/2/
> 
> 
> Testing
> ---
> 
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher 
> servlet.
> 
> 
> Change base URL for the API to "/open-metadata/access-services" 
> 
> 
> Clean maven unused dependenies
> 
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
> 
> 
> File Attachments
> 
> 
> Added apache licence to a properties file
>   
> 

[jira] [Reopened] (ATLAS-2676) UI - (IE-11) - If an entity is search through Basic search by Type then it show "undefined: Unknown/invalid glossary term" error

2018-05-15 Thread Tejas Rawool (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tejas Rawool reopened ATLAS-2676:
-

[~madhan.neethiraj], This issue reproducible in IE 11 when basic search is done 
by selecting particular type, when type is selected and search button is 
clicked *undefined* is set in "search by term dropdown". Please find attached 
video with steps [^ATLAS-2676BugVideo.webm]

> UI -  (IE-11) - If an entity is search through Basic search by Type then it 
> show "undefined: Unknown/invalid glossary term" error
> -
>
> Key: ATLAS-2676
> URL: https://issues.apache.org/jira/browse/ATLAS-2676
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Tejas Rawool
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2676BugVideo.webm, SS8.jpg
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2676) UI - (IE-11) - If an entity is search through Basic search by Type then it show "undefined: Unknown/invalid glossary term" error

2018-05-15 Thread Tejas Rawool (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tejas Rawool updated ATLAS-2676:

Attachment: ATLAS-2676BugVideo.webm

> UI -  (IE-11) - If an entity is search through Basic search by Type then it 
> show "undefined: Unknown/invalid glossary term" error
> -
>
> Key: ATLAS-2676
> URL: https://issues.apache.org/jira/browse/ATLAS-2676
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Tejas Rawool
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2676BugVideo.webm, SS8.jpg
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Build failed in Jenkins: Atlas-master-UnitTests #1367

2018-05-15 Thread Apache Jenkins Server
See 

--
[...truncated 171.45 KB...]
[INFO] Exclude: **/public/js/external_lib/**
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/public/js/libs/**
[INFO] Exclude: **/atlas.data/**
[INFO] Exclude: **/${sys:atlas.data}/**
[INFO] Exclude: **/policy-store.txt
[INFO] Exclude: **/*rebel*.xml
[INFO] Exclude: **/*rebel*.xml.bak
[INFO] Exclude: **/test/resources/**
[INFO] 174 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 174 licenses.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources-solr) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 9 resources
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
atlas-repository ---
[INFO] 
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 132 source files to 

[INFO] 
:
 Some input files use or override a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-repository ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 35 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-repository ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 45 source files to 

[INFO] 
:
 

 uses or overrides a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-repository 
---
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider

---
 T E S T S
---
Running org.apache.atlas.repository.impexp.ImportTransformerTest
Running org.apache.atlas.query.DSLParsingTest
Running org.apache.atlas.repository.impexp.ZipSourceTest
Running org.apache.atlas.repository.store.graph.v1.AtlasComplexAttributesTest
Running org.apache.atlas.repository.impexp.ZipSinkTest
Running org.apache.atlas.query.GremlinQueryComposerTest
Running org.apache.atlas.repository.impexp.AtlasImportRequestTest
Running org.apache.atlas.glossary.GlossaryServiceTest
Running org.apache.atlas.repository.tagpropagation.ClassificationPropagationTest
Running org.apache.atlas.repository.impexp.UniqueListTest
Running 
org.apache.atlas.repository.store.graph.v1.InverseReferenceUpdateHardDeleteV1Test
Running