[jira] [Resolved] (ATLAS-3898) Authorize read of typedefs

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-3898.

Resolution: Fixed

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>  Labels: authorization, ranger
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3898:
--
Fix Version/s: 3.0.0

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>  Labels: authorization, ranger
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3898:
--
Fix Version/s: 2.2.0

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>  Labels: authorization, ranger
> Fix For: 2.2.0
>
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3898:
--
Affects Version/s: 2.1.0

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3898:
--
Labels: authorization ranger  (was: )

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>  Labels: authorization, ranger
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3898:
--
Component/s:  atlas-core

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated Aug. 14, 2020, 4:34 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff 


Diff: https://reviews.apache.org/r/72477/diff/9/

Changes: https://reviews.apache.org/r/72477/diff/8-9/


Testing
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console


Thanks,

Mandar Ambawane

Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/#review221585
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
Lines 413 (patched)


Given this method returns true only when all entries are of type 
ENTITY_TYPE_AUDIT_ENTRY, it will be efficient traverse the list only until 
another type is found. Consider the following:
  private static final Predicate 
PRED_IS_NOT_TYPE_AUDIT_ENTITY = obj -> 
!obj.getTypeName().equals(AtlasAuditService.ENTITY_TYPE_AUDIT_ENTRY);

  private boolean skipAuditEntries(List entityHeaders) {
return CollectionUtils.isEmpty(entityHeaders) || 
!entityHeaders.stream().anyMatch(PRED_IS_NOT_TYPE_AUDIT_ENTITY);
  }


- Madhan Neethiraj


On Aug. 14, 2020, 2:06 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72477/
> ---
> 
> (Updated Aug. 14, 2020, 2:06 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3583
> https://issues.apache.org/jira/browse/ATLAS-3583
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
> UPDATE and DELETE
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json 9777b7a 
>   
> addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> a95cf4e 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  a0dc816 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  8e7c1b3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  0dc3193 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff 
> 
> 
> Diff: https://reviews.apache.org/r/72477/diff/8/
> 
> 
> Testing
> ---
> 
> Basic testing is done.
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

[jira] [Updated] (ATLAS-3583) Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

[Mandar Ambawane (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3583:
---
Attachment: ATLAS-3583-V8.patch

> Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and 
> DELETE
> 
>
> Key: ATLAS-3583
> URL: https://issues.apache.org/jira/browse/ATLAS-3583
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3583-V3.patch, ATLAS-3583-V8.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated Aug. 14, 2020, 2:06 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Reverted Test case changes because of issues in execution.
Planning to include those in subsequent patch.


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff 


Diff: https://reviews.apache.org/r/72477/diff/8/

Changes: https://reviews.apache.org/r/72477/diff/7-8/


Testing
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console


Thanks,

Mandar Ambawane

[jira] [Commented] (ATLAS-3898) Authorize read of typedefs

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177781#comment-17177781
 ] 

ASF subversion and git services commented on ATLAS-3898:


Commit bc770b4a20b43f32cea8d64740a8ee5408db8755 in atlas's branch 
refs/heads/branch-2.0 from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=bc770b4 ]

ATLAS-3898: authorization updates to require TYPE_READ permission for type-def 
read

Signed-off-by: Madhan Neethiraj 


> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72714: ATLAS-3898 :- Authorize read of typedefs.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72714/#review221584
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 14, 2020, 1:35 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72714/
> ---
> 
> (Updated Aug. 14, 2020, 1:35 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3898
> https://issues.apache.org/jira/browse/ATLAS-3898
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> 
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assinged to user.
> 
> a)Instrumented authorization code to read classification typedef endpoints in 
> Atlas code with create permission.
> b)Added logAudit property in AtlasRequest to skip auditing for filtering 
> calls.
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
>  460b454b9 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
> 95d69e685 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
> 7287b3dd7 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasTypesDefFilterRequest.java
>  PRE-CREATION 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
>  734991691 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
>  79f52700b 
> 
> 
> Diff: https://reviews.apache.org/r/72714/diff/2/
> 
> 
> Testing
> ---
> 
> Done end to end testing with Atlas with SimpleAuthorizer for getAll typedefs 
> API, and type def API with name & guid.
> 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2110
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

[jira] [Commented] (ATLAS-3898) Authorize read of typedefs

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1719#comment-1719
 ] 

ASF subversion and git services commented on ATLAS-3898:


Commit f077bbbf3b2df2e44df833017a307c565897a74e in atlas's branch 
refs/heads/master from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f077bbb ]

ATLAS-3898: authorization updates to require TYPE_READ permission for type-def 
read

Signed-off-by: Madhan Neethiraj 


> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Description: 
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This patch authorize read for all typedefs. It implicitly add read permission 
if create,update or delete permission is assigned to user.

  was:
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to authorize read of classifications def to user with create 
permission.




> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Attachment: ATLAS-3898.1.patch

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Attachment: (was: ATLAS-3898.2.patch)

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Summary: Authorize read of typedefs  (was: Authorize read of 
Classifications def to user with create permission.)

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.2.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This jira propose to authorize read of classifications def to user with 
> create permission.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72714: ATLAS-3898 :- Authorize read of typedefs.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72714/
---

(Updated Aug. 14, 2020, 1:35 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Summary (updated)
-

ATLAS-3898 :- Authorize read of typedefs.


Bugs: ATLAS-3898
https://issues.apache.org/jira/browse/ATLAS-3898


Repository: atlas


Description
---

Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This patch authorize read for all typedefs. It implicitly add read permission 
if create,update or delete permission is assinged to user.

a)Instrumented authorization code to read classification typedef endpoints in 
Atlas code with create permission.
b)Added logAudit property in AtlasRequest to skip auditing for filtering calls.


Diffs
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 460b454b9 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
95d69e685 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
7287b3dd7 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasTypesDefFilterRequest.java
 PRE-CREATION 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 734991691 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f52700b 


Diff: https://reviews.apache.org/r/72714/diff/2/


Testing
---

Done end to end testing with Atlas with SimpleAuthorizer for getAll typedefs 
API, and type def API with name & guid.

https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2110


Thanks,

Nixon Rodrigues

Re: Review Request 72714: ATLAS-3898 :- Authorize read of Classifications def to user with create permission.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72714/
---

(Updated Aug. 14, 2020, 9:36 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Changes
---

This patch authorize read for all typedefs. It implicitly add read permission 
if create,update or delete permission is assinged to user.


Bugs: ATLAS-3898
https://issues.apache.org/jira/browse/ATLAS-3898


Repository: atlas


Description (updated)
---

Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This patch authorize read for all typedefs. It implicitly add read permission 
if create,update or delete permission is assinged to user.

a)Instrumented authorization code to read classification typedef endpoints in 
Atlas code with create permission.
b)Added logAudit property in AtlasRequest to skip auditing for filtering calls.


Diffs (updated)
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 460b454b9 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
95d69e685 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
7287b3dd7 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasTypesDefFilterRequest.java
 PRE-CREATION 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 734991691 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f52700b 


Diff: https://reviews.apache.org/r/72714/diff/2/

Changes: https://reviews.apache.org/r/72714/diff/1-2/


Testing (updated)
---

Done end to end testing with Atlas with SimpleAuthorizer for getAll typedefs 
API, and type def API with name & guid.

https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2110


Thanks,

Nixon Rodrigues

[jira] [Commented] (ATLAS-3900) UI: Allow user to select the date range for date attribute in basic search

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177638#comment-17177638
 ] 

ASF subversion and git services commented on ATLAS-3900:


Commit c27883ccc38d07ddc6aa273f38d20920b8035a38 in atlas's branch 
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=c27883c ]

ATLAS-3900: UI: Allow user to select the date range for date attribute in basic 
search

(cherry picked from commit 41eebcf4cf435d37c5e67aea916513eac36e3ee5)


> UI: Allow user to select the date range for date attribute in basic search
> --
>
> Key: ATLAS-3900
> URL: https://issues.apache.org/jira/browse/ATLAS-3900
> Project: Atlas
>  Issue Type: Sub-task
>  Components: atlas-webui
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
>  Labels: basic-search, datetimepicker
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3900-1.patch, ATLAS-3900-2.patch, 
> ATLAS-3900-3.patch, ATLAS-3900.patch, Screen Shot 2020-07-21 at 10.59.59 
> PM.png, Screen Shot 2020-07-21 at 11.00.08 PM.png, Screen Shot 2020-07-21 at 
> 11.00.15 PM.png
>
>
> In basic search attribute popup if the user selects the date type attribute 
> then UI should show a few quick search operator and custom range selection. 
> example:
> !Screen Shot 2020-07-21 at 10.59.59 PM.png|width=631,height=282!
>  
> !Screen Shot 2020-07-21 at 11.00.08 PM.png|width=630,height=302!
>  
> !Screen Shot 2020-07-21 at 11.00.15 PM.png|width=630,height=304!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3900) UI: Allow user to select the date range for date attribute in basic search

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177635#comment-17177635
 ] 

ASF subversion and git services commented on ATLAS-3900:


Commit 41eebcf4cf435d37c5e67aea916513eac36e3ee5 in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=41eebcf ]

ATLAS-3900: UI: Allow user to select the date range for date attribute in basic 
search


> UI: Allow user to select the date range for date attribute in basic search
> --
>
> Key: ATLAS-3900
> URL: https://issues.apache.org/jira/browse/ATLAS-3900
> Project: Atlas
>  Issue Type: Sub-task
>  Components: atlas-webui
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
>  Labels: basic-search, datetimepicker
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3900-1.patch, ATLAS-3900-2.patch, 
> ATLAS-3900-3.patch, ATLAS-3900.patch, Screen Shot 2020-07-21 at 10.59.59 
> PM.png, Screen Shot 2020-07-21 at 11.00.08 PM.png, Screen Shot 2020-07-21 at 
> 11.00.15 PM.png
>
>
> In basic search attribute popup if the user selects the date type attribute 
> then UI should show a few quick search operator and custom range selection. 
> example:
> !Screen Shot 2020-07-21 at 10.59.59 PM.png|width=631,height=282!
>  
> !Screen Shot 2020-07-21 at 11.00.08 PM.png|width=630,height=302!
>  
> !Screen Shot 2020-07-21 at 11.00.15 PM.png|width=630,height=304!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177633#comment-17177633
 ] 

ASF subversion and git services commented on ATLAS-3875:


Commit 83e9c21f7805b7badc9390a15fd747e1e6a7f8e2 in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from jyoti0208
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=83e9c21 ]

ATLAS-3875: updated sample client to improve logging

Signed-off-by: Madhan Neethiraj 


> Adding missing APIs in AtlasClient with test cases
> --
>
> Key: ATLAS-3875
> URL: https://issues.apache.org/jira/browse/ATLAS-3875
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Jyoti Singh
>Assignee: Jyoti Singh
>Priority: Major
>  Labels: api, client
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3875-1.patch, ATLAS-3875-2.patch, 
> ATLAS-3875-4.patch
>
>
> 1. There are many new APIs added to Atlas Project but the corresponding  APIs 
> are missing from AtlasClientv2. The aim of this task is to complete the gap 
> amongst existing APIs and their endpoints in Atls client. This will also 
> include adding test cases via integration testing.
> There are functions from AtlasClient for the following REST endpoints
>  * TypeRest
>  * EntityRest
>  * LineageRest
>  * DiscoveryRest
>  * GlossaryRest
>  * RelationshipRest
> 2. Added Sample-Project to showcase how to integrate with Atlas using 
> AtlasCleint. This helps the user to understand the basic rest functionality 
> of Atlas.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3878) Notifications: Improve Memory Usage in Scale Enviroment

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177629#comment-17177629
 ] 

ASF subversion and git services commented on ATLAS-3878:


Commit 4a57f92f649e389b8f5ef653394a5f091f1a36de in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from Ashutosh 
Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4a57f92 ]

ATLAS-3878: Notifications: Improve Memory Usage for HBase Audits Writing


> Notifications: Improve Memory Usage in Scale Enviroment
> ---
>
> Key: ATLAS-3878
> URL: https://issues.apache.org/jira/browse/ATLAS-3878
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3878-Notifications-Improve-Memory-Usage-in-Sca-v2.patch
>
>
> *Background*
> As part of entity creation, Atlas sends notifications of different types. 
> Current implementation, to listeners. Listeners in turn perform specific 
> tasks.
> At a more concrete level, the _EntityAuditListenerV2_ will write audits and 
> the _NotificationEntityChangeListener_ will send Kafka notifications.
> Each of the listeners create notification objects. The notification objects 
> are large in number and are short lived.
> The transient nature of the notification objects causes memory pressure in 
> scale environment.
> *Solution*
> Create object pool for notification objects. This way objects can be 
> reused.and existing design can be kept in tact. This will also offer benefit 
> of using existing test setup for verification.
> *Tests Used*
> _Setup_ 
> Create a test rig that will spawn multiple works that will invoke Atlas' bulk 
> APIs for entity creation.
> Node: 40 workers, 8 GB allocated memory and 40 cores.
> _Observation_
> About 40 mins into the exercise, memory pressure builds up causing GC 
> collects to take longer. This causes ZK timeout and finally Atlas process 
> crashes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3912) move classes to appropriate modules

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177631#comment-17177631
 ] 

ASF subversion and git services commented on ATLAS-3912:


Commit fb374763988d869fa8ce1b18bf4d438a64f4bb06 in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from Madhan 
Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=fb37476 ]

ATLAS-3912: moved classes from intg to repository or common module


> move classes to appropriate modules
> ---
>
> Key: ATLAS-3912
> URL: https://issues.apache.org/jira/browse/ATLAS-3912
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-intg
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3912.patch
>
>
> Classes that are unrelated to integration of Atlas clients should be moved 
> out of intg module, for example:
>  - org.apache.atlas.entitytransform
>  - org.apache.atlas.pc
>  - org.apache.atlas.listener
>  - org.apache.atlas.store
> Classes in these packages should be move to modules like repository or common.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3892) Basic search enhanced Feature - Search history

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3892:
---
Fix Version/s: 3.0.0

> Basic search enhanced Feature - Search history 
> ---
>
> Key: ATLAS-3892
> URL: https://issues.apache.org/jira/browse/ATLAS-3892
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> Feature to provide filters for better searching abilities : 
> Date Range feature with 6 different filters :
> 1.last 7 days.
> 2.Last month.
> 3.Last 30 days.
> 4.Today.
> 5.Yesterday.
> 6.Custom Range.
> 7.This Month.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177632#comment-17177632
 ] 

ASF subversion and git services commented on ATLAS-3875:


Commit b7255ec7e24f87da6f2dba47965a4e22e94c2250 in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from jyoti0208
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b7255ec ]

ATLAS-3875: adding sample client change

Signed-off-by: Madhan Neethiraj 


> Adding missing APIs in AtlasClient with test cases
> --
>
> Key: ATLAS-3875
> URL: https://issues.apache.org/jira/browse/ATLAS-3875
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Jyoti Singh
>Assignee: Jyoti Singh
>Priority: Major
>  Labels: api, client
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3875-1.patch, ATLAS-3875-2.patch, 
> ATLAS-3875-4.patch
>
>
> 1. There are many new APIs added to Atlas Project but the corresponding  APIs 
> are missing from AtlasClientv2. The aim of this task is to complete the gap 
> amongst existing APIs and their endpoints in Atls client. This will also 
> include adding test cases via integration testing.
> There are functions from AtlasClient for the following REST endpoints
>  * TypeRest
>  * EntityRest
>  * LineageRest
>  * DiscoveryRest
>  * GlossaryRest
>  * RelationshipRest
> 2. Added Sample-Project to showcase how to integrate with Atlas using 
> AtlasCleint. This helps the user to understand the basic rest functionality 
> of Atlas.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3904) Regression: Glossary term deatils page not able to render the classfication tab

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177627#comment-17177627
 ] 

ASF subversion and git services commented on ATLAS-3904:


Commit ce2ba123a2b9ce43503d5e101400b93fa5b6267e in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ce2ba12 ]

ATLAS-3904: Regression: Glossary term deatils page not able to render the 
classfication tab #2


> Regression: Glossary term deatils page not able to render the classfication 
> tab
> ---
>
> Key: ATLAS-3904
> URL: https://issues.apache.org/jira/browse/ATLAS-3904
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3904-1.patch, ATLAS-3904.patch, Screen Shot 
> 2020-07-28 at 5.09.08 PM.png
>
>
> Click on the term details page and check the console.
>  
> !Screen Shot 2020-07-28 at 5.09.08 PM.png|width=618,height=304!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3892) Basic search enhanced Feature - Search history

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177634#comment-17177634
 ] 

ASF subversion and git services commented on ATLAS-3892:


Commit 1b41b980415961419bb4af8710bd82f34395779c in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from chaitali 
borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=1b41b98 ]

ATLAS-3892 : Basic search enhanced Feature - Search history

Signed-off-by: kevalbhatt 


> Basic search enhanced Feature - Search history 
> ---
>
> Key: ATLAS-3892
> URL: https://issues.apache.org/jira/browse/ATLAS-3892
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> Feature to provide filters for better searching abilities : 
> Date Range feature with 6 different filters :
> 1.last 7 days.
> 2.Last month.
> 3.Last 30 days.
> 4.Today.
> 5.Yesterday.
> 6.Custom Range.
> 7.This Month.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3876) Relationship Search API not showing correct approximateCount

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177630#comment-17177630
 ] 

ASF subversion and git services commented on ATLAS-3876:


Commit aa441de4f62947b96f6ff387f4d140a2b83c99dc in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=aa441de ]

ATLAS-3876 : Relationship Search API not showing correct approximateCount

Signed-off-by: nixonrodrigues 


> Relationship Search API not showing correct approximateCount
> 
>
> Key: ATLAS-3876
> URL: https://issues.apache.org/jira/browse/ATLAS-3876
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: Relationships
> Fix For: 3.0.0
>
>
> Relationship Search API for hive columns showing *approximateCount* as -1 in 
> response.
>  E.g.
> {code:java}
> v2/search/relationship?limit=10=0=3e424245-0676-4d47-96a1-e17228b38367=__hive_table.columns=name=ASCENDING=true
> {code}
> *WorkAround:* 
> Added queryParam in REST api : *boolean getApproximateCount*
> To get approximate count, enable flag getApproximateCount = true



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3892) Basic search enhanced Feature - Search history

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3892:
---
Fix Version/s: 2.2.0

> Basic search enhanced Feature - Search history 
> ---
>
> Key: ATLAS-3892
> URL: https://issues.apache.org/jira/browse/ATLAS-3892
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Feature to provide filters for better searching abilities : 
> Date Range feature with 6 different filters :
> 1.last 7 days.
> 2.Last month.
> 3.Last 30 days.
> 4.Today.
> 5.Yesterday.
> 6.Custom Range.
> 7.This Month.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177628#comment-17177628
 ] 

ASF subversion and git services commented on ATLAS-3909:


Commit ba1b40f0426e5ff0e621eab5184d916a6f506f59 in atlas's branch 
refs/heads/dependabot/npm_and_yarn/dashboardv2/bootstrap-3.4.1 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ba1b40f ]

ATLAS-3909: UI: Improve readability for the table view in the entity detail page


> UI: Improve readability for the table view in the entity detail page 
> -
>
> Key: ATLAS-3909
> URL: https://issues.apache.org/jira/browse/ATLAS-3909
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, 
> image-2020-08-03-12-48-28-192.png
>
>
> Change the key style to bold for table view in the entity details page. 
>  
> !image-2020-08-03-12-48-10-984.png|width=508,height=311!
> *Expected:*
> !image-2020-08-03-12-48-28-192.png|width=541,height=341!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3892) Basic search enhanced Feature - Search history

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177625#comment-17177625
 ] 

ASF subversion and git services commented on ATLAS-3892:


Commit 1b41b980415961419bb4af8710bd82f34395779c in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=1b41b98 ]

ATLAS-3892 : Basic search enhanced Feature - Search history

Signed-off-by: kevalbhatt 


> Basic search enhanced Feature - Search history 
> ---
>
> Key: ATLAS-3892
> URL: https://issues.apache.org/jira/browse/ATLAS-3892
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> Feature to provide filters for better searching abilities : 
> Date Range feature with 6 different filters :
> 1.last 7 days.
> 2.Last month.
> 3.Last 30 days.
> 4.Today.
> 5.Yesterday.
> 6.Custom Range.
> 7.This Month.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3900) UI: Allow user to select the date range for date attribute in basic search

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177626#comment-17177626
 ] 

ASF subversion and git services commented on ATLAS-3900:


Commit 41eebcf4cf435d37c5e67aea916513eac36e3ee5 in atlas's branch 
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=41eebcf ]

ATLAS-3900: UI: Allow user to select the date range for date attribute in basic 
search


> UI: Allow user to select the date range for date attribute in basic search
> --
>
> Key: ATLAS-3900
> URL: https://issues.apache.org/jira/browse/ATLAS-3900
> Project: Atlas
>  Issue Type: Sub-task
>  Components: atlas-webui
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
>  Labels: basic-search, datetimepicker
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3900-1.patch, ATLAS-3900-2.patch, 
> ATLAS-3900-3.patch, ATLAS-3900.patch, Screen Shot 2020-07-21 at 10.59.59 
> PM.png, Screen Shot 2020-07-21 at 11.00.08 PM.png, Screen Shot 2020-07-21 at 
> 11.00.15 PM.png
>
>
> In basic search attribute popup if the user selects the date type attribute 
> then UI should show a few quick search operator and custom range selection. 
> example:
> !Screen Shot 2020-07-21 at 10.59.59 PM.png|width=631,height=282!
>  
> !Screen Shot 2020-07-21 at 11.00.08 PM.png|width=630,height=302!
>  
> !Screen Shot 2020-07-21 at 11.00.15 PM.png|width=630,height=304!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

[Jyoti Singh]

> On Aug. 11, 2020, 6:50 p.m., Sidharth Mishra wrote:
> > client/client-v2/src/main/python/atlas_client/discovery_model.py
> > Lines 22 (patched)
> > 
> >
> > Please remove one extra blank line (we always keep one blank line as 
> > separator if needed)

For Python classes we have to add 2 blank lines between imports and class name.
https://www.python.org/dev/peps/pep-0008/#blank-lines


- Jyoti


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/#review221546
---


On Aug. 10, 2020, 5:26 p.m., Jyoti Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72730/
> ---
> 
> (Updated Aug. 10, 2020, 5:26 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - Added basic structure for Python client
> - This includes all classes for Entity and TypeDef
> - Added all endpoints for typedef
> 
> 
> Diffs
> -
> 
>   atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION 
>   
> atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json 
> PRE-CREATION 
>   
> atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json
>  PRE-CREATION 
>   
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json
>  PRE-CREATION 
>   
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json
>  PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/typedef_create.json 
> PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION 
>   client/client-v2/src/main/python/LICENSE PRE-CREATION 
>   client/client-v2/src/main/python/README.md PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/discovery_client.py 
> PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/discovery_model.py 
> PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/glossary_client.py 
> PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/glossary_model.py 
> PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/lineage_client.py 
> PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/relationship_client.py 
> PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/relationship_model.py 
> PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/typedef_client.py 
> PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION 
>   client/client-v2/src/main/python/requirements.txt PRE-CREATION 
>   client/client-v2/src/main/python/setup.py PRE-CREATION 
>   client/client-v2/src/main/python/tests/__init__.py PRE-CREATION 
>   client/client-v2/src/main/resources/logging.conf PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72730/diff/4/
> 
> 
> Testing
> ---
> 
> Tested on local.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>