Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221069
---


Ship it!




Ship It!

- Sarath Subramanian


On June 24, 2020, 8:07 a.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> ---
> 
> (Updated June 24, 2020, 8:07 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
> https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add following ozone typeDefs to Atlas models
> 
> entityDefs:
> ozone_volume
> ozone_bucket
> ozone_key
> 
> enumDefs:
> ozone_storage_type
> ozone_replication_type
> 
> structDefs:
> ozone_key_location
> 
> relationshipDefs:
> ozone_volume_buckets
> ozone_bucket_keys
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221064
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 24, 2020, 3:07 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> ---
> 
> (Updated June 24, 2020, 3:07 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
> https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add following ozone typeDefs to Atlas models
> 
> entityDefs:
> ozone_volume
> ozone_bucket
> ozone_key
> 
> enumDefs:
> ozone_storage_type
> ozone_replication_type
> 
> structDefs:
> ozone_key_location
> 
> relationshipDefs:
> ozone_volume_buckets
> ozone_bucket_keys
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/
---

(Updated June 24, 2020, 3:07 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review Comments.


Bugs: ATLAS-3856
https://issues.apache.org/jira/browse/ATLAS-3856


Repository: atlas


Description (updated)
---

Add following ozone typeDefs to Atlas models

entityDefs:
ozone_volume
ozone_bucket
ozone_key

enumDefs:
ozone_storage_type
ozone_replication_type

structDefs:
ozone_key_location

relationshipDefs:
ozone_volume_buckets
ozone_bucket_keys


Diffs (updated)
-

  addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72614/diff/3/

Changes: https://reviews.apache.org/r/72614/diff/2-3/


Testing
---


Thanks,

Nikhil Bonte

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221061
---




addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 50 (patched)


keyLocation => ozone_key_location



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 136 (patched)


I suggest to set isIndexable=true for attribute ozone_bucket.storageType.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 177 (patched)


I suggest to set isIndexable=true for following attributes:
 - ozone_key.dataSize
 - ozone_key.replicationType
 - ozone_key.replicationFactor


- Madhan Neethiraj


On June 24, 2020, 2:07 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> ---
> 
> (Updated June 24, 2020, 2:07 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
> https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add following ozone typeDefs to Atlas models
> 
> entityDefs:
> Ozone volume
> Ozone bucket
> Ozone key
> 
> enumDefs:
> ozone_storage_type
> ozone_replication_type
> 
> structDefs:
> keyLocation
> 
> relationshipDefs:
> ozone_volume_buckets
> ozone_bucket_keys
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Nikhil Bonte]

> On June 24, 2020, 1:20 a.m., Sarath Subramanian wrote:
> > addons/models/3000-Cloud/3050-ozone-typedefs.json
> > Lines 15 (patched)
> > 
> >
> > "isOptional" is set to false for all attributes of "keyLocations". Can 
> > there be cases where you don't have all the information and only some.

I am not sure about this, in this case may I keep all attributes of 
"keyLocations" as "isOptional: true"?


- Nikhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221057
---


On June 24, 2020, 2:07 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> ---
> 
> (Updated June 24, 2020, 2:07 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
> https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add following ozone typeDefs to Atlas models
> 
> entityDefs:
> Ozone volume
> Ozone bucket
> Ozone key
> 
> enumDefs:
> ozone_storage_type
> ozone_replication_type
> 
> structDefs:
> keyLocation
> 
> relationshipDefs:
> ozone_volume_buckets
> ozone_bucket_keys
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Nikhil Bonte]

> On June 24, 2020, 1:20 a.m., Sarath Subramanian wrote:
> > addons/models/3000-Cloud/3050-ozone-typedefs.json
> > Lines 28 (patched)
> > 
> >
> > does "length" type needs to be of string type?

set as "long"


- Nikhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221057
---


On June 24, 2020, 2:07 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> ---
> 
> (Updated June 24, 2020, 2:07 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
> https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add following ozone typeDefs to Atlas models
> 
> entityDefs:
> Ozone volume
> Ozone bucket
> Ozone key
> 
> enumDefs:
> ozone_storage_type
> ozone_replication_type
> 
> structDefs:
> keyLocation
> 
> relationshipDefs:
> ozone_volume_buckets
> ozone_bucket_keys
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/
---

(Updated June 24, 2020, 2:07 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-3856
https://issues.apache.org/jira/browse/ATLAS-3856


Repository: atlas


Description (updated)
---

Add following ozone typeDefs to Atlas models

entityDefs:
Ozone volume
Ozone bucket
Ozone key

enumDefs:
ozone_storage_type
ozone_replication_type

structDefs:
keyLocation

relationshipDefs:
ozone_volume_buckets
ozone_bucket_keys


Diffs (updated)
-

  addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72614/diff/2/

Changes: https://reviews.apache.org/r/72614/diff/1-2/


Testing
---


Thanks,

Nikhil Bonte

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221057
---




addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 6 (patched)


"Atlas Type representing the locations for key" => "location information 
about Ozone key"



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 15 (patched)


"isOptional" is set to false for all attributes of "keyLocations". Can 
there be cases where you don't have all the information and only some.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 22 (patched)


consider setting "isIndexable" to true for all string, int and date type 
attributes. This will enable searching on this attributes using basic search.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 28 (patched)


does "length" type needs to be of string type?



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 49 (patched)


ozone => Ozone


- Sarath Subramanian


On June 22, 2020, 10:45 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> ---
> 
> (Updated June 22, 2020, 10:45 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
> https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add following ozone typeDefs to Atlas models
> 
> Ozone volume
> Ozone bucket
> Ozone key
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221055
---




addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 5 (patched)


If each instance of this struct represent one location, consider renaming 
keyLocations => keyLocation.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 88 (patched)


Consider using an enum for storageType - if the list of values is 
well-known in Ozone.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 96 (patched)


versioning => supportsVersioning/versioningEnabled



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 137 (patched)


Consider using an enum for replicationType - if the list of values is 
well-known in Ozone.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 169 (patched)


Given Atlas may not track all updates to Ozone objects, I suggest to not 
have 'modificationTime' attribute in the model.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 181 (patched)


ozone_volume_ozone_bucket => ozone_volume_buckets



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 185 (patched)


I suggest to not specify explicit 'relationshipLabel' here; this is 
necessary only for earlier version entity-types that didn't use relationships.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 188 (patched)


bucket => buckets



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 201 (patched)


ozone_bucket_ozone_key => ozone_bucket_keys



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 205 (patched)


I suggest to not specify explicit 'relationshipLabel' here; this is 
necessary only for earlier version entity-types that didn't use relationships.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 208 (patched)


key => keys


- Madhan Neethiraj


On June 23, 2020, 5:45 a.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> ---
> 
> (Updated June 23, 2020, 5:45 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
> https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add following ozone typeDefs to Atlas models
> 
> Ozone volume
> Ozone bucket
> Ozone key
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/
---

(Updated June 23, 2020, 5:45 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3856
https://issues.apache.org/jira/browse/ATLAS-3856


Repository: atlas


Description
---

Add following ozone typeDefs to Atlas models

Ozone volume
Ozone bucket
Ozone key


Diffs
-

  addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72614/diff/1/


Testing
---


Thanks,

Nikhil Bonte