Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

2016-06-20 Thread Shwetha GS 


> On June 20, 2016, 7:35 p.m., David Kantor wrote:
> > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java, 
> > line 124
> > 
> >
> > Why has the log level has been changed to INFO in several places 
> > throught EntityResource?  I would think that in a production Atlas 
> > environment this would generate a lot of log noise.  Shouldn't these remain 
> > at DEBUG?

I also changed info logs in GraphBackedMetadataRepository to debug. At the 
least, we should have API inputs and outputs, else we can't figure out whats 
happening. If these logs are not relevant for you, you can change the log level 
to warn in atlas-log4j.xml, anyway its configurable

We also need a way of refreshing log levels at runtime so that we can enable 
debug logs whenever required


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138663
---


On June 20, 2016, 12:01 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48945/
> ---
> 
> (Updated June 20, 2016, 12:01 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-819
> https://issues.apache.org/jira/browse/ATLAS-819
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added  base type with the attributes name, owner and description that any 
> type can extend and the users can set these attributes.
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java
>  c1ccd05 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  1621d95 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
>  37df6da 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  95f255e 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  81cd5e0 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
>  c92bd43 
>   
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
>  8a5736a 
>   
> addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 
> cf81406 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  c956a32 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 5d9950f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  3686fa8 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 5a175e7 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 9db8180 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  b2171c2 
>   
> addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
>  bae4c1a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 
>   distro/src/conf/atlas-log4j.xml e14afa3 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  dd7dd74 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  c385df3 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  d9e6cb9 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java
>  9dc93ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 0713d30 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
> 74d89ce 
> 
> Diff: https://reviews.apache.org/r/48945/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

2016-06-20 Thread David Kantor 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138663
---




webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java (line 
123)


Why has the log level has been changed to INFO in several places throught 
EntityResource?  I would think that in a production Atlas environment this 
would generate a lot of log noise.  Shouldn't these remain at DEBUG?



webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java (line 85)


See earlier comment about changing log level to INFO.


- David Kantor


On June 20, 2016, 12:01 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48945/
> ---
> 
> (Updated June 20, 2016, 12:01 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-819
> https://issues.apache.org/jira/browse/ATLAS-819
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added  base type with the attributes name, owner and description that any 
> type can extend and the users can set these attributes.
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java
>  c1ccd05 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  1621d95 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
>  37df6da 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  95f255e 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  81cd5e0 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
>  c92bd43 
>   
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
>  8a5736a 
>   
> addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 
> cf81406 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  c956a32 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 5d9950f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  3686fa8 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 5a175e7 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 9db8180 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  b2171c2 
>   
> addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
>  bae4c1a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 
>   distro/src/conf/atlas-log4j.xml e14afa3 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  dd7dd74 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  c385df3 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  d9e6cb9 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java
>  9dc93ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 0713d30 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
> 74d89ce 
> 
> Diff: https://reviews.apache.org/r/48945/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

2016-06-20 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138656
---


Ship it!




Ship It!

- Suma Shivaprasad


On June 20, 2016, 12:01 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48945/
> ---
> 
> (Updated June 20, 2016, 12:01 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-819
> https://issues.apache.org/jira/browse/ATLAS-819
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added  base type with the attributes name, owner and description that any 
> type can extend and the users can set these attributes.
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java
>  c1ccd05 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  1621d95 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
>  37df6da 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  95f255e 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  81cd5e0 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
>  c92bd43 
>   
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
>  8a5736a 
>   
> addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 
> cf81406 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  c956a32 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 5d9950f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  3686fa8 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 5a175e7 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 9db8180 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  b2171c2 
>   
> addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
>  bae4c1a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 
>   distro/src/conf/atlas-log4j.xml e14afa3 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  dd7dd74 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  c385df3 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  d9e6cb9 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java
>  9dc93ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 0713d30 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
> 74d89ce 
> 
> Diff: https://reviews.apache.org/r/48945/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

2016-06-20 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138658
---


Ship it!




Ship It!

- Suma Shivaprasad


On June 20, 2016, 12:01 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48945/
> ---
> 
> (Updated June 20, 2016, 12:01 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-819
> https://issues.apache.org/jira/browse/ATLAS-819
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added  base type with the attributes name, owner and description that any 
> type can extend and the users can set these attributes.
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java
>  c1ccd05 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  1621d95 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
>  37df6da 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  95f255e 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  81cd5e0 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
>  c92bd43 
>   
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
>  8a5736a 
>   
> addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 
> cf81406 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  c956a32 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 5d9950f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  3686fa8 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 5a175e7 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 9db8180 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  b2171c2 
>   
> addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
>  bae4c1a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 
>   distro/src/conf/atlas-log4j.xml e14afa3 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  dd7dd74 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  c385df3 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  d9e6cb9 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java
>  9dc93ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 0713d30 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
> 74d89ce 
> 
> Diff: https://reviews.apache.org/r/48945/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

2016-06-20 Thread Hemanth Yamijala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138589
---


Ship it!




The changes look ok to me. Please review model changes with Suma once before 
shipping.

- Hemanth Yamijala


On June 20, 2016, 12:01 p.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48945/
> ---
> 
> (Updated June 20, 2016, 12:01 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-819
> https://issues.apache.org/jira/browse/ATLAS-819
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added  base type with the attributes name, owner and description that any 
> type can extend and the users can set these attributes.
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java
>  c1ccd05 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  1621d95 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
>  37df6da 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  95f255e 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  81cd5e0 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
>  c92bd43 
>   
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
>  8a5736a 
>   
> addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 
> cf81406 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  c956a32 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 5d9950f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  3686fa8 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 5a175e7 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 9db8180 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  b2171c2 
>   
> addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
>  bae4c1a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 
>   distro/src/conf/atlas-log4j.xml e14afa3 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  dd7dd74 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  c385df3 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  d9e6cb9 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java
>  9dc93ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 0713d30 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
> 74d89ce 
> 
> Diff: https://reviews.apache.org/r/48945/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

2016-06-20 Thread Shwetha GS 


> On June 20, 2016, 10:19 a.m., Hemanth Yamijala wrote:
> > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java,
> >  line 107
> > 
> >
> > I didn't get why this was removed - possibly something specific to 
> > Falcon? Likewise, is the USER attribute going to be replaced by OWNER?

timestamp was set to current time and didn't have any other significance. 
Deleted it in favor of atlas system attributes created time and last modified 
time. user is deleted as owner is set now


> On June 20, 2016, 10:19 a.m., Hemanth Yamijala wrote:
> > addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala,
> >  line 51
> > 
> >
> > This is removed, but should extend Asset?

Have made fs_path extend dataset and hdfs_path extend fs_path. Will check with 
Suma once


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138569
---


On June 20, 2016, 9:01 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48945/
> ---
> 
> (Updated June 20, 2016, 9:01 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-819
> https://issues.apache.org/jira/browse/ATLAS-819
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added  base type with the attributes name, owner and description that any 
> type can extend and the users can set these attributes.
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java
>  c1ccd05 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  1621d95 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
>  37df6da 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  95f255e 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  81cd5e0 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
>  c92bd43 
>   
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
>  8a5736a 
>   
> addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 
> cf81406 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  c956a32 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 5d9950f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  3686fa8 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 5a175e7 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 9db8180 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  b2171c2 
>   
> addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
>  bae4c1a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 
>   distro/src/conf/atlas-log4j.xml e14afa3 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  dd7dd74 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  c385df3 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  d9e6cb9 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java
>  9dc93ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 0713d30 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
> 74d89ce 
> 
> Diff: https://reviews.apache.org/r/48945/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

2016-06-20 Thread Shwetha GS 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/
---

(Updated June 20, 2016, 12:01 p.m.)


Review request for atlas.


Changes
---

Addressed review comments


Bugs: ATLAS-819
https://issues.apache.org/jira/browse/ATLAS-819


Repository: atlas


Description
---

Added  base type with the attributes name, owner and description that any type 
can extend and the users can set these attributes.


Diffs (updated)
-

  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java 
c1ccd05 
  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
 1621d95 
  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
 37df6da 
  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 
95f255e 
  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
 81cd5e0 
  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
 c92bd43 
  
addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
 8a5736a 
  addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 
cf81406 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 c956a32 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
5d9950f 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 3686fa8 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
5a175e7 
  addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
9db8180 
  
addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
 c3bdbfa 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 b2171c2 
  
addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
 bae4c1a 
  client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 
  distro/src/conf/atlas-log4j.xml e14afa3 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 dd7dd74 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 c385df3 
  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
d9e6cb9 
  
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java
 9dc93ae 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
0713d30 
  webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
74d89ce 

Diff: https://reviews.apache.org/r/48945/diff/


Testing
---

UTs


Thanks,

Shwetha GS

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

2016-06-20 Thread Hemanth Yamijala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138569
---




addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
 


I didn't get why this was removed - possibly something specific to Falcon? 
Likewise, is the USER attribute going to be replaced by OWNER?



addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 


This is removed, but should extend Asset?



addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
 (line 48)


description is a part of Asset. So should go, just like owner?


- Hemanth Yamijala


On June 20, 2016, 9:01 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48945/
> ---
> 
> (Updated June 20, 2016, 9:01 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-819
> https://issues.apache.org/jira/browse/ATLAS-819
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added  base type with the attributes name, owner and description that any 
> type can extend and the users can set these attributes.
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java
>  c1ccd05 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  1621d95 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
>  37df6da 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  95f255e 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
>  81cd5e0 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
>  c92bd43 
>   
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
>  8a5736a 
>   
> addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala 
> cf81406 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  3686fa8 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
>  c3bdbfa 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  b2171c2 
>   
> addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
>  bae4c1a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 
>   distro/src/conf/atlas-log4j.xml e14afa3 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  dd7dd74 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  c385df3 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  d9e6cb9 
>   
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java
>  9dc93ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 0713d30 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
> 74d89ce 
> 
> Diff: https://reviews.apache.org/r/48945/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>