Re: Licensing problem (LGPL in codebase!!)

[Suraj Acharya]

As part of the release we do run the rat plugin.
So it is a highly unlikely this would have been run through a release.
However, changing it now is a great addition since the release manager has
to go through the whole license check for all of the files.
Also, as Sean mentioned anyone who has made any changes to the file after
the addition of the license will also need to be informed of the change to
the license.

Thanks

Suraj


On Thu, Dec 14, 2017 at 2:49 AM, Niels Basjes  wrote:

> Hi all,
>
> After we hear back from Thiru I would like Zoltan to fix these 4 files.
>
> lang/java/compiler/src/main/java/org/apache/avro/compiler/
> schema/SchemaVisitorAction.java
> lang/java/compiler/src/main/java/org/apache/avro/compiler/
> schema/SchemaVisitor.java
> lang/java/compiler/src/main/java/org/apache/avro/compiler/
> schema/Schemas.java
> lang/java/compiler/src/main/java/org/apache/avro/compiler/
> schema/CloningVisitor.java
>
> See: https://issues.apache.org/jira/browse/AVRO-2118
>
> After those have been fixed we can commit this change (guys, please review
> this. Thanks.)
> https://issues.apache.org/jira/browse/AVRO-2119
>
> Niels Basjes
>
>
> On Thu, Dec 14, 2017 at 11:11 AM, Niels Basjes  wrote:
>
> > Hi all,
> >
> > I had a closer look at the code base.
> >
> > Most important:
> > 1) I have found these files only in the master branch.
> > 2) I checked both release 1.8.2 and 1.7.7 and in these files are NOT
> > present in any of those releases. (
> > So we're ok on this part.
> >
> > I have found exactly 2 files with this problem:
> > ./lang/java/compiler/src/main/java/org/apache/avro/compiler/
> > schema/SchemaVisitorAction.java
> > ./lang/java/compiler/src/main/java/org/apache/avro/compiler/
> > schema/SchemaVisitor.java
> >
> > I have found 1 additional commit that touches these two files:
> >
> > https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f
> > 1b8df573c9
> >
> > commit 9132015450a2ad6f56cd582b393e8f1b8df573c9
> >> Author: Thiruvalluvan M G 
> >> AuthorDate: Sun Apr 30 21:02:02 2017 +0530
> >> Commit: Thiruvalluvan M G 
> >> CommitDate: Sun Apr 30 23:31:29 2017 +0530
> >> Added more tests and fixed a couple of bugs. Also formatted the code
> >
> >
> > In both these files the only changes are:
> > - Removing the author tag
> > - Whitespace changes.
> >
> > See:
> > https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f
> > 1b8df573c9#diff-d0adffb4097a1e43917fd5c3f2aae1ab
> > https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f
> > 1b8df573c9#diff-ced3f0d25217ef63c2f2ea09a8b60e92
> >
> > @Thiru: To be 100% sure: You agree with changing these two files to the
> > Apache license?
> >
> > Niels Basjes
> >
> >
> > On Wed, Dec 13, 2017 at 6:47 PM, Sean Busbey  wrote:
> >
> >> In addition to Zoltan we'll need to confirm anyone else who has modified
> >> the files.
> >>
> >> On Dec 13, 2017 11:46, "Sean Busbey"  wrote:
> >>
> >> > Have these files made it into a release?
> >> >
> >> > On Dec 13, 2017 10:18, "Niels Basjes"  wrote:
> >> >
> >> >> Zoltan,
> >> >>
> >> >> Because the copyright notice now says you own it I guess the best way
> >> to
> >> >> approach this is is when you put up a pull request with all those
> files
> >> >> files having a new license header.
> >> >> That way it is clear that you made the license switch. I think this
> >> should
> >> >> be a separate jira to document this clearly.
> >> >>
> >> >> What do you guys think about this approach?
> >> >>
> >> >> @Nandor / Gabor: I'll put up a ticket that we should run rat much
> more
> >> >> often (for both 1.8 and master). (i.e. no longer only in separate
> >> profile
> >> >> of maven)
> >> >>
> >> >> Niels Basjes
> >> >>
> >> >>
> >> >> On Wed, Dec 13, 2017 at 4:37 PM, Zoltan Farkas
> >> >>  >> >> > wrote:
> >> >>
> >> >> > Hi Niels, the license is a mistake made by me.
> >> >> > Those files were based from my work on spf4j-avro which is
> currently
> >> >> dual
> >> >> > licensed with LGPL and Apache .
> >> >> >
> >> >> > We should just replace the license headers with the appropriate
> >> Apache
> >> >> > header.
> >> >> > Let me know if you need me to do anything.
> >> >> >
> >> >> > Thank you
> >> >> >
> >> >> > --z
> >> >> >
> >> >> > > On Dec 13, 2017, at 8:14 AM, Niels Basjes 
> wrote:
> >> >> > >
> >> >> > > Hi all,
> >> >> > >
> >> >> > > I was going through the codebase and I found that several files
> are
> >> >> not
> >> >> > > Apache licensed.
> >> >> > >
> >> >> > > https://github.com/apache/avro/tree/master/lang/java/
> >> >> > compiler/src/main/java/org/apache/avro/compiler/schema
> >> >> > >
> >> >> > > Some of these files do not have a copyright block (fixable), yet
> >> some
> >> >> > have
> >> >> > > this:
> >> >> > >
> >> >> > > /*
> >> >> > >
> >> >> > > * Copyright 

[jira] [Commented] (AVRO-2115) Support @Union in members too

[Doug Cutting (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290950#comment-16290950
 ] 

Doug Cutting commented on AVRO-2115:


Yes, that should be fixed in the package documentation.

Also, please update the Union.java documentation, adding a sentence like, "A 
null schema may be specified with Void.class."

> Support @Union in members too
> -
>
> Key: AVRO-2115
> URL: https://issues.apache.org/jira/browse/AVRO-2115
> Project: Avro
>  Issue Type: Improvement
>Reporter: Miguel
>Priority: Minor
>
> Allow defining unions in members:
> {code:java}
> class MyDatum {
>@Nullable
>@Union({String.class, Long.class, Other.class,...})
>Object o;
> }
> {code}
> It can currently be implemented using @AvroSchema like this, but it is seems 
> in my oppinion more verbose and more difficult to maintain:
> {code:java}
> @AvroSchema("[\"null\",\"string\",...")
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (AVRO-2118) Rat tool fails over several files.

[Zoltan Farkas (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290829#comment-16290829
 ] 

Zoltan Farkas edited comment on AVRO-2118 at 12/14/17 1:39 PM:
---

created PR: https://github.com/apache/avro/pull/267


was (Author: zolyfarkas):
will create a PR, and add the details to this JIRA.

> Rat tool fails over several files.
> --
>
> Key: AVRO-2118
> URL: https://issues.apache.org/jira/browse/AVRO-2118
> Project: Avro
>  Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Zoltan Farkas
> Fix For: 1.9.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-2118) Rat tool fails over several files.

[Zoltan Farkas (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290829#comment-16290829
 ] 

Zoltan Farkas commented on AVRO-2118:
-

will create a PR, and add the details to this JIRA.

> Rat tool fails over several files.
> --
>
> Key: AVRO-2118
> URL: https://issues.apache.org/jira/browse/AVRO-2118
> Project: Avro
>  Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Zoltan Farkas
> Fix For: 1.9.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] avro pull request #266: Avro 2117 code cleanup

[nielsbasjes]

GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/266

Avro 2117 code cleanup

This is a massive set of changes to reduce the number of needless warnings 
in the (mostly Java) code base.
I have kept each type of change in a separate commit so we can cherry-pick 
if one or more are unwanted.

Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2117-CodeCleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #266


commit 6a2adc9403c8c70332d7fd988d203232be165792
Author: Niels Basjes 
Date:   2017-12-13T13:56:00Z

AVRO-2117: Cleanup Java - Fix spelling errors

commit 8f9ff6cdd39019621912ebba085227a86f870660
Author: Niels Basjes 
Date:   2017-12-13T14:24:49Z

AVRO-2117: Cleanup Java - Remove trailing spaces

commit 40df4ebee2d98a3f83276a5b22ce84b46d2c1843
Author: Niels Basjes 
Date:   2017-12-13T14:25:01Z

AVRO-2117: Cleanup C# - Remove trailing spaces

commit 723eb369485d3377b9da32a448fd0828fae47289
Author: Niels Basjes 
Date:   2017-12-13T14:48:24Z

AVRO-2117: Cleanup Java - Explicit types replaced with <>

commit 501e6f21ec2db7a975ed9ca243a2253d72d5085a
Author: Niels Basjes 
Date:   2017-12-13T14:54:13Z

AVRO-2117: Cleanup Java - Copyright block is reported as 'Dangling Javadoc'

commit 3d8791143dd4a0d2fa2a0ddd17138cc2711f01b5
Author: Niels Basjes 
Date:   2017-12-13T15:01:18Z

AVRO-2117: Cleanup Java - Remove unused imports

commit 2204c502997e836f1cea065ebe373e98197a200b
Author: Niels Basjes 
Date:   2017-12-13T16:03:34Z

AVRO-2117: Cleanup Java - Cleanup tests

commit fd43dafe106b1858b70973770fa42acba905d670
Author: Niels Basjes 
Date:   2017-12-14T09:56:21Z

AVRO-2117: Cleanup Java - Remove redundant type arguments




---

Re: Licensing problem (LGPL in codebase!!)

[Niels Basjes]

Hi all,

After we hear back from Thiru I would like Zoltan to fix these 4 files.

lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitorAction.java
lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitor.java
lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/Schemas.java
lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/CloningVisitor.java

See: https://issues.apache.org/jira/browse/AVRO-2118

After those have been fixed we can commit this change (guys, please review
this. Thanks.)
https://issues.apache.org/jira/browse/AVRO-2119

Niels Basjes


On Thu, Dec 14, 2017 at 11:11 AM, Niels Basjes  wrote:

> Hi all,
>
> I had a closer look at the code base.
>
> Most important:
> 1) I have found these files only in the master branch.
> 2) I checked both release 1.8.2 and 1.7.7 and in these files are NOT
> present in any of those releases. (
> So we're ok on this part.
>
> I have found exactly 2 files with this problem:
> ./lang/java/compiler/src/main/java/org/apache/avro/compiler/
> schema/SchemaVisitorAction.java
> ./lang/java/compiler/src/main/java/org/apache/avro/compiler/
> schema/SchemaVisitor.java
>
> I have found 1 additional commit that touches these two files:
>
> https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f
> 1b8df573c9
>
> commit 9132015450a2ad6f56cd582b393e8f1b8df573c9
>> Author: Thiruvalluvan M G 
>> AuthorDate: Sun Apr 30 21:02:02 2017 +0530
>> Commit: Thiruvalluvan M G 
>> CommitDate: Sun Apr 30 23:31:29 2017 +0530
>> Added more tests and fixed a couple of bugs. Also formatted the code
>
>
> In both these files the only changes are:
> - Removing the author tag
> - Whitespace changes.
>
> See:
> https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f
> 1b8df573c9#diff-d0adffb4097a1e43917fd5c3f2aae1ab
> https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f
> 1b8df573c9#diff-ced3f0d25217ef63c2f2ea09a8b60e92
>
> @Thiru: To be 100% sure: You agree with changing these two files to the
> Apache license?
>
> Niels Basjes
>
>
> On Wed, Dec 13, 2017 at 6:47 PM, Sean Busbey  wrote:
>
>> In addition to Zoltan we'll need to confirm anyone else who has modified
>> the files.
>>
>> On Dec 13, 2017 11:46, "Sean Busbey"  wrote:
>>
>> > Have these files made it into a release?
>> >
>> > On Dec 13, 2017 10:18, "Niels Basjes"  wrote:
>> >
>> >> Zoltan,
>> >>
>> >> Because the copyright notice now says you own it I guess the best way
>> to
>> >> approach this is is when you put up a pull request with all those files
>> >> files having a new license header.
>> >> That way it is clear that you made the license switch. I think this
>> should
>> >> be a separate jira to document this clearly.
>> >>
>> >> What do you guys think about this approach?
>> >>
>> >> @Nandor / Gabor: I'll put up a ticket that we should run rat much more
>> >> often (for both 1.8 and master). (i.e. no longer only in separate
>> profile
>> >> of maven)
>> >>
>> >> Niels Basjes
>> >>
>> >>
>> >> On Wed, Dec 13, 2017 at 4:37 PM, Zoltan Farkas
>> >> > >> > wrote:
>> >>
>> >> > Hi Niels, the license is a mistake made by me.
>> >> > Those files were based from my work on spf4j-avro which is currently
>> >> dual
>> >> > licensed with LGPL and Apache .
>> >> >
>> >> > We should just replace the license headers with the appropriate
>> Apache
>> >> > header.
>> >> > Let me know if you need me to do anything.
>> >> >
>> >> > Thank you
>> >> >
>> >> > --z
>> >> >
>> >> > > On Dec 13, 2017, at 8:14 AM, Niels Basjes  wrote:
>> >> > >
>> >> > > Hi all,
>> >> > >
>> >> > > I was going through the codebase and I found that several files are
>> >> not
>> >> > > Apache licensed.
>> >> > >
>> >> > > https://github.com/apache/avro/tree/master/lang/java/
>> >> > compiler/src/main/java/org/apache/avro/compiler/schema
>> >> > >
>> >> > > Some of these files do not have a copyright block (fixable), yet
>> some
>> >> > have
>> >> > > this:
>> >> > >
>> >> > > /*
>> >> > >
>> >> > > * Copyright (c) 2001 - 2016, Zoltan Farkas All Rights Reserved.
>> >> > > *
>> >> > > * This library is free software; you can redistribute it and/or
>> >> > > * modify it under the terms of the GNU Lesser General Public
>> >> > > * License as published by the Free Software Foundation; either
>> >> > > * version 2.1 of the License, or (at your option) any later
>> version.
>> >> > > *
>> >> > > * This library is distributed in the hope that it will be useful,
>> >> > > * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> >> > > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> >> > > * GNU General Public License for more details.
>> >> > > *
>> >> > > * You should have received a copy of the GNU Lesser General Public
>> >> > > * License along with this 

[jira] [Commented] (AVRO-2118) Rat tool fails over several files.

[Niels Basjes (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290705#comment-16290705
 ] 

Niels Basjes commented on AVRO-2118:


[~zolyfarkas]: These are the 4 remaining files
  
lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitorAction.java
  
lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitor.java
  lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/Schemas.java
  
lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/CloningVisitor.java



> Rat tool fails over several files.
> --
>
> Key: AVRO-2118
> URL: https://issues.apache.org/jira/browse/AVRO-2118
> Project: Avro
>  Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Zoltan Farkas
> Fix For: 1.9.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (AVRO-2118) Rat tool fails over several files.

[Niels Basjes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niels Basjes reassigned AVRO-2118:
--

Assignee: Zoltan Farkas  (was: Niels Basjes)

> Rat tool fails over several files.
> --
>
> Key: AVRO-2118
> URL: https://issues.apache.org/jira/browse/AVRO-2118
> Project: Avro
>  Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Zoltan Farkas
> Fix For: 1.9.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-2119) Run rat tool as part of the regular (java) build.

[Niels Basjes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niels Basjes updated AVRO-2119:
---
Fix Version/s: 1.8.3
   1.9.0

> Run rat tool as part of the regular (java) build.
> -
>
> Key: AVRO-2119
> URL: https://issues.apache.org/jira/browse/AVRO-2119
> Project: Avro
>  Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Fix For: 1.9.0, 1.8.3
>
>
> On a regular basis files get in that do not meet the licensing requirements.
> The root casue seems to be that in order to do the check you need to run the 
> Apache Rat too manually (which many forget).
> This must be dome much more often.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-2119) Run Apache Rat check on every java build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290695#comment-16290695
 ] 

ASF GitHub Bot commented on AVRO-2119:
--

GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/265

AVRO-2119: Run Apache Rat check on every java build

This simply forces Apache Rat to run on every Java build.
Must be committed to branch-1.7 branch-1.8 and master.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2119-Run-rat-always

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit 8c2d37c912610cff49101aab6bff02425ed50c3a
Author: Niels Basjes 
Date:   2017-12-14T10:27:55Z

AVRO-2119: Run Apache Rat check on every java build




> Run Apache Rat check on every java build
> 
>
> Key: AVRO-2119
> URL: https://issues.apache.org/jira/browse/AVRO-2119
> Project: Avro
>  Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Fix For: 1.9.0, 1.8.3
>
>
> On a regular basis files get in that do not meet the licensing requirements.
> The root casue seems to be that in order to do the check you need to run the 
> Apache Rat too manually (which many forget).
> This must be dome much more often.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] avro pull request #265: AVRO-2119: Run Apache Rat check on every java build

[nielsbasjes]

GitHub user nielsbasjes opened a pull request:

https://github.com/apache/avro/pull/265

AVRO-2119: Run Apache Rat check on every java build

This simply forces Apache Rat to run on every Java build.
Must be committed to branch-1.7 branch-1.8 and master.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nielsbasjes/avro AVRO-2119-Run-rat-always

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit 8c2d37c912610cff49101aab6bff02425ed50c3a
Author: Niels Basjes 
Date:   2017-12-14T10:27:55Z

AVRO-2119: Run Apache Rat check on every java build




---

[jira] [Updated] (AVRO-2118) Rat tool fails over several files.

[Niels Basjes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niels Basjes updated AVRO-2118:
---
Fix Version/s: (was: 1.8.3)

> Rat tool fails over several files.
> --
>
> Key: AVRO-2118
> URL: https://issues.apache.org/jira/browse/AVRO-2118
> Project: Avro
>  Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Fix For: 1.9.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-2119) Run Apache Rat check on every java build

[Niels Basjes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niels Basjes updated AVRO-2119:
---
Summary: Run Apache Rat check on every java build  (was: Run rat tool as 
part of the regular (java) build.)

> Run Apache Rat check on every java build
> 
>
> Key: AVRO-2119
> URL: https://issues.apache.org/jira/browse/AVRO-2119
> Project: Avro
>  Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Fix For: 1.9.0, 1.8.3
>
>
> On a regular basis files get in that do not meet the licensing requirements.
> The root casue seems to be that in order to do the check you need to run the 
> Apache Rat too manually (which many forget).
> This must be dome much more often.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-2118) Rat tool fails over several files.

[Niels Basjes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niels Basjes updated AVRO-2118:
---
Fix Version/s: 1.8.3
   1.9.0

> Rat tool fails over several files.
> --
>
> Key: AVRO-2118
> URL: https://issues.apache.org/jira/browse/AVRO-2118
> Project: Avro
>  Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Fix For: 1.9.0, 1.8.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (AVRO-2119) Run rat tool as part of the regular (java) build.

[Niels Basjes (JIRA)]

Niels Basjes created AVRO-2119:
--

 Summary: Run rat tool as part of the regular (java) build.
 Key: AVRO-2119
 URL: https://issues.apache.org/jira/browse/AVRO-2119
 Project: Avro
  Issue Type: Improvement
Reporter: Niels Basjes
Assignee: Niels Basjes


On a regular basis files get in that do not meet the licensing requirements.
The root casue seems to be that in order to do the check you need to run the 
Apache Rat too manually (which many forget).

This must be dome much more often.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Licensing problem (LGPL in codebase!!)

[Niels Basjes]

Hi all,

I had a closer look at the code base.

Most important:
1) I have found these files only in the master branch.
2) I checked both release 1.8.2 and 1.7.7 and in these files are NOT
present in any of those releases. (
So we're ok on this part.

I have found exactly 2 files with this problem:
./lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitorAction.java
./lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitor.java

I have found 1 additional commit that touches these two files:

https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f1b8df573c9

commit 9132015450a2ad6f56cd582b393e8f1b8df573c9
> Author: Thiruvalluvan M G 
> AuthorDate: Sun Apr 30 21:02:02 2017 +0530
> Commit: Thiruvalluvan M G 
> CommitDate: Sun Apr 30 23:31:29 2017 +0530
> Added more tests and fixed a couple of bugs. Also formatted the code


In both these files the only changes are:
- Removing the author tag
- Whitespace changes.

See:
https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f1b8df573c9#diff-d0adffb4097a1e43917fd5c3f2aae1ab
https://github.com/apache/avro/commit/9132015450a2ad6f56cd582b393e8f1b8df573c9#diff-ced3f0d25217ef63c2f2ea09a8b60e92

@Thiru: To be 100% sure: You agree with changing these two files to the
Apache license?

Niels Basjes


On Wed, Dec 13, 2017 at 6:47 PM, Sean Busbey  wrote:

> In addition to Zoltan we'll need to confirm anyone else who has modified
> the files.
>
> On Dec 13, 2017 11:46, "Sean Busbey"  wrote:
>
> > Have these files made it into a release?
> >
> > On Dec 13, 2017 10:18, "Niels Basjes"  wrote:
> >
> >> Zoltan,
> >>
> >> Because the copyright notice now says you own it I guess the best way to
> >> approach this is is when you put up a pull request with all those files
> >> files having a new license header.
> >> That way it is clear that you made the license switch. I think this
> should
> >> be a separate jira to document this clearly.
> >>
> >> What do you guys think about this approach?
> >>
> >> @Nandor / Gabor: I'll put up a ticket that we should run rat much more
> >> often (for both 1.8 and master). (i.e. no longer only in separate
> profile
> >> of maven)
> >>
> >> Niels Basjes
> >>
> >>
> >> On Wed, Dec 13, 2017 at 4:37 PM, Zoltan Farkas
> >>  >> > wrote:
> >>
> >> > Hi Niels, the license is a mistake made by me.
> >> > Those files were based from my work on spf4j-avro which is currently
> >> dual
> >> > licensed with LGPL and Apache .
> >> >
> >> > We should just replace the license headers with the appropriate Apache
> >> > header.
> >> > Let me know if you need me to do anything.
> >> >
> >> > Thank you
> >> >
> >> > --z
> >> >
> >> > > On Dec 13, 2017, at 8:14 AM, Niels Basjes  wrote:
> >> > >
> >> > > Hi all,
> >> > >
> >> > > I was going through the codebase and I found that several files are
> >> not
> >> > > Apache licensed.
> >> > >
> >> > > https://github.com/apache/avro/tree/master/lang/java/
> >> > compiler/src/main/java/org/apache/avro/compiler/schema
> >> > >
> >> > > Some of these files do not have a copyright block (fixable), yet
> some
> >> > have
> >> > > this:
> >> > >
> >> > > /*
> >> > >
> >> > > * Copyright (c) 2001 - 2016, Zoltan Farkas All Rights Reserved.
> >> > > *
> >> > > * This library is free software; you can redistribute it and/or
> >> > > * modify it under the terms of the GNU Lesser General Public
> >> > > * License as published by the Free Software Foundation; either
> >> > > * version 2.1 of the License, or (at your option) any later version.
> >> > > *
> >> > > * This library is distributed in the hope that it will be useful,
> >> > > * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> > > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >> > > * GNU General Public License for more details.
> >> > > *
> >> > > * You should have received a copy of the GNU Lesser General Public
> >> > > * License along with this program; if not, write to the Free
> Software
> >> > > * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
> >> 02111-1307,
> >> > USA.
> >> > > */
> >> > >
> >> > > And according to https://www.apache.org/legal/r
> >> esolved.html#category-x
> >> > the
> >> > > LGPL is not allowed to be included.
> >> > >
> >> > > How do we fix this problem?
> >> > >
> >> > > --
> >> > > Best regards / Met vriendelijke groeten,
> >> > >
> >> > > Niels Basjes
> >> >
> >> >
> >>
> >>
> >> --
> >> Best regards / Met vriendelijke groeten,
> >>
> >> Niels Basjes
> >>
> >
>



-- 
Best regards / Met vriendelijke groeten,

Niels Basjes

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

[Miguel (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290624#comment-16290624
 ] 

Miguel edited comment on AVRO-2115 at 12/14/17 9:47 AM:


Good! Added Void to the test. 

I have seen that 
[documentation|https://avro.apache.org/docs/1.7.6/api/java/org/apache/avro/reflect/package-summary.html]
 may be wrong. It says that: 
Classes are mapped to Avro records. Only concrete classes with a no-argument 
constructor are supported. All inherited fields that are not static or 
transient are used. Fields are not permitted to be null unless annotated by 
Nullable or *a Union containing null.*

Maybe should it be:
*... a Union containing Void.*

If you agree I add to the patch.



was (Author: elmendavies):
Good! Added Void to the test. 

I have seen that 
[documentation|https://avro.apache.org/docs/1.7.6/api/java/org/apache/avro/reflect/package-summary.html]
 may be wrong. It says that: 
"Classes are mapped to Avro records. Only concrete classes with a no-argument 
constructor are supported. All inherited fields that are not static or 
transient are used. Fields are not permitted to be null unless annotated by 
Nullable or* a Union containing null.*"

Maybe should it be:
*"... a Union containing Void."*

If you agree I add to the patch.


> Support @Union in members too
> -
>
> Key: AVRO-2115
> URL: https://issues.apache.org/jira/browse/AVRO-2115
> Project: Avro
>  Issue Type: Improvement
>Reporter: Miguel
>Priority: Minor
>
> Allow defining unions in members:
> {code:java}
> class MyDatum {
>@Nullable
>@Union({String.class, Long.class, Other.class,...})
>Object o;
> }
> {code}
> It can currently be implemented using @AvroSchema like this, but it is seems 
> in my oppinion more verbose and more difficult to maintain:
> {code:java}
> @AvroSchema("[\"null\",\"string\",...")
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-2115) Support @Union in members too

[Miguel (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290624#comment-16290624
 ] 

Miguel commented on AVRO-2115:
--

Good! Added Void to the test. 

I have seen that 
[documentation|https://avro.apache.org/docs/1.7.6/api/java/org/apache/avro/reflect/package-summary.html]
 may be wrong. It says that: 
"Classes are mapped to Avro records. Only concrete classes with a no-argument 
constructor are supported. All inherited fields that are not static or 
transient are used. Fields are not permitted to be null unless annotated by 
Nullable or* a Union containing null.*"

Maybe should it be:
"...* a Union containing Void.*"

If you agree I add to the patch.


> Support @Union in members too
> -
>
> Key: AVRO-2115
> URL: https://issues.apache.org/jira/browse/AVRO-2115
> Project: Avro
>  Issue Type: Improvement
>Reporter: Miguel
>Priority: Minor
>
> Allow defining unions in members:
> {code:java}
> class MyDatum {
>@Nullable
>@Union({String.class, Long.class, Other.class,...})
>Object o;
> }
> {code}
> It can currently be implemented using @AvroSchema like this, but it is seems 
> in my oppinion more verbose and more difficult to maintain:
> {code:java}
> @AvroSchema("[\"null\",\"string\",...")
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)