[PR] Bump @babel/traverse from 7.17.9 to 7.23.2 in /lang/js [avro]

[via GitHub]

dependabot[bot] opened a new pull request, #2559:
URL: https://github.com/apache/avro/pull/2559

   Bumps 
[@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse)
 from 7.17.9 to 7.23.2.
   
   Release notes
   Sourced from https://github.com/babel/babel/releases;>@​babel/traverse's 
releases.
   
   v7.23.2 (2023-10-11)
   NOTE: This release also re-publishes 
@babel/core, even if it does not appear in the linked release 
commit.
   Thanks https://github.com/jimmydief;>@​jimmydief for your first 
PR!
   :bug: Bug Fix
   
   babel-traverse
   
   https://redirect.github.com/babel/babel/pull/16033;>#16033 
Only evaluate own String/Number/Math methods (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   
   
   babel-preset-typescript
   
   https://redirect.github.com/babel/babel/pull/16022;>#16022 
Rewrite .tsx extension when using 
rewriteImportExtensions (https://github.com/jimmydief;>@​jimmydief)
   
   
   babel-helpers
   
   https://redirect.github.com/babel/babel/pull/16017;>#16017 
Fix: fallback to typeof when toString is applied to incompatible object (https://github.com/JLHwung;>@​JLHwung)
   
   
   babel-helpers, 
babel-plugin-transform-modules-commonjs, 
babel-runtime-corejs2, babel-runtime-corejs3, 
babel-runtime
   
   https://redirect.github.com/babel/babel/pull/16025;>#16025 
Avoid override mistake in namespace imports (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   
   
   
   Committers: 5
   
   Babel Bot (https://github.com/babel-bot;>@​babel-bot)
   Huáng Jùnliàng (https://github.com/JLHwung;>@​JLHwung)
   James Diefenderfer (https://github.com/jimmydief;>@​jimmydief)
   Nicolò Ribaudo (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   https://github.com/liuxingbaoyu;>@​liuxingbaoyu
   
   v7.23.1 (2023-09-25)
   Re-publishing @babel/helpers due to a publishing error in 
7.23.0.
   v7.23.0 (2023-09-25)
   Thanks https://github.com/lorenzoferre;>@​lorenzoferre and https://github.com/RajShukla1;>@​RajShukla1 for your 
first PRs!
   :rocket: New Feature
   
   babel-plugin-proposal-import-wasm-source, 
babel-plugin-syntax-import-source, 
babel-plugin-transform-dynamic-import
   
   https://redirect.github.com/babel/babel/pull/15870;>#15870 
Support transforming import source for wasm (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   
   
   babel-helper-module-transforms, babel-helpers, 
babel-plugin-proposal-import-defer, 
babel-plugin-syntax-import-defer, 
babel-plugin-transform-modules-commonjs, 
babel-runtime-corejs2, babel-runtime-corejs3, 
babel-runtime, babel-standalone
   
   https://redirect.github.com/babel/babel/pull/15878;>#15878 
Implement import defer proposal transform support (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   
   
   babel-generator, babel-parser, 
babel-types
   
   https://redirect.github.com/babel/babel/pull/15845;>#15845 
Implement import defer parsing support (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   https://redirect.github.com/babel/babel/pull/15829;>#15829 
Add parsing support for the source phase imports proposal (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   
   
   babel-generator, 
babel-helper-module-transforms, babel-parser, 
babel-plugin-transform-dynamic-import, 
babel-plugin-transform-modules-amd, 
babel-plugin-transform-modules-commonjs, 
babel-plugin-transform-modules-systemjs, 
babel-traverse, babel-types
   
   https://redirect.github.com/babel/babel/pull/15682;>#15682 
Add createImportExpressions parser option (https://github.com/JLHwung;>@​JLHwung)
   
   
   babel-standalone
   
   https://redirect.github.com/babel/babel/pull/15671;>#15671 
Pass through nonce to the transformed script element (https://github.com/JLHwung;>@​JLHwung)
   
   
   babel-helper-function-name, 
babel-helper-member-expression-to-functions, 
babel-helpers, babel-parser, 
babel-plugin-proposal-destructuring-private, 
babel-plugin-proposal-optional-chaining-assign, 
babel-plugin-syntax-optional-chaining-assign, 
babel-plugin-transform-destructuring, 
babel-plugin-transform-optional-chaining, 
babel-runtime-corejs2, babel-runtime-corejs3, 
babel-runtime, babel-standalone, 
babel-types
   
   https://redirect.github.com/babel/babel/pull/15751;>#15751 
Add support for optional chain in assignments (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   
   
   babel-helpers, babel-plugin-proposal-decorators
   
   https://redirect.github.com/babel/babel/pull/15895;>#15895 
Implement the decorator metadata proposal (https://github.com/nicolo-ribaudo;>@​nicolo-ribaudo)
   
   
   babel-traverse, babel-types
   
   https://redirect.github.com/babel/babel/pull/15893;>#15893 
Add t.buildUndefinedNode (https://github.com/liuxingbaoyu;>@​liuxingbaoyu)
   
   
   babel-preset-typescript
   
   
   
   ... (truncated)
   
   
   Changelog
   Sourced from https://github.com/babel/babel/blob/main/CHANGELOG.md;>@​babel/traverse's
 changelog.
   
   v7.23.2 (2023-10-11)
   :bug: Bug Fix
  

PR 2544 Deserialization for Java reserved words

[Stephen Kittelson]

I opened PR https://github.com/apache/avro/pull/2544 to resolve Jira issue
https://issues.apache.org/jira/browse/AVRO-2956 in which Avro tools for
Java correctly generates the code for a schema by appending dollar signs to
the end of Java reserved words to prevent compilation errors, but the
current deserialization code does not look for classes with names ending in
'$' for the reserved words. Upon deserialization, the generated classes are
not found and the generic records are used instead, thus negating the
benefit of using the generated code. My PR will resolve this issue and
deserialization will find the classes and use the generated code as
intended.

If there are any issues with the PR or my approach to solve the problem,
please let me know.

Thanks,
Stephen Kittelson

[PR] AVRO-3887: [Java] Remove redundant casts in BinaryDecoder [avro]

[via GitHub]

Fokko opened a new pull request, #2558:
URL: https://github.com/apache/avro/pull/2558

   
   
   ## What is the purpose of the change
   
   Makes the code look nicer
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (AVRO-3887) Remove redundant casts

[Fokko Driesprong (Jira)]

Fokko Driesprong created AVRO-3887:
--

 Summary: Remove redundant casts
 Key: AVRO-3887
 URL: https://issues.apache.org/jira/browse/AVRO-3887
 Project: Apache Avro
  Issue Type: Improvement
Affects Versions: 1.11.3
Reporter: Fokko Driesprong
Assignee: Fokko Driesprong
 Fix For: 1.12.0


Removes redundant casts to improve the readability of the code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] New Avro logo (final)

[Oscar Westra van Holthe - Kind]

Hi all,

The results yesterday show that V9.2 is perceived as better than V11.2,
despite being angled downward. This is, I believe, because the angle of
V11.2 hides the underside: this makes the plane look incomplete.

My vote is for V9.2 if changed to fly upward, V3.1 otherwise.


Kind regards,
Oscar



On Mon, 16 Oct 2023 at 21:46, Emma K  wrote:

> Hi all,
>
> Thank you for your kind words throughout the process and vote! I wanted to
> refrain from jumping in earlier lest I accidentally influenced the initial
> vote in any way!
>
> Just wanted to hop in now and give my thoughts on the suggestions Ryan
> received at the Community Over Code conference and Oscar's suggestion of
> another possible upwards variant.
>
> I'll start with Oscar's suggestion first, which also ties into the first
> point of advice Ryan received from the marketing and publicity office. If
> we'd like to follow ASF's marketing team's intuition that the upward design
> of 11.2 is better than the downward design of 9.2 I think that's valid and
> makes sense! If this is the case, then I would suggest we use the 11.2
> design rather than the 9.2 design, and I can make some slight adjustments
> to the angle of the plane as we see fit. I'll add that I am a little more
> hesitant about this approach only because the 11.2 design did not beat out
> or tie with the votes of design 9.2 in the first round of voting, and
> ultimately I would like the final logo to be something that the community
> as a whole loves and agrees upon!
>
> The next suggestion Ryan received was based on the PT Mono font being a
> little strange for the word 'Avro' as the r is the only serifed letter.
> This is something I didn't notice before but they are right! I actually
> already have five other fonts on the backburner that I tried when I was
> drafting the original design versions but I personally liked the PT Mono
> font the best so gave that as the only option (which in hindsight might not
> have been the best choice). What I can do is once the final icon is chosen
> as the winner (either the plane or the pigeon) I can draft up a few more
> versions with the alternate font choices and we can decide if one of the
> other fonts will work better in the long run.
>
> Finally, in terms of the last suggestion from the marketing and publicity
> office of having the word Avro in the plane's dark blue, I have to
> respectfully disagree with this assessment. The area of dark blue in the
> plane icons is so small that even at large sizes it would be difficult to
> read 'Avro' if it was there, and at small sizes, it would be impossible to
> parse. Based on what I was taught when studying graphic design, icons for
> logos should be memorable and have the simplest possible design to convey
> the desired image. As an example of this, think of Apple's logo, which is a
> simplistic apple icon with a chunk missing. I would posit that if Apple
> wrote 'Apple' on their icon, it wouldn't be nearly as effective.
>
> That's my 2¢ anyways! I'm happy to make more adjustments to the fonts and
> the angles of the icons as we see fit, and I'm so excited to see which
> design will be the final winner in the end! :D
>
> All my best,
>
> Emma
>
> On Mon, Oct 16, 2023 at 12:33 PM Oscar Westra van Holthe - Kind <
> os...@westravanholthe.nl> wrote:
>
> > Hi all,
> >
> > The results are in: with 6 binding votes (all cast within 6 hours), and
> no
> > non-binding votes, it's a near-tie between V9.2 and V3.1.
> >
> > These are the votes:
> >
> >- V9.2: 3 votes
> >- V10.2: 1 vote
> >- V11.2: 0 votes
> >- V3.1: 2 votes (I changed the vote for V6.1, as the V3.1 variant was
> >part of the vote)
> >
> >
> > What's next: one week to vote by simple majority between V9.2 and V3.1.
> > (given our quick votes last time, it's probably more than enough)
> >
> > Then, if we choose for V9.2, perhaps Emma can also create a good version
> > flying
> > slightly upward
> > <
> >
> https://clipart-library.com/newhp/31-316437_transparent-airplane-clipart-paper-airplane-clipart-png-png.png
> > >
> > instead
> > of steeply like V11.2. I think we can leave it up to her good judgement
> to
> > determine if that's really an improvement.
> >
> >
> > So, which do you like more: the plane V9.2, or the pigeon V3.1?
> >
> >
> > Kind regards,
> > Oscar
> >
> >
> > On Mon, 9 Oct 2023 at 22:54, Ryan Skraba  wrote:
> >
> > > Hello! I don't want to derail the conversation or vote, but I had the
> > > opportunity to attend the marketing and publicity office hours during
> the
> > > community over Code conference. They had some pretty specific
> suggestions
> > > (but not requirements of course). I'm on my phone but I just want to
> > > capture them here!
> > >
> > > 1. Plane going up is better than down!
> > > 2. PT Mono is peculiar for our specific word because the r has serifs
> and
> > > the others don't.
> > > 3. If we use the arrow, it would look great to have the word Avro in
> the
> > > plane's dark blue!

[PR] AVRO-3886: Serialize attribute in schema to support custom logical type [avro]

[via GitHub]

ZENOTME opened a new pull request, #2557:
URL: https://github.com/apache/avro/pull/2557

   
   
   ## What is the purpose of the change
   
   *(For example: This pull request improves file read performance by buffering 
data, fixing AVRO-.)*
   
   
   ## Verifying this change
   
   *(Please pick one of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   - *Extended interop tests to verify consistent valid schema names between 
SDKs*
   - *Added test that validates that Java throws an AvroRuntimeException on 
invalid binary data*
   - *Manually verified the change by building the website and checking the new 
redirect*
   
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / 
not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] New Avro logo (final)

[Martin Grigorov]

On Mon, Oct 16, 2023 at 7:33 PM Oscar Westra van Holthe - Kind <
os...@westravanholthe.nl> wrote:

> Hi all,
>
> The results are in: with 6 binding votes (all cast within 6 hours), and no
> non-binding votes, it's a near-tie between V9.2 and V3.1.
>
> These are the votes:
>
>- V9.2: 3 votes
>- V10.2: 1 vote
>- V11.2: 0 votes
>- V3.1: 2 votes (I changed the vote for V6.1, as the V3.1 variant was
>part of the vote)
>
>
> What's next: one week to vote by simple majority between V9.2 and V3.1.
>

+1 for v9.2 (as of current design or if changed to go up).



> (given our quick votes last time, it's probably more than enough)
>
> Then, if we choose for V9.2, perhaps Emma can also create a good version
> flying
> slightly upward
> <
> https://clipart-library.com/newhp/31-316437_transparent-airplane-clipart-paper-airplane-clipart-png-png.png
> >
> instead
> of steeply like V11.2. I think we can leave it up to her good judgement to
> determine if that's really an improvement.
>
>
> So, which do you like more: the plane V9.2, or the pigeon V3.1?
>
>
> Kind regards,
> Oscar
>
>
> On Mon, 9 Oct 2023 at 22:54, Ryan Skraba  wrote:
>
> > Hello! I don't want to derail the conversation or vote, but I had the
> > opportunity to attend the marketing and publicity office hours during the
> > community over Code conference. They had some pretty specific suggestions
> > (but not requirements of course). I'm on my phone but I just want to
> > capture them here!
> >
> > 1. Plane going up is better than down!
> > 2. PT Mono is peculiar for our specific word because the r has serifs and
> > the others don't.
> > 3. If we use the arrow, it would look great to have the word Avro in the
> > plane's dark blue!
> >
> > It was a neat conversation and they said some really nice things about
> the
> > initiative!
> >
> > If we do anything about 2 or 3, we can talk about any adjustments after
> the
> > vote. To be honest, I'm 100% confident with these current logos and
> leaving
> > any changes to Emma's discretion!
> >
> > All my bets Ryan
> >
> > On Mon, Oct 2, 2023, 13:08 Ryan Blue  wrote:
> >
> > > My vote is for 10.2.
> > >
> > > On Mon, Oct 2, 2023 at 9:02 AM Oscar Westra van Holthe - Kind <
> > > os...@westravanholthe.nl> wrote:
> > >
> > > > Hi all,
> > > >
> > > > Since the start, I've been a fan of the pigeon. It looks good, and
> it's
> > > > very distinctive.
> > > >
> > > > And it's completely different from any send icon, so it cannot be
> > > conflated
> > > > with a message protocol icon.
> > > >
> > > > My vote is for V3.1
> > > >
> > > >
> > > > Kind regards,
> > > > Oscar
> > > >
> > > > --
> > > > ✉️ Oscar Westra van Holthe - Kind 
> > > >  https://github.com/opwvhk/
> > > >
> > > > Op ma 2 okt. 2023 16:47 schreef Ryan Skraba :
> > > >
> > > > > I can't stop changing my mind, but I'm going to go with V9.2 -- I
> > > > > really like the pigeon too, but I think the paper plane fits too
> > > > > nicely to pass up!
> > > > >
> > > > > Excellent work, Emma, and thanks Oscar for calling the vote. I
> think
> > > > > your voting proposal makes sense!
> > > > >
> > > > > Ryan
> > > > >
> > > > >
> > > > > On Mon, Oct 2, 2023 at 3:59 PM Ismaël Mejía 
> > wrote:
> > > > > >
> > > > > > V9.2
> > > > > >
> > > > > > Like Fokko I was also not so close to the subject and it is great
> > to
> > > > > > see the final selection.
> > > > > > It looks so great. Thanks for all the work Emma and everyone!
> > > > > >
> > > > > > Ismaël
> > > > > >
> > > > > >
> > > > > > On Mon, Oct 2, 2023 at 3:23 PM Fokko Driesprong <
> fo...@apache.org>
> > > > > wrote:
> > > > > > >
> > > > > > > Hey Oscar,
> > > > > > >
> > > > > > > Thanks for raising this vote. I wasn't active in the
> conversation
> > > > > > > around the new logo, but I followed it from the sideline. The
> new
> > > > > logos are
> > > > > > > fantastic. Kudos to Emma.
> > > > > > >
> > > > > > > I really like the pigeon, especially the one with the envelope!
> > My
> > > > vote
> > > > > > > goes to V6.1 if I can't vote on the alternative version :)
> > > > > > >
> > > > > > > Cheers, Fokko
> > > > > > >
> > > > > > > Op ma 2 okt 2023 om 14:14 schreef Oscar Westra van Holthe -
> Kind
> > <
> > > > > > > os...@westravanholthe.nl>:
> > > > > > >
> > > > > > > > Hello everyone,
> > > > > > > >
> > > > > > > > The past month, there has been new progress on our search
> for a
> > > new
> > > > > logo (
> > > > > > > > AVRO-3554  >).
> > > > > Thanks to
> > > > > > > > Emma Kellam and the feedback we've all given, we can now
> > proceed
> > > to
> > > > > vote on
> > > > > > > > the matter.
> > > > > > > >
> > > > > > > > These are the finalists to choose from (if the image is
> > > unreadable,
> > > > > it
> > > > > > > > links to the comment where the finalists are announced):
> > > > > > > > <
> > > > > > > >
> > > > >
> > > >
> > >
> >
> 

Re: Add support for nanosecond datetime types

[Martin Grigorov]

Hi Fokko,

Whenever I see an empty ticket and/or Github description (like
https://issues.apache.org/jira/browse/AVRO-3884,
https://github.com/apache/avro/pull/2554) the first thing that comes to my
mind is to close it without giving an explanation too!
If the reporter does not bother to help him/herself then there is no need
to waste my time either!
I didn't close your PR because your are a fellow committer in the project.
But now I think this is even worse! A newbie may not know how to report an
issue or how to propose an improvement, but I expect better from a
long-time Apache committer!
Same for https://issues.apache.org/jira/browse/AVRO-3871. Such a JIRA issue
is plain useless. In a few months/years even you won't remember why you
needed the new class.

For changes in the specification I'd expect a discussion in the mailing
list (like this one) that provides information on what kind of problems
there are and a proposal on how to solve them. A PR may accompany the
discussion just to make it more clear but without an agreement on the
mailing list a change of the spec should not be made!

Regards,
Martin

On Mon, Oct 16, 2023 at 7:27 PM Fokko Driesprong  wrote:

> Hi everyone,
>
> I just created a PR to add support for:
>
>- timestamp-nanos
>- local-timestamp-nanos
>
> Let me know what you think: https://github.com/apache/avro/pull/2554
> Looking
> forward to your input!
>
> Kind regards,
> Fokko
>

Re: [PR] AVRO-3609: [Rust] Remove wrong collection of custom attributes [avro]

[via GitHub]

martin-g merged PR #2556:
URL: https://github.com/apache/avro/pull/2556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] AVRO-3609: [Rust] Remove wrong collection of custom attributes [avro]

[via GitHub]

martin-g opened a new pull request, #2556:
URL: https://github.com/apache/avro/pull/2556

   AVRO-3609
   
   ## What is the purpose of the change
   
   * The collection of the custom attributes was wrong. It should collect only 
attributes which names are not in the predefined list
   Found the bug while reviewing the code for AVRO-3886
   
   ## Verifying this change
   
   * The old unit tests should still pass
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org