[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call
zyearn commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268383593
##
File path: src/brpc/socket.cpp
##
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+if (FLAGS_health_check_using_rpc) {
Review comment:
这个问题之后单独开一个issue解决吧，混在一起解决有点乱
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] darrenwang00 commented on issue #698: Fail to find protoc
darrenwang00 commented on issue #698: Fail to find protoc URL: https://github.com/apache/incubator-brpc/issues/698#issuecomment-475840520 in centos , the protoc install in /usr/bin/protoc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] darrenwang00 opened a new issue #698: Fail to find protoc
darrenwang00 opened a new issue #698: Fail to find protoc URL: https://github.com/apache/incubator-brpc/issues/698 **Describe the bug (描述bug)** centos7 安装安装完所有依赖， sh config_brpc.sh --headers=/usr/include --libs=/usr/lib64 **To Reproduce (复现方法)** **Expected behavior (期望行为)** **Versions (各种版本)** OS: Compiler: brpc: protobuf: **Additional context/screenshots (更多上下文/截图)**  PROTOC=$(find_bin_or_die protoc) protoc bin not install in /usr/lib64 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call
zyearn commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268381737
##
File path: src/brpc/socket.cpp
##
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+if (FLAGS_health_check_using_rpc) {
Review comment:
revive这个函数似乎是不存在竞争的，compare_exchange_weak是必成功的，那把这些操作放到compare_exchange_weak就可以了
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-475596731 那max_replies_size这个有什么建议呢？还是通过gflags指定吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated: Move reuse_addr from server.cpp to endpoint.cpp and make the code more robust
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 51259c0 Move reuse_addr from server.cpp to endpoint.cpp and make the
code more robust
51259c0 is described below
commit 51259c0b5d68bdea12895865b24683c8dda18554
Author: gejun
AuthorDate: Fri Mar 22 19:45:06 2019 +0800
Move reuse_addr from server.cpp to endpoint.cpp and make the code more
robust
---
src/brpc/server.cpp| 7 ++-
src/butil/endpoint.cpp | 25 ++---
src/butil/endpoint.h | 7 ---
test/brpc_channel_unittest.cpp | 2 +-
test/brpc_input_messenger_unittest.cpp | 2 +-
test/brpc_server_unittest.cpp | 2 +-
test/brpc_socket_unittest.cpp | 4 ++--
test/brpc_ssl_unittest.cpp | 2 +-
8 files changed, 30 insertions(+), 21 deletions(-)
diff --git a/src/brpc/server.cpp b/src/brpc/server.cpp
index 051d18a..383b643 100644
--- a/src/brpc/server.cpp
+++ b/src/brpc/server.cpp
@@ -104,9 +104,6 @@ const char* status_str(Server::Status s) {
butil::static_atomic g_running_server_count = BUTIL_STATIC_ATOMIC_INIT(0);
-DEFINE_bool(reuse_addr, true, "Bind to ports in TIME_WAIT state");
-BRPC_VALIDATE_GFLAG(reuse_addr, PassValidate);
-
// Following services may have security issues and are disabled by default.
DEFINE_bool(enable_dir_service, false, "Enable /dir");
DEFINE_bool(enable_threads_service, false, "Enable /threads");
@@ -939,7 +936,7 @@ int Server::StartInternal(const butil::ip_t& ip,
_listen_addr.ip = ip;
for (int port = port_range.min_port; port <= port_range.max_port; ++port) {
_listen_addr.port = port;
-butil::fd_guard sockfd(tcp_listen(_listen_addr, FLAGS_reuse_addr));
+butil::fd_guard sockfd(tcp_listen(_listen_addr));
if (sockfd < 0) {
if (port != port_range.max_port) { // not the last port, try next
continue;
@@ -999,7 +996,7 @@ int Server::StartInternal(const butil::ip_t& ip,
}
butil::EndPoint internal_point = _listen_addr;
internal_point.port = _options.internal_port;
-butil::fd_guard sockfd(tcp_listen(internal_point, FLAGS_reuse_addr));
+butil::fd_guard sockfd(tcp_listen(internal_point));
if (sockfd < 0) {
LOG(ERROR) << "Fail to listen " << internal_point << " (internal)";
return -1;
diff --git a/src/butil/endpoint.cpp b/src/butil/endpoint.cpp
index dcb683b..a0ecb35 100644
--- a/src/butil/endpoint.cpp
+++ b/src/butil/endpoint.cpp
@@ -29,12 +29,12 @@
#include "butil/logging.h"
#include "butil/memory/singleton_on_pthread_once.h"
#include "butil/strings/string_piece.h"
+#include // SO_REUSEADDR SO_REUSEPORT
-#ifndef SO_REUSEPORT
-#define SO_REUSEPORT15
-#endif
-//This option is supported since Linux 3.9.
-DEFINE_bool(reuse_port, false, "turn on support for SO_REUSEPORT socket
option.");
+//supported since Linux 3.9.
+DEFINE_bool(reuse_port, false, "Enable SO_REUSEPORT for all listened sockets");
+
+DEFINE_bool(reuse_addr, true, "Enable SO_REUSEADDR for all listened sockets");
__BEGIN_DECLS
int BAIDU_WEAK bthread_connect(
@@ -308,25 +308,36 @@ int tcp_connect(EndPoint point, int* self_port) {
return sockfd.release();
}
-int tcp_listen(EndPoint point, bool reuse_addr) {
+int tcp_listen(EndPoint point) {
fd_guard sockfd(socket(AF_INET, SOCK_STREAM, 0));
if (sockfd < 0) {
return -1;
}
-if (reuse_addr) {
+
+if (FLAGS_reuse_addr) {
+#if defined(SO_REUSEADDR)
const int on = 1;
if (setsockopt(sockfd, SOL_SOCKET, SO_REUSEADDR,
, sizeof(on)) != 0) {
return -1;
}
+#else
+LOG(ERROR) << "Missing def of SO_REUSEADDR while -reuse_addr is on";
+return -1;
+#endif
}
if (FLAGS_reuse_port) {
+#if defined(SO_REUSEPORT)
const int on = 1;
if (setsockopt(sockfd, SOL_SOCKET, SO_REUSEPORT,
, sizeof(on)) != 0) {
LOG(WARNING) << "Fail to setsockopt SO_REUSEPORT of sockfd=" <<
sockfd;
}
+#else
+LOG(ERROR) << "Missing def of SO_REUSEPORT while -reuse_port is on";
+return -1;
+#endif
}
struct sockaddr_in serv_addr;
diff --git a/src/butil/endpoint.h b/src/butil/endpoint.h
index c6446d7..bec4dc5 100644
--- a/src/butil/endpoint.h
+++ b/src/butil/endpoint.h
@@ -119,10 +119,11 @@ int endpoint2hostname(const EndPoint& point, std::string*
host);
// Returns the socket descriptor, -1 otherwise and errno is set.
int tcp_connect(EndPoint server, int* self_port);
-// Create and listen to a TCP socket bound with `ip_and_port'. If `reuse_addr'
-// is true, ports in TIME_WAIT will be bound as well.
+// Create and listen to a TCP socket
[GitHub] [incubator-brpc] jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…
jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-475585775 > 如果有人错误的在单个命令里面写了两个命令，那么在response的处理里面做一个校验，判断返回的reply个数大于我们request时候预期的，就报错关闭连接。 这个必要性不大，反而会让用户觉得麻烦。比如从配置中读进来代表commands的字段可能包含多个command，用户还得拆开一个个调用。既然本身就支持简单的分隔，就没必要人为的拆开了。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-475580374 如果有人错误的在单个命令里面写了两个命令，那么在response的处理里面做一个校验，判断返回的reply个数大于我们request时候预期的，就报错关闭连接。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-475579096 嗨，原来有个max_replies_size这样的flags变量，用于控制分配MysqlReply数组的大小，现在如果利用上pipelined_count，就可以不用这个flags了，这样就不用定义一个死的数组大小了，你觉得这样会好一些吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call
zyearn commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268103165
##
File path: src/brpc/socket.cpp
##
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+if (FLAGS_health_check_using_rpc) {
Review comment:
对的，不过这个问题一直存在。放while循环之前也不行，没有compare_exchange_weak成功还得恢复回来，这里有挺多竞争问题的
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268082594 ## File path: src/brpc/socket.cpp ## @@ -92,6 +95,13 @@ DEFINE_int32(connect_timeout_as_unreachable, 3, "times *continuously*, the error is changed to ENETUNREACH which " "fails the main socket as well when this socket is pooled."); +DEFINE_bool(health_check_using_rpc, false, "By default health check succeeds if server" Review comment: 这个flag删掉吧，用health_check_path是否为空来代替，这还能更明确地让用户知道这是在假设下游能提供hc接口。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call
jamesge commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268081617
##
File path: src/brpc/controller.h
##
@@ -324,6 +325,12 @@ friend void
policy::ProcessThriftRequest(InputMessageBase*);
bool is_done_allowed_to_run_in_place() const
{ return has_flag(FLAGS_ALLOW_DONE_TO_RUN_IN_PLACE); }
+// Tell RPC that this particular call is used to do health check. These two
Review comment:
那为什么要public？
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call
jamesge commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268081937
##
File path: src/brpc/load_balancer.h
##
@@ -40,6 +40,7 @@ class LoadBalancer : public NonConstDescribable, public
Destroyable {
bool has_request_code;
uint64_t request_code;
const ExcludedServers* excluded;
+bool health_check_call;
Review comment:
hc绝对不会走lb，这个是不必要的，删掉吧
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #694: Health check by rpc call
TousakaRin commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268080772
##
File path: src/brpc/socket.cpp
##
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+if (FLAGS_health_check_using_rpc) {
Review comment:
在784行加一句sleep(10)可以百分之复现这个问题，是不是应该把这些操作移到while循环之前
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #694: Health check by rpc call
TousakaRin commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268080772
##
File path: src/brpc/socket.cpp
##
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+if (FLAGS_health_check_using_rpc) {
Review comment:
在784行加一句sleep(10)可以百分之复现这个问题
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #694: Health check by rpc call
TousakaRin commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268080437
##
File path: src/brpc/socket.cpp
##
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+if (FLAGS_health_check_using_rpc) {
Review comment:
这里似乎有问题，在compare_exchange_weak成功之后，lb就已经能够选取之前SetFailed的socket了，之后设置state为heath_checking_using_rpc，中间会导致有一些预期之外的指向SetFailed节点的rpc。这个问题在这里还好，由于上面的sp->circuit_breaker.Reset()；也存在类似问题，有小概率导致熔断无法恢复。
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call
zyearn commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268067952
##
File path: src/brpc/channel.cpp
##
@@ -281,6 +281,15 @@ int Channel::Init(butil::EndPoint server_addr_and_port,
return InitSingle(server_addr_and_port, "", options);
}
+int Channel::Init(SocketId id, const ChannelOptions* options) {
Review comment:
嗯，改成class HealthCheckChannel : public brpc::Channel了
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on issue #697: 客户端出现大量timeout
jamesge commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-475515818 先跑下asan排除下内存问题吧 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] cuisonghui commented on issue #697: 客户端出现大量timeout
cuisonghui commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-475515554 @jamesge 好的，谢谢，目前我的服务打开vars就会挂掉，我先把这个问题定位一下． This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #694: Health check by rpc call
TousakaRin commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268052431
##
File path: src/brpc/channel.cpp
##
@@ -281,6 +281,15 @@ int Channel::Init(butil::EndPoint server_addr_and_port,
return InitSingle(server_addr_and_port, "", options);
}
+int Channel::Init(SocketId id, const ChannelOptions* options) {
Review comment:
是不是可以做成Socket私有的 HealthCheckChannel，这里暴露给用户是有点怪。
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #694: Health check by rpc call
TousakaRin commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268052431
##
File path: src/brpc/channel.cpp
##
@@ -281,6 +281,15 @@ int Channel::Init(butil::EndPoint server_addr_and_port,
return InitSingle(server_addr_and_port, "", options);
}
+int Channel::Init(SocketId id, const ChannelOptions* options) {
Review comment:
是不是可以做成Socket私有的 HealthCheckChannel : public ChannelBase。这里暴露给用户是有点怪。
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475507329 忽略吧，谢谢各位，问题已经解决 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475504372 手动安装到了/user/local/lib目录下 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475504292 我apt-get移除了所有安装，然后收到安装到了/user/local/lib目录下，然后用上边说的cmake方式编译， /usr/bin/ld: /usr/local/lib/libgflags.a(gflags.cc.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
