[GitHub] [camel-website] davsclaus commented on issue #73: Redesign

2019-08-14 Thread GitBox 
davsclaus commented on issue #73: Redesign
URL: https://github.com/apache/camel-website/pull/73#issuecomment-521518092
 
 
   Great work Zoran
   
   A few comments
   
   1)
   I would remove the section with:
   
   INTEGRATED WITH APACHE CAMEL
   The following projects can leverage Apache Camel as a routing and mediation 
engine
   
   ... as this is very old content
   
   2)
   At the section where Camel and Camel Quarkus is mention, then I would add 
Apache Camel before them, so we have all 3, otherwise its actually a bit 
unclear.
   
   3)
   Blueprint -> OSGi Blueprint
   And also add Standalone
   
   And we should likely update it a bit as it mentions OSGi first.
   
   And I wonder if Portability should be named Runtimes ?
   
   4)
   I would put the new Camel logo more prominently in the top
   
   5)
   Remove the last dot from the headline, Integration you want.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Claus Ibsen 
Hi

I have also cleaned with

git clean -dXf
removed my m2/repository/org/apache/camel

And did a rebuild

mvn clean install -P fastinstall

And it worked fine, well later there is a build error with mongodb

On Wed, Aug 14, 2019 at 11:53 PM Babak Vahdat
 wrote:
>
>
>
> > On 14 Aug 2019, at 22:14, Babak Vahdat  wrote:
> >
> > Hi Claus
> >
> > Without that change I get a compilation error about the missing class 
> > DefinitionPropertiesPlaceholderProviderHelper in camel-core.
> >
> > Could you please delete your local m2 cache and try to build the master 
> > branch locally without this commit?
> >
> > Right now I don‘t have access to my laptop, but will try to see if I can 
> > reproduce the problem again.
>
> Now I reverted that commit, deleted the folder 
> ~/.m2/repository/org/apache/camel and ran `mvn clean install -Dtest=XXX` and 
> this is the compilation error which I get now again:
>
> [INFO] Camel :: Example :: Zipkin :: Service 2  SKIPPED
> [INFO] Camel :: Docs .. SKIPPED
> [INFO] Camel :: Assembly .. SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  02:46 min
> [INFO] Finished at: 2019-08-14T23:40:37+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile 
> (default-compile) on project camel-core: Compilation failure
> [ERROR] 
> /Users/bvahdat/dev/workspace/camel/core/camel-core/src/main/java/org/apache/camel/model/DefinitionPropertyPlaceholderConfigurer.java:[24,41]
>  error: cannot find symbol
> [ERROR]   symbol:   class DefinitionPropertiesPlaceholderProviderHelper
> [ERROR]   location: package org.apache.camel.model.placeholder
> [ERROR]
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :camel-core
>
> And I guess this missing class gets generated here: 
> https://github.com/apache/camel/blob/master/tooling/apt/src/main/java/org/apache/camel/tools/apt/PropertyPlaceholderGenerator.java#L108-L163
>  
> 
>
> Babak
>
> >
> > Sorry for the noise
> > Babak
> >
> >> Am 14.08.2019 um 21:57 schrieb Andrea Cosentino :
> >>
> >> The build on CI wasn't failing. I'm +1 for reverting.
> >>
> >> Il mer 14 ago 2019, 21:49 Claus Ibsen  ha scritto:
> >>
> >>> Hi Babak
> >>>
> >>> We should not have camel-apt as compile dependency as its should not
> >>> be there for regular Camel end users.
> >>>
> >>> I wonder what error you see - the code before was like it was in camel
> >>> 2.x and has always been.
> >>> So I wonder what error you have.
> >>>
> >>> IMHO we need to revert so its as before, but before I wonder what
> >>> problem you had.
> >>>
>  On Wed, Aug 14, 2019 at 6:38 PM  wrote:
> 
>  This is an automated email from the ASF dual-hosted git repository.
> 
>  bvahdat pushed a commit to branch master
>  in repository https://gitbox.apache.org/repos/asf/camel.git
> 
> 
>  The following commit(s) were added to refs/heads/master by this push:
> new 8d4834e  fix the compilation error because of the missing
> >>> DefinitionPropertiesPlaceholderProviderHelper class being generated
>  8d4834e is described below
> 
>  commit 8d4834e0752d0b6a8b45c6df36641e3f9b5a8eaf
>  Author: Babak Vahdat 
>  AuthorDate: Wed Aug 14 18:38:15 2019 +0200
> 
>    fix the compilation error because of the missing
> >>> DefinitionPropertiesPlaceholderProviderHelper class being generated
>  ---
>  core/camel-core/pom.xml | 23 ---
>  1 file changed, 4 insertions(+), 19 deletions(-)
> 
>  diff --git a/core/camel-core/pom.xml b/core/camel-core/pom.xml
>  index 118b999..b073fe1 100644
>  --- a/core/camel-core/pom.xml
>  +++ b/core/camel-core/pom.xml
>  @@ -65,6 +65,10 @@
> 
> 
> org.apache.camel
>  +apt
>  +
>  +
>  +org.apache.camel
> camel-base
> 
> 
>  @@ -637,25 +641,6 @@
> 
> 
> 
>  -
>  -
>  -apt
>  -

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Babak Vahdat 


> On 14 Aug 2019, at 22:14, Babak Vahdat  wrote:
> 
> Hi Claus
> 
> Without that change I get a compilation error about the missing class 
> DefinitionPropertiesPlaceholderProviderHelper in camel-core.
> 
> Could you please delete your local m2 cache and try to build the master 
> branch locally without this commit?
> 
> Right now I don‘t have access to my laptop, but will try to see if I can 
> reproduce the problem again.

Now I reverted that commit, deleted the folder 
~/.m2/repository/org/apache/camel and ran `mvn clean install -Dtest=XXX` and 
this is the compilation error which I get now again:

[INFO] Camel :: Example :: Zipkin :: Service 2  SKIPPED
[INFO] Camel :: Docs .. SKIPPED
[INFO] Camel :: Assembly .. SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  02:46 min
[INFO] Finished at: 2019-08-14T23:40:37+02:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) 
on project camel-core: Compilation failure
[ERROR] 
/Users/bvahdat/dev/workspace/camel/core/camel-core/src/main/java/org/apache/camel/model/DefinitionPropertyPlaceholderConfigurer.java:[24,41]
 error: cannot find symbol
[ERROR]   symbol:   class DefinitionPropertiesPlaceholderProviderHelper
[ERROR]   location: package org.apache.camel.model.placeholder
[ERROR] 
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :camel-core

And I guess this missing class gets generated here: 
https://github.com/apache/camel/blob/master/tooling/apt/src/main/java/org/apache/camel/tools/apt/PropertyPlaceholderGenerator.java#L108-L163
 


Babak 

> 
> Sorry for the noise
> Babak
> 
>> Am 14.08.2019 um 21:57 schrieb Andrea Cosentino :
>> 
>> The build on CI wasn't failing. I'm +1 for reverting.
>> 
>> Il mer 14 ago 2019, 21:49 Claus Ibsen  ha scritto:
>> 
>>> Hi Babak
>>> 
>>> We should not have camel-apt as compile dependency as its should not
>>> be there for regular Camel end users.
>>> 
>>> I wonder what error you see - the code before was like it was in camel
>>> 2.x and has always been.
>>> So I wonder what error you have.
>>> 
>>> IMHO we need to revert so its as before, but before I wonder what
>>> problem you had.
>>> 
 On Wed, Aug 14, 2019 at 6:38 PM  wrote:
 
 This is an automated email from the ASF dual-hosted git repository.
 
 bvahdat pushed a commit to branch master
 in repository https://gitbox.apache.org/repos/asf/camel.git
 
 
 The following commit(s) were added to refs/heads/master by this push:
new 8d4834e  fix the compilation error because of the missing
>>> DefinitionPropertiesPlaceholderProviderHelper class being generated
 8d4834e is described below
 
 commit 8d4834e0752d0b6a8b45c6df36641e3f9b5a8eaf
 Author: Babak Vahdat 
 AuthorDate: Wed Aug 14 18:38:15 2019 +0200
 
   fix the compilation error because of the missing
>>> DefinitionPropertiesPlaceholderProviderHelper class being generated
 ---
 core/camel-core/pom.xml | 23 ---
 1 file changed, 4 insertions(+), 19 deletions(-)
 
 diff --git a/core/camel-core/pom.xml b/core/camel-core/pom.xml
 index 118b999..b073fe1 100644
 --- a/core/camel-core/pom.xml
 +++ b/core/camel-core/pom.xml
 @@ -65,6 +65,10 @@


org.apache.camel
 +apt
 +
 +
 +org.apache.camel
camel-base


 @@ -637,25 +641,6 @@


 
 -
 -
 -apt
 -
 -true
 -
 -
 -
 -
 -
 -
 -org.apache.camel
 -apt
 -provided
 -
 -
 -
 -
 -


aix
 
>>> 
>>> 
>>> --
>>> Claus Ibsen
>>> -
>>> http://davsclaus.com @davsclaus
>>> Camel in Action 2:

[GitHub] [camel-website] zregvart commented on issue #73: Redesign

2019-08-14 Thread GitBox 
zregvart commented on issue #73: Redesign
URL: https://github.com/apache/camel-website/pull/73#issuecomment-521413076
 
 
   Preview is 
[here](https://builds.apache.org/job/Camel.website/view/change-requests/job/PR-73/Preview/index.html).
   
   This is how the front page looks with this change:
   
   ![Screenshot_2019-08-14 Home page - Apache 
Camel(1)](https://user-images.githubusercontent.com/1306050/63055202-ac5bdb00-bee5-11e9-9ef2-ed87008e3f70.png)
   
   Feedback welcome.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Babak Vahdat 
Hi Claus

Without that change I get a compilation error about the missing class 
DefinitionPropertiesPlaceholderProviderHelper in camel-core.

Could you please delete your local m2 cache and try to build the master branch 
locally without this commit?

Right now I don‘t have access to my laptop, but will try to see if I can 
reproduce the problem again.

Sorry for the noise
Babak

> Am 14.08.2019 um 21:57 schrieb Andrea Cosentino :
> 
> The build on CI wasn't failing. I'm +1 for reverting.
> 
> Il mer 14 ago 2019, 21:49 Claus Ibsen  ha scritto:
> 
>> Hi Babak
>> 
>> We should not have camel-apt as compile dependency as its should not
>> be there for regular Camel end users.
>> 
>> I wonder what error you see - the code before was like it was in camel
>> 2.x and has always been.
>> So I wonder what error you have.
>> 
>> IMHO we need to revert so its as before, but before I wonder what
>> problem you had.
>> 
>>> On Wed, Aug 14, 2019 at 6:38 PM  wrote:
>>> 
>>> This is an automated email from the ASF dual-hosted git repository.
>>> 
>>> bvahdat pushed a commit to branch master
>>> in repository https://gitbox.apache.org/repos/asf/camel.git
>>> 
>>> 
>>> The following commit(s) were added to refs/heads/master by this push:
>>> new 8d4834e  fix the compilation error because of the missing
>> DefinitionPropertiesPlaceholderProviderHelper class being generated
>>> 8d4834e is described below
>>> 
>>> commit 8d4834e0752d0b6a8b45c6df36641e3f9b5a8eaf
>>> Author: Babak Vahdat 
>>> AuthorDate: Wed Aug 14 18:38:15 2019 +0200
>>> 
>>>fix the compilation error because of the missing
>> DefinitionPropertiesPlaceholderProviderHelper class being generated
>>> ---
>>> core/camel-core/pom.xml | 23 ---
>>> 1 file changed, 4 insertions(+), 19 deletions(-)
>>> 
>>> diff --git a/core/camel-core/pom.xml b/core/camel-core/pom.xml
>>> index 118b999..b073fe1 100644
>>> --- a/core/camel-core/pom.xml
>>> +++ b/core/camel-core/pom.xml
>>> @@ -65,6 +65,10 @@
>>> 
>>> 
>>> org.apache.camel
>>> +apt
>>> +
>>> +
>>> +org.apache.camel
>>> camel-base
>>> 
>>> 
>>> @@ -637,25 +641,6 @@
>>> 
>>> 
>>> 
>>> -
>>> -
>>> -apt
>>> -
>>> -true
>>> -
>>> -
>>> -
>>> -
>>> -
>>> -
>>> -org.apache.camel
>>> -apt
>>> -provided
>>> -
>>> -
>>> -
>>> -
>>> -
>>> 
>>> 
>>> aix
>>> 
>> 
>> 
>> --
>> Claus Ibsen
>> -
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2
>>

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Andrea Cosentino 
The build on CI wasn't failing. I'm +1 for reverting.

Il mer 14 ago 2019, 21:49 Claus Ibsen  ha scritto:

> Hi Babak
>
> We should not have camel-apt as compile dependency as its should not
> be there for regular Camel end users.
>
> I wonder what error you see - the code before was like it was in camel
> 2.x and has always been.
> So I wonder what error you have.
>
> IMHO we need to revert so its as before, but before I wonder what
> problem you had.
>
> On Wed, Aug 14, 2019 at 6:38 PM  wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > bvahdat pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/camel.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> >  new 8d4834e  fix the compilation error because of the missing
> DefinitionPropertiesPlaceholderProviderHelper class being generated
> > 8d4834e is described below
> >
> > commit 8d4834e0752d0b6a8b45c6df36641e3f9b5a8eaf
> > Author: Babak Vahdat 
> > AuthorDate: Wed Aug 14 18:38:15 2019 +0200
> >
> > fix the compilation error because of the missing
> DefinitionPropertiesPlaceholderProviderHelper class being generated
> > ---
> >  core/camel-core/pom.xml | 23 ---
> >  1 file changed, 4 insertions(+), 19 deletions(-)
> >
> > diff --git a/core/camel-core/pom.xml b/core/camel-core/pom.xml
> > index 118b999..b073fe1 100644
> > --- a/core/camel-core/pom.xml
> > +++ b/core/camel-core/pom.xml
> > @@ -65,6 +65,10 @@
> >  
> >  
> >  org.apache.camel
> > +apt
> > +
> > +
> > +org.apache.camel
> >  camel-base
> >  
> >  
> > @@ -637,25 +641,6 @@
> >  
> >  
> >
> > -
> > -
> > -apt
> > -
> > -true
> > -
> > -
> > -
> > -
> > -
> > -
> > -org.apache.camel
> > -apt
> > -provided
> > -
> > -
> > -
> > -
> > -
> >  
> >  
> >  aix
> >
>
>
> --
> Claus Ibsen
> -
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Claus Ibsen 
Hi Babak

We should not have camel-apt as compile dependency as its should not
be there for regular Camel end users.

I wonder what error you see - the code before was like it was in camel
2.x and has always been.
So I wonder what error you have.

IMHO we need to revert so its as before, but before I wonder what
problem you had.

On Wed, Aug 14, 2019 at 6:38 PM  wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> bvahdat pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/camel.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>  new 8d4834e  fix the compilation error because of the missing 
> DefinitionPropertiesPlaceholderProviderHelper class being generated
> 8d4834e is described below
>
> commit 8d4834e0752d0b6a8b45c6df36641e3f9b5a8eaf
> Author: Babak Vahdat 
> AuthorDate: Wed Aug 14 18:38:15 2019 +0200
>
> fix the compilation error because of the missing 
> DefinitionPropertiesPlaceholderProviderHelper class being generated
> ---
>  core/camel-core/pom.xml | 23 ---
>  1 file changed, 4 insertions(+), 19 deletions(-)
>
> diff --git a/core/camel-core/pom.xml b/core/camel-core/pom.xml
> index 118b999..b073fe1 100644
> --- a/core/camel-core/pom.xml
> +++ b/core/camel-core/pom.xml
> @@ -65,6 +65,10 @@
>  
>  
>  org.apache.camel
> +apt
> +
> +
> +org.apache.camel
>  camel-base
>  
>  
> @@ -637,25 +641,6 @@
>  
>  
>
> -
> -
> -apt
> -
> -true
> -
> -
> -
> -
> -
> -
> -org.apache.camel
> -apt
> -provided
> -
> -
> -
> -
> -
>  
>  
>  aix
>


-- 
Claus Ibsen
-
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

[GitHub] [camel-website] zregvart opened a new pull request #73: Redesign

2019-08-14 Thread GitBox 
zregvart opened a new pull request #73: Redesign
URL: https://github.com/apache/camel-website/pull/73
 
 
   With this there's a new front page design (still a bit work in progress), I 
started by consolidating CSS and ended up redesigning...
   
   This consolidates the CSS used between Antora and the Hugo built parts very 
much a work in progress. The end result would be same exact styling that we 
have in the Antora bits in the Hugo built bits and also integration of only the 
used bits in Bootstrap into the CSS we have.
   
   For this markup also needed to change and some visual differences will be 
noticed between current and the proposed changes here.
   
   A lot of the repeating layouts were removed so that the default layout is 
used instead, thus reducing some of the repetition and easing future 
maintenance.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] jamesnetherton commented on issue #906: Dev mode doesn't show if the build failed

2019-08-14 Thread GitBox 
jamesnetherton commented on issue #906: Dev mode doesn't show if the build 
failed
URL: https://github.com/apache/camel-k/issues/906#issuecomment-521179709
 
 
   Seems the watch that gets set up on the integration exceeds its timeout, as 
the build error recovery loop can take a while to exhaust all of its retry 
attempts.
   
   When I force the watch timeout to 5 minutes, I can then see the error status:
   
   ```
   integration "sample" in phase Error
   integration deployment failed
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] asf-ci commented on issue #134: Fix #133 Test netty4-http as a producer

2019-08-14 Thread GitBox 
asf-ci commented on issue #134: Fix #133 Test netty4-http as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#issuecomment-521153196
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/camel-quarkus-pr/88/Failed Tests: 2camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-netty4-http:
 2org.apache.camel.quarkus.component.netty4.http.CamelTest.netty4HttpProducerorg.apache.camel.quarkus.component.netty4.http.CamelIT.netty4HttpProducer
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http as a producer

2019-08-14 Thread GitBox 
ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http 
as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313743121
 
 

 ##
 File path: 
integration-tests/netty4-http/src/test/java/org/apache/camel/quarkus/component/netty4/http/CamelTest.java
 ##
 @@ -16,18 +16,119 @@
  */
 package org.apache.camel.quarkus.component.netty4.http;
 
+import static org.hamcrest.Matchers.is;
+
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.Reader;
+import java.io.Writer;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketException;
 import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.atomic.AtomicBoolean;
 
-import io.quarkus.test.junit.QuarkusTest;
-import io.restassured.RestAssured;
 import org.junit.jupiter.api.Test;
 
-import static org.hamcrest.Matchers.is;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
 
 @QuarkusTest
 public class CamelTest {
+
 @Test
 public void testNetty4Http() throws Exception {
 RestAssured.when().get(new 
URI("http://localhost:8999/foo;)).then().body(is("Netty Hello World"));
 }
+
+@Test
+public void netty4HttpProducer() throws Exception {
+try (Server s = new Server("HTTP/1.1 200 OK\r\n" +
+"Content-Type: text/plain\r\n" +
+"\r\n" +
+"Hello from the mockserver!")) {
+/* First check that our mockserver actually works */
+RestAssured.when().get(new URI("http://localhost:; + 
CamelRoute.PRODUCER_TARGET_PORT + "/")).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+/* The producer route should proxy the mockserver */
+RestAssured.when().get(new 
URI("http://localhost:8999/producer;)).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+}
+}
+
+/**
+ * An HTTP server always sending the same response.
+ */
+static class Server implements Closeable, Runnable {
 
 Review comment:
   > reuse an existing netty http endpoint
   
   done in b8ae8a1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] hholtzhausen commented on issue #132: netty4-http producer fails with RejectedExecutionException

2019-08-14 Thread GitBox 
hholtzhausen commented on issue #132: netty4-http producer fails with 
RejectedExecutionException
URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-521137866
 
 
   > @hholtzhausen this looks like an issue on our side, as confirmation: does 
it fails in both jvm and native mode ?
   
   I was able to reproduce this in native mode a week or so ago using 
camel-quarkus 0.0.3-SNAPSHOT and quarkus 999-SNAPSHOT. I used those versions to 
get around https://github.com/apache/camel-quarkus/issues/80 and a 
_java.lang.NoClassDefFoundError: org/conscrypt/BufferAllocator_ during native 
compile.
   
   With the current  camel-quarkus 0.1.1-SNAPSHOT version I am getting the 
_java.lang.NoClassDefFoundError: org/conscrypt/BufferAllocator_ exception again 
during native compile.  I suspect the NoClassDefFoundError is a problem in 
quarkus 0.20.0.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http as a producer

2019-08-14 Thread GitBox 
ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http 
as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313737756
 
 

 ##
 File path: 
integration-tests/netty4-http/src/test/java/org/apache/camel/quarkus/component/netty4/http/CamelTest.java
 ##
 @@ -16,18 +16,119 @@
  */
 package org.apache.camel.quarkus.component.netty4.http;
 
+import static org.hamcrest.Matchers.is;
+
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.Reader;
+import java.io.Writer;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketException;
 import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.atomic.AtomicBoolean;
 
-import io.quarkus.test.junit.QuarkusTest;
-import io.restassured.RestAssured;
 import org.junit.jupiter.api.Test;
 
-import static org.hamcrest.Matchers.is;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
 
 @QuarkusTest
 public class CamelTest {
+
 @Test
 public void testNetty4Http() throws Exception {
 RestAssured.when().get(new 
URI("http://localhost:8999/foo;)).then().body(is("Netty Hello World"));
 }
+
+@Test
+public void netty4HttpProducer() throws Exception {
+try (Server s = new Server("HTTP/1.1 200 OK\r\n" +
+"Content-Type: text/plain\r\n" +
+"\r\n" +
+"Hello from the mockserver!")) {
+/* First check that our mockserver actually works */
+RestAssured.when().get(new URI("http://localhost:; + 
CamelRoute.PRODUCER_TARGET_PORT + "/")).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+/* The producer route should proxy the mockserver */
+RestAssured.when().get(new 
URI("http://localhost:8999/producer;)).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+}
+}
+
+/**
+ * An HTTP server always sending the same response.
+ */
+static class Server implements Closeable, Runnable {
 
 Review comment:
   > reuse an existing netty http endpoint
   
   What an idea!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-k] WillemJiang closed issue #902: Road Map about Yaml DSL

2019-08-14 Thread GitBox 
WillemJiang closed issue #902: Road Map about Yaml DSL
URL: https://github.com/apache/camel-k/issues/902
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #134: Fix #133 Test netty4-http as a producer

2019-08-14 Thread GitBox 
lburgazzoli commented on a change in pull request #134: Fix #133 Test 
netty4-http as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313732059
 
 

 ##
 File path: 
integration-tests/netty4-http/src/test/java/org/apache/camel/quarkus/component/netty4/http/CamelTest.java
 ##
 @@ -16,18 +16,119 @@
  */
 package org.apache.camel.quarkus.component.netty4.http;
 
+import static org.hamcrest.Matchers.is;
+
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.Reader;
+import java.io.Writer;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketException;
 import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.atomic.AtomicBoolean;
 
-import io.quarkus.test.junit.QuarkusTest;
-import io.restassured.RestAssured;
 import org.junit.jupiter.api.Test;
 
-import static org.hamcrest.Matchers.is;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
 
 @QuarkusTest
 public class CamelTest {
+
 @Test
 public void testNetty4Http() throws Exception {
 RestAssured.when().get(new 
URI("http://localhost:8999/foo;)).then().body(is("Netty Hello World"));
 }
+
+@Test
+public void netty4HttpProducer() throws Exception {
+try (Server s = new Server("HTTP/1.1 200 OK\r\n" +
+"Content-Type: text/plain\r\n" +
+"\r\n" +
+"Hello from the mockserver!")) {
+/* First check that our mockserver actually works */
+RestAssured.when().get(new URI("http://localhost:; + 
CamelRoute.PRODUCER_TARGET_PORT + "/")).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+/* The producer route should proxy the mockserver */
+RestAssured.when().get(new 
URI("http://localhost:8999/producer;)).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+}
+}
+
+/**
+ * An HTTP server always sending the same response.
+ */
+static class Server implements Closeable, Runnable {
 
 Review comment:
   Another option would be to reuse an existing netty http endpoint and ditch 
the server at all


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http as a producer

2019-08-14 Thread GitBox 
ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http 
as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313731272
 
 

 ##
 File path: 
integration-tests/netty4-http/src/test/java/org/apache/camel/quarkus/component/netty4/http/CamelTest.java
 ##
 @@ -16,18 +16,119 @@
  */
 package org.apache.camel.quarkus.component.netty4.http;
 
+import static org.hamcrest.Matchers.is;
+
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.Reader;
+import java.io.Writer;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketException;
 import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.atomic.AtomicBoolean;
 
-import io.quarkus.test.junit.QuarkusTest;
-import io.restassured.RestAssured;
 import org.junit.jupiter.api.Test;
 
-import static org.hamcrest.Matchers.is;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
 
 @QuarkusTest
 public class CamelTest {
+
 @Test
 public void testNetty4Http() throws Exception {
 RestAssured.when().get(new 
URI("http://localhost:8999/foo;)).then().body(is("Netty Hello World"));
 }
+
+@Test
+public void netty4HttpProducer() throws Exception {
+try (Server s = new Server("HTTP/1.1 200 OK\r\n" +
+"Content-Type: text/plain\r\n" +
+"\r\n" +
+"Hello from the mockserver!")) {
+/* First check that our mockserver actually works */
+RestAssured.when().get(new URI("http://localhost:; + 
CamelRoute.PRODUCER_TARGET_PORT + "/")).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+/* The producer route should proxy the mockserver */
+RestAssured.when().get(new 
URI("http://localhost:8999/producer;)).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+}
+}
+
+/**
+ * An HTTP server always sending the same response.
+ */
+static class Server implements Closeable, Runnable {
+
+private volatile AtomicBoolean stop = new AtomicBoolean(false);
 
 Review comment:
   `volatile AtomicBoolean` - what a nice nonsense! :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http as a producer

2019-08-14 Thread GitBox 
ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http 
as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313729917
 
 

 ##
 File path: 
integration-tests/netty4-http/src/main/java/org/apache/camel/quarkus/component/netty4/http/CamelRoute.java
 ##
 @@ -19,10 +19,16 @@
 import org.apache.camel.builder.RouteBuilder;
 
 public class CamelRoute extends RouteBuilder {
+
+public static final int PRODUCER_TARGET_PORT = 10102;
 
 Review comment:
   Not sure how? The test app AND the test classes need to agree on the same 
port number while they live in distinct JVM processes. We'd have to pass the 
random port via an endpoint running on some constant port - which I think is 
too complicated for what it brings. Or you maybe have a better idea?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #134: Fix #133 Test netty4-http as a producer

2019-08-14 Thread GitBox 
lburgazzoli commented on a change in pull request #134: Fix #133 Test 
netty4-http as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313729118
 
 

 ##
 File path: 
integration-tests/netty4-http/src/test/java/org/apache/camel/quarkus/component/netty4/http/CamelTest.java
 ##
 @@ -16,18 +16,119 @@
  */
 package org.apache.camel.quarkus.component.netty4.http;
 
+import static org.hamcrest.Matchers.is;
+
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.Reader;
+import java.io.Writer;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketException;
 import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.atomic.AtomicBoolean;
 
-import io.quarkus.test.junit.QuarkusTest;
-import io.restassured.RestAssured;
 import org.junit.jupiter.api.Test;
 
-import static org.hamcrest.Matchers.is;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
 
 @QuarkusTest
 public class CamelTest {
+
 @Test
 public void testNetty4Http() throws Exception {
 RestAssured.when().get(new 
URI("http://localhost:8999/foo;)).then().body(is("Netty Hello World"));
 }
+
+@Test
+public void netty4HttpProducer() throws Exception {
+try (Server s = new Server("HTTP/1.1 200 OK\r\n" +
+"Content-Type: text/plain\r\n" +
+"\r\n" +
+"Hello from the mockserver!")) {
+/* First check that our mockserver actually works */
+RestAssured.when().get(new URI("http://localhost:; + 
CamelRoute.PRODUCER_TARGET_PORT + "/")).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+/* The producer route should proxy the mockserver */
+RestAssured.when().get(new 
URI("http://localhost:8999/producer;)).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+}
+}
+
+/**
+ * An HTTP server always sending the same response.
+ */
+static class Server implements Closeable, Runnable {
 
 Review comment:
   Quarkus is not portable too and I think we need to introduce the test scope 
and push quarkus team to support it otherwise it is a mess (imho)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http as a producer

2019-08-14 Thread GitBox 
ppalaga commented on a change in pull request #134: Fix #133 Test netty4-http 
as a producer
URL: https://github.com/apache/camel-quarkus/pull/134#discussion_r313728474
 
 

 ##
 File path: 
integration-tests/netty4-http/src/test/java/org/apache/camel/quarkus/component/netty4/http/CamelTest.java
 ##
 @@ -16,18 +16,119 @@
  */
 package org.apache.camel.quarkus.component.netty4.http;
 
+import static org.hamcrest.Matchers.is;
+
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.Reader;
+import java.io.Writer;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketException;
 import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.atomic.AtomicBoolean;
 
-import io.quarkus.test.junit.QuarkusTest;
-import io.restassured.RestAssured;
 import org.junit.jupiter.api.Test;
 
-import static org.hamcrest.Matchers.is;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
 
 @QuarkusTest
 public class CamelTest {
+
 @Test
 public void testNetty4Http() throws Exception {
 RestAssured.when().get(new 
URI("http://localhost:8999/foo;)).then().body(is("Netty Hello World"));
 }
+
+@Test
+public void netty4HttpProducer() throws Exception {
+try (Server s = new Server("HTTP/1.1 200 OK\r\n" +
+"Content-Type: text/plain\r\n" +
+"\r\n" +
+"Hello from the mockserver!")) {
+/* First check that our mockserver actually works */
+RestAssured.when().get(new URI("http://localhost:; + 
CamelRoute.PRODUCER_TARGET_PORT + "/")).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+/* The producer route should proxy the mockserver */
+RestAssured.when().get(new 
URI("http://localhost:8999/producer;)).then()
+.statusCode(200)
+.body(is("Hello from the mockserver!"));
+}
+}
+
+/**
+ * An HTTP server always sending the same response.
+ */
+static class Server implements Closeable, Runnable {
 
 Review comment:
   I did not want to expand the class path while we cannot use the test scope. 
I did not like `com.sun.net.httpserver.HttpServer` for not being portable 
accross Java vendors. I have not thought of Undertow (or vert.x) though. Let me 
have a look if it is there in the CP already.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] lburgazzoli commented on issue #132: netty4-http producer fails with RejectedExecutionException

2019-08-14 Thread GitBox 
lburgazzoli commented on issue #132: netty4-http producer fails with 
RejectedExecutionException
URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-521126112
 
 
   Yes it is 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] jamesnetherton commented on issue #132: netty4-http producer fails with RejectedExecutionException

2019-08-14 Thread GitBox 
jamesnetherton commented on issue #132: netty4-http producer fails with 
RejectedExecutionException
URL: https://github.com/apache/camel-quarkus/issues/132#issuecomment-521125437
 
 
   Since you mentioned the LRU cache. I wonder if it's similar to what I 
observed in [CAMEL-13504](https://issues.apache.org/jira/browse/CAMEL-13504).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services