Re: Upcoming deprecations in 4.1 version

[Andrus Adamchik]

> On Feb 2, 2018, at 10:53 AM, Nikita Timofeev  
> wrote:
> 
> - cayenne-joda module
> PR is already done for this, there is some discussion too [1].

With Joda stating on their site that "[..] from Java SE 8 onwards, users are 
asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces 
this project.", deprecating it makes sense in 4.1 that requires Java 8.

> - password encoding settings in the Modeler
> This one is more about redesigning this feature, then just deprecation.
> Think this should be discussed s Just wanted to mention it here also.

This is very much in line with moving configuration of all Java strategies to 
DI.

> - cayenne-dbcp2 support;
> Does anyone still using this?

[..]

> For me it seems better to document how to create custom data source
> and give some examples, instead of trying to guess what will be needed by 
> users.

Yeah, while DBCP2 by itself is probably alive and well, I'd rather we move 
trivial integrations into the docs. I suspect this one falls in a "trivial" 
category.

In other words I am +1 on all of these.

Andrus

Re: Upcoming deprecations in 4.1 version

[Nikita Timofeev]

Thanks for feedback.

Password encoding is a more distant thing to happen, for start it can be simply
moved to runtime out of the modeler.
But looking at the recent discussion [1] I think we need to redesign this part.

As for dbpc2,if it is a requirement it can be replaced by one line of
meaningful code
in runtime (it is what our code essentially do) :

org.apache.commons.dbcp2.BasicDataSourceFactory.createDataSource(properties);

If we keep dbcp2, then for consistency we should provide wrappers
for all other popular connection pools (and/or custom datasource providers).
And that will lead to great support effort, that we can't handle
effectively, I think.

For me it seems better to document how to create custom data source
and give some examples, instead of trying to guess what will be needed by users.

[1] 
https://lists.apache.org/thread.html/6618af9f0d96718c66b5a7a9dd3788142945aa388cf5a8923bea0391@%3Cuser.cayenne.apache.org%3E

On Fri, Feb 2, 2018 at 4:09 PM, Michael Gentry  wrote:
> On Fri, Feb 2, 2018 at 2:53 AM, Nikita Timofeev 
> wrote:
>
>> - cayenne-dbcp2 support;
>> Does anyone still using this?
>>
>> - password encoding settings in the Modeler
>> This one is more about redesigning this feature, then just deprecation.
>> Think this should be discussed s
>> Just wanted to mention it here also.
>>
>
>  I know of at least one project (and think there are others) that is using
> the password encoding feature.  They have a web application and batch/cron
> jobs that use the same Cayenne Model/JAR with the encrypted password stored
> externally to make it easier to support their security requirements for
> password rotation (just have to update one file).  They are definitely
> using DBCPDataSourceFactory, although not yet on Cayenne 4.  How would
> cayenne-dbcp2
> going away impact them in the future?
>
> Thanks,
>
> mrg



-- 
Best regards,
Nikita Timofeev

Re: Upcoming deprecations in 4.1 version

[Michael Gentry]

On Fri, Feb 2, 2018 at 2:53 AM, Nikita Timofeev 
wrote:

> - cayenne-dbcp2 support;
> Does anyone still using this?
>
> - password encoding settings in the Modeler
> This one is more about redesigning this feature, then just deprecation.
> Think this should be discussed s
> Just wanted to mention it here also.
>

 I know of at least one project (and think there are others) that is using
the password encoding feature.  They have a web application and batch/cron
jobs that use the same Cayenne Model/JAR with the encrypted password stored
externally to make it easier to support their security requirements for
password rotation (just have to update one file).  They are definitely
using DBCPDataSourceFactory, although not yet on Cayenne 4.  How would
cayenne-dbcp2
going away impact them in the future?

Thanks,

mrg

Upcoming deprecations in 4.1 version

[Nikita Timofeev]

Hi all,

Want to share my plans for deprecating some stuff in *4.1* that is
outdated, and I don't see any good reason to support it in Cayenne
*after 4.1* (4.2 or 5.0?).

Here they are:

- cayenne-joda module
PR is already done for this, there is some discussion too [1].

- cayenne-dbcp2 support;
Does anyone still using this?

- password encoding settings in the Modeler
This one is more about redesigning this feature, then just deprecation.
Think this should be discussed s
Just wanted to mention it here also.


Want to hear your thoughts about this.

[1] https://github.com/apache/cayenne/pull/262

-- 
Best regards,
Nikita Timofeev