[GitHub] rlenferink closed pull request #22: migrated readdir_r (deprecated) to readdir.
rlenferink closed pull request #22: migrated readdir_r (deprecated) to readdir.
URL: https://github.com/apache/celix/pull/22
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/deployment_admin/private/src/deployment_admin.c
b/deployment_admin/private/src/deployment_admin.c
index 6c8c505e..f7c1edd4 100644
--- a/deployment_admin/private/src/deployment_admin.c
+++ b/deployment_admin/private/src/deployment_admin.c
@@ -505,15 +505,15 @@ static celix_status_t deploymentAdmin_deleteTree(char *
directory) {
status = CELIX_FILE_IO_EXCEPTION;
} else {
- struct dirent dp;
- struct dirent *result = NULL;
- int rc = readdir_r(dir, &dp, &result);
- while (rc == 0 && result != NULL) {
- if ((strcmp((dp.d_name), ".") != 0) &&
(strcmp((dp.d_name), "..") != 0)) {
+ struct dirent *dp;
+ errno = 0;
+ dp = readdir(dir);
+ while (dp != NULL) {
+ if ((strcmp((dp->d_name), ".") != 0) &&
(strcmp((dp->d_name), "..") != 0)) {
char subdir[512];
- snprintf(subdir, sizeof(subdir), "%s/%s",
directory, dp.d_name);
+ snprintf(subdir, sizeof(subdir), "%s/%s",
directory, dp->d_name);
- if (dp.d_type == DT_DIR) {
+ if (dp->d_type == DT_DIR) {
status =
deploymentAdmin_deleteTree(subdir);
} else {
if (remove(subdir) != 0) {
@@ -522,10 +522,11 @@ static celix_status_t deploymentAdmin_deleteTree(char *
directory) {
}
}
}
- rc = readdir_r(dir, &dp, &result);
+ errno = 0;
+ dp = readdir(dir);
}
- if (rc != 0) {
+ if (errno != 0) {
status = CELIX_FILE_IO_EXCEPTION;
}
diff --git a/framework/private/src/bundle_archive.c
b/framework/private/src/bundle_archive.c
index 3d0513db..6f128d30 100644
--- a/framework/private/src/bundle_archive.c
+++ b/framework/private/src/bundle_archive.c
@@ -202,23 +202,21 @@ celix_status_t bundleArchive_recreate(const char *
archiveRoot, bundle_archive_p
long highestId = -1;
char *location = NULL;
- struct dirent dent;
- struct dirent *result = NULL;
+ struct dirent *dent;
struct stat st;
- int rc;
- rc = readdir_r(archive->archiveRootDir, &dent,
&result);
- while (rc == 0 && result != NULL) {
+ dent = readdir(archive->archiveRootDir);
+ while (dent != NULL) {
char subdir[512];
- snprintf(subdir, 512, "%s/%s",
archiveRoot, dent.d_name);
+ snprintf(subdir, 512, "%s/%s",
archiveRoot, dent->d_name);
int rv = stat(subdir, &st);
- if (rv == 0 && S_ISDIR(st.st_mode) &&
(strncmp(dent.d_name, "version", 7) == 0)) {
- sscanf(dent.d_name,
"version%*d.%ld", &idx);
+ if (rv == 0 && S_ISDIR(st.st_mode) &&
(strncmp(dent->d_name, "version", 7) == 0)) {
+ sscanf(dent->d_name,
"version%*d.%ld", &idx);
if (idx > highestId) {
highestId = idx;
}
}
- rc = readdir_r(archive->archiveRootDir,
&dent, &result);
+ dent = readdir(archive->archiveRootDir);
}
status = CELIX_DO_IF(status,
bundleArchive_getRevisionLocation(archive, 0, &location));
@@ -751,15 +749,13 @@ static celix_status_t
bundleArchive_deleteTree(bundle_archive_pt archive, const
status = CELIX_FILE_IO_EXCEPTION;
} else {
- struct dirent dp;
- struct dirent *result = NULL;
- int rc = 0;
+ struc
[GitHub] jsjolen opened a new pull request #28: Feat 6 filter gtest
jsjolen opened a new pull request #28: Feat 6 filter gtest URL: https://github.com/apache/celix/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jsjolen commented on issue #28: Feat 6 filter gtest
jsjolen commented on issue #28: Feat 6 filter gtest URL: https://github.com/apache/celix/pull/28#issuecomment-467598601 Oops. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jsjolen closed pull request #28: Feat 6 filter gtest
jsjolen closed pull request #28: Feat 6 filter gtest URL: https://github.com/apache/celix/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jsjolen edited a comment on issue #28: Feat 6 filter gtest
jsjolen edited a comment on issue #28: Feat 6 filter gtest URL: https://github.com/apache/celix/pull/28#issuecomment-467598601 Oops. Thatäs not supposed to be here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #29: Update Cmake files to fix OSX build
rbulter opened a new pull request #29: Update Cmake files to fix OSX build URL: https://github.com/apache/celix/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #29: Update Cmake files to fix OSX build
rbulter opened a new pull request #29: Update Cmake files to fix OSX build URL: https://github.com/apache/celix/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter commented on issue #29: Update Cmake files to fix OSX build
rbulter commented on issue #29: Update Cmake files to fix OSX build URL: https://github.com/apache/celix/pull/29#issuecomment-492772935 I fixed the OSX build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter closed pull request #29: Update Cmake files to fix OSX build
rbulter closed pull request #29: Update Cmake files to fix OSX build URL: https://github.com/apache/celix/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter closed pull request #29: CELIX-462 Update Cmake files to fix OSX build
rbulter closed pull request #29: CELIX-462 Update Cmake files to fix OSX build URL: https://github.com/apache/celix/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #30: Feature/celix 462 fix osx build
rbulter opened a new pull request #30: Feature/celix 462 fix osx build URL: https://github.com/apache/celix/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter closed pull request #30: Feature/celix 462 fix osx build
rbulter closed pull request #30: Feature/celix 462 fix osx build URL: https://github.com/apache/celix/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #31: Feature/celix 462 fix osx build
rbulter opened a new pull request #31: Feature/celix 462 fix osx build URL: https://github.com/apache/celix/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes merged pull request #31: Feature/celix 462 fix osx build
pnoltes merged pull request #31: Feature/celix 462 fix osx build URL: https://github.com/apache/celix/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #32: Merge pull request #1 from apache/develop
rbulter opened a new pull request #32: Merge pull request #1 from apache/develop URL: https://github.com/apache/celix/pull/32 Merge Develop This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter closed pull request #32: Merge pull request #1 from apache/develop
rbulter closed pull request #32: Merge pull request #1 from apache/develop URL: https://github.com/apache/celix/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter commented on issue #32: Merge pull request #1 from apache/develop
rbulter commented on issue #32: Merge pull request #1 from apache/develop URL: https://github.com/apache/celix/pull/32#issuecomment-506022266 Merge apace helix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #32: Merge pull request #1 from apache/develop
rbulter opened a new pull request #32: Merge pull request #1 from apache/develop URL: https://github.com/apache/celix/pull/32 Merge Develop This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter closed pull request #32: Merge pull request #1 from apache/develop
rbulter closed pull request #32: Merge pull request #1 from apache/develop URL: https://github.com/apache/celix/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] dhbfischer opened a new pull request #33: Added HTTP/websocket admin with civetweb as server
dhbfischer opened a new pull request #33: Added HTTP/websocket admin with civetweb as server URL: https://github.com/apache/celix/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #34: Feature/add tcp pubsub endpoint
rbulter opened a new pull request #34: Feature/add tcp pubsub endpoint URL: https://github.com/apache/celix/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #34: Feature/add tcp pubsub endpoint
rlenferink commented on issue #34: Feature/add tcp pubsub endpoint URL: https://github.com/apache/celix/pull/34#issuecomment-509091689 Hi @rbulter. Thanks for your contribution of a TCP pubsubadmin to Celix. However, it looks like the tests for the TCP pubsubadmin are failing: https://travis-ci.org/apache/celix/builds/555472206 https://travis-ci.org/apache/celix/jobs/555472207#L6499 Can you have a look at those as well? You can leave the PR open and once fixed squash the commits into a single commit again. That way Travis will build this PR every time you commit something ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on a change in pull request #34: Feature/add tcp pubsub endpoint
rlenferink commented on a change in pull request #34: Feature/add tcp pubsub endpoint URL: https://github.com/apache/celix/pull/34#discussion_r300936011 ## File path: bundles/pubsub/pubsub_admin_tcp/CMakeLists.txt ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +#if (BUILD_PUBSUB_PSA_TCP) Review comment: Remove if This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on a change in pull request #34: Feature/add tcp pubsub endpoint
rlenferink commented on a change in pull request #34: Feature/add tcp pubsub
endpoint
URL: https://github.com/apache/celix/pull/34#discussion_r300937458
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -0,0 +1,745 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership. The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the
+ *"License"); you may not use this file except in compliance
+ *with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *Unless required by applicable law or agreed to in writing,
+ *software distributed under the License is distributed on an
+ *"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ *specific language governing permissions and limitations
+ *under the License.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "pubsub_tcp_handler.h"
+#include "pubsub_tcp_topic_receiver.h"
+#include "pubsub_psa_tcp_constants.h"
+#include "pubsub_tcp_common.h"
+
+#include
+#include
+
+#define MAX_EPOLL_EVENTS 16
+#ifndef UUID_STR_LEN
+#define UUID_STR_LEN 37
+#endif
+
+
+#define L_DEBUG(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_DEBUG, __VA_ARGS__)
+#define L_INFO(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_INFO, __VA_ARGS__)
+#define L_WARN(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_WARNING, __VA_ARGS__)
+#define L_ERROR(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_ERROR, __VA_ARGS__)
+
+struct pubsub_tcp_topic_receiver {
+ celix_bundle_context_t *ctx;
+ log_helper_t *logHelper;
+ long serializerSvcId;
+ pubsub_serializer_service_t *serializer;
+ char *scope;
+ char *topic;
+ char scopeAndTopicFilter[5];
+ bool metricsEnabled;
+ pubsub_tcpHandler_pt socketHandler;
+ pubsub_tcpHandler_pt sharedSocketHandler;
+
+ struct {
+celix_thread_t thread;
+celix_thread_mutex_t mutex;
+bool running;
+ } thread;
+
+ struct {
+celix_thread_mutex_t mutex;
+hash_map_t *map; //key = tcp url, value =
psa_tcp_requested_connection_entry_t*
+bool allConnected; //true if all requestedConnectection are connected
+ } requestedConnections;
+
+ long subscriberTrackerId;
+ struct {
+celix_thread_mutex_t mutex;
+hash_map_t *map; //key = bnd id, value = psa_tcp_subscriber_entry_t
+bool allInitialized;
+ } subscribers;
+};
+
+typedef struct psa_tcp_requested_connection_entry {
+ pubsub_tcp_topic_receiver_t *parent;
+ char *key;
+ char *url;
+ int fd;
+ bool connected;
+ bool statically; //true if the connection is statically configured through
the topic properties.
+} psa_tcp_requested_connection_entry_t;
+
+typedef struct psa_tcp_subscriber_metrics_entry_t {
+ unsigned int msgTypeId;
+ uuid_t origin;
+
+ unsigned long nrOfMessagesReceived;
+ unsigned long nrOfSerializationErrors;
+ struct timespec lastMessageReceived;
+ double averageTimeBetweenMessagesInSeconds;
+ double averageSerializationTimeInSeconds;
+ double averageDelayInSeconds;
+ double maxDelayInSeconds;
+ double minDelayInSeconds;
+ unsigned int lastSeqNr;
+ unsigned long nrOfMissingSeqNumbers;
+} psa_tcp_subscriber_metrics_entry_t;
+
+typedef struct psa_tcp_subscriber_entry {
+ int usageCount;
+ hash_map_t *msgTypes; //map from serializer svc
+ hash_map_t *metrics; //key = msg type id, value = hash_map (key = origin
uuid, value = psa_tcp_subscriber_metrics_entry_t*
+ pubsub_subscriber_t *svc;
+ bool initialized; //true if the init function is called through the receive
thread
+} psa_tcp_subscriber_entry_t;
+
+
+static void pubsub_tcpTopicReceiver_addSubscriber(void *handle, void *svc,
const celix_properties_t *props,
+ const celix_bundle_t *owner);
+
+static void pubsub_tcpTopicReceiver_removeSubscriber(void *handle, void *svc,
const celix_properties_t *props,
+ const celix_bundle_t
*owner);
+
+static void *psa_tcp_recvThread(void *data);
+
+static void
psa_tcp_connectToAllRequestedConnections(pubsub_tcp_topic_receiver_t *receiver);
+
+static void psa_tcp_initializeAllSubscribers(pubsub_tcp_topic_receiver_t
*receiver);
+
+static void processMsg(void* handle, const pubsub_tcp_msg_header_t *hdr, const
unsigned char *payload, size_t payloadSize, struct timespec *receiveTime);
+static void psa_tcp_connectHandler(void *handle, const char *url, bool lock);
+static void psa_tcp_disConnectHandler(void *handle, const char *url);
+
+
+
+pubsub_tcp_topic_receiver_t
*pubsub_tcpTopicReceiver_create(celix_bundle_context_t *ctx,
+
[GitHub] [celix] rlenferink commented on a change in pull request #34: Feature/add tcp pubsub endpoint
rlenferink commented on a change in pull request #34: Feature/add tcp pubsub
endpoint
URL: https://github.com/apache/celix/pull/34#discussion_r300939510
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -0,0 +1,745 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership. The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the
+ *"License"); you may not use this file except in compliance
+ *with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *Unless required by applicable law or agreed to in writing,
+ *software distributed under the License is distributed on an
+ *"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ *specific language governing permissions and limitations
+ *under the License.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "pubsub_tcp_handler.h"
+#include "pubsub_tcp_topic_receiver.h"
+#include "pubsub_psa_tcp_constants.h"
+#include "pubsub_tcp_common.h"
+
+#include
+#include
+
+#define MAX_EPOLL_EVENTS 16
+#ifndef UUID_STR_LEN
+#define UUID_STR_LEN 37
+#endif
+
+
+#define L_DEBUG(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_DEBUG, __VA_ARGS__)
+#define L_INFO(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_INFO, __VA_ARGS__)
+#define L_WARN(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_WARNING, __VA_ARGS__)
+#define L_ERROR(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_ERROR, __VA_ARGS__)
+
+struct pubsub_tcp_topic_receiver {
+ celix_bundle_context_t *ctx;
+ log_helper_t *logHelper;
+ long serializerSvcId;
+ pubsub_serializer_service_t *serializer;
+ char *scope;
+ char *topic;
+ char scopeAndTopicFilter[5];
+ bool metricsEnabled;
+ pubsub_tcpHandler_pt socketHandler;
+ pubsub_tcpHandler_pt sharedSocketHandler;
+
+ struct {
+celix_thread_t thread;
+celix_thread_mutex_t mutex;
+bool running;
+ } thread;
+
+ struct {
+celix_thread_mutex_t mutex;
+hash_map_t *map; //key = tcp url, value =
psa_tcp_requested_connection_entry_t*
+bool allConnected; //true if all requestedConnectection are connected
+ } requestedConnections;
+
+ long subscriberTrackerId;
+ struct {
+celix_thread_mutex_t mutex;
+hash_map_t *map; //key = bnd id, value = psa_tcp_subscriber_entry_t
+bool allInitialized;
+ } subscribers;
+};
+
+typedef struct psa_tcp_requested_connection_entry {
+ pubsub_tcp_topic_receiver_t *parent;
+ char *key;
+ char *url;
+ int fd;
+ bool connected;
+ bool statically; //true if the connection is statically configured through
the topic properties.
+} psa_tcp_requested_connection_entry_t;
+
+typedef struct psa_tcp_subscriber_metrics_entry_t {
+ unsigned int msgTypeId;
+ uuid_t origin;
+
+ unsigned long nrOfMessagesReceived;
+ unsigned long nrOfSerializationErrors;
+ struct timespec lastMessageReceived;
+ double averageTimeBetweenMessagesInSeconds;
+ double averageSerializationTimeInSeconds;
+ double averageDelayInSeconds;
+ double maxDelayInSeconds;
+ double minDelayInSeconds;
+ unsigned int lastSeqNr;
+ unsigned long nrOfMissingSeqNumbers;
+} psa_tcp_subscriber_metrics_entry_t;
+
+typedef struct psa_tcp_subscriber_entry {
+ int usageCount;
+ hash_map_t *msgTypes; //map from serializer svc
+ hash_map_t *metrics; //key = msg type id, value = hash_map (key = origin
uuid, value = psa_tcp_subscriber_metrics_entry_t*
+ pubsub_subscriber_t *svc;
+ bool initialized; //true if the init function is called through the receive
thread
+} psa_tcp_subscriber_entry_t;
+
+
+static void pubsub_tcpTopicReceiver_addSubscriber(void *handle, void *svc,
const celix_properties_t *props,
+ const celix_bundle_t *owner);
+
+static void pubsub_tcpTopicReceiver_removeSubscriber(void *handle, void *svc,
const celix_properties_t *props,
+ const celix_bundle_t
*owner);
+
+static void *psa_tcp_recvThread(void *data);
+
+static void
psa_tcp_connectToAllRequestedConnections(pubsub_tcp_topic_receiver_t *receiver);
+
+static void psa_tcp_initializeAllSubscribers(pubsub_tcp_topic_receiver_t
*receiver);
+
+static void processMsg(void* handle, const pubsub_tcp_msg_header_t *hdr, const
unsigned char *payload, size_t payloadSize, struct timespec *receiveTime);
+static void psa_tcp_connectHandler(void *handle, const char *url, bool lock);
+static void psa_tcp_disConnectHandler(void *handle, const char *url);
+
+
+
+pubsub_tcp_topic_receiver_t
*pubsub_tcpTopicReceiver_create(celix_bundle_context_t *ctx,
+
[GitHub] [celix] rlenferink commented on a change in pull request #34: Feature/add tcp pubsub endpoint
rlenferink commented on a change in pull request #34: Feature/add tcp pubsub
endpoint
URL: https://github.com/apache/celix/pull/34#discussion_r300939596
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -0,0 +1,745 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership. The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the
+ *"License"); you may not use this file except in compliance
+ *with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *Unless required by applicable law or agreed to in writing,
+ *software distributed under the License is distributed on an
+ *"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ *specific language governing permissions and limitations
+ *under the License.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "pubsub_tcp_handler.h"
+#include "pubsub_tcp_topic_receiver.h"
+#include "pubsub_psa_tcp_constants.h"
+#include "pubsub_tcp_common.h"
+
+#include
+#include
+
+#define MAX_EPOLL_EVENTS 16
+#ifndef UUID_STR_LEN
+#define UUID_STR_LEN 37
+#endif
+
+
+#define L_DEBUG(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_DEBUG, __VA_ARGS__)
+#define L_INFO(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_INFO, __VA_ARGS__)
+#define L_WARN(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_WARNING, __VA_ARGS__)
+#define L_ERROR(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_ERROR, __VA_ARGS__)
+
+struct pubsub_tcp_topic_receiver {
+ celix_bundle_context_t *ctx;
+ log_helper_t *logHelper;
+ long serializerSvcId;
+ pubsub_serializer_service_t *serializer;
+ char *scope;
+ char *topic;
+ char scopeAndTopicFilter[5];
+ bool metricsEnabled;
+ pubsub_tcpHandler_pt socketHandler;
+ pubsub_tcpHandler_pt sharedSocketHandler;
+
+ struct {
+celix_thread_t thread;
+celix_thread_mutex_t mutex;
+bool running;
+ } thread;
+
+ struct {
+celix_thread_mutex_t mutex;
+hash_map_t *map; //key = tcp url, value =
psa_tcp_requested_connection_entry_t*
+bool allConnected; //true if all requestedConnectection are connected
+ } requestedConnections;
+
+ long subscriberTrackerId;
+ struct {
+celix_thread_mutex_t mutex;
+hash_map_t *map; //key = bnd id, value = psa_tcp_subscriber_entry_t
+bool allInitialized;
+ } subscribers;
+};
+
+typedef struct psa_tcp_requested_connection_entry {
+ pubsub_tcp_topic_receiver_t *parent;
+ char *key;
+ char *url;
+ int fd;
+ bool connected;
+ bool statically; //true if the connection is statically configured through
the topic properties.
+} psa_tcp_requested_connection_entry_t;
+
+typedef struct psa_tcp_subscriber_metrics_entry_t {
+ unsigned int msgTypeId;
+ uuid_t origin;
+
+ unsigned long nrOfMessagesReceived;
+ unsigned long nrOfSerializationErrors;
+ struct timespec lastMessageReceived;
+ double averageTimeBetweenMessagesInSeconds;
+ double averageSerializationTimeInSeconds;
+ double averageDelayInSeconds;
+ double maxDelayInSeconds;
+ double minDelayInSeconds;
+ unsigned int lastSeqNr;
+ unsigned long nrOfMissingSeqNumbers;
+} psa_tcp_subscriber_metrics_entry_t;
+
+typedef struct psa_tcp_subscriber_entry {
+ int usageCount;
+ hash_map_t *msgTypes; //map from serializer svc
+ hash_map_t *metrics; //key = msg type id, value = hash_map (key = origin
uuid, value = psa_tcp_subscriber_metrics_entry_t*
+ pubsub_subscriber_t *svc;
+ bool initialized; //true if the init function is called through the receive
thread
+} psa_tcp_subscriber_entry_t;
+
+
+static void pubsub_tcpTopicReceiver_addSubscriber(void *handle, void *svc,
const celix_properties_t *props,
+ const celix_bundle_t *owner);
+
+static void pubsub_tcpTopicReceiver_removeSubscriber(void *handle, void *svc,
const celix_properties_t *props,
+ const celix_bundle_t
*owner);
+
+static void *psa_tcp_recvThread(void *data);
+
+static void
psa_tcp_connectToAllRequestedConnections(pubsub_tcp_topic_receiver_t *receiver);
+
+static void psa_tcp_initializeAllSubscribers(pubsub_tcp_topic_receiver_t
*receiver);
+
+static void processMsg(void* handle, const pubsub_tcp_msg_header_t *hdr, const
unsigned char *payload, size_t payloadSize, struct timespec *receiveTime);
+static void psa_tcp_connectHandler(void *handle, const char *url, bool lock);
+static void psa_tcp_disConnectHandler(void *handle, const char *url);
+
+
+
+pubsub_tcp_topic_receiver_t
*pubsub_tcpTopicReceiver_create(celix_bundle_context_t *ctx,
+
[GitHub] [celix] rlenferink commented on a change in pull request #34: Feature/add tcp pubsub endpoint
rlenferink commented on a change in pull request #34: Feature/add tcp pubsub
endpoint
URL: https://github.com/apache/celix/pull/34#discussion_r300939510
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c
##
@@ -0,0 +1,745 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership. The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the
+ *"License"); you may not use this file except in compliance
+ *with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *Unless required by applicable law or agreed to in writing,
+ *software distributed under the License is distributed on an
+ *"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ *specific language governing permissions and limitations
+ *under the License.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "pubsub_tcp_handler.h"
+#include "pubsub_tcp_topic_receiver.h"
+#include "pubsub_psa_tcp_constants.h"
+#include "pubsub_tcp_common.h"
+
+#include
+#include
+
+#define MAX_EPOLL_EVENTS 16
+#ifndef UUID_STR_LEN
+#define UUID_STR_LEN 37
+#endif
+
+
+#define L_DEBUG(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_DEBUG, __VA_ARGS__)
+#define L_INFO(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_INFO, __VA_ARGS__)
+#define L_WARN(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_WARNING, __VA_ARGS__)
+#define L_ERROR(...) \
+logHelper_log(receiver->logHelper, OSGI_LOGSERVICE_ERROR, __VA_ARGS__)
+
+struct pubsub_tcp_topic_receiver {
+ celix_bundle_context_t *ctx;
+ log_helper_t *logHelper;
+ long serializerSvcId;
+ pubsub_serializer_service_t *serializer;
+ char *scope;
+ char *topic;
+ char scopeAndTopicFilter[5];
+ bool metricsEnabled;
+ pubsub_tcpHandler_pt socketHandler;
+ pubsub_tcpHandler_pt sharedSocketHandler;
+
+ struct {
+celix_thread_t thread;
+celix_thread_mutex_t mutex;
+bool running;
+ } thread;
+
+ struct {
+celix_thread_mutex_t mutex;
+hash_map_t *map; //key = tcp url, value =
psa_tcp_requested_connection_entry_t*
+bool allConnected; //true if all requestedConnectection are connected
+ } requestedConnections;
+
+ long subscriberTrackerId;
+ struct {
+celix_thread_mutex_t mutex;
+hash_map_t *map; //key = bnd id, value = psa_tcp_subscriber_entry_t
+bool allInitialized;
+ } subscribers;
+};
+
+typedef struct psa_tcp_requested_connection_entry {
+ pubsub_tcp_topic_receiver_t *parent;
+ char *key;
+ char *url;
+ int fd;
+ bool connected;
+ bool statically; //true if the connection is statically configured through
the topic properties.
+} psa_tcp_requested_connection_entry_t;
+
+typedef struct psa_tcp_subscriber_metrics_entry_t {
+ unsigned int msgTypeId;
+ uuid_t origin;
+
+ unsigned long nrOfMessagesReceived;
+ unsigned long nrOfSerializationErrors;
+ struct timespec lastMessageReceived;
+ double averageTimeBetweenMessagesInSeconds;
+ double averageSerializationTimeInSeconds;
+ double averageDelayInSeconds;
+ double maxDelayInSeconds;
+ double minDelayInSeconds;
+ unsigned int lastSeqNr;
+ unsigned long nrOfMissingSeqNumbers;
+} psa_tcp_subscriber_metrics_entry_t;
+
+typedef struct psa_tcp_subscriber_entry {
+ int usageCount;
+ hash_map_t *msgTypes; //map from serializer svc
+ hash_map_t *metrics; //key = msg type id, value = hash_map (key = origin
uuid, value = psa_tcp_subscriber_metrics_entry_t*
+ pubsub_subscriber_t *svc;
+ bool initialized; //true if the init function is called through the receive
thread
+} psa_tcp_subscriber_entry_t;
+
+
+static void pubsub_tcpTopicReceiver_addSubscriber(void *handle, void *svc,
const celix_properties_t *props,
+ const celix_bundle_t *owner);
+
+static void pubsub_tcpTopicReceiver_removeSubscriber(void *handle, void *svc,
const celix_properties_t *props,
+ const celix_bundle_t
*owner);
+
+static void *psa_tcp_recvThread(void *data);
+
+static void
psa_tcp_connectToAllRequestedConnections(pubsub_tcp_topic_receiver_t *receiver);
+
+static void psa_tcp_initializeAllSubscribers(pubsub_tcp_topic_receiver_t
*receiver);
+
+static void processMsg(void* handle, const pubsub_tcp_msg_header_t *hdr, const
unsigned char *payload, size_t payloadSize, struct timespec *receiveTime);
+static void psa_tcp_connectHandler(void *handle, const char *url, bool lock);
+static void psa_tcp_disConnectHandler(void *handle, const char *url);
+
+
+
+pubsub_tcp_topic_receiver_t
*pubsub_tcpTopicReceiver_create(celix_bundle_context_t *ctx,
+
[GitHub] [celix-site] rlenferink opened a new pull request #7: Converted site to Hugo
rlenferink opened a new pull request #7: Converted site to Hugo URL: https://github.com/apache/celix-site/pull/7 The pull request contains the Celix site converted from Jekyll to Hugo. This is described on the [mailing list](https://lists.apache.org/thread.html/1e83c6fc0f1bab00d42867ecd2ffd27cbf9011b9b652fb6fc95c75fd@%3Cdev.celix.apache.org%3E) and can be merged by lazy consensus after 2019/07/12 18:54:42 (UTC+2). I am creating a pull request to test the deploy previews of Netlify. Per pull request a preview will be generated so new contributors are able to preview the generated site very quickly and reviewing new contributions will be easier as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix-site] netlify[bot] commented on issue #7: Converted site to Hugo
netlify[bot] commented on issue #7: Converted site to Hugo URL: https://github.com/apache/celix-site/pull/7#issuecomment-510947939 Deploy preview for *celix-staging* ready! Built with commit 1e44b19fd08ac4878e860785e7b147d34608b885 https://deploy-preview-7--celix-staging.netlify.com This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix-site] rlenferink merged pull request #7: Converted site to Hugo
rlenferink merged pull request #7: Converted site to Hugo URL: https://github.com/apache/celix-site/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #33: Added HTTP/websocket admin with civetweb as server
rlenferink commented on issue #33: Added HTTP/websocket admin with civetweb as server URL: https://github.com/apache/celix/pull/33#issuecomment-511373473 Hi @dhbfischer, after voting on [dev@celix](https://lists.apache.org/thread.html/b14b2c4221d40d0b610de738f6682b24de0e3d179ac13ad0f1b5df71@%3Cdev.celix.apache.org%3E) and [general@incubator](https://lists.apache.org/thread.html/c0c8abef5eda7462147ebcf0fa5cbd10ec06c3246065674e995da062@%3Cgeneral.incubator.apache.org%3E) this donation is now accepted. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #33: Added HTTP/websocket admin with civetweb as server
rlenferink merged pull request #33: Added HTTP/websocket admin with civetweb as server URL: https://github.com/apache/celix/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] dhbfischer opened a new pull request #35: Http admin
dhbfischer opened a new pull request #35: Http admin URL: https://github.com/apache/celix/pull/35 A few improvements for HTTP admin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #35: Http admin
rlenferink merged pull request #35: Http admin URL: https://github.com/apache/celix/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter closed pull request #34: Feature/add tcp pubsub endpoint
rbulter closed pull request #34: Feature/add tcp pubsub endpoint URL: https://github.com/apache/celix/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #36: Add pubsub_admin_tcp
rbulter opened a new pull request #36: Add pubsub_admin_tcp URL: https://github.com/apache/celix/pull/36 Add PubSub_admin_tcp This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #36: Add pubsub_admin_tcp
rlenferink commented on issue #36: Add pubsub_admin_tcp URL: https://github.com/apache/celix/pull/36#issuecomment-513105079 Hi @rbulter thanks for your contribution. I've reviewed this contribution and it looks good to me. Because this is a substantial contribution (a new pubsub admin) we need to do a vote on our dev@celix mailing list on accepting the code. After that we need to go through the formal IP clearance process to ensure that proper attention is paid to intellectual property. I will start a formal vote on the dev@celix mailing list on accepting this code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] dhbfischer opened a new pull request #37: Framework bugfixes
dhbfischer opened a new pull request #37: Framework bugfixes URL: https://github.com/apache/celix/pull/37 Fixed segmentation faults with dangling service trackers and service registrations This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #37: Framework bugfixes
rlenferink merged pull request #37: Framework bugfixes URL: https://github.com/apache/celix/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #36: Add pubsub_admin_tcp
rlenferink commented on issue #36: Add pubsub_admin_tcp URL: https://github.com/apache/celix/pull/36#issuecomment-515703038 Hi @rbulter, after voting on [dev@celix](https://lists.apache.org/thread.html/0f9ba172a6eee909173b70d8552b58a9fa4928f1f067d5b1b3d134ed@%3Cdev.celix.apache.org%3E) and [general@incubator](https://lists.apache.org/thread.html/f613462951da7b2ce05ae4cca076285b98b4d2419901f9ebb642e8ac@%3Cgeneral.incubator.apache.org%3E) this donation is now accepted. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #36: Add pubsub_admin_tcp
rlenferink merged pull request #36: Add pubsub_admin_tcp URL: https://github.com/apache/celix/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink opened a new pull request #38: Added support for custom msg ids in descriptor
rlenferink opened a new pull request #38: Added support for custom msg ids in descriptor URL: https://github.com/apache/celix/pull/38 This PR adds support for custom message ids to message descriptors. If no message ID is specified, the default 'utils_stringHash' function is used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] dhbfischer opened a new pull request #39: Added pubsub admin websocket
dhbfischer opened a new pull request #39: Added pubsub admin websocket URL: https://github.com/apache/celix/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #39: Added pubsub admin websocket
rlenferink commented on issue #39: Added pubsub admin websocket URL: https://github.com/apache/celix/pull/39#issuecomment-519526567 Hi @dhbfischer. Thanks for yet another code donation. I've reviewed this contribution and it looks good to me. It is building and tests are running as well (1 test is failing but that is in another component and was failing before this PR as well). Because this is a new component and a substantial contribution we need to do a vote on our dev@celix mailing list. After that we also need to go through the formal IP clearance process to ensure that proper attention is paid to intellectual property. I will start a formal vote on the dev@celix mailing list on accepting this code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #40: Fix tcp seg fault
rbulter opened a new pull request #40: Fix tcp seg fault URL: https://github.com/apache/celix/pull/40 This pull request fixes: - tcp admin segfault when unloading service - make the tcp examples work. @pnoltes I have fixed some issues pubsub topology admin. that fixes crashes when unloading a pubsub tcp / zmq / etc admin. and make possible that a receiver will receive data after unloading / loading the service pubsub tcp / zmq/ etc admin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter closed pull request #40: Fix tcp seg fault
rbulter closed pull request #40: Fix tcp seg fault URL: https://github.com/apache/celix/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #41: - Fix TCP example.
rbulter opened a new pull request #41: - Fix TCP example. URL: https://github.com/apache/celix/pull/41 - Remove TCP crash after unloading tcp admin service (Problem in pubsub topology admin) - Enable pubsub sending after unloading pubsub tcp admin (Problem in pubsub topology admin) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter commented on issue #41: - Fix TCP example.
rbulter commented on issue #41: - Fix TCP example. URL: https://github.com/apache/celix/pull/41#issuecomment-519690426 This pull request fixes: - tcp admin segfault when unloading service - make the tcp examples work. @pnoltes I have fixed some issues pubsub topology admin. that fixes crashes when unloading a pubsub tcp / zmq / etc admin. and make possible that a receiver will receive data after unloading / loading the service pubsub tcp / zmq/ etc admin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on a change in pull request #41: - Fix TCP example.
rlenferink commented on a change in pull request #41: - Fix TCP example. URL: https://github.com/apache/celix/pull/41#discussion_r312465533 ## File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_sender.c ## @@ -198,7 +195,7 @@ pubsub_tcp_topic_sender_t *pubsub_tcpTopicSender_create( char *url = NULL; asprintf(&url, "tcp://%s:%u", bindIP, port); char *bindUrl = NULL; -asprintf(&bindUrl, "tcp://0.0.0.0:%u", port); +asprintf(&bindUrl, "tcp://127.0.0.1:%u", port); Review comment: Why change this to localhost instead of 0.0.0.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter commented on a change in pull request #41: - Fix TCP example.
rbulter commented on a change in pull request #41: - Fix TCP example. URL: https://github.com/apache/celix/pull/41#discussion_r312608715 ## File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_sender.c ## @@ -198,7 +195,7 @@ pubsub_tcp_topic_sender_t *pubsub_tcpTopicSender_create( char *url = NULL; asprintf(&url, "tcp://%s:%u", bindIP, port); char *bindUrl = NULL; -asprintf(&bindUrl, "tcp://0.0.0.0:%u", port); +asprintf(&bindUrl, "tcp://127.0.0.1:%u", port); Review comment: this is an error, i have fixed this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #41: - Fix TCP example.
rlenferink commented on issue #41: - Fix TCP example. URL: https://github.com/apache/celix/pull/41#issuecomment-521562407 Changes to the PSA look good to me. I did check out the changes and all our existing examples are still running fine and the `pubsub_publisher_tcp` & `pubsub_subscriber_tcp` examples are working as well now. @pnoltes can you confirm the changes to the topology manager are okay to be merged? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes merged pull request #41: - Fix TCP example.
pnoltes merged pull request #41: - Fix TCP example. URL: https://github.com/apache/celix/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink opened a new pull request #42: Added check for serializer type when connecting endpoints
rlenferink opened a new pull request #42: Added check for serializer type when connecting endpoints URL: https://github.com/apache/celix/pull/42 Updated the pubsub admins to check for serializer type when connecting endpoints. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #42: Added check for serializer type when connecting endpoints
rlenferink commented on issue #42: Added check for serializer type when connecting endpoints URL: https://github.com/apache/celix/pull/42#issuecomment-522503309 _Waiting for ICLA from Michiel_ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #42: Added check for serializer type when connecting endpoints
rlenferink merged pull request #42: Added check for serializer type when connecting endpoints URL: https://github.com/apache/celix/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #42: Added check for serializer type when connecting endpoints
rlenferink commented on issue #42: Added check for serializer type when connecting endpoints URL: https://github.com/apache/celix/pull/42#issuecomment-522737517 _ICLA received from Michiel_ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh opened a new pull request #43: Develop
idzardh opened a new pull request #43: Develop URL: https://github.com/apache/celix/pull/43 Implemented avpr parsing, generation of dyn_type en updating the serializer tests for the generated dyn_type This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #39: Added pubsub admin websocket
rlenferink merged pull request #39: Added pubsub admin websocket URL: https://github.com/apache/celix/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #43: Added avpr parsing and serialization
rlenferink commented on issue #43: Added avpr parsing and serialization URL: https://github.com/apache/celix/pull/43#issuecomment-524793081 Can you update the `bundles/pubsub/pubsub_serializer_json` as well? => https://github.com/apache/celix/blob/develop/bundles/pubsub/pubsub_serializer_json/src/pubsub_serializer_impl.c#L250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh commented on issue #43: Added avpr parsing and serialization
idzardh commented on issue #43: Added avpr parsing and serialization URL: https://github.com/apache/celix/pull/43#issuecomment-526080299 Added json_serializer and fixed differences between build types. All tests passed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #43: Added avpr parsing and serialization
rlenferink merged pull request #43: Added avpr parsing and serialization URL: https://github.com/apache/celix/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes opened a new pull request #44: Initial setup for a GitHub Ci flow
pnoltes opened a new pull request #44: Initial setup for a GitHub Ci flow URL: https://github.com/apache/celix/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes closed pull request #44: Initial setup for a GitHub Ci flow
pnoltes closed pull request #44: Initial setup for a GitHub Ci flow URL: https://github.com/apache/celix/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #38: Added support for custom msg ids in descriptor
rlenferink merged pull request #38: Added support for custom msg ids in descriptor URL: https://github.com/apache/celix/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh opened a new pull request #45: Fix for curl dependency
idzardh opened a new pull request #45: Fix for curl dependency URL: https://github.com/apache/celix/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on a change in pull request #45: Fix for curl dependency
rlenferink commented on a change in pull request #45: Fix for curl dependency
URL: https://github.com/apache/celix/pull/45#discussion_r320109195
##
File path: CMakeLists.txt
##
@@ -49,6 +52,33 @@ ELSE ()
set(CMAKE_EXE_LINKER_FLAGS "-pthread ${CMAKE_EXE_LINKER_FLAGS}")
ENDIF()
+if(ENABLE_W_ERROR)
+set(CMAKE_CXX_FLAGS "-Werror ${CMAKE_CXX_FLAGS_DEBUG}")
Review comment:
This probably should be
```CMake
set(CMAKE_CXX_FLAGS "-Werror ${CMAKE_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS_DEBUG "-Werror ${CMAKE_CXX_FLAGS_DEBUG}")
```
Otherwise when setting the `ENABLE_W_ERROR` flag the DEBUG flags are always
included.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] rlenferink commented on a change in pull request #45: Fix for curl dependency
rlenferink commented on a change in pull request #45: Fix for curl dependency URL: https://github.com/apache/celix/pull/45#discussion_r320109770 ## File path: cmake/celix_project/AddOpenSSL.cmake ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# include(ExternalProject) +# ExternalProject_Add( +#openssl_project +# ) + +if (NOT TARGET OpenSSL::SSL) +add_library(OpenSSL::SSL GLOBAL) +set_target_properties(OpenSSL::SSL PROPERTIES +IMPORTED_LOCATION "/usr/lib/openssl/libssl.so" +INTERFACE_INCLUDE_DIRECTORIES "/usr/include/openssl" +) + # set(OPENSSL_ROOT_DIR "/usr/lib/openssl") +endif() + +if (NOT TARGET OpenSSL::Crypto) +add_library(OpenSSL::Crypto GLOBAL) +set_target_properties(OpenSSL::Crypto PROPERTIES +IMPORTED_LOCATION "/usr/lib/openssl/libcrypto.so" Review comment: Does this work when OpenSSL is installed at another location, e.g. `$HOME/.local/lib/openssl/libcrypto.so`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on issue #45: Fix for curl dependency
rlenferink commented on issue #45: Fix for curl dependency URL: https://github.com/apache/celix/pull/45#issuecomment-527325878 Note for the one approving this PR: please squash and merge due to the 42 commits in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink edited a comment on issue #45: Fix for curl dependency
rlenferink edited a comment on issue #45: Fix for curl dependency URL: https://github.com/apache/celix/pull/45#issuecomment-527325878 Note for the one merging this PR: please squash and merge due to the 42 commits in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh commented on a change in pull request #45: Fix for curl dependency
idzardh commented on a change in pull request #45: Fix for curl dependency URL: https://github.com/apache/celix/pull/45#discussion_r320111222 ## File path: cmake/celix_project/AddOpenSSL.cmake ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# include(ExternalProject) +# ExternalProject_Add( +#openssl_project +# ) + +if (NOT TARGET OpenSSL::SSL) +add_library(OpenSSL::SSL GLOBAL) +set_target_properties(OpenSSL::SSL PROPERTIES +IMPORTED_LOCATION "/usr/lib/openssl/libssl.so" +INTERFACE_INCLUDE_DIRECTORIES "/usr/include/openssl" +) + # set(OPENSSL_ROOT_DIR "/usr/lib/openssl") +endif() + +if (NOT TARGET OpenSSL::Crypto) +add_library(OpenSSL::Crypto GLOBAL) +set_target_properties(OpenSSL::Crypto PROPERTIES +IMPORTED_LOCATION "/usr/lib/openssl/libcrypto.so" Review comment: This script is not loaded, so it doesn't do anything (anymore). I tried this but it does not work, I will remove the file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #45: Fix for curl dependency
rlenferink merged pull request #45: Fix for curl dependency URL: https://github.com/apache/celix/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh opened a new pull request #46: Develop
idzardh opened a new pull request #46: Develop URL: https://github.com/apache/celix/pull/46 Allow for openssl dependencies with find_package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes commented on issue #46: Develop
pnoltes commented on issue #46: Develop
URL: https://github.com/apache/celix/pull/46#issuecomment-528506427
Could you update the FindOpenSSL.cmake with the following:
find_path(OPENSSL_INCLUDE_DIR ssl.h crypto.h
/usr/include/openssl
/usr/local/include/openssl
/usr/local/opt/openssl/include/openssl
${OPENSSL_DIR}/include/openssl)
find_library(OPENSSL_LIBRARY NAMES ssl
PATHS /usr/lib /usr/local/lib /usr/local/opt/openssl/lib
${OPENSSL_DIR}/lib)
I think this fixes the build issues on OSX
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] rlenferink commented on issue #46: Develop
rlenferink commented on issue #46: Develop URL: https://github.com/apache/celix/pull/46#issuecomment-528513361 @pnoltes remember to squash and merge (57 commits in this PR) and fill in an appropriate commit message This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh commented on issue #46: Develop
idzardh commented on issue #46: Develop URL: https://github.com/apache/celix/pull/46#issuecomment-528517593 @pnoltes your suggestion indeed fixed the build for OSX, thank you for the help! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes merged pull request #46: Develop
pnoltes merged pull request #46: Develop URL: https://github.com/apache/celix/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] dhbfischer opened a new pull request #47: Feature/http admin improvements
dhbfischer opened a new pull request #47: Feature/http admin improvements URL: https://github.com/apache/celix/pull/47 Improved deletion of http admin services This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] dhbfischer opened a new pull request #48: Feature/pubsub tcp admin fix
dhbfischer opened a new pull request #48: Feature/pubsub tcp admin fix URL: https://github.com/apache/celix/pull/48 Fixed tcp admin port extraction from string Fix for setting bind ip in sender This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on a change in pull request #48: Feature/pubsub tcp admin fix
rlenferink commented on a change in pull request #48: Feature/pubsub tcp admin
fix
URL: https://github.com/apache/celix/pull/48#discussion_r322751349
##
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##
@@ -451,7 +451,8 @@ void pubsub_tcpHandler_setUrlInfo(char *url,
pubsub_tcpHandler_url_t *url_info)
url_info->hostname = strtok(strdup(hostname), ":");
if (port) {
port += 1;
-if (isdigit(atoi(port)) == 0) url_info->portnr = atoi(port);
+unsigned int portDigits = (unsigned) atoi(port);
Review comment:
Probably the cast should be `(unsigned int)` as well (right now
`(unsigned)`).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] pnoltes merged pull request #47: Feature/http admin improvements
pnoltes merged pull request #47: Feature/http admin improvements URL: https://github.com/apache/celix/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes merged pull request #48: Feature/pubsub tcp admin fix
pnoltes merged pull request #48: Feature/pubsub tcp admin fix URL: https://github.com/apache/celix/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] dhbfischer opened a new pull request #49: Feature/openssl linking
dhbfischer opened a new pull request #49: Feature/openssl linking URL: https://github.com/apache/celix/pull/49 Added configurable openssl library for linking This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] coveralls commented on issue #49: Feature/openssl linking
coveralls commented on issue #49: Feature/openssl linking URL: https://github.com/apache/celix/pull/49#issuecomment-530246713 [](https://coveralls.io/builds/25646784) Coverage increased (+0.03%) to 58.569% when pulling **c7bc8e79996f8a9c5c7159412f26f54d4cc70900 on dhbfischer:feature/openssl_linking** into **53d0813fe5bd5c4da620e715837ebf418d723fb9 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes merged pull request #49: Feature/openssl linking
pnoltes merged pull request #49: Feature/openssl linking URL: https://github.com/apache/celix/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #50: Feature/fix tcp transmissions
rbulter opened a new pull request #50: Feature/fix tcp transmissions URL: https://github.com/apache/celix/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes opened a new pull request #51: Feature/handle hooks in registry
pnoltes opened a new pull request #51: Feature/handle hooks in registry URL: https://github.com/apache/celix/pull/51 Fixes a race condition issue with adding/removing service listener hooks (service trackers). Also fixes an mem issue in the json serialiser and refactors the pubsub tests to use service instead of a global pointer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink commented on a change in pull request #50: Feature/fix tcp transmissions
rlenferink commented on a change in pull request #50: Feature/fix tcp
transmissions
URL: https://github.com/apache/celix/pull/50#discussion_r324850011
##
File path: CMakeLists.txt
##
@@ -38,8 +38,10 @@ set(ENABLE_MORE_WARNINGS OFF)
IF (ANDROID)
set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -Wall ${CMAKE_C_FLAGS}")
ELSE ()
-set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -Wall -Werror -fPIC
${CMAKE_C_FLAGS}")
-set(CMAKE_CXX_FLAGS "-std=c++11 -Wall -Wextra -Weffc++ -fno-rtti
-fno-exceptions ${CMAKE_CXX_FLAGS}")
+set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -fPIC ${CMAKE_C_FLAGS}")
+set(CMAKE_CXX_FLAGS "-std=c++11 -fno-rtti
-fno-exceptions${CMAKE_CXX_FLAGS}")
Review comment:
A missing space is breaking the build
```suggestion
set(CMAKE_CXX_FLAGS "-std=c++11 -fno-rtti -fno-exceptions
${CMAKE_CXX_FLAGS}")
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] rlenferink merged pull request #50: Feature/fix tcp transmissions
rlenferink merged pull request #50: Feature/fix tcp transmissions URL: https://github.com/apache/celix/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #51: Feature/handle hooks in registry
rlenferink merged pull request #51: Feature/handle hooks in registry URL: https://github.com/apache/celix/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh opened a new pull request #52: Added parsing of internal types
idzardh opened a new pull request #52: Added parsing of internal types URL: https://github.com/apache/celix/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #52: Added parsing of internal types
rlenferink merged pull request #52: Added parsing of internal types URL: https://github.com/apache/celix/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh opened a new pull request #53: CELIX-468
idzardh opened a new pull request #53: CELIX-468 URL: https://github.com/apache/celix/pull/53 Renamed constants to celix_constants (including ifdef) Changed all includes to use new file name @pnoltes the issue mentions that some variables should be prefixed with CELIX, however all variables are already prefixed with either CELIX or OSGI, what would be the best way to proceed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes commented on issue #53: CELIX-468
pnoltes commented on issue #53: CELIX-468 URL: https://github.com/apache/celix/pull/53#issuecomment-533250446 > Renamed constants to celix_constants (including ifdef) > Changed all includes to use new file name > @pnoltes the issue mentions that some variables should be prefixed with CELIX, however all variables are already prefixed with either CELIX or OSGI, what would be the best way to proceed? I though not all constants had a CELIX_ or OSGI_ prefix. I see that they do, than this change is enough :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes merged pull request #53: CELIX-468
pnoltes merged pull request #53: CELIX-468 URL: https://github.com/apache/celix/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] idzardh opened a new pull request #54: CELIX-468 Two extra test-cases
idzardh opened a new pull request #54: CELIX-468 Two extra test-cases URL: https://github.com/apache/celix/pull/54 Apparently these are not compiled in any of the test scenarios on the build server, caught them during further testing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes merged pull request #54: CELIX-468 Two extra test-cases
pnoltes merged pull request #54: CELIX-468 Two extra test-cases URL: https://github.com/apache/celix/pull/54 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rbulter opened a new pull request #55: Feature/refactor tcp
rbulter opened a new pull request #55: Feature/refactor tcp URL: https://github.com/apache/celix/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #55: Feature/refactor tcp
rlenferink merged pull request #55: Feature/refactor tcp URL: https://github.com/apache/celix/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] pnoltes opened a new pull request #56: Adds a experimental dir to the Celix project and moves some bundles
pnoltes opened a new pull request #56: Adds a experimental dir to the Celix project and moves some bundles URL: https://github.com/apache/celix/pull/56 Currently more stable and unstable bundles are in the same dir, to make a more clear distiction what is consider really unstable/experimental the misc/experimental dir can be used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [celix] rlenferink merged pull request #56: Adds a experimental dir to the Celix project and moves some bundles
rlenferink merged pull request #56: Adds a experimental dir to the Celix project and moves some bundles URL: https://github.com/apache/celix/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
