Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)
On Jul 9, 2015, at 3:27 PM, David Nalley da...@gnsa.us wrote: On Thu, Jul 9, 2015 at 4:49 AM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 09-Jul-2015, at 12:50 pm, Sebastien Goasguen run...@gmail.com wrote: Let’s revert , that’s our new rule Since we have not voted what/how we are going to do commits, let’s treat this more of a guideline or honour code. Votes aren't strictly necessary. As a matter of fact, votes should be avoided if at all possible. We should strive for consensus, and when we have it, it is as binding as if we had a tally of votes. I’ve expressed few concersn on this rule wrt code reviewing for PRs that are not getting attention, so IMO let’s try to have the discussion and find solution before we really start enforcing them. So my take (FWIW) is that without the pain, we'll never adjust our method of operation or find the solutions. In example, no one came to the list asking for reviews. +1 --David
RE: Introducing Boris Schrijver
Welcome, Boris -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Thursday, July 9, 2015 2:19 AM To: dev@cloudstack.apache.org Cc: bo...@pcextreme.nl Subject: Re: Introducing Boris Schrijver Welcome, Boris :-) Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Wido den Hollander w...@widodh.nl To: dev@cloudstack.apache.org Cc: bo...@pcextreme.nl Sent: Wednesday, 8 July, 2015 16:08:09 Subject: Introducing Boris Schrijver Hi all, As you might know, we at PCextreme are using CloudStack for our public cloud offering and have been looking for a CloudStack dev for a long time. We found one; so let me introduce Boris Schrijver. Boris will be our fulltime CloudStack developer with no other purpose then making CloudStack better :) CloudStack is a Apache project, so it will be Boris contributing to CloudStack and NOT PCextreme as a company. He might become a committer one day, who knows. Today is his first day, so it will take a bit before you'll see the first PR coming in. Wido
Re: IRC and Slack
A bit rough, but you get the idea http://www.cloudstackforum.com/vanilla/ -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: sebgoa run...@gmail.com To: dev@cloudstack.apache.org Sent: Friday, 3 July, 2015 08:27:43 Subject: Re: IRC and Slack Some great ideas in there. I am +1 for: -consolidate #cloudstack-dev and #cloudstack -move bots to #cloudstack-announce -Remi's idea to publish slack message to #cloudstack (and vice versa). -the idea to use something like discourse or stack overflow etc… Somebody wants to take this on :) On Jul 2, 2015, at 11:13 PM, Nux! n...@li.nux.ro wrote: Hi, Our IRC channels seem to be dead, indeed, at least for user support purposes. IRC is pretty established and works great for many projects, it just requires people active then and there. Probably any form of chat will have the same fate no matter how trendy and personally -1 for anything like slack, hipchat etc. Perhaps a forum might be more user friendly than mailing lists? Discourse ( http://try.discourse.org/ ) looks pretty nice and feature-rich (login with github, facebook etc etc). My 2 cents -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Sebastien Goasguen run...@gmail.com To: dev@cloudstack.apache.org Sent: Thursday, 2 July, 2015 09:39:31 Subject: IRC and Slack Hi folks, IRC has been mostly deserted for a while now. But there are still folks hanging out there with unanswered questions. I also know of several slack channels on cloudstack. We need to take a decision here. Shall we officially abandon IRC and out a notice there that points towards Slack. If we do, how do we invite everyone to the slack channel ? -Sebastien
Build failed in Jenkins: simulator-singlerun #1355
See http://jenkins.buildacloud.org/job/simulator-singlerun/1355/ -- Started by upstream project build-master-simulator build number 2172 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by upstream project build-master build number 2459 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit'
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120222980 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120227544 Can you add some unit tests or marvin tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: simulator-singlerun #1354
See http://jenkins.buildacloud.org/job/simulator-singlerun/1354/ -- Started by upstream project build-master-simulator build number 2171 originally caused by: Started by an SCM change Started by an SCM change Started by upstream project build-master build number 2458 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] -
[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/574#issuecomment-120215440 This was much needed. The code looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-4.5 #496
See http://jenkins.buildacloud.org/job/build-4.5/496/changes Changes: [abhinandan.prateek] CLOUDSTACK-8624: Added the support for mysql db port and lowered the requiremnts for available disk capacity to 2.1GB VS original 5GB as it was too excessive. -- [...truncated 3191 lines...] [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-plugin-network-ssp --- [INFO] Compiling 17 source files to http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/stratosphere-ssp/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-vcs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 5 resources [INFO] Copying 0 resource [INFO] Copying 0 resource [INFO] Copying 0 resource [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-plugin-network-vcs --- [INFO] Compiling 44 source files to http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/brocade-vcs/target/classes [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-plugin-network-nvp --- [INFO] Surefire report directory: http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/nicira-nvp/target/surefire-reports --- T E S T S --- [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-plugin-network-vns --- [INFO] Surefire report directory: http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/bigswitch-vns/target/surefire-reports --- T E S T S --- Running com.cloud.network.nicira.NatRuleTest Running com.cloud.network.resource.BigSwitchVnsResourceTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.017 sec Running com.cloud.network.nicira.NiciraTagTest [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ssp --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/stratosphere-ssp/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-plugin-network-ssp --- [INFO] Compiling 2 source files to http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/stratosphere-ssp/target/test-classes log4j:WARN No appenders could be found for logger (com.cloud.network.nicira.NiciraNvpTag). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.336 sec Running com.cloud.network.nicira.NiciraNvpApiTest log4j:WARN No appenders could be found for logger (org.apache.commons.httpclient.params.DefaultHttpParams). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.817 sec Running com.cloud.network.bigswitch.BigSwitchApiTest Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.338 sec Running com.cloud.network.resource.NiciraNvpResourceTest [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-vcs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/brocade-vcs/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-plugin-network-vcs --- [INFO] Compiling 3 source files to http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/network-elements/brocade-vcs/target/test-classes Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.11 sec Tests run: 36, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.242 sec Running com.cloud.network.guru.NiciraNvpGuestNetworkGuruTest Results : Tests run: 30, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Network Opendaylight 4.5.2-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-opendaylight --- [INFO]
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119875445 +1 LGTM (self) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [PROPOSAL] Commit to master through PR only
On 07-Jul-2015, at 1:09 pm, sebgoa run...@gmail.commailto:run...@gmail.com wrote: The PR should not be squashed until it's reviewed and accepted. I am only arguing for squashing it when it is accepted and before merge. For now, I would love for us to focus on the 2 LGTM and green tests (as much as we can get them green). We can fine tune later. Two issues; - This seems to be already failing, under the Apache way IMO there is no way we can enforce and ensure that at least two people would review any and every PR. There are already a growing number of open PRs that we cannot close unless we get 2 LGTM. Should we put some sort of maximum wait time on PRs that attract no attention (review or discussions), say of 72 hours (excluding weekends) so at least committers can merge their changes? - In case of a release that is going to happen and feature freeze has started, in that case will new feature work and refactoring work be on hold to be merged on master. For example, features being worked on right now, what will happen to them as master/4.6 may not allow them to be merged (as they are new features). Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [PROPOSAL] Commit to master through PR only
On 09-Jul-2015, at 2:14 pm, Rohit Yadav rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com wrote: - This seems to be already failing, under the Apache way IMO there is no way we can enforce and ensure that at least two people would review any and every PR. There are already a growing number of open PRs that we cannot close unless we get 2 LGTM. Should we put some sort of maximum wait time on PRs that attract no attention (review or discussions), say of 72 hours (excluding weekends) so at least committers can merge their changes? Forgot to explicitly add in the suggestion above - Such attention-deficit PRs (no review, discussion or comment of any sorts) should only be merged if Travis is green along with other automated jenkins jobs (rat, build etc) we’ve setup. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...
Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/565#issuecomment-119905456 The changes Look Good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: package-rhel63-4.5 #291
See http://jenkins.buildacloud.org/job/package-rhel63-4.5/291/ -- Started by upstream project build-4.5 build number 495 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on rpmbuilder-2 in workspace http://jenkins.buildacloud.org/job/package-rhel63-4.5/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to rpmbuilder-2(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' Archiving artifacts
Build failed in Jenkins: simulator-4.5-singlerun #251
See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/251/ -- Started by upstream project build-4.5-simulator build number 306 originally caused by: Started by upstream project build-4.5 build number 495 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/569#issuecomment-119913350 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: coverity resource leaks
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/564#issuecomment-119917601 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/568#issuecomment-119917422 Looks good to me. Commented on older PR earlier. PR https://github.com/apache/cloudstack/pull/552 can be removed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: simulator-singlerun #1349
See http://jenkins.buildacloud.org/job/simulator-singlerun/1349/ -- Started by upstream project build-master-simulator build number 2166 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by upstream project build-master build number 2454 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the
[GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/560#issuecomment-119918219 Awesome, @rafaelweingartner Thanks for fixing it. LGTM @DaanHoogland would you mind to have a look at this one as well? Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/560#issuecomment-119919812 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/570#issuecomment-119920451 LGTM :+1: But, please, next time do it in 2 separate commits: 1 commit with file formatting 1 commit with the actual change It was a bit hard to see your changes in the middle of all formatting. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
GitHub user pavanb018 opened a pull request: https://github.com/apache/cloudstack/pull/569 Handling Basic Zone scenarios for starting VM in stopped state Basic Zone result: Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS === ok -- Ran 1 test in 41.609s OK Advanced Zone result: Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm | Status : SUCCESS === ok -- Ran 1 test in 139.844s OK You can merge this pull request into a Git repository by running: $ git pull https://github.com/pavanb018/cloudstack regfail Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/569.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #569 commit 7edbd902ea492c26a2210d2a2e1eef7b21d148db Author: pavan018 pavanbandarupa...@gmail.com Date: 2015-07-08T05:35:03Z Changes for Regression failures commit 861f901be933a76bd6a27e6bc12e0976c44a2a9c Author: pavan018 pavanbandarupa...@gmail.com Date: 2015-07-09T07:23:27Z Handling Basic zone failures in startVM with false condition --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...
Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/567#issuecomment-119841442 The commit looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)
On Jul 9, 2015, at 4:45 AM, Rajani Karuturi raj...@apache.org wrote: PR #565 is also closed with one review. I dont agree to adding an exception. Reviewing would be one way to get others engaged and become aware. Otherwise, they lay there untouched and unused. Let’s revert , that’s our new rule I am sure we have enough committers who can review. Lately, lot more folks are adding marvin tests as well. sailaja,sowmya,talluri,gaurav Can you review the PRs? Regarding the revert, Maybe we can wait for 8 more hours (to catch up on IST and other timezones) to get another review. If we dont get any review or if we get a -1, we should revert. ~Rajani On Thu, Jul 9, 2015 at 4:30 AM, David Nalley da...@gnsa.us wrote: More tests are good, on the other hand exceptions tend to beget exceptions at tremendous speed. On Wed, Jul 8, 2015 at 7:48 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: That was never formalized, hence I put it as a shakespearian question. I did sugest it otherwise I would have just reverted. I don't like the exception but if the number of people working on integration is to low to have a good flow we could. On Wed, Jul 8, 2015 at 1:46 PM, Sanjeev N sanj...@apache.org wrote: I thought there is a limitation on LGTMs for integration tests? On Wed, Jul 8, 2015 at 5:11 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: guys and dolss, this was closed with only 1 LGTM! we agreed not to submit with less then two ok reviews on master. So next steps? revert? some extra justification or else revert? . On Wed, Jul 8, 2015 at 12:39 PM, asfgit g...@git.apache.org wrote: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- -- Daan -- Daan
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...
On Thu, Jul 9, 2015 at 8:44 AM, pavanb018 g...@git.apache.org wrote: looks good to me pavanb018 you probably should write LGTM ;) -- Daan
Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)
On 09-Jul-2015, at 12:50 pm, Sebastien Goasguen run...@gmail.commailto:run...@gmail.com wrote: Let’s revert , that’s our new rule Since we have not voted what/how we are going to do commits, let’s treat this more of a guideline or honour code. I’ve expressed few concersn on this rule wrt code reviewing for PRs that are not getting attention, so IMO let’s try to have the discussion and find solution before we really start enforcing them. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
[GitHub] cloudstack pull request: Config drive changes for vm migration
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/552#issuecomment-119883042 LGTM. Nice option to have config drive ISO for meta data! Migration logic looks fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/570 CLOUDSTACK-8620 :skip test cases if rbd storage is not available in l⦠skipping tests based on storage for lxc hype and fixing pep8 issues test result = Test increasing volume size within the account limit and verify primary storage usage ... SKIP: unsupported storage type Test increasing volume size above the account limit ... SKIP: unsupported storage type Test increasing volume size above the domain limit ... SKIP: unsupported storage type -- Ran 3 tests in 2.236s OK (SKIP=3) You can merge this pull request into a Git repository by running: $ git pull https://github.com/nitt10prashant/cloudstack lxc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/570.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #570 commit 7486f6fcb247a35ab7f139713796dc6647f80c09 Author: nitt10prashant nitt10.prash...@gmail.com Date: 2015-07-09T09:09:51Z CLOUDSTACK-8620 :skip test cases if rbd storage is not available in lxc setup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/568#discussion_r34226433 --- Diff: test/integration/component/test_dhcp_dns_offload.py --- @@ -0,0 +1,2126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# License); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + Tests for DHCP DNS offload feature + +from marvin.cloudstackTestCase import cloudstackTestCase, unittest +from marvin.lib.utils import (random_gen, validateList, cleanup_resources, get_hypervisor_type) +from marvin.lib.base import (Account, + NIC, + ServiceOffering, + DiskOffering, + VirtualMachine, + Network, + NetworkOffering, + Configurations, + Host, + Template, + SSHKeyPair, + Router) +from marvin.lib.common import (get_zone, + get_template, + get_domain + ) +from nose.plugins.attrib import attr +from marvin.codes import PASS,FAIL +from random import randint +import random,string,time,tempfile,os,re + +@unittest.skip(Skipping dhcp-dns-offload tests for now, since it requires external dhcp server) --- End diff -- Need to comment this if DHCP Server is available in the shared network broadcast domain while running tests. Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Config drive changes for vm migration
Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/570#discussion_r34249648
--- Diff: test/integration/component/test_ps_resize_volume.py ---
@@ -48,59 +51,69 @@
RESOURCE_SECONDARY_STORAGE,
XEN_SERVER)
+
class TestResizeVolume(cloudstackTestCase):
@classmethod
def setUpClass(cls):
cloudstackTestClient = super(TestResizeVolume,
- cls).getClsTestClient()
+ cls).getClsTestClient()
cls.api_client = cloudstackTestClient.getApiClient()
+cls.hypervisor = cloudstackTestClient.getHypervisorInfo()
# Fill services from the external config file
cls.services = cloudstackTestClient.getParsedTestDataConfig()
# Get Zone, Domain and templates
cls.domain = get_domain(cls.api_client)
-cls.zone = get_zone(cls.api_client,
cloudstackTestClient.getZoneForTests())
+cls.zone = get_zone(
+cls.api_client,
+cloudstackTestClient.getZoneForTests())
cls.services[mode] = cls.zone.networktype
+cls._cleanup = []
+cls.unsupportedStorageType = False
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.api_client,
storagetype='rbd'):
+cls.unsupportedStorageType = True
+return
cls.resourcetypemapping = {RESOURCE_PRIMARY_STORAGE: 10,
RESOURCE_SECONDARY_STORAGE: 11}
-
-
cls.template = get_template(
-cls.api_client,
-cls.zone.id,
-cls.services[ostype]
-)
+cls.api_client,
+cls.zone.id,
+cls.services[ostype]
+)
cls.services[virtual_machine][zoneid] = cls.zone.id
cls.services[virtual_machine][template] = cls.template.id
cls.services[volume][zoneid] = cls.zone.id
-cls._cleanup = []
try:
cls.hypervisor =
str(get_hypervisor_type(cls.api_client)).lower()
# Creating service offering with normal config
cls.service_offering = ServiceOffering.create(cls.api_client,
-
cls.services[service_offering])
+ cls.services[\
--- End diff --
this looks strange. are you sure you want to break the line within a
string-literal?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/570#issuecomment-119930090 @DaanHoogland @bhaisaab @karuturi Could you please have a look at this one as well? :) Thanks in advance. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Config drive changes for vm migration
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/552#issuecomment-119935788 Discarding this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: simulator-singlerun #1350
See http://jenkins.buildacloud.org/job/simulator-singlerun/1350/ -- Started by upstream project build-master-simulator build number 2167 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO]
[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/571 CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its⦠⦠initial start-up process If SSVM cannot be started then the existing entry is removed and a new SSVM gets created. Made similar changes for CPVM as well. Also cleaned up some log messages in SSVM and CPVM manager code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/koushik-das/cloudstack CS-8623 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/571.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #571 commit 1646084ac671dd9b807301a5830db4dd3c8c9b7b Author: Koushik Das kous...@apache.org Date: 2015-07-09T11:44:24Z CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its initial start-up process If SSVM cannot be started then the existing entry is removed and a new SSVM gets created. Made similar changes for CPVM as well. Also cleaned up some log messages in SSVM and CPVM manager code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: simulator-singlerun #1351
See http://jenkins.buildacloud.org/job/simulator-singlerun/1351/ -- Started by upstream project build-master-simulator build number 2168 originally caused by: Started by upstream project build-master build number 2455 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/569#discussion_r34238492 --- Diff: test/integration/component/test_blocker_bugs.py --- @@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self): #all it's services should resume # Find router associated with user account -list_router_response = list_routers( --- End diff -- Since list router vm is getting called multiple time based on zone networking type , can we use a function which list router vm based on networking type . Please ignore the comment if you feel it is not required . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Is it possible to point external Router Network on cloudstack
Hi All, My Network team allocated a Network segment 10.3.132.0/24 on VLAN 132. So is that possible to create a VM using this network without the Virtualrouter. Where it should have to point via my PhysicalRouter. Thanks, Keerthi
Re: [PROPOSAL] Commit to master through PR only
On Thu, Jul 9, 2015 at 10:51 AM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 09-Jul-2015, at 2:14 pm, Rohit Yadav rohit.ya...@shapeblue.com wrote: - This seems to be already failing, under the Apache way IMO there is no way we can enforce and ensure that at least two people would review any and every PR. There are already a growing number of open PRs that we cannot close unless we get 2 LGTM. Should we put some sort of maximum wait time on PRs that attract no attention (review or discussions), say of 72 hours (excluding weekends) so at least committers can merge their changes? Forgot to explicitly add in the suggestion above - Such attention-deficit PRs (no review, discussion or comment of any sorts) should only be merged if Travis is green along with other automated jenkins jobs (rat, build etc) we’ve setup. I like the idea but think that 72 hours is way to short and also a committers must have shown effort to attract attention to their PR by more then the old 'mail-and-forget' management method. Regards, Rohit Yadav -- Daan
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/569#issuecomment-119887574 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119889147 UI is not really my thing, but given the logic applied and the code itself, LGTM too. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119891522 +1 changes looks good. but, a jira ticket is required. Also, I dont think you can self vote ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
I think I look good to myself as well ;} On Thu, Jul 9, 2015 at 11:44 AM, karuturi g...@git.apache.org wrote: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119891522 +1 changes looks good. but, a jira ticket is required. Also, I dont think you can self vote ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- -- Daan
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119893211 @karuturi fair point, will add a JIRA ticket tracking this. Will re-push with the JIRA ID and merge. IMO one should be able to cast reviews, the minimum two LGTM requirements can be hard to enforce in an opensource community, no? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Github user pavanb018 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/569#discussion_r34239937 --- Diff: test/integration/component/test_blocker_bugs.py --- @@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self): #all it's services should resume # Find router associated with user account -list_router_response = list_routers( --- End diff -- We already have the list_routers as wrapper function on top of the api building. This function serves basic and advanced zone depending upon the passed arguments. Hence the same is called depending on the network type check. Adding another function with network type as a parameter might just be another wrapper that internally calls list_routers again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [PROPOSAL] Commit to master through PR only
On 09-Jul-2015, at 2:56 pm, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: I like the idea but think that 72 hours is way to short I think 72 hours (note: no counting weekends) should be good enough, which is the window for our release/vote process as well. We can increase this to perhaps 120 hours (5 days, except weekends). Doing this would allow at the committers to get their work merged without waiting on others. If the PR has one commit (or squashed into one commit), it would be easier to revert their merged PR if a future issue is found. and also a committers must have shown effort to attract attention to their PR by more then the old 'mail-and-forget' management method. Given that committers/pmc-members are recognised as a contributors working in their free time, it will be challenging to enforce committers/pmc-members to participate in PR reviews. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
On 09-Jul-2015, at 3:21 pm, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: I think I look good to myself as well ;} On Thu, Jul 9, 2015 at 11:44 AM, karuturi g...@git.apache.orgmailto:g...@git.apache.org wrote: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119891522 +1 changes looks good. but, a jira ticket is required. Also, I dont think you can self vote ;) That was an attempt to gain some attention on the PR, glad it worked ;) Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Build failed in Jenkins: simulator-singlerun #1348
See http://jenkins.buildacloud.org/job/simulator-singlerun/1348/ -- Started by upstream project build-master-simulator build number 2165 originally caused by: Started by an SCM change Started by upstream project build-master build number 2453 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit]
Re: [GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
LGTM!! I am taking this patch. On Thu, Jul 9, 2015 at 3:25 PM, pavanb018 g...@git.apache.org wrote: Github user pavanb018 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/569#discussion_r34239937 --- Diff: test/integration/component/test_blocker_bugs.py --- @@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self): #all it's services should resume # Find router associated with user account -list_router_response = list_routers( --- End diff -- We already have the list_routers as wrapper function on top of the api building. This function serves basic and advanced zone depending upon the passed arguments. Hence the same is called depending on the network type check. Adding another function with network type as a parameter might just be another wrapper that internally calls list_routers again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
4.5.2 open issues remaining
H, Can everybody look at [1] and look if further tickets can be closed. I reduced the list by 60 tickets moving inactive tickets to 'Future' and closing what I knew could be closed. The main objective of course is to get 4.5.2 out and voted in;) [1]https://issues.apache.org/jira/issues/?jql=project%20%3D%20CLOUDSTACK%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20fixVersion%20%3D%204.5.2%20ORDER%20BY%20updated%20ASC -- Daan
Re: [PROPOSAL] Commit to master through PR only
On Thu, Jul 9, 2015 at 12:04 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 09-Jul-2015, at 2:56 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: I like the idea but think that 72 hours is way to short I think 72 hours (note: no counting weekends) should be good enough, which is the window for our release/vote process as well. We can increase this to perhaps 120 hours (5 days, except weekends). 7 days (including weekends even seem short to me. The objective is to make shore all code is reviewed! Doing this would allow at the committers to get their work merged without waiting on others. If the PR has one commit (or squashed into one commit), it would be easier to revert their merged PR if a future issue is found. The idea is that committers do wait on others. Reviews are required for a reason. A merge commit can easily be reverted as well. Not related to this discussion. and also a committers must have shown effort to attract attention to their PR by more then the old 'mail-and-forget' management method. Given that committers/pmc-members are recognised as a contributors working in their free time, it will be challenging to enforce committers/pmc-members to participate in PR reviews. No one is expected to work in their free time. I know a lot of us do but I would say we do most work in sponsored time. -- Daan
[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: simulator-singlerun #1352
See http://jenkins.buildacloud.org/job/simulator-singlerun/1352/ -- Started by upstream project build-master-simulator build number 2169 originally caused by: Started by an SCM change Started by upstream project build-master build number 2456 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit]
[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/572 CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a ⦠â¦cache in nfs secondary staging store negative(-1) old review request by Hiroki Ohashi that is planned for 4.5.2 @bhaisaab, @karuturi, @wilderrodrigues please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-7539 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/572.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #572 commit 780816ee9f9461f1eaa6bc5133354f99b06cd208 Author: Hiroki Ohashi hiroki.ooha...@aist.go.jp Date: 2014-10-02T08:21:06Z CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a cache in nfs secondary staging store negative(-1) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)
On Thu, Jul 9, 2015 at 4:49 AM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 09-Jul-2015, at 12:50 pm, Sebastien Goasguen run...@gmail.com wrote: Let’s revert , that’s our new rule Since we have not voted what/how we are going to do commits, let’s treat this more of a guideline or honour code. Votes aren't strictly necessary. As a matter of fact, votes should be avoided if at all possible. We should strive for consensus, and when we have it, it is as binding as if we had a tally of votes. I’ve expressed few concersn on this rule wrt code reviewing for PRs that are not getting attention, so IMO let’s try to have the discussion and find solution before we really start enforcing them. So my take (FWIW) is that without the pain, we'll never adjust our method of operation or find the solutions. In example, no one came to the list asking for reviews. --David
[GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/560#issuecomment-119974151 Nice to hear that, I will be waiting for CS 4.6 now ;) If you guys will check those classes âXcpServerNetworkUsageCommandWrapperâ and âXenServer56NetworkUsageCommandWrapperâ let me know. I think that VPC might have a problem for XCP. On Thu, Jul 9, 2015 at 9:00 AM, asfgit notificati...@github.com wrote: Closed #560 https://github.com/apache/cloudstack/pull/560 via 25e9918 https://github.com/apache/cloudstack/commit/25e9918c5791a74bc4840ec6d6bf9e9ece397a68 . â Reply to this email directly or view it on GitHub https://github.com/apache/cloudstack/pull/560#event-351780004. -- Rafael Weingärtner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Findbugs issues with instance acces to st...
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/573 Findbugs issues with instance acces to static fields I wonder if these fields are used solely on the host or on the management server as well. If the code is running on both it is not right that these fields are static as multiple versions of KVM may be deployed in a cloud. the use of the fields is static so this wrapper function is needed to negate the findbugs warning. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack findbugs-ST Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/573.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #573 commit 187c5c7817532eb6764a4147cf6bea4e3db98d8b Author: Daan Hoogland d...@onecht.net Date: 2015-07-09T18:48:49Z adhere to naming conventions for enums commit cb4618673d193ef9492c5e5a9f57a9c37fb390be Author: Daan Hoogland d...@onecht.net Date: 2015-07-09T19:05:10Z findbugs: create wrapper to deal with static field --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/574 CLOUDSTACK-8622: Reinstate working sessions in browser - Login is based on sessionkey HttpOnly Cookie - ApiServlet does login verification using sessionKey from both the request cookies and the API parameters. In both cases, if either or both are passed they should match the sessionKey stored in the current session of the HttpRequest - UI: it no longer needs to read or set sessionkey cookie - UI: it no longer needs to return g_sessionKey value in the API requests, though to support a sso mechanism it is not removed for that specific case - UI: on logout, all cookies are removed (though this won't remove httponly ones) - Secure jsessionid cookie is set to be HttpOnly and Secure - SAML login should also set HttpOnly cookie before redirecting to UI - SAML: ListIdps API is made a readonly API that won't destroy an existing session Performed tests (login, saml login if applicable, page refreshes, opening multiple tabs, logout) with following combinations: - SAML disabled, normal auth as admin, domain-admin and user - SAML enabled, normal auth as admin, domain-admin and user; and saml sso as admin, domain-admin and user You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cloudstack CLOUDSTACK-8622 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #574 commit 88f63d516860d348b818d1c9149829f3469cd00a Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-07-09T20:58:30Z CLOUDSTACK-8622: Reinstate working sessions in browser - Login is based on sessionkey HttpOnly Cookie - ApiServlet does login verification using sessionKey from both the request cookies and the API parameters. In both cases, if either or both are passed they should match the sessionKey stored in the current session of the HttpRequest - UI: it no longer needs to read or set sessionkey cookie - UI: it no longer needs to return g_sessionKey value in the API requests, though to support a sso mechanism it is not removed for that specific case - UI: on logout, all cookies are removed (though this won't remove httponly ones) - Secure jsessionid cookie is set to be HttpOnly and Secure - SAML login should also set HttpOnly cookie before redirecting to UI - SAML: ListIdps API is made a readonly API that won't destroy an existing session Performed tests (login, saml login if applicable, page refreshes, opening multiple tabs, logout) with following combinations: - SAML disabled, normal auth as admin, domain-admin and user - SAML enabled, normal auth as admin, domain-admin and user; and saml sso as admin, domain-admin and user --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/574#issuecomment-120146560 I reviewed https://github.com/apache/cloudstack/pull/308 and found that it needs more fixes, since that PR is slightly old now, worked on this. This aims to have a good trade off between security and re-enabling session across tabs: the greatest benefit is that refreshing the UI won't log you out. Please review. cc @DaanHoogland @rsafonseca @wilderrodrigues @abhinandanprateek @jlk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/575 CLOUDSTACK-8457: Add option to authorize SAML SSO for user when adding user With SAML enabled, add user view shows option to authorize SAML SSO for a user. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cloudstack saml-adduserfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/575.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #575 commit c1c67f313a2ba08022b647baa0ca65f134c062c1 Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-07-09T20:56:51Z CLOUDSTACK-8457: Add option to authorize SAML SSO for user when adding user Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/574#issuecomment-120146710 (note: single patch ensures we capture the single aim with this fix and also easy to port to other branches, 4.5/master etc.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120149819 Screenshot:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: coverity resource leaks
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: simulator-singlerun #1353
See http://jenkins.buildacloud.org/job/simulator-singlerun/1353/ -- Started by upstream project build-master-simulator build number 2170 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by upstream project build-master build number 2457 originally caused by: Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern
