date:20150807

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/635#issuecomment-128843113
  
@devdeep You have written a very fine test and as it passes and tests what 
its target should do you would get a definate lgtm on tat one from me. However 
it does not test the code that was changed in this PR so it should be submitted 
separately and the code here should be tested in this PR.

let's ask the RMs, @remibergsma and @karuturi. If they think it is fine to 
add it like this I will let them. The code looks ok but the PR doesn't to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [DISCUSS] CLOUDSTACK-8652: remove old upg...

Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/608


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [DISCUSS] CLOUDSTACK-8652: remove old upg...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/608#issuecomment-128839114
  
No momentum or consensus for this kind of work. discussion on dev@ is fine 
but I expect no technical solution and political/marketing impasse.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/664


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/664#issuecomment-128833636
  
LGTM, i will have a go at merging when I have Miguels new version of the 
merge script and the origin/apache triangle ready on my new (post schuberg 
philis) workstation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Cloudstack collab Dublin 8-9 October

2015-08-07 Thread Giles Sirett

All

We've got the schedule published for CCCEU15
http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe/program/schedule

Thanks to everybody who is participating

Could folks on this list please help by promoting the schedule on twitter,etc

Kind Regards
Giles

Giles Sirett
CEO

[cid:image001.jpg@01D0D15C.09C92D00]

D: +44 20 3603 0541 | S: +44 20 3603 0540 | M: +44 796 111 2055

giles.sir...@shapeblue.com |
www.shapeblue.com |
Twitter:@shapeBlue

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge - rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software
Engineering
CloudStack Infrastructure
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the author and do not necessarily
represent those of Shape Blue Ltd or related companies. If you are not the
intended recipient of this email, you must neither take any action based upon
its contents, nor copy or show it to anyone. Please contact the sender if you
believe you have received this email in error. Shape Blue Ltd is a company
incorporated in England & Wales. ShapeBlue Services India LLP is a company
incorporated in India and is operated under license from Shape Blue Ltd. Shape
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company
registered by The Republic of South Africa and is traded under license from
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-128828795
  
Hi @koushik-das I was able to test your PR and it seems to do what you 
said: start the system VMs before the other instances. However, it doesn't 
solve the problem completely. In my case, I had two routers and a bunch of VMs. 
The routers started first, but when the first instance was started the router 
was not yet ready. CloudStack then destroyed the router, and on the next HA run 
about 5-10 minutes later everything was started properly. If you want my full 
logs, let me know and I'll put them somewhere.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[4.6] Issues deploying VM on VMware

2015-08-07 Thread Mike Tutkowski

Hi,

I was wondering if anyone was aware of issues in 4.6 around deploying VMs
on VMware.

I have a Basic Zone running system VMs on XenServer and am trying to deploy
a VM to local storage on ESXi. CloudStack is claiming insufficient space to
deploy the VM.

I plan to look into this in more depth, but was just curious first if
anyone knew of current issues here.

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

[GitHub] cloudstack pull request: [DISCUSS] CLOUDSTACK-8652: remove old upg...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/608#issuecomment-128792204
  
@DaanHoogland Shall we close this PR and discuss on list what we want to do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Off topic about fork on git hub and pull requests

2015-08-07 Thread Mike Tutkowski

Glad to hear it worked. :)

On Friday, August 7, 2015, Rafael Weingärtner 
wrote:

> Many thanks mike that worked out.
>
> On Fri, Aug 7, 2015 at 1:17 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com 
> > wrote:
>
> > If the end goal is to just have the master branch on your fork equal to
> the
> > master branch on origin, how's about fetching master on origin to your
> > local system, then switching to your local master branch and executing
> "git
> > reset --hard origin/master" (assuming you don't have any work in
> > progress...if you do, stash it first) and then executing "git push  > fork> master --force" and see if that does the trick?
> >
> > On Thu, Aug 6, 2015 at 5:46 PM, Rafael Weingärtner <
> > rafaelweingart...@gmail.com > wrote:
> >
> > > Hi guys,
> > > I know this might not be the right place to post it, but I bet that you
> > > have the answer at the tip of your tongue.
> > >
> > > I have created a fork from https://github.com/apache/cloudstack, on
> that
> > > fork I have made some changes and created a pull request. The pull
> > request
> > > was already accepted and merged into origin (
> > > https://github.com/apache/cloudstack), master branch.
> > >
> > > Today I noticed that my fork was a few commits behind the origin
> branch,
> > so
> > > I changed the remote repository to
> https://github.com/apache/cloudstack,
> > > fetched the commits and then pushed to my fork.
> > >
> > > The problem is the following, in my fork it is appearing as 4 commits
> > ahead
> > > of the origin in master branch, 2 commits that were already merged into
> > the
> > > origin, and 2 commits that represent the push I did to send the new
> > commits
> > > from origin to my fork.
> > >
> > > Now, If I try to create a new pull request, those commits are going to
> be
> > > added into the pull request and I did not want to do that. Is there a
> way
> > > to work around that?
> > >
> > > --
> > > Rafael Weingärtner
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com 
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
> >
>
>
>
> --
> Rafael Weingärtner
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-128748550
  
Thanks @miguelaferreira :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-07 Thread miguelaferreira

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-128748395
  
Hi @koushik-das 

Sorry to step in like this, but I talked to @remibergsma and I think you 
can fix your branch by doing this:
```
git checkout 032a335
git cherry-pick cabc9ea
git reset --hard
```

If you do this, please double-check the result (it should be your two 
commits together at the top), and then do: 
```
git push -f origin HEAD:CLOUDSTACK-8704
```

To update this PR.

I hope this helps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-128745820
  
@remibergsma Will the following work?
- do git pull on master
- then do a git pull --rebase, this will make the commits appear on top
- then do the squash
- push them to master after editing the message


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-128727494
  
@koushik-das you can solve it like this:
- start with a new branch from your first commit
- then cherry-pick the second one in
- consider if you want to squash them together
- force push this to your fork (koushik-das) on branch (CLOUDSTACK-8704)
The PR should then have two commits. Let me know if you need any help!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/666#discussion_r36527589
  
--- Diff: 
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -2627,7 +2627,7 @@ public boolean postStateTransitionEvent(final 
StateMachine2.Transition

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/666#discussion_r36526622
  
--- Diff: 
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -2627,7 +2627,7 @@ public boolean postStateTransitionEvent(final 
StateMachine2.Transition

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-128719973
  
@koushik-das I' testing this tonight and will merge if it's OK. Before I 
proceed, could you please squash the 3 commits into 1. I cannot merge it like 
this. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/666


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/666#issuecomment-128717347
  
LGTM from my super phone ;) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8714 Restore VM (Re-install VM...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/659


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8638: install update_host_pass...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/663


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

2015-08-07 Thread kevindierkx

Github user kevindierkx commented on the pull request:

https://github.com/apache/cloudstack/pull/664#issuecomment-128695172
  
I've removed the above mentions of commented code. Should be all set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36516193
  
--- Diff: ui/scripts/ui-custom/accountsWizard.js ---
@@ -130,89 +130,89 @@
 dataType: "json",
 async: false,
 success: function(json) {
-   //for testing only (begin)
-   /*
-   json = {
-   "ldapuserresponse": {
-   "count": 11,
-   "LdapUser": [
-   {
-   "email": 
"t...@test.com",
-   "principal": 
"CN=Administrator,CN=Users,DC=hyd-qa,DC=com",
-   "username": 
"Administrator",
-   "domain": 
"CN=Administrator"
-   },
-   {
-   "email": 
"t...@test.com",
-   "principal": 
"CN=Guest,CN=Users,DC=hyd-qa,DC=com",
-   "username": "Guest",
-   "domain": "CN=Guest"
-   },
-   {
-   "email": 
"t...@test.com",
-   "principal": 
"CN=IUSR_HYD-QA12,CN=Users,DC=hyd-qa,DC=com",
-   "username": 
"IUSR_HYD-QA12",
-   "domain": 
"CN=IUSR_HYD-QA12"
-   },
-   {
-   "email": 
"t...@test.com",
-   "principal": 
"CN=IWAM_HYD-QA12,CN=Users,DC=hyd-qa,DC=com",
-   "username": 
"IWAM_HYD-QA12",
-   "domain": 
"CN=IWAM_HYD-QA12"
-   },
-   {
-   "email": 
"t...@test.com",
-   "principal": 
"CN=SUPPORT_388945a0,CN=Users,DC=hyd-qa,DC=com",
-   "username": 
"SUPPORT_388945a0",
-   "domain": 
"CN=SUPPORT_388945a0"
-   },
-   {
-   "principal": 
"CN=jessica j,CN=Users,DC=hyd-qa,DC=com",
-   "firstname": "jessica",
-   "lastname": "j",
-   "username": "jessica",
-   "domain": "CN=jessica j"
-   },
-   {
-   "principal": 
"CN=krbtgt,CN=Users,DC=hyd-qa,DC=com",
-   "username": "krbtgt",
-   "domain": "CN=krbtgt"
-   },
-   {
-   "email": 
"sa...@sadhu.com",
-   "principal": 
"CN=sadhu,CN=Users,DC=hyd-qa,DC=com",
-   "firstname": "sadhu",
-   "username": "sadhu",
-   "domain": "CN=sadhu"
-   },
-   {
-   "email": 
"t...@test.com",
-   "principal": 
"CN=sangee1 hariharan,CN=Users,DC=hyd-qa,DC=com",
-   "firstname": "sangee1",
-   "lastname": "hariharan",
-   "userna

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36516165
  
--- Diff: ui/scripts/templates.js ---
@@ -2746,7 +2722,7 @@
  if (((isAdmin() == false && !(jsonObj.domainid == g_domainid && 
jsonObj.account == g_account))  //if neither root-admin, nor item owner
  || jsonObj.isready == false)
  || (jsonObj.bootable == false)
- || (jsonObj.domainid ==   1 && jsonObj.account == "system")
+ || (jsonObj.domainid ==1 && jsonObj.account =="system")
--- End diff --

please remove this block of commented code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-08-07 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/661#issuecomment-128693767
  
Travis is green and 2LGTM, merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515654
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -4363,12 +4363,12 @@
 array1.push("&password=" + 
todb(args.data.cluster.vCenterPassword));
 
 //dvswitch is enabled
-   /*
+/*
 if (args.data.cluster.vSwitchPublicType != "")
 array1.push('&publicvswitchtype=' + 
args.data.cluster.vSwitchPublicType);
-   */
+*/
--- End diff --

remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515683
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -4377,23 +4377,23 @@
 if (args.data.cluster.vSwitchGuestType != "")
 array1.push('&guestvswitchtype=' + 
args.data.cluster.vSwitchGuestType);
 */
-   
-   /*
+
+/*
 if (args.data.cluster.vSwitchGuestName != "")
 array1.push("&guestvswitchname=" + 
args.data.cluster.vSwitchGuestName);
-   */
+*/
--- End diff --

remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515666
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -4363,12 +4363,12 @@
 array1.push("&password=" + 
todb(args.data.cluster.vCenterPassword));
 
 //dvswitch is enabled
-   /*
+/*
 if (args.data.cluster.vSwitchPublicType != "")
 array1.push('&publicvswitchtype=' + 
args.data.cluster.vSwitchPublicType);
-   */
+*/
 
-   /*
+/*
 if (args.data.cluster.vSwitchPublicName != "")
 array1.push("&publicvswitchname=" + 
args.data.cluster.vSwitchPublicName);
 */
--- End diff --

remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515568
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -2108,17 +2108,17 @@
 
$fields.filter('[rel=username]').hide();
 
$fields.filter('[rel=key]').hide();
 } else if ($(this).val() == "S3") {
-   
$fields.filter('[rel=name]').css('display', 'inline-block');
-   

-   if(s3stores != null && 
s3stores.length > 0) {
-   
$fields.filter('[rel=name]').find('input').val(s3stores[0].name);
-   
$fields.filter('[rel=name]').find('input').attr("disabled", "disabled");
-   } else {
-   
//$fields.filter('[rel=name]').find('input').val("");
-   
$fields.filter('[rel=name]').find('input').removeAttr("disabled");
-   }   

-   
-   //NFS
+
$fields.filter('[rel=name]').css('display', 'inline-block');
+
+if(s3stores != null && 
s3stores.length > 0) {
+
$fields.filter('[rel=name]').find('input').val(s3stores[0].name);
+
$fields.filter('[rel=name]').find('input').attr("disabled", "disabled");
+} else {
+
//$fields.filter('[rel=name]').find('input').val("");
--- End diff --

remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515531
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1972,45 +1972,45 @@
 }
 },
 secondaryStorage: {
-fields: {
+fields: {
 provider: {
 label: 'label.provider',
 select: function(args) {
-   var storageproviders = [];  
-   storageproviders.push({ id: '', description: 
''});  
-   
-   $.ajax({
-   url: createURL('listImageStores'),
-   data: {
-   provider: 'S3'
-   },
-   async: true,
-   success: function(json) {   

-   var s3stores = 
json.listimagestoresresponse.imagestore;
-   if(s3stores != null && 
s3stores.length > 0) {   
-   storageproviders.push({ 
id: 'S3', description: 'S3'}); //if (region-wide) S3 store exists already, only 
"S3" option should be included here. Any other type of store is not allowed to 
be created since cloudstack doesn't support multiple types of store at this 
point. 
-   } else {
-   /*  
  
-   UI no longer gets providers 
from "listStorageProviders&type=image" because:
-   (1) Not all of returned values 
are handled by UI (e.g. Provider "NetApp" is not handled by UI).
-   (2) Provider "SMB" which is 
handled by UI is not returned from "listStorageProviders&type=image" 
-   */
-   storageproviders.push({ 
id: 'NFS', description: 'NFS'});
-   storageproviders.push({ 
id: 'SMB', description: 'SMB/CIFS'});
-   storageproviders.push({ 
id: 'S3', description: 'S3'});
-   storageproviders.push({ 
id: 'Swift', description: 'Swift'});

-   }   

+var storageproviders = [];
+storageproviders.push({ id: '', description: 
''});
+
+$.ajax({
+url: createURL('listImageStores'),
+data: {
+provider: 'S3'
+},
+async: true,
+success: function(json) {
+var s3stores = 
json.listimagestoresresponse.imagestore;
+if(s3stores != null && s3stores.length 
> 0) {
+storageproviders.push({ id: 'S3', 
description: 'S3'}); //if (region-wide) S3 store exists already, only "S3" 
option should be included here. Any other type of store is not allowed to be 
created since cloudstack doesn't support multiple types of store at this point.
+} else {
+/*
+UI no longer gets providers from 
"listStorageProviders&type=image" because:
+(1) Not all of returned values are 
handled by UI (e.g. Provider "NetApp" is not handled by UI).
+(2) Provider "SMB" which is 
handled by UI is not returned from "listStorageProviders&type=image"
+*/
--- End diff --

remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515479
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1139,15 +1139,15 @@
 dependsOn: 'overridepublictraffic'
 },
 */
-   
-   /*
+
+/*
 vSwitchPublicName: {
 label: 'Public Traffic vSwitch Name',
 dependsOn: 'overridepublictraffic',
 isHidden: true
 },
 */
--- End diff --

let's remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515504
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1221,14 +1221,14 @@
 
 },
 */
-   
-   /*
+
+/*
 vSwitchGuestName: {
 label: 'Guest Traffic vSwitch Name',
 dependsOn: 'overrideguesttraffic',
 isHidden: true
 },
-   */
+*/
--- End diff --

let's remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515461
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1139,15 +1139,15 @@
 dependsOn: 'overridepublictraffic'
 },
 */
--- End diff --

a not reformatted bit but remove makes sense as well here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515489
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1221,14 +1221,14 @@
 
 },
 */
--- End diff --

remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36515422
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -983,12 +983,12 @@
 
 
 } else {
-/*
-   
$form.find('.form-item[rel=vSwitchPublicType]').css('display', 'none');
-   
$form.find('.form-item[rel=vSwitchGuestType]').css('display', 'none');
-   
$form.find('.form-item[rel=vSwitchPublicName]').css('display','none');
-   
$form.find('.form-item[rel=vSwitchGuestName]').css('display','none');
-   */
+/*
--- End diff --

more comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36514941
  
--- Diff: ui/scripts/zoneWizard.js ---
@@ -963,16 +963,16 @@
 if ($(this).val() == "VMware") {
 //$('li[input_sub_group="external"]', 
$dialogAddCluster).show();
 if (dvSwitchEnabled) {
-/*   
-   
$fields.filter('[rel=vSwitchPublicType]').css('display', 'inline-block');
-   
$form.find('.form-item[rel=vSwitchGuestType]').css('display', 'inline-block');
+/*
--- End diff --

wow, more code that won't run


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36514806
  
--- Diff: ui/scripts/vpc.js ---
@@ -155,41 +155,41 @@
  };
  */
 //virtualmachineids parameter has been replaced with 
vmidipmap parameter, so comment out the lines above.
-
-
+
+
 var inputData = {
 id: args.context.internalLoadBalancers[0].id
-};   
-/* 
+};
+/*
  * e.g. first VM(xxx) has two IPs(10.1.1.~), second 
VM(yyy) has three IPs(10.2.2.~):
- * vmidipmap[0].vmid=xxx  vmidipmap[0].vmip=10.1.1.11 
- * vmidipmap[1].vmid=xxx  vmidipmap[1].vmip=10.1.1.12 
- * vmidipmap[2].vmid=yyy  vmidipmap[2].vmip=10.2.2.77 
- * vmidipmap[3].vmid=yyy  vmidipmap[3].vmip=10.2.2.78 
- * vmidipmap[4].vmid=yyy  vmidipmap[4].vmip=10.2.2.79 
+ * vmidipmap[0].vmid=xxx  vmidipmap[0].vmip=10.1.1.11
+ * vmidipmap[1].vmid=xxx  vmidipmap[1].vmip=10.1.1.12
+ * vmidipmap[2].vmid=yyy  vmidipmap[2].vmip=10.2.2.77
+ * vmidipmap[3].vmid=yyy  vmidipmap[3].vmip=10.2.2.78
+ * vmidipmap[4].vmid=yyy  vmidipmap[4].vmip=10.2.2.79
  */
 var selectedVMs = vms;
 if (selectedVMs != null) {
 var vmidipmapIndex = 0;
-for (var vmIndex = 0; vmIndex < selectedVMs.length; 
vmIndex++) {  
+for (var vmIndex = 0; vmIndex < selectedVMs.length; 
vmIndex++) {
 var selectedIPs = selectedVMs[vmIndex]._subselect;
 for (var ipIndex = 0; ipIndex < 
selectedIPs.length; ipIndex++) {
 inputData['vmidipmap[' + vmidipmapIndex + 
'].vmid'] = selectedVMs[vmIndex].id;
-
-//"ipAddresses" is not in args.context since 
this LB rule is under a VPC, not an address. 
+
+//"ipAddresses" is not in args.context since 
this LB rule is under a VPC, not an address.
 /*
--- End diff --

yet another useless bit reformatted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36514699
  
--- Diff: ui/scripts/ui/widgets/listView.js ---
@@ -275,7 +275,7 @@
 });
 } else {
 $newRow = 
replaceItem($instanceRow,
-   args.data, 
//$.extend($instanceRow.data('json-obj'), args.data), /* 
$.extend($instanceRow.data('json-obj'), args.data) causes CLOUDSTACK-4687 */
+args.data, 
//$.extend($instanceRow.data('json-obj'), args.data), /* 
$.extend($instanceRow.data('json-obj'), args.data) causes CLOUDSTACK-4687 */
--- End diff --

once someone understands this comment, please replace it with something 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36514600
  
--- Diff: ui/scripts/ui/widgets/detailView.js ---
@@ -1062,19 +1062,19 @@
 
 //???
 /*
-if("pollAgainIfValueIsIn" in value) {
-if ((content in value.pollAgainIfValueIsIn) && 
(value.pollAgainFn != null)) {
-//poll again
-var intervalKey = setInterval(function() {
-var toClearInterval = 
value.pollAgainFn(context);
-if(toClearInterval == true) {
-clearInterval(intervalKey);
-$('.detail-view .toolbar 
.button.refresh').click(); //click Refresh button to refresh detailView
-}
-}, 2000);
-}
-}
-*/
+ if("pollAgainIfValueIsIn" in value) {
+ if ((content in value.pollAgainIfValueIsIn) && 
(value.pollAgainFn != null)) {
+ //poll again
+ var intervalKey = setInterval(function() {
+ var toClearInterval = value.pollAgainFn(context);
+ if(toClearInterval == true) {
+ clearInterval(intervalKey);
+ $('.detail-view .toolbar .button.refresh').click(); 
//click Refresh button to refresh detailView
+ }
+ }, 2000);
+ }
+ }
+ */
--- End diff --

exorcise this bit!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36514540
  
--- Diff: ui/scripts/ui-custom/regions.js ---
@@ -37,9 +37,9 @@
 $li.data('region-data', region);
 
 /* e.g.
-   region.endpoint == 
"http://localhost:8080/client/";
-   document.location.href 
== "http://localhost:8080/client/#";
-   */
+region.endpoint== 
"http://localhost:8080/client/";
+document.location.href == 
"http://localhost:8080/client/#";
+*/
--- End diff --

comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36514359
  
--- Diff: ui/scripts/templates.js ---
@@ -2735,8 +2735,8 @@
 /*
 if(g_regionsecondaryenabled != true) {
 allowedActions.push("copyISO");
-   }
-   */
+}
+*/
 }
--- End diff --

eh, reformatted code in comment :catholiccrosssign: ;) let's remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36514301
  
--- Diff: ui/scripts/templates.js ---
@@ -2689,14 +2689,14 @@
 //do nothing
 } else {
 allowedActions.push("edit");
-
+
 allowedActions.push("copyTemplate");
 /*
 if(g_regionsecondaryenabled != true) {
 allowedActions.push("copyTemplate");
 }
 */
-   
+
 //allowedActions.push("createVm"); // For Beta2, this simply 
doesn't work without a network.
--- End diff --

another bit to remove (the 7 lines above)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36514016
  
--- Diff: ui/scripts/templates.js ---
@@ -519,16 +519,16 @@
 });
 }
 
-
-//XenServer only (starts here) 
 
+
+//XenServer only (starts here)
 if 
(args.$form.find('.form-item[rel=xenserverToolsVersion61plus]').css("display") 
!= "none") {
 $.extend(data, {
 
'details[0].hypervisortoolsversion': (args.data.xenserverToolsVersion61plus == 
"on") ? "xenserver61" : "xenserver56"
 });
 }
 //XenServer only (ends here)
-
-
+
--- End diff --

why adding two empty lines here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

2015-08-07 Thread borisroman

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/664#issuecomment-128689329
  
We've used the following scripts to remove the trailing white spaces and 
leading tabs:


Tabs to 4 white spaces:
find . -iname '*.js' -type f -exec sed -i '' 's/\t//' {} \+

Remove trailing white spaces:
find . -iname '*.js' -type f -exec sed -i '' 's/[[:space:]]\{1,\}$//' {} \+


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/666#issuecomment-128689198
  
@borisroman Thx, removed the redundant parentheses


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36513912
  
--- Diff: ui/scripts/storage.js ---
@@ -55,13 +55,13 @@
 }
 
 /*
-   state: {
- label: 'State',
-   indicator: {
+state: {
+  label: 'State',
+indicator: {
 'Ready': 'on'
   }
-   }
-   */
+}
+*/
--- End diff --

let's get rid of this bit of confusing code in comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36513758
  
--- Diff: ui/scripts/regions.js ---
@@ -197,7 +197,7 @@
 var region = args.context.regions[0];
 
 /* e.g.
-  region.endpoint  == "http://localhost:8080/client/";
+  region.endpoint== "http://localhost:8080/client/";
   document.location.href == 
"http://localhost:8080/client/#";
   */
 /*
--- End diff --

let's not reformat biut remove code in comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

2015-08-07 Thread pritisarap12

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/667

CLOUDSTACK-8717: Failed to start instance after restoring the running 
instance 

On setup with two cluster wide primary storage verify restoring a running 
instance.(As while restoring instance root disk may get created on another 
primary storage.)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-8717-Failed-to-start-instance-after-restoring-the-running-instance

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/667.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #667


commit f163cbcb44d1c712deb5722f9623cb4675f01bf9
Author: Priti Sarap 
Date:   2015-08-07T12:27:54Z

CLOUDSTACK-8717: Failed to start instance after restoring the running 
instance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/664#discussion_r36513703
  
--- Diff: ui/scripts/instances.js ---
@@ -1959,16 +1959,16 @@
 },
 converter: 
cloudStack.converters.toBooleanText
 },
-
+
 /*
-   isoid: {
+isoid: {
   label: 'label.attached.iso',
   isEditable: false,
   converter: function(isoid) {
 return cloudStack.converters.toBooleanText(isoid != 
null);
   }
 },
-   */
+*/
--- End diff --

Let's remove these lines, and not reformat to keep comment in code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-07 Thread manuiiit

Github user manuiiit commented on the pull request:

https://github.com/apache/cloudstack/pull/658#issuecomment-128686845
  
@wido Ya I checked it.Any user was able to change permissions of the 
template.Updated the description with a case i tried.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-128686334
  
@kishankavala Made the change to use VM type instead of name to distinguish 
between user and system VMs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8714 Restore VM (Re-install VM...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/659#issuecomment-128686244
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/658#issuecomment-128686068
  
Code LGTM, but is it the case right now that anybody can change a template?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/661#issuecomment-128685407
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/664#issuecomment-128685238
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/666#issuecomment-128685143
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...