[GitHub] cloudstack pull request: Removed unused methods from XenServerConn...

[rodrigo93]

Github user rodrigo93 commented on the pull request:

https://github.com/apache/cloudstack/pull/1557#issuecomment-221426317
  
Hi @rafaelweingartner ,
Thanks for the advice. I will take a look on that and do the proper changes 
as soon as I can.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221409650
  
Oh, I think you were just resolving conflicts.  I will run CI again just to 
verify...  Otherwise this is looking good.  Thanks everyone...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221409302
  
Was the only change since the last CI run the updating of the marvin test 
(which I can't run anyway)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: DS template copies don��...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1560#issuecomment-221409198
  
Hi @nvazquez, 

Thanks for the PR. Great work as always, especially on documenting the 
problem.

I think we can improve it a little bit. What about extracting lines 
5480-5485 to a method? Then, those java comments can become java docs (which I 
believe are much better) and also you would be able to write test cases.

Also, I think we should change the “throw new Exception()” to a more 
specific exception. What about the CloudRuntimeException or another one?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[KrisSterckx]

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221394563
  
Thanks all folks, that gives the needed LGTM votes!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: DS template copies don��...

[nvazquez]

GitHub user nvazquez opened a pull request:

https://github.com/apache/cloudstack/pull/1560

CLOUDSTACK-9368: DS template copies don’t get deleted in VMware ESXi with 
multiple clusters and zone wide storage

JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9386

### Introduction
In some production environments with multiple clusters it was noticed that 
unused templates were consuming too much storage. It was discovered that 
template cleanup was not deleting marked templates on ESXi.

### Description of the problem
Suppose we have multiple clusters `(c1, c2,...,cN)` on a data center and 
template `T` from which we deploy vms on `c1.`
Suppose now that we expunge those vms, and there's no other vm instance 
from template `T,` so this was the actual workflow:

1. CloudStack marks template for cleanup after `storage.cleanup.interval` 
seconds, by setting `marked_for_gc = 1` on `template_spool_ref` table, for that 
template.

2. After another `storage.cleanup.interval` seconds a `DestroyCommand` will 
be sent, to delete template from primary storage

3. On `VmwareResource`, command is processed, and it first picks up a 
random cluster, say `ci != c1` to look for vm template (using volume's path) 
and destroy it. But, as template was on `c1` it cannot be found, so it won't be 
deleted. Entry on `template_spool_ref` is deleted but not the actual template 
on hypervisor side.

### Proposed solution
We propose a way to attack problem shown in point 3, by not picking up a 
random cluster to look for vm but using data store. This way we make sure vm 
template will be deleted in every case, and not depending on random cluster 
selection

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nvazquez/cloudstack gcbug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1560


commit 656bba0cc3281d40c2609eafc0f7ae691a8863e8
Author: nvazquez 
Date:   2016-05-20T16:01:03Z

CLOUDSTACK-9368: Find vm on datacenter instead of randomly choosing a 
cluster




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221349421
  
Thanks @nlivens, great work cleaning.
The code LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

[footplus]

Github user footplus commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1555#discussion_r64432411
  
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -204,6 +203,7 @@ if [ -f "$customCACert" ]
 then
   keytool -delete -alias $aliasName -keystore $keyStore -storepass 
$storepass -noprompt
   keytool -import -alias $aliasName -keystore $keyStore -storepass 
$storepass -noprompt -file $customCACert
+  keytool -importkeystore -srckeystore $defaultJavaKeyStoreFile 
-destkeystore $keyStore -srcstorepass $defaultJavaKeyStorePass -deststorepass 
$storepass
--- End diff --

It seems that we absolutely need a -noprompt option here, since re-applying 
the configuration will lead to keytool prompting whether to overwrite or not, 
and freezing the Agent then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[syed]

GitHub user syed reopened a pull request:

https://github.com/apache/cloudstack/pull/1423

[CLOUDSTACK-9296] Start ipsec for client VPN

This fix starts the IPSEC daemon when enabling client side vpn

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack ipsec-start-bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1423


commit dfa555f2ad775ee3177efcd675e37b8c46201af6
Author: Syed 
Date:   2016-02-23T15:14:33Z

[CLOUDSTACK-9296] Start ipsec for client VPN




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[syed]

Github user syed closed the pull request at:

https://github.com/apache/cloudstack/pull/1423


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1555#issuecomment-221324840
  
Thanks for the update.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

[footplus]

Github user footplus commented on the pull request:

https://github.com/apache/cloudstack/pull/1555#issuecomment-221324378
  
Hum, please wait a bit before merging, it seems that in certain cases, a 
problem occurs; I'm not sure yet, but there may be more to it.

I'll double check what exactly is occurring (got agent disconnections on 
SSVM, not sure why, maybe unrelated). Upon restarting the service, got the 
following:

``
2016-05-24 16:13:00,805 WARN  [utils.script.Script] 
(agentRequest-Handler-4:null) Timed out: 
/usr/local/cloud/systemvm/config_ssl.sh -i 1.2.3.4 -h s-400-VM -k 
/tmp/prvkey8397704182155251777.tmp -p /tmp/pubcert3668437820792344314.tmp -t 
/tmp/certchain6337729082886052511.tmp -u /tmp/rootcert3605556222455908935.tmp . 
 Output is: Certificate was added to keystoreExisting entry alias 
debian:pscprocert.pem exists, overwrite? [no]:  adding rewrite rules to file: 
/etc/apache2/sites-available/default-ssl
``



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-221304669
  
@swill if you are happy to merge this without including the tests requested 
by @jburwell then this PR is ready to merge.

@luhaijiao I've created CLOUDSTACK-9385 to deal with the password server 
not running on redundant virtual routers. Please can you post your findings 
there if they do not match what I've described?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...

[pdion891]

Github user pdion891 commented on the pull request:

https://github.com/apache/cloudstack/pull/1548#issuecomment-221301992
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1530#discussion_r64402582
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
 
 import org.apache.log4j.Logger;
 
+import com.cloud.utils.StringUtils;
+import com.google.common.base.Preconditions;
+
 public class VmdkFileDescriptor {
 private static final Logger s_logger = 
Logger.getLogger(VmdkFileDescriptor.class);
 private static final String VMDK_PROPERTY_CREATE_TYPE = "createType";
 private static final String VMDK_CREATE_TYPE_VMFSSPARSE = "vmfsSparse";
 private static final String VMDK_PROPERTY_ADAPTER_TYPE = 
"ddb.adapterType";
 
-private Properties _properties = new Properties();
+private final Properties _properties = new Properties();
 private String _baseFileName;
 
 public VmdkFileDescriptor() {
 }
 
 public void parse(byte[] vmdkFileContent) throws IOException {
-BufferedReader in = null;
-try {
-in = new BufferedReader(new InputStreamReader(new 
ByteArrayInputStream(vmdkFileContent),"UTF-8"));
+try (BufferedReader in = new BufferedReader(new 
InputStreamReader(new ByteArrayInputStream(vmdkFileContent),"UTF-8"));) {
 String line;
 while ((line = in.readLine()) != null) {
 // ignore empty and comment lines
 line = line.trim();
-if (line.isEmpty())
-continue;
-if (line.charAt(0) == '#')
+if (line.isEmpty() | line.charAt(0) == '#') {
--- End diff --

will redo the travis thing as well ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1530#discussion_r64402502
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
 
 import org.apache.log4j.Logger;
 
+import com.cloud.utils.StringUtils;
+import com.google.common.base.Preconditions;
+
 public class VmdkFileDescriptor {
 private static final Logger s_logger = 
Logger.getLogger(VmdkFileDescriptor.class);
 private static final String VMDK_PROPERTY_CREATE_TYPE = "createType";
 private static final String VMDK_CREATE_TYPE_VMFSSPARSE = "vmfsSparse";
 private static final String VMDK_PROPERTY_ADAPTER_TYPE = 
"ddb.adapterType";
 
-private Properties _properties = new Properties();
+private final Properties _properties = new Properties();
 private String _baseFileName;
 
 public VmdkFileDescriptor() {
 }
 
 public void parse(byte[] vmdkFileContent) throws IOException {
-BufferedReader in = null;
-try {
-in = new BufferedReader(new InputStreamReader(new 
ByteArrayInputStream(vmdkFileContent),"UTF-8"));
+try (BufferedReader in = new BufferedReader(new 
InputStreamReader(new ByteArrayInputStream(vmdkFileContent),"UTF-8"));) {
 String line;
 while ((line = in.readLine()) != null) {
 // ignore empty and comment lines
 line = line.trim();
-if (line.isEmpty())
-continue;
-if (line.charAt(0) == '#')
+if (line.isEmpty() | line.charAt(0) == '#') {
--- End diff --

sure, i don't think it matters for a boolean but I'll change it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1548#issuecomment-221284250
  
@moul can you close and reopen the PR or rebase and force push in order to 
kick off Jenkins again so we can get this all green?

@pdion891 I think you have spent enough time with Docker to give me the the 
missing LGTM vote.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1519#issuecomment-221278559
  
@dsclose if you can fix the merge conflicts I can run this again and see 
what is outstanding.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1530#discussion_r64397004
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
 
 import org.apache.log4j.Logger;
 
+import com.cloud.utils.StringUtils;
+import com.google.common.base.Preconditions;
+
 public class VmdkFileDescriptor {
 private static final Logger s_logger = 
Logger.getLogger(VmdkFileDescriptor.class);
 private static final String VMDK_PROPERTY_CREATE_TYPE = "createType";
 private static final String VMDK_CREATE_TYPE_VMFSSPARSE = "vmfsSparse";
 private static final String VMDK_PROPERTY_ADAPTER_TYPE = 
"ddb.adapterType";
 
-private Properties _properties = new Properties();
+private final Properties _properties = new Properties();
 private String _baseFileName;
 
 public VmdkFileDescriptor() {
 }
 
 public void parse(byte[] vmdkFileContent) throws IOException {
-BufferedReader in = null;
-try {
-in = new BufferedReader(new InputStreamReader(new 
ByteArrayInputStream(vmdkFileContent),"UTF-8"));
+try (BufferedReader in = new BufferedReader(new 
InputStreamReader(new ByteArrayInputStream(vmdkFileContent),"UTF-8"));) {
 String line;
 while ((line = in.readLine()) != null) {
 // ignore empty and comment lines
 line = line.trim();
-if (line.isEmpty())
-continue;
-if (line.charAt(0) == '#')
+if (line.isEmpty() | line.charAt(0) == '#') {
--- End diff --

Yes it is; it is a binary operator. The "|" is a bitwise OR operation.

@DaanHoogland are you sure you wanted to use a "|"?
I have just glanced at the code, but it seems that you should have used the 
"||" (the or operator)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[swill]

Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1530#discussion_r64395993
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
 
 import org.apache.log4j.Logger;
 
+import com.cloud.utils.StringUtils;
+import com.google.common.base.Preconditions;
+
 public class VmdkFileDescriptor {
 private static final Logger s_logger = 
Logger.getLogger(VmdkFileDescriptor.class);
 private static final String VMDK_PROPERTY_CREATE_TYPE = "createType";
 private static final String VMDK_CREATE_TYPE_VMFSSPARSE = "vmfsSparse";
 private static final String VMDK_PROPERTY_ADAPTER_TYPE = 
"ddb.adapterType";
 
-private Properties _properties = new Properties();
+private final Properties _properties = new Properties();
 private String _baseFileName;
 
 public VmdkFileDescriptor() {
 }
 
 public void parse(byte[] vmdkFileContent) throws IOException {
-BufferedReader in = null;
-try {
-in = new BufferedReader(new InputStreamReader(new 
ByteArrayInputStream(vmdkFileContent),"UTF-8"));
+try (BufferedReader in = new BufferedReader(new 
InputStreamReader(new ByteArrayInputStream(vmdkFileContent),"UTF-8"));) {
 String line;
 while ((line = in.readLine()) != null) {
 // ignore empty and comment lines
 line = line.trim();
-if (line.isEmpty())
-continue;
-if (line.charAt(0) == '#')
+if (line.isEmpty() | line.charAt(0) == '#') {
--- End diff --

Is a single `|` really a valid operator in java???


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1556#issuecomment-221277026
  


### CI RESULTS

```
Tests Run: 82
  Skipped: 0
   Failed: 0
   Errors: 3
 Duration: 8h 11m 34s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_71Q19A/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_71Q19A/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_71Q19A/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_32_26_Y962ID:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_32_26_Y962ID/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_32_26_Y962ID/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_32_26_Y962ID/runinfo.txt)

**`/tmp/MarvinLogs/test_network_71Q19A:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_71Q19A/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_71Q19A/results.txt)
* 

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1297#issuecomment-221278053
  
Apparently `status` is missing from the `listTemplates` response in some 
cases.  I will investigate after we freeze and before we cut an RC to see if we 
can resolve it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1556#issuecomment-221277292
  
This is a clean run.  The errors here are not related to this PR.  I will 
merge this.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Somesh Naidu]

Congratulations Will!

Regards,
Somesh

-Original Message-
From: Tutkowski, Mike [mailto:mike.tutkow...@netapp.com] 
Sent: Monday, May 23, 2016 2:13 AM
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Congratulations, Will!

> On May 22, 2016, at 10:29 PM, Prashant Mishra 
>  wrote:
> 
> Congrats Will!
> 
> 
>> On 5/19/16, 2:02 PM, "Jayapal Uradi"  wrote:
>> 
>> Congrats Will.
>> 
>> Thanks,
>> Jayapal
>>> On 19-May-2016, at 1:54 pm, Rohit Yadav 
>>> wrote:
>>> 
>>> Congrats Will.
>>> 
>>> Regards,
>>> Rohit Yadav
>>> 
>>> 
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> @shapeblue
>>> 
>>> 
>>> On May 19 2016, at 12:26 pm, Sebastien Goasguen 
>>> wrote:
>>> 
>>> Morning Everyone,
>>> 
>>> Yesterday at the ASF board meeting, the board passed the resolution
>>> making Will Stevens the new Vice President of the Apache CloudStack
>>> project.
>>> 
>>> Join me in congratulating Will on this appointment, wish him luck and
>>> bring your unwavering support !
>>> 
>>> You may have noticed that Will took on RM duties for the new releases
>>> going forward and has also taken a very active role to finish bringing
>>> us to github based workflow and CI. Will has some updates on that front
>>> that I am sure you will all like.
>>> 
>>> -Sebastien
>>> Former VP CloudStack
>> 
>> 
>> 
>> 
>> DISCLAIMER
>> ==
>> This e-mail may contain privileged and confidential information which is
>> the property of Accelerite, a Persistent Systems business. It is intended
>> only for the use of the individual or entity to which it is addressed. If
>> you are not the intended recipient, you are not authorized to read,
>> retain, copy, print, distribute or use this message. If you have received
>> this communication in error, please notify the sender and delete all
>> copies of this message. Accelerite, a Persistent Systems business does
>> not accept any liability for virus infected mails.
> 
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the 
> property of Accelerite, a Persistent Systems business. It is intended only 
> for the use of the individual or entity to which it is addressed. If you are 
> not the intended recipient, you are not authorized to read, retain, copy, 
> print, distribute or use this message. If you have received this 
> communication in error, please notify the sender and delete all copies of 
> this message. Accelerite, a Persistent Systems business does not accept any 
> liability for virus infected mails.

[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...

[moul]

Github user moul commented on the pull request:

https://github.com/apache/cloudstack/pull/1548#issuecomment-221256635
  
@swill, this solution is backward compatible, the `.dockerinit` file always 
cohabited with `.dockerenv`, until recently, `.dockerinit` was removed while 
`.dockerenv` is still there



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221222391
  
@koushik-das, thanks for the review. Yes, all our model objects in the 
Nuage VSP library are Serializable :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-221221816
  
I understand @swill. I'll leave this up to you.

The PR has two LGTMs, so we can merge when we want. Same goes for #1531


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-221220936
  
rebase, yes. I will keep reformat and functional/technical changes 
segragated, however.
funny enough the .../push run is started again this time around


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221218765
  
LGTM. In some of the *Command.java and *Annswer.java classes, simple member 
types has been replaced with types defined in the Nuage VSP library. As long as 
all of them are serialisable should be good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

[resmo]

Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/1257#issuecomment-221216726
  
would like to see this fixed, @sureshanaparti can I help you out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1494#discussion_r64358114
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
 ---
@@ -19,173 +19,43 @@
 
 package com.cloud.agent.api.element;
 
-import com.cloud.agent.api.CmdBuilder;
 import com.cloud.agent.api.Command;
+import net.nuage.vsp.acs.client.api.model.VspAclRule;
+import net.nuage.vsp.acs.client.api.model.VspNetwork;
 
 import java.util.List;
-import java.util.Map;
 
 public class ApplyAclRuleVspCommand extends Command {
 
-private final boolean _networkAcl;
-private final String _networkUuid;
-private final String _networkDomainUuid;
-private final String _vpcOrSubnetUuid;
-private final String _networkName;
-private final boolean _isL2Network;
-private final List> _aclRules;
-private final long _networkId;
-private final boolean _egressDefaultPolicy;
-private final Boolean _acsIngressAcl;
+private final VspAclRule.ACLType _aclType;
+private final VspNetwork _network;
+private final List _aclRules;
--- End diff --

I am assuming that VspNetwork, VspAclRule etc. are all serialisable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-221215124
  
@DaanHoogland I don't know, can you rebase and squash push -f?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221212242
  
@GabrielBrascher, @abhinandanprateek, resolved / commented on your notes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1530#issuecomment-221211912
  
tag:easypr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1530#discussion_r64353975
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent) throws 
IOException {
 }
 }
 } finally {
-if (in != null)
+if (in != null) {
--- End diff --

abso-f^%


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1530#discussion_r64353084
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) throws 
IOException {
 while ((line = in.readLine()) != null) {
 // ignore empty and comment lines
 line = line.trim();
-if (line.isEmpty())
+if (line.isEmpty()) {
 continue;
-if (line.charAt(0) == '#')
+}
+if (line.charAt(0) == '#') {
 continue;
+}
 
-String[] tokens = line.split("=");
+final String[] tokens = line.split("=");
 if (tokens.length == 2) {
-String name = tokens[0].trim();
+final String name = tokens[0].trim();
 String value = tokens[1].trim();
-if (value.charAt(0) == '\"')
+if (value.charAt(0) == '\"') {
 value = value.substring(1, value.length() - 1);
+}
 
 _properties.put(name, value);
 } else {
 if (line.startsWith("RW")) {
-int startPos = line.indexOf('\"');
-int endPos = line.lastIndexOf('\"');
-assert (startPos > 0);
-assert (endPos > 0);
+final int startPos = line.indexOf('\"');
+final int endPos = line.lastIndexOf('\"');
+assert startPos > 0;
+assert endPos > 0;
--- End diff --

using checkState
indexOf and lastIndexOf on the same string will not ever result in endPos < 
startPos by contract, only startPos >0 and endPos != startPos should do. This 
is however searching '\' insted of FileSeparator and other improvements are 
sure to be possible, so I will leave that to a new PR someday as this change is 
old already and should leave my memory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1530#discussion_r64352201
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) throws 
IOException {
 while ((line = in.readLine()) != null) {
 // ignore empty and comment lines
 line = line.trim();
-if (line.isEmpty())
+if (line.isEmpty()) {
 continue;
-if (line.charAt(0) == '#')
+}
+if (line.charAt(0) == '#') {
--- End diff --

changed (finally)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[nlivens]

Github user nlivens commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1494#discussion_r64350508
  
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final long 
routerId, final long guestNe
 sc.setParameters("states", State.Stopped);
 return listBy(sc);
 }
+
+@Override
+public List listIncludingRemovedByVpcId(long vpcId) {
+SearchCriteria sc = VpcSearch.create();
--- End diff --

These are not column names, these are the names that are given inside that 
VpcSearch object. This is how it's done in all DAOs :)
```java
VpcSearch = createSearchBuilder();
VpcSearch.and("role", VpcSearch.entity().getRole(), Op.EQ);
VpcSearch.and("vpcId", VpcSearch.entity().getVpcId(), Op.EQ);
VpcSearch.done();
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-221205073
  
timeouts in the before_script.sh again but I will investigate locally.
@rhtyd do you know why only continuous-integration/travis-ci/pr was run 
this time and continuous-integration/travis-ci/push was run 4 days ago?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1297#issuecomment-221202570
  
@swill, do you know what those errors are about? (always a dizzy feeling 
when this happens)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1556#issuecomment-221202485
  
Simple changes. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

[luhaijiao]

Github user luhaijiao commented on the pull request:

https://github.com/apache/cloudstack/pull/1519#issuecomment-221202635
  
@dclose I think this PR is important for RvR environment too,  particularly 
to the commits d582358 and bf285e1.  Would be very nice to have it in 4.9 if 
you can review the CI results and fix the issues.

thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

[abhinandanprateek]

Github user abhinandanprateek commented on the pull request:

https://github.com/apache/cloudstack/pull/1531#issuecomment-221200314
  
LGTM based on code review and template build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-221190865
  
tnx @rhtyd 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-221189095
  
Done @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1511


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[rhtyd]

GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1511

4.9/master bountycastle changes

This PR adds bountycastle related version and code fixes from @DaanHoogland 
on top of https://github.com/apache/cloudstack/pull/1510

I could not fix java compilation issues when using version 1.54 with 
openjdk 1.7.0_99, @DaanHoogland can you take over? The branch in on asf remote 
so you can push/pull as necessary. Thanks.

cc @swill 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack 4.9-bountycastle-daan

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1511


commit 74514f6b9906dfd0079097c8076ec75fe68a8244
Author: Daan Hoogland 
Date:   2016-05-18T11:25:32Z

upgrade bouncy castle to version 1.54

commit 431f567073f1a912960a742539a6c0829ef5b928
Author: Daan Hoogland 
Date:   2016-05-18T11:45:41Z

pedantic formatting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-221186203
  
@rhtyd please re-open this one, if you will.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1531#issuecomment-221185506
  
sure tag:easypr LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-221184807
  
@swill There is a question about enhanced integration testing but no code 
supplied so, tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---