Re: [GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[roarain...@126.com]

thank you for replying。
But CloudStack4.6 mysql database cloud table configuration has no this name.
 mysql> use cloud
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A

Database changed
mysql> select database(); 
++
| database() |
++
| cloud  |
++
1 row in set (0.00 sec)

mysql> desc configuration;
+---+---+--+-+---+---+
| Field | Type  | Null | Key | Default   | Extra |
+---+---+--+-+---+---+
| category  | varchar(255)  | NO   | MUL | Advanced  |   |
| instance  | varchar(255)  | NO   | MUL | NULL  |   |
| component | varchar(255)  | NO   | MUL | management-server |   |
| name  | varchar(255)  | NO   | PRI | NULL  |   |
| value | varchar(8191) | YES  | | NULL  |   |
| description   | varchar(1024) | YES  | | NULL  |   |
| default_value | varchar(8191) | YES  | | NULL  |   |
| updated   | datetime  | YES  | | NULL  |   |
| scope | varchar(255)  | YES  | | NULL  |   |
| is_dynamic| tinyint(1)| NO   | | 0 |   |
+---+---+--+-+---+---+
10 rows in set (0.00 sec)

mysql> select name,value from configuration where name like '%dynamic.apiche%';
Empty set (0.00 sec)

mysql>  



roarain...@126.com
 
From: abhinandanprateek
Date: 2016-09-28 10:06
To: dev
Subject: [GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars 
that are added ...
Github user abhinandanprateek commented on the issue:
 
https://github.com/apache/cloudstack/pull/1684
  
@pdion891 The root of this issue is that 4.9 uses dynamic api checker, 
which by default is not enabled. So even when the login succeed it does not go 
anywhere as the access to any api is denied.
After upgrade run this on cloud db:  update cloud.configuration set 
value='true' where name='dynamic.apichecker.enabled';

This will fix the login issue.
I am sure this is there in upgrade documentation, @rhtyd will be the best 
person to comment if it can be included in upgrade scripts. cc @jburwell 
 
 
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 The root of this issue is that 4.9 uses dynamic api checker, 
which by default is not enabled. So even when the login succeed it does not go 
anywhere as the access to any api is denied.
After upgrade run this on cloud db:  update cloud.configuration set 
value='true' where name='dynamic.apichecker.enabled';

This will fix the login issue.
I am sure this is there in upgrade documentation, @rhtyd will be the best 
person to comment if it can be included in upgrade scripts. cc @jburwell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@serg38 no problem


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@jburwell @rhtyd Thanks in advance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@rhytd can you help @serg38 craft a template with KVM installed and the 
virsh commands to create a nested VM?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
Did a code walk-thru and review with @murali-reddy, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@jburwell The only BUILTIN Centos template for Vmware is 5.3 that doesn't 
have KVM support to my knowledge. Are you proposing to introduce another 
BUILTIN template so that it is available for anyone to use during the 
integration testing? We don't have any KVM expertise at this point so this will 
be next to mission impossible. The only option for us would be to package 
vSphere python SDK and try to talk to vCenter directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1678: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1678
  
@jburwell there was some issue with jenkins, force pushing PR resolved it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
@karuturi awaiting feature enhancement to blueorangutan which was delayed 
due to an medical emergency.  Also, I want to wait to perform further testing 
until #1692 is tested and merged as it fixes a number of smoke test errors.  
Tests for it are running now, and I expect it to be merged tomorrow (28 Sept 
2016).  I apologize for the wait.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@serg38 the goal is not only verify that functionality works now, but in 
the future to protect against regressions.  My thinking is that we could deploy 
a CentOS VM, install KVM, and verify that we can create an ephemeral VM within 
it.  A specially packaged template could have the KVM packages pre-installed 
and a small Debian or Alpine template on-board.  The test would pass when it is 
able to SSH into the nested VM over the link-local interface.  Such a test 
would be self-contained and not require any particular storage or network 
settings.  Does such a test seem reasonable and valuable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@syed #1692 is testing now.  It addresses ping test related failures in the 
smoke test suite.  I am hoping the tests pass, and we can merge it first thing 
tomorrow.  Once it has, we can rebase this branch and kick of the smoke test 
run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled tests ...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1693
  
LGTM on the testing 
```
test DeployVM in anti-affinity groups for project ... === TestName: 
test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS ===
test DeployVM in anti-affinity groups ... === TestName: 
test_DeployVmAntiAffinityGroup | Status : SUCCESS ===
Test 3D GPU support ... === TestName: test_3d_gpu_support | Status : 
SUCCESS ===
Test Deploy Virtual Machine ... SKIP: This test case is written 
specificallyfor XenServer hypervisor
Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
Test deploy virtual machine with root resize ... === TestName: 
test_00_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize of 0 ... 
=== TestName: test_01_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize less than 
template size ... === TestName: test_02_deploy_vm_root_resize | Status : 
SUCCESS ===
Test to deploy vm with a first fit offering ... === TestName: 
test_deployvm_firstfit | Status : SUCCESS ===
Test deploy VMs using user concentrated planner ... === TestName: 
test_deployvm_userconcentrated | Status : SUCCESS ===
Test deploy VMs using user dispersion planner ... === TestName: 
test_deployvm_userdispersing | Status : SUCCESS ===
Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | 
Status : SUCCESS ===
Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
Test to create disk offering ... === TestName: test_01_create_disk_offering 
| Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: 
test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: 
test_04_create_fat_type_disk_offering | Status : SUCCESS ===
Test to update existing disk offering ... === TestName: 
test_02_edit_disk_offering | Status : SUCCESS ===
Test to delete disk offering ... === TestName: test_03_delete_disk_offering 
| Status : SUCCESS ===
Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Test to check role, role permissions and account life cycles ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests that default four roles exist ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests role update when role is in use by an account ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests concurrent order updation of role permission ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests creation of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests listing of default role's permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests order updation of role permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
test update configuration setting at zone level scope ... === TestName: 
test_UpdateConfigParamWithScope | Status : SUCCESS ===
Test guest vlan range dedication ... === TestName: 
test_dedicateGuestVlanRange | Status : SUCCESS ===
Test create public & private ISO ... === TestName: test_01_create_iso | 
Status : SUCCESS ===
Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS ===
Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS ===
Test for extract ISO ... === TestName: test_04_extract_Iso | Status : 
SUCCESS ===
Update & Test for ISO permissions ... === TestName: test_05_iso_permissions 
| Status : SUCCESS ===
Test for copy ISO from one zone to another ... SKIP: Not enough zones 
available to perform copy template
Test delete ISO ... === TestName: test_07_list_default_iso | Status : 
SUCCESS ===
Test listing Volumes using 'ids' parameter ... === TestName: 
test_01_list_volumes | Status : SUCCESS ===
Test listing Templates using 'ids' parameter ... === TestName: 
test_02_list_templates | Status : SUCCESS ===

RE: [DISCUSS] Replacing the VR

[Marty Godsey]

Matthew,

From an Engineers viewpoint and someone who has a production deployment of 
CloudStack now offering VPC services to providers, I think the approach of a 
plugin is a wise move. As you mentioned,  a full blown replacement of the VR, 
since it is such a vital piece of ACS, would require extensive work to make 
sure that it is not only implemented in such a manner as to support future 
changes more easily but also in a way that provides a rock solid platform when 
upgraded since al the VRs would need to be upgraded. By doing it as a plugin, 
this allows providers to "try" out VyOS first in a non-destructive manner and 
easily roll back if it proves to not be a good move.

So I agree with the plugin route.

Regards,
Marty Godsey

-Original Message-
From: Matthew Smart [mailto:msm...@smartsoftwareinc.com] 
Sent: Tuesday, September 27, 2016 7:13 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Replacing the VR

Will,

I think that would be very helpful to me at least and for posterity for sure. I 
am in the process of rolling out my first production deployment of Cloudstack 
so I have been busier than expected (plus I have been jumping back and forth 
between different offices). What I intended to propose was that we tackle this 
using an intermediary step. Instead of jumping in and replacing the VR 
wholesale from the start of this initiative what if we look at integrating Vyos 
as a plugin in the same manner as other network offering plugins. Replacing 
such a core and vital component of the Cloudstack infrastructure as the VR 
should be met with a great deal of caution and with careful thought and 
planning. Such a replacement would require a nontrivial amount of effort by 
core contributors to be successful and it is questionable whether such an 
initiative is the area where they feel their time is best invested.

In my opinion, using the current plugin capabilities of Cloudstack as a first 
step would have the benefit of giving the devs a proof of concept that can be 
used to evaluate Vyos as a potential replacement for the current VR without 
touching the current core networking functionality at all. Additionally, the 
code needed to integrate Vyos as a plugin would, I assume, be directly reusable 
if the decision is made to go forward with a Vyos based VR refactor. So we are 
not duplicating or wasting effort either. Plus, it would serve as an excellent 
process during which to document the network offering plugin architecture.

On the downside to this approach, my understanding would be that the Vyos 
deploy in such an environment would have to be external to the cloudstack 
ecosystem it supports (either a bare metal install or a non cloudstack managed 
VM). Personally, for POC purposes I do not see this as a huge stumbling block 
since I expect that anyone who works on cloudstack can deploy a VM using Virsh 
or some similar hypervisor interface.

What do you think of that approach? What percentage of the functions current 
embodied by the VR are abstracted in such a way as to be offloadable to a 
plugin? Would such a plugin be feature complete enough to represent a proof of 
concept for a potential Vyos based VR?

Thanks,


Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 09/26/2016 03:01 PM, Will Stevens wrote:
> I feel like I have squashed this discussion with my potential approach 
> to handling this.  Maybe we should just pickup this discussion 
> assuming I didn't post that.  :P
>
> Regarding the docs.  I have considered building a stubbed example 
> network plugin and then documenting how you would take that stub and build on 
> it.
> Would that be interesting?
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw 
> @CloudOps_
>
> On Fri, Sep 23, 2016 at 12:15 AM, Murali Reddy 
> 
> wrote:
>
>> Matthew,
>>
>> Please see https://cwiki.apache.org/confluence/display/CLOUDSTACK/
>> Extending+CloudStack+Networking
>>
>> Thanks,
>> Murali
>>
>>
>>
>>
>>
>> On 22/09/16, 11:23 PM, "Matthew Smart" 
>> wrote:
>>
>>> Hey Murali,
>>>
>>> I have been reading through the API and other documentation to try 
>>> to get a basic understanding of the network service offering 
>>> abstraction methodology in CS. I have not dove into the code yet but 
>>> before I did I thought I would try a different approach.
>>>
>>> Imagine I were to come to this list and say that I have a network 
>>> offering that I sell and that I wanted to write whatever I needed to 
>>> in order to integrate it as an offering in CloudStack. Is there some 
>>> specific documentation and guidelines you would direct me to read in 
>>> order to gather the knowledge necessary to create a cloudstack 
>>> compatible interface for my product?
>>>
>>> I don't know 

Re: [DISCUSS] Replacing the VR

[Matthew Smart]

Will,

I think that would be very helpful to me at least and for posterity for 
sure. I am in the process of rolling out my first production deployment 
of Cloudstack so I have been busier than expected (plus I have been 
jumping back and forth between different offices). What I intended to 
propose was that we tackle this using an intermediary step. Instead of 
jumping in and replacing the VR wholesale from the start of this 
initiative what if we look at integrating Vyos as a plugin in the same 
manner as other network offering plugins. Replacing such a core and 
vital component of the Cloudstack infrastructure as the VR should be met 
with a great deal of caution and with careful thought and planning. Such 
a replacement would require a nontrivial amount of effort by core 
contributors to be successful and it is questionable whether such an 
initiative is the area where they feel their time is best invested.


In my opinion, using the current plugin capabilities of Cloudstack as a 
first step would have the benefit of giving the devs a proof of concept 
that can be used to evaluate Vyos as a potential replacement for the 
current VR without touching the current core networking functionality at 
all. Additionally, the code needed to integrate Vyos as a plugin would, 
I assume, be directly reusable if the decision is made to go forward 
with a Vyos based VR refactor. So we are not duplicating or wasting 
effort either. Plus, it would serve as an excellent process during which 
to document the network offering plugin architecture.


On the downside to this approach, my understanding would be that the 
Vyos deploy in such an environment would have to be external to the 
cloudstack ecosystem it supports (either a bare metal install or a non 
cloudstack managed VM). Personally, for POC purposes I do not see this 
as a huge stumbling block since I expect that anyone who works on 
cloudstack can deploy a VM using Virsh or some similar hypervisor interface.


What do you think of that approach? What percentage of the functions 
current embodied by the VR are abstracted in such a way as to be 
offloadable to a plugin? Would such a plugin be feature complete enough 
to represent a proof of concept for a potential Vyos based VR?


Thanks,


Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 09/26/2016 03:01 PM, Will Stevens wrote:

I feel like I have squashed this discussion with my potential approach to
handling this.  Maybe we should just pickup this discussion assuming I
didn't post that.  :P

Regarding the docs.  I have considered building a stubbed example network
plugin and then documenting how you would take that stub and build on it.
Would that be interesting?

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Fri, Sep 23, 2016 at 12:15 AM, Murali Reddy 
wrote:


Matthew,

Please see https://cwiki.apache.org/confluence/display/CLOUDSTACK/
Extending+CloudStack+Networking

Thanks,
Murali





On 22/09/16, 11:23 PM, "Matthew Smart" 
wrote:


Hey Murali,

I have been reading through the API and other documentation to try to
get a basic understanding of the network service offering abstraction
methodology in CS. I have not dove into the code yet but before I did I
thought I would try a different approach.

Imagine I were to come to this list and say that I have a network
offering that I sell and that I wanted to write whatever I needed to in
order to integrate it as an offering in CloudStack. Is there some
specific documentation and guidelines you would direct me to read in
order to gather the knowledge necessary to create a cloudstack
compatible interface for my product?

I don't know the history but I see several products that have navigated
this process (Nuage, Nicira, ...etc) and am wondering how a new provider
would work with you guys to navigate that process. If this is too vague,
we can pretend my new offering is a hardware firewall device.

My goal here is to gain an understanding of how CS interacts with third
party offerings underneath the hood. I have some thoughts (I think
inline with Will Steven's brain dump and diagram) but want to make sure
I am not suffering some misapprehensions about the architecture and,
short of tracing code, was not successful at finding the information I
needed to satisfy myself that I know how it is designed.

Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 09/20/2016 04:54 AM, Murali Reddy wrote:

Configuration management of network appliances particularly for Cloud

and NFV scenarios is still evolving area. Programmability is the not the
strength for even the most popular 

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@milamberspace I agree because it appears to remove the need to maintain 
the Python compilation script which reduces complexity and doesn't add any more 
build time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

[milamberspace]

Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@rhtyd in the normal case, if the key label.affinity.groups doesn't exists, 
the default language is display ("Affinity Groups" in this case). The PR is a 
regression for this case (vs the current 4.9 version).
@rhtyd the quote issue is now fixed on my test platform.
@jburwell the json key/vleu format seems a good way. I will try to test the 
changes of current transifex process to move to json file next weekend (1st 
oct).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [RESULT][VOTE] Apache CloudStack 4.8.1

[Will Stevens]

Yes. That is why I did the vote and release, even though we did not
advertise it, it makes things easier for dev going forward. :)

On Sep 27, 2016 5:05 PM, "John Burwell"  wrote:

> Will,
>
> We make a announcement for 4.8.2.0.  I just wanted to make sure that there
> was a 4.8.1 since we are working on 4.8.2.0 …
>
> Thanks,
> -John
>
> >
> john.burw...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
>
>
>
> On Sep 27, 2016, at 1:09 PM, Will Stevens  wrote:
> >
> > There is a different thread (take two) which has the official votes and
> > such.  I did not do an announcement for the release though.
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> > On Tue, Sep 27, 2016 at 1:07 PM, Will Stevens 
> wrote:
> >
> >> We did have an official release in the sense that it was voted on and
> >> released, but I did not make a big scene about.   You guys were working
> on
> >> 4.8.2 and I just wanted to get it released before you guys modified the
> >> branch so the release branching didn't get messed up.
> >>
> >> *Will STEVENS*
> >> Lead Developer
> >>
> >> *CloudOps* *| *Cloud Solutions Experts
> >> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> >> w cloudops.com *|* tw @CloudOps_
> >>
> >> On Tue, Sep 27, 2016 at 1:01 PM, John Burwell <
> john.burw...@shapeblue.com>
> >> wrote:
> >>
> >>> Will,
> >>>
> >>> Have we had an official 4.8.1 release?
> >>>
> >>> Thanks,
> >>> -John
> >>>
> 
> >>> john.burw...@shapeblue.com
> >>> www.shapeblue.com
> >>> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> >>> @shapeblue
> >>>
> >>>
> >>>
> >>> On Aug 15, 2016, at 11:48 AM, Will Stevens 
> wrote:
> 
>  Thanks Milamber.  I will add my own vote.
> 
>  *Will STEVENS*
>  Lead Developer
> 
>  *CloudOps* *| *Cloud Solutions Experts
>  420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>  w cloudops.com *|* tw @CloudOps_
> 
>  On Mon, Aug 15, 2016 at 11:45 AM, Milamber 
> wrote:
> 
> > Hello,
> >
> > This vote isn't compliant with the ASF release vote. We need as
> least 3
> > PMC +1 vote [1].
> >
> > Will, you can just vote +1 and resend the result. (Or another PMC
> >>> member)
> >
> > Milamber
> >
> > [1] http://www.apache.org/foundation/voting.html#ReleaseVotes
> >
> >
> >
> > On 15/08/2016 15:16, Will Stevens wrote:
> >
> >> Hi all,
> >>
> >> After 72+ hours, the vote for CloudStack 4.8.1 *passes* with
> >> 2 PMC + 1 non-PMC votes.
> >>
> >> +1 (PMC / binding)
> >> * Mike Tutkowski
> >> * Milamber
> >>
> >> +1 (non binding)
> >> * Simon Weller
> >>
> >> 0
> >> none
> >>
> >> -1
> >> none
> >>
> >> Thanks to everyone participating.
> >>
> >> I will now prepare the release announcement to go out after 24 hours
> >>> to
> >> give the mirrors time to catch up.
> >>
> >>
> >
> >>>
> >>>
> >>
>
>

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [RESULT][VOTE] Apache CloudStack 4.8.1

[John Burwell]

Will,

We make a announcement for 4.8.2.0.  I just wanted to make sure that there was 
a 4.8.1 since we are working on 4.8.2.0 …

Thanks,
-John

> 
john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

On Sep 27, 2016, at 1:09 PM, Will Stevens  wrote:
> 
> There is a different thread (take two) which has the official votes and
> such.  I did not do an announcement for the release though.
> 
> *Will STEVENS*
> Lead Developer
> 
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
> 
> On Tue, Sep 27, 2016 at 1:07 PM, Will Stevens  wrote:
> 
>> We did have an official release in the sense that it was voted on and
>> released, but I did not make a big scene about.   You guys were working on
>> 4.8.2 and I just wanted to get it released before you guys modified the
>> branch so the release branching didn't get messed up.
>> 
>> *Will STEVENS*
>> Lead Developer
>> 
>> *CloudOps* *| *Cloud Solutions Experts
>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>> w cloudops.com *|* tw @CloudOps_
>> 
>> On Tue, Sep 27, 2016 at 1:01 PM, John Burwell 
>> wrote:
>> 
>>> Will,
>>> 
>>> Have we had an official 4.8.1 release?
>>> 
>>> Thanks,
>>> -John
>>> 
 
>>> john.burw...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
>>> @shapeblue
>>> 
>>> 
>>> 
>>> On Aug 15, 2016, at 11:48 AM, Will Stevens  wrote:
 
 Thanks Milamber.  I will add my own vote.
 
 *Will STEVENS*
 Lead Developer
 
 *CloudOps* *| *Cloud Solutions Experts
 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
 w cloudops.com *|* tw @CloudOps_
 
 On Mon, Aug 15, 2016 at 11:45 AM, Milamber  wrote:
 
> Hello,
> 
> This vote isn't compliant with the ASF release vote. We need as least 3
> PMC +1 vote [1].
> 
> Will, you can just vote +1 and resend the result. (Or another PMC
>>> member)
> 
> Milamber
> 
> [1] http://www.apache.org/foundation/voting.html#ReleaseVotes
> 
> 
> 
> On 15/08/2016 15:16, Will Stevens wrote:
> 
>> Hi all,
>> 
>> After 72+ hours, the vote for CloudStack 4.8.1 *passes* with
>> 2 PMC + 1 non-PMC votes.
>> 
>> +1 (PMC / binding)
>> * Mike Tutkowski
>> * Milamber
>> 
>> +1 (non binding)
>> * Simon Weller
>> 
>> 0
>> none
>> 
>> -1
>> none
>> 
>> Thanks to everyone participating.
>> 
>> I will now prepare the release announcement to go out after 24 hours
>>> to
>> give the mirrors time to catch up.
>> 
>> 
> 
>>> 
>>> 
>> 

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@jburwell a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
Trillian test result (tid-58)
Environment: vmware-55u3 (x2), Advanced Networking
Total time taken: 33200 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1681-t58-vmware-55u3.zip
Test completed. 41 look ok, 12 have errors


Test | Result | Time (s)
--- | --- | ---
test_oobm_zchange_password | `Failure` | 20.361
test_04_rvpc_privategw_static_routes | `Failure` | 383.174
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 212.325
test_02_vpc_privategw_static_routes | `Failure` | 232.360
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 585.633
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
459.765
test_01_vpc_privategw_acl | `Failure` | 106.756
test_01_redundant_vpc_site2site_vpn | `Failure` | 412.476
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 425.171
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
399.796
test_router_dhcphosts | `Error` | 827.549
test_isolate_network_password_server | `Error` | 825.097
test_extendPhysicalNetworkVlan | `Error` | 0.031
test_dedicatePublicIpRange | `Error` | 0.213
test_04_rvpc_network_garbage_collector_nics | `Error` | 227.392
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 455.683
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 370.529
test_02_routervm_iptables_policies | `Error` | 920.696
test_01_vpc_site2site_vpn | `Error` | 491.171
test_01_vpc_remote_access_vpn | `Error` | 0.094
test_01_test_vm_volume_snapshot | `Error` | 151.079
test_01_single_VPC_iptables_policies | `Error` | 1010.381
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 843.716
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 76.635
test_router_dns_externalipquery | Success | 0.070
test_rolepermission_lifecycle_update | Success | 6.566
test_rolepermission_lifecycle_list | Success | 6.263
test_rolepermission_lifecycle_delete | Success | 6.158
test_rolepermission_lifecycle_create | Success | 6.179
test_rolepermission_lifecycle_concurrent_updates | Success | 6.302
test_role_lifecycle_update_role_inuse | Success | 6.197
test_role_lifecycle_update | Success | 11.258
test_role_lifecycle_list | Success | 6.282
test_role_lifecycle_delete | Success | 11.247
test_role_lifecycle_create | Success | 6.212
test_role_inuse_deletion | Success | 6.184
test_role_account_acls_multiple_mgmt_servers | Success | 7.661
test_role_account_acls | Success | 7.971
test_releaseIP | Success | 288.086
test_reboot_router | Success | 599.543
test_public_ip_user_account | Success | 10.186
test_public_ip_admin_account | Success | 40.235
test_oobm_multiple_mgmt_server_ownership | Success | 14.558
test_oobm_issue_power_status | Success | 10.557
test_oobm_issue_power_soft | Success | 15.557
test_oobm_issue_power_reset | Success | 15.549
test_oobm_issue_power_on | Success | 15.593
test_oobm_issue_power_off | Success | 15.590
test_oobm_issue_power_cycle | Success | 15.658
test_oobm_enabledisable_across_clusterzones | Success | 57.971
test_oobm_enable_feature_valid | Success | 5.150
test_oobm_enable_feature_invalid | Success | 0.089
test_oobm_disable_feature_valid | Success | 5.158
test_oobm_disable_feature_invalid | Success | 5.168
test_oobm_configure_invalid_driver | Success | 0.077
test_oobm_configure_default_driver | Success | 0.076
test_oobm_background_powerstate_sync | Success | 19.591
test_nic_secondaryip_add_remove | Success | 212.565
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 
76.621
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.475
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 125.136
test_network_acl | Success | 201.411
test_deployvm_userdispersing | Success | 60.629
test_deployvm_userdata_post | Success | 30.423
test_deployvm_userdata | Success | 186.248
test_deployvm_userconcentrated | Success | 55.702
test_deployvm_firstfit | Success | 196.124
test_deploy_vm_multiple | Success | 222.462
test_deploy_vm_from_iso | Success | 432.595
test_deploy_vm | Success | 0.023
test_delete_account | Success | 318.066
test_default_role_deletion | Success | 6.285
test_create_pvlan_network | Success | 5.163
test_createRegion | Success | 0.031
test_createPortablePublicIPRange | Success | 15.274
test_createPortablePublicIPAcquire | Success | 15.482
test_assign_and_removal_lb | Success | 148.732
test_advZoneVirtualRouter | Success | 0.019
test_UpdateStorageOverProvisioningFactor | Success 

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@syed @jburwell I should be able to run the tests toward the end of the 
week or during the weekend. At the moment, my resources in the lab are devoted 
to other CloudStack dev activities.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[syed]

Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@jburwell Squashed the commits. You can run the smoke tests on this. This 
change is mostly on the managed storage side so running any volume related 
tests would be helpful apart from the tests @mike-tutkowski has added.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@syed could you please squash your commits?  Once that is done, the 
following items will be need to be completed:

* [ ] Re-execute functional test since the code has changed since they were 
last run (@mike-tutowski)
* [ ] Execute regression tests on KVM, VMware, and Xen with unmanaged 
storage (@jburwell using blueorangutan)

Are there any specific component tests that should be run in addition to 
the smoke tests?
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@nathanejohnson thank you for your confirmation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[nathanejohnson]

Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@jburwell that is correct, the lab I tested on is running KVM + ceph.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@nathanejohnson to confirm, the test results in your [26 Aug 
comment](https://github.com/apache/cloudstack/pull/1645#issuecomment-242715452) 
comment were from a run on KVM + Ceph?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[nathanejohnson]

Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@jburwell , test results were posted earlier in the thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@jburwell Creating Marvin test for this PR will be a huge undertaking. It 
would require building and configuring a hypervisor in a deployed VM and then 
creating VM in VM. Considering storage, environmental and network implication 
the test will be complicated and error prone. An alternative approach would 
require integrating vSphere SDK with Marvin python libraries and query vSphere 
for the actual nested virtualization settings from a deployed VM. The effort 
doesn't seem to be warranted for such a minor change. As long as standard 
integration suite is passing this shouldn't affect any existing functionality. 
What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@nathanejohnson @kiwiflyer do you have test results to share for KVM + 
Ceph?  If not, we need to rollback this PR until we get test confirmation of 
the functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
@jburwell a Trillian-Jenkins matrix job (centos6 mgmt + xs56sp1, centos7 
mgmt + vmware55u3, ubuntu mgmt + kvmcentos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
Looks like the blueorangutan build didn't complete properly.  I am 
re-kicking it now.

@blueorangutan test matrix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [RESULT][VOTE] Apache CloudStack 4.8.1

[Will Stevens]

There is a different thread (take two) which has the official votes and
such.  I did not do an announcement for the release though.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Sep 27, 2016 at 1:07 PM, Will Stevens  wrote:

> We did have an official release in the sense that it was voted on and
> released, but I did not make a big scene about.   You guys were working on
> 4.8.2 and I just wanted to get it released before you guys modified the
> branch so the release branching didn't get messed up.
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Tue, Sep 27, 2016 at 1:01 PM, John Burwell 
> wrote:
>
>> Will,
>>
>> Have we had an official 4.8.1 release?
>>
>> Thanks,
>> -John
>>
>> >
>> john.burw...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
>> @shapeblue
>>
>>
>>
>> On Aug 15, 2016, at 11:48 AM, Will Stevens  wrote:
>> >
>> > Thanks Milamber.  I will add my own vote.
>> >
>> > *Will STEVENS*
>> > Lead Developer
>> >
>> > *CloudOps* *| *Cloud Solutions Experts
>> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
>> > w cloudops.com *|* tw @CloudOps_
>> >
>> > On Mon, Aug 15, 2016 at 11:45 AM, Milamber  wrote:
>> >
>> >> Hello,
>> >>
>> >> This vote isn't compliant with the ASF release vote. We need as least 3
>> >> PMC +1 vote [1].
>> >>
>> >> Will, you can just vote +1 and resend the result. (Or another PMC
>> member)
>> >>
>> >> Milamber
>> >>
>> >> [1] http://www.apache.org/foundation/voting.html#ReleaseVotes
>> >>
>> >>
>> >>
>> >> On 15/08/2016 15:16, Will Stevens wrote:
>> >>
>> >>> Hi all,
>> >>>
>> >>> After 72+ hours, the vote for CloudStack 4.8.1 *passes* with
>> >>> 2 PMC + 1 non-PMC votes.
>> >>>
>> >>> +1 (PMC / binding)
>> >>> * Mike Tutkowski
>> >>> * Milamber
>> >>>
>> >>> +1 (non binding)
>> >>> * Simon Weller
>> >>>
>> >>> 0
>> >>> none
>> >>>
>> >>> -1
>> >>> none
>> >>>
>> >>> Thanks to everyone participating.
>> >>>
>> >>> I will now prepare the release announcement to go out after 24 hours
>> to
>> >>> give the mirrors time to catch up.
>> >>>
>> >>>
>> >>
>>
>>
>

Re: [RESULT][VOTE] Apache CloudStack 4.8.1

[Will Stevens]

We did have an official release in the sense that it was voted on and
released, but I did not make a big scene about.   You guys were working on
4.8.2 and I just wanted to get it released before you guys modified the
branch so the release branching didn't get messed up.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Sep 27, 2016 at 1:01 PM, John Burwell 
wrote:

> Will,
>
> Have we had an official 4.8.1 release?
>
> Thanks,
> -John
>
> >
> john.burw...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
>
>
>
> On Aug 15, 2016, at 11:48 AM, Will Stevens  wrote:
> >
> > Thanks Milamber.  I will add my own vote.
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> > On Mon, Aug 15, 2016 at 11:45 AM, Milamber  wrote:
> >
> >> Hello,
> >>
> >> This vote isn't compliant with the ASF release vote. We need as least 3
> >> PMC +1 vote [1].
> >>
> >> Will, you can just vote +1 and resend the result. (Or another PMC
> member)
> >>
> >> Milamber
> >>
> >> [1] http://www.apache.org/foundation/voting.html#ReleaseVotes
> >>
> >>
> >>
> >> On 15/08/2016 15:16, Will Stevens wrote:
> >>
> >>> Hi all,
> >>>
> >>> After 72+ hours, the vote for CloudStack 4.8.1 *passes* with
> >>> 2 PMC + 1 non-PMC votes.
> >>>
> >>> +1 (PMC / binding)
> >>> * Mike Tutkowski
> >>> * Milamber
> >>>
> >>> +1 (non binding)
> >>> * Simon Weller
> >>>
> >>> 0
> >>> none
> >>>
> >>> -1
> >>> none
> >>>
> >>> Thanks to everyone participating.
> >>>
> >>> I will now prepare the release announcement to go out after 24 hours to
> >>> give the mirrors time to catch up.
> >>>
> >>>
> >>
>
>

Re: [RESULT][VOTE] Apache CloudStack 4.8.1

[John Burwell]

Will,

Have we had an official 4.8.1 release?

Thanks,
-John

> 
john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

On Aug 15, 2016, at 11:48 AM, Will Stevens  wrote:
> 
> Thanks Milamber.  I will add my own vote.
> 
> *Will STEVENS*
> Lead Developer
> 
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
> 
> On Mon, Aug 15, 2016 at 11:45 AM, Milamber  wrote:
> 
>> Hello,
>> 
>> This vote isn't compliant with the ASF release vote. We need as least 3
>> PMC +1 vote [1].
>> 
>> Will, you can just vote +1 and resend the result. (Or another PMC member)
>> 
>> Milamber
>> 
>> [1] http://www.apache.org/foundation/voting.html#ReleaseVotes
>> 
>> 
>> 
>> On 15/08/2016 15:16, Will Stevens wrote:
>> 
>>> Hi all,
>>> 
>>> After 72+ hours, the vote for CloudStack 4.8.1 *passes* with
>>> 2 PMC + 1 non-PMC votes.
>>> 
>>> +1 (PMC / binding)
>>> * Mike Tutkowski
>>> * Milamber
>>> 
>>> +1 (non binding)
>>> * Simon Weller
>>> 
>>> 0
>>> none
>>> 
>>> -1
>>> none
>>> 
>>> Thanks to everyone participating.
>>> 
>>> I will now prepare the release announcement to go out after 24 hours to
>>> give the mirrors time to catch up.
>>> 
>>> 
>> 

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@rhtyd @milamberspace I have started a conversation on dev@ to discuss 
transitioning to the JSON format.  Is acceptable to hold this PR until we come 
to consensus on that thread?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

L10N Translation File Format

[John Burwell]

All,

As part of the effort to remove the requirement for JSPs and streamline the 
development process, Milamber has raised the option of replacing the 
message*.properties files with a JSON key/value format [1].  As I understand 
it, Transifex supports this file format, and it appears that it would simplify 
the PR as it would remove the need to convert the message*.properties files to 
JSON.  Is my understanding correct?  If so, are there any downsides to 
switching over the JSON format?

Thanks,
-John

[1]: https://github.com/apache/cloudstack/pull/1669#issuecomment-249790923

john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1689: Switched to the official SolidFire SDK for Python

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1689
  
@mike-tutkowski excellent -- thanks for adding that configuration bit.  I 
am LGTM once the Jenkins and Travis complete successfully.

@karuturi @rhtyd are you able to review for a second LGTM?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1694#discussion_r80714655
  
--- Diff: 
server/test/com/cloud/storage/listener/StoragePoolMonitorTest.java ---
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.storage.listener;
+
+import com.cloud.agent.api.StartupRoutingCommand;
+import com.cloud.exception.ConnectionException;
+import com.cloud.exception.StorageUnavailableException;
+import com.cloud.host.HostVO;
+import com.cloud.hypervisor.Hypervisor;
+import com.cloud.storage.ScopeType;
+import com.cloud.storage.StorageManagerImpl;
+import com.cloud.storage.StoragePoolStatus;
+import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import java.util.Collections;
+
+public class StoragePoolMonitorTest {
+
+private StorageManagerImpl storageManager;
+private PrimaryDataStoreDao poolDao;
+private StoragePoolMonitor storagePoolMonitor;
+private HostVO host;
+private StoragePoolVO pool;
+private StartupRoutingCommand cmd;
+
+@Before
+public void setUp() throws Exception {
+storageManager = Mockito.mock(StorageManagerImpl.class);
+poolDao = Mockito.mock(PrimaryDataStoreDao.class);
+
+storagePoolMonitor = new StoragePoolMonitor(storageManager, 
poolDao);
+host = new HostVO("some-uuid");
--- End diff --

Why not pass in `UUID.randomUUID().toString()`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1694#discussion_r80714972
  
--- Diff: server/src/com/cloud/storage/listener/StoragePoolMonitor.java ---
@@ -99,12 +99,12 @@ public void processConnect(Host host, StartupCommand 
cmd, boolean forRebalance)
 }
 
 Long hostId = host.getId();
-s_logger.debug("Host " + hostId + " connected, sending 
down storage pool information ...");
+s_logger.debug("Host " + hostId + " connected, 
connecting host to shared pool id " + pool.getId() + " and sending storage pool 
information ...");
--- End diff --

Please wrap in a `if (s_logger.isDebugEnabled)` to check to avoid 
unnecessary string concatenation when the `DEBUG` level is disabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1689: Switched to the official SolidFire SDK for Python

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1689
  
@jburwell I just added that to requirements.txt. I also put a link to 
solidfire-sdk-python 1.1.0.92 in the description of this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1593
  
@serg38 I have this PR on a list to re-review.  In my view, using a global 
setting for this value is whole inappropriate.  I have been busy with other 
items, and haven't had a chance to get back around to it.  I plan to get it to 
it in the next day or two.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
Yes LGTM from my side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@koushik-das are you LGTM on this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@rhtyd can you add the configuration data to blueorangutan for the changes 
to `test_ssvm.py`?

@serg38 @nvazquez once my review comments are addressed and blueorganutan 
has been updated, we will kick test matrix to verify this PR and merge it 
master once it passes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80701705
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
--- End diff --

Relying on the result having only one space seems brittle.  Please consider 
splitting on "on" and trimming the results or using a regular expression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80702685
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
+mounted_img_store_url = split_res[0]
+for img_store in image_stores_response:
+   img_store_url = str(img_store.url)
+   if img_store_url.startswith("nfs://"):
+   img_store_url = img_store_url[6:]
+#Add colon after ip address to match output from mount 
command
+first_slash = img_store_url.find('/')
+img_store_url = img_store_url[0:first_slash] + ':' + 
img_store_url[first_slash:]
+if img_store_url == mounted_img_store_url:
+img_store_id = img_store.id
+break
--- End diff --

What is this `for` accomplishing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80704271
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
+mounted_img_store_url = split_res[0]
+for img_store in image_stores_response:
+   img_store_url = str(img_store.url)
+   if img_store_url.startswith("nfs://"):
+   img_store_url = img_store_url[6:]
+#Add colon after ip address to match output from mount 
command
+first_slash = img_store_url.find('/')
+img_store_url = img_store_url[0:first_slash] + ':' + 
img_store_url[first_slash:]
+if img_store_url == mounted_img_store_url:
+img_store_id = img_store.id
+break
+
+self.assertNotEqual(
+img_store_id,
+None,
+"Check image store id mounted on SSVM"
+)
+
+   #Update NFS version for image store mounted on SSVM
+updateConfigurationCmd = 
updateConfiguration.updateConfigurationCmd()
+updateConfigurationCmd.name = "secstorage.nfs.version"
+updateConfigurationCmd.value = nfs_version
+updateConfigurationCmd.imagestoreuuid = img_store_id
+
+updateConfigurationResponse = 
self.apiclient.updateConfiguration(updateConfigurationCmd)
+self.logger.debug("updated the parameter %s with value 
%s"%(updateConfigurationResponse.name, updateConfigurationResponse.value))
+
+   #Stop SSVM
+   self.debug("Stopping SSVM: %s" % ssvm.id)
+cmd = stopSystemVm.stopSystemVmCmd()
+cmd.id = ssvm.id
+self.apiclient.stopSystemVm(cmd)
+
+timeout = self.services["timeout"]
+while True:
+list_ssvm_response = list_ssvms(
+self.apiclient,
+id=ssvm.id
+)
+if isinstance(list_ssvm_response, list):
+if list_ssvm_response[0].state == 'Running':
+break
+if timeout == 0:
+raise Exception("List SSVM call failed!")
+
+time.sleep(self.services["sleep"])
+timeout = timeout - 1
+
+   self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+ssvm = list_ssvm_response[0]
+self.debug("SSVM state after debug: %s" % ssvm.state)
+self.assertEqual(
 

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80701833
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
--- End diff --

Please add an assertion that `list_ssvm_response` is not `None`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80702827
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
+mounted_img_store_url = split_res[0]
+for img_store in image_stores_response:
+   img_store_url = str(img_store.url)
+   if img_store_url.startswith("nfs://"):
+   img_store_url = img_store_url[6:]
+#Add colon after ip address to match output from mount 
command
+first_slash = img_store_url.find('/')
+img_store_url = img_store_url[0:first_slash] + ':' + 
img_store_url[first_slash:]
+if img_store_url == mounted_img_store_url:
+img_store_id = img_store.id
+break
+
+self.assertNotEqual(
+img_store_id,
+None,
+"Check image store id mounted on SSVM"
+)
+
+   #Update NFS version for image store mounted on SSVM
+updateConfigurationCmd = 
updateConfiguration.updateConfigurationCmd()
+updateConfigurationCmd.name = "secstorage.nfs.version"
+updateConfigurationCmd.value = nfs_version
+updateConfigurationCmd.imagestoreuuid = img_store_id
+
+updateConfigurationResponse = 
self.apiclient.updateConfiguration(updateConfigurationCmd)
+self.logger.debug("updated the parameter %s with value 
%s"%(updateConfigurationResponse.name, updateConfigurationResponse.value))
+
+   #Stop SSVM
+   self.debug("Stopping SSVM: %s" % ssvm.id)
+cmd = stopSystemVm.stopSystemVmCmd()
+cmd.id = ssvm.id
+self.apiclient.stopSystemVm(cmd)
+
+timeout = self.services["timeout"]
+while True:
+list_ssvm_response = list_ssvms(
+self.apiclient,
+id=ssvm.id
+)
--- End diff --

Please add an assertions to check the following: 

* `list_ssvm_response` is not `None`
* `list_ssvm_response` is an instance of `list_ssvm_response`
* `list_ssvm_response` contains one element with an ID equal to `ssvm.id`

Also, why is `list_ssvm_response` being re-used in multiple contexts across 
this method?  Please consider splitting into multiple variables to more clearly 
express the intent of how each result should be used and avoid overwriting 
values in a manner that causes inconsistent behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as 

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80700964
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
+mounted_img_store_url = split_res[0]
+for img_store in image_stores_response:
+   img_store_url = str(img_store.url)
+   if img_store_url.startswith("nfs://"):
+   img_store_url = img_store_url[6:]
+#Add colon after ip address to match output from mount 
command
+first_slash = img_store_url.find('/')
+img_store_url = img_store_url[0:first_slash] + ':' + 
img_store_url[first_slash:]
+if img_store_url == mounted_img_store_url:
+img_store_id = img_store.id
+break
+
+self.assertNotEqual(
+img_store_id,
+None,
+"Check image store id mounted on SSVM"
+)
+
+   #Update NFS version for image store mounted on SSVM
+updateConfigurationCmd = 
updateConfiguration.updateConfigurationCmd()
+updateConfigurationCmd.name = "secstorage.nfs.version"
+updateConfigurationCmd.value = nfs_version
+updateConfigurationCmd.imagestoreuuid = img_store_id
+
+updateConfigurationResponse = 
self.apiclient.updateConfiguration(updateConfigurationCmd)
+self.logger.debug("updated the parameter %s with value 
%s"%(updateConfigurationResponse.name, updateConfigurationResponse.value))
+
+   #Stop SSVM
+   self.debug("Stopping SSVM: %s" % ssvm.id)
+cmd = stopSystemVm.stopSystemVmCmd()
+cmd.id = ssvm.id
+self.apiclient.stopSystemVm(cmd)
+
+timeout = self.services["timeout"]
+while True:
+list_ssvm_response = list_ssvms(
+self.apiclient,
+id=ssvm.id
+)
+if isinstance(list_ssvm_response, list):
+if list_ssvm_response[0].state == 'Running':
+break
+if timeout == 0:
+raise Exception("List SSVM call failed!")
+
+time.sleep(self.services["sleep"])
+timeout = timeout - 1
--- End diff --

Please consider replacing this `while` loop (lines 1299-1311) with 
`utils.waitUntil` as it provides a Pythonic/tested implementation of waiting 
for a condition to complete.  It would also clarify the intent of this section.


---
If your project is set up for it, you can reply to this email 

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80701499
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
 # Call to verify cloud process is running
 self.test_04_cpvm_internals()
 return
+
+@attr(
+tags=[
+"advanced",
+"advancedns",
+"smoke",
+"basic",
+"sg"],
+required_hardware="true")
+def test_11_ss_nfs_version_on_ssvm(self):
+"""Test NFS Version on Secondary Storage mounted properly on SSVM
+"""
+
+   # 1) List SSVM in zone
+   # 2) Get id and url from mounted nfs store
+   # 3) Update NFS version for previous image store
+   # 4) Stop SSVM
+   # 5) Check NFS version of mounted nfs store after SSVM starts 
+
+   nfs_version = self.config.nfsVersion
+   if nfs_version == None:
+   self.skipTest('No NFS version provided in test data')
+
+   #List SSVM for zone id
+list_ssvm_response = list_ssvms(
+self.apiclient,
+systemvmtype='secondarystoragevm',
+state='Running',
+zoneid=self.zone.id
+)
+self.assertEqual(
+isinstance(list_ssvm_response, list),
+True,
+"Check list response returns a valid list"
+)
+self.assertEqual(
+len(list_ssvm_response),
+1,
+"Check list System VMs response"
+)
+
+ssvm = list_ssvm_response[0]
+image_stores_response = 
ImageStore.list(self.apiclient,zoneid=self.zone.id)
+
+   if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into SSVMs is done via management server for Vmware and 
Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+ssvm.privateip,
+"mount | grep 'type nfs'",
+hypervisor=self.hypervisor)
+
+   for res in result:
+split_res = res.split(" on ")
+mounted_img_store_url = split_res[0]
+for img_store in image_stores_response:
+   img_store_url = str(img_store.url)
+   if img_store_url.startswith("nfs://"):
+   img_store_url = img_store_url[6:]
+#Add colon after ip address to match output from mount 
command
+first_slash = img_store_url.find('/')
+img_store_url = img_store_url[0:first_slash] + ':' + 
img_store_url[first_slash:]
+if img_store_url == mounted_img_store_url:
+img_store_id = img_store.id
+break
+
+self.assertNotEqual(
+img_store_id,
+None,
+"Check image store id mounted on SSVM"
+)
+
+   #Update NFS version for image store mounted on SSVM
+updateConfigurationCmd = 
updateConfiguration.updateConfigurationCmd()
+updateConfigurationCmd.name = "secstorage.nfs.version"
+updateConfigurationCmd.value = nfs_version
+updateConfigurationCmd.imagestoreuuid = img_store_id
+
+updateConfigurationResponse = 
self.apiclient.updateConfiguration(updateConfigurationCmd)
+self.logger.debug("updated the parameter %s with value 
%s"%(updateConfigurationResponse.name, updateConfigurationResponse.value))
+
+   #Stop SSVM
+   self.debug("Stopping SSVM: %s" % ssvm.id)
--- End diff --

Please consider changing the log level to `INFO` as this information seems 
like it would be useful for monitoring the progress of the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1615#discussion_r80702139
  
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -42,12 +43,19 @@
 class TestSSVMs(cloudstackTestCase):
 
 def setUp(self):
+   test_case = super(TestSSVMs, self)
 self.apiclient = self.testClient.getApiClient()
 self.hypervisor = self.testClient.getHypervisorInfo()
 self.cleanup = []
+   self.config = test_case.getClsConfig()
 self.services = self.testClient.getParsedTestDataConfig()
 self.zone = get_zone(self.apiclient, 
self.testClient.getZoneForTests())
 
+self.logger = logging.getLogger('TestSSVMs')
+self.stream_handler = logging.StreamHandler()
+self.logger.setLevel(logging.DEBUG)
+self.logger.addHandler(self.stream_handler)
+
 # Default sleep is set to 90 seconds, which is too long if the 
SSVM takes up to 2min to start.
 # Second sleep in the loop will waste test time.
 self.services["sleep"] = 30
--- End diff --

I recognize that this value is out of the scope of this change.  However, 
would it make sense to reduce this value to 5 seconds?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1593
  
@serg38 giving your explanations I am ok with your proposal. Just one 
addendum, I think we should document it as much as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@jburwell a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@serg38 @nvazquez I apologize that I am late to the review.  I would like 
to see a Marvin test added that verifies that nested virtualization works when 
the global setting is enabled (i.e. successfully create a VM within a VM).  
Would that be possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1593
  
@rafaelweingartner @rhtyd Do we make any decision on this? The scope of 
this PR was very limited initially. It would be much easier if we don't expand 
it too far.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1677
  
@serg38 I just kicked a smoke test run on VMware.  Assuming that passes, it 
will be good for 4.9.1.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1677
  
@blueorangutan test centos7 vmware55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1615
  
@jburwell @karuturi @rafaelweingartner Can you check if this PR can be 
merged by the upcoming release? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1677
  
@jburwell It would be nice to include this PR to the upcoming release. Are 
there anything else needed ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@rafaelweingartner @jburwell @karuturi Looks like this PR has everything to 
get merged. Can we do it by the release freeze?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[pdion891]

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek did you ran a fresh install of 4.9.x  or did an upgrade 
from example 4.4.4 ?

The way I'm testing is as follow, in case I do something wrong:

1) ``git checkout tags/4.4.4 -b 4.4.4``
2) Deploy and start management-server
```
mvn -DskipTests=true clean install -T 2
mvn -Pdeveloper -pl developer -Ddeploydb
mvn -pl client jetty:run
```
4) Auth test on the ui,  then stop jetty 
5) Change version to upgrade: ``git fetch origin pull/1684/head:pr-1684``
6) Build the new version but not deploy the DB to force the upgrade path:
```
mvn -DskipTests=true clean install -T 2
mvn -pl client jetty:run
```
7) test auth as admin in the UI and it's not working.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 104
 Hypervisor xenserver
 NetworkType Advanced
 Passed=101
 Failed=2
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_ssvm.py

 * test_03_ssvm_internals Failed

* test_routers_network_ops.py

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1673
  
@wido sorry for the delayed response -- I lost track of this browser tab.  
The quickest way may be to create a new branch from 4.8, cherry pick this 
commit into it, push the new branch, and open a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 I am unable to reproduce the issue. All the authenticators 
configured are tried.
I find it strange that there are no logs. Will it be possible to take a 
second look. I need either logs or some leads to move further on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1678: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1678
  
@abhinandanprateek it appears that there is a Findbugs issue that needs to 
be addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1686: CLOUDSTACK-9507: ListVM response's guest_os id shoul...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1686
  
@rhtyd @serg38 while I agree that this change makes logical sense, it 
breaks the API compatibility which we 
[guarantee](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Releases#Releases-Versioning)
 for major releases.   5.0.0 is 
[scheduled](https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BPROPOSAL%5D+2016-2017+Release+Cycle+and+Calendar)
 to open on 5 December 2016.  I suggest that we hold this PR until that time 
when we will be accepting changes that break API backwards compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1686: CLOUDSTACK-9507: ListVM response's guest_os id shoul...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1686
  
@rhytd Current implementation has a bug as well that returns GuestOsId in 
place of GuestOsTypeId. I am for not only switching to UUID but also for fixing 
it and returning correct output.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1689: Switched to the official SolidFire SDK for Python

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1689
  
@mike-tutkowski is the SolidFire Python SDK available via pip?  If so, 
could you please add it to `requirements.txt` in the project root directory?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-32


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1685: IGNORE this PR

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-31


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1685: IGNORE this PR

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1689: Switched to the official SolidFire SDK for Python

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1689
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1685: IGNORE this PR

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1685


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1678: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1678
  
I think the build timed out. 

> [INFO] --- findbugs-maven-plugin:3.0.3:findbugs (findbugs) @ 
cloud-plugin-network-bigswitch ---
> [INFO] Fork Value is true
> Build timed out (after 96 minutes). Marking the build as aborted.
> Build was aborted
> 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
@blueorangutan @jburwell any update on the tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1694
  
@rhtyd a Trillian-Jenkins test job (centos6 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1694
  
@blueorangutan test centos6 kvm-centos7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: ACS 4.9 + VMware: Failed to deploy VPC VR due to IPAssoc failure

[Prashanth Manthena]

Hi Murali,

Thank you for the quick response.

We will try out your PR, and will keep you updated.

I have couple of questions for you:

Do you know of any other issues in ACS 4.9/master with VMware ?

Is ACS 4.9/master with VMware being supported and qualified by the
community ?

Thanking you in advance !!

With regards,
Prashanth

On Mon, Sep 26, 2016 at 2:06 PM, Murali Reddy 
wrote:

>
> findRouterEthDeviceIndex() in VmwareResource returned -1.
>
>
> Looks like CLOUDSTACK-9491: incorrect parsing of device list to find
> ethernet index of plugged NIC
>
> There is a PR https://github.com/apache/cloudstack/pull/1681
>
>
>
> On 26/09/16, 5:13 PM, "Prashanth Manthena"  nuagenetworks.net> wrote:
>
> >Hi All,
> >
> >We are hitting an issue where VPC VR is failing to come up due to IpAssoc
> >failure in ACS+VMware setup.
> >
> >We have tried with the following system VM templates:
> >
> >http://cloudstack.apt-get.eu/systemvm/4.6/systemvm64template-4.6.0-
> vmware.ova
> >
> >http://cloudstack.apt-get.eu/templates/4.7/systemvm64template-2016-05-18-
> 4.7.0-vmware.ova
> >
> >
> >Is there a more latest system VM template that fixes this issue ?
> >
> >
> >Here is the error log:
> >
> >[1:00]
> >IpAssocVpcCommand) (logid:f727c105) Prepare Ip Assoc failure on applying
> >one ip due to exception:
> >com.cloud.exception.InternalErrorException: Failed to find DomR VIF to
> >associate/disassociate IP with.
> >   at
> >com.cloud.hypervisor.vmware.resource.VmwareResource.
> prepareNetworkElementCommand(VmwareResource.java:917)
> >   at
> >com.cloud.hypervisor.vmware.resource.VmwareResource.
> prepareCommand(VmwareResource.java:803)
> >   at
> >com.cloud.agent.resource.virtualnetwork.VirtualRoutingResource.
> executeRequest(VirtualRoutingResource.java:97)
> >   at
> >com.cloud.hypervisor.vmware.resource.VmwareResource.
> executeRequest(VmwareResource.java:387)
> >   at
> >com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(
> DirectAgentAttache.java:315)
> >   at
> >org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(
> ManagedContextRunnable.java:49)
> >   at
> >org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(
> DefaultManagedContext.java:56)
> >   at
> >org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
> callWithContext(DefaultManagedContext.java:103)
> >   at
> >org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
> runWithContext(DefaultManagedContext.java:53)
> >   at
> >org.apache.cloudstack.managed.context.ManagedContextRunnable.run(
> ManagedContextRunnable.java:46)
> >   at
> >java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> >   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> >   at
> >java.util.concurrent.ScheduledThreadPoolExecutor$
> ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> >   at
> >java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(
> ScheduledThreadPoolExecutor.java:292)
> >   at
> >java.util.concurrent.ThreadPoolExecutor.runWorker(
> ThreadPoolExecutor.java:1145)
> >   at
> >java.util.concurrent.ThreadPoolExecutor$Worker.run(
> ThreadPoolExecutor.java:615)
> >   at java.lang.Thread.run(Thread.java:745)
> >2016-09-26 02:30:22,053 ERROR [c.c.a.r.v.VirtualRoutingResource]
> >(DirectAgent-80:ctx-d0fb047f 10.31.56.182, job-65/job-66, cmd:
> >IpAssocVpcCommand) (logid:f727c105) Failed to prepare VR command due to
> >com.cloud.exception.InternalErrorException: Failed to find DomR VIF to
> >associate/disassociate IP with.
> >
> >With regards,
> >Prashanth
>
>

[GitHub] cloudstack issue #1678: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1678
  
@karuturi Jenkins fail on find-bug: [ERROR] Failed to execute goal 
org.codehaus.mojo:findbugs-maven-plugin:3.0.3:findbugs (findbugs) on project 
cloud-plugin-network-bigswitch: Execution findbugs of goal 
org.codehaus.mojo:findbugs-maven-plugin:3.0.3:findbugs failed: Java returned: 
143 

I did not make any changes there, do you know if it is failing elsewhere 
too ? Or it is just some spurious failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1694
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1686: CLOUDSTACK-9507: ListVM response's guest_os id shoul...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1686
  
@serg38 I mean the os_type_id, which was previously returned as an integer 
but should be returned as a uuid. The uuid would be consumeable by the 
listGuestOsMapping API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] Fixing API response to return uuid instead of integer for listVMs

[Rohit Yadav]

All,


The listVirtualMachines API response contains a guest os_type_id field which is 
an integer, and therefore not useful or easily consumable [1].

All new/modern APIs for example should only return UUIDs for client/users to 
consume, returning integers (as in database id) may not be

consumeable. Therefore, I've sent a PR [2] that aims to fix the issue for the 
API by making it return uuid for the guest_os_type field instead of the id 
(integer).


Please share if you've any concerns around the change, as it breaks the API 
response type return by previous CloudStack versions from id to uuid for the 
listVirtualMachines API. In most cases, if you're consuming this field from the 
API response; the field should work with other APIs wherever they are further 
passed or processed and the API service should convert the id and uuid 
interchangeably.


The only APIs which directly accepts the guest os type is listGuestOsMapping 
and it works with both uuid and integer ids, though using uuids is preferred 
and advised.


[1] https://issues.apache.org/jira/browse/CLOUDSTACK-9507

[2] https://github.com/apache/cloudstack/pull/1686


Regards.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1694
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

[rhtyd]

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1694

CLOUDSTACK-9509: Host Connects Without Storage

KVM hosts on shared storage failure was accepted by mgmt server with the
host state as Up, even though there was no primary/shared storage available 
on
it. This patch offers a quick fix by throwing an exception in the storage 
monitor
which connects storage pool on host. The failure is trapped by agent manager
that disconnects the agent without any investigation.

Based on Lab tests, KVM agent may take upto 2 minutes to attempt NFS mount 
when
the storage is inaccessible (firewalled, or shutdown) before returning back 
with
an error. It is safe to assume that this won't add pressure on mgmt server 
due to
several reconnection attempts, and KVM agent would retry reconnection every 
2
minutes.

For such KVM hosts, where failure happens due to storage issues; they will 
be
briefly put in Alert state but will be mostly be in Connecting state during 
which
the KVM host attempts to mount/reconfigure NFS storage pool.

/cc @jburwell @karuturi 
@blueorangutan package

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack kvm-no-storage-failfast

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1694


commit e13e40ee9cc664ec9d326c8b6fae0c76f6adc01a
Author: Rohit Yadav 
Date:   2016-06-07T06:11:16Z

CLOUDSTACK-9509: Host Connects Without Storage

KVM hosts on shared storage failure was accepted by mgmt server with the
host state as Up, even though there was no primary/shared storage available 
on
it. This patch offers a quick fix by throwing an exception in the storage 
monitor
which connects storage pool on host. The failure is trapped by agent manager
that disconnects the agent without any investigation.

Based on Lab tests, KVM agent may take upto 2 minutes to attempt NFS mount 
when
the storage is inaccessible (firewalled, or shutdown) before returning back 
with
an error. It is safe to assume that this won't add pressure on mgmt server 
due to
several reconnection attempts, and KVM agent would retry reconnection every 
2
minutes.

For such KVM hosts, where failure happens due to storage issues; they will 
be
briefly put in Alert state but will be mostly be in Connecting state during 
which
the KVM host attempts to mount/reconfigure NFS storage pool.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@milamberspace I've fixed the issues that were raised and few other 
unescaped characters I found from the generated l10n js files. The 
`label.affinity.groups` translation does not exist in korean message.properties 
file so the label is not found and hence not translated and we see the 
label/key.

Please re-review. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
Thanks @milamberspace I'll fix them, the issues come up due to differences 
in how java/jsp urlencoded the translation strings and how the python based 
messages.properties->l10n js file converter escapes the unicode strings.

The approach to move from messages.properties to json can be done in the 
next step, as that will require change in the transifex workflow -- while this 
PR aims at removing jsps without changing the transifex workflow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@murali-reddy a Trillian-Jenkins test job (centos7 mgmt + vmware55u3) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@blueorangutan test centos7 vmware55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@jburwell function 'findRouterEthDeviceIndex' which is modified, is invoked 
when ever a new tier to VPC is added (virtual NIC is hot-plugged). Many VPC 
tests run againest the VMware environment will cover this scenario.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---