[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
@jayapalu Thanks. Have you made changes for kvm ? I cannot find 
GetVmIpAddressCommand in plugins/hypervisors/kvm(actually only find it in 
plugins/hypervisors/xenserver/)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r102651816
  
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus 
status) throws InsufficientCap
 }
 rootDiskSize = 
Long.parseLong(customParameters.get("rootdisksize"));
 
-// only KVM supports rootdisksize override
-if (hypervisorType != HypervisorType.KVM) {
-throw new 
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not 
support rootdisksize override");
+// only KVM, XenServer and VMware  supports 
rootdisksize override
+if (!(hypervisorType == HypervisorType.KVM || 
hypervisorType == HypervisorType.XenServer || hypervisorType == 
HypervisorType.VMware)) {
+throw new 
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not 
support  rootdisksize override");
--- End diff --

The condition in VolumeApiServiceImpl.java at line# 1029 above and this 
doesn't match. You skipped None and Any. Is that intentional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

[jayapalu]

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1883
  
There are no marvin tests available for this. The unique mac address 
supposed for the two different deployments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1883#discussion_r102651320
  
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long 
networkId, final long accountId, f
 }
 
 @Override
-public String getNextAvailableMacAddress(final long networkConfigId) {
+public String getNextAvailableMacAddress(final long networkConfigId, 
Integer zoneMacIdentifier) {
 final SequenceFetcher fetch = SequenceFetcher.getInstance();
-
 long seq = fetch.getNextSequence(Long.class, _tgMacAddress, 
networkConfigId);
-seq = seq | _prefix << 40 | _rand.nextInt(Short.MAX_VALUE) << 16 & 
0xl;
+if(zoneMacIdentifier!=0){
+seq = seq | _prefix << 40 | (long)zoneMacIdentifier << 32 | 
networkConfigId << 16 & 0xl;
+}
+else {
+seq = seq | _prefix << 40 | _rand.nextInt(Short.MAX_VALUE) << 
16 & 0xl;
+
+}
--- End diff --

formatted 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1883#discussion_r102651284
  
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long 
networkId, final long accountId, f
 }
 
 @Override
-public String getNextAvailableMacAddress(final long networkConfigId) {
+public String getNextAvailableMacAddress(final long networkConfigId, 
Integer zoneMacIdentifier) {
 final SequenceFetcher fetch = SequenceFetcher.getInstance();
-
 long seq = fetch.getNextSequence(Long.class, _tgMacAddress, 
networkConfigId);
-seq = seq | _prefix << 40 | _rand.nextInt(Short.MAX_VALUE) << 16 & 
0xl;
+if(zoneMacIdentifier!=0){
--- End diff --

Added null check for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r102650751
  
--- Diff: 
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java
 ---
@@ -436,7 +436,7 @@ public void testResizeVolumeCommand() {
 final Answer answer = wrapper.execute(resizeCommand, 
citrixResourceBase);
 verify(citrixResourceBase, times(1)).getConnection();
 
-assertFalse(answer.getResult());
+//assertFalse(answer.getResult());
--- End diff --

@priyankparihar @anshul1886 Is this commented statement required for future 
reference? If not, better to remove this line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
@serg38 Thanks for filtering the error :) My tests run has been with 
encryption disabled. I think trillion runs with db encryption enabled. I will 
check on how I can decrypt the value in tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r102650370
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2073,6 +2089,43 @@ protected StartAnswer execute(StartCommand cmd) {
 }
 }
 
+private void resizeRootDisk(VirtualMachineMO vmMo, DiskTO rootDiskTO, 
VmwareHypervisorHost hyperHost, VmwareContext context) throws Exception
+{
+Pair vdisk = getVirtualDiskInfo(vmMo, 
rootDiskTO.getPath() + ".vmdk");
+assert(vdisk != null);
+
+Long reqSize=((VolumeObjectTO)rootDiskTO.getData()).getSize()/1024;
+VirtualDisk disk = vdisk.first();
+if(reqSize > disk.getCapacityInKB())
+{
+VirtualMachineDiskInfo diskInfo = 
getMatchingExistingDisk(vmMo.getDiskInfoBuilder(), rootDiskTO, hyperHost, 
context);
+assert (diskInfo != null);
+String[] diskChain = diskInfo.getDiskChain();
+
+if(diskChain!=null && diskChain.length>1)
+{
+s_logger.error("Unsupported Disk chain length "+ 
diskChain.length);
+throw new Exception("Unsupported Disk chain length "+ 
diskChain.length);
+}
+if(diskInfo.getDiskDeviceBusName()==null || 
!diskInfo.getDiskDeviceBusName().toLowerCase().contains("scsi"))
--- End diff --

startsWith("scsi") ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r102649977
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -703,6 +703,16 @@ private Answer execute(ResizeVolumeCommand cmd) {
 }
 
 VirtualDisk disk = vdisk.first();
+if(vdisk.second()!=null && 
!vdisk.second().toLowerCase().contains("scsi"))
--- End diff --

@priyankparihar _vdisk.second()_ here holds the disk bus name, that would 
ide0:0,... (or) scsi0:0,...
I think startsWith("scsi") check would be more precise.

Move "_VirtualDisk disk = vdisk.first();_" stmt below this if check. For 
all non-scsi disks, the _disk_ var is unnecessarily stacked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1883#discussion_r102649918
  
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -83,9 +83,19 @@
 public final static int DEFAULT_AUTOSCALE_POLICY_INTERVAL_TIME = 30;
 public final static int DEFAULT_AUTOSCALE_POLICY_QUIET_TIME = 5 * 60;
 private final static Random s_rand = new 
Random(System.currentTimeMillis());
-
-public static long createSequenceBasedMacAddress(final long 
macAddress) {
-return macAddress | 0x0600l | (long)s_rand.nextInt(32768) 
<< 25 & 0x00fffe00l;
+private final static long prefix = 0x1e;
+
+public static long createSequenceBasedMacAddress(final long 
macAddress, long globalConfig) {
--- End diff --

It is not possible for macAddress, globalConfig to less than zero. 
For globalconfig maximum value 255 is allowed. 
macAddress value is coming from the DB (ipVO)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

[Ashadeepa]

Github user Ashadeepa commented on the issue:

https://github.com/apache/cloudstack/pull/1957
  
@rafaelweingartner : Regarding that force commit, will surely keep that in 
mind in future.

About keyword documentation, I had gone through several cloudstack apis 
(E.g. 
https://cloudstack.apache.org/api/apidocs-4.9/apis/listVirtualMachines.html, 
https://cloudstack.apache.org/api/apidocs-4.9/apis/listNetworks.html, 
https://cloudstack.apache.org/api/apidocs-4.9/apis/listZones.html, etc) , 
similar thing are being used. I do agree what you are suggesting. However,  
IMO, the API name "listVpnUser" gives an idea about the response we will get, 
i.e. listing the vpn user using a search keyword. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...

[kishankavala]

Github user kishankavala commented on the issue:

https://github.com/apache/cloudstack/pull/1922
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #838: CLOUDSTACK-8857 listProjects doesn't return ta...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/838


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #865: CLOUDSTACK-8856 Primary Storage Used(type tag ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/865


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #838: CLOUDSTACK-8857 listProjects doesn't return tags vmst...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/838
  
good fix. merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #865: CLOUDSTACK-8856 Primary Storage Used(type tag with va...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/865
  
merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/669
  
@anshul1886 Please address the open questions and rebase. Post the latest 
test results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Jira permission to close outdated/solved tickets

[Daan Hoogland]

I should be able to give you karma Rafael,
I will have a shot at it later this morning

On 22/02/17 23:00, "Rafael Weingärtner"  wrote:

Thanks.
Hahaha, if the current VP does not have karma, who will!?

Actually, those were only an example I have found much more than that; I am
adding them to a list and then I would post it here before closing them
once and for all.
I could use someone with karma to do the job, but I did not want to bother
you guys with this kind of task.

Anyways, I will finish the list and then post the tickets here.


On Wed, Feb 22, 2017 at 4:52 PM, Will Stevens  wrote:

> I closed them for you.  I don't know how the karma or whatever works to
> give permissions on Jira, but apparently I had enough permissions.  :)
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 22, 2017 at 4:49 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > How does one get permission to close tickets on Jira?
> >
> > I had some spare time today, and I was navigating through some old open
> > tickets such as https://issues.apache.org/jira/browse/CLOUDSTACK-1805,
> > https://issues.apache.org/jira/browse/CLOUDSTACK-8557, and
> > https://issues.apache.org/jira/browse/CLOUDSTACK-8156 that can be
> closed.
> > However, I did not have clearance to do so.
> >
> > Does anyone here know with whom should I talk to?
> >
> > --
> > Rafael Weingärtner
> >
>



-- 
Rafael Weingärtner



daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands
@shapeblue
  
 

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@nvazquez Are you looking at the test failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
Trillian test result (tid-890)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35724 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1961-t890-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 46 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 863.96 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 374.04 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 345.82 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.02 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 160.04 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.18 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 250.72 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 279.91 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 522.74 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 512.38 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1413.40 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 554.00 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.51 | test_volumes.py
test_08_resize_volume | Success | 156.45 | test_volumes.py
test_07_resize_fail | Success | 161.50 | test_volumes.py
test_06_download_detached_volume | Success | 156.60 | test_volumes.py
test_05_detach_volume | Success | 155.79 | test_volumes.py
test_04_delete_attached_volume | Success | 151.23 | test_volumes.py
test_03_download_attached_volume | Success | 156.28 | test_volumes.py
test_02_attach_volume | Success | 95.65 | test_volumes.py
test_01_create_volume | Success | 711.29 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.16 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.72 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 163.74 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 247.58 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.62 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.97 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 130.86 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.92 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 30.38 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.14 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 25.36 | test_templates.py
test_10_destroy_cpvm | Success | 161.67 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.47 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.55 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.56 | test_ssvm.py
test_06_stop_cpvm | Success | 131.66 | test_ssvm.py
test_05_stop_ssvm | Success | 138.70 | test_ssvm.py
test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
test_03_ssvm_internals | Success | 3.37 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.11 | test_snapshots.py
test_04_change_offering_small | Success | 240.68 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

[jayapalu]

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/843
  
@rhtyd 
This is basic zone related changes. In the above results failures are not 
related to the changes.
Can you please review the changes once. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

[jayapalu]

GitHub user jayapalu reopened a pull request:

https://github.com/apache/cloudstack/pull/1922

CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet

Acquire ip from additional public subnet and configure nat on that ip.
After this pick any from that network and access additional public subnet 
from this vm. Traffic is supposed to go via additional public subnet interface 
in the VR.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack vpcApub

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1922.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1922


commit 0645cbe14c33c8271bd2f13785288c0be0c8038c
Author: Jayapal 
Date:   2017-02-22T10:50:48Z

CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

[jayapalu]

Github user jayapalu closed the pull request at:

https://github.com/apache/cloudstack/pull/1922


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1963
  
@syed Are you looking to get this into 4.10? If you are not, I have this 
corrected in a PR scheduled for 4.11. If you are, then I think you're missing a 
file (SolidFireUtil).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...

[anshul1886]

Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/803


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...

[anshul1886]

GitHub user anshul1886 reopened a pull request:

https://github.com/apache/cloudstack/pull/803

CLOUDSTACK-8833: Fixed  Generating url and migrate volume to another 
storage , resulting two entry in UI and listvolume is not working for that 
volume

Update the volume id in volume_store_ref table to newly created volume for 
migration


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8833

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/803.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #803


commit 493f5818aaddfe96570ee2ebe1d52f8de447d7b5
Author: Anshul Gangwar 
Date:   2015-06-10T10:03:42Z

CLOUDSTACK-8833: Fixed  Generating url and migrate volume to another 
storage , resulting two entry in UI and listvolume is not working for that 
volume
Update the volume id in volume_store_ref table to newly created volume for 
migration




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1962
  
@syed This LGTM. I wonder, though, if we can only check in the necessary 
parts (i.e. not the massive rearrangements to the imports)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/669
  
@sureshanaparti, Can you have a look at this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
Trillian test result (tid-888)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46490 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr815-t888-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 46 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 530.63 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1371.46 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 552.82 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 779.75 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 84.47 | 
test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 89.57 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 321.54 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 141.72 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 542.75 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 330.08 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 668.75 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 911.71 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1042.05 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.69 | test_volumes.py
test_08_resize_volume | Success | 96.00 | test_volumes.py
test_07_resize_fail | Success | 101.28 | test_volumes.py
test_06_download_detached_volume | Success | 25.36 | test_volumes.py
test_05_detach_volume | Success | 100.40 | test_volumes.py
test_04_delete_attached_volume | Success | 10.20 | test_volumes.py
test_03_download_attached_volume | Success | 15.31 | test_volumes.py
test_02_attach_volume | Success | 10.69 | test_volumes.py
test_01_create_volume | Success | 392.31 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 410.04 | 
test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 280.22 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 191.32 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 100.63 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 262.86 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.79 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.28 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 66.22 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.31 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 10.18 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.24 | test_vm_life_cycle.py
test_01_stop_vm | Success | 30.27 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 85.75 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.06 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 5.12 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.12 | test_templates.py
test_01_create_template | Success | 50.53 | test_templates.py
test_10_destroy_cpvm | Success | 226.80 | test_ssvm.py
test_09_destroy_ssvm | Success | 204.44 | test_ssvm.py
test_08_reboot_cpvm | Success | 141.55 | test_ssvm.py
test_07_reboot_ssvm | Success | 153.82 | test_ssvm.py
test_06_stop_cpvm | Success | 166.92 | test_ssvm.py
test_05_stop_ssvm | Success | 168.97 | test_ssvm.py
test_04_cpvm_internals | Success | 1.16 | test_ssvm.py
test_03_ssvm_internals | Success | 3.32 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py
test_01_snapshot_root_disk | Success | 26.26 | test_snapshots.py
test_04_change_offering_small | Success | 126.25 | test_service_offerings.py

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[anshul1886]

Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/1867


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[anshul1886]

GitHub user anshul1886 reopened a pull request:

https://github.com/apache/cloudstack/pull/1867

CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre…

…ad if they are failed to cleanup during DeleteSnapshot command

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9706

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1867


commit 1c04b30143c84cd4c5fabf9467d2509e78b49f06
Author: Anshul Gangwar 
Date:   2016-05-09T07:15:31Z

CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thread if 
they are failed to cleanup during DeleteSnapshot command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
Trillian test result (tid-889)
Environment: xenserver-62sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32992 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr815-t889-xenserver-62sp1.zip
Intermitten failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_nic.py
Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 27 look ok, 34 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_sys_vm_start | `Failure` | 0.06 | test_secondary_storage.py
test_04_rvpc_privategw_static_routes | `Failure` | 10.65 | 
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 10.68 | 
test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 10.64 | 
test_privategw_acl.py
test_01_vpc_privategw_acl | `Failure` | 5.62 | test_privategw_acl.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
test_02_VPC_default_routes | `Error` | 5.65 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | `Error` | 10.63 | test_vpc_router_nics.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | 
test_vpc_redundant.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | 
test_volumes.py
test_change_service_offering_for_vm_with_snapshots | `Error` | 5.18 | 
test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 5.70 | 
test_vm_snapshots.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 0.00 | 
test_vm_life_cycle.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | 
test_vm_life_cycle.py
ContextSuite context=TestTemplates>:setup | `Error` | 0.00 | 
test_templates.py
test_10_destroy_cpvm | `Error` | 5.11 | test_ssvm.py
test_09_destroy_ssvm | `Error` | 5.17 | test_ssvm.py
test_08_reboot_cpvm | `Error` | 305.62 | test_ssvm.py
test_07_reboot_ssvm | `Error` | 305.48 | test_ssvm.py
test_06_stop_cpvm | `Error` | 5.12 | test_ssvm.py
test_05_stop_ssvm | `Error` | 5.14 | test_ssvm.py
test_04_cpvm_internals | `Error` | 940.12 | test_ssvm.py
test_03_ssvm_internals | `Error` | 935.76 | test_ssvm.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 5.84 | 
test_service_offerings.py
ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | 
test_routers.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | 
test_router_dns.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | 

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
@milamberspace  Should the merge to master be an empty merge? Meaning is 
this only for 4.9??


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
@rhtyd missed this one. Thanks for reminding. merging now.
@milamberspace  Thanks for keeping the translations updated for every 
release :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@sateesh-chodapuneedi can you take a look at the test failures as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1885


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1379: CLOUDSTACK-8324: config drive data set/get sc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1379


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
Trillian test result (tid-887)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30347 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1774-t887-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Test completed. 46 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 361.18 | 
test_privategw_acl.py
test_03_delete_template | `Error` | 5.08 | test_templates.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 170.90 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 71.22 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 270.95 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 277.36 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 558.44 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 515.69 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1452.89 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 559.35 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 766.32 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1328.86 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.75 | test_volumes.py
test_08_resize_volume | Success | 156.49 | test_volumes.py
test_07_resize_fail | Success | 161.50 | test_volumes.py
test_06_download_detached_volume | Success | 156.41 | test_volumes.py
test_05_detach_volume | Success | 155.73 | test_volumes.py
test_04_delete_attached_volume | Success | 151.23 | test_volumes.py
test_03_download_attached_volume | Success | 156.50 | test_volumes.py
test_02_attach_volume | Success | 129.57 | test_volumes.py
test_01_create_volume | Success | 725.23 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.19 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.77 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.78 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 282.85 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.75 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.95 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.86 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 126.15 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.16 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.34 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 70.91 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.13 | test_templates.py
test_04_extract_template | Success | 5.12 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 25.36 | test_templates.py
test_10_destroy_cpvm | Success | 191.85 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.77 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.66 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.86 | test_ssvm.py
test_06_stop_cpvm | Success | 161.82 | test_ssvm.py
test_05_stop_ssvm | Success | 134.17 | test_ssvm.py
test_04_cpvm_internals | Success | 1.27 | test_ssvm.py
test_03_ssvm_internals | Success | 3.81 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.21 | test_snapshots.py
test_04_change_offering_small | Success | 239.65 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.08 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.15 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
test_09_reboot_router | Success | 40.36 | 

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

[nathanejohnson]

Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1945
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1212
  
Trillian test result (tid-884)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35787 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1212-t884-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 46 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 369.27 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 164.37 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 65.86 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 260.56 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 276.46 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 536.00 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 509.24 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1411.07 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 552.30 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 748.25 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1298.60 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.24 | test_volumes.py
test_08_resize_volume | Success | 156.12 | test_volumes.py
test_07_resize_fail | Success | 156.26 | test_volumes.py
test_06_download_detached_volume | Success | 156.20 | test_volumes.py
test_05_detach_volume | Success | 155.79 | test_volumes.py
test_04_delete_attached_volume | Success | 151.51 | test_volumes.py
test_03_download_attached_volume | Success | 156.16 | test_volumes.py
test_02_attach_volume | Success | 95.35 | test_volumes.py
test_01_create_volume | Success | 716.02 | test_volumes.py
test_deploy_vm_multiple | Success | 267.03 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.53 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.13 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.66 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.65 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.66 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.13 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.27 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 61.10 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.33 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.11 | test_templates.py
test_01_create_template | Success | 30.33 | test_templates.py
test_10_destroy_cpvm | Success | 161.60 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.88 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.61 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.55 | test_ssvm.py
test_06_stop_cpvm | Success | 161.66 | test_ssvm.py
test_05_stop_ssvm | Success | 133.85 | test_ssvm.py
test_04_cpvm_internals | Success | 1.41 | test_ssvm.py
test_03_ssvm_internals | Success | 5.16 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
test_01_snapshot_root_disk | Success | 10.94 | test_snapshots.py
test_04_change_offering_small | Success | 239.57 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.08 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.14 | test_secondary_storage.py
test_09_reboot_router | Success | 40.29 | test_routers.py
test_08_start_router | Success | 30.23 | test_routers.py
test_07_stop_router | Success | 10.12 | test_routers.py

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
Trillian test result (tid-882)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46340 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1941-t882-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 45 look ok, 4 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 549.16 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1370.26 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 581.04 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 716.49 | 
test_privategw_acl.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 206.76 | test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 871.38 | 
test_vpc_redundant.py
test_01_vpc_site2site_vpn | Success | 295.37 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 141.56 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 408.90 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 686.62 | test_vpc_router_nics.py
test_02_redundant_VPC_default_routes | Success | 1131.55 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.53 | test_volumes.py
test_08_resize_volume | Success | 85.62 | test_volumes.py
test_07_resize_fail | Success | 100.71 | test_volumes.py
test_06_download_detached_volume | Success | 30.28 | test_volumes.py
test_05_detach_volume | Success | 100.18 | test_volumes.py
test_04_delete_attached_volume | Success | 10.15 | test_volumes.py
test_03_download_attached_volume | Success | 10.18 | test_volumes.py
test_02_attach_volume | Success | 10.79 | test_volumes.py
test_01_create_volume | Success | 392.38 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.23 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 186.28 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 130.79 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 201.75 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 36.89 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 185.14 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 85.88 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.07 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.11 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 10.15 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.20 | test_vm_life_cycle.py
test_01_stop_vm | Success | 30.21 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 130.97 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.11 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 75.54 | test_templates.py
test_10_destroy_cpvm | Success | 201.53 | test_ssvm.py
test_09_destroy_ssvm | Success | 198.75 | test_ssvm.py
test_08_reboot_cpvm | Success | 151.56 | test_ssvm.py
test_07_reboot_ssvm | Success | 153.90 | test_ssvm.py
test_06_stop_cpvm | Success | 167.13 | test_ssvm.py
test_05_stop_ssvm | Success | 168.90 | test_ssvm.py
test_04_cpvm_internals | Success | 1.11 | test_ssvm.py
test_03_ssvm_internals | Success | 3.43 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.07 | test_snapshots.py
test_04_change_offering_small | Success | 125.99 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.09 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

[syed]

GitHub user syed reopened a pull request:

https://github.com/apache/cloudstack/pull/1962

CLOUDSTACK-9798 - Resizing root disk fails when using SolidFire

This one is easy to reproduce:

1. Create a VM with where the root disk goes to the managed solidfire
2. Stop the VM
3. Resize the ROOT disk
4. Error


@mike-tutkowski  Would you be able to review this? 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack sf_root_resize_bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1962


commit 2aefba819930ee9669810a23efe5908e1897d2ab
Author: Syed 
Date:   2017-02-22T23:05:26Z

Check for null when verifying pool capacity




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

[syed]

Github user syed closed the pull request at:

https://github.com/apache/cloudstack/pull/1962


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/843
  
Trillian test result (tid-881)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46234 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr843-t881-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 45 look ok, 4 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 540.36 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1406.19 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 592.48 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 187.44 | 
test_privategw_acl.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 
328.62 | test_internal_lb.py
test_02_list_snapshots_with_removed_data_store | `Error` | 110.75 | 
test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 115.85 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 297.74 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 141.71 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 533.23 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 320.04 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 698.77 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 865.61 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1072.42 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 16.00 | test_volumes.py
test_08_resize_volume | Success | 96.11 | test_volumes.py
test_07_resize_fail | Success | 101.05 | test_volumes.py
test_06_download_detached_volume | Success | 30.58 | test_volumes.py
test_05_detach_volume | Success | 100.31 | test_volumes.py
test_04_delete_attached_volume | Success | 10.21 | test_volumes.py
test_03_download_attached_volume | Success | 15.33 | test_volumes.py
test_02_attach_volume | Success | 11.18 | test_volumes.py
test_01_create_volume | Success | 432.72 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 475.26 | 
test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 280.29 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 191.33 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 100.86 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 283.18 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.82 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 71.29 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.16 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.20 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 20.31 | test_vm_life_cycle.py
test_02_start_vm | Success | 30.32 | test_vm_life_cycle.py
test_01_stop_vm | Success | 30.30 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 121.32 | test_templates.py
test_08_list_system_templates | Success | 0.05 | test_templates.py
test_07_list_public_templates | Success | 0.06 | test_templates.py
test_05_template_permissions | Success | 0.09 | test_templates.py
test_04_extract_template | Success | 5.28 | test_templates.py
test_03_delete_template | Success | 5.13 | test_templates.py
test_02_edit_template | Success | 90.08 | test_templates.py
test_01_create_template | Success | 61.04 | test_templates.py
test_10_destroy_cpvm | Success | 226.88 | test_ssvm.py
test_09_destroy_ssvm | Success | 229.24 | test_ssvm.py
test_08_reboot_cpvm | Success | 151.66 | test_ssvm.py
test_07_reboot_ssvm | Success | 144.28 | test_ssvm.py
test_06_stop_cpvm | Success | 171.97 | test_ssvm.py
test_05_stop_ssvm | Success | 138.98 | test_ssvm.py
test_04_cpvm_internals | Success | 1.19 | test_ssvm.py
test_03_ssvm_internals | Success | 3.68 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.26 | test_snapshots.py
test_04_change_offering_small | Success | 129.37 

Re: PRs for 4.10

[Sergey Levitskiy]

I would like to get this added
https://github.com/apache/cloudstack/pull/1935


On 2/22/17, 2:33 PM, "David Mabry"  wrote:

I would like to see the following PRs merged:

https://github.com/apache/cloudstack/pull/1915
https://github.com/apache/cloudstack/pull/1954 <- This one could be 
backported to 4.8/4.9

Collectively, these solve an issue that causes the VPC router to fail due 
to a full /var/log FS.  We’ve tested these extensively in the lab and confirmed 
that it does solve the problem.

Thanks,
David Mabry

On 2/22/17, 2:00 PM, "williamstev...@gmail.com on behalf of Will Stevens" 
 wrote:

I would like to get this fix in:
https://github.com/apache/cloudstack/pull/1907

This fix is really important because it causes routing issues when the 
IP,
which was not cleaned up, is later used on a different VR.

*Will STEVENS*
Lead Developer



On Wed, Feb 22, 2017 at 5:29 AM, Rohit Yadav 
wrote:

> Rajani and all,
>
>
> Please consider following PRs for review and merge:
>
>
> https://github.com/apache/cloudstack/pull/1829 (XenServer HVM VM 
attached
> disk limit bugfix, enough LGTMs and test results)
>
> https://github.com/apache/cloudstack/pull/1941 (same as above with
> additional fixes, lacks review lgtms)
> https://github.com/apache/cloudstack/pull/1896 (translation updates)
>
> https://github.com/apache/cloudstack/pull/1770 (template size issue
> bugfix)
>
> https://github.com/apache/cloudstack/pull/1950 (Ubuntu 16.04 packaging
> tomcat6/7 support)
>
> https://github.com/apache/cloudstack/pull/1951 (xenserver7 capability 
fix
> and upgrade path from 4.9.2->4.9.3)
>
> https://github.com/apache/cloudstack/pull/1944 (metrics view and infra
> tab/UI performance improvement)
> https://github.com/apache/cloudstack/pull/1903 (cannot add users to 
vpc
> vpn)
>
> https://github.com/apache/cloudstack/pull/1945
>
> https://
> github.com/apache/cloudstack/pull/1946
>
> https://
> github.com/apache/cloudstack/pull/1947
> https://github.com/apache/cloudstack/pull/1856
> https://github.com/apache/cloudstack/pull/1212
>
>
>
> Regards.
>
> 
> From: Rajani Karuturi 
> Sent: 22 February 2017 14:41:42
> To: dev@cloudstack.apache.org
> Subject: Re: PRs for 4.10
>
> 6 days to go for the first RC.
> Please get the required lgtms and tests ready for the PRs you like to 
see
> in 4.10.
> I will try to merge all the PRs that meet the criteria.
>
> Thanks,
> ~Rajani
>
> On 19 Feb 2017 3:11 p.m., "Rajani Karuturi"  wrote:
>
> > noted.
> >
> >
> > ~ Rajani
> >
> > http://cloudplatform.accelerite.com/
> >
> >
> > On February 17, 2017 at 6:03 PM, Frank Maximus (
> > frank.maxi...@nuagenetworks.net) wrote:
> >
> > I have a couple of bugfixes on previous version outstanding,
> > which I would like to have merged to 4.10,
> > both still requiring review:
> > on 4.8: PR#1912 : 
which
> > fixes password service running on internal lb vms, making it 
impossible
> to
> > do loadbalancing on port 8080
> > on 4.9: PR#1925 : 
Minor
> > plugin fix
> >
> > Kind Regards,
> > Frank
> >
> > On Tue, Feb 14, 2017 at 10:56 PM Syed Ahmed  
wrote:
> >
> > I'd like to include https://github.com/apache/cloudstack/pull/1928 
to
> 4.10
> > as well. This is a simple fix that adds hypervisor capabilities for
> > XenServer 7
> >
> > Thanks,
> > -Syed
> >
> > On Tue, Feb 14, 2017 at 12:06 AM, Will Stevens 

> > wrote:
> >
> > Not sure, I will see if I can find some time tomorrow to look at 
this.
> > Thanks...
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Mon, Feb 13, 2017 at 11:58 PM, Rajani Karuturi 

> 

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

[leprechau]

Github user leprechau commented on the issue:

https://github.com/apache/cloudstack/pull/1606
  
What's the current status of this PR?  Is this acceptable as is?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PRs for 4.10

[David Mabry]

I would like to see the following PRs merged:

https://github.com/apache/cloudstack/pull/1915
https://github.com/apache/cloudstack/pull/1954 <- This one could be backported 
to 4.8/4.9

Collectively, these solve an issue that causes the VPC router to fail due to a 
full /var/log FS.  We’ve tested these extensively in the lab and confirmed that 
it does solve the problem.

Thanks,
David Mabry

On 2/22/17, 2:00 PM, "williamstev...@gmail.com on behalf of Will Stevens" 
 wrote:

I would like to get this fix in:
https://github.com/apache/cloudstack/pull/1907

This fix is really important because it causes routing issues when the IP,
which was not cleaned up, is later used on a different VR.

*Will STEVENS*
Lead Developer



On Wed, Feb 22, 2017 at 5:29 AM, Rohit Yadav 
wrote:

> Rajani and all,
>
>
> Please consider following PRs for review and merge:
>
>
> https://github.com/apache/cloudstack/pull/1829 (XenServer HVM VM attached
> disk limit bugfix, enough LGTMs and test results)
>
> https://github.com/apache/cloudstack/pull/1941 (same as above with
> additional fixes, lacks review lgtms)
> https://github.com/apache/cloudstack/pull/1896 (translation updates)
>
> https://github.com/apache/cloudstack/pull/1770 (template size issue
> bugfix)
>
> https://github.com/apache/cloudstack/pull/1950 (Ubuntu 16.04 packaging
> tomcat6/7 support)
>
> https://github.com/apache/cloudstack/pull/1951 (xenserver7 capability fix
> and upgrade path from 4.9.2->4.9.3)
>
> https://github.com/apache/cloudstack/pull/1944 (metrics view and infra
> tab/UI performance improvement)
> https://github.com/apache/cloudstack/pull/1903 (cannot add users to vpc
> vpn)
>
> https://github.com/apache/cloudstack/pull/1945
>
> https://
> github.com/apache/cloudstack/pull/1946
>
> https://
> github.com/apache/cloudstack/pull/1947
> https://github.com/apache/cloudstack/pull/1856
> https://github.com/apache/cloudstack/pull/1212
>
>
>
> Regards.
>
> 
> From: Rajani Karuturi 
> Sent: 22 February 2017 14:41:42
> To: dev@cloudstack.apache.org
> Subject: Re: PRs for 4.10
>
> 6 days to go for the first RC.
> Please get the required lgtms and tests ready for the PRs you like to see
> in 4.10.
> I will try to merge all the PRs that meet the criteria.
>
> Thanks,
> ~Rajani
>
> On 19 Feb 2017 3:11 p.m., "Rajani Karuturi"  wrote:
>
> > noted.
> >
> >
> > ~ Rajani
> >
> > http://cloudplatform.accelerite.com/
> >
> >
> > On February 17, 2017 at 6:03 PM, Frank Maximus (
> > frank.maxi...@nuagenetworks.net) wrote:
> >
> > I have a couple of bugfixes on previous version outstanding,
> > which I would like to have merged to 4.10,
> > both still requiring review:
> > on 4.8: PR#1912 : which
> > fixes password service running on internal lb vms, making it impossible
> to
> > do loadbalancing on port 8080
> > on 4.9: PR#1925 : Minor
> > plugin fix
> >
> > Kind Regards,
> > Frank
> >
> > On Tue, Feb 14, 2017 at 10:56 PM Syed Ahmed  wrote:
> >
> > I'd like to include https://github.com/apache/cloudstack/pull/1928 to
> 4.10
> > as well. This is a simple fix that adds hypervisor capabilities for
> > XenServer 7
> >
> > Thanks,
> > -Syed
> >
> > On Tue, Feb 14, 2017 at 12:06 AM, Will Stevens 
> > wrote:
> >
> > Not sure, I will see if I can find some time tomorrow to look at this.
> > Thanks...
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Mon, Feb 13, 2017 at 11:58 PM, Rajani Karuturi 
> > wrote:
> >
> > Thanks Will. I will take a look at this today and merge.
> >
> > Is it possible to add a systemvmtemplate job on
> > builds.apachecloudstack.net (https://builds.cloudstack.org/)
> > similar to
> > http://jenkins.buildacloud.org/job/build-systemvm64-master/ ?
> >
> > Thanks,
> >
> > ~ Rajani
> >
> > http://cloudplatform.accelerite.com/
> >
> > On February 13, 2017 at 10:46 PM, Will Stevens
> > (wstev...@cloudops.com) wrote:
> >
> > At this point, I think 1741 is ready to merge. I think we need
> > one more
> > LGTM though...
> >
> > *Will STEVENS*
> > Lead 

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

[syed]

Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1962
  
@mike-tutkowski This happens when you don't specify IOPS in the service 
offering for the VM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Jira permission to close outdated/solved tickets

[Will Stevens]

Awesome, thank you sir.

*Will STEVENS*
Lead Developer



On Wed, Feb 22, 2017 at 5:00 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Thanks.
> Hahaha, if the current VP does not have karma, who will!?
>
> Actually, those were only an example I have found much more than that; I am
> adding them to a list and then I would post it here before closing them
> once and for all.
> I could use someone with karma to do the job, but I did not want to bother
> you guys with this kind of task.
>
> Anyways, I will finish the list and then post the tickets here.
>
>
> On Wed, Feb 22, 2017 at 4:52 PM, Will Stevens 
> wrote:
>
> > I closed them for you.  I don't know how the karma or whatever works to
> > give permissions on Jira, but apparently I had enough permissions.  :)
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Wed, Feb 22, 2017 at 4:49 PM, Rafael Weingärtner <
> > rafaelweingart...@gmail.com> wrote:
> >
> > > How does one get permission to close tickets on Jira?
> > >
> > > I had some spare time today, and I was navigating through some old open
> > > tickets such as https://issues.apache.org/jira/browse/CLOUDSTACK-1805,
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-8557, and
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-8156 that can be
> > closed.
> > > However, I did not have clearance to do so.
> > >
> > > Does anyone here know with whom should I talk to?
> > >
> > > --
> > > Rafael Weingärtner
> > >
> >
>
>
>
> --
> Rafael Weingärtner
>

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Trillian test result (tid-886)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29913 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1773-t886-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 356.24 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 145.04 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 56.20 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 235.76 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 262.29 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 506.28 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 481.20 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1398.43 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 543.40 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 744.83 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1265.04 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.78 | test_volumes.py
test_08_resize_volume | Success | 156.51 | test_volumes.py
test_07_resize_fail | Success | 156.53 | test_volumes.py
test_06_download_detached_volume | Success | 156.51 | test_volumes.py
test_05_detach_volume | Success | 155.88 | test_volumes.py
test_04_delete_attached_volume | Success | 151.74 | test_volumes.py
test_03_download_attached_volume | Success | 156.96 | test_volumes.py
test_02_attach_volume | Success | 124.66 | test_volumes.py
test_01_create_volume | Success | 728.69 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.27 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.76 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.93 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 268.32 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.07 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.64 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.19 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 56.01 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.88 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.92 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.34 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 45.48 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.18 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.10 | test_templates.py
test_01_create_template | Success | 55.65 | test_templates.py
test_10_destroy_cpvm | Success | 161.67 | test_ssvm.py
test_09_destroy_ssvm | Success | 133.15 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.71 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.65 | test_ssvm.py
test_06_stop_cpvm | Success | 131.75 | test_ssvm.py
test_05_stop_ssvm | Success | 163.95 | test_ssvm.py
test_04_cpvm_internals | Success | 1.25 | test_ssvm.py
test_03_ssvm_internals | Success | 3.40 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.11 | test_snapshots.py
test_04_change_offering_small | Success | 239.68 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.07 | test_service_offerings.py
test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
@rhtyd  Can you please run trillian tests for this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
Moved the schema changes to 4920-41000 upgrade path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@rhtyd Can you kick off VMware CI on this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Jira permission to close outdated/solved tickets

[Rafael Weingärtner]

Thanks.
Hahaha, if the current VP does not have karma, who will!?

Actually, those were only an example I have found much more than that; I am
adding them to a list and then I would post it here before closing them
once and for all.
I could use someone with karma to do the job, but I did not want to bother
you guys with this kind of task.

Anyways, I will finish the list and then post the tickets here.


On Wed, Feb 22, 2017 at 4:52 PM, Will Stevens  wrote:

> I closed them for you.  I don't know how the karma or whatever works to
> give permissions on Jira, but apparently I had enough permissions.  :)
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 22, 2017 at 4:49 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > How does one get permission to close tickets on Jira?
> >
> > I had some spare time today, and I was navigating through some old open
> > tickets such as https://issues.apache.org/jira/browse/CLOUDSTACK-1805,
> > https://issues.apache.org/jira/browse/CLOUDSTACK-8557, and
> > https://issues.apache.org/jira/browse/CLOUDSTACK-8156 that can be
> closed.
> > However, I did not have clearance to do so.
> >
> > Does anyone here know with whom should I talk to?
> >
> > --
> > Rafael Weingärtner
> >
>



-- 
Rafael Weingärtner

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

[kiwiflyer]

Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

[kiwiflyer]

Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
LGTM from borisstoyanov in a commit comment (acspr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Jira permission to close outdated/solved tickets

[Will Stevens]

I closed them for you.  I don't know how the karma or whatever works to
give permissions on Jira, but apparently I had enough permissions.  :)

*Will STEVENS*
Lead Developer



On Wed, Feb 22, 2017 at 4:49 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> How does one get permission to close tickets on Jira?
>
> I had some spare time today, and I was navigating through some old open
> tickets such as https://issues.apache.org/jira/browse/CLOUDSTACK-1805,
> https://issues.apache.org/jira/browse/CLOUDSTACK-8557, and
> https://issues.apache.org/jira/browse/CLOUDSTACK-8156 that can be closed.
> However, I did not have clearance to do so.
>
> Does anyone here know with whom should I talk to?
>
> --
> Rafael Weingärtner
>

Jira permission to close outdated/solved tickets

[Rafael Weingärtner]

How does one get permission to close tickets on Jira?

I had some spare time today, and I was navigating through some old open
tickets such as https://issues.apache.org/jira/browse/CLOUDSTACK-1805,
https://issues.apache.org/jira/browse/CLOUDSTACK-8557, and
https://issues.apache.org/jira/browse/CLOUDSTACK-8156 that can be closed.
However, I did not have clearance to do so.

Does anyone here know with whom should I talk to?

-- 
Rafael Weingärtner

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

[syed]

GitHub user syed opened a pull request:

https://github.com/apache/cloudstack/pull/1963

CLOUDSTACK-9799 - Unable to create volume from snapshots with "_" in 
solidfire

Steps to reproduce:

1. Create a volume using the SolidFire plugin
2. Take a snpshot of the volume
3. Create volume from snapshot with "_" in the name
4. Error

@mike-tutkowski This as well :)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack sf_vol_from_snapshot_bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1963.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1963


commit d3d41335bc241a15a4c281cab6b7d2099f24f002
Author: Syed 
Date:   2017-02-22T21:16:44Z

Escape the volume name when creating volume from snapshot on SolidFire




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

[syed]

GitHub user syed opened a pull request:

https://github.com/apache/cloudstack/pull/1962

CLOUDSTACK-9798 - Resizing root disk fails when using SolidFire

This one is easy to reproduce:

1. Create a VM with where the root disk goes to the managed solidfire
2. Stop the VM
3. Resize the ROOT disk
4. Error


@mike-tutkowski  Would you be able to review this? 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack sf_root_resize_bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1962


commit d5a0ad8eeba111810e3e37721a05576b0c0f8ba3
Author: Syed 
Date:   2017-02-22T21:09:17Z

Check for null when verifying pool capacity




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@BlueOrangUtan help


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #351: This branch implements the CSV and native HA support ...

[kiwiflyer]

Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/351
  
tag:needslove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@BlueOrangUtan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

[kiwiflyer]

Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/669
  
tag:needslove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@syed the -cleanup scripts are for removing data that had been migrated, 
not for temporary tables. also a use case for those may be if things are done 
partly in the migrate script and partly in the migrate class, though I can't 
think of a real instance of that use case.
as for the ovs-tunnel code, we don't have to loose that, do we? SO even 
with people using it we can apply this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...

[kiwiflyer]

Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1885
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Attaching more than 14 data volumes to an instance

[Suresh Anaparti]

Friðvin,

Thanks for the suggestion. I’ll go with the schema update.

- Suresh

On 21/02/17, 7:02 PM, "Friðvin Logi Oddbjörnsson"  
wrote:

On 18 February 2017 at 20:51:42, Suresh Anaparti (
suresh.anapa...@accelerite.com) wrote:

I checked the limits set for VMware hypervisor and observed some
discrepancies. These can be either updated from the
updateHypervisorCapabilities API (max_data_volumes_limit,
max_hosts_per_cluster after improvements) or schema update during
upgradation. Which one would be better? For schema update, I have to raise
a PR.


If these are hard limits for the hypervisors, then I’m more inclined that
they be immutable (i.e. to not allow changing them through the API) and,
therefor, only updated through a schema update.  However, if these are not
hard limits for the hypervisors (or if there are some valid reasons for
allowing these limits to be easily updated), then having them updatable
through the API would make sense.


Friðvin Logi Oddbjörnsson

Senior Developer

Tel: (+354) 415 0200 | frid...@greenqloud.com

Mobile: (+354) 696 6528 | PGP Key: 57CA1B00



Twitter: @greenqloud  | @qstackcloud


www.greenqloud.com | www.qstack.com

[image: qstack_blue_landscape_byqreenqloud-01.png]





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

[kiwiflyer]

Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1946
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
seen it work in practice: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[marcaurele]

Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@syed I would prefer to move what's inside `schema-481to490-cleanup.sql` to 
the end of the file `schema-481to490.sql` as it would have been the way of 
processing during an update from 481 to 490.
If I get the go about the move, I'll do it too in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[syed]

Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
I agree with @DaanHoogland , as @marcaurele mentioned, the only file we 
need to worry about is `schema-481to490-cleanup.sql` the rest of them are 
either empty or change the configuration where the order of execution doesn't 
really matter. Looking at it briefly it looks like it modifies 
`ovs_tunnel_network` table which is used to manage OVS tunnels when using 
non-vxlan isolation. I've never seen anyone use this in production. Would be 
useful if we can find someone who has used this before. Or if no one is using, 
it is LGTM from me as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PRs for 4.10

[Will Stevens]

I would like to get this fix in:
https://github.com/apache/cloudstack/pull/1907

This fix is really important because it causes routing issues when the IP,
which was not cleaned up, is later used on a different VR.

*Will STEVENS*
Lead Developer



On Wed, Feb 22, 2017 at 5:29 AM, Rohit Yadav 
wrote:

> Rajani and all,
>
>
> Please consider following PRs for review and merge:
>
>
> https://github.com/apache/cloudstack/pull/1829 (XenServer HVM VM attached
> disk limit bugfix, enough LGTMs and test results)
>
> https://github.com/apache/cloudstack/pull/1941 (same as above with
> additional fixes, lacks review lgtms)
> https://github.com/apache/cloudstack/pull/1896 (translation updates)
>
> https://github.com/apache/cloudstack/pull/1770 (template size issue
> bugfix)
>
> https://github.com/apache/cloudstack/pull/1950 (Ubuntu 16.04 packaging
> tomcat6/7 support)
>
> https://github.com/apache/cloudstack/pull/1951 (xenserver7 capability fix
> and upgrade path from 4.9.2->4.9.3)
>
> https://github.com/apache/cloudstack/pull/1944 (metrics view and infra
> tab/UI performance improvement)
> https://github.com/apache/cloudstack/pull/1903 (cannot add users to vpc
> vpn)
>
> https://github.com/apache/cloudstack/pull/1945
>
> https://
> github.com/apache/cloudstack/pull/1946
>
> https://
> github.com/apache/cloudstack/pull/1947
> https://github.com/apache/cloudstack/pull/1856
> https://github.com/apache/cloudstack/pull/1212
>
>
>
> Regards.
>
> 
> From: Rajani Karuturi 
> Sent: 22 February 2017 14:41:42
> To: dev@cloudstack.apache.org
> Subject: Re: PRs for 4.10
>
> 6 days to go for the first RC.
> Please get the required lgtms and tests ready for the PRs you like to see
> in 4.10.
> I will try to merge all the PRs that meet the criteria.
>
> Thanks,
> ~Rajani
>
> On 19 Feb 2017 3:11 p.m., "Rajani Karuturi"  wrote:
>
> > noted.
> >
> >
> > ~ Rajani
> >
> > http://cloudplatform.accelerite.com/
> >
> >
> > On February 17, 2017 at 6:03 PM, Frank Maximus (
> > frank.maxi...@nuagenetworks.net) wrote:
> >
> > I have a couple of bugfixes on previous version outstanding,
> > which I would like to have merged to 4.10,
> > both still requiring review:
> > on 4.8: PR#1912 : which
> > fixes password service running on internal lb vms, making it impossible
> to
> > do loadbalancing on port 8080
> > on 4.9: PR#1925 : Minor
> > plugin fix
> >
> > Kind Regards,
> > Frank
> >
> > On Tue, Feb 14, 2017 at 10:56 PM Syed Ahmed  wrote:
> >
> > I'd like to include https://github.com/apache/cloudstack/pull/1928 to
> 4.10
> > as well. This is a simple fix that adds hypervisor capabilities for
> > XenServer 7
> >
> > Thanks,
> > -Syed
> >
> > On Tue, Feb 14, 2017 at 12:06 AM, Will Stevens 
> > wrote:
> >
> > Not sure, I will see if I can find some time tomorrow to look at this.
> > Thanks...
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Mon, Feb 13, 2017 at 11:58 PM, Rajani Karuturi 
> > wrote:
> >
> > Thanks Will. I will take a look at this today and merge.
> >
> > Is it possible to add a systemvmtemplate job on
> > builds.apachecloudstack.net (https://builds.cloudstack.org/)
> > similar to
> > http://jenkins.buildacloud.org/job/build-systemvm64-master/ ?
> >
> > Thanks,
> >
> > ~ Rajani
> >
> > http://cloudplatform.accelerite.com/
> >
> > On February 13, 2017 at 10:46 PM, Will Stevens
> > (wstev...@cloudops.com) wrote:
> >
> > At this point, I think 1741 is ready to merge. I think we need
> > one more
> > LGTM though...
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens
> >  wrote:
> >
> > @Daan: In order for the tests to pass with 1741, the tests have
> > to be run
> > with the SystemVM from the PR being used.
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Wed, Feb 8, 2017 at 2:46 AM, Daan Hoogland
> > 
> > wrote:
> >
> > About 1741, I started the packaging, Will but saw Boris making a
> > remark about the system VMs. I'll look into that and start the
> > tests.
> >
> > On Tue, Feb 7, 2017 at 8:19 PM, Will Stevens
> > 
> > wrote:
> >
> > I would like to get 1741(strongswan) in, but I need to get
> > Trillian to
> >
> > run
> >
> > against it with a system vm built from my pr. I have done a CI in
> > bubble
> > and it came back clean, but would like confirmation through
> > Trillian as
> > well.
> >
> > On Feb 7, 2017 2:17 PM, "Milamber"  wrote:
> >
> > And this PR for 4.9 but need to be foward to 4.10 too.
> >
> > 

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

[syed]

Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
@anshul1886 it looks like #672 is closed so that leaves us with #1941 , Are 
we targeting it for 4.10? If yes, then there are some comments there which you 
might want to address there. If we do make it into 4.10 then we can close this 
and use #1941 instead. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102556528
  
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId() {
 Assert.assertEquals(domain, domainManager.findDomainByIdOrPath(1L, 
"/validDomain/"));
 }
 
+@Test(expected=InvalidParameterValueException.class)
+public void testDeleteDomainNullDomain() {
+Mockito.when(_domainDao.findById(DOMAIN_ID)).thenReturn(null);
+domainManager.deleteDomain(DOMAIN_ID, testDomainCleanup);
+}
+
+@Test(expected=PermissionDeniedException.class)
+public void testDeleteDomainRootDomain() {
+
Mockito.when(_domainDao.findById(Domain.ROOT_DOMAIN)).thenReturn(domain);
+domainManager.deleteDomain(Domain.ROOT_DOMAIN, testDomainCleanup);
+}
+
+//TODO testDeleteDomainCleanup
+
+@Test
+public void testDeleteDomainNoCleanup() {
+domainManager.deleteDomain(DOMAIN_ID, testDomainCleanup);
+Mockito.verify(domainManager).deleteDomain(domain, 
testDomainCleanup);
+
Mockito.verify(domainManager).checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+Mockito.verify(domainManager).cleanupDomainOfferings(DOMAIN_ID);
+Mockito.verify(lock).unlock();
+Assert.assertEquals(false, domainManager.getRollBackState());
+}
+
+@Test
+public void 
testCheckDomainAccountsNetworksAndResourcesBeforeRemovingRemoveDomain() {
+
domainManager.checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+
Mockito.verify(domainManager).publishRemoveEventsAndRemoveDomain(domain);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void 
testCheckDomainAccountsNetworksAndResourcesBeforeRemovingDontRemoveDomain() {
+domainNetworkIds.add(2l);
+
domainManager.checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+Mockito.verify(domainManager).failRemoveOperation(domain, 
domainAccountsForCleanup, domainNetworkIds, false);
+}
+
+@Test
+public void testPublishRemoveEventsAndRemoveDomainSuccessfulDelete() {
+domainManager.publishRemoveEventsAndRemoveDomain(domain);
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_PRE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_domainDao).remove(DOMAIN_ID);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void testPublishRemoveEventsAndRemoveDomainExceptionDelete() {
+Mockito.when(_domainDao.remove(DOMAIN_ID)).thenReturn(false);
+domainManager.publishRemoveEventsAndRemoveDomain(domain);
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_PRE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_messageBus, 
Mockito.never()).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_domainDao).remove(DOMAIN_ID);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void testFailRemoveOperation() {
--- End diff --

Thanks! I removed `expected` from `@Test` annotation and added a catch 
block to assert exception class. It is a nasty method to test indeed :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

[syed]

Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
@rhtyd If I understand correctly if we add the DB changes in 4.9.2->4.9.3  
then after forward merging, upgrade from 4.9.2->4.10.0 should not have any 
problems with idempotency correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1903
  
Trillian test result (tid-883)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33531 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1903-t883-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 46 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 864.37 | 
test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 370.91 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 150.49 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 61.30 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 235.86 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 282.35 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 459.32 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 517.05 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1408.57 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 537.91 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1264.82 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.60 | test_volumes.py
test_08_resize_volume | Success | 156.50 | test_volumes.py
test_07_resize_fail | Success | 161.59 | test_volumes.py
test_06_download_detached_volume | Success | 156.34 | test_volumes.py
test_05_detach_volume | Success | 155.92 | test_volumes.py
test_04_delete_attached_volume | Success | 151.24 | test_volumes.py
test_03_download_attached_volume | Success | 156.42 | test_volumes.py
test_02_attach_volume | Success | 126.00 | test_volumes.py
test_01_create_volume | Success | 622.27 | test_volumes.py
test_deploy_vm_multiple | Success | 273.56 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.62 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 35.94 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.89 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.97 | test_vm_life_cycle.py
test_02_start_vm | Success | 5.15 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.36 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 75.75 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.05 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 5.25 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 35.42 | test_templates.py
test_10_destroy_cpvm | Success | 131.73 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.61 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.35 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.83 | test_ssvm.py
test_06_stop_cpvm | Success | 131.53 | test_ssvm.py
test_05_stop_ssvm | Success | 133.69 | test_ssvm.py
test_04_cpvm_internals | Success | 0.98 | test_ssvm.py
test_03_ssvm_internals | Success | 3.34 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.25 | test_snapshots.py
test_04_change_offering_small | Success | 242.71 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
test_09_reboot_router | Success | 40.39 | test_routers.py
test_08_start_router | Success | 30.30 | test_routers.py
test_07_stop_router | Success | 10.16 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.72 | test_routers.py
test_03_restart_network_cleanup | 

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-531


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1907
  
Ok, great.
Thanks for the explanation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1907
  
@rafaelweingartner the only change was to remove the extra gateway 
verification if it was a 'guest' network because this is now handled by the 
code in #1871.

```
+guest_gw = self.config.cmdline().get_guest_gw()
+logging.info("Interface has the following gateway ==> %s", 
guest_gw)
+
+if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
```

The rest of the code is the same as the original pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@borisstoyanov great, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
Thanks for this fix @nvazquez, I'll kick marvin tests to verify it doesn't 
brake any other test.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@blueorangurtan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1961: Fix for test_snapshots.py using nfs2 instead ...

[nvazquez]

GitHub user nvazquez opened a pull request:

https://github.com/apache/cloudstack/pull/1961

Fix for test_snapshots.py using nfs2 instead of nfs template

Fix for marvin test failure introduced in #1847 

Cc: @borisstoyanov @rhtyd @karuturi 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nvazquez/cloudstack addNewNfsTestData

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1961.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1961


commit e0c2ad887552b090e3a4cfabfa1d9b62e4e22a61
Author: nvazquez 
Date:   2017-02-22T18:54:02Z

Fix for test_snapshots.py using nfs2 instead of nfs template




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1953#discussion_r102539843
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
@@ -584,18 +584,36 @@ public void defFileBasedDisk(String filePath, String 
diskLabel, DiskBus bus, Dis
 
 /* skip iso label */
 private String getDevLabel(int devId, DiskBus bus) {
--- End diff --

@HrWiggles Will add unit tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1907
  
@swill LGTM for the changes.

The changes introduced now are different from the last ones, right? Now it 
is basically the addition of a log and the skipping of a processing flow if 
condition `not address['add'] and not ip.configured()` is met.

I am guessing this the PR changed because of the changes introduced with 
#1871, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1953#discussion_r102539356
  
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) 
{
 return maxDataVolumesSupported.intValue();
 }
 
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
 // allocate deviceId
-List vols = _volsDao.findByInstance(vmId);
+int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
+List vols = _volsDao.findByInstance(vm.getId());
 if (deviceId != null) {
-if (deviceId.longValue() > 15 || deviceId.longValue() == 3) {
-throw new RuntimeException("deviceId should be 1,2,4-15");
+if (deviceId.longValue() > maxDataVolumesSupported || 
deviceId.longValue() == 3) {
+throw new RuntimeException("deviceId should be 1,2,4-" + 
maxDataVolumesSupported);
 }
 for (VolumeVO vol : vols) {
 if (vol.getDeviceId().equals(deviceId)) {
-throw new RuntimeException("deviceId " + deviceId + " 
is used by vm" + vmId);
+throw new RuntimeException("deviceId " + deviceId + " 
is used by vm" + vm.getId());
 }
 }
 } else {
 // allocate deviceId here
 List devIds = new ArrayList();
-for (int i = 1; i < 15; i++) {
+for (int i = 1; i < maxDataVolumesSupported; i++) {
--- End diff --

@HrWiggles Correct. I've updated the code. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102536773
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = getGlobalLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+
+try {
+long ownerId = domain.getAccountId();
+if (BooleanUtils.toBoolean(cleanup)) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
 rollBackState = true;
 CloudRuntimeException e =
-new CloudRuntimeException("Delete failed on 
domain " + domain.getName() + " (id: " + domain.getId() +
-"); Please make sure all users and sub 
domains have been removed from the domain before deleting");
+new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
+domain.getId() + ").");
 e.addProxyObject(domain.getUuid(), "domainId");
 throw e;
 }
-_messageBus.publish(_name, 
MESSAGE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
 } else {
-rollBackState = true;
-String msg = null;
-if (!accountsForCleanup.isEmpty()) {
-msg = accountsForCleanup.size() + " accounts to 
cleanup";
-} else if (!networkIds.isEmpty()) {
-msg = networkIds.size() + " non-removed networks";
-} else if (hasDedicatedResources) {
-msg = "dedicated resources.";
-}
+
checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+}
 
-CloudRuntimeException e = new 
CloudRuntimeException("Can't 

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
Trillian test result (tid-880)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32319 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1958-t880-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 46 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 324.14 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.02 | 
test_snapshots.py
test_UpdateStorageOverProvisioningFactor | `Error` | 0.03 | 
test_over_provisioning.py
test_UpdateStorageOverProvisioningFactor | `Error` | 0.06 | 
test_over_provisioning.py
test_01_vpc_site2site_vpn | Success | 174.24 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 65.93 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 244.48 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 298.16 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 544.33 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 511.50 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1396.46 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 540.72 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 753.01 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1273.44 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 151.86 | test_volumes.py
test_08_resize_volume | Success | 156.14 | test_volumes.py
test_07_resize_fail | Success | 161.92 | test_volumes.py
test_06_download_detached_volume | Success | 155.97 | test_volumes.py
test_05_detach_volume | Success | 155.65 | test_volumes.py
test_04_delete_attached_volume | Success | 145.90 | test_volumes.py
test_03_download_attached_volume | Success | 155.99 | test_volumes.py
test_02_attach_volume | Success | 89.75 | test_volumes.py
test_01_create_volume | Success | 620.70 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.69 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 133.91 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 256.99 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.61 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.23 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 35.78 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.77 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 126.31 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.15 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.44 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 85.54 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.17 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.86 | test_templates.py
test_01_create_template | Success | 70.45 | test_templates.py
test_10_destroy_cpvm | Success | 191.88 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.07 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.53 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.82 | test_ssvm.py
test_06_stop_cpvm | Success | 131.30 | test_ssvm.py
test_05_stop_ssvm | Success | 138.75 | test_ssvm.py
test_04_cpvm_internals | Success | 0.93 | test_ssvm.py
test_03_ssvm_internals | Success | 3.41 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.08 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.08 | test_ssvm.py
test_01_snapshot_root_disk | Success | 10.92 | test_snapshots.py
test_04_change_offering_small | Success | 210.29 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102535697
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = getGlobalLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+
+try {
+long ownerId = domain.getAccountId();
+if (BooleanUtils.toBoolean(cleanup)) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
--- End diff --

Ah, the naming of methods, I also find very hard sometimes; I think most 
programmers have this problem. I think the name you proposed is ok. I am not 
creative today.

I also liked the way the code became cleaner and easier to read. It also 
facilitates future changes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102534985
  
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId() {
 Assert.assertEquals(domain, domainManager.findDomainByIdOrPath(1L, 
"/validDomain/"));
 }
 
+@Test(expected=InvalidParameterValueException.class)
+public void testDeleteDomainNullDomain() {
+Mockito.when(_domainDao.findById(DOMAIN_ID)).thenReturn(null);
+domainManager.deleteDomain(DOMAIN_ID, testDomainCleanup);
+}
+
+@Test(expected=PermissionDeniedException.class)
+public void testDeleteDomainRootDomain() {
+
Mockito.when(_domainDao.findById(Domain.ROOT_DOMAIN)).thenReturn(domain);
+domainManager.deleteDomain(Domain.ROOT_DOMAIN, testDomainCleanup);
+}
+
+//TODO testDeleteDomainCleanup
+
+@Test
+public void testDeleteDomainNoCleanup() {
+domainManager.deleteDomain(DOMAIN_ID, testDomainCleanup);
+Mockito.verify(domainManager).deleteDomain(domain, 
testDomainCleanup);
+
Mockito.verify(domainManager).checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+Mockito.verify(domainManager).cleanupDomainOfferings(DOMAIN_ID);
+Mockito.verify(lock).unlock();
+Assert.assertEquals(false, domainManager.getRollBackState());
+}
+
+@Test
+public void 
testCheckDomainAccountsNetworksAndResourcesBeforeRemovingRemoveDomain() {
+
domainManager.checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+
Mockito.verify(domainManager).publishRemoveEventsAndRemoveDomain(domain);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void 
testCheckDomainAccountsNetworksAndResourcesBeforeRemovingDontRemoveDomain() {
+domainNetworkIds.add(2l);
+
domainManager.checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+Mockito.verify(domainManager).failRemoveOperation(domain, 
domainAccountsForCleanup, domainNetworkIds, false);
+}
+
+@Test
+public void testPublishRemoveEventsAndRemoveDomainSuccessfulDelete() {
+domainManager.publishRemoveEventsAndRemoveDomain(domain);
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_PRE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_domainDao).remove(DOMAIN_ID);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void testPublishRemoveEventsAndRemoveDomainExceptionDelete() {
+Mockito.when(_domainDao.remove(DOMAIN_ID)).thenReturn(false);
+domainManager.publishRemoveEventsAndRemoveDomain(domain);
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_PRE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_messageBus, 
Mockito.never()).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_domainDao).remove(DOMAIN_ID);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void testFailRemoveOperation() {
--- End diff --

Here we still have a problem.
the exception is thrown at line 227 and the code at line 228 is never 
executed. 
That is why I called nasty to write a test here. It is very tricky


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1907
  
I have squash merged the changes that @ustcweizhou requested.  Would you 
mind reviewing again so we can get this important fix into 4.10.  Thanks...

@rafaelweingartner, it looks like I lost your code review in the process of 
doing the squashed commit.  Can you review and confirm your previous review?  

Thanks guys...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102531132
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = getGlobalLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+
+try {
+long ownerId = domain.getAccountId();
+if (BooleanUtils.toBoolean(cleanup)) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
 rollBackState = true;
 CloudRuntimeException e =
-new CloudRuntimeException("Delete failed on 
domain " + domain.getName() + " (id: " + domain.getId() +
-"); Please make sure all users and sub 
domains have been removed from the domain before deleting");
+new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
+domain.getId() + ").");
 e.addProxyObject(domain.getUuid(), "domainId");
 throw e;
 }
-_messageBus.publish(_name, 
MESSAGE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
 } else {
-rollBackState = true;
-String msg = null;
-if (!accountsForCleanup.isEmpty()) {
-msg = accountsForCleanup.size() + " accounts to 
cleanup";
-} else if (!networkIds.isEmpty()) {
-msg = networkIds.size() + " non-removed networks";
-} else if (hasDedicatedResources) {
-msg = "dedicated resources.";
-}
+
checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+}
 
-CloudRuntimeException e = new 
CloudRuntimeException("Can't delete the 

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102529801
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = getGlobalLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+
+try {
+long ownerId = domain.getAccountId();
+if (BooleanUtils.toBoolean(cleanup)) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
--- End diff --

Done, I liked it how it simplified the code inside those blocks. However, I 
still find it difficult to name methods, do you agree with name 
`tryCleanupDomain`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102531047
  
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId() {
 Assert.assertEquals(domain, domainManager.findDomainByIdOrPath(1L, 
"/validDomain/"));
 }
 
+@Test(expected=InvalidParameterValueException.class)
+public void testDeleteDomainNullDomain() {
+Mockito.when(_domainDao.findById(DOMAIN_ID)).thenReturn(null);
+domainManager.deleteDomain(DOMAIN_ID, testDomainCleanup);
+}
+
+@Test(expected=PermissionDeniedException.class)
+public void testDeleteDomainRootDomain() {
+
Mockito.when(_domainDao.findById(Domain.ROOT_DOMAIN)).thenReturn(domain);
+domainManager.deleteDomain(Domain.ROOT_DOMAIN, testDomainCleanup);
+}
+
+//TODO testDeleteDomainCleanup
+
+@Test
+public void testDeleteDomainNoCleanup() {
+domainManager.deleteDomain(DOMAIN_ID, testDomainCleanup);
+Mockito.verify(domainManager).deleteDomain(domain, 
testDomainCleanup);
+
Mockito.verify(domainManager).checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+Mockito.verify(domainManager).cleanupDomainOfferings(DOMAIN_ID);
+Mockito.verify(lock).unlock();
+Assert.assertEquals(false, domainManager.getRollBackState());
+}
+
+@Test
+public void 
testCheckDomainAccountsNetworksAndResourcesBeforeRemovingRemoveDomain() {
+
domainManager.checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+
Mockito.verify(domainManager).publishRemoveEventsAndRemoveDomain(domain);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void 
testCheckDomainAccountsNetworksAndResourcesBeforeRemovingDontRemoveDomain() {
+domainNetworkIds.add(2l);
+
domainManager.checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+Mockito.verify(domainManager).failRemoveOperation(domain, 
domainAccountsForCleanup, domainNetworkIds, false);
+}
+
+@Test
+public void testPublishRemoveEventsAndRemoveDomainSuccessfulDelete() {
+domainManager.publishRemoveEventsAndRemoveDomain(domain);
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_PRE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_domainDao).remove(DOMAIN_ID);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void testPublishRemoveEventsAndRemoveDomainExceptionDelete() {
+Mockito.when(_domainDao.remove(DOMAIN_ID)).thenReturn(false);
+domainManager.publishRemoveEventsAndRemoveDomain(domain);
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_PRE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_messageBus, 
Mockito.never()).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_domainDao).remove(DOMAIN_ID);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void testFailRemoveOperation() {
--- End diff --

Great, I've added verification, I have missed that out, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102530895
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = getGlobalLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+
+try {
+long ownerId = domain.getAccountId();
+if (BooleanUtils.toBoolean(cleanup)) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
 rollBackState = true;
 CloudRuntimeException e =
-new CloudRuntimeException("Delete failed on 
domain " + domain.getName() + " (id: " + domain.getId() +
-"); Please make sure all users and sub 
domains have been removed from the domain before deleting");
+new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
+domain.getId() + ").");
 e.addProxyObject(domain.getUuid(), "domainId");
 throw e;
 }
-_messageBus.publish(_name, 
MESSAGE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
 } else {
-rollBackState = true;
-String msg = null;
-if (!accountsForCleanup.isEmpty()) {
-msg = accountsForCleanup.size() + " accounts to 
cleanup";
-} else if (!networkIds.isEmpty()) {
-msg = networkIds.size() + " non-removed networks";
-} else if (hasDedicatedResources) {
-msg = "dedicated resources.";
-}
+
checkDomainAccountsNetworksAndResourcesBeforeRemoving(domain);
+}
 
-CloudRuntimeException e = new 
CloudRuntimeException("Can't delete the 

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
Trillian test result (tid-878)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32944 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1955-t878-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 329.25 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 164.34 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 70.82 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 270.12 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 288.94 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 511.96 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 515.21 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1413.54 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 557.28 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 743.95 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1282.32 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.30 | test_volumes.py
test_08_resize_volume | Success | 151.31 | test_volumes.py
test_07_resize_fail | Success | 161.21 | test_volumes.py
test_06_download_detached_volume | Success | 156.04 | test_volumes.py
test_05_detach_volume | Success | 155.69 | test_volumes.py
test_04_delete_attached_volume | Success | 151.00 | test_volumes.py
test_03_download_attached_volume | Success | 156.04 | test_volumes.py
test_02_attach_volume | Success | 124.19 | test_volumes.py
test_01_create_volume | Success | 724.31 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.70 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.60 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 166.79 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 257.28 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.57 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 41.07 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.79 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.68 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.13 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.37 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 60.62 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.13 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 25.28 | test_templates.py
test_10_destroy_cpvm | Success | 161.61 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.57 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.43 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.41 | test_ssvm.py
test_06_stop_cpvm | Success | 131.63 | test_ssvm.py
test_05_stop_ssvm | Success | 134.59 | test_ssvm.py
test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
test_03_ssvm_internals | Success | 3.70 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
test_01_snapshot_root_disk | Success | 10.93 | test_snapshots.py
test_04_change_offering_small | Success | 239.36 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.06 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.09 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
test_09_reboot_router | Success | 35.26