RE: New Object Storage - Huawei OBS

[Kishan Kavala]

Hi Ronald,
 Here is what I found from the logs:

Error:
WARN  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Failed to 
start module [root-ca] due to: [Failed to start bean 'cloudStackLifeCycle'; 
nested exception is java.lang.LinkageError: loader constraint violation: when 
resolving method 'org.bouncycastle.cert.X509v3CertificateBuilder 
org.bouncycastle.cert.X509v3CertificateBuilder.addExtension(org.bouncycastle.asn1.ASN1ObjectIdentifier,
 boolean, org.bouncycastle.asn1.ASN1Encodable)' the class loader 
org.eclipse.jetty.webapp.WebAppClassLoader @1d9295e2 of the current class, 
org/apache/cloudstack/utils/security/CertUtils, and the class loader 
org.codehaus.plexus.classworlds.realm.ClassRealm @7fecc26f for the method's 
defining class, org/bouncycastle/cert/X509v3CertificateBuilder, have different 
Class objects for the type org/bouncycastle/asn1/ASN1ObjectIdentifier used in 
the signature (org.apache.cloudstack.utils.security.CertUtils is in unnamed 
module of loader org.eclipse.jetty.webapp.WebAppClassLoader @1d9295e2, parent 
loader org.codehaus.plexus.classworlds.realm.ClassRealm @7fecc26f; 
org.bouncycastle.cert.X509v3CertificateBuilder is in unnamed module of loader 
org.codehaus.plexus.classworlds.realm.ClassRealm @7fecc26f, parent loader 
'bootstrap')].

Reason:
ASN1ObjectIdentifier has different versions in the dependencies of root-ca and 
Huawei OBS(huaweicloud-sdk-iam) packages. java.lang.LinkageError happens when 
code is compiled with dependency version say v1 and then is running with 
dependency version say v2.

Solution:

Add provided scope to huaweicloud-sdk-iam dependency in Huawei OBS project. 
This will mark dependencies that should be provided at runtime.


com.huaweicloud.sdk
huaweicloud-sdk-iam
3.1.69
 provided


Regards,
Kishan


 


-Original Message-
From: Kishan Kavala  
Sent: Friday, December 15, 2023 6:42 PM
To: dev@cloudstack.apache.org
Subject: RE: New Object Storage - Huawei OBS

Ronald,
 The error is coming from rootca project after adding Huawei OBS plugin.


org.apache.cloudstack
cloud-plugin-ca-rootca
${project.version}


After removing the above from client/pom.xml, Huawei OBS plugin was loaded.

On the other hand, if I remove Huawei OBS plugin and keep rootca project, I see 
no issues.

I'm investigating further, in the meantime removing rootca project can unblock 
your development.

Regards,
Kishan

 


-Original Message-
From: Ronald Feicht 
Sent: Friday, December 15, 2023 2:12 PM
To: dev@cloudstack.apache.org
Subject: Re: New Object Storage - Huawei OBS

Hi Kishan,


when I add my module to client/pom.xml I get the following error and 
http://192.168.17.252:8080/client/ returns "HTTP ERROR 503 Service Unavailable" 
because of the following exception:

[WARNING] Failed startup of context 
o.e.j.m.p.JettyWebAppContext@1df8ea34{/client,file:///opt/cloudstack-huawei-obs/client/target/classes/META-INF/webapp/,UNAVAILABLE}{file:///opt/cloudstack-huawei-obs/client/target/classes/META-INF/webapp/}
java.lang.NullPointerException
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$1.with
 (DefaultModuleDefinitionSet.java:104)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:263)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:251)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.startContexts
 (DefaultModuleDefinitionSet.java:96)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load 
(DefaultModuleDefinitionSet.java:79)
at 
org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules
 (ModuleBasedContextFactory.java:37)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init 
(CloudStackSpringContext.java:70)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext. 
(CloudStackSpringContext.java:57)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpring

RE: New Object Storage - Huawei OBS

[Kishan Kavala]

java:72)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:169)
at org.eclipse.jetty.server.Server.start (Server.java:407)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:97)
at org.eclipse.jetty.server.Server.doStart (Server.java:371)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:72)
at org.eclipse.jetty.maven.plugin.AbstractJettyMojo.startJetty 
(AbstractJettyMojo.java:450)
at org.eclipse.jetty.maven.plugin.AbstractJettyMojo.execute 
(AbstractJettyMojo.java:311)
at org.eclipse.jetty.maven.plugin.JettyRunMojo.execute 
(JettyRunMojo.java:152)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:347)

But the directory exists and is not empty:

[root@cloudstack-centos cloudstack-huawei-obs]# ll 
/opt/cloudstack-huawei-obs/client/target/classes/META-INF/webapp/
total 4
drwxr-xr-x. 2 root root   21 Dec 15 08:59 WEB-INF
-rw-r--r--. 1 root root 1135 Dec 15 08:59 index.html
drwxr-xr-x. 3 root root   39 Dec 15 08:59 .
drwxr-xr-x. 4 root root   87 Dec 15 08:59 ..
[root@cloudstack-centos cloudstack-huawei-obs]# ll 
/opt/cloudstack-huawei-obs/client/target/classes/META-INF/webapp/WEB-INF/
total 4
-rw-r--r--. 1 root root 2694 Dec 15 08:59 web.xml
drwxr-xr-x. 2 root root   21 Dec 15 08:59 .
drwxr-xr-x. 3 root root   39 Dec 15 08:59 ..

I have compared my plugin code to that of Minio and 
https://github.com/wido/cloudstack/commits/ceph-object-store but fail to see 
what I have done wrong. The only significant thing I can make out is my choice 
for the directory name 
"/opt/cloudstack-huawei-obs/plugins/storage/object/huawei-obs".
In plugins/pom.xml all object storage plugins have only a simple name without 
the character "-" in it.
storage/object/minio
storage/object/simulator
storage/object/huawei-obs
But surely that cannot be the source of the error?

My fork is located here https://github.com/scsynergy/cloudstack-huawei-obs and 
I created a Pull Request for you.


Mit freundlichen Grüßen
R. Feicht

sc synergy GmbH
Hilgestrasse 14 | 55294 Bodenheim | Deutschland
Fon: +49 6135 71691 - 000 | Fax: +49 6135 71691 - 299 http://www.scsynergy.com 
| ronald.fei...@scsynergy.com Sitz der Gesellschaft Bodenheim, HRB 8830, 
Amtsgericht Mainz, Geschäftsführer: Christian Reichert


________
From: Kishan Kavala 
Sent: Friday, December 15, 2023 06:35
To: dev@cloudstack.apache.org
Subject: RE: New Object Storage - Huawei OBS

Hi Ronald,
 You need to add module to client/pom.xml and add the plugin folder to 
plugins/pom.xml.
Looks like your implementation of ObjectStoreProvider is not getting registered 
as a ObjectStoreProvider.

If you can share a draft PR, I can review and suggest what is missing.

Regards,
Kishan




-Original Message-
From: Ronald Feicht 
Sent: Thursday, December 14, 2023 5:01 PM
To: dev@cloudstack.apache.org
Subject: Re: New Object Storage - Huawei OBS

Hi,


I had added the module to client/pom.xml, but then 
http://192.168.17.252:8080/cli

RE: New Object Storage - Huawei OBS

[Kishan Kavala]

Hi Ronald,
 You need to add module to client/pom.xml and add the plugin folder to 
plugins/pom.xml.
Looks like your implementation of ObjectStoreProvider is not getting registered 
as a ObjectStoreProvider. 

If you can share a draft PR, I can review and suggest what is missing.

Regards,
Kishan  

 


-Original Message-
From: Ronald Feicht  
Sent: Thursday, December 14, 2023 5:01 PM
To: dev@cloudstack.apache.org
Subject: Re: New Object Storage - Huawei OBS

Hi,


I had added the module to client/pom.xml, but then 
http://192.168.17.252:8080/client/ retuns "HTTP ERROR 503 Service Unavailable" 
because of the following exception:

[WARNING] Failed startup of context 
o.e.j.m.p.JettyWebAppContext@1df8ea34{/client,file:///opt/cloudstack-huawei-obs/client/target/classes/META-INF/webapp/,UNAVAILABLE}{file:///opt/cloudstack-huawei-obs/client/target/classes/META-INF/webapp/}
java.lang.NullPointerException
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$1.with
 (DefaultModuleDefinitionSet.java:104)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:263)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:268)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
 (DefaultModuleDefinitionSet.java:251)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.startContexts
 (DefaultModuleDefinitionSet.java:96)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load 
(DefaultModuleDefinitionSet.java:79)
at 
org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules
 (ModuleBasedContextFactory.java:37)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init 
(CloudStackSpringContext.java:70)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext. 
(CloudStackSpringContext.java:57)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext. 
(CloudStackSpringContext.java:61)
at 
org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized
 (CloudStackContextLoaderListener.java:52)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized 
(ContextHandler.java:933)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized 
(ServletContextHandler.java:553)
at org.eclipse.jetty.server.handler.ContextHandler.startContext 
(ContextHandler.java:892)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
(ServletContextHandler.java:356)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp 
(WebAppContext.java:1445)
at org.eclipse.jetty.maven.plugin.JettyWebAppContext.startWebapp 
(JettyWebAppContext.java:328)
at org.eclipse.jetty.webapp.WebAppContext.startContext 
(WebAppContext.java:1409)
at org.eclipse.jetty.server.handler.ContextHandler.doStart 
(ContextHandler.java:825)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart 
(ServletContextHandler.java:275)
at org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:524)
at org.eclipse.jetty.maven.plugin.JettyWebAppContext.doStart 
(JettyWebAppContext.java:397)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:72)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:117)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:97)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:72)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:117)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:97)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:72)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:169)
at org.eclipse.jetty.server.Server.start (Server.java:407)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:110)
at 

RE: new committer Vladimir Petrov

[Kishan Kavala]

Congratulations Vladi!!

 


-Original Message-
From: Nicolas Vazquez  
Sent: Tuesday, December 12, 2023 4:43 PM
To: dev@cloudstack.apache.org
Cc: users 
Subject: Re: new committer Vladimir Petrov

Congratulations Vladi!

Regards,
Nicolas Vazquez


From: Abhishek Kumar 
Date: Tuesday, 12 December 2023 at 08:08
To: dev@cloudstack.apache.org 
Cc: users 
Subject: Re: new committer Vladimir Petrov Congrats Vladi!


 

On Tue, 12 Dec 2023 at 15:22, Daan Hoogland  wrote:

> community,
>
> The PMC has decided Vladi to become a committer and he has gracefully 
> accepted. Please join me in welcoming Vladi to the project as 
> committer.
> Congratulations Vladi
>
> --
> Daan
>

RE: Question about ObjectStoreDriver for implementing Ceph driver

[Kishan Kavala]

Yes Rohit. TO is the correct way to send details to Resource layer.

@Wido Looking forward to the commits. Let me know if you have any questions.

 


-Original Message-
From: Wido den Hollander  
Sent: Tuesday, December 12, 2023 2:28 PM
To: dev@cloudstack.apache.org; Rohit Yadav ; 
kis...@apache.org
Subject: Re: Question about ObjectStoreDriver for implementing Ceph driver



Op 12/12/2023 om 04:45 schreef Rohit Yadav:
> Hi Wido,
> 
> I think when the minio object storage plugin was written we didn’t have the 
> limitations or foresight on how to structure the code, I would agree in 
> refactoring the interface enough to allow what you’re trying to achieve.
> 
> Typically to a plugin you don’t want to pass database objects (Dao or VO) but 
> a transform them as transfer object (TO) that doesn’t introduce dao or schema 
> pkg dependencies to the plugin and TOs are kept as simple Java object. In the 
> TO you can introduce fields and getters that suit your use cases.
> 

Got it, thanks for the feedback! I'll work on this in two different commits.

Wido

> Regards.
> 
> Regards.
> 
> From: Wido den Hollander 
> Sent: Tuesday, December 12, 2023 1:28:56 AM
> To: dev@cloudstack.apache.org ; 
> kis...@apache.org 
> Subject: Question about ObjectStoreDriver for implementing Ceph driver
> 
> Hi (Kishan),
> 
> I am making a first attempt [0] to implement a Ceph RGW [1] Object 
> Store Driver for CloudStack and I have a few questions about the code.
> 
> While implementing the Ceph RGW driver I have noticed that some 
> methods are provided the bucket's name (as a String) as an argument, 
> but I'd rather have a 'Bucket' object, for example:
> 
> public AccessControlList getBucketAcl(String bucketName, long storeId) 
> public boolean setBucketEncryption(String bucketName, long storeId)
> 
> In Ceph's case it would be better if these methods would get a Bucket 
> object, like:
> 
> 
> public AccessControlList getBucketAcl(Bucket bucket, long storeId)
> 
> The reason is that I need to access the Account the bucket belongs to.
> With Minio there is an 'Admin' client which allows you to do all these 
> operations as an Admin, but with Ceph there isn't. With Ceph you are 
> supposed to obtain the credentials (access + secret) via an Admin API 
> [2] and then execute these commands as the user.
> 
> Now, we have the access + secret key from the account recorded under 
> the account and we can access that from the Bucket object:
> 
> bucket.getAccessKey()
> bucket.getSecretKey()
> 
> My proposal would be to change the signature of these methods, but 
> before I do so, is there any particular reason the String was passed 
> and not the whole Bucket object?
> 
> Thanks,
> 
> Wido
> 
> [0]: https://github.com/wido/cloudstack/commits/ceph-object-store
> [1]: https://ceph.io/en/discover/technology/#object
> [2]:
> https://www.javadoc.io/doc/io.github.twonote/radosgw-admin4j/latest/or
> g/twonote/rgwadmin4j/RgwAdmin.html
> 
>   
> 
> 

RE: new PMC member: Abhishek Kumar

[Kishan Kavala]

Congratulations Abhishek!!

 


-Original Message-
From: John Bampton  
Sent: Monday, November 27, 2023 4:38 PM
To: dev@cloudstack.apache.org
Subject: Re: new PMC member: Abhishek Kumar

Great news Abhishek !!  Thank you and well done :)

On Mon, 27 Nov 2023 at 20:59, Nicolas Vazquez 
wrote:

> Well done Abhishek, congratulations!
>
> Regards,
> Nicolas Vazquez
>
>
> From: Jithin Raju 
> Date: Monday, 27 November 2023 at 01:21
> To: dev@cloudstack.apache.org , users < 
> us...@cloudstack.apache.org>
> Subject: Re: new PMC member: Abhishek Kumar Congratulations Abhishek.
>
> -Jithin
>
> From: Daan Hoogland 
> Date: Thursday, 23 November 2023 at 2:11 PM
> To: users , dev 
> 
> Subject: new PMC member: Abhishek Kumar The Project Management 
> Committee (PMC) for Apache CloudStack has invited Abhishek Kumar to 
> become a PMC member and we are pleased to announce that they have 
> accepted.
>
> Abhishek has contributed in the past and has shown effort to make the 
> project run smoothly. He is also the Release Manager for the upcoming
> 4.19 release.
>
> please join me in congratulating Abhishek
>
> --
> Daan
>
>
>
>
>
>

[Proposal] KVM ingestion in CloudStack

[Kishan Kavala]

Hi,
CloudStack supports import/export of unmanaged instances for VMware. Similar 
feature for KVM is WIP: https://github.com/apache/cloudstack/pull/7712
Support for migrating instances from VMware to KVM is also WIP: 
https://github.com/apache/cloudstack/pull/7881

To enhance KVM import capabilities further, I would like to add support for 
importing  external KVM instances. External KVM instances can imported from 
non-CloudStack orchestration engines or from a standalone KVM host. Initial 
implementation will support import of libvirt based instances which are in 
stopped state (Cold Migration). Later phases can support Live Migration and 
non-libvirt based. instances (e.g. Proxmox).

regards,
Kishan

 

RE: [DISCUSS] Upgrading Mockito & phasing out powermock

[Kishan Kavala]

+1
Agree with the approach, Vishesh.

 


-Original Message-
From: Wei ZHOU  
Sent: Tuesday, June 6, 2023 8:11 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Upgrading Mockito & phasing out powermock

lgtm. go ahead Vishesh.

-Wei


On Tue, 6 Jun 2023 at 14:17, Vishesh Jindal 
wrote:

> Hi all,
>
> I am working on upgrading Mockito's version & phasing out powermock. 
> For new maven modules, I would request all to use Mockito's mockStatic 
> instead of Powermock.
>
> Why?
> Powermock's last release was on Nov 2, 2020. The project seems to have 
> been abandoned. Powermock has compatibility issues with Mockito's 
> latest version as well.
>
> How?
> The only usage for PowerMock I could see in code was for mocking 
> static methods. Since Mockito v3.4.0, it has the capability to mock static 
> methods.
> I plan to migrate tests to Mockito's mockStatic instead of PowerMock. 
> This will have to be done module by module and will take some time.
>
> I have prepared a PR here: 
> https://github.com/apache/cloudstack/pull/7577
>
> This PR upgrades mockito from v3.2.4 to v3.12.4 and removes the usage 
> of PowerMock from utils module.
>
>
> Let me know if you have any questions/concerns.
>
> Regards,
> Vishesh
>
>
>
>
>

[Proposal] Object Storage in CloudStack

[Kishan Kavala]

Hi,
I would like CloudStack to support Object Storage as a first-class end user 
feature. It can be added using plugin framework to support various Object 
Storage providers.
CloudStack will manage the lifecycle of ObjectStoragePools and Buckets. Any S3 
compliant client should be able to manage the objects within the buckets.

I've added a draft functional spec here:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BDRAFT%5D+CloudStack+Object+Store

Looking forward to your feedback.

regards,
Kishan


 

Hello Again!

[Kishan Kavala]

Hi,
 I've joined ShapeBlue and very happy to back with CloudStack community. 
Looking forward to working with you all.

regards,
Kishan


 

RE: Alternative Cloudstack UI for KVM and Basic Zones (with SG)

[Kishan Kavala]

Ivan,
UI is very impressive and user friendly.
Thanks for sharing.

-Original Message-
From: Jayapal Uradi [mailto:jayapal.ur...@accelerite.com]
Sent: 25 April 2017 03:41 PM
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: Re: Alternative Cloudstack UI for KVM and Basic Zones (with SG)

New UI pages looks good.

Thanks,
Jayapal
> On Apr 25, 2017, at 1:55 PM, Rajani Karuturi  wrote:
>
> Looks very good. Thanks for open sourcing it :)
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On April 25, 2017 at 12:42 PM, Ivan Kudryavtsev
> (kudryavtsev...@bw-sw.com) wrote:
>
> Hello, Cloudstack community.
>
> We are proud to present our last development effort to you.
> During the last
> 5 months we spend some time to develop alternative Cloudstack UI for
> basic zones with KVM hypervisor and security groups. This is basically
> the thing we are using in our clouds. During the design of the
> software we tried to fulfill the expectations of our average cloud
> users and simplify operations as much as possible.
>
> The project is OSS and can be found at GitHub with bunch of
> screenshots and deployment guide. It's under active development so, we
> will ge glad if you join and provide us with additional feedback, UX
> considerations and other interesting information.
>
> Project page at GitHub: https://bwsw.github.io/cloudstack-ui/
> Source code: https://github.com/bwsw/cloudstack-ui
>
> Have a good day. Looking forward hearing your feedback.
>
> --
> With best regards, Ivan Kudryavtsev
> Bitworks Software, Ltd.
> Cell: +7-923-414-1515
> WWW: http://bw-sw.com/




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: :[VOTE] Apache Cloudstack 4.10.0.0

[Kishan Kavala]

@Rajani
Both the blockers are related. I'll create a PR for the fix.

-Original Message-
From: Rajani Karuturi [mailto:raj...@apache.org] 
Sent: Thursday, March 02, 2017 3:18 PM
To: Boris Stoyanov 
Cc: dev@cloudstack.apache.org; Wido den Hollander ; Rajani 
Karuturi 
Subject: Re: :[VOTE] Apache Cloudstack 4.10.0.0

@pierre-Luc, I think we have to support centos6 atleast till Q2 2017.
https://wiki.centos.org/About/Product

Thanks for testing Boris, Rene and Mike.
We currently have the following blockers for RC2:
https://github.com/apache/cloudstack/pull/1923
https://issues.apache.org/jira/browse/CLOUDSTACK-9807
https://issues.apache.org/jira/browse/CLOUDSTACK-9808


+ the exception which Mike reported and needs to be analysed.

I will keep this thread open for any new issues. Keep testing :)



~Rajani
http://cloudplatform.accelerite.com/

On Thu, Mar 2, 2017 at 2:49 PM, Boris Stoyanov  wrote:

> Hi all,
>
> I’m adding the smoketests resluts.
>
> I’ve executed them agains the 3 most common hypervisors with the 
> latests versions deployed.
>
> KVM env:
> 2x KVM on CentOS7.2
> Management CentOS7.2
> Primary and secondary storage: NFS
> Java 1.8.0_121
> Advanced network with one zone (2 hosts)
>
> VMware env:
> 2x VMware-6.5 hosts
> Management CentOS7.2
> Primary and secondary storage: NFS
> Java 1.8.0_121
> Advanced network with one zone (2 hosts)
>
> XenServer env:
> 2x XenServer 6.5sp1 hosts
> Management CentOS7.2
> Primary and secondary storage: NFS
> Java 1.8.0_121
> Advanced network with one zone
>
> Generally the tests look good with small exceptions, there are few 
> known issues around vpc_redundant, test_snapshots, privategw_acl.
>
> Attached are the results summaries. I’ve tried sending the execution 
> logs but mail got rejected.
>
>
>
> > On Mar 2, 2017, at 9:14 AM, Rajani Karuturi  wrote:
> >
> > On Wed, Mar 1, 2017 at 12:51 PM, Wido den Hollander 
> wrote:
> >
> >>
> >>> Op 1 maart 2017 om 2:12 schreef Rajani Karuturi :
> >>>
> >>>
> >>> Hi All,
> >>>
> >>> I've created a 4.10.0.0 release, with the following artifacts up 
> >>> for a
> >> vote:
> >>>
> >>> Git Branch and Commit
> >>> SH:https://git-wip-us.apache.org/repos/asf?p=cloudstack.
> >> git;a=shortlog;h=refs/heads/4.10.0.0-RC20170301T0634
> >>> Commit:7c1d003b5269b375d87f4f6cfff8a144f0608b67
> >>>  >> git;a=shortlog;h=refs/heads/4.10.0.0-RC20170301T0634Commit:
> >> 7c1d003b5269b375d87f4f6cfff8a144f0608b67>
> >>>
> >>> Source release (checksums and signatures are available at the same 
> >>> location):https://dist.apache.org/repos/dist/dev/cloudstack/4.10.0
> >>> .0/
> >>>
> >>
> >> I get a 404 here. Am I too early to fetch the tarball?
> >>
> >> I always prefer to test with a tarball instead of a Git repo. 
> >> Trying to prevent I accidentally test with a wrong commit/branch.
> >>
> >
> >
> > Thanks for bringing this up Wido. My svn command didnt work after 
> > the upgrade to sierra and I didnt notice the errors. I pushed it now.
> > You should be able to download now.
> >
> >
> >>
> >> Wido
> >>
> >>> PGP release keys (signed using
> >>> CBB44821):https://dist.apache.org/repos/dist/release/cloudstack/KE
> >>> YS
> >>>
> >>> Vote will be open for 72 hours.
> >>>
> >>> For sanity in tallying the vote, can PMC members please be sure to 
> >>> indicate "(binding)" with their vote?
> >>>
> >>> [ ] +1  approve
> >>> [ ] +0  no opinion
> >>> [ ] -1  disapprove (and reason why)
> >>>
> >>>
> >>>
> >>> ~Rajani
> >>> http://cloudplatform.accelerite.com/
> >>
>
> boris.stoya...@shapeblue.com
> www.shapeblue.com
> @shapeblue
>
>
>
>



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSAL] add native container orchestration service)

[Kishan Kavala]

Daan,
 I've updated the earlier spec to support any Vm cluster. Please let me know 
your thoughts on this.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Service+Cluster+Functional+Specification

regards,
Kishan

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] 
Sent: 27 February 2017 04:02 PM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native vm-cluster orchestration service (was: 
[PROPOSAL] add native container orchestration service)

Any follow up Koushik? I want to refactor our proof of concept and integrate it 
in master.

On 21/02/17 10:42, "Kishan Kavala"  wrote:

Sure Daan. I'll publish the design on cwiki and share the link.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] 
Sent: Monday, February 20, 2017 7:27 PM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] add native vm-cluster orchestration service (was: 
[PROPOSAL] add native container orchestration service)

So, being very late in the discussion but havingread the whole thread 
before editting the title of this thread,

Can we agree that we want a generic vm-cluster service and leave the 
container bits to containers? Kishan can you share your design? Shapeblue wants 
to rebase their k8 service on top of this and I would like yours and Murali's 
work to not conflict.

daan.hoogl...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands 
@shapeblue
  
 


-Original Message-
From: Paul Angus [mailto:paul.an...@shapeblue.com]
Sent: dinsdag 7 februari 2017 08:14
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service

Will is 100% correct.  As I mentioned the Title is misleading.  However, 
Murali did clarify in his explanation; this is really about vm cluster 
orchestration.




From: Will Stevens 
Sent: 6 Feb 2017 22:54
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service

​My understanding is that what Paul is talking about is what is already 
built and IS what the thread is talking about.​

*Will STEVENS*
Lead Developer

<https://goo.gl/NYZ8KK>

On Mon, Feb 6, 2017 at 2:29 PM, Rajesh Ramchandani < 
rajesh.ramchand...@accelerite.com> wrote:

> Hi Paul - I think this is different from what the thread was about. 
> The conversation was specifically about adding support for container 
> orchestrators. You are talking about provisioning a group of VMs.
> Although, this is something I think several Cloudstack users have 
> requested before and we should propose a solution to this.
>
> Raj
>
> 
> From: Paul Angus 
> Sent: Monday, February 6, 2017 11:16:41 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [PROPOSAL] add native container orchestration service
>
> #WhatHeSaid
>
> The title is misleading.  The proposal is purely to add the notion of 
> Clusters of VMs to CloudStack.  These may be for databases, containers 
> or anything else that needs 'clusters' of compute. Self-healing and 
> autoscaling are logical next steps to be added.
>
> Those guys at ShapeBlue have open-sourced their whole k8s container 
> service piece.  If/when the 'cluster' part of that work is added into 
> CloudStack, the k8s specific pieces can be used by anyone who wants 
> to, alternatively they could be used for reference in order to create 
> another types of cluster.  (or ignored completely).
>
>
>
>
> paul.an...@shapeblue.com
> www.shapeblue.com<http://www.shapeblue.com>
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>
>
>
>
> -Original Message-
> From: Will Stevens [mailto:williamstev...@gmail.com]
> Sent: 31 January 2017 13:26
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native container orchestration service
>
> s/cloud-init/cloud-config/
>
> On Jan 31, 2017 7:24 AM, "Will Stevens"  wrote:
>
> > I think that is covered in this proposal. There is nothing k8s 
> > specific in this integration (from what I understand), all the k8s 
> > details are passed in via the cloud-init configuration after the 
> > cluster
> has been provisioned.
> >
> > On Jan 31, 2017 3:06 AM, "Lianghwa Jou" 
> > 
> > wrote:
> >
> >
> > There are many container o

RE: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSAL] add native container orchestration service)

[Kishan Kavala]

Sure Daan. I'll publish the design on cwiki and share the link.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] 
Sent: Monday, February 20, 2017 7:27 PM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] add native vm-cluster orchestration service (was: 
[PROPOSAL] add native container orchestration service)

So, being very late in the discussion but havingread the whole thread before 
editting the title of this thread,

Can we agree that we want a generic vm-cluster service and leave the container 
bits to containers? Kishan can you share your design? Shapeblue wants to rebase 
their k8 service on top of this and I would like yours and Murali's work to not 
conflict.

daan.hoogl...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands @shapeblue
  
 


-Original Message-
From: Paul Angus [mailto:paul.an...@shapeblue.com]
Sent: dinsdag 7 februari 2017 08:14
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service

Will is 100% correct.  As I mentioned the Title is misleading.  However, Murali 
did clarify in his explanation; this is really about vm cluster orchestration.




From: Will Stevens 
Sent: 6 Feb 2017 22:54
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service

​My understanding is that what Paul is talking about is what is already built 
and IS what the thread is talking about.​

*Will STEVENS*
Lead Developer



On Mon, Feb 6, 2017 at 2:29 PM, Rajesh Ramchandani < 
rajesh.ramchand...@accelerite.com> wrote:

> Hi Paul - I think this is different from what the thread was about. 
> The conversation was specifically about adding support for container 
> orchestrators. You are talking about provisioning a group of VMs.
> Although, this is something I think several Cloudstack users have 
> requested before and we should propose a solution to this.
>
> Raj
>
> 
> From: Paul Angus 
> Sent: Monday, February 6, 2017 11:16:41 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [PROPOSAL] add native container orchestration service
>
> #WhatHeSaid
>
> The title is misleading.  The proposal is purely to add the notion of 
> Clusters of VMs to CloudStack.  These may be for databases, containers 
> or anything else that needs 'clusters' of compute. Self-healing and 
> autoscaling are logical next steps to be added.
>
> Those guys at ShapeBlue have open-sourced their whole k8s container 
> service piece.  If/when the 'cluster' part of that work is added into 
> CloudStack, the k8s specific pieces can be used by anyone who wants 
> to, alternatively they could be used for reference in order to create 
> another types of cluster.  (or ignored completely).
>
>
>
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>
>
>
>
> -Original Message-
> From: Will Stevens [mailto:williamstev...@gmail.com]
> Sent: 31 January 2017 13:26
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native container orchestration service
>
> s/cloud-init/cloud-config/
>
> On Jan 31, 2017 7:24 AM, "Will Stevens"  wrote:
>
> > I think that is covered in this proposal. There is nothing k8s 
> > specific in this integration (from what I understand), all the k8s 
> > details are passed in via the cloud-init configuration after the 
> > cluster
> has been provisioned.
> >
> > On Jan 31, 2017 3:06 AM, "Lianghwa Jou" 
> > 
> > wrote:
> >
> >
> > There are many container orchestrators. Those container 
> > orchestrators are happy to run on any VMs or bare metal machines. 
> > K8s is just one of them and there will be more in the future. It may 
> > not be a good idea to make CloudStack to be k8s aware. IMO, the 
> > relationship between k8s and cloudstack should be similar to 
> > application and os. It probably not a good idea to make your OS to 
> > be aware of any specific applications so IMHO I don’t think k8s should be 
> > native to CloudStack.
> > It makes more sense to provide some generic services that many 
> > applications can take advantages of. Some generic resource grouping 
> > service makes sense so a group of VMs, baremetal machines or network 
> > can be treated as a single entity. Some life cycle management will 
> > be necessary for these entities too. We can deploy k8s, swarm, dcos 
> > or even non-container specific services on top of CloudStack. The 
> > k8s is changing fast. One single tenant installation may need more 
> > than one VM group and may actually requires more (k8s federation). 
> > It will be a struggle to be in sync if we try to bring k8s specific 
> > knowledge into
> cloudstack.
> >
> > Regards,
> >
> >
> > --
> > Lianghwa Jou
> > VP Engineering, Accelerite
> > email: lianghwa@accelerite.com
> >
> >
> >
> >
> >
> > On 1/29/17, 11:54 PM, "Murali Re

RE: [PROPOSAL] add native container orchestration service

[Kishan Kavala]

Murali,
 APIs are similar, but the name is generic - createServiceCluster instead of 
createContainerCluster
Same with DB tables names - service_cluster instead of container_cluster
API params or the DB columns in the spec you published don't have anything 
specific to container_clusters and can be used for any service.

-Original Message-
From: Murali Reddy [mailto:muralimmre...@gmail.com] 
Sent: 02 February 2017 02:34 PM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service


Thanks for the feedback. There have been some concerns here with this proposal. 
I think we had sufficient valid arguments why we need this functionality in 
CloudStack. While this proposal is to use k8s as container orchestrator design 
should be able to adopt other container orchestrator.


Unless anybody has any specific technical points on this, I'd like to go on 
with its implementation and open up a PR.


Kishan, when do you think you can share further details (northbound API 
semantics etc) on the work you are doing? I am planning to get this feature the 
for 4.11. 



On 31/01/17, 5:54 PM, "Will Stevens"  wrote:

>I think that is covered in this proposal. There is nothing k8s specific 
>in this integration (from what I understand), all the k8s details are 
>passed in via the cloud-init configuration after the cluster has been 
>provisioned.
>
>On Jan 31, 2017 3:06 AM, "Lianghwa Jou"  wrote:
>
>
>There are many container orchestrators. Those container orchestrators 
>are happy to run on any VMs or bare metal machines. K8s is just one of 
>them and there will be more in the future. It may not be a good idea to 
>make CloudStack to be k8s aware. IMO, the relationship between k8s and 
>cloudstack should be similar to application and os. It probably not a 
>good idea to make your OS to be aware of any specific applications so 
>IMHO I don’t think k8s should be native to CloudStack. It makes more 
>sense to provide some generic services that many applications can take 
>advantages of. Some generic resource grouping service makes sense so a 
>group of VMs, baremetal machines or network can be treated as a single 
>entity. Some life cycle management will be necessary for these entities 
>too. We can deploy k8s, swarm, dcos or even non-container specific 
>services on top of CloudStack. The k8s is changing fast. One single 
>tenant installation may need more than one VM group and may actually 
>requires more (k8s federation). It will be a struggle to be in sync if 
>we try to bring k8s specific knowledge into cloudstack.
>
>Regards,
>
>
>--
>Lianghwa Jou
>VP Engineering, Accelerite
>email: lianghwa@accelerite.com
>
>
>
>
>
>On 1/29/17, 11:54 PM, "Murali Reddy"  wrote:
>
>
>I agree with some good views Will has shared and I also agree to 
>the concerns raised by Wido and Eric. IMO we need balance of staying 
>relevant/add new features vs stability of CloudStack and take 
>corrective action if needed. We have two good examples for both. When 
>SDN was hot technology CloudStack ended up with bunch of SDN controller 
>integrations.
>Few years later, now CloudStack is carrying baggage with no maintainers 
>for those plugins, with probably not many of CloudStack users needing overlays.
>On the other hand, other than attempt to liaison with ETSI for NFV no 
>effort was done. OpenStack has become de-facto for NFV. Now for 
>OpenStack, arguably NFV has become larger use case than cloud it self. 
>I concur with Will’s point that with minimal viable solution that does 
>not change the core of CloudStack, and can keep CloudStack relevant is 
>worth to be taken in.
>
>Will,
>
>To your question of how different is from ShapeBlue’s container 
>service, its design, implementation and API semantics etc remain same.
>ShapeBlue’s container service was true drop in plug-in to CloudStack, 
>with this proposal I am trying to re-work to make it a core CloudStack 
>pluggable service which is part of CloudStack.
>
>Key concepts that this proposal is trying to add
>
>- add notion of ‘container cluster’ as a first class entity in 
>CloudStack. Which is bacially collection of other CloudStack resources 
>(like VM’s, networks, public ip, network rules etc)
>- life cycle operation to manage ‘container cluster’ like 
>create, delete, start, stop, scale-up, scale-down, heal etc
>- orchestrate container orchestrator control plane on top of 
>provisioned resources
>
>At-least for k8s (which is what this proposal is targeting), 
>integration with k8s is bare minimum. There are cloud-config scripts 
>that automatically setup k8s cluster master and node VM’s. All 
>CloudStack is doing in passing the cloud-config to the core OS VM’s as user 
>data.
>
>Regards
>Murali Reddy
>
>
>
>
>
>
>
>On 29/01/17, 8:54 AM, "Will Stevens" behalf of wstev...@cloudops.com> wrote:
>
>>I agree that we need to be careful what we take on and own inside
>>CloudStack.  I feel 

RE: [PROPOSAL] add native container orchestration service

[Kishan Kavala]

Taking this abstraction one more level up, I propose we keep the cluster 
generic, and not just for container service. More so, because the proposal is 
to make it core cloudstack pluggable service.

With the proposed container orchestration service,
 - A notion of cluster is introduced, which is basically group of Vms, network 
rules etc
 
 Container service is not the only use-case which will benefit from this 
cluster. Any service which requires a bunch of Vms grouped can make use of this 
cluster.

 Any service which require the following can be supported by a generic 
framework, similar to network plugin framework.
 - Create group of Vms (ServiceCluster) and manage their life cycle 
 - Configure network to make the ServiceCluster functional (e.g. open required 
ports on all vms to for services to communicate)
 - Create network rules to make the control pane accessible (e.g. create 
PortForwarding rule to access k8s/PaaS dashboard)
 - Driven by cloud-config via userdata (e.g. config to download required 
binaries and start services on the Vms)
 - Support a purpose-built template (e.g. CoreOS)
 
This framework can be used by services like Container service, PaaS or 
DB-as-a-service .  I’ve been doing some prototypes on a similar kind of 
abstraction.

-Original Message-
From: Murali Reddy [mailto:murali.re...@shapeblue.com] 
Sent: Monday, January 30, 2017 1:24 PM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service


I agree with some good views Will has shared and I also agree to the concerns 
raised by Wido and Eric. IMO we need balance of staying relevant/add new 
features vs stability of CloudStack and take corrective action if needed. We 
have two good examples for both. When SDN was hot technology CloudStack ended 
up with bunch of SDN controller integrations. Few years later, now CloudStack 
is carrying baggage with no maintainers for those plugins, with probably not 
many of CloudStack users needing overlays. On the other hand, other than 
attempt to liaison with ETSI for NFV no effort was done. OpenStack has become 
de-facto for NFV. Now for OpenStack, arguably NFV has become larger use case 
than cloud it self. I concur with Will’s point that with minimal viable 
solution that does not change the core of CloudStack, and can keep CloudStack 
relevant is worth to be taken in. 

Will,

To your question of how different is from ShapeBlue’s container service, its 
design, implementation and API semantics etc remain same. ShapeBlue’s container 
service was true drop in plug-in to CloudStack, with this proposal I am trying 
to re-work to make it a core CloudStack pluggable service which is part of 
CloudStack. 

Key concepts that this proposal is trying to add

- add notion of ‘container cluster’ as a first class entity in CloudStack. 
Which is bacially collection of other CloudStack resources (like VM’s, 
networks, public ip, network rules etc)
- life cycle operation to manage ‘container cluster’ like create, delete, 
start, stop, scale-up, scale-down, heal etc
- orchestrate container orchestrator control plane on top of provisioned 
resources

At-least for k8s (which is what this proposal is targeting), integration with 
k8s is bare minimum. There are cloud-config scripts that automatically setup 
k8s cluster master and node VM’s. All CloudStack is doing in passing the 
cloud-config to the core OS VM’s as user data.

Regards
Murali Reddy







On 29/01/17, 8:54 AM, "Will Stevens"  wrote:

>I agree that we need to be careful what we take on and own inside 
>CloudStack.  I feel like some of the plugins or integrations which we 
>have been "maintaining" may serve us better to abandon, but I feel like 
>that is a whole discussion on its own.
>
>In this case, I feel like there is a minimum viable solution which puts 
>CloudStack in a pretty good place to enable container orchestration.  
>For example, one of the biggest challenges with K8S is the fact that it 
>is single tenant.  CloudStack has good multi tenancy support and has 
>the ability to orchestrate the underlying infra quite well.  We will 
>have to be very careful not to try to own too deep into the K8S world 
>though, in my opinion.  We only want to be responsible for providing 
>the infra (and a way to bootstrap K8S ideally) and be able to scale the 
>infra, everything else should be owned by the K8S on top.  That is the 
>way I see it anyway, but please add your input.
>
>I think it is a liability to try to go too deep, for the same reasons 
>Wido and Erik have mentioned.  But I also think we need to take it 
>seriously because that train is moving and this may be a good 
>opportunity to stay relevant in a rapidly changing market.
>
>*Will STEVENS*
>Lead Developer
>
>
>
>On Sat, Jan 28, 2017 at 1:13 PM, Wido den Hollander  wrote:
>
>>
>> > Op 27 januari 2017 om 16:08 schreef Will Stevens 
>> >> >:
>> >
>> >
>> > Hey Murali,
>> > How different is this pro

RE: Usage data reported by listvirtualmachines incomplete in setup with multiple management servers

[Kishan Kavala]

Stefan,
 If you are looking for network usage data, listUsageRecords API will provide 
more accurate info.

~kishan

-Original Message-
From: Stefan Engstrom [mailto:sengst...@ena.com]
Sent: Thursday, July 28, 2016 10:04 AM
To: dev 
Subject: Usage data reported by listvirtualmachines incomplete in setup with 
multiple management servers

Hello all - we are standing up a cloud service using CloudStack 4.8 with some 
select PRs included.

We base usage rate reporting on differentials of the data (rates) served by GET 
listvirtualmachines. While validating our production build which has three 
management servers we noticed that this approach is under-reporting network r/w 
and disk r/w volumes (and most likely iops as well).


The test case and diagnostics we looked at today are the following:

1. curl a decent (11.7 GB) payload to disk in a centos 7 VM

2. Check the network transfer on the VM's nic with "ip -s link"

3. Verify the transfer on the ACS host with virsh.

4. Check reporting from the individual management hosts - the *sum* of what 
they report via GET listvirtualmachines matches the volume in steps 1-3 above.


The load balanced IP for the management cluster picks a host at random (and 
have you stick to it) - thus you get a usage number anywhere between 0 and the 
correct value, probably depending on how the start of the individual management 
hosts were staggered on startup.


>From a cursory look at the code we think the agent on the host collects 
>differentials every time it is queried by a management host, reports the diff 
>and the management hosts proceeds to accumulate that. A little backwards 
>perhaps but it explains the behavior outlined above.


So, I wonder how other people deal with this, or even if there is awareness of 
the issue when you have multiple management servers.


My planned work-around for now is to pull the management servers individually 
and simply add up the results, but curious to hear other ideas. Anybody using 
the ACS  usage server or the graphite integration for this kind of reporting?


Thanks for your thoughts,


Stefan Engström

Lead Research & Development Engineer
Education Networks of America

618 Grassmere Park Drive

Suite 12

Nashville, TN 37211

Phone: 615-312-6136
CTAC: 888-612-2880
Video @ https://ena.zoom.us/my/sengstrom
Mobile: 615-500-3223 <= Best option





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: LXC container template for CloudStack

[Kishan Kavala]

You can try this centos 7 template for LXC: 
http://download.cloud.com/templates/builtin/centos-7-x86_64.tar.gz

-Original Message-
From: Cloud List [mailto:cloud-l...@sg.or.id] 
Sent: Wednesday, June 08, 2016 1:35 PM
To: us...@cloudstack.apache.org; dev@cloudstack.apache.org
Subject: Re: LXC container template for CloudStack

Dear all,

Anyone can point me to any URLs containing ready-to-use LXC container template 
for Cloudstack, ready for download?

Thank you.

-ip-


On Mon, Jun 6, 2016 at 2:21 PM, Cloud List  wrote:

> Dear all,
>
> I am trying to add an LXC cluster in addition to the existing running 
> KVM cluster in my CloudStack 4.8.0 test environment.
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+Support+in+
> Cloudstack
>
> I understand that the LXC container template for CloudStack is not 
> provided / bundled by default, so we need to create one or download. 
> May I
> know:
>
> (1) How do we create one? I follow the instruction on how to create 
> LXC template for Ubuntu here:
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+Template+cr
> eation#LXCTemplatecreation-CreatingtemplateonUbuntu
>
> It requires us to install lxc (apt-get install lxc) but doing so will 
> remove cloudstack-agent package hosted on the same host.
>
> (2) Where can we download ready-to-use LXC container template for 
> CloudStack?
>
> Looking forward to your reply, thank you.
>
> Cheers.
>
> -ip-
>



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: hidden configuration items revisited

[Kishan Kavala]

Nathan,
  You can use "Secure" category instead of "Hidden". Config items with "Secure" 
category are encrypted and also included in listConfigurations API response. 

~kishan

-Original Message-
From: Nathan Johnson [mailto:njohn...@ena.com] 
Sent: 08 May 2016 22:01
To: dev@cloudstack.apache.org
Subject: hidden configuration items revisited

I would like to get some feedback for a proposed addition of a feature that 
would allow “Hidden” configuration items to be returned from the 
listConfigurations endpoint.

1) There will be a new optional parameter for listConfigurations called 
showhidden .  Defaults to false.  Existing behavior is preserved unless 
showhidden is set to true.

2) There is a now configuration item, com.cloud.allowshowhidden , which 
defaults to false.  This must be set to true in order for showhidden to be 
allowed.  If showhidden=true is passed and com.cloud.allowshowhidden=false, an 
InvalidParameterValueException is thrown.

So the web UI would still hide hidden configuration items regardless of the 
state of com.cloud.allowshowhidden since it will not be passing 
showhidden=true.  The main value of this would be from API implementations / 
middleware, which is what our front-end talks to instead of directly to 
cloudstack management server.

Obviously there is an explicit reason hidden configuration items are not 
displayed via the API at present.  The Hidden configuration items contain some 
very sensitive data, such as private keys etc.  I would like to submit a pull 
request that would make sense to everyone and still be secure by default and 
not open up pandora’s box so to speak.  I have this working in our lab, but I 
wanted to get a bit of feedback before submitting a PR.

So several questions:

1) Would it make sense for com.cloud.allowshowhidden to be a “Hidden”  
configuration item?  The up side of this is that you could not toggle this 
value from the API.  Marking it hidden means that a rogue root admin api key 
holder could not grant themselves more access.  The down side is that I’m not 
sure how to easily change this value outside of manually going into the 
database and changing it, and one should hope that root admin api key holders 
are well trusted.  Currently I have this implemented as an “Advanced” 
configuration item.

2) I picked com.cloud.allowshowhidden out of my hat.  Is there a more 
appropriate name that I should use?




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: introduction

[Kishan Kavala]

Welcome back Murali!

-Original Message-
From: Abhinav Roy [mailto:abhinav@accelerite.com] 
Sent: 24 March 2016 10:53 AM
To: dev@cloudstack.apache.org
Subject: RE: introduction


Welcome back Murali :)

Regards,
Abhinav

-Original Message-
From: Murali Reddy [mailto:murali.re...@shapeblue.com] 
Sent: Wednesday, March 23, 2016 5:21 PM
To: dev@cloudstack.apache.org
Subject: introduction

All,

Just wanted to let the community know that I have decided to work on Apache 
CloudStack again. I have taken up a position at ShapeBlue, so you will be 
seeing me around @dev and @users. For the new members of the community and 
others who I have not interacted with, here is small self introduction. I 
started my journey with CloudStack, in late 2010 as cloud.com employee. Later 
spent 4 years till late 2014 working on various CloudStack features (EIP, GSLB, 
NAAS, NetScaler integration, native SDN controller, distributed virtual router, 
event bus to name few). I was working on NFV solution on OpenStack over a year. 
I am excited to join back the community, looking forward to interact with you.

Thanks,
Murali



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

[Kishan Kavala]

+1 for the move.

Regards,
Kishan Kavala
Chief Product Engineer, 
CloudPlatform Development, Accelerite.
www.accelerite.com

-Original Message-
From: chunfeng tian [mailto:tianyunqu...@gmail.com] 
Sent: 20 March 2016 05:22 PM
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1

On Sun, Mar 20, 2016 at 1:51 PM, Mattmann, Chris A (3980) < 
chris.a.mattm...@jpl.nasa.gov> wrote:

> +1..
>
> ++
> Chris Mattmann, Ph.D.
> Chief Architect
> Instrument Software and Science Data Systems Section (398) NASA Jet 
> Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 168-519, Mailstop: 168-527
> Email: chris.a.mattm...@nasa.gov
> WWW:  http://sunset.usc.edu/~mattmann/
> ++
> Director, Information Retrieval and Data Science Group (IRDS) Adjunct 
> Associate Professor, Computer Science Department University of 
> Southern California, Los Angeles, CA 90089 USA
> WWW: http://irds.usc.edu/
> ++
>
>
>
>
>
> -Original Message-
> From: Will Stevens 
> Reply-To: "dev@cloudstack.apache.org" 
> Date: Friday, March 18, 2016 at 3:44 PM
> To: "dev@cloudstack.apache.org" 
> Subject: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'
>
> >We are discussing this proposal in 3 or 4 threads, so I will not try 
> >to recap everything.  Instead I will try to give a brief overview of 
> >the problem and a proposal for solving it.
> >
> >*Problem:*
> >The Apache CloudStack community needs additional github permissions 
> >in order to integrate CI for the purpose of maintaining code quality.  
> >The ASF does not have enough granular control via the 'apache' github 
> >organization to give the 'apache/cloudstack' repository the needed 
> >permissions.
> >
> >*Proposal:*
> >Transfer ownership of the 'apache/cloudstack' mirrored repository out 
> >of the 'apache' github organization into the 'apache-cloudstack' 
> >github organization (which I have already setup and started inviting users 
> >to).
> >Both members of the ACS community and the ASF board will have 'owner'
> >permissions on this new organization.  This will allow for 
> >permissions to be applied specifically to the 'apache-cloudstack' 
> >organization and not have to be applied to the entire 'apache' organization.
> >
> >By transferring ownership, all of the PRs will be copied to the new 
> >repository and redirects will be created on github from 
> >'apache/cloudstack'
> >to 'apache-cloudstack/cloudstack'.
> >
> >The developer workflow and commit workflow will remain unchanged.  
> >The canonical ASF repository (git://git.apache.org/cloudstack.git) 
> >will
> remain
> >the source of truth and commits will be made to that repository.
> >
> >Please ask if anything is unclear or needs to be better defined in 
> >order for you to cast a vote.
>
>


--
Tian ChunFeng
http://cloud.domolo.com



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[Blocker/Critical] VR related Issues

[Kishan Kavala]

Below VR related issues currently open. Most of these issues did not exist in 
4.5.x and are related to VR refactor (persistent VR).

Blocker
https://issues.apache.org/jira/browse/CLOUDSTACK-8690 - Remote Access VPN not 
working

Critical
https://issues.apache.org/jira/browse/CLOUDSTACK-8688 - Default policy for 
INPUT and FORWARD chain is ACCEPT in VR filter table (Wilder is working on 
this) 
https://issues.apache.org/jira/browse/CLOUDSTACK-8681 - CS does not honor the 
default deny egress policy in isolated network
https://issues.apache.org/jira/browse/CLOUDSTACK-8710 - site2site vpn iptables 
rules are not configured on VR
https://issues.apache.org/jira/browse/CLOUDSTACK-8685 - Default route is not 
configured on VPC VR
https://issues.apache.org/jira/browse/CLOUDSTACK-8694  - Monitor service cron 
job not visible

RE: [Blocker] Default ip table rules on VR

[Kishan Kavala]

This is a security issue with high impact.
We should treat it as a blocker.

-Original Message-
From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] 
Sent: 30 July 2015 02:07 PM
To:  
Subject: Re: [Blocker] Default ip table rules on VR

I see VR ingress traffic is blocked by default from iptables mangle table.
But on the guest interface all the traffic is accepted.
Also egress firewall rule will break because of FORWARD policy.

Thanks,
Jayapal

On 30-Jul-2015, at 12:53 PM, Jayapal Reddy Uradi 
 wrote:

> 
> It is security concern on the VR. All the ingress traffic onto the VR is 
> accepted.
> Let it be blocker.
> 
> Thanks,
> Jayapal
> 
> On 30-Jul-2015, at 12:28 PM, Daan Hoogland 
> wrote:
> 
>> I changed it to critical. It is only a blocker if we agree on this 
>> list that it is.
>> 
>> On Thu, Jul 30, 2015 at 6:44 AM, Sanjeev N  wrote:
>>> Hi,
>>> 
>>> In latest ACS builds, the ip table rules in VR have ACCEPT as the 
>>> default policy in INPUT and FORWARD chains, instead of DROP.
>>> 
>>> Created a blocker bug for this issue
>>> https://issues.apache.org/jira/browse/CLOUDSTACK-8688
>>> 
>>> Can somebody please fix it?
>>> 
>>> Thanks,
>>> Sanjeev
>> 
>> 
>> 
>> --
>> Daan
> 

RE: [BLOCKER] unable to start VR in basic zone on master

[Kishan Kavala]

Created PR: https://github.com/apache/cloudstack/pull/627

-Original Message-
From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com] 
Sent: 27 July 2015 06:23 PM
To: dev@cloudstack.apache.org
Subject: Re: [BLOCKER] unable to start VR in basic zone on master

Just replied to the previous email to the list.

Sorry, I missed that one.

I haven’t tested basic zone in a while… will give it a try.

Cheers,
Wilder


> On 27 Jul 2015, at 14:51, Wilder Rodrigues  
> wrote:
> 
> Hi there Rajani,
> 
> My apologies, I missed that one.
> 
> I haven’t tested basic zone in a while, to be honest. I will have a look to 
> see if I can be of any help.
> 
> Cheers,
> Wilder
> 
> 
>> On 27 Jul 2015, at 11:11, Rajani Karuturi  wrote:
>> 
>> I faced the same issue with basic zone using xenserver on master.
>> 
>> Wilder,
>> Can you please comment on this?
>> 
>> ~Rajani
>> 
>> On Fri, Jul 24, 2015 at 4:00 PM, Kishan Kavala 
>> 
>> wrote:
>> 
>>> @Wilder, can you please look into this issue.
>>> Looks like VR config file is incomplete and it is over-writing the 
>>> IP information set by cloud-early-config.
>>> 
>>> VR Config file:
>>> #Apache CloudStack Virtual Router Config File 
>>> 1.0
>>> 
>>> 
>>> /var/cache/cloud/monitor_service.json
>>> 
>>> {"config":"[dhcp]:processname=dnsmasq:servicename=dnsmasq:pidfile=/v
>>> ar/run/dnsmasq/dnsmasq.pid:,[ssh]:processname=sshd:servicename=ssh:p
>>> idfile=/var/run/sshd.pid:,[webserver]:processname=apache2:servicenam
>>> e=apache2:pidfile=/var/run/apache2.pid:,","type":"monitorservice"}
>>> 
>>> 
>>> /opt/cloud/bin/update_config.py monitor_service.json 
>>> 
>>> /var/log/cloud.log:
>>> 2015-07-24 09:29:28,997 Loading data bag type monitorservice
>>> 2015-07-24 09:29:28,998 Command of type monitorservice received
>>> 2015-07-24 09:29:28,999 Writing data bag type monitorservice
>>> 2015-07-24 09:29:28,999 Creating data bag type ips
>>> 2015-07-24 09:29:28,999 Loading data bag type cmdline
>>> 2015-07-24 09:29:29,000 Executing ip addr show dev eth1
>>> 2015-07-24 09:29:29,019 Will remove all configured addresses on 
>>> device eth1
>>> 2015-07-24 09:29:29,019 Removing addresses from device eth1
>>> 2015-07-24 09:29:29,036 Removed address 169.254.2.130/16 from device 
>>> eth1
>>> 2015-07-24 09:29:29,056 Removed address 169.254.2.130/16 from device 
>>> eth1
>>> 2015-07-24 09:29:29,057 Executing ip addr show dev eth0
>>> 2015-07-24 09:29:29,075 Will remove all configured addresses on 
>>> device eth0
>>> 2015-07-24 09:29:29,076 Removing addresses from device eth0
>>> 2015-07-24 09:29:29,093 Removed address 10.220.39.131/19 from device 
>>> eth0
>>> 2015-07-24 09:29:29,112 Removed address 10.220.39.131/19 from device 
>>> eth
>>> 
>>> 
>>> -Original Message-
>>> From: Sanjeev N [mailto:sanj...@apache.org]
>>> Sent: 24 July 2015 12:06 PM
>>> To: dev@cloudstack.apache.org
>>> Subject: [BlockerBug] VR creation fails in basic zone
>>> 
>>> Hi,
>>> 
>>> In latest build with ACS master, VR creation fails in basic zone.
>>> Created a blocker bug for this. More details @
>>> https://issues.apache.org/jira/browse/CLOUDSTACK-8668
>>> 
>>> Thanks,
>>> Sanjeev
>>> 
> 

RE: [BlockerBug] VR creation fails in basic zone

[Kishan Kavala]

@Wilder, can you please look into this issue.
Looks like VR config file is incomplete and it is over-writing the IP 
information set by cloud-early-config. 

VR Config file:
#Apache CloudStack Virtual Router Config File

1.0


/var/cache/cloud/monitor_service.json
{"config":"[dhcp]:processname=dnsmasq:servicename=dnsmasq:pidfile=/var/run/dnsmasq/dnsmasq.pid:,[ssh]:processname=sshd:servicename=ssh:pidfile=/var/run/sshd.pid:,[webserver]:processname=apache2:servicename=apache2:pidfile=/var/run/apache2.pid:,","type":"monitorservice"}


/opt/cloud/bin/update_config.py monitor_service.json


/var/log/cloud.log:
2015-07-24 09:29:28,997 Loading data bag type monitorservice
2015-07-24 09:29:28,998 Command of type monitorservice received
2015-07-24 09:29:28,999 Writing data bag type monitorservice
2015-07-24 09:29:28,999 Creating data bag type ips
2015-07-24 09:29:28,999 Loading data bag type cmdline
2015-07-24 09:29:29,000 Executing ip addr show dev eth1
2015-07-24 09:29:29,019 Will remove all configured addresses on device eth1
2015-07-24 09:29:29,019 Removing addresses from device eth1
2015-07-24 09:29:29,036 Removed address 169.254.2.130/16 from device eth1
2015-07-24 09:29:29,056 Removed address 169.254.2.130/16 from device eth1
2015-07-24 09:29:29,057 Executing ip addr show dev eth0
2015-07-24 09:29:29,075 Will remove all configured addresses on device eth0
2015-07-24 09:29:29,076 Removing addresses from device eth0
2015-07-24 09:29:29,093 Removed address 10.220.39.131/19 from device eth0
2015-07-24 09:29:29,112 Removed address 10.220.39.131/19 from device eth


-Original Message-
From: Sanjeev N [mailto:sanj...@apache.org] 
Sent: 24 July 2015 12:06 PM
To: dev@cloudstack.apache.org
Subject: [BlockerBug] VR creation fails in basic zone

Hi,

In latest build with ACS master, VR creation fails in basic zone.
Created a blocker bug for this. More details @
https://issues.apache.org/jira/browse/CLOUDSTACK-8668

Thanks,
Sanjeev

RE: [Proposal] Continuos Integration Testing on ACS master.

[Kishan Kavala]

Bharat,
 I hope this will go a long way in improving product quality. How are you going 
to handle the handle the hardware requirement? What is the plan to publish the 
results to ML?

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: 23 July 2015 03:46 PM
To: dev
Subject: Re: [Proposal] Continuos Integration Testing on ACS master.

Good work Bharat, Keep in mind that many people work on this in many ways and 
many attempts have failed due to nothing but lack of consensus. I have only 
glanced but will take my time with it soon.

On Thu, Jul 23, 2015 at 10:50 AM, Bharat Kumar  wrote:
> Hi All,
>
> Currently we do sanity checks on master using Travis, But travis runs 
> only simulator tests (AFAIK). I think it will be better if we can run both 
> BVTs and regression tests on real hardware. I am woking on implementing this.
>
> Functional spec and design details.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orches
> trator+and+test+runner+to+enable+continuos+integration
>
> Please read the FS and give your comments or suggestions.
>
> Thanks,
> Bharat.



--
Daan

RE: [Proposal] CoreOS support

[Kishan Kavala]

Sure Sebastian. I'll check OS type list and remove outdated distros. 

-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: 22 July 2015 08:09 PM
To: dev@cloudstack.apache.org
Subject: Re: [Proposal] CoreOS support

+1

Can you clean that last of OS Type while you are it, last time I checked it was 
really long with some outdated distros…

-sebastien

> On Jul 22, 2015, at 4:35 PM, Somesh Naidu  wrote:
> 
> +1
> 
> Regards,
> Somesh
> 
> -Original Message-
> From: Ahmad [mailto:aemne...@gmail.com] 
> Sent: Wednesday, July 22, 2015 10:28 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [Proposal] CoreOS support
> 
> +1 looking forward to this.
> 
> 
> 
>> On Jul 22, 2015, at 1:14 PM, Kishan Kavala  wrote:
>> 
>> I would like to add CoreOS as a supported OS type to cloudstack.
>> CoreOS vms can be created even now by selecting OS type as "Other". There 
>> are cloud providers supporting CoreOS offerings in production already.
>> By making the changes mentioned at [1] I would make it easier to deploy 
>> CoreOS Vms and also add UI support for providing cloud-config via userdata.
>> I'll also update the documentation at [2] after making these changes.
>> 
>> [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/CoreOS
>> [2] https://coreos.com/os/docs/latest/booting-on-cloudstack.html

[Proposal] CoreOS support

[Kishan Kavala]

I would like to add CoreOS as a supported OS type to cloudstack.
CoreOS vms can be created even now by selecting OS type as "Other". There are 
cloud providers supporting CoreOS offerings in production already.
By making the changes mentioned at [1] I would make it easier to deploy CoreOS 
Vms and also add UI support for providing cloud-config via userdata.
I'll also update the documentation at [2] after making these changes.

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/CoreOS
[2] https://coreos.com/os/docs/latest/booting-on-cloudstack.html

RE: [PROPOSAL] drop old upgrade code

[Kishan Kavala]

-1 on dropping old upgrade code.

I prefer skipping old upgrade paths during coverity scan instead of removing 
the code altogether.
Even with multi-step upgrade, user will be forced to register system templates 
multiple times (once for every step).  
Agree with John regarding the need to establish a standard upgrade policy.

-Original Message-
From: John Burwell [mailto:john.burw...@shapeblue.com] 
Sent: 20 July 2015 09:41 PM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] drop old upgrade code

Daan,

While I see the desire to remove outstanding scan issues, doing it at the 
expense of a feature required by users is not acceptable to me.  My first 
question is how many users are still running pre-4.x versions?  In its current 
state, the commit message lacks an explanation of the reasoning for the change, 
and there is no documentation about the change.  Until these basic bits of 
documentation are addressed, and we have a good feel for the user impact, I am 
-1 on this change.

With this change, I think we should also establish a standard upgrade support 
policy (e.g. current minor release - x revisions).  If a user falls far enough 
behind, they would be require to execute a multi-step upgrade in order to 
upgrade to latest.  Whatever we decide, it should be clearly documented, and 
discussed on dev@ and user@.

I am happy to pose these questions on user@ to get a feel for the potential 
impact of this change and input on the desired upgrade policy.

Thanks,
-John

---
John Burwell (@john_burwell)
VP of Software Engineering, ShapeBlue
(571) 403-2411 | +44 20 3603 0542
http://www.shapeblue.com
Please join us at CloudStack Collab EU — 
http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe




> On Jul 20, 2015, at 10:27 AM, Daan Hoogland  wrote:
>
> in anticipation of loads of +1's I made a new PR (at [2])
>
> On Mon, Jul 20, 2015 at 2:29 PM, Wido den Hollander  wrote:
>>
>>
>> On 20-07-15 13:48, Daan Hoogland wrote:
>>> LS,
>>>
>>> In coverity the only remaining high impact issues are concerned with 
>>> upgrade code. Some of it is in 4.3 and 4.5 code but most in pre-4 
>>> upgrades.
>>>
>>> I addressed the file Upgrade218to22.java in a PR [1] and I move that 
>>> we don't pull it but instead drop the file altogether together with 
>>> all upgrade code dating prior to 4.0.0. anybody on older versions 
>>> can still upgrade to any version between 4.0 and 4.5 and move on 
>>> from there.
>>>
>>> My objective is to have no high impact issues remaining so we 
>>> clearly see when we are digressing beit by hand or in  an automated way.
>>>
>>> +1?
>>>
>>
>> +1 I don't see a reason to keep supporting these ancient upgrade paths.
>>
>> Wido
>>
>>> [1] https://github.com/apache/cloudstack/pull/603
>
> [2] https://github.com/apache/cloudstack/pull/608
>
>
> --
> Daan

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

RE: [DISCUSS] Release principles for Apache CloudStack

[Kishan Kavala]

Remi,
 Release process looks good to me. Can you also add some info about maintenance 
release?
- After release, will the fixes go into x.y branch and merged back to master?
- or bug fixes go into master and selectively merged back to x.y branch?


-Original Message-
From: Remi Bergsma [mailto:r...@remi.nl] 
Sent: 02 July 2015 17:17
To: 
Subject: [DISCUSS] Release principles for Apache CloudStack 

Hi all,

We already agreed contributions should always go via a PR and require two 
LGTM’s before we merge. Let me propose the next step on how I think we should 
do release management for 4.6 and on.

I talked to several people over the past weeks and wrote this wiki article:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack
 

 

If you like this way of working, I volunteer to be your RM :-)

Like folks suggested earlier, it would be nice to work on this with multiple 
people. So, feel free to join. Maybe @dahn @bhaisaab and/or others are willing 
to teach me some of their tricks.

Regards,
Remi

RE: [DISCUSS] Stop using Review Board

[Kishan Kavala]

+1 for GitHub

Can we do a one-time migration of all open RB requests to GH and make RB 
read-only?

-Original Message-
From: Rajani Karuturi [mailto:raj...@apache.org] 
Sent: Monday, March 30, 2015 10:33 AM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Stop using Review Board

+1

~Rajani

On Fri, Mar 27, 2015 at 9:00 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> 
wrote:

> +1
>
> On Fri, Mar 27, 2015 at 2:52 AM, Sebastien Goasguen 
> wrote:
>
> > Hi everyone,
> >
> > Since GitHub pull requests have been enabled for cloudstack, we have 
> > closed 127 commits.
> >
> > I believe this is a nicer interface, one that folks are used to when 
> > contributing to other open source projects.
> >
> > In the meantime, we still have 73 open reviews on Review Board
> >
> > https://reviews.apache.org/
> >
> > * I propose that we stop using RB all together, and remove any links 
> > to
> it
> > from our website and README.
> >
> > A few of us have tried to close some of the reviews by pinging the
> authors
> > already.
> >
> > * My second proposition is that we write a comment in all reviews:
> >
> > “Thanks for the patch, the cloudstack community has decided to stop 
> > using Review Board in favor of github pull request.
> > You can see  to learn how to submit a pull request to cloudstack.
> > Could you move your patch to a PR ?
> > Without response from you we will close this review within 7 days.
> > "
> >
> > There is good contribution guidelines in our docs README:
> > https://github.com/apache/cloudstack-docs
> >
> > -Sebastien
>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>

RE: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack

[Kishan Kavala]

Congratulations Rohit. Well deserved!!

-Original Message-
From: Vaibhav Gupta [mailto:vaibhav.gu...@citrix.com] 
Sent: Saturday, March 28, 2015 4:19 PM
To: dev@cloudstack.apache.org
Subject: RE: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack

Congratulations, Rohit!!

Thanks,
Vaibhav 

-Original Message-
From: Alena Prokharchyk [mailto:alena1...@gmail.com] 
Sent: 28 March 2015 12:55
To: dev@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack

Congrats, Rohit!

On Fri, Mar 27, 2015 at 11:07 PM, Ahmad  wrote:

> Congrats Mr Yadav! Keep kicking tail.
>
>
>
> > On Mar 27, 2015, at 1:07 AM, Sebastien Goasguen 
> wrote:
> >
> > The Project Management Committee (PMC) for Apache CloudStack are pleased
> to
> > announce that Rohit Yadav has accepted our invitation to join the PMC.
> >
> > Please join me in congratulating him.
> >
> > On behalf of the Apache CloudStack PMC
>



-- 
Alena Prokharchyk
https://twitter.com/Lemonjet
http://www.linkedin.com/pub/alena-prokharchyk/13/282/a7b

RE: [DISCUSS] Usage server: when can start end be after end date?

[Kishan Kavala]

Response inline:

-Original Message-
From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] 
Sent: Monday, March 16, 2015 3:41 PM
To: dev
Cc: Kishan Kavala
Subject: [DISCUSS] Usage server: when can start end be after end date?

Hi,

In the usage server, when can a resource (say volumes) have their creation date 
after end date when calculating usage records/data. For example this check:

https://github.com/apache/cloudstack/blob/master/usage/src/com/cloud/usage/parser/VolumeUsageParser.java#L106

In which cases/scenarios, will we hit that?

[KK] Issue is due to the SQL query(GET_ALL_USAGE_RECORDS) in Usage**DaoImpl. If 
the usage job does not run for few days, records are processed in bulk when it 
runs the next time. In Vm usage for example, If there are multiple stop/starts 
during that period, usage_vm_instance will contain multiple entries for the 
same Vm. The last entry will have end_date = null if the Vm is still running. 
The entry with null end_date is always returned with this query irrespective of 
the start/end dates of the job. This may result in negative usage in some 
cases. Ideally this should be fixed in the Dao, instead of adding the check 
mentioned above. 

Lastly, what happens if a resource usage is less than an aggregation period or 
does not evenly divide into one. For example, if resource usage were 
billed/generated hourly and if I use a VM for a 1.3 hours, will I have usage 
data/records for an hour or 2 hours or 1.3 hours?

[KK] If the aggregation period is 1 hr, there will be two usage records X1 and 
X2. Raw_usage for X1 + X2 will = 1.3hrs. It could be 1hr in the 1st record and 
0.3 hrs in the 2nd record. Depends on when the resource was allocated/released. 
It won't be 1hr or 2hrs for sure.

RE: [DISCUSS] Support Docker as a hypervisor in CloudStack ( CloudStack / CLOUDSTACK-8205)

[Kishan Kavala]

CoreOS is supported on CS. Templates are available here: 
http://dl.openvm.eu/cloudstack/coreos/x86_64/

Still, I think it is working exploring Docker as a hypervisor also.

Tuna stared some work on this earlier:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Supporting+Docker+as+a+hypervisor
http://ngtuna.blogspot.in/2013/12/docker-in-cloudstack.html

https://issues.apache.org/jira/browse/CLOUDSTACK-6664


-Original Message-
From: Koushik Das [mailto:koushik@citrix.com] 
Sent: Monday, March 16, 2015 10:49 AM
To: dev@cloudstack.apache.org
Subject: RE: [DISCUSS] Support Docker as a hypervisor in CloudStack ( 
CloudStack / CLOUDSTACK-8205)

This is another alternate https://coreos.com/using-coreos/containers/. CS needs 
to support CoreOS.

-Original Message-
From: Diwas Joshi [mailto:dj.dij...@gmail.com] 
Sent: Monday, 16 March 2015 2:53
To: dev@cloudstack.apache.org
Subject: [DISCUSS] Support Docker as a hypervisor in CloudStack ( CloudStack / 
CLOUDSTACK-8205)

hello, I would like to work on the following issue for
https://issues.apache.org/jira/browse/CLOUDSTACK-8205 for google summer of code 
2015. It would be really helpful if someone can tell me more about the idea and 
provide guidelines to get started with this.

regards

RE: [ANNOUNCE] New committer: Harikrishna Patnala

[Kishan Kavala]

Congratulations Hari!

-Original Message-
From: Rajani Karuturi [mailto:raj...@apache.org] 
Sent: Tuesday, March 10, 2015 11:00 AM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New committer: Harikrishna Patnala

The Project Management Committee (PMC) for Apache CloudStack has asked 
Harikrishna Patnala to become a committer and we are pleased to announce that 
he has accepted.

Being a committer allows many contributors to contribute more autonomously. For 
developers, it makes it easier to submit changes and eliminates the need to 
have contributions reviewed via the patch submission process. Whether 
contributions are development-related or otherwise, it is a recognition of a 
contributor's participation in the project and commitment to the project and 
the Apache Way.

Please join me in congratulating Hari.

https://github.com/apache/cloudstack/commits/master?author=harikrishna-patnala
Keep them coming. :)

--
on behalf of the CloudStack PMC,

~Rajani

RE: [DISCUSS] Improving VR services such as password server

[Kishan Kavala]

Rohit,
Completely agree with the scalability and maintenance issues with systems Vms. 
Using an agent inside VR will probably work well for KVM, since the KVM agent 
(Resource layer) is remote. Communication using link-local network also won't 
be a problem is such case.
For other hypervisors, it will increase load on the mgmt server due to direct 
agents.  Also, mgmt server cannot access VRs directly.

The options you mentioned  are definitely worth exploring.

Are you also looking at improving system Vm upgrade procedure?

-Original Message-
From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] 
Sent: Friday, February 20, 2015 1:24 PM
To: dev; us...@cloudstack.apache.org
Subject: [DISCUSS] Improving VR services such as password server

Hi,

I'm trying to explore how to make systemvms more robust and fault-tolerant, and 
the manual/automated QA of systemvms. One of the common user facing issues 
related to scalability was the reset password/key servers where the VR serves 
data using socat etc using forking mechanisms and global locks. This slows down 
the processes such as reset password.

More here: https://issues.apache.org/jira/browse/CLOUDSTACK-8272

One of the blindly thrown solutions includes increasing the VR RAM which works 
for at scale but then seems to fail again when the load is increased beyond a 
point. I don't know of any performance and stress testing reports that tell us 
about these bottlenecks. Please share if you have done anything in this regard.

I want to do couple of things:

- Explore systemvm build changes using newer tools such as packer
- Cleanup script execution and code in resource layer
- Start replacing bash scripts with more robust implementations, perhaps a 
single or few agents on VRs that provide non-hardcoded well-documented 
interfaces
- Right now everything in VR/systemvms is sort of hardcoded and the 
services/interfaces are not well-documented. The idea is to refactor and wrap 
everything we want to do with the systemvms in a general agents framework that 
provides monitoring and managing the VRs (do stuff like upgrades etc to combat 
things like ghost, poodle issues):
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Agents+Framework

What are the other issues you've had in past that you would like to be improved?

--
Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +91 8826230892 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab PS. If you see any footer below, I did 
not add it :) Find out more about ShapeBlue and our range of CloudStack related 
services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

RE: Usage Records not Generating.

[Kishan Kavala]

Rajasekhar,
 I do not see any errors in the usage server logs posted earlier. As per mgmt 
server heartbeat check, usage server is not updating usage_job tables also. Did 
you try restarting usage server?


-Original Message-
From: raja sekhar [mailto:rajsekhar@gmail.com] 
Sent: Wednesday, February 18, 2015 4:03 PM
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Subject: Re: Usage Records not Generating.

Hi All,

I have found this error in management server log file saying that usage server 
is not running,but usage server is still running. I am using two management 
servers, on Dec 27 2014 i have rebooted manually one of the management 
server,and the log is showing that date, from that date onwards iam not getting 
usage records.Is this BUG?
I heard that this is fixed in 4.3.
https://issues.apache.org/jira/browse/CLOUDSTACK-5613

If not what is the procedure to generate usage records again?

2015-02-18 00:08:49,700 DEBUG [c.c.a.m.DirectAgentAttache]
(DirectAgent-152:ctx-c1bbf117) Seq 1-1418147853: Executing request
2015-02-18 00:08:49,991 INFO  [c.c.h.HighAvailabilityManagerImpl]
(HA-3:ctx-fc33e670) *checking health of usage server*
2015-02-18 00:08:49,994 DEBUG [c.c.h.HighAvailabilityManagerImpl]
(HA-3:ctx-fc33e670) *usage server running? false*, heartbeat: *Sat Dec 27
23:14:50 PST* *2014*
2015-02-18 00:08:49,995 WARN  [o.a.c.alerts] (HA-3:ctx-fc33e670)
 alertType:: 13 // dataCenterId:: 0 // podId:: 0 // clusterId:: null //
message:: *No usage server process running*
2015-02-18 00:08:49,998 DEBUG [c.c.a.AlertManagerImpl] (HA-3:ctx-fc33e670) Have 
already sent: 1 emails for alert type '13' -- skipping send email


Regards,
Rajasekhar.


On Mon, Feb 9, 2015 at 5:13 PM, raja sekhar  wrote:

> Hi Wei,
>
> Thanks for your reply.
> I have found the file in "cd /etc/cloudstack/management/log4j-cloud.xml"
> and "cd /etc/cloudstack/usage/log4j-cloud.xml".it is same as you told.
>
> The log file i have captured in "/var/log/cloudstack/usage/usage.log" is:
>
>
> 2014-12-28 07:15:05,773 DEBUG [db.Transaction.Transaction]
> (Usage-Job-1:null) Transaction is not closed properly:
> -UsageEventDaoImpl.getRecentEvents:99-ComponentInstantiationPostProces
> sor$InterceptorDispatcher.intercept:125-UsageManagerImpl.parse:556-Usa
> geManagerImpl.runInContextInternal:349-UsageManagerImpl$1.runInContext
> :291-ManagedContextRunnable$1.run:49-DefaultManagedContext$1.call:56-D
> efaultManagedContext.callWithContext:103-DefaultManagedContext.runWith
> Context:53-ManagedContextRunnable.run:46-UsageManagerImpl.run:288-Exec
> utors$RunnableAdapter.call:471
> :
> -UsageEventDaoImpl.getRecentEvents:99-ComponentInstantiationPostProces
> sor$InterceptorDispatcher.intercept:125-UsageManagerImpl.parse:556-Usa
> geManagerImpl.runInContextInternal:349-UsageManagerImpl$1.runInContext
> :291-ManagedContextRunnable$1.run:49-DefaultManagedContext$1.call:56-D
> efaultManagedContext.callWithContext:103-DefaultManagedContext.runWith
> Context:53-ManagedContextRunnable.run:46-UsageManagerImpl.run:288-Exec
> utors$RunnableAdapter.call:471,
> .  Called by
> -TransactionLegacy.open:166-TransactionLegacy.open:126-UsageManagerImp
> l.parse:786-UsageManagerImpl.runInContextInternal:349-UsageManagerImpl
> $1.runInContext:291-ManagedContextRunnable$1.run:49-DefaultManagedCont
> ext$1.call:56-DefaultManagedContext.callWithContext:103-DefaultManaged
> Context.runWithContext:53-ManagedContextRunnable.run:46-UsageManagerIm
> pl.run:288-Executors$RunnableAdapter.call:471
> 2014-12-28 07:15:05,776 INFO  [cloud.usage.UsageManagerImpl]
> (Usage-Job-1:null) usage job complete
> 2014-12-29 06:39:27,416 INFO
>  [context.support.ClassPathXmlApplicationContext] (main:null) 
> Refreshing
> org.springframework.context.support.ClassPathXmlApplicationContext@1055e55f:
> startup date [Sun Dec 28 22:39:27 PST 2014]; root of context hierarchy
> 2014-12-29 06:39:27,664 INFO  [factory.xml.XmlBeanDefinitionReader]
> (main:null) Loading XML bean definitions from class path resource 
> [usageApplicationContext.xml]
> 2014-12-29 06:39:28,929 INFO
>  [context.annotation.ClassPathBeanDefinitionScanner] (main:null) 
> JSR-330 'javax.inject.Named' annotation found and supported for 
> component scanning
> 2014-12-29 06:39:30,436 INFO
>  [factory.annotation.AutowiredAnnotationBeanPostProcessor] (main:null)
> JSR-330 'javax.inject.Inject' annotation found and supported for 
> autowiring
> 2014-12-29 06:39:30,912 INFO
>  [context.support.ClassPathXmlApplicationContext] (main:null) Bean 
> 'transactionContextBuilder' of type [class 
> com.cloud.utils.db.TransactionContextBuilder] is not eligible for 
> getting processed by all BeanPostProcessors (for example: not eligible 
> for
> auto-proxying)
> 2014-12-29 06:39:30,992 INFO  
> [factory.support.DefaultListableBeanFactory]
> (main:null) Pre-instantiating singletons in
> org.springframework.beans.factory.support.DefaultListableBeanFactory@259e215b:
> defining beans
> [org.springframework.context.annotation.internalC

RE: Differences in schema-442to450.sql between 4.5 and master

[Kishan Kavala]

Added commit 1091d458 to 4.5 branch.

Regards,
Kishan

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Thursday, November 27, 2014 3:14 PM
To: dev
Subject: Re: Differences in schema-442to450.sql between 4.5 and master

Please take note that people that made the change probably made it to 
schema-441to450.sql which I renamed.

On Thu, Nov 27, 2014 at 10:32 AM, Hugo Trippaers  wrote:
> See this diff:
> Hugos-MacBook-Pro-7:cloudstack hugo (master)$ git diff master 4.5 
> setup/db/db/schema-442to450.sql diff --git 
> a/setup/db/db/schema-442to450.sql b/setup/db/db/schema-442to450.sql 
> index f84bca6..083943b 100644
> --- a/setup/db/db/schema-442to450.sql
> +++ b/setup/db/db/schema-442to450.sql
> @@ -753,8 +753,6 @@ INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, 
> category_id, display_name, crea  INSERT IGNORE INTO `cloud`.`guest_os` 
> (id, uuid, category_id, display_name, created) VALUES (247, UUID(), 3, 
> 'Oracle Linux 7', utc_timestamp());  INSERT IGNORE INTO 
> `cloud`.`guest_os` (id, uuid, category_id, display_name, created) 
> VALUES (248, UUID(), 1, 'CentOS 6 (32-bit)', utc_timestamp());  INSERT 
> IGNORE INTO `cloud`.`guest_os` (id, uuid, category_id, display_name, 
> created) VALUES (249, UUID(), 1, 'CentOS 6 (64-bit)', 
> utc_timestamp()); -INSERT IGNORE INTO `cloud`.`guest_os` (id, uuid, 
> category_id, display_name, created) VALUES (250, UUID(), 3, 'Oracle 
> Enterprise Linux 6.5 (32-bit)', utc_timestamp()); -INSERT IGNORE INTO 
> `cloud`.`guest_os` (id, uuid, category_id, display_name, created) 
> VALUES (251, UUID(), 3, 'Oracle Enterprise Linux 6.5 (64-bit)', 
> utc_timestamp());
>
>  INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` 
> (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, 
> created, is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0  INSERT 
> IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0 @@ -837,8 +835,6 
> @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` 
> (uuid,hypervisor_type, hypervis  INSERT IGNORE INTO 
> `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0  INSERT IGNORE 
> INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0  INSERT IGNORE 
> INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0 -INSERT IGNORE 
> INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0 -INSERT IGNORE 
> INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0  INSERT IGNORE 
> INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0  INSERT IGNORE 
> INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0  INSERT IGNORE 
> INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
> hypervisor_version, guest_os_name, guest_os_id, created, 
> is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0 @@ -935,16 +931,6 
> @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` 
> (uuid,hypervisor_type, hypervis
>
>  INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, 
> hypervisor_type, hypervisor_version, max_guests_limit, 
> security_group_enabled, max_data_volumes_limit, storage_motion_sup
>
> -update vlan set vlan_id=concat('vlan://', vlan_id) where vlan_type = 
> "VirtualNetwork" and vlan_id not like "vlan://%";
> -
> -CREATE TABLE `cloud`.`baremetal_rct` (
> -  `id` bigint unsigned UNIQUE AUTO_INCREMENT,
> -  `uuid` varchar(40) UNIQUE NOT NULL,
> -  `url` varchar(2048) NOT NULL,
> -  `rct` text NOT NULL,
> -   PRIMARY KEY (`id`)
> -) ENGINE = InnoDB DEFAULT CHARSET=utf8;
> -
>  --Remove duplicates from guest_os_hypervisor table  DELETE t1 FROM 
> guest_os_hypervisor t1, guest_os_hypervisor t2 WHERE 
> (t1.hypervisor_type = t2.hypervisor_type AND t1.hypervisor_version = 
> t2.hypervisor_version AND t1.guest_os_id =
>
> @@ -958,9 +944,6 @@ ALTER TABLE `cloud`.`user_vm_details` MODIFY 
> `value` VARCHAR(5120);
>
>  UPDATE `cloud`.`host` SET resource = REPLACE(resource, 
> 'com.cloud.hypervisor.xen.resource', 
> 'com.cloud.hypervisor.xenserver.resource') WHERE 
> hypervisor_type='XenServer' AND REMOVED
>
> -INSERT INTO `cloud`.`vm_template` (id, uuid, unique_name, name, public, 
> created, t

Re: Review Request 27222: Usage Events to be captured based on Volume State Machine

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27222/#review60560
---

Ship it!


master: 781648fb1003c8c32875e9ff7a6c4ef4694539f7

- Kishan Kavala


On Nov. 10, 2014, 3:15 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27222/
> ---
> 
> (Updated Nov. 10, 2014, 3:15 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-7792
> https://issues.apache.org/jira/browse/CLOUDSTACK-7792
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Currently in CloudStack the Usage Events for Volume related actions are 
> captured directly at various places.
> 
> But actually Volume has a State Machine which can be used to capture Usage 
> Events for volume similar to VM Usage Events
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/storage/Volume.java 91ad955 
>   api/src/com/cloud/vm/VirtualMachine.java 99152d6 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java
>  b21616a 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  826e2ee 
>   engine/schema/src/com/cloud/storage/VolumeVO.java e328253 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java
>  f2b4c95 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
>  9c45cb8 
>   server/src/com/cloud/storage/StorageManagerImpl.java 153c25a 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 088f054 
>   server/src/com/cloud/storage/listener/VolumeStateListener.java 0ba2969 
> 
> Diff: https://reviews.apache.org/r/27222/diff/
> 
> 
> Testing
> ---
> 
> Tested on Simulator. Also tested on XenServer for the following use cases
> 
> 1. Add Volume (Migrate, Destroy)
> 2. Attach Volume (Live Migration and normal Migration)
> 3. Upload Volume (Attach also)
> 4. Delete Volume
> 5. Deploy VM (With Data Disk and with out Data Disk)
> 6. Destroy VM (With Data Disk and with out Data Disk)
> 7. Recover VM
> 8. Restore VM
> 9. Resize Volume
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 27520: Usage Job fails with "Data too long for column 'user_name'"

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27520/#review60559
---


4.5 36fd780482dbd65ef9328f630d0af0793d0fed2e

- Kishan Kavala


On Nov. 10, 2014, 2:44 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27520/
> ---
> 
> (Updated Nov. 10, 2014, 2:44 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7830
> https://issues.apache.org/jira/browse/CLOUDSTACK-7830
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> While inserting into the cloud_usage database  it is getting the following 
> exception.
> 
> INSERT INTO usage_vpn_user (usage_vpn_user.zone_id, 
> usage_vpn_user.account_id, usage_vpn_user.domain_id, usage_vpn_user.user_id, 
> usage_vpn_user.user_name, usage_vpn_user.created, usage_vpn_user.deleted) 
> VALUES (0, 13, 14, 4, _binary'timothy.lother...@dcxclouddemo.co.za', 
> '2014-03-11 14:36:50', null)
> 
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long 
> for column 'user_name' at row 1
>   at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4072)
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-441to450.sql d9bc8e0 
> 
> Diff: https://reviews.apache.org/r/27520/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.5.0 by upgrading from 4.3.0
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 27671: MS does not start after the VM it is running on is rebooted

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27671/#review60558
---


4.5 34f31f90331d0027b133ccdc8fdb65ab86ce26cc

- Kishan Kavala


On Nov. 6, 2014, 12:26 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27671/
> ---
> 
> (Updated Nov. 6, 2014, 12:26 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7851
> https://issues.apache.org/jira/browse/CLOUDSTACK-7851
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> After installing management server on centos and try to reboot the machine. 
> It will not start the management server automatically.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud-management.rc eaabd30 
> 
> Diff: https://reviews.apache.org/r/27671/diff/
> 
> 
> Testing
> ---
> 
> Tested on Centos 6.x and RHEL 7
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 27613: sync Job Failures always reported as success on Event Bus

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27613/#review60557
---


4.5 cdabb2407a0761939d5159fd2317ebd7dcca4eb7

- Kishan Kavala


On Nov. 5, 2014, 5:26 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27613/
> ---
> 
> (Updated Nov. 5, 2014, 5:26 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-7843
> https://issues.apache.org/jira/browse/CLOUDSTACK-7843
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As complete async job event gets published before saving the job status to 
> the database. so it is not putting correct job status into event bus while 
> publishing.
> 
> 
> Diffs
> -
> 
>   
> framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
>  548182a 
> 
> Diff: https://reviews.apache.org/r/27613/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 27021: Reservations for VMware VMs remain after dynamic scaling

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27021/#review60556
---


4.5 0e7f1ea9b819de197e70a088e92d7ffb7016d063

- Kishan Kavala


On Oct. 22, 2014, 11:33 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27021/
> ---
> 
> (Updated Oct. 22, 2014, 11:33 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7763
> https://issues.apache.org/jira/browse/CLOUDSTACK-7763
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Reservations for VMware VMs remain after dynamic scaling
> https://issues.apache.org/jira/browse/CLOUDSTACK-7763
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  085b6bbed4918be3155fd44c8bed785983526e11 
> 
> Diff: https://reviews.apache.org/r/27021/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 26969: During VM deployment and while choosing CUSTOM disk offering for data disk, the size of the data disk is not considered for checking resource limit of primary storage.

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26969/#review60555
---


4.5: 310bb255acd74b6347bd778590e15543eef7333b

- Kishan Kavala


On Oct. 21, 2014, 6:04 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26969/
> ---
> 
> (Updated Oct. 21, 2014, 6:04 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7760
> https://issues.apache.org/jira/browse/CLOUDSTACK-7760
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-7760
> During VM deployment and while choosing CUSTOM disk offering for data disk, 
> the size of the data disk is not considered for checking resource limit of 
> primary storage.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 
> 2636096d03d7cfa097605ac066b8bd66b24972b7 
> 
> Diff: https://reviews.apache.org/r/26969/diff/
> 
> 
> Testing
> ---
> 
> tested on 4.5
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 27613: sync Job Failures always reported as success on Event Bus

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27613/#review60551
---

Ship it!


Master: ca66062cd54305afaaa64d707a88fc11764e292d

- Kishan Kavala


On Nov. 5, 2014, 5:26 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27613/
> ---
> 
> (Updated Nov. 5, 2014, 5:26 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-7843
> https://issues.apache.org/jira/browse/CLOUDSTACK-7843
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As complete async job event gets published before saving the job status to 
> the database. so it is not putting correct job status into event bus while 
> publishing.
> 
> 
> Diffs
> -
> 
>   
> framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
>  548182a 
> 
> Diff: https://reviews.apache.org/r/27613/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 27671: MS does not start after the VM it is running on is rebooted

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27671/#review60550
---

Ship it!


Master: 131c2f2014f69685b200b5304be88d9b1da3a2c9

- Kishan Kavala


On Nov. 6, 2014, 12:26 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27671/
> ---
> 
> (Updated Nov. 6, 2014, 12:26 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7851
> https://issues.apache.org/jira/browse/CLOUDSTACK-7851
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> After installing management server on centos and try to reboot the machine. 
> It will not start the management server automatically.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud-management.rc eaabd30 
> 
> Diff: https://reviews.apache.org/r/27671/diff/
> 
> 
> Testing
> ---
> 
> Tested on Centos 6.x and RHEL 7
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 26969: During VM deployment and while choosing CUSTOM disk offering for data disk, the size of the data disk is not considered for checking resource limit of primary storage.

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26969/#review60547
---

Ship it!


Master: 991d783e0332d07cba18d046dfc7220a063f670f

- Kishan Kavala


On Oct. 21, 2014, 6:04 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26969/
> ---
> 
> (Updated Oct. 21, 2014, 6:04 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7760
> https://issues.apache.org/jira/browse/CLOUDSTACK-7760
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-7760
> During VM deployment and while choosing CUSTOM disk offering for data disk, 
> the size of the data disk is not considered for checking resource limit of 
> primary storage.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 
> 2636096d03d7cfa097605ac066b8bd66b24972b7 
> 
> Diff: https://reviews.apache.org/r/26969/diff/
> 
> 
> Testing
> ---
> 
> tested on 4.5
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 27520: Usage Job fails with "Data too long for column 'user_name'"

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27520/#review60548
---

Ship it!


Master: 895cc9189ab61d4d084c1aa6a2773b65eb6ad5f7

- Kishan Kavala


On Nov. 10, 2014, 2:44 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27520/
> ---
> 
> (Updated Nov. 10, 2014, 2:44 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7830
> https://issues.apache.org/jira/browse/CLOUDSTACK-7830
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> While inserting into the cloud_usage database  it is getting the following 
> exception.
> 
> INSERT INTO usage_vpn_user (usage_vpn_user.zone_id, 
> usage_vpn_user.account_id, usage_vpn_user.domain_id, usage_vpn_user.user_id, 
> usage_vpn_user.user_name, usage_vpn_user.created, usage_vpn_user.deleted) 
> VALUES (0, 13, 14, 4, _binary'timothy.lother...@dcxclouddemo.co.za', 
> '2014-03-11 14:36:50', null)
> 
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long 
> for column 'user_name' at row 1
>   at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4072)
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-441to450.sql d9bc8e0 
> 
> Diff: https://reviews.apache.org/r/27520/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.5.0 by upgrading from 4.3.0
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 27021: Reservations for VMware VMs remain after dynamic scaling

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27021/#review60546
---

Ship it!


ea99ff1c8622eadf8024ee9922d5f2b2b18d4f80

- Kishan Kavala


On Oct. 22, 2014, 11:33 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27021/
> ---
> 
> (Updated Oct. 22, 2014, 11:33 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7763
> https://issues.apache.org/jira/browse/CLOUDSTACK-7763
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Reservations for VMware VMs remain after dynamic scaling
> https://issues.apache.org/jira/browse/CLOUDSTACK-7763
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  085b6bbed4918be3155fd44c8bed785983526e11 
> 
> Diff: https://reviews.apache.org/r/27021/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 26871: CLOUDSTACK-7748: Cloudstack version number is missing in system vm template.

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26871/#review59561
---

Ship it!


34b7288ca424faa4b9d33b4f678dc7403e354099

- Kishan Kavala


On Oct. 21, 2014, 11:39 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26871/
> ---
> 
> (Updated Oct. 21, 2014, 11:39 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7748
> https://issues.apache.org/jira/browse/CLOUDSTACK-7748
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-7748: Cloudstack version number is missing in system vm template.
> /etc/cloudstack-release in system vm does not have version number which 
> leads in vm deployment failure while checking router version
> 
> 
> During the system vm build, arguments can be passed to build.sh script 
> where 'version' argument is one of the optional arguments. The bug is even if 
> version argument is not passed defalut value(CLOUDSTACK_RELEASE=4.4.0) is 
> overridden by the null value (since argument is not passed).
> 
> 
> Diffs
> -
> 
>   tools/appliance/build.sh 8bf78b1 
>   tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh 
> c076bb5 
> 
> Diff: https://reviews.apache.org/r/26871/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 26871: CLOUDSTACK-7748: Cloudstack version number is missing in system vm template.

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26871/#review57549
---

Ship it!


- Kishan Kavala


On Oct. 17, 2014, 11 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26871/
> ---
> 
> (Updated Oct. 17, 2014, 11 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7748
> https://issues.apache.org/jira/browse/CLOUDSTACK-7748
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-7748: Cloudstack version number is missing in system vm template.
> /etc/cloudstack-release in system vm does not have version number which 
> leads in vm deployment failure while checking router version
> 
> 
> During the system vm build, arguments can be passed to build.sh script 
> where 'version' argument is one of the optional arguments. The bug is even if 
> version argument is not passed defalut value(CLOUDSTACK_RELEASE=4.4.0) is 
> overridden by the null value (since argument is not passed).
> 
> 
> Diffs
> -
> 
>   tools/appliance/build.sh 8bf78b1 
> 
> Diff: https://reviews.apache.org/r/26871/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 26738: listVMSnapshot API is not returning parent id in response

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26738/#review56881
---


Commit 7fe3c45142172e003fda340f779567f73525ffd8

- Kishan Kavala


On Oct. 15, 2014, 4:58 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26738/
> ---
> 
> (Updated Oct. 15, 2014, 4:58 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7729
> https://issues.apache.org/jira/browse/CLOUDSTACK-7729
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Currently listVMSnapshot API is not returning parent id in response if parent 
> exists for a given snapshot (It displays only parent Name).
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/VMSnapshotResponse.java 168c548 
>   server/src/com/cloud/api/ApiResponseHelper.java 50376d2 
> 
> Diff: https://reviews.apache.org/r/26738/diff/
> 
> 
> Testing
> ---
> 
> Tested on latest Master with XenServer Hypervisor.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 26738: listVMSnapshot API is not returning parent id in response

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26738/#review56685
---

Ship it!


- Kishan Kavala


On Oct. 15, 2014, 4:58 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26738/
> ---
> 
> (Updated Oct. 15, 2014, 4:58 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7729
> https://issues.apache.org/jira/browse/CLOUDSTACK-7729
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Currently listVMSnapshot API is not returning parent id in response if parent 
> exists for a given snapshot (It displays only parent Name).
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/VMSnapshotResponse.java 168c548 
>   server/src/com/cloud/api/ApiResponseHelper.java 50376d2 
> 
> Diff: https://reviews.apache.org/r/26738/diff/
> 
> 
> Testing
> ---
> 
> Tested on latest Master with XenServer Hypervisor.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26168/#review56384
---

Ship it!


Commit 50185b7c3a1fd26e9a8635c28cee70fda32d3fc5

- Kishan Kavala


On Oct. 9, 2014, 11:56 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26168/
> ---
> 
> (Updated Oct. 9, 2014, 11:56 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-7648
> https://issues.apache.org/jira/browse/CLOUDSTACK-7648
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> There are new VM State Machine changes introduced while adding VM Sync 
> changes and these were missed to capture the usage events. 
> 
> This is causing to get wrong usage statistics for a VM who's state is changed 
> by VM sync
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachine.java 34387eb 
>   engine/components-api/src/com/cloud/network/NetworkStateListener.java 
> c86f782 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java
>  92163ea 
>   
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
>  c998e3b 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19 
>   server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 968c538 
>   server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746 
>   server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6 
>   server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48 
>   server/src/com/cloud/vm/UserVmStateListener.java a0088b8 
>   server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 
> 8e606ca 
>   utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645 
>   utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb 
> 
> Diff: https://reviews.apache.org/r/26168/diff/
> 
> 
> Testing
> ---
> 
> Tested on Simulator for all VM Lifecycle states and tested with Xenserver for 
> VM Sync reatled actions. 
> 
> Ran Simulator for VM lifecycle realted tests.
> 
> Currenly there is no API call listUsageEvents to verify that events are 
> generated.
> 
> Ran Simulator and used smoke tests against simulator to test it.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 26356: [RHEL7] management server failed to start once machine is rebooted

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26356/#review55638
---

Ship it!


commit e8f1c592120707ac214d535a6637fa7dc5826289

- Kishan Kavala


On Oct. 6, 2014, 3:15 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26356/
> ---
> 
> (Updated Oct. 6, 2014, 3:15 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-7671
> https://issues.apache.org/jira/browse/CLOUDSTACK-7671
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> After you install management server on rhel 7 and start the server. Now try 
> to reboot the machine and start management server then it will fail to start 
> as pid file is not able to create as cloud user.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 7306d1f 
>   packaging/centos63/default/macros.spec f3c937c 
>   packaging/centos63/rhel7/cloudstack-management.conf PRE-CREATION 
>   packaging/centos63/rhel7/macros.spec 4b71092 
> 
> Diff: https://reviews.apache.org/r/26356/diff/
> 
> 
> Testing
> ---
> 
> Tested on RHEL-7 and RHEL 6.2 servers.
> 
> Installed and re booted the machines..
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 25768: changing value of cpu/mem.overprovisioning.factor for xen cluster is not affecting total memory at zone level

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25768/#review54407
---

Ship it!


Commit 476733cb92634c8494fe64762d7fbc178292a754

- Kishan Kavala


On Sept. 18, 2014, 10:40 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25768/
> ---
> 
> (Updated Sept. 18, 2014, 10:40 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7571
> https://issues.apache.org/jira/browse/CLOUDSTACK-7571
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-7571
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java 9cae045 
> 
> Diff: https://reviews.apache.org/r/25768/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 25530: CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when enable.ha.storage.migration is false

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25530/#review54405
---

Ship it!


Ship It!

- Kishan Kavala


On Sept. 11, 2014, 11:12 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25530/
> ---
> 
> (Updated Sept. 11, 2014, 11:12 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7534
> https://issues.apache.org/jira/browse/CLOUDSTACK-7534
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
>CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when 
> enable.ha.storage.migration is false
> 
> Separate global config to enable/disable Storage Migration during normal 
> deployment
> Introduced a configuration parameter named enable.storage.migration
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  afc6f63 
>   server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 310f361 
> 
> Diff: https://reviews.apache.org/r/25530/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 25530: CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when enable.ha.storage.migration is false

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25530/#review54406
---


commit c55bc0b2d11be4820a24af426e23da3db54a0cb1

- Kishan Kavala


On Sept. 11, 2014, 11:12 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25530/
> ---
> 
> (Updated Sept. 11, 2014, 11:12 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7534
> https://issues.apache.org/jira/browse/CLOUDSTACK-7534
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
>CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when 
> enable.ha.storage.migration is false
> 
> Separate global config to enable/disable Storage Migration during normal 
> deployment
> Introduced a configuration parameter named enable.storage.migration
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
>  afc6f63 
>   server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 310f361 
> 
> Diff: https://reviews.apache.org/r/25530/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 25228: hitting java.lang.reflect.InvocationTargetException while starting usage server

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25228/#review52018
---

Ship it!


commit 51e0488e5c07595219142fb2f954726f72e0adf2

- Kishan Kavala


On Sept. 2, 2014, 9:38 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25228/
> ---
> 
> (Updated Sept. 2, 2014, 9:38 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7316
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7316
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Usage server is failing to start when we install Usage server on the 
> management server with DB encryption enabled. Usage is server is unable to 
> get "key" file from the classpath. 
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 790f57b 
> 
> Diff: https://reviews.apache.org/r/25228/diff/
> 
> 
> Testing
> ---
> 
> Tested on centos 6.3 and rhel 7
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 24229: upgrade system templates in 4.4.x

[Kishan Kavala]

> On Aug. 5, 2014, 4:12 p.m., Kishan Kavala wrote:
> > Daan,
> >  This looks good to me.
> > Can you also please remove template upgrade code in Upgrade421to430.java. 
> > Otherwise upgrades from 4.2 will fail complaining that 
> > systemvm-xenserver-4.3 is not available.

I mean systemvm--4.3 template, not just xen


- Kishan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24229/#review49584
---


On Aug. 4, 2014, 5:53 p.m., daan Hoogland wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24229/
> ---
> 
> (Updated Aug. 4, 2014, 5:53 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> upgrade code for templates in 4.4.x due to java upgrade
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade440to441.java 497da8d 
> 
> Diff: https://reviews.apache.org/r/24229/diff/
> 
> 
> Testing
> ---
> 
> sugestions welcome
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

Re: Review Request 24229: upgrade system templates in 4.4.x

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24229/#review49584
---


Daan,
 This looks good to me.
Can you also please remove template upgrade code in Upgrade421to430.java. 
Otherwise upgrades from 4.2 will fail complaining that systemvm-xenserver-4.3 
is not available.

- Kishan Kavala


On Aug. 4, 2014, 5:53 p.m., daan Hoogland wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24229/
> ---
> 
> (Updated Aug. 4, 2014, 5:53 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> upgrade code for templates in 4.4.x due to java upgrade
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade440to441.java 497da8d 
> 
> Diff: https://reviews.apache.org/r/24229/diff/
> 
> 
> Testing
> ---
> 
> sugestions welcome
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

SSL keystore file name

[Kishan Kavala]

SSl keystore was changed from cloud.keystore to cloudmanagementserver.keystore 
with below commit [1]. Later, related code change were over-written in commit 
[2]. I made changes [3] to keep keystore filename as 
cloudmanagementserver.keystore in all references. 
Please let me know if you see any issues.

[1] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=57ba367f3c985e80ea1b34267e298b481a353298
[2] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=2774b62d64989bddc1e4664ef7a93dff11c77657
[3] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=c61c636ce8a1d74fd22d89026d40ba904fff6cf8

Re: Review Request 23808: listCapacity API missing types for certain zones

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23808/#review48641
---

Ship it!


commit da55aff64f1b8255daa7999b91672bd2195bb76b


- Kishan Kavala


On July 22, 2014, 6:54 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23808/
> ---
> 
> (Updated July 22, 2014, 6:54 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7158
> https://issues.apache.org/jira/browse/CLOUDSTACK-7158
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> listCapacity API missing types for certain zones
> https://issues.apache.org/jira/browse/CLOUDSTACK-7158
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java b7784f2 
>   server/src/com/cloud/server/ManagementServerImpl.java 99b12732 
> 
> Diff: https://reviews.apache.org/r/23808/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23617/#review48472
---

Ship it!


- Kishan Kavala


On July 22, 2014, 6:05 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23617/
> ---
> 
> (Updated July 22, 2014, 6:05 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Putting the create event into event bus for addNicToVirutalMachine command 
> explicitly as we can not use BaseAsyncCreateCommand.We can not extend this 
> with BaseAsyncCreateCmd due to the checks we do before creating the nic.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 411f620 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 90f37ef 
> 
> Diff: https://reviews.apache.org/r/23617/diff/
> 
> 
> Testing
> ---
> 
> Tested against the following setup:
> 
> 1. XenServer 6.2
> 2. Master Branch
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 23603: Fixed CLOUDSTACK-6983: unable to register lxc template

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23603/#review48212
---

Ship it!


Ship It!

- Kishan Kavala


On July 21, 2014, 3:23 p.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23603/
> ---
> 
> (Updated July 21, 2014, 3:23 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Marcus Sorensen.
> 
> 
> Bugs: CLOUDSTACK-6983
> https://issues.apache.org/jira/browse/CLOUDSTACK-6983
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added a check for tar.gz format in checktemplate
> 
> 
> Diffs
> -
> 
>   utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java bad94de 
> 
> Diff: https://reviews.apache.org/r/23603/diff/
> 
> 
> Testing
> ---
> 
> manually tested register template on lxc
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 23603: Fixed CLOUDSTACK-6983: unable to register lxc template

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23603/#review48201
---



utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java
<https://reviews.apache.org/r/23603/#comment84556>

You can add isCorrectExtension check for tar file type


- Kishan Kavala


On July 17, 2014, 11:56 a.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23603/
> ---
> 
> (Updated July 17, 2014, 11:56 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Marcus Sorensen.
> 
> 
> Bugs: CLOUDSTACK-6983
> https://issues.apache.org/jira/browse/CLOUDSTACK-6983
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added a check for tar.gz format in checktemplate
> 
> 
> Diffs
> -
> 
>   utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java bad94de 
> 
> Diff: https://reviews.apache.org/r/23603/diff/
> 
> 
> Testing
> ---
> 
> manually tested register template on lxc
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 23547: CLOUDSTACK-7113: Ability to reset password when Router VM is stopped

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23547/#review48112
---

Ship it!


Ship It!

- Kishan Kavala


On July 16, 2014, 3:36 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23547/
> ---
> 
> (Updated July 16, 2014, 3:36 p.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7113
> https://issues.apache.org/jira/browse/CLOUDSTACK-7113
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-7113: Ability to reset password when Router VM is stopped 
> With this improvement password reset also happens when router is in stopped 
> state on resetPasswordCmd and restoreVM
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/network/element/VirtualRouterElement.java 3b3cacd 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dac4acf 
> 
> Diff: https://reviews.apache.org/r/23547/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

Alex,
@Encrypt will both encrypt and decrypt. In dev setup, encryption is disabled by 
default. db.cloud.encryption.type is set to none in db.properties.
For encryption to work, you need to do the following:

1.  Set db.cloud.encryption.type=file in db.properties

2.  Set db.cloud.encrypt.secret= in db.properties

3.  Set MS secret key. $cat  > /etc/cloudstack/management/key

4.  Deploy DB


From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Friday, 27 June 2014 5:12 PM
To: Kishan Kavala
Cc: Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram Ganesh; 
Animesh Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Kishan,

1. Why Long instead of Integer : You replied that it should be Integer
2. @Encrypt : Does it both encrypt & decrypt? Is there anything necessary to 
make it work because it doesn't seem to work when I trace the persist.

Thanks
Alex Ough

On Fri, Jun 27, 2014 at 7:39 AM, Kishan Kavala 
mailto:kishan.kav...@citrix.com>> wrote:
Alex,
Are the questions on review board?

From: Alex Ough [mailto:alex.o...@sungardas.com<mailto:alex.o...@sungardas.com>]
Sent: Friday, 27 June 2014 12:03 AM
To: Alena Prokharchyk
Cc: Kishan Kavala; dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>; 
Murali Reddy; Ram Ganesh; Animesh Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Alena,

It has been reduced almost twice because a lot has been separated from the CS 
and moved to the plug-in not because they are 'unnecessary'. Please remember 
that my initial implementation was inside the CS not as a plug-in as I said in 
the previous email.

Of course, I asked and urged the review repeatedly and you'll see the all the 
histories of them if you find emails using this subject, which started 10/17/13.
[DISCUSS] Domain-Account-User Sync Up Among Multiple Regions
Even if I asked so many times, unfortunately, I couldn't get an actual feedback 
until Daan finally asked Chiradeep and you to review them, which is 3/10/14.

Kishan,
I posted 2 questions, so please guide me for the questions.

Thanks
Alex Ough


On Thu, Jun 26, 2014 at 12:57 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex,

By “huge” I’ve meant that there was a lot of repetitive hardcoded things, lot 
of unnecessary changes to the CS orchestration layer. If you compare a number 
of changes now and originally, you can see that it reduced almost twice.

But lets discuss the complains about lack of initial review as its more 
important question.

Review of the design spec should happen before you start designing/coding. As I 
jumped on review much later, after you’ve submitted the entire plugin code, so 
I I didn’t participate in “Feature Request” discussion review that might have 
happened earlier. And I do assume that the reviews/emails exchanges were done 
at that initial phase? You should have contacted the people participating in 
the initial phase, and ask them for the review as well.

As a part of my review, I’ve made sure to cover the things I’m certain should 
have been changed. I’ve reviewed the feature logic as well, consulting the FS 
you’ve written. I’m not saying that there is anything wrong with your initial 
design, but asking for a second opinion from the guys who have more expertise 
in Regions.

Kishan, please help to do the final review the Alex’s plugin design 
https://reviews.apache.org/r/17790

Thank you,
Alena.
From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 25, 2014 at 9:03 PM

To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: Kishan Kavala mailto:kishan.kav...@citrix.com>>, 
"dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Alena,

I understand that you have been helping a lot to make my codes to match the 
coding standards, but I'm not sure what you mean by "the code base was 
unnecessary huge".
The initial implementation was to support the synchronization inside the CS 
because this feature is missing in the current multiple region support, and 
most of jobs were  to separate the implementation from the CS because you guys 
wanted me to provide it as a plugin.

And I kept asking reviews for the design spec from when I published the 
documents with initial prototype, it took a while for you to start to review my 
implementation and they have been mostly about the coding standards instead of 
the logic itself. So I'm saying that it would have been better if there has 
been someone 

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

Alex,
Are the questions on review board?

From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Friday, 27 June 2014 12:03 AM
To: Alena Prokharchyk
Cc: Kishan Kavala; dev@cloudstack.apache.org; Murali Reddy; Ram Ganesh; Animesh 
Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Alena,

It has been reduced almost twice because a lot has been separated from the CS 
and moved to the plug-in not because they are 'unnecessary'. Please remember 
that my initial implementation was inside the CS not as a plug-in as I said in 
the previous email.

Of course, I asked and urged the review repeatedly and you'll see the all the 
histories of them if you find emails using this subject, which started 10/17/13.
[DISCUSS] Domain-Account-User Sync Up Among Multiple Regions
Even if I asked so many times, unfortunately, I couldn't get an actual feedback 
until Daan finally asked Chiradeep and you to review them, which is 3/10/14.

Kishan,
I posted 2 questions, so please guide me for the questions.

Thanks
Alex Ough


On Thu, Jun 26, 2014 at 12:57 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex,

By “huge” I’ve meant that there was a lot of repetitive hardcoded things, lot 
of unnecessary changes to the CS orchestration layer. If you compare a number 
of changes now and originally, you can see that it reduced almost twice.

But lets discuss the complains about lack of initial review as its more 
important question.

Review of the design spec should happen before you start designing/coding. As I 
jumped on review much later, after you’ve submitted the entire plugin code, so 
I I didn’t participate in “Feature Request” discussion review that might have 
happened earlier. And I do assume that the reviews/emails exchanges were done 
at that initial phase? You should have contacted the people participating in 
the initial phase, and ask them for the review as well.

As a part of my review, I’ve made sure to cover the things I’m certain should 
have been changed. I’ve reviewed the feature logic as well, consulting the FS 
you’ve written. I’m not saying that there is anything wrong with your initial 
design, but asking for a second opinion from the guys who have more expertise 
in Regions.

Kishan, please help to do the final review the Alex’s plugin design 
https://reviews.apache.org/r/17790

Thank you,
Alena.
From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 25, 2014 at 9:03 PM

To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: Kishan Kavala mailto:kishan.kav...@citrix.com>>, 
"dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Alena,

I understand that you have been helping a lot to make my codes to match the 
coding standards, but I'm not sure what you mean by "the code base was 
unnecessary huge".
The initial implementation was to support the synchronization inside the CS 
because this feature is missing in the current multiple region support, and 
most of jobs were  to separate the implementation from the CS because you guys 
wanted me to provide it as a plugin.

And I kept asking reviews for the design spec from when I published the 
documents with initial prototype, it took a while for you to start to review my 
implementation and they have been mostly about the coding standards instead of 
the logic itself. So I'm saying that it would have been better if there has 
been someone to review the design spec and the prototype from the initial phase.

Again, I really appreciate your help to come this far, but it was also very 
painful for me.
Thanks
Alex Ough

On Wed, Jun 25, 2014 at 10:41 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex,

In the beginning the code was not very well organazied, didn't match coding 
standarts (no use of spring, misleading names, not segregated to its own 
plugin), and the code base was unneccessary huge.
All of the above it very hard to review and understand the code logic from the 
beginning and engage more people to the review. Therefore Chiradeep pointed it 
in his original review that the code needs to match CS standarts first, and be 
better organized. I helped to review the fixes, and did logic review as well 
after the code came into “reviewable” shape.

I'm asking Kishan/Murali to look at it to see if anything is missing or 
incorrect in the final review, not to make you override or change everything 
you've already put in.

Thank you,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Wednesday, June 

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

Alex, 
You are correct. It should be Integer and not Long.

> -Original Message-
> From: Alex Ough [mailto:alex.o...@sungardas.com]
> Sent: Thursday, 26 June 2014 8:09 PM
> To: Kishan Kavala
> Cc: cloudstack
> Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among
> Multiple Regions (Core Changes)
> 
> Kishan,
> 
> The type of region id is Integer, not Long, so I'm wondering why it should be
> Long.
> 
> Alex Ough
> 
> 
> 
> On Thu, Jun 26, 2014 at 2:08 AM, Kishan Kavala 
> wrote:
> 
> >This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/20099/
> >
> > Alex,
> >  As discussed on the mailing list, ORIGINATEDREGIONUUID should be the
> regionId which is Long. So all the ORIGINATEDREGIONUUID references should
> just be ORIGINATEDREGIONID and of datatype Long.
> >
> >
> > - Kishan Kavala
> >
> > On June 24th, 2014, 9:24 p.m. IST, Alex Ough wrote:
> >   Review request for cloudstack.
> > By Alex Ough.
> >
> > *Updated June 24, 2014, 9:24 p.m.*
> >  *Repository: * cloudstack-git
> > Description
> >
> > This is the review request for the core changes related with #17790 that has
> only the new plugin codes.
> >
> >   Testing
> >
> > 1. Successfully tested real time synchronization as soon as resources are
> created/deleted/modified in one region.
> > 2. Successfully tested full scans to synchronize resources that were missed
> during real time synchronization because of any reasons like network
> connection issues.
> > 3. The tests were done manually and also automatically by randomly
> generating changes each region.
> >
> >   Diffs
> >
> >- api/src/com/cloud/event/EventTypes.java (0fa3cd5)
> >- api/src/com/cloud/user/AccountService.java (eac8a76)
> >- api/src/com/cloud/user/DomainService.java (4c1f93d)
> >- api/src/org/apache/cloudstack/api/ApiConstants.java (adda5f4)
> >- api/src/org/apache/cloudstack/api/BaseCmd.java (ac9a208)
> >-
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccount
> Cmd.java
> >(50d67d9)
> >-
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccount
> Cmd.java
> >(5754ec5)
> >-
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccount
> Cmd.java
> >(3e5e1d3)
> >-
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccount
> Cmd.java
> >(f30c985)
> >-
> api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCm
> d.java
> >(3c185e4)
> >-
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccount
> Cmd.java
> >(a7ce74a)
> >-
> api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainC
> md.java
> >(312c9ee)
> >-
> api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainC
> md.java
> >(a6d2b0b)
> >-
> api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomain
> Cmd.java
> >(409a84d)
> >-
> api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.j
> ava
> >(f6743ba)
> >-
> api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionC
> md.java
> >(b08cbbb)
> >-
> api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.jav
> a
> >(8f223ac)
> >-
> api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.jav
> a
> >(08ba521)
> >-
> api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.ja
> va
> >(c6e09ef)
> >-
> api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.jav
> a
> >(d69eccf)
> >-
> api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java
> >(69623d0)
> >-
> api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java
> >(2090d21)
> >-
> api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.ja
> va
> >(f21e264)
> >- api/src/org/apache/cloudstack/api/response/RegionResponse.java
> >(6c74fa6)
> >- api/src/org/apache/cloudstack/region/Region.java (df64e44)
> >- api/src/org/apache/cloudstack/region/RegionService.java (afefcc7)
> >- api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java
> >(10c3d85)
> >- client/pom.xml (29fef4f)
> >- engine/schema/resources/META-INF/cloudstack/core/spring-engine-
> schema-core-daos-context.xml
> >(2ef0d20)
> > 

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46720
---



engine/schema/src/org/apache/cloudstack/region/RegionVO.java
<https://reviews.apache.org/r/20099/#comment82279>

You can use @Encrypt annotation to encrypt and decrypt password. Framework 
will do the encryption instead of doing md5hash while persisting. You can refer 
to VpnUserVO.java to see an example.


- Kishan Kavala


On June 24, 2014, 9:24 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 24, 2014, 9:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 0fa3cd5 
>   api/src/com/cloud/user/AccountService.java eac8a76 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 
>   api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 8f223ac 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> f21e264 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml 29fef4f 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  2ef0d20 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  4136b5c 
>   plugins/pom.xml b5e6a61 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  b753952 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  6f7be90 
>   server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 
>   server/src/com/cloud/event/ActionEventUtils.java 2b3cfea 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManager.java 194c5d2 
>   server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 
>   server/src/com/cloud/user/DomainManager.java f72b18a 
>   server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
>   server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
>   server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 
>   server/

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46719
---


Alex,
 As discussed on the mailing list, ORIGINATEDREGIONUUID should be the regionId 
which is Long. So all the ORIGINATEDREGIONUUID references should just be 
ORIGINATEDREGIONID and of datatype Long. 

- Kishan Kavala


On June 24, 2014, 9:24 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 24, 2014, 9:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 0fa3cd5 
>   api/src/com/cloud/user/AccountService.java eac8a76 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 
>   api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 8f223ac 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> f21e264 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml 29fef4f 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  2ef0d20 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  4136b5c 
>   plugins/pom.xml b5e6a61 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  b753952 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  6f7be90 
>   server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 
>   server/src/com/cloud/event/ActionEventUtils.java 2b3cfea 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManager.java 194c5d2 
>   server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 
>   server/src/com/cloud/user/DomainManager.java f72b18a 
>   server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
>   server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
>   server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 
>   server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 
>   server/test/com/cloud/user/AccountManagerImpl

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review46718
---


Alex,
 As discussed on the mailing list, ORIGINATEDREGIONUUID should be the regionId 
which is Long. So all the ORIGINATEDREGIONUUID references should just be 
ORIGINATEDREGIONID and of datatype Long. 

- Kishan Kavala


On June 24, 2014, 9:24 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated June 24, 2014, 9:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 0fa3cd5 
>   api/src/com/cloud/user/AccountService.java eac8a76 
>   api/src/com/cloud/user/DomainService.java 4c1f93d 
>   api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 
>   api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> 50d67d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 5754ec5 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  3e5e1d3 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> f30c985 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 3c185e4 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a7ce74a 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 312c9ee 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> a6d2b0b 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 409a84d 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
> 8f223ac 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
> 08ba521 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
> c6e09ef 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
> d69eccf 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 
> 69623d0 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 
> 2090d21 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> f21e264 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml 29fef4f 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  2ef0d20 
>   engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  4136b5c 
>   plugins/pom.xml b5e6a61 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
>  b753952 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  6f7be90 
>   server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 
>   server/src/com/cloud/event/ActionEventUtils.java 2b3cfea 
>   server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
>   server/src/com/cloud/user/AccountManager.java 194c5d2 
>   server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 
>   server/src/com/cloud/user/DomainManager.java f72b18a 
>   server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
>   server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
>   server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 
>   server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 
>   server/test/com/cloud/user/AccountManagerImpl

Re: Review Request 22721: removed hard coded jdk_dirs in cloud-usage script

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22721/#review46630
---

Ship it!


Commit c468228fe807c621decc5919dadae9bcbb38c753

- Kishan Kavala


On June 18, 2014, 3:45 p.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22721/
> ---
> 
> (Updated June 18, 2014, 3:45 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-6926
> https://issues.apache.org/jira/browse/CLOUDSTACK-6926
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> used to readlink -e and dirname to get the JAVA_HOME
> if JAVA_HOME is not already defined, sets it to jdk home if javac is present 
> else jre home if java is present.
> if nothing is present, it exits with error
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud-usage.rc 6170379 
>   packaging/debian/init/cloud-usage 1cc75cc 
> 
> Diff: https://reviews.apache.org/r/22721/diff/
> 
> 
> Testing
> ---
> 
> 
> tested it when java is not installed, jre is installed, jdk installed or when 
> a older version is installed on centos 6.4 and ubuntu 14.04 
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

Alex,
You can refer to the code from initDataSource  method in Transaction.java.
Properties file can be loaded using the following:

File dbPropsFile = PropertiesUtil.findConfigFile(propsFileName);

From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 4:31 PM
To: Kishan Kavala
Cc: Alena Prokharchyk; dev@cloudstack.apache.org; Murali Reddy; Ram Ganesh; 
Animesh Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

Thanks Kishan, but there seems to be lots of 'db.properties' files, so which 
one should be referenced?

Alex Ough

On Wed, Jun 25, 2014 at 2:25 AM, Kishan Kavala 
mailto:kishan.kav...@citrix.com>> wrote:
Alex,
As Alena mentioned, it is admin’s responsibility to keep ids same across 
Regions. Ids should be used as unique identifier. Region name is merely 
descriptive name and its mostly associated with geographic location.
Also note that region name can be updated anytime using updateRegion API.

Unlike, other internal Ids in CS, region Ids are assigned by admin. So exposing 
region Id to admin should not be an issue.

Id of the local region cannot be guaranteed to be “1” always. Region Id has to 
be unique across all regions. While creating new region admin will provide 
unique region id to cloud-setup-databases script. Id of the local region is 
stored in db.properties. To identify a Local region you can use one of the 
following options:

1.   Look up region.id<http://region.id> in db.properties

2.   Add a new column in region table


From: Alex Ough [mailto:alex.o...@sungardas.com<mailto:alex.o...@sungardas.com>]
Sent: Wednesday, 25 June 2014 8:18 AM
To: Alena Prokharchyk
Cc: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>; Kishan Kavala; 
Murali Reddy; Ram Ganesh; Animesh Chaturvedi

Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

There is one thing that was not mentioned, which is that currently the id of 
'Local' region is always 1 and if we do not guarantee that, there is no way to 
find out which is the local region unless we add one more field to tells which 
is the local region.
I'm wondering if we have a solution for this now.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 9:59 PM, Alex Ough 
mailto:alex.o...@sungardas.com>> wrote:
I agree with that the ids are unique identifier, but they are usually internal 
purpose not exposed to the users. So it is a little strange to ask users to 
assign ids when they add new regions. And if we do not allow duplicated names, 
I'm not sure why it is not good to use names as a unique identifier.

It's been a long way to come this far with several reasons, so I really want to 
wrap this up as soon as possible, and this doesn't seem to be a major obstacle, 
so let me just use 'id' as a parameter if there is no one with a different 
thought until tomorrow morning.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, id is used as a unique identifier for CS objects. And it is the CS 
requirement to refer to the object by id if the id is present. Look at all the 
other APIs. We nowhere refer to the network/vpc/vm by name just because its 
more human readable. The id is used by Api layer when parameter validation is 
done, by lots of Dao methods (findById is one of them), etc.  Even look at 
updateRegion/deleteRegion – we don’t refer to them by name, but by the id.

The reason why Kishan added the support for controlling the id by adding it to 
the createRegion call (and making it unique) is exactly that – region 
administrator can decide what id to set on the region, and to introduce the 
region with the same id to the other regions’ db.

So I would still suggest on using the id of the region in the API calls you are 
modifying. Unless developers who worked on regions feature – Kishan/Murali – 
come up with the valid objection.

Thanks,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 5:41 PM

To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>, Kishan Kavala 
mailto:kishan.kav...@citrix.com>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

We can use the same ids & names, but we don't have to use the same ids if we 
use names, which is a little easier because names are user readable but ids are 
not, so we don't need to memorize/check all the ids when we add new regions in 
multiple regions, which can be confusing.

Thanks

RE: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Kishan Kavala]

Alex,
As Alena mentioned, it is admin’s responsibility to keep ids same across 
Regions. Ids should be used as unique identifier. Region name is merely 
descriptive name and its mostly associated with geographic location.
Also note that region name can be updated anytime using updateRegion API.

Unlike, other internal Ids in CS, region Ids are assigned by admin. So exposing 
region Id to admin should not be an issue.

Id of the local region cannot be guaranteed to be “1” always. Region Id has to 
be unique across all regions. While creating new region admin will provide 
unique region id to cloud-setup-databases script. Id of the local region is 
stored in db.properties. To identify a Local region you can use one of the 
following options:

1.   Look up region.id in db.properties

2.   Add a new column in region table


From: Alex Ough [mailto:alex.o...@sungardas.com]
Sent: Wednesday, 25 June 2014 8:18 AM
To: Alena Prokharchyk
Cc: dev@cloudstack.apache.org; Kishan Kavala; Murali Reddy; Ram Ganesh; Animesh 
Chaturvedi
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

There is one thing that was not mentioned, which is that currently the id of 
'Local' region is always 1 and if we do not guarantee that, there is no way to 
find out which is the local region unless we add one more field to tells which 
is the local region.
I'm wondering if we have a solution for this now.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 9:59 PM, Alex Ough 
mailto:alex.o...@sungardas.com>> wrote:
I agree with that the ids are unique identifier, but they are usually internal 
purpose not exposed to the users. So it is a little strange to ask users to 
assign ids when they add new regions. And if we do not allow duplicated names, 
I'm not sure why it is not good to use names as a unique identifier.

It's been a long way to come this far with several reasons, so I really want to 
wrap this up as soon as possible, and this doesn't seem to be a major obstacle, 
so let me just use 'id' as a parameter if there is no one with a different 
thought until tomorrow morning.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 8:52 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Alex, id is used as a unique identifier for CS objects. And it is the CS 
requirement to refer to the object by id if the id is present. Look at all the 
other APIs. We nowhere refer to the network/vpc/vm by name just because its 
more human readable. The id is used by Api layer when parameter validation is 
done, by lots of Dao methods (findById is one of them), etc.  Even look at 
updateRegion/deleteRegion – we don’t refer to them by name, but by the id.

The reason why Kishan added the support for controlling the id by adding it to 
the createRegion call (and making it unique) is exactly that – region 
administrator can decide what id to set on the region, and to introduce the 
region with the same id to the other regions’ db.

So I would still suggest on using the id of the region in the API calls you are 
modifying. Unless developers who worked on regions feature – Kishan/Murali – 
come up with the valid objection.

Thanks,
Alena.

From: Alex Ough mailto:alex.o...@sungardas.com>>
Date: Tuesday, June 24, 2014 at 5:41 PM

To: Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>>
Cc: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" 
mailto:dev@cloudstack.apache.org>>, Kishan Kavala 
mailto:kishan.kav...@citrix.com>>, Murali Reddy 
mailto:murali.re...@citrix.com>>, Ram Ganesh 
mailto:ram.gan...@citrix.com>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple 
Regions (Core Changes)

We can use the same ids & names, but we don't have to use the same ids if we 
use names, which is a little easier because names are user readable but ids are 
not, so we don't need to memorize/check all the ids when we add new regions in 
multiple regions, which can be confusing.

Thanks
Alex Ough

On Tue, Jun 24, 2014 at 8:33 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:
Aren’t we supposed to sync the regions across the multiple regions Dbs? Because 
that’s what region FS states:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/AWS-Style+Regions+Functional+Spec,
 “Adding 2nd region” paragraph, bullet #4:


1. Install a 2nd CS instance.

2. While installing database set region_id using -r option in 
cloud-setup-databases script (Make sure database_key is same across all 
regions).

cloud-setup-databases cloud:@localhost --deploy-as=root: 
-e  -m  -k  -r 

3. Start mgmt server

4. Using addRegion API, add region 1 to region 2 and also region 2 to region 1.



I assume that we expect the admin to add the region with the same name and the 
same id to ALL regions Dbs (

RE: KVM + LXC on the same host

[Kishan Kavala]

KVM system vms on the same host as LXC containers is already supported.
Below proposal was to support userVms in a similar way.

> -Original Message-
> From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
> Sent: Wednesday, 11 June 2014 5:57 AM
> To: dev@cloudstack.apache.org
> Subject: Re: KVM + LXC on the same host
> 
> I thought the LXC 2.0 project uses KVM system vms on the same host as LXC
> containers?
> https://cwiki.apache.org/confluence/x/oJNMAg
> 
> From: Kishan Kavala
> mailto:kishan.kav...@citrix.com>>
> Reply-To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
> mailto:dev@cloudstack.apache.org>>
> Date: Sunday, June 8, 2014 at 11:59 PM
> To: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
> mailto:dev@cloudstack.apache.org>>
> Subject: RE: KVM + LXC on the same host
> 
> 
> 
> -Original Message-
> From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
> Sent: Saturday, 7 June 2014 1:50 AM
> To: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>
> Subject: Re: KVM + LXC on the same host
> Tuna
> Thanks for the feedback, conceptually, i was not trying to address the issue 
> of
> sysvms not running on LXC.
> Here is the use case as i see it.
> Assume you roll out a farm of  10 KVM servers and your density with KVM is
> 200 virtual machines. Most of these VMs dont require independent kernel
> and additional layers of virtualization abstraction. As the result, you can 
> place
> 400 LXC machines and 20 fully virtualized Linux or even Windows Servers. If
> you do chargeback, you can offer the LXC machines for much lower price point
> since we can place more LXC containers.
> Your density becomes much greater with LXC and yet you still cover the
> corner case when end-user needs KVM instance.
> Pierre-Luc
> If I will get to try this scenario - i may have to alter the KVM/LXC agent
> somewhat to make it work with CloudStack, i will let you know.
> Ilya,
> Some minor changes to KVM/LXC agent will be required to make this work.
> Below piece of code in createVMFromSpec (LibvirtComputingResource),
> deploys systems Vms in KVM and user Vms in LXC.
> If we include some flag in VirtualMachineTO, it should be possible to specify
> which userVm has to be deployed (KVM/LXC).
> 
> if (HypervisorType.LXC == _hypervisorType && VirtualMachine.Type.User
> == vmTO.getType()) {
> // LXC domain is only valid for user VMs. Use KVM for system VMs.
> guest.setGuestType(GuestDef.guestType.LXC);
> vm.setHvsType(HypervisorType.LXC.toString().toLowerCase());
> } else {
> guest.setGuestType(GuestDef.guestType.KVM);
> vm.setHvsType(HypervisorType.KVM.toString().toLowerCase());
> vm.setLibvirtVersion(_hypervisorLibvirtVersion);
> vm.setQemuVersion(_hypervisorQemuVersion);
> }
> 
> 
> 
> Alternative solution would be to run separate LXC and KVM clusters, which is
> also a possibility - but usage and distribution will be uneven.
> Regards
> ilya
> The concept of combining both technologies under one hypervisor On 6/6/14,
> 8:42 AM, Pierre-Luc Dion wrote:
> > ilya,
> >
> > Let us know how it goes your hybrid of LXC+KVM. I'm interested to know
> > how it's going,  I might try that too on the side.
> >
> >
> >
> >
> > Pierre-Luc Dion
> > Architecte de Solution Cloud | Cloud Solutions Architect 855-OK-CLOUD
> > (855-652-5683) x1101
> > - - -
> >
> > *CloudOps*420 rue Guy
> > Montréal QC  H3J 1S6
> > www.cloudops.com
> > @CloudOps_
> >
> >
> > On Fri, Jun 6, 2014 at 10:53 AM, Nguyen Anh Tu
> mailto:t...@apache.org>> wrote:
> >
> >> That should be a good idea, Ilya. At that moment, i'm working on
> >> Docker support. When it's done, we can run only Docker hosts, no need
> >> to use KVM for hosting system vms.
> >>
> >> Cheers,
> >> --Tuna
> >>
> >> Sent from my GT-N7000
> >> On Jun 5, 2014 7:58 AM, "ilya musayev"
> >> mailto:ilya.mailing.li...@gmail.com>>
> >> wrote:
> >>
> >>> We are considering running KVM and LXC on the same host and
> >>> hopefully control both through cloudstack.
> >>>
> >>> I know there are agents involved for each component, i dont know if
> >>> we
> >> can
> >>> have a hybrid of LXC+KVM.
> >>>
> >>> The use case is simple, we would like the end user to pick
> >>> LXC/Docker for performance, or KVM instance if he really needed all
> >>> bells and whistles
> >> of
> >>> dedicated kernel in fully virtualized environment.
> >>>
> >>> Is anyone aware why we should not mix 2 workloads on the same host?
> >>> Is it possible at this point in time to mix LXC, KVM and CloudStack,
> >>> i assume
> >> the
> >>> answer is no, but perhaps there is a hack i can try.
> >>>
> >>> Thanks
> >>> ilya
> >>>
> 

Re: Review Request 22456: CLOUDSTACK-6869: Public key content is overridden by template's meta data when you create a instance

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22456/#review45363
---

Ship it!


Ship It!

- Kishan Kavala


On June 11, 2014, 4:35 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22456/
> ---
> 
> (Updated June 11, 2014, 4:35 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6869
> https://issues.apache.org/jira/browse/CLOUDSTACK-6869
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6869: Public key content is overridden by template's meta data 
> when you create a instance
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/template/TemplateManagerImpl.java 3ebb43a 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 14d2eef 
> 
> Diff: https://reviews.apache.org/r/22456/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

RE: KVM + LXC on the same host

[Kishan Kavala]

> -Original Message-
> From: ilya musayev [mailto:ilya.mailing.li...@gmail.com]
> Sent: Saturday, 7 June 2014 1:50 AM
> To: dev@cloudstack.apache.org
> Subject: Re: KVM + LXC on the same host
> 
> Tuna
> 
> Thanks for the feedback, conceptually, i was not trying to address the issue 
> of
> sysvms not running on LXC.
> 
> Here is the use case as i see it.
> 
> Assume you roll out a farm of  10 KVM servers and your density with KVM is
> 200 virtual machines. Most of these VMs dont require independent kernel
> and additional layers of virtualization abstraction. As the result, you can 
> place
> 400 LXC machines and 20 fully virtualized Linux or even Windows Servers. If
> you do chargeback, you can offer the LXC machines for much lower price point
> since we can place more LXC containers.
> 
> Your density becomes much greater with LXC and yet you still cover the
> corner case when end-user needs KVM instance.
> 
> Pierre-Luc
> 
> If I will get to try this scenario - i may have to alter the KVM/LXC agent
> somewhat to make it work with CloudStack, i will let you know.
Ilya, 
 Some minor changes to KVM/LXC agent will be required to make this work. Below 
piece of code in createVMFromSpec (LibvirtComputingResource), deploys systems 
Vms in KVM and user Vms in LXC.
If we include some flag in VirtualMachineTO, it should be possible to specify 
which userVm has to be deployed (KVM/LXC).

if (HypervisorType.LXC == _hypervisorType && VirtualMachine.Type.User 
== vmTO.getType()) {
// LXC domain is only valid for user VMs. Use KVM for system VMs.
guest.setGuestType(GuestDef.guestType.LXC);
vm.setHvsType(HypervisorType.LXC.toString().toLowerCase());
} else {
guest.setGuestType(GuestDef.guestType.KVM);
vm.setHvsType(HypervisorType.KVM.toString().toLowerCase());
vm.setLibvirtVersion(_hypervisorLibvirtVersion);
vm.setQemuVersion(_hypervisorQemuVersion);
}



> Alternative solution would be to run separate LXC and KVM clusters, which is
> also a possibility - but usage and distribution will be uneven.
> 
> Regards
> ilya
> 
> The concept of combining both technologies under one hypervisor On 6/6/14,
> 8:42 AM, Pierre-Luc Dion wrote:
> > ilya,
> >
> > Let us know how it goes your hybrid of LXC+KVM. I'm interested to know
> > how it's going,  I might try that too on the side.
> >
> >
> >
> >
> > Pierre-Luc Dion
> > Architecte de Solution Cloud | Cloud Solutions Architect 855-OK-CLOUD
> > (855-652-5683) x1101
> > - - -
> >
> > *CloudOps*420 rue Guy
> > Montréal QC  H3J 1S6
> > www.cloudops.com
> > @CloudOps_
> >
> >
> > On Fri, Jun 6, 2014 at 10:53 AM, Nguyen Anh Tu  wrote:
> >
> >> That should be a good idea, Ilya. At that moment, i'm working on
> >> Docker support. When it's done, we can run only Docker hosts, no need
> >> to use KVM for hosting system vms.
> >>
> >> Cheers,
> >> --Tuna
> >>
> >> Sent from my GT-N7000
> >> On Jun 5, 2014 7:58 AM, "ilya musayev" 
> >> wrote:
> >>
> >>> We are considering running KVM and LXC on the same host and
> >>> hopefully control both through cloudstack.
> >>>
> >>> I know there are agents involved for each component, i dont know if
> >>> we
> >> can
> >>> have a hybrid of LXC+KVM.
> >>>
> >>> The use case is simple, we would like the end user to pick
> >>> LXC/Docker for performance, or KVM instance if he really needed all
> >>> bells and whistles
> >> of
> >>> dedicated kernel in fully virtualized environment.
> >>>
> >>> Is anyone aware why we should not mix 2 workloads on the same host?
> >>> Is it possible at this point in time to mix LXC, KVM and CloudStack,
> >>> i assume
> >> the
> >>> answer is no, but perhaps there is a hack i can try.
> >>>
> >>> Thanks
> >>> ilya
> >>>

Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44885
---

Ship it!


Ship It!

- Kishan Kavala


On June 6, 2014, 2:58 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> ---
> 
> (Updated June 6, 2014, 2:58 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. Added fix to retrieve the correct domain id for a given accountid. 
> vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when 
> an invalid domainid is retrieved. Throw an exception in case of invalid 
> domain id.
> 3. Now, creation of tags is getting successful post the fix.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd 
>   engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed 
>   server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7 
> 
> Diff: https://reviews.apache.org/r/19874/diff/
> 
> 
> Testing
> ---
> 
> Test creation, listing and deletion tags on UserVM ... === TestName: 
> test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: 
> test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: 
> test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: 
> test_08_volume_tag | Status : SUCCESS ===
> ok
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 22075: Database Information missing in Alter table statements in a commit to schema-430to440.sql

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22075/#review44352
---

Ship it!


dbd05e3ff5015a867652d805b08965851608e577

- Kishan Kavala


On May 30, 2014, 12:11 p.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22075/
> ---
> 
> (Updated May 30, 2014, 12:11 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6808
> https://issues.apache.org/jira/browse/CLOUDSTACK-6808
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added db info to the queries
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-430to440.sql 85eb173 
> 
> Diff: https://reviews.apache.org/r/22075/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 22077: CLOUDSTACK-6669 Support volume resize in usage server

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22077/#review44351
---

Ship it!


Ship It!

- Kishan Kavala


On May 30, 2014, 12:09 p.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22077/
> ---
> 
> (Updated May 30, 2014, 12:09 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6669
> https://issues.apache.org/jira/browse/CLOUDSTACK-6669
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added support for resize volume in usage
> 
> 
> Diffs
> -
> 
>   usage/src/com/cloud/usage/UsageManagerImpl.java 4ceecbb 
> 
> Diff: https://reviews.apache.org/r/22077/diff/
> 
> 
> Testing
> ---
> 
> yes manual testing
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43948
---

Ship it!



commit ce6a53e37b982d868ae923a294cf49df5cfed27e
Author: Rajani Karuturi 
Date:   Fri May 23 15:50:06 2014 +0530

Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted 
ip range

- Kishan Kavala


On May 27, 2014, 10:15 a.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> ---
> 
> (Updated May 27, 2014, 10:15 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added removed columns for user_ip_address and vlan tables to soft delete the 
> entries.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/dc/Vlan.java ac9acda 
>   api/src/com/cloud/network/IpAddress.java f831e27 
>   engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345 
>   engine/schema/src/com/cloud/dc/VlanVO.java ff103b9 
>   engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 14e29cb 
>   setup/db/db/schema-430to440.sql 3b525c4 
> 
> Diff: https://reviews.apache.org/r/21853/diff/
> 
> 
> Testing
> ---
> 
> manually tested it.
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43946
---


Patch does not apply to master branch. Can you please submit a another patch 
for master?

- Kishan Kavala


On May 23, 2014, 3:54 p.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> ---
> 
> (Updated May 23, 2014, 3:54 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added removed columns for user_ip_address and vlan tables to soft delete the 
> entries.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/dc/Vlan.java ac9acda 
>   api/src/com/cloud/network/IpAddress.java f831e27 
>   engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345 
>   engine/schema/src/com/cloud/dc/VlanVO.java ff103b9 
>   engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3f79a76 
>   setup/db/db/schema-430to440.sql 7fa93e7 
> 
> Diff: https://reviews.apache.org/r/21853/diff/
> 
> 
> Testing
> ---
> 
> manually tested it.
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 21853: Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21853/#review43945
---

Ship it!


commit 2ab7bcade2f37cb17e071a6154fdae1d80e4ff99
Author: Rajani Karuturi 
Date:   Fri May 23 15:50:06 2014 +0530

Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted 
ip range


- Kishan Kavala


On May 23, 2014, 3:54 p.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21853/
> ---
> 
> (Updated May 23, 2014, 3:54 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6756
> https://issues.apache.org/jira/browse/CLOUDSTACK-6756
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added removed columns for user_ip_address and vlan tables to soft delete the 
> entries.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/dc/Vlan.java ac9acda 
>   api/src/com/cloud/network/IpAddress.java f831e27 
>   engine/components-api/src/com/cloud/network/addr/PublicIp.java a20e345 
>   engine/schema/src/com/cloud/dc/VlanVO.java ff103b9 
>   engine/schema/src/com/cloud/network/dao/IPAddressVO.java de2d934 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3f79a76 
>   setup/db/db/schema-430to440.sql 7fa93e7 
> 
> Diff: https://reviews.apache.org/r/21853/diff/
> 
> 
> Testing
> ---
> 
> manually tested it.
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 21196: CLOUDSTACK-6551: [Automation] Failed to revert vm snapshot in xen

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21196/#review42480
---

Ship it!


Ship It!

- Kishan Kavala


On May 8, 2014, 4:24 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21196/
> ---
> 
> (Updated May 8, 2014, 4:24 p.m.)
> 
> 
> Review request for cloudstack, anthony xu and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6551
> https://issues.apache.org/jira/browse/CLOUDSTACK-6551
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6551: [Automation] Failed to revert vm snapshot in xen 
> Added revert_memory_snapshot method to cloud-plugin-storage
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625Resource.java
>  d290194 
> 
> Diff: https://reviews.apache.org/r/21196/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 21195: CLOUDSTACK-6544: [Automation] Failed to create template for ROOT volume in Xen, with Exception: callHostPlugin failed

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21195/#review42474
---

Ship it!


17810b0e95ce6418b6809ab5d3dd436659120721

- Kishan Kavala


On May 8, 2014, 3:28 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21195/
> ---
> 
> (Updated May 8, 2014, 3:28 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6544
> https://issues.apache.org/jira/browse/CLOUDSTACK-6544
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6544: [Automation] Failed to create template for ROOT volume in 
> Xen, with Exception: callHostPlugin failed
> 
> Missing vmopsSnapshot plugin in case of XenServer 6.2 SP1
> 
> 
> Diffs
> -
> 
>   scripts/vm/hypervisor/xenserver/xenserver62/patch 13f4f93 
> 
> Diff: https://reviews.apache.org/r/21195/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 20516: CLOUDSTACK-6463: password is not set for VMs created from password enabled template

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20516/#review42127
---


commit ce3074e9a23e71855798cb5decd01d7f9958f6c0

- Kishan Kavala


On April 21, 2014, 3:01 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20516/
> ---
> 
> (Updated April 21, 2014, 3:01 p.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6463
> https://issues.apache.org/jira/browse/CLOUDSTACK-6463
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6463: password is not set for VMs created from password enabled 
> template
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java c098e85 
> 
> Diff: https://reviews.apache.org/r/20516/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 20519: CLOUDSTACK-6466: cpu and ram is not getting updated correctly in usage_vm_instance table for usage type 2

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20519/#review42126
---

Ship it!


commit 508e3e2c9b08850049a046bc5a22941e481fad5e

- Kishan Kavala


On April 21, 2014, 3:25 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20519/
> ---
> 
> (Updated April 21, 2014, 3:25 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6466
> https://issues.apache.org/jira/browse/CLOUDSTACK-6466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6466: cpu and ram is not getting updated correctly in 
> usage_vm_instance table for usage type 2
> 
> 
> Diffs
> -
> 
>   usage/src/com/cloud/usage/UsageManagerImpl.java 6ce6901 
> 
> Diff: https://reviews.apache.org/r/20519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 15349: Overprivisoning changes needed

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review42121
---

Ship it!


commit 99b4cf788eded0f6f155ff8cda51aeb2e505f764

- Kishan Kavala


On April 17, 2014, 10:01 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> ---
> 
> (Updated April 17, 2014, 10:01 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1.) This includes the change to reserve cpu and memory only when 
> vmware.reserve.cpu/mem is true, regardless of overcommit. 
> 2.) populate the default value of the cpu overcommit at cluster level form 
> the global setting when up grading. 
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 82b6d84 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java c3a6b06 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  e89777d 
>   setup/db/db/schema-420to421.sql 42e9c1e 
> 
> Diff: https://reviews.apache.org/r/15349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 20516: CLOUDSTACK-6463: password is not set for VMs created from password enabled template

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20516/#review40874
---

Ship it!


Ship It!

- Kishan Kavala


On April 21, 2014, 3:01 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20516/
> ---
> 
> (Updated April 21, 2014, 3:01 p.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6463
> https://issues.apache.org/jira/browse/CLOUDSTACK-6463
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6463: password is not set for VMs created from password enabled 
> template
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java c098e85 
> 
> Diff: https://reviews.apache.org/r/20516/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 20152: In com.cloud.utils.crypt.EncryptionSecretKeyChecker the key file paths are hard coded

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20152/#review39991
---

Ship it!


commit 1d0b14673da2b877112a4030c17496e26cf3f531
Please file a ticket to change key name cloudstack specific like.. 
cloudstack.key

- Kishan Kavala


On April 9, 2014, 6:01 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20152/
> ---
> 
> (Updated April 9, 2014, 6:01 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6354
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6354
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> In com.cloud.utils.crypt.EncryptionSecretKeyChecker the key file paths are 
> hard coded to "/etc/cloudstack/management/key" which will cause issue if key 
> generation path gets changes during installation time.
> 
> 
> Diffs
> -
> 
>   utils/src/com/cloud/utils/crypt/EncryptionSecretKeyChecker.java 0e995c4 
>   utils/test/com/cloud/utils/crypto/EncryptionSecretKeyCheckerTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20152/diff/
> 
> 
> Testing
> ---
> 
> Tested with enabling ecnryption.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 19612: Added fix for CLOUDSTACK-6269

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19612/#review38581
---

Ship it!


Ship It!

- Kishan Kavala


On March 25, 2014, 7:24 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19612/
> ---
> 
> (Updated March 25, 2014, 7:24 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added fix for the mentioned bug.More details in the bug.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java
>  27002f2 
> 
> Diff: https://reviews.apache.org/r/19612/diff/
> 
> 
> Testing
> ---
> 
> Tested and post this, issue is not observed.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

RE: cidrs in acls

[Kishan Kavala]

Daan,
 I looked at the code in acl-item-cidrs. Persisting cidrs in separate table 
looks good.
Pending items:

1. All references to NetworkACLItemVO.getSourceCidrList() should call 
NetworkACLItemDao.loadCidrs. Cidr list won't be available otherwise. 
2. Migration code should be added to upgrade path to move existing cidrs to new 
network_acl_item_cidr table

Regards,
kishan

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Wednesday, 19 February 2014 8:33 PM
> To: dev; Kishan Kavala
> Subject: Re: cidrs in acls
> 
> Kishan,
> 
> Can you have a look  at the branch acl-item-cidrs. I made some code to
> handle the cidrs from a separate table. I hardly think this can be enough and
> would like to create a checklist on what I need to do next.
> (item one is use the new transaction model;)
> 
> thanks,
> Daan
> 
> On Fri, Jan 17, 2014 at 1:19 PM, Daan Hoogland
>  wrote:
> > That was what I thought as well. What was the retionale to join them
> > into one field?
> >
> > On Fri, Jan 17, 2014 at 8:32 AM, Kishan Kavala 
> wrote:
> >> Daan,
> >>   Similar to firewall_rules_cidrs, separate table can be used to store acl
> cidrs. Maybe in network_acl_item_cidrs.
> >>
> >> Regards,
> >> kishan
> >>
> >>> -Original Message-
> >>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >>> Sent: Friday, 17 January 2014 1:05 AM
> >>> To: Kishan Kavala
> >>> Cc: dev
> >>> Subject: cidrs in acls
> >>>
> >>> H Kishan,
> >>>
> >>> I see you implemented CLOUDSTACK-763. it merges a lot of cidrs into
> one field.
> >>> The api doesn't check the field length. I enlarged the field in the
> >>> create table statement to 2048 for the 4.3 branch. Can you help me
> >>> think about a more solid solution, please. It seems to me those cidrs
> shouldn't be joint into one field.
> >>>
> >>> regards,
> >>> Daan
> 
> 
> 
> --
> Daan

[Proposal] LXC Enhancements

[Kishan Kavala]

LXC support was added to CloudStack in 4.2 release was implemented as a 
hypervisor. Following operations are currently supported:
- Add an LXC cluster 
- Add an LXC host 
- Register an LXC template 
- Spin up an LXC container (Create/Start/Stop/Destroy)

I would like to add more functionality, mostly on the storage side.
- Support data disk while creating container 
- Support attach/detach data disk 
- Support Ceph storage 
- Migrate volume of a stopped container 
- Create template from ROOT volume 
- Attach/Detach an ISO to a container 
- Launch container from ISO 
- Console Access

FS:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+2.0

Jira Ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-6122

Please let me know your comments.

Thanks,
Kishan

RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)

[Kishan Kavala]

Daan,
 I couldn't repo CLOUDSTACK-6069 in my regular VPC setup.  Does this happen 
only when using mixed setup with Nicira?

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Thursday, 13 February 2014 2:29 PM
> To: Animesh Chaturvedi; dev@cloudstack.apache.org
> Cc: Kishan Kavala; Murali Reddy; daan Hoogland
> Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> I can confirm that it also exists in master. Unfortunately it is not high on 
> my
> prio list right now. We have a pressing bug hurting us in our production
> systems that I will get out of the way first.
> 
> What I can say is that I am puzzled that my test works in 4.2 and before as I
> instantiate a private gateway with associated network, while the system
> network offering for private gateways has no tags and I have two guest
> networks.
> 
> I will return to this issue when given time.
> 
> Regards,
> Daan
> 
> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: woensdag 12 februari 2014 11:52
> To: dev@cloudstack.apache.org
> Cc: Kishan Kavala; Murali Reddy; Daan Hoogland; daan Hoogland
> Subject: RE: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> 
> Adding Murali as well.
> 
> Daan I am not sure if there was any specific work done on this during 4.3 to
> cause it to regress.  Did you debug this further?
> 
> Thanks
> Animesh
> 
> 
> 
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Monday, February 10, 2014 11:42 AM
> > To: dev
> > Cc: Kishan Kavala
> > Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-6069
> >
> > I will try in master as well. And look for a solution there.
> >
> > On Mon, Feb 10, 2014 at 8:13 PM, Animesh Chaturvedi
> >  wrote:
> > > Daan
> > >
> > > Can you create a tracking bug for this issue? Adding Kishan for his
> > > input
> > >
> > > Animesh
> > >
> > >> -Original Message-
> > >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > >> Sent: Monday, February 10, 2014 10:25 AM
> > >> To: dev
> > >> Subject: Re: [VOTE] Apache CloudStack 4.3.0 (fourth round)
> > >>
> > >> H,
> > >>
> > >> -1 (binding)
> > >>
> > >> I have a backwards compatibility issue with 4.3. It might turn out
> > >> to be a setup thing but I have verified that 4.2.1 works with my setup.
> > >> I have four basic test cases|:
> > >> 1. create network and vm on top - works 2. create bridged network
> > >> and create vm on it - works 3. create a vpc with private gateway
> > >> (and
> > >> ...) - fails 4. create a vpc with nicira based private gateway -
> > >> works
> > >>
> > >> I haven't actually tried 1,2 and 4 on this rc because 3 was always
> > >> giving me the most problems. The others worked on the previous rc.
> > >> Having discussed this with Hugo, we'll probably not stop using 4.3
> > >> if it passes but it needs fixing asap.
> > >>
> > >> setup
> > >> 1 zone
> > >> 1 pod
> > >> 1 cluster
> > >> 2 hosts (xen 6.0.2)
> > >>
> > >> 2 physnets
> > >> - physnet 1 vlan based (Public, Guest(tagged "vlan-based"),
> > >> Management,
> > >> Storage)
> > >> - physnet 2 nicira based (Guest (tagged "nicira-based"))
> > >>
> > >> Now creating a private gateway on the vpc using marvin I get a 530
> > >> server error. I dare to put a -1 here as it is a majority vote. One
> > >> of the things that makes me hesitate is
> > >> 4.2.1 code (succeeding):
> > >> 2014-02-10 15:43:45,621 DEBUG [xen.resource.CitrixResourceBase]
> > >> (DirectAgent-4:null) Creating VLAN 322 on host 10.200.23.41 on
> > >> device
> > >> tunnel0
> > >> 4.3.0 code (failing)
> > >> 2014-02-10 17:33:51,083 DEBUG [c.c.h.x.r.CitrixResourceBase]
> > >> (DirectAgent-4:ctx-6d5f0cd4) Creating VLAN 322 on host 10.200.23.42
> > >> on device tunnel0
> > >>
> > >>
> > >> On Mon, Feb 10, 2014 at 12:28 PM, Nux!  wrote:
> > >> > On 08.02.2014 10:56, Nux! wrote:
> > >> >>
> > >> >> On 08.02.2014 00:51, Animesh Chaturvedi wrote:
> > >> >>>
> > >> >>> Hi All,
> > >> >>>
> > >> >>>
> > >> >>> I've created a 4.3.0 release, with the following artifacts up
> > >> >>> for a
> > >> >>> vote:
> > >> >>
> > >> >>
> > >> >> +1 from me, upgrade from 4.2.1 works fine. Tested with CentOS,
> > >> >> +KVM,
> > >> >> NFS, CLVM, Adv+SG.
> > >> >
> > >> >
> > >> > There might be a problem with the HA engine, please see
> > >> > https://issues.apache.org/jira/browse/CLOUDSTACK-6065
> > >> >
> > >> >
> > >> > --
> > >> > Sent from the Delta quadrant using Borg technology!
> > >> >
> > >> > Nux!
> > >> > www.nux.ro
> > >>
> > >>
> > >>
> > >> --
> > >> Daan
> >
> >
> >
> > --
> > Daan

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17747/#review33924
---

Ship it!


Ship It!

- Kishan Kavala


On Feb. 7, 2014, 4:49 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17747/
> ---
> 
> (Updated Feb. 7, 2014, 4:49 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin 
> Mehta.
> 
> 
> Bugs: CLOUDSTACK-6023
> https://issues.apache.org/jira/browse/CLOUDSTACK-6023
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6023: Non windows instances are created on XenServer with a 
> vcpu-max above supported xenserver limits
> 
> Changed the VCPU max limit to 16 and provided a cluster level configuration 
> parameter for this max limit named xen.vm.vcpu.max
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/VirtualMachineTO.java e6240ff 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 28bd724 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  48ccf70 
> 
> Diff: https://reviews.apache.org/r/17747/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

RE: Anyone else having trouble starting up a VM in 4.3?

[Kishan Kavala]

After commit f562579e282fc1a37e7c81a0f090ca82ed22eda6, 64bit 4.3 systemVm 
templates are used instead of 4.2 templates.
While fixing CLOUDSTACK-5690, I changed the minimum version required for router 
to 4.3. Seeding the new 64bit system template will fix the issue.
Global config "router.version.check" can be set to false to skip the router 
version check and use older template. 

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Monday, 20 January 2014 10:53 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Anyone else having trouble starting up a VM in 4.3?
> 
> I have updated the ticket with a couple exceptions from my log.
> 
> 
> On Sun, Jan 19, 2014 at 10:08 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
> 
> > Thanks!
> >
> > I updated the ticket to note that I have observed this in a basic zone
> > (the ticket mentioned this has not been observed in a basic zone).
> >
> >
> > On Sun, Jan 19, 2014 at 8:04 PM, Rayees Namathponnan <
> > rayees.namathpon...@citrix.com> wrote:
> >
> >> This issue is reported with automation run
> >>
> >> https://issues.apache.org/jira/browse/CLOUDSTACK-5901
> >>
> >>
> >>
> >>
> >> On 1/19/14 5:43 PM, "Mike Tutkowski" 
> >> wrote:
> >>
> >> >Just as an FYI, it claims an upgrade is in progress in part of the log.
> >> >Not
> >> >sure why that would be.
> >> >
> >> >
> >> >On Sun, Jan 19, 2014 at 6:42 PM, Mike Tutkowski <
> >> >mike.tutkow...@solidfire.com> wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> Yeah, I just wanted to see first if anyone else had observed this
> >> issue.
> >> >>
> >> >> I have re-created my environment from scratch. The SSVM and CPVM
> >> >> start; however, I cannot start up a user VM.
> >> >>
> >> >> I have to head out for a bit, but can attach my logs when I return.
> >> >>
> >> >> Thanks
> >> >>
> >> >>
> >> >> On Sun, Jan 19, 2014 at 6:30 PM, Yitao Jiang
> >> >>
> >> >>wrote:
> >> >>
> >> >>> Putting your logs here will be more helpful.
> >> >>>
> >> >>> Thanks,
> >> >>>
> >> >>> Yitao
> >> >>>
> >> >>>
> >> >>> 2014/1/20 Mike Tutkowski 
> >> >>>
> >> >>> > Hi,
> >> >>> >
> >> >>> > I rebased on top of 4.3 yesterday (previous rebase on top of
> >> >>> > 4.3 was
> >> >>> just a
> >> >>> > few days earlier) and now I get an "Insufficient Space"
> >> >>> > exception
> >> >>>when
> >> >>> > trying to start up a VM.
> >> >>> >
> >> >>> > Anyone else having this trouble?
> >> >>> >
> >> >>> > I didn't dig into this too deeply, though...perhaps there was a
> >> >>>schema
> >> >>> > change and I'll need to re-create my environment for this to
> >> >>> > work. I
> >> >>> just
> >> >>> > sort of doubted a schema change happened this late in the 4.3
> >> >>>release,
> >> >>> so
> >> >>> > thought it might be something else.
> >> >>> >
> >> >>> > Thanks
> >> >>> >
> >> >>> > --
> >> >>> > *Mike Tutkowski*
> >> >>> > *Senior CloudStack Developer, SolidFire Inc.*
> >> >>> > e: mike.tutkow...@solidfire.com
> >> >>> > o: 303.746.7302
> >> >>> > Advancing the way the world uses the
> >> >>> > cloud
> >> >>> > * *
> >> >>> >
> >> >>>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> *Mike Tutkowski*
> >> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> >> e: mike.tutkow...@solidfire.com
> >> >> o: 303.746.7302
> >> >> Advancing the way the world uses the
> >> >>cloud
> >> >> * *
> >> >>
> >> >
> >> >
> >> >
> >> >--
> >> >*Mike Tutkowski*
> >> >*Senior CloudStack Developer, SolidFire Inc.*
> >> >e: mike.tutkow...@solidfire.com
> >> >o: 303.746.7302
> >> >Advancing the way the world uses the
> >> >cloud
> >> >* *
> >>
> >>
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*
> >
> 
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*

RE: cidrs in acls

[Kishan Kavala]

Daan, 
  Similar to firewall_rules_cidrs, separate table can be used to store acl 
cidrs. Maybe in network_acl_item_cidrs.

Regards,
kishan

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Friday, 17 January 2014 1:05 AM
> To: Kishan Kavala
> Cc: dev
> Subject: cidrs in acls
> 
> H Kishan,
> 
> I see you implemented CLOUDSTACK-763. it merges a lot of cidrs into one field.
> The api doesn't check the field length. I enlarged the field in the create 
> table
> statement to 2048 for the 4.3 branch. Can you help me think about a more solid
> solution, please. It seems to me those cidrs shouldn't be joint into one 
> field.
> 
> regards,
> Daan

Re: Review Request 16730: Add usage event detials for vm state transitions when using custom compute offering.

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16730/#review31368
---

Ship it!


55a9b5d2a2dae4883d52506c6f6a2d5dac4c91cd

- Kishan Kavala


On Jan. 8, 2014, 11:20 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16730/
> ---
> 
> (Updated Jan. 8, 2014, 11:20 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5742
> https://issues.apache.org/jira/browse/CLOUDSTACK-5742
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5742
> Add usage event detials for vm state transitions when using custom compute 
> offering.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 23df880 
>   server/src/com/cloud/vm/UserVmStateListener.java 6c0c5e9 
> 
> Diff: https://reviews.apache.org/r/16730/diff/
> 
> 
> Testing
> ---
> 
> tested on 4.3
> 
> 
> Thanks,
> 
> bharat kumar
> 
>