[GitHub] cloudstack issue #2010: VPC Inline LB - CLOUDSTACK-9282
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/2010 Added Marvin test code PEP8 and PyFlakes compliance: CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/.py CloudStack$ CloudStack$ pyflakes test/integration/component/test_vpcinlinelbvm.py CloudStack$ CloudStack$ pep8 test/integration/component/test_vpcinlinelbvm.py CloudStack$ Validation: Marvin test results: => Native ACS Environment: nosetests --with-marvin --marvin-config=nuage.cfg test/integration/component/test_vpcinlinelbvm.py Test VpcInlineLbVm basic functionality ... === TestName: test_01_vpcinlinelbvm | Status : SUCCESS === ok Test VpcInlineLbVm basic functionality with traffic ... === TestName: test_02_vpcinlinelbvm_with_traffic | Status : SUCCESS === ok Test VpcInlineLbVm functionality with multiple public IP addresses ... === TestName: test_03_vpcinlinelbvm_with_multiple_public_ips_traffic | Status : SUCCESS === ok Test VpcInlineLbVm functionality with lb rule events by performing ... === TestName: test_04_vpcinlinelbvm_with_lb_rule_events_traffic | Status : SUCCESS === ok Test VpcInlineLbVm functionality with different LB algorithms by ... === TestName: test_05_vpcinlinelbvm_with_algorithms_traffic | Status : SUCCESS === ok Test VpcInlineLbVm functionality with VpcInlineLbVm appliance ... === TestName: test_06_vpcinlinelbvm_appliance_operations_traffic | Status : EXCEPTION === ERROR Test VpcInlineLbVm provider with network restarts and reboots by ... === TestName: test_07_vpcinlinelbvm_with_network_restarts_and_reboots | Status : EXCEPTION === ERROR ... Ran 7 tests in 9684.676s FAILED (errors=2) [failed_plus_exceptions.txt](https://github.com/apache/cloudstack/files/854289/failed_plus_exceptions.txt) [results.txt](https://github.com/apache/cloudstack/files/854288/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/854290/runinfo.txt) Note: The above test failures are due to the bug: https://issues.apache.org/jira/browse/CLOUDSTACK-9837 => ACS + Nuage VSP Environment: nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_vpc_vpcinlinelb.py Test Nuage VSP VpcInlineLbVm basic functionality ... === TestName: test_01_nuage_vpcinlinelbvm | Status : SUCCESS === ok Test Nuage VSP VpcInlineLbVm basic functionality with traffic ... === TestName: test_02_nuage_vpcinlinelbvm_with_traffic | Status : SUCCESS === ok Test Nuage VSP VpcInlineLbVm functionality with multiple public IP ... === TestName: test_03_nuage_vpcinlinelbvm_with_multiple_public_ips_traffic | Status : SUCCESS === ok Test Nuage VSP VpcInlineLbVm functionality with lb rule events by ... === TestName: test_04_nuage_vpcinlinelbvm_with_lb_rule_events_traffic | Status : FAILED === FAIL Test Nuage VSP VpcInlineLbVm functionality with different LB ... === TestName: test_05_nuage_vpcinlinelbvm_with_algorithms_traffic | Status : SUCCESS === ok Test Nuage VSP VpcInlineLbVm functionality with VpcInlineLbVm ... === TestName: test_06_nuage_vpcinlinelbvm_appliance_operations_traffic | Status : EXCEPTION === ERROR Test Nuage VSP VpcInlineLbVm functionality with network reboots and ... === TestName: test_07_nuage_vpcinlinelbvm_with_network_restarts_and_reboots | Status : SUCCESS === ok Ran 7 tests in 12848.175s FAILED (errors=1, failures=1) [failed_plus_exceptions.txt](https://github.com/apache/cloudstack/files/854302/failed_plus_exceptions.txt) [results.txt](https://github.com/apache/cloudstack/files/854301/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/854300/runinfo.txt) Note: The above failure is a random failure on Nuage VSP environment, which we are debugging. => Concurrency tests Thread Count: 15 nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_vpc_vpcinlinelb.py Test Nuage VSP VPC Network Public Load Balancing Rules Concurrency ... === TestName: test_01_nuage_vpc_network_public_lb_rules_concurrency | Status : SUCCESS === ok -- Ran 1 test in 1606.907s OK [results.txt](https://github.com/apache/cloudstack/files/854313/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/854312/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not workin
[GitHub] cloudstack issue #2005: CLOUDSTACK-9450: Network Offering for VPC based on D...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/2005 PEP8 & PyFlakes compliance of our marvin test code: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py CloudStack$ Validations: Marvin test results: => nosetests --with-marvin --marvin-config=nuage.cfg nuagevsp/test_nuage_static_nat.py Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS === ok Test Nuage VSP Nuage Underlay (underlay networking) enabled Public ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS === ok Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Static ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality for Isolated network by ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality for VPC network by ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with different Egress ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with VM NIC operations by ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with VM migration by ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with network restarts by ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS === ok -- Ran 10 tests in 10713.290s OK [results.txt](https://github.com/apache/cloudstack/files/840912/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/840911/runinfo.txt) => nosetests --with-marvin --marvin-config=nuage.cfg nuagevsp/test_nuage_source_nat.py Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Source ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality for Isolated network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality for VPC network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality with different Egress ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality with VM NIC operations by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality with VM migration by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality with network restarts by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test -- Ran 8 tests in 1490.621s OK (SKIP=6) [results.txt](https://github.com/apache/cloudstack/files/840914/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/840915/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2005: CLOUDSTACK-9450: Network Offering for VPC bas...
GitHub user prashanthvarma opened a pull request: https://github.com/apache/cloudstack/pull/2005 CLOUDSTACK-9450: Network Offering for VPC based on DB flag Co-Authored-By: Prashanth Manthena prashanth.manth...@nuagenetworks.net Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-9398 Design Document: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+Offering+for+VPC+based+on+DB+flag You can merge this pull request into a Git repository by running: $ git pull https://github.com/nuagenetworks/cloudstack feature/nw_offering_for_vpc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2005.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2005 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2004: CLOUDSTACK-9832: Restrict addition of public IP NIC ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/2004 PEP8 & PyFlakes compliance of our marvin test code: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py CloudStack$ Validations: Marvin test results: => nosetests --with-marvin --marvin-config=nuage.cfg nuagevsp/test_nuage_vpc_network.py Test basic VPC Network functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS === ok Test basic VPC Network functionality with Nuage VSP SDN plugin on ... SKIP: There is only one Zone configured: skipping test -- Ran 2 tests in 274.059s OK (SKIP=1) [results.txt](https://github.com/apache/cloudstack/files/840864/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/840863/runinfo.txt) => nosetests --with-marvin --marvin-config=nuage.cfg nuagevsp/test_nuage_vsp.py Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS === ok Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName: test_nuage_vsp_device | Status : SUCCESS === ok -- Ran 2 tests in 511.178s OK [results.txt](https://github.com/apache/cloudstack/files/840866/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/840867/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2004: CLOUDSTACK-9832: Restrict addition of public ...
GitHub user prashanthvarma opened a pull request: https://github.com/apache/cloudstack/pull/2004 CLOUDSTACK-9832: Restrict addition of public IP NIC to the VPC VR when the VPC offering does not contain VpcVirtualRouter as a SourceNat provider Detail: When the VPC offering does not contain VpcVirtualRouter as a SourceNat provider, then we will not add the interface in the public network to the VpcVR. Thus, conserving Public IPs. Co-Authored-By: Prashanth Manthena prashanth.manth...@nuagenetworks.net You can merge this pull request into a Git repository by running: $ git pull https://github.com/nuagenetworks/cloudstack feature/vr_without_public_ip Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2004.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2004 commit adf889df566d7c68fdba51bc0046b9a71c7c1b3c Author: Frank Maximus <frank.maxi...@nuagenetworks.net> Date: 2015-11-18T14:05:58Z CLOUDSTACK-9832: Restrict addition of public IP NIC to the VPC VR when the VPC offering does not contain VpcVirtualRouter as a SourceNat provider Detail: When the VPC offering does not contain VpcVirtualRouter as a SourceNat provider, then we will not add the interface in the public network to the VpcVR. Thus, conserving Public IPs. Co-Authored-By: Prashanth Manthena prashanth.manth...@nuagenetworks.net --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1981 @borisstoyanov yes, I also did cross check the test failures. Thanks for the investigation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack-docs/pull/19 @rhtyd @karuturi Can we please merge this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1981 @borisstoyanov I am glad you liked the PR, we (@nuagenetworks) made it a practice to add and run integration tests that test the changes we propose/make in a PR. Moreover, we internally qualify through regressions the whole system with those changes for both Nuage VSP and native ACS setups/environments where necessary. Thank you for kicking the regression tests. Please do also code review the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1981 PEP8 & PyFlakes compliance of our marvin test code: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py CloudStack$ Validations: Marvin test results: nosetests --with-marvin --marvin-config=nuage.cfg nuagevsp/test_nuage_vsp_domain_template.py Test Nuage VSP Domain Template selection per VPC ... === TestName: test_01_nuage_Domain_Template_selection_per_VPC | Status : SUCCESS === ok Test Nuage VSP Domain Template selection per VPC as ROOT domain ... === TestName: test_02_nuage_Domain_Template_selection_per_VPC_as_ROOT_user | Status : SUCCESS === ok Test Nuage VSP Domain Template selection per VPC as domain admin ... === TestName: test_03_nuage_Domain_Template_selection_per_VPC_as_domain_admin | Status : SUCCESS === ok Test Nuage VSP Domain Template selection per VPC as domain ... === TestName: test_04_nuage_Domain_Template_selection_per_VPC_as_domain_user | Status : SUCCESS === ok Test Nuage VSP Domain Template selection per VPC as subdomain admin ... === TestName: test_05_nuage_Domain_Template_selection_per_VPC_as_subdom_admin | Status : SUCCESS === ok Test Nuage VSP Domain Template selection per VPC as subdomain ... === TestName: test_06_nuage_Domain_Template_selection_per_VPC_as_subdom_user | Status : SUCCESS === ok Test Nuage VSP Global Domain Template ... === TestName: test_07_nuage_Global_Domain_Template | Status : SUCCESS === ok Test Nuage VSP Global Domain Template as ROOT domain regular user ... === TestName: test_08_nuage_Global_Domain_Template_as_ROOT_user | Status : SUCCESS === ok Test Nuage VSP Global Domain Template as domain admin user ... === TestName: test_09_nuage_Global_Domain_Template_as_domain_admin | Status : SUCCESS === ok Test Nuage VSP Global Domain Template as domain regular user ... === TestName: test_10_nuage_Global_Domain_Template_as_domain_user | Status : SUCCESS === ok Test Nuage VSP Global Domain Template as subdomain admin user ... === TestName: test_11_nuage_Global_Domain_Template_as_subdomain_admin | Status : SUCCESS === ok Test Nuage VSP Global Domain Template as subdomain regular user ... === TestName: test_12_nuage_Global_Domain_Template_as_subdomain_user | Status : SUCCESS === ok -- Ran 12 tests in 6203.613s OK [results.txt](https://github.com/apache/cloudstack/files/810482/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/810483/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1981 Design document for this feature: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Nuage+domain+template+selection+per+VPC --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1981: CLOUDSTACK-9806: Nuage domain template select...
GitHub user prashanthvarma opened a pull request: https://github.com/apache/cloudstack/pull/1981 CLOUDSTACK-9806: Nuage domain template selection per VPC Co-Authored-By: Prashanth Manthena <prashanth.manth...@nuagenetworks.net> Co-Authored-By: Frank Maximus <frank.maxi...@nuagenetworks.net> You can merge this pull request into a Git repository by running: $ git pull https://github.com/nuagenetworks/cloudstack feature/nuage_vpc_selectable_domain_template Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1981.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1981 commit 55ce0d91805fc4807952ead3f8160eae589038ab Author: Sigert Goeminne <sigert.goemi...@nuagenetworks.net> Date: 2016-10-06T12:30:59Z CLOUDSTACK-9806: Nuage domain template selection per VPC Co-Authored-By: Prashanth Manthena <prashanth.manth...@nuagenetworks.net> Co-Authored-By: Frank Maximus <frank.maxi...@nuagenetworks.net> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack-docs/pull/19 @rhtyd @karuturi @krissterckx Additionally, added a section on how to run The Nuage VSP Plugin specific Marvin tests. You can merge this PR as it is complete now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack-docs/pull/19 @rhtyd @karuturi Please do review this cloudstack-docs PR, which includes changes to the Nuage VSP Plugin documentation for ACS 4.10 release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack-docs/pull/19 These changes in the documentation are in accordance with our merged feature support (including bug fix) PRs. Here are some of our merged feature support PRs: https://github.com/apache/cloudstack/pull/1578 https://github.com/apache/cloudstack/pull/1579 https://github.com/apache/cloudstack/pull/1580 https://github.com/apache/cloudstack/pull/1452 Moreover, we have restructured and extended the documentation with some screen-shots. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 Thank you all for helping us in merging this PR, much appreciated !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @rhtyd I have re-kicked Travis, but it still fails due to the following exception (test environment and/or code issue) while running the test "test_create_volume_under_domain": CloudstackAPIException: Execute cmd: createvolume failed, due to: errorCode: 431, errorText:This disk offering requires a custom size specified\n Anyhow, this issue has nothing to do with the code changes in this PR. In between, @borisroman reviewed this PR, and gave a LGTM. Let me know, if you need us to do anything from our side. CC: @jburwell @murali-reddy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @rhtyd Just to make sure, are we waiting for a LGTM to merge this PR ? May be, @jburwell can comment and/or give a LGTM as he has reviewed the PR :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @rhtyd @jburwell We have resolved all your review comments, and updated this PR. Moreover, all our internal regressions are looking good with the latest code in this PR. Let me know, if you want me to re-trigger travis (e.g. rebase this PR with latest master) once its issues are resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @rhtyd We have now resolved all your review comments including adding of the requested unit test coverage, and we have rebased this PR with the latest master (i.e. contains PR #1801 fix). Here is my analysis regarding the following regression test failures: 1) test_06_download_detached_volume -> Failed to access SSVM to extractVolume download info. Above failing test case tries to download a volume unattached to a VM by extracting its download info from SSVM, which fails due to failed access/connection with SSVM. This test case passes in other test environments (e.g. KVM and VMware). Thus, most likely, its a test environment (intermittent) issue. 2) test_01_create_template -> Failed to delete the created template during test case tearDown Above failing test case creates a template (adds to cleanup list), does some assertions on the returned list of templates, and goes to test case tearDown (deletes objects in cleanup list). Similar tests pass in other test cases of the same test script "test-templates.py" and in other test environments (e.g. xenserver and VMware). One major difference between the failing test case and others is that the deletion of template is happening right after its creation (bit too quick). Thus, most likely, it is a timing related (intermittent) issue. Let me know, if you need anything from our side. cc: @jburwell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r9043
--- Diff: server/src/com/cloud/network/NetworkModelImpl.java ---
@@ -1558,6 +1558,32 @@ public boolean checkIpForService(IpAddress userIp,
Service service, Long network
}
@Override
+public boolean providerSupportsCapability(Set providers,
Service service, Capability cap) {
--- End diff --
@rhtyd Unit test coverage added for this at
server/test/com/cloud/network/MockNetworkModelImpl.java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @jburwell Thank you for the update, I was planning to investigate the same test failure (test_router_dhcp_opts) as unlike other test failures it looked like an actual reproducible issue from brief failure analysis. Anyhow, you saved me some time :) Just a small remark, most of the failures in the regression tests are either test cleanup issues (e.g. failed to delete because resource is in use) (or) timeout issues (e.g. failed to SSH into VM). According to me, one can avoid such failures by refactoring/restructuring the Marvin test code in such smoke tests. We will rebase this PR with latest master once PR #1800 and PR #1801 have been merged, and update here to re-run the regression tests. @rhtyd Once we update this PR with the requested unit test coverage in the above review comments, are we good w.r.t your code review ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 LGTM From our internal code review and regression run results (including our added Nuage VSP SDN plugin specific Marvin tests, refer the previous comment for their corresponding test results). @rhtyd @jburwell You can now kick off a regression run via blueorangutan, and code review this PR. Let me know, if you need anything from our side --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 Nuage VSP SDN plugin specific Marvin test code PEP8 & PyFlakes Compliance: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py Nuage VSP SDN plugin specific Marvin test results: | Marvin Test Script | PASSED Testcases | SKIPPED Testcases | FAILED Testcases | ERROR Testcases | Total Number of Testcases | |-|--|---|--|-|---| | test_nuage_internal_dns.py | 6| 0 | 0| 0 | 6 | | test_nuage_non_public_sharednetwork_ip_range.py | 5| 0 | 0| 0 | 5 | | test_nuage_password_reset.py| 1| 0 | 0| 0 | 1 | | test_nuage_public_sharednetwork_ip_range.py | 8| 0 | 0| 0 | 8 | | test_nuage_publicsharednetwork.py | 13 | 0 | 0| 0 | 13| | test_nuage_public_sharednetwork_userdata.py | 51 | 0 | 0| 0 | 51| | test_nuage_sharednetwork_deployVM.py| 51 | 0 | 0| 0 | 51| | test_nuage_sharednetwork_vpc_vm_monitor.py | 10 | 0 | 0| 0 | 10| | test_nuage_source_nat.py| 2| 6 | 0| 0 | 8 | | test_nuage_static_nat.py| 10 | 0 | 0| 0 | 10| | test_nuage_vpc_internal_lb.py | 7| 0 | 1| 0 | 8 | | test_nuage_vpc_network.py | 1| 1 | 0| 0 | 2 | | test_nuage_vsp.py | 2| 0 | 0| 0 | 2 | | TOTAL RESULTS: | 167 | 7 | 1| 0 | 175 | Nuage VSP SDN plugin specific Marvin Test Run Logs: test_nuage_internal_dns.py: [results.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/6/results.txt) [runinfo.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/5/runinfo.txt) test_nuage_non_public_sharednetwork_ip_range.py: [results.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/7/results.txt) [runinfo.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/8/runinfo.txt) test_nuage_password_reset.py: [results.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/10/results.txt) [runinfo.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/9/runinfo.txt) test_nuage_public_sharednetwork_ip_range.py: [results.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/12/results.txt) [runinfo.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/11/runinfo.txt) test_nuage_publicsharednetwork.py: [results.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/15/results.txt) [runinfo.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/16/runinfo.txt) test_nuage_public_sharednetwork_userdata.py: [results.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/17/results.txt) [runinfo.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/18/runinfo.txt) test_nuage_sharednetwork_deployVM.py: [results.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/19/results.txt) [runinfo.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/20/runinfo.txt) test_nuage_sharednetwork_vpc_vm_monitor.py: [results.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/25/results.txt) [runinfo.txt](https://github.mv.usa.alcatel.com/CloudStack/CloudStack/files/26/runinfo.txt) test_nuage_source_na
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @rhtyd @jburwell UPDATE: We are currently re-qualifying this PR (internally, re-based with latest master and commits squashed) as we hit the issue "systemvm: Fix regression from 825935" in our weekend regression runs on this PR, which was fixed yesterday on master. Took us some time to find the root cause :) Anyhow, once all our internal regression runs and added Marvin tests in this PR pass, we will update this PR accordingly (re-based with latest master and commits squashed). Let me know, if you need anything from my side. Thank you for your support !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1592: CLOUDSTACK-9416 (Bug in ACS master GUI) : Ena...
Github user prashanthvarma closed the pull request at: https://github.com/apache/cloudstack/pull/1592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1592: CLOUDSTACK-9416 (Bug in ACS master GUI) : Enabling S...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1592 Closing this PR as its shadow PR #1785 got merged into 4.9/master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1785: CLOUDSTACK-9416 : Enabling Static NAT on an associat...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1785 @rhtyd This is a shadow of PR #1592 , rebased against 4.9 as requested. Note: The original PR #1592 has enough LGTMs to merge this PR. Once you merge this PR, I will close the PR #1592 . Sorry for the inconvenience !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1592: CLOUDSTACK-9416 (Bug in ACS master GUI) : Enabling S...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1592 @rhtyd I had difficulties changing the base branch to 4.9 and re-basing against 4.9 as the source branch on my fork is master (prashanthvarma:master). Anyhow, I have opened a new PR #1785 with this UI bug fix commit against 4.9 branch. Once you merge PR #1785, I will close this PR. Sorry for the inconvenience !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1785: CLOUDSTACK-9416 : Enabling Static NAT on an a...
GitHub user prashanthvarma opened a pull request: https://github.com/apache/cloudstack/pull/1785 CLOUDSTACK-9416 : Enabling Static NAT on an associated Public IP to one of the NICs (networks) of a multi-NIC VM fails due to a wrong (default) Guest VM IP being selected in the GUI You can merge this pull request into a Git repository by running: $ git pull https://github.com/prashanthvarma/cloudstack 4.9 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1785.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1785 commit 094c4cf02bf75ed3e5bd227f7b4cfe614f386871 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-06-15T12:47:50Z CLOUDSTACK-9416 : Enabling Static NAT on an associated Public IP to one of the NICs (networks) of a multi-NIC VM fails due to a wrong (default) Guest VM IP being selected in the GUI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @rhtyd @jburwell We will rebase this PR with the latest master asap, and update you. As mentioned in the previous comments, we wanted to merge this PR after merging PR #1580 as there are some feature interactions and dependencies, which we will fix during the rebase of this PR with the latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 @rhtyd @jburwell Thank you for reviewing and helping us merge this PR, much appreciated !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @rhtyd @jburwell Thank you for reviewing and helping us merge this PR, much appreciated !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @rhtyd I have resolved all your comments and updated the PR. Moreover, all the tests that are run on this PR are now fully successful (blueorangutan tests + added Marvin tests in this PR). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Github user prashanthvarma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1580#discussion_r89540443 --- Diff: tools/marvin/marvin/lib/base.py --- @@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs): cmd.listall = True return(apiclient.listPortableIpRanges(cmd)) + +class NuageUnderlayPublicIpRange: --- End diff -- @rhtyd I am convinced with your reasoning, I will move the module to our directory plugins/nuagevsp, and will update you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @rhtyd Here are the latest test results of the added Marvin tests that test the changes in this PR. 1) Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_static_nat.py Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS === ok Test Nuage VSP Nuage Underlay (underlay networking) enabled Public ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS === ok Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Static ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality for Isolated network by ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality for VPC network by ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with different Egress ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with VM NIC operations by ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with VM migration by ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with network restarts by ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS === ok -- Ran 10 tests in 16073.682s OK Test results: [results.txt](https://github.com/apache/cloudstack/files/612037/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/612038/runinfo.txt) 2) Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_source_nat.py Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Source ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality for Isolated network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality for VPC network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality with different Egress ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality with VM NIC operations by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality with VM migration by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test Test Nuage VSP Source NAT functionality with network restarts by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test -- Ran 8 tests in 1658.814s OK (SKIP=6) Test results: [results.txt](https://github.com/apache/cloudstack/files/612040/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/612041/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 @rhtyd I am afraid, the newly added integration test takes well beyond 20 mins (Ran 4 tests in 6729.698s in the previous run, refer earlier comments for more details) to run all its test-cases because of its extensive test scenarios and E2E traffic tests including verifications for the bug fix in this PR. Thus, it is not practical to add it as a smoke tests. Anyhow, I will run them again on our setups, and will share the results with you asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Github user prashanthvarma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1580#discussion_r89472040 --- Diff: client/tomcatconf/commands.properties.in --- @@ -0,0 +1,804 @@ +# Licensed to the Apache Software Foundation (ASF) under one --- End diff -- FYI, this deleted file is still being referenced in one of the Marvin smoke tests test/integration/smoke/test_staticroles.py (refer its setUp class). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Github user prashanthvarma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1580#discussion_r89471555 --- Diff: tools/marvin/marvin/lib/base.py --- @@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs): cmd.listall = True return(apiclient.listPortableIpRanges(cmd)) + +class NuageUnderlayPublicIpRange: --- End diff -- Agree, but this is a key infrastructure query API for Nuage VSP SDN platform (overlay vs underlay networking). Moreover, our custom base/utility class "nuageTestCase.py" also imports and uses this class. Thus, we have added it to the Marvin base class "base.py" for cleaner abstraction and code usage. For other Nuage VSP supported feature specific/custom APIs, we tend to include them in our custom base/utility class "nuageTestCase.py" at test/integration/plugins/nuagevsp/. Let me know, if you still think otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd I have resolved and responded to your comments, and updated the PR
accordingly. Moreover, I have just kicked on our internal regression tests
(including the added Marvin tests in this PR that test the code changes in this
PR).
Regarding the above failures, all of them are either test environment
(intermittent errors) and are not related to the code changes in this PR.
1) TestRVPCSite2SiteVpn - Failing to download the template in the
setupClass.
Exception("Template download failed exception")
2) test_02_vpc_privategw_static_routes - Failing to create privategateway
in the VPC as the specified vlan is already in use.
errorText:Network with vlan vlan://926 already exists in zone 1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89308445
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/api/response/NuageVlanIpRangeResponse.java
---
@@ -0,0 +1,38 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.response;
+
+import com.cloud.api.commands.VspConstants;
+import com.cloud.dc.Vlan;
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+import org.apache.cloudstack.api.EntityReference;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+
+@EntityReference(value = Vlan.class)
+public class NuageVlanIpRangeResponse extends VlanIpRangeResponse {
--- End diff --
We are not just communicating success/failure, but extending
VlanIpRangeResponse along with a boolean flag to specify if the listed vlan ip
ranges are underlay enabled (or) disabled in Nuage VSP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 LGTM - based on our Internal regression testing and code review on the latest code in this PR. @rhtyd @jburwell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 LGTM - based on our Internal regression testing and code review on the latest code in this PR. @rhtyd @jburwell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 @rhtyd @jburwell I have briefly investigated the above failed tests "test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL" and "test_oobm_enabledisable_across_clusterzones", here are my findings: 1) "test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL " fails during establishment of SSH connection to the VM via its public IP (SSH connection failed to setup, timeout error). Moreover, this test passed in the previous blueorangutan run (refer my previous comment on investigations of the previous blueorangutan run). 2) "test_oobm_enabledisable_across_clusterzones" failure looks like a test environment (i.e. host hardware issue). Moreover, this test passed in the previous blueorangutan run (refer my previous comment on investigations of the previous blueorangutan run). Here is the error from the logs: errorcode : 530, errortext : u'Out-of-band Management action (STATUS) on host (d2049cf2-47ba-4a81-8e72-d01c1dc77dd0) failed with error: > Error: no response from RAKP 1 message\nError: Unable to establish IPMI v2 / RMCP+ session\nRunning Get PICMG Properties my_addr 0x20, transit 0, target 0x20\nNo Response from Get PICMG Properties\nNo PICMG Extenstion discovered\nUnable to get Chassis Power Status\n'} IMHO, the above failing tests are most likely due to test environment issues, and has nothing to do with the code changes in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/756 @rhtyd Here are the screen-shots without and with this UI bug fix:   As pointed out by @nlivens in the previous comment, "The actual Public Load Balancer provider is derived from the VPC offering, and not from this extra field "Public Load Balancer Provider". So, this field has no use at all since it's completely ignored." The cleaner implementation for this UI tab would be to only list "Public Load Balancer Providers" mentioned in the selected VPC offering. Moreover, don't show this tab, if there are no "Public Load Balancer Providers" being mentioned in the selected VPC offering. Finally, make use of the selected "Public Load Balancer Provider" in the actual implementation of the VPC. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/756 @rhtyd, rebased against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1592: CLOUDSTACK-9416 (Bug in ACS master GUI) : Enabling S...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1592 @rhtyd Rebased this PR with latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 @jburwell I have squashed all the commits in this PR into one logical commit as suggested by you. Moreover, I have briefly investigated the above failed test "test_02_redundant_VPC_default_routes" and here are my findings: 1) The above test case fails during establishment of SSH connection to the VM via its public IP (SSH connection failed to setup, timeout error) 2) It looks like a test code (and/or) test environment issue as similar SSH tests in other test cases in the same test script "test_vpc_redundant.py" pass. 3) The only difference between this failing test case and other test cases being the number of retries while establishing SSH connection to the VM via its public IP (0 and 5 retries respectively). Thus, most likely, increasing the number of retries in the failing test case will fix this issue on your test environment. 4) This test case fails at the same point across different PRs (e.g. PR #1580 and PR #1579 ) Conclusion: The above test "test_02_redundant_VPC_default_routes" is failing due to test code (and/or) test environment issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @jburwell I have squashed all the commits in this PR into one logical commit as suggested by you. Moreover, I have briefly investigated the above failed test "test_02_redundant_VPC_default_routes" and here are my findings: 1) The above test case fails during establishment of SSH connection to the VM via its public IP (SSH connection failed to setup, timeout error) 2) It looks like a test code (and/or) test environment issue as similar SSH tests in other test cases in the same test script "test_vpc_redundant.py" pass. 3) The only difference between this failing test case and other test cases being the number of retries while establishing SSH connection to the VM via its public IP (0 and 5 retries respectively). Thus, most likely, increasing the number of retries in the failing test case will fix this issue on your test environment. 4) This test case fails at the same point across different PRs (e.g. PR #1577 and PR #1579 ) Conclusion: The above test "test_02_redundant_VPC_default_routes" is failing due to test code (and/or) test environment issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @jburwell @rhtyd I have re-based this PR with latest master, and we now only have two commits (1 dev + 1 test). Jenkins and Travis are green now, you can now kick off regression tests on this PR via blueorangutan. Meanwhile, we are re-running our local regression tests on the latest build. Let me know, if you need anything from our side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 @jburwell @rhtyd The previous Jenkins failure was due to missing solidfire plugin dependency. I have re-based this PR with latest master, and we now only have two commits (1 dev + 1 test). Jenkins and Travis are green now, you can now kick off regression tests on this PR via blueorangutan. Meanwhile, we are re-running our regression tests on the latest build. Let me know, if you need anything from our side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @jburwell @rhtyd We want to get this PR merged in after merging in PR #1580 as there are some feature interactions and dependencies. Thus, we will rebase this PR on top of the PR #1580 (2 dev + 2 test commits) and let you know. Let me know, if this is fine with you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd We were able to successfully run the failing test "test_01_create_template" on our kvm-centos7 environment with this PR build after dealing with the issue on ACS-KVM agent (missing semi-colon in systemd file), which was fixed on master today. Adding to our last two comments, all the above test failures are most likely test environment (or) timing issues. Please do reconsider this PR for review and merging into master for 4.10 RC. Here are the test run logs: [results.txt](https://github.com/apache/cloudstack/files/581418/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/581417/runinfo.txt) Test create public & private template ... === TestName: test_01_create_template | Status : SUCCESS === ok -- Ran 1 test in 541.353s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd We have briefly investigated the above test failures, and here are our findings: 1) No single test is failing across all the environments, and this PR doesn't contain any "hypervisor" specific changes. 2) The failed test on KVM "test_01_create_template" looks more like a timing issue, and we might not always hit it (refer above comment). Is there a way, we can re-trigger the above failing tests on your CI environment, and also get the management server logs for them to further debug these failures ? It will also be handy for us to get the results and logs of these tests when ran against latest master. Hope, we are not asking to much :) Meanwhile, we will try to reproduce these failures on our setups. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @rhtyd @jburwell Looks like, above test failures are not related to the code changes on this PR. Let me know, if you want us to do anything from our side to assist you in qualifying and merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @rhtyd As I mentioned in the earlier comments, this feature PR has dependency with our other open feature PR #1578. Thus, we re-based this PR (2 commits) on top of that PR (2 commits) as we don't know which PR will go in first. One option: Once PR #1578 has been merged into master, we will re-base this PR with latest master. Thus, we will have only two commits in this PR. Let me know, if you want us to do this in a different way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @rhtyd @jburwell As I mentioned in the earlier comments, this feature PR has dependency with our other open feature PR #1578. Thus, we re-based this PR (2 commits) on top of that PR (2 commits) as we don't know which PR will go in first. One option: Once PR #1578 has been merged into master, we will re-base this PR with latest master. Thus, we will have only two commits in this PR. Let me know, if you want us to do this in a different way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @jburwell @rhtyd I have rebased this PR with latest master, and squashed commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @jburwell @rhtyd I have rebased this PR with latest master, and squashed commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd I have rebased this PR with latest master, and squashed commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 @jburwell @rhtyd I have rebased this PR with latest master, and squashed the Marvin test commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 @jburwell @rhtyd Ok, we will rebase the PR, and let you know here. Moreover, we can re-run the added Marvin tests and share the results after the re-base. Generally, we have two commits in a PR, one for dev and one for test (Marvin). Let me know, if you want us to do this in a different way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 @jburwell @rhtyd Ok, we will rebase the PR, and let you know here. Moreover, we can re-run the added Marvin tests and share the results after the re-base. This PR has dependency from our other open PR #1578 . Thus, we included that PR commits in this PR. Generally, we have two commits in a PR, one for dev and one for test (Marvin). Let me know, if you want us to do this in a different way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @jburwell @rhtyd Ok, we will rebase the PR, and let you know here. Moreover, we can re-run the added Marvin tests and share the results after the re-base. This PR has dependency from our other open PR #1578 . Thus, we included that PR commits in this PR. Generally, we have two commits in a PR, one for dev and one for test (Marvin). Let me know, if you want us to do this in a different way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 @jburwell @rhtyd Ok, we will rebase the PR and squash our changes/commits, and let you know here. Moreover, we can re-run the added Marvin tests and share the results after the re-base. Generally, we have two commits in a PR, one for dev and one for test (Marvin). Is it fine to have this two commits per PR, and squash the other commits ? Our open PRs #1579 and #1580 have dependencies on this PR. Thus, we included this PR commits in those PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1579 Marvin test code PEP8 & PyFlakes compliance: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py CloudStack$ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 Marvin test code PEP8 & PyFlakes compliance: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py CloudStack$ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 Marvin test code PEP8 & PyFlakes compliance: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py CloudStack$ @remibergsma Our Marvin test code is now truly PEP8 & PyFlakes compliant. Moreover, we have extended our custom base class "test/integration/plugins/nuagevsp/nuageTestCase.py" support for optimal creation of cloudstack objects at setUpClass level in order to re-use/test them across different testcases. Thus, conserving test resources (i.e. reduced test created objects and time). Note: We have updated with these changes our other outstanding PRs as well. Let me know, if you have any other questions for me. Thank you for your valuable review and suggestions !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1578 Marvin test code PEP8 & PyFlakes compliance: CloudStack$ CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py CloudStack$ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @remibergsma As a common team practice, we just happened to agree upon with this line length :). Agree, we should make our Marvin code truly PEP8 compliant as you suggested, and update our Marvin code accordingly. I ran all our Marvin tests with this PR as it involves Nuage VSP support for underlay networking besides our default overlay networking. Moreover, we perform quite a few VM deployments (reboots, migrations, expunges, etc.) and traffic tests (e.g. SSH into VM and then wget from the Internet) in these tests. Finally, the CentOS guest VM template that we use for our internal regressions takes a bit longer to start/stop guest VMs (rich feature set and programmes). Here are some metrics: VM deployements: 63 Isolated network creations: 57 SSH into VMs (reconnects) = 82 Note: Unless required, we don't always run all of our Marvin tests in a single Marvin run. Anyhow, we actively use nosetests features such as tags/attributes to run subset of these tests in the following scenarios: 1) simulator tests (required hardware=false) 2) feature specific tests 3) basic (smoke) tests 4) E2E (traffic) tests Note: Once we have considerable number of tests in our plugins/nuagevsp directory, we are also thinking about creating sub-directories as well (e.g. component, smoke, etc.). Let me know, your thoughts on this, and if you have any other questions for me. Thank you for your valuable review and suggestions !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 Marvin test code PEP8 & PyFlakes compliance: CloudStack$ CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/*.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py CloudStack$ Validations: 1) Nuage VSP underlay infra. Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp Test user data and password reset functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_UserDataPasswordReset | Status : SUCCESS === ok Test Nuage VSP Isolated networks with different combinations of Source NAT service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Source NAT service providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS === ok Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS === ok Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range creation and deletion ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS === ok Test Nuage VSP Isolated networks with different combinations of Static NAT service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Static NAT service providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Offering with different combinations of LB service providers ... === TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS === ok Test Nuage VSP VPC Network Offering with and without Internal LB service ... === TestName: test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS === ok Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with different combinations of Internal LB rules ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality by perfor
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @bvbharatk IMHO, above Marvin test failure is not related to the code on this PR. Let me know, if you want us to do any actions from our side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1592: CLOUDSTACK-9416 : (ACS master GUI) Enabling S...
GitHub user prashanthvarma opened a pull request: https://github.com/apache/cloudstack/pull/1592 CLOUDSTACK-9416 : (ACS master GUI) Enabling Static NAT on an associated Public IP to one of the NICs (networks) of a multi-NIC VM fails due to a wrong (default) Guest VM IP being selected in the GUI You can merge this pull request into a Git repository by running: $ git pull https://github.com/prashanthvarma/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1592.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1585 @swill Yes, this is a bug in current master, and IMHO is a candidate to be merged into the frozen master to be released in 4.9. Note: As of know, there have been two code reviews in this PR from the community. We will force push to kick off Travis again, and will keep you updated. Thank you !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1585 Marvin Test Run: CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg /test/integration/plugins/nuagevsp Marvin Test Results: Test user data and password reset functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_UserDataPasswordReset | Status : SUCCESS === ok Test Nuage VSP VPC Offering with different combinations of LB service providers ... === TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS === ok Test Nuage VSP VPC Network Offering with and without Internal LB service ... === TestName: test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS === ok Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with different combinations of Internal LB rules ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality by performing (wget) traffic tests within a VPC ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with different LB algorithms by performing (wget) traffic tests ... === TestName: test_06_nuage_internallb_algorithms_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with restarts of VPC network components by performing (wget) ... === TestName: test_07_nuage_internallb_vpc_network_restarts_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with InternalLbVm appliance operations by performing (wget) ... === TestName: test_08_nuage_internallb_appliance_operations_traffic | Status : SUCCESS === ok Test basic VPC Network functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS === ok Test basic VPC Network functionality with Nuage VSP SDN plugin on multiple zones ... SKIP: There is only one Zone configured: skipping test Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS === ok Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName: test_nuage_vsp_device | Status : SUCCESS === ok Ran 13 tests in 8562.574s OK (SKIP=1) Marvin Test Run Logs: [results.txt](https://github.com/apache/cloudstack/files/308973/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/308975/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1585 PR contents: 1) Fix for this bug 2) Marvin test coverage for Nuage VSP device CRUD operations including verifications for this bug fix. PEP8 & PyFlakes compliance of the added Marvin code: CloudStack$ CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py CloudStack$ Marvin Test Run: CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg /test/integration/plugins/nuagevsp/test_nuage_vsp.py Marvin Test Run Results: Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS === ok Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName: test_nuage_vsp_device | Status : SUCCESS === ok Ran 2 tests in 447.773s OK Marvin Test Run Logs: [results.txt](https://github.com/apache/cloudstack/files/304392/results.txt) [runinfo.txt](https://github.com/apache/cloudstack/files/304393/runinfo.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1577 Added Marvin test code PEP8 & PyFlakes compliance: CloudStack$ CloudStack$ pep8 --max-line-length=150 test/integration/component/test_vpc_network_internal_lbrules.py CloudStack$ CloudStack$ pyflakes test/integration/component/test_vpc_network_internal_lbrules.py CloudStack$ CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py CloudStack$ Validations: 1) Made sure that we didn't break any Public LB (VpcVirtualRouter) functionality. Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg test/integration/component/test_vpc_network_lbrules.py Test results: Test case no 210 and 227: List Load Balancing Rules belonging to a VPC ... === TestName: test_01_VPC_LBRulesListing | Status : SUCCESS === ok Test Create LB rules for 1 network which is part of a two/multiple virtual networks of a ... === TestName: test_02_VPC_CreateLBRuleInMultipleNetworks | Status : SUCCESS === ok Test case no 222 : Create LB rules for a two/multiple virtual networks of a ... === TestName: test_03_VPC_CreateLBRuleInMultipleNetworksVRStoppedState | Status : SUCCESS === ok Test case no 222 : Create LB rules for a two/multiple virtual networks of a ... === TestName: test_04_VPC_CreateLBRuleInMultipleNetworksVRStoppedState | Status : SUCCESS === ok Test case no 214 : Delete few(not all) LB rules for a single virtual network of a ... === TestName: test_05_VPC_CreateAndDeleteLBRule | Status : SUCCESS === ok Test Delete few(not all) LB rules for a single virtual network of ... === TestName: test_06_VPC_CreateAndDeleteLBRuleVRStopppedState | Status : SUCCESS === ok Test Delete all LB rules for a single virtual network of a ... === TestName: test_07_VPC_CreateAndDeleteAllLBRule | Status : SUCCESS === ok Test Delete all LB rules for a single virtual network of a ... === TestName: test_08_VPC_CreateAndDeleteAllLBRuleVRStoppedState | Status : SUCCESS === ok Test User should not be allowed to create a LB rule for a VM that belongs to a different VPC. ... === TestName: test_09_VPC_LBRuleCreateFailMultipleVPC | Status : SUCCESS === ok Test User should not be allowed to create a LB rule for a VM that does not belong to any VPC. ... === TestName: test_10_VPC_FailedToCreateLBRuleNonVPCNetwork | Status : SUCCESS === ok Test case no 217 and 236: User should not be allowed to create a LB rule for a ... === TestName: test_11_VPC_LBRuleCreateNotAllowed | Status : SUCCESS === ok Test User should not be allowed to create a LB rule on an Ipaddress that Source Nat enabled. ... === TestName: test_12_VPC_LBRuleCreateFailForRouterIP | Status : SUCCESS === ok Test User should not be allowed to create a LB rule on an Ipaddress that already has a PF rule. ... === TestName: test_13_VPC_LBRuleCreateFailForPFSourceNATIP | Status : SUCCESS === ok Test User should not be allowed to create a LB rule on an Ipaddress that already has a Static Nat rule. ... === TestName: test_14_VPC_LBRuleCreateFailForStaticNatRule | Status : SUCCESS === ok Test release Ip address that has a LB rule assigned to it. ... === TestName: test_15_VPC_ReleaseIPForLBRuleCreated | Status : SUCCESS === ok Ran 15 tests in 8586.639s OK 2) Marvin test coverage for Internal LB feature on master with native ACS setup (component directory) including validations for this bug fix. Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg test/integration/component/test_vpc_network_internal_lbrules.py Test results: Test VPC Network Internal LB functionality with different combinations of Internal LB rules ... === TestName: test_01_internallb_rules | Status : SUCCESS === ok Test VPC Network Internal LB functionality by performing (wget) traffic tests within a VPC ... === TestName: test_02_internallb_rules_traffic | Status : SUCCESS === ok Test VPC Network Internal LB functionality with restarts of VPC network components by performing (wget) ... === TestName: test_03_internallb_rules_vpc_network_restarts_traffic | Status : SUCCESS === ok Test VPC Network Internal LB functionality with InternalLbVm appliance operations by performing (wget) ... === TestName: test_04_internallb_appliance_operations_traffic | Status : SUCCESS === ok Ran 4 tests in 6729.698s OK 3) Enhancements on our exiting Internal LB Marvin test code (nuagevsp plugins directory) to validate this bug fix. Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py Test results: Test Nuage VSP
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 Our Marvin test code PEP8 & PyFlakes compliance: CloudStack$ CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py CloudStack$ CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py CloudStack$ Validations: 1) Underlay infra (PAT & FIP2UL) Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg plugins/nuagevsp/test_nuage_source_nat.py Test results: Test Nuage VSP Isolated networks with different combinations of Source NAT service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Source NAT service providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS === ok Test Nuage VSP Source NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS === ok -- Ran 8 tests in 13360.858s OK Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg plugins/nuagevsp/test_nuage_static_nat.py Test results: Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS === ok Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range creation and deletion ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS === ok Test Nuage VSP Isolated networks with different combinations of Static NAT service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Static NAT service providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS === ok Test Nuage VSP Static NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS === ok -- Ran 10 tests in 9472.468s OK 2) Overlay Infra (Source & Static NAT) Marvin test run: nosetests --with-marvin --marvin-config=nuage.cfg plugins/nuagevsp/test_nuage_source_nat.py Test results: Test Nuage VSP Isolated networks with different combinations of Source NAT service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS === ok Test Nuage VSP VPC networks with different combinations of Source NAT servi
[GitHub] cloudstack pull request: More VR performance!
Github user prashanthvarma commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-215041061 @milamberspace @swill @remibergsma @DaanHoogland, I am seeing a similar issue on master: https://issues.apache.org/jira/browse/CLOUDSTACK-9370 I have couple of questions regarding this issue: Does this PR supposed to fix this issue as well, and is anyone else seeing this issue on master ? Please excuse me, if this is not the correct platform for such questions. Let me know, where I can ask such questions. Thank you !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Github user prashanthvarma commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-214209793 @DaanHoogland, We haven't heard from @pedro-martins in a while. Let's hope, he responds soon (or) someone form the community reviews our code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Github user prashanthvarma commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-26802 @DaanHoogland That's a good suggestion. We will discuss on the optimal location in the plugin's project directory, and incorporate them in the next PR. Thank you for the review and suggestions !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Github user prashanthvarma commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-211092880 @DaanHoogland you are right, that is the main motive :). Let me know, if you want me to publish it elsewhere as well for easier user access. Thank you !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211044426
@DaanHoogland Sure, here is an example Nuage VSP SDN plugin specific Marvin
tests config file contents:
{
"zones": [
{
"name": "MyZone",
"guestcidraddress": "10.1.1.0/24",
"dns2": "8.8.6.6",
"dns1": "10.10.0.10",
"physical_networks": [
{
"broadcastdomainrange": "Zone",
"isolationmethods": [
"VLAN"
],
"name": "Management Network",
"traffictypes": [
{
"kvm": "mgmtbr0",
"typ": "Management"
},
{
"kvm": "mgmtbr0",
"typ": "Public"
},
{
"kvm": "mgmtbr0",
"typ": "Storage"
}
],
"providers": [
{
"broadcastdomainrange": "ZONE",
"name": "VirtualRouter"
}
]
},
{
"broadcastdomainrange": "Zone",
"isolationmethods": [
"VSP"
],
"name": "Nuage Network",
"traffictypes": [
{
"kvm": "alubr0",
"typ": "Guest"
}
],
"providers": [
{
"broadcastdomainrange": "ZONE",
"name": "VirtualRouter"
},
{
"broadcastdomainrange": "ZONE",
"name": "NuageVsp",
"devices": [
{
"username": "csproot",
"retryinterval": "60",
"hostname": "10.30.35.129",
"apiversion": "v3_2",
"retrycount": "4",
"password": "csproot",
"port": 8443
}
]
},
{
"broadcastdomainrange": "ZONE",
"name": "VpcVirtualRouter"
},
{
"broadcastdomainrange": "ZONE",
"name": "InternalLbVm"
}
]
}
],
"securitygroupenabled": "false",
"ipranges": [
{
"startip": "10.29.1.1",
"endip": "10.29.9.255",
"netmask": "255.255.0.0",
"gateway": "10.29.0.1"
}
],
"networktype": "Advanced",
"pods": [
{
"endip": "10.20.15.255",
"name": &q
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
GitHub user prashanthvarma opened a pull request: https://github.com/apache/cloudstack/pull/1452 CLOUDSTACK-9322: Support for Internal LB fuctionality with Nuage VSP SDN Plugin including Marvin tests Task: https://issues.apache.org/jira/browse/CLOUDSTACK-9322 PR contents: 1) UI changes to support LB provider âInternalLbVmâ during VPC offering creation. 2) Bug fix for CLOUDSTACK-9320. 3) Nuage VSP SDN Plugin related enhancements for VPC network functionality. 4) Marvin test coverage for Internal LB support on master with Nuage VSP SDN Plugin. 5) Enhancements on our exiting Marvin test code (nuagevsp plugins directory). 6) PyFlakes & PEP8 compliance with our Marvin test code. Test run: CloudStack$ nosetests --with-marvin --marvin-config=nuage_ant.cfg test/integration/plugins/nuagevsp/ -a tags=nuagevsp Test results: Test user data and password reset functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_UserDataPasswordReset | Status : SUCCESS === ok Test Nuage VSP VPC Offering with different combinations of LB service providers ... === TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS === ok Test Nuage VSP VPC Network Offering with and without Internal LB service ... === TestName: test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS === ok Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with different combinations of Internal LB rules ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality by performing (wget) traffic tests within a VPC ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with different LB algorithms by performing (wget) traffic tests ... === TestName: test_06_nuage_internallb_algorithms_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with restarts of VPC network components by performing (wget) ... === TestName: test_07_nuage_internallb_vpc_network_restarts_traffic | Status : SUCCESS === ok Test Nuage VSP VPC Internal LB functionality with InternalLbVm appliance operations by performing (wget) ... === TestName: test_08_nuage_internallb_appliance_operations_traffic | Status : SUCCESS === ok Test Basic VPC Network Functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS === ok Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS === ok -- Ran 11 tests in 12094.705s OK Test run logs: PEP8 & PyFlakes Compliance: CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/*.py CloudStack$ pyflakes test/integration/plugins/nuagevsp/nuageTestCase.py CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_password_reset.py CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vpc_network.py CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vsp.py CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py #CLOUDSTACK-9322 You can merge this pull request into a Git repository by running: $ git pull https://github.com/prashanthvarma/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1452.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1452 commit be67e5cf0649e906291883d974873fb9f49aaff2 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-02-18T10:03:34Z CLOUDSTACK-9322 : Changes to support InternalLbVm with Nuage VSP plugin commit 7f811d9962e4112ac789129c3e73c4652db00c54 Author: Nick Livens <nick.liv...@nuagenetworks.net> Date: 2016-03-21T13:34:18Z CLOUDSTACK-9320 : InternalLBVM is not getting destroyed when the last Internal Load Balancer rule is removed for the corresponding source IP address commit 12085aae2caa4562dd7740d857e21f746d5a7748 Author: Prashanth Manthena <prashanth.manth...@alcatel-lucent.com> Date: 2016-03-23T14:59:41Z CLOUDSTACK-9322 : Marvin tests for Internal Lb with Nuage VSP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but n
