[GitHub] cloudstack pull request: Make the generated json files unique to p...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1470

Make the generated json files unique to prevent concurrency issues

The json files now have UUIDs to prevent them from getting overwritten 
before they've been executed. Prevents config to be pushed to the wrong router 
:-s

```
2016-02-25 18:32:23,797 DEBUG [c.c.a.t.Request] 
(AgentManager-Handler-1:null) (logid:) Seq 2-4684025087442026584: Processing:  
{ Ans: , MgmtId: 90520732674657, via: 2, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.routing.GroupA
nswer":{"results":["null - success: null","null - success: [INFO] 
update_config.py :: Processing incoming file => 
vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b\n[INFO] Processing JSON 
file vm_dhcp_entry.json.4ea4506
1-2efb-4467-8eaa-db3d77fb0a7b\n"],"result":true,"wait":0}}] }
```

On the router:
```
2016-02-25 18:32:23,416  merge.py __moveFile:298 Processed file written to 
/var/cache/cloud/processed/vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b.gz
```

![screen shot 2016-02-25 at 19 33 
17](https://cloud.githubusercontent.com/assets/1630096/13329886/acdae4fc-dbf6-11e5-8c20-fdc6661f5a0b.png)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
47_fix_concurrency_issue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1470.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1470


commit f632215b0493b210201fa7590db00ce64cf25e4a
Author: Miguel Ferreira <miguelferre...@me.com>
Date:   2016-02-25T13:32:09Z

Make the generated json files unique to prevent concurrency issues

Backported from Cosmic.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Apply static routes on change to master s...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1472

Apply static routes on change to master state

Refactored static routes for private gateways so they also get loaded when 
the router switches to master state. Otherwise they're lost and connections 
drop after fail over.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
47_fix_static_router_master_change

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1472


commit b9feb39e175f59f63a2781e9dd93ffdc1ad58e84
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-20T19:05:48Z

apply static routes on change to master state




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1467


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1469


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1473

Bump ssh retries to prevent false positives of test_loadbalance

No more false positives after this change.

```
[root@cs1 integration]# cat 
/tmp//MarvinLogs/test_loadbalance_TR5RJD/results.txt
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok

--
Ran 3 tests in 930.418s

OK
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
47_bump_test_loadbalance_retries

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1473


commit ebfd3c9db6ebd264a1daae6479d6c620d785996c
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-21T18:19:42Z

bump ssh retries to prevent false positives of test_loadbalance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1469

Bump ssh retries to prevent false positives of test_loadbalance

No more false positives after this change.

```
[root@cs1 integration]# cat 
/tmp//MarvinLogs/test_loadbalance_TR5RJD/results.txt
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok

--
Ran 3 tests in 930.418s

OK
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
47_bump_test_loadbalance_retries

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1469


commit ebfd3c9db6ebd264a1daae6479d6c620d785996c
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-21T18:19:42Z

bump ssh retries to prevent false positives of test_loadbalance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Apply static routes on change to master s...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1468


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1471

Lower the time we wait for interfaces to appear

Waiting for interfaces is tricky. They might never appear.. for example 
when we have entries in `/etc/cloudstack/ips.json` that haven't been plugged 
yet. Waiting this long makes everything horribly slow (every vm, interface, 
static route, etc, etc, will hit this wait, for every device). We've seen 
CloudStack send an `ip_assoc.json` command for `eth1` public nic only and then 
the router goes crazy waiting for all other interfaces that were there before 
reboot and aren't there. If only the router would return to the mgt server a 
success of `eth1`, it would get the command for `eth2` etc etc. Obviously, a 
destroy works much faster because no state services, so no knowledge of 
previous devices so no waits :-)

After a stop/start the router has state in `/etc/cloudstack/ips.json` and 
every commands waits. Eventually hitting the hardcoded 120 sec timeout.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 47_lower_interface_wait

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1471.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1471


commit 3636ad1114a89101ed0a14520572b5f0203d454b
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-25T21:48:54Z

lower the time we wait for interfaces to appear

They might never appear.. for example when we have entries in
/etc/cloudstack/ips.json that haven't been plugged yet. Waiting
this long makes everything horribly slow (every vm, interface,
static route, etc, etc, will hit this wait, for every device).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1465#issuecomment-207051489
  
@DaanHoogland This can be pointed towards 4.7 so I will close this and open 
one to 4.7 instead of master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1465


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Apply static routes on change to master s...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1468

Apply static routes on change to master state

Refactored static routes for private gateways so they also get loaded when 
the router switches to master state. Otherwise they're lost and connections 
drop after fail over.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
47_fix_static_router_master_change

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1468


commit b9feb39e175f59f63a2781e9dd93ffdc1ad58e84
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-20T19:05:48Z

apply static routes on change to master state




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1467

Lower the time we wait for interfaces to appear after restart

Waiting for interfaces is tricky. They might never appear.. for example 
when we have entries in `/etc/cloudstack/ips.json` that haven't been plugged 
yet. Waiting this long makes everything horribly slow (every vm, interface, 
static route, etc, etc, will hit this wait, for every device). We've seen 
CloudStack send an `ip_assoc.json` command for `eth1` public nic only and then 
the router goes crazy waiting for all other interfaces that were there before 
reboot and aren't there. If only the router would return to the mgt server a 
success of `eth1`, it would get the command for `eth2` etc etc. Obviously, a 
destroy works much faster because no state services, so no knowledge of 
previous devices so no waits :-)

After a stop/start the router has state in `/etc/cloudstack/ips.json` and 
every commands waits. Eventually hitting the hardcoded 120 sec timeout.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 47_lower_interface_wait

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1467


commit 3636ad1114a89101ed0a14520572b5f0203d454b
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-25T21:48:54Z

lower the time we wait for interfaces to appear

They might never appear.. for example when we have entries in
/etc/cloudstack/ips.json that haven't been plugged yet. Waiting
this long makes everything horribly slow (every vm, interface,
static route, etc, etc, will hit this wait, for every device).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1465

Fix concurrency issue on virtual router

The json files now have UUIDs to prevent them from getting overwritten 
before they've been executed. Prevents config to be pushed to the wrong router 
:-s

```
2016-02-25 18:32:23,797 DEBUG [c.c.a.t.Request] 
(AgentManager-Handler-1:null) (logid:) Seq 2-4684025087442026584: Processing:  
{ Ans: , MgmtId: 90520732674657, via: 2, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.routing.GroupA
nswer":{"results":["null - success: null","null - success: [INFO] 
update_config.py :: Processing incoming file => 
vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b\n[INFO] Processing JSON 
file vm_dhcp_entry.json.4ea4506
1-2efb-4467-8eaa-db3d77fb0a7b\n"],"result":true,"wait":0}}] }
```

On the router:
```
2016-02-25 18:32:23,416  merge.py __moveFile:298 Processed file written to 
/var/cache/cloud/processed/vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b.gz
```

![screen shot 2016-02-25 at 19 33 
17](https://cloud.githubusercontent.com/assets/1630096/13329886/acdae4fc-dbf6-11e5-8c20-fdc6661f5a0b.png)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
47_fix_concurrency_issue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1465


commit f632215b0493b210201fa7590db00ce64cf25e4a
Author: Miguel Ferreira <miguelferre...@me.com>
Date:   2016-02-25T13:32:09Z

Make the generated json files unique to prevent concurrency issues

Backported from Cosmic.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1462#issuecomment-205452667
  
Works as expected, LGTM.
![screen shot 2016-04-04 at 21 05 09 
pm](https://cloud.githubusercontent.com/assets/1630096/14260084/0fbd98ae-faaa-11e5-8cab-446aaed9b52e.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: speedup iptables setup

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1449#issuecomment-204764789
  
@swill In the logs I see this:

```
{returns: [u'--2016-04-01 21:41:30--  http://www.google.com/', u'Resolving 
www.google.com... 2607:f8b0:4006:807::2004, 172.217.0.36', u'Connecting to 
www.google.com|2607:f8b0:4006:807::2004|:80... failed: Network is 
unreachable.', u'Connecting to www.google.com|172.217.0.36|:80... connected.', 
u'HTTP request sent, awaiting response... 302 Found', u'Location: 
http://www.google.ca/?gfe_rd=cr=Cuv-Vo3NLuih8wfM-b6oAw [following]', 
u'--2016-04-01 21:41:30--  
http://www.google.ca/?gfe_rd=cr=Cuv-Vo3NLuih8wfM-b6oAw', u'Resolving 
www.google.ca... failed: Connection timed out.', u"wget: unable to resolve host 
address 'www.google.ca'"]}
root: DEBUG: Result from SSH into the Virtual Machine: [u'--2016-04-01 
21:41:30--  http://www.google.com/', u'Resolving www.google.com... 
2607:f8b0:4006:807::2004, 172.217.0.36', u'Connecting to 
www.google.com|2607:f8b0:4006:807::2004|:80... failed: Network is 
unreachable.', u'Connecting to www.google.com|172.217.0.36|:80... connected.', 
u'HTTP request sent, awaiting response... 302 Found', u'Location: 
http://www.google.ca/?gfe_rd=cr=Cuv-Vo3NLuih8wfM-b6oAw [following]', 
u'--2016-04-01 21:41:30--  
http://www.google.ca/?gfe_rd=cr=Cuv-Vo3NLuih8wfM-b6oAw', u'Resolving 
www.google.ca... failed: Connection timed out.', u"wget: unable to resolve host 
address 'www.google.ca'"]
```

It resolved `google.com` but then gets redirected to `www.google.ca` which 
it cannot resolve due to a timeout. Looks like a local issue, indeed. In a 
newer version of the test we are testing the public gateway instead but that 
hasn't been merged / sent as PR I guess.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: speedup iptables setup

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1449#issuecomment-204532720
  
@kollyma Please squash the commits.
@swill Let's run integration tests on this before merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1425#issuecomment-204382745
  
@swill Congrats on the first bubble-tested PR :-) I would recommend posting 
the results though, the results.txt file shows which tests were run. If later 
we want to check, it's documented here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199270791
  
@milamberspace No back porting please :-) Just upgrade to 4.7, it's a 
painless 10min job.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-199270124
  
Guys, LGTMs or not, there were no integration test results posted so it 
shouldn't have been merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Worked around some possible runtime excep...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1444#issuecomment-198881402
  
This PR has some nice improvements, so that's great @rafaelweingartner! 

Still, I'm clueless why people merge without running a single integration 
test. When doing so, you risk making master unstable. You simply don't know if 
you broke something else unintentionally. When you run integration tests on 
another PR later on and that fails, you don't know whether it's that PR or it 
was master. We've been there, it's a pain. I'll leave it up to @swill to decide 
as I'm no longer RM. I'd have reverted it, for sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/780#issuecomment-198515978
  
@swill Please do proceed with revert, I totally agree.

`git revert -m 1 dc0ba6bd1a774d3ff4bc4a4dcc00e1434ab1f6e3` will do. Let me 
know if you need help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1437#issuecomment-195625848
  
I see your point @rafaelweingartner, no hard feelings here. If we simply 
always run the integration tests, there is no discussion whether or not we need 
to run them. Otherwise others will also state they don't need testing and we 
end up with all sorts of nasty bugs. Let someone verify it against a really 
hyperv box. And if we can't find anyone who cares to do this, I'll +1 a PR that 
removes hyperv all together ;-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1437#issuecomment-195620065
  
@GabrielBrascher based on what tests? It was only compiled.

I'm with @eriweb here, this should not go in without testing. Ask on the ML 
if someone with HyperV can confirm it still works and run at least 
`vm_life_cycle` integration tests.

@rafaelweingartner "There are things that do not need to be tested"? C'mon 
please.

To be clear: -1:-1: on this until we have done integration testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-195547692
  
If there's a Marvin integration test for this feature, I'm wondering why it 
succeeded without this fix. I think we might need to improve the test and show 
it's broken, then also show this PR fixes it. Anyone feels like fixing the test 
as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1429#issuecomment-193384072
  
@kiwiflyer Thanks, have seen this as well and will try your fix when I have 
some time :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1428#issuecomment-193383891
  
Hi @kiwiflyer, did you test this without MySQL HA as well? I doubt it will 
work without `mysql-connector-java`. Also, this most likely also needs to be 
fixed on other distributions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1094#issuecomment-190320208
  
Hi @nvazquez, when we run this in production weird stuff started to happen. 
This happened with VPCs that have a private gateway attached. It seemed to get 
confused and plugged nics in the wrong lswitches. We had to revert this change 
and it worked fine again. Before digging deeper, did you ever succeed creating 
a private gateway with this code base?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Improve ordering of fields of VPC router ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1422#issuecomment-187368247
  
@DaanHoogland I debugged so many routers recently that I think it's fair to 
say this info on the top is most valuable :-) But feel free to disagree.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Improve ordering of fields of VPC router ...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1422

Improve ordering of fields of VPC router detail tab

The field we use most are now on the top:
- name
- state
- hypervisor
- link local ip
- redundant state

The other fields are nice, but not needed most of the time.

Result:
![screen shot 2016-02-21 at 20 11 
49](https://cloud.githubusercontent.com/assets/1630096/13204809/37ce63c0-d8d9-11e5-8861-35c1c1a406cf.png)

Before:

![vpc_router_details_before](https://cloud.githubusercontent.com/assets/1630096/13204811/41510f10-d8d9-11e5-850f-549ab063.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
ui-vpc-routers-improvement_47

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1422


commit d2fdab0750468e21fda350bbed8f9d1d2c3f262f
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-21T19:20:56Z

Improve ordering of fields of VPC router detail tab

The field we use most are now on the top:
- name
- state
- hypervisor
- link local ip
- redundant state

The other fields are nice, but not needed most of the time.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1421#discussion_r53555783
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
 def __moveFile(self, origPath, path):
 if not os.path.exists(path):
 os.makedirs(path)
-timestamp = str(int(round(time.time(
-os.rename(origPath, path + "/" + self.fileName + "." + timestamp)
+
+zipped_file_name = path + "/" + self.fileName + "." + 
str(uuid.uuid4()) + ".gz"
--- End diff --

The filename becomes quite long in that case. The date is already in the 
meta data of the file, so one could use `ls -latr` to get it:

![screen shot 2016-02-20 at 20 29 
02](https://cloud.githubusercontent.com/assets/1630096/13198719/aa0d1982-d810-11e5-88c5-d833d738a442.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1421#issuecomment-186664554
  
Test result:
![screen shot 2016-02-20 at 19 35 
42](https://cloud.githubusercontent.com/assets/1630096/13198466/8c0c4b9e-d809-11e5-883b-b37b4beb53d9.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: zip the processed json files so we save d...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1421

zip the processed json files so we save diskspace

Zip the processed json files and make sure they're unique (timestamp is not 
unique).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
gzip-processed-json-router-config

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1421


commit 8b037169cbfc7f0e699ee593dd09f27f89a9
Author: Boris Schrijver <bschrij...@schubergphilis.com>
Date:   2016-02-20T12:39:42Z

zip the processed json files so we save diskspace




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1413#issuecomment-185635109
  
LGTM, based on the tests below. This runs in prod at SBP.

Test results:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === Test

[GitHub] cloudstack pull request: Fix unique mac address per rVPC router

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1413#issuecomment-184191105
  
@DaanHoogland A private gw uses a single ip address so there's your issue 
:-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix unique mac address per rVPC router

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1413#issuecomment-183729063
  
LGTM

Master router:

![pr1413_router1](https://cloud.githubusercontent.com/assets/1630096/13029502/bb27f23c-d28e-11e5-9060-ebce22b3f9e7.png)

Backup router before master destroy:

![pr1413_router2_before](https://cloud.githubusercontent.com/assets/1630096/13029504/c6da2776-d28e-11e5-8cee-d5e1fc24e81f.png)

Backup now master:

![pr1413_router2_after](https://cloud.githubusercontent.com/assets/1630096/13029507/cfb1ba62-d28e-11e5-8dd4-f60cb38ad62d.png)

What works fine now (and was broken before):
- eth2 (private gw) is only UP on master (used to be both UP on 
master/backup)
- eth2 has unique mac addresses on each router (used to be the same)
- a crash of router brings up private gw on new master

Integration tests are running as we spreak.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-183022736
  
Don't merge stuff without responding to the comments. Look at your commits, 
two with the same title? How does that help? I asked to squash them on Aug 14 
and now you just merge it... weird. I will revert it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9012 :automation of cores feat...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1011#issuecomment-182276612
  
@runseb Totally agree, reverted merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: automated 9277 9276 9275 9274 9273 9179 9...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1401#issuecomment-182276957
  
@runseb Keep an eye on this PR, it has the same ip address problem and I 
commented last week already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: prevent RTNETLINK errors as we were itera...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1404

prevent RTNETLINK errors as we were iterating over empty list

Error seen:
  RTNETLINK answers: File exists

Integration tests are running, will post results later.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack RTNETLINK-errors

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1404


commit 6769b9b7fed1ff732244dbe7e2fecfe24f008a14
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-08T15:04:54Z

prevent RTNETLINK errors as we were iterating over empty list

Error seen:
  RTNETLINK answers: File exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Check the existence of 'forceencap' param...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1402

Check the existence of 'forceencap' parameter before use

Check the existence of 'forceencap' parameter before use.

Error seen:

```
Traceback (most recent call last):
  File "/opt/cloud/bin/update_config.py", line 140, in 
process_file()
  File "/opt/cloud/bin/update_config.py", line 54, in process_file
finish_config()
  File "/opt/cloud/bin/update_config.py", line 44, in finish_config
returncode = configure.main(sys.argv)
  File "/opt/cloud/bin/configure.py", line 1003, in main
vpns.process()
  File "/opt/cloud/bin/configure.py", line 488, in process
self.configure_ipsec(self.dbag[vpn])
  File "/opt/cloud/bin/configure.py", line 544, in configure_ipsec
file.addeq(" forceencaps=%s" % CsHelper.bool_to_yn(obj['encap']))
KeyError: 'encap'
```


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack forceencap_check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1402


commit 4ad05d1ade9d98e3a1bd268bcc1d7a0f0767d26d
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-02-05T15:58:01Z

Check the existence of 'forceencap' parameter before use




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: automated 9277 9276 9275 9274 9273 9179 9...

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1401#discussion_r51845671
  
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -781,6 +781,15 @@
 "ostype": "CentOS 5.6 (64-bit)"
 
 },
+"coreos_volume": {
+"diskname": "Volume_core",
+
"urlvmware":"http://10.147.28.7/templates/coreos/coreos_production_vmware.ova;,
--- End diff --

If you add download links like this, no one else in the community will be 
able to run your test. Please check if you can use something that is available 
already, check openvm.eu for example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: automated 9277 9276 9275 9274 9273 9179 9...

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1401#discussion_r51846029
  
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -790,6 +799,26 @@
 "format": "OVA",
 "ispublic": "true"
 },
+"CentOS7template": {
+"displaytext": "Centos",
+"name": "Centos",
+"passwordenabled": False,
+"isdynamicallyscalable":True,
+"ostype": "CentOS 7",
+"url": "http://10.147.28.7/templates/cenots7/Centos7.vhd;,
--- End diff --

Would this work? 
http://dl.openvm.eu/cloudstack/centos/vanilla/7/x86_64/CentOS-7-x86_64-vanilla-xen.vhd.bz2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: WIP: adding dynamically routing cap...

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r51846623
  
--- Diff: setup/db/db/schema-471to480.sql ---
@@ -27,3 +27,10 @@ ALTER TABLE `cloud`.`image_store` MODIFY COLUMN `url` 
varchar(2048);
 ALTER TABLE `cloud`.`template_store_ref` MODIFY COLUMN `url` varchar(2048);
 ALTER TABLE `cloud`.`volume_store_ref` MODIFY COLUMN `url` varchar(2048);
 ALTER TABLE `cloud`.`volume_store_ref` MODIFY COLUMN `download_url` 
varchar(2048);
+
--- End diff --

Please use `schema-481to490.sql` instead as `4.8.0` is already released.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1386#issuecomment-179703172
  
Test results, tested together with #1383:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUC

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1383#issuecomment-179703106
  
Test results, tested together with #1386:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUC

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1400#issuecomment-179708000
  
The integration tests succeed and this results in a massive speed 
improvement for ACL rules. We've tested it with 500 and 1000 and it's like 
50-60 times faster. 

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === Test

[GitHub] cloudstack pull request: CLOUDSTACK-7836: Make s2s VPN CIDR list l...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1388


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8300: Set indexes on event tab...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1387

CLOUDSTACK-8300: Set indexes on event table

When there are many events in the cloud.event table, the UI throws an SQL 
exception and the management server spikes at 100% CPU for minutes. That causes 
other API calls to fail with 530 errors.

It seems an index on the 'archived' field is missing (since it is used in 
the WHERE clause).

We have 1.4M events in the table:
`select count(*) from event;`
1497838

This PR adds the index to the `archived` field and the `state` field.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack CLOUDSTACK-8300

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1387


commit 14c837ab8329f98b3fe071dd69807dcae77f4f7c
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-30T15:50:46Z

CLOUDSTACK-8300: Set indexes on event table




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-7836: Make s2s VPN CIDR list l...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1388

CLOUDSTACK-7836: Make s2s VPN CIDR list longer

We found the 200 char limit not sufficient. This should provide more room 
for longer CIDR lists.

123.123.123.123/24 ==> 18 chars + comma = 19 chars per cidr max

Was: 200/19 = ~10
Now: 4096/19 = ~215

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack CLOUDSTACK-7836

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1388


commit e767d44567e7a67e9b948390602a13fd9cc99aeb
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-30T17:58:18Z

CLOUDSTACK-7836: Make s2s VPN CIDR list longer

123.123.123.123/24 ==> 18 chars + comma = 19 chars per cidr max

Was: 200/19 = ~10
Now: 4096/19 = ~215




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1271#issuecomment-177167744
  
The problem is clear:
![screen shot 2016-01-30 at 13 35 
41](https://cloud.githubusercontent.com/assets/1630096/12695748/f207e5ce-c757-11e5-9097-d9b41b75d26f.png)

I tried with this patch but still see it appearing. Cleared cache and such 
but didn't help. Was anyone able to verify this?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1363#issuecomment-177145863
  
The commits that get reverted here were supposed to fix a findbugs issue. 
Will this reintroduce them? Can we both fix it and resolve the findbugs issue? 
Ping @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1386

CLOUDSTACK-9266: Make deleting static routes in private gw work

The to-be-deleted static routes were removed from the json file, instead of 
putting them there with revoke=true. The script that parses the json now 
doesn't find it and thus does not delete it.

Example after adding/removing some:
```
root@r-3-VM:/var/cache/cloud# cat /etc/cloudstack/staticroutes.json 
{
"1.2.3.0/24": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "1.2.3.0/24", 
"revoke": true
}, 
"1.2.3.4/32": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "1.2.3.4/32", 
"revoke": true
}, 
"1.2.33.3/32": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "1.2.33.3/32", 
"revoke": true
}, 
"1.22.2.2/32": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "1.22.2.2/32", 
"revoke": true
}, 
"10.1.2.1/32": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "10.1.2.1/32", 
"revoke": true
}, 
"10.1.200.0/25": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "10.1.200.0/25", 
"revoke": true
}, 
"10.11.12.13/32": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "10.11.12.13/32", 
"revoke": true
}, 
"172.16.1.3/32": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "172.16.1.3/32", 
"revoke": true
}, 
"172.16.15.14/32": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "172.16.15.14/32", 
"revoke": false
}, 
"172.16.17.0/25": {
"gateway": "172.16.0.1", 
"ip_address": "172.16.0.2", 
"network": "172.16.17.0/25", 
"revoke": false
}, 
"id": "staticroutes"
}
```

This results in:
```
root@r-3-VM:/var/cache/cloud# ip route show
default via 192.168.23.1 dev eth1 
169.254.0.0/16 dev eth0  proto kernel  scope link  src 169.254.1.67 
172.16.0.0/24 dev eth2  proto kernel  scope link  src 172.16.0.2 
172.16.15.14 via 172.16.0.1 dev eth2 
172.16.17.0/25 via 172.16.0.1 dev eth2 
192.168.23.0/24 dev eth1  proto kernel  scope link  src 192.168.23.4 
```

Two static routes left, the rest deleted:
```
172.16.15.14 via 172.16.0.1 dev eth2 
172.16.17.0/25 via 172.16.0.1 dev eth2 
```

That also matches the UI:

https://cloud.githubusercontent.com/assets/1630096/12693933/83e67d80-c71b-11e5-9241-9f478522b7a4.png;>



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
fix-del-private-gw-route

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1386


commit a40415604a9a8bbdc7833d850c4f74d66236d334
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-30T05:24:03Z

CLOUDSTACK-9266: Make deleting static routes in private gw work




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1383

CLOUDSTACK-9264: Make /32 static routes for private gw work

Static routes for private gateways that were /32 failed because the `route` 
command used had `-net` in it and a `/32` requires `-host` instead. I rewrote 
it to `ip` commands.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack slash32routefix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1383


commit 78c43669e5c175bf4bbe6b4857ec4c9fcd53b402
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-29T18:25:29Z

CLOUDSTACK-9264: Make /32 static routes for private gw work




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1383#issuecomment-176950230
  
Tested the following static routes:
https://cloud.githubusercontent.com/assets/1630096/12686942/1f0c9a3c-c6cd-11e5-9b65-60e813fdde47.png;>

Both show up fine now:
https://cloud.githubusercontent.com/assets/1630096/12686949/26a0d998-c6cd-11e5-9fa9-b89f0382a726.png;>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Display hostname the VPC router runs on

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1384

Display hostname the VPC router runs on

This is displayed on Infra tab and it's annoying that on the VPC page only 
the link local is mentioned and not the hostname. That is now corrected, so you 
have the correct details to login to the router straight away.

Before:
https://cloud.githubusercontent.com/assets/1630096/12687083/f7de5760-c6cd-11e5-9f62-cdf2cce8aeed.png;>

After:
https://cloud.githubusercontent.com/assets/1630096/12687088/fc4d1c1e-c6cd-11e5-8573-cdde638264f7.png;>

So the option 'Host' was added and displays the hypervisor the VPC runs on.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
ui-display-vpc-router-host

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1384


commit f6cb6a6286c6b7baa5e8ea99b7ec290e41dfb0cd
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-29T19:53:19Z

Display hostname the VPC router runs on

This is displayed on Infra tab and it's annoying that on the VPC
page only the link local is mentioned and not the hostname. That is
now corrected, so you have the correct details to login to the
router straight away.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: trailing commas in javascripts removed

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1288#issuecomment-176114078
  
@runseb We could see it as a bug, but I agree with @bhaisaab that it is a 
non-issue that was "fixed" to make SonarQube happy. Fine to do that straight on 
master IMHO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-176011491
  
@jayapalu The test may pass, but my manual (scripted cloudmonkey) test 
doesn't so we need to figure out what goes wrong. See my comments above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1261#issuecomment-175782752
  
@bhaisaab Why merge without running integration tests? How do we know this 
doesn't break anything else?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.9.0-SNAPSHOT in master b...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1369#issuecomment-174941848
  
I'll also add the upgrade paths to this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.8.1-SNAPSHOT in 4.8 bran...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1368#issuecomment-174941822
  
I'll also add the upgrade paths to this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.7.2-SNAPSHOT in 4.7 bran...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1367#issuecomment-174941786
  
I'll also add the upgrade paths to this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.7.2-SNAPSHOT in 4.7 bran...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1367

Set version to 4.7.2-SNAPSHOT in 4.7 branch

After releasing 4.7.1, next version is 4.7.2-SNAPSHOT in 4.7 branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 472_version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1367


commit bd523755086471b1cd525fa12745ee79a8210159
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-26T08:30:48Z

update debian changelog

commit a4ac9d3fff23814880dd0a337e7222fb9b489ef2
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-26T08:33:56Z

Updating pom.xml version numbers for release 4.7.2-SNAPSHOT

Signed-off-by: Remi Bergsma <git...@remi.nl>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.8.1-SNAPSHOT in 4.8 bran...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1368

Set version to 4.8.1-SNAPSHOT in 4.8 branch

After releasing 4.8.0, next version is 4.8.1-SNAPSHOT in 4.8 branch.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 481_version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1368


commit 32fcc4711793234a3ffd5e3834bd5d1eaf8e81bc
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-26T08:36:26Z

Updating pom.xml version numbers for release 4.8.1-SNAPSHOT

Signed-off-by: Remi Bergsma <git...@remi.nl>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.9.0-SNAPSHOT in master b...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1369

Set version to 4.9.0-SNAPSHOT in master branch

After releasing 4.8.0, next version is 4.9.0-SNAPSHOT in master branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 490_version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1369


commit 874ae0fbbba7545cd98c96723ab3abd52ad62254
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-26T08:42:02Z

Updating pom.xml version numbers for release 4.9.0-SNAPSHOT

Signed-off-by: Remi Bergsma <git...@remi.nl>

commit 2305c28f36d8ef974bad72efc529b532012c3a7d
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-26T08:44:02Z

update debian changelog




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.9.0-SNAPSHOT in master b...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1369#issuecomment-175051270
  
Tested the upgrade to `4.9.0` and that works fine:

```
2016-01-26 14:39:09,544 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) DB version = 4.8.1 Code Version = 4.9.0-SNAPSHOT
2016-01-26 14:39:09,545 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Database upgrade must be performed from 4.8.1 to 4.9.0-SNAPSHOT
2016-01-26 14:39:09,545 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Running upgrade Upgrade481to490 to upgrade from 4.8.1-4.9.0 to 4.9.0
2016-01-26 14:39:09,549 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-481to490.sql in the classpath
2016-01-26 14:39:09,549 DEBUG [c.c.u.s.Script] (main:null) (logid:) System 
resource: null
2016-01-26 14:39:09,550 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Classpath resource: 
file:/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-481to490.sql
2016-01-26 14:39:09,550 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Absolute path =  
/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-481to490.sql
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Licensed to the Apache Software Foundation (ASF) under one
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- or more contributor license agreements.  See the NOTICE file
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- distributed with this work for additional information
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- regarding copyright ownership.  The ASF licenses this file
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- to you under the Apache License, Version 2.0 (the
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- "License"); you may not use this file except in compliance
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- with the License.  You may obtain a copy of the License at
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2016-01-26 14:39:09,551 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--   http://www.apache.org/licenses/LICENSE-2.0
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Unless required by applicable law or agreed to in writing,
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- software distributed under the License is distributed on an
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- KIND, either express or implied.  See the License for the
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- specific language governing permissions and limitations
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- under the License.
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--;
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Schema upgrade from 4.8.1 to 4.9.0;
2016-01-26 14:39:09,552 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--;
2016-01-26 14:39:09,562 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Cleaning upgrades because all management server are now at the same 
version
2016-01-26 14:39:09,564 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Upgrading to version 4.9.0...
2016-01-26 14:39:09,564 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Cleanup upgrade Upgrade481to490 to upgrade from 4.8.1-4.9.0 to 4.9.0
2016-01-26 14:39:09,565 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-481to490-cleanup.sql in the classpath
2016-01-26 14:39:09,565 DEBUG [c.c.u.s.Script] (main:null) (logid:) System 
resource: null
2016-01-26 14:39:09,566 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Classpath resource: 
file:/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-481to490-cleanup.sql
2016-01-26 14:39:09,566 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Absolute path =  
/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-481to490-cleanup.sql
2016-01-26 14:39:09,566 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Licensed to the Apache Software Foundation (ASF) under one
2016-01-26 14:39:09,566 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- or more contributor license agreements.  See the NOTICE file
2016-01-26 14:39:09,566 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- distri

[GitHub] cloudstack pull request: Set version to 4.9.0-SNAPSHOT in master b...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1369#issuecomment-175092697
  
Tested `4.6.2` to `4.9.0` upgrade and that works as expected.

```
2016-01-26 16:00:36,899 DEBUG [c.c.u.d.VersionDaoImpl] (main:null) (logid:) 
Checking to see if the database is at a version before it was the version table 
is created
2016-01-26 16:00:36,909 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) DB version = 4.6.2 Code Version = 4.9.0-SNAPSHOT
2016-01-26 16:00:36,909 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Database upgrade must be performed from 4.6.2 to 4.9.0-SNAPSHOT
2016-01-26 16:00:36,909 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Running upgrade Upgrade461to470 to upgrade from 4.6.1-4.7.0 to 4.7.0
2016-01-26 16:00:36,913 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-461to470.sql in the classpath
2016-01-26 16:00:36,913 DEBUG [c.c.u.s.Script] (main:null) (logid:) System 
resource: null
2016-01-26 16:00:36,918 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Classpath resource: 
file:/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-461to470.sql
2016-01-26 16:00:36,918 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Absolute path =  
/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-461to470.sql
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Licensed to the Apache Software Foundation (ASF) under one
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- or more contributor license agreements.  See the NOTICE file
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- distributed with this work for additional information
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- regarding copyright ownership.  The ASF licenses this file
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- to you under the Apache License, Version 2.0 (the
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- "License"); you may not use this file except in compliance
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- with the License.  You may obtain a copy of the License at
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--   http://www.apache.org/licenses/LICENSE-2.0
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Unless required by applicable law or agreed to in writing,
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- software distributed under the License is distributed on an
2016-01-26 16:00:36,919 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
2016-01-26 16:00:36,920 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- KIND, either express or implied.  See the License for the
2016-01-26 16:00:36,920 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- specific language governing permissions and limitations
2016-01-26 16:00:36,920 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- under the License.
2016-01-26 16:00:36,920 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--;
2016-01-26 16:00:36,920 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Schema upgrade from 4.6.1 to 4.7.0;
2016-01-26 16:00:36,920 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--;
<>
2016-01-26 16:00:37,029 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-470to471.sql in the classpath
2016-01-26 16:00:37,029 DEBUG [c.c.u.s.Script] (main:null) (logid:) System 
resource: null
2016-01-26 16:00:37,030 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Classpath resource: 
file:/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-470to471.sql
2016-01-26 16:00:37,030 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Absolute path =  
/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-470to471.sql
2016-01-26 16:00:37,030 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Licensed to the Apache Software Foundation (ASF) under one
2016-01-26 16:00:37,030 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- or more contributor license agreements.  See the NOTICE file
2016-01-26 16:00:37,030 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- distributed with this work for additional information
2016-01-26 16:00:37,030 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- regarding copyright ownership.  The ASF licenses this file
2016-01-26 16:00:37,030 DEBUG [c.c.u.d.ScriptRunner] (main:null)

[GitHub] cloudstack pull request: Set version to 4.7.2-SNAPSHOT in 4.7 bran...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1367#issuecomment-174997795
  
Tried upgrade from `4.7.1` to `4.7.2` and that was successful:

```
2016-01-26 12:47:32,170 DEBUG [c.c.u.d.VersionDaoImpl] (main:null) (logid:) 
Checking to see if the database is at a version before it was the version table 
is created
2016-01-26 12:47:32,196 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) DB version = 4.7.1 Code Version = 4.7.2-SNAPSHOT
2016-01-26 12:47:32,197 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Database upgrade must be performed from 4.7.1 to 4.7.2-SNAPSHOT
2016-01-26 12:47:32,197 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Running upgrade Upgrade471to472 to upgrade from 4.7.1-4.7.2 to 4.7.2
2016-01-26 12:47:32,201 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-471to472.sql in the classpath
2016-01-26 12:47:32,201 DEBUG [c.c.u.s.Script] (main:null) (logid:) System 
resource: null
2016-01-26 12:47:32,202 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Classpath resource: 
file:/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-471to472.sql
2016-01-26 12:47:32,202 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Absolute path =  
/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-471to472.sql
2016-01-26 12:47:32,203 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Licensed to the Apache Software Foundation (ASF) under one
2016-01-26 12:47:32,203 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- or more contributor license agreements.  See the NOTICE file
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- distributed with this work for additional information
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- regarding copyright ownership.  The ASF licenses this file
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- to you under the Apache License, Version 2.0 (the
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- "License"); you may not use this file except in compliance
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- with the License.  You may obtain a copy of the License at
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--   http://www.apache.org/licenses/LICENSE-2.0
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Unless required by applicable law or agreed to in writing,
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- software distributed under the License is distributed on an
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- KIND, either express or implied.  See the License for the
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- specific language governing permissions and limitations
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- under the License.
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--;
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Schema upgrade from 4.7.1 to 4.7.2;
2016-01-26 12:47:32,204 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--;
2016-01-26 12:47:32,214 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Cleaning upgrades because all management server are now at the same 
version
2016-01-26 12:47:32,216 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Upgrading to version 4.7.2...
2016-01-26 12:47:32,216 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Cleanup upgrade Upgrade471to472 to upgrade from 4.7.1-4.7.2 to 4.7.2
2016-01-26 12:47:32,217 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-471to472-cleanup.sql in the classpath
2016-01-26 12:47:32,217 DEBUG [c.c.u.s.Script] (main:null) (logid:) System 
resource: null
2016-01-26 12:47:32,217 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Classpath resource: 
file:/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-471to472-cleanup.sql
2016-01-26 12:47:32,217 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Absolute path =  
/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-471to472-cleanup.sql
2016-01-26 12:47:32,218 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Licensed to the Apache Software Foundation (ASF) under one
2016-01-26 12:47:32,218 DEBUG [c.c.u.d.Scri

[GitHub] cloudstack pull request: Set version to 4.7.2-SNAPSHOT in 4.7 bran...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1367#issuecomment-174998354
  
Ping @DaanHoogland @borisroman Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.8.1-SNAPSHOT in 4.8 bran...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1368#issuecomment-175004288
  
Ping @borisroman @DaanHoogland Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Set version to 4.8.1-SNAPSHOT in 4.8 bran...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1368#issuecomment-175004146
  
Tested upgrade from `4.7.2` to `4.8.1` and that succeeded:

```
2016-01-26 13:06:13,421 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) DB version = 4.7.2 Code Version = 4.8.1-SNAPSHOT
2016-01-26 13:06:13,422 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Database upgrade must be performed from 4.7.2 to 4.8.1-SNAPSHOT
2016-01-26 13:06:13,422 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Running upgrade Upgrade471to480 to upgrade from 4.7.1-4.8.0 to 4.8.0
2016-01-26 13:06:13,425 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-471to480.sql in the classpath
2016-01-26 13:06:13,425 DEBUG [c.c.u.s.Script] (main:null) (logid:) System 
resource: null
2016-01-26 13:06:13,426 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Classpath resource: 
file:/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-471to480.sql
2016-01-26 13:06:13,426 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Absolute path =  
/data/git/cs2/cloudstack/client/target/utilities/scripts/db/db/schema-471to480.sql
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Licensed to the Apache Software Foundation (ASF) under one
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- or more contributor license agreements.  See the NOTICE file
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- distributed with this work for additional information
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- regarding copyright ownership.  The ASF licenses this file
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- to you under the Apache License, Version 2.0 (the
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- "License"); you may not use this file except in compliance
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- with the License.  You may obtain a copy of the License at
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--   http://www.apache.org/licenses/LICENSE-2.0
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Unless required by applicable law or agreed to in writing,
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- software distributed under the License is distributed on an
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- KIND, either express or implied.  See the License for the
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- specific language governing permissions and limitations
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- under the License.
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--;
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Schema upgrade from 4.7.1 to 4.8.0;
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
--;
2016-01-26 13:06:13,428 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`nicira_nvp_router_map` DROP INDEX `logicalrouter_uuid`  
2016-01-26 13:06:13,483 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`volume_host_ref` MODIFY COLUMN `url` varchar(2048) 
2016-01-26 13:06:13,496 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`object_datastore_ref` MODIFY COLUMN `url` varchar(2048) 
2016-01-26 13:06:13,507 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`image_store` MODIFY COLUMN `url` varchar(2048) 
2016-01-26 13:06:13,523 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`template_store_ref` MODIFY COLUMN `url` varchar(2048) 
2016-01-26 13:06:13,533 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`volume_store_ref` MODIFY COLUMN `url` varchar(2048) 
2016-01-26 13:06:13,544 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
ALTER TABLE `cloud`.`volume_store_ref` MODIFY COLUMN `download_url` 
varchar(2048) 
2016-01-26 13:06:13,568 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Running upgrade Upgrade480to481 to upgrade from 4.8.0-4.8.1 to 4.8.1
2016-01-26 13:06:13,569 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-480to481.sql in the classpath
2016-01-26 13:06:13,569 D

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1364#issuecomment-174863942
  

`cat /etc/cloudstack/staticroutes.json` before and after change:

Before always had one entry:


```
{
"10.135.255.10": {
"gateway": "10.135.255.129",
"ip_address": "10.135.255.10",
"network": "10.0.0.0/9",
"revoke": false
},
 }
```

After this PR:

```
{
"10.0.0.0/9": {
"gateway": "10.135.255.129",
"ip_address": "10.135.255.10",
"network": "10.0.0.0/9",
"revoke": false
},
"10.128.0.0/13": {
"gateway": "10.135.255.129",
"ip_address": "10.135.255.10",
"network": "10.128.0.0/13",
"revoke": false
},
}
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1364

CLOUDSTACK-9256 add unique key for static routes in json

Static routes that are being set do not show up in the static_routes.json 
file. The reason for this is that the index that is used, is the gateway 
address, which is not unique. Hence stuff is overwritten and lost.

Ping @borisroman @wilderrodrigues @DaanHoogland 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack CLOUDSTACK-9256

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1364


commit 62fc6fef97efb2c938737262cabb9254fca55ba1
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-25T16:17:55Z

CLOUDSTACK-9256 add unique key for static routes in json




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1279#issuecomment-174196682
  
For the record: the upgrade works:

```
2016-01-23 16:06:44,796 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) DB version = 4.6.2 Code Version = 4.7.1-SNAPSHOT
2016-01-23 16:06:44,797 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Database upgrade must be performed from 4.6.2 to 4.7.1-SNAPSHOT
2016-01-23 16:06:44,797 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Running upgrade Upgrade462to470 to upgrade from 4.6.2-4.7.0 to 4.7.0
2016-01-23 16:06:44,800 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking 
for db/schema-461to470.sql in the classpath
```

And then:
```
2016-01-23 16:06:44,803 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
-- Schema upgrade from 4.6.1 to 4.7.0;
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9245 - Cannot delete non-attac...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1358#issuecomment-174210065
  
Ping @borisroman 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9245 - Cannot delete non-attac...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1358#issuecomment-174210050
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```
Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
  

[GitHub] cloudstack pull request: UI: improve filter dropdown width

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1354#issuecomment-174215209
  
LGTM
https://cloud.githubusercontent.com/assets/1630096/12532310/4bf04906-c211-11e5-9120-0988f28ebc1c.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1279#issuecomment-174211604
  
@bhaisaab Let me rephrase: I tested your PR and that works :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9254: Make longer names displa...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1362

CLOUDSTACK-9254: Make longer names display pretty in UI

The arrow always fell off when I log in ;-)

Before change it looked like this:
https://cloud.githubusercontent.com/assets/1630096/12533043/f4e4baa8-c223-11e5-83ed-7e77bbce3a6c.png;>

Now also longer names display nicely:
https://cloud.githubusercontent.com/assets/1630096/12533051/19474d20-c224-11e5-85c4-8d5ba1b7e938.png;>

Ping @borisroman 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack ui-name-layout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1362


commit 0c8313acaa1e43bb9499ca01141811b119cae89f
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-23T21:50:22Z

CLOUDSTACK-9254: Make longer names display pretty




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-173863164
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```
Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
  

[GitHub] cloudstack pull request: Refactor system VM default network creati...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1359#issuecomment-173872832
  
@ProjectMoon Indeed! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1200#issuecomment-173955971
  
Ping @wilderrodrigues see answer above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1340#issuecomment-173357915
  
LGTM, wasn't able to check it with a Netscaler setup. Looks good and syntax 
of js is OK.
https://cloud.githubusercontent.com/assets/1630096/12462979/7f44d4c2-bfc1-11e5-8857-f0fd8f8fa133.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-173364862
  
@DaanHoogland This test is failing:

```
Test migrate VM ... === TestName: test_08_migrate_vm | Status : EXCEPTION 
===
ERROR
```

Details:
```
==
ERROR: Test migrate VM
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 
594, in test_08_migrate_vm
self.vm_to_migrate.migrate(self.apiclient, migrate_host.id)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 653, in 
migrate
apiclient.migrateVirtualMachine(cmd)
  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 772, in migrateVirtualMachine
response = self.connection.marvinRequest(command, 
response_type=response, method=method)
  File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", 
line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : 
u'2016-01-20T21:19:08+', cmd : 
u'org.apache.cloudstack.api.command.admin.vm.MigrateVMCmd', userid : 
u'95279fda-bed0-11e5-90a2-5254001daa61', jobstatus : 2, jobid : 
u'e7a1bb0f-39a5-4868-97c9-8fda5f8a8aa1', jobresultcode : 530, jobresulttype : 
u'object', jobresult : {errorcode : 530, errortext : 
u"org.libvirt.LibvirtException: internal error: process exited while connecting 
to monitor: 2016-01-20T21:19:09.852246Z qemu-kvm: Failed to start VNC server on 
`192.168.22.22:0,password': Failed to bind socket: Cannot assign requested 
address\n"}, accountid : u'95278d2a-bed0-11e5-90a2-5254001daa61'}
```

Tried the test again and it failed again. Can you investigate please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1346#issuecomment-173187438
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
FAILED ===
FAIL
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : FAILED ===
FAIL
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : FAILED ===
FAIL
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
...skipping...
Check the password file in the Router VM ... === Test

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1349#issuecomment-173194446
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== Test

[GitHub] cloudstack pull request: Enhance VR performance

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50251651
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
 self.conf.search(sline, line)
 
 def delete_leases(self):
-changed = []
-leases = []
 try:
-for line in open(LEASES):
-bits = line.strip().split(' ')
-to = {"device": bits[0],
-  "mac": bits[1],
-  "ip": bits[2],
-  "host": bits[3:],
-  "del": False
-  }
-changed.append(to)
-
-for v in changed:
-if v['mac'] == to['mac'] or v['ip'] == to['ip'] or 
v['host'] == to['host']:
-to['del'] = True
-leases.append(to)
-
-for o in leases:
-if o['del']:
-cmd = "dhcp_release eth%s %s %s" % (o['device'], 
o['ip'], o['mac'])
-logging.info(cmd)
-CsHelper.execute(cmd)
+open(LEASES, 'w').close()
--- End diff --

Instead of removing one entry, everything gets deleted and then the ones 
needed are added again later on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50251745
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
--- End diff --

We discussed that but there were some issues we need to investigate. This 
already improves it, once we figure out how to make it conditional we'll add a 
new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9195: Cancelled/failed async j...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1272#issuecomment-173205246
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== Test

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1352#issuecomment-172977865
  
@DaanHoogland I think we agree cloud-early-config needs major refactoring 
as it is one big copy/paste thing. Just don't think this is the time to do it.

All this does is pickup the public ip address and use it, like other parts 
also do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1352#issuecomment-173005222
  
`cloud-early-config` now logs:

```
Not setting up route of RFC1918 space to 192.168.22.1 befause 192.168.23.2 
is RFC1918..
```

Routes are not set as expected:
```
root@v-85-VM: # route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric RefUse 
Iface
0.0.0.0 192.168.23.10.0.0.0 UG0  00 eth2
169.254.0.0 0.0.0.0 255.255.0.0 U 0  00 eth0
192.168.22.00.0.0.0 255.255.255.0   U 0  00 eth1
192.168.23.00.0.0.0 255.255.255.0   U 0  00 eth2
```

And when it has a real public ip a route is set to the internal gw. That 
functionality still works and didn't change.

```
Setting up route of RFC1918 space to 192.168.22.1 
```

Routes are setup now:
```
root@v-1357-VM: # route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric RefUse 
Iface
0.0.0.0 x.y.227.1   0.0.0.0 UG0  00 eth2
10.0.0.0192.168.22.1255.0.0.0   UG0  00 eth1
169.254.0.0 0.0.0.0 255.255.0.0 U 0  00 eth0
172.16.0.0  192.168.22.1255.240.0.0 UG0  00 eth1
192.168.0.0 192.168.22.1255.255.0.0 UG0  00 eth1
192.168.22.00.0.0.0 255.255.255.0   U 0  00 eth1
 x.y.227.0  0.0.0.0 255.255.255.0   U 0  00 eth2
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1352#issuecomment-173002828
  
@nislim Can you please test the enhanced patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1352#issuecomment-173002681
  
Discussed with @DaanHoogland and he sent me a patch ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1321#issuecomment-172892988
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1321#issuecomment-172908360
  
@DaanHoogland This PR is better than the current situation and would 
improve even more if the whole check would disappear. If the PR is changed, 
I'll happily run the tests again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1352

CLOUDSTACK-9244 Fix setting up RFC1918 routes

Public ip var was empty so routes were always set. Corrected this.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
cloud-early-config-route-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1352


commit d6015700532c7c4676f4d402611fa4738cd4045d
Author: Remi Bergsma <git...@remi.nl>
Date:   2016-01-19T17:24:49Z

CLOUDSTACK-9244 Fix setting up RFC1918 routes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1338#issuecomment-172537670
  
@nitin-maharana I like it when you put screenshots, as this speeds up my 
testing because I can see what you mean. I will test it soon, can you help me 
by putting a screenshot so that I look for the right thing? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1334#issuecomment-172539609
  
LGTM, not tested actual Netscaler integration as I don't have such a setup.

I did check the syntax and saw the UI still renders properly.

![screen shot 2016-01-18 at 15 24 
26](https://cloud.githubusercontent.com/assets/1630096/12393696/9afbd25e-bdf7-11e5-92c7-101cbf1f3fc7.png)

![screen shot 2016-01-18 at 15 21 
56](https://cloud.githubusercontent.com/assets/1630096/12393657/5a8333b6-bdf7-11e5-9f23-2f12cfbc0e97.png)


![screen shot 2016-01-18 at 15 19 
56](https://cloud.githubusercontent.com/assets/1630096/12393652/548dd6fa-bdf7-11e5-90ac-925ee73029d0.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: trailing commas in javascripts removed

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1288#issuecomment-172533708
  
LGTM, UI seems to display OK.

![screen shot 2016-01-18 at 15 00 
56](https://cloud.githubusercontent.com/assets/1630096/12393165/516e8c2e-bdf4-11e5-9b79-8b0cd6855fc4.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui: improve metrics view implementation

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1347#issuecomment-172536210
  
LGTM, nice improvement @bhaisaab !

Some screenshots of my test env:

![screen shot 2016-01-18 at 15 09 
08](https://cloud.githubusercontent.com/assets/1630096/12393394/afbaa172-bdf5-11e5-927b-0cbe94236a3a.png)

![screen shot 2016-01-18 at 15 09 
16](https://cloud.githubusercontent.com/assets/1630096/12393398/b4349d7a-bdf5-11e5-9158-5cc197242a41.png)

![screen shot 2016-01-18 at 15 09 
57](https://cloud.githubusercontent.com/assets/1630096/12393399/b8065376-bdf5-11e5-8cdb-940d97b35464.png)

![screen shot 2016-01-18 at 15 10 
23](https://cloud.githubusercontent.com/assets/1630096/12393405/bb1b8be4-bdf5-11e5-9e2f-17652e044729.png)

![screen shot 2016-01-18 at 15 11 
57](https://cloud.githubusercontent.com/assets/1630096/12393433/da694d24-bdf5-11e5-88d4-f98bf7a50a32.png)







---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1338#issuecomment-172545747
  
LGTM based on these tests:

Situation before when not using Netscaler:

![screen shot 2016-01-18 at 15 37 
25](https://cloud.githubusercontent.com/assets/1630096/12394040/baae8bc6-bdf9-11e5-9443-23ff6f2c42cb.png)

![screen shot 2016-01-18 at 15 34 
47](https://cloud.githubusercontent.com/assets/1630096/12394036/b5cc0b38-bdf9-11e5-9fc2-c29197c504ee.png)

![screen shot 2016-01-18 at 15 34 
58](https://cloud.githubusercontent.com/assets/1630096/12394044/c048925c-bdf9-11e5-9188-b694f823332c.png)

Basically, the button is displayed but throws an ugly message.

After the fix in this PR the button is hidden:

![screen shot 2016-01-18 at 15 38 
46](https://cloud.githubusercontent.com/assets/1630096/12394060/cffca7f6-bdf9-11e5-9c87-7cc739f5cc8e.png)

Didn't test if it shows when using Netscaler, as I don't have it in my test 
environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---