Re: Daisy notification messages
On Thu, 2007-08-23 at 09:27 +0200, Reinhard Poetz wrote: Grzegorz Kossakowski wrote: I must missed it because there was no notification about this document on our docs list thus commenting now. Does anybody know why we don't receive any notification mails from Daisy? I've checked the dsy_list_listener user and it is configured correctly. I'll look at it (right now). There was a problem with the default ActiveMQ configuration included with Daisy 1.5, causing this problem. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Daisy notification messages
On Thu, 2007-08-23 at 10:06 +0200, Bruno Dumon wrote: On Thu, 2007-08-23 at 09:27 +0200, Reinhard Poetz wrote: Grzegorz Kossakowski wrote: I must missed it because there was no notification about this document on our docs list thus commenting now. Does anybody know why we don't receive any notification mails from Daisy? I've checked the dsy_list_listener user and it is configured correctly. I'll look at it (right now). There was a problem with the default ActiveMQ configuration included with Daisy 1.5, causing this problem. Seems there's another problem too: Could not connect to SMTP host: hermes.apache.org, port: 25 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Problem with Daisy or sitemaptags2daisy tool
On Tue, 2007-06-12 at 13:26 +0200, Grzegorz Kossakowski wrote: Hi, I tried to run sitemaptags2daisy tool, it failed throwing this exception: Exception in thread main org.outerj.daisy.repository.RepositoryException: Received exception from repository server. at org.outerj.daisy.repository.clientimpl.infrastructure.DaisyHttpClient.handleNotOkResponse(DaisyHttpClient.java:154) at org.outerj.daisy.repository.clientimpl.infrastructure.DaisyHttpClient.executeMethod(DaisyHttpClient.java:85) at org.outerj.daisy.repository.clientimpl.RemoteDocumentStrategy.store(RemoteDocumentStrategy.java:217) at org.outerj.daisy.repository.commonimpl.DocumentImpl.save(DocumentImpl.java:383) at org.outerj.daisy.repository.commonimpl.DocumentImpl.save(DocumentImpl.java:368) at org.apache.cocoon.documentation.daisy.SitemapTagsToDaisy.updateDocument(SitemapTagsToDaisy.java:545) at org.apache.cocoon.documentation.daisy.SitemapTagsToDaisy.createDocument(SitemapTagsToDaisy.java:551) at org.apache.cocoon.documentation.daisy.SitemapTagsToDaisy.run(SitemapTagsToDaisy.java:145) at org.apache.cocoon.documentation.daisy.SitemapTagsToDaisy.main(SitemapTagsToDaisy.java:82) Caused by: org.outerj.daisy.repository.clientimpl.infrastructure.DaisyPropagatedException: [org.outerj.daisy.repository.RepositoryException] Problem storing document. Caused by: org.outerj.daisy.repository.clientimpl.infrastructure.DaisyPropagatedException: [com.mysql.jdbc.MysqlDataTruncation] Data truncation: Data truncated for column 'stringvalue' at row 1 This error can occur when the maximum field length (255 characters) is exceeded. Any context as to what class it was processing? Most likely one of the annotations has a very long value. We could look into adding a check on this so that a more user-friendly message is thrown. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [docs] Documentation for sitemap components from 2.1 lost?
On Mon, 2007-06-04 at 16:16 +0200, Alexander Klimetschek wrote: Hi, I just wanted to add some useful note to the documentation for the XIncludeTransformer (Note that the path in the href is RELATIVE to the current document!), but as I see, the 2.2 docs on cocoon.zones.apache.org/daisy for sitemap components don't contain the text of the 2.1 docs. E.g the 2.1 documentation for xinclude transformer (http://cocoon.apache.org/2.1/userdocs/xinclude-transformer.html) is quite long, but for 2.2 (http://cocoon.zones.apache.org/daisy/cdocs-core/g2/g2/Transformer/985.html) it just says Implementation of an XInclude transformer. along with the standard reference (ie. class name) and No documentation available yet.. I always thought for sitemap compenents the javadoc of that class is used, but in this case the javadoc for xincludetransformer is quite short as well (but has yet another text). Only some information is extracted from the source files, see the section on sitemap component documentation at http://cocoon.zones.apache.org/daisy/cdocs-site-main/g4/1273.html So is there any place to retrieve the old 2.1 docs from? Would make documentation much harder when all those components have to be redocumented again ;-) No, seriously, it would be easier for people like me to add/improve docs when that 2.1 content would be on current daisy (where I do have rights to edit things). All 2.1 docs are in Daisy at: http://cocoon.zones.apache.org/daisy/legacydocs/654.html for XInclude: http://cocoon.zones.apache.org/daisy/legacydocs/documentation/userdocs/sitemap-components/transformers/core/xinclude-transformer.html So you could copy the old text to the new document. Hint: when copying content between documents, it is best to open the source document also in the editor, and copy the text from the editor, rather than from the published view. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Too many emails from Daisy
On Wed, 2007-01-31 at 07:54 +0100, Reinhard Poetz wrote: Carsten Ziegeler wrote: Although the title of this email might look like spam, it's not spam but it is about spam :) It seems that Daisy is sending changes emails over and over again to the docs mailing list. Does anyone know why yes, whenever it is restarted, the mail queue is worked off again. I guess it is a bug of the particular milestone release that we use as I don't see this behaviour in my company's Daisy instances which run on Daisy 1.5.1. and more important how to stop this? no idea, I would do it if I had an idea. Bruno? As Steven pointed out, it's probably some problem caused by ActiveMQ resending messages. I'd suggest you (or I) stop the repository server, drop the tables in the activemq database, and restart the repository server. The problem will probably re-occur after a while, but at least this should remove most of the problem for now. I don't think upgrading Daisy will change much about this problem, we'll have a closer look at it in the next days/week. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: cforms dojo updates: calendar, help and validation messages, multivalue editor
On Thu, 2007-01-25 at 18:34 +0100, Grzegorz Kossakowski wrote: Bruno Dumon napisał(a): On Thu, 2007-01-25 at 17:39 +0100, Grzegorz Kossakowski wrote: I think you forgot your [1] link. Sorry, here it goes: http://thread.gmane.org/gmane.text.xml.cocoon.user/59615 I'm aware that this particular problem has other reason that need to be fixed but this shows exactly what happens were there is no js. All the things I've changed were already Javascript based, so I see little problems there. It's of course possible to override the default XSLs to do something non-javascript based. I know, but AFAIR before dojo transition if js had failed to load validation still have been displayed. Or it wasn't the case then? Ah yes. That could be easily fixed by adding the validation error icon as part of the widget-defining element (i.e. the element that gets replaced by the dojo widget). What is more important, if there is any agreement on treating this kind of issues? Should we just require JS for Forms or try create html output that easily fallbacks if there is no js? Is it possible and worth the effort? Some stuff simply requires javascript (popups, datepickers, etc). But you're right that the validation error icon should always be displayed, even if the js fails to load. Not sure if you want more than this? -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: cforms dojo updates: calendar, help and validation messages, multivalue editor
On Thu, 2007-01-25 at 17:39 +0100, Grzegorz Kossakowski wrote: Bruno Dumon napisał(a): Hi, I've replaced the calendar, the help and validation message popups and the multi-value editor with dojo-based implementations. Thanks to Jeremy for upgrading to dojo 0.4, which made this possible and easier. snip/ If anyone notices problems, feel free to fix or report them. I would like to ask if Forms are still supposed to work without JS enabled? If so there is an issue with validation errors, see [1]. I think it's quite easy to fix this particular issue (I can take care of it) but I would like to know about general guidelines. Also there is still issue with loading forms resources in C2.2, but it's topic for another thread. I'll start it now. I think you forgot your [1] link. All the things I've changed were already Javascript based, so I see little problems there. It's of course possible to override the default XSLs to do something non-javascript based. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: cforms dojo updates: calendar, help and validation messages, multivalue editor
On Thu, 2007-01-25 at 19:02 +0100, Grzegorz Kossakowski wrote: Bruno Dumon napisał(a): On Thu, 2007-01-25 at 18:34 +0100, Grzegorz Kossakowski wrote: Ah yes. That could be easily fixed by adding the validation error icon as part of the widget-defining element (i.e. the element that gets replaced by the dojo widget). Could you take care of it or should I apply the patch? I could have a look at it in the weekend, but a patch is welcome. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
cforms dojo updates: calendar, help and validation messages, multivalue editor
Hi, I've replaced the calendar, the help and validation message popups and the multi-value editor with dojo-based implementations. Thanks to Jeremy for upgrading to dojo 0.4, which made this possible and easier. For the first 3, these now use dojo's popup-things, which has the user-visible advantages of using a backing iframe in IE (so the popups are displayed on top of other input fields), correct positioning of the popups in IE, and at most one popup is open at the same time. Since validation messages are also displayed via these popups, any mixed content in them will now be preserved. For the calendar, it now supports date, time, and datetime selection, this is driven by the 'variant' attribute of the formatting date convertor. As before, the server-side date/time patterns are also also used on the client. The calendar is internationalized, for the precise supported languages see the dojo-languages parameter in form-field-styling.xsl. If anyone notices problems, feel free to fix or report them. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: CForms problem
On Sat, 2007-01-20 at 18:24 +0100, Philipp Zerelles wrote: On Saturday 20 January 2007 18:04, Bruno Dumon wrote: On Sat, 2007-01-20 at 17:14 +0100, Philipp Zerelles wrote: I found a problem in CForms that seems to be known already but not really addressed. When I have a CForm and go to a completely different page from there and then come back using the continuation, my form input fields are cleared because there are no request-parameters and a null value is treated as if the request-parameter was set empty. The real problem with this is that the validation is triggered as well and errors may be shown although there are none. This is the part in org.apache.cocoon.forms.formmodel.Field that is responsible for that: // FIXME: Should we consider only non-null values? // Although distinguishing an empty value (input present but blank) from a null value // (input not present in the form) is possible, this distinction is not possible for // several other kinds of widgets such as BooleanField or MultiValueField. So we keep // it consistent with other widgets. //if (newEnteredValue != null) { readFromRequest(newEnteredValue); //} Are the values the form had when last posted not still stored in the widget? After a failed submit I mean. This code always will overwrite them with empty values if coming back without request-parameters. What do you think about that? Seems normal behaviour to me. If you want to go back to the form, the form shouldn't do a 'form process' cycle, it should simply display the form. For most forms, this can best be done by making a distinction between http GET (display form) and POST (process form) requests. For those cases where a GET makes more sense (e.g. a search form), the parameters should simply be in the URL. Ok, that makes sense. But currently, the 'form process' cycle is started always when coming back to a continuation, even for http GET. Yes, that seems to be a bit of a problem in flowscript-library. I didn't study it in detail, but it would probably be possible to add some property to the forms object to configure whether it should form processing on post. If it itches you enough, you could look into patching the Form.js. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: CForms problem
On Sat, 2007-01-20 at 17:14 +0100, Philipp Zerelles wrote: I found a problem in CForms that seems to be known already but not really addressed. When I have a CForm and go to a completely different page from there and then come back using the continuation, my form input fields are cleared because there are no request-parameters and a null value is treated as if the request-parameter was set empty. The real problem with this is that the validation is triggered as well and errors may be shown although there are none. This is the part in org.apache.cocoon.forms.formmodel.Field that is responsible for that: // FIXME: Should we consider only non-null values? // Although distinguishing an empty value (input present but blank) from a null value // (input not present in the form) is possible, this distinction is not possible for // several other kinds of widgets such as BooleanField or MultiValueField. So we keep // it consistent with other widgets. //if (newEnteredValue != null) { readFromRequest(newEnteredValue); //} Are the values the form had when last posted not still stored in the widget? After a failed submit I mean. This code always will overwrite them with empty values if coming back without request-parameters. What do you think about that? Seems normal behaviour to me. If you want to go back to the form, the form shouldn't do a 'form process' cycle, it should simply display the form. For most forms, this can best be done by making a distinction between http GET (display form) and POST (process form) requests. For those cases where a GET makes more sense (e.g. a search form), the parameters should simply be in the URL. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: RFC: CForms Roadmap
Hi Jeremy, On Sun, 2007-01-07 at 13:01 +, Jeremy Quinn wrote: Hi All Now that Cocoon 2.1.11-dev runs Dojo 0.4.1, I think we have a solid platform to complete the modernisation of CForms client-side code. snip/ Replacements : Date/Time widget : replace MattKruse stuff with Dojo's implementation. I'm going to need this in the next couple of weeks, so it's very likely I'll work on this. Help validation popups: replace MattKruse stuff with a new Dojo implementation. I've got something like this in Daisy already, it seems to work quite well, so I could move it into CForms. MultiValue Editor: re-implement as a Dojo widget This is also one I'm motivated to work on, since I wrote it originally. I still need to get up-to-date with dojo 0.4 and the current cforms, but if all goes well I hope to be able to do something about these 3. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
RE: WildcardMatcherHelper caching issue
Ard, What is cached is the pattern, not the string to be matched against it, so what you describe isn't a problem IIUC. On Mon, 2007-01-08 at 10:30 +0100, Ard Schrijvers wrote: Hello, think I kind of missed this WildcardMatcherHelper untill now. From which cocoon version on is this available? Can you define in your matcher wether it should use this WildcardMatcherHelper, or is this by default? Regarding the caching, currently it would seem to me like a very possible memory leak. What if I have something like map:part element=othermatcher value=cocoon://foo/{date:MMddHHmmssSS}/ or if you have an active forum build with cforms, and 2ervw3verv452345435wdfwfw.continue patterns are cached (or is it only for caching pipelines?) This would imply a new cached pattern for every request. Of course, the thing above with the date is stupid, but it is too easy to create memory leaks for a user. The solution that a user should choose between caching or noncaching WildcardMatcherHelper seems to me to difficult for an average user to make a judgement on this. The option about a WeakHashMap should be some sort of SoftHashMap (SoftRef) instead. WeakReferences are deleted when no longer a strong ref is available, so either there would be a strong ref (implying the same memory leak) or there whould be no strong ref, so all cached patterns are removed on every gc. With SoftReferences they are only removed when jvm decides to do so (when low on memory). But, IMO, it is not ok to have the jvm possibly go low on memory, and the jvm to remove cached patterns at random (more sense it makes, to have the most used patterns kept in memory). I really think the best way is some simple LRUMemoryStore with a maxitems configured by default to 1000 or something, and possibly overridden for the user who knows more about it. Default, every user can easily work with it without having to think about it. Regards Ard -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
RE: WildcardMatcherHelper caching issue
On Mon, 2007-01-08 at 11:52 +0100, Ard Schrijvers wrote: Ard, What is cached is the pattern, not the string to be matched against it, so what you describe isn't a problem IIUC. I already was a little amazed. But then, who is using always-changing patterns? Like in dynamic sitemaps or something? Do not really see this possible memory leak in here.. There is no real issue here for Cocoon indeed, I was just nitpicking that I prefered a design whereby the user of the wildcard matcher is responsible for the caching, just as is the case for regexp's or XSLT's or whatever. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: WildcardMatcherHelper caching issue
On Sat, 2007-01-06 at 01:03 +0100, Alfred Nathaniel wrote: On Fri, 2007-01-05 at 13:45 +0100, Bruno Dumon wrote: Hi, I noticed the new WildcardMatcherHelper class holds an internal static map for caching. In the older solution, it was up to the caller to cache the compiled pattern (similar to how regexp libraries work). This had the advantage that the caller itself can decide whether the pattern should be cached. It also avoids a potential memory leak if this code is used to evaluate always-changing patterns, and avoids the need to do hashmap lookups. So I'm wondering if anyone would mind if I change it back so that caller caches the pattern? Thanks for any input. The integrated cache is a convenience for the many client who repeated match the same pattern and gain performance without having to code their own cache management. If you have an application where you will be matching a lot of one-shot patterns, you could add public static Map match(String pat, String str, Map cache) which can be called with a null Map to by-pass caching. The old signature then becomes simply public static Map match(String pat, String str) { return match(pat, str, cache); } The built-in cache could also use a WeakHashMap to avoid ever-increasing memory consumption. Thanks for the info. I don't actually have an immediate use for one-shot patterns, however I'm using the wildcard matcher and noticed the change. I thought the compiled patterns were usually just kept in instance variables, hardly deserving to be called cache management, though I must admit I didn't study how it is done everywhere. Having this cache inside the WildcardMatcherHelper seemed like a step back to me. But if needed non-caching behaviour can indeed be added later again while keeping the convenience of the default cache. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
WildcardMatcherHelper caching issue
Hi, I noticed the new WildcardMatcherHelper class holds an internal static map for caching. In the older solution, it was up to the caller to cache the compiled pattern (similar to how regexp libraries work). This had the advantage that the caller itself can decide whether the pattern should be cached. It also avoids a potential memory leak if this code is used to evaluate always-changing patterns, and avoids the need to do hashmap lookups. So I'm wondering if anyone would mind if I change it back so that caller caches the pattern? Thanks for any input. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Vote] Use latest rhino in 2.1.x
Hi, This vote passed with lots of +1 and no -1. Just in case anyone is working on the same: I could look into doing the upgrade tomorrow. On Thu, 2006-11-16 at 13:11 +0100, Carsten Ziegeler wrote: Ok, it seems we should vote on this topic. As you all know, including the version of rhino in 2.1.x has legal problems and we have to do something about it. Fortunately, the latest version of Rhino is licenced under an acceptable term, so we could include that version in 2.1.x. Unfortunately this creates minor incompatibilites and might infect people using specific functions in flowscript. On the other hand, if we insist on using the current version we can't include rhino in our releases, split out the flow stuff from core, make it available separately, force people to download it and download rhino from somewhere else...and so on. So in the end we have to decide which solution hurts less for our users. It seems that we think that using the latest version of rhino is less pain, so let's vote on this. Please cast your votes for using latest rhino in 2.1.x. Carsten -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Vote] Use latest rhino in 2.1.x
On Thu, 2006-11-16 at 13:11 +0100, Carsten Ziegeler wrote: Ok, it seems we should vote on this topic. As you all know, including the version of rhino in 2.1.x has legal problems and we have to do something about it. Fortunately, the latest version of Rhino is licenced under an acceptable term, so we could include that version in 2.1.x. Unfortunately this creates minor incompatibilites and might infect people using specific functions in flowscript. On the other hand, if we insist on using the current version we can't include rhino in our releases, split out the flow stuff from core, make it available separately, force people to download it and download rhino from somewhere else...and so on. So in the end we have to decide which solution hurts less for our users. It seems that we think that using the latest version of rhino is less pain, so let's vote on this. Please cast your votes for using latest rhino in 2.1.x. +1 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Ajax-block: what's the purpose of node.xml?
On Tue, 2006-08-22 at 18:07 +0200, Carsten Ziegeler wrote: Sylvain Wallez schrieb: Carsten Ziegeler wrote: The importNode() function in the insertion.js of our ajax block has a text for node.xml - what does this actually check? It checks a IE-specific feature that allows to get the representation of a node and its children as serialized XML document (as a String). Now, it seems that in some cases this check evaluates to true which results in buggy element nodes which are unusable in IE. That was precisely meant for IE. What version are you using? 6.0 Can we remove this check? IIRC IE had some issues with namespaces in the importNode function, but I also see that this function has namespace-aware DOM function commented out. So I don't know... The interesting thing is that it seems to depend on the xml structure returned by the server whether node.xml works or not. And if node.xml works, the result is wrong. I used a workaround by switching to the _importNode function. So if noone really knows why we test there, I guess we can remove this test. If noone is against it I will remove it. (IIRC...) The reason _importDomNode is not used in IE is because IE will not recognize/evaluate HTML attributes with special meaning such as 'style' and 'onclick' etc (a well-known annoying problem, if you google a bit around). Thus if the HTML returned from the server uses any of these attributes, you'll quickly notice they won't work anymore. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Cocoon 2.2 and Java 5
On Tue, 2006-08-08 at 09:25 +0200, Bertrand Delacretaz wrote: On 8/8/06, Reinhard Poetz [EMAIL PROTECTED] wrote: ...What do people think about making Java 5, which was released almost _2 years ago_, the minimum requirement for trunk?.. I'm ok as long as 2.1.x continues to run on JDK 1.4 (which shouldn't be a problem as 2.1.x is not supposed to evolve much). I thought the minimum for 2.1.x is still JDK 1.3 (!). +1 for 1.5 for trunk. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Vote] Java 5 as minimum JDK requirement
On Tue, 2006-08-08 at 15:14 +0200, Reinhard Poetz wrote: As Java 5 was released almost 2 years ago, I propose making it the minimum requirement for trunk and all artifacts released from there. +1 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [vote] Use servlet API 2.4 in trunk
On Tue, 2006-08-08 at 17:33 +0200, Reinhard Poetz wrote: I propose switching to servlet API 2.4 in *trunk*. This shouldn't cause any problems as a stable version of Tomcat (5.0.16), the reference implementation for servlet containers, is available since Dec, 4th 2003. +1 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Another docs question...
On Tue, 2006-07-25 at 14:48 -0700, Mark Lundquist wrote: Are the docs on the Daisy site for 2.2, or for 2.1.X? Both: These should be for 2.2: http://cocoon.zones.apache.org/daisy/documentation/659.html and these for 2.1: http://cocoon.zones.apache.org/daisy/legacydocs/654.html though some documents (like those about the forms) are shared between both. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Doc] last version?
On Fri, 2006-07-21 at 13:37 -0700, Mark Lundquist wrote: __ Hi, I am contributing with edits made using the doc-editors role (i.e., I know that my changes don't get published live when I save them, even if the publish immediately box is checked). But still there is something I don't understand... After I save my edits, I'm returned to the document page, annotated with this: WARNING: you are looking at the live version of this document, which is currently not the last version. (Fair enough...) If I then click on the last version link, the version displayed shows this: WARNING: you are not looking at the live version but at the last version. (OK...) However... it still looks just like the live version to me, it doesn't have my changes. If I go here: http://cocoon.zones.apache.org/daisy/documentation/864/forms/binding/488/versions.html ...then I see Version 5 as the version containing my changes. If I click on the link to view version 5, it shows with the note claiming it to be the last version, as before, and it is missing my changes. But... in the versions listing I can click on the diffs and see my changes. And... if I edit the page, the version that comes up in the editor includes my changes. Is this a bug? yep, it's the bug I mentioned in my earlier reply. I have some time this afternoon, I'll look into upgrading Daisy then, so that this bug will be gone. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[daisy] upgrading Daisy on cocoon zone
Hi, I'll start now on upgrading Daisy on the cocoon zone to version 1.5-M2. It's best not to edit anything untill I'm done, since your editing session will be lost when restarting Daisy after the upgrade. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [daisy] upgrading Daisy on cocoon zone -- DONE
On Sat, 2006-07-22 at 13:26 +0200, Bruno Dumon wrote: Hi, I'll start now on upgrading Daisy on the cocoon zone to version 1.5-M2. It's best not to edit anything untill I'm done, since your editing session will be lost when restarting Daisy after the upgrade. The upgrade is done. If you've recently (5 hours) used Daisy, especially the editor, then it's best to clear your browsers' cache or to force-refresh when on the editor page. Something that's new and interesting, especially for persons with only the 'editor' role, is that you can switch to a 'staging' view of the site. This will show by default the last versions of all documents (also influences the navigation tree, queries embedded in pages, etc.). This switch is done by clicking on the LIVE/STAGING indicator in the right of the menubar. If you notice any problems after this upgrade, don't hesitate to report them. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Daisy] Link to new document?
On Tue, 2006-07-18 at 12:06 -0700, Mark Lundquist wrote: Hi, sorry for such a lame question... I was unsure whether to post this here or to the Daisy list... Anyway, playing with my brand new doc:editor role on the Cocoon docs Daisy site... when I use the Link to new document button in the editor toolbar, everything seems to work OK, and I get what looks like a link. But then, how do I edit the newly created document, if indeed there is one? This is the document you created: http://cocoon.zones.apache.org/daisy/documentation/1165.html The Daisy version currently running on the zone has a bug due to which it is only possible to view the live version of documents. Since with your permissions you're not allowed to publish the document as live, it is not possible to view what your wrote (except by opening the document in the editor). I'll look into updating the Daisy on the zone in one of the next weeks. I tried clicking on the link, and it took me to www.daisy.com! :-) Seriously. Where did you click on the link? In the editor, you can't click on the link (there's a special 'open' button on the toolbar to open the link), and you didn't save the document containing the link AFAICS (and in any case, due to the bug mentioned above, you wouldn't see the content containing the link anyhow). -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[jira] Commented: (COCOON-1879) Make fd:field whitespace trimming behavior configurable
[ http://issues.apache.org/jira/browse/COCOON-1879?page=comments#action_12420112 ] Bruno Dumon commented on COCOON-1879: - Looks good. I'd validate the value of the whitespace attribute so that it gives an error when using an unsupported value (to protect against typos). I'd also avoid doing string comparisons to check the type of whitespace trimming (e..g trimming.equals(preserve)), since these are relatively expensive (though for these short strings, it won't matter much). Something that solves both problems, is the use of an enumeration class, following the type-safe enumeration pattern, as described at e.g. http://java.sun.com/developer/Books/shiftintojava/page1.html Thus a class like: public class Whitespace { public static final Whitespace PRESERVE = new Whitespace(preserve); public static final Whitespace TRIM_START = new Whitespace(trim-start); private final String name; private Whitespace(String name) { this.name = name; } public String toString() { return name; } } and as described in the linked article, one can then simply use e.g. trimming == Whitespace.PRESERVE to test the sort of trimming. With this change, this patch will be ready to commit, so if you have SVN access already, you can do that yourself. Don't forget to mention the change in status.xml, and update the docs in Daisy: http://cocoon.zones.apache.org/daisy/documentation/864/forms/widgets/481.html Make fd:field whitespace trimming behavior configurable --- Key: COCOON-1879 URL: http://issues.apache.org/jira/browse/COCOON-1879 Project: Cocoon Type: Improvement Components: Blocks: Forms Versions: 2.2-dev (Current SVN), 2.1.10-dev (current SVN) Reporter: Jason Johnston Attachments: COCOON-1879.diff Currently fd:field widgets always trim leading and trailing whitespace from the user's input. Sometimes this behavior is not desired, so it should be configurable. See this thread for discussion: http://marc.theaimsgroup.com/?t=11496023148r=1w=2 Patch forthcoming. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: SessionReplication
On Fri, 2006-06-30 at 12:05 +0200, Reinhard Poetz wrote: Matthew Langham wrote: Hi, Can someone tell me if the current state of Session Replication in Cocoon is still as described in: http://wiki.apache.org/cocoon/FlowscriptAndSessionReplication ? If so - 1. Is this any different in 2.2? no 2. Has anyone looked at how long it would take to fix this? 3. If I don't use Flowscript in my application - does SessionReplication work? Currently the best bet is using Apples as controller and put only Serializable objects into the session. Just to clarify/expand, apples are stateful too and are managed by the same continuationsmanager as flowscript continuations. It is possible to have stateless apples, but that's just so that stateless interactions could be written similarly to the stateful interactions. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
RE: [CForms] Tree widget based on XML document
On Mon, 2006-06-19 at 11:56 +0200, Martijn C. Vos wrote: Bruno Dumon [mailto:[EMAIL PROTECTED] wrote: I think Cocoon only needs one tree model and that is a tree model based on XML. The selection-list widget has the possibility to declare static content in the form definition and can also refer to an xml document in the src attribute. Something like that would be nice for the tree widget. I don't see why the tree widget should be limited to XML models only, the selection list isn't limited to that either (see e.g. the jxpath selection list). Dictating to use XML would again require needless conversions from Java to XML when it is not needed. I don't think it should necessarily be the only one, but it definitely should be the default tree. Sure, that would make sense. Everything can be converted to XML, and Cocoon is designed around XML. The only reason to use something else is to skip a conversion step and save a bit of time, but unlike the current trees, a good XML tree can do anything. mcv. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [CForms] Tree widget based on XML document
On Sun, 2006-06-18 at 11:03 +0200, Bruno Dumon wrote: Hi, On Thu, 2006-06-15 at 23:49 +0200, Fred Vos wrote: snip/ Another thing that is necessary is the possibility to add key-value pairs to every folder and node, available in the form template. To create a directory tree with directories and files, showing filename, size, date et cetera, then requires the use of a directory generator and transforming its output to an xml document that can be used in the tree widget. I don't think the current tree model implementation forbids to add such key-value pairs (or any sort of attribute) to your own tree node implementation. It might of course be considered to make this a standarized concept. I didn't think of this before, but the example you have given is perfectly possible with the SourceTreeModel today, without any work at all (no pipelines to set up, no XSL to write, and in addition branches are only loaded on demand and file name filtering is possible). So from a user POV, using the specific SourceTreeModel really is easier in this case. I understand this was just an example though. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Vote] New committers
On Wed, 2006-06-14 at 21:16 +0200, Joerg Heinicke wrote: 1. Andreas Hochsteger +1 2. Peter Hunsberger +1 3. Jason Johnston +1 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [CForms] Tree widget based on XML document
Hi, On Thu, 2006-06-15 at 23:49 +0200, Fred Vos wrote: Hello, On the 30th of may, Martijn C. Vos asked the users list if there was a tree model for the tree widget, using an XML document as input. See http://marc.theaimsgroup.com/?l=xml-cocoon-usersm=114899845703571w=2 I answered him that at work we developed such a tree model. Later Simone Gianni asked if I could contribute my code via Jira. I did some cleanup work, preparing the code for contribution, but the code still depends on the XOM library. Though I like the XOM library, I do not think an extra dependency, only for this tree, is a good thing if other libraries already included in Cocoon, offer the necessary functionality. Also the tree model uses an URL in the src attribute. One cannot use src=cocoon:/bla for instance, only src=file:///path/to/xmldoc or http://www.bla.org/path/to/xmldoc;. Could you explain why you need to load the XML into a tree model like XOM? AFAICS, the tree model could be build directly from SAX events. This would avoid the creation of an intermediate object model, and hence lower memory consumption and improve performance. There's another reason why I do not think a patch is a good thing. The tree widget is a really nice addition to cocoon 2.1.8. But the current implementations of tree models (DefaultTreeModel, SourceTreeModel and JavaTreeModel) and the samples are difficult to comprehend. Their implementations in the source tree are different from other widgets. Somehow it must be possible to make the tree widget easier to use. I think Cocoon only needs one tree model and that is a tree model based on XML. The selection-list widget has the possibility to declare static content in the form definition and can also refer to an xml document in the src attribute. Something like that would be nice for the tree widget. I don't see why the tree widget should be limited to XML models only, the selection list isn't limited to that either (see e.g. the jxpath selection list). Dictating to use XML would again require needless conversions from Java to XML when it is not needed. Another thing that is necessary is the possibility to add key-value pairs to every folder and node, available in the form template. To create a directory tree with directories and files, showing filename, size, date et cetera, then requires the use of a directory generator and transforming its output to an xml document that can be used in the tree widget. I don't think the current tree model implementation forbids to add such key-value pairs (or any sort of attribute) to your own tree node implementation. It might of course be considered to make this a standarized concept. The tree widget is the most complicated widget in CForms and it will stay the most complicated widget, no matter how much work is done on making its use easier. I am prepared to start work on replacing the current implementations of tree models with one model and trying to make its use easier, but I do not have much time for it. So, before doing anything, I want to ask the community if you think this is a good idea. I'm new to developing Cocoon components, so if I start to work on it, I need someone to help me getting started and to review my code, if possible someone who understands CForms. A tree model which can be build from XML, with support for generic attributes, would be a great addition. But does it require any radical changes? Isn't this just another tree model implementation? -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Please review changes to WildcardHelper
On Thu, 2006-06-01 at 11:27 +0200, Carsten Ziegeler wrote: Hi, I just fixed the bug in our wildcard helper. The problem was the following: if a pattern ends with a constant string (like .xml) and the uri in question contained this constant twice (like (hello.xml.xml) the pattern did not match. I added a junit test case for this and now the tests all succeed. BUT, while looking at the wildcard helper code, I found several smelling code place, like unreachable code etc. which I cleaned up. In addition the fix for the bug seems to work, but I'm not 100% sure if it breaks something else. So, it would be great if others can review the code. I'm not sure if the code of the wildcard helper is correct at all; I guess there are still other cases where the pattern does not match although it should. So I think we have to rewrite the code anyway. One idea I had is to transform the pattern into a regexp and then use one of the regexp libraries for matching. This won't be of much help, but I thought the wildcard matcher is significantly faster than regexpes. PS: I like the idea of moving it to commons-lang. I've used it on several occasions outside Cocoon. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Please review changes to WildcardHelper
On Thu, 2006-06-01 at 15:59 +0200, Carsten Ziegeler wrote: Bruno Dumon wrote: On Thu, 2006-06-01 at 11:27 +0200, Carsten Ziegeler wrote: I'm not sure if the code of the wildcard helper is correct at all; I guess there are still other cases where the pattern does not match although it should. So I think we have to rewrite the code anyway. One idea I had is to transform the pattern into a regexp and then use one of the regexp libraries for matching. This won't be of much help, but I thought the wildcard matcher is significantly faster than regexpes. Yes, the wildcard matcher is indeed faster (although the question is if it really makes a difference for the performance of the whole request). Why do you think that using regexp won't be of much help? The regexp libraries are tried and trusted. The won't be of much help refered to my remark, not to the regexp libraries ;-) -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: FW: ResourceReader mime type auto-detection
If I'm not mistaken, it basically falls back to doing: java.net.URLConnection.getFileNameMap().getContentTypeFor(fileName); Javadocs of getFileNameMap say: Loads filename map (a mimetable) from a data file. It will first try to load the user-specific table, defined by content.types.user.table property. If that fails, it tries to load the default built-in table at lib/content-types.properties under java home. On Tue, 2006-05-30 at 17:20 +0100, Andrew Stevens wrote: No response over in users@, so perhaps I'll have more luck here? :-) Andrew. From: Andrew Stevens [EMAIL PROTECTED] Date: Fri, 26 May 2006 13:08:56 +0100 Hi, I have a pipeline that needs to serve up static files of any type from a particular directory. And yes, I know it'd be more efficient to just have the web server do it, but we don't control the server that hosts it and there's constraints on the configuration deployment process that mean we have to do it this way. Previously, I was using a matcher for each file extension, and specifying the corresponding mime-type parameter in the map:read. However, I gather that if no mime-type is specified the resource reader is supposed to determine the mime type automatically using inputSource.getMimeType() on the (Excalibur) Source. So I tried replacing my multiple matchers with just map:match pattern=staticfiles/** map:read src=files/{1}/ /map:match For PDFs and image files, this works just fine. However, MS Word/Excel/Powerpoint files are displayed as text/binary within the browser window rather than prompting to download or open them in the relevant application. SWF files are also displayed as text rather than in the Flash player/plugin. This appears to be because the Content-Type header is being sent back as text/html; charset=ISO-8859-1 rather than e.g. application/vnd.ms-excel I haven't checked every file type we use (yet) so there may be others that also have the problem. Is this a known limitation of the resource reader? Does it only recognise certain file types, or is there something else going on I'm not aware of (e.g. missing some configuration somewhere)? I'm using Cocoon 2.1.7, although the current SVN version on the 2_1_X branch doesn't appear to be any different. Andrew. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Automatic releases
On Wed, 2006-05-24 at 22:06 +0200, Reinhard Poetz wrote: Jorg Heymans wrote: Reinhard Poetz wrote: Is there any possibility to provide automatic *unofficial* releases of our artifacts? I'm asking because for me (and I think for others too) it's an important requirement that only non-SNAPSHOT artifacts are used in my POMs. That's the only way to guarantee that a POM working today will still work tommorrow or in two years. One possibility is of course to maintain these non-official artifacts in the context of your own project. I fully agree with your argument about producing reproducible artifacts. However I'm not sure what to think when you say 'unofficial release'. A release is a release, whether we send a note to [EMAIL PROTECTED] or not. The only difference to a snapshot releases is that we publish identifiable artifacts like cocoon-forms-r412334.jar instead of cocoon-forms-SNAPSHOT.jar. Compare it with a nightly build and producing nightly builds has been done for ages. snip/ If Cocoon has say 50 artifacts (I'm wildly guessing here), and you do 50 releases a year, in 5 years this will give 12.500 released jars. Seems like quite a lot to keep around forever :-) -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[forms] Repeater.moveRow() method
Hi, While using the repeater.moveRow(from, to) method, there were two things about it which I found illogical: * to move a row to the last position, say x, one needs to specify a to-index of x + 1 * if the to-index is larger then from-index, the to-index is lowered by one. I don't understand why, since if one specifies that a row should be moved to e.g. position 5, to me it seems it should really go to position 5, and not position 4. Maybe someone can shine some light on this, but in any case I'm planning on adding a second moveRow method which has the (IMO) normal behaviour. Changing the behaviour of the current method would be backwards incompatible. Bruno. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: ForrestBot build for cocoon-docs FAILED
On Sun, 2006-05-14 at 21:10 +0100, Ross Gardler wrote: Bruno Dumon wrote: On Fri, 2006-05-05 at 16:28 +0100, Ross Gardler wrote: [EMAIL PROTECTED] wrote: Automated build for cocoon-docs FAILED ... http://cocoon.zones.apache.org/daisy/documentation/864/forms/widgets/739.html In this document we can see that daisy is using a pseudo protocol of javadoc:. This protocol is not processed by Daisy when publiching the XML version of the document, and Forrest knows nothing of this pseudo-protocol. However, all is not lost. I recall reading on the Daisy dev list that it uses Forrests locationmap code to handle psuedo protocols like this. if someone can point me at how this is done within Daisy I'll look at making the forrest publication honour the protocol. Alternatively, we need the XML source to contain the URI that this resolves to. Oops! I knew there was some reason I couldn't use this feature yet, but had forgotten about it. Just an update on the current status of this I tried to include the javadoc: protocol support in Forrest the other day, unfortunaly I discovered a bug in SVN head of Forrest that prevents it working. I've got to find out what this is and fix it before the Cocoon-Docs will build properly again, I'll work on it as and when time allows, but please do not hold your breath. OK, then I'll see to adjust the document that causes the error so that the forrestbot can do its job again. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: ForrestBot build for cocoon-docs FAILED
On Fri, 2006-05-05 at 16:28 +0100, Ross Gardler wrote: [EMAIL PROTECTED] wrote: Automated build for cocoon-docs FAILED ... [java] X [0] 2.1/userdocs/widgets/javadoc:org.apache.cocoon.forms.formmodel.tree.TreeModel BROKEN: No pipeline matched request: 2.1/userdocs/widgets/javadoc:org.apache.cocoon.forms.formmodel.tree.TreeModel [java] X [0] 2.1/userdocs/widgets/javadoc:org.apache.cocoon.forms.formmodel.tree.Tree BROKEN: No pipeline matched request: 2.1/userdocs/widgets/javadoc:org.apache.cocoon.forms.formmodel.tree.Tree [java] X [0] 2.1/userdocs/widgets/javadoc:org.apache.cocoon.forms.formmodel.tree.TreeWalker BROKEN: No pipeline matched request: 2.1/userdocs/widgets/javadoc:org.apache.cocoon.forms.formmodel.tree.TreeWalker This looks like someone has used a javadoc: protocol in the source files. Unfortunately, Daisy does not recognise We can see which pages contain these broken links by lookig at: http://forrest.zones.apache.org/ft/build/cocoon-docs/broken-links.xml That leads us to: http://forrest.zones.apache.org/ft/build/cocoon-docs/2.1/userdocs/widgets/widget_tree.html from where we can get to the Daisy source page by following the edit link at the bottom of the page: http://cocoon.zones.apache.org/daisy/documentation/864/forms/widgets/739.html In this document we can see that daisy is using a pseudo protocol of javadoc:. This protocol is not processed by Daisy when publiching the XML version of the document, and Forrest knows nothing of this pseudo-protocol. However, all is not lost. I recall reading on the Daisy dev list that it uses Forrests locationmap code to handle psuedo protocols like this. if someone can point me at how this is done within Daisy I'll look at making the forrest publication honour the protocol. Alternatively, we need the XML source to contain the URI that this resolves to. Oops! I knew there was some reason I couldn't use this feature yet, but had forgotten about it. Below is the information about how it is configured. If it would be too inconvenient to add it to forrest right now, I can remove the usages of javadoc: in the document itself (though its *very* handy). The link transformer is configured like this: map:transformer logger=sitemap.transformer.linkrewriter name=linkrewriter pool-grow=2 pool-max=32 pool-min=2 src=org.apache.cocoon.transformation.LinkRewriterTransformer schemesjavadoc/schemes link-attrshref/link-attrs /map:transformer In cocoon.xconf this input module is defined: component-instance name=javadoc class=org.apache.forrest.locationmap.LocationMapModule logger=sitemap.modules.locationmap file src=context://daisy/javadoc_locationmap.xml/ /component-instance and the javadoc_locationmap.xml file is attached. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED] ?xml version=1.0? locationmap xmlns=http://apache.org/forrest/locationmap/1.0; components matchers default=lm matcher name=lm src=org.apache.forrest.locationmap.WildcardLocationMapHintMatcher/ matcher name=regexp-lm src=org.apache.forrest.locationmap.RegexpLocationMapMatcher/ /matchers /components locator !-- Note: we're using the 'flow-attr' input module below to translates dots to slashes, though of course this is not at all related to flow attributes, we're just using the JXPath-support of that input module. Don't know if there's a nicer way to do this -- match pattern=org.apache.cocoon.* location src=http://cocoon.apache.org/2.1/apidocs/{flow-attr:translate('{0}', '.', '/')}.html/ /match match pattern=java.* location src=http://java.sun.com/j2se/1.5.0/docs/api/{flow-attr:translate('{0}', '.', '/')}.html/ /match match pattern=javax.* location src=http://java.sun.com/j2se/1.5.0/docs/api/{flow-attr:translate('{0}', '.', '/')}.html/ /match match pattern=org.w3c.dom.* location src=http://java.sun.com/j2se/1.5.0/docs/api/{flow-attr:translate('{0}', '.', '/')}.html/ /match match pattern=org.xml.sax.* location src=http://java.sun.com/j2se/1.5.0/docs/api/{flow-attr:translate('{0}', '.', '/')}.html/ /match /locator /locationmap
Re: [vote] Simone Gianni as a new Cocoon committer
On Fri, 2006-03-24 at 11:19 +0100, Sylvain Wallez wrote: Hi all, It's spring time, new committers are blossoming! I'd like to propose Simone Gianni for Cocoon committership. Simone has contributed interesting additions and bug fixes to CForms that show a very good understanding of this stuff, and is participating more and more to discussions. It's time for him to be able to commit his patches himself! Please cast your votes. +1 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Properties for NekoHTMLGenerator
On Fri, 2006-03-24 at 10:17 +0100, Jean-Baptiste Quenot wrote: Hello, Can you please comment on this: https://issues.apache.org/jira/browse/COCOON-1639#action_12371243 Excerpt from the comment: I was about to commit [the new NekoHTMLTransformer] when I noticed neko.properties containing URLs as property keys. The javadoc for java.util.Properties states that « The key contains all of the characters in the line starting with the first non-white space character and up to, but not including, the first unescaped '=', ':', or white space character other than a line terminator. ». Example: http://xml.org/sax/features/namespaces=true http://cyberneko.org/html/features/balance-tags=true Has someone been able to test the settings in neko.properties successfully? If this is the case, why is the colon after http not interpreted as a key separator? Or quoting Andrew Stevens « at worst it just needs the colons to be escaped ». I have never used those components, but you're quite right that this can't work. The colons will need to be escaped. Good observation. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator builder
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371529 ] Bruno Dumon commented on COCOON-1806: - Hi Simone, If you would let the ValidatorBuilder implement LogEnabled and Contextualizable, you could pass the logger and context to setupComponent, so that the validator object has access to these. If one has access to the Context object, it is possible to get the request and objectModel from there (using ContextHelper). Finally, if you could also add a conf patch for SVN trunk (I know, it's trivial), then your patch is ready to apply... Thanks! [PATCH] Java class custom validator builder --- Key: COCOON-1806 URL: http://issues.apache.org/jira/browse/COCOON-1806 Project: Cocoon Type: New Feature Components: Blocks: Forms Versions: 2.1.9-dev (current SVN) Reporter: Simone Gianni Attachments: javavalidator-conf.diff, javavalidator.diff Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (COCOON-1806) [PATCH] Java class custom validator builder
[ http://issues.apache.org/jira/browse/COCOON-1806?page=all ] Bruno Dumon closed COCOON-1806: --- Fix Version: 2.2-dev (Current SVN) 2.1.9-dev (current SVN) Resolution: Fixed Applied. Thanks for your contribution. PS: the forms block is shared between Cocoon 2.1.x and 2.2 (at least the java sources and the samples), so the patch for either trunk or 2.1.x only had to contain the config changes. [PATCH] Java class custom validator builder --- Key: COCOON-1806 URL: http://issues.apache.org/jira/browse/COCOON-1806 Project: Cocoon Type: New Feature Components: Blocks: Forms Versions: 2.1.9-dev (current SVN) Reporter: Simone Gianni Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator builder
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371554 ] Bruno Dumon commented on COCOON-1806: - Forgot to mention this: It would be nice if you could add some docs on this new validator on http://cocoon.zones.apache.org/daisy/documentation/864/forms/concepts/484.html If you don't have an account in Daisy yet, first register yourself, then send a mail to the dev list asking for edit access (mention your Daisy login). Alternatively, if you write something up in text or html format and attach it to this issue, I can add it over there as well. [PATCH] Java class custom validator builder --- Key: COCOON-1806 URL: http://issues.apache.org/jira/browse/COCOON-1806 Project: Cocoon Type: New Feature Components: Blocks: Forms Versions: 2.1.9-dev (current SVN) Reporter: Simone Gianni Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator builder
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371557 ] Bruno Dumon commented on COCOON-1806: - @andrew: save the patch files (javavalidator2.diff and javavalidator-conf.diff) in the cocoon source tree root and do patch -p0 javavalidator2.diff patch -p0 javavalidator-conf.diff Alternatively, instead of this patch, remember that you can also add validators on the form instance from your Java code: form.addValidator(new WidgetValidator() { ... }); [PATCH] Java class custom validator builder --- Key: COCOON-1806 URL: http://issues.apache.org/jira/browse/COCOON-1806 Project: Cocoon Type: New Feature Components: Blocks: Forms Versions: 2.1.9-dev (current SVN) Reporter: Simone Gianni Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Attachments: javavalidator-conf.diff, javavalidator-trunk.diff, javavalidator.diff, javavalidator2.diff Implemented a custom java validator builder, very similar to the custom java listener builder. Also implemented a sample birthday validator and added it to form2 sample. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (COCOON-1806) [PATCH] Java class custom validator builder
On Thu, 2006-03-23 at 15:23 +0100, Simone Gianni wrote: Hi Bruno, I already have an account on cocoon zones : SimoneGianni. Please give me edit rights, Done. I also have to write about the char datatype (COCOON-1789) and the apache enum selection lists (COCOON-1793). great. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [vote] Niclas Hedhman as a new Cocoon committer
On Thu, 2006-03-23 at 19:26 +0100, Daniel Fagerstrom wrote: Hi all! I'd like to propose Niclas Hedhman as a new Cocoon committer. He has been around at cocoon-dev since 2000, regularly delivering insight full comments about technical as well as community questions, high quality patches and strong opinions in various topics ;) He has been and is committer and active in several other Apache projects and have started some OS projects outside Apache. He is also an expert member of JSR 291 (OSGi), and earlier JSR-78 (RMI Custom Remote References). Please cast your votes. +1 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[jira] Commented: (COCOON-1804) Javascript FOM_SCOPE issue when using Java as the flow engine - ReferenceError: cocoon is not defined
[ http://issues.apache.org/jira/browse/COCOON-1804?page=comments#action_12371398 ] Bruno Dumon commented on COCOON-1804: - Implementing a WidgetValidator + Builder + adding it to cocoon.xconf should IMO only be done for providing entirely new types of validators, not for your application-logic validators. Now what's been missing for a long time is a generic java class validator, i.e. something one could use like: fd:validation fd:java class=/ /fd:validation and which delegates to the specified class, without requiring registration in cocoon.xconf. Creating such a fd:java validator should be easy. If Avalon interfaces such as Contextualizable and Serviceable are honored, the validator can access the request object etc. As an alternative, you can also add a validator on the form instance (using the addValidator method on any widget). This makes it very easy to make objects from your flow available to the validator. Javascript FOM_SCOPE issue when using Java as the flow engine - ReferenceError: cocoon is not defined --- Key: COCOON-1804 URL: http://issues.apache.org/jira/browse/COCOON-1804 Project: Cocoon Type: Bug Components: Blocks: Java Flow Versions: 2.1.8 Reporter: Andrew Madu Priority: Blocker I have created a java flow class which does the following: //Load in validation file FormInstance form = new FormInstance(forms/login.xml); My login map (snippet) is as follows: Login.xml: fd:validation fd:javascript var success = true; var newUserReg = new Packages.test.User(); var username = widget.lookupWidget(username); var password = widget.lookupWidget(password); try { var checkUserTest = newUserReg.getUser(username.value, password.value); if (checkUserTest != null) { cocoon.session.setAttribute(user, checkUserTest); success = true; }else{ username.setValidationError(new Packages.org.apache.cocoon.forms.validation.ValidationError(e, false)); password.setValidationError(new Packages.org.apache.cocoon.forms.validation.ValidationError(The password, username combination does not exist. Please enter another one., false)); success = false; } } catch (e) { username.setValidationError(new Packages.org.apache.cocoon.forms.validation.ValidationError(e, false)); password.setValidationError(new Packages.org.apache.cocoon.forms.validation.ValidationError(e., false)); success = false; } return success; /fd:javascript /fd:validation I am getting an error message when the line 'cocoon.session.setAttribute(user, checkUserTest)' is hit.: ReferenceError: cocoon is not defined What is the issue here, can I create a session object from within form validation/javascript in another way? Andrew -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: ForrestBot build for cocoon-docs FAILED
On Tue, 2006-03-21 at 19:11 +1100, David Crossley wrote: David Crossley wrote: Bruno Dumon wrote: BTW, this time not because the zone was restarted. Not sure what the problem is though. I investigated a bit yesterday, but cannot see what is the problem. Notice that today there are less breaks than yesterday. However, looking at the cocoon-docs mailing list diffs from Daisy i cannot see any relevant changes. http://forrest.zones.apache.org/ft/build/cocoon-docs/broken-links.xml It complains about Daisy IDs 786 and 655 which are navigation documents. Surely Forrest's Cocoon had already processed those resources. Strange. I am stumped. Ross seems busy with other stuff. Curiouser and curiouser. At the next 12-hourly run there is only one breakage and for a different ID. FYI: I've had a look at the Daisy log files, and don't see anything there. The server has also been continuously up. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Vote] Release plan for 2.1.9
On Tue, 2006-03-21 at 09:20 +0100, Carsten Ziegeler wrote: Although we already agreed informaly on the release plan, we should do a formal vote. As I won't be able to do the release on the 31st of March, we have to delay it by one week (unless someone else volunteers to do it). So the proposed plan to release 2.1.9 is: - Start code freeze on the 31st of March - Release on the 6th of April (if nothing bad happens) Please cast your votes +1 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [docs] sitemap component docs initial import done
On Mon, 2006-03-20 at 11:20 +0100, hepabolu wrote: Bertrand Delacretaz said the following on 18-03-2006 21:24: Le 18 mars 06 à 21:03, Bruno Dumon a écrit : ...You can see the result in the Components section of the documentation, or browse it using the faceted navigation... Awesome! (sound of me writing down your name in the I-owe-these-guys-a-beer list) ...There's still a lot of work to do to fill in all the docs, but at least this gives an overview of the available components... And the work can be done in small steps, one class at a time, cool! +1000 here too. BTW Just for clarity: if I properly tag a class and add the info that's in the legacy docs for this class, would that be ok? And was that your intention? The intention is to tag the classes, and to write longer, user-oriented documentation on it in Daisy. For this the legacy docs, javadoc, wiki and mailing list archives can be used as inspiration. If you want to help out, but don't necessarily know much about all these components, a first and very helpful step would be to add the javadoc tags. Here's a description of the supported tags, taken from whiteboard/sitemaptags2daisy/README.txt --- begin --- @cocoon.sitemap.component.name default name with which this component is declared in the sitemap @cocoon.sitemap.component.documentation.disabled excludes the component from the documentation @cocoon.sitemap.component.documentation A short (one-paragraph) description of the component. Can contain HTML markup (preferably only inline tags). @cocoon.sitemap.component.documentation.caching A comment about the caching of this component. The cacheability of the component is figured out automatially by its implemented interfaces, but this tag allows to provide a short comment on the chaching conditions. This is mapped to a field in Daisy, thus should not contain HTML markup. --- end --- All tags are optional. For the @c.s.c.documentation tag, you can often just take the first or first few sentences of the javadoc. Also take care to add the tags at the end of the javadoc. I mean the javadoc should be structured like this: /** * Here's the normal javadoc * * @cocoon.sitemap.component.documentation blah blah */ If you look at e.g. I18nTransformer.java, you'll see the tags are at the top, and the normal javadoc text at the bottom, which breaks the javadoc generation: http://cocoon.apache.org/2.1/apidocs/org/apache/cocoon/transformation/I18nTransformer.html (it thinks the text is all part of the @c.s.c.logger annotation). Note that I'm running this tool on trunk, so any updates will only have effect when committed over there. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: error handling in aggregations
On Mon, 2006-03-20 at 12:00 +, Jeremy Quinn wrote: Thanks for your reply Bruno, On 19 Mar 2006, at 13:32, Bruno Dumon wrote: On Sun, 2006-03-19 at 12:10 +, Jeremy Quinn wrote: Hi All Investigating this further, I came up with this simplest possible sitemap to reproduce the problem : ?xml version=1.0? map:sitemap xmlns:map=http://apache.org/cocoon/sitemap/1.0; map:components map:generators default=file map:generator name=file label=content logger=sitemap.generator.file pool-grow=4 pool-max=32 pool- min=4 src=org.apache.cocoon.generation.FileGenerator/ /map:generators map:serializers default=xml map:serializer name=xml logger=sitemap.serializer.xml mime-type=text/xml pool-grow=4 pool-max=32 pool-min=4 src=org.apache.cocoon.serialization.XMLSerializer/ /map:serializers map:matchers default=wildcard map:matcher logger=sitemap.matcher.wildcard name=wildcard src=org.apache.cocoon.matching.WildcardURIMatcher/ /map:matchers map:pipes default=noncaching map:pipe logger=sitemap.pipes.noncaching name=noncaching src=org.apache.cocoon.components.pipeline.impl.NonCachingProcessingP ipe line parameter name=outputBufferSize value=32768/ /map:pipe /map:pipes /map:components map:pipelines map:pipeline internal-only=false type=noncaching map:match pattern=test map:aggregate element=site map:part element=content1 src=nothing.xml/ map:part element=content2 src=nothingelse.xml/ /map:aggregate map:serialize type=xml / /map:match /map:pipeline /map:pipelines /map:sitemap I set this up as the top-level sitemap, loaded by cocoon.xconf. I access the url and I get this : $ curl http://localhost:/test ?xml version=1.0 encoding=ISO-8859-1?sitecontent1// sitehtmlheadtitleResource Not Found/titlestyle!--body { background-color: white; color: black; font-family: verdana, helvetica, sanf serif;}h1 {color: #336699; margin: 0px 0px 20px 0px; border-width: 0px 0px 1px 0px; border-style: solid; border-color: #336699;}p.footer { color: #336699; border-width: 1px 0px 0px 0px; border-style: solid; border-color: #336699; }span {color: #336699;} pre {padding-left: 20px;}a:link {font-weight: bold; color: #336699;} a:visited {color: #336699; }a:hover {color: #80; background- color: #80;}a:active {color: #00;}--/style/ headbodyh1Resource Not Found/h1pspanMessage:/span Resource Not Found/ppspanDescription:/span The requested resource quot;/testquot; could not be found/ppspanSender:/ span org.apache.cocoon.servlet.CocoonServlet/ppspanSource:/ span Cocoon Servlet/pp class='footer'a href='http:// cocoon.apache.org/'Apache Cocoon 2.1.9-dev/p/body/html Two outputs First the content of the failed aggregation : sitecontent1// site Then the generic error message. If I now comment out the line parameter name=outputBufferSize value=32768/ from the map:pipe. then I only get the error message. I have tested this in 2.1.7 -- 2.1.9-dev. I suspect this did not occur in 2.1.6. Is this a bug, or is it what I should expect to happen if an output buffer is configured? Hi Jeremy, Given the streaming nature of the SAX pipeline, buffering the complete output at the end of the pipeline is indeed the only way to reliably recover from exceptions that might happen during its execution. This is not necessarily bad, as whatever other way you would solve this, you would need to temporarily store the data in one way or another to be able to recover from errors. Thanks for your explanation. So I wonder why is this behaviour is 'fixed' when I turn off the buffer? Or am I not actually turning off the buffer by removing that parameter, just allowing it to be set to a different default value? Yes, by default the whole output is buffered before sending it to the client. If you search for outputBufferSize in Cocoon's default root sitemap you will find some information on this. There's a little bit more to it though. In case of an error the output your pipeline is quite small: ?xml version=1.0 encoding=ISO-8859-1?sitecontent1//site It is not normally that small, in my 'real' pipelines, there is far more content. which is much less then your buffer size of 32768, so normally Cocoon should still be able to reset the output before generating the error page. Someone asked the exact same question a week or two ago on the users list, at which time I had a quick look into this. The cause is that the ContentAggregator class, which does the aggregation, will still generate the endDocument event in case an exception occurs. IMO, it should not do this (unless it would also catch the exception). Here is the relevant fragment
Re: ForrestBot build for cocoon-docs FAILED
BTW, this time not because the zone was restarted. Not sure what the problem is though. On Mon, 2006-03-20 at 12:22 +, [EMAIL PROTECTED] wrote: Automated build for cocoon-docs FAILED Log attached. snip/ [java] * [372/7] [0/296] 4.138s 53.3Kb 2.1/userdocs/core/image-reader.html [java] * [373/6] [0/296] 3.547s 48.8Kb 2.1/userdocs/widgets/widget_row_action.html [java] * [375/4] [0/296] 3.646s 50.2Kb 2.1/userdocs/profile-generator.html [java] * [376/3] [0/296] 3.742s 46.7Kb 2.1/faq/faq-selectors.html [java] X [0] 2.1/userdocs/concepts/validation.html BROKEN: Resource not found: cocoon://daisy.site.786 [java] X [0] 2.1/userdocs/text-serializer.html BROKEN: Resource not found: cocoon://daisy.site.655 [java] X [0] 2.1/userdocs/svgpng-serializer.html BROKEN: Resource not found: cocoon://daisy.site.655 [java] Total time: 20 minutes 10 seconds, Site size: 16,404,087 Site pages: 324 [java] Java Result: 1 [echo] Copying broken links file to site root. [copy] Copying 1 file to /var/apache2/htdocs/ft/build/cocoon-docs [echo] Oops, something broke -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [docs] sitemap component docs initial import done
On Mon, 2006-03-20 at 14:09 +0100, hepabolu wrote: Bruno Dumon said the following on 20-03-2006 11:58: The intention is to tag the classes, and to write longer, user-oriented documentation on it in Daisy. For this the legacy docs, javadoc, wiki and mailing list archives can be used as inspiration. If you want to help out, but don't necessarily know much about all these components, a first and very helpful step would be to add the javadoc tags. If you look at e.g. I18nTransformer.java, you'll see the tags are at the top, and the normal javadoc text at the bottom, which breaks the javadoc generation: http://cocoon.apache.org/2.1/apidocs/org/apache/cocoon/transformation/I18nTransformer.html (it thinks the text is all part of the @c.s.c.logger annotation). So after this is done, each component ends up with: - a javadoc file - a summary (using this tool) in Daisy - a Daisy page with user oriented info Is this correct? The last two items are in the same Daisy document, just different parts in it. So they will be dispayed on the same page. As for every Java class, there will of course be a javadoc-generated page. However, since sitemap components are not used using their Java API, and their target audience is not only Java developers, it is IMO more meaningful and easier to maintain their docs in Daisy. So with time we might remove the longer user-oriented descriptions from the javadoc and only use Daisy for them, but let's first see how this evolves before removing anything. Note that I'm running this tool on trunk, so any updates will only have effect when committed over there. Good to know. ;-) Bye, Helma -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: error handling in aggregations
On Sun, 2006-03-19 at 12:10 +, Jeremy Quinn wrote: Hi All Investigating this further, I came up with this simplest possible sitemap to reproduce the problem : ?xml version=1.0? map:sitemap xmlns:map=http://apache.org/cocoon/sitemap/1.0; map:components map:generators default=file map:generator name=file label=content logger=sitemap.generator.file pool-grow=4 pool-max=32 pool- min=4 src=org.apache.cocoon.generation.FileGenerator/ /map:generators map:serializers default=xml map:serializer name=xml logger=sitemap.serializer.xml mime-type=text/xml pool-grow=4 pool-max=32 pool-min=4 src=org.apache.cocoon.serialization.XMLSerializer/ /map:serializers map:matchers default=wildcard map:matcher logger=sitemap.matcher.wildcard name=wildcard src=org.apache.cocoon.matching.WildcardURIMatcher/ /map:matchers map:pipes default=noncaching map:pipe logger=sitemap.pipes.noncaching name=noncaching src=org.apache.cocoon.components.pipeline.impl.NonCachingProcessingPipe line parameter name=outputBufferSize value=32768/ /map:pipe /map:pipes /map:components map:pipelines map:pipeline internal-only=false type=noncaching map:match pattern=test map:aggregate element=site map:part element=content1 src=nothing.xml/ map:part element=content2 src=nothingelse.xml/ /map:aggregate map:serialize type=xml / /map:match /map:pipeline /map:pipelines /map:sitemap I set this up as the top-level sitemap, loaded by cocoon.xconf. I access the url and I get this : $ curl http://localhost:/test ?xml version=1.0 encoding=ISO-8859-1?sitecontent1// sitehtmlheadtitleResource Not Found/titlestyle!--body { background-color: white; color: black; font-family: verdana, helvetica, sanf serif;}h1 {color: #336699; margin: 0px 0px 20px 0px; border-width: 0px 0px 1px 0px; border-style: solid; border-color: #336699;}p.footer { color: #336699; border-width: 1px 0px 0px 0px; border-style: solid; border-color: #336699; }span {color: #336699;} pre {padding-left: 20px;}a:link {font-weight: bold; color: #336699;} a:visited {color: #336699; }a:hover {color: #80; background- color: #80;}a:active {color: #00;}--/style/ headbodyh1Resource Not Found/h1pspanMessage:/span Resource Not Found/ppspanDescription:/span The requested resource quot;/testquot; could not be found/ppspanSender:/ span org.apache.cocoon.servlet.CocoonServlet/ppspanSource:/ span Cocoon Servlet/pp class='footer'a href='http:// cocoon.apache.org/'Apache Cocoon 2.1.9-dev/p/body/html Two outputs First the content of the failed aggregation : sitecontent1//site Then the generic error message. If I now comment out the line parameter name=outputBufferSize value=32768/ from the map:pipe. then I only get the error message. I have tested this in 2.1.7 -- 2.1.9-dev. I suspect this did not occur in 2.1.6. Is this a bug, or is it what I should expect to happen if an output buffer is configured? Hi Jeremy, Given the streaming nature of the SAX pipeline, buffering the complete output at the end of the pipeline is indeed the only way to reliably recover from exceptions that might happen during its execution. This is not necessarily bad, as whatever other way you would solve this, you would need to temporarily store the data in one way or another to be able to recover from errors. There's a little bit more to it though. In case of an error the output your pipeline is quite small: ?xml version=1.0 encoding=ISO-8859-1?sitecontent1//site which is much less then your buffer size of 32768, so normally Cocoon should still be able to reset the output before generating the error page. Someone asked the exact same question a week or two ago on the users list, at which time I had a quick look into this. The cause is that the ContentAggregator class, which does the aggregation, will still generate the endDocument event in case an exception occurs. IMO, it should not do this (unless it would also catch the exception). Here is the relevant fragment: try { SourceUtil.parse(this.manager, part.source, this); } finally { if (part.element != null) { endElem(part.element); } } } } finally { endElem(this.rootElement); this.contentHandler.endDocument(); } I'd be in favor of removing these two finally blocks. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[docs] sitemap component docs initial import done
Hi, I just wanted to let you know: * that the new tool to sync the information about sitemap components from the Java sources to Daisy documents, about which I wrote in a previous mail, is now in the whiteboard. * that I've done an initial run of it (during which I disabled the email notifications to avoid 190 similar mails on the docs list). It uses the trunk-sources so for now not all blocks are included. You can see the result in the Components section of the documentation, or browse it using the faceted navigation. http://cocoon.zones.apache.org/daisy/documentation/ There's still a lot of work to do to fill in all the docs, but at least this gives an overview of the available components. I'll see to add some documentation on how to contribute to this. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[docs] @cocoon.sitemap tags and Daisy
Hi, This weekend I wrote a little tool to sync the @cocoon.sitemap.** annotations in the source code to Daisy documents. This proved to be quite simple, since a lot of work was already done: the tags were already defined, there are sources files using them, and the SitemapTask class showed how to use QDox to extract them. More precisely, for each sitemap component source file, the tool will check if there is already a document for it in Daisy (based on a field JavaClass containing the fully qualified name of the class). If it does not exist, it will create it, or otherwise update the existing document (only if needed, so that documents are not updated unnecessarily). The following annotations are mapped to fields in Daisy documents: @cocoon.sitemap.component.name @cocoon.sitemap.component.documentation.caching The value of the following annotation is mapped to a part (to support markup and somewhat longer content) in the Daisy document: @cocoon.sitemap.component.documentation The following tag is honored to exclude the class from the documentation: @cocoon.sitemap.component.documentation.disabled Also, some fields are automatically assigned: - java class name - component type (matcher, generator, ...) - block name - deprecated There are some other tags (for label, logger, pooling.max and configuration) that it currently ignores, as I thought these are not that useful. The goal of all this would be that the basic facts about each component are taken from the source code, and longer (user-oriented) documentation could then be added in Daisy (in a document part that is left alone by this tool). I'll finish it up next weekend (if time permits) and commit it to the whiteboard. I would then also like to give it a run (based on trunk), if nobody sees a problem in that (the documents can always be deleted afterwards, if needed). -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: svn commit: r385053 - in /cocoon/trunk/cocoon-template/cocoon-template-impl/src/main: java/org/apache/cocoon/template/template-instructions.xml resources/org/apache/cocoon/template/template-instru
On Mon, 2006-03-13 at 09:26 +0100, Leszek Gawron wrote: [EMAIL PROTECTED] wrote: Author: bruno Date: Sat Mar 11 02:41:49 2006 New Revision: 385053 URL: http://svn.apache.org/viewcvs?rev=385053view=rev Log: Sharing template block with 2.1: step 3: move template-instructions.xml between java sources (AFAIK 2.1 build doesn't support a separate resources dir) Added: cocoon/trunk/cocoon-template/cocoon-template-impl/src/main/java/org/apache/cocoon/template/template-instructions.xml - copied unchanged from r385046, cocoon/trunk/cocoon-template/cocoon-template-impl/src/main/resources/org/apache/cocoon/template/template-instructions.xml Removed: cocoon/trunk/cocoon-template/cocoon-template-impl/src/main/resources/org/apache/cocoon/template/template-instructions.xml you cannot do it like this - maven won't pick that file up for jar package. Ah of course. I have now added it to the resources in the pom of the template block. If you prefer another solution, just let me know. BTW, I think we'll need to do something similar for the resources in the forms block. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [EMAIL PROTECTED]: Project daisy-util (in module cocoon) failed
I took care of this. On Sun, 2006-03-12 at 00:26 -0800, Gump wrote: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project daisy-util has an issue affecting its community integration. snip/ -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
forgot to update license files in legal (was Re: svn commit: r385265 - in /cocoon/trunk/lib/optional: daisy-htmlcleaner-1.1.jar daisy-htmlcleaner-1.4.1.jar daisy-util-1.1.jar daisy-util-1.4.1.jar)
Thanks for reminding, done now. On Sun, 2006-03-12 at 04:27 -0600, Antonio Gallardo wrote: Bruno, please update the license files in legal. Best Regards, Antonio Gallardo [EMAIL PROTECTED] wrote: Author: bruno Date: Sun Mar 12 01:36:27 2006 New Revision: 385265 snip/ -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Sharing the template block between 2.1 and 2.2 DONE!
On Fri, 2006-03-10 at 16:53 +0100, Reinhard Poetz wrote: Jason Johnston wrote: A question: it appears that both the 2.1.x core and the template block contain the classes o.a.c.generation.JXTemplateGenerator and o.a.c.transformation.JXTemplateTransformer. In 2.1.x they're the old JX we know and love, and in the template block they point to the new JX. So when using those old classes in 2.1.x with the template block included, which version of JX gets used? In 2.1.x the old generator should *not* extend the new generator and in the template block we should simply remove the class. In order to do this and follow our versioning policy, we have to deprecate the old implementations. I followed this suggestion, as this is also what has been voted on [1]. The move is done now. The java sources of the template block are shared via svn:externals. In 2.1, the new jx template generator is by default declared in the sitemap with the name newjx. [1] http://marc.theaimsgroup.com/?t=11371475241r=1w=2 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Documentation] Verify status of flowscript document please
On Fri, 2006-03-10 at 11:31 +0100, hepabolu wrote: Hi, AFAICT this page: http://cocoon.zones.apache.org/daisy/legacydocs/documentation/userdocs/flow/api.html is still valid for trunk. If so I'd like to move it out of the legacy documentation into the official documentation for 2.2. For those not up-to-date on this: it merely means it will be useable in both 2.1.X and 2.2 documentation. So can some flow expert do a quick check and either change the Daisy collection of the file or report back here. It needs a refresh, for example the request, response and session objects have been replaced with their full java equivalents instead of a subset of them (and hence, don't need to be documented in full there anymore). It would be best to check the source code of the FOM to see if all methods parameters have been documented. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[jira] Commented: (COCOON-1777) fd:on-value-changed does not work with fd:multivaluefield
[ http://issues.apache.org/jira/browse/COCOON-1777?page=comments#action_12369849 ] Bruno Dumon commented on COCOON-1777: - Hi, Thanks for your patch. If I understand it correctly, the following will cause auto-submit to be enabled if there are value change listeners: script type=text/javascriptxsl:value-of select=$browser-variable/ = forms_createOptionTransfer('xsl:value-of select=@id/', xsl:value-of select=@listening = 'true'/);/script which makes it impossible to disable value change listeners, so a better test would be: script type=text/javascriptxsl:value-of select=$browser-variable/ = forms_createOptionTransfer('xsl:value-of select=@id/', xsl:value-of select=@listening = 'true' and not(fi:styling/@submit-on-change = 'false')/);/script Correct? fd:on-value-changed does not work with fd:multivaluefield - Key: COCOON-1777 URL: http://issues.apache.org/jira/browse/COCOON-1777 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.1.8 Reporter: Grzegorz Kossakowski (aka g[R]eK) Attachments: mutlivaluefield.patch Element fd:on-value-changed seems to not work with fd:multivaluefield. I have tried it using Cocoon samples, more specifically I changed fd:[EMAIL PROTECTED]'drinks'] to: fd:multivaluefield id=drinks fd:labelIndicate which 2 of the following drinks you'd like to receive:/fd:label fd:datatype base=string/ fd:validation fd:value-count exact=2/ /fd:validation fd:selection-list fd:item value=Maes/ fd:item value=Jupiler/ fd:item value=Leffe/ fd:item value=Hoegaarden/ fd:item value=Coca Cola/ /fd:selection-list fd:on-value-changed javascript java.lang.System.err.println(Drinks value changed: + event.newValue); /javascript /fd:on-value-changed /fd:multivaluefield So I just added fd:on-value-changed but nothing happend when I was trying to change values of this field. I have no problem with normal field widgets, events work perfectly. I am also sure that it's not client/styling issue because I found that in form instance xml normal field widget have @listening attribute but multivalue field have not. I don not know how to debug Cocoon so I am not able to continue investigation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Sharing the template block between 2.1 and 2.2 (was Re: Release 2.1.9 (again))
On Thu, 2006-03-09 at 14:49 -0700, Jason Johnston wrote: On Thu, 2006-03-09 at 21:10 +, Upayavira wrote: Jason Johnston wrote: On Thu, 2006-03-09 at 08:46 -0800, Ralph Goers wrote: Bruno Dumon wrote: On Thu, 2006-03-09 at 06:35 -0800, Ralph Goers wrote: Hi. Its me again. Seriously, are we there yet? I guess nothing changed since you last asked ;-) Not quite. A few days passed, which is all Sylvain said he needed. AFAIK that is all we are waiting for. It gets mentioned every time someone asks about the 2.1.9 release, so to keep the pattern going: what about the Template block from trunk? IIRC this was discussed and planned for inclusion in 2.1.9. Could you make a patch? That could make it happen. I would be glad to. But I would need guidance, since I know nothing about what is required. Is it just adding an svn:external to that block, or are there code changes involved? I just gave this a try to see if it needs any special work. Here's what I did or found out: * copied the java sources (src/main/java) * resources (src/main/resources): - 2.2 has imports for xconf and xroles, so for 2.1 I had to create a set of patch files (similar as is done for forms): nothing special here - the resources also contained a file template-instructions.xml, I copied this to the java sources * the template block needs the (new in 2.2) class TemplateObjectModelHelper, which is outside of the template block. I copied it in the sources of the template block * class JavascriptExpression and TemplateObjectModelHelper: require changes due to changed rhino API. For JavascriptExpression I simply commented out the code since it is not essential. * I got classcast exceptions when StringTemplateFactory and ExpressionFactory were looked up from the ServiceManager. The cause is that these classes don't have a service interface (their role is a concrete class). I introduced interfaces for them. * Added block to gump.xml and block.properties And then it worked. I tried it first with a simple test file and then with the forms block, and everything seems ok. - o - To summarize: if we want to have a shared codebase for the template block, things that need to handled: - introduce interface for StringTemplateFactory and ExpressionFactory == this is something I can do - don't make use of new rhino API features: I need someone else to look into this - Move template_instructions.xml between the java sources instead of the resources: I could do this, if nobody objects or knows a better way - TemplateObjectModelHelper: could duplicate it into 2.1 core Opinions? Objections? Help? -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[jira] Commented: (COCOON-1777) fd:on-value-changed does not work with fd:multivaluefield
[ http://issues.apache.org/jira/browse/COCOON-1777?page=comments#action_12369858 ] Bruno Dumon commented on COCOON-1777: - I applied your patch, with the submit-on-change change. fd:on-value-changed does not work with fd:multivaluefield - Key: COCOON-1777 URL: http://issues.apache.org/jira/browse/COCOON-1777 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.1.8 Reporter: Grzegorz Kossakowski (aka g[R]eK) Attachments: mutlivaluefield.patch Element fd:on-value-changed seems to not work with fd:multivaluefield. I have tried it using Cocoon samples, more specifically I changed fd:[EMAIL PROTECTED]'drinks'] to: fd:multivaluefield id=drinks fd:labelIndicate which 2 of the following drinks you'd like to receive:/fd:label fd:datatype base=string/ fd:validation fd:value-count exact=2/ /fd:validation fd:selection-list fd:item value=Maes/ fd:item value=Jupiler/ fd:item value=Leffe/ fd:item value=Hoegaarden/ fd:item value=Coca Cola/ /fd:selection-list fd:on-value-changed javascript java.lang.System.err.println(Drinks value changed: + event.newValue); /javascript /fd:on-value-changed /fd:multivaluefield So I just added fd:on-value-changed but nothing happend when I was trying to change values of this field. I have no problem with normal field widgets, events work perfectly. I am also sure that it's not client/styling issue because I found that in form instance xml normal field widget have @listening attribute but multivalue field have not. I don not know how to debug Cocoon so I am not able to continue investigation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Re[2]: [Documentation] isGlobal == HTTP redirect, right? (was: Verify status of flowscript document please)
On Fri, 2006-03-10 at 12:16 +0100, Grzegorz Kossakowski wrote: Hello Bertrand, Friday, March 10, 2006, 11:51:33 AM, you wrote: Le 10 mars 06 à 11:31, hepabolu a écrit : Just wondering about this isGlobal explanation: If the isGlobal argument is true, the redirect will be global, i.e. it returns all the way to the browser, even from within internal requests. is not too clear for me, I'd write: after few moments of exhilaration caused by the fact my first reported bug was fixed I feel the same, it's not clear The isGlobal argument, if true, causes an HTTP redirect to be sent to the client browser in all cases. When isGlobal is false and the current request is an internal one (i.e. uses the cocoon: protocol), the redirect is processed internally within Cocoon, by executing the pipeline specified by the uri argument, without sending an HTTP redirect. +1 for this with one exception. Not always pipeline is executed even isGlobal is false. Eg: map:aggregate map:part src=cocoon:/callflow/ /map:aggregate And in some flow function: cocoon.redirectTo(http://www.google.com;, false); Aggregator will try to use as a part content read from google. So it's not neccessarily redirect to another Cocoon pipeline. It just redirect internal request to whatever you want. Thanks for clarifying (I learned something new). I added your explanation to the docs: http://cocoon.zones.apache.org/daisy/legacydocs/documentation/userdocs/flow/api.html -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Use Maven 2 for the generation of the Cocoon documentation
On Tue, 2006-03-07 at 09:06 +0100, Reinhard Poetz wrote: Bruno Dumon wrote: OTOH, having the docs split up between a lot of little maven-sites might lessen the overview. Because of the nature of Daisy this shouldn't become a problem: - we can have one navigation document which is a collection of all block navigation docs - we have Daisy books - if that's not enough, we can refer to the same document from different navigation docs Yes indeed, we can republish the same content in different ways. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Use Maven 2 for the generation of the Cocoon documentation
On Mon, 2006-03-06 at 18:39 +0100, Reinhard Poetz wrote: hepabolu wrote: Finally, adding the proposed plugin can always be added later without loosing the effort of the current setup. ok, that's right. Anyway, I can't do it myself now but if somebody is interested, I can help. Maybe some of the Daisy gurus here can comment on the idea itself? It shouldn't be too hard. If it is just for publishing, you don't even need the Daisy client libraries, being able to do a HTTP request is enough. I'm not sure what the difficulties are that Ross refers too in reusing the navigation documents. A basic plugin can probably be created in a day (by an experienced Java/XSLT person). As for publishing the docs via Maven, I can understand the benefits to that, especially as each block will become less dependent on the core and might be versioned and released independently. OTOH, having the docs split up between a lot of little maven-sites might lessen the overview. In the short term, personally I'll focus on the actual content, as I think that's a more urgent issue. However, while writing docs, we should keep in mind to keep the docs related to a block grouped, focussed and independent from each other, so that we don't make this proposal harder to achieve. [only slightly related to this thread...] Something which I'll look in setting up soon is to allow to refer to javadoc using a javadoc: URL which gets translated to the actual javadoc location during publishing. To make it more block-oriented, the syntax will probably be something like javadoc:blockname:org/apache/ -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Docs] FAQ Document Type
On Sat, 2006-03-04 at 19:04 +, Ross Gardler wrote: Bruno Dumon wrote: On Wed, 2006-03-01 at 14:01 +, Ross Gardler wrote: A couple of weeks ago I promised to set up a FAQ system in Daisy. I've now done this. Creating a FAQ == There is a FAQ document Type. This is a simple document in which the document title should be the question and the content should be the answer. To illustrate things I have copied the installation faqs from http://cocoon.apache.org/2.1/faq/faq-install.html into individual FAQ documents, for example: http://cocoon.zones.apache.org/daisy/documentation/799.html?branch=1language=1 http://cocoon.zones.apache.org/daisy/documentation/806.html?branch=1language=1 snip the details/ So, if people like this, we should migrate all FAQs from the legacy docs into this format, as well as including relevant ones from the Wiki. Ross Thanks for setting this up. I have some reservations though about copying the FAQs from the legacy docs. I haven't read them all but a lot of them have become either incorrect or irrelevant. One of the reasons for the new documentation is that we can leave behind the outdated information. Yes, that makes sense, I'm a little behind with Cocoon, so do not have the knowledge to decide what goes in and what stays out. I'd also like to change the query in the navigation to a query in a document: having the long questions in the navigation doesn't make sense I think. +1 I only really threw these in as examples. Later I realised I had not done an example of creating a complete FAQ document (i.e. with questions answers) only of indexes (bth navigation and in document). None daisy users should be aware that the query system in Daisy is superb and very flexible. If folk want something better than is currently in place then just ask how (or do it). I now made this of it: http://cocoon.zones.apache.org/daisy/documentation/856.html I've added a forms-related FAQ and a flowscript-related FAQ. Similar to the FAQ doctype, I'd also like to set up a GlosarryItem doctype which can be used to provide short explanations of Cocoon-specific terms (such as sitemap, subsitemap, FOM, flowscript, blocks, real blocks, ...). +1 And the glossary is here: http://cocoon.zones.apache.org/daisy/documentation/857.html -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Docs] FAQ Document Type
On Wed, 2006-03-01 at 14:01 +, Ross Gardler wrote: A couple of weeks ago I promised to set up a FAQ system in Daisy. I've now done this. Creating a FAQ == There is a FAQ document Type. This is a simple document in which the document title should be the question and the content should be the answer. To illustrate things I have copied the installation faqs from http://cocoon.apache.org/2.1/faq/faq-install.html into individual FAQ documents, for example: http://cocoon.zones.apache.org/daisy/documentation/799.html?branch=1language=1 http://cocoon.zones.apache.org/daisy/documentation/806.html?branch=1language=1 snip the details/ So, if people like this, we should migrate all FAQs from the legacy docs into this format, as well as including relevant ones from the Wiki. Ross Thanks for setting this up. I have some reservations though about copying the FAQs from the legacy docs. I haven't read them all but a lot of them have become either incorrect or irrelevant. One of the reasons for the new documentation is that we can leave behind the outdated information. I'll have a look at removing those I think shouldn't be included anymore, and maybe adding some fresh ones. I'd also like to change the query in the navigation to a query in a document: having the long questions in the navigation doesn't make sense I think. Similar to the FAQ doctype, I'd also like to set up a GlosarryItem doctype which can be used to provide short explanations of Cocoon-specific terms (such as sitemap, subsitemap, FOM, flowscript, blocks, real blocks, ...). -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[docs] updating Daisy
Hi, If nobody minds I'd like to upgrade the Daisy on the cocoon zone this afternoon, somewhere around 4 pm CET. Since this involves restarting Daisy, it's better not to edit docs in Daisy around that time. I'll give a notice when it's done. Bruno. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: I am guest in Daisy
On Fri, 2006-03-03 at 11:38 +0100, Jean-Baptiste Quenot wrote: Hello, Can someone with Daisy karma grant me to edit documents? I would like to change the « Who we are » page for now. done, enjoy. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[docs] Daisy updated, some new docs
Hi, The Daisy update on the cocoon zone is done. I have also added some new sitemap reference docs, e.g. http://cocoon.zones.apache.org/daisy/documentation/sitemap/reference/pipeline_elements/842.html It's basically a document for each sitemap element, with a short description, the attributes, and a link field holding references to the documents describing the child elements of the sitemap element. It should be complete (for C2.1) but if you notice missing elements or attributes, just let me know or add them yourself. I have left out the container-specific attributes on purpose (pool-min etc.). From time to time I'll try to fill this up with some more content, integrating the old docs etc. - o - To the default CocoonDocument document type, I've added some (optional) fields to allow more query-based navigation and faceted navigation. The fields are: * CocoonBlock: core, forms, portal, ... * CocoonComponentReference: if the document is the reference documentation for some type of Cocoon component (a transformer, a widget), then this is indicated in this field So that allows some more faceted browsing: http://cocoon.zones.apache.org/daisy/documentation/facetedBrowser/default -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: ForrestBot build for cocoon-docs FAILED
I started the zone services. On Mon, 2006-02-27 at 00:02 +, [EMAIL PROTECTED] wrote: Automated build for cocoon-docs FAILED Log attached. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: ForrestBot build for cocoon-docs FAILED
Zone services restarted... On Fri, 2006-02-24 at 00:02 +, [EMAIL PROTECTED] wrote: Automated build for cocoon-docs FAILED Log attached. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Forms broken on IE
On Thu, 2006-02-23 at 13:43 +0100, Sylvain Wallez wrote: Bruno Dumon wrote: Hi, With latest SVN (2_1_x branch), CForms gives a javascript error on IE6. This happens whenever I click somewhere on the page (doesn't matter where: in a blank area or an input field). The cause is that in dojo's HtmlDragManager.js, on line 185, the 'e' variable is undefined: onMouseUp: function(e){ this.mouseDownX = null; this.mouseDownY = null; this._dragTriggered = false; var _this = this; e.preventDefault(); === e undefined Maybe some of you who follow up dojo development know if this is already fixed or if the problem is caused by us. This not a problem in Dojo, but a bug in Matt Kruses's PopupWindow class that wasn't properly chaining window.onload when there's an existing handler, as is the case with Dojo. I fixed it when committing the Dojo stuff [1] Sylvain [1] http://svn.apache.org/viewcvs.cgi/cocoon/trunk/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/resources/mattkruse-lib/PopupWindow.js?rev=379087r1=367689r2=379087 Hmmm, I still have this error. I was first testing on Windows 2000 (with latest IE6) but now verified it's the same on Windows XP. This is with an up to date checkout from this morning. Nobody else seeing this? -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Forms broken on IE
On Thu, 2006-02-23 at 11:10 +0100, Carsten Ziegeler wrote: Bruno Dumon wrote: Hi, With latest SVN (2_1_x branch), CForms gives a javascript error on IE6. This happens whenever I click somewhere on the page (doesn't matter where: in a blank area or an input field). The cause is that in dojo's HtmlDragManager.js, on line 185, the 'e' variable is undefined: onMouseUp: function(e){ this.mouseDownX = null; this.mouseDownY = null; this._dragTriggered = false; var _this = this; e.preventDefault(); === e undefined Maybe some of you who follow up dojo development know if this is already fixed or if the problem is caused by us. Such issues really raise the question, Ralph has asked earlier one: Does it make sense that a stable forms block heavily depends on such an unstable Ajax block? I would be great, if the forms block could be used without ajax and ajax is an optional part. So we can mark forms stable without having to worry about ajax stuff. If we are not going this way and are tying those blocks heavily together (like they are today) then we should not mark the forms block stable and wait for that until the ajax block is stable as well. I think we can mark them both stable. It's not like the Ajax functionality will be removed again in the future, and from the user's mailing list it seems many people are already relying on it. But as Sylvain pointed out, since he just rewrote that part, it might be better to wait a few weeks for the release so that it can get some more testing. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367320 ] Bruno Dumon commented on COCOON-1780: - @vincent: I don't think there's a problem with that, but since it worked with 'button' before, the real cause of the bug had to be something else. [PATCH] Upload Widget : Can not change selected file Key: COCOON-1780 URL: http://issues.apache.org/jira/browse/COCOON-1780 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Reporter: vincent Demay Assignee: Jean-Baptiste Quenot Fix For: 2.1.9-dev (current SVN) When a file is selected with the upload widget and a on-value-change event is fired, the value of the widget can not be changed by user. here is the patch Index: /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl === --- /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 377974) +++ /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy) @@ -486,7 +486,7 @@ xsl:text[/xsl:text xsl:value-of select=fi:value/ xsl:text] /xsl:text -input type=button id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ + input type=submit id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ /xsl:when xsl:otherwise input type=file id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] title={fi:hint} accept=[EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367334 ] Bruno Dumon commented on COCOON-1780: - good you noticed, it's fixed now, I hope. [PATCH] Upload Widget : Can not change selected file Key: COCOON-1780 URL: http://issues.apache.org/jira/browse/COCOON-1780 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Reporter: vincent Demay Assignee: Jean-Baptiste Quenot Fix For: 2.1.9-dev (current SVN) When a file is selected with the upload widget and a on-value-change event is fired, the value of the widget can not be changed by user. here is the patch Index: /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl === --- /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 377974) +++ /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy) @@ -486,7 +486,7 @@ xsl:text[/xsl:text xsl:value-of select=fi:value/ xsl:text] /xsl:text -input type=button id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ + input type=submit id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ /xsl:when xsl:otherwise input type=file id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] title={fi:hint} accept=[EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Forms broken on IE
Hi, With latest SVN (2_1_x branch), CForms gives a javascript error on IE6. This happens whenever I click somewhere on the page (doesn't matter where: in a blank area or an input field). The cause is that in dojo's HtmlDragManager.js, on line 185, the 'e' variable is undefined: onMouseUp: function(e){ this.mouseDownX = null; this.mouseDownY = null; this._dragTriggered = false; var _this = this; e.preventDefault(); === e undefined Maybe some of you who follow up dojo development know if this is already fixed or if the problem is caused by us. TIA -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367344 ] Bruno Dumon commented on COCOON-1780: - Hi Vincent, It's not really useless code, since it allows more flexibility in rendering. For example, it would allow to use the HTML button tag, allowing to put an image on the button. The way I've fixed the Upload widget follows the same pattern as the other widgets do, such as Action. In fact, I looked a bit too much at the Action widget and that's why I got it wrong the first time. [PATCH] Upload Widget : Can not change selected file Key: COCOON-1780 URL: http://issues.apache.org/jira/browse/COCOON-1780 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Reporter: vincent Demay Assignee: Jean-Baptiste Quenot Fix For: 2.1.9-dev (current SVN) When a file is selected with the upload widget and a on-value-change event is fired, the value of the widget can not be changed by user. here is the patch Index: /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl === --- /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 377974) +++ /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy) @@ -486,7 +486,7 @@ xsl:text[/xsl:text xsl:value-of select=fi:value/ xsl:text] /xsl:text -input type=button id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ + input type=submit id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ /xsl:when xsl:otherwise input type=file id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] title={fi:hint} accept=[EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367361 ] Bruno Dumon commented on COCOON-1780: - If you want to use an image as a button, you can use an input type=image it works fine ! Well yes, but try to combine an image and text in one button then. Just kidding, it's not that this is important to me, but why artifically limit it to form controls that leave a request parameter? This could as suggeted by Vincent also be done by just checking: fullId.equals(request.getParameter(Form.SUBMIT_ID_PARAMETER) but then I don't see why not to set the submit widget while we're at it? It just seems a little nicer to me to set it at the beginning and then later do the form.getSubmitWidget() == this test, which better explains what we're testing. I think that the Upload widget is a totally different kind of widget than an action or a submit widget (that is an action ;) ). You do not want to submit the form nor doing a custom action, you just want the upload widget to delete its uploaded file. So I do not understand the need to set the form submit id in this widget. But it *is* the submit widget, and it will be set as submit widget anyway, just a little bit later (after the readFromRequest processing). Anyhow, adjust it as you feel appropriate. I'll already be happy if it works :-) [PATCH] Upload Widget : Can not change selected file Key: COCOON-1780 URL: http://issues.apache.org/jira/browse/COCOON-1780 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Reporter: vincent Demay Assignee: Jean-Baptiste Quenot Fix For: 2.1.9-dev (current SVN) When a file is selected with the upload widget and a on-value-change event is fired, the value of the widget can not be changed by user. here is the patch Index: /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl === --- /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 377974) +++ /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy) @@ -486,7 +486,7 @@ xsl:text[/xsl:text xsl:value-of select=fi:value/ xsl:text] /xsl:text -input type=button id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ + input type=submit id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ /xsl:when xsl:otherwise input type=file id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] title={fi:hint} accept=[EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367218 ] Bruno Dumon commented on COCOON-1780: - Hmm, I have exactly the same problem and the patch suggested above, changing button to submit, solves it. How is the provided link to http://svn.apache.org/viewcvs.cgi?rev=376238view=rev related? [PATCH] Upload Widget : Can not change selected file Key: COCOON-1780 URL: http://issues.apache.org/jira/browse/COCOON-1780 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Reporter: vincent Demay Assignee: Jean-Baptiste Quenot When a file is selected with the upload widget and a on-value-change event is fired, the value of the widget can not be changed by user. here is the patch Index: /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl === --- /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 377974) +++ /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy) @@ -486,7 +486,7 @@ xsl:text[/xsl:text xsl:value-of select=fi:value/ xsl:text] /xsl:text -input type=button id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ + input type=submit id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ /xsl:when xsl:otherwise input type=file id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] title={fi:hint} accept=[EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367248 ] Bruno Dumon commented on COCOON-1780: - I just committed a patch. The cause of the problem is that the submitWidget is now assigned after the readFromRequest processing. Fixed it in the same way as for the other widgets (such as Action). [PATCH] Upload Widget : Can not change selected file Key: COCOON-1780 URL: http://issues.apache.org/jira/browse/COCOON-1780 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Reporter: vincent Demay Assignee: Jean-Baptiste Quenot When a file is selected with the upload widget and a on-value-change event is fired, the value of the widget can not be changed by user. here is the patch Index: /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl === --- /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 377974) +++ /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy) @@ -486,7 +486,7 @@ xsl:text[/xsl:text xsl:value-of select=fi:value/ xsl:text] /xsl:text -input type=button id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ + input type=submit id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ /xsl:when xsl:otherwise input type=file id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] title={fi:hint} accept=[EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file
[ http://issues.apache.org/jira/browse/COCOON-1780?page=all ] Bruno Dumon closed COCOON-1780: --- Fix Version: 2.1.9-dev (current SVN) Resolution: Fixed [PATCH] Upload Widget : Can not change selected file Key: COCOON-1780 URL: http://issues.apache.org/jira/browse/COCOON-1780 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) Reporter: vincent Demay Assignee: Jean-Baptiste Quenot Fix For: 2.1.9-dev (current SVN) When a file is selected with the upload widget and a on-value-change event is fired, the value of the widget can not be changed by user. here is the patch Index: /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl === --- /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 377974) +++ /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy) @@ -486,7 +486,7 @@ xsl:text[/xsl:text xsl:value-of select=fi:value/ xsl:text] /xsl:text -input type=button id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ + input type=submit id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] value=... onclick=forms_submitForm(this)/ /xsl:when xsl:otherwise input type=file id=[EMAIL PROTECTED]:input name=[EMAIL PROTECTED] title={fi:hint} accept=[EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1777) fd:on-value-changed does not work with fd:multivaluefield
[ http://issues.apache.org/jira/browse/COCOON-1777?page=comments#action_12366600 ] Bruno Dumon commented on COCOON-1777: - About the docs: you're right. Apparently they were republished just very recently. Yes, 2.1.9-dev supports this, as the forms code is shared by the 2_1_x branch and trunk. fd:on-value-changed does not work with fd:multivaluefield - Key: COCOON-1777 URL: http://issues.apache.org/jira/browse/COCOON-1777 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.1.8 Reporter: Grzegorz Kossakowski (aka g[R]eK) Element fd:on-value-changed seems to not work with fd:multivaluefield. I have tried it using Cocoon samples, more specifically I changed fd:[EMAIL PROTECTED]'drinks'] to: fd:multivaluefield id=drinks fd:labelIndicate which 2 of the following drinks you'd like to receive:/fd:label fd:datatype base=string/ fd:validation fd:value-count exact=2/ /fd:validation fd:selection-list fd:item value=Maes/ fd:item value=Jupiler/ fd:item value=Leffe/ fd:item value=Hoegaarden/ fd:item value=Coca Cola/ /fd:selection-list fd:on-value-changed javascript java.lang.System.err.println(Drinks value changed: + event.newValue); /javascript /fd:on-value-changed /fd:multivaluefield So I just added fd:on-value-changed but nothing happend when I was trying to change values of this field. I have no problem with normal field widgets, events work perfectly. I am also sure that it's not client/styling issue because I found that in form instance xml normal field widget have @listening attribute but multivalue field have not. I don not know how to debug Cocoon so I am not able to continue investigation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1777) fd:on-value-changed does not work with fd:multivaluefield
[ http://issues.apache.org/jira/browse/COCOON-1777?page=comments#action_12366550 ] Bruno Dumon commented on COCOON-1777: - I have recently added support for value changed listeners for multivaluefields. Cocoon 2.1.8 does not yet support this (as also mentioned in the docs). fd:on-value-changed does not work with fd:multivaluefield - Key: COCOON-1777 URL: http://issues.apache.org/jira/browse/COCOON-1777 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.1.8 Reporter: Grzegorz Kossakowski (aka g[R]eK) Element fd:on-value-changed seems to not work with fd:multivaluefield. I have tried it using Cocoon samples, more specifically I changed fd:[EMAIL PROTECTED]'drinks'] to: fd:multivaluefield id=drinks fd:labelIndicate which 2 of the following drinks you'd like to receive:/fd:label fd:datatype base=string/ fd:validation fd:value-count exact=2/ /fd:validation fd:selection-list fd:item value=Maes/ fd:item value=Jupiler/ fd:item value=Leffe/ fd:item value=Hoegaarden/ fd:item value=Coca Cola/ /fd:selection-list fd:on-value-changed javascript java.lang.System.err.println(Drinks value changed: + event.newValue); /javascript /fd:on-value-changed /fd:multivaluefield So I just added fd:on-value-changed but nothing happend when I was trying to change values of this field. I have no problem with normal field widgets, events work perfectly. I am also sure that it's not client/styling issue because I found that in form instance xml normal field widget have @listening attribute but multivalue field have not. I don not know how to debug Cocoon so I am not able to continue investigation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Cocoon zone services are down again (Was: ForrestBot build for cocoon-docs FAILED)
I restarted them now. Is it necessary that the forrestbot runs so often? Seems like now it runs every 3 hours. IMO once or twice a day would be enough. On Fri, 2006-02-03 at 16:35 +1100, David Crossley wrote: These failures are because the Cocoon zone services are down again. -David [EMAIL PROTECTED] wrote: Automated build for cocoon-docs FAILED Log attached. [snip ] Cocoon will report the status of each document: - in column 1: *=okay X=brokenLink ^=pageSkipped (see FAQ). [java] [java] cocoon 2.2.0-dev [java] Copyright (c) 1999-2005 Apache Software Foundation. All rights reserved. [java] Build: December 8 2005 (TargetVM=1.4, SourceVM=1.4, Debug=on, Optimize=on) [java] [java] [java] [java] X [0] linkmap.html BROKEN: Connection refused [java] Total time: 0 minutes 6 seconds, Site size: 0 Site pages: 0 [java] Java Result: 1 [echo] Copying broken links file to site root. [copy] Copying 1 file to /var/apache2/htdocs/ft/build/cocoon-docs [echo] Oops, something broke -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[jira] Commented: (COCOON-1571) [PATCH] NullPointerException in MultiValueField
[ http://issues.apache.org/jira/browse/COCOON-1571?page=comments#action_12363408 ] Bruno Dumon commented on COCOON-1571: - IMO the locale parameter should not be null. Otherwise we might need to add such a check to every widget. I think it would be better to fix the place where this code is getting called so that the locale parameter is never null. [PATCH] NullPointerException in MultiValueField --- Key: COCOON-1571 URL: http://issues.apache.org/jira/browse/COCOON-1571 Project: Cocoon Type: Bug Components: Blocks: Forms Versions: 2.2-dev (Current SVN) Environment: Operating System: other Platform: Other Reporter: Peter Brant Assignee: Jean-Baptiste Quenot Attachments: multivaluefield.patch, sample.zip If the locale is not specified and the selection list is being created dynamically, a NullPointerException can result (in my specific case, it was the DataType implementation using the locale as part of formatting a number). Patch is attached. It just uses the same technique that Field already uses. Patch is against 2.2, but if this could make it into the next 2.1 release too, that would be great. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: New ASF members
On Tue, 2005-12-13 at 09:33 +, Ross Gardler wrote: Reinhard Poetz wrote: Sylvain Wallez wrote: Hi all, An ASF members meeting was held yesterday evening here in San Diego during which new members were voted in. Among the 33 new members, some are well known here: - Bruno Dumon - Antonio Gallardo - Ross Gardler - Reinhard Poetz - Jeremy Quinn Congratulations and a warm welcome to the new members! I'm surprised and honored and I have to say that I'm really proud that I was elected. Many thanks to all of you! I have to say, I am also suprised and honored. Thank you for yet another vote of confidence from the ASF - somehow this kind of thing always feels better than a promotion ;-) Same here, I didn't expect this as I haven't been that active lately, so even more suprised but also honored, proud and happy. Big thanks! -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [RT] The next shiny thing?
On Mon, 2005-12-05 at 17:15 +0100, Sylvain Wallez wrote: Peter Hunsberger wrote: snip/ Perhaps an area on the Wiki to discuss straw man features and requirements for a 3.0 release would be a good thing? See http://cocoon.zones.apache.org/daisy/test/g1/792.html (BTW, how do we create a new book in Daisy?) Just create a new document of type 'Book Definition', it will then appear along the available books to publish (at /daisy/books/definitions) -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [zone] keeping copies of the zone's config files
On Sat, 2005-11-19 at 12:05 +0100, Bertrand Delacretaz wrote: I have copied important config files (maybe not all of them, a double-check would be welcome) to the committer's private SVN area, see https://svn.apache.org/repos/private/committers/pmc/cocoon/ cocoon.zones.apache.org/README.txt I've used a simple copy (described in that file) to bring the configs to my local SVN sandbox for committing, this is not optimal but at least we now have a safe copy of those files. I haven't included anything from the Daisy setup, if someone who knows Daisy better than me could do that, please have a look at https://svn.apache.org/repos/private/committers/pmc/cocoon/ cocoon.zones.apache.org/zone-config-files/UPDATING.txt and update accordingly. We do indeed need to look at this, Daisy is currently not being backed up AFAIK (both data config). I might have a look at this some time, but no promises. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: 2.2 Documentation
On Wed, 2005-11-23 at 12:58 +0100, hepabolu wrote: Regarding the documentation of 2.2: Let me first give you some Daisy background to clarify things, before I explain what I have in mind. Note that this is the quick dirty explanation. The Outerthought boys can give a much more detailed overview. Daisy supports sites (the already mentioned Legacy docs and Documentation) and collections. A collection is merely a set of documents and a site can be considered as a view on one or more collections. That's what is currently the case in our Daisy setup in the zones: Collection legacydocs contains all documentation as it was present in the xdocs of BRANCH_2.1.X. Collection documentation contains all new documents that are written in Daisy. Bruno has marked documents part of legacydocs with a two line red warning at the top of the document. You can see this when you open such a page in Daisy. There are already two sites in Daisy: Legacy docs and Documentation. Both use documents from both collections. My idea was this: I've used Legacy docs site to recreate the old cocoon.apache.org site as best as possible. If this is not enough, a little bit of work needs to be done. This site will be restricted to the 2.1 branch. Since Cocoon 2.1 is frozen when it comes to new features, I suggest that the documentation is only updated when some blatant errors or typos are found. For the 2.2 version please use the Documentation site. That's where new documentation is supposed to be entered. This site also contains links to all available documents in the legacydocs collection, see the last line in the navigation bar. This is added for convenience: if you find documentation in the legacydocs that is still valid for the 2.2 version, just move the documentation from the legacydocs collection to the documentation collection. This has no impact on the documentation in the Legacydocs site. I know it's possible that a document resides in both collections, but I want to end up with a collection of legacydocs that holds information that is either completely outdated or only valid for the 2.1 branch. I know we can make branches in Daisy, but at the moment I don't think this is necessary. I'd rather use that feature when we move from 2.2 to 3.0. Are you sure this is unnecessary? The current setup shares the same documents in the new docs and the legacy docs. Thus when the new docs are updated, refactored, retired etc, this influences the legacy docs too. This was fine as long as the legacy docs served exactly for this purpose, but now the legacy docs have turned into the official 2.1.8 documentation. If we don't make a branch for 2.1.8, there's no way the 2.1.x docs can still be produced and maintained in the future. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [VOTE] Naming rule for HTML IDs generated by CForms
On Sun, 2005-11-06 at 11:51 +0100, Sylvain Wallez wrote: So please choose one proposal below: [ ] foo.bar:input (colon, not CSS-friendly because of IE) +1 -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: Other ID naming proposals (was Re: CForms widget ID naming)
On Sat, 2005-11-05 at 11:20 +0100, Ugo Cei wrote: Il giorno 05/nov/05, alle ore 08:46, Sylvain Wallez ha scritto: So let's make other proposals. Let's consider wiget foo.bar (e.g. a fd:field in a fd:group) and the ID of its input. - foo.bar..input: the '.' is doubled, which can never conflict with a widget's full name - foo.bar._input: generated element's name starts with a character that we can forbid as the first character of widget names I prefer the first one (double '.') which is IMO more readable than the second. Another one, which looks more natural: foo.bar.input.: the trailing '.' ensures it cannot conflict with a widget's full name The fact that it is not that readable might be a plus. The problem with double dots or a dot at the end is that it's easy to miss when reading the code. an extra '_' sticks out more and won't be missed as easily. agreed, +1 for the underscore -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [Documentation] clarifications about docs
On Sat, 2005-11-05 at 18:51 +0100, hepabolu wrote: Guys, snip/ Cocoon 2.2+ - the documentation is generated as a Daisy book in both PDF and HTML. As an additional resource next to the normal site, I assume? I mean, the books are fine for printing or linear reading, but the primary rendering would stay something like we currently have, I thought/hoped. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[docs] Daisy access control again
Hi, Apparently someone had enabled write access for guest users. I assume this was done by mistake, and have disabled this again. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: [docs] daisy sites not available?
On Sat, 2005-11-05 at 00:39 +, Ross Gardler wrote: Steven Noels wrote: On 04 Nov 2005, at 17:53, Bruno Dumon wrote: Hi, any reason the sites on http://cocoon.zones.apache.org/daisy/ have been made inaccessible? I saw the ACL change notification message this morning but didn't really check what it was, nor who it initiated. Anyway, I now found out who it was (Ross), and I reverted his actions. But it seems like Ross corrected stuff himself in parallel. In the future, even though it is easy to play around with ACL config, we should refrain from doing so without prior warning here. This change had been discussed onlist (must register to edit). I thought the last thing said about this was that Upayavira, who was the main person expressing concerns about the public accessibility, said he was fine with it as long as it was clearly marked that these are not the released docs (which has not been done yet). See the last messages from this thread: http://thread.gmane.org/gmane.text.xml.cocoon.devel/57406 However, as you correctly point out I reverted the change after just a couple of minutes since the effect was less than desirable and I don't currently have the time to change the default page displayed when not logged in. I would have annouced it had I left it in place, but in the two minutes it was like that I didn't expect so many people to spot it. I'll announce *before* I experiment in the future ;-) Just a coincidence probably: I noticed it in the morning when looking something up with a colleague, then checked again at the end of the day and noticed it was still the same. -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]
[docs] daisy sites not available?
Hi, any reason the sites on http://cocoon.zones.apache.org/daisy/ have been made inaccessible? -- Bruno Dumon http://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center [EMAIL PROTECTED] [EMAIL PROTECTED]