[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/256#issuecomment-136397624
  
@m1r4ge, tested and confirm that this works. However, there is already a 
`nodeEqual` method (see 
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/util/plist-helpers.js#L83),
 which compares nodes in a more correct way. Consider using it instead of 
string comparison.

Also please file an Apache ICLA,  if possible 
(http://www.apache.org/dev/new-committers-guide.html#cla). Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Gulp now correctly serves the productio...

[riknoll]

Github user riknoll closed the pull request at:

https://github.com/apache/cordova-docs/pull/321


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

[marcuspridham]

GitHub user marcuspridham opened a pull request:

https://github.com/apache/cordova-lib/pull/292

CB-8993 Plugin restore ignores search path

When restoring a platform the search path needs to be provided otherwise
plugins will always be resolved to npm.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marcuspridham/cordova-lib CB-8993

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #292


commit 9b840b20c5983aec6d7e4aea7e181644158a5856
Author: Marcus Pridham 
Date:   2015-08-31T16:08:58Z

CB-8993 Plugin restore ignores search path

When restoring a platform the search path needs to be provided otherwise
plugins will always be resolved to npm.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

[m1r4ge]

Github user m1r4ge commented on the pull request:

https://github.com/apache/cordova-lib/pull/256#issuecomment-136423739
  
@vladimir-kotikov It's seemed to me that I tried that method and it didn't 
work properly. Now everything works fine. Thx for clarifications. I'll file 
Aache ICLA soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-wp8 pull request: Get rid of Math.random() when making a r...

[scale-tone]

Github user scale-tone commented on the pull request:

https://github.com/apache/cordova-wp8/pull/86#issuecomment-136438200
  
> please also file an ICLA here:
http://www.apache.org/dev/new-committers-guide.html#cla

OK, just sent the form to secret...@apache.org.

2015-08-28 15:54 GMT+03:00 Vladimir Kotikov :

> Filed https://issues.apache.org/jira/browse/CB-9572, merging in.
>
> @scale-tone , please also file an ICLA
> here: http://www.apache.org/dev/new-committers-guide.html#cla
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-wp8 pull request: Get rid of Math.random() when making a r...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-wp8/pull/86#issuecomment-136438829
  
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Tools Release?

[Steven Gill]

Hey Tim,

You are correct. I forgot to run svn commit. Updated RC's are now there.

You can also test using npm install -g cordova@rc

On Aug 30, 2015 10:01 PM, "Tim Barham"  wrote:

> Hey Steve - you mention version bumps for lib, cli and plugman, but that
> doesn't seem to be what's in dist/dev... There we have lib 5.3.0, cli 5.3.0
> and plugman 1.01, but in the vote email you refer to lib 5.3.1, cli 5.3.1
> and plugman 1.0.2. Did you miss updating dist/dev?
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Saturday, August 29, 2015 10:11 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release?
>
> Ended up making a mistake with lib which made me have to bump patch
> versions for lib, cli, and plugman. ugh. Vote is up.
>
> On Fri, Aug 28, 2015 at 11:18 AM, Steven Gill 
> wrote:
>
> > Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9574=01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7c7c548018227b4e339f2008d2b0066f52%7c72f988bf86f141af91ab2d7cd011db47%7c1=uXAIHKcK0orjQpH5%2bt9Nnwb3XQWuAFVnqgKme8mJ5uQ%3d
> >
> > On Thu, Aug 27, 2015 at 11:53 PM, Nikhil Khandelwal <
> > nikhi...@microsoft.com> wrote:
> >
> >> I really just meant minor version bump instead of major. Sorry for the
> >> mix-up in terminology.
> >>
> >> -Nikhil
> >>
> >> -Original Message-
> >> From: Carlos Santana [mailto:csantan...@gmail.com]
> >> Sent: Thursday, August 27, 2015 11:07 PM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [DISCUSS] Tools Release?
> >>
> >> That was my thinking no API breakage no major bump.
> >>
> >> Feature added minor bump
> >>
> >> - Carlos
> >> Sent from my iPhone
> >>
> >> > On Aug 28, 2015, at 1:47 AM, Steven Gill 
> >> wrote:
> >> >
> >> > It is interesting. Adding a new platform could be consideration for a
> >> > major or minor. The platform (OSX) is having a major jump.
> >> >
> >> > According to semver, a major would be making a incompatible api change
> >> > and a minor would be adding functionality in a backwards-compatible
> >> manner.
> >> >
> >> > We don't break anything by adding osx, so I'm leaning toward minor.
> >> >
> >> > -Steve
> >> >
> >> > On Thu, Aug 27, 2015 at 10:37 PM, Carlos Santana
> >> > 
> >> > wrote:
> >> >
> >> >> +1 minor release bump not major
> >> >>
> >> >> - Carlos
> >> >> Sent from my iPhone
> >> >>
> >> >>> On Aug 27, 2015, at 11:45 PM, Nikhil Khandelwal
> >> >>> 
> >> >> wrote:
> >> >>>
> >> >>> Also, there has been a browser release that we need to pin.
> >> >>>
> >> >>> -Nikhil
> >> >>>
> >> >>> -Original Message-
> >> >>> From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> >> >>> Sent: Wednesday, August 26, 2015 6:21 PM
> >> >>> To: dev@cordova.apache.org
> >> >>> Subject: RE: [DISCUSS] Tools Release?
> >> >>>
> >> >>> +1. Not sure if it will be a patch release as it does ship new
> >> >>> +platforms
> >> >> along with it and it could be considered a major bump because of
> that.
> >> >>>
> >> >>> -Nikhil
> >> >>>
> >> >>> -Original Message-
> >> >>> From: Jesse [mailto:purplecabb...@gmail.com]
> >> >>> Sent: Wednesday, August 26, 2015 6:17 PM
> >> >>> To: dev@cordova.apache.org
> >> >>> Subject: Re: [DISCUSS] Tools Release?
> >> >>>
> >> >>> +1
> >> >>>
> >> >>>
> >> >>>
> >>  On Aug 26, 2015, at 6:14 PM, Carlos Santana 
> >> >> wrote:
> >> 
> >>  Yep makes sense to cut a release before that PR hits master
> >> > On Wed, Aug 26, 2015 at 9:11 PM Carlos Santana
> >> > 
> >> >> wrote:
> >> >
> >> > +1
> >> > On Wed, Aug 26, 2015 at 8:47 PM Steven Gill
> >> > 
> >> > wrote:
> >> >
> >> >> How do people feel about a patch tools release including the
> >> >> recently released platforms (windows, browser) + early support
> >> >> for osx + updated cordova-serve.
> >> >>
> >> >> It would be nice to get this out before we add the new platform
> >> >> api polyfill PR which is slated to get merged end of this week.
> >> >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2f
> >> >> git
> >> >> hub.com
> %2fapache%2fcordova-lib%2fpull%2f282=01%7c01%7cnikhil
> >> >> kh%
> >> >> 40microsoft.com
> %7cd6166af76ee448279b7808d2ae7d429b%7c72f988bf86f1
> >> >> 41a
> >> >> f91ab2d7cd011db47%7c1=o4lRdDOed%2fvW6ZhlIidmAsdT2OSAwsoQ0Nw
> >> >> rMI
> >> >> 4nTU8%3d
> >> >>>
> >> >>> 
> >> >>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> >>> For additional commands, e-mail: dev-h...@cordova.apache.org
> >> >>>
> >> >>>
> >> >>> 
> >> >>> - To unsubscribe, e-mail: 

[GitHub] cordova-docs pull request: added phonegap to tools section

[stevengill]

Github user stevengill closed the pull request at:

https://github.com/apache/cordova-docs/pull/322


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/292#discussion_r38340821
  
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -56,7 +56,7 @@ function prepare(options) {
 var hooksRunner = new HooksRunner(projectRoot);
 return hooksRunner.fire('before_prepare', options)
 .then(function(){
-return restore.installPlatformsFromConfigXML(options.platforms);
+return restore.installPlatformsFromConfigXML(options.platforms, { 
searchpath : options.searchpath });
--- End diff --

I don't see this searchpath ption being used by [the downstream function]( 
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/restore-util.js#L35
 ).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/292#discussion_r38341095
  
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -56,7 +56,7 @@ function prepare(options) {
 var hooksRunner = new HooksRunner(projectRoot);
 return hooksRunner.fire('before_prepare', options)
 .then(function(){
-return restore.installPlatformsFromConfigXML(options.platforms);
+return restore.installPlatformsFromConfigXML(options.platforms, { 
searchpath : options.searchpath });
--- End diff --

Oops never mind, I see the changes you have made to restore-utils.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Marshmallow Update and Cordova-Android 5.0

[Joe Bowser]

Hey

So, I created a new topic branch of my github with the new changes as
suggested earlier.

https://github.com/infil00p/cordova-android/tree/smores

The thing we have to make sure works is if the user turns off the
permissions on Marshmellow.  Right now if the permissions are off,
everything crashes and dies, so we're going to issue a 5.0 because plugins
will have to have this code to work on the latest version of Android.  It's
not a API change, since we're adding it, but I feel that it's important
enough that we should bump the major version anyway.

Can we PLEASE not have any other features creep into 5.0?  If we need
additional features, we can do a 6.0.  I'm not against bumping major
versions as long as we get into a trend of not breaking shit like we did in
the bump from 3.7 to 4.0.

Also, we're going to deprecate 3.7, is there any major third-party plugins
that still don't work with 4.0.x that we should be aware of?  Do we have
people to cover the docs on that.

Thoughts?

Joe

RE: Cordova Face to Face meeting

[Parashuram N]

I will see if we can set up a hangouts for this. I am sure we can set up a Lync 
meeting in the conference rooms. 
We also have 1 hour allocated for discussing the agenda, but I think we should 
use this mailing list to seed that discussions.
Shaz, can you do a "state of the union" something in the morning, also to set 
the context ?

Some of the big topics we could discuss are listed below. Can we have *an 
owner* for each topic who can drive the discussions ? Alternatively, please add 
topics you would like to drive.  

- Documentation and Tutorials 
- Medic 
- Cordova Plugins
- Android Future
- iOS Future
- Other platforms

Posting the rough agenda here again for reference, also created a 
Cordova-discuss file for this - 
https://github.com/cordova/cordova-discuss/blob/master/proposals/Face2Face-Oct15.md

10:30 - 11:00: Introductions
11:00 - 12:00: Finalize agenda for the 2 days
12:00 - 2:00: Lunch, Networking
2:00 - 5:00: Major Topics for Discusssions
5:00 - End time (and head to bar for beer)

 Oct 15
Starts at 10:00
10:00 - 10:30: Finalize smaller teams for more focussed discussions
10:30 - 12:00 - Continue discussions on specific topcis
12:-1:00 - Lunch
1:00 - 3:00 - Break out sessions, smaller groups
>

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Thursday, August 27, 2015 11:08 AM
To: dev@cordova.apache.org
Subject: Re: Cordova Face to Face meeting

This sounds good.
We may want to do a hangout for some of this, so those who cannot attend can 
still take part, and express opinions, maybe in the Finalize Agenda portion? 
Either that or we hire a film crew ...

I am available to stay later on the 15th, so I am fine with whatever.


My team is hiring!
@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7c9f43665601ff43e8c69e08d2af0a7ba4%7c72f988bf86f141af91ab2d7cd011db47%7c1=VhCa2lSfO6lIR1pIahPJ1y3X3haVJF9Lfnvtmjn4YDM%3d

On Thu, Aug 27, 2015 at 7:14 AM, Parashuram N 
wrote:

> Let us make it Oct 14 and Oct 15. How about this being a rough agenda. 
> I was not present at the Google Face-to-Face meeting, but we could use 
> parts of that agenda too.
>
> Oct 14
>
> Starts 10:30 (so that folks driving from Vancouver/Portland can get 
> here in time)
>
>
> 10:30 - 11:00: Introductions
> 11:00 - 12:00: Finalize agenda for the 2 days
> 12:00 - 2:00: Lunch, Networking
> 2:00 - 5:00: Major Topics for Discusssions
> 5:00 - End time (and head to bar for beer)
>
> Oct 15
> Starts at 10:00
> 10:00 - 10:30: Finalize smaller teams for more focussed discussions
> 10:30 - 12:00 - Continue discussions on specific topcis
> 12:-1:00 - Lunch
> 1:00 - 3:00 - Break out sessions, smaller groups
>
> At the end of Oct 15, we should probably come together again to 
> summarize the meeting. What time do folks want to leave on Oct 15? 
> There are folks from the east coast, so it may make sense to end at a 
> time when they can take the same day flights if they need.
>
>
>
> On 8/26/15, 2:48 PM, "Shazron"  wrote:
>
> >I second Wed Oct 14 and Thurs Oct 15.
> >Fri Oct16 can be the travel day back (or whatever) then its the weekend!
> >
> >On Wed, Aug 26, 2015 at 1:30 PM, Parashuram N 
> >
> >wrote:
> >
> >> I think we should do 2 days. How about we just pick 14 and 15 and 
> >>fill the  agenda for that?
> >>
> >> -Original Message-
> >> From: Steven Gill [mailto:stevengil...@gmail.com]
> >> Sent: Wednesday, August 26, 2015 1:24 PM
> >> To: dev@cordova.apache.org
> >> Subject: Re: Cordova Face to Face meeting
> >>
> >> We haven't started an agenda yet but we should. Are we doing the 3 days?
> >>
> >> Very rough agenda I just started at
> >>
> >>
> >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdocs.
> goo
> >>https://na01.safelinks.protection.outlook.com/?url=gle.com=01%7
> >>c01%7cpanarasi%40microsoft.com%7c9f43665601ff43e8c69e08d2af0a7ba4%7c
> >>72f988bf86f141af91ab2d7cd011db47%7c1=Ym2fDxynZfaRjdLbKyQ4Dj41e
> >>0EgUD%2fanCi1mAKR9GY%3d
> %2fdocument%2fd%2f16b3IrjQOBrBdiuphTEUCe8yI49IHQ_uFAlJOCMUPER8%2fe
> >>dit.=01%7c01%7cpanarasi%40microsoft.com
> %7c4071dfec21d148185ef108d2ae
> >>545c6c%7c72f988bf86f141af91ab2d7cd011db47%7c1=jnfdlpvCkyTCqHku
> >>s1b%2
> >>fRCzdYQghX6C4k4ZgrZ%2fgeKA%3d
> >> Please add to it :)
> >>
> >> On Wed, Aug 26, 2015 at 1:12 PM, Martijn Walraven < 
> >> martijnwalra...@meteor.com> wrote:
> >>
> >> > Hi everyone,
> >> >
> >> > Yes, I did get the message! Thanks for reaching out and inviting me.
> >> > It sounds like a great opportunity to meet the people around 
> >> > Cordova and to see where the project is going.
> >> >
> >> > I'm a new core developer at Meteor. I joined Meteor after 
> >> > developing Meteor iOS, a native client for the Meteor DDP 
> >> > protocol. Over the last few months I've worked on improving our 
> >> > Cordova integration for the upcoming
> >> > 1.2 release.
> >> >
> >> > Is there a list 

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38346729
  
--- Diff: www/_includes/footer.html ---
@@ -72,3 +74,6 @@
 
 
 

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38346892
  
--- Diff: gulpfile.js ---
@@ -31,6 +33,7 @@ var WATCH_INTERVAL= 1000; // in milliseconds
 var ROOT_DIR   = ".";
 var SOURCE_DIR = path.join(ROOT_DIR, "www");
 var DEV_DIR= path.join(ROOT_DIR, "build-dev");
+var LINT_DIR= path.join(DEV_DIR, "blog");
--- End diff --

The directory where we want to run the lint. We can change it later as per 
use but currently the docs have a lot of formatting errors so I excluded it 
from linting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/292#issuecomment-136471159
  
Thanks for suggesting these changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/292#issuecomment-136472329
  
Thanks for suggesting these changes. 

However, I have a suggestion :
As it currently stands, it seems like adding adding a platform or restoring 
from config.xml is broken.
It doesn't handle cases where the searchpath comes from config.json or the 
case when the searchpath could be an array of multiple paths.

I propose we include that fix with this one. What do you think ?

For references, see : [Handling searchpaths as string or 
array](https://github.com/apache/cordova-lib/blob/41765f1fd7393be1fff2b39ba7cf00b5bf6f1ef1/cordova-lib/src/cordova/plugin.js#L97).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

[marcuspridham]

Github user marcuspridham commented on the pull request:

https://github.com/apache/cordova-lib/pull/292#issuecomment-136482068
  
Thanks.  I just tried these cases it appears to already work. The search 
path provided with prepare passes through 
https://github.com/apache/cordova-lib/blob/41765f1fd7393be1fff2b39ba7cf00b5bf6f1ef1/cordova-lib/src/cordova/plugin.js#L97
 before a plugin is added so it is always processed to handle config.json and 
multiple paths.

I tried these cases they all appear to work for me.

1. Restore plugins using plugin_search_path in .cordova/config.json.
2. Restore plugins using combination of plugin_search_path and cli provided 
search path.  One plugin located in each location.
3. Restore plugins using 2 search paths on cli.  cordova prepare 
--searchpath ../plugin_cache:../plugin_cache_2/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [Discuss] BlackBerry Release

[Tim Windsor]

I've tested the mobile-spec app on the previous version and the new one. While 
there are issues, they appear to be the same from what I've seen.

Tim Windsor
Open Source Technical Lead – Devices





-Original Message-
From: Bryan Higgins [mailto:br...@bryanhiggins.net] 
Sent: Saturday, August 29, 2015 11:34 AM
To: dev@cordova.apache.org
Subject: Re: [Discuss] BlackBerry Release

I've uploaded the RC here:
https://dist.apache.org/repos/dist/dev/cordova/CB-9576/

We'll need to test it before starting a VOTE thread (hopefully on Monday).

On Wed, Aug 26, 2015 at 3:39 PM, Tim Windsor 
wrote:

> Tim here - I think the code is in good shape for release. I've tested 
> with it in a few projects that have built successfully.
>
> I've got no more pull requests planned at this time.
>
> Tim Windsor
> Open Source Technical Lead - Devices
>
>
>
>
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Wednesday, August 26, 2015 8:56 AM
> To: dev@cordova.apache.org
> Subject: Re: [Discuss] BlackBerry Release
>
> Brian nice to hear from you.
>
> I completely understand, I'm not 100% still waiting on finance 
> division to see if they will approve the expense.
>
> - Carlos
> Sent from my iPhone
>
> > On Aug 26, 2015, at 8:31 AM, Bryan Higgins 
> wrote:
> >
> > Steve - thanks! I'll let you know if I hit any roadblocks.
> >
> > Carlos - I wish I could justify the expense! It would have been 
> > great to catch up with everyone but I'm working on non-Cordova 
> > related projects these days.
> >
> > On Tue, Aug 25, 2015 at 4:24 PM, Carlos Santana 
> > 
> > wrote:
> >
> >> Hey Brian are you going to Face to Face Meetup on Oct?
> >>
> >> - Carlos
> >> Sent from my iPhone
> >>
> >>> On Aug 25, 2015, at 4:09 PM, Steven Gill 
> wrote:
> >>>
> >>> Sweet! Let me know if you have any questions for releasing!
> >>>
> >>> -Steve
> >>>
> >>> On Tue, Aug 25, 2015 at 12:58 PM, Carlos Santana 
> >>> 
> >>> wrote:
> >>>
>  You are alive!!!
> 
>  I was afraid a truck hit you all guys :-)
> 
>  - Carlos
>  Sent from my iPhone
> 
> >> On Aug 25, 2015, at 3:24 PM, Bryan Higgins 
> >> 
> > wrote:
> >
> > Hi all,
> >
> > It's been a while :)
> >
> > I'd like to do a maintenance release for BlackBerry this week.
> > Here is
>  the
> > change log for anyone interested. Special thanks to Tim Windsor 
> > for
>  taking
> > on much of this work.
> >
> > -Bryan
> >
> > CB-8306 Fix parseUri to handle http://foo/bar?a...@b.com
> > CB-7807 Add BlackBerry10 platform to a project on any 
> > workstation OS
> > CB-8417 moved platform specific js into platform
> > CB-8417 renamed platform_modules into cordova-js-src
> > CB-8899 stick to grunt-jasmine-node@0.2.1
> > CB-9072 Fix exception logging in packager.js
> > CB-9010 Adds check_reqs implementation
> > CB-8941 Adds support for subdomain whitelisting
> > CB-6768 Handle icons outside of www/.
> > CB-9009 include http://localhost:8472 in Content-Security-Policy
> >> header
> > CB-6768 Default Icon is now copied into platform_www.
> 
>  -
>  --
>  -- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>  For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >> ---
> >> -- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-docs pull request: Removed redundant TOC headers in docs

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/324

Removed redundant TOC headers in docs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs cordova-website-toc-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #324


commit a8a96ae73270a96d3687d115aca7e5df43db0db6
Author: riknoll 
Date:   2015-08-28T21:31:55Z

Removed redundant TOC headers in docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Cordova website plugin improvements

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/325

Cordova website plugin improvements

Converts the plugin help pages to markdown so that their formatting remains 
consistent with the rest of the website and tweaked their content slightly. 
Also:

* Adds credit to npmsearch below the search results
* Adds title text to platform icons in search results for accessibility 
reasons
* Removes plugin issue tracker link
* CSS fixes for plugins

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs 
cordova-website-plugin-improvements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #325


commit 81620fad1e1436ccc917593c76381eec722c05d1
Author: riknoll 
Date:   2015-08-29T00:21:41Z

Removed plugin issue tracker link

commit cb423b4def15b9e6adf4bf6343cb6136e92d3533
Author: riknoll 
Date:   2015-08-29T00:53:56Z

Fixed some plugins CSS, links, and added npmsearch credit

commit f5a706252a99b5d9c386fd6121d59625c74ac9ee
Author: riknoll 
Date:   2015-08-31T18:25:12Z

Converted plugin help pages to markdown and fixed minor content errors

commit 7b148293a4411a38270c28ee31cadc8a5e8eac83
Author: riknoll 
Date:   2015-08-31T20:14:29Z

Added title text for the icons in plugin cards




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

[muratsu]

Github user muratsu commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-136498895
  
I think the logic needs some rework.
Imagine original picture with size 2w x 1h (aspect ratio 2). If we want to 
scale this image to 10x5 this CR will provide us with 5x2.5 which is not the 
most optimum outcome. 

Ideally the outcome should be:

original width x height | aspect ratio
--- | ---
2x1 | 2

 target width x height  | target aspect ratio | output width x height | 
output aspect ratio
--- | --- | --- | ---
10x5 | 2 | 10x5 | 2
12x5 | 2,4 | 10x5 | 2
8x5 | 1,6 | 8x4 | 2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

[trubit]

Github user trubit commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-136507080
  
Yeah, in my case it worked, but correct calculation is:
var scale = Math.min(targetWidth / this.width, targetHeight / 
this.height);

Calculates ratio for both sides and pick the small one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

[muratsu]

Github user muratsu commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-136510649
  
Yup, looks like right. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request: Fix a typo in README.md

[tripodsan]

Github user tripodsan commented on the pull request:

https://github.com/apache/cordova-osx/pull/11#issuecomment-136515109
  
this should be closed. the typo is fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Discuss] BlackBerry Release

[Bryan Higgins]

I'm on it :)

On Mon, Aug 31, 2015 at 7:00 PM, Steven Gill  wrote:

> Lets get this vote thread started!
>
> On Mon, Aug 31, 2015 at 1:06 PM, Tim Windsor 
> wrote:
>
> > I've tested the mobile-spec app on the previous version and the new one.
> > While there are issues, they appear to be the same from what I've seen.
> >
> > Tim Windsor
> > Open Source Technical Lead – Devices
> >
> >
> >
> >
> >
> > -Original Message-
> > From: Bryan Higgins [mailto:br...@bryanhiggins.net]
> > Sent: Saturday, August 29, 2015 11:34 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [Discuss] BlackBerry Release
> >
> > I've uploaded the RC here:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-9576/
> >
> > We'll need to test it before starting a VOTE thread (hopefully on
> Monday).
> >
> > On Wed, Aug 26, 2015 at 3:39 PM, Tim Windsor 
> > wrote:
> >
> > > Tim here - I think the code is in good shape for release. I've tested
> > > with it in a few projects that have built successfully.
> > >
> > > I've got no more pull requests planned at this time.
> > >
> > > Tim Windsor
> > > Open Source Technical Lead - Devices
> > >
> > >
> > >
> > >
> > >
> > > -Original Message-
> > > From: Carlos Santana [mailto:csantan...@gmail.com]
> > > Sent: Wednesday, August 26, 2015 8:56 AM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [Discuss] BlackBerry Release
> > >
> > > Brian nice to hear from you.
> > >
> > > I completely understand, I'm not 100% still waiting on finance
> > > division to see if they will approve the expense.
> > >
> > > - Carlos
> > > Sent from my iPhone
> > >
> > > > On Aug 26, 2015, at 8:31 AM, Bryan Higgins 
> > > wrote:
> > > >
> > > > Steve - thanks! I'll let you know if I hit any roadblocks.
> > > >
> > > > Carlos - I wish I could justify the expense! It would have been
> > > > great to catch up with everyone but I'm working on non-Cordova
> > > > related projects these days.
> > > >
> > > > On Tue, Aug 25, 2015 at 4:24 PM, Carlos Santana
> > > > 
> > > > wrote:
> > > >
> > > >> Hey Brian are you going to Face to Face Meetup on Oct?
> > > >>
> > > >> - Carlos
> > > >> Sent from my iPhone
> > > >>
> > > >>> On Aug 25, 2015, at 4:09 PM, Steven Gill 
> > > wrote:
> > > >>>
> > > >>> Sweet! Let me know if you have any questions for releasing!
> > > >>>
> > > >>> -Steve
> > > >>>
> > > >>> On Tue, Aug 25, 2015 at 12:58 PM, Carlos Santana
> > > >>> 
> > > >>> wrote:
> > > >>>
> > >  You are alive!!!
> > > 
> > >  I was afraid a truck hit you all guys :-)
> > > 
> > >  - Carlos
> > >  Sent from my iPhone
> > > 
> > > >> On Aug 25, 2015, at 3:24 PM, Bryan Higgins
> > > >> 
> > > > wrote:
> > > >
> > > > Hi all,
> > > >
> > > > It's been a while :)
> > > >
> > > > I'd like to do a maintenance release for BlackBerry this week.
> > > > Here is
> > >  the
> > > > change log for anyone interested. Special thanks to Tim Windsor
> > > > for
> > >  taking
> > > > on much of this work.
> > > >
> > > > -Bryan
> > > >
> > > > CB-8306 Fix parseUri to handle http://foo/bar?a...@b.com
> > > > CB-7807 Add BlackBerry10 platform to a project on any
> > > > workstation OS
> > > > CB-8417 moved platform specific js into platform
> > > > CB-8417 renamed platform_modules into cordova-js-src
> > > > CB-8899 stick to grunt-jasmine-node@0.2.1
> > > > CB-9072 Fix exception logging in packager.js
> > > > CB-9010 Adds check_reqs implementation
> > > > CB-8941 Adds support for subdomain whitelisting
> > > > CB-6768 Handle icons outside of www/.
> > > > CB-9009 include http://localhost:8472 in Content-Security-Policy
> > > >> header
> > > > CB-6768 Default Icon is now copied into platform_www.
> > > 
> > >  -
> > >  --
> > >  -- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >  For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >>
> > > >> ---
> > > >> -- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >>
> > > >>
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

[GitHub] cordova-registry pull request: Revert "Revert "made registry read-...

[stevengill]

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-registry/pull/1

Revert "Revert "made registry read-only""

This reverts commit f0b3f27c960b7a5ddce6c0219f29c7278356045f.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-registry master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-registry/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit b747112a675bb239eb5e1239d0468d8ae378bc05
Author: Steve Gill 
Date:   2015-08-31T23:18:39Z

Revert "Revert "made registry read-only""

This reverts commit f0b3f27c960b7a5ddce6c0219f29c7278356045f.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Update: Plugins Registry warnings

[Steven Gill]

So I have a PR ready to make the registry read-only. [1]

Unfortunately, plugman don't support outputting the errors received from
the registry to our users. `plugman publish PLUGIN` outputs `publish fail`.

Even though I added a nice error message to the registry, users won't see
it. Maybe other tools which consume plugins directly from the registry will
be able to use this message.

If others have better suggestions for this problem, please share.

Any holdback on me merging this commit and deploying it?

Note: I accidentally pushed my original commit to the wrong origin (apache)
so reverted it.

[1] https://github.com/apache/cordova-registry/pull/1

On Tue, Aug 11, 2015 at 7:14 PM, Shazron  wrote:

> "At the last hangout we discussed delaying switching the registry over to
> read only until Aug 15thish. We should discuss what else needs to happen
> for us to hit this."
>
> This is coming up fast. Anything we need to do before this deadline?
>
> On Thu, Jul 30, 2015 at 10:08 AM, Steven Gill 
> wrote:
>
> > So I looked into adding warnings into the registry that users who are
> > trying to publish/adduser would get, but it won't work.
> >
> > If plugman publish is successful, plugman does nothing. If plugman
> publish
> > fails, plugman will output the error that the registry sends.
> >
> > Once we switch the registry to read-only, I'll add an error message that
> > tells users to publish to npm and points them to the appropriate guide.
> >
> > At the last hangout we discussed delaying switching the registry over to
> > read only until Aug 15thish. We should discuss what else needs to happen
> > for us to hit this.
> >
> > The next tools release, plugman looses all commands related to the
> registry
> > (publish, unpublish, adduser, owner). I'll be starting that release right
> > after iOS 3.9.0 is done releasing.
> >
> > I am going to spend time tomorrow trying to gather the emails of people
> who
> > are still publishing and send them an email asking them to move over to
> > npm.
> >
> > -Steve
> >
>

[GitHub] cordova-osx pull request: CB-9581 OSX WebView does not send cookie...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-osx/pull/22#issuecomment-136527429
  
I'll pull this in and close both this and PR #21 at the same time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request: @trivial add 'Resources' group so that p...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-osx/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request: CB-9581 OSX WebView does not send cookie...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-osx/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: [CB-7965] Add cordova-plugi...

[surajpindoria]

GitHub user surajpindoria opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/31

[CB-7965] Add cordova-plugin-statusbar support for browser platform



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/surajpindoria/cordova-plugin-statusbar 
browserSupport

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit a0e5b517e07acc92e891fe869e1b8fc8c395b6a2
Author: Suraj Pindoria 
Date:   2015-08-31T22:55:17Z

[CB-7965] Add cordova-plugin-statusbar support for browser platform




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request: [CB-7966] Add cordova-plugi...

[surajpindoria]

GitHub user surajpindoria opened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/37

[CB-7966] Add cordova-plugin-vibration support for browser platform

The previous imple

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/surajpindoria/cordova-plugin-vibration 
browserSupport

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit aa9835a71bc12e62d4520ac575de74a4e2790c84
Author: Suraj Pindoria 
Date:   2015-08-31T19:00:51Z

[CB-7966] Add cordova-plugin-vibration support for browser platform




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] 3.8.0 BlackBerry Release

[Bryan Higgins]

Please review and vote on this 3.8.0 BlackBerry Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-9576

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-9576

The package was published from its corresponding git tag:
3530eaa782

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-blackberry#3.8.0

Blog post to review is here:

https://github.com/cordova/apache-blog-posts/pull/45

Upon a successful vote I will upload the archive to dist/, publish it to
NPM, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses

[GitHub] cordova-osx pull request: Fix a typo in README.md

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-osx/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Tools Release?

[Tim Barham]

Thanks Steve. And yeah, I'd done the testing - just wanted to verify the 
archives :).

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Tuesday, September 1, 2015 4:00 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Tools Release?

Hey Tim,

You are correct. I forgot to run svn commit. Updated RC's are now there.

You can also test using npm install -g cordova@rc

On Aug 30, 2015 10:01 PM, "Tim Barham"  wrote:

> Hey Steve - you mention version bumps for lib, cli and plugman, but that
> doesn't seem to be what's in dist/dev... There we have lib 5.3.0, cli 5.3.0
> and plugman 1.01, but in the vote email you refer to lib 5.3.1, cli 5.3.1
> and plugman 1.0.2. Did you miss updating dist/dev?
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Saturday, August 29, 2015 10:11 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release?
>
> Ended up making a mistake with lib which made me have to bump patch
> versions for lib, cli, and plugman. ugh. Vote is up.
>
> On Fri, Aug 28, 2015 at 11:18 AM, Steven Gill 
> wrote:
>
> > Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9574=01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7c7c548018227b4e339f2008d2b0066f52%7c72f988bf86f141af91ab2d7cd011db47%7c1=uXAIHKcK0orjQpH5%2bt9Nnwb3XQWuAFVnqgKme8mJ5uQ%3d
> >
> > On Thu, Aug 27, 2015 at 11:53 PM, Nikhil Khandelwal <
> > nikhi...@microsoft.com> wrote:
> >
> >> I really just meant minor version bump instead of major. Sorry for the
> >> mix-up in terminology.
> >>
> >> -Nikhil
> >>
> >> -Original Message-
> >> From: Carlos Santana [mailto:csantan...@gmail.com]
> >> Sent: Thursday, August 27, 2015 11:07 PM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [DISCUSS] Tools Release?
> >>
> >> That was my thinking no API breakage no major bump.
> >>
> >> Feature added minor bump
> >>
> >> - Carlos
> >> Sent from my iPhone
> >>
> >> > On Aug 28, 2015, at 1:47 AM, Steven Gill 
> >> wrote:
> >> >
> >> > It is interesting. Adding a new platform could be consideration for a
> >> > major or minor. The platform (OSX) is having a major jump.
> >> >
> >> > According to semver, a major would be making a incompatible api change
> >> > and a minor would be adding functionality in a backwards-compatible
> >> manner.
> >> >
> >> > We don't break anything by adding osx, so I'm leaning toward minor.
> >> >
> >> > -Steve
> >> >
> >> > On Thu, Aug 27, 2015 at 10:37 PM, Carlos Santana
> >> > 
> >> > wrote:
> >> >
> >> >> +1 minor release bump not major
> >> >>
> >> >> - Carlos
> >> >> Sent from my iPhone
> >> >>
> >> >>> On Aug 27, 2015, at 11:45 PM, Nikhil Khandelwal
> >> >>> 
> >> >> wrote:
> >> >>>
> >> >>> Also, there has been a browser release that we need to pin.
> >> >>>
> >> >>> -Nikhil
> >> >>>
> >> >>> -Original Message-
> >> >>> From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> >> >>> Sent: Wednesday, August 26, 2015 6:21 PM
> >> >>> To: dev@cordova.apache.org
> >> >>> Subject: RE: [DISCUSS] Tools Release?
> >> >>>
> >> >>> +1. Not sure if it will be a patch release as it does ship new
> >> >>> +platforms
> >> >> along with it and it could be considered a major bump because of
> that.
> >> >>>
> >> >>> -Nikhil
> >> >>>
> >> >>> -Original Message-
> >> >>> From: Jesse [mailto:purplecabb...@gmail.com]
> >> >>> Sent: Wednesday, August 26, 2015 6:17 PM
> >> >>> To: dev@cordova.apache.org
> >> >>> Subject: Re: [DISCUSS] Tools Release?
> >> >>>
> >> >>> +1
> >> >>>
> >> >>>
> >> >>>
> >>  On Aug 26, 2015, at 6:14 PM, Carlos Santana 
> >> >> wrote:
> >> 
> >>  Yep makes sense to cut a release before that PR hits master
> >> > On Wed, Aug 26, 2015 at 9:11 PM Carlos Santana
> >> > 
> >> >> wrote:
> >> >
> >> > +1
> >> > On Wed, Aug 26, 2015 at 8:47 PM Steven Gill
> >> > 
> >> > wrote:
> >> >
> >> >> How do people feel about a patch tools release including the
> >> >> recently released platforms (windows, browser) + early support
> >> >> for osx + updated cordova-serve.
> >> >>
> >> >> It would be nice to get this out before we add the new platform
> >> >> api polyfill PR which is slated to get merged end of this week.
> >> >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2f
> >> >> git
> >> >> https://na01.safelinks.protection.outlook.com/?url=hub.com=01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7cfa41d3cc7ca04072345908d2b22e0c19%7c72f988bf86f141af91ab2d7cd011db47%7c1=8GXT31S4lpImvW7YMtRXw3L%2fvamYUX71DFlnFT1AGKA%3d
> %2fapache%2fcordova-lib%2fpull%2f282=01%7c01%7cnikhil
> >> >> kh%
> >> >> 

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38373392
  
--- Diff: gulpfile.js ---
@@ -31,6 +33,7 @@ var WATCH_INTERVAL= 1000; // in milliseconds
 var ROOT_DIR   = ".";
 var SOURCE_DIR = path.join(ROOT_DIR, "www");
 var DEV_DIR= path.join(ROOT_DIR, "build-dev");
+var LINT_DIR= path.join(DEV_DIR, "blog");
--- End diff --

But this excludes the rest of the site too, which should be linted. Is 
there a way to tell `htmlverify` to exclude/ignore a path?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38373454
  
--- Diff: gulpfile.js ---
@@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) {
 exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_posts")], done);
 });
 
+gulp.task('lint', function() {
+return gulp.src(path.join(LINT_DIR, "**", "*.html"))
+.pipe(htmllint());
+});
+
+gulp.task('checklinks', function(cb) {
+  crawler.crawl('http://localhost:3000/')
--- End diff --

Why should it depend on the `serve` task?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38373489
  
--- Diff: gulpfile.js ---
@@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) {
 exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_posts")], done);
 });
 
+gulp.task('lint', function() {
+return gulp.src(path.join(LINT_DIR, "**", "*.html"))
+.pipe(htmllint());
+});
+
+gulp.task('checklinks', function(cb) {
+  crawler.crawl('http://localhost:3000/')
+.on('fetch404', function(queueItem, response) {
--- End diff --

It's not caught. This tool can't replace manual inspection entirely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38373580
  
--- Diff: gulpfile.js ---
@@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) {
 exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_posts")], done);
 });
 
+gulp.task('lint', function() {
--- End diff --

Only when all linter errors are fixed, can we have build depend on lint. 
For now, it should be an independent task. We don't have jslint. I filed it as 
a separate feature to add, but it won't be in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38373786
  
--- Diff: gulpfile.js ---
@@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) {
 exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_posts")], done);
 });
 
+gulp.task('lint', function() {
+return gulp.src(path.join(LINT_DIR, "**", "*.html"))
+.pipe(htmllint());
+});
+
+gulp.task('checklinks', function(cb) {
+  crawler.crawl('http://localhost:3000/')
--- End diff --

Because it expects localhost:3000 to be present for this to work


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removed redundant TOC headers in docs

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removed redundant TOC headers in docs

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/324#issuecomment-136531188
  
[I love 
it](https://youtube.googleapis.com/v/keLVVzekMbU?start=0=2=3)! 
Merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38374303
  
--- Diff: www/_includes/footer.html ---
@@ -72,3 +74,6 @@
 
 
 

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/323#discussion_r38375651
  
--- Diff: gulpfile.js ---
@@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) {
 exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_posts")], done);
 });
 
+gulp.task('lint', function() {
+return gulp.src(path.join(LINT_DIR, "**", "*.html"))
+.pipe(htmllint());
+});
+
+gulp.task('checklinks', function(cb) {
+  crawler.crawl('http://localhost:3000/')
--- End diff --

A server should be running for this task to succeed, but a server should 
not be started every time this task runs. Let's instead encode this dependency 
by adding a statement like `console.log("Make sure the server is running on " + 
SERVE_URL + "before running this task.")` to the `'checklinks'` task.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-9585 Support globs with 'coho verify...

[TimBarham]

GitHub user TimBarham opened a pull request:

https://github.com/apache/cordova-coho/pull/93

CB-9585 Support globs with 'coho verify-archive' command.

This adds supports for globs to the `coho verify-archive` command, so you 
can pass wildcards such as:

coho verify-archive *.tgz

(which is handy, since that's what `coho create-archive` says to do 
:smile:).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-coho verify-archive-globs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #93


commit a701d6303eb86a1f609dd9afc6caa0e0188b0109
Author: Tim Barham 
Date:   2015-09-01T00:32:49Z

CB-9585 Support globs with 'coho verify-archive' command.

This adds supports for globs to the 'coho verify-archive' command, so you 
can pass wildcards such as:

coho verify-archive *.tgz

(which is handy, since that's what 'coho create-archive' says to do :) ).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-9557 Fixes apk install failure wh...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/209#issuecomment-136538097
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: The extra digit need to be added to ...

[fujunwei]

Github user fujunwei commented on the pull request:

https://github.com/apache/cordova-android/pull/211#issuecomment-136538202
  
@agrieve 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9462 iOS 3.9.0 breaks npm link module...

[rayshan]

Github user rayshan commented on the pull request:

https://github.com/apache/cordova-ios/pull/153#issuecomment-136541007
  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Update: Plugins Registry warnings

[Nikhil Khandelwal]

On a related note, was our plan to do re-direction from old plugin registry ID 
to npm ID? I still get a warning and no automatic re-direction with latest 
cordova.

cordova plugin add org.apache.cordova.camera
Fetching plugin "org.apache.cordova.camera" via npm
WARNING: org.apache.cordova.camera has been renamed to cordova-plugin-camera. 
You may not be getting the latest version! We suggest you `cordova plugin rm 
org.apache.cordova.camera` and `cordova plugin add cordova-plugin-camera`.

Thanks,
Nikhil


-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Monday, August 31, 2015 4:25 PM
To: dev@cordova.apache.org
Subject: Re: Update: Plugins Registry warnings

So I have a PR ready to make the registry read-only. [1]

Unfortunately, plugman don't support outputting the errors received from the 
registry to our users. `plugman publish PLUGIN` outputs `publish fail`.

Even though I added a nice error message to the registry, users won't see it. 
Maybe other tools which consume plugins directly from the registry will be able 
to use this message.

If others have better suggestions for this problem, please share.

Any holdback on me merging this commit and deploying it?

Note: I accidentally pushed my original commit to the wrong origin (apache) so 
reverted it.

[1] 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-registry%2fpull%2f1=01%7c01%7cnikhilkh%40microsoft.com%7cf6adff27b1b24fc2cceb08d2b25b72cb%7c72f988bf86f141af91ab2d7cd011db47%7c1=7PRvSCOB7pl%2b5Hj3MoQAJSOjTWXXBsRluJJ04823hMI%3d

On Tue, Aug 11, 2015 at 7:14 PM, Shazron  wrote:

> "At the last hangout we discussed delaying switching the registry over 
> to read only until Aug 15thish. We should discuss what else needs to 
> happen for us to hit this."
>
> This is coming up fast. Anything we need to do before this deadline?
>
> On Thu, Jul 30, 2015 at 10:08 AM, Steven Gill 
> wrote:
>
> > So I looked into adding warnings into the registry that users who 
> > are trying to publish/adduser would get, but it won't work.
> >
> > If plugman publish is successful, plugman does nothing. If plugman
> publish
> > fails, plugman will output the error that the registry sends.
> >
> > Once we switch the registry to read-only, I'll add an error message 
> > that tells users to publish to npm and points them to the appropriate guide.
> >
> > At the last hangout we discussed delaying switching the registry 
> > over to read only until Aug 15thish. We should discuss what else 
> > needs to happen for us to hit this.
> >
> > The next tools release, plugman looses all commands related to the
> registry
> > (publish, unpublish, adduser, owner). I'll be starting that release 
> > right after iOS 3.9.0 is done releasing.
> >
> > I am going to spend time tomorrow trying to gather the emails of 
> > people
> who
> > are still publishing and send them an email asking them to move over 
> > to npm.
> >
> > -Steve
> >
>

RE: [Vote] Tools Release Aug 28th

[Tim Barham]

+1

* Verified tags with coho verify-tags
* Verified signature and hashes with coho verify-archive
* Verified package contents match git repo at tag
* Installed Cordova
* Built and ran blank app for Windows, Android, Browser
* Verified blank app launches without error in Ripple

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Saturday, August 29, 2015 10:12 AM
To: dev@cordova.apache.org
Subject: Re: [Vote] Tools Release Aug 28th

You can test via npm install -g cordova@rc

On Fri, Aug 28, 2015 at 5:10 PM, Steven Gill  wrote:

> Please review and vote on this Tools Release by replying to this email 
> (and keep discussion on the DISCUSS thread)
>
> Release issue: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-9574=01%7c01%7cTBARHAM%40064d.m
> gd.microsoft.com%7ca8bb5a9a2bfe4287d40908d2b00676a6%7c72f988bf86f141af
> 91ab2d7cd011db47%7c1=G6OWjCtY79PXjOYZ%2bgrDYft3srcryHEaWeoRQXGs8
> yA%3d
>
> Both tools have been published to 
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9574/
>
> The packages were published from their corresponding git tags:
>
> cordova-js: 4.1.1 (66c2bb8e56)
> cordova-lib: 5.3.1 (7ce4eb4b8f)
> cordova-plugman: 1.0.2 (ee8aefc5cc)
> cordova-cli: 5.3.1 (427c1f2294)
>
> Upon a successful vote I will upload the archives to dist/, publish them to 
> NPM, and post the corresponding blog post.
>
> Voting guidelines: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting.
> md=01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7ca8bb5a9a2bfe4287d
> 40908d2b00676a6%7c72f988bf86f141af91ab2d7cd011db47%7c1=FicqExIIO
> g%2b4GPNn9s3Q6MH5N7PFoaOH4SezvFXIYM0%3d
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Built hello world app and mobile-spec
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9556 Don't uninstall dependent plugin...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/287#discussion_r38295456
  
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -273,8 +273,13 @@ function runInstall(actions, platform, project_dir, 
plugin_dir, plugins_dir, opt
 var platformJson = PlatformJson.load(plugins_dir, platform);
 
 if (platformJson.isPluginInstalled(pluginInfo.id)) {
+var msg = 'Plugin "' + pluginInfo.id + '" already installed on ' + 
platform + '.';
--- End diff --

Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Unified logging proposal

[Sergey Shakhnazarov (Akvelon)]

Hi guys,

Please take a look at proposal on Unified logging (related to the proposal on 
cordova-lib refactoring[1]):
https://github.com/cordova/cordova-discuss/issues/14

[1]: https://github.com/cordova/cordova-discuss/pull/12

Please let me know if you have any questions or considerations.

Best regards,
Sergey Shakhnazarov

[GitHub] cordova-lib pull request: CB-9556 Don't uninstall dependent plugin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/287


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Marshmallow Update and Cordova-Android 5.0

[Joe Bowser]

BTW: I got Contacts somewhat working with Marshmellow.  It's still got the
same crappy concurrency bugs that it always has, and I am not sure how to
resolve those without re-writing the damn thing, but the purpose of this is
to figure out how to get permissions to work, and I have something that
works.

https://github.com/infil00p/cordova-plugin-contacts/tree/smores

This works with the latest smores tree of Cordova Android, and I tested it
on Lollipop and Marshmellow.  I'm going to move on to some of the other
plugins to get them ready for Marshmellow, but it'd be good to have people
look these over.

I did find a nasty security bug with this, though.  If you request one
permission out of the permission group, you get all the permissions.  So,
anything that can read contacts can magically write contacts even if you
don't request that permission explicitly.  I think this is a serious bug,
and I'm going to dig tomorrow to see if someone already reported it.

On Mon, Aug 31, 2015 at 11:35 AM Joe Bowser  wrote:

> Hey
>
> So, I created a new topic branch of my github with the new changes as
> suggested earlier.
>
> https://github.com/infil00p/cordova-android/tree/smores
>
> The thing we have to make sure works is if the user turns off the
> permissions on Marshmellow.  Right now if the permissions are off,
> everything crashes and dies, so we're going to issue a 5.0 because plugins
> will have to have this code to work on the latest version of Android.  It's
> not a API change, since we're adding it, but I feel that it's important
> enough that we should bump the major version anyway.
>
> Can we PLEASE not have any other features creep into 5.0?  If we need
> additional features, we can do a 6.0.  I'm not against bumping major
> versions as long as we get into a trend of not breaking shit like we did in
> the bump from 3.7 to 4.0.
>
> Also, we're going to deprecate 3.7, is there any major third-party plugins
> that still don't work with 4.0.x that we should be aware of?  Do we have
> people to cover the docs on that.
>
> Thoughts?
>
> Joe
>
>
>

[GitHub] cordova-registry pull request: Revert "Revert "made registry read-...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-registry/pull/1#issuecomment-136591049
  
Is there any reason to keep all the commented code around? It will live in 
the repo history anyway, why not delete it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-8936 iOS logs gathering

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/60#discussion_r38379807
  
--- Diff: buildbot-conf/cordova.conf ---
@@ -360,9 +360,10 @@ def cordova_steps_run_tests(platform, 
extra_args=list()):
 'log',
 '--platform', platform
 ],
-description   = 'gathering logs',
-timeout   = LOG_GETTING_TIMEOUT,
-haltOnFailure = False,
+description= 'gathering logs',
+timeout= LOG_GETTING_TIMEOUT,
+haltOnFailure  = False,
+flunkOnFailure = False,
--- End diff --

Good call with this one! However, later on we should also debug what's 
causing this error on Windows: `Couldn't find log file. It may be because of 
old cordova-windows version or some problems with log script.`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-8936 iOS logs gathering

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-medic/pull/60


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

[KonradFak]

Github user KonradFak commented on the pull request:

https://github.com/apache/cordova-lib/pull/256#issuecomment-136372119
  

+1, waiting for merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-9579 Fixed failed tests w...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/74

CB-9579 Fixed failed tests when "DeleteMe" contact already exists

https://issues.apache.org/jira/browse/CB-9579

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-9579

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #74


commit d51590c4bf873e292adbc4c32f06896967c25059
Author: Alexander Sorokin 
Date:   2015-08-31T14:05:58Z

CB-9579 Fixed failed tests when "DeleteMe" contact already exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

[psychowico]

Github user psychowico commented on the pull request:

https://github.com/apache/cordova-lib/pull/256#issuecomment-136369156
  
can you merge this, plz? very annoying bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org