[GitHub] cordova-medic pull request: CB-9660 Don't kill emulators/apps afte...

2015-09-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-medic/pull/65


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-medic pull request: CB-9660 Don't kill emulators/apps afte...

2015-09-22 Thread dblotsky
Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-medic/pull/65#issuecomment-142384410
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...

2015-09-22 Thread dblotsky
Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/64#discussion_r40131491
  
--- Diff: medic/medic-log.js ---
@@ -63,10 +63,14 @@ function logIOS() {
 });
 }
 
-function logWindows() {
+function logWindows(timeout) {
 var logScriptPath = path.join("mobilespec", "platforms", "windows", 
"cordova", "log.bat");
 if (fs.existsSync(logScriptPath)) {
-shelljs.exec(logScriptPath + " --dump --mins 15", function (code, 
output) {
+var mins = 15;
+if (timeout) {
+mins = Math.ceil(timeout / 60);
--- End diff --

A few notes:
- Please add a small constant (~2 min) to the time so that we also capture 
anything that happened before the run
- Please factor out the default 15 mins into a constant
- Please add a function to convert minutes to seconds, so it's easier to 
read (i.e. `mins = sec2min(timeout)`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9552 Updating linked platform removes...

2015-09-22 Thread macdonst
GitHub user macdonst opened a pull request:

https://github.com/apache/cordova-ios/pull/165

CB-9552 Updating linked platform removes original files

If symlink then just unlink not recursive removal of directory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cordova-ios CB-9552

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #165


commit 39648f0bdfb8b06f8ae6af5609c8c2a51ba4dc17
Author: Simon MacDonald 
Date:   2015-09-22T19:30:43Z

CB-9552 Updating linked platform removes original files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



CVE-2015-5204: HTTP header injection vulnerability in Apache Cordova File Transfer Plugin for Android

2015-09-22 Thread Joe Bowser
CVE-2015-5204: HTTP header injection vulnerability in Apache Cordova File
Transfer Plugin for Android

Severity:
 Medium

Vendor:
 The Apache Software Foundation

Versions Affected:
 Cordova Android File Transfer Plugin  (1.2.1 and below)

Description:
 Android applications built with the Cordova framework that use the File
 Transfer Plugin can have the HTTP headers set by that plugin be manipulated
 by the filename being uploaded.  This allows for for cookies to be forged
 by the Cordova application, or for the file payload to be replaced in some
 situations.  Remotely hosted applications and applications developed with
 Cordova that allow the user to manually enter the filename are
 especially vulnerable to this issue.

Upgrade path:
 Developers who are concerned about this issue should install version 1.3.0
 or higher of the Cordova File Transfer Plugin and rebuild their
 applications.  This plugin now conforms with RFC-2616 and no longer allows
 non-ASCII characters and control characters in header names or values.
 Any non-ASCII characters will be removed from the header.  Developers
should be aware,
 and encode these characters before adding the values to the header.

Credit:
 This issue was discovered by Muneaki Nishimura (Sony Digital Network
Applications, Inc.)


Re: Cordova Face to Face Meeting

2015-09-22 Thread Simon MacDonald
Congratulations Carlos and Edna, I know how difficult that must have been.

Most Adobians are staying at the Silver Cloud Inn, 2122 152nd Avenue
Northeast, Redmond, WA 98052 which has a shuttle to MS.

Also, created #f2f channel on Cordova Slack.


Simon Mac Donald
http://hi.im/simonmacdonald

On Tue, Sep 22, 2015 at 12:52 PM, Carlos Santana 
wrote:

> Hi finally the Magical Goblins from finance send a telegram.
> I'm happy to announce that two IBMers got approved to attend, me and Edna
>
> So I need more info to book our travel. Where are folks staying what's the
> address, do we need a car or you guys have Uber?
>
> What you all think if I create a #F2F Slack channel to ask more of my
> stupid questions and kind organize those attending?
>
>
>
> On Tue, Sep 15, 2015 at 2:28 PM Parashuram N 
> wrote:
>
> > Hi,
> >
> > We are only a month away from the Cordova Face to Face meeting on Oct
> 14th
> > and 15th !! This is a friendly reminder to make your travel arrangements
> to
> > Redmond, WA, USA. I will send out the exact address in Redmond in a
> follow
> > up email.
> > Note that this meet up is open to anyone who is interested in making the
> > Cordova project better, builds tools on top of Apache Cordova, or simply
> > has ideas/issues with the project. The tentative agenda for the meeting
> is
> > here -
> >
> https://github.com/cordova/cordova-discuss/blob/master/proposals/Face2Face-Oct15.md
> >
> > I am also working to see if I can set up a live-stream or at least a
> voice
> > call for majority of this meeting.
> >
> > Action Item: I think we should seed the meeting with some of the topics
> we
> > would like to discuss at the meeting, so I request you to either respond
> to
> > this email with potential topics you would like to discuss, or edit the
> > agenda directly.
> > Some topics we could discuss are
> >
> >
> > -  Documentation
> >
> > -  Continuous Integration and how folks can participate
> >
> > -  Platform specific discussions - Android, iOS, etc
> >
> > -  Identifying Main pain points for Cordova users.
> >
> > -  
> >
>


RE: Cordova Face to Face Meeting

2015-09-22 Thread Parashuram N
The meeting will take place in Microsoft Main Campus - mostly in building 33. 
There are a number of hotels in an around Redmond. You can even pick hotels in 
Belleve downtown or Redmond downtown (closer) . There are Microsoft offices 
nearby from where you can get a shuttle to where the meeting happens. 

I will also start a registration to get a count of all the folks who will be 
coming. 

P.S: A pixie told me a secret that people who register have a remote chance to 
get Microsoft company store vouchers :) 

-Original Message-
From: Simon MacDonald [mailto:simon.macdon...@gmail.com] 
Sent: Tuesday, September 22, 2015 10:13 AM
To: dev@cordova.apache.org
Subject: Re: Cordova Face to Face Meeting

Congratulations Carlos and Edna, I know how difficult that must have been.

Most Adobians are staying at the Silver Cloud Inn, 2122 152nd Avenue Northeast, 
Redmond, WA 98052 which has a shuttle to MS.

Also, created #f2f channel on Cordova Slack.


Simon Mac Donald
https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald=01%7c01%7cpanarasi%40microsoft.com%7ca155949ee7d24e940ab908d2c3712e60%7c72f988bf86f141af91ab2d7cd011db47%7c1=VavGZuUnGqrYafpSE10AM37V4UYMnHio6iyGApTS1MQ%3d

On Tue, Sep 22, 2015 at 12:52 PM, Carlos Santana 
wrote:

> Hi finally the Magical Goblins from finance send a telegram.
> I'm happy to announce that two IBMers got approved to attend, me and 
> Edna
>
> So I need more info to book our travel. Where are folks staying what's 
> the address, do we need a car or you guys have Uber?
>
> What you all think if I create a #F2F Slack channel to ask more of my 
> stupid questions and kind organize those attending?
>
>
>
> On Tue, Sep 15, 2015 at 2:28 PM Parashuram N 
> wrote:
>
> > Hi,
> >
> > We are only a month away from the Cordova Face to Face meeting on 
> > Oct
> 14th
> > and 15th !! This is a friendly reminder to make your travel 
> > arrangements
> to
> > Redmond, WA, USA. I will send out the exact address in Redmond in a
> follow
> > up email.
> > Note that this meet up is open to anyone who is interested in making 
> > the Cordova project better, builds tools on top of Apache Cordova, 
> > or simply has ideas/issues with the project. The tentative agenda 
> > for the meeting
> is
> > here -
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fcordova%2fcordova-discuss%2fblob%2fmaster%2fproposals%2fFace2F
> ace-Oct15.md=01%7c01%7cpanarasi%40microsoft.com%7ca155949ee7d24e9
> 40ab908d2c3712e60%7c72f988bf86f141af91ab2d7cd011db47%7c1=gRdv2RZ
> mlVcPSr1QTJyhA%2bkYdH4m5OkiP4xSOXDaly4%3d
> >
> > I am also working to see if I can set up a live-stream or at least a
> voice
> > call for majority of this meeting.
> >
> > Action Item: I think we should seed the meeting with some of the 
> > topics
> we
> > would like to discuss at the meeting, so I request you to either 
> > respond
> to
> > this email with potential topics you would like to discuss, or edit 
> > the agenda directly.
> > Some topics we could discuss are
> >
> >
> > -  Documentation
> >
> > -  Continuous Integration and how folks can participate
> >
> > -  Platform specific discussions - Android, iOS, etc
> >
> > -  Identifying Main pain points for Cordova users.
> >
> > -  
> >
>


RE: [DISCUSS] Tools Release

2015-09-22 Thread Sergey Grebnov (Akvelon)
Here is announce draft, please review
https://github.com/cordova/apache-blog-posts/pull/46/

Should we include link to JIRA issue for more details?
https://issues.apache.org/jira/browse/CB-9297 

Thx!
Sergey
-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Friday, September 18, 2015 3:20 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Tools Release

The new thread has started. I had to bump patch versions for tools, so they now 
are:
cordova-lib: 5.3.3 (932ad57858)
cordova-plugman: 1.0.4 (0de514b4b1)
cordova-cli: 5.3.3 (e647fe4382)

Also, packages, broken when published from Windows seems to be known problem:  
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fnpm%2fnpm%2fissues%2f2097=01%7c01%7cv-segreb%40microsoft.com%7cd9f82e0ca54a471d88c608d2c012d6c2%7c72f988bf86f141af91ab2d7cd011db47%7c1=zX8PqZr8%2fY2RRly4U9pl0eHLaSgrpqSwW8wpf5ZXVdg%3d
Probably we might workaround this by pinning  'eol=crlf' for executable scripts 
through .gitattributes (there is a nice article from GitHub here: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fhelp.github.com%2farticles%2fdealing-with-line-endings%2f=01%7c01%7cv-segreb%40microsoft.com%7cd9f82e0ca54a471d88c608d2c012d6c2%7c72f988bf86f141af91ab2d7cd011db47%7c1=O6Fverh%2fFbeXiPmW7kGfWswi8RAVvf8t4V7ZvfX8CUA%3d
 ). Any thoughts?

-
Best regards, Vladimir

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
Sent: Thursday, September 17, 2015 5:10 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Tools Release

BTW, could anybody please grant me access to npmjs. I had to ask Sergey to 
publish packages to NPM.

-
Best regards, Vladimir

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Thursday, September 17, 2015 4:57 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Tools Release

OK Vladimir

On Thu, Sep 17, 2015 at 9:50 AM Vladimir Kotikov (Akvelon) < 
v-vlk...@microsoft.com> wrote:

> Working on it
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Tommy-Carlos Williams [mailto:to...@devgeeks.org]
> Sent: Thursday, September 17, 2015 4:01 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release
>
> Were we waiting on a vote? I would +1
>
> > On 17 Sep 2015, at 22:50, Carlos Santana  wrote:
> >
> > A day has pass and no sign of a vote for the emergency fix.
> >
> > Why not just do a tools release with everything it's in master today?
> > in theory we should be able to do a release of what's in master at 
> > any time
> >
> >
> > On Thu, Sep 17, 2015 at 5:29 AM Vladimir Kotikov (Akvelon) < 
> > v-vlk...@microsoft.com> wrote:
> >
> >> I believe this is not a blocker. We have platforms pinned with 
> >> tilde, so platform's patch release will be picked up automatically.
> >>
> >> -
> >> Best regards, Vladimir
> >>
> >> -Original Message-
> >> From: Tommy Williams [mailto:to...@devgeeks.org]
> >> Sent: Thursday, September 17, 2015 7:59 AM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [DISCUSS] Tools Release
> >>
> >> I have a cherry pick to cordova-ios[1] that would be good to be 
> >> included in 5.3.2 if there are already plans to update iOS’s pinned 
> >> version…
> >>
> >> 1.
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> >> su
> >> es.apache.org%2fjira%2fbrowse%2fCB-9046=01%7c01%7cv-vlkoti%400
> >> 64
> >> d.mgd.microsoft.com%7cc74c34192a664443cce908d2bf1cc69b%7c72f988bf86
> >> f1
> >> 41af91ab2d7cd011db47%7c1=M%2f1jcQ0q3%2bllZYMoSsU0dHNrX12No0fK
> >> 5H
> >> lcW3C13mg%3d
> >>
> >>
> >> On 17 September 2015 at 03:46:52, Carlos Santana
> >> (csantan...@gmail.com)
> >> wrote:
> >>
> >> +1
> >>
> >> There are more commits seating in master, Should we plan for 
> >> another release right after releasing the cherry-pick release for nodejs@4?
> >>
> >>
> >> On Wed, Sep 16, 2015 at 11:25 AM Steven Gill 
> >> 
> >> wrote:
> >>
> >>> Good idea with the cherry-pick.
> >>> On Sep 16, 2015 8:07 AM, "Sergey Grebnov (Akvelon)" < 
> >>> v-seg...@microsoft.com>
> >>> wrote:
> >>>
>  We currently have iOS and Node v4 compatibility issue[1] which 
>  has been recently fixed[2] so I propose to cherry pick that fix 
>  and do patch
> >>> release
>  (cordova@5.3.2).
> 
>  Does anyone have any reason to delay a tools patch release?
> 
>  If not, I will start the release tomorrow.
> 
>  [1]
>  https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2f
>  is
>  s
>  ues.apache.org%2fjira%2fbrowse%2fCB-9297=01%7c01%7cv-vlkoti%
>  40
>  0
>  64d.mgd.microsoft.com%7cc74c34192a664443cce908d2bf1cc69b%7c72f988
>  bf
>  8
>  6f141af91ab2d7cd011db47%7c1=MtwvQkbecpe9ES%2fY5JyJbOnNsQUQa
>  Nf
>  e
>  LWy9BBMgejk%3d
>  [2]
> >>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fg
> 

Re: [Android] 5.0.x release branch?

2015-09-22 Thread Carlos Santana
+1 we should always use the engine tag to mark the minimum compatible version 
at least 

-1 for cordova CLI to automagically to install an older version. It will be a 
pain to get this implemented right, we would need to download all the 
package.json for multiple versions of the plugin and pick the lowest common 
denominator based on engine tags and remember that one plugin support multiple 
engine tags across different platform versions and CLI/plugman. 

This brings an interesting feature to implement In the plugin search website, 
to display the engine tags for a specific plugin version. Allowing a developer 
to search for a compatible plugin for their current app. 

- Carlos
Sent from my iPhone

> On Sep 22, 2015, at 8:57 PM, Nikhil Khandelwal  wrote:
> 
> Thanks, Joe for the detailed explanation. I understand why we've taken this 
> route. It's good that this is only a build failure. One of the complaints we 
> commonly hear from Cordova developers is that "I have a cordova project with 
> a certain version of the platform, I need to find the plugin that will work 
> with it". Our CLI always defaults to add the latest released version of the 
> plugin.
> 
> After this breaking change, an existing cordova project with cordova-android 
> < 5.x, cannot build with the latest version of the following plugins:
>- camera
>   - geolocation
>   - contacts.
> These are some of the most popular plugins in cordova plugin ecosystem [1].
> 
> I propose that we should do our best to avoid disruptive breaking changes 
> here. Some ideas that come to mind:
> - As Joe mentioned below - reflection. It has the downsides that Joe 
> mentioned. No one likes to write code like this it but results in least grief 
> for Cordova users. Some pain here for plugin developers will simplify the 
> experience for large number of corodva JS developers. I know we are doing 
> some of this in cordova-ios [2] and would love to find ways on how to make 
> this manageable and not super ugly.
> - Add an  ' '  to the 
> plugins - failure happens at plugin add in this scenario. Cordova-lib could 
> be more intelligent to detect this error and resort to using an older version 
> of the plugin. The downside of this is that these projects cannot use the 
> latest and greatest of these plugins. 
> 
> Thanks,
> Nikhil
> 
> [1] http://cordova.apache.org/use-the-force-luke/plugins/?sortBy=Downloads
> [2] 
> https://github.com/apache/cordova-plugin-camera/blob/master/src/ios/CDVCamera.m#L44
> 
> Thanks,
> Nikhil
> 
> 
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com] 
> Sent: Monday, September 21, 2015 6:32 PM
> To: dev@cordova.apache.org
> Subject: Re: [Android] 5.0.x release branch?
> 
> On Mon, Sep 21, 2015 at 5:43 PM Nikhil Khandelwal 
> wrote:
> 
>> Can you explain why latest plugins will not be compatible with older 
>> versions of Cordova?
> 
> 
> They won't be compatible because Cordova-Android compiles against API 22, and 
> these plugins will require API 23 so that they can detect permissions and 
> support Marshmellow.
> 
> 
>> Can this be avoided by any means?
> 
> 
> Only with a lot of Java reflection, and I'd rather not subject plugin 
> developers to that, or try to hide it under the hood in some awful utility 
> class that everyone will want to see die.  I'm very much a fan of if 
> statements because they work, and they're easy to read and debug, unlike when 
> bad things happen to things you reflect into.  Plugins that require API 23 
> will only work with Cordova-Android 5.0 and up.  This only impacts five of 
> our core plugins, but any plugin that requires permissions from the Android 
> Manifest will have to be updated.  If we can avoid using advanced language 
> tricks to make the APKs compatible, we should do that.
> 
> When you mean they would not be compatible - will it result in a build or
>> runtime failure?
>> 
>> 
> This will be a build failure, since API 22 does not have these permissions, 
> nor does it have the code required for API 23.
> 
> 
>> For marshmallow, what is the guidance that we need to issue to the 
>> larger Cordova plugin ecosystem? Joe you are ahead of the curve here 
>> compared to most other plugin developers - a blot post explaining what 
>> are known gotchas would be great. I really hope we can use our Cordova 
>> blog to communicate these changes actively to the plugin ecosystem. 
>> This mailing list only gets 400+ subscribers.
>> 
>> 
> There will be a blog post once 5.0 is released.  We're not forcing people to 
> upgrade to 5.0, and we will be supporting the 4.x branch for six months.  
> This does mean we're stuck supporting 3.x, 4.x and 5.x for a brief window, 
> but I have no control over when Marshmallow is released, only whether we want 
> to support it or not.  I think we do, but I could be wrong.
> 
> At least this should be easier than the jump from 3.x to 4.x for most 

RE: [DISCUSS] Tools Release

2015-09-22 Thread Sergey Grebnov (Akvelon)
Could someone merge the post or give me write access to the apache-blog-posts 
repo please.
https://github.com/cordova/apache-blog-posts/pull/46 

I'll update npm after that.

Thx!
Sergey
-Original Message-
From: Sergey Grebnov (Akvelon) 
Sent: Tuesday, September 22, 2015 9:42 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Tools Release

Here is announce draft, please review
https://github.com/cordova/apache-blog-posts/pull/46/

Should we include link to JIRA issue for more details?
https://issues.apache.org/jira/browse/CB-9297 

Thx!
Sergey
-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
Sent: Friday, September 18, 2015 3:20 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Tools Release

The new thread has started. I had to bump patch versions for tools, so they now 
are:
cordova-lib: 5.3.3 (932ad57858)
cordova-plugman: 1.0.4 (0de514b4b1)
cordova-cli: 5.3.3 (e647fe4382)

Also, packages, broken when published from Windows seems to be known problem:  
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fnpm%2fnpm%2fissues%2f2097=01%7c01%7cv-segreb%40microsoft.com%7cd9f82e0ca54a471d88c608d2c012d6c2%7c72f988bf86f141af91ab2d7cd011db47%7c1=zX8PqZr8%2fY2RRly4U9pl0eHLaSgrpqSwW8wpf5ZXVdg%3d
Probably we might workaround this by pinning  'eol=crlf' for executable scripts 
through .gitattributes (there is a nice article from GitHub here: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fhelp.github.com%2farticles%2fdealing-with-line-endings%2f=01%7c01%7cv-segreb%40microsoft.com%7cd9f82e0ca54a471d88c608d2c012d6c2%7c72f988bf86f141af91ab2d7cd011db47%7c1=O6Fverh%2fFbeXiPmW7kGfWswi8RAVvf8t4V7ZvfX8CUA%3d
 ). Any thoughts?

-
Best regards, Vladimir

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
Sent: Thursday, September 17, 2015 5:10 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Tools Release

BTW, could anybody please grant me access to npmjs. I had to ask Sergey to 
publish packages to NPM.

-
Best regards, Vladimir

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Thursday, September 17, 2015 4:57 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Tools Release

OK Vladimir

On Thu, Sep 17, 2015 at 9:50 AM Vladimir Kotikov (Akvelon) < 
v-vlk...@microsoft.com> wrote:

> Working on it
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Tommy-Carlos Williams [mailto:to...@devgeeks.org]
> Sent: Thursday, September 17, 2015 4:01 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release
>
> Were we waiting on a vote? I would +1
>
> > On 17 Sep 2015, at 22:50, Carlos Santana  wrote:
> >
> > A day has pass and no sign of a vote for the emergency fix.
> >
> > Why not just do a tools release with everything it's in master today?
> > in theory we should be able to do a release of what's in master at 
> > any time
> >
> >
> > On Thu, Sep 17, 2015 at 5:29 AM Vladimir Kotikov (Akvelon) < 
> > v-vlk...@microsoft.com> wrote:
> >
> >> I believe this is not a blocker. We have platforms pinned with 
> >> tilde, so platform's patch release will be picked up automatically.
> >>
> >> -
> >> Best regards, Vladimir
> >>
> >> -Original Message-
> >> From: Tommy Williams [mailto:to...@devgeeks.org]
> >> Sent: Thursday, September 17, 2015 7:59 AM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [DISCUSS] Tools Release
> >>
> >> I have a cherry pick to cordova-ios[1] that would be good to be 
> >> included in 5.3.2 if there are already plans to update iOS’s pinned 
> >> version…
> >>
> >> 1.
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> >> su
> >> es.apache.org%2fjira%2fbrowse%2fCB-9046=01%7c01%7cv-vlkoti%400
> >> 64
> >> d.mgd.microsoft.com%7cc74c34192a664443cce908d2bf1cc69b%7c72f988bf86
> >> f1
> >> 41af91ab2d7cd011db47%7c1=M%2f1jcQ0q3%2bllZYMoSsU0dHNrX12No0fK
> >> 5H
> >> lcW3C13mg%3d
> >>
> >>
> >> On 17 September 2015 at 03:46:52, Carlos Santana
> >> (csantan...@gmail.com)
> >> wrote:
> >>
> >> +1
> >>
> >> There are more commits seating in master, Should we plan for 
> >> another release right after releasing the cherry-pick release for nodejs@4?
> >>
> >>
> >> On Wed, Sep 16, 2015 at 11:25 AM Steven Gill 
> >> 
> >> wrote:
> >>
> >>> Good idea with the cherry-pick.
> >>> On Sep 16, 2015 8:07 AM, "Sergey Grebnov (Akvelon)" < 
> >>> v-seg...@microsoft.com>
> >>> wrote:
> >>>
>  We currently have iOS and Node v4 compatibility issue[1] which 
>  has been recently fixed[2] so I propose to cherry pick that fix 
>  and do patch
> >>> release
>  (cordova@5.3.2).
> 
>  Does anyone have any reason to delay a tools patch release?
> 
>  If not, I will start the release tomorrow.
> 
>  [1]
>  https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2f
>  is
>  s
>  

RE: [Vote] Tools Release Sep 17th (Take 2)

2015-09-22 Thread Sergey Grebnov (Akvelon)
The vote has now closed. The results are:

Positive Binding Votes: 3

Carlos Santana
Vladimir Kotikov
Sergey Grebnov

Negative Binding Votes: 0

The vote has passed.

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Saturday, September 19, 2015 11:53 AM
To: dev@cordova.apache.org
Subject: Re: [Vote] Tools Release Sep 17th (Take 2)

+1
verify tags
recreated archives and compare
review code changes
test cli with nodejs v4.0.0


On Fri, Sep 18, 2015 at 6:13 AM Vladimir Kotikov (Akvelon) < 
v-vlk...@microsoft.com> wrote:

> Please review and vote on this Tools Release by replying to this email 
> (and keep discussion on the DISCUSS thread)
>
> Release issue: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-9678=01%7c01%7cv-segreb%40micro
> soft.com%7cf5f85c33a0704148265b08d2c123a0ff%7c72f988bf86f141af91ab2d7c
> d011db47%7c1=WWX7zbTavyxOi7p5hjQLkt7Fx8%2bfIC6NrLFmBcNiOqs%3d
>
> Tools have been published to dist/dev:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.
> apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-9678=01%7c01%7cv-s
> egreb%40microsoft.com%7cf5f85c33a0704148265b08d2c123a0ff%7c72f988bf86f
> 141af91ab2d7cd011db47%7c1=%2fPnDikq%2faLHUkgOEk6QiBezUruglRXPh%2
> bLQPYCwBcsw%3d
>
> The packages were published from their corresponding git tags:
> cordova-lib: 5.3.3 (932ad57858)
> cordova-plugman: 1.0.4 (0de514b4b1)
> cordova-cli: 5.3.3 (e647fe4382)
>
> Upon a successful vote I will upload the archives to dist/, publish 
> them to NPM, and post the corresponding blog post.
>
> Voting guidelines:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting.
> md=01%7c01%7cv-segreb%40microsoft.com%7cf5f85c33a0704148265b08d2c
> 123a0ff%7c72f988bf86f141af91ab2d7cd011db47%7c1=TmbHg0tH7UuPqR3Pv
> %2bcx393EeufgusTIW5noMDkZY%2fs%3d
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran 'npm test' for repos, being published
> * Built hello world app and mobile-spec
>
> -
> Best regards, Vladimir
>


[GitHub] cordova-docs pull request: Implementing Proper Latest Docs Version

2015-09-22 Thread dblotsky
GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/358

Implementing Proper Latest Docs Version

Adding docs root and language root redirects. Adding `site.latest_version` 
for that purpose, and for `not_latest_warning_text`. Changing all links to 
`docs/{lang}/edge` to `docs/{lang}/{latest_version}` because that is what they 
actually should be.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs 
cordova-website-docs-redirects

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #358


commit 851da8b9ca1c6407207996b15386999fee599fd1
Author: Dmitry Blotsky 
Date:   2015-09-23T02:44:11Z

Adding docs root and language root redirects. Also adding 
site.latest_version.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [Android] 5.0.x release branch?

2015-09-22 Thread Nikhil Khandelwal
Thanks, Joe for the detailed explanation. I understand why we've taken this 
route. It's good that this is only a build failure. One of the complaints we 
commonly hear from Cordova developers is that "I have a cordova project with a 
certain version of the platform, I need to find the plugin that will work with 
it". Our CLI always defaults to add the latest released version of the plugin.

After this breaking change, an existing cordova project with cordova-android < 
5.x, cannot build with the latest version of the following plugins:
- camera
   - geolocation
   - contacts.
These are some of the most popular plugins in cordova plugin ecosystem [1].

I propose that we should do our best to avoid disruptive breaking changes here. 
Some ideas that come to mind:
- As Joe mentioned below - reflection. It has the downsides that Joe mentioned. 
No one likes to write code like this it but results in least grief for Cordova 
users. Some pain here for plugin developers will simplify the experience for 
large number of corodva JS developers. I know we are doing some of this in 
cordova-ios [2] and would love to find ways on how to make this manageable and 
not super ugly.
- Add an  ' '  to the 
plugins - failure happens at plugin add in this scenario. Cordova-lib could be 
more intelligent to detect this error and resort to using an older version of 
the plugin. The downside of this is that these projects cannot use the latest 
and greatest of these plugins. 

Thanks,
Nikhil

[1] http://cordova.apache.org/use-the-force-luke/plugins/?sortBy=Downloads
[2] 
https://github.com/apache/cordova-plugin-camera/blob/master/src/ios/CDVCamera.m#L44

Thanks,
Nikhil


-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Monday, September 21, 2015 6:32 PM
To: dev@cordova.apache.org
Subject: Re: [Android] 5.0.x release branch?

On Mon, Sep 21, 2015 at 5:43 PM Nikhil Khandelwal 
wrote:

> Can you explain why latest plugins will not be compatible with older 
> versions of Cordova?


They won't be compatible because Cordova-Android compiles against API 22, and 
these plugins will require API 23 so that they can detect permissions and 
support Marshmellow.


> Can this be avoided by any means?


Only with a lot of Java reflection, and I'd rather not subject plugin 
developers to that, or try to hide it under the hood in some awful utility 
class that everyone will want to see die.  I'm very much a fan of if statements 
because they work, and they're easy to read and debug, unlike when bad things 
happen to things you reflect into.  Plugins that require API 23 will only work 
with Cordova-Android 5.0 and up.  This only impacts five of our core plugins, 
but any plugin that requires permissions from the Android Manifest will have to 
be updated.  If we can avoid using advanced language tricks to make the APKs 
compatible, we should do that.

When you mean they would not be compatible - will it result in a build or
> runtime failure?
>
>
This will be a build failure, since API 22 does not have these permissions, nor 
does it have the code required for API 23.


> For marshmallow, what is the guidance that we need to issue to the 
> larger Cordova plugin ecosystem? Joe you are ahead of the curve here 
> compared to most other plugin developers - a blot post explaining what 
> are known gotchas would be great. I really hope we can use our Cordova 
> blog to communicate these changes actively to the plugin ecosystem. 
> This mailing list only gets 400+ subscribers.
>
>
There will be a blog post once 5.0 is released.  We're not forcing people to 
upgrade to 5.0, and we will be supporting the 4.x branch for six months.  This 
does mean we're stuck supporting 3.x, 4.x and 5.x for a brief window, but I 
have no control over when Marshmallow is released, only whether we want to 
support it or not.  I think we do, but I could be wrong.

At least this should be easier than the jump from 3.x to 4.x for most people, 
but the alternative is that your plugin just doesn't work at all on 
Marshmallow.  We need to at least give plugin developers this option, since 
it'll roll out on all the Nexus devices in the next two weeks, and we'll hear 
more about it.


> Can you re-base your cordova-android over the current master? It's 
> hard to see a diff in the current form:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fapache%2fcordova-android%2fcompare%2fmaster...infil00p%3asmore
> s=01%7c01%7cnikhilkh%40microsoft.com%7cb451a04dccc64fabdb9608d2c2
> edb23c%7c72f988bf86f141af91ab2d7cd011db47%7c1=j0bxz39itXdtylHJlv
> PYoJpZqXMhFjyTV35I9X5Yxzs%3d
>
>
I had to do a merge commit to get this to happen (boo), but it should be mostly 
cleaned up now.  It seems some style cleanup creeped into the most recent 
changes, but this should be a bit more readable.


> -Nikhil
>
> -Original Message-
> From: Joe Bowser 

Re: [Android] 5.0.x release branch?

2015-09-22 Thread Joe Bowser
I'm completely against using reflection for this purpose.  Version codes
were invented for a reason and we don't have any mechanism in place to unit
test any Android code (or any other native code on any of the platforms).

I will vote against any release that includes reflection for this purpose
since reflection has only brought us security issues and extreme WebView
breakage when used (Simon can tell you the tales of the HTC console.log
reflection code.).  Reflection is a worst-case scenario tool like when a
method in WebView marked as deprecated completely disappears, not something
we should make a habit of using often.  If we open the door for this, we'll
get reflection creeping elsewhere, like the Plugins API.

Just say no to reflection.


On Tue, Sep 22, 2015, 5:57 PM Nikhil Khandelwal 
wrote:

> Thanks, Joe for the detailed explanation. I understand why we've taken
> this route. It's good that this is only a build failure. One of the
> complaints we commonly hear from Cordova developers is that "I have a
> cordova project with a certain version of the platform, I need to find the
> plugin that will work with it". Our CLI always defaults to add the latest
> released version of the plugin.
>
> After this breaking change, an existing cordova project with
> cordova-android < 5.x, cannot build with the latest version of the
> following plugins:
> - camera
>- geolocation
>- contacts.
> These are some of the most popular plugins in cordova plugin ecosystem [1].
>
> I propose that we should do our best to avoid disruptive breaking changes
> here. Some ideas that come to mind:
> - As Joe mentioned below - reflection. It has the downsides that Joe
> mentioned. No one likes to write code like this it but results in least
> grief for Cordova users. Some pain here for plugin developers will simplify
> the experience for large number of corodva JS developers. I know we are
> doing some of this in cordova-ios [2] and would love to find ways on how to
> make this manageable and not super ugly.
> - Add an  ' '  to the
> plugins - failure happens at plugin add in this scenario. Cordova-lib could
> be more intelligent to detect this error and resort to using an older
> version of the plugin. The downside of this is that these projects cannot
> use the latest and greatest of these plugins.
>
> Thanks,
> Nikhil
>
> [1] http://cordova.apache.org/use-the-force-luke/plugins/?sortBy=Downloads
> [2]
> https://github.com/apache/cordova-plugin-camera/blob/master/src/ios/CDVCamera.m#L44
>
> Thanks,
> Nikhil
>
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Monday, September 21, 2015 6:32 PM
> To: dev@cordova.apache.org
> Subject: Re: [Android] 5.0.x release branch?
>
> On Mon, Sep 21, 2015 at 5:43 PM Nikhil Khandelwal 
> wrote:
>
> > Can you explain why latest plugins will not be compatible with older
> > versions of Cordova?
>
>
> They won't be compatible because Cordova-Android compiles against API 22,
> and these plugins will require API 23 so that they can detect permissions
> and support Marshmellow.
>
>
> > Can this be avoided by any means?
>
>
> Only with a lot of Java reflection, and I'd rather not subject plugin
> developers to that, or try to hide it under the hood in some awful utility
> class that everyone will want to see die.  I'm very much a fan of if
> statements because they work, and they're easy to read and debug, unlike
> when bad things happen to things you reflect into.  Plugins that require
> API 23 will only work with Cordova-Android 5.0 and up.  This only impacts
> five of our core plugins, but any plugin that requires permissions from the
> Android Manifest will have to be updated.  If we can avoid using advanced
> language tricks to make the APKs compatible, we should do that.
>
> When you mean they would not be compatible - will it result in a build or
> > runtime failure?
> >
> >
> This will be a build failure, since API 22 does not have these
> permissions, nor does it have the code required for API 23.
>
>
> > For marshmallow, what is the guidance that we need to issue to the
> > larger Cordova plugin ecosystem? Joe you are ahead of the curve here
> > compared to most other plugin developers - a blot post explaining what
> > are known gotchas would be great. I really hope we can use our Cordova
> > blog to communicate these changes actively to the plugin ecosystem.
> > This mailing list only gets 400+ subscribers.
> >
> >
> There will be a blog post once 5.0 is released.  We're not forcing people
> to upgrade to 5.0, and we will be supporting the 4.x branch for six
> months.  This does mean we're stuck supporting 3.x, 4.x and 5.x for a brief
> window, but I have no control over when Marshmallow is released, only
> whether we want to support it or not.  I think we do, but I could be wrong.
>
> At least this should be easier than the jump from 3.x to 4.x for most
> 

[GitHub] cordova-ios pull request: CB-9693 Fix www copy with spaces in proj...

2015-09-22 Thread dpogue
GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-ios/pull/166

CB-9693 Fix www copy with spaces in project name



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-ios patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #166


commit 0ac7bfddd74cde796913fe36f81d145953a68b27
Author: Darryl Pogue 
Date:   2015-09-23T02:05:55Z

CB-9693 Fix www copy with spaces in project name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [Android] 5.0.x release branch?

2015-09-22 Thread Karen Tran
Hi Joe,

I tested your geolocation plugin changes with mobilespec and the app
crashes when you click "Deny" permission and when you click "Accept"
permission for the first time. When you go back to the app after accepting,
you can get location data.

I agree with having a 5.0.x branch soon since I know some people are
already asking about using API 23 and needing to test it asap.


On Mon, Sep 21, 2015 at 9:32 PM, Joe Bowser  wrote:

> On Mon, Sep 21, 2015 at 5:43 PM Nikhil Khandelwal 
> wrote:
>
> > Can you explain why latest plugins will not be compatible with older
> > versions of Cordova?
>
>
> They won't be compatible because Cordova-Android compiles against API 22,
> and these plugins will require API 23 so that they can detect permissions
> and support Marshmellow.
>
>
> > Can this be avoided by any means?
>
>
> Only with a lot of Java reflection, and I'd rather not subject plugin
> developers to that, or try to hide it under the hood in some awful utility
> class that everyone will want to see die.  I'm very much a fan of if
> statements because they work, and they're easy to read and debug, unlike
> when bad things happen to things you reflect into.  Plugins that require
> API 23 will only work with Cordova-Android 5.0 and up.  This only impacts
> five of our core plugins, but any plugin that requires permissions from the
> Android Manifest will have to be updated.  If we can avoid using advanced
> language tricks to make the APKs compatible, we should do that.
>
> When you mean they would not be compatible - will it result in a build or
> > runtime failure?
> >
> >
> This will be a build failure, since API 22 does not have these permissions,
> nor does it have the code required for API 23.
>
>
> > For marshmallow, what is the guidance that we need to issue to the larger
> > Cordova plugin ecosystem? Joe you are ahead of the curve here compared to
> > most other plugin developers - a blot post explaining what are known
> > gotchas would be great. I really hope we can use our Cordova blog to
> > communicate these changes actively to the plugin ecosystem. This mailing
> > list only gets 400+ subscribers.
> >
> >
> There will be a blog post once 5.0 is released.  We're not forcing people
> to upgrade to 5.0, and we will be supporting the 4.x branch for six
> months.  This does mean we're stuck supporting 3.x, 4.x and 5.x for a brief
> window, but I have no control over when Marshmallow is released, only
> whether we want to support it or not.  I think we do, but I could be wrong.
>
> At least this should be easier than the jump from 3.x to 4.x for most
> people, but the alternative is that your plugin just doesn't work at all on
> Marshmallow.  We need to at least give plugin developers this option, since
> it'll roll out on all the Nexus devices in the next two weeks, and we'll
> hear more about it.
>
>
> > Can you re-base your cordova-android over the current master? It's hard
> to
> > see a diff in the current form:
> >
> https://github.com/apache/cordova-android/compare/master...infil00p:smores
> >
> >
> I had to do a merge commit to get this to happen (boo), but it should be
> mostly cleaned up now.  It seems some style cleanup creeped into the most
> recent changes, but this should be a bit more readable.
>
>
> > -Nikhil
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Monday, September 21, 2015 2:14 PM
> > To: dev 
> > Subject: [Android] 5.0.x release branch?
> >
> > Hey
> >
> > In the next two weeks, Marshmallow will most likely getting released with
> > the brand new Nexus 6P being released from Huawei.  Given that most of
> the
> > Nexus devices will be getting this release, we should probably release
> the
> > 5.0.x branch of Android soon, and get the new plugins updated.
> >
> > It should be noted that the latest plugins will not be compatible with
> > older versions of Cordova, which is a big deal.  This is due to the use
> of
> > various compatibility checks to make sure they support Marshmallow and
> > older versions of Android.
> >
> > So, if everyone can look over the smores branches of my GitHub before I
> > create the 5.0.x branch and pull the changes into it, that would be
> awesome.
> >
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2finfil00p%2fcordova-android%2ftree%2fsmores=01%7c01%7cnikhilkh%40microsoft.com%7c1785194b1f82494fc2d908d2c2c99f36%7c72f988bf86f141af91ab2d7cd011db47%7c1=%2fPKmL8KTsz5dnC3A75yMatXLQUnfK0Nv07%2bve4PVcCE%3d
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2finfil00p%2fcordova-plugin-geolocation%2ftree%2fsmores=01%7c01%7cnikhilkh%40microsoft.com%7c1785194b1f82494fc2d908d2c2c99f36%7c72f988bf86f141af91ab2d7cd011db47%7c1=o6cLXM4f3kpUGCTlIv65ft8lKv6pc5qbeY%2bdUxiP4bc%3d
> >
> >
> 

[GitHub] cordova-plugin-geolocation pull request: background location under...

2015-09-22 Thread ccloquet
GitHub user ccloquet opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/51

background location under iOS 9

Hi, 

Thanks for this upgrade of the plugin !

I just tried to run in under iOS 9, and it seems that the following lines 
should be added before [self.locationManager startUpdatingLocation] : 

locationManager.pausesLocationUpdatesAutomatically = NO;
locationManager.allowsBackgroundLocationUpdates = YES;

However, doing so drains the battery quickly.

Do you have a similar experience ?

These lines can also be useful, even not strictly necessary for the 
background usage : 

locationManager.activityType = CLActivityTypeFitness;
locationManager.desiredAccuracy = kCLLocationAccuracyBestForNavigation;
locationManager.distanceFilter = kCLDistanceFilterNone;

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dingxin/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit bab87020ab1ae1ab421b61ee8138b9215fdeeb4d
Author: dingxin 
Date:   2015-09-08T03:12:15Z

add background location update

commit 4a523d4c7e05180f759b1dbbf12ff151b418afd6
Author: dingxin 
Date:   2015-09-08T03:17:58Z

.gitignore add .project




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Add Pacifica to showcase apps.

2015-09-22 Thread drbeermann
GitHub user drbeermann opened a pull request:

https://github.com/apache/cordova-docs/pull/360

Add Pacifica to showcase apps.

Just based it off of the NewVo one. Seems to be working fine when correctly 
serving locally.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drbeermann/cordova-docs pacifica_addition

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #360


commit 2412c376b29d3a137f257bb5eeb414fe1c047d6a
Author: Dale Beermann 
Date:   2015-09-23T05:11:54Z

Add Pacifica to showcase apps.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Adding Syntax Highlighting to Site

2015-09-22 Thread dblotsky
GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/359

Adding Syntax Highlighting to Site



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs 
cordova-website-syntax-highlighting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/359.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #359


commit 765421f5d502942e363346dea05e27b22cfe5469
Author: Dmitry Blotsky 
Date:   2015-09-23T02:29:13Z

Adding google-code-prettify.

commit 489ade0ce2e948ca249a8eba8699c2ea48c37684
Author: Dmitry Blotsky 
Date:   2015-09-23T02:31:26Z

Adding syntax highlighting code. Switching to redcarpet for Markdown 
because Kramdown willingly doesn't comply with GFM 
(https://github.com/jekyll/jekyll/issues/2711).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9690 Can't submit iPad apps to the Ap...

2015-09-22 Thread macdonst
GitHub user macdonst opened a pull request:

https://github.com/apache/cordova-ios/pull/167

CB-9690 Can't submit iPad apps to the App Store for iOS 9

Closes something

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cordova-ios CB-9690

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #167


commit dabe0b16256d4044e9d15546e86c7f8675e24781
Author: Simon MacDonald 
Date:   2015-09-23T04:46:06Z

CB-9690 Can't submit iPad apps to the App Store for iOS 9

Closes something




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9690 Can't submit iPad apps to the Ap...

2015-09-22 Thread devgeeks
Github user devgeeks commented on the pull request:

https://github.com/apache/cordova-ios/pull/167#issuecomment-142491934
  
Doesn't that completely opt out of "Slide Over and Split View" ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-osx pull request: CB-9692 OSX: cordova.exec is not availab...

2015-09-22 Thread tripodsan
GitHub user tripodsan opened a pull request:

https://github.com/apache/cordova-osx/pull/24

CB-9692 OSX: cordova.exec is not available



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tripodsan/cordova-osx CB-9692

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-osx/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 8d5942e52403881cbfd97b219fcee6e8a03fbe0a
Author: Tobias Bocanegra 
Date:   2015-09-18T05:35:32Z

CB-9581 OSX WebView does not send cookies is safari cache is cleared

commit cdd71f5f1e7533436998206ff500243a9f8095f9
Author: Tobias Bocanegra 
Date:   2015-09-23T00:12:49Z

CB-9692 OSX: cordova.exec is not available




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [Android] 5.0.x release branch?

2015-09-22 Thread Joe Bowser
On Tue, Sep 22, 2015 at 1:30 PM, Karen Tran  wrote:

> Hi Joe,
>
> I tested your geolocation plugin changes with mobilespec and the app
> crashes when you click "Deny" permission and when you click "Accept"
> permission for the first time. When you go back to the app after accepting,
> you can get location data.
>


I'm not getting that behaviour with the latest version of the smores branch
and the latest plugin.  I noticed that the watch commands aren't working as
they should, which is bad.  Try pulling down the latest on the smores repo.
  Also, please update the issue on JIRA.

https://issues.apache.org/jira/browse/CB-9105


>
> I agree with having a 5.0.x branch soon since I know some people are
> already asking about using API 23 and needing to test it asap.
>
>
Yeah, it's easier to get people to test off that than some random topic
branch on Github.



>
> On Mon, Sep 21, 2015 at 9:32 PM, Joe Bowser  wrote:
>
> > On Mon, Sep 21, 2015 at 5:43 PM Nikhil Khandelwal <
> nikhi...@microsoft.com>
> > wrote:
> >
> > > Can you explain why latest plugins will not be compatible with older
> > > versions of Cordova?
> >
> >
> > They won't be compatible because Cordova-Android compiles against API 22,
> > and these plugins will require API 23 so that they can detect permissions
> > and support Marshmellow.
> >
> >
> > > Can this be avoided by any means?
> >
> >
> > Only with a lot of Java reflection, and I'd rather not subject plugin
> > developers to that, or try to hide it under the hood in some awful
> utility
> > class that everyone will want to see die.  I'm very much a fan of if
> > statements because they work, and they're easy to read and debug, unlike
> > when bad things happen to things you reflect into.  Plugins that require
> > API 23 will only work with Cordova-Android 5.0 and up.  This only impacts
> > five of our core plugins, but any plugin that requires permissions from
> the
> > Android Manifest will have to be updated.  If we can avoid using advanced
> > language tricks to make the APKs compatible, we should do that.
> >
> > When you mean they would not be compatible - will it result in a build or
> > > runtime failure?
> > >
> > >
> > This will be a build failure, since API 22 does not have these
> permissions,
> > nor does it have the code required for API 23.
> >
> >
> > > For marshmallow, what is the guidance that we need to issue to the
> larger
> > > Cordova plugin ecosystem? Joe you are ahead of the curve here compared
> to
> > > most other plugin developers - a blot post explaining what are known
> > > gotchas would be great. I really hope we can use our Cordova blog to
> > > communicate these changes actively to the plugin ecosystem. This
> mailing
> > > list only gets 400+ subscribers.
> > >
> > >
> > There will be a blog post once 5.0 is released.  We're not forcing people
> > to upgrade to 5.0, and we will be supporting the 4.x branch for six
> > months.  This does mean we're stuck supporting 3.x, 4.x and 5.x for a
> brief
> > window, but I have no control over when Marshmallow is released, only
> > whether we want to support it or not.  I think we do, but I could be
> wrong.
> >
> > At least this should be easier than the jump from 3.x to 4.x for most
> > people, but the alternative is that your plugin just doesn't work at all
> on
> > Marshmallow.  We need to at least give plugin developers this option,
> since
> > it'll roll out on all the Nexus devices in the next two weeks, and we'll
> > hear more about it.
> >
> >
> > > Can you re-base your cordova-android over the current master? It's hard
> > to
> > > see a diff in the current form:
> > >
> >
> https://github.com/apache/cordova-android/compare/master...infil00p:smores
> > >
> > >
> > I had to do a merge commit to get this to happen (boo), but it should be
> > mostly cleaned up now.  It seems some style cleanup creeped into the most
> > recent changes, but this should be a bit more readable.
> >
> >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > Sent: Monday, September 21, 2015 2:14 PM
> > > To: dev 
> > > Subject: [Android] 5.0.x release branch?
> > >
> > > Hey
> > >
> > > In the next two weeks, Marshmallow will most likely getting released
> with
> > > the brand new Nexus 6P being released from Huawei.  Given that most of
> > the
> > > Nexus devices will be getting this release, we should probably release
> > the
> > > 5.0.x branch of Android soon, and get the new plugins updated.
> > >
> > > It should be noted that the latest plugins will not be compatible with
> > > older versions of Cordova, which is a big deal.  This is due to the use
> > of
> > > various compatibility checks to make sure they support Marshmallow and
> > > older versions of Android.
> > >
> > > So, if everyone can look over the smores branches of my GitHub before I
> > > create the 5.0.x branch and pull the changes into it, that 

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-09-22 Thread reynaldo-tortoledo-hs
Github user reynaldo-tortoledo-hs commented on the pull request:

https://github.com/apache/cordova-ios/pull/132#issuecomment-142457227
  
`npm install --save q && npm install --save nopt`

Thanks ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-09-22 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request:

https://github.com/apache/cordova-ios/pull/164

CB-9685 A fix for the magnifying glass popping up on iOS9 longpress

I though `CDVLongPressFix` would not be the best name. Especially if we 
ever need to fix any other gestures Apple breaks for us, so I went for 
`CDVGestureHandler`.

I hope you like it!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/EddyVerbruggen/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #164


commit b6348f7a0cb55ca3972334cb40ad310823792fa9
Author: EddyVerbruggen 
Date:   2015-09-22T10:02:36Z

CB-9685 A fix for the magnifying glass popping up on iOS9 when longpressing 
the webview




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...

2015-09-22 Thread alsorokin
GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-medic/pull/64

CB-8936 Tweaking windows log gathering timeout

https://issues.apache.org/jira/browse/CB-8936

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-medic CB-8936

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit 7a6cf285161ad632052f900c565a332bac8be13e
Author: Alexander Sorokin 
Date:   2015-09-22T08:15:51Z

CB-8936 Tweaking windows log gathering timeout




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser pull request: Added support for file:/...

2015-09-22 Thread bpresles
GitHub user bpresles opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/116

Added support for file:/// access

I had the requirement to be able to access file:/// image on my 
inappbrowser popup in Android. But I had issues with Security.

This was because the WebView wasn't configured to allow universal access 
from file URLs (required for Jelly Bean or greater).

I think this would be a good idea to include this change in the original 
plugin, as I'm sure I'm not the only one facing this issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bpresles/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit b0e7a776f982ce2081b7c43a5d859166b498d9a1
Author: Bertrand PRESLES 
Date:   2015-09-22T14:14:21Z

Added support for file:/// access




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org