date:20160301

Re: [DISCUSS] Cordova-iOS release

2016-03-01 Thread Steven Gill

Blog post for review: https://github.com/apache/cordova-docs/pull/530

On Tue, Mar 1, 2016 at 11:11 PM, Steven Gill  wrote:

> Shaz is back tomorrow. I just wanted to get his blessing before closing
> the vote thread.
>
> On Mon, Feb 29, 2016 at 8:39 PM, Steven Gill 
> wrote:
>
>> Just bumped the ios vote thread
>>
>> On Mon, Feb 29, 2016 at 7:06 PM, Carlos Santana 
>> wrote:
>>
>>> Sorry that I have being MIA, was at IBM conference at Vegas, and what
>>> happened stayed there :-)
>>>
>>> Where we are with iOS release?
>>>
>>> I guess I was late to the Android 5.1.1 party that vote is done.
>>>
>>>
>>> On Thu, Feb 25, 2016 at 9:26 PM Steven Gill 
>>> wrote:
>>>
>>> > I sent a PR with the bug fix.
>>> > https://github.com/apache/cordova-ios/pull/198
>>> >
>>> > Hoping to get this release going again tomorrow.
>>> >
>>> > Yeah it isn't a patch release, but a minor. Lets get iOS out first and
>>> then
>>> > we can focus on tools. It should work fine for people wanting to
>>> manually
>>> > update via `cordova platform add ios@4.1.0` once released.
>>> >
>>> >
>>> >
>>> > On Thu, Feb 25, 2016 at 5:45 PM, Nikhil Khandelwal <
>>> nikhi...@microsoft.com
>>> > >
>>> > wrote:
>>> >
>>> > > Since this is a bug we encountered previously as well - should we
>>> block
>>> > on
>>> > > it? Also, looks like it will not be a patch release and we may need
>>> an
>>> > > accompanying tools release. Is that correct?
>>> > >
>>> > > -Nikhil
>>> > >
>>> > > -Original Message-
>>> > > From: Steven Gill [mailto:stevengil...@gmail.com]
>>> > > Sent: Wednesday, February 24, 2016 7:00 PM
>>> > > To: dev@cordova.apache.org
>>> > > Subject: Re: [DISCUSS] Cordova-iOS release
>>> > >
>>> > > Ran into a bug while testing upgrading from 3.9.2 to 4.1.0
>>> > >
>>> > >
>>> > >
>>> >
>>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9254=01%7c01%7cnikhilkh%40microsoft.com%7caa36706be39e4022069108d33d8fd2f9%7c72f988bf86f141af91ab2d7cd011db47%7c1=zLWtMl89ZwXQIJcBpcZ2XnBlqMfO4OcwJKBN2xEvhDA%3d
>>> > >
>>> > >
>>> > >
>>> > > On Wed, Feb 24, 2016 at 5:00 PM, Steven Gill >> >
>>> > > wrote:
>>> > >
>>> > > > Changes:
>>> > > >
>>> > > > * CB-10693 added missing header license
>>> > > > * CB-10693 Updated checked-in node_modules
>>> > > > * CB-10530 - Updated cordova.js. This closes #193
>>> > > > * CB-10530 - App freezes sometimes directly after starting on iOS
>>> > > > * CB-10668 checked in node_modules
>>> > > > * CB-10668 removed bin/node_modules
>>> > > > * CB-10668 updated create.js to grab node_modules from root,
>>> updated
>>> > > > package.json
>>> > > > * CB-10138  Adds missing plugin metadata to plugin_list module
>>> > > > * CB-10493: [iOS] Missing icon.png
>>> > > > * CB-10184: Images.xcassets: A 83.5x83.5@2x app icon is required
>>> for
>>> > > iPad
>>> > > > apps targeting iOS 9.0 and later
>>> > > > * Disable ios-deploy wifi mode when deploying to a device
>>> > > > * CB-10272 - Improve  and  error
>>> logs
>>> > > > * Updated bundled iso-sim to 5.0.6
>>> > > > * CB-10233: Support different config.xml file per CDVViewController
>>> > > > instance
>>> > > > * Add additional valid targets for simulation
>>> > > > * Trigger mirror push of tag
>>> > > > * Update JS snapshot to version 4.1.0-dev (via coho)
>>> > > > * Updated CDV version macro to 4.0.1
>>> > > > * CB-10185 - Update CordovaLib.xcodeproj to recommended settings in
>>> > Xcode
>>> > > > 7.2
>>> > > > * CB-10171 - WebKit Error after migration to iOS@4.0.0
>>> > > > * CB-10155 - DisallowOverscroll not working
>>> > > > * CB-10168: CDVViewController appURL is nil if wwwFolderName is the
>>> > path
>>> > > > to a resource bundle
>>> > > > * CB-10162 update reference url for icon images (closes #182)
>>> > > > * CB-10162 correct the paths for iOS icon and splashscreen
>>> resources
>>> > > > * This closes #172
>>> > > > * Update JS snapshot to version 4.1.0-dev (via coho)
>>> > > > * Set VERSION to 4.1.0-dev (via coho)
>>> > > >
>>> > > > I'm going to set the version to 4.1.0
>>> > > >
>>> > > > On Wed, Feb 24, 2016 at 4:03 PM, Steven Gill <
>>> stevengil...@gmail.com>
>>> > > > wrote:
>>> > > >
>>> > > >> Merged it in after chatting with Shaz
>>> > > >>
>>> > > >> On Wed, Feb 24, 2016 at 12:55 PM, Darryl Pogue 
>>> > > wrote:
>>> > > >>
>>> > > >>> I think we're still waiting for
>>> > > >>> https://github.com/apache/cordova-ios/pull/193 to land (but it's
>>> > > >>> probably
>>> > > >>> good to merge)
>>> > > >>>
>>> > > >>> On 24 February 2016 at 12:53, Steven Gill <
>>> stevengil...@gmail.com>
>>> > > >>> wrote:
>>> > > >>>
>>> > > >>> > Any blockers? Going to aim to send this out this afternoon.
>>> > > >>> >
>>> > > >>> >
>>> > > >>> > -Steve
>>> > > >>> >
>>> > > >>>
>>> > > >>
>>> > > >>
>>> > > >
>>> > >
>>> >
>>>
>>
>>
>

[GitHub] cordova-docs pull request: CB-10693 added ios 4.1.0 release blog p...

2016-03-01 Thread stevengill

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-docs/pull/530

CB-10693 added ios 4.1.0 release blog post



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-docs CB-10693

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #530


commit 7a6a709b54d91efc37603b56e39ba55699434da0
Author: Steve Gill 
Date:   2016-03-02T07:21:49Z

CB-10693 added ios 4.1.0 release blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-iOS release

2016-03-01 Thread Steven Gill

Shaz is back tomorrow. I just wanted to get his blessing before closing the
vote thread.

On Mon, Feb 29, 2016 at 8:39 PM, Steven Gill  wrote:

> Just bumped the ios vote thread
>
> On Mon, Feb 29, 2016 at 7:06 PM, Carlos Santana 
> wrote:
>
>> Sorry that I have being MIA, was at IBM conference at Vegas, and what
>> happened stayed there :-)
>>
>> Where we are with iOS release?
>>
>> I guess I was late to the Android 5.1.1 party that vote is done.
>>
>>
>> On Thu, Feb 25, 2016 at 9:26 PM Steven Gill 
>> wrote:
>>
>> > I sent a PR with the bug fix.
>> > https://github.com/apache/cordova-ios/pull/198
>> >
>> > Hoping to get this release going again tomorrow.
>> >
>> > Yeah it isn't a patch release, but a minor. Lets get iOS out first and
>> then
>> > we can focus on tools. It should work fine for people wanting to
>> manually
>> > update via `cordova platform add ios@4.1.0` once released.
>> >
>> >
>> >
>> > On Thu, Feb 25, 2016 at 5:45 PM, Nikhil Khandelwal <
>> nikhi...@microsoft.com
>> > >
>> > wrote:
>> >
>> > > Since this is a bug we encountered previously as well - should we
>> block
>> > on
>> > > it? Also, looks like it will not be a patch release and we may need an
>> > > accompanying tools release. Is that correct?
>> > >
>> > > -Nikhil
>> > >
>> > > -Original Message-
>> > > From: Steven Gill [mailto:stevengil...@gmail.com]
>> > > Sent: Wednesday, February 24, 2016 7:00 PM
>> > > To: dev@cordova.apache.org
>> > > Subject: Re: [DISCUSS] Cordova-iOS release
>> > >
>> > > Ran into a bug while testing upgrading from 3.9.2 to 4.1.0
>> > >
>> > >
>> > >
>> >
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9254=01%7c01%7cnikhilkh%40microsoft.com%7caa36706be39e4022069108d33d8fd2f9%7c72f988bf86f141af91ab2d7cd011db47%7c1=zLWtMl89ZwXQIJcBpcZ2XnBlqMfO4OcwJKBN2xEvhDA%3d
>> > >
>> > >
>> > >
>> > > On Wed, Feb 24, 2016 at 5:00 PM, Steven Gill 
>> > > wrote:
>> > >
>> > > > Changes:
>> > > >
>> > > > * CB-10693 added missing header license
>> > > > * CB-10693 Updated checked-in node_modules
>> > > > * CB-10530 - Updated cordova.js. This closes #193
>> > > > * CB-10530 - App freezes sometimes directly after starting on iOS
>> > > > * CB-10668 checked in node_modules
>> > > > * CB-10668 removed bin/node_modules
>> > > > * CB-10668 updated create.js to grab node_modules from root, updated
>> > > > package.json
>> > > > * CB-10138  Adds missing plugin metadata to plugin_list module
>> > > > * CB-10493: [iOS] Missing icon.png
>> > > > * CB-10184: Images.xcassets: A 83.5x83.5@2x app icon is required
>> for
>> > > iPad
>> > > > apps targeting iOS 9.0 and later
>> > > > * Disable ios-deploy wifi mode when deploying to a device
>> > > > * CB-10272 - Improve  and  error
>> logs
>> > > > * Updated bundled iso-sim to 5.0.6
>> > > > * CB-10233: Support different config.xml file per CDVViewController
>> > > > instance
>> > > > * Add additional valid targets for simulation
>> > > > * Trigger mirror push of tag
>> > > > * Update JS snapshot to version 4.1.0-dev (via coho)
>> > > > * Updated CDV version macro to 4.0.1
>> > > > * CB-10185 - Update CordovaLib.xcodeproj to recommended settings in
>> > Xcode
>> > > > 7.2
>> > > > * CB-10171 - WebKit Error after migration to iOS@4.0.0
>> > > > * CB-10155 - DisallowOverscroll not working
>> > > > * CB-10168: CDVViewController appURL is nil if wwwFolderName is the
>> > path
>> > > > to a resource bundle
>> > > > * CB-10162 update reference url for icon images (closes #182)
>> > > > * CB-10162 correct the paths for iOS icon and splashscreen resources
>> > > > * This closes #172
>> > > > * Update JS snapshot to version 4.1.0-dev (via coho)
>> > > > * Set VERSION to 4.1.0-dev (via coho)
>> > > >
>> > > > I'm going to set the version to 4.1.0
>> > > >
>> > > > On Wed, Feb 24, 2016 at 4:03 PM, Steven Gill <
>> stevengil...@gmail.com>
>> > > > wrote:
>> > > >
>> > > >> Merged it in after chatting with Shaz
>> > > >>
>> > > >> On Wed, Feb 24, 2016 at 12:55 PM, Darryl Pogue 
>> > > wrote:
>> > > >>
>> > > >>> I think we're still waiting for
>> > > >>> https://github.com/apache/cordova-ios/pull/193 to land (but it's
>> > > >>> probably
>> > > >>> good to merge)
>> > > >>>
>> > > >>> On 24 February 2016 at 12:53, Steven Gill > >
>> > > >>> wrote:
>> > > >>>
>> > > >>> > Any blockers? Going to aim to send this out this afternoon.
>> > > >>> >
>> > > >>> >
>> > > >>> > -Steve
>> > > >>> >
>> > > >>>
>> > > >>
>> > > >>
>> > > >
>> > >
>> >
>>
>
>

Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-03-01 Thread Steven Gill

Please review the blog post. https://github.com/apache/cordova-docs/pull/529



On Fri, Feb 26, 2016 at 2:00 PM, Steven Gill  wrote:

> Alright, I ended up just doing a rebase from master instead of
> cherry-picking. I think it should be all good now. Third vote sent.
>
> On Fri, Feb 26, 2016 at 9:00 AM, Steven Gill 
> wrote:
>
>> Hmm. Alright. I thought I got them all but obviously not. I'll
>> reinvestigate today.
>> On Feb 26, 2016 3:58 AM, "Alexander Sorokin (Akvelon)" <
>> v-als...@microsoft.com> wrote:
>>
>>> Sorry to say that but it looks like only a half of the changes made it
>>> to the archive this time.
>>>
>>> Here's what is missing:
>>> * CB-10138 Adds missing plugin metadata to `plugin_list` module.
>>> * CB-10443 Pass original options instead of remaining
>>> * CB-10443 Fix `this.root` null reference
>>> * CB-10421 Fixes exception when calling run script with `--help` option
>>> * updated `.gitignore`
>>> * CB-10406 Fixes an exception, thrown when building using Ant.
>>> * CB-10157 Uninstall app from device/emulator only when signed apk is
>>> already installed
>>>
>>> -Original Message-
>>> From: Steven Gill [mailto:stevengil...@gmail.com]
>>> Sent: Thursday, February 25, 2016 6:45 PM
>>> To: dev@cordova.apache.org
>>> Subject: RE: [DISCUSS] Cordova-Android 5.2.0 Release
>>>
>>> Ahh your right. Looks like since 5.1.x existed I needed to manually
>>> cherry-pick changes into it instead of relying on coho prepare-release
>>> command.  I'll send a new vote today.
>>> On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" <
>>> v-als...@microsoft.com> wrote:
>>>
>>> > I think there's something wrong with the package: it doesn't contain
>>> > any of the changes described in the release notes, only increased
>>> version.
>>> >
>>> > -Original Message-
>>> > From: Steven Gill [mailto:stevengil...@gmail.com]
>>> > Sent: Thursday, February 25, 2016 5:59 AM
>>> > To: dev@cordova.apache.org
>>> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>>> >
>>> > I added them today :D
>>> >
>>> > On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal
>>> > >> > >
>>> > wrote:
>>> >
>>> > > These commands look great - it will be good to add them to release
>>> > > process docs if they are not already there.
>>> > >
>>> > > -Nikhil
>>> > >
>>> > > -Original Message-
>>> > > From: Steven Gill [mailto:stevengil...@gmail.com]
>>> > > Sent: Wednesday, February 24, 2016 10:03 AM
>>> > > To: dev@cordova.apache.org
>>> > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>>> > >
>>> > > Definitely. Already committed the update.
>>> > >
>>> > > My new strategy with bundled/checked in dependencies
>>> > >
>>> > > * update package.json dep version if required
>>> > > * rm -rf node_modules
>>> > > * npm install --production (skips dev dependencies)
>>> > > * git add node_modules/* (checkin all modules needed for platform
>>> > > add git
>>> > > url)
>>> > > * git commit
>>> > > * npm install (Readd dev dependencies for ability to run tests
>>> > > locally)
>>> > >
>>> > >
>>> > >
>>> > > On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) <
>>> > > v-vlk...@microsoft.com> wrote:
>>> > >
>>> > > > Steve, do you plan to update bundled `cordova-common` as a part of
>>> > > > this release?
>>> > > >
>>> > > > -
>>> > > > Best regards, Vladimir
>>> > > >
>>> > > > -Original Message-
>>> > > > From: Steven Gill [mailto:stevengil...@gmail.com]
>>> > > > Sent: Wednesday, February 24, 2016 8:12 PM
>>> > > > To: dev@cordova.apache.org
>>> > > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>>> > > >
>>> > > > Issue:
>>> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
>>> > > > ss
>>> > > > ue
>>> > > > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%40
>>> > > > 06
>>> > > > 4d
>>> > > > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86
>>> > > > f1
>>> > > > 41
>>> > > > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRY
>>> > > > xX
>>> > > > dH
>>> > > > fE%3d
>>> > > >
>>> > > > I'm going to make this version 5.1.1. I'll update here if I decide
>>> > > > to go with 5.2.0 instead.
>>> > > >
>>> > > > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser 
>>> > wrote:
>>> > > >
>>> > > > > OK, are we sure we didn't add any new minor features?
>>> > > > >
>>> > > > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill
>>> > > > > 
>>> > > > > wrote:
>>> > > > >
>>> > > > > > Well we should be following semver.
>>> > > > > >
>>> > > > > >
>>> > > > > >- Bug fixes and other minor changes: Patch release,
>>> > > > > > increment the
>>> > > > last
>>> > > > > >number, e.g. 1.0.1
>>> > > > > >- New features which don't break existing features: Minor
>>> > release,
>>> > > > > >increment the middle number, e.g. 1.1.0
>>> > > > > >- Changes which break backwards compatibility: Major
>>> > > > > > release,

[GitHub] cordova-docs pull request: CB-10687 added android 5.1.1 release bl...

2016-03-01 Thread stevengill

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-docs/pull/529

CB-10687 added android 5.1.1 release blog post

Please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #529


commit a3de144d971583dab1a8a1d055771741e482f986
Author: Steve Gill 
Date:   2016-03-02T07:06:13Z

CB-10687 added android 5.1.1 release blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: blackberry camera fixes

2016-03-01 Thread kovacs-tamas

GitHub user kovacs-tamas opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/187

blackberry camera fixes

handle image size from the parameters, rotate the picture to the proper 
position.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kovacs-tamas/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #187


commit bb3296b4e352773ba4ca468374141da6f734ea00
Author: Tamas Kovacs 
Date:   2016-03-02T07:00:51Z

handle image size from the parameters, rotate the picture to the proper 
position




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54685843
  
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
 return filePath;
 }
 
+// This is not absolute, but more mightNeedOrientationCorrection
+- (BOOL) needsOrientationCorrection:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
+// TODO use image to detect if it needs an orientation correction
+
+// See FIXME #2
+//if (options.sourceType != 
UIImagePickerControllerSourceTypeCamera) {
+//return false;
+//}
+return options.correctOrientation;
+}
+
+- (BOOL) needsResize:(CDVPictureOptions*)options
+{
+return (options.targetSize.height > 0 && options.targetSize.width > 0);
+}
+
+- (BOOL) needsEdit:(UIImage*)image options:(CDVPictureOptions*)options
+{
+return [self needsOrientationCorrection:image options:options] || 
[self needsResize:options];
+}
+
+- (BOOL) needsSavingToPhotoAlbum:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
+/*
+ We save to the photo album if:
+ - the option is set
+ - the image is fetch from the camera OR the image has been edited (no 
need to duplicate image in the library)
+ */
+BOOL isSourceCamera = options.sourceType == 
UIImagePickerControllerSourceTypeCamera;
+BOOL saveToPhotoAlbum = options.saveToPhotoAlbum && ([self 
needsEdit:image options:options] || isSourceCamera);
+
+return saveToPhotoAlbum;
+}
+
+/*
+ Metadata is not needed for:
+ - source: gallery
+ - destination: NATIVE_URI
+ - no edit (not orientation and not resize and not allowEdits)
+ 
+ otherwise, it can be found:
+ - source: camera
+ => UIImagePickerControllerMediaMetadata
+ - source: gallery
+ => CGImage thingy
+ */
+
+// resultForImage:
+//  retrieve image, OK
+//  edit image (orientation + resize) and metadata OK
+//  if (geoLoc)
+//  save on self.{data, metadata}
+//  wait for geoLoc
+//  else
+//  saveAndResult
+//
+// saveAndResult:
+//  saveToPhotoAlbum if needed (options.saveToPhotoAlbum && !(gallery 
&& NATIVE_URI))
+//  send back the image URI
+- (void)didReceiveImage:(CDVPictureOptions*)options 
info:(NSDictionary*)info
--- End diff --

For consistency's sake, use the same naming convention for both image 
results and video results. (cf: 'resultForVideo')


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Blackberry camera fix

2016-03-01 Thread kovacs-tamas

Github user kovacs-tamas closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/182


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] 5.1.1 Android Release (attempt 3)

2016-03-01 Thread Steven Gill

The vote has now closed. The results are:

Positive Binding Votes: 4
Steve Gill
Alexander Sorokin
Joe Bowser
Sergey Grebnov

The vote has passed.


On Mon, Feb 29, 2016 at 9:53 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:

> I vote +1
>
> * Manually verified platform could be added, built and run (blank app)
> * Run auto-tests for core plugins on Android 6.0 device (paramedic)
>
> -Sergey Grebnov
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Tuesday, March 1, 2016 1:24 AM
> To: dev 
> Subject: Re: [Vote] 5.1.1 Android Release (attempt 3)
>
> I vote +1
>
> * Verified archives via `coho verify-archive`
> * Verified tags manually
> * Verified that blank app creates correctly with platform
> * Verified that blank app can be successfully ran and built
> * Ran mobilespec for master versions
>
> Side Note: I like what Alexander did for this one, and I trust they're
> thorough. Are all these steps automated? Is there a coho command to switch
> all plugins to release?
>
> On Mon, Feb 29, 2016 at 3:18 AM, Alexander Sorokin (Akvelon) <
> v-als...@microsoft.com> wrote:
>
> > I vote +1:
> >
> > * Verified archives via `coho verify-archive`
> > * Verified tags manually
> > * Verified that blank app creates correctly with platform
> > * Verified that blank app can be successfully ran and built
> > * Verified that platform can be updated from previous version
> > * Verified compatibility with core plugins (ran mobilespec for release
> > and master versions)
> > * Went through release notes
> > * Checked for whitespace issues
> > * Checked for Unicode issues
> > * Verified version
> > * Verified line breaks
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Saturday, February 27, 2016 12:59 AM
> > To: dev@cordova.apache.org
> > Subject: [Vote] 5.1.1 Android Release (attempt 3)
> >
> > Please review and vote on this 5.1.1 Android Release by replying to
> > this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-alsoro%40micr
> > osoft.com%7c1e385003521440220cf208d33ef81c81%7c72f988bf86f141af91ab2d7
> > cd011db47%7c1=Z2tQqIECSBR9UtvQJFyZPR%2bW3xLqmgj2pARsHI5laoo%3d
> >
> > The archive has been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10687
> >
> > The package was published from its corresponding git tag:
> > cordova-android: 5.1.1 (41ac464aca)
> >
> > Note that you can test it out via:
> >
> > cordova platform add
> > https://github.com/apache/cordova-android#5.1.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> > .md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ran through all testing steps at
> >
> > https://github.com/apache/cordova-coho/blob/master/docs/platforms-rele
> > ase-process.md#what-to-test
> >
>

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54685214
  
--- Diff: src/ios/CDVCamera.m ---
@@ -344,49 +429,6 @@ - 
(void)popoverControllerDidDismissPopover:(id)popoverController
 self.hasPendingOperation = NO;
 }
 
-- (NSData*)processImage:(UIImage*)image info:(NSDictionary*)info 
options:(CDVPictureOptions*)options
--- End diff --

[Just so I can remember to check what replaced the functionality that used 
to be provided by this funtion]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54685084
  
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
 return filePath;
 }
 
+// This is not absolute, but more mightNeedOrientationCorrection
+- (BOOL) needsOrientationCorrection:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
+// TODO use image to detect if it needs an orientation correction
+
+// See FIXME #2
+//if (options.sourceType != 
UIImagePickerControllerSourceTypeCamera) {
+//return false;
+//}
+return options.correctOrientation;
+}
+
+- (BOOL) needsResize:(CDVPictureOptions*)options
+{
+return (options.targetSize.height > 0 && options.targetSize.width > 0);
+}
+
+- (BOOL) needsEdit:(UIImage*)image options:(CDVPictureOptions*)options
+{
+return [self needsOrientationCorrection:image options:options] || 
[self needsResize:options];
+}
+
+- (BOOL) needsSavingToPhotoAlbum:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
+/*
+ We save to the photo album if:
+ - the option is set
+ - the image is fetch from the camera OR the image has been edited (no 
need to duplicate image in the library)
+ */
+BOOL isSourceCamera = options.sourceType == 
UIImagePickerControllerSourceTypeCamera;
+BOOL saveToPhotoAlbum = options.saveToPhotoAlbum && ([self 
needsEdit:image options:options] || isSourceCamera);
+
+return saveToPhotoAlbum;
+}
+
+/*
+ Metadata is not needed for:
+ - source: gallery
+ - destination: NATIVE_URI
+ - no edit (not orientation and not resize and not allowEdits)
+ 
+ otherwise, it can be found:
+ - source: camera
+ => UIImagePickerControllerMediaMetadata
+ - source: gallery
+ => CGImage thingy
--- End diff --

what 'thingy' ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54685044
  
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
 return filePath;
 }
 
+// This is not absolute, but more mightNeedOrientationCorrection
+- (BOOL) needsOrientationCorrection:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
+// TODO use image to detect if it needs an orientation correction
+
+// See FIXME #2
+//if (options.sourceType != 
UIImagePickerControllerSourceTypeCamera) {
+//return false;
+//}
+return options.correctOrientation;
+}
+
+- (BOOL) needsResize:(CDVPictureOptions*)options
+{
+return (options.targetSize.height > 0 && options.targetSize.width > 0);
+}
+
+- (BOOL) needsEdit:(UIImage*)image options:(CDVPictureOptions*)options
+{
+return [self needsOrientationCorrection:image options:options] || 
[self needsResize:options];
+}
+
+- (BOOL) needsSavingToPhotoAlbum:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
+/*
+ We save to the photo album if:
+ - the option is set
+ - the image is fetch from the camera OR the image has been edited (no 
need to duplicate image in the library)
+ */
+BOOL isSourceCamera = options.sourceType == 
UIImagePickerControllerSourceTypeCamera;
+BOOL saveToPhotoAlbum = options.saveToPhotoAlbum && ([self 
needsEdit:image options:options] || isSourceCamera);
+
+return saveToPhotoAlbum;
+}
+
+/*
+ Metadata is not needed for:
+ - source: gallery
+ - destination: NATIVE_URI
+ - no edit (not orientation and not resize and not allowEdits)
--- End diff --

what about 'quality' changes ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54684979
  
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
 return filePath;
 }
 
+// This is not absolute, but more mightNeedOrientationCorrection
+- (BOOL) needsOrientationCorrection:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
+// TODO use image to detect if it needs an orientation correction
+
+// See FIXME #2
+//if (options.sourceType != 
UIImagePickerControllerSourceTypeCamera) {
+//return false;
+//}
+return options.correctOrientation;
+}
+
+- (BOOL) needsResize:(CDVPictureOptions*)options
+{
+return (options.targetSize.height > 0 && options.targetSize.width > 0);
+}
+
+- (BOOL) needsEdit:(UIImage*)image options:(CDVPictureOptions*)options
+{
+return [self needsOrientationCorrection:image options:options] || 
[self needsResize:options];
+}
+
+- (BOOL) needsSavingToPhotoAlbum:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
--- End diff --

If the user specifies the option saveToPhotoAlbum and the image already 
exists in the PhotoLibrary, shouldn't we save it to the SavedPhotoAlbum ? 
(since SavedPhotoAlbum is different from the PhotoLibrary). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54684516
  
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
 return filePath;
 }
 
+// This is not absolute, but more mightNeedOrientationCorrection
+- (BOOL) needsOrientationCorrection:(UIImage*)image 
options:(CDVPictureOptions*)options
--- End diff --

We don't need a separate function for this, I think we can have these 
options 'inline' where needed instead of creating separate functions for them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54684356
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
 
 CDVPictureOptions* pictureOptions = [CDVPictureOptions 
createFromTakePictureArguments:command];
+
+/*
+ FIXME #1
+ What to do about quality?
+ If the option is set and the image is retrieved from the 
PhotoLibrary or SavedAlbum with a NATIVE_URI, no editing,
+ and is not saved to the photo album, then we return the "wrong" 
image.
+ However, the doc says "quality of the **saved** image", so it 
might be fine.
+ */
+/*
+ FIXME #2
+ The doc says: "Rotate the image to correct for the orientation of 
the device **during capture**."
+ Is capture <=> sourceType == CAMERA ?
+ */
+// Check for option compatibility
+BOOL isDestinationNativeUri = (pictureOptions.destinationType == 
DestinationTypeNativeUri);
+
+BOOL needsResize = [self needsResize:pictureOptions];
+BOOL needsOrientationCorrection = 
pictureOptions.correctOrientation;
+BOOL isSourceCamera = (pictureOptions.sourceType == 
UIImagePickerControllerSourceTypeCamera);
+BOOL allowsEditing = pictureOptions.allowsEditing;
+BOOL needsSavingToPhotoAlbum = (needsResize || 
needsOrientationCorrection || allowsEditing);
+
+// if one wants an edited image and a NATIVE_URI, the edited image 
must be in the assets library therefore one must set the saveToPhotoAlbum 
option to true.
+if (!pictureOptions.saveToPhotoAlbum && isDestinationNativeUri && 
needsSavingToPhotoAlbum) {
+NSLog(@"Incompatible options, cannot return native URI if 
image is not in the assets library");
+CDVPluginResult* result = [CDVPluginResult 
resultWithStatus:CDVCommandStatus_ERROR messageAsString:@"Incompatible options, 
cannot return native URI if image is not in the assets library"];
+[weakSelf.commandDelegate sendPluginResult:result 
callbackId:command.callbackId];
+return;
+}
+
 pictureOptions.popoverSupported = [weakSelf popoverSupported];
 pictureOptions.usesGeolocation = [weakSelf usesGeolocation];
-pictureOptions.cropToSize = NO;
--- End diff --

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-03-01 Thread stevengill

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-lib/pull/363#issuecomment-191085463
  
LGTM! Great work @riknoll! Very clean code and is easy to follow. Looking 
forward to switching over to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-browser release

2016-03-01 Thread Steven Gill

Yes, follow semver!

If we can get a good track record of following semver, I'd like to see us
switch to ^ with our pinned platforms and plugins so minors get picked up
automatically.

On Tue, Mar 1, 2016 at 7:01 PM, Tim Barham  wrote:

> It's been a long time since we did a cordova-browser release, and there
> have been many improvements since then. Should we get a release out before
> the next tools release?
>
> If so, what should the version be? Proper npm versioning would suggest we
> go with 4.1.0 (since it is more than just bug fixes), but since we
> currently pin ~4.0.0 in cordova-lib, that will mean people won't get it
> automatically, and it's very unlikely there are backward compat issues.
> Still, I guess 4.1.0 is the right thing to do.
>

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54684008
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
 
 CDVPictureOptions* pictureOptions = [CDVPictureOptions 
createFromTakePictureArguments:command];
+
+/*
+ FIXME #1
+ What to do about quality?
+ If the option is set and the image is retrieved from the 
PhotoLibrary or SavedAlbum with a NATIVE_URI, no editing,
+ and is not saved to the photo album, then we return the "wrong" 
image.
+ However, the doc says "quality of the **saved** image", so it 
might be fine.
+ */
+/*
+ FIXME #2
+ The doc says: "Rotate the image to correct for the orientation of 
the device **during capture**."
+ Is capture <=> sourceType == CAMERA ?
+ */
+// Check for option compatibility
+BOOL isDestinationNativeUri = (pictureOptions.destinationType == 
DestinationTypeNativeUri);
+
+BOOL needsResize = [self needsResize:pictureOptions];
+BOOL needsOrientationCorrection = 
pictureOptions.correctOrientation;
+BOOL isSourceCamera = (pictureOptions.sourceType == 
UIImagePickerControllerSourceTypeCamera);
+BOOL allowsEditing = pictureOptions.allowsEditing;
+BOOL needsSavingToPhotoAlbum = (needsResize || 
needsOrientationCorrection || allowsEditing);
+
+// if one wants an edited image and a NATIVE_URI, the edited image 
must be in the assets library therefore one must set the saveToPhotoAlbum 
option to true.
+if (!pictureOptions.saveToPhotoAlbum && isDestinationNativeUri && 
needsSavingToPhotoAlbum) {
--- End diff --

Hmmm, I agree that we should ideally not save into the photoAlbum if the 
user hasn't specified it in the options.
But on the other hand, the current behavior is to edit the image anyway, 
then go ahead and save it in the assets library/saved photo album anyway.
Which one should we go with ? I'm not really sure. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54683445
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
 
 CDVPictureOptions* pictureOptions = [CDVPictureOptions 
createFromTakePictureArguments:command];
+
+/*
+ FIXME #1
+ What to do about quality?
+ If the option is set and the image is retrieved from the 
PhotoLibrary or SavedAlbum with a NATIVE_URI, no editing,
+ and is not saved to the photo album, then we return the "wrong" 
image.
+ However, the doc says "quality of the **saved** image", so it 
might be fine.
+ */
+/*
+ FIXME #2
+ The doc says: "Rotate the image to correct for the orientation of 
the device **during capture**."
+ Is capture <=> sourceType == CAMERA ?
+ */
+// Check for option compatibility
+BOOL isDestinationNativeUri = (pictureOptions.destinationType == 
DestinationTypeNativeUri);
+
+BOOL needsResize = [self needsResize:pictureOptions];
+BOOL needsOrientationCorrection = 
pictureOptions.correctOrientation;
+BOOL isSourceCamera = (pictureOptions.sourceType == 
UIImagePickerControllerSourceTypeCamera);
+BOOL allowsEditing = pictureOptions.allowsEditing;
+BOOL needsSavingToPhotoAlbum = (needsResize || 
needsOrientationCorrection || allowsEditing);
+
+// if one wants an edited image and a NATIVE_URI, the edited image 
must be in the assets library therefore one must set the saveToPhotoAlbum 
option to true.
+if (!pictureOptions.saveToPhotoAlbum && isDestinationNativeUri && 
needsSavingToPhotoAlbum) {
--- End diff --

We also need to account for when the 'quality' option is not set the 
DEFAULT value. That also counts as an edit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54682684
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
 
 CDVPictureOptions* pictureOptions = [CDVPictureOptions 
createFromTakePictureArguments:command];
+
+/*
+ FIXME #1
+ What to do about quality?
+ If the option is set and the image is retrieved from the 
PhotoLibrary or SavedAlbum with a NATIVE_URI, no editing,
+ and is not saved to the photo album, then we return the "wrong" 
image.
+ However, the doc says "quality of the **saved** image", so it 
might be fine.
+ */
+/*
+ FIXME #2
+ The doc says: "Rotate the image to correct for the orientation of 
the device **during capture**."
--- End diff --

Yes. and possibly, it's also used for images picked from photolibrary or 
savedalbum, not sure though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread rakatyal

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/526#issuecomment-191067882
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixing README for display on Co...

2016-03-01 Thread rakatyal

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/84#issuecomment-191067046
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54680375
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
 
 CDVPictureOptions* pictureOptions = [CDVPictureOptions 
createFromTakePictureArguments:command];
+
+/*
+ FIXME #1
+ What to do about quality?
--- End diff --

I think if the quality option is specified, we need to modify the image 
retrieved from the PhotoLibraryr or SavedAlbum & (re)save it with the specified 
quality, then send a 'reference' back to the newly saved image.
This looks like a potential change in the API and might need to be ran past 
the dev mailing list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54680247
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
 
 CDVPictureOptions* pictureOptions = [CDVPictureOptions 
createFromTakePictureArguments:command];
+
+/*
+ FIXME #1
+ What to do about quality?
--- End diff --

Let's create a JIRA issue for this one as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54679929
  
--- Diff: src/ios/CDVCamera.m ---
@@ -78,7 +131,10 @@ + (instancetype) 
createFromTakePictureArguments:(CDVInvokedUrlCommand*)command
 pictureOptions.mediaType = [[command argumentAtIndex:6 
withDefault:@(MediaTypePicture)] unsignedIntegerValue];
 pictureOptions.allowsEditing = [[command argumentAtIndex:7 
withDefault:@(NO)] boolValue];
 pictureOptions.correctOrientation = [[command argumentAtIndex:8 
withDefault:@(NO)] boolValue];
-pictureOptions.saveToPhotoAlbum = [[command argumentAtIndex:9 
withDefault:@(NO)] boolValue];
+
+BOOL isDestinationNativeUri = (pictureOptions.destinationType == 
DestinationTypeNativeUri);
+BOOL isSourceCamera = (pictureOptions.sourceType == 
UIImagePickerControllerSourceTypeCamera);
+pictureOptions.saveToPhotoAlbum = [[command argumentAtIndex:9 
withDefault:@(NO)] boolValue] || (isDestinationNativeUri && isSourceCamera);
--- End diff --

A comment for the reason behind this 'quirk' would be good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54678642
  
--- Diff: src/ios/CDVCamera.m ---
@@ -59,6 +59,59 @@ Licensed to the Apache Software Foundation (ASF) under 
one
 
 @implementation CDVPictureOptions
 
+/*
+ API:
+ Camera:
+ - CameraPopoverHandle:
+ - setPosition(popoverOptions) => ()
+ - getPicture(success, failure, options) => CameraPopoverHandle
+ - options:
+ - quality (number [0-100])
+ - destinationType (number):
+ 0: DATA_URL
+ 1: FILE_URI
+ 2: NATIVE_URI
+ - sourceType (number):
+ 0: PHOTOLIBRARY
+ 1: CAMERA
+ 2: SAVEDPHOTOALBUM
+ - allowEdit (bool)
+ - encodingType (number):
+ 0: JPEG
+ 1: PNG
+ - targetWidth/targetHeight (number)
+ - mediaType (number):
+ 0: PICTURE
+ 1: VIDEO
+ 2: ALLMEDIA
+ - correctOrientation (bool)
+ - saveToPhotoAlbum (bool)
+ - cameraDirection (number)
+ 0: BACK
+ 1: FRONT
+ - popoverOptions (dictionnary) [iPad only]:
+ - x (number)
+ - y (number)
+ - width (number)
+ - height (number)
+ - arrowDir (number):
+ 1: ARROW_UP
+ 2: ARROW_DOWN
+ 4: ARROW_LEFT
+ 8: ARROW_RIGHT
+ 15: ARROW_ANY
+ - cleanup => ()
+ */
+
+/*
+ TODO:
--- End diff --

Please, File JIRA issues for these ToDO's


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54678618
  
--- Diff: src/ios/CDVCamera.m ---
@@ -59,6 +59,59 @@ Licensed to the Apache Software Foundation (ASF) under 
one
 
 @implementation CDVPictureOptions
 
+/*
+ API:
+ Camera:
+ - CameraPopoverHandle:
--- End diff --

Also, why do we have the API documented here ? If the documentation is 
lacking, shouldn't we add it to the README.md that shows up so that app 
developers can also take advantage of it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54678557
  
--- Diff: src/ios/CDVCamera.m ---
@@ -59,6 +59,59 @@ Licensed to the Apache Software Foundation (ASF) under 
one
 
 @implementation CDVPictureOptions
 
+/*
+ API:
+ Camera:
+ - CameraPopoverHandle:
--- End diff --

it's a bit hard to follow these options since there's no indentation.
for example, is 'getPicture' also part of 'CameraPopoverHandle' ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: Switch from adm-zip to archiver.

2016-03-01 Thread TimBarham

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-browser/pull/10#issuecomment-191031984
  
@amikula - this PR was closed by a commit made to `cordova-firefoxos`, 
which was probably done by mistake.

But regarding this problem specifically: since it was last released, 
`cordova-browser` has been updated to use the `cordova-serve`, which in turn 
uses ExpressJS for things including handling compression. So this PR is 
out-of-date, and likely the problem will go away when we do another 
`cordova-browser` release (which I will kick off the process for).

In the meantime, you could try the latest changes to `cordova-browser` 
(including verifying this problem is now fixed) by adding the browser platform 
using:

cordova add platform browser@https://github.com/apache/cordova-browser 
--save


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Cordova-browser release

2016-03-01 Thread Tim Barham

It's been a long time since we did a cordova-browser release, and there have 
been many improvements since then. Should we get a release out before the next 
tools release?

If so, what should the version be? Proper npm versioning would suggest we go 
with 4.1.0 (since it is more than just bug fixes), but since we currently pin 
~4.0.0 in cordova-lib, that will mean people won't get it automatically, and 
it's very unlikely there are backward compat issues. Still, I guess 4.1.0 is 
the right thing to do.

[GitHub] cordova-plugin-media pull request: Fixing README for display on Co...

2016-03-01 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54670241
  
--- Diff: README.md ---
@@ -415,7 +411,7 @@ Starts recording an audio file.
 
 - Windows devices can use MP3, M4A and WMA formats for recorded audio. 
However in most cases it is not possible to use MP3 for audio recording on 
_Windows Phone 8.1_ devices, because an MP3 encoder is [not shipped with 
Windows 
Phone](https://msdn.microsoft.com/en-us/library/windows/apps/windows.media.mediaproperties.mediaencodingprofile.createmp3.aspx).
 
-- If a full path is not provided, the recording is placed in the 
AppData/temp directory. This can be accessed via the `File` API using 
`LocalFileSystem.TEMPORARY` or 'ms-appdata:///temp/' URI.
+- If a full path is not provided, the recording is placed in the 
AppData/temp directory. This can be accessed via the `File` API using 
`LocalFileSystem.TEMPORARY` or `ms-appdata:///temp/` URI.
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixing README for display on Co...

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54670094
  
--- Diff: README.md ---
@@ -58,10 +58,6 @@ Although in the global scope, it is not available until 
after the `deviceready`
 
 - Only one media file can be played back at a time.
 
-- There are strict restrictions on how your application interacts with 
other media. See the [Microsoft documentation for details][url].
-
-[url]: 
http://msdn.microsoft.com/en-us/library/windowsphone/develop/hh184838(v=vs.92).aspx
-
--- End diff --

Gotcha.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixing README for display on Co...

2016-03-01 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54669864
  
--- Diff: README.md ---
@@ -58,10 +58,6 @@ Although in the global scope, it is not available until 
after the `deviceready`
 
 - Only one media file can be played back at a time.
 
-- There are strict restrictions on how your application interacts with 
other media. See the [Microsoft documentation for details][url].
-
-[url]: 
http://msdn.microsoft.com/en-us/library/windowsphone/develop/hh184838(v=vs.92).aspx
-
--- End diff --

The link redirects to a redirect to a page that does not sound like the 
original one that was linked to


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Plugin Version Selection for Cordova Lib

2016-03-01 Thread Richard Knoll

Hey everyone,

The new plugin version selection implementation for cordova-lib has been in PR 
[1] for a while and I plan on merging it tomorrow if nobody objects. It is a 
pretty big update to the behavior of "cordova plugin add", so I wanted to give 
a heads up and make sure that people are aware that this is happening. Also see 
the cordova-discuss proposal [2] and the JIRA [3] for context.

Thanks,
Richard

[1]: https://github.com/apache/cordova-lib/pull/363
[2]: https://github.com/cordova/cordova-discuss/pull/30
[3]: https://issues.apache.org/jira/browse/CB-10679

[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/58#discussion_r54668778
  
--- Diff: README.md ---
@@ -340,6 +285,61 @@ capturing a video clip, the `CaptureErrorCB` callback 
executes with a
 - Cordova for BlackBerry 10 attempts to launch the __Video Recorder__ 
application, provided by RIM, to capture video recordings. The app receives a 
`CaptureError.CAPTURE_NOT_SUPPORTED` error code if the application is not 
installed on the device.
 
 
+## CaptureAudioOptions
+
+> Encapsulates audio capture configuration options.
+
+### Properties
+
+- __limit__: The maximum number of audio clips the device user can record 
in a single capture operation.  The value must be greater than or equal to 1 
(defaults to 1).
+
+- __duration__: The maximum duration of an audio sound clip, in seconds.
+
+### Example
+
+// limit capture operation to 3 media files, no longer than 10 seconds 
each
+var options = { limit: 3, duration: 10 };
+
+navigator.device.capture.captureAudio(captureSuccess, captureError, 
options);
+
+### Amazon Fire OS Quirks
+
+- The `duration` parameter is not supported.  Recording lengths cannot be 
limited programmatically.
+
+### Android Quirks
+
+- The `duration` parameter is not supported.  Recording lengths can't be 
limited programmatically.
+
+### BlackBerry 10 Quirks
+
+- The `duration` parameter is not supported.  Recording lengths can't be 
limited programmatically.
+- The `limit` parameter is not supported, so only one recording can be 
created for each invocation.
+
+### iOS Quirks
+
+- The `limit` parameter is not supported, so only one recording can be 
created for each invocation.
+
+
+## CaptureImageOptions
+
+> Encapsulates image capture configuration options.
--- End diff --

Nitpick: This doesn't need to be a quote.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/58#discussion_r54668668
  
--- Diff: README.md ---
@@ -340,6 +285,61 @@ capturing a video clip, the `CaptureErrorCB` callback 
executes with a
 - Cordova for BlackBerry 10 attempts to launch the __Video Recorder__ 
application, provided by RIM, to capture video recordings. The app receives a 
`CaptureError.CAPTURE_NOT_SUPPORTED` error code if the application is not 
installed on the device.
 
 
+## CaptureAudioOptions
+
+> Encapsulates audio capture configuration options.
--- End diff --

Nitpick: This doesn't need to be a quote.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/526#discussion_r54667932
  
--- Diff: www/static/js/index.js ---
@@ -145,17 +145,48 @@ $(document).ready(function () {
 
 // Smooth scroll to anchor links
 $("a[href^='#']").on('click', function(e) {
-if(this.hash) {
+
+// scroll only if there is a hash in the href
+var hash = this.hash;
+if (hash) {
 
 // prevent default anchor click behavior
 e.preventDefault();
 
-// store hash
-var hash = this.hash;
+// get the fragment without the "#" symbol
+var targetName = hash;
+if (targetName[0] === "#") {
--- End diff --

I guess the condition will never fail as long as browsers obey the 
standard. I'll remove the check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: Fixing README for displ...

2016-03-01 Thread riknoll

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/58

Fixing README for display on Cordova website

I moved some stuff around because it looked awkward in the TOC for the 
page. See 
[here](http://cordova.apache.org/docs/en/dev/cordova-plugin-media-capture/index.html)

@dblotsky @rakatyal to review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-media-capture 
website-readme-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit 5c644f0ffdf134449bf443b0e254ab7c294359b8
Author: riknoll 
Date:   2016-03-02T01:26:53Z

Fixing README for display on Cordova website




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixing README for display on Co...

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54667450
  
--- Diff: README.md ---
@@ -58,10 +58,6 @@ Although in the global scope, it is not available until 
after the `deviceready`
 
 - Only one media file can be played back at a time.
 
-- There are strict restrictions on how your application interacts with 
other media. See the [Microsoft documentation for details][url].
-
-[url]: 
http://msdn.microsoft.com/en-us/library/windowsphone/develop/hh184838(v=vs.92).aspx
-
--- End diff --

Is this no longer relevant?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/526#discussion_r54666977
  
--- Diff: www/static/js/index.js ---
@@ -145,17 +145,48 @@ $(document).ready(function () {
 
 // Smooth scroll to anchor links
 $("a[href^='#']").on('click', function(e) {
-if(this.hash) {
+
+// scroll only if there is a hash in the href
+var hash = this.hash;
+if (hash) {
 
 // prevent default anchor click behavior
 e.preventDefault();
 
-// store hash
-var hash = this.hash;
+// get the fragment without the "#" symbol
+var targetName = hash;
+if (targetName[0] === "#") {
+var targetName = targetName.slice(1);
--- End diff --

We should not re-define targetName with a `var`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Fix a number of documentation ...

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/528#issuecomment-191009883
  
@rakatyal 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Fix a number of documentation ...

2016-03-01 Thread nikhilkh

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-docs/pull/528

CB-10178 Fix a number of documentation issues

Here are the list of fixes
- Add more examples for icons for Windows and link to platform SDK docs.
- Ensure all references to CLI guide - now reference to notion of "creating 
your first app"
- Update all links for plugins to point to internal docs as opposed to 
npm/GitHub.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs docupdate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #528


commit 1ee9e415aeaf2827849a3c708bc21f1f34926b78
Author: Nikhil Khandelwal 
Date:   2016-03-02T01:12:44Z

CB-10178 Fix a number of documentation issues




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Fixing README for displa...

2016-03-01 Thread rakatyal

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/153#issuecomment-191008766
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10720 Fixed spelling, capit...

2016-03-01 Thread dblotsky

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/186

CB-10720 Fixed spelling, capitalization, and other small issues.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-10720

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #186


commit ce50a2c3c63736f014298dd6d24c529c3ece702a
Author: Dmitry Blotsky 
Date:   2016-03-02T01:09:03Z

CB-10720 Fixed spelling, capitalization, and other small issues.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: CB-10720 Minor spelling/forma...

2016-03-01 Thread dblotsky

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-plugin-console/pull/17

CB-10720 Minor spelling/formatting changes.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-console CB-10720

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-console/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit a14d319680447030871751fa94d6a4abb548a110
Author: Dmitry Blotsky 
Date:   2016-03-02T01:22:05Z

CB-10720 Minor spelling/formatting changes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixing README for display on Co...

2016-03-01 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54666299
  
--- Diff: README.md ---
@@ -415,7 +411,7 @@ Starts recording an audio file.
 
 - Windows devices can use MP3, M4A and WMA formats for recorded audio. 
However in most cases it is not possible to use MP3 for audio recording on 
_Windows Phone 8.1_ devices, because an MP3 encoder is [not shipped with 
Windows 
Phone](https://msdn.microsoft.com/en-us/library/windows/apps/windows.media.mediaproperties.mediaencodingprofile.createmp3.aspx).
 
-- If a full path is not provided, the recording is placed in the 
AppData/temp directory. This can be accessed via the `File` API using 
`LocalFileSystem.TEMPORARY` or 'ms-appdata:///temp/' URI.
+- If a full path is not provided, the recording is placed in the 
AppData/temp directory. This can be accessed via the `File` API using 
`LocalFileSystem.TEMPORARY` or `ms-appdata:///temp/` URI.
--- End diff --

`Appdata/temp`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Fixing README for displa...

2016-03-01 Thread riknoll

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/153

Fixing README for display on Cordova website

@dblotsky @rakatyal to review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser 
website-readme-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #153


commit bd3bb451ad971715cd91a3f37d8ad8bdec973c0a
Author: riknoll 
Date:   2016-03-02T01:21:02Z

Fixing README for display on Cordova website




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10737 Fetching now errors out on inv...

2016-03-01 Thread rakatyal

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/525#issuecomment-191007432
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixing README for display on Co...

2016-03-01 Thread riknoll

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/84

Fixing README for display on Cordova website

@dblotsky @rakatyal to review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-media CB-something

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit f63399ebe1036c14d2a5055b4746171e77dd40f1
Author: riknoll 
Date:   2016-02-29T22:56:05Z

Fixing README for display on Cordova website




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/526#discussion_r54665031
  
--- Diff: www/static/js/index.js ---
@@ -145,17 +145,48 @@ $(document).ready(function () {
 
 // Smooth scroll to anchor links
 $("a[href^='#']").on('click', function(e) {
-if(this.hash) {
+
+// scroll only if there is a hash in the href
+var hash = this.hash;
+if (hash) {
 
 // prevent default anchor click behavior
 e.preventDefault();
 
-// store hash
-var hash = this.hash;
+// get the fragment without the "#" symbol
+var targetName = hash;
+if (targetName[0] === "#") {
--- End diff --

Do we need to return if this condition fails?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-03-01 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r54663442
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets, 
opts) {
 });
 };
 
+function determinePluginTarget(projectRoot, cfg, target, fetchOptions) {
+var parts = target.split('@');
+var id = parts[0];
+var version = parts[1];
+
+// If no version is specified, retrieve the version (or source) from 
config.xml
+if (!version && !cordova_util.isUrl(id) && 
!cordova_util.isDirectory(id)) {
--- End diff --

Right, I just refactored this code, but I should have caught that. Changing 
now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-03-01 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r54660579
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets, 
opts) {
 });
 };
 
+function determinePluginTarget(projectRoot, cfg, target, fetchOptions) {
+var parts = target.split('@');
+var id = parts[0];
+var version = parts[1];
+
+// If no version is specified, retrieve the version (or source) from 
config.xml
+if (!version && !cordova_util.isUrl(id) && 
!cordova_util.isDirectory(id)) {
+events.emit('verbose', 'No version specified, retrieving version 
from config.xml');
+var ver = getVersionFromConfigFile(id, cfg);
+
+if (cordova_util.isUrl(ver) || cordova_util.isDirectory(ver)) {
+target = ver;
+} else if (ver) {
+// If version exists in config.xml, use that
+target = id + '@' + ver;
+} else {
+// If no version is given at all and we are fetching from npm, 
we
+// can attempt to use the Cordova dependencies the plugin 
lists in
+// their package.json
+var shouldUseNpmInfo = !fetchOptions.searchpath && 
!fetchOptions.noregistry;
+
+if(shouldUseNpmInfo) {
+events.emit('verbose', 'No version given in config.xml, 
attempting to use plugin engine info');
+}
+
+return (shouldUseNpmInfo ? registry.info([id]) : Q({}))
+.then(function(pluginInfo) {
+return getFetchVersion(projectRoot, pluginInfo, 
pkgJson.version);
+}, function(error) {
--- End diff --

Sure, I can change it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Minor changes to Readme

2016-03-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request: Minor changes to readme

2016-03-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-globalization/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request: Minor changes to readme

2016-03-01 Thread riknoll

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-globalization/pull/46#issuecomment-190957333
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request: Minor changes to readme

2016-03-01 Thread dblotsky

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-globalization/pull/46#issuecomment-190956617
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request: Minor changes to readme

2016-03-01 Thread rakatyal

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-plugin-globalization/pull/46

Minor changes to readme

@riknoll, @dblotsky: Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-globalization 
raghav-readme

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-globalization/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #46


commit 05218c9fa0ff69b4088048b731f270923dce6bed
Author: Raghav Katyal 
Date:   2016-03-01T23:11:24Z

Minor changes to readme




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fix splashscreen typo in latest blogpos...

2016-03-01 Thread BBosman

Github user BBosman commented on the pull request:

https://github.com/apache/cordova-docs/pull/503#issuecomment-190953715
  
Ping @vladimir-kotikov .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...

2016-03-01 Thread bso-intel

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-android/pull/264#issuecomment-190952289
  
Right. I agree that silently passing is not good.
So, I said that we should print the warning message to the user "Warning: 
 in the  already exists. {Skipped copying/Overwrote} that 
file".
My proposal leaves some options to make the plugins runnable without 
changing the Cordova source code. 
I am not sure how the current behavior of throwing an exception is better 
than this proposal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...

2016-03-01 Thread brodybits

Github user brodybits commented on the pull request:

https://github.com/apache/cordova-android/pull/264#issuecomment-190951704
  
I would favor leaving it to the plugins to use the `lib-file` instead of 
`source-file` to install the libraries. A couple of things that could really 
help:
- very clear documentation on how to specify the native NDK Android 
libraries (I did not see it anywhere)
- clarify the error message in cases like this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10730 Move plugin handlers tests ...

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/155#discussion_r54650191
  
--- Diff: spec/unit/JsprojManager.spec.js ---
@@ -25,6 +25,7 @@ var AppxManifest = 
require('../../template/cordova/lib/AppxManifest');
 var JsprojManager = rewire('../../template/cordova/lib/JsprojManager');
 
 var PROJECT_PATH = 'spec/unit/fixtures/EmptyProject';
--- End diff --

Should this be `DummyProject`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/264#issuecomment-190947034
  
My concern with silently passing here is that there could be a 
runtime/build failure because potentially the wrong version of the file is 
added depending on the order of adding pluigns or even worse the same filename 
has completely different source code.

Fixing those runtime or gradle build failure might not be a pleasant 
experience either for the user. There is no good solution for this - but 
working with the conflicting plugins to change where they add those files. For 
commonly used libraries, they should just use the `framework` element as that 
handles scenarios around multiple plugins adding common libraries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Minor changes to Readme

2016-03-01 Thread riknoll

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/129#issuecomment-190944752
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Minor changes to Readme

2016-03-01 Thread rakatyal

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/129#issuecomment-190943028
  
@dblotsky, @riknoll: Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: Minor changes to Readme

2016-03-01 Thread rakatyal

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/129

Minor changes to Readme



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
raghav-readme

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #129


commit 22652fb148f2999f1aea3e14e9dc4e94376b3d4e
Author: Raghav Katyal 
Date:   2016-03-01T22:31:39Z

Minor changes to Readme




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...

2016-03-01 Thread bso-intel

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-android/pull/264#issuecomment-190937260
  
Hi nikhill,

I am not a plugin writer so I don't know whether the plugin write can use 
other tags for their purposes.
This issue was reported from one of the Intel xdk users who needed to use 
both plugins in his app.
It looks to me that  tag is quite frequently used for some 
library files (as Vladimir pointed out).
Whenever the user complains about this issue, we (Cordova) can't blame the 
plugin developers for not checking with possible conflicts with other plugins.
I think the users will understand the new warning message (once aded), and 
if any issue arise by skipping/overwriting the existing files, and they can try 
a different order to resolve the issue.
However, when Cordova CLI throws an exception, it just leaves no option for 
the user. 
It is going to be a dead end for this use case. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/264#issuecomment-190929927
  
I agree we should improve the error messages - especially the 'Uh oh!' :)

We have three tags:
- 
[lib-file](http://cordova.apache.org/docs/en/dev/plugin_ref/spec.html#lib-file)
- 
[source-file](http://cordova.apache.org/docs/en/dev/plugin_ref/spec.html#source-file)
- 
[resource-file](http://cordova.apache.org/docs/en/dev/plugin_ref/spec.html#resource-file)

@bso-intel - Should the plugin be using `lib-file` for libraries instead of 
`source-file`, which already follows the 'copyFile' semantics?





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54644131
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Significant Documentation Updates"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for feedback on the experience of using Cordova from the 
developer standpoint. We received more than 900 responses and documentation 
emerged as one of the major pain points for the average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action-driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader-friendly. The 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
+- Updated the platform guides as single page content following a common 
structure. For example, the [Android 
Guide](http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html)
 and others now have the following sections:
+   - Requirements and Support
--- End diff --

Please indent this list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54639244
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Significant Documentation Updates"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for feedback on the experience of using Cordova from the 
developer standpoint. We received more than 900 responses and Documentation 
emerged as one of the major pain points for the average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
+- Updated the platform guides as single page content following a common 
structure. For example, the [Android 
Guide](http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html)
 and others now have the following sections:
+   - Requirements and Support
--- End diff --

It is indented isn't it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54639014
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Significant Documentation Updates"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for feedback on the experience of using Cordova from the 
developer standpoint. We received more than 900 responses and Documentation 
emerged as one of the major pain points for the average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
+- Updated the platform guides as single page content following a common 
structure. For example, the [Android 
Guide](http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html)
 and others now have the following sections:
+   - Requirements and Support
+   - Installing the Requirements
+   - Project Configuration
+   - Debugging
+   - Signing an App
+   - Platform Centered Workflow
+   - Upgrading
+- Moved Core Plugin docs, like [Cordova Plugin 
Camera](http://cordova.apache.org/docs/en/latest/cordova-plugin-camera/index.html),
 from Github to be a part of the website so that they are now accessible from 
one place and are easier to read.
--- End diff --

"... to be a part of the website. They are now ..."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54638889
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Significant Documentation Updates"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for feedback on the experience of using Cordova from the 
developer standpoint. We received more than 900 responses and Documentation 
emerged as one of the major pain points for the average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
+- Updated the platform guides as single page content following a common 
structure. For example, the [Android 
Guide](http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html)
 and others now have the following sections:
+   - Requirements and Support
--- End diff --

Please indent this list so that it renders as a sub-list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54638795
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Significant Documentation Updates"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for feedback on the experience of using Cordova from the 
developer standpoint. We received more than 900 responses and Documentation 
emerged as one of the major pain points for the average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
--- End diff --

"CLI" -> "The CLI section".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54638755
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Significant Documentation Updates"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for feedback on the experience of using Cordova from the 
developer standpoint. We received more than 900 responses and Documentation 
emerged as one of the major pain points for the average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
--- End diff --

"Reader-friendly".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54638717
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
--- End diff --

"Action-driven".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54638658
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Significant Documentation Updates"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for feedback on the experience of using Cordova from the 
developer standpoint. We received more than 900 responses and Documentation 
emerged as one of the major pain points for the average Cordova developer.
--- End diff --

Don't need to capitalize "documentation".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread rakatyal

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/527#issuecomment-190883463
  
Addressed feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/526#issuecomment-190880778
  
Cool! I'm assuming this fixes the camera docs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54626152
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
--- End diff --

Sounds fair.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54625576
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
--- End diff --

Isn't that self explanatory? Introduction, create apps, create plugins, 
advanced topics and reference. We might just be using the same terms as 
description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Label for custum type phone ...

2016-03-01 Thread tobiasmuecksch

Github user tobiasmuecksch commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/102#issuecomment-190874401
  
:+1: +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54624737
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
+- Updated the platform guides as single page content following a common 
structure. 
+- Moved Core Plugin docs, like [Cordova Plugin 
Camera](http://cordova.apache.org/docs/en/latest/cordova-plugin-camera/index.html),
 from Github to be a part of the website so that they are now accessible from 
one place and are easier to read.
+- Fixed a number of Jira bugs related to documentation as a part of 
improving these articles.
+
+These all are reflected in the new Docs release and we would love to hear 
your feedback so that we can continue to work on improving it.
+
+It's easy to provide feedback: 
--- End diff --

+1 PRs are welcome - using the edit button on the website.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54624115
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
+- Updated the platform guides as single page content following a common 
structure. 
+- Moved Core Plugin docs, like [Cordova Plugin 
Camera](http://cordova.apache.org/docs/en/latest/cordova-plugin-camera/index.html),
 from Github to be a part of the website so that they are now accessible from 
one place and are easier to read.
+- Fixed a number of Jira bugs related to documentation as a part of 
improving these articles.
+
+These all are reflected in the new Docs release and we would love to hear 
your feedback so that we can continue to work on improving it.
+
+It's easy to provide feedback: 
--- End diff --

Maybe mention the edit button on docs pages? Also, it would be nice to link 
to the docs component: 
https://issues.apache.org/jira/browse/CB/component/12316407/?selectedTab=com.atlassian.jira.jira-projects-plugin:component-summary-panel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54623759
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
--- End diff --

Perhaps a more descriptive title here - ideas:
- Revamped Cordova Documentation experience
- Significant Documentation updates


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54623862
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
+- Updated the platform guides as single page content following a common 
structure. 
+- Moved Core Plugin docs, like [Cordova Plugin 
Camera](http://cordova.apache.org/docs/en/latest/cordova-plugin-camera/index.html),
 from Github to be a part of the website so that they are now accessible from 
one place and are easier to read.
+- Fixed a number of Jira bugs related to documentation as a part of 
improving these articles.
+
+These all are reflected in the new Docs release and we would love to hear 
your feedback so that we can continue to work on improving it.
+
+It's easy to provide feedback: 
+
+- File a JIRA using "Component": Docs- 
--- End diff --

The hyphen at the end needs to be removed. We should link to instructions 
for filing a JIRA. I believe we have details on the website.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54623474
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
--- End diff --

It will be great to give a high level walk through of the different 
sections of the TOC: 
 - Architecture overview
- Create apps:  Focused on app developer blah blah
- Create Plugins: Focused on plugin developer blah blah
- Reference topics



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54623383
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
--- End diff --

* "...asking for the experience of working with Cordova from our users.=> 
"...asking for feedback on the experience of using Cordova from the developer 
standpoint."
* "of an average..." => "for the average..."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/527#discussion_r54623053
  
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+--- 
+layout: post 
+author: 
+name: Raghav Katyal
+url: https://github.com/rakatyal
+title:  "Docs Improvement"
+categories: announcements 
+tags: news releases docs 
+---
+
+We are happy to announce that we have made significant content updates to 
our documentation.
+
+
+A while back we conducted a 
[survey](https://apachecordovabot.typeform.com/to/BCc5co) on the Cordova 
website asking for the experience of working with Cordova from our users. We 
received more than 900 responses and Documentation emerged as one of the major 
pain points of an average Cordova developer.
+
+Since then we have made efforts to improve the quality of our 
documentation. To summarize it:
+
+- Validated and corrected most of the current doc content.
+- Re-organized the content for our website and made our table of contents 
more concise and composed of action driven items for ease of navigation.
+- Added a 'Reference' section and updated the articles to make them 
comprehensive and reader friendly. 
[CLI](http://cordova.apache.org/docs/en/latest/cordova-cli/index.html) for 
example, now lives under the 'Reference' section.
+- Updated the platform guides as single page content following a common 
structure. 
--- End diff --

Great to give an example here too. For example, the [Android 
guide](http://link) has important details on machine setup - blah blah. 
(highlighting the common structure).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

2016-03-01 Thread rakatyal

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/527

Adding blog post for docs improvement



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav-blog

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #527


commit 73bbb1f00f011ddaf6be3a4b26ceb243fe7c629e
Author: Raghav Katyal 
Date:   2016-03-01T19:28:02Z

Adding blog post for docs improvement




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-01 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54620911
  
--- Diff: src/ios/CDVCamera.h ---
@@ -87,19 +91,51 @@ typedef NSUInteger CDVMediaType;
 {}
 
 @property (strong) CDVCameraPicker* pickerController;
-@property (strong) NSMutableDictionary *metadata;
+@property (strong) NSDictionary* metadata;
 @property (strong, nonatomic) CLLocationManager *locationManager;
-@property (strong) NSData* data;
+@property (strong) UIImage* image;
 
 /*
- * getPicture
+ * takePicture
  *
  * arguments:
- * 1: this is the javascript function that will be called with the 
results, the first parameter passed to the
- * javascript function is the picture as a Base64 encoded string
- *  2: this is the javascript function to be called if there was an error
+ *  1: success callback (called with either Base64, file URI or native URI)
--- End diff --

These comments seem to be meant to document the javascript side of things, 
instead of the objective-c side. What's the reason for them being here ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Pinned plugins and releases

2016-03-01 Thread Steven Gill

I think once that plugin version constraint PR lands, we can removing
plugin pinning. Correct me if I'm wrong, but for that PR to be useful, we
need to update all of the package.json files of the plugins to include the
engine information.

I agree logging something like "fetching pinned plugin version X" when
installing a plugin would be a nice addition. We could also do a lookup to
see what the latest version on npm is and only output a message if what is
being fetched isn't the latest.

Another possible solution is to trust our semver versioning and allow the
pins to grab minor updates by default.

I don't think it is necessary to do a tools release every time a minor
plugin is released. If people really want to latest plugins, then can
install them explicitly until the next tools release.

On Mon, Feb 29, 2016 at 9:57 PM, Nikhil Khandelwal 
wrote:

> I think pinning plugins in the CLI is causing a bunch of confusion (see
> CB-10677) as cordova plugin add might not get you the latest released
> plugin. This is a change in behavior - perhaps - we should log when the
> plugin is different from the latest released version. Also, there is an
> issue with our release strategy - should we change our policy to release
> TOOLS with every minor plugin release bump in addition to platform release?
>
> With new plugin version constraint matching behavior implemented as part
> of this PR: https://github.com/apache/cordova-lib/pull/363 . Is there
> still a use case for pinning core plugins in package.json? Presumably, we
> could specify the constraints for a new plugin release and plugins will be
> "effectively" pinned.
>
> Thanks,
> Nikhil
> My team is hiring.
>
>

[GitHub] cordova-windows pull request: CB-10714 #2 Ignore case for --archs

2016-03-01 Thread jerroydmoore

GitHub user jerroydmoore opened a pull request:

https://github.com/apache/cordova-windows/pull/156

CB-10714 #2 Ignore case for --archs 

Second attempt at CB-10714. Submitted an ICLA earlier today and introduced 
myself to the dev@cordova.apache.org mailing list. Passes existing Unit Tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jerroydmoore/cordova-windows CB-10714

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #156


commit b65510a92e306a242a90a3394491a3513c92e249
Author: Jerroyd Moore 
Date:   2016-03-01T18:49:14Z

Pass Unit Tests for Ignoring case for --archs

This fixes up commit c9305e5224c63f390aeb8d5ef698bf1e3b7b7f4f.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: cordova-cli Travis CI

2016-03-01 Thread Steven Gill

Yeah, no idea why it was disabled in the first place. +1 to adding it back

On Tue, Mar 1, 2016 at 10:39 AM, Nikhil Khandelwal 
wrote:

> Yes, I don't see a reason to disable this.
>
> -Nikhil
>
> -Original Message-
> From: dharmendra sharma [mailto:dharam.accent...@gmail.com]
> Sent: Tuesday, March 1, 2016 5:31 AM
> To: dev@cordova.apache.org
> Subject: Re: cordova-cli Travis CI
>
> I suggest we should keep Travis CI. That will enhance the code quality of
> commit.
>
> What other have opinion about the same ?
>
>
> On Tue, Mar 1, 2016 at 6:31 PM, Sergey Shakhnazarov (Akvelon) <
> v-ses...@microsoft.com> wrote:
>
> > Hi guys,
> >
> > I wonder why Travis CI is disabled [1] for cordova-cli and whether we
> > should enable it?
> > 5 tests are failing currently.
> >
> > [1]:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2ftravi
> > s-ci.org%2fapache%2fcordova-cli=01%7c01%7cnikhilkh%40microsoft.co
> > m%7c698e46d5e1504678a7e408d341d67f5e%7c72f988bf86f141af91ab2d7cd011db4
> > 7%7c1=zQbt%2bRnCjEoKQSyYwGTDvwWwTOzL8OczM6bPGVVlMiA%3d
> >
> > Please let me know if you have any questions or considerations.
> >
> > Best regards,
> > Sergey Shakhnazarov.
> >
> >
>

RE: cordova-cli Travis CI

2016-03-01 Thread Nikhil Khandelwal

Yes, I don't see a reason to disable this.

-Nikhil

-Original Message-
From: dharmendra sharma [mailto:dharam.accent...@gmail.com] 
Sent: Tuesday, March 1, 2016 5:31 AM
To: dev@cordova.apache.org
Subject: Re: cordova-cli Travis CI

I suggest we should keep Travis CI. That will enhance the code quality of 
commit.

What other have opinion about the same ?


On Tue, Mar 1, 2016 at 6:31 PM, Sergey Shakhnazarov (Akvelon) < 
v-ses...@microsoft.com> wrote:

> Hi guys,
>
> I wonder why Travis CI is disabled [1] for cordova-cli and whether we 
> should enable it?
> 5 tests are failing currently.
>
> [1]: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2ftravi
> s-ci.org%2fapache%2fcordova-cli=01%7c01%7cnikhilkh%40microsoft.co
> m%7c698e46d5e1504678a7e408d341d67f5e%7c72f988bf86f141af91ab2d7cd011db4
> 7%7c1=zQbt%2bRnCjEoKQSyYwGTDvwWwTOzL8OczM6bPGVVlMiA%3d
>
> Please let me know if you have any questions or considerations.
>
> Best regards,
> Sergey Shakhnazarov.
>
>

RE: [Vote] 4.1.0 iOS Release

2016-03-01 Thread Mefire O .

+1

-Original Message-
From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] 
Sent: Monday, February 29, 2016 11:51 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] 4.1.0 iOS Release

I vote +1

* Run auto-tests for core plugins with browserify option on iOS 8.1.1 device. 
Log available at [1]
* Reviewed release notes

[1] 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgist.github.com%2fsgrebnov%2f8f0e59f010dac7d4cfa9=01%7c01%7commenjik%40microsoft.com%7ccfa720e0bcc44372433f08d341a634f6%7c72f988bf86f141af91ab2d7cd011db47%7c1=zpxTT9O4qU1%2bOu114zoDGvpU2%2bK7gwLV4H5L5EYECyA%3d

-Sergey Grebnov

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tuesday, March 1, 2016 7:39 AM
To: dev@cordova.apache.org
Subject: Re: [Vote] 4.1.0 iOS Release

bump

On Fri, Feb 26, 2016 at 3:46 PM, Steven Gill  wrote:

> Please review and vote on this 4.1.0 iOS Release by replying to this 
> email (and keep discussion on the DISCUSS thread)
>
> Release issue: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-10693=01%7c01%7cv-segreb%40micr
> osoft.com%7c9c31bd8acf5f49913dd908d3418b74d0%7c72f988bf86f141af91ab2d7
> cd011db47%7c1=FwNXD72z6iE9u2nGXV11IWt3YJfi0uJVeujNthKNjIw%3d
>
> The archive has been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10693
>
> The package was published from its corresponding git tag:
> cordova-ios: 4.1.0 (b3794e2788)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ios#4.1.0
>
> Upon a successful vote I will upload the archive to dist/, publish it to npm, 
> and post the blog post.
>
> Voting guidelines: 
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and 
> subdependencies have Apache-compatible licenses
> * Ran through testing steps at
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-rele
> https://na01.safelinks.protection.outlook.com/?url=ase-process.md
> =01%7c01%7commenjik%40microsoft.com%7ccfa720e0bcc44372433f08d341a634f6
> %7c72f988bf86f141af91ab2d7cd011db47%7c1=IgdUubdaC%2fKf%2fER20DiQSmGpwoCYa06EfttV1K97QHE%3d#testing
>
>

[GitHub] cordova-plugin-camera pull request: Major refactor

2016-03-01 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190840500
  
Oops, my bad. :)
Reviewing that PR instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-03-01 Thread riknoll

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-190839346
  
@MatthewBooth can you fill out an ICLA? I need that in order to merge your 
rebase. Instructions are here: 
http://cordova.apache.org/contribute/contribute_guidelines.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix for CB-10050 : Plugin Came...

2016-03-01 Thread riknoll

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/183#issuecomment-190838635
  
@omefire can you take a look at this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Major refactor

2016-03-01 Thread dieppe

Github user dieppe commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190836981
  
@omefire I did close this one :wink:  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Major refactor

2016-03-01 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190836679
  
I see that you opened another PR: 
https://github.com/apache/cordova-plugin-camera/pull/185
Please, close this one then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: CB-10636 Add JSHint for...

2016-03-01 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/57#discussion_r54605945
  
--- Diff: tests/plugin.xml ---
@@ -26,6 +26,8 @@
 Cordova Media Capture Plugin Tests
 Apache 2.0
 
+
--- End diff --

Nope, I don't :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

1 2 >

1 - 100 of 126 matches

Mail list logo