Re: [VOTE] cordova-browser@5.0.4 patch release

2018-08-09 Thread Steven Gill
+1

On Tue, Aug 7, 2018 at 5:21 AM Chris Brody  wrote:

> Thanks Gandhi. Can I get one more review on this one?
> On Mon, Aug 6, 2018 at 11:28 PM gandhi rajan 
> wrote:
> >
> > +1
> >
> > On Tuesday, July 31, 2018, Chris Brody  wrote:
> >
> > > Please review and vote on this cordova-browser@5.0.4 patch release by
> > > replying to this email (and keep discussion on the DISCUSS thread).
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-14230
> > >
> > > The archive has been published to dist/dev:
> > > https://dist.apache.org/repos/dist/dev/cordova/CB-14230/
> > >
> > > The package was published from its corresponding git tag:
> > >
> > > cordova-browser: 5.0.4 (c61ce21186)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add
> https://github.com/apache/cordova-browser#5.0.4
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> > > to npm, and post the blog post.
> > >
> > > Voting guidelines:
> > >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ensured continuous build was green when repo was tagged
> > > * able to add to
> > > https://github.com/brodybits/cordova-dialogs-bootstrap-test using
> > > cordova platform add github:brodybits/cordova-browser#5.0.x, run, and
> > > try a couple dialogs with npm@2.15.11 (bundled with deprecated node
> > > v4.9.1) on Windows Edge, Windows Chrome, and macOS Safari
> > > * able to add to
> > > https://github.com/brodybits/cordova-dialogs-bootstrap-test using
> > > cordova platform add github:brodybits/cordova-browser#5.0.x, run, and
> > > try a couple dialogs with npm@5.6.0 (bundled with node v8.11.3)
> > > * more details in https://github.com/apache/cordova-browser/pull/55
> > >
> > > Proposed blog post in: https://github.com/apache/cordova-docs/pull/857
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
> > --
> > Regards,
> > Gandhi
> >
> > "The best way to find urself is to lose urself in the service of others
> !!!"
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: [VOTE] cordova-common Release (Attempt 2)

2018-06-04 Thread Steven Gill
+1
* npm test
* coho verify-archive
* coho audit-license-headers

On Mon, Jun 4, 2018 at 1:13 PM Jesse  wrote:

> +1
> * npm test
> * coho verify-archive
> * coho audit-license-headers
>
>
>
> @purplecabbage
> risingj.com
>
> On Fri, Jun 1, 2018 at 11:47 PM, Darryl Pogue  wrote:
>
> > Please review and vote on this Tools Release by replying to this email
> > (and keep discussion on the DISCUSS thread)
> >
> > Release issue:
> > https://issues.apache.org/jira/browse/CB-14112
> >
> > Packages have been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-14112/
> >
> > The packages were published from the corresponding git tag:
> > cordova-common: 2.2.3 (6530ce7fd4)
> >
> > Upon a successful vote I will upload the archives to dist/, publish
> > them to npm, and post the corresponding blog post.
> >
> > Blog post:
> > https://github.com/apache/cordova-docs/pull/828
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > sub-dependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repos were tagged
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [VOTE] cordova-common Release

2018-05-31 Thread Steven Gill
+1

* Ran npm test
* coho audit-license-header
* coho verify-archive

On Thu, May 31, 2018 at 4:40 AM Chris Brody  wrote:

> +1
>
> On May 31, 2018 12:21 AM, "Darryl Pogue"  wrote:
>
> > Please review and vote on this Tools Release by replying to this email
> > (and keep discussion on the DISCUSS thread)
> >
> > Release issue:
> > https://issues.apache.org/jira/browse/CB-14112
> >
> > Packages have been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-14112/
> >
> > The packages were published from the corresponding git tag:
> > cordova-common: 2.2.2 (e98283d030)
> >
> > Upon a successful vote I will upload the archives to dist/, publish
> > them to npm, and post the corresponding blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > sub-dependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repos were tagged
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: deprecate weinre?

2018-05-20 Thread Steven Gill
+1

On Sun, May 20, 2018 at 9:50 AM Joe Bowser  wrote:

> +1
>
> On Sun., May 20, 2018, 8:48 a.m. julio cesar sanchez, <
> jcesarmob...@gmail.com> wrote:
>
> > Last release was in 7 Oct 2014, there is a lot of issues and nobody is
> > working on them, and the even the weinre README.md talks about better
> > inspectors, so, should we officially deprecate it and close all the
> pending
> > issues?
> >
>


Re: Contributor Introduction

2018-05-18 Thread Steven Gill
Welcome! Feel free to reach out if you have any questions. Great to see
Monaca interested in contributing 

On Fri, May 18, 2018 at 5:04 PM Shazron  wrote:

> Welcome Gearóid!
>
> On Fri, May 18, 2018 at 10:44 PM Gearóid M  wrote:
>
> > Hi all,
> >
> > My name is Gearóid. I've been building apps with Cordova for many years,
> > and am hoping to now start contributing to the project. I am currently
> > working at Monaca, and I am also the maintainer of the Onsen UI
> framework.
> >
> > I have a lot of experience with Javascript, HTML and CSS, as well as
> > experience creating several Cordova plugins with Java. I hope to be able
> to
> > make some contributions in these areas.
> >
> > P.S. I see many familiar names on the mailing list from previous Phonegap
> > Days in Amsterdam -- looking forward to collaborating with you all!
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: Contributor Introduction

2018-05-14 Thread Steven Gill
Welcome Ken!

Let me know if you have any questions about contributing to cordova!

On Mon, May 14, 2018 at 8:40 AM gandhi rajan 
wrote:

> Hi Ken,
>
> Warm welcome. Really looking forward for your contributions. Cheers.
>
> On Monday, May 14, 2018, 内藤謙一  wrote:
>
> > Hi Everyone,
> >
> > My name is Ken Naito.
> >
> > I am an engineer and working on mobile application development at Monaca.
> >
> > I have wide experience in HTML, JavaScript, Java, and Objective-C via
> > implementing Cordova applications and plugins on which Monaca uses.
> >
> > I would like to contribute to the Cordova community with bug fixes,
> > feature implementations, and improvements.
> >
> > Regards,
> > Ken
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>
> --
> Regards,
> Gandhi
>
> "The best way to find urself is to lose urself in the service of others
> !!!"
>


Re: Contributor Introduction

2018-05-11 Thread Steven Gill
Woo! Welcome Bryan! Don't by shy to reach out on here or on the cordova
slack!

On Fri, May 11, 2018 at 6:59 AM Simon MacDonald 
wrote:

> Welcome Bryan, happy to see folks from Monaca on the list.
>
> Simon Mac Donald
> http://simonmacdonald.com
>
>
> On Fri, May 11, 2018 at 3:32 AM Bryan Ellis  wrote:
>
> > Hey Everyone,
> >
> > My name is Bryan Ellis. I am currently working at Monaca as a Senior
> > Software Engineer.
> >
> > I have a strong professional and educational background in Java,
> > JavaScript, HTML, CSS, and other languages.
> >
> > Since I have been working with the Apache Cordova framework on a regular
> > basis within Monaca, I am looking forward to contributing back to the
> > community with bug fixes, feature implementations, and tooling
> > improvements.
> >
>


Re: PR with additional linting rules

2018-05-08 Thread Steven Gill
I don't have any issues adding those new rules around unused args. It would
be best if we incorporated the new rules across all of our repos, but I'm
not going to be picky at this stage

On Tue, May 8, 2018 at 7:26 AM Darryl Pogue  wrote:

> Hi folks,
>
> There's a PR[1] to cordova-common that turns on some additional linting
> rules and removes unused function parameters.
>
> I'm happy to merge it but feel like I shouldn't unilaterally approve
> changes to our linting rules, so anyone else have any strong feelings on
> this?
>
> [1] https://github.com/apache/cordova-common/pull/17
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: New Android Preference

2018-04-20 Thread Steven Gill
Let's do it.

On Fri, Apr 20, 2018, 2:29 PM julio cesar sanchez 
wrote:

> Yeah, having the plugin as dependency should be enough, but as Simon said,
> as a lot of plugins will need this, makes sense to add it to the platform
>
> El viernes, 20 de abril de 2018, Jesse  escribió:
>
> > So instead of plugin authors including gradle files, they would just add
> > the  to the plugin.xml and be done?
> >
> > I assume this requires a platform update.
> > Do we miss anything from not including a version as in  way?
> > If we just ask plugin authors to add a dependency on
> > cordova-support-google-services
> > doesn't that mean that the android platform wouldn't need to change?
> >
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Fri, Apr 20, 2018 at 12:04 PM, Simon MacDonald <
> > simon.macdon...@gmail.com
> > > wrote:
> >
> > > Hey all,
> > >
> > > I'd like to suggest that we add a new Android preference. It would be a
> > > boolean preference, to control whether or not to run the Google
> Services
> > > Plugin.
> > >
> > > A number of plugins need to have this gradle plugin run during build
> time
> > > and they are handling it via a gradle file included in their plugin
> like
> > > this:
> > >
> > > https://github.com/fechanique/cordova-plugin-fcm/blob/
> > > master/src/android/FCMPlugin.gradle
> > >
> > > but that falls down if two plugins try to apply GoogleServicesPlugin.
> > >
> > > The way to mitigate that right now is to have dependency on
> > > cordova-support-google-services so it will only run once.
> > >
> > > 
> > >
> > > However, it makes sense for this to be a preference in cordova-android.
> > > Perhaps,
> > >
> > > 
> > >
> > > If the value is true, then we apply the GoogleServicesPlugin.
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> >
>


Re: [DISCUSS] Android & iOS release

2018-04-17 Thread Steven Gill
Joe or myself don't currently have the time to fix this problem and
probably won't for the foreseeable future. Plugin maintainers can send PRs
to cordova-android adding their mapping if they want or update their
plugins.

But I'd like to get this release out because of the bug fixes that have
landed and because the release train should keep rolling. A future release
can happen with those fixes once PRs come in

On Tue, Apr 17, 2018 at 2:59 PM, Joe Bowser <bows...@gmail.com> wrote:

> On Tue, Apr 17, 2018 at 2:54 PM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > Yeah, but our plugins work because we have put some code to copy our
> files
> > to a new location instead of updating the paths in the plugins'
> plugin.xml.
> > This is handled for what our plugins need, but not for all the possible
> > cases, so I don't think it's ok to make a patch to just make our plugins
> > work but don't do the same for other allowed files. If we didn't update
> the
> > core plugins for the new path we shouldn't ask users to do it in their
> > plugins.
> >
> >
> Fair, we should really be updating all our plugins and figuring out how to
> remove the patch.  The last thing I want to see is this code growing like
> a cancer, which it very well could.  I don't think we should be delaying
> the release because of third party plugins not being able to be installed.
>
>
> > Also there is the problem I told you about the false positive making it
> > think it's an Eclipse project and making our plugins fail to install if
> > they are installed after a plugin with the previos problem.
> >
> >
> Yeah, that's a pretty major failure that we never saw when we were testing
> 7.0.  I don't think this should delay the release either unless a PR
> arrives that fixes this.
>
>
>
> >
> > 2018-04-17 23:30 GMT+02:00 Joe Bowser <bows...@gmail.com>:
> >
> > > I disagree.  We have our core plugins installing and uninstalling
> without
> > > issue currently, and we can't babysit everyone with their third party
> > > plugins.  The community needs to come up with a plan on deprecating the
> > old
> > > project structure and communicating that to the third party plugin
> > > maintainers.
> > >
> > >
> > > On Tue, Apr 17, 2018 at 2:28 PM, julio cesar sanchez <
> > > jcesarmob...@gmail.com
> > > > wrote:
> > >
> > > > Before doing an Android release we should fix the problems with
> plugins
> > > > installs, people is not updating because of it
> > > >
> > > > 2018-04-17 3:31 GMT+02:00 gandhi rajan <gandhiraja...@gmail.com>:
> > > >
> > > > > Hi Steve,
> > > > >
> > > > > Can you please have a look at this PR -
> > > > > https://github.com/apache/cordova-docs/pull/811
> > > > >
> > > > > It's related to Cordova doc changes.
> > > > >
> > > > > On Tuesday, April 17, 2018, Steven Gill stevengil...@gmail.com>
> > wrote:
> > > > >
> > > > > > Going to aim to do a release this week. Let me know if there are
> > any
> > > > PRs
> > > > > I
> > > > > > should look at.
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Regards,
> > > > > Gandhi
> > > > >
> > > > > "The best way to find urself is to lose urself in the service of
> > others
> > > > > !!!"
> > > > >
> > > >
> > >
> >
>


Re: [VOTE] Plugins Release (Attempt 2)

2018-04-16 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3
Steve Gill
Julio Cesar
Joe Bowser

The vote has passed. I will publish the blog post and publish the plugins to npm



On Mon, Apr 16, 2018 at 1:52 PM, Joe Bowser <bows...@gmail.com> wrote:

> I vote +1
>
> - Tested with Mobilespec
>
> On Sun, Apr 15, 2018, 2:37 PM julio cesar sanchez, <jcesarmob...@gmail.com
> >
> wrote:
>
> > I vote +1
> >
> > 2018-04-13 22:08 GMT+02:00 Steven Gill <stevengil...@gmail.com>:
> >
> > > Please review and vote on the release of this plugins release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-14030
> > >
> > > The plugins have been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-14030/
> > >
> > > The packages were published from their corresponding git tags:
> > > cordova-plugin-camera: 4.0.3 (6ce1443622)
> > > cordova-plugin-vibration: 3.1.0 (0b323409f9)
> > > cordova-plugin-statusbar: 2.4.2 (fbc4862dbd)
> > > cordova-plugin-media-capture: 3.0.2 (288a47eee1)
> > > cordova-plugin-inappbrowser: 3.0.0 (757022d85a)
> > > cordova-plugin-globalization: 1.11.0 (65331146ca)
> > > cordova-plugin-device: 2.0.2 (e83c1afd84)
> > > cordova-plugin-battery-status: 2.0.2 (aebf1a1445)
> > > cordova-plugin-device-motion: 2.0.1 (7aa654f673)
> > > cordova-plugin-device-orientation: 2.0.1 (477eb2b52e)
> > >
> > > Upon a successful vote I will upload the archives to dist/, upload
> > > them to npm, and post the corresponding blog post.
> > >
> > > Voting guidelines:
> > >
> > https://github.com/apache/cordova-coho/blob/master/docs/
> release-voting.md
> > > How to vote on a plugins release at
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > > plugins-release-process.md#voting
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ensured continuous build was green when repos were tagged
> > >
> >
>


[DISCUSS] Android & iOS release

2018-04-16 Thread Steven Gill
Going to aim to do a release this week. Let me know if there are any PRs I
should look at.


Re: [DISCUSS] Plugins release

2018-04-13 Thread Steven Gill
Thanks Julio! Sent the updated vote thread

On Fri, Apr 13, 2018 at 11:35 AM, julio cesar sanchez <
jcesarmob...@gmail.com> wrote:

> I've sent a PR that fixes the InAppBrowser problem with the
> cordovaDependencies
> https://github.com/apache/cordova-plugin-inappbrowser/pull/266
>
> 2018-04-13 20:23 GMT+02:00 Steven Gill <stevengil...@gmail.com>:
>
> > Julio, I will update the release today and include those two.
> >
> > On Fri, Apr 13, 2018 at 10:33 AM, Simon MacDonald <
> > simon.macdon...@gmail.com
> > > wrote:
> >
> > > John,
> > >
> > > It is included.
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > > On Fri, Apr 13, 2018 at 1:32 PM, johnkger...@gmail.com <
> > > johnkger...@gmail.com> wrote:
> > >
> > > >
> > > >
> > > > On 2018/04/09 17:52:04, Steven Gill <stevengil...@gmail.com> wrote:
> > > > > Going to aim to do a plugins release this Wed, April 11th. Let me
> > know
> > > if
> > > > > there are any important PRs I should look at before than.
> > > > >
> > > > Hi Steven,
> > > >
> > > > Please insure that cordova-plugin-globalization pull request 64 is
> > > > included; https://github.com/apache/cordova-plugin-globalization/
> > pull/64
> > > >
> > > > Thanks for your help!
> > > > John
> > > >
> > > > 
> -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> >
>


[VOTE] Plugins Release (Attempt 2)

2018-04-13 Thread Steven Gill
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-14030

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-14030/

The packages were published from their corresponding git tags:
cordova-plugin-camera: 4.0.3 (6ce1443622)
cordova-plugin-vibration: 3.1.0 (0b323409f9)
cordova-plugin-statusbar: 2.4.2 (fbc4862dbd)
cordova-plugin-media-capture: 3.0.2 (288a47eee1)
cordova-plugin-inappbrowser: 3.0.0 (757022d85a)
cordova-plugin-globalization: 1.11.0 (65331146ca)
cordova-plugin-device: 2.0.2 (e83c1afd84)
cordova-plugin-battery-status: 2.0.2 (aebf1a1445)
cordova-plugin-device-motion: 2.0.1 (7aa654f673)
cordova-plugin-device-orientation: 2.0.1 (477eb2b52e)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repos were tagged


Re: [VOTE] Plugins Release

2018-04-13 Thread Steven Gill
Cancelling this. Will send an updated one today.

On Thu, Apr 12, 2018 at 6:30 PM, Steven Gill <stevengil...@gmail.com> wrote:

> Please review and vote on the release of this plugins release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-14030
>
> The plugins have been published to 
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-14030/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-camera: 4.0.3 (6ce1443622)
> cordova-plugin-vibration: 3.1.0 (0b323409f9)
> cordova-plugin-statusbar: 2.4.2 (fbc4862dbd)
> cordova-plugin-media-capture: 3.0.2 (288a47eee1)
> cordova-plugin-inappbrowser: 3.0.0 (200f7c1923)
> cordova-plugin-globalization: 1.11.0 (65331146ca)
> cordova-plugin-device: 2.0.2 (e83c1afd84)
> cordova-plugin-battery-status: 2.0.2 (aebf1a1445)
>
> Upon a successful vote I will upload the archives to dist/, upload them to 
> npm, and post the corresponding blog post.
>
> Voting guidelines: 
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> How to vote on a plugins release at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies have 
> Apache-compatible licenses
> * Ensured continuous build was green when repos were tagged
>
>
>


Re: [DISCUSS] Plugins release

2018-04-13 Thread Steven Gill
Julio, I will update the release today and include those two.

On Fri, Apr 13, 2018 at 10:33 AM, Simon MacDonald <simon.macdon...@gmail.com
> wrote:

> John,
>
> It is included.
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Fri, Apr 13, 2018 at 1:32 PM, johnkger...@gmail.com <
> johnkger...@gmail.com> wrote:
>
> >
> >
> > On 2018/04/09 17:52:04, Steven Gill <stevengil...@gmail.com> wrote:
> > > Going to aim to do a plugins release this Wed, April 11th. Let me know
> if
> > > there are any important PRs I should look at before than.
> > >
> > Hi Steven,
> >
> > Please insure that cordova-plugin-globalization pull request 64 is
> > included; https://github.com/apache/cordova-plugin-globalization/pull/64
> >
> > Thanks for your help!
> > John
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [DISCUSS] Plugins release

2018-04-12 Thread Steven Gill
Blog post for review: https://github.com/apache/cordova-docs/pull/812

On Thu, Apr 12, 2018 at 1:34 PM, Steven Gill <stevengil...@gmail.com> wrote:

> I've reviewed the PRs.
>
> Julio, for vibration plugin, I'm thinking it gets documented as a quirk.
> I'll do that and start the release now.
>
>
> On Tue, Apr 10, 2018 at 12:42 AM, Niklas Merz <niklas.m...@rhoen.de>
> wrote:
>
>> Not a really an important one, but I would like to see my first PR to
>> InAppBrowser merged, so I can switch the plugin in our project back to
>> a released version.
>>
>> I added an option to the InAppBrowser
>> https://github.com/apache/cordova-plugin-inappbrowser/pull/254.
>>
>> Thanks
>>
>> Quoting julio cesar sanchez <jcesarmob...@gmail.com>:
>>
>> > I have this one removing navigator.notification from vibration plugin
>> as it
>> > has been deprecated for a long time and even removed from the docs
>> > https://github.com/apache/cordova-plugin-vibration/pull/67.
>> > So it might require minor or major version bump?
>> >
>> > Also, related issue, on Android, vibration plugin uses the browser
>> > implementation, but looks like Google doesn't allow to vibrate without
>> user
>> > interaction first, so we should document it or go back to the native
>> > implementation. https://issues.apache.org/jira/browse/CB-14022.
>> > If going back to the native implementation, then we should do it for
>> this
>> > release, if just documenting, probably can wait.
>> >
>> > And I have this one for InAppBrowser plugin, was going to merge it but
>> > travis is failing on one of the Android tests
>> > https://github.com/apache/cordova-plugin-inappbrowser/pull/264
>> >
>> >
>> > 2018-04-09 19:52 GMT+02:00 Steven Gill <stevengil...@gmail.com>:
>> >
>> >> Going to aim to do a plugins release this Wed, April 11th. Let me know
>> if
>> >> there are any important PRs I should look at before than.
>> >>
>>
>>
>>
>


[VOTE] Plugins Release

2018-04-12 Thread Steven Gill
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-14030

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-14030/

The packages were published from their corresponding git tags:
cordova-plugin-camera: 4.0.3 (6ce1443622)
cordova-plugin-vibration: 3.1.0 (0b323409f9)
cordova-plugin-statusbar: 2.4.2 (fbc4862dbd)
cordova-plugin-media-capture: 3.0.2 (288a47eee1)
cordova-plugin-inappbrowser: 3.0.0 (200f7c1923)
cordova-plugin-globalization: 1.11.0 (65331146ca)
cordova-plugin-device: 2.0.2 (e83c1afd84)
cordova-plugin-battery-status: 2.0.2 (aebf1a1445)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repos were tagged


Re: [DISCUSS] Plugins release

2018-04-12 Thread Steven Gill
I've reviewed the PRs.

Julio, for vibration plugin, I'm thinking it gets documented as a quirk.
I'll do that and start the release now.

On Tue, Apr 10, 2018 at 12:42 AM, Niklas Merz <niklas.m...@rhoen.de> wrote:

> Not a really an important one, but I would like to see my first PR to
> InAppBrowser merged, so I can switch the plugin in our project back to
> a released version.
>
> I added an option to the InAppBrowser
> https://github.com/apache/cordova-plugin-inappbrowser/pull/254.
>
> Thanks
>
> Quoting julio cesar sanchez <jcesarmob...@gmail.com>:
>
> > I have this one removing navigator.notification from vibration plugin as
> it
> > has been deprecated for a long time and even removed from the docs
> > https://github.com/apache/cordova-plugin-vibration/pull/67.
> > So it might require minor or major version bump?
> >
> > Also, related issue, on Android, vibration plugin uses the browser
> > implementation, but looks like Google doesn't allow to vibrate without
> user
> > interaction first, so we should document it or go back to the native
> > implementation. https://issues.apache.org/jira/browse/CB-14022.
> > If going back to the native implementation, then we should do it for this
> > release, if just documenting, probably can wait.
> >
> > And I have this one for InAppBrowser plugin, was going to merge it but
> > travis is failing on one of the Android tests
> > https://github.com/apache/cordova-plugin-inappbrowser/pull/264
> >
> >
> > 2018-04-09 19:52 GMT+02:00 Steven Gill <stevengil...@gmail.com>:
> >
> >> Going to aim to do a plugins release this Wed, April 11th. Let me know
> if
> >> there are any important PRs I should look at before than.
> >>
>
>
>


[DISCUSS] Plugins release

2018-04-09 Thread Steven Gill
Going to aim to do a plugins release this Wed, April 11th. Let me know if
there are any important PRs I should look at before than.


Re: Request estimate for next release of cordova-plugin-globalization

2018-03-26 Thread Steven Gill
cordova-plugin-globalization was deprecated November 2017. See
https://github.com/apache/cordova-plugin-globalization#deprecation-notice

We aren't planning on doing anymore releases as far as I'm aware. We
recommend pointing your package.json & config.xml to the github repo
instead if you want to continue using it. Another option is to fork the
plugin and publish it under a different name with the fix you need.

Cheers,
-Steve

On Mon, Mar 26, 2018 at 11:19 AM, johnkger...@gmail.com <
johnkger...@gmail.com> wrote:

> Hi Team,
>
> Pull request #64 (https://github.com/apache/cordova-plugin-globalization/
> pull/64) was committed on February 2 to address a ReDoS issue in
> moment.js, which is shipped in cordova-plugin-globalization.  As this is a
> security issue, may I ask what the current plans are for releasing a new
> version of the plugin please?  We've tested the nightly build and confirmed
> that the issue has been addressed, but would obviously prefer to ship with
> a released version of the plugin as opposed to a nightly build.
>
> Thanks for your help,
> John Gerken
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


[DRAFT] Apache Cordova board report for March.

2018-03-17 Thread Steven Gill
Hey all, please review the board report at
https://github.com/apache/cordova-apache-board-reports/pull/10

This is actually overdue. So I'll probably be submitting it this evening.

Cheers,
-Steve


Re: Translation Bankruptcy?

2018-02-28 Thread Steven Gill
Created an issue for this: https://issues.apache.org/jira/browse/CB-13931

On Tue, Feb 27, 2018 at 1:41 PM, Jesse <purplecabb...@gmail.com> wrote:

> +1 to bankruptcy
>
> The translation system was designed at a time where we had major
> contributions from google, ibm, intel, microsoft ... which sadly has fallen
> off.
>
> We should encourage community member to provide their own translations, via
> their own sites.  I believe Monaca has a considerable about of Japanese
> material.
>
>
>
>
> @purplecabbage
> risingj.com
>
> On Tue, Feb 27, 2018 at 1:25 PM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
> > I agree with your suggestion Jan. I don't think we as a project have the
> > resources to manage translations. The process in place today is not being
> > used and the translations are horribly out of date.
> >
> > I think it is best to remove the translations from the docs site
> >
> > On Tue, Feb 27, 2018 at 12:27 PM, Jan Piotrowski <piotrow...@gmail.com>
> > wrote:
> >
> > > Hi Andrey,
> > >
> > > you are certainly not wrong. While cleaning up cordova-docs
> > > documentation (about how to develop and build the documentation
> > > website) I found many bits and pieces of processes that seem to have
> > > worked one time, including many things about translations. I don't
> > > know why or when this all got broken by what changes and what the plan
> > > was back then.
> > >
> > > So I just collected all that content at
> > > https://github.com/apache/cordova-docs/blob/master/doc/translate.md
> > >
> > > But as this unfortunately doesn't seem to have been used in the last
> > > ~2 years, the current state is - in my opinion - too broken to fix
> > > (without major effort).
> > >
> > > Best,
> > > Jan
> > >
> > > 2018-02-27 19:18 GMT+01:00 Andrey Kurdumov <kant2...@googlemail.com>:
> > > > From my perspective, as a person who was trying to do translation of
> > > Russian language alone, translation is already bankrupted after new
> docs
> > > website design was implemented.
> > > > The reason for my opinion was following
> > > > - Documentation website was changed without thinking that keep
> > > translation intact is difficult. As a result it was broken
> > > > - People who change generation of website seriously think that
> machine
> > > translated content is usable. I recommend them read in Chinese recent
> > > articles in computational biology, or for example latest news about
> > > politics each day and try to understand not ‘idea’ of what’s going on,
> > but
> > > actually understand details.
> > > > - All tools which I create to support quick iteration of translations
> > > has to be rewritten in the new implementation and now has to be
> > > re-implemented.
> > > > - During migration all files was changed location and has to be
> > > revalidated again for whole docs
> > > >
> > > > If documentation website would not be touched, and if any change in
> > > implementation of docs website could be vetoed by people who do
> > > localization, I don’t see point investing time in the localization to
> my
> > > native language again. If I finish Russian , I could start translating
> to
> > > Ukrainian after that, since this is language which I also know
> relatively
> > > good.
> > > >
> > > > Translation is time consuming, and if such efforts would be discarded
> > > just for pure change of internal implementation, there no reason to
> even
> > > try.
> > > >
> > > > Sent from Mail for Windows 10
> > > >
> > > > From: Jan Piotrowski
> > > > Sent: Tuesday, February 27, 2018 7:22 PM
> > > > To: dev
> > > > Subject: Translation Bankruptcy?
> > > >
> > > > Hi all,
> > > >
> > > > while doing some work on cordova-docs I also took a look at the
> > > > translations again.
> > > >
> > > > Translations are (theoretically) done on Crowdin, synced from and to
> > > Github:
> > > > https://crowdin.com/project/cordova
> > > >
> > > > Unfortunately this doesn't really seem to work:
> > > >
> > > > 1. There is no (working) documentation on how to import or export
> > > > files from or to Crowdin:
> > > > https://github.com/apache/cordova-docs/blob/maste

Re: Translation Bankruptcy?

2018-02-27 Thread Steven Gill
I agree with your suggestion Jan. I don't think we as a project have the
resources to manage translations. The process in place today is not being
used and the translations are horribly out of date.

I think it is best to remove the translations from the docs site

On Tue, Feb 27, 2018 at 12:27 PM, Jan Piotrowski 
wrote:

> Hi Andrey,
>
> you are certainly not wrong. While cleaning up cordova-docs
> documentation (about how to develop and build the documentation
> website) I found many bits and pieces of processes that seem to have
> worked one time, including many things about translations. I don't
> know why or when this all got broken by what changes and what the plan
> was back then.
>
> So I just collected all that content at
> https://github.com/apache/cordova-docs/blob/master/doc/translate.md
>
> But as this unfortunately doesn't seem to have been used in the last
> ~2 years, the current state is - in my opinion - too broken to fix
> (without major effort).
>
> Best,
> Jan
>
> 2018-02-27 19:18 GMT+01:00 Andrey Kurdumov :
> > From my perspective, as a person who was trying to do translation of
> Russian language alone, translation is already bankrupted after new docs
> website design was implemented.
> > The reason for my opinion was following
> > - Documentation website was changed without thinking that keep
> translation intact is difficult. As a result it was broken
> > - People who change generation of website seriously think that machine
> translated content is usable. I recommend them read in Chinese recent
> articles in computational biology, or for example latest news about
> politics each day and try to understand not ‘idea’ of what’s going on, but
> actually understand details.
> > - All tools which I create to support quick iteration of translations
> has to be rewritten in the new implementation and now has to be
> re-implemented.
> > - During migration all files was changed location and has to be
> revalidated again for whole docs
> >
> > If documentation website would not be touched, and if any change in
> implementation of docs website could be vetoed by people who do
> localization, I don’t see point investing time in the localization to my
> native language again. If I finish Russian , I could start translating to
> Ukrainian after that, since this is language which I also know relatively
> good.
> >
> > Translation is time consuming, and if such efforts would be discarded
> just for pure change of internal implementation, there no reason to even
> try.
> >
> > Sent from Mail for Windows 10
> >
> > From: Jan Piotrowski
> > Sent: Tuesday, February 27, 2018 7:22 PM
> > To: dev
> > Subject: Translation Bankruptcy?
> >
> > Hi all,
> >
> > while doing some work on cordova-docs I also took a look at the
> > translations again.
> >
> > Translations are (theoretically) done on Crowdin, synced from and to
> Github:
> > https://crowdin.com/project/cordova
> >
> > Unfortunately this doesn't really seem to work:
> >
> > 1. There is no (working) documentation on how to import or export
> > files from or to Crowdin:
> > https://github.com/apache/cordova-docs/blob/master/doc/translate.md
> >
> > 2. There is no way to figure out the current state of the translations
> > vs. the actual documentation.
> > 3. From looking at the languages I understand: Translations are _very_
> > outdated vs. the actual documentation.
> >
> > 4. There are translated files for files that do not exist in English any
> more:
> > https://issues.apache.org/jira/browse/CB-13161
> >
> > 5. There seem to be lots of auto translated bits in different
> > languages, also Source Code and other technical stuff was
> > (automatically) translated in several languages:
> > https://issues.apache.org/jira/browse/CB-11414
> >
> > To summarize:
> > No translating is happening because of the above facts. The current
> > translations are out of date, unmaintained, contra productive or even
> > misleading.
> >
> > My suggestion:
> > Let's just face it and declare translation bankruptcy.
> >
> > We remove all translated content from the docs repo (latest + dev
> > version only) and redirect each link to the matching English version.
> >
> > Agree?
> > Disagree?
> > Suggestions?
> >
> > Best,
> > Jan
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


[DISCUSS] cordova-android@7.1.0 released!

2018-02-27 Thread Steven Gill
Blog:
https://cordova.apache.org/announcements/2018/02/26/cordova-android-7.1.0.html
Tweet: https://twitter.com/apachecordova/status/968556516247715841


Re: [DISCUSS] cordova-android release

2018-02-23 Thread Steven Gill
Please review the blog post: https://github.com/apache/cordova-docs/pull/789

On Tue, Feb 20, 2018 at 2:05 PM, Joe Bowser <bows...@gmail.com> wrote:

> +1
>
> On Feb 20, 2018 9:19 AM, "Jan Piotrowski" <piotrow...@gmail.com> wrote:
>
> > +1 Looking good.
> >
> > 2018-02-20 19:53 GMT+01:00 Steven Gill <stevengil...@gmail.com>:
> > > Issue: https://issues.apache.org/jira/browse/CB-13912
> > >
> > > I'm thinking minor bump to 7.1.0. You can see the change log in the
> > > comments of the issue
> > >
> > > On Sat, Feb 17, 2018 at 1:51 PM, Simon MacDonald <
> > simon.macdon...@gmail.com>
> > > wrote:
> > >
> > >> +1
> > >>
> > >> The change is super useful for Android 4.4 devices.
> > >>
> > >> On Fri, Feb 16, 2018 at 17:48 gandhi rajan <gandhiraja...@gmail.com>
> > >> wrote:
> > >>
> > >> > +1
> > >> >
> > >> > On Saturday, February 17, 2018, Steven Gill <stevengil...@gmail.com
> >
> > >> > wrote:
> > >> >
> > >> > > cordova-android release. Going to do a minor or patch release for
> > >> > android.
> > >> > > Any issues or concerns?
> > >> > >
> > >> >
> > >> >
> > >> > --
> > >> > Regards,
> > >> > Gandhi
> > >> >
> > >> > "The best way to find urself is to lose urself in the service of
> > others
> > >> > !!!"
> > >> >
> > >> --
> > >> Simon Mac Donald
> > >> http://simonmacdonald.com
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [Vote] 7.1.0 Android Release

2018-02-23 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3

Jesse MacFadyen
Steven Gill
Simon MacDonald

The vote has passed.

Thank you all.

On Thu, Feb 22, 2018 at 11:55 AM, Jesse <purplecabb...@gmail.com> wrote:

> I vote +1
> * Ran coho audit-license-headers
> * Ran coho check-license
> * Created a test app and successfully built it
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Feb 22, 2018 at 8:05 AM, Simon MacDonald <
> simon.macdon...@gmail.com>
> wrote:
>
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Created a test app and added push plugin. Successfully received push
> > notifications.
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Wed, Feb 21, 2018 at 4:46 PM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > Please review and vote on this 7.1.0 Android Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-13912
> > >
> > > The archive has been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13912
> > >
> > > The package was published from its corresponding git tag:
> > > cordova-android: 7.1.0 (f7d122bd8e)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add https://github.com/apache/
> cordova-android#7.1.0
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> > > to npm, and post the blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ensured continuous build was green when repo was tagged
> > > * Ran through testing section at
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > > platforms-release-process.md#what-to-test
> > >
> >
>


Re: [VOTE] Cordova-Windows@6.0.0 Release

2018-02-21 Thread Steven Gill
I vote +1

* Ran coho verify-archive
* Ran coho audit-license-headers
* Ran coho check-license
* ran npm test

On Tue, Feb 20, 2018 at 2:51 PM, Jan Piotrowski 
wrote:

> Please review and vote on this 6.0.0 Windows Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-13896
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-13896
>
> The package was published from its corresponding git tag:
> cordova-windows: 6.0.0 (c40fedff1a)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-windows#6.0.0
>
> Upon a successful vote I will upload the archive to dist/, publish it
> to npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * Ran npm test in cordova-windows
> * Ran mobile-spec tests and observed numerous (but expected) failures
> * Created, built and ran a project with the /bin scripts
> * Created, built and ran a project / hello world app using the CLI
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


[Vote] 7.1.0 Android Release

2018-02-21 Thread Steven Gill
Please review and vote on this 7.1.0 Android Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13912

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13912

The package was published from its corresponding git tag:
cordova-android: 7.1.0 (f7d122bd8e)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-android#7.1.0

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* Ran through testing section at
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#what-to-test


Re: [DISCUSS] cordova-android release

2018-02-20 Thread Steven Gill
Issue: https://issues.apache.org/jira/browse/CB-13912

I'm thinking minor bump to 7.1.0. You can see the change log in the
comments of the issue

On Sat, Feb 17, 2018 at 1:51 PM, Simon MacDonald <simon.macdon...@gmail.com>
wrote:

> +1
>
> The change is super useful for Android 4.4 devices.
>
> On Fri, Feb 16, 2018 at 17:48 gandhi rajan <gandhiraja...@gmail.com>
> wrote:
>
> > +1
> >
> > On Saturday, February 17, 2018, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > cordova-android release. Going to do a minor or patch release for
> > android.
> > > Any issues or concerns?
> > >
> >
> >
> > --
> > Regards,
> > Gandhi
> >
> > "The best way to find urself is to lose urself in the service of others
> > !!!"
> >
> --
> Simon Mac Donald
> http://simonmacdonald.com
>


Re: cordova-fetch Pull Request to fix CB-13503 problems with using plugins from local file system

2018-02-16 Thread Steven Gill
Thanks Thomas! I'll take a look at the PR

On Fri, Feb 16, 2018 at 2:03 PM, Thomas Brian  wrote:

> Hello everyone,
>
> I was updating one of our projects from Cordova 6.5 to Cordova 8.0 this
> week and I ran into the same issue as described in CB-13503 that prevents
> local plugins from working properly when using cordova-fetch (
> https://issues.apache.org/jira/browse/CB-13503)
>
> I tried to dig into the problem and I think I have a working fix, so I
> published it as PR #13 on GitHub: https://github.com/apache/cord
> ova-fetch/pull/13. Talking to Jan Piotrowski on the slack channel, he
> suggested that I also bring attention to it on this Mailing-List.
>
> Specifically, this PR adds support for plugins added to package.json with
> the syntax "my-plugin": "file:path/to/plugin". The trimID function did not
> support those previously, since it tried to form a path with "target" +
> "package.json" ("file:path/to/plugin/package.json") and used this path in
> fs.existsSync, which failed because this function does not expect a file:
> prefix.
>
> I also added a test case that should reproduce the bug. It fetches the
> plugin twice, because the first install doesn't trigger the trimID function
> since the getJsonDiff works as expected the first time, and it only falls
> back to trimID on the second run.
>
> Please let me know if you have any questions or concerns regarding this
> pull request. I will also try to monitor the PR on GitHub.
>
> Have a nice day,
> Thomas
> --
> Thomas Brian
> Développeur Frontend
> Frontend Developer
> tbr...@tobostudio.com 
> www.tobostudio.com 
>


[DISCUSS] cordova-android release

2018-02-16 Thread Steven Gill
cordova-android release. Going to do a minor or patch release for android.
Any issues or concerns?


Re: [DISCUSS] cordovaDependencies section in core plugins

2018-01-03 Thread Steven Gill
I also think it should be removed.

On Jan 3, 2018 8:06 PM, "julio cesar sanchez" 
wrote:

> I'm +1 on removing it, we added it to avoid errors and we ended with errors
> because of it.
>
> BTW, as the plugin versions were bumped because of some platforms code
> removal in them, should we set the dependencies to only allow the install
> of latest version of that plugins in Cordova 8 as that's the one that
> removed the platforms? If not, people with older projects and the
> deprecated platforms will get that version without the platform code.
>
>
> 2018-01-03 15:07 GMT+01:00 Simon MacDonald :
>
> > Going back and reading my original email I feel like I wasn't clear.
> > Specifically I was wondering if we really need something like:
> >
> > "4.0.0": {
> > "cordova": ">100"
> > }
> >
> > in all of the plugins?
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> >
> > On Tue, Jan 2, 2018 at 9:16 PM, Shazron  wrote:
> > > 1. Seems like a typo, let's find all the ones with typos and update to
> > > reasonable values or remove it for the plugin if its not valid.
> > > 2. I believe we need it. Some plugins have hard requirements:
> > > https://github.com/phonegap/phonegap-plugin-push/blob/
> > f6e0dccfb2a6906c37b5f89f2d2170c3ff420d97/package.json#L33-L60
> > >
> > >
> > > On Wed, Jan 3, 2018 at 2:04 AM, julio cesar sanchez <
> > jcesarmob...@gmail.com>
> > > wrote:
> > >
> > >> For reference, this is the mail discussion about adding it
> > >> https://lists.apache.org/thread.html/cee101266d23a66d57e096da0b613f
> > >> edd6e5572b2a101f5a4d4062c2@%3Cdev.cordova.apache.org%3E
> > >>
> > >> 2018-01-02 18:56 GMT+01:00 Simon MacDonald  >:
> > >>
> > >> > Hey all,
> > >> >
> > >> > Recently we updated most of the core plugins to new major version.
> > >> > Unfortunately we forgot to update the "cordovaDependencies" section
> in
> > >> > package.json which prevents the next major version from being
> > >> > installed.
> > >> >
> > >> > For instance we bumped cordova-plugin-camera to version 4.0.0 but
> > >> > package.json still had:
> > >> >
> > >> > "engines": {
> > >> >   "cordovaDependencies": {
> > >> > "3.0.0": {
> > >> >"cordova-android": ">=6.3.0"
> > >> > },
> > >> > "4.0.0": {
> > >> >   "cordova": ">100"
> > >> > }
> > >> >   }
> > >> > }
> > >> >
> > >> > so that prevented anyone not running cordova CLI version greater
> than
> > >> > 100 from installing via NPM. Since we are still at cordova 8.x this
> > >> > means no one could install the new plugin releases from NPM.
> > >> >
> > >> > Thank goodness Julio was paying attention over the holiday season
> and
> > >> > was able to get the ball rolling to fix the issue and get a bunch of
> > >> > point releases of the core plugins released so folks would not be
> > >> > stuck in the new year.
> > >> >
> > >> > My questions are:
> > >> >
> > >> > 1) How do we prevent this from happening in the future? Should we
> > >> > document that this change needs to be made?
> > >> > 2) Do we even need this section of package.json? What purpose does
> it
> > >> hold?
> > >> >
> > >> > Thanks…
> > >> >
> > >> > Simon Mac Donald
> > >> > http://simonmacdonald.com
> > >> >
> > >> > 
> -
> > >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >> > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >> >
> > >> >
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [VOTE] Cordova-browser@5.0.3 release

2017-12-27 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3
Simon MacDonald
Steve Gill
Suraj Pindoria

The vote has passed.


On Wed, Dec 20, 2017 at 1:21 PM, Simon MacDonald <simon.macdon...@gmail.com>
wrote:

> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran npm test in cordova-browser
> * Created hello world app via cli
>
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Wed, Dec 20, 2017 at 4:11 PM, Suraj Pindoria <pindoria.su...@gmail.com>
> wrote:
>
> > I vote +1:
> >
> > * ran coho audit-license-headers
> > * ran coho check-license
> > * added and ran platform on new project
> >
> > > On Dec 20, 2017, at 12:45, Steven Gill <stevengil...@gmail.com> wrote:
> > >
> > > Please review and vote on this 5.0.3 Browser Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-13689
> > >
> > > The archive has been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13689
> > >
> > > The package was published from its corresponding git tag:
> > >cordova-browser: 5.0.3 (94f95913ee)
> > >
> > > Note that you can test it out via:
> > >
> > >cordova platform add https://github.com/apache/
> cordova-browser#5.0.3
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> > > to npm, and post the blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Built hello world app via cli
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [DISCUSS] Plugins release

2017-12-27 Thread Steven Gill
+1

On Wed, Dec 27, 2017 at 10:40 AM, julio cesar sanchez <
jcesarmob...@gmail.com> wrote:

> The plugins to be released are:
>
> cordova-plugin-vibration: 3.0.1
> cordova-plugin-screen-orientation: 3.0.1
> cordova-plugin-splashscreen: 5.0.1
> cordova-plugin-media: 5.0.1
> cordova-plugin-media-capture: 3.0.1
> cordova-plugin-network-information: 2.0.1
> cordova-plugin-file: 6.0.1
> cordova-plugin-geolocation: 4.0.1
> cordova-plugin-device: 2.0.1
> cordova-plugin-dialogs: 2.0.1
> cordova-plugin-battery-status: 2.0.1
> cordova-plugin-camera: 4.0.1
> cordova-plugin-inappbrowser: 2.0.1
>
> I also updated this one because of another issue
> cordova-plugin-statusbar: 2.4.1
>
> I'm +1 on releasing them before people start complaining about not being
> able to get latest version
>
>
>
> 2017-12-27 19:23 GMT+01:00 Simon MacDonald :
>
> > Hey all,
> >
> > Any issues with doing a patch release for the plugins? All of the major
> > version bumps we did for:
> >
> > cordova-plugin-battery-status: 2.0.0 (8f1872cd45)
> > cordova-plugin-camera: 4.0.0 (4ae0de1c5e)
> > cordova-plugin-contacts: 3.0.1 (cfdffed461)
> > cordova-plugin-device: 2.0.0 (753f956da4)
> > cordova-plugin-dialogs: 2.0.0 (839eb34d06)
> > cordova-plugin-file: 6.0.0 (957e1dcb22)
> > cordova-plugin-geolocation: 4.0.0 (0f5868057f)
> > cordova-plugin-globalization: 1.0.9 (a7b978f4a5)
> > cordova-plugin-inappbrowser: 2.0.0 (d85991accb)
> > cordova-plugin-media: 5.0.0 (4a7b55cceb)
> > cordova-plugin-media-capture: 3.0.0 (52cfcf1052)
> > cordova-plugin-network-information: 2.0.0 (2cfc366c2a)
> > cordova-plugin-splashscreen: 5.0.0 (36bf91c9e8)
> > cordova-plugin-statusbar: 2.4.0 (caf2ae6605)
> > cordova-plugin-screen-orientation: 3.0.0 (044e8cc728)
> > cordova-plugin-vibration: 3.0.0 (e6be96084f)
> >
> > cannot be installed from npm due to an issue in package.json. The fix is
> > already in place thanks to Julio.
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
>


[ANNOUNCE] Plugins Release

2017-12-20 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/943624619562381312
Blog: https://cordova.apache.org/news/2017/12/20/plugins-release.html


Re: [DISCUSS] Browser Release

2017-12-20 Thread Steven Gill
Needed to do a quick 5.0.3 since I didn't merge master into 5.0.x branch.
5.0.2 doesn't have the fixes we wanted in it :(.

On Mon, Dec 18, 2017 at 10:51 AM, Simon MacDonald <simon.macdon...@gmail.com
> wrote:

> Yup, let's do it.
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Mon, Dec 18, 2017 at 1:37 PM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
> > Doing a small patch release for browser to fix the asset tag issue.
> >
>


[VOTE] Cordova-browser@5.0.3 release

2017-12-20 Thread Steven Gill
Please review and vote on this 5.0.3 Browser Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13689

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13689

The package was published from its corresponding git tag:
cordova-browser: 5.0.3 (94f95913ee)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-browser#5.0.3

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Built hello world app via cli


Re: [DISCUSS] Plugins Release

2017-12-20 Thread Steven Gill
Please review blog post https://github.com/apache/cordova-docs/pull/778

On Mon, Dec 18, 2017 at 10:36 AM, Steven Gill <stevengil...@gmail.com>
wrote:

> Looks like media and media-capture need to be fixed due to me not updating
> the dependency on the file plugin. Vote on the rest of the plugins and i'll
> send out a new vote thread just for those two.
>
> On Thu, Dec 14, 2017 at 9:50 PM, Joe Bowser <bows...@gmail.com> wrote:
>
>> Same, I would like to see everything pushed out before the new year.  With
>> the break and sabbaticals (Steve on Jan, me on Feb), I would like to see
>> things out when there's all hands on deck.
>>
>> On Thu, Dec 14, 2017 at 9:03 PM, Simon MacDonald <
>> simon.macdon...@gmail.com>
>> wrote:
>>
>> > Yeah, let's get a plugin release out before a lot of us take off on
>> > vacation.
>> >
>> > Simon Mac Donald
>> > http://simonmacdonald.com
>> >
>> > On Thu, Dec 14, 2017 at 8:58 PM, Shazron <shaz...@gmail.com> wrote:
>> >
>> > > The release train for plugins shouldn't be stopped since we do
>> infrequent
>> > > releases. Plugins not on this train will be on the next one.
>> > >
>> > > On Fri, Dec 15, 2017 at 7:43 AM, Steven Gill <stevengil...@gmail.com>
>> > > wrote:
>> > >
>> > > > I was going to do whichever ones were ready. Want to get them out
>> > before
>> > > > the holidays. I'll review some prs for it today and aim to do a
>> release
>> > > > tomorrow.
>> > > >
>> > > > Adobe is shutdown Dec 22 - Jan 2. I'm also going to be gone the
>> month
>> > of
>> > > > January for Sabbatical.
>> > > >
>> > > > On Thu, Dec 14, 2017 at 2:09 PM, julio cesar sanchez <
>> > > > jcesarmob...@gmail.com
>> > > > > wrote:
>> > > >
>> > > > > All of them?
>> > > > >
>> > > > > I have this pending PR
>> > > > > <https://github.com/apache/cordova-plugin-statusbar/pull/91>
>> waiting
>> > > to
>> > > > be
>> > > > > merged, I was planning on doing it this weekend. It removes old
>> iOS
>> > 6-7
>> > > > > code from statusbar plugin. And then I was planning on deprecating
>> > some
>> > > > of
>> > > > > StatusBar.styleLightContent, StatusBar.styleBlackTranslucent and
>> > > > > StatusBar.styleBlackOpaque as all 3 of them do the exact same
>> thing
>> > > now.
>> > > > >
>> > > > > This one <https://github.com/apache/cor
>> dova-plugin-statusbar/pull/67
>> > >
>> > > > > about
>> > > > > adding browser support looks interesting, but somebody with more
>> > > > experience
>> > > > > in browser platform should review it.
>> > > > >
>> > > > > I was also planning on removing some code (the deprecated
>> > UIAlertView)
>> > > > from
>> > > > > dialogs plugin.
>> > > > >
>> > > > >
>> > > > >
>> > > > > 2017-12-14 22:52 GMT+01:00 Steven Gill <stevengil...@gmail.com>:
>> > > > >
>> > > > > > Any issues with me doing a plugins release?
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>
>


Re: [VOTE] Cordova-Browser@5.0.2 Release

2017-12-20 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Jesse MacFadyen
Simon MacDonald

The vote has passed.


On Tue, Dec 19, 2017 at 11:36 AM, Jesse <purplecabb...@gmail.com> wrote:

> I vote +1:
> * Ran coho verify-archives
> * Ran coho audit-license-headers
> * Ran coho check-license
> * Ran npm test in cordova-browser  23 specs, 0 failures
> * Created hello world app via cli
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Dec 18, 2017 at 7:35 PM, Simon MacDonald <
> simon.macdon...@gmail.com>
> wrote:
>
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ran npm test in cordova-browser
> > * Created hello world app via cli
> >
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Mon, Dec 18, 2017 at 2:37 PM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > Please review and vote on this 5.0.2 Browser Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-13689
> > >
> > > The archive has been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13689
> > >
> > > The package was published from its corresponding git tag:
> > > cordova-browser: 5.0.2 (3d3149377c)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add https://github.com/apache/
> cordova-browser#5.0.2
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> > > to npm, and post the blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ran npm test in cordova-browser
> > > * Created hello world app via cli
> > >
> >
>


Re: [VOTE] Plugins release for media and media-capture

2017-12-20 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Vishal Mishra
Simon MacDonald

The vote has passed.


On Tue, Dec 19, 2017 at 11:29 AM, Vishal Mishra <vismi...@adobe.com.invalid>
wrote:

> I vote +1:
>
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Added and removed media and media-capture plugins to a sample project
>
>
> Vishal Mishra
>
> On 12/18/17, 7:10 PM, "Simon MacDonald" <simon.macdon...@gmail.com> wrote:
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Added media and media-capture to sample project
>
>
> Simon Mac Donald
> https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fsimonmacdonald.com=02%7C01%7Cvismishr%40adobe.com%
> 7Ca44336f6f41d41f7821608d5468e0d71%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636492498279518808=ke7jPDtqj3p7X0BzudyPrxRNwd%
> 2Bm70mz%2FVW6tMhyaPY%3D=0
>
> On Mon, Dec 18, 2017 at 2:07 PM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
> > Please review and vote on the release of this plugins release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13681=02%7C01%7Cvismishr%40adobe.com%7Ca44336f6f41d41f7821608d5468e
> 0d71%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636492498279518808=%2FUoqL%2FitpKpq8yVPWM%
> 2FzMAenx%2BPYnpxvWuQamM1Obi4%3D=0
> >
> > The plugins have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13681/
> >
> > The packages were published from their corresponding git tags:
> >
> > cordova-plugin-media: 5.0.0 (f4b82af06d)
> > cordova-plugin-media-capture: 3.0.0 (41129a64f4)
> >
> > Upon a successful vote I will upload the archives to dist/, upload
> > them to npm, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7Cvismishr%40adobe.com%
> 7Ca44336f6f41d41f7821608d5468e0d71%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636492498279518808=2B3%2FiJb9323ziK8GB2z5X0H9dQD%
> 2Fj%2F2c5lRtqbZPRK4%3D=0
> > How to vote on a plugins release at
> > https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%
> 2Fblob%2Fmaster%2Fdocs%2F=02%7C01%7Cvismishr%40adobe.com%
> 7Ca44336f6f41d41f7821608d5468e0d71%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636492498279518808=KNRn4nsVVqrUztS%2FFtuRSjhq9%
> 2BAxRpOKoosG%2FIW2yCE%3D=0
> > plugins-release-process.md#voting
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> >
>
>
>


Re: [VOTE] Plugins Release

2017-12-20 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Audrey So
Simon MacDonald

The vote has passed.


On Mon, Dec 18, 2017 at 11:14 AM, Simon MacDonald <simon.macdon...@gmail.com
> wrote:

> I vote +1:
>
> * Added and removed relevant plugins to hello world app
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
>
> for:
>
> cordova-plugin-battery-status: 2.0.0 (8f1872cd45)
> cordova-plugin-camera: 4.0.0 (4ae0de1c5e)
> cordova-plugin-contacts: 3.0.1 (cfdffed461)
> cordova-plugin-device: 2.0.0 (753f956da4)
> cordova-plugin-dialogs: 2.0.0 (839eb34d06)
> cordova-plugin-file: 6.0.0 (957e1dcb22)
> cordova-plugin-geolocation: 4.0.0 (0f5868057f)
> cordova-plugin-globalization: 1.0.9 (a7b978f4a5)
> cordova-plugin-inappbrowser: 2.0.0 (d85991accb)
> cordova-plugin-network-information: 2.0.0 (2cfc366c2a)
> cordova-plugin-splashscreen: 5.0.0 (36bf91c9e8)
> cordova-plugin-statusbar: 2.4.0 (caf2ae6605)
> cordova-plugin-screen-orientation: 3.0.0 (044e8cc728)
> cordova-plugin-vibration: 3.0.0 (e6be96084f)
>
>
> I vote -1 for:
>
> cordova-plugin-media: 5.0.0 (4a7b55cceb)
> cordova-plugin-media-capture: 3.0.0 (52cfcf1052)
>
> which need an updated commit to install correctly.
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Mon, Dec 18, 2017 at 1:59 PM, Audrey So <a...@adobe.com.invalid> wrote:
>
> > I vote +1:
> > * Added and removed relevant plugins to hello world app
> >
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> >
> >
> >
> >
> >
> > On 12/15/17, 5:37 PM, "Steven Gill" <stevengil...@gmail.com> wrote:
> >
> > >Please review and vote on the release of this plugins release
> > >by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13681=02%7C01%7Causo%40adobe.com%7Cbab47da7e60e431d639c08d54425
> ab52%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636489850939480303=
> > b98ht5hLtPx8uJEuT1ond4%2FySa4dClRlLilS2IF3dNk%3D=0
> > >
> > >The plugins have been published to
> > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13681/
> > >
> > >The packages were published from their corresponding git tags:
> > >cordova-plugin-battery-status: 2.0.0 (8f1872cd45)
> > >cordova-plugin-camera: 4.0.0 (4ae0de1c5e)
> > >cordova-plugin-contacts: 3.0.1 (cfdffed461)
> > >cordova-plugin-device: 2.0.0 (753f956da4)
> > >cordova-plugin-dialogs: 2.0.0 (839eb34d06)
> > >cordova-plugin-file: 6.0.0 (957e1dcb22)
> > >cordova-plugin-geolocation: 4.0.0 (0f5868057f)
> > >cordova-plugin-globalization: 1.0.9 (a7b978f4a5)
> > >cordova-plugin-inappbrowser: 2.0.0 (d85991accb)
> > >cordova-plugin-media: 5.0.0 (4a7b55cceb)
> > >cordova-plugin-media-capture: 3.0.0 (52cfcf1052)
> > >cordova-plugin-network-information: 2.0.0 (2cfc366c2a)
> > >cordova-plugin-splashscreen: 5.0.0 (36bf91c9e8)
> > >cordova-plugin-statusbar: 2.4.0 (caf2ae6605)
> > >cordova-plugin-screen-orientation: 3.0.0 (044e8cc728)
> > >cordova-plugin-vibration: 3.0.0 (e6be96084f)
> > >
> > >Upon a successful vote I will upload the archives to dist/, upload
> > >them to npm, and post the corresponding blog post.
> > >
> > >Voting guidelines:
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md=02%7C01%7Causo%40adobe.com%
> > 7Cbab47da7e60e431d639c08d54425ab52%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636489850939480303=BBorwhnXue%2Fkffi9aqBdG%
> > 2FzKPjuJz6wnGZ84G7j6qd0%3D=0
> > >How to vote on a plugins release at
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Fplugins-release-process.md%23voting=02%7C01%7Causo%40adobe.com%
> > 7Cbab47da7e60e431d639c08d54425ab52%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636489850939480303=MzCTGxJyZbQeI1TiU5LiL4qoc1mDa0
> > 9zXj%2B1TbTQdW8%3D=0
> > >
> > >Voting will go on for a minimum of 48 hours.
> > >
> > >I vote +1:
> > >* Ran coho audit-license-headers over the relevant repos
> > >* Ran coho check-license to ensure all dependencies and
> > >subdependencies have Apache-compatible licenses
> > >* Ensured continuous build was green when repos were tagged
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>


[ANNOUNCE] Cordova@8 + tools released

2017-12-19 Thread Steven Gill
Blog: https://cordova.apache.org/news/2017/12/18/tools-release.html
Tweet: https://twitter.com/apachecordova/status/943210561541570560


Re: [Vote] Tools Release

2017-12-19 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Audrey So
Suraj Pindoria

The vote has passed.


On Fri, Dec 15, 2017 at 3:02 PM, Suraj Pindoria <pindoria.su...@gmail.com>
wrote:

> I vote +1:
>
> - Ran npm test
> - Ran coho audit-license-headers
> - Ran coho check-license
> - Ran through
> https://github.com/apache/cordova-coho/blob/master/docs/
> tools-release-process.md#test
>
>
> On Fri, Dec 15, 2017 at 1:48 PM, Audrey So <a...@adobe.com.invalid> wrote:
>
> >
> > I vote +1:
> > * Ran npm test over relevant repos
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> >
> >
> >
> >
> >
> >
> >
> > On 12/14/17, 1:51 PM, "Steven Gill" <stevengil...@gmail.com> wrote:
> >
> > >Please review and vote on this Tools Release
> > >by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13674=02%7C01%7Causo%40adobe.com%7C905aefe54cabf43808d5433c
> eddd%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636488851324261584=
> > mzyCPCbmkUTXSa4gTdWU3%2BmD9mNFZoeKhzK6vb3UA3E%3D=0
> > >Both tools have been published to
> > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13674/
> > >
> > >The packages were published from their corresponding git tags:
> > >
> > >cordova-lib: 8.0.0 (81f0a8214a)
> > >cordova-plugman: 2.0.0 (9224753804)
> > >cordova-cli: 8.0.0 (0aacb29a6e)
> > >cordova-fetch: 1.3.0 (5c57f09e75)
> > >cordova-common: 2.2.1 (3bdc82251e)
> > >cordova-create: 1.1.2 (64f1385d69)
> > >
> > >Upon a successful vote I will upload the archives to dist/, publish
> > >them to npm, and post the corresponding blog post.
> > >
> > >Voting guidelines:
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md=02%7C01%7Causo%40adobe.com%
> > 7C905aefe54cabf43808d5433ceddd%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636488851324261584=aQv747TQWJ1WqDN%
> > 2FEQYDDh0TVrxidSTCZgW%2BIin2OmA%3D=0
> > >
> > >Voting will go on for a minimum of 48 hours.
> > >
> > >I vote +1:
> > >* Ran coho audit-license-headers over the relevant repos
> > >* Ran coho check-license to ensure all dependencies and
> > >subdependencies have Apache-compatible licenses
> > >* Ensured continuous build was green when repos were tagged
> > >* Ran through testing section at
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Ftools-release-process.md%23test=02%7C01%7Causo%40adobe.com%
> > 7C905aefe54cabf43808d5433ceddd%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636488851324261584=FQcJKpgyRGrffvKRkeFs%2Byt%
> > 2BN8KLPvZ2Icwo6Ym43RU%3D=0
> >
>


Re: [DISCUSS] cordova@8 & tools release

2017-12-18 Thread Steven Gill
Please review the tools release blog post.
https://github.com/apache/cordova-docs/pull/777

On Sat, Dec 16, 2017 at 5:20 PM, Terence M. Bandoian 
wrote:

> I just tested on Cordova 7.0.0 and was able to successfully add local
> plugins with and without the --no-fetch option.  Seems to have been fixed.
>
> -Terence
>
>
> On 12/13/2017 11:08 PM, Darryl Pogue wrote:
>
>> On Wed, Dec 13, 2017 at 6:15 PM, Terence M. Bandoian 
>> wrote:
>>
>>> Does removing '--no-fetch' apply to adding plugins?  I've recently had to
>>> use that option to get local plugins (file spec) added without hanging.
>>>
>> If there are cases where cordova-fetch is failing to install plugins,
>> please file bugs so we can know what they are.
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


[VOTE] Cordova-Browser@5.0.2 Release

2017-12-18 Thread Steven Gill
Please review and vote on this 5.0.2 Browser Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13689

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13689

The package was published from its corresponding git tag:
cordova-browser: 5.0.2 (3d3149377c)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-browser#5.0.2

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test in cordova-browser
* Created hello world app via cli


[VOTE] Plugins release for media and media-capture

2017-12-18 Thread Steven Gill
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13681

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13681/

The packages were published from their corresponding git tags:

cordova-plugin-media: 5.0.0 (f4b82af06d)
cordova-plugin-media-capture: 3.0.0 (41129a64f4)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses


[DISCUSS] Browser Release

2017-12-18 Thread Steven Gill
Doing a small patch release for browser to fix the asset tag issue.


Re: [DISCUSS] Plugins Release

2017-12-18 Thread Steven Gill
Looks like media and media-capture need to be fixed due to me not updating
the dependency on the file plugin. Vote on the rest of the plugins and i'll
send out a new vote thread just for those two.

On Thu, Dec 14, 2017 at 9:50 PM, Joe Bowser <bows...@gmail.com> wrote:

> Same, I would like to see everything pushed out before the new year.  With
> the break and sabbaticals (Steve on Jan, me on Feb), I would like to see
> things out when there's all hands on deck.
>
> On Thu, Dec 14, 2017 at 9:03 PM, Simon MacDonald <
> simon.macdon...@gmail.com>
> wrote:
>
> > Yeah, let's get a plugin release out before a lot of us take off on
> > vacation.
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Thu, Dec 14, 2017 at 8:58 PM, Shazron <shaz...@gmail.com> wrote:
> >
> > > The release train for plugins shouldn't be stopped since we do
> infrequent
> > > releases. Plugins not on this train will be on the next one.
> > >
> > > On Fri, Dec 15, 2017 at 7:43 AM, Steven Gill <stevengil...@gmail.com>
> > > wrote:
> > >
> > > > I was going to do whichever ones were ready. Want to get them out
> > before
> > > > the holidays. I'll review some prs for it today and aim to do a
> release
> > > > tomorrow.
> > > >
> > > > Adobe is shutdown Dec 22 - Jan 2. I'm also going to be gone the month
> > of
> > > > January for Sabbatical.
> > > >
> > > > On Thu, Dec 14, 2017 at 2:09 PM, julio cesar sanchez <
> > > > jcesarmob...@gmail.com
> > > > > wrote:
> > > >
> > > > > All of them?
> > > > >
> > > > > I have this pending PR
> > > > > <https://github.com/apache/cordova-plugin-statusbar/pull/91>
> waiting
> > > to
> > > > be
> > > > > merged, I was planning on doing it this weekend. It removes old iOS
> > 6-7
> > > > > code from statusbar plugin. And then I was planning on deprecating
> > some
> > > > of
> > > > > StatusBar.styleLightContent, StatusBar.styleBlackTranslucent and
> > > > > StatusBar.styleBlackOpaque as all 3 of them do the exact same thing
> > > now.
> > > > >
> > > > > This one <https://github.com/apache/cordova-plugin-statusbar/pull/
> 67
> > >
> > > > > about
> > > > > adding browser support looks interesting, but somebody with more
> > > > experience
> > > > > in browser platform should review it.
> > > > >
> > > > > I was also planning on removing some code (the deprecated
> > UIAlertView)
> > > > from
> > > > > dialogs plugin.
> > > > >
> > > > >
> > > > >
> > > > > 2017-12-14 22:52 GMT+01:00 Steven Gill <stevengil...@gmail.com>:
> > > > >
> > > > > > Any issues with me doing a plugins release?
> > > > > >
> > > > >
> > > >
> > >
> >
>


[VOTE] Plugins Release

2017-12-15 Thread Steven Gill
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13681

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13681/

The packages were published from their corresponding git tags:
cordova-plugin-battery-status: 2.0.0 (8f1872cd45)
cordova-plugin-camera: 4.0.0 (4ae0de1c5e)
cordova-plugin-contacts: 3.0.1 (cfdffed461)
cordova-plugin-device: 2.0.0 (753f956da4)
cordova-plugin-dialogs: 2.0.0 (839eb34d06)
cordova-plugin-file: 6.0.0 (957e1dcb22)
cordova-plugin-geolocation: 4.0.0 (0f5868057f)
cordova-plugin-globalization: 1.0.9 (a7b978f4a5)
cordova-plugin-inappbrowser: 2.0.0 (d85991accb)
cordova-plugin-media: 5.0.0 (4a7b55cceb)
cordova-plugin-media-capture: 3.0.0 (52cfcf1052)
cordova-plugin-network-information: 2.0.0 (2cfc366c2a)
cordova-plugin-splashscreen: 5.0.0 (36bf91c9e8)
cordova-plugin-statusbar: 2.4.0 (caf2ae6605)
cordova-plugin-screen-orientation: 3.0.0 (044e8cc728)
cordova-plugin-vibration: 3.0.0 (e6be96084f)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repos were tagged


Re: [DISCUSS] cordova@8 & tools release

2017-12-15 Thread Steven Gill
Just a heads up. One test is failing in cordova-lib for node 8. The fix was
landed in cordova-fetch (which is also being voted on)

On Wed, Dec 13, 2017 at 9:08 PM, Darryl Pogue  wrote:

> Given the number of times I've run into (and complained about) build
> failures due to unexpected npm version bugs, I'm 100% in favour of
> this.
>
>
> On Wed, Dec 13, 2017 at 6:15 PM, Terence M. Bandoian 
> wrote:
> > Does removing '--no-fetch' apply to adding plugins?  I've recently had to
> > use that option to get local plugins (file spec) added without hanging.
>
> If there are cases where cordova-fetch is failing to install plugins,
> please file bugs so we can know what they are.
>
>
> On Wed, Dec 13, 2017 at 8:14 PM, Rabindra Nayak
>  wrote:
> >
> > What could be functionalities  of new tool ? Any high level design in
> mind
> > ,If we are dropping  npm then where those templates will  come.
> >
> > Moreover tools like visual studio  17 Microsoft team has integrated
> Cordova
> > framework ,like that if we integrate cordova  tool in Android studio and
> > Xcode it could be useful ,again you people can see how far it is
> possible .
>
> This will not affect how end users install or use Cordova, nor should
> it affect tools like VS that integrate with Cordova.
>
> Currently cordova-lib has a package dependency on an old and
> unsupported version of npm (2.x). That means when you install Cordova
> using npm, it actually installs a second older copy of npm internally.
> That has caused problems for people (including myself) due to commands
> around Cordova sometimes using the system npm and sometimes using the
> older npm, and there are behaviour differences between the two
> versions.
>
> The proposal is for Cordova to stop depending on (and therefore stop
> installing) an older version of npm, and to rely on the system npm and
> the new cordova-fetch system.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: [DISCUSS] Plugins Release

2017-12-14 Thread Steven Gill
I was going to do whichever ones were ready. Want to get them out before
the holidays. I'll review some prs for it today and aim to do a release
tomorrow.

Adobe is shutdown Dec 22 - Jan 2. I'm also going to be gone the month of
January for Sabbatical.

On Thu, Dec 14, 2017 at 2:09 PM, julio cesar sanchez <jcesarmob...@gmail.com
> wrote:

> All of them?
>
> I have this pending PR
> <https://github.com/apache/cordova-plugin-statusbar/pull/91> waiting to be
> merged, I was planning on doing it this weekend. It removes old iOS 6-7
> code from statusbar plugin. And then I was planning on deprecating some of
> StatusBar.styleLightContent, StatusBar.styleBlackTranslucent and
> StatusBar.styleBlackOpaque as all 3 of them do the exact same thing now.
>
> This one <https://github.com/apache/cordova-plugin-statusbar/pull/67>
> about
> adding browser support looks interesting, but somebody with more experience
> in browser platform should review it.
>
> I was also planning on removing some code (the deprecated UIAlertView) from
> dialogs plugin.
>
>
>
> 2017-12-14 22:52 GMT+01:00 Steven Gill <stevengil...@gmail.com>:
>
> > Any issues with me doing a plugins release?
> >
>


[DISCUSS] Plugins Release

2017-12-14 Thread Steven Gill
Any issues with me doing a plugins release?


[Vote] Tools Release

2017-12-14 Thread Steven Gill
Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13674
Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13674/

The packages were published from their corresponding git tags:

cordova-lib: 8.0.0 (81f0a8214a)
cordova-plugman: 2.0.0 (9224753804)
cordova-cli: 8.0.0 (0aacb29a6e)
cordova-fetch: 1.3.0 (5c57f09e75)
cordova-common: 2.2.1 (3bdc82251e)
cordova-create: 1.1.2 (64f1385d69)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repos were tagged
* Ran through testing section at
https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test


[DRAFT] Apache Cordova Board Report - December 2017

2017-12-13 Thread Steven Gill
https://github.com/apache/cordova-apache-board-reports/pull/9

Please review. Needs to be submitted to board soon


[DISCUSS] cordova@8 & tools release

2017-12-12 Thread Steven Gill
Working on getting out a tools release

Doing cordova@8 because we are dropping support for blackberry, webos,
Ubuntu.

Also aiming to remove `--no-fetch` in this release and drop npm dependency
from cordova.

Lastly, `cordova save` command will be dropped in this release too

Any thoughts or feedback?


Re: [Vote] Cordova-common@2.2.0 Release

2017-11-27 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Joe Bowser
Simon MacDonald

The vote has passed.


On Thu, Nov 23, 2017 at 1:23 PM, Simon MacDonald <simon.macdon...@gmail.com>
wrote:

> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran npm test
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Thu, Nov 23, 2017 at 2:33 PM, Joe Bowser <bows...@gmail.com> wrote:
>
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ran npm test
> >
> > On Wed, Nov 22, 2017 at 8:42 PM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > Please review and vote on this cordova-common Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-13599
> > >
> > > Both tools have been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13599/
> > >
> > > The packages were published from their corresponding git tags:
> > >
> > > cordova-common: 2.2.0 (afc6185419)
> > >
> > > Upon a successful vote I will upload the archives to dist/, publish
> > > them to npm, and post the corresponding blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ran npm test
> > >
> >
>


[Vote] Cordova-common@2.2.0 Release

2017-11-22 Thread Steven Gill
Please review and vote on this cordova-common Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13599

Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13599/

The packages were published from their corresponding git tags:

cordova-common: 2.2.0 (afc6185419)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test


[Discuss] cordova common release

2017-11-21 Thread Steven Gill
We need to do a cordova common release in preparation for
cordova-android@7.0.0 release. Any objections?


Re: [Vote] 4.5.4 iOS Release

2017-11-20 Thread Steven Gill
I vote +1

Ran hello world app
ran coho verify archive

On Mon, Nov 20, 2017 at 12:56 PM, Audrey So  wrote:

> I vote +1:
> * Created helloworld using CLI and build scripts, deployed to emulator
> * Ran npm test,(passed)
>
> * Ran coho audit-license-headers
> * Ran coho check-license
>
>
>
>
>
> On 11/15/17, 2:27 PM, "Suraj Pindoria"  wrote:
>
> >Please review and vote on this 4.5.4 iOS Release by replying to this email
> >(and keep discussion on the DISCUSS thread)
> >
> >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13579=02%7C01%7C%7C8fdb37ead9994ab746d208d52c79283d%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463821230294178=
> nc7tIwg5LB3o6rr1l97kUeCQYJ04uMDorvHy%2F1xQnrM%3D=0
> >
> >The archive has been published to dist/dev:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%
> 2Fcordova%2FCB-13579=02%7C01%7C%7C8fdb37ead9994ab746d208d52c79283d%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463821230294178=
> bq36tF0a%2F4KRvNYVMmcoscx6o3N3bjAGID7wIEuNiYQ%3D=0
> >
> >The package was published from its corresponding git tag:
> > cordova-ios: 4.5.4 (acf91073e5)
> >
> >Note that you can test it out via:
> >
> > cordova platform add https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fgithub.com%
> 2Fapache%2Fcordova-ios%234.5.4=02%7C01%7C%
> 7C8fdb37ead9994ab746d208d52c79283d%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636463821230294178=Y%2Ft7rngdixUYGoORWOXTHcmm8PTiVr
> urRpZmxvvVC20%3D=0
> >
> >Upon a successful vote I will upload the archive to dist/, publish it to
> >npm, and post the blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7C8fdb37ead9994ab746d208d52c79283d%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463821230294178=
> vRXhzzoqt1LDibsMZJrb%2FjWqjRilnBx2Oa8zvhBJAeA%3D=0
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers
> >* Ran coho check-license
> >* Ensured continuous build was green when repo was tagged
> >* Created and tested against mobilespec
> >* Created helloworld using CLI and build scripts, deployed to
> >device/emulator
>


[ANNOUNCE] Plugins released Nov 10, 2017

2017-11-13 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/930233319370801152
Blog: http://cordova.apache.org/news/2017/11/10/plugins-release.html


[ANNOUNCE] Cordova-Android@6.4.0 released

2017-11-13 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/930241180280922112
Blog:
http://cordova.apache.org/announcements/2017/11/09/android-release.html


Re: [discuss] plugins release

2017-11-10 Thread Steven Gill
Blog post for review https://github.com/apache/cordova-docs/pull/758

On Thu, Nov 2, 2017 at 4:44 PM, Steven Gill <stevengil...@gmail.com> wrote:

> sweet
>
> On Thu, Nov 2, 2017 at 4:24 PM, julio cesar sanchez <
> jcesarmob...@gmail.com> wrote:
>
>> All my PRs are merged now.
>>
>> We should continue with the plugins release.
>>
>> 2017-10-19 2:05 GMT+02:00 Steven Gill <stevengil...@gmail.com>:
>>
>> > Yay! I'll review soon and make sure they make it in for the release
>> >
>> > On Wed, Oct 18, 2017 at 4:17 PM, Kelvin Dart <kelvin.da...@gmail.com>
>> > wrote:
>> >
>> > > cordova-plugin-compat has been removed and PRs for relevant plugins
>> has
>> > > been raised here:
>> > >
>> > > https://github.com/apache/cordova-plugin-camera/pull/293 <
>> > > https://github.com/apache/cordova-plugin-camera/pull/293>
>> > > https://github.com/apache/cordova-plugin-contacts/pull/156 <
>> > > https://github.com/apache/cordova-plugin-contacts/pull/156>
>> > > https://github.com/apache/cordova-plugin-file/pull/220 <
>> > > https://github.com/apache/cordova-plugin-file/pull/220>
>> > > https://github.com/apache/cordova-plugin-file-transfer/pull/192 <
>> > > https://github.com/apache/cordova-plugin-file-transfer/pull/192>
>> > > https://github.com/apache/cordova-plugin-geolocation/pull/96 <
>> > > https://github.com/apache/cordova-plugin-geolocation/pull/96>
>> > > https://github.com/apache/cordova-plugin-media/pull/151 <
>> > > https://github.com/apache/cordova-plugin-media/pull/151>
>> > > https://github.com/apache/cordova-plugin-media-capture/pull/85 <
>> > > https://github.com/apache/cordova-plugin-media-capture/pull/85>
>> > >
>> > > Kelvin
>> > >
>> > > > On 18 Oct 2017, at 08:57, julio cesar sanchez <
>> jcesarmob...@gmail.com>
>> > > wrote:
>> > > >
>> > > > I have some PRs that I've not merged because of Android tests
>> failing
>> > > (any
>> > > > of my PRs is for Android), not sure if it's ok to merge them.
>> > > >
>> > > > https://github.com/apache/cordova-plugin-camera/pull/291
>> > > > https://github.com/apache/cordova-plugin-geolocation/pull/94
>> > > > https://github.com/apache/cordova-plugin-media-capture/pull/83
>> > > > https://github.com/apache/cordova-plugin-media/pull/148
>> > > > https://github.com/apache/cordova-plugin-statusbar/pull/89
>> > > >
>> > > >
>> > > > 2017-10-18 9:33 GMT+02:00 Kelvin Dart <kelvin.da...@gmail.com>:
>> > > >
>> > > >> I will make these pulls later this afternoon. I'll respond here
>> with
>> > the
>> > > >> PRs when raised.
>> > > >>
>> > > >> Kelvin
>> > > >>
>> > > >>
>> > > >> Best regards,
>> > > >> Kelvin
>> > > >>
>> > > >> On 18 October 2017 at 00:25, Steven Gill <stevengil...@gmail.com>
>> > > wrote:
>> > > >>
>> > > >>> Going to try to start it later this week. Still waiting on a few
>> prs
>> > to
>> > > >>> come in around removing compat. May just make some of those
>> changes
>> > > >> myself.
>> > > >>> Going to look at doing a larger release this time.
>> > > >>>
>> > > >>> I know the following definitely need to go out.
>> > > >>>
>> > > >>> cordova-plugin-status-bar
>> > > >>> cordova-plugin-file-transfer
>> > > >>>
>> > > >>> Post the PRs i should be looking at.
>> > > >>>
>> > > >>
>> > >
>> > >
>> >
>>
>
>


Re: [VOTE] Plugins Release Nov 6, 2017

2017-11-09 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3
Steve Gill
Audrey So
Joe Bowser

The vote has passed.


On Thu, Nov 9, 2017 at 10:30 AM, Joe Bowser <bows...@gmail.com> wrote:

> I vote +1
>
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran mobilespec on Android
>
>
> On Tue, Nov 7, 2017 at 3:56 PM, Audrey So <a...@adobe.com.invalid> wrote:
>
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Added/removed plugins successfully on hello world app
> >
> >
> >
> >
> >
> > On 11/6/17, 4:47 PM, "Steven Gill" <stevengil...@gmail.com> wrote:
> >
> > >Please review and vote on the release of this plugins release
> > >by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13542=02%7C01%7C%7C79be3d4758654a06bf6808d525794081%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636456125059190144=
> > BfyawxPhwkYmEw8aNV5RCG8Dy9uf3baYzZ4ivq756%2Bo%3D=0
> > >
> > >The plugins have been published to
> > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13542/
> > >
> > >The packages were published from their corresponding git tags:
> > >cordova-plugin-battery-status: 1.2.5 (e336730d4b)
> > >cordova-plugin-camera: 3.0.0 (d456eeb711)
> > >cordova-plugin-contacts: 3.0.0 (a4d5e28e74)
> > >cordova-plugin-device: 1.1.7 (6d2011ba02)
> > >cordova-plugin-dialogs: 1.3.4 (10887f4026)
> > >cordova-plugin-file-transfer: 1.7.0 (c9ac8e1b3e)
> > >cordova-plugin-file: 5.0.0 (8568babcc0)
> > >cordova-plugin-geolocation: 3.0.0 (a168c04b33)
> > >cordova-plugin-globalization: 1.0.8 (a99c829800)
> > >cordova-plugin-inappbrowser: 1.7.2 (b9c577044c)
> > >cordova-plugin-media: 4.0.0 (ad484202f5)
> > >cordova-plugin-media-capture: 2.0.0 (ea934aa267)
> > >cordova-plugin-network-information: 1.3.4 (0cdf5d1999)
> > >cordova-plugin-splashscreen: 4.1.0 (326f13220e)
> > >cordova-plugin-statusbar: 2.3.0 (655f6cb1da)
> > >cordova-plugin-screen-orientation: 2.0.2 (8a8f8562cb)
> > >cordova-plugin-vibration: 2.1.6 (ab73db1943)
> > >cordova-plugin-whitelist: 1.3.3 (d10c82486f)
> > >cordova-plugin-wkwebview-engine: 1.1.4 (9fb282e2dd)
> > >cordova-plugin-test-framework: 1.1.6 (dfe4e84453)
> > >
> > >Upon a successful vote I will upload the archives to dist/, upload
> > >them to npm, and post the corresponding blog post.
> > >
> > >Voting guidelines:
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md=02%7C01%7C%7C79be3d4758654a06bf6808d525794081%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636456125059190144=
> > RcCwyes6xVvMwiyL91XBDhurzm9xdi%2FNtVqhRjO7qs4%3D=0
> > >How to vote on a plugins release at
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Fplugins-release-process.md%23voting=02%7C01%7C%
> > 7C79be3d4758654a06bf6808d525794081%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636456125059190144=AhozWWZ1I9UhDzgBESbvUl8FhuptOv
> > ltYTYGD53%2Bp%2FM%3D=0
> > >
> > >Voting will go on for a minimum of 48 hours.
> > >
> > >I vote +1:
> > >* Ran coho audit-license-headers over the relevant repos
> > >* Ran coho check-license to ensure all dependencies and
> > >subdependencies have Apache-compatible licenses
> > >* Ran mobile-spec
> >
>


Re: [Vote] 6.4.0 Android Release

2017-11-08 Thread Steven Gill
I vote +1:
* Ran coho verify-archive
* Created hello world app & and deployed to device
* ran npm test

On Wed, Nov 8, 2017 at 1:59 PM, Audrey So  wrote:

> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Created hello world app & was able to add/ rm, build/run successfully to
> emulator
> * Npm test (passed)
>
>
>
>
>
> On 11/8/17, 1:50 PM, "Suraj Pindoria"  wrote:
>
> >I vote +1:
> >
> >* Ran npm test, all greens
> >* Created hello-world and successfully deployed to emulator and device
> >
> >On Mon, Nov 6, 2017 at 3:44 PM, Joe Bowser  wrote:
> >
> >> Please review and vote on this 6.4.0 Android Release
> >>
> >> by replying to this email (and keep discussion on the DISCUSS thread)
> >>
> >> Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 15328=02%7C01%7C%7C7ef3146720f64801841808d526f2cf99%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636457746667246255=
> KdNZwan2KSTZyr7h4FWDFjay%2BMXZFiSVBRmY7gTigHs%3D=0
> >>
> >> The archive has been published to dist/dev:
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%
> 2Fcordova%2FCB-15328=02%7C01%7C%7C7ef3146720f64801841808d526f2cf99%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636457746667246255=
> cdg1bNexFkAsm8z6pbiLcFXVbxT8hWOIi27UNW7t2u0%3D=0
> >>
> >> The package was published from its corresponding git tag:
> >> cordova-android: 6.4.0 (7a27ee4f69)
> >>
> >> Note that you can test it out via:
> >>
> >> cordova platform add https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fgithub.com%
> 2Fapache%2Fcordova-android%236.4.0=02%7C01%7C%
> 7C7ef3146720f64801841808d526f2cf99%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636457746667246255=V4eSZvvNwyCt7VnF3oGcPdJfNHfH1A
> m86tiFkc3fYcE%3D=0
> >>
> >> Upon a successful vote I will upload the archive to dist/, publish it to
> >> npm, and post the blog post.
> >>
> >> Voting guidelines:
> >> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7C7ef3146720f64801841808d526f2cf99%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636457746667246255=
> pWKuOK95S2kEwumzjqU1jRxkQ3IjpOznjO3QghcB0Xg%3D=0
> >>
> >> Voting will go on for a minimum of 48 hours.
> >>
> >> I vote +1:
> >> * Ran coho audit-license-headers over the relevant repos
> >> * Ran coho check-license to ensure all dependencies and subdependencies
> >> have Apache-compatible licenses
> >> * Ensured continuous build was green when repo was tagged
> >>
>


[VOTE] Plugins Release Nov 6, 2017

2017-11-06 Thread Steven Gill
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13542

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13542/

The packages were published from their corresponding git tags:
cordova-plugin-battery-status: 1.2.5 (e336730d4b)
cordova-plugin-camera: 3.0.0 (d456eeb711)
cordova-plugin-contacts: 3.0.0 (a4d5e28e74)
cordova-plugin-device: 1.1.7 (6d2011ba02)
cordova-plugin-dialogs: 1.3.4 (10887f4026)
cordova-plugin-file-transfer: 1.7.0 (c9ac8e1b3e)
cordova-plugin-file: 5.0.0 (8568babcc0)
cordova-plugin-geolocation: 3.0.0 (a168c04b33)
cordova-plugin-globalization: 1.0.8 (a99c829800)
cordova-plugin-inappbrowser: 1.7.2 (b9c577044c)
cordova-plugin-media: 4.0.0 (ad484202f5)
cordova-plugin-media-capture: 2.0.0 (ea934aa267)
cordova-plugin-network-information: 1.3.4 (0cdf5d1999)
cordova-plugin-splashscreen: 4.1.0 (326f13220e)
cordova-plugin-statusbar: 2.3.0 (655f6cb1da)
cordova-plugin-screen-orientation: 2.0.2 (8a8f8562cb)
cordova-plugin-vibration: 2.1.6 (ab73db1943)
cordova-plugin-whitelist: 1.3.3 (d10c82486f)
cordova-plugin-wkwebview-engine: 1.1.4 (9fb282e2dd)
cordova-plugin-test-framework: 1.1.6 (dfe4e84453)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran mobile-spec


Re: [discuss] plugins release

2017-11-02 Thread Steven Gill
sweet

On Thu, Nov 2, 2017 at 4:24 PM, julio cesar sanchez <jcesarmob...@gmail.com>
wrote:

> All my PRs are merged now.
>
> We should continue with the plugins release.
>
> 2017-10-19 2:05 GMT+02:00 Steven Gill <stevengil...@gmail.com>:
>
> > Yay! I'll review soon and make sure they make it in for the release
> >
> > On Wed, Oct 18, 2017 at 4:17 PM, Kelvin Dart <kelvin.da...@gmail.com>
> > wrote:
> >
> > > cordova-plugin-compat has been removed and PRs for relevant plugins has
> > > been raised here:
> > >
> > > https://github.com/apache/cordova-plugin-camera/pull/293 <
> > > https://github.com/apache/cordova-plugin-camera/pull/293>
> > > https://github.com/apache/cordova-plugin-contacts/pull/156 <
> > > https://github.com/apache/cordova-plugin-contacts/pull/156>
> > > https://github.com/apache/cordova-plugin-file/pull/220 <
> > > https://github.com/apache/cordova-plugin-file/pull/220>
> > > https://github.com/apache/cordova-plugin-file-transfer/pull/192 <
> > > https://github.com/apache/cordova-plugin-file-transfer/pull/192>
> > > https://github.com/apache/cordova-plugin-geolocation/pull/96 <
> > > https://github.com/apache/cordova-plugin-geolocation/pull/96>
> > > https://github.com/apache/cordova-plugin-media/pull/151 <
> > > https://github.com/apache/cordova-plugin-media/pull/151>
> > > https://github.com/apache/cordova-plugin-media-capture/pull/85 <
> > > https://github.com/apache/cordova-plugin-media-capture/pull/85>
> > >
> > > Kelvin
> > >
> > > > On 18 Oct 2017, at 08:57, julio cesar sanchez <
> jcesarmob...@gmail.com>
> > > wrote:
> > > >
> > > > I have some PRs that I've not merged because of Android tests failing
> > > (any
> > > > of my PRs is for Android), not sure if it's ok to merge them.
> > > >
> > > > https://github.com/apache/cordova-plugin-camera/pull/291
> > > > https://github.com/apache/cordova-plugin-geolocation/pull/94
> > > > https://github.com/apache/cordova-plugin-media-capture/pull/83
> > > > https://github.com/apache/cordova-plugin-media/pull/148
> > > > https://github.com/apache/cordova-plugin-statusbar/pull/89
> > > >
> > > >
> > > > 2017-10-18 9:33 GMT+02:00 Kelvin Dart <kelvin.da...@gmail.com>:
> > > >
> > > >> I will make these pulls later this afternoon. I'll respond here with
> > the
> > > >> PRs when raised.
> > > >>
> > > >> Kelvin
> > > >>
> > > >>
> > > >> Best regards,
> > > >> Kelvin
> > > >>
> > > >> On 18 October 2017 at 00:25, Steven Gill <stevengil...@gmail.com>
> > > wrote:
> > > >>
> > > >>> Going to try to start it later this week. Still waiting on a few
> prs
> > to
> > > >>> come in around removing compat. May just make some of those changes
> > > >> myself.
> > > >>> Going to look at doing a larger release this time.
> > > >>>
> > > >>> I know the following definitely need to go out.
> > > >>>
> > > >>> cordova-plugin-status-bar
> > > >>> cordova-plugin-file-transfer
> > > >>>
> > > >>> Post the PRs i should be looking at.
> > > >>>
> > > >>
> > >
> > >
> >
>


Re: [DISCUSS] Cordova-Android 6.4.0 Release

2017-11-01 Thread Steven Gill
Do it!

On Wed, Nov 1, 2017 at 10:28 AM, Joe Bowser  wrote:

> I just merged in the fix for compiling with the latest Gradle Android
> tools/Android Studio.  I think we need to do a release fairly quickly so
> that people can use the latest version of Android to build their projects.
>
> Any thoughts on this before we go ahead with a vote thread?
>


Re: [VOTE] Cordova-fetch@1.2.1 release (attempt 2)

2017-10-30 Thread Steven Gill
I vote +1:
* Ran coho verify-license
* Npm test

On Fri, Oct 27, 2017 at 4:59 PM, Audrey So  wrote:

> Hi everyone,
>
>
> Please review and vote on this Cordova-Fetch 1.2.1 Release
>
> by replying to this email (and keep discussion on the DISCUSS thread)
>
>
> Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13504=02%7C01%7C%7C7819fc06062c4772b4d608d51d936bdf%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636447441364000671=
> FkRyVQlVasL9QfZV02vw2QPcv6Q0KmgjS21MbMLtB%2FQ%3D=0
>
>
> Has been published to dist/dev:
>
> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%
> 2Fcordova%2FCB-13504%2F=02%7C01%7C%7C7819fc06062c4772b4d608d51d93
> 6bdf%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636447441364000671=C660T4zQopL4X3pmFMffTaBLYxUcWU
> EoxfswcJfJM24%3D=0
>
>
> The packages were published from their corresponding git tags:
>
>
> cordova-fetch: 1.2.1 (01706153bf)
>
>
>
> Upon a successful vote I will upload the archives to dist/, publish them
> to npm, and post the corresponding blog post.
>
>
> Voting guidelines: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7C7819fc06062c4772b4d608d51d936bdf%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636447441364000671=W8%
> 2FxW0Zmm8vePKRij%2FQwGGuD8Bj28YSkWZARmuAzp6I%3D=0
>
>
> Voting will go on for a minimum of 48 hours.
>
>
> I vote +1:
>
> * Ran coho audit-license-headers over the relevant repos
>
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
>
> * Ensured continuous build was green when repos were tagged
>
> * Npm test
>
>
> Thanks!
>
>
> — Audrey
>


Re: [VOTE] 4.5.3 iOS Release

2017-10-30 Thread Steven Gill
I vote +1:
* Ran coho verify-license
* Npm test

On Thu, Oct 26, 2017 at 2:12 PM, Audrey So  wrote:

> I vote +1:
> * Ran coho audit-license-headers
> * Ran coho check-license
> * Ran/tested mobilespec
> * Created hello-world app, deployed to emulator
> * Npm test
>
>
>
>
>
> On 10/25/17, 3:33 PM, "Suraj Pindoria"  wrote:
>
> >Please review and vote on this 4.5.3 iOS Release by replying to this email
> >(and keep discussion on the DISCUSS thread)
> >
> >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13493=02%7C01%7C%7Ce084f1f69b0e4617a32808d51bf87b7b%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636445676415459887=
> wlUecnAkiLyoHza2DYKZJEoksnJZ5I7kLHJdXeOUw7k%3D=0
> >
> >The archive has been published to dist/dev:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%
> 2Fcordova%2FCB-13493=02%7C01%7C%7Ce084f1f69b0e4617a32808d51bf87b7b%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636445676415459887=
> s1wnAe0cBc3yI%2Fhaa3AkfyqG9xz1qnVU3tEVypyrpic%3D=0
> >
> >The package was published from its corresponding git tag:
> > cordova-ios: 4.5.3 (ce2ab968e7)
> >
> >Note that you can test it out via:
> >
> > cordova platform add https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fgithub.com%
> 2Fapache%2Fcordova-ios%234.5.3=02%7C01%7C%
> 7Ce084f1f69b0e4617a32808d51bf87b7b%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636445676415459887=GLcgo4T%2BpcK96f8Rc1B4XgQ4K6R%
> 2BPmt1stqGE7j7kyQ%3D=0
> >
> >Upon a successful vote I will upload the archive to dist/, publish it to
> >npm, and post the blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7Ce084f1f69b0e4617a32808d51bf87b7b%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636445676415459887=waC%
> 2BUz3DxUEVsUMNhyTIN7tli54QzIxX7lcMu%2F2vB6k%3D=0
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers
> >* Ran coho check-license
> >* Ensured continuous build was green when repo was tagged
> >* Created and tested against mobilespec
> >* Created helloworld using CLI and build scripts, deployed to
> >device/emulator
>


Re: [VOTE] Cordova-Fetch 1.2.1 Release

2017-10-27 Thread Steven Gill
lol, don't know why it keeps showing up in discuss thread for me

On Fri, Oct 27, 2017 at 4:57 PM, Audrey So  wrote:

> Hi everyone,
>
>
> Please review and vote on this Cordova-Fetch 1.2.1 Release
>
> by replying to this email (and keep discussion on the DISCUSS thread)
>
>
> Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13504=02%7C01%7C%7C7819fc06062c4772b4d608d51d936bdf%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636447441364000671=
> FkRyVQlVasL9QfZV02vw2QPcv6Q0KmgjS21MbMLtB%2FQ%3D=0
>
>
> Has been published to dist/dev:
>
> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%
> 2Fcordova%2FCB-13504%2F=02%7C01%7C%7C7819fc06062c4772b4d608d51d93
> 6bdf%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636447441364000671=C660T4zQopL4X3pmFMffTaBLYxUcWU
> EoxfswcJfJM24%3D=0
>
>
> The packages were published from their corresponding git tags:
>
>
> cordova-fetch: 1.2.1 (01706153bf)
>
>
>
> Upon a successful vote I will upload the archives to dist/, publish them
> to npm, and post the corresponding blog post.
>
>
> Voting guidelines: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7C7819fc06062c4772b4d608d51d936bdf%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636447441364000671=W8%
> 2FxW0Zmm8vePKRij%2FQwGGuD8Bj28YSkWZARmuAzp6I%3D=0
>
>
> Voting will go on for a minimum of 48 hours.
>
>
> I vote +1:
>
> * Ran coho audit-license-headers over the relevant repos
>
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
>
> * Ensured continuous build was green when repos were tagged
>
> * Npm test
>
>
> Thanks!
>
>
> — Audrey
>


[ANNOUNCE] Cordova-Browser@5.0.1 Released

2017-10-19 Thread Steven Gill
Blog: https://cordova.apache.org/news/2017/10/19/browser-release.html
Tweet: https://twitter.com/apachecordova/status/921149906827411456


Re: [Vote] 5.0.1 Browser Release

2017-10-19 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 4

Steve Gill
Audrey So
Suraj Pindoria
Jesse MacFadyen

The vote has passed.


On Thu, Oct 19, 2017 at 3:00 PM, Jesse <purplecabb...@gmail.com> wrote:

> +1
>
> * Ran npm test, all green
> * Ran coho verify-archive
> * cordova platform add
> /repos/cordova/cordova-dist-dev/CB-13444/cordova-browser-5.0.1.tgz
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Oct 19, 2017 at 1:40 PM, Suraj Pindoria <pindoria.su...@gmail.com>
> wrote:
>
> > +1
> >
> > * Ran npm test, all green
> > * Ran coho audit-license-headers
> > * Ran coho check-license
> > * Created hello-world and launched in browser
> >
> >
> > On Tue, Oct 17, 2017 at 9:53 AM, Audrey So <a...@adobe.com.invalid>
> wrote:
> >
> > > I vote +1:
> > > * Ran npm test (passed)
> > > * Created hello world app
> > > * Ran coho audit-license-headers
> > > * Ran coho check-license
> > >
> > >
> > >
> > >
> > > - Audrey
> > >
> > > On 10/16/17, 3:51 PM, "Steven Gill" <stevengil...@gmail.com> wrote:
> > >
> > > >Please review and vote on this 5.0.1 Browser Release
> > > >by replying to this email (and keep discussion on the DISCUSS thread)
> > > >
> > > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > > 13444=02%7C01%7C%7Cf73f8a55d86e437282d008d514e8700b%
> > > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636437910917880753=
> > > PM0qviF2ORF7uqFz5ceBC8JrqChVkuVgeL8B%2BGIbIpk%3D=0
> > > >
> > > >The archive has been published to
> > > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13444
> > > >
> > > >The package was published from its corresponding git tag:
> > > >cordova-browser: 5.0.1 (d118ec8e30)
> > > >
> > > >Note that you can test it out via:
> > > >
> > > >cordova platform add https://na01.safelinks.
> > > protection.outlook.com/?url=https%3A%2F%2Fgithub.com%
> > > 2Fapache%2Fcordova-browser%235.0.1=02%7C01%7C%
> > > 7Cf73f8a55d86e437282d008d514e8700b%7Cfa7b1b5a7b34438794aed2c178de
> > > cee1%7C0%7C0%7C636437910917880753=pviRi91ZjCA8t4T9W%
> > > 2FUth5bqpfNegyWp89c0FQXMkkQ%3D=0
> > > >
> > > >Upon a successful vote I will upload the archive to dist/, publish it
> > > >to npm, and post the blog post.
> > > >
> > > >Voting guidelines:
> > > >https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%
> 2Fblob%2Fmaster%2Fdocs%
> > > 2Frelease-voting.md=02%7C01%7C%7Cf73f8a55d86e437282d008d514e8
> 700b%
> > > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636437910917880753=T%
> > > 2F9u194OLhUAeWVPXtBUdbU2h%2FLeicECOaKAM6Tkfck%3D=0
> > > >
> > > >Voting will go on for a minimum of 48 hours.
> > > >
> > > >I vote +1:
> > > >* Ran coho audit-license-headers over the relevant repos
> > > >* Ran coho check-license to ensure all dependencies and
> > > >subdependencies have Apache-compatible licenses
> > > >* Ran npm test
> > > >* created hello world app
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> >
>


Re: [DISCUSS] Browser@5.0.1 release

2017-10-19 Thread Steven Gill
Please review the blog post. https://github.com/apache/cordova-docs/pull/751

Also, I need one more vote for the browser release to wrap it up

On Sun, Oct 15, 2017 at 4:40 PM, Steven Gill <stevengil...@gmail.com> wrote:

> Sent a PR for a issue with the merges directory not working with the
> latest browser. Please review. https://github.com/
> apache/cordova-browser/pull/46
>
> On Fri, Oct 13, 2017 at 4:05 PM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
>> I'm going to do a browser release to fix https://issues.apache.org/
>> jira/browse/CB-13228.
>>
>> Let me know if anything else should go in.
>>
>
>


Re: [discuss] plugins release

2017-10-18 Thread Steven Gill
Yay! I'll review soon and make sure they make it in for the release

On Wed, Oct 18, 2017 at 4:17 PM, Kelvin Dart <kelvin.da...@gmail.com> wrote:

> cordova-plugin-compat has been removed and PRs for relevant plugins has
> been raised here:
>
> https://github.com/apache/cordova-plugin-camera/pull/293 <
> https://github.com/apache/cordova-plugin-camera/pull/293>
> https://github.com/apache/cordova-plugin-contacts/pull/156 <
> https://github.com/apache/cordova-plugin-contacts/pull/156>
> https://github.com/apache/cordova-plugin-file/pull/220 <
> https://github.com/apache/cordova-plugin-file/pull/220>
> https://github.com/apache/cordova-plugin-file-transfer/pull/192 <
> https://github.com/apache/cordova-plugin-file-transfer/pull/192>
> https://github.com/apache/cordova-plugin-geolocation/pull/96 <
> https://github.com/apache/cordova-plugin-geolocation/pull/96>
> https://github.com/apache/cordova-plugin-media/pull/151 <
> https://github.com/apache/cordova-plugin-media/pull/151>
> https://github.com/apache/cordova-plugin-media-capture/pull/85 <
> https://github.com/apache/cordova-plugin-media-capture/pull/85>
>
> Kelvin
>
> > On 18 Oct 2017, at 08:57, julio cesar sanchez <jcesarmob...@gmail.com>
> wrote:
> >
> > I have some PRs that I've not merged because of Android tests failing
> (any
> > of my PRs is for Android), not sure if it's ok to merge them.
> >
> > https://github.com/apache/cordova-plugin-camera/pull/291
> > https://github.com/apache/cordova-plugin-geolocation/pull/94
> > https://github.com/apache/cordova-plugin-media-capture/pull/83
> > https://github.com/apache/cordova-plugin-media/pull/148
> > https://github.com/apache/cordova-plugin-statusbar/pull/89
> >
> >
> > 2017-10-18 9:33 GMT+02:00 Kelvin Dart <kelvin.da...@gmail.com>:
> >
> >> I will make these pulls later this afternoon. I'll respond here with the
> >> PRs when raised.
> >>
> >> Kelvin
> >>
> >>
> >> Best regards,
> >> Kelvin
> >>
> >> On 18 October 2017 at 00:25, Steven Gill <stevengil...@gmail.com>
> wrote:
> >>
> >>> Going to try to start it later this week. Still waiting on a few prs to
> >>> come in around removing compat. May just make some of those changes
> >> myself.
> >>> Going to look at doing a larger release this time.
> >>>
> >>> I know the following definitely need to go out.
> >>>
> >>> cordova-plugin-status-bar
> >>> cordova-plugin-file-transfer
> >>>
> >>> Post the PRs i should be looking at.
> >>>
> >>
>
>


[discuss] plugins release

2017-10-17 Thread Steven Gill
Going to try to start it later this week. Still waiting on a few prs to
come in around removing compat. May just make some of those changes myself.
Going to look at doing a larger release this time.

I know the following definitely need to go out.

cordova-plugin-status-bar
cordova-plugin-file-transfer

Post the PRs i should be looking at.


Re: [proposal] Remove tool generated docs from camera plugin?

2017-10-17 Thread Steven Gill
I'm fine with going back to a simple readme

On Sun, Oct 15, 2017 at 12:52 AM, julio cesar sanchez <
jcesarmob...@gmail.com> wrote:

> The README.md already have a section
>  documentation-is-generated-by-a-tool>
> about how the README.md is generated. But maybe it should be more clear and
> say that the README.md shouldn't be updated manually.
>
> BTW, I sent a PR  >
> to make the template be in sync with the README.md changes. If anybody can
> take a look it would be good. Not sure if I can merge while the tests are
> failing, but I only changed the template, so I'm pretty sure I didn't break
> anything and tests are failing in all other plugins, but that's another
> topic.
>
> About if it's a good idea, I've found the original cordova-discuss issue
>  and proposal
>  and reading them I
> think it's a good idea as I understand that the API part of the docs are
> automatically generated from the js files, which avoids them to be out of
> sync if a js change is made.
>
>
> 2017-10-15 1:07 GMT+02:00 Jan Piotrowski :
>
> > The "not aware" problem can probably be resolved (80/20) by adding
> > comments to the template that are also in the generated output.
> >
> > But it the TEMPLATE.md actually a good idea? Is it worth the extra
> effort?
> >
> > -J
> >
> > 2017-10-15 0:01 GMT+02:00 julio cesar sanchez :
> > > cordova-plugin-camera docs work on a different way than other plugins.
> > The
> > > README.md is generated from jsdoc2md/TEMPLATE.md when the commit is
> done.
> > > I think it was a proof of concept to be done in all the plugins, but it
> > the
> > > end it was only done in camera plugin.
> > > The problem is most people is not aware of this, so they just update
> the
> > > README.md manually as on any other plugins, and most of the committers
> > > aren't aware neither or forgot about it and just merge those changes.
> > >
> > > So, I was about to send a new PR and the jsdoc2md/TEMPLATE.md is out of
> > > sync with the README.md.
> > >
> > > So, we have two options, we can move back to a regular README.md like
> the
> > > other plugins, or do this in all the plugins and not accept README.md
> > file
> > > changes without the corresponding jsdoc2md/TEMPLATE.md.
> > >
> > > What do you think?
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


[Vote] 5.0.1 Browser Release

2017-10-16 Thread Steven Gill
Please review and vote on this 5.0.1 Browser Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13444

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13444

The package was published from its corresponding git tag:
cordova-browser: 5.0.1 (d118ec8e30)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-browser#5.0.1

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test
* created hello world app


Re: [DISCUSS] Browser@5.0.1 release

2017-10-15 Thread Steven Gill
Sent a PR for a issue with the merges directory not working with the latest
browser. Please review. https://github.com/apache/cordova-browser/pull/46

On Fri, Oct 13, 2017 at 4:05 PM, Steven Gill <stevengil...@gmail.com> wrote:

> I'm going to do a browser release to fix https://issues.apache.org/
> jira/browse/CB-13228.
>
> Let me know if anything else should go in.
>


[DISCUSS] Browser@5.0.1 release

2017-10-13 Thread Steven Gill
I'm going to do a browser release to fix
https://issues.apache.org/jira/browse/CB-13228.

Let me know if anything else should go in.


Re: [VOTE] 4.5.2 iOS Release

2017-10-12 Thread Steven Gill
+1

* Ran coho audit-license-headers
* Ran coho check-license
* Ran mobilespec
* Created hello-world app, deployed to emulator
* Npm test


On Tue, Oct 10, 2017 at 7:14 AM, Audrey So  wrote:

> I vote +1:
> * Ran coho audit-license-headers
> * Ran coho check-license
> * Ran mobilespec
> * Created hello-world app, deployed to emulator
> * Npm test
>
>
>
>
> On 10/9/17, 2:31 PM, "Suraj Pindoria"  wrote:
>
> >Please review and vote on this 4.5.2 iOS Release
> >by replying to this email (and keep discussion on the DISCUSS thread)
> >
> >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13417=02%7C01%7C%7C73ad262abb824905dfc708d50f5d135a%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636431814784811281=
> BMubFWb0jXgG4YLJ0s1PsbA41%2BE1Otg4czucF9dJ5Cw%3D=0
> >
> >The archive has been published to dist/dev:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%
> 2Fcordova%2FCB-13417=02%7C01%7C%7C73ad262abb824905dfc708d50f5d135a%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636431814784811281=
> YIbWlOxnUTuAdZP477MSp5RwhYU2T%2BH%2BA8XVHnPmql0%3D=0
> >
> >The package was published from its corresponding git tag:
> >PASTE OUTPUT OF: coho print-tags -r ios --tag 4.5.2
> >
> >Note that you can test it out via:
> >
> >cordova platform add https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fgithub.com%
> 2Fapache%2Fcordova-ios%234.5.2=02%7C01%7C%
> 7C73ad262abb824905dfc708d50f5d135a%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636431814784811281=%2BvRhaYsrhnwG4MJHfg6xoNDErQtKd
> 8mfaU4rR9EqX0M%3D=0
> >
> >Upon a successful vote I will upload the archive to dist/, publish it to
> >npm, and post the blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7C73ad262abb824905dfc708d50f5d135a%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636431814784811281=
> NFxGZlIHyzj67518JJhXiDRxQowV%2FTO6O9RZSBOs7mg%3D=0
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers over the relevant repos
> >* Ran coho check-license to ensure all dependencies and subdependencies
> >have Apache-compatible licenses
> >* Ensured continuous build was green when repo was tagged
> >* Ran mobilespec
> >* Created hello-world, deployed to emulator/device
> >* Checked create/build/version scripts
>


[Announce] Tools Release

2017-10-10 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/917988312773746688
Blog: http://cordova.apache.org/news/2017/10/10/tools-release.html


Re: [Discuss] Tools release

2017-10-09 Thread Steven Gill
Please review the tools release blog post
https://github.com/apache/cordova-docs/pull/747

On Mon, Oct 2, 2017 at 3:17 PM, Steven Gill <stevengil...@gmail.com> wrote:

> issue: https://issues.apache.org/jira/browse/CB-13380
>
> On Mon, Oct 2, 2017 at 2:28 PM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
>> Time for the tools release!
>>
>> Any specific prs need to be merged?
>>
>> cordova-lib@7.1.0,
>> cordova-cli@7.1.0,
>> cordova-fetch@1.2.0
>> cordova-node-xcode@0.9.4 (IMO this should not be using a 0 as a major
>> version but instead jump to 1.0.0. Proper semver compliance)
>> cordova-js@4.2.2
>> cordova-common@2.1.1
>>
>> Anything else?
>>
>
>


Re: [VOTE] Tools Release

2017-10-09 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: (# of PMC members that +1'ed)

Steve Gill
Audrey So
Jesse MacFadyen

The vote has passed.


On Mon, Oct 9, 2017 at 3:35 PM, Jesse <purplecabb...@gmail.com> wrote:

> I vote +1:
> * Coho verify-archives
> * Ran npm test on all the repos (all passing except for 1 timeout in
> fetch),
> * Built an app (added+rm ios)
>
> In order to actually test the versions of all packages listed in here, I
> had to run the following to checkout the correct version.  Use if you like.
>
> cd cordova-js
> git checkout f03c7971c2
> cd ../cordova-lib
> git checkout 1a8c8abb77
> cd ../cordova-plugman
> git checkout 128d95269f
> cd ../cordova-cli
> git checkout cc5cb8a6e8
> cd ../cordova-fetch
> git checkout 522ed6593e
> cd ../cordova-common
> git checkout e76dd52f67
> cd ../cordova-node-xcode
> git checkout 9345e5ed03
> cd ..
> coho npm-link
>
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Oct 9, 2017 at 2:32 PM, Audrey So <a...@adobe.com.invalid> wrote:
>
> > I vote +1:
> > * Ran npm test on all the repos (all passing),
> > * Built a hello world app (added/ rm platform and plugin)
> > * Coho audit-license-headers
> > * Coho check-license
> >
> >
> >
> > — Audrey
> >
> > On 10/6/17, 3:45 PM, "Steven Gill" <stevengil...@gmail.com> wrote:
> >
> > >Please review and vote on this Tools Release
> > >by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13380=02%7C01%7C%7C52ccfe40bad84d677a8108d50d0bf769%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636429267400494850=
> > Bukz7zoMaTLzvta1cPd54irhlXO6boTgTQDh8l4hCaE%3D=0
> > >
> > >Tools have been published to
> > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13380/
> > >
> > >The packages were published from their corresponding git tags:
> > >
> > >cordova-js: 4.2.2 (f03c7971c2)
> > >cordova-lib: 7.1.0 (1a8c8abb77)
> > >cordova-plugman: 1.5.1 (128d95269f)
> > >cordova-cli: 7.1.0 (cc5cb8a6e8)
> > >cordova-fetch: 1.2.0 (522ed6593e)
> > >cordova-common: 2.1.1 (e76dd52f67)
> > >cordova-node-xcode: 1.0.0 (9345e5ed03)
> > >
> > >Upon a successful vote I will upload the archives to dist/, publish
> > >them to npm, and post the corresponding blog post.
> > >
> > >Voting guidelines:
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md=02%7C01%7C%7C52ccfe40bad84d677a8108d50d0bf769%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636429267400494850=
> > SBuZWjiU7MyqZU2A64FKHHyTsbEd%2BrzYJIBitoJRNbY%3D=0
> > >
> > >Voting will go on for a minimum of 48 hours.
> > >
> > >I vote +1:
> > >* Ran coho audit-license-headers over the relevant repos
> > >* Ran coho check-license to ensure all dependencies and
> > >subdependencies have Apache-compatible licenses
> > >* Ran npm test in each repo
> > >* Did basic hello world test, adding/removing platforms/plugins
> >
>


[VOTE] Tools Release

2017-10-06 Thread Steven Gill
Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13380

Tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13380/

The packages were published from their corresponding git tags:

cordova-js: 4.2.2 (f03c7971c2)
cordova-lib: 7.1.0 (1a8c8abb77)
cordova-plugman: 1.5.1 (128d95269f)
cordova-cli: 7.1.0 (cc5cb8a6e8)
cordova-fetch: 1.2.0 (522ed6593e)
cordova-common: 2.1.1 (e76dd52f67)
cordova-node-xcode: 1.0.0 (9345e5ed03)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test in each repo
* Did basic hello world test, adding/removing platforms/plugins


Re: [Discuss] Tools release

2017-10-02 Thread Steven Gill
issue: https://issues.apache.org/jira/browse/CB-13380

On Mon, Oct 2, 2017 at 2:28 PM, Steven Gill <stevengil...@gmail.com> wrote:

> Time for the tools release!
>
> Any specific prs need to be merged?
>
> cordova-lib@7.1.0,
> cordova-cli@7.1.0,
> cordova-fetch@1.2.0
> cordova-node-xcode@0.9.4 (IMO this should not be using a 0 as a major
> version but instead jump to 1.0.0. Proper semver compliance)
> cordova-js@4.2.2
> cordova-common@2.1.1
>
> Anything else?
>


[Discuss] Tools release

2017-10-02 Thread Steven Gill
Time for the tools release!

Any specific prs need to be merged?

cordova-lib@7.1.0,
cordova-cli@7.1.0,
cordova-fetch@1.2.0
cordova-node-xcode@0.9.4 (IMO this should not be using a 0 as a major
version but instead jump to 1.0.0. Proper semver compliance)
cordova-js@4.2.2
cordova-common@2.1.1

Anything else?


Re: [Vote] 6.3.0 Android Release

2017-09-27 Thread Steven Gill
I vote +1:

* Ran npm test
* Added to a hello world project, added plugins
* ran coho verify-archive

On Mon, Sep 25, 2017 at 2:25 PM, Joe Bowser  wrote:

> Please review and vote on this 6.3.0 Android Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-
>
> The archive has been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-
>
> The package was published from its corresponding git tag:
> cordova-android: 6.3.0 (021c9c19e8)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-android#6.3.0
>
> Upon a successful vote I will upload the archive to dist/, publish it
> to npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran mobilespec on emulator and Google Pixel device
> * Ran Unit Tests from IDE
> * Ensured continuous build was green when repo was tagged
>


[ANNOUNCE] Plugins Release

2017-09-22 Thread Steven Gill
Plugins release is out!

Blog: http://cordova.apache.org/news/2017/09/22/plugins-release.html
Tweet: https://twitter.com/apachecordova/status/911368906043985920


Re: [DISCUSS] Plugin release

2017-09-22 Thread Steven Gill
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
but I used the new undocumented automatic release script that fil created
for this past one. I'll document it up for this next release

On Fri, Sep 22, 2017 at 3:04 PM, Simon MacDonald <simon.macdon...@gmail.com>
wrote:

> Yeah, we should be doing another plugins release soon. We have:
>
> cordova-plugin-status-bar
> cordova-plugin-file-transfer
>
> Needing releases.
>
> Steve, is the release process documented anywhere so you don't have to be
> the person who runs it each and every time?
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Fri, Sep 22, 2017 at 6:00 PM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > For next release I want cordova-plugin-statusbar as I fixed it to work
> > properly on iPhone X
> >
> > 2017-09-22 21:27 GMT+02:00 Steven Gill <stevengil...@gmail.com>:
> >
> > > Please review the blog post for the release
> > >
> > > https://github.com/apache/cordova-docs/pull/734
> > >
> > > On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill <stevengil...@gmail.com>
> > > wrote:
> > >
> > > > Yeah I only released the plugins that people mentioned in this thread
> > to
> > > > release. I can fire up another plugins release next week. What
> plugins
> > do
> > > > people want reviewed/released?
> > > >
> > > > On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <
> > > > simon.macdon...@gmail.com> wrote:
> > > >
> > > >> Just realized that cordova-plugin-file-transfer was never bumped. It
> > > >> includes an important fix for apps. Without it new apps may be
> > rejected
> > > >> from the Play Store.
> > > >>
> > > >>
> > > >> Simon Mac Donald
> > > >> http://simonmacdonald.com
> > > >>
> > > >> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill <
> stevengil...@gmail.com>
> > > >> wrote:
> > > >>
> > > >> > the ios release blog post tells users about the console plugin.
> > > >> > http://cordova.apache.org/announcements/2017/09/08/ios-
> release.html
> > > >> >
> > > >> > I'll make sure to highlight these changes in the plugins release
> > blog
> > > >> post.
> > > >> >
> > > >> > Starting a new vote with console + compat only having minor bumps
> > > >> >
> > > >> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> > > >> > jcesarmob...@gmail.com
> > > >> > > wrote:
> > > >> >
> > > >> > > There has been already a few people asking about the duplicate
> > > >> symbols on
> > > >> > > slack
> > > >> > >
> > > >> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald <
> > > simon.macdon...@gmail.com
> > > >> >:
> > > >> > >
> > > >> > > > IMHO both cordova-plugin-compat and cordova-plugin-console
> > should
> > > >> > receive
> > > >> > > > minor version bumps. Neither breaks backwards compatibility
> so I
> > > >> don't
> > > >> > > feel
> > > >> > > > like a major version bump is warranted.
> > > >> > > >
> > > >> > > > As well all of our core plugins that depend on
> > > cordova-plugin-compat
> > > >> > use
> > > >> > > > the ^1.x in their semver so they would pull in the earlier
> > version
> > > >> of
> > > >> > the
> > > >> > > > compat plugin and in combination with the upcoming
> > cordova-android
> > > >> > 6.3.0
> > > >> > > > pretty much all apps will fail to build.
> > > >> > > >
> > > >> > > > When it comes to cordova-plugin-console we should also err on
> > the
> > > >> side
> > > >> > of
> > > >> > > > caution when it comes to the version number bump. I spent some
> > > time
> > > >> > this
> > > >> > > > morning debugging an internal app that was using cordova-ios
> > 4.5.0
> > > >> and
> > > >> > > > cordova-plugin-console. It

Re: [Discuss] Cordova-Android 6.3.0 Release

2017-09-22 Thread Steven Gill
yup!

On Fri, Sep 22, 2017 at 2:18 PM, Joe Bowser <bows...@gmail.com> wrote:

> OK, we should start the vote on Monday so that we don't leave a vote over
> the weekend that people miss.  Everyone cool with that?
>
> On Tue, Sep 5, 2017 at 4:48 PM, Simon MacDonald <simon.macdon...@gmail.com
> >
> wrote:
>
> > As soon as we release cordova-plugin-compat because we've added all those
> > classes into cordova-android propper.
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Tue, Sep 5, 2017 at 7:46 PM, Simon MacDonald <
> simon.macdon...@gmail.com
> > >
> > wrote:
> >
> > > Let's do it
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > > On Tue, Sep 5, 2017 at 2:01 PM, Steven Gill <stevengil...@gmail.com>
> > > wrote:
> > >
> > >> Lets do it. I'll update cordova-common in android now
> > >>
> > >> On Tue, Sep 5, 2017 at 10:58 AM, Joe Bowser <bows...@gmail.com>
> wrote:
> > >>
> > >> > Hey
> > >> >
> > >> > I'm back from PTO and while I was out, Android Oreo got released.  I
> > >> bumped
> > >> > the target SDK in the repo before I left for PTO, and I'm wondering
> > how
> > >> > people feel about doing a 6.3.0 release to support Oreo now that
> it's
> > a
> > >> > real thing?
> > >> >
> > >> > Thoughts?
> > >> >
> > >> > Joe
> > >> >
> > >>
> > >
> > >
> >
>


Re: [VOTE] Plugins Release (attempt 2)

2017-09-22 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Joe Bowser
Simon MacDonalod

The vote has passed.


On Wed, Sep 20, 2017 at 4:32 PM, Steven Gill <stevengil...@gmail.com> wrote:

> discuss thread Simon!
>
> On Wed, Sep 20, 2017 at 4:21 PM, Simon MacDonald <
> simon.macdon...@gmail.com> wrote:
>
>> Just realized that cordova-plugin-file-transfer was never bumped. It
>> includes an important fix for apps. Without it new apps may be rejected
>> from the Play Store.
>>
>>
>> Simon Mac Donald
>> http://simonmacdonald.com
>>
>> On Wed, Sep 20, 2017 at 6:01 PM, Joe Bowser <bows...@gmail.com> wrote:
>>
>> > I vote +1
>> >
>> > * Verified Archives
>> > * Tested MobileSpec and made sure that Camera actually got installed
>> > * Tested against master of cordova-android (cordova-android >= 6.3.0)
>> >
>> > On Wed, Sep 20, 2017 at 11:25 AM, Simon MacDonald <
>> > simon.macdon...@gmail.com
>> > > wrote:
>> >
>> > > I vote + 1
>> > >
>> > > Passed
>> > > * Checked for deprecation notices for plugin-device-motion &
>> orientation
>> > > * Tested that cordova-plugin-console is not added for ios when
>> > cordova-ios
>> > > >= 4.5.0
>> > > * Tested that cordova-plugin-compat is not added for android when
>> > > cordova-android >= 6.3.0
>> > > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
>> > which
>> > > depends on cordova-plugin-compat (from github master) and the build
>> > passes.
>> > >
>> > >
>> > > Simon Mac Donald
>> > > http://simonmacdonald.com
>> > >
>> > > On Wed, Sep 20, 2017 at 1:57 PM, Steven Gill <stevengil...@gmail.com>
>> > > wrote:
>> > >
>> > > > Please review and vote on the release of this plugins release
>> > > > by replying to this email (and keep discussion on the DISCUSS
>> thread)
>> > > >
>> > > > Release issue: https://issues.apache.org/jira/browse/CB-13294
>> > > >
>> > > > The plugins have been published to
>> > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
>> > > >
>> > > > The packages were published from their corresponding git tags:
>> > > > cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
>> > > > cordova-plugin-compat: 1.2.0 (be2a46be8d)
>> > > > cordova-plugin-device-motion: 2.0.0 (1236b957af)
>> > > > cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
>> > > >
>> > > > Upon a successful vote I will upload the archives to dist/, upload
>> > > > them to npm, and post the corresponding blog post.
>> > > >
>> > > > Voting guidelines:
>> > > > https://github.com/apache/cordova-coho/blob/master/docs/
>> > > release-voting.md
>> > > > How to vote on a plugins release at
>> > > > https://github.com/apache/cordova-coho/blob/master/docs/
>> > > > plugins-release-process.md#voting
>> > > >
>> > > > Voting will go on for a minimum of 48 hours.
>> > > >
>> > > > I vote +1:
>> > > > * Ran coho audit-license-headers over the relevant repos
>> > > > * Ran coho check-license to ensure all dependencies and
>> > > > subdependencies have Apache-compatible licenses
>> > > > * Ensured continuous build was green when repos were tagged
>> > > >
>> > >
>> >
>>
>
>


Re: [DISCUSS] Plugin release

2017-09-22 Thread Steven Gill
Please review the blog post for the release

https://github.com/apache/cordova-docs/pull/734

On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill <stevengil...@gmail.com> wrote:

> Yeah I only released the plugins that people mentioned in this thread to
> release. I can fire up another plugins release next week. What plugins do
> people want reviewed/released?
>
> On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <
> simon.macdon...@gmail.com> wrote:
>
>> Just realized that cordova-plugin-file-transfer was never bumped. It
>> includes an important fix for apps. Without it new apps may be rejected
>> from the Play Store.
>>
>>
>> Simon Mac Donald
>> http://simonmacdonald.com
>>
>> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill <stevengil...@gmail.com>
>> wrote:
>>
>> > the ios release blog post tells users about the console plugin.
>> > http://cordova.apache.org/announcements/2017/09/08/ios-release.html
>> >
>> > I'll make sure to highlight these changes in the plugins release blog
>> post.
>> >
>> > Starting a new vote with console + compat only having minor bumps
>> >
>> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
>> > jcesarmob...@gmail.com
>> > > wrote:
>> >
>> > > There has been already a few people asking about the duplicate
>> symbols on
>> > > slack
>> > >
>> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald <simon.macdon...@gmail.com
>> >:
>> > >
>> > > > IMHO both cordova-plugin-compat and cordova-plugin-console should
>> > receive
>> > > > minor version bumps. Neither breaks backwards compatibility so I
>> don't
>> > > feel
>> > > > like a major version bump is warranted.
>> > > >
>> > > > As well all of our core plugins that depend on cordova-plugin-compat
>> > use
>> > > > the ^1.x in their semver so they would pull in the earlier version
>> of
>> > the
>> > > > compat plugin and in combination with the upcoming cordova-android
>> > 6.3.0
>> > > > pretty much all apps will fail to build.
>> > > >
>> > > > When it comes to cordova-plugin-console we should also err on the
>> side
>> > of
>> > > > caution when it comes to the version number bump. I spent some time
>> > this
>> > > > morning debugging an internal app that was using cordova-ios 4.5.0
>> and
>> > > > cordova-plugin-console. It was failing to build because of duplicate
>> > > code.
>> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
>> > > > cordova-ios 4.5.0 the problem would not have existed.
>> > > >
>> > > > I think we need to be ready to start answering that question as to
>> why
>> > > apps
>> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in
>> > > order?
>> > > >
>> > > > My recommendations is to restart this vote thread with the four
>> plugins
>> > > but
>> > > > tag their versions as cordova-plugin-compat@1.2.0,
>> > > > cordova-plugin-console@1.1.0. The device motion and device
>> orientation
>> > > > plugins can have any version number we want as they will not run
>> into
>> > the
>> > > > above problems.
>> > > >
>> > > >
>> > > > Simon Mac Donald
>> > > > http://simonmacdonald.com
>> > > >
>> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <
>> stevengil...@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > Plugin vote is going to fail it seems due to the issue simon
>> found.
>> > > > >
>> > > > > Simons  message:
>> > > > > "Failed
>> > > > > * Added cordova-plugin-camera to a project with cordova-android
>> 6.3.0
>> > > > which
>> > > > > depends on cordova-plugin-compat and the build fails.
>> > > > >
>> > > > > The reason the build fails is that all of the cordova plugins that
>> > > depend
>> > > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0.
>> > > Since
>> > > > > compat was bumped to 2.0.0 when you install cordova-plugin-camera
>> on
>> > > your
>

Re: [DISCUSS] Plugin release

2017-09-20 Thread Steven Gill
Yeah I only released the plugins that people mentioned in this thread to
release. I can fire up another plugins release next week. What plugins do
people want reviewed/released?

On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <simon.macdon...@gmail.com>
wrote:

> Just realized that cordova-plugin-file-transfer was never bumped. It
> includes an important fix for apps. Without it new apps may be rejected
> from the Play Store.
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
> > the ios release blog post tells users about the console plugin.
> > http://cordova.apache.org/announcements/2017/09/08/ios-release.html
> >
> > I'll make sure to highlight these changes in the plugins release blog
> post.
> >
> > Starting a new vote with console + compat only having minor bumps
> >
> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> > jcesarmob...@gmail.com
> > > wrote:
> >
> > > There has been already a few people asking about the duplicate symbols
> on
> > > slack
> > >
> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald <simon.macdon...@gmail.com
> >:
> > >
> > > > IMHO both cordova-plugin-compat and cordova-plugin-console should
> > receive
> > > > minor version bumps. Neither breaks backwards compatibility so I
> don't
> > > feel
> > > > like a major version bump is warranted.
> > > >
> > > > As well all of our core plugins that depend on cordova-plugin-compat
> > use
> > > > the ^1.x in their semver so they would pull in the earlier version of
> > the
> > > > compat plugin and in combination with the upcoming cordova-android
> > 6.3.0
> > > > pretty much all apps will fail to build.
> > > >
> > > > When it comes to cordova-plugin-console we should also err on the
> side
> > of
> > > > caution when it comes to the version number bump. I spent some time
> > this
> > > > morning debugging an internal app that was using cordova-ios 4.5.0
> and
> > > > cordova-plugin-console. It was failing to build because of duplicate
> > > code.
> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
> > > > cordova-ios 4.5.0 the problem would not have existed.
> > > >
> > > > I think we need to be ready to start answering that question as to
> why
> > > apps
> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in
> > > order?
> > > >
> > > > My recommendations is to restart this vote thread with the four
> plugins
> > > but
> > > > tag their versions as cordova-plugin-compat@1.2.0,
> > > > cordova-plugin-console@1.1.0. The device motion and device
> orientation
> > > > plugins can have any version number we want as they will not run into
> > the
> > > > above problems.
> > > >
> > > >
> > > > Simon Mac Donald
> > > > http://simonmacdonald.com
> > > >
> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <stevengil...@gmail.com
> >
> > > > wrote:
> > > >
> > > > > Plugin vote is going to fail it seems due to the issue simon found.
> > > > >
> > > > > Simons  message:
> > > > > "Failed
> > > > > * Added cordova-plugin-camera to a project with cordova-android
> 6.3.0
> > > > which
> > > > > depends on cordova-plugin-compat and the build fails.
> > > > >
> > > > > The reason the build fails is that all of the cordova plugins that
> > > depend
> > > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0.
> > > Since
> > > > > compat was bumped to 2.0.0 when you install cordova-plugin-camera
> on
> > > your
> > > > > cordova-android 6.3.0 project it fails the semver and it pulls in
> the
> > > > 1.1.0
> > > > > version. Now both compat and cordova-android deliver the same
> classes
> > > and
> > > > > the build fails."
> > > > >
> > > > > I actually have 1.2.0 version of the plugin already tagged from
> when
> > I
> > > > ran
> > > > > the plugin process on Monday. It is identical to the 2.0.0 version
> > that
> > > > is
> > > > &

Re: [VOTE] Plugins Release (attempt 2)

2017-09-20 Thread Steven Gill
discuss thread Simon!

On Wed, Sep 20, 2017 at 4:21 PM, Simon MacDonald <simon.macdon...@gmail.com>
wrote:

> Just realized that cordova-plugin-file-transfer was never bumped. It
> includes an important fix for apps. Without it new apps may be rejected
> from the Play Store.
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Wed, Sep 20, 2017 at 6:01 PM, Joe Bowser <bows...@gmail.com> wrote:
>
> > I vote +1
> >
> > * Verified Archives
> > * Tested MobileSpec and made sure that Camera actually got installed
> > * Tested against master of cordova-android (cordova-android >= 6.3.0)
> >
> > On Wed, Sep 20, 2017 at 11:25 AM, Simon MacDonald <
> > simon.macdon...@gmail.com
> > > wrote:
> >
> > > I vote + 1
> > >
> > > Passed
> > > * Checked for deprecation notices for plugin-device-motion &
> orientation
> > > * Tested that cordova-plugin-console is not added for ios when
> > cordova-ios
> > > >= 4.5.0
> > > * Tested that cordova-plugin-compat is not added for android when
> > > cordova-android >= 6.3.0
> > > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
> > which
> > > depends on cordova-plugin-compat (from github master) and the build
> > passes.
> > >
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > > On Wed, Sep 20, 2017 at 1:57 PM, Steven Gill <stevengil...@gmail.com>
> > > wrote:
> > >
> > > > Please review and vote on the release of this plugins release
> > > > by replying to this email (and keep discussion on the DISCUSS thread)
> > > >
> > > > Release issue: https://issues.apache.org/jira/browse/CB-13294
> > > >
> > > > The plugins have been published to
> > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
> > > >
> > > > The packages were published from their corresponding git tags:
> > > > cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
> > > > cordova-plugin-compat: 1.2.0 (be2a46be8d)
> > > > cordova-plugin-device-motion: 2.0.0 (1236b957af)
> > > > cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
> > > >
> > > > Upon a successful vote I will upload the archives to dist/, upload
> > > > them to npm, and post the corresponding blog post.
> > > >
> > > > Voting guidelines:
> > > > https://github.com/apache/cordova-coho/blob/master/docs/
> > > release-voting.md
> > > > How to vote on a plugins release at
> > > > https://github.com/apache/cordova-coho/blob/master/docs/
> > > > plugins-release-process.md#voting
> > > >
> > > > Voting will go on for a minimum of 48 hours.
> > > >
> > > > I vote +1:
> > > > * Ran coho audit-license-headers over the relevant repos
> > > > * Ran coho check-license to ensure all dependencies and
> > > > subdependencies have Apache-compatible licenses
> > > > * Ensured continuous build was green when repos were tagged
> > > >
> > >
> >
>


[VOTE] Plugins Release (attempt 2)

2017-09-20 Thread Steven Gill
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13294

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/

The packages were published from their corresponding git tags:
cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
cordova-plugin-compat: 1.2.0 (be2a46be8d)
cordova-plugin-device-motion: 2.0.0 (1236b957af)
cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repos were tagged


Re: [DISCUSS] Plugin release

2017-09-20 Thread Steven Gill
the ios release blog post tells users about the console plugin.
http://cordova.apache.org/announcements/2017/09/08/ios-release.html

I'll make sure to highlight these changes in the plugins release blog post.

Starting a new vote with console + compat only having minor bumps

On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <jcesarmob...@gmail.com
> wrote:

> There has been already a few people asking about the duplicate symbols on
> slack
>
> 2017-09-20 17:06 GMT+02:00 Simon MacDonald <simon.macdon...@gmail.com>:
>
> > IMHO both cordova-plugin-compat and cordova-plugin-console should receive
> > minor version bumps. Neither breaks backwards compatibility so I don't
> feel
> > like a major version bump is warranted.
> >
> > As well all of our core plugins that depend on cordova-plugin-compat use
> > the ^1.x in their semver so they would pull in the earlier version of the
> > compat plugin and in combination with the upcoming cordova-android 6.3.0
> > pretty much all apps will fail to build.
> >
> > When it comes to cordova-plugin-console we should also err on the side of
> > caution when it comes to the version number bump. I spent some time this
> > morning debugging an internal app that was using cordova-ios 4.5.0 and
> > cordova-plugin-console. It was failing to build because of duplicate
> code.
> > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
> > cordova-ios 4.5.0 the problem would not have existed.
> >
> > I think we need to be ready to start answering that question as to why
> apps
> > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in
> order?
> >
> > My recommendations is to restart this vote thread with the four plugins
> but
> > tag their versions as cordova-plugin-compat@1.2.0,
> > cordova-plugin-console@1.1.0. The device motion and device orientation
> > plugins can have any version number we want as they will not run into the
> > above problems.
> >
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > Plugin vote is going to fail it seems due to the issue simon found.
> > >
> > > Simons  message:
> > > "Failed
> > > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
> > which
> > > depends on cordova-plugin-compat and the build fails.
> > >
> > > The reason the build fails is that all of the cordova plugins that
> depend
> > > on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0.
> Since
> > > compat was bumped to 2.0.0 when you install cordova-plugin-camera on
> your
> > > cordova-android 6.3.0 project it fails the semver and it pulls in the
> > 1.1.0
> > > version. Now both compat and cordova-android deliver the same classes
> and
> > > the build fails."
> > >
> > > I actually have 1.2.0 version of the plugin already tagged from when I
> > ran
> > > the plugin process on Monday. It is identical to the 2.0.0 version that
> > is
> > > being voted on. We can either stop the current vote thread and start a
> > new
> > > one with 1.2.0 instead of 2.0.0, or we could continue the current vote
> > > thread and start a new one just for compat@1.2.0. If we go with option
> > 2,
> > > we can release both 1.2.0 and 2.0.0.
> > >
> > > This is a good point to remember in the future. Deprecation should be
> > minor
> > > not major bumps.
> > >
> > >
> > > On Tue, Sep 12, 2017 at 11:43 PM, Shazron <shaz...@gmail.com> wrote:
> > >
> > > > Created PR for CB-13170 cordova-plugin-console
> > > > https://github.com/apache/cordova-plugin-console/pull/25
> > > >
> > > > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
> > > > simon.macdon...@gmail.com>
> > > > wrote:
> > > >
> > > > > Both of:
> > > > >
> > > > > cordova-plugin-device-motion
> > > > > cordova-plugin-device-orientation
> > > > >
> > > > > should get their deprecation PR's merge and also released.
> > > > >
> > > > > Simon Mac Donald
> > > > > http://simonmacdonald.com
> > > > >
> > > > >
> > > > > On Mon, Sep 11, 2017 at 7:03 PM, Shazron <shaz...@gmail.com>
> wrote:
> > > > > > +1 on console. No PRs for that y

Re: [VOTE] Plugins Release

2017-09-20 Thread Steven Gill
This vote has failed. I will send out a new one shortly

On Tue, Sep 19, 2017 at 10:28 PM, Steven Gill <stevengil...@gmail.com>
wrote:

> nice catch.
>
> On Tue, Sep 19, 2017 at 8:10 PM, Simon MacDonald <
> simon.macdon...@gmail.com> wrote:
>
>> I vote - 1
>>
>> Passed
>> * Checked for deprecation notices for plugin-device-motion & orientation
>> * Tested that cordova-plugin-console is not added for ios when cordova-ios
>> >= 4.5.0
>> * Tested that cordova-plugin-compat is not added for android when
>> cordova-android >= 6.3.0
>>
>> Failed
>> * Added cordova-plugin-camera to a project with cordova-android 6.3.0
>> which
>> depends on cordova-plugin-compat and the build fails.
>>
>> The reason the build fails is that all of the cordova plugins that depend
>> on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
>> compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
>> cordova-android 6.3.0 project it fails the semver and it pulls in the
>> 1.1.0
>> version. Now both compat and cordova-android deliver the same classes and
>> the build fails.
>>
>>
>>
>> Simon Mac Donald
>> http://simonmacdonald.com
>>
>> On Mon, Sep 18, 2017 at 7:05 PM, Audrey So <a...@adobe.com.invalid>
>> wrote:
>>
>> > I vote + 1
>> >
>> > * Verified signatures
>> >
>> > * Checked for deprecation notices for plugin-device-motion & orientation
>> > * Tested that cordova-plugin-console is not added for ios
>> > * Tested that cordova-plugin-compat is not added for android
>> > * Added plugins to cordova project
>> >
>> >
>> >
>> >
>> > On 9/18/17, 3:05 PM, "Joe Bowser" <bows...@gmail.com> wrote:
>> >
>> > >I vote +1
>> > >
>> > >* Tested cordova-plugin-compat installation to make sure it doesn't
>> > install
>> > >on cordova-android master
>> > >* Ran mobilespec locally
>> > >* Verified signatures
>> > >
>> > >
>> > >On Mon, Sep 18, 2017 at 2:08 PM, Steven Gill <stevengil...@gmail.com>
>> > wrote:
>> > >
>> > >> Please review and vote on the release of this plugins release
>> > >> by replying to this email (and keep discussion on the DISCUSS thread)
>> > >>
>> > >> Release issue: https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
>> > 13294=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
>> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=%
>> > 2B2sZF4YE7bcA8vA4%2BqZgknBBArYMn0mbzXFQMlwkGR4%3D=0
>> > >>
>> > >> The plugins have been published to
>> > >> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
>> > >>
>> > >> The packages were published from their corresponding git tags:
>> > >> cordova-plugin-console: 2.0.0 (f0e113bdf4)
>> > >> cordova-plugin-compat: 2.0.0 (0df201c24d)
>> > >> cordova-plugin-device-motion: 2.0.0 (1236b957af)
>> > >> cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
>> > >>
>> > >> Upon a successful vote I will upload the archives to dist/, upload
>> > >> them to npm, and post the corresponding blog post.
>> > >>
>> > >> Voting guidelines:
>> > >> https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%
>> 2Fmaster%2Fdocs%
>> > 2Frelease-voting.md=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
>> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=
>> > TH5HU27%2FrfoPu6ZjCmQ8ZsLHx2W8LwUCwzSsQ0VCMhA%3D=0
>> > >> How to vote on a plugins release at
>> > >> https://na01.safelinks.protection.outlook.com/?url=
>> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%
>> > 2Fblob%2Fmaster%2Fdocs%2Fplug=02%7C01%7C%
>> > 7C14e404d7c0e7454c718b08d4fee1591a%7Cfa7b1b5a7b34438794aed2c178de
>> > cee1%7C0%7C0%7C636413691211640629=QpsOtFm7U0IYm0RjMC4RQxThr0vb9u
>> > nJ5YuXH6yrrjc%3D=0
>> > >> ins-release-process.md#voting
>> > >>
>> > >> Voting will go on for a minimum of 48 hours.
>> > >>
>> > >> I vote +1:
>> > >> * Ran coho audit-license-headers over the relevant repos
>> > >> * Ran coho check-license to ensure all dependencies and
>> > >> subdependencies have Apache-compatible licenses
>> > >> * Ensured continuous build was green when repos were tagged
>> > >>
>> >
>>
>
>


Re: [DISCUSS] Plugin release

2017-09-19 Thread Steven Gill
Plugin vote is going to fail it seems due to the issue simon found.

Simons  message:
"Failed
* Added cordova-plugin-camera to a project with cordova-android 6.3.0 which
depends on cordova-plugin-compat and the build fails.

The reason the build fails is that all of the cordova plugins that depend
on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
cordova-android 6.3.0 project it fails the semver and it pulls in the 1.1.0
version. Now both compat and cordova-android deliver the same classes and
the build fails."

I actually have 1.2.0 version of the plugin already tagged from when I ran
the plugin process on Monday. It is identical to the 2.0.0 version that is
being voted on. We can either stop the current vote thread and start a new
one with 1.2.0 instead of 2.0.0, or we could continue the current vote
thread and start a new one just for compat@1.2.0. If we go with option 2,
we can release both 1.2.0 and 2.0.0.

This is a good point to remember in the future. Deprecation should be minor
not major bumps.


On Tue, Sep 12, 2017 at 11:43 PM, Shazron <shaz...@gmail.com> wrote:

> Created PR for CB-13170 cordova-plugin-console
> https://github.com/apache/cordova-plugin-console/pull/25
>
> On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
> simon.macdon...@gmail.com>
> wrote:
>
> > Both of:
> >
> > cordova-plugin-device-motion
> > cordova-plugin-device-orientation
> >
> > should get their deprecation PR's merge and also released.
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> >
> > On Mon, Sep 11, 2017 at 7:03 PM, Shazron <shaz...@gmail.com> wrote:
> > > +1 on console. No PRs for that yet though so it's not ready.
> > >
> > > On Tue, Sep 12, 2017 at 5:46 AM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> > >
> > >> Console should be released too since it has been moved back into ios
> for
> > >> next release. https://issues.apache.org/jira/browse/CB-13170
> > >>
> > >> On Sep 11, 2017 2:04 PM, "Jesse" <purplecabb...@gmail.com> wrote:
> > >>
> > >> > Android release is dependent on us releasing an
> > >> > updated cordova-plugin-compat
> > >> >
> > >> > Anyone have any reasons to not do a release? Anything outstanding
> > >> > anyone wants to get merged in before moving ahead with a plugins
> > >> > release? Any other comments on the topic?
> > >> >
> > >> > Cheers,
> > >> >   Jesse
> > >> >
> > >> >
> > >> > @purplecabbage
> > >> > risingj.com
> > >> >
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [VOTE] Plugins Release

2017-09-19 Thread Steven Gill
nice catch.

On Tue, Sep 19, 2017 at 8:10 PM, Simon MacDonald <simon.macdon...@gmail.com>
wrote:

> I vote - 1
>
> Passed
> * Checked for deprecation notices for plugin-device-motion & orientation
> * Tested that cordova-plugin-console is not added for ios when cordova-ios
> >= 4.5.0
> * Tested that cordova-plugin-compat is not added for android when
> cordova-android >= 6.3.0
>
> Failed
> * Added cordova-plugin-camera to a project with cordova-android 6.3.0 which
> depends on cordova-plugin-compat and the build fails.
>
> The reason the build fails is that all of the cordova plugins that depend
> on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since
> compat was bumped to 2.0.0 when you install cordova-plugin-camera on your
> cordova-android 6.3.0 project it fails the semver and it pulls in the 1.1.0
> version. Now both compat and cordova-android deliver the same classes and
> the build fails.
>
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Mon, Sep 18, 2017 at 7:05 PM, Audrey So <a...@adobe.com.invalid> wrote:
>
> > I vote + 1
> >
> > * Verified signatures
> >
> > * Checked for deprecation notices for plugin-device-motion & orientation
> > * Tested that cordova-plugin-console is not added for ios
> > * Tested that cordova-plugin-compat is not added for android
> > * Added plugins to cordova project
> >
> >
> >
> >
> > On 9/18/17, 3:05 PM, "Joe Bowser" <bows...@gmail.com> wrote:
> >
> > >I vote +1
> > >
> > >* Tested cordova-plugin-compat installation to make sure it doesn't
> > install
> > >on cordova-android master
> > >* Ran mobilespec locally
> > >* Verified signatures
> > >
> > >
> > >On Mon, Sep 18, 2017 at 2:08 PM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> > >
> > >> Please review and vote on the release of this plugins release
> > >> by replying to this email (and keep discussion on the DISCUSS thread)
> > >>
> > >> Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13294=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=%
> > 2B2sZF4YE7bcA8vA4%2BqZgknBBArYMn0mbzXFQMlwkGR4%3D=0
> > >>
> > >> The plugins have been published to
> > >> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
> > >>
> > >> The packages were published from their corresponding git tags:
> > >> cordova-plugin-console: 2.0.0 (f0e113bdf4)
> > >> cordova-plugin-compat: 2.0.0 (0df201c24d)
> > >> cordova-plugin-device-motion: 2.0.0 (1236b957af)
> > >> cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
> > >>
> > >> Upon a successful vote I will upload the archives to dist/, upload
> > >> them to npm, and post the corresponding blog post.
> > >>
> > >> Voting guidelines:
> > >> https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629=
> > TH5HU27%2FrfoPu6ZjCmQ8ZsLHx2W8LwUCwzSsQ0VCMhA%3D=0
> > >> How to vote on a plugins release at
> > >> https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%
> > 2Fblob%2Fmaster%2Fdocs%2Fplug=02%7C01%7C%
> > 7C14e404d7c0e7454c718b08d4fee1591a%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636413691211640629=QpsOtFm7U0IYm0RjMC4RQxThr0vb9u
> > nJ5YuXH6yrrjc%3D=0
> > >> ins-release-process.md#voting
> > >>
> > >> Voting will go on for a minimum of 48 hours.
> > >>
> > >> I vote +1:
> > >> * Ran coho audit-license-headers over the relevant repos
> > >> * Ran coho check-license to ensure all dependencies and
> > >> subdependencies have Apache-compatible licenses
> > >> * Ensured continuous build was green when repos were tagged
> > >>
> >
>


  1   2   3   4   5   6   7   8   9   10   >