Re: Nomination for a new chair for Apache Cordova
+1 Bryan has been a great a team member and remains dedicated towards the development since years! On Fri, Dec 1, 2023 at 5:36 PM Norman Breau wrote: > +1 > > On 2023-11-29 9:52 p.m., Jesse wrote: > > Hello friends! I have been the chair of Apache Cordova since around > > December of 2018, roughly 5 years. My duties of late have been mostly > > administrative: board reports, PMC management etc. Some of it is listed > > here in the README: > https://github.com/apache/cordova-apache-board-reports > > I think it is time for new leadership and I have decided to resign my > > duties as the Apache Cordova chair. I formally nominate Bryan Ellis as > the > > next chair. > > Bryan has been a consistently motivated contributor to the project and > has > > been diligently pushing through many of our releases over the last > several > > years. I believe Bryan will be great in this new role and I will do my > > best to help him. Bryan is very familiar with and helps uphold 'The > Apache > > Way' > > (https://www.apache.org/foundation/how-it-works.html) and he will be a > > great liaison with the Board. I won't be far, I plan to remain in the > > community and will always be reachable, though I am going to be more > > focused on personal goals. I am always available to answer questions > and > > help sort issues. Cheers, > >Jesse > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [VOTE] cordova-plugin-camera 7.0.0 Release
I vote +1: - verified tags - verified archive - npm audit has no issues - no linting issues - changes look good On Wed, Sep 6, 2023 at 1:36 PM Norman Breau wrote: > I vote +1: > > - No NPM Audit issues > - Ran npm test on linux > - Ran dev version of the plugin against a real project > - Ran paramedic tests with API 24 simulator (pre-scoped storage test) > - Ran paramedic tests with API 32 simulator (scoped storage test) > - Ran paramedic tests with API 33 simulator (scoped storage test w/ > granular permissions) > - Verified Archive > - Verified Tags > > On 2023-09-06 5:44 a.m., Bryan Ellis wrote: > > Please review and vote on this cordova-plugin-camera Release v7.0.0 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > > > https://dist.apache.org/repos/dist/dev/cordova/camera-v7.0.0 > > > > The package was published from its corresponding git tag: > > > > cordova-plugin-camera: 7.0.0 (24839eb71f) > > > > Note that you can test it out via: > > > > cordova plugin add > https://github.com/apache/cordova-plugin-camera#7.0.0 > > > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > = > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > > * NPM Audit (found 0 vulnerabilities) > > * NPM Test > > * Ran `cordova build` test > > * Ran `cordova run` emulator test (iOS & Android) > > * Ran `cordova plugin add` test > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [VOTE] cordova-plugin-screen-orientation release 3.0.3
I vote +1 - coho verify-archive OK - coho verify-tags OK - npm test OK - CI is green for tag - changes look good to me Thanks for the effort, Niklas! On Tue, Feb 21, 2023 at 10:54 PM Norman Breau wrote: > I vote +1 > > - Local NPM test (linux) passes > - NPM audit passes > - Verified Archive > - Verified Tags > - CI is green > > On 2023-02-21 5:39 p.m., Niklas Merz wrote: > > Please review and vote on the release of this plugins release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The plugins have been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/screenorientation3.0.3/ > > > > The packages were published from their corresponding git tags: > > cordova-plugin-screen-orientation: 3.0.3 (8a8fc1d98a) > > > > Upon a successful vote I will upload the archives to dist/, upload them > > to npm, and post the corresponding blog post: > > https://github.com/apache/cordova-docs/pull/1288 > > > > Voting guidelines: https://github.com/apache/cordova- > > coho/blob/master/docs/release-voting.md > > How to vote on a plugins release at https://github.com/apache/cordova- > > coho/blob/master/docs/plugins-release-process.md#voting > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1 > > > > I checked: > > > > * no license header issues (coho audit-license-headers -r .| less) > > * licenses compliant with Apache policy (coho check-license -r .) > > * signature ok > > * tests pass in CI > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] Enable github discussions
+1 to GH Discussions. Hopefully lowers the barrier for folks to engage. And given the amount of "bug reports" that are actually support requests it might be beneficial if we can a) keep the discussion on GitHub b) better preserve the history for future users On Mon, Nov 21, 2022 at 12:52 PM Norman Breau wrote: > For Slack, I've been using an invite link that "does not expire", however, > the invite link does have a limit of 1,000 people. Therefore it's not > very suitable > for a long time usage or as a permanent link and it will need to be > regenerated > occasionally. This is what makes GitHub Discussions much more accessible. > > Additionally, discussions has more powerful organizing features and can > be linked > whereas Slack discussions tends to get lost. > > So +1 from me to use GitHub discussions for support. > > On 2022-11-21 3:10 a.m., Niklas Merz wrote: > > Hey everyone, > > > > I quite like GitHub discussion for support over chat tools like Slack. > > Slack is not really accessible for users and the limitations of the free > > plan are not good. We still could use the official ASF Slack for some > > things like chatting in the PMC, DMs etc. > > > > A nice thing about GitHub discussions is that you can convert > > discussions to issues and vice versa. So it's easy to turn an issue > > which is actually a support question to a discussion or the other way > > around. > > > > Therefore big +1 from me. > > > > On November 20, 2022, Jesse wrote: > >> Hello all, > >> > >> github discussions are a great way of keeping code conversations very > >> close > >> to the actual code and I think would suit our project better than our > >> use > >> of #slack > >> > >> The apache airflow project switched to use discussions [1] > >> This is not configurable via asf.yml [2] and requires an infra ticket > >> linking a consensus reaching discussion. [3] > >> > >> I propose that we enable discussions on the apache/cordova repo [4] to > >> evaluate, and we can possibly make a decision to include other repos > >> later. > >> > >> What do you think? > >> > >> Cheers, > >> Jesse > >> > >> [1] > >> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191332632#GitHubIssues/Discussions- > >> GithubIssuesandDiscussions > >> [2] > >> https://cwiki.apache.org/confluence/display/INFRA/Git+- > >> +.asf.yaml+features > >> [3] > >> https://cwiki.apache.org/confluence/display/INFRA/Git+- > >> +.asf.yaml+features#Git.asf.yamlfeatures-GitHubDiscussions > >> [4] https://github.com/apache/cordova > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust timbrust3...@gmail.com
Re: Plugin Search
+1 to #2 On Fri, Oct 21, 2022 at 5:48 PM Jesse wrote: > #2 makes the most sense to me too, easiest to support long term > > > On Oct 21, 2022, at 8:17 AM, julio cesar sanchez > wrote: > > > > +1 to option #2 > > > > Niklas, option 2 already mentions having a link to the npm search with > > cordova ecosystem prefilled for easier searching of other 3rd party > plugins > > > >> El El vie, 21 oct 2022 a las 16:39, Niklas Merz > >> escribió: > >> > >> I'm +1 on #2, too. Making clear which plugins are Official and supported > >> actively is a good idea. And just a simple note on how to find more on > >> npm is enough IMHO. > >> > >>> On October 21, 2022, Norman Breau wrote: > >>> Hi Team, > >>> > >>> I want to reach a final verdict on how deal with the broken search > >>> page > >>> at https://cordova.apache.org/plugins/ > >>> > >>> We have an active issue being tracked at > >>> https://github.com/apache/cordova-docs/issues/1128 but in summary, > >>> the rest service used to power the search has gone offline and > >>> doesn't > >>> appear to be coming back. > >>> > >>> Throughout the thread there has been several ideals about how to move > >>> forward including: > >>> > >>> 1. Using another third-party API service: https://api-docs.npms.io/ > >>> 2. Having a static page listing the officially supported Apache > >>> plugins, > >>> with a link to https://www.npmjs.com/search?q=ecosystem%3Acordova > >>> 3. Removing the page entirely, maybe with a blog post explaining how > >>> to > >>> find third-party plugins. > >>> > >>> Additionally there are few ideas floated around with using the NPM > >>> Couch > >>> API directly, but there may be terms of use issues involved without > >>> having self-managed server hosting a mirror. > >>> > >>> Personally, I vote -1 for #1 and #3. npms.io doesn't have a clear > >>> terms > >>> of use, as far as I can find. I'm not sure if the API matches the old > >>> npmsearch that we did use, and we may just run into the same issue > >>> down the road. For #3, community members have already explicitly > >>> expressed dissent with removing the page entirely. > >>> > >>> I vote +1 for #2, having the static page with a mention + link to NPM > >>> for third-party plugins. I think this is most likely the best path > >>> forward. > >>> > >>> > >>> > >>> - > >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust timbrust3...@gmail.com
Re: [VOTE] Camera Plugin Release 5.0.1
I vote +1: * changes make sense * coho-verify archive * npm audit passes locally * npm test passes locally On Wed, Nov 4, 2020 at 1:54 PM Niklas Merz wrote: > I vote +1 > > * checked signature and hash with coho-verify archive > * checked licenses > * no audit issues > * checked tag > * local paramedic run with ios successfull > > November 4, 2020 2:53 AM, "Bryan Ellis" wrote: > > > Please review and vote on this Cordova Plugin Camera Release v5.0.1 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/camera-20201104 > > > > The package was published from its corresponding git tag: > > cordova-plugin-camera: 5.0.1 (0d13b71d33) > > > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog > > post. > > > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and sub-dependencies > have Apache-compatible > > licenses > > * Ensured the npm audit report was sufficient for release > > > > * AS there are issues within the CI testing service accross ALL plugins, > for this release I have > > manually tested: > > * Build Mobile Spec project for iOS & Android w/ CLI > > * Run Mobile Spec project on iOS & Android simulator w/ CLI > > * Executed the Mobile Spec Jasmine tests on iOS & Android > > > > Audit Report: > > > > 0 vulnerabilities found > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [Discuss] Cordova Hangout NewEra#2
I'm +1 for doing the meeting tomorrow. For the lazy people, I've once again put the date into the world clock: https://www.timeanddate.com/worldclock/fixedtime.html?msg=Cordova+Committer+Video+Chat=20200917T15=%3A=1 Maybe we can talk about the donation offer once again and (finally?) make a decision what to do with it. Best, Tim On Wed, Sep 16, 2020 at 10:38 AM Jesse wrote: > As alluded to in the private conversations in #slack, we are tentatively > having a meetup on Thursday the 17th at 8 AM PDT. This timeframe does not > work great for everyone, but none ever will, and I think that is okay, we > are distributed, and these meetings are about discussion and collaboration > more than decision making so no one should feel left out, or obligated to > attend. > > That said, we haven't got a lot of time before Thursday morning ... ~30 > hours, and I would like us to have some defined discussion points, ideally > brought up by people who would like to present them. > > How does everyone feel about going ahead with the hangout this week? We > could also push back a week. > Who has a topic they would like to present for discussion? > > Cheers, > Jesse > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: Team page on Cordova website
> Cheers, > > >> Raphael > > >> > > >> [1] > > >> > https://github.com/apache/cordova-lib/graphs/contributors?from=2018-04-02=2020-04-02=c > > >> > > >> Am Sa., 22. Feb. 2020 um 15:55 Uhr schrieb Niklas Merz < > > >> niklasm...@apache.org>: > > >> > > >> Hi everyone, > > >> > > >> Like discussed before I think it might be a good idea to add a page to > > >> our website for Cordova users to get to know the community members. > > >> > > >> I am writing here because to me this only makes sense if most of the > > >> active committers are involved and want to be part of this list. > > >> > > >> I created this PR with the first draft and some screenshots: > > >> https://github.com/apache/cordova-docs/pull/1063 > > >> > > >> There are still some open points to do and discuss. I am not the best > > >> web designer and would appreciate any help. Feel free to push to this > > >> branch or create PRs any time. > > >> > > >> Looking forward to make this happen. > > >> > > >> Kind regards > > >> Niklas > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > >> For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: Deprecate outdated Cordova platforms - motion
Hi, correct me if I'm wrong, but isn't the deprecation missing a formal vote? Best, Tim On Fri, Sep 4, 2020 at 4:52 AM Chris Brody wrote: > I have now raised the following PRs: > > - https://github.com/apache/cordova-lib/pull/851 > - https://github.com/apache/cordova-lib/pull/852 > - https://github.com/apache/cordova-docs/pull/1117 > - https://github.com/apache/cordova-docs/pull/1118 > > > On Fri, Jun 26, 2020 at 4:38 AM Niklas Merz wrote: > > > +1 from me > > > > Am 26. Juni 2020, 03:20, um 03:20, Chris Brody > > schrieb: > > >I would continue to vote for immediate deprecation of both cordova-osx > > >and > > >cordova-windows. > > > > > >Not only would cordova-osx lose relevance due to both Catalyst and > > >cordova-electron, it is already obsolete due to lack of support for > > >CocoaPods. This basically makes cordova-osx now unusable for me when I > > >start using SQLite3 pods in new plugin development. And we know that > > >cordova-windows is not supported by Visual Studio 2019. > > > > > >Immediate deprecation at this point would allow us to drop support > > >within > > >the next year or so. We are already overloaded by the work of > > >supporting > > >the other Cordova platforms. > > > > > > > > >On Wed, Jun 24, 2020 at 2:37 AM Niklas Merz > > >wrote: > > > > > >> I agree with the that. Personally I never used these platforms for > > >app and > > >> plugin development. I cannot tell for Windows but for macOS the > > >alternative > > >> is pretty clear. > > >> > > >> Like Darryl wrote in the OSX thread, we should wait for Catalyst to > > >be > > >> stable and then formally deprecate the osx platform. It has not > > >recieved > > >> any major updates for some time anyways. > > >> > > >> June 23, 2020 11:01 PM, "Darryl Pogue" wrote: > > >> > > >> > I think the best path forward for Cordova apps on macOS is either > > >> > through cordova-ios with Catalyst, or through cordova-electron. > > >> > > > >> > Most plugins don't support the osx platform, but do have > > >> > implementations for iOS, so Catalyst is probably the best choice > > >from > > >> > an ecosystem perspective for most people. It will also come pretty > > >> > close to guaranteeing support for the new Apple Silicon platform. > > >> > > > >> > IMO once we have support for Catalyst in cordova-ios, we should > > >look > > >> > to deprecate cordova-osx. > > >> > > > >> > ~Darryl > > >> > > >> June 24, 2020 4:40 AM, "Chris Brody" wrote: > > >> > > >> > It seems to me like both cordova-osx and cordova-windows are now > > >outdated > > >> > for various known reasons: > > >> > > > >> > - cordova-osx has outdated platform name and does not support > > >CocoaPods > > >> > - cordova-windows requires previous Visual Studio version 2017 to > > >build > > >> > > > >> > Given that: > > >> > > > >> > - These desktop platforms are known to be outdated. > > >> > - It is possible to use cordova-electron to support these and other > > >> desktop > > >> > platforms. > > >> > - It would be possible to build iOS apps for macOS starting with > > >> Catalina, > > >> > using Catalyst, once we solve > > >> > https://github.com/apache/cordova-ios/issues/699 > > >> > - We have more than enough work on our hands to support the > > >> non-deprecated > > >> > Cordova platforms. > > >> > > > >> > I would vote to: > > >> > > > >> > - deprecate these platforms now > > >> > - plan to remove support in a future major release (not now) > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > >> For additional commands, e-mail: dev-h...@cordova.apache.org > > >> > > >> > > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: Migrate Sauce Labs user used in CI testing from snay to cordova
I think I've found the main blocker:
GH Actions secrets are not exposed to PRs from forks. :(
There is an open feature request for this though:
https://github.community/t/make-secrets-available-to-builds-of-forks/16166
Cheers,
Tim
On Mon, Aug 31, 2020 at 8:53 PM Jan Piotrowski wrote:
> You might go slow on this - somewhere in the back of my head I have
> _something_ why we did not follow through with this in the past but I can
> not figure out what it was, sorry :/ Hopefully it is nothing and will just
> work.
>
> J
>
>
>
> Am So., 30. Aug. 2020 um 19:55 Uhr schrieb Tim Brust <
> timbrust3...@gmail.com
> >:
>
> > Hi there,
> >
> > I'd like to continue to migrate our testing setup from TravisCI to GitHub
> > Actions. Currently, our plugins are all running on Travis and test
> against
> > VMs on Sauce Labs [1] and are not yet migrated.
> >
> > They currently use the Travis-encrypted credentials of Alexander
> ("snay").
> > Since I do not have those credentials, I can't open an INFRA ticket to
> add
> > the access key as a secret to GH Actions.
> >
> > Luckily, Jan created a user called "cordova" which seems more fitting
> than
> > a personal/private user account, too. Also, the credentials are properly
> > checked into our SVN and could be used for manual testing of specific
> > device combos. The accounts should be identical as Sauce Labs offers 5
> VMs
> > for open source users for free.
> >
> > Therefore, I'd like to switch all our Sauce Labs tests to the cordova
> > account when I start (try) the migration to GH actions for the remaining
> > repos. As you all know, no ETAs on these tasks :)
> >
> > Let me know what you think. Ideally I'd like to omit the discussion if
> > Sauce Labs is needed at all in this thread.
> >
> > Best,
> > Tim
> >
> > [1] - https://app.saucelabs.com/open_sauce/user/snay/tests
> > --
> > Tim Brust
> >
>
--
Tim Brust, Product Engineer
tim.br...@sinnerschrader.com
T +49 40 398855 315
SinnerSchrader Deutschland GmbH | SinnerSchrader Group
Völckersstraße 38, 22765 Hamburg, Germany
Amtsgericht Hamburg HRB-Nr. 63663
Geschäftsführer: Matthias Schrader (Sprecher),
Jürgen Alker, Dr. Axel Averdung, Holger Blank,
Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson
Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag
https://www.sinnerschrader.com | NEXT AGENCY
Re: [DISCUSS] cordova-plugin-camera 5.0.0 Major Release
The Android bug that prevented the 4.2.0 release is fixed in the meantime? Can't recall if there is a to-do left. On Thu, Sep 3, 2020 at 6:49 AM Bryan Ellis wrote: > Does anyone have any reason to delay a cordova-plugin-camera major release > (5.0.0)? > > Any additional outstanding changes to land? > > - Android tasks to use AndroidX will not be included in this release since > Cordova-Android does not have AndroidX enabled by default. > > If not, I will start the release process shortly. -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] Cordova-iOS 6.1.1 Release
I vote +1 - CI is green - changes make sense - npm audit is happy - coho verify-archive is happy Thanks Darryl for making the release! On Sat, Aug 29, 2020 at 9:01 AM Niklas Merz wrote: > I vote +1 > > * verified tag and hash > * no audit issues > * draft tag matches sha in email (checked manually) > * checked LICENSE + NOTICE > * CI green > * changes look good > > > > One minor issue: coho verify-tags does not work with new "draft" naming > > > Am 28.08.20 um 23:31 schrieb Darryl Pogue: > > Hi folks, > > Apologies for the delay in getting this release together! > > > > Please review and vote on this 6.1.1 Cordova-iOS release by replying > > to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/ios611/ > > > > The package was published from its corresponding git tag (draft/6.1.1): > > cordova-ios: 6.1.1 (3ba64485f3) > > > > Note that you can test it out via: > > cordova platform add github:apache/cordova-ios#draft/6.1.1 > > > > Upon a successful vote I will upload the archive to dist/, publish it > > to npm, and post the blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Updated dependencies and verified no npm audit warnings > > * Ran npm tests locally and confirmed passing > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Migrate Sauce Labs user used in CI testing from snay to cordova
Hi there,
I'd like to continue to migrate our testing setup from TravisCI to GitHub
Actions. Currently, our plugins are all running on Travis and test against
VMs on Sauce Labs [1] and are not yet migrated.
They currently use the Travis-encrypted credentials of Alexander ("snay").
Since I do not have those credentials, I can't open an INFRA ticket to add
the access key as a secret to GH Actions.
Luckily, Jan created a user called "cordova" which seems more fitting than
a personal/private user account, too. Also, the credentials are properly
checked into our SVN and could be used for manual testing of specific
device combos. The accounts should be identical as Sauce Labs offers 5 VMs
for open source users for free.
Therefore, I'd like to switch all our Sauce Labs tests to the cordova
account when I start (try) the migration to GH actions for the remaining
repos. As you all know, no ETAs on these tasks :)
Let me know what you think. Ideally I'd like to omit the discussion if
Sauce Labs is needed at all in this thread.
Best,
Tim
[1] - https://app.saucelabs.com/open_sauce/user/snay/tests
--
Tim Brust
Re: Hi !!
Hi Narveer, a warm welcome to you! Looking forward to seeing some contributions from you. :) Cheers, Tim On Thu, Aug 27, 2020 at 8:20 PM Narveer Rathore < rathore.narveer1...@gmail.com> wrote: > Hello, I have been using cordova for the past 3 years on one of our core > products. Glad to be part of the community and opportunities to learn more. > > Thanks, > Narveer Singh Rathore > rathore.narveer1...@gmail.com > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [DISCUSS] cordova-ios 6.1.1 patch release
+1 Thanks for taking the initiative, Darryl! Sent from my iPhone > On 20. Aug 2020, at 9:53 PM, Niklas Merz wrote: > > +1 sounds like a good time to release a patch > >> Am 20.08.20 um 21:38 schrieb Chris Brody: >> +1 >> >>> On Thu, Aug 20, 2020 at 3:30 PM Darryl Pogue wrote: >>> >>> Anyone have any objections to making a cordova-ios 6.1.1 patch release? >>> Namely, it fixes an issue where deploying to devices doesn't work. >>> >>> Diff from 6.1.0: >>> https://github.com/apache/cordova-ios/compare/6.1.0...master >>> >>> I don't really want to try to rush anything else into this release, just a >>> patch version to fix running on devices. >>> >>> ~Darryl >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-file-transfer
+1 Sent from my iPhone > On 18. Aug 2020, at 8:22 AM, Dave Alden wrote: > > +1 > >> On Tue, 18 Aug 2020, 05:47 Bryan Ellis, wrote: >> >> This vote is only for the purpose of unarchive and remove the deprecation >> status for the plugin of: >> >> cordova-plugin-file-transfer >> >> Please keep the discussion in the discussion thread. >> >> Vote will follow the usual voting rules: >> * Minimum of 48 Hours >> * 2 + 1 Binding Vote >> >> +1 >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Revive/Undeprecate cordova-plugin-file-transfer
Hi there, I'd like to discuss the revival of the cordova-plugin-file-transfer plugin. With the decision from 2017 it was sunsetted and the XHR/fetch alternative was proposed. [1], [2] However, neither the plugin was deprecated on npm nor the GitHub repository archived. With the release of cordova-ios@6 it is no longer usable. [3] No surprise given the fact no work as has been done on the plugin in the recent years. However, it seems that 1. A lot of people are still relying on the plugin - the count of unique users that commented, opened a duplicate issue or reacted to comments is (IMHO) very high compared to other issues (and I read at least 90% of our newly opened issues). [3] 2. There are reasons to *not *use XHR/fetch. Personally, I've experienced out of memory issues which resulted in white screens and page reloads on iOS with big files. If it helps, I can try to provide an example app that showcases the issues with XHR/fetch. We've created a fork at work and applied a lot of the recent fixes we did for other plugins, too, such as removing deprecated platforms, migrating to @cordova/eslint, cleaning up the package.json files and npmignore list. I'm happy to contribute those commits back to the original plugin, as the work is done anyways. The same discussion could be applied to other plugins, too. There is a general tracking issue: [4], take a note at especially this comment [5] I'll link this mailing thread to the issue [4], too, and ask affected users to give some more input why they can't migrate to XHR/fetch, too. Looking forward to hearing from you and your opinions. Best, Tim Links: [1] - https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html [2] - https://issues.apache.org/jira/browse/CB-13052 [3] - https://github.com/apache/cordova-plugin-file-transfer/issues/258 [4] - https://github.com/apache/cordova/issues/185 [5] - https://github.com/apache/cordova/issues/185#issuecomment-569979586 -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: Formally deprecate cordova-plugin-wkwebview-engine?
npm paclages can be deprecated without releasing a new version. Sent from my iPhone > On 6. Jul 2020, at 12:45 AM, Norman Breau wrote: > > Ok so general consensus is that we should deprecate, but we must first > release a version that to restrict > the plugin from being installed on cordova-ios platform. This is already done > and merged via > https://github.com/apache/cordova-plugin-wkwebview-engine/pull/158 so I think > all we need is a release. > > To get the deprecation notice on NPM readme, we'd also need a release. Does > this mean we need two different releases? > > I'd be more than happy to take the initiative to start the release process, > but I don't have a mac, so I won't be able to run the native unit tests, > locally. This isn't exactly blocking, but I'm not sure if there is anything > else in this repo that would require a mac for publishing. I also don't have > npm publishing rights. > >> On 2020-07-03 3:43 p.m., julio cesar sanchez wrote: >> Yeah, I think we can deprecate it since cordova-ios 6 works the same way by >> default, but as Darryl said, we should do a last release with the engines >> properly configured to not install in cordova-ios 6. >> >> El El vie, 3 jul 2020 a las 20:04, Darryl Pogue >> escribió: >> >>> I don't know that we want to go as far as deprecating it just yet, but >>> we should definitely do a release that prevents it from being >>> installed with cordova-ios 6 (since it conflicts). >>> >>> On Fri, Jul 3, 2020 at 10:50 AM Chris Brody wrote: It would definitely be nice if we don't have to support that plugin any longer, and I think it would be good to archive it as well. My one >>> comment is that there should be a very clear guide for people who have to >>> continue using the same scheme due to data stored by the web view. A couple of off-topic items that I think are related: I think we should recommend that people consider using native plugins >>> such as cordova-plugin-file, SQLite, or something similar for storing >>> important data.. I have seen quite a few things such as local storage deleting >>> data, IndexedDB eviction, and other things going wrong to trust the WebView to not lose data. I think we should deprecate and archive some other plugins in the near future, due to the support burden, as I proposed in: https://github.com/apache/cordova/issues/185 On Fri, Jul 3, 2020 at 1:28 PM Norman Breau >>> wrote: > Hi team, > > I believe previously we decided on a path to deprecate > cordova-plugin-wkwebview-engine, but I wanted > to make sure that is still our stance. > > cordova-ios@6 supports both url schemes and the legacy file scheme, > effectively making the wkwebview engine plugin redundant. Now that > cordova-ios@6 is released, I feel like it's time to formally deprecate > the wkwebview plugin according to our Deprecation Policy[1] > > With that being said, I'm not sure if we also want to archive this > repository. According to the policy, we should archive if: > > "A deprecated repository might also be archived if we don't intend to > provide support of any kind (Issues, Pull Requests, Releases) for this > component any more." > > I feel like this is probably our intention as I think all maintenance > will now be done in cordova-ios going forward, but I want to gather >>> some > thoughts on this. > > [1]https://cordova.apache.org/deprecation_policy.html > > Cheers, > Norman > > > > - > To unsubscribe, e-mail:dev-unsubscr...@cordova.apache.org > For additional commands, e-mail:dev-h...@cordova.apache.org > > >>> - >>> To unsubscribe, e-mail:dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail:dev-h...@cordova.apache.org >>> >>> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Cordova-Common 4.0.2 Release
I vote +1: - ✅ coho verify-archive cordova-common-4.0.2.tgz - CI is green - changes make sense - LICENSE and NOTICE file are present - ✅ npm cit locally On Wed, Jul 1, 2020 at 4:51 PM Niklas Merz wrote: > I vote +1 > > * verified hash > * verified signature > * npm install and no audit issues > * checked license headers > * checked existence of license > * checked tag with coho > * CI green > * tests pass locally > * changes make sense for patch > > July 1, 2020 4:31 PM, "Bryan Ellis" wrote: > > > Please review and vote on this Cordova Common v4.0.2 Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/common-v4.0.2 > > > > The package was published from its corresponding git tag: > > cordova-common: 4.0.2 (f2c2a8d326) > > > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog > > post. > > > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho "audit-license-headers" over the relevant repos > > * Ran coho "check-license" to ensure all dependencies and > subdependencies have Apache-compatible > > licenses > > * Ensured the continuous build was green when repo was tagged > > * Ensured the "npm audit" had 0 vulnerabilities at time of release vote > creation > > * Ensure the "npm tests" were passing locally and on CI services > > * Ran build test > > * Run simulator test > > * Tested with two plugins that contains a "config-file" element > targeting "*-Info.plist" > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] cordova-plugin-inappbrowser 4.0.0 release
Thanks for taking care of this release, Niklas. I vote +1: - Changes make sense ( https://github.com/apache/cordova-plugin-inappbrowser/compare/3.2.0...4.0.0) - Tested our existing iOS app with cordova-ios@5.1.1 - works fine - Tested a new hello world app with cordova-ios@6.0.0 - works fine - ✅ coho verify-archive cordova-plugin-inappbrowser-4.0.0.tgz - ✅ npm audit - ✅ npm test On Tue, Jun 9, 2020 at 7:24 PM Niklas Merz wrote: > Please review and vote on the release of this plugin release > by replying to this email (and keep discussion on the DISCUSS thread) > > The plugin has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-inappbrowser-4.0.0/ > > The packages were published from their corresponding git tags: > cordova-plugin-inappbrowser: 4.0.0 (d2b512ed04) > > Releasenotes: > > https://github.com/apache/cordova-plugin-inappbrowser/blob/master/RELEASENOTES.md#400-jun-09-2020 > > Upon a successful vote I will upload the archives to dist/, upload them > to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting > > Please check the release blog post, too: > https://github.com/apache/cordova-docs/pull/1085 > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repos were tagged > * Checked for existence of LICENSE and NOTICE files > * npm audit green > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: Modernize cordova-android build?
+1 to Norman's statement. However, I believe the PR is not ready to be merged at the moment. On Mon, Jun 8, 2020 at 2:23 PM Norman Breau wrote: > Yes, I had a misunderstanding from the Android documentation, I think > you can use any JDK version as long as it's at least version 8, because > in the gradle config, we declare that we want to compile for JDK 1.8 at > > https://github.com/apache/cordova-android/blob/a830145f36c8bba2ecdf7910f3699116d4c2f018/framework/build.gradle#L58-L61 > > I would +1 easing the restriction of the JDK version check so that it > allows JDK 8+ so users don't need to have multiple java environments > installed just to use Cordova. JDK8 end of life is also at the end of > this year. > > On 2020-06-08 5:04 a.m., julio cesar sanchez wrote: > > There is a PR to allow any jdk version, we mistakenly thought java 8 was > > required for android development, but looks like we were wrong. > > > > https://github.com/apache/cordova-android/pull/928 > > > > > > El lunes, 8 de junio de 2020, Darryl Pogue escribió: > > > >> On Sun, Jun 7, 2020 at 7:49 PM Chris Brody > wrote: > >>> Another thing is that many build systems are now using a Gradle > wrapper, > >>> while Cordova still needs the Gradle tool to be installed in its search > >>> path. This may be related to a nasty-looking issue here: > >>> https://github.com/apache/cordova-android/issues/845 > >> I seem to recall that we have to use the system-installed gradle to > >> generate our gradle wrapper, because the wrapper depends on a JAR file > >> and we're not allowed to distribute JAR files. > >> > >> Previous mailing list discussion regarding gradle wrapper distribution: > >> https://lists.apache.org/thread.html/9fcaf3cd6b22e9cd6d09e17ff5956b > >> f661c3560be923f734dcc4450e%401403096149%40%3Cdev.cordova.apache.org%3E > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: Strongly deprecating the FileTransfer plugin
While I agree that we should somehow archive old code, I'm still -1 on a deprecation of this plugin. (We've had some discussion about it here, too: https://github.com/apache/cordova/issues/185) XHR is not reliable and causes OOM errors when handling large data. On Wed, Jun 3, 2020 at 7:29 PM Norman Breau wrote: > +1 on archiving/adding [DEPRECATED] text in the description. > > On 2020-06-03 4:25 p.m., julio cesar sanchez wrote: > > This happens with all the deprecated plugins we have, people keeps > > reporting issues on them. > > I proposed long ago to archive them, but some people was against it, but > I > > think archiving is the way to go when something is deprecated. > > > > > > El miércoles, 3 de junio de 2020, Jesse > escribió: > > > >> +1 The deprecation notice needs to be prominent, I missed it myself on a > >> quick scroll. > >> Some of that readme is in a specific format to support appearance in > >> docs.cordova.io ( similar to > >> https://cordova.apache.org/docs/en/latest/reference/ > >> cordova-plugin-file/index.html > >> ) > >> This is no longer a requirement, so we can go prominent. > >> We should also ask INFRA to put the text [DEPRECATED] in the > description, > >> and possibly even archive the repo. > >> > >> > >> On Wed, Jun 3, 2020 at 12:02 PM Norman Breau > >> wrote: > >> > >>> I'm sure you're not the only one who misses it, considering the repo is > >>> still pretty active in terms of new issues being reported. > >>> > >>> On 2020-06-03 3:59 p.m., Darryl Pogue wrote: > >>>> Correction: There is in fact a deprecation notice, part-way down the > >>>> README, but it's not especially attention grabbing and I missed it the > >>>> first 2 times I skimmed the file. > >>>> > >>>> On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue > wrote: > >>>> > >>>>> Hey folks, > >>>>> > >>>>> The File Transfer plugin has been officially deprecated since 2017: > >>>>> > >>> https://cordova.apache.org/blog/2017/10/18/from- > >> filetransfer-to-xhr2.html > >>>>> However, the repo and npm have no link to that page or any sort of > >>>>> indication that it is not maintained. > >>>>> > >>>>> With the release of cordova-ios 6, the FileTransfer plugin no longer > >>>>> compiles on iOS: > >>>>> https://github.com/apache/cordova-plugin-file-transfer/issues/258 > >>>>> > >>>>> I want to reply to that issue saying that it's deprecated and not > >>>>> maintained, but I feel like we haven't made that very clear. > >>>>> > >>>>> I would like to propose that we update the README for File Transfer > >>> with a > >>>>> clear deprecation notice which links to the blog post from 2017, and > >>> that > >>>>> we ask ASF Infra to mark the repo as archived. > >>>>> > >>>>> Any objections? > >>>>> > >>>>> ~Darryl > >>>>> > >>> - > >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>> For additional commands, e-mail: dev-h...@cordova.apache.org > >>> > >>> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [VOTE] cordova-common 4.0.1 Release (2nd submission)
I vote +1 * coho verify-archive OK * CI is green * Changes make sense On Fri, May 15, 2020 at 8:21 AM Niklas Merz wrote: > I vote +1 > > * verify signature and hash with coho verify archive > * npm install and npm audit success > * CI green for tag > * verify tag with coho > * tests green locally > * check license headers with coho > > Thank you Bryan for your work. > > > May 15, 2020 3:25 AM, "Bryan Ellis" wrote: > > > Please review and vote on this cordova-common release v4.0.1 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/common-4.0.1 > > > > The package was published from its corresponding git tag: > > cordova-common: 4.0.1 (13e06971c1) > > > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog > > post. > > > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible > > licenses > > * Ensured continuous build was green when repo was tagged > > * NPM Audit (exception for dev related dependency) > > * NPM Test > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: vote: PR merge convention
+1 to Niklas suggestion :) Sent from my iPhone > On 2. May 2020, at 6:54 PM, Niklas Merz wrote: > > We could try to enforce this setting with .asf.yml. I saw this posted on > another list. > > See: > https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Mergebuttons > > Should we roll this out to all repos? > > May 2, 2020 1:38 PM, "julio cesar sanchez" wrote: > >> Just a reminder that we agreed on using the squash and merge, but I still >> see regular merge commits in a few repos from time to time. >> >>> El El sáb, 5 oct 2019 a las 19:32, gandhi rajan >>> escribió: >>> >>> + 1 for squash and merge as it makes the repo history cleaner. >>> On Sat, Oct 5, 2019 at 8:34 PM wrote: >>> >>> +1 for "Squash and merge" as the default strategy >>> >>> Regarding "Create a merge commit": >>> At times, I find this option valuable too. Consider a PR that cleans up a >>> test suite. As part of that cleanup I might re-order the test cases. As >>> re-ordering produces a noisy diff, I usually isolate it in its own >>> commit. >>> I would not want to merge this commit with the others as that would lead >>> to >>> a commit with a very incomprehensible diff. So in this case I would favor >>> leaving the commits separate and doing an actual merge to group them >>> together in the global history. >>> >>> Am Fr., 4. Okt. 2019 um 17:03 Uhr schrieb julio cesar sanchez < >>> jcesarmob...@gmail.com>: >>> Sorry if it wasn't clear, I said I was leaving the protecting master >>> branch out of the vote. Looks like we all agree on using "Squash and merge" as default, unless >>> it makes more sense to use one of the other options. El jue., 3 oct. 2019 a las 3:43, Bryan Ellis () escribió: > -1 for protected master branches. > Protecting a branch is a great idea except it does not work with our > current workflow process. COHO commits directly onto the master >>> branch for > releases. We would have to spend more time planning and changing our entire > current workflow process to eliminate direct commits if we wanted to > protect branches. There is alternative such keeping master open for direct > commits and development while creating a protected "production" >>> branch. > Anyways this part of the discussion is off-topic and could be another > discussion... Anyways, stated above I am downvoting protected >>> branches for > now. > > +1 for "Squash and merge" > Makes a nice single commit with the PR number and without the extra >>> merge > commit. > > +1 for "Rebase and merge" > There are use cases where this can work perfectly. > For example, Cordova-Electron has a `draft-2.0.0` branch which is targeting > the next major release. Major PRs were merged into that branch with "Squash > and merge". This means all PRs have nice PR# information in the >>> title. > A PR will later be created to merge this branch onto master. "Rebase >>> and > merge" will be used and will not create the merge commit message and >>> will > not squash. > > -1 for "Create a merge commit" > Not in favor of the extra merge commit. I think in most cases one PR should > focus on one task so that means it could be squashed when there are > multiple commits. If "Create a merge commit" is used, each commit >>> will >>> be > merged and does not contain the PR# in the title. When creating >>> release > notes, I need to manually review those commits to identify what PR it came > from to include the PR linking. Some times, depending on if they are >>> all > related commits, I need to manually group them and create a >>> meaningful > title for the release notes which I would prefer to have been done > beforehand. > > > On Wed, Oct 2, 2019 at 12:51 AM Jesse >>> wrote: > >> -1 for protected master branches, we are a small group of >>> committers and >> don't need rules to keep us honest. >> Protecting master would involve infra, as we cannot manage the >>> minutia in >> github. I think we all do this anyway except for rare occasions. >> >> +1 for squash and merge, as long as the meaningful individual >>> commit >> messages get consolidated into the 1 commit. >> >> On Tue, Oct 1, 2019 at 8:36 AM Norman Breau < >>> nor...@normanbreau.com> >> wrote: >> >>> +1 to protect the master branch. >>> >>> Forcing PR will help organize commits if we need to go back in >>> time to determine the reason why a change was made as the >>> commit in github will show the corresponding PR. Which will >>> (hopefully) be properly filled out with context and motivation, >>> as well as the issues that the PR resolves. >>> >>> +1 for "squash + merge" as a default strategy.
Re: [VOTE] cordova-app-hello-world 5.0.0 Release
I vote +1: ✅ coho verify-archive ✅ Changes make sense ✅ NOTICE and LICENSE file are present On Wed, Apr 8, 2020 at 2:29 AM Bryan Ellis wrote: > Please review and vote on this cordova-app-hello-world Major Release v5.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-5.0.0 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 5.0.0 (70084d1bab) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos (gitignore is > excluded) > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses (No Dependencies) > * NPM Audit (No Package) > * NPM Test (No Tests) > * Built locally a CLI which has cordova-create tied with > cordova-app-hello-world@5.0.0. > * Created a new cordova project > * Tested a platform add, build, and run with Android > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] Cordova-ESLint 3.0.0 Release
I vote +1: ✅ CI is green ✅ npm audit ✅ npm test ✅ coho verify-archive ✅ Changes make sense On Tue, Mar 24, 2020 at 4:32 AM Bryan Ellis wrote: > Please review and vote on this Cordova ESLint Major Release v3.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/eslint-v3.0.0 > > The package was published from its corresponding git tag: > cordova-eslint: 3.0.0 (ca7a0d2c02) > > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post[?]. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * NPM Audit > * NPM Test > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: Automatic Cordova cleanup command
Isn't rm -r platform plugins enough? On Wed, Jan 22, 2020 at 2:00 AM Chris Brody wrote: > We can see from issues like > https://github.com/xpbrew/cordova-sqlite-storage/issues/856 that extremely > weird behavior can happen when projects become outdated. > > I think there should be a CLI command that cleans up the project workarea: > purge out old plugins and platforms and ensure that all configuration is > properly migrated. > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [DISCUSS] Cordova Windows Release 7.1.0
I’ll try to take a look at it tomorrow (GMT+1) Sorry for the delay! Sent from my iPhone > On 18. Dec 2019, at 7:07 PM, Chris Brody wrote: > > Any chance I can get a couple reviews on the VOTE thread? > >> On Thu, Dec 12, 2019 at 8:15 PM Chris Brody wrote: >> >> As discussed and agreed in >> https://github.com/apache/cordova-windows/issues/341 I am now taking >> cordova-windows@7.1.0 release over. >> >> Does anyone have any reason to delay this release? Any patches to land? >> >> If not, I will make the release within the next day or early next week. >> >>> On Tue, Jul 30, 2019 at 10:12 AM Chris Brody >>> wrote: >>> >>> Do we have a list of blocking issues? >>> >>> I think this release is badly needed since cordova-windows@latest is >>> currently not working for me or others. >>> >>> Thanks in advance, >>> >>> Chris >>> >>> On Tue, Jul 30, 2019 at 6:00 AM Jan Piotrowski >> wrote: >>>> >>>> As I wrote in the initial email I am on this release. >>>> >>>> CI is green after some work, but there are still open issues or >>>> questions (e.g. >>>> >> https://github.com/apache/cordova-windows/issues/357#issuecomment-511396401 >> ) >>>> or solved issues waiting for feedback from the initial reporter. >>>> >>>> J >>>> >>>> Am Di., 30. Juli 2019 um 05:26 Uhr schrieb Chris Brody < >> chris.br...@gmail.com>: >>>>> >>>>> I think this release should be made asap. Right now I have to do >>>>> something like cordova platform add windows@6 or cordova platform >> add >>>>> github:apache/cordova-windows#master to get a working Windows build >>>>> for testing. I got some documentation updates merged to make it clear >>>>> that it will *not* work with Visual Studio 2019. >>>>> >>>>> I can make this release sometime in the next 1-2 weeks if nobody else >>>>> wants to make it. >>>>> >>>>> Is there anything else blocking this release? >>>>> >>>>> Does any other committer have time to make this release this week? >>>>> >>>>> On Fri, Jul 5, 2019 at 9:50 AM Tim Brust >>>>> wrote: >>>>>> >>>>>> For the lazy ppl, here is the diff: >>>>>> https://github.com/apache/cordova-windows/compare/7.0.0...master >>>>>> Go for it Jan! :) >>>>>> >>>>>> On Thu, Jul 4, 2019 at 5:51 PM Jan Piotrowski < >> piotrow...@gmail.com> wrote: >>>>>> >>>>>>> Does anyone have any reason to delay a cordova-windows platform >> release? >>>>>>> Any outstanding patches to land? >>>>>>> >>>>>>> If not, I will start the release soon. >>>>>>> >>>>>>> (CI is currently red, so this will require some investigation.) >>>>>>> >>>>>>> >> - >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>>>>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> Tim Brust, Product Engineer >>>>>> >>>>>> tim.br...@sinnerschrader.com >>>>>> T +49 40 398855 315 >>>>>> >>>>>> SinnerSchrader Deutschland GmbH | SinnerSchrader Group >>>>>> Völckersstraße 38, 22765 Hamburg, Germany >>>>>> >>>>>> Amtsgericht Hamburg HRB-Nr. 63663 >>>>>> Geschäftsführer: Matthias Schrader (Sprecher), >>>>>> Jürgen Alker, Dr. Axel Averdung, Holger Blank, >>>>>> Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson >>>>>> >>>>>> Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag >>>>>> >>>>>> https://www.sinnerschrader.com | NEXT AGENCY >>>>> >>>>> - >>>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>>>> >>>> >>>> - >>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>>> >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Cordova-iOS 5.1.1 Release
I vote +1: - CI is green - coho verify-archive - I could successful add the platform with WKWebViewOnly enabled On Thu, Nov 28, 2019 at 5:25 PM Bryan Ellis wrote: > Please review and vote on this iOS Release v5.1.1 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1 > > The package was published from its corresponding git tag: > cordova-ios: 5.1.1 (86a87fed74) > > Note that you can test it out via: > > cordova platform add https://github.com/apache/cordova-ios#5.1.1 > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * NPM Audit > * NPM Tests > * Build Tests > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [DISCUSS] Cordova-iOS 5.1.1 Patch Release
I'd like to bring attention to the fact, that even with the 5.1.1 release the cordova-plugin-inappbrowser will need an update, too. It's already reported that it's not working with cordova-ios 5.1.0 and the WKWebViewOnly flag enabled. Issue: https://github.com/apache/cordova-plugin-inappbrowser/issues/583, potential PR: https://github.com/apache/cordova-plugin-inappbrowser/issues/584 On Thu, Nov 28, 2019 at 1:47 PM Bryan Ellis wrote: > Correction: > > The current changes link is written correctly but hyperlink is incorrect. > Here is the correct link. > > https://github.com/apache/cordova-ios/compare/rel/5.1.0...master > > Please also note that the 5.2.0-dev related commits will not be > cherry-picked into the 5.1.x branch or in the 5.1.1 release. > > On Thu, Nov 28, 2019 at 10:05 PM Bryan Ellis wrote: > > > Does anyone have any reason to delay a cordova-ios patch release (5.1.1)? > > > > Any outstanding patches to land? > > > > Current changes: > > https://github.com/apache/cordova-ios/compare/rel/5.1.0...master > > <https://github.com/apache/cordova-ios/compare/rel/5.0.1...master> > > > > As a bug was introduced in the minor release, I will go ahead and submit > > the vote shortly to get a quick turnaround on the patch release. > > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] Cordova-iOS 5.1.0 Release
I vote +1: ✅ CI is green for the tag ✅ coho verify-archive ✅ changes make sense ✅ npm audit > On 23. Nov 2019, at 14:06, Bryan Ellis wrote: > > Please review and vote on this iOS Release v5.1.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.0 > > The package was published from its corresponding git tag: >cordova-ios: 5.1.0 (dc327c1df4) > > Note that you can test it out via: > >cordova platform add https://github.com/apache/cordova-ios#5.1.0 > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * NPM Audit > * NPM Tests
Re: [DISCUSS] Cordova-Common 3.2.1 Release
Friendly reminder- are you still working on this? :) On Thu, Sep 19, 2019 at 3:52 AM Bryan Ellis wrote: > Does anyone have any reason to delay a cordova-common patch release > (3.2.1)? > Any outstanding patches to land? > > If not, I will start the release process shortly. (<24h). > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] Cordova-Android 8.1.0 Release
I vote +1: - CI is green for the tag ✅ - npm audit ✅ - coho verify-archive ✅ - coho check-license ✅ - tested the platform, generated an aab file ✅ On Fri, Sep 13, 2019 at 4:04 AM Jesse wrote: > +1 > - coho verify-archive > - ci is green > > > On Thu, Sep 12, 2019 at 8:51 PM Ken Naito wrote: > > > +1 > > > > * coho verify-archive OK > > * coho verify-tags OK > > * The last commit 7e8b47d0121fe49bd3ddde39dd29e669e3fd9519 in > > cordova-android passes all CI tests on github. > > > > > > Ken > > > > On 2019/09/11 17:26, Bryan Ellis wrote: > > > cordova-android: 8.1.0 (f1f472297a) > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [BOARD REPORT DRAFT] September 2019 Cordova Board Report
Looks good! One minor nit: personally I’d write “APIs” over “apis” in the “Activity” section. Is it noteworthy that our Jenkins was down some time? Sent from my iPhone > On 11. Sep 2019, at 8:00 PM, gandhi rajan wrote: > > Looks perfect. > >> On Wednesday, September 11, 2019, Jesse wrote: >> >> Please review and comment here. >> >> https://github.com/apache/cordova-apache-board-reports/ >> blob/master/2019/2019-09.md >> >> Sorry for the lateness of this email, the report is due today. >> >> Cheers, >> Jesse >> > > > -- > Regards, > Gandhi > > "The best way to find urself is to lose urself in the service of others !!!" - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Cordova dev] info needed label
Installing the Stale bot is probably not possible I guess? > On 15. Jul 2019, at 23:18, Darryl Pogue wrote: > > +1 > > Might also be worth proposing a rule that issues tagged “info needed” get > closed after X days if there is no information provided. We have a bunch of > issues piling up that are all waiting for info, and we have no process that > allows us to close those. > > On Mon, Jul 15, 2019 at 2:11 PM Jesse wrote: > >> +1 I don't think you'll see any objections. >> >> On Mon, Jul 15, 2019 at 2:07 PM Chris Brody wrote: >> >>> We receive a number of support issues where I think we need an >>> explicit label such as “info needed”, to make it clear that more >>> information is needed before we can provide any support. I think we >>> need to add this label to a number of repos such as apache/cordova, >>> cordova-android, cordova-ios, etc. >>> >>> Any objections if I would add this label to some of the repos on GitHub? >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> >>> >> signature.asc Description: Message signed with OpenPGP
Re: [VOTE] Plugins (minor) releases
I vote +1 *for each:* * CI is green * coho verify-archive ✅ * coho check-license ✅ * npm audit ✅ * npm test ✅ On Fri, Jun 28, 2019 at 2:50 PM Jan Piotrowski wrote: > Please review and vote on the release of these plugins releases > by replying to this email (and keep discussion on the DISCUSS thread) > > Two of these minor updates are comparably big, see their release notes: > > https://github.com/apache/cordova-plugin-camera/blob/master/RELEASENOTES.md#410-jun-27-2019 > > https://github.com/apache/cordova-plugin-inappbrowser/blob/master/RELEASENOTES.md#310-jun-27-2019 > > The plugins have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-camera-4.1.0/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-inappbrowser-3.1.0/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-wkwebview-engine-1.2.0/ > > The packages were published from their corresponding git tags: > cordova-plugin-camera: 4.1.0 (ae3531acfa) > cordova-plugin-inappbrowser: 3.1.0 (2ca1c923a2) > cordova-plugin-wkwebview-engine: 1.2.0 (3015342f10) > > Upon a successful vote I will upload the archives to dist/, upload > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ensured continuous build was green when repos were tagged > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [DISCUSS] Cordova Windows Release 7.1.0
For the lazy ppl, here is the diff: https://github.com/apache/cordova-windows/compare/7.0.0...master Go for it Jan! :) On Thu, Jul 4, 2019 at 5:51 PM Jan Piotrowski wrote: > Does anyone have any reason to delay a cordova-windows platform release? > Any outstanding patches to land? > > If not, I will start the release soon. > > (CI is currently red, so this will require some investigation.) > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: Nightly build #1138 for cordova has failed
Has anyone looked into the recent Jenkins failures? I suspected the coho execa change, but the failure is related to not finding the npm binary. (Besides that, the Node.js version is quite outdated: v8.10.0) Cheers, Tim On Mon, Jul 1, 2019 at 4:50 AM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > Nightly build #1138 for cordova has failed. > > Please check failure details on build details page at > https://builds.apache.org/job/cordova-nightly/1138/ > You can also take a look at build console: > https://builds.apache.org/job/cordova-nightly/1138/consoleFull > > - > Jenkins for Apache Cordova > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] (More) Plugins (patch) releases
I vote +1 *for each plugin*: * CI is green * coho verify-archive ✅ * coho check-license ✅ * npm audit ✅ * npm test ✅ * Changes make sense On Fri, Jun 28, 2019 at 2:51 PM Jan Piotrowski wrote: > Please review and vote on the release of these plugins releases > by replying to this email (and keep discussion on the DISCUSS thread) > > The plugins have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-file-6.0.2/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-geolocation-4.0.2/ > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-media-5.0.3/ > > The packages were published from their corresponding git tags: > cordova-plugin-geolocation: 4.0.2 (6319a2c1d6) > cordova-plugin-media: 5.0.3 (a3641b5411) > cordova-plugin-file: 6.0.2 (24dba9f4f9) > > Upon a successful vote I will upload the archives to dist/, upload > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ensured continuous build was green when repos were tagged > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [VOTE] Cordova-Electron 1.1.0 Release
I vote +1: * CI is green for release tag * coho verify-archive ✅ * coho check-license ✅ * npm audit ✅ * npm test ✅ On Fri, Jun 28, 2019 at 6:17 AM Bryan Ellis wrote: > Please review and vote on this Electron Release v1.1.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/electron-v1.1.0 > > The package was published from its corresponding git tag: > cordova-electron: 1.1.0 (32dd1c40dc) > > > Note that you can test it out via: > > cordova platform add https://github.com/apache/cordova-electron#1.1.0 > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * NPM Audit > * NPM Test > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [VOTE] Plugins (patch) releases
I vote +1 *for each plugin*: * CI is green for release tag * coho verify-archive ✅ * coho check-license ✅ * npm audit ✅ * Changes make sense On Wed, Jun 19, 2019 at 6:17 PM Jan Piotrowski wrote: > Please review and vote on the release of these plugins releases > by replying to this email (and keep discussion on the DISCUSS thread) > > The plugins have been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-dialogs-2.0.2/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-network-information-2.0.2/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-screen-orientation-3.0.2/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-battery-status-2.0.3/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-statusbar-2.4.3/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-whitelist-1.3.4/ > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-media-capture-3.0.3/ > > The packages were published from their corresponding git tags: > cordova-plugin-dialogs: 2.0.2 (eadaaada6c) > cordova-plugin-network-information: 2.0.2 (561b13f917) > cordova-plugin-screen-orientation: 3.0.2 (95e664d6eb) > cordova-plugin-battery-status: 2.0.3 (93d27ca2d5) > cordova-plugin-statusbar: 2.4.3 (d456212b4c) > cordova-plugin-whitelist: 1.3.4 (5620d36aac) > cordova-plugin-media-capture: 3.0.3 (2d259ef291) > > Upon a successful vote I will upload the archives to dist/, upload > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ensured continuous build was green when repos were tagged > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [VOTE] cordova-plugin-splashscreen Release 5.0.3
I vote +1: * CI is green for release tag * coho verify-archive ✅ * coho check-license ✅ * npm audit ✅ * Changes make sense On Thu, May 9, 2019 at 10:52 PM Jan Piotrowski wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > The plugins have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/splash20190509/ > > The packages were published from their corresponding git tags: > cordova-plugin-splashscreen: 5.0.3 (5339fcf377) > > Upon a successful vote I will upload the archives to dist/, upload > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ensured continuous build was green when repos were tagged > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [VOTE] cordova-plugin-device Release 2.0.3
I vote +1: * CI is green for release tag * coho verify-archive ✅ * coho check-license ✅ * npm audit ✅ * Changes make sense On Sat, Jun 15, 2019 at 12:40 AM Jan Piotrowski wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > The plugins have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-device-2.0.3/ > <https://dist.apache.org/repos/dist/dev/cordova/splash20190509/> > > The packages were published from their corresponding git tags: > cordova-plugin-device: 2.0.3 (dc7b39be5b) > > Upon a successful vote I will upload the archives to dist/, upload > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ensured continuous build was green when repos were tagged > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [VOTE] cordova-plugin-vibration Release 3.1.1
+1 * CI is green * coho verify-archive cordova-plugin-vibration-3.1.1.tgz ✅ * coho check-license ✅ * Changes make sense (small but hey!) PS @Jan - it seems your GPG key is not (yet) in the https://people.apache.org/keys/group/cordova.asc list. Given my account Apache account is very new, but my key is in the list, I assume you need to add it to https://id.apache.org :) On Thu, May 16, 2019 at 11:56 AM Jan Piotrowski wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > The plugins have been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-vibration%2381/ > > The packages were published from their corresponding git tags: > cordova-plugin-vibration: 3.1.1 (524ad47f2d) > > Upon a successful vote I will upload the archives to dist/, upload > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ensured continuous build was green when repos were tagged > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] cordova-common@3.2.0 tools release
+1 * CI is green * coho verify-archive cordova-common-3.2.0.tgz ✅ * coho check-license ✅ * Changes make sense PS @Chris - it seems your GPG key is not (yet) in the https://people.apache.org/keys/group/cordova.asc list. Given my account Apache account is very new, but my key is in the list, I assume you need to add it to https://id.apache.org :) On Wed, Jun 12, 2019 at 10:12 PM wrote: > +1 > > Reviewed changes since last version > > Am Mi., 12. Juni 2019 um 11:19 Uhr schrieb Jan Piotrowski < > piotrow...@gmail.com>: > > > +1 > > > > Changes since 3.1.0 look good. > > > > (Waiting for CI to turn green on release commit though.) > > > > Am Mi., 12. Juni 2019 um 10:59 Uhr schrieb Chris Brody < > > chris.br...@gmail.com>: > > > > > Please review and vote on this cordova-common@3.2.0 tools release by > > > replying to this email (and keep discussion on the DISCUSS thread). > > > > > > cordova-common@3.2.0 tools release artifacts have been published to > > > dist/dev: > > > https://dist.apache.org/repos/dist/dev/cordova/cordova-common-3.2.0/ > > > > > > The packages were published from their corresponding git tags: > > > > > > cordova-common: 3.2.0 (68014753da) > > > > > > Blog post is already proposed in: > > > https://github.com/apache/cordova-docs/pull/1002 > > > > > > Upon a successful vote I will upload the archives to dist/, publish > > > them to npm, and post the corresponding blog post. > > > > > > Voting guidelines: > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Ensured continuous build was green when repos were tagged > > > * npm audit shows no warning messages > > > * I raised PRs including some DRAFT PRs for outdated packages that > > > were indicated by: npm outdated > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [BOARD REPORT DRAFT] June 2019 Cordova Board Report
LGTM! (I haven't checked any numbers like GitHub issues) On Mon, Jun 10, 2019 at 5:30 PM Jesse wrote: > Please review and comment. > https://github.com/apache/cordova-apache-board-reports > /blob/master/2019/2019-06.md > < > https://github.com/apache/cordova-apache-board-reports/blob/master/2019/2019-03.md > > > > Cheers, > Jesse > > @purplecabbage > risingj.com > -- Tim Brust timbrust3...@gmail.com M: +49 160 9757 3632 <+4916097573632>
Re: [DISCUSS] Remove all documentation translations
+1 for removing them Personally I've got the feeling that we can't maintain them while keeping a good/high quality. On Wed, May 15, 2019 at 10:24 AM wrote: > Doc translations are not being actively maintained and are thus outdated. > Furthermore, at least some of the existing translations seem to be really > bad too. Consequently I propose to remove all translations from the docs > (cordova-docs as well as any other repos). > > I checked the guide entry page > <https://cordova.apache.org/docs/en/latest/guide/cli/index.html> in German > and it's so horribly bad that it can be considered totally useless IMO. > OTOH, doing a Google translation of the English version yields a really > helpful and comprehensible text. > > Related Issues: > > >- https://github.com/apache/cordova/issues/29 >- https://github.com/apache/cordova-docs/issues/995 > > Cheers, > Raphael > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] Cordova-Plugman 3.0.1 Release
I vote +1: - ran coho verify-archive successfully - npm audit passes - changes make sense On Thu, Apr 11, 2019 at 2:25 PM Bryan Ellis wrote: > Please review and vote on this Cordova Plugman Release v3.0.1 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova > > The package was published from its corresponding git tag: > cordova-plugman: 3.0.1 (247122d4b8) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * NPM Audit > * NPM Test -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [DISCUSS] Node 6.x & 8.x Deprecation & Node 12.x Support
+1, too. However, personally, I'd like to wait until December to drop Node.js 8 support (as Jan pointed out in February <https://github.com/apache/cordova/issues/79#issuecomment-465543935>, >30% of the users are using Node.js v8). Go for it with Node.js 6 and Node.js 12 though :) PS: The plugins are often still using Node.js 4, I'm dropping it one by one (see https://github.com/apache/cordova/issues/72) On Wed, Apr 10, 2019 at 4:49 PM wrote: > I recently thought about whether we should be having a release candidate > for the next major versions. > At least for platforms and the CLIs I think that would make sense. > > Am Mi., 10. Apr. 2019 um 16:24 Uhr schrieb Darryl Pogue < > dvpdin...@gmail.com > >: > > > +1 > > > > One suggestion: If (and this is a big if) we're able to get the iOS > > and Android platform updates ready by October/November, we could > > consider releasing the next major publicly, but not making it the > > default version on npm. This would hopefully gives us a period where > > people could try it and identify issues with plugins before we roll it > > out to everyone. We should still target a full public release around > > the end of the year (but December tends to be bad for doing stuff due > > to holidays, so maybe early January?) > > > > Let's try to get node 12.x added to our CI as soon as possible, and > > unofficially add support in patch releases. > > > > On Wed, Apr 10, 2019 at 1:56 AM julio cesar sanchez > > wrote: > > > > > > +1 > > > > > > sounds good > > > > > > El mié., 10 abr. 2019 a las 9:51, Shazron () > > escribió: > > > > > > > +1000 > > > > > > > > On Wed, Apr 10, 2019 at 1:17 PM wrote: > > > > > > > > > Sounds reasonable and well thought out to me. > > > > > > > > > > Bryan Ellis schrieb am Mi., 10. Apr. 2019, > 09:42: > > > > > > > > > > > I would like to start the discussion around Cordova's planning > for > > > > > > deprecating Node 6.x and Node 8.x as well as starting to support > > Node > > > > > 12.x. > > > > > > > > > > > > Since Node 6.x is being deprecated by the end of this month, I am > > not > > > > > > expecting drastic action. > > > > > > > > > > > > Additionally, Node 8.x is expected to be deprecated by December. > > > > > > > > > > > > IMO, we could hold out till December to deprecate both versions > and > > > > just > > > > > > warn users about our recommendation to upgrade in the meantime. > > These > > > > > > notices and warnings can be added in April and September as a > > patch or > > > > > > minor release. > > > > > > > > > > > > As a side note, I suspect Android Q's release (August?) and > > possible > > > > iOS > > > > > > (Sept?) to be out before December. For a major release for these > > new > > > > > > platforms, adding Node will fall in nicely. > > > > > > > > > > > > Blog Post PR: https://github.com/apache/cordova-docs/pull/965 > > > > > > GH Issue Ticket: https://github.com/apache/cordova/issues/79 > > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] cordova-lib@9.0.1 Release
I vote +1: - CI is green - Changes make sense - coho verify-archive cordova-lib-9.0.1.tgz is OK On Mon, Apr 1, 2019 at 7:42 AM Darryl Pogue wrote: > Please review and vote on this cordova-lib release by replying to this > email (and keep discussion on the DISCUSS thread) > > Artifacts have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/lib901/ > > The packages were published from their corresponding git tags: > cordova-lib: 9.0.1 (d4a0938385) > > Upon a successful vote I will upload the archives to dist/, and > publish them to npm. I don't personally think a blog post is needed > for a patch update to a non-user-facing library, but I'll bring that > up in the DISCUSS thread. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ensured continuous build was green when repos were tagged > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] Cordova-Electron 1.0.1 Patch Release
+1
* coho verify-archive OK
* CI is green
On Tue, Mar 5, 2019 at 1:18 PM Jan Piotrowski wrote:
> +1
>
> * CI is green
> * changes make sense
>
> Am Di., 5. März 2019 um 07:14 Uhr schrieb Ken Naito :
> >
> > +1
> >
> > * coho verify-archive OK
> > * coho verify-tags OK (except for confirming signature owner)
> > * The last commit 8649e607d605f8c705b983d7042aa73ba7da1c4f passes CI
> tests.
> >
> >
> > Note that I added
> > {
> > title: 'Electron',
> > versions: ['1.0'],
> > id: 'electron',
> > repoName: 'cordova-electron',
> > jiraComponentName: 'cordova-electron'
> > }
> > in repoutils.js in cordova-coho to use coho commands for
> cordova-electron.
> >
> >
> >
> > On 2019/03/04 17:49, Bryan Ellis wrote:
> > > cordova-electron: 1.0.1 (a8c677ed8b)
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> ---------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
--
Tim Brust, Product Engineer
tim.br...@sinnerschrader.com
T +49 40 398855 315
SinnerSchrader Deutschland GmbH | SinnerSchrader Group
Völckersstraße 38, 22765 Hamburg, Germany
Amtsgericht Hamburg HRB-Nr. 63663
Geschäftsführer: Matthias Schrader (Sprecher),
Jürgen Alker, Dr. Axel Averdung, Holger Blank,
Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson
Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag
https://www.sinnerschrader.com | NEXT AGENCY
