[GitHub] wanggaolin opened a new issue #9877: 你好，不能隐藏图例

2019-01-30 Thread GitBox 
wanggaolin opened a new issue #9877: 你好，不能隐藏图例
URL: https://github.com/apache/incubator-echarts/issues/9877
 
 
   版本:v2.7
   当前图例有20多个，当我选中第3个图例，就把其他图例都隐藏，反之就把显示其他图例
   这个版本没有dispatchAction方法，怎么解决? 谢谢


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: Chinese site echarts.baidu.com Was:: [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

2019-01-30 Thread Justin Mclean 
Hi,

Moving from the incubator general list.

> Those projects do not belong to apache-echarts.

Right I did not say they were. They are using the ECharts name incorrectly, see 
[1] on use of Apache names by 3rd parties [2] and attribution [3].

Part of being a member of the PPMC is to protect their brand [4][5]. So the 
question is what the ECharts PPMC going to do about this?

Thanks,
Justin

1. https://www.apache.org/foundation/marks/guide
2. https://www.apache.org/foundation/marks/events#naming
3. https://www.apache.org/foundation/marks/events#attributions
4. http://www.apache.org/dev/pmc.html#brand-policy
5. http://www.apache.org/dev/pmc.html#brand-report



-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] alanmeng82 edited a comment on issue #9758: Modified the node's coordinates generate method

2019-01-30 Thread GitBox 
alanmeng82 edited a comment on issue #9758: Modified the node's coordinates 
generate method
URL: 
https://github.com/apache/incubator-echarts/pull/9758#issuecomment-459241985
 
 
   > @alanmeng82 Hi, can you provide a demo to create the situation you 
mentioned?
   
   @Ovilia Certainly,here is the demo code for finding the difference between 
the original and modifed.
   
   
[example.txt](https://github.com/apache/incubator-echarts/files/2816016/example.txt)
   
   And there're some snapshots that show the result directly:
   
   3 nodes:
  original:
   
![3_nodes_org](https://user-images.githubusercontent.com/39982875/52036996-ea586980-2568-11e9-9f25-eda6909697d2.jpg)
   
  modified:
   
![3_nodes_modified](https://user-images.githubusercontent.com/39982875/52037047-00fec080-2569-11e9-99ad-8189bdd46050.jpg)
   
   5 nodes:
  original:
   
![5_nodes_org](https://user-images.githubusercontent.com/39982875/52037181-3d322100-2569-11e9-9ac1-5aeb8ff701df.jpg)
   
  modified:
   
![5_nodes_modified](https://user-images.githubusercontent.com/39982875/52037186-3f947b00-2569-11e9-922b-c52dfa13873f.jpg)
   
   7 nodes:
  original:
   
![7_nodes_org](https://user-images.githubusercontent.com/39982875/52037208-5044f100-2569-11e9-8592-6f4e7441335d.jpg)
   
  modified:
   
![7_nodes_modified](https://user-images.githubusercontent.com/39982875/52037224-5a66ef80-2569-11e9-8b43-98df72eb1f88.jpg)
   
   Now we can keep the graph bottom edge be parallel with the screen bottom 
line.Especially I think it will be better when you draw a triangle as it be 
often used with high frequency. 
   
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] alanmeng82 commented on issue #9758: Modified the node's coordinates generate method

2019-01-30 Thread GitBox 
alanmeng82 commented on issue #9758: Modified the node's coordinates generate 
method
URL: 
https://github.com/apache/incubator-echarts/pull/9758#issuecomment-459241985
 
 
   > @alanmeng82 Hi, can you provide a demo to create the situation you 
mentioned?
   
   Certainly,here is the demo code for finding the difference between the 
original and modifed.
   
   
[example.txt](https://github.com/apache/incubator-echarts/files/2816016/example.txt)
   
   And there're some snapshots that show the result directly:
   
   3 nodes:
  original:
   
![3_nodes_org](https://user-images.githubusercontent.com/39982875/52036996-ea586980-2568-11e9-9f25-eda6909697d2.jpg)
   
  modified:
   
![3_nodes_modified](https://user-images.githubusercontent.com/39982875/52037047-00fec080-2569-11e9-99ad-8189bdd46050.jpg)
   
   5 nodes:
  original:
   
![5_nodes_org](https://user-images.githubusercontent.com/39982875/52037181-3d322100-2569-11e9-9ac1-5aeb8ff701df.jpg)
   
  modified:
   
![5_nodes_modified](https://user-images.githubusercontent.com/39982875/52037186-3f947b00-2569-11e9-922b-c52dfa13873f.jpg)
   
   7 nodes:
  original:
   
![7_nodes_org](https://user-images.githubusercontent.com/39982875/52037208-5044f100-2569-11e9-8592-6f4e7441335d.jpg)
   
  modified:
   
![7_nodes_modified](https://user-images.githubusercontent.com/39982875/52037224-5a66ef80-2569-11e9-8b43-98df72eb1f88.jpg)
   
   Now we can keep the graph bottom edge be parallel with the screen bottom 
line.Especially I think it will be better when you draw a triangle as it be 
often used with high frequency. 
   
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] Ovilia commented on issue #9750: fix: exclude padding from tooltip position, since it's included in clientWidth

2019-01-30 Thread GitBox 
Ovilia commented on issue #9750: fix: exclude padding from tooltip position, 
since it's included in clientWidth
URL: 
https://github.com/apache/incubator-echarts/pull/9750#issuecomment-459238330
 
 
   @oustn Thanks for your contribution! 
   Now you are one of the ECharts contributors. Since we joined the Apache 
group, you need to assign [ICLA](https://www.apache.org/licenses/icla.pdf) file 
for your first PR.
   Please fill in the PDF and print it, then sign on it and send the scanned 
file to secret...@apache.org and oviliazh...@gmail.com with the title `ICLA for 
incubator-echarts project`.
   This may be a little tricky, and sorry for the trouble. This is required for 
the first time your commit is merged in. If you refused, your commit will be 
backed off.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] 100pah merged pull request #9750: fix: exclude padding from tooltip position, since it's included in clientWidth

2019-01-30 Thread GitBox 
100pah merged pull request #9750: fix: exclude padding from tooltip position, 
since it's included in clientWidth
URL: https://github.com/apache/incubator-echarts/pull/9750
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] 100pah merged pull request #9876: Add my keys

2019-01-30 Thread GitBox 
100pah merged pull request #9876: Add my keys
URL: https://github.com/apache/incubator-echarts/pull/9876
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: [Discussion] About the PR based dev workflow

2019-01-30 Thread Ovilia 
That's true.
We should probably use GitHub Wiki or create a Web page to document it.

Zhang Wenli
http://zhangwenli.com


On Thu, Jan 31, 2019 at 2:25 AM Clement Ho 
wrote:

> The workflow in https://nvie.com/posts/a-successful-git-branching-model/
> works
> too. I just want to make sure it's well documented so that contributors
> know where to fork from when contributing code improvements
>
> On Tue, Jan 29, 2019 at 1:31 PM SHUANG SU  wrote:
>
> > In fact, a big APP (hundreds of engineers are working on it) we are
> > involved in is following
> > a workflow similar to <
> > https://nvie.com/posts/a-successful-git-branching-model/>.
> >
> > But I think there are several drawbacks if applied to echarts:
> > (1) In this workflow, the `master` branch, which contains only some tags,
> > is rarely concerned.
> > But developers mostly concerns `develop` branch, based on feature
> branches
> > created.
> > In fact, the `master` branch in the workflow is similar to the current
> > `release` branch of echarts,
> > and the `develop` branch is similar to the `master` branch of echarts.
> > (2) The workflow takes more extra work on merging. It is inevitable for
> the
> > repo developed by
> > many people, but is probably expensive and not necessary for some small
> > projects like echarts.
> >
> > I agree that we should pay more attention to make the `master` branch
> keep
> > "stable" and
> > contains the latest "finished" changes (bug fix, new feature, ...).  And
> > based on that the
> > `master` branch can be the base of the new dev branch.
> >
> > About the "release stage", it is relatively simple:
> > By convention, the development of echarts have been following the
> process:
> > develop => release => develop => ...
> > Although there is some parallel between "develop" and "release", but
> > generally they are linear.
> > When a "release stage" started, a "release" branch is created and the
> > overall regression test is
> > performed. This stage takes at least a weak or even weeks, depending on
> how
> > many changes
> > are made and how many extra defeats are found in this stage. It also
> > includes the voting process
> > of ASF. After it finally released, the "release" branch is merged back to
> > the "master" branch.
> >
> >
> >
> > --
> >  Su Shuang (100pah)
> > --
> >
> >
> >
> > On Tue, 29 Jan 2019 at 17:22, Ovilia  wrote:
> >
> > > I don't think branches should be divided into those maintained by one
> > > person or shared by multiple persons.
> > > I think branches should be divided by functioning. Beside special
> > branches
> > > like master, release and etc., most feature-based branches should be
> > > treated in the same way, no matter they are a small feature maintained
> > by a
> > > single developer, or a large one by multiple people.
> > >
> > > With that being said, Workflow B looks good to me, only that I think we
> > may
> > > have a further discussion about whether we should use master branch for
> > > everyday development.
> > >
> > > To make sure master branch is more stable, would it be a better idea to
> > use
> > > dev branch for regular developing? See
> > > https://nvie.com/posts/a-successful-git-branching-model/
> > >
> > > Zhang Wenli
> > > http://zhangwenli.com
> > >
> > >
> > > On Mon, Jan 28, 2019 at 2:15 AM SHUANG SU 
> > wrote:
> > >
> > > > Based on the current setting of the `echarts` repo (PR based dev),
> > > > I think the two workflows could be used in developing:
> > > >
> > > > [Terminology]
> > > > + `Public Branch`: that is the protected branch in echarts
> > > > (master|release|protected-xxx).
> > > > + `Private Branch`: that is the branch is only used by me, either in
> > > > echarts repo or other cloned repo.
> > > >
> > > > [Issues considered]
> > > > + This scenario should not be in a mess: created a PR but it not
> > approved
> > > > yet, then make new commits at local, then the PR approved and merged,
> > > then
> > > > pull.
> > > > + How to sync `Public Branch` and `Private Branch` easily.
> > > > + The commit log would look neat (Otherwise, it would be ugly that
> lots
> > > of
> > > > merge logs, and most of the key logs are not in the `Public Branch`).
> > > > + It should not bring troubles to locating issues (such as diff log,
> > find
> > > > when and where some problem brought). The `Squash Merge` probably
> > brings
> > > > that trouble.
> > > >
> > > >
> > > > --- Workflow A: dev on `Private Branch` ---
> > > > [Workflow]
> > > > + Dev and commit on the local `Private Branch`. Keep sync with some
> > > `Public
> > > > Branch` manually.
> > > > + Create PR from the corresponding remote `Private Branch` to the
> > `Public
> > > > Branch`.
> > > > + Use "normal merge" when merging PR.
> > > > + Pull from the `Public Branch` and merge to the local `Private
> Branch`
> > > if
> > > > other commits exist.
> > > > [Advantage]
> > > > + Do not need to `rebase`.
> > > > [Disadvantage]
> > > > + Troubled

[GitHub] Ovilia commented on issue #9641: Spanish translation of javascript file

2019-01-30 Thread GitBox 
Ovilia commented on issue #9641: Spanish translation of javascript file
URL: 
https://github.com/apache/incubator-echarts/pull/9641#issuecomment-459205971
 
 
   Thanks for your contribution! 
   Now you are one of the ECharts contributors. Since we joined the Apache 
group, you need to assign [ICLA](https://www.apache.org/licenses/icla.pdf) file 
for your first PR.
   Please fill in the PDF and print it, then sign on it and send the scanned 
file to secret...@apache.org and oviliazh...@gmail.com with the title `ICLA for 
incubator-echarts project`.
   This may be a little tricky, and sorry for the trouble. This is required for 
the first time your commit is merged in. If you refused, your commit will be 
backed off.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] Ovilia merged pull request #9641: Spanish translation of javascript file

2019-01-30 Thread GitBox 
Ovilia merged pull request #9641: Spanish translation of javascript file
URL: https://github.com/apache/incubator-echarts/pull/9641
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] pissang commented on issue #9867: Can't properly click/touch nodes on mobile

2019-01-30 Thread GitBox 
pissang commented on issue #9867: Can't properly click/touch nodes on mobile
URL: 
https://github.com/apache/incubator-echarts/issues/9867#issuecomment-459202017
 
 
   @JonathanRufino You can search hover with multiple points in 
https://github.com/ecomfe/zrender/blob/master/src/Handler.js#L276 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] Ovilia opened a new pull request #9876: Add my keys

2019-01-30 Thread GitBox 
Ovilia opened a new pull request #9876: Add my keys
URL: https://github.com/apache/incubator-echarts/pull/9876
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] Ovilia commented on issue #9758: Modified the node's coordinates generate method

2019-01-30 Thread GitBox 
Ovilia commented on issue #9758: Modified the node's coordinates generate method
URL: 
https://github.com/apache/incubator-echarts/pull/9758#issuecomment-459200704
 
 
   @alanmeng82 Hi, can you provide a demo to create the situation you mentioned?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] troy351 commented on a change in pull request #9750: 修复 tooltip position 重复计算 padding

2019-01-30 Thread GitBox 
troy351 commented on a change in pull request #9750: 修复 tooltip position 重复计算 
padding
URL: https://github.com/apache/incubator-echarts/pull/9750#discussion_r250858734
 
 

 ##
 File path: src/component/tooltip/TooltipContent.js
 ##
 @@ -291,15 +291,13 @@ TooltipContent.prototype = {
 if (document.defaultView && document.defaultView.getComputedStyle) {
 var stl = document.defaultView.getComputedStyle(this.el);
 if (stl) {
-width += parseInt(stl.paddingLeft, 10) + 
parseInt(stl.paddingRight, 10)
-+ parseInt(stl.borderLeftWidth, 10) + 
parseInt(stl.borderRightWidth, 10);
-height += parseInt(stl.paddingTop, 10) + 
parseInt(stl.paddingBottom, 10)
-+ parseInt(stl.borderTopWidth, 10) + 
parseInt(stl.borderBottomWidth, 10);
+width += parseInt(stl.borderLeftWidth, 10) + 
parseInt(stl.borderRightWidth, 10);
+height += parseInt(stl.borderTopWidth, 10) + 
parseInt(stl.borderBottomWidth, 10);
 }
 
 Review comment:
   Why not just explict declare `box-sizing` in the default `cssText` of the 
tooltip dom?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] pissang commented on issue #9871: Flow GL无法获取点击事件

2019-01-30 Thread GitBox 
pissang commented on issue #9871: Flow GL无法获取点击事件
URL: 
https://github.com/apache/incubator-echarts/issues/9871#issuecomment-459199912
 
 
   Yes. `flowGL` doesn't support mouse event currently.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] pissang commented on issue #9846: effectScatter的涟漪效果在火狐下消失了

2019-01-30 Thread GitBox 
pissang commented on issue #9846: effectScatter的涟漪效果在火狐下消失了
URL: 
https://github.com/apache/incubator-echarts/issues/9846#issuecomment-459199819
 
 
   Please post your example code on the gallery 
https://gallery.echartsjs.com/explore.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] Ovilia commented on a change in pull request #9750: 修复 tooltip position 重复计算 padding

2019-01-30 Thread GitBox 
Ovilia commented on a change in pull request #9750: 修复 tooltip position 重复计算 
padding
URL: https://github.com/apache/incubator-echarts/pull/9750#discussion_r252522672
 
 

 ##
 File path: src/component/tooltip/TooltipContent.js
 ##
 @@ -291,15 +291,13 @@ TooltipContent.prototype = {
 if (document.defaultView && document.defaultView.getComputedStyle) {
 var stl = document.defaultView.getComputedStyle(this.el);
 if (stl) {
-width += parseInt(stl.paddingLeft, 10) + 
parseInt(stl.paddingRight, 10)
-+ parseInt(stl.borderLeftWidth, 10) + 
parseInt(stl.borderRightWidth, 10);
-height += parseInt(stl.paddingTop, 10) + 
parseInt(stl.paddingBottom, 10)
-+ parseInt(stl.borderTopWidth, 10) + 
parseInt(stl.borderBottomWidth, 10);
+width += parseInt(stl.borderLeftWidth, 10) + 
parseInt(stl.borderRightWidth, 10);
+height += parseInt(stl.borderTopWidth, 10) + 
parseInt(stl.borderBottomWidth, 10);
 }
 
 Review comment:
   @oustn 's correct. Made a demo at https://jsfiddle.net/ovilia/hx04kzu1/7/ . 
With or without `box-sizing: border-box;`, `clientWidth` contains padding all 
the same.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] scarecrow111 opened a new issue #9875: how to use google map in echarts?

2019-01-30 Thread GitBox 
scarecrow111 opened a new issue #9875: how to use google map in echarts?
URL: https://github.com/apache/incubator-echarts/issues/9875
 
 
   
   
   
   ## General Questions
   
   
   
   
   
   
   
   
   ## Issue Type
   
   
   
   - [ ] I have a question to ask about *how to use ECharts to ...*；我想提问如何使用 
ECharts 实现某功能
   - [ ] I have a bug to report；我想要报 bug
   - [ ] I have a feature to request, e.g.: *I'd like a new feature that 
...*；我需要一个新功能
   - [ ] I have a feature to enhance, e.g.: *The current feature should be 
improved in the way that ...*；我希望改进某个功能
   - [ ] There's something wrong with the documents；文档有些问题
   - [ ] Others, or I'm not sure which issue types to choose 
here；其他，或我不知道应该选什么类型
   
   
   ## Issue Details
   
   
   
   
   
   
   ### Expected Behavior
   
   
   
   
   
   
   ### Current Behavior
   
   
   
   
   
   
   ### Online Example
   
   
   
   
   
   
   
   
   
   
   
   ## Topics
   
   
   
   ## Anything Else We Need to Know
   
   
   
   
   
   
   ## Environment
   
   - ECharts version；ECharts 版本: {DESCRIBE_HERE}
   
   - [ ] It happens only on certain browsers or operating systems. 
对于特定浏览器或操作系统才会出现的问题，请提供相应环境信息：{BROWSER_VERSION_OR_OS_INFORMATION_HERE}
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] Ericazhang1990 opened a new issue #9874: 建议series[i]-line.sampling可以同时返回两个值，最大值和最小值

2019-01-30 Thread GitBox 
Ericazhang1990 opened a new issue #9874: 
建议series[i]-line.sampling可以同时返回两个值，最大值和最小值
URL: https://github.com/apache/incubator-echarts/issues/9874
 
 
   
   - [√] Required: I have read the document and examples and tried to solve it 
by myself. （必填）我读过了文档和教程，并且曾试图自己解决问题。
   - [√ ] Required: I have searched for similar issues and that didn't help. 
（必填）我搜索过 issue 但是没有帮助。
   - [ √] Required: I have tried with the latest version of ECharts and still 
have this problem. （必填）我试过最新版本的 ECharts，还是存在这个问题。
   
   In this issue, I have provided information with: 在这个 issue 中我提供了以下信息：
   - [√ ] Required: issue type；（必填）issue 类型
   - [√ ] Required: one sentence description in issue details；（必填）一句话的问题描述
   - [ ] Required: demo；（必填）能反映问题的例子（如果你想提问或报 bug）
   - [ ] Required: ECharts version；ECharts 版本
   
   
   
   
   ## Issue Type
   
   
   
   - [ ] I have a question to ask about *how to use ECharts to ...*；我想提问如何使用 
ECharts 实现某功能
   - [ ] I have a bug to report；我想要报 bug
   - [ ] I have a feature to request, e.g.: *I'd like a new feature that 
...*；我需要一个新功能
   - [√] I have a feature to enhance, e.g.: *The current feature should be 
improved in the way that ...*；我希望改进某个功能
   - [ ] There's something wrong with the documents；文档有些问题
   - [ ] Others, or I'm not sure which issue types to choose 
here；其他，或我不知道应该选什么类型
   
   
   ## Issue Details
   
   
   
   sampling属性支持两个像素点内返回最大值和最小值
   
   
   ### Expected Behavior
   
   
   
   1 添加类似"max"，“min”的属性，来返回两个像素点内的最大值和最小值；
   2 sample自定义可以返回数组，返回多个值，返回1个值则是对一个像素点内的值稀释，返回两个点则是对2个像素点内的值进行稀释。
   两种方案希望有一种被使用
   
   
   ### Current Behavior
   
   
   
   
   
   
   ### Online Example
   
   
   
   
   
   
   
   
   
   
   
   ## Topics
   
   
   
   ## Anything Else We Need to Know
   
   
   
   
   
   
   ## Environment
   
   - ECharts version；ECharts 版本: {DESCRIBE_HERE}
   
   - [ ] It happens only on certain browsers or operating systems. 
对于特定浏览器或操作系统才会出现的问题，请提供相应环境信息：{BROWSER_VERSION_OR_OS_INFORMATION_HERE}
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] oustn commented on a change in pull request #9750: 修复 tooltip position 重复计算 padding

2019-01-30 Thread GitBox 
oustn commented on a change in pull request #9750: 修复 tooltip position 重复计算 
padding
URL: https://github.com/apache/incubator-echarts/pull/9750#discussion_r252496885
 
 

 ##
 File path: src/component/tooltip/TooltipContent.js
 ##
 @@ -291,15 +291,13 @@ TooltipContent.prototype = {
 if (document.defaultView && document.defaultView.getComputedStyle) {
 var stl = document.defaultView.getComputedStyle(this.el);
 if (stl) {
-width += parseInt(stl.paddingLeft, 10) + 
parseInt(stl.paddingRight, 10)
-+ parseInt(stl.borderLeftWidth, 10) + 
parseInt(stl.borderRightWidth, 10);
-height += parseInt(stl.paddingTop, 10) + 
parseInt(stl.paddingBottom, 10)
-+ parseInt(stl.borderTopWidth, 10) + 
parseInt(stl.borderBottomWidth, 10);
+width += parseInt(stl.borderLeftWidth, 10) + 
parseInt(stl.borderRightWidth, 10);
+height += parseInt(stl.borderTopWidth, 10) + 
parseInt(stl.borderBottomWidth, 10);
 }
 
 Review comment:
   I think no matter what the `box-sizing` is, the `clientHeight` always 
includes padding.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: Chinese site echarts.baidu.com Was:: [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

2019-01-30 Thread Dave Fisher 
Hi -

It look like there are several ECharts in the ecomfe repositories - 
https://github.com/ecomfe?utf8=✓=echarts== 


Which are essential to ECharts? Those that are ought to become part of this 
project. There are several concerns including licensing, etc. First let’s 
review the list.

Regards,
Dave

> On Jan 30, 2019, at 2:27 PM, Clement Ho  wrote:
> 
> The docs are a little confusing and could use some help:
> 
>   - Google search results vary between ECharts docs originating from the
>   following websites:
>  - https://ecomfe.github.io/echarts-doc/public/en/
>  
>  - http://echarts.apache.org/
>  
>  - http://echarts.baidu.com
>  - http://echarts.apache.org should redirect to
>   https://echarts.apache.org
>   - https://github.com/ecomfe/echarts-doc is the repo for the docs, should
>   that be under apache as well?
> 
> 
> 
> On Wed, Jan 30, 2019 at 4:03 PM Dave Fisher  wrote:
> 
>> Hi Justin,
>> 
>> You are looking at the Chinese version of this: https://echarts.apache.org
>> 
>> 
>> I think that a reasonable solution for the pooling may be to put this
>> website up on https://echarts.apache.org/zh/ <
>> https://echarts.apache.org/zh/> and then redirect. That would fit Apache
>> Branding requirements. ECharts has 32,319 Stars and 9,403 Forks most of
>> which are in China. Performance might be an issue.
>> 
>> Echarts Devs would you please look into moving the Chinese site to ASF
>> Infrastructure. Once that is done properly then we can consider the best
>> way to handle echarts.baidu.com domain. Perhaps there are some creative
>> ways to handle this …
>> 
>> Regards,
>> Dave
>> 
>>> On Jan 30, 2019, at 1:23 PM, Justin Mclean 
>> wrote:
>>> 
>>> There is also possible a more serious issue re branding, trademarks and
>> project independence. Now it possible that this has already been discussed,
>> and there are plans to remove it, but what is being done about this domain
>> name? https://echarts.baidu.com . Please add
>> something in your podling report about this.
>> 
>>

[GitHub] jonavila closed issue #9855: When will 4.2.1-rc1 be released in NPM?

2019-01-30 Thread GitBox 
jonavila closed issue #9855: When will 4.2.1-rc1 be released in NPM?
URL: https://github.com/apache/incubator-echarts/issues/9855
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: Chinese site echarts.baidu.com Was:: [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

2019-01-30 Thread Clement Ho 
The docs are a little confusing and could use some help:

   - Google search results vary between ECharts docs originating from the
   following websites:
  - https://ecomfe.github.io/echarts-doc/public/en/
  
  - http://echarts.apache.org/
  
  - http://echarts.baidu.com
  - http://echarts.apache.org should redirect to
   https://echarts.apache.org
   - https://github.com/ecomfe/echarts-doc is the repo for the docs, should
   that be under apache as well?



On Wed, Jan 30, 2019 at 4:03 PM Dave Fisher  wrote:

> Hi Justin,
>
> You are looking at the Chinese version of this: https://echarts.apache.org
> 
>
> I think that a reasonable solution for the pooling may be to put this
> website up on https://echarts.apache.org/zh/ <
> https://echarts.apache.org/zh/> and then redirect. That would fit Apache
> Branding requirements. ECharts has 32,319 Stars and 9,403 Forks most of
> which are in China. Performance might be an issue.
>
> Echarts Devs would you please look into moving the Chinese site to ASF
> Infrastructure. Once that is done properly then we can consider the best
> way to handle echarts.baidu.com domain. Perhaps there are some creative
> ways to handle this …
>
> Regards,
> Dave
>
> > On Jan 30, 2019, at 1:23 PM, Justin Mclean 
> wrote:
> >
> > There is also possible a more serious issue re branding, trademarks and
> project independence. Now it possible that this has already been discussed,
> and there are plans to remove it, but what is being done about this domain
> name? https://echarts.baidu.com . Please add
> something in your podling report about this.
>
>

Chinese site echarts.baidu.com Was:: [VOTE] Release Apache ECharts 4.2.1 (release candidate 1)

2019-01-30 Thread Dave Fisher 
Hi Justin,

You are looking at the Chinese version of this: https://echarts.apache.org 


I think that a reasonable solution for the pooling may be to put this website 
up on https://echarts.apache.org/zh/  and then 
redirect. That would fit Apache Branding requirements. ECharts has 32,319 Stars 
and 9,403 Forks most of which are in China. Performance might be an issue.

Echarts Devs would you please look into moving the Chinese site to ASF 
Infrastructure. Once that is done properly then we can consider the best way to 
handle echarts.baidu.com domain. Perhaps there are some creative ways to handle 
this …

Regards,
Dave

> On Jan 30, 2019, at 1:23 PM, Justin Mclean  wrote:
> 
> There is also possible a more serious issue re branding, trademarks and 
> project independence. Now it possible that this has already been discussed, 
> and there are plans to remove it, but what is being done about this domain 
> name? https://echarts.baidu.com . Please add 
> something in your podling report about this.

Re: ECharts incubator report

2019-01-30 Thread Justin Mclean 
Hi,

> But the rc version is not tagged as "latest" in npm, so the public can not
> get this version by `npm install`.

That seems acceptable / reasonable thing to do as only people who know it 
exists can get it.

> But the published `4.2.0-rc.2` on npm you saw in [2] is tagged as "latest"
> and have been published to the public. 

Please remove it, yes that will cause some issues, but the PPMC needs to follow 
ASF release policy. IMO If you want an exception you will need to talk to the 
board and/or VP legal to get permission.

Thanks,
Justin

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] ClemMakesApps commented on issue #9855: When will 4.2.1-rc1 be released in NPM?

2019-01-30 Thread GitBox 
ClemMakesApps commented on issue #9855: When will 4.2.1-rc1 be released in NPM?
URL: 
https://github.com/apache/incubator-echarts/issues/9855#issuecomment-459054429
 
 
   Ah I see. Thanks for explaining @pissang 
   
   @jonavila this issue seems resolved. Can we close it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: [Discussion] About the PR based dev workflow

2019-01-30 Thread Clement Ho 
The workflow in https://nvie.com/posts/a-successful-git-branching-model/ works
too. I just want to make sure it's well documented so that contributors
know where to fork from when contributing code improvements

On Tue, Jan 29, 2019 at 1:31 PM SHUANG SU  wrote:

> In fact, a big APP (hundreds of engineers are working on it) we are
> involved in is following
> a workflow similar to <
> https://nvie.com/posts/a-successful-git-branching-model/>.
>
> But I think there are several drawbacks if applied to echarts:
> (1) In this workflow, the `master` branch, which contains only some tags,
> is rarely concerned.
> But developers mostly concerns `develop` branch, based on feature branches
> created.
> In fact, the `master` branch in the workflow is similar to the current
> `release` branch of echarts,
> and the `develop` branch is similar to the `master` branch of echarts.
> (2) The workflow takes more extra work on merging. It is inevitable for the
> repo developed by
> many people, but is probably expensive and not necessary for some small
> projects like echarts.
>
> I agree that we should pay more attention to make the `master` branch keep
> "stable" and
> contains the latest "finished" changes (bug fix, new feature, ...).  And
> based on that the
> `master` branch can be the base of the new dev branch.
>
> About the "release stage", it is relatively simple:
> By convention, the development of echarts have been following the process:
> develop => release => develop => ...
> Although there is some parallel between "develop" and "release", but
> generally they are linear.
> When a "release stage" started, a "release" branch is created and the
> overall regression test is
> performed. This stage takes at least a weak or even weeks, depending on how
> many changes
> are made and how many extra defeats are found in this stage. It also
> includes the voting process
> of ASF. After it finally released, the "release" branch is merged back to
> the "master" branch.
>
>
>
> --
>  Su Shuang (100pah)
> --
>
>
>
> On Tue, 29 Jan 2019 at 17:22, Ovilia  wrote:
>
> > I don't think branches should be divided into those maintained by one
> > person or shared by multiple persons.
> > I think branches should be divided by functioning. Beside special
> branches
> > like master, release and etc., most feature-based branches should be
> > treated in the same way, no matter they are a small feature maintained
> by a
> > single developer, or a large one by multiple people.
> >
> > With that being said, Workflow B looks good to me, only that I think we
> may
> > have a further discussion about whether we should use master branch for
> > everyday development.
> >
> > To make sure master branch is more stable, would it be a better idea to
> use
> > dev branch for regular developing? See
> > https://nvie.com/posts/a-successful-git-branching-model/
> >
> > Zhang Wenli
> > http://zhangwenli.com
> >
> >
> > On Mon, Jan 28, 2019 at 2:15 AM SHUANG SU 
> wrote:
> >
> > > Based on the current setting of the `echarts` repo (PR based dev),
> > > I think the two workflows could be used in developing:
> > >
> > > [Terminology]
> > > + `Public Branch`: that is the protected branch in echarts
> > > (master|release|protected-xxx).
> > > + `Private Branch`: that is the branch is only used by me, either in
> > > echarts repo or other cloned repo.
> > >
> > > [Issues considered]
> > > + This scenario should not be in a mess: created a PR but it not
> approved
> > > yet, then make new commits at local, then the PR approved and merged,
> > then
> > > pull.
> > > + How to sync `Public Branch` and `Private Branch` easily.
> > > + The commit log would look neat (Otherwise, it would be ugly that lots
> > of
> > > merge logs, and most of the key logs are not in the `Public Branch`).
> > > + It should not bring troubles to locating issues (such as diff log,
> find
> > > when and where some problem brought). The `Squash Merge` probably
> brings
> > > that trouble.
> > >
> > >
> > > --- Workflow A: dev on `Private Branch` ---
> > > [Workflow]
> > > + Dev and commit on the local `Private Branch`. Keep sync with some
> > `Public
> > > Branch` manually.
> > > + Create PR from the corresponding remote `Private Branch` to the
> `Public
> > > Branch`.
> > > + Use "normal merge" when merging PR.
> > > + Pull from the `Public Branch` and merge to the local `Private Branch`
> > if
> > > other commits exist.
> > > [Advantage]
> > > + Do not need to `rebase`.
> > > [Disadvantage]
> > > + Troubled by the lots of merges.
> > > + The commit logs of `Public Branch` does not look neat.
> > > [Suitable for]
> > > + Dev some feature independently.
> > >
> > > --- Workflow B: dev on `Public Branch` ---
> > > [Wrokflow]
> > > + Dev and commit on a local `Public Branch`.
> > > + Push to a temporary branch and create a PR to the remote `Public
> > Branch`.
> > > `git push origin HEAD:refs/heads/tmp-xxx`
> > > + Use `rebase

[GitHub] XargoNet commented on issue #2321: Created English version of echarts-all.js file, would like to contribute file to ECharts

2019-01-30 Thread GitBox 
XargoNet commented on issue #2321: Created English version of echarts-all.js 
file, would like to contribute file to ECharts
URL: 
https://github.com/apache/incubator-echarts/issues/2321#issuecomment-459020087
 
 
   Hi, many thanks for this file.
   I'm facing an issue with Maps:
   `TypeError: echarts.registerMap is not a function`
   
   I'm loading the provinces of a country, to be drawn. It work with any other 
echarts.js file (non translated).
   
   I tried to add the function with no luck.
   
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: ECharts incubator report

2019-01-30 Thread Kevin A. McGrail 
Are you talking about the email with subject: "Re: [VOTE] Release Apache
ECharts 4.2.1 (release candidate 1)" from 1/29 started by you?

I haven't dug in and checked everything like LICENSES and headers or the
signatures and but overall it looks really strong and I would vote +1
but you need to have sha256 or sha512 signatures to verify the zip file.

I will setup a suitable node.js environment for this so I can test
future builds and be more involved.

Regards,
KAM

On 1/30/2019 11:05 AM, Ovilia wrote:
> Dear mentors,
>
> We've published our release vote on general@, but it has got no reply by
> now.
> Could you have a look at it, and give a +1 perhaps?
>
> Zhang Wenli
> http://zhangwenli.com
>
>
> On Wed, Jan 30, 2019 at 11:34 PM Dave Fisher  wrote:
>
>> Hi -
>>
>> Also, the project did begin discussions about adding a committer on
>> private@. These stalled, but can be restarted now.
>>
>> Regards,
>> Dave
>>
>> Sent from my iPhone
>>
>>> On Jan 30, 2019, at 7:24 AM, Kevin A. McGrail 
>> wrote:
>>> Nice response Shuang.  If I can help with the voting process for
>>> releases, etc., please let me know.
>>>
>>> I can also try to help with adding more committers, writing notices,
>>> etc. to try and get more interest on Social Media even.
>>>
>>> Regards,
>>> KAM
 On 1/30/2019 3:11 AM, SHUANG SU wrote:
 Hi Justin,

 I am afraid it is inevitable to push the rc version to npm. Without
>> that,
 the build
 process and some local CI process can not be performed, which causes the
 developers
 concerning about this project can not test whether the release
>> candidate is
 qualified to be released.
 But the rc version is not tagged as "latest" in npm, so the public can
>> not
 get this version
 by `npm install`. So it will not make bad effect, just like publishing
>> the
 rc pack to the
 Apache svn dev repo [1].

 But the published `4.2.0-rc.2` on npm you saw in [2] is tagged as
>> "latest"
 and have been
 published to the public. That is incorrect according to the Apache
>> rule. We
 should have
 removed it. But unfortunately we have missed the opportunity to do that.
 Many outsider
 projects or systems have depended on that, and the removal will cause
>> some
 disaster.

 This mistake was made because we did not clear enough about the total
 release process.
 But having this experience, this mistake will not happen again. Only the
 official release
 will be directed to publish in npm from now on.

 1. https://dist.apache.org/repos/dist/dev/incubator/
 2. https://www.npmjs.com/package/echarts


 Thanks

 --
 Su Shuang (100pah)
 --



> On Wed, 30 Jan 2019 at 15:14, Justin Mclean 
>> wrote:
> HI,
>
>> As about "When were the last committers or PPMC members elected?", we
> don't have new committers or PPMC members elected after the
>> initiation. So
> should I fill in NA or the initiation date?
>
> Yes, but being a year in incubation without adding any committer or PMC
> members is concerning, especially given the number of contributors to
>> the
> project. You might want to put in the report what is being done to
>> address
> this.There’s some tasks mentioned on the private list that need to be
> followed up on by the PPMC I think.
>
>> As about release version, we tagged "rc" for release candidate
>> version.
> Does that mean rc version can never be available to the public?
>
> Release candidates should not be made available to the general public,
> they can be made available to people who follow the dev list. [1] They
>> can
> be placed here. [2]
>
> Thanks,
> Justin
>
> 1. https://www.apache.org/dev/release-distribution#unreleased
> 2. http://www.apache.org/legal/release-policy.html#stage
>
>
>
>>> --
>>> Kevin A. McGrail
>>> VP Fundraising, Apache Software Foundation
>>> Chair Emeritus Apache SpamAssassin Project
>>> https://www.linkedin.com/in/kmcgrail - 703.798.0171
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
>>> For additional commands, e-mail: dev-h...@echarts.apache.org
>>>
>>

-- 
Kevin A. McGrail
VP Fundraising, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171


-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: ECharts incubator report

2019-01-30 Thread Ovilia 
Dear mentors,

We've published our release vote on general@, but it has got no reply by
now.
Could you have a look at it, and give a +1 perhaps?

Zhang Wenli
http://zhangwenli.com


On Wed, Jan 30, 2019 at 11:34 PM Dave Fisher  wrote:

> Hi -
>
> Also, the project did begin discussions about adding a committer on
> private@. These stalled, but can be restarted now.
>
> Regards,
> Dave
>
> Sent from my iPhone
>
> > On Jan 30, 2019, at 7:24 AM, Kevin A. McGrail 
> wrote:
> >
> > Nice response Shuang.  If I can help with the voting process for
> > releases, etc., please let me know.
> >
> > I can also try to help with adding more committers, writing notices,
> > etc. to try and get more interest on Social Media even.
> >
> > Regards,
> > KAM
> >> On 1/30/2019 3:11 AM, SHUANG SU wrote:
> >> Hi Justin,
> >>
> >> I am afraid it is inevitable to push the rc version to npm. Without
> that,
> >> the build
> >> process and some local CI process can not be performed, which causes the
> >> developers
> >> concerning about this project can not test whether the release
> candidate is
> >> qualified to be released.
> >> But the rc version is not tagged as "latest" in npm, so the public can
> not
> >> get this version
> >> by `npm install`. So it will not make bad effect, just like publishing
> the
> >> rc pack to the
> >> Apache svn dev repo [1].
> >>
> >> But the published `4.2.0-rc.2` on npm you saw in [2] is tagged as
> "latest"
> >> and have been
> >> published to the public. That is incorrect according to the Apache
> rule. We
> >> should have
> >> removed it. But unfortunately we have missed the opportunity to do that.
> >> Many outsider
> >> projects or systems have depended on that, and the removal will cause
> some
> >> disaster.
> >>
> >> This mistake was made because we did not clear enough about the total
> >> release process.
> >> But having this experience, this mistake will not happen again. Only the
> >> official release
> >> will be directed to publish in npm from now on.
> >>
> >> 1. https://dist.apache.org/repos/dist/dev/incubator/
> >> 2. https://www.npmjs.com/package/echarts
> >>
> >>
> >> Thanks
> >>
> >> --
> >> Su Shuang (100pah)
> >> --
> >>
> >>
> >>
> >>> On Wed, 30 Jan 2019 at 15:14, Justin Mclean 
> wrote:
> >>>
> >>> HI,
> >>>
>  As about "When were the last committers or PPMC members elected?", we
> >>> don't have new committers or PPMC members elected after the
> initiation. So
> >>> should I fill in NA or the initiation date?
> >>>
> >>> Yes, but being a year in incubation without adding any committer or PMC
> >>> members is concerning, especially given the number of contributors to
> the
> >>> project. You might want to put in the report what is being done to
> address
> >>> this.There’s some tasks mentioned on the private list that need to be
> >>> followed up on by the PPMC I think.
> >>>
>  As about release version, we tagged "rc" for release candidate
> version.
> >>> Does that mean rc version can never be available to the public?
> >>>
> >>> Release candidates should not be made available to the general public,
> >>> they can be made available to people who follow the dev list. [1] They
> can
> >>> be placed here. [2]
> >>>
> >>> Thanks,
> >>> Justin
> >>>
> >>> 1. https://www.apache.org/dev/release-distribution#unreleased
> >>> 2. http://www.apache.org/legal/release-policy.html#stage
> >>>
> >>>
> >>>
> >
> > --
> > Kevin A. McGrail
> > VP Fundraising, Apache Software Foundation
> > Chair Emeritus Apache SpamAssassin Project
> > https://www.linkedin.com/in/kmcgrail - 703.798.0171
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
> > For additional commands, e-mail: dev-h...@echarts.apache.org
> >
>
>

Re: ECharts incubator report

2019-01-30 Thread Dave Fisher 
Hi -

Also, the project did begin discussions about adding a committer on private@. 
These stalled, but can be restarted now.

Regards,
Dave

Sent from my iPhone

> On Jan 30, 2019, at 7:24 AM, Kevin A. McGrail  wrote:
> 
> Nice response Shuang.  If I can help with the voting process for
> releases, etc., please let me know.
> 
> I can also try to help with adding more committers, writing notices,
> etc. to try and get more interest on Social Media even.
> 
> Regards,
> KAM
>> On 1/30/2019 3:11 AM, SHUANG SU wrote:
>> Hi Justin,
>> 
>> I am afraid it is inevitable to push the rc version to npm. Without that,
>> the build
>> process and some local CI process can not be performed, which causes the
>> developers
>> concerning about this project can not test whether the release candidate is
>> qualified to be released.
>> But the rc version is not tagged as "latest" in npm, so the public can not
>> get this version
>> by `npm install`. So it will not make bad effect, just like publishing the
>> rc pack to the
>> Apache svn dev repo [1].
>> 
>> But the published `4.2.0-rc.2` on npm you saw in [2] is tagged as "latest"
>> and have been
>> published to the public. That is incorrect according to the Apache rule. We
>> should have
>> removed it. But unfortunately we have missed the opportunity to do that.
>> Many outsider
>> projects or systems have depended on that, and the removal will cause some
>> disaster.
>> 
>> This mistake was made because we did not clear enough about the total
>> release process.
>> But having this experience, this mistake will not happen again. Only the
>> official release
>> will be directed to publish in npm from now on.
>> 
>> 1. https://dist.apache.org/repos/dist/dev/incubator/
>> 2. https://www.npmjs.com/package/echarts
>> 
>> 
>> Thanks
>> 
>> --
>> Su Shuang (100pah)
>> --
>> 
>> 
>> 
>>> On Wed, 30 Jan 2019 at 15:14, Justin Mclean  wrote:
>>> 
>>> HI,
>>> 
 As about "When were the last committers or PPMC members elected?", we
>>> don't have new committers or PPMC members elected after the initiation. So
>>> should I fill in NA or the initiation date?
>>> 
>>> Yes, but being a year in incubation without adding any committer or PMC
>>> members is concerning, especially given the number of contributors to the
>>> project. You might want to put in the report what is being done to address
>>> this.There’s some tasks mentioned on the private list that need to be
>>> followed up on by the PPMC I think.
>>> 
 As about release version, we tagged "rc" for release candidate version.
>>> Does that mean rc version can never be available to the public?
>>> 
>>> Release candidates should not be made available to the general public,
>>> they can be made available to people who follow the dev list. [1] They can
>>> be placed here. [2]
>>> 
>>> Thanks,
>>> Justin
>>> 
>>> 1. https://www.apache.org/dev/release-distribution#unreleased
>>> 2. http://www.apache.org/legal/release-policy.html#stage
>>> 
>>> 
>>> 
> 
> -- 
> Kevin A. McGrail
> VP Fundraising, Apache Software Foundation
> Chair Emeritus Apache SpamAssassin Project
> https://www.linkedin.com/in/kmcgrail - 703.798.0171
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
> For additional commands, e-mail: dev-h...@echarts.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: ECharts incubator report

2019-01-30 Thread Kevin A. McGrail 
Nice response Shuang.  If I can help with the voting process for
releases, etc., please let me know.

I can also try to help with adding more committers, writing notices,
etc. to try and get more interest on Social Media even.

Regards,
KAM
On 1/30/2019 3:11 AM, SHUANG SU wrote:
> Hi Justin,
>
> I am afraid it is inevitable to push the rc version to npm. Without that,
> the build
> process and some local CI process can not be performed, which causes the
> developers
> concerning about this project can not test whether the release candidate is
> qualified to be released.
> But the rc version is not tagged as "latest" in npm, so the public can not
> get this version
> by `npm install`. So it will not make bad effect, just like publishing the
> rc pack to the
> Apache svn dev repo [1].
>
> But the published `4.2.0-rc.2` on npm you saw in [2] is tagged as "latest"
> and have been
> published to the public. That is incorrect according to the Apache rule. We
> should have
> removed it. But unfortunately we have missed the opportunity to do that.
> Many outsider
> projects or systems have depended on that, and the removal will cause some
> disaster.
>
> This mistake was made because we did not clear enough about the total
> release process.
> But having this experience, this mistake will not happen again. Only the
> official release
> will be directed to publish in npm from now on.
>
> 1. https://dist.apache.org/repos/dist/dev/incubator/
> 2. https://www.npmjs.com/package/echarts
>
>
> Thanks
>
> --
>  Su Shuang (100pah)
> --
>
>
>
> On Wed, 30 Jan 2019 at 15:14, Justin Mclean  wrote:
>
>> HI,
>>
>>> As about "When were the last committers or PPMC members elected?", we
>> don't have new committers or PPMC members elected after the initiation. So
>> should I fill in NA or the initiation date?
>>
>> Yes, but being a year in incubation without adding any committer or PMC
>> members is concerning, especially given the number of contributors to the
>> project. You might want to put in the report what is being done to address
>> this.There’s some tasks mentioned on the private list that need to be
>> followed up on by the PPMC I think.
>>
>>> As about release version, we tagged "rc" for release candidate version.
>> Does that mean rc version can never be available to the public?
>>
>> Release candidates should not be made available to the general public,
>> they can be made available to people who follow the dev list. [1] They can
>> be placed here. [2]
>>
>> Thanks,
>> Justin
>>
>> 1. https://www.apache.org/dev/release-distribution#unreleased
>> 2. http://www.apache.org/legal/release-policy.html#stage
>>
>>
>>

-- 
Kevin A. McGrail
VP Fundraising, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171


-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] Janicek2 opened a new issue #9873: No data info on one day period chart.

2019-01-30 Thread GitBox 
Janicek2 opened a new issue #9873: No data info on one day period chart.
URL: https://github.com/apache/incubator-echarts/issues/9873
 
 
   
   
   
   ## General Questions
   
   
   
   
   
   
   
   
   ## Issue Type
   
   
   
   - [x ] I have a question to ask about *how to use ECharts to ...*；我想提问如何使用 
ECharts 实现某功能
   - [ ] I have a bug to report；我想要报 bug
   - [ ] I have a feature to request, e.g.: *I'd like a new feature that 
...*；我需要一个新功能
   - [ ] I have a feature to enhance, e.g.: *The current feature should be 
improved in the way that ...*；我希望改进某个功能
   - [ ] There's something wrong with the documents；文档有些问题
   - [ ] Others, or I'm not sure which issue types to choose 
here；其他，或我不知道应该选什么类型
   
   
   ## Issue Details
   
   
   
   
   
   No data info on one day period chart.
   
   ### Expected Behavior
   
   
![chart](https://user-images.githubusercontent.com/35063987/51982880-7d28d380-2497-11e9-9c84-1529879ce9ba.png)
   
   
   
   
   
   
   
   ### Current Behavior
   
   
   
   
   
   
   ### Online Example
   
   
   
   
   
   
   
   
   
   
   
   ## Topics
   
   
   
   ## Anything Else We Need to Know
   
   
   
   
   
   
   ## Environment
   
   - ECharts version；ECharts 版本: {DESCRIBE_HERE}
   
   - [ ] It happens only on certain browsers or operating systems. 
对于特定浏览器或操作系统才会出现的问题，请提供相应环境信息：{BROWSER_VERSION_OR_OS_INFORMATION_HERE}
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] JonathanRufino commented on issue #9867: Can't properly click/touch nodes on mobile

2019-01-30 Thread GitBox 
JonathanRufino commented on issue #9867: Can't properly click/touch nodes on 
mobile
URL: 
https://github.com/apache/incubator-echarts/issues/9867#issuecomment-458925729
 
 
   @pissang Could you give me any direction where to look at the code? I would 
like to try to do a quick fix to release an app, while this enhancement is not 
officially released.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: ECharts incubator report

2019-01-30 Thread SHUANG SU 
Hi Justin,

I am afraid it is inevitable to push the rc version to npm. Without that,
the build
process and some local CI process can not be performed, which causes the
developers
concerning about this project can not test whether the release candidate is
qualified to be released.
But the rc version is not tagged as "latest" in npm, so the public can not
get this version
by `npm install`. So it will not make bad effect, just like publishing the
rc pack to the
Apache svn dev repo [1].

But the published `4.2.0-rc.2` on npm you saw in [2] is tagged as "latest"
and have been
published to the public. That is incorrect according to the Apache rule. We
should have
removed it. But unfortunately we have missed the opportunity to do that.
Many outsider
projects or systems have depended on that, and the removal will cause some
disaster.

This mistake was made because we did not clear enough about the total
release process.
But having this experience, this mistake will not happen again. Only the
official release
will be directed to publish in npm from now on.

1. https://dist.apache.org/repos/dist/dev/incubator/
2. https://www.npmjs.com/package/echarts


Thanks

--
 Su Shuang (100pah)
--



On Wed, 30 Jan 2019 at 15:14, Justin Mclean  wrote:

> HI,
>
> > As about "When were the last committers or PPMC members elected?", we
> don't have new committers or PPMC members elected after the initiation. So
> should I fill in NA or the initiation date?
>
> Yes, but being a year in incubation without adding any committer or PMC
> members is concerning, especially given the number of contributors to the
> project. You might want to put in the report what is being done to address
> this.There’s some tasks mentioned on the private list that need to be
> followed up on by the PPMC I think.
>
> > As about release version, we tagged "rc" for release candidate version.
> Does that mean rc version can never be available to the public?
>
> Release candidates should not be made available to the general public,
> they can be made available to people who follow the dev list. [1] They can
> be placed here. [2]
>
> Thanks,
> Justin
>
> 1. https://www.apache.org/dev/release-distribution#unreleased
> 2. http://www.apache.org/legal/release-policy.html#stage
>
>
>