[jira] [Created] (FALCON-1670) Testing of the xml files from example folder in distributed mode

[Praveen Adlakha (JIRA)]

Praveen Adlakha created FALCON-1670:
---

 Summary: Testing of the xml files from example folder in 
distributed mode 
 Key: FALCON-1670
 URL: https://issues.apache.org/jira/browse/FALCON-1670
 Project: Falcon
  Issue Type: Test
Reporter: Praveen Adlakha
Assignee: Praveen Adlakha


Hi All,

While examples dir in distributed mode all the xml files were not tested.Need 
to verify them.

Thanks
Praveen



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1660) Examples directory missing in distributed mode

[Praveen Adlakha (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061713#comment-15061713
 ] 

Praveen Adlakha commented on FALCON-1660:
-

[~pragya.mittal]

As the patch has been merged have created  FALCON-1670  to test it . If 
required will submit one more patch.

Thanks

> Examples directory missing in distributed mode
> --
>
> Key: FALCON-1660
> URL: https://issues.apache.org/jira/browse/FALCON-1660
> Project: Falcon
>  Issue Type: Bug
>Reporter: Praveen Adlakha
>Assignee: Praveen Adlakha
> Fix For: 0.9
>
> Attachments: FALCON-1660.patch
>
>
> Hi All,
> Right now we donot have example dir in the distributed mode tar we should add 
> it.
> Thanks
> Praveen



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[pavan kumar kolamuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/
---

(Updated Dec. 17, 2015, 9 a.m.)


Review request for Falcon.


Changes
---

Added description to Rerun API as said in comments


Repository: falcon-git


Description
---

Currently rerun API was not supported in case of Native Scheduler in Falcon. 
Rerun of instances should be implemented in FalconWorkflowEngine.


Diffs (updated)
-

  client/src/main/java/org/apache/falcon/resource/InstancesResult.java e05eeeb 
  scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
c9c0f42 
  scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
3cc8a25 
  
scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
 f3beabc 
  scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
e446069 
  
scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
 59f5cba 
  
scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
 PRE-CREATION 
  
scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
 fb11091 
  scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
  scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
  
scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java 
1f69fab 
  scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
  scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
2f3aa3a 
  scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
f1d1931 
  
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java 
4bee269 
  scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
0e3dfa9 
  
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java 
b2f8e80 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
e0d2a0e 
  
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
 c19cada 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
a26eb77 
  scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
d274ad7 
  
scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
 6d5bd49 
  
webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
 f5bcc54 
  
webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
 7959b63 
  webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a 

Diff: https://reviews.apache.org/r/41401/diff/


Testing
---


Thanks,

pavan kumar kolamuri

[jira] [Updated] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

[pavan kumar kolamuri (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pavan kumar kolamuri updated FALCON-1636:
-
Attachment: FALCON-1636-v3.patch

> Add Rerun API In Falcon Native Scheduler
> 
>
> Key: FALCON-1636
> URL: https://issues.apache.org/jira/browse/FALCON-1636
> Project: Falcon
>  Issue Type: Sub-task
>  Components: scheduler
>Reporter: pavan kumar kolamuri
>Assignee: pavan kumar kolamuri
> Attachments: FALCON-1636-v0.patch, FALCON-1636-v1.patch, 
> FALCON-1636-v2.patch, FALCON-1636-v3.patch
>
>
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

[pavan kumar kolamuri (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061747#comment-15061747
 ] 

pavan kumar kolamuri commented on FALCON-1636:
--

Added the description to Rerun API . [~pallavi.rao] Can you please check now . 

> Add Rerun API In Falcon Native Scheduler
> 
>
> Key: FALCON-1636
> URL: https://issues.apache.org/jira/browse/FALCON-1636
> Project: Falcon
>  Issue Type: Sub-task
>  Components: scheduler
>Reporter: pavan kumar kolamuri
>Assignee: pavan kumar kolamuri
> Attachments: FALCON-1636-v0.patch, FALCON-1636-v1.patch, 
> FALCON-1636-v2.patch, FALCON-1636-v3.patch
>
>
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FALCON-1639) Implement update feature for native scheduler

[Pallavi Rao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Rao updated FALCON-1639:

Attachment: FALCON-1639.patch

Rebased and updated patch.

> Implement update feature for native scheduler
> -
>
> Key: FALCON-1639
> URL: https://issues.apache.org/jira/browse/FALCON-1639
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Pallavi Rao
>Assignee: Pallavi Rao
> Fix For: 0.9
>
> Attachments: FALCON-1639.patch, FALCON-1639.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1670) Testing of the xml files from example folder in distributed mode

[Pragya Mittal (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061783#comment-15061783
 ] 

Pragya Mittal commented on FALCON-1670:
---

We need to update the site documentation on how to use these examples in 
distributed mode as well.

> Testing of the xml files from example folder in distributed mode 
> -
>
> Key: FALCON-1670
> URL: https://issues.apache.org/jira/browse/FALCON-1670
> Project: Falcon
>  Issue Type: Test
>Reporter: Praveen Adlakha
>Assignee: Praveen Adlakha
>
> Hi All,
> While examples dir in distributed mode all the xml files were not tested.Need 
> to verify them.
> Thanks
> Praveen



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FALCON-1377) Add tests in falcon for the Triage API

[Karishma Gulati (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karishma Gulati updated FALCON-1377:

Attachment: Falcon-1377-v2.patch

> Add tests in falcon for the Triage API
> --
>
> Key: FALCON-1377
> URL: https://issues.apache.org/jira/browse/FALCON-1377
> Project: Falcon
>  Issue Type: Test
>Affects Versions: trunk
> Environment: QA
>Reporter: Karishma Gulati
>Assignee: Karishma Gulati
> Attachments: Falcon-1377-v2.patch, Falcon-1377.patch
>
>
> Add tests for the feature explained in 
> https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage 
> data processing issues through falcon. 
> As part of this patch, will add tests corresponding to single colo 
> processing. Cross-colo instance triage tests wil be added in a separate class 
> as part of a separate patch. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FALCON-1669) Falcon should show more helpful message when it is unable to initialize Falcon Client object

[Ajay Yadava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ajay Yadava updated FALCON-1669:

Summary: Falcon should show more helpful message when it is unable to 
initialize Falcon Client object  (was: Falcon should show the stackstrace info 
rather than just "Unable to initialize Falcon Client object")

> Falcon should show more helpful message when it is unable to initialize 
> Falcon Client object
> 
>
> Key: FALCON-1669
> URL: https://issues.apache.org/jira/browse/FALCON-1669
> Project: Falcon
>  Issue Type: Improvement
>  Components: client
>Reporter: baishuo
>Assignee: baishuo
> Fix For: 0.9
>
> Attachments: FALCON-1669.patch
>
>
> when client fail to start, we only get the information "Unable to initialize 
> Falcon Client object", I think we need more inforamation to get root cause. 
> So I think print the stacktrace of exception is nessasary



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the Triage API

[Karishma Gulati]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40779/
---

(Updated Dec. 17, 2015, 2:50 p.m.)


Review request for Falcon.


Repository: falcon-git


Description
---

Add tests for the feature explained in 
https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage data 
processing issues through falcon.
As part of this patch, will add tests corresponding to single colo processing. 
Cross-colo instance triage tests wil be added in a separate class as part of a 
separate patch.


Diffs (updated)
-

  
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java
 921a303 
  
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
 3d05ae9 
  
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
 00ef79d 
  
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/40779/diff/


Testing
---


Thanks,

Karishma Gulati

[jira] [Commented] (FALCON-1377) Add tests in falcon for the Triage API

[Karishma Gulati (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062142#comment-15062142
 ] 

Karishma Gulati commented on FALCON-1377:
-

Thanks [~ajayyadava], [~pragya.mittal] for the review. Have incorporated your 
comments and published the new patch here, as well as on the review board. 

> Add tests in falcon for the Triage API
> --
>
> Key: FALCON-1377
> URL: https://issues.apache.org/jira/browse/FALCON-1377
> Project: Falcon
>  Issue Type: Test
>Affects Versions: trunk
> Environment: QA
>Reporter: Karishma Gulati
>Assignee: Karishma Gulati
> Attachments: Falcon-1377-v2.patch, Falcon-1377.patch
>
>
> Add tests for the feature explained in 
> https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage 
> data processing issues through falcon. 
> As part of this patch, will add tests corresponding to single colo 
> processing. Cross-colo instance triage tests wil be added in a separate class 
> as part of a separate patch. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the Triage API

[Karishma Gulati]

> On Nov. 30, 2015, 2:40 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java,
> >  line 51
> > 
> >
> > inputDataRoot and outputDataRoot ?

We need to delete all test data (created for input and output feeds) as well, 
which wasn't getting deleted earlier. All our feed templates have these 
directories as their default data path.


> On Nov. 30, 2015, 2:40 p.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java,
> >  line 536
> > 
> >
> > Add to AssertUtil.

It's a very test logic specific assertion.


- Karishma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40779/#review108314
---


On Dec. 17, 2015, 2:50 p.m., Karishma Gulati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40779/
> ---
> 
> (Updated Dec. 17, 2015, 2:50 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Add tests for the feature explained in 
> https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage 
> data processing issues through falcon.
> As part of this patch, will add tests corresponding to single colo 
> processing. Cross-colo instance triage tests wil be added in a separate class 
> as part of a separate patch.
> 
> 
> Diffs
> -
> 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java
>  921a303 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
>  3d05ae9 
>   
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
>  00ef79d 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40779/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>

[jira] [Resolved] (FALCON-817) Simplify operability by merging the staging and working dirs in cluster entity into one dir

[Ajay Yadava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ajay Yadava resolved FALCON-817.

Resolution: Duplicate

Since FALCON-1648 already contains a patch, I am closing this JIRA as duplicate.

> Simplify operability by merging the staging and working dirs in cluster 
> entity into one dir
> ---
>
> Key: FALCON-817
> URL: https://issues.apache.org/jira/browse/FALCON-817
> Project: Falcon
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 0.6
>Reporter: Venkatesh Seetharam
>  Labels: operability
>
> Good to have one dir for user to create before submitting a cluster entity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1665) Migrate Pagination integration tests to unit tests

[Balu Vellanki (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062326#comment-15062326
 ] 

Balu Vellanki commented on FALCON-1665:
---

It should be fine to convert them to UTs if pagination test cases are covered 
in EntityManagerTest.

> Migrate Pagination integration tests to unit tests
> --
>
> Key: FALCON-1665
> URL: https://issues.apache.org/jira/browse/FALCON-1665
> Project: Falcon
>  Issue Type: Improvement
>Reporter: Ajay Yadava
>  Labels: newbie
>
> Currently EntityManagerPaginationJerseyIT contains integration tests for 
> pagination related functionality only. We can substitute them with the unit 
> tests, many unit tests for pagination are already available in 
> EntityManagerTest.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: Apache-Falcon-Distributed-Assembly #636

[Apache Jenkins Server]

See 


Changes:

[ajaynsit] FALCON-1635 Migration of EntityManagerJerseySmokeIT to use falcon 
unit.

[ajaynsit] FALCON-1669 Falcon should show more helpful message when it is 
unable to

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H4 (Mapreduce zookeeper Hadoop Pig falcon Hdfs) in 
workspace 
Checking out a fresh workspace because 
 
doesn't exist
Cleaning local Directory nightly
Checking out http://svn.apache.org/repos/asf/hadoop/nightly at revision 
'2015-12-17T15:30:12.671 +'
A test-patch
A test-patch/test-patch.sh
AUtar-munge
A commitBuild.sh
AUjenkinsPrecommitAdmin.py
A hudsonEnv.sh
A jenkinsSetup
A jenkinsSetup/installTools.sh
AUhudsonBuildHadoopNightly.sh
A buildMR-279Branch.sh
AUhudsonBuildHadoopPatch.sh
AUhudsonBuildHadoopRelease.sh
AUprocessHadoopPatchEmailRemote.sh
AUprocessHadoopPatchEmail.sh
A README.txt
At revision 1720604
Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/falcon.git
 > git init 
 >  # 
 > timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/falcon.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/falcon.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/falcon.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/falcon.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/falcon.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/falcon.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 62fb403beeb75da5f376c5c907fec5f2167842c0 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 62fb403beeb75da5f376c5c907fec5f2167842c0
 > git rev-list 4b523130fbbcaff9e2ff6e577ceb52e3572aaa3c # timeout=10
[Apache-Falcon-Distributed-Assembly] $ /bin/bash -xe 
/tmp/hudson7120500296301956586.sh
+ source nightly/hudsonEnv.sh
/tmp/hudson7120500296301956586.sh: line 2: nightly/hudsonEnv.sh: No such file 
or directory
Build step 'Execute shell' marked build as failure
Archiving artifacts

[jira] [Commented] (FALCON-1635) Migration of EntityManagerJerseySmokeIT to use falcon unit

[Narayan Periwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062292#comment-15062292
 ] 

Narayan Periwal commented on FALCON-1635:
-

Thanks [~ajayyadava]!

> Migration of EntityManagerJerseySmokeIT to use falcon unit
> --
>
> Key: FALCON-1635
> URL: https://issues.apache.org/jira/browse/FALCON-1635
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
> Fix For: 0.9
>
> Attachments: FALCON-1635-v1.patch, FALCON-1635-v2.patch, 
> FALCON-1635-v3.patch, FALCON-1635.patch
>
>
> In this jira, we migrate  EntityManagerPaginationJerseyIT and 
> EntityManagerJerseySmokeIT using falcon unit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41464: FALCON-1645 : Database export

[Balu Vellanki]

> On Dec. 17, 2015, 2:17 a.m., Ying Zheng wrote:
> > common/src/test/resources/config/feed/feed-export-0.1.xml, line 55
> > 
> >
> > According to my understanding, the element "Locations" can be removed 
> > since you already define it below "clusters". Correct me if I am wrong. 
> > Same for the other test xml.

Feed can have different locations for source and target clusters. The locations 
defined outside the "clusters" is the default. So I think having "locations" 
within cluster is ok.


- Balu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41464/#review110837
---


On Dec. 16, 2015, 8:12 p.m., Venkatesan Ramachandran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41464/
> ---
> 
> (Updated Dec. 16, 2015, 8:12 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Ability to export to database
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/LifeCycle.java d4d39e8 
>   client/src/main/java/org/apache/falcon/Tag.java 5027ac0 
>   client/src/main/resources/feed-0.1.xsd 2974dd6 
>   common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java f9b3966 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 66dba6f 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 18d5152 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 
> 0b48e66 
>   
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 
> f206ff1 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 98cdf6b 
>   
> common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java
>  a583f52 
>   common/src/test/java/org/apache/falcon/entity/v0/EntityGraphTest.java 
> f49362f 
>   common/src/test/resources/config/feed/feed-export-0.1.xml PRE-CREATION 
>   common/src/test/resources/config/feed/feed-export-exclude-fields-0.1.xml 
> PRE-CREATION 
>   
> oozie/src/main/java/org/apache/falcon/oozie/DatabaseExportWorkflowBuilder.java
>  PRE-CREATION 
>   
> oozie/src/main/java/org/apache/falcon/oozie/DatabaseImportWorkflowBuilder.java
>  45f46d7 
>   oozie/src/main/java/org/apache/falcon/oozie/ExportWorkflowBuilder.java 
> PRE-CREATION 
>   
> oozie/src/main/java/org/apache/falcon/oozie/FeedExportCoordinatorBuilder.java 
> PRE-CREATION 
>   
> oozie/src/main/java/org/apache/falcon/oozie/FeedImportCoordinatorBuilder.java 
> 70289d0 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java 
> b1db186 
>   
> oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
>  026f79f 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java 
> 9fbc5b2 
>   oozie/src/main/resources/action/feed/export-sqoop-database-action.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41464/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> Unit tests
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>

Re: Review Request 41464: FALCON-1645 : Database export

[Ying Zheng]

> On Dec. 17, 2015, 2:17 a.m., Ying Zheng wrote:
> > common/src/test/resources/config/feed/feed-export-0.1.xml, line 55
> > 
> >
> > According to my understanding, the element "Locations" can be removed 
> > since you already define it below "clusters". Correct me if I am wrong. 
> > Same for the other test xml.
> 
> Balu Vellanki wrote:
> Feed can have different locations for source and target clusters. The 
> locations defined outside the "clusters" is the default. So I think having 
> "locations" within cluster is ok.

Yes, I understand that. This is nitpicking. Both ways should generate the same 
result. Added this comment because there is only one cluster and the location 
within the cluster looks redundant in Venky's case.


- Ying


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41464/#review110837
---


On Dec. 16, 2015, 8:12 p.m., Venkatesan Ramachandran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41464/
> ---
> 
> (Updated Dec. 16, 2015, 8:12 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Ability to export to database
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/LifeCycle.java d4d39e8 
>   client/src/main/java/org/apache/falcon/Tag.java 5027ac0 
>   client/src/main/resources/feed-0.1.xsd 2974dd6 
>   common/src/main/java/org/apache/falcon/entity/DatasourceHelper.java f9b3966 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 66dba6f 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 18d5152 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 
> 0b48e66 
>   
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 
> f206ff1 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 98cdf6b 
>   
> common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java
>  a583f52 
>   common/src/test/java/org/apache/falcon/entity/v0/EntityGraphTest.java 
> f49362f 
>   common/src/test/resources/config/feed/feed-export-0.1.xml PRE-CREATION 
>   common/src/test/resources/config/feed/feed-export-exclude-fields-0.1.xml 
> PRE-CREATION 
>   
> oozie/src/main/java/org/apache/falcon/oozie/DatabaseExportWorkflowBuilder.java
>  PRE-CREATION 
>   
> oozie/src/main/java/org/apache/falcon/oozie/DatabaseImportWorkflowBuilder.java
>  45f46d7 
>   oozie/src/main/java/org/apache/falcon/oozie/ExportWorkflowBuilder.java 
> PRE-CREATION 
>   
> oozie/src/main/java/org/apache/falcon/oozie/FeedExportCoordinatorBuilder.java 
> PRE-CREATION 
>   
> oozie/src/main/java/org/apache/falcon/oozie/FeedImportCoordinatorBuilder.java 
> 70289d0 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java 
> b1db186 
>   
> oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
>  026f79f 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java 
> 9fbc5b2 
>   oozie/src/main/resources/action/feed/export-sqoop-database-action.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41464/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> Unit tests
> 
> 
> Thanks,
> 
> Venkatesan Ramachandran
> 
>

Re: Review Request 41396: FALCON-1635: Migration of EntityManagerPaginationJerseyIT and EntityManagerJerseySmokeIT to use falcon unit

[Balu Vellanki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41396/#review110967
---

Ship it!


Ship It!

- Balu Vellanki


On Dec. 17, 2015, 7:04 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41396/
> ---
> 
> (Updated Dec. 17, 2015, 7:04 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1635
> https://issues.apache.org/jira/browse/FALCON-1635
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> In this jira, we migrate EntityManagerPaginationJerseyIT and 
> EntityManagerJerseySmokeIT using falcon unit.
> 
> 
> Diffs
> -
> 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java 
> PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 
> 258bb1a 
>   
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java
>  2bedb88 
>   
> webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java
>  35119f0 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 
> f94bd8c 
>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 0697b3d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 
> 1d3167b 
> 
> Diff: https://reviews.apache.org/r/41396/diff/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Balu Vellanki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review110968
---



common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 
(line 193)


getTimeStampAsLong() and getNominalTimeStampAsLong() can be made into a 
single method to avoid code repetition.


- Balu Vellanki


On Dec. 17, 2015, 11:20 a.m., Peeyush Bishnoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> ---
> 
> (Updated Dec. 17, 2015, 11:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
> 
> Diffs
> -
> 
>   
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
>  b709857 
>   
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 
> f206ff1 
>   
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java
>  29f933d 
> 
> Diff: https://reviews.apache.org/r/41505/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>

[jira] [Commented] (FALCON-1665) Migrate Pagination integration tests to unit tests

[Ajay Yadava (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062552#comment-15062552
 ] 

Ajay Yadava commented on FALCON-1665:
-

Thanks for confirming [~bvellanki]. This is going to save me lot of time in 
committing patches :P

> Migrate Pagination integration tests to unit tests
> --
>
> Key: FALCON-1665
> URL: https://issues.apache.org/jira/browse/FALCON-1665
> Project: Falcon
>  Issue Type: Improvement
>Reporter: Ajay Yadava
>  Labels: newbie
>
> Currently EntityManagerPaginationJerseyIT contains integration tests for 
> pagination related functionality only. We can substitute them with the unit 
> tests, many unit tests for pagination are already available in 
> EntityManagerTest.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Peeyush Bishnoi]

> On Dec. 17, 2015, 5:16 p.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java,
> >  line 193
> > 
> >
> > getTimeStampAsLong() and getNominalTimeStampAsLong() can be made into a 
> > single method to avoid code repetition.

Fixed


- Peeyush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review110968
---


On Dec. 17, 2015, 11:20 a.m., Peeyush Bishnoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> ---
> 
> (Updated Dec. 17, 2015, 11:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
> 
> Diffs
> -
> 
>   
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
>  b709857 
>   
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 
> f206ff1 
>   
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java
>  29f933d 
> 
> Diff: https://reviews.apache.org/r/41505/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>

[jira] [Commented] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

[pavan kumar kolamuri (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063590#comment-15063590
 ] 

pavan kumar kolamuri commented on FALCON-1636:
--

Updated jira after addressing comments. Please check [~pallavi.rao] 
[~ajayyadava]

> Add Rerun API In Falcon Native Scheduler
> 
>
> Key: FALCON-1636
> URL: https://issues.apache.org/jira/browse/FALCON-1636
> Project: Falcon
>  Issue Type: Sub-task
>  Components: scheduler
>Reporter: pavan kumar kolamuri
>Assignee: pavan kumar kolamuri
> Attachments: FALCON-1447-v4.patch, FALCON-1636-v0.patch, 
> FALCON-1636-v1.patch, FALCON-1636-v2.patch, FALCON-1636-v3.patch
>
>
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[Ajay Yadava]

> On Dec. 18, 2015, 6:37 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java, line 53
> > 
> >
> > We want to use same logic for extrenal triggers also which can be 
> > triggered by external service.

It is still advisable to have two different events, we can still avoid code 
duplication by having multiple event types in case statement or calling same 
methods but the flows will be much clearer and they will also be easy to 
separate later on if you want special handling in case of only rerun.


> On Dec. 18, 2015, 6:37 a.m., pavan kumar kolamuri wrote:
> > client/src/main/java/org/apache/falcon/resource/InstancesResult.java, line 
> > 37
> > 
> >
> > After rerunning instances, we are displaying result with status. That 
> > time instance might be in Ready state. Please check in Falconworkflowengine 
> > rerun api.

My question is not on code flow but more on conditions. For example workflow 
status can be waiting - when workflow is waiting for data to be available. So 
what is the difference between READY and waiting? Is it that it is not running 
because of concurrency constraints?


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/#review25
---


On Dec. 18, 2015, 6:45 a.m., pavan kumar kolamuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41401/
> ---
> 
> (Updated Dec. 18, 2015, 6:45 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 
> e05eeeb 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
> 3cc8a25 
>   
> scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
>  f3beabc 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
>  59f5cba 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
>  PRE-CREATION 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java
>  1f69fab 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
> 2f3aa3a 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
> f1d1931 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java
>  4bee269 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 0e3dfa9 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java
>  b2f8e80 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
> e0d2a0e 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
> d274ad7 
>   
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
>  6d5bd49 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a 
> 
> Diff: https://reviews.apache.org/r/41401/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[Ajay Yadava]

- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/#review25
---


On Dec. 18, 2015, 6:45 a.m., pavan kumar kolamuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41401/
> ---
> 
> (Updated Dec. 18, 2015, 6:45 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 
> e05eeeb 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
> 3cc8a25 
>   
> scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
>  f3beabc 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
>  59f5cba 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
>  PRE-CREATION 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java
>  1f69fab 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
> 2f3aa3a 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
> f1d1931 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java
>  4bee269 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 0e3dfa9 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java
>  b2f8e80 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
> e0d2a0e 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
> d274ad7 
>   
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
>  6d5bd49 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a 
> 
> Diff: https://reviews.apache.org/r/41401/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[pavan kumar kolamuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/#review25
---



client/src/main/java/org/apache/falcon/resource/InstancesResult.java (line 37)


After rerunning instances, we are displaying result with status. That time 
instance might be in Ready state. Please check in Falconworkflowengine rerun 
api.



scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java (line 
437)


Makes sense will remove



scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
 (line 28)


Sure will change



scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
 (line 34)


Sure will change



scheduler/src/main/java/org/apache/falcon/state/InstanceState.java (line 53)


We want to use same logic for extrenal triggers also which can be triggered 
by external service.



scheduler/src/main/java/org/apache/falcon/state/InstanceState.java (line 54)


This is to make sure consistency with trigger and makes idempotent. As it 
is starting state



scheduler/src/main/java/org/apache/falcon/state/InstanceState.java (line 196)


Explained in previous comments



scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java 
(line 42)


Explained



scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
(line 145)


No, its actual externalID workflowId. We have already method for ExternalID


- pavan kumar kolamuri


On Dec. 17, 2015, 9 a.m., pavan kumar kolamuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41401/
> ---
> 
> (Updated Dec. 17, 2015, 9 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 
> e05eeeb 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
> 3cc8a25 
>   
> scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
>  f3beabc 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
>  59f5cba 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
>  PRE-CREATION 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java
>  1f69fab 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
> 2f3aa3a 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
> f1d1931 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java
>  4bee269 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 0e3dfa9 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java
>  b2f8e80 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
> e0d2a0e 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
> d274ad7 
>   
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
>  6d5bd49 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   

[jira] [Updated] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

[pavan kumar kolamuri (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pavan kumar kolamuri updated FALCON-1636:
-
Attachment: FALCON-1447-v4.patch

> Add Rerun API In Falcon Native Scheduler
> 
>
> Key: FALCON-1636
> URL: https://issues.apache.org/jira/browse/FALCON-1636
> Project: Falcon
>  Issue Type: Sub-task
>  Components: scheduler
>Reporter: pavan kumar kolamuri
>Assignee: pavan kumar kolamuri
> Attachments: FALCON-1447-v4.patch, FALCON-1636-v0.patch, 
> FALCON-1636-v1.patch, FALCON-1636-v2.patch, FALCON-1636-v3.patch
>
>
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[Ajay Yadava]

> On Dec. 18, 2015, 6:37 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java,
> >  line 145
> > 
> >
> > No, its actual externalID workflowId. We have already method for 
> > ExternalID

In FalconWorkflowEngine.java
```InstancesResult.WorkflowStatus.valueOf(STATE_STORE

.getExecutionInstance(instance.getId()).getCurrentState().name());```
instance.getID() returns InstanceID.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/#review25
---


On Dec. 18, 2015, 6:45 a.m., pavan kumar kolamuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41401/
> ---
> 
> (Updated Dec. 18, 2015, 6:45 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 
> e05eeeb 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
> 3cc8a25 
>   
> scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
>  f3beabc 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
>  59f5cba 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
>  PRE-CREATION 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java
>  1f69fab 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
> 2f3aa3a 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
> f1d1931 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java
>  4bee269 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 0e3dfa9 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java
>  b2f8e80 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
> e0d2a0e 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
> d274ad7 
>   
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
>  6d5bd49 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a 
> 
> Diff: https://reviews.apache.org/r/41401/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>

[jira] [Commented] (FALCON-1661) Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Peeyush Bishnoi (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063595#comment-15063595
 ] 

Peeyush Bishnoi commented on FALCON-1661:
-

Updated patch is attached after incorporating review comments.

> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
>
> Key: FALCON-1661
> URL: https://issues.apache.org/jira/browse/FALCON-1661
> Project: Falcon
>  Issue Type: Bug
>  Components: common
>Reporter: Peeyush Bishnoi
>Assignee: Peeyush Bishnoi
> Fix For: 0.9
>
> Attachments: FALCON-1661.patch, FALCON-1661.v1.patch
>
>
> When working on FALCON-1643, I found that same "timestamp" is getting set 
> upon adding Falcon instances vertices in GraphDB. Due to this while trying to 
> sort the vertices on timestamp many instances are not getting sorted properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[Ajay Yadava]

> On Dec. 18, 2015, 6:37 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java,
> >  line 145
> > 
> >
> > No, its actual externalID workflowId. We have already method for 
> > ExternalID
> 
> Ajay Yadava wrote:
> In FalconWorkflowEngine.java
> ```InstancesResult.WorkflowStatus.valueOf(STATE_STORE
> 
> .getExecutionInstance(instance.getId()).getCurrentState().name());```
> instance.getID() returns InstanceID.
> 
> pavan kumar kolamuri wrote:
> This is not the place this is used , this is used in
> @Override
> public void reRun(String cluster, String jobId, Properties props, 
> boolean isForced) throws FalconException {
> InstanceState instanceState = 
> STATE_STORE.getExecutionInstance(jobId);

So you are using the same method for fetching through instanceID and through 
externalID as well?


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/#review25
---


On Dec. 18, 2015, 6:45 a.m., pavan kumar kolamuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41401/
> ---
> 
> (Updated Dec. 18, 2015, 6:45 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 
> e05eeeb 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
> 3cc8a25 
>   
> scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
>  f3beabc 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
>  59f5cba 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
>  PRE-CREATION 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java
>  1f69fab 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
> 2f3aa3a 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
> f1d1931 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java
>  4bee269 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 0e3dfa9 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java
>  b2f8e80 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
> e0d2a0e 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
> d274ad7 
>   
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
>  6d5bd49 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a 
> 
> Diff: https://reviews.apache.org/r/41401/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>

[jira] [Updated] (FALCON-1661) Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Peeyush Bishnoi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peeyush Bishnoi updated FALCON-1661:

Attachment: FALCON-1661.v1.patch

> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
>
> Key: FALCON-1661
> URL: https://issues.apache.org/jira/browse/FALCON-1661
> Project: Falcon
>  Issue Type: Bug
>  Components: common
>Reporter: Peeyush Bishnoi
>Assignee: Peeyush Bishnoi
> Fix For: 0.9
>
> Attachments: FALCON-1661.patch, FALCON-1661.v1.patch
>
>
> When working on FALCON-1643, I found that same "timestamp" is getting set 
> upon adding Falcon instances vertices in GraphDB. Due to this while trying to 
> sort the vertices on timestamp many instances are not getting sorted properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Peeyush Bishnoi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/
---

(Updated Dec. 18, 2015, 6:48 a.m.)


Review request for Falcon.


Bugs: FALCON-1661
https://issues.apache.org/jira/browse/FALCON-1661


Repository: falcon-git


Description
---

Similar timestamp is getting added for Falcon instance vertex in GraphDB


Diffs (updated)
-

  
common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
 b709857 
  common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 
f206ff1 
  
common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 
29f933d 

Diff: https://reviews.apache.org/r/41505/diff/


Testing
---

yes


Thanks,

Peeyush Bishnoi

[jira] [Commented] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

[pavan kumar kolamuri (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063594#comment-15063594
 ] 

pavan kumar kolamuri commented on FALCON-1636:
--

My reply also went like comments , So duplicated the same to replies for 
clarity .  Please check

> Add Rerun API In Falcon Native Scheduler
> 
>
> Key: FALCON-1636
> URL: https://issues.apache.org/jira/browse/FALCON-1636
> Project: Falcon
>  Issue Type: Sub-task
>  Components: scheduler
>Reporter: pavan kumar kolamuri
>Assignee: pavan kumar kolamuri
> Attachments: FALCON-1447-v4.patch, FALCON-1636-v0.patch, 
> FALCON-1636-v1.patch, FALCON-1636-v2.patch, FALCON-1636-v3.patch
>
>
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (FALCON-1673) Making the cluster, feed and process xml's values configurable during submission.

[Narayan Periwal (JIRA)]

Narayan Periwal created FALCON-1673:
---

 Summary: Making the cluster, feed and process xml's values 
configurable during submission.
 Key: FALCON-1673
 URL: https://issues.apache.org/jira/browse/FALCON-1673
 Project: Falcon
  Issue Type: New Feature
Reporter: Narayan Periwal
Assignee: Narayan Periwal


As of now, when we submit the cluster, feed or process xmls, the values in the 
xmls are not configurable; the users have to declare the values to all the 
properties and thing in the xml itself. We want to make this configurable as in 
user should be able the variables during submission through the properties file 
or xml file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[pavan kumar kolamuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/
---

(Updated Dec. 18, 2015, 6:45 a.m.)


Review request for Falcon.


Changes
---

Addressed Comments


Repository: falcon-git


Description
---

Currently rerun API was not supported in case of Native Scheduler in Falcon. 
Rerun of instances should be implemented in FalconWorkflowEngine.


Diffs (updated)
-

  client/src/main/java/org/apache/falcon/resource/InstancesResult.java e05eeeb 
  scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
c9c0f42 
  scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
3cc8a25 
  
scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
 f3beabc 
  scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
e446069 
  
scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
 59f5cba 
  
scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
 PRE-CREATION 
  
scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
 fb11091 
  scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
  scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
  
scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java 
1f69fab 
  scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
  scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
2f3aa3a 
  scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
f1d1931 
  
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java 
4bee269 
  scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
0e3dfa9 
  
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java 
b2f8e80 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
e0d2a0e 
  
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
 c19cada 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
a26eb77 
  scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
d274ad7 
  
scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
 6d5bd49 
  
webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
 f5bcc54 
  
webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
 7959b63 
  webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a 

Diff: https://reviews.apache.org/r/41401/diff/


Testing
---


Thanks,

pavan kumar kolamuri

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[pavan kumar kolamuri]

> On Dec. 18, 2015, 5:20 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, 
> > line 438
> > 
> >
> > instance is already cast to ProcessExecutionInstance in the above 
> > statement, so checking here is redundant. May be this check should go up.

Will fix


> On Dec. 18, 2015, 5:20 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java,
> >  line 34
> > 
> >
> > Similarly can we make change here also to accept only InstanceID?

Sure


> On Dec. 18, 2015, 5:20 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java, line 53
> > 
> >
> > Won't RERUN be more intuitive instead of EXTERNAL_TRIGGER?

We want to use same logic for extrenal triggers also which can be triggered by 
external service.


> On Dec. 18, 2015, 5:20 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java, line 54
> > 
> >
> > Shouldn't rerun only be valid for terminal states? By that logic for 
> > waiting instances, rerun should throw invalid state transition exception, 
> > right?

This is to make sure consistency with trigger and makes idempotent. As it is 
starting state


> On Dec. 18, 2015, 5:20 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/state/InstanceState.java, line 196
> > 
> >
> > Will it be more intuitive to name it rerun?

Explained


> On Dec. 18, 2015, 5:20 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java,
> >  line 42
> > 
> >
> > Will it be more intuitive to rename it to onRerun?

Explained the reason


> On Dec. 18, 2015, 5:20 a.m., Ajay Yadava wrote:
> > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java,
> >  line 145
> > 
> >
> > Isn't it instanceID?

No it is workflowID


- pavan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/#review110948
---


On Dec. 17, 2015, 9 a.m., pavan kumar kolamuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41401/
> ---
> 
> (Updated Dec. 17, 2015, 9 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 
> e05eeeb 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
> 3cc8a25 
>   
> scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
>  f3beabc 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
>  59f5cba 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
>  PRE-CREATION 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java
>  1f69fab 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
> 2f3aa3a 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
> f1d1931 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java
>  4bee269 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 0e3dfa9 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java
>  b2f8e80 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
> e0d2a0e 
>   
> 

Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Balu Vellanki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review34
---

Ship it!


Ship It!

- Balu Vellanki


On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> ---
> 
> (Updated Dec. 18, 2015, 6:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
> 
> Diffs
> -
> 
>   
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
>  b709857 
>   
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 
> f206ff1 
>   
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java
>  29f933d 
> 
> Diff: https://reviews.apache.org/r/41505/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[pavan kumar kolamuri]

> On Dec. 18, 2015, 6:37 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java,
> >  line 145
> > 
> >
> > No, its actual externalID workflowId. We have already method for 
> > ExternalID
> 
> Ajay Yadava wrote:
> In FalconWorkflowEngine.java
> ```InstancesResult.WorkflowStatus.valueOf(STATE_STORE
> 
> .getExecutionInstance(instance.getId()).getCurrentState().name());```
> instance.getID() returns InstanceID.

This is not the place this is used , this is used in
@Override
public void reRun(String cluster, String jobId, Properties props, boolean 
isForced) throws FalconException {
InstanceState instanceState = STATE_STORE.getExecutionInstance(jobId);


- pavan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/#review25
---


On Dec. 18, 2015, 6:45 a.m., pavan kumar kolamuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41401/
> ---
> 
> (Updated Dec. 18, 2015, 6:45 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 
> e05eeeb 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
> 3cc8a25 
>   
> scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
>  f3beabc 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
>  59f5cba 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
>  PRE-CREATION 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java
>  1f69fab 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
> 2f3aa3a 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
> f1d1931 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java
>  4bee269 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 0e3dfa9 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java
>  b2f8e80 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
> e0d2a0e 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
> d274ad7 
>   
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
>  6d5bd49 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a 
> 
> Diff: https://reviews.apache.org/r/41401/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>

Re: Review Request 41396: FALCON-1635: Migration of EntityManagerPaginationJerseyIT and EntityManagerJerseySmokeIT to use falcon unit

[Ajay Yadava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41396/#review110947
---

Ship it!


Ship It!

- Ajay Yadava


On Dec. 17, 2015, 7:04 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41396/
> ---
> 
> (Updated Dec. 17, 2015, 7:04 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1635
> https://issues.apache.org/jira/browse/FALCON-1635
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> In this jira, we migrate EntityManagerPaginationJerseyIT and 
> EntityManagerJerseySmokeIT using falcon unit.
> 
> 
> Diffs
> -
> 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java 
> PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 
> 258bb1a 
>   
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java
>  2bedb88 
>   
> webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java
>  35119f0 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 
> f94bd8c 
>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 0697b3d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 
> 1d3167b 
> 
> Diff: https://reviews.apache.org/r/41396/diff/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

[jira] [Commented] (FALCON-1670) Testing of the xml files from example folder in distributed mode

[Ajay Yadava (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061969#comment-15061969
 ] 

Ajay Yadava commented on FALCON-1670:
-

[~Praveen]

If the existing examples don't work, then you can add new files with prefix 
"distributed" e.g. distributed-cluster.xml, distributed-input-feed.xml etc. 


> Testing of the xml files from example folder in distributed mode 
> -
>
> Key: FALCON-1670
> URL: https://issues.apache.org/jira/browse/FALCON-1670
> Project: Falcon
>  Issue Type: Test
>Reporter: Praveen Adlakha
>Assignee: Praveen Adlakha
>
> Hi All,
> While examples dir in distributed mode all the xml files were not tested.Need 
> to verify them.
> Thanks
> Praveen



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

[Ajay Yadava (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061974#comment-15061974
 ] 

Ajay Yadava commented on FALCON-1636:
-

I am in middle of reviewing this JIRA, will update the comments once I am done. 
Sorry for back and forth.

> Add Rerun API In Falcon Native Scheduler
> 
>
> Key: FALCON-1636
> URL: https://issues.apache.org/jira/browse/FALCON-1636
> Project: Falcon
>  Issue Type: Sub-task
>  Components: scheduler
>Reporter: pavan kumar kolamuri
>Assignee: pavan kumar kolamuri
> Attachments: FALCON-1636-v0.patch, FALCON-1636-v1.patch, 
> FALCON-1636-v2.patch, FALCON-1636-v3.patch
>
>
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (FALCON-1671) FalconUnit is causing webapp tests failure

[Peeyush Bishnoi (JIRA)]

Peeyush Bishnoi created FALCON-1671:
---

 Summary: FalconUnit is causing webapp tests failure
 Key: FALCON-1671
 URL: https://issues.apache.org/jira/browse/FALCON-1671
 Project: Falcon
  Issue Type: Bug
  Components: webapp
Reporter: Peeyush Bishnoi
Priority: Critical
 Fix For: 0.9


FalconUnit is causing webapp tests failure:

{code:java}
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 15.854 s
[INFO] Finished at: 2015-12-17T16:01:08+05:30
[INFO] Final Memory: 87M/425M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile 
(default-testCompile) on project falcon-webapp: Compilation failure: 
Compilation failure:
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java:[58,16]
 error: setup() in AbstractSchedulerManagerJerseyIT cannot override setup() in 
FalconUnitTestBase
[ERROR] overridden method does not throw Exception
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java:[98,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java:[99,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[44,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[45,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[71,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[95,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[122,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java:[92,16]
 error: setup() in EntityManagerJerseyIT cannot override setup() in 
FalconUnitTestBase
[ERROR] overridden method does not throw Exception
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[36,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[37,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[60,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[61,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[95,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[96,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java:[50,16]
 error: setup() in ProcessInstanceManagerIT cannot override setup() in 
FalconUnitTestBase
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FALCON-1671) FalconUnit is causing webapp tests failure

[Peeyush Bishnoi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peeyush Bishnoi updated FALCON-1671:

Description: 
FalconUnit tests are failing while building Falcon
{code:java}
Running org.apache.falcon.unit.TestFalconUnit
objc[1899]: Class JavaLaunchHelper is implemented in both 
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/bin/java 
and 
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
 One of the two will be used. Which one is undefined.
Tests run: 11, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 319.837 sec 
<<< FAILURE! - in org.apache.falcon.unit.TestFalconUnit
testProcessInstanceManagementAPI2(org.apache.falcon.unit.TestFalconUnit)  Time 
elapsed: 91.763 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertEquals(Assert.java:118)
at org.testng.Assert.assertEquals(Assert.java:160)
at 
org.apache.falcon.unit.TestFalconUnit.testProcessInstanceManagementAPI2(TestFalconUnit.java:285)

{code}

  was:
FalconUnit is causing webapp tests failure:

{code:java}
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 15.854 s
[INFO] Finished at: 2015-12-17T16:01:08+05:30
[INFO] Final Memory: 87M/425M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile 
(default-testCompile) on project falcon-webapp: Compilation failure: 
Compilation failure:
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java:[58,16]
 error: setup() in AbstractSchedulerManagerJerseyIT cannot override setup() in 
FalconUnitTestBase
[ERROR] overridden method does not throw Exception
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java:[98,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java:[99,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[44,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[45,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[71,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[95,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java:[122,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java:[92,16]
 error: setup() in EntityManagerJerseyIT cannot override setup() in 
FalconUnitTestBase
[ERROR] overridden method does not throw Exception
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[36,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[37,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[60,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[61,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[95,34]
 error: COLO has private access in FalconUnitTestBase
[ERROR] 
/Users/pbishnoi/data/apache/1491/falcon/webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java:[96,37]
 error: CLUSTER has private access in FalconUnitTestBase
[ERROR] 

[jira] [Commented] (FALCON-1661) Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Peeyush Bishnoi (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061919#comment-15061919
 ] 

Peeyush Bishnoi commented on FALCON-1661:
-

Patch is attached that will add the "timestamp" for Falcon instance vertex in 
GraphDB on basis of nominal time. Please review.

> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
>
> Key: FALCON-1661
> URL: https://issues.apache.org/jira/browse/FALCON-1661
> Project: Falcon
>  Issue Type: Bug
>  Components: common
>Reporter: Peeyush Bishnoi
>Assignee: Peeyush Bishnoi
> Fix For: 0.9
>
> Attachments: FALCON-1661.patch
>
>
> When working on FALCON-1643, I found that same "timestamp" is getting set 
> upon adding Falcon instances vertices in GraphDB. Due to this while trying to 
> sort the vertices on timestamp many instances are not getting sorted properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Peeyush Bishnoi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/
---

Review request for Falcon.


Bugs: FALCON-1661
https://issues.apache.org/jira/browse/FALCON-1661


Repository: falcon-git


Description
---

Similar timestamp is getting added for Falcon instance vertex in GraphDB


Diffs
-

  
common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
 b709857 
  common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 
f206ff1 
  
common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 
29f933d 

Diff: https://reviews.apache.org/r/41505/diff/


Testing
---

yes


Thanks,

Peeyush Bishnoi

[jira] [Commented] (FALCON-1639) Implement update feature for native scheduler

[sandeep samudrala (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061933#comment-15061933
 ] 

sandeep samudrala commented on FALCON-1639:
---

LGTM. +1

> Implement update feature for native scheduler
> -
>
> Key: FALCON-1639
> URL: https://issues.apache.org/jira/browse/FALCON-1639
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Pallavi Rao
>Assignee: Pallavi Rao
> Fix For: 0.9
>
> Attachments: FALCON-1639.patch, FALCON-1639.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41495: FALCON-1639 Implement update feature for native scheduler

[sandeep samudrala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41495/#review110943
---

Ship it!


Ship It!

- sandeep samudrala


On Dec. 17, 2015, 8:20 a.m., Pallavi Rao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41495/
> ---
> 
> (Updated Dec. 17, 2015, 8:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1639
> https://issues.apache.org/jira/browse/FALCON-1639
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Adding support entity update via native scheduler
> 
> 
> Diffs
> -
> 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   
> scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 
> 2f68ddb 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   
> scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
>  0ddf895 
> 
> Diff: https://reviews.apache.org/r/41495/diff/
> 
> 
> Testing
> ---
> 
> UT added. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

[jira] [Commented] (FALCON-1639) Implement update feature for native scheduler

[pavan kumar kolamuri (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061948#comment-15061948
 ] 

pavan kumar kolamuri commented on FALCON-1639:
--

[~pallavi.rao] I have left few comments. Can you please check. Other than that 
patch looks good.

> Implement update feature for native scheduler
> -
>
> Key: FALCON-1639
> URL: https://issues.apache.org/jira/browse/FALCON-1639
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Pallavi Rao
>Assignee: Pallavi Rao
> Fix For: 0.9
>
> Attachments: FALCON-1639.patch, FALCON-1639.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41396: FALCON-1635: Migration of EntityManagerPaginationJerseyIT and EntityManagerJerseySmokeIT to use falcon unit

[pavan kumar kolamuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41396/#review110946
---

Ship it!


Ship It!

- pavan kumar kolamuri


On Dec. 17, 2015, 7:04 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41396/
> ---
> 
> (Updated Dec. 17, 2015, 7:04 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1635
> https://issues.apache.org/jira/browse/FALCON-1635
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> In this jira, we migrate EntityManagerPaginationJerseyIT and 
> EntityManagerJerseySmokeIT using falcon unit.
> 
> 
> Diffs
> -
> 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java 
> PRE-CREATION 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 
> 258bb1a 
>   
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java
>  2bedb88 
>   
> webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java
>  35119f0 
>   
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java
>  7959b63 
>   
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 
> f94bd8c 
>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 0697b3d 
>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java 
> 1d3167b 
> 
> Diff: https://reviews.apache.org/r/41396/diff/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 41495: FALCON-1639 Implement update feature for native scheduler

[pavan kumar kolamuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41495/#review110944
---



scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java (line 
480)


Shouldn't we register here as we are unregistering to ServiceRegistery in 
suspend ?



scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
 (line 213)


Can you add comment about parallelInstances here why is it differnt from 
process concurrency. In InstanceRunner we are getting process concurrency right 
?



scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java (line 180)


Same here. why it is added as perdicate, we can always get from process 
definition right ?


- pavan kumar kolamuri


On Dec. 17, 2015, 8:20 a.m., Pallavi Rao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41495/
> ---
> 
> (Updated Dec. 17, 2015, 8:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1639
> https://issues.apache.org/jira/browse/FALCON-1639
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Adding support entity update via native scheduler
> 
> 
> Diffs
> -
> 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   
> scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 
> 2f68ddb 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   
> scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
>  0ddf895 
> 
> Diff: https://reviews.apache.org/r/41495/diff/
> 
> 
> Testing
> ---
> 
> UT added. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

[jira] [Updated] (FALCON-1671) FalconUnit tests are failing while building Falcon

[Peeyush Bishnoi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peeyush Bishnoi updated FALCON-1671:

Summary: FalconUnit tests are failing while building Falcon  (was: 
FalconUnit is causing webapp tests failure)

> FalconUnit tests are failing while building Falcon
> --
>
> Key: FALCON-1671
> URL: https://issues.apache.org/jira/browse/FALCON-1671
> Project: Falcon
>  Issue Type: Bug
>  Components: webapp
>Reporter: Peeyush Bishnoi
>Priority: Critical
> Fix For: 0.9
>
>
> FalconUnit tests are failing while building Falcon
> {code:java}
> Running org.apache.falcon.unit.TestFalconUnit
> objc[1899]: Class JavaLaunchHelper is implemented in both 
> /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/bin/java 
> and 
> /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
>  One of the two will be used. Which one is undefined.
> Tests run: 11, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 319.837 sec 
> <<< FAILURE! - in org.apache.falcon.unit.TestFalconUnit
> testProcessInstanceManagementAPI2(org.apache.falcon.unit.TestFalconUnit)  
> Time elapsed: 91.763 sec  <<< FAILURE!
> java.lang.AssertionError: expected: but was:
>   at org.testng.Assert.fail(Assert.java:89)
>   at org.testng.Assert.failNotEquals(Assert.java:489)
>   at org.testng.Assert.assertEquals(Assert.java:118)
>   at org.testng.Assert.assertEquals(Assert.java:160)
>   at 
> org.apache.falcon.unit.TestFalconUnit.testProcessInstanceManagementAPI2(TestFalconUnit.java:285)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FALCON-1661) Similar timestamp is getting added for Falcon instance vertex in GraphDB

[Peeyush Bishnoi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peeyush Bishnoi updated FALCON-1661:

Attachment: FALCON-1661.patch

> Similar timestamp is getting added for Falcon instance vertex in GraphDB
> 
>
> Key: FALCON-1661
> URL: https://issues.apache.org/jira/browse/FALCON-1661
> Project: Falcon
>  Issue Type: Bug
>  Components: common
>Reporter: Peeyush Bishnoi
>Assignee: Peeyush Bishnoi
> Fix For: 0.9
>
> Attachments: FALCON-1661.patch
>
>
> When working on FALCON-1643, I found that same "timestamp" is getting set 
> upon adding Falcon instances vertices in GraphDB. Due to this while trying to 
> sort the vertices on timestamp many instances are not getting sorted properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1635) Migration of EntityManagerJerseySmokeIT to use falcon unit

[pavan kumar kolamuri (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061951#comment-15061951
 ] 

pavan kumar kolamuri commented on FALCON-1635:
--

+1 for the patch. Looks good

> Migration of EntityManagerJerseySmokeIT to use falcon unit
> --
>
> Key: FALCON-1635
> URL: https://issues.apache.org/jira/browse/FALCON-1635
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
> Attachments: FALCON-1635-v1.patch, FALCON-1635-v2.patch, 
> FALCON-1635-v3.patch, FALCON-1635.patch
>
>
> In this jira, we migrate  EntityManagerPaginationJerseyIT and 
> EntityManagerJerseySmokeIT using falcon unit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1639) Implement update feature for native scheduler

[pavan kumar kolamuri (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061949#comment-15061949
 ] 

pavan kumar kolamuri commented on FALCON-1639:
--

[~pallavi.rao] Can you also please create a jira to add integration tests for 
touch and update? 

> Implement update feature for native scheduler
> -
>
> Key: FALCON-1639
> URL: https://issues.apache.org/jira/browse/FALCON-1639
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Pallavi Rao
>Assignee: Pallavi Rao
> Fix For: 0.9
>
> Attachments: FALCON-1639.patch, FALCON-1639.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1665) Migrate Pagination integration tests to unit tests

[Balu Vellanki (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062572#comment-15062572
 ] 

Balu Vellanki commented on FALCON-1665:
---

Saves all of us time, thank you for doing this [~ajayyadava]

> Migrate Pagination integration tests to unit tests
> --
>
> Key: FALCON-1665
> URL: https://issues.apache.org/jira/browse/FALCON-1665
> Project: Falcon
>  Issue Type: Improvement
>Reporter: Ajay Yadava
>  Labels: newbie
>
> Currently EntityManagerPaginationJerseyIT contains integration tests for 
> pagination related functionality only. We can substitute them with the unit 
> tests, many unit tests for pagination are already available in 
> EntityManagerTest.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41495: FALCON-1639 Implement update feature for native scheduler

[Pallavi Rao]

> On Dec. 17, 2015, 11:48 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java, 
> > line 484
> > 
> >
> > Shouldn't we register here as we are unregistering to ServiceRegistery 
> > in suspend ?

During resume, the instances are moved to the appropriate state. If they are 
supposed to be scheduled, onSchedule will get invoked and registering happens 
there.


> On Dec. 17, 2015, 11:48 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java,
> >  line 213
> > 
> >
> > Can you add comment about parallelInstances here why is it differnt 
> > from process concurrency. In InstanceRunner we are getting process 
> > concurrency right ?

The reason for adding parallelInstances is this - The update kicks in for new 
instances, but, old waiting instances are scheduled and it retrieves the 
parallelism for entity definition, it will the "new" parallelism (if the user 
has updated it). Since there is no versioning of entities yet, need to store 
what was the parallelism when that instance was created.

Will add a comment to that effect.


> On Dec. 17, 2015, 11:48 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java, line 180
> > 
> >
> > Same here. why it is added as perdicate, we can always get from process 
> > definition right ?

Answered above. Will add a comment.


- Pallavi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41495/#review110944
---


On Dec. 17, 2015, 8:20 a.m., Pallavi Rao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41495/
> ---
> 
> (Updated Dec. 17, 2015, 8:20 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1639
> https://issues.apache.org/jira/browse/FALCON-1639
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Adding support entity update via native scheduler
> 
> 
> Diffs
> -
> 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   
> scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 
> 2f68ddb 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   
> scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
>  0ddf895 
> 
> Diff: https://reviews.apache.org/r/41495/diff/
> 
> 
> Testing
> ---
> 
> UT added. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

Re: Review Request 41495: FALCON-1639 Implement update feature for native scheduler

[Pallavi Rao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41495/
---

(Updated Dec. 18, 2015, 4:48 a.m.)


Review request for Falcon.


Changes
---

Addressed review comments.


Bugs: FALCON-1639
https://issues.apache.org/jira/browse/FALCON-1639


Repository: falcon-git


Description
---

Adding support entity update via native scheduler


Diffs (updated)
-

  scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
c9c0f42 
  scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 
2f68ddb 
  scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
e446069 
  
scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
 fb11091 
  scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
  scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
  
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
 c19cada 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
a26eb77 
  
scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
 0ddf895 

Diff: https://reviews.apache.org/r/41495/diff/


Testing
---

UT added. Manual testing done.


Thanks,

Pallavi Rao

[jira] [Updated] (FALCON-1639) Implement update feature for native scheduler

[Pallavi Rao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FALCON-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Rao updated FALCON-1639:

Attachment: FALCON-1639-v1.patch

Addressed [~pavan kumar]'s review comments.

> Implement update feature for native scheduler
> -
>
> Key: FALCON-1639
> URL: https://issues.apache.org/jira/browse/FALCON-1639
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Pallavi Rao
>Assignee: Pallavi Rao
> Fix For: 0.9
>
> Attachments: FALCON-1639-v1.patch, FALCON-1639.patch, 
> FALCON-1639.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (FALCON-1672) Add Integration Tests for update and touch feature

[Pallavi Rao (JIRA)]

Pallavi Rao created FALCON-1672:
---

 Summary: Add Integration Tests for update and touch feature
 Key: FALCON-1672
 URL: https://issues.apache.org/jira/browse/FALCON-1672
 Project: Falcon
  Issue Type: Sub-task
  Components: scheduler
Reporter: Pallavi Rao






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41495: FALCON-1639 Implement update feature for native scheduler

[pavan kumar kolamuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41495/#review18
---

Ship it!


Ship It!

- pavan kumar kolamuri


On Dec. 18, 2015, 4:48 a.m., Pallavi Rao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41495/
> ---
> 
> (Updated Dec. 18, 2015, 4:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1639
> https://issues.apache.org/jira/browse/FALCON-1639
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Adding support entity update via native scheduler
> 
> 
> Diffs
> -
> 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   
> scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 
> 2f68ddb 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   
> scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
>  0ddf895 
> 
> Diff: https://reviews.apache.org/r/41495/diff/
> 
> 
> Testing
> ---
> 
> UT added. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

[jira] [Commented] (FALCON-1639) Implement update feature for native scheduler

[pavan kumar kolamuri (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063459#comment-15063459
 ] 

pavan kumar kolamuri commented on FALCON-1639:
--

Looks good +1 for the patch

> Implement update feature for native scheduler
> -
>
> Key: FALCON-1639
> URL: https://issues.apache.org/jira/browse/FALCON-1639
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Pallavi Rao
>Assignee: Pallavi Rao
> Fix For: 0.9
>
> Attachments: FALCON-1639-v1.patch, FALCON-1639.patch, 
> FALCON-1639.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FALCON-1639) Implement update feature for native scheduler

[Pallavi Rao (JIRA)]

[ 
https://issues.apache.org/jira/browse/FALCON-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063476#comment-15063476
 ] 

Pallavi Rao commented on FALCON-1639:
-

Thanks [~pavan kumar], [~sandeep.samudrala] for the review.

Committing this now to unblock QA. Please feel free to review post commit and 
open JIRAs for any comments that need to be addressed.

> Implement update feature for native scheduler
> -
>
> Key: FALCON-1639
> URL: https://issues.apache.org/jira/browse/FALCON-1639
> Project: Falcon
>  Issue Type: Sub-task
>Reporter: Pallavi Rao
>Assignee: Pallavi Rao
> Fix For: 0.9
>
> Attachments: FALCON-1639-v1.patch, FALCON-1639.patch, 
> FALCON-1639.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

[Ajay Yadava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41401/#review110948
---



client/src/main/java/org/apache/falcon/resource/InstancesResult.java (line 37)


Where is it getting used? Under what conditions is a workflow said to be in 
READY state?



scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java (line 
437)


instance is already cast to ProcessExecutionInstance in the above 
statement, so checking here is redundant. May be this check should go up.



scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
 (line 28)


Won't it be just InstanceID?



scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
 (line 34)


Similarly can we make change here also to accept only InstanceID?



scheduler/src/main/java/org/apache/falcon/state/InstanceState.java (line 53)


Won't RERUN be more intuitive instead of EXTERNAL_TRIGGER?



scheduler/src/main/java/org/apache/falcon/state/InstanceState.java (line 54)


Shouldn't rerun only be valid for terminal states? By that logic for 
waiting instances, rerun should throw invalid state transition exception, right?



scheduler/src/main/java/org/apache/falcon/state/InstanceState.java (line 196)


Will it be more intuitive to name it rerun?



scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java 
(line 42)


Will it be more intuitive to rename it to onRerun?



scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
(line 145)


Isn't it instanceID?


- Ajay Yadava


On Dec. 17, 2015, 9 a.m., pavan kumar kolamuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41401/
> ---
> 
> (Updated Dec. 17, 2015, 9 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> ---
> 
> Currently rerun API was not supported in case of Native Scheduler in Falcon. 
> Rerun of instances should be implemented in FalconWorkflowEngine.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 
> e05eeeb 
>   scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java 
> c9c0f42 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 
> 3cc8a25 
>   
> scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java
>  f3beabc 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutor.java 
> e446069 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/EventType.java
>  59f5cba 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/event/RerunEvent.java
>  PRE-CREATION 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  fb11091 
>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java 164fb0e 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java 7f2bda9 
>   
> scheduler/src/main/java/org/apache/falcon/state/InstanceStateChangeHandler.java
>  1f69fab 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c702cc3 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 
> 2f3aa3a 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 
> f1d1931 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java
>  4bee269 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 
> 0e3dfa9 
>   
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java
>  b2f8e80 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java 
> e0d2a0e 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
>  c19cada 
>   
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 
> a26eb77 
>   scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 
> d274ad7 
>   
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
>  6d5bd49 
>   
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java
>  f5bcc54 
>   
>