Re: Fineract CN Fims Web App: Angular 7 Upgrade

2019-05-28 Thread Vishwas Babu 
Hello Ruphine,

Done!

Regards,
Vishwas



On Mon, May 27, 2019 at 2:39 AM Ruphine Kengne 
wrote:

> Hello Vishwas,
>
> I have added some commits to this PR
>  which
> reduces some of the errors I faced and upgraded the ngrx to v7.
> Please can you merged that to the FINCN-154 branch you created so that
> anyone can clone that branch to contribute.
>
> Thanks.
>
> On Tue, 7 May 2019 at 19:48, Ruphine Kengne 
> wrote:
>
>> Thanks Vishwas
>>
>> On Tue, 7 May 2019 at 17:23, Vishwas Babu <
>> vish...@confluxtechnologies.com> wrote:
>>
>>> Hello Ruphine,
>>>
>>> >>Can a new branch be created on the Apache repository for me to push
>>> the changes there so as to enable other people to contribute?
>>> Done,  https://github.com/apache/fineract-cn-fims-web-app/tree/FINCN-154
>>>  .
>>>
>>> Regards,
>>> Vishwas
>>>
>>>
>>>
>>> On Tue, May 7, 2019 at 6:52 AM Ruphine Kengne 
>>> wrote:
>>>
 Hello Everyone,

 Hope this email finds you in good health.

 I have started upgrading fims web-app from angular v4 to v7 to solve
 the errors I faced when writing unit test. Here,
 https://issues.apache.org/jira/browse/FINCN-102

 I have created a Jira ticket :
 https://issues.apache.org/jira/browse/FINCN-154 to keep track.
 Here, is the link to my github repository :
 https://github.com/kengneruphine/fineract-cn-fims-web-app/tree/angular-7-upgrade
 with the new branch I created to contain the upgrade.

 Can a new branch be created on the Apache repository for me to push the
 changes there so as to enable other people to contribute?

 Right now, am facing some errors with ngrx and here is the link to the
 paste bin containing  the errors : https://pastebin.com/uvZLCwy5.

 Please, Mark can you help with the errors above?

 Thanks
 Ruphine Kengne

Re: Fineract CN Fims Web App: Angular 7 Upgrade

2019-05-27 Thread Ruphine Kengne 
Hello Vishwas,

I have added some commits to this PR
 which reduces
some of the errors I faced and upgraded the ngrx to v7.
Please can you merged that to the FINCN-154 branch you created so that
anyone can clone that branch to contribute.

Thanks.

On Tue, 7 May 2019 at 19:48, Ruphine Kengne  wrote:

> Thanks Vishwas
>
> On Tue, 7 May 2019 at 17:23, Vishwas Babu 
> wrote:
>
>> Hello Ruphine,
>>
>> >>Can a new branch be created on the Apache repository for me to push the
>> changes there so as to enable other people to contribute?
>> Done,  https://github.com/apache/fineract-cn-fims-web-app/tree/FINCN-154
>>  .
>>
>> Regards,
>> Vishwas
>>
>>
>>
>> On Tue, May 7, 2019 at 6:52 AM Ruphine Kengne 
>> wrote:
>>
>>> Hello Everyone,
>>>
>>> Hope this email finds you in good health.
>>>
>>> I have started upgrading fims web-app from angular v4 to v7 to solve the
>>> errors I faced when writing unit test. Here,
>>> https://issues.apache.org/jira/browse/FINCN-102
>>>
>>> I have created a Jira ticket :
>>> https://issues.apache.org/jira/browse/FINCN-154 to keep track.
>>> Here, is the link to my github repository :
>>> https://github.com/kengneruphine/fineract-cn-fims-web-app/tree/angular-7-upgrade
>>> with the new branch I created to contain the upgrade.
>>>
>>> Can a new branch be created on the Apache repository for me to push the
>>> changes there so as to enable other people to contribute?
>>>
>>> Right now, am facing some errors with ngrx and here is the link to the
>>> paste bin containing  the errors : https://pastebin.com/uvZLCwy5.
>>>
>>> Please, Mark can you help with the errors above?
>>>
>>> Thanks
>>> Ruphine Kengne
>>>
>>>

Re: Fineract CN Fims Web App: Angular 7 Upgrade

2019-05-07 Thread Ruphine Kengne 
Thanks Vishwas

On Tue, 7 May 2019 at 17:23, Vishwas Babu 
wrote:

> Hello Ruphine,
>
> >>Can a new branch be created on the Apache repository for me to push the
> changes there so as to enable other people to contribute?
> Done,  https://github.com/apache/fineract-cn-fims-web-app/tree/FINCN-154 .
>
> Regards,
> Vishwas
>
>
>
> On Tue, May 7, 2019 at 6:52 AM Ruphine Kengne 
> wrote:
>
>> Hello Everyone,
>>
>> Hope this email finds you in good health.
>>
>> I have started upgrading fims web-app from angular v4 to v7 to solve the
>> errors I faced when writing unit test. Here,
>> https://issues.apache.org/jira/browse/FINCN-102
>>
>> I have created a Jira ticket :
>> https://issues.apache.org/jira/browse/FINCN-154 to keep track.
>> Here, is the link to my github repository :
>> https://github.com/kengneruphine/fineract-cn-fims-web-app/tree/angular-7-upgrade
>> with the new branch I created to contain the upgrade.
>>
>> Can a new branch be created on the Apache repository for me to push the
>> changes there so as to enable other people to contribute?
>>
>> Right now, am facing some errors with ngrx and here is the link to the
>> paste bin containing  the errors : https://pastebin.com/uvZLCwy5.
>>
>> Please, Mark can you help with the errors above?
>>
>> Thanks
>> Ruphine Kengne
>>
>>

Re: Fineract CN Fims Web App: Angular 7 Upgrade

2019-05-07 Thread Vishwas Babu 
Hello Ruphine,

>>Can a new branch be created on the Apache repository for me to push the
changes there so as to enable other people to contribute?
Done,  https://github.com/apache/fineract-cn-fims-web-app/tree/FINCN-154 .

Regards,
Vishwas



On Tue, May 7, 2019 at 6:52 AM Ruphine Kengne 
wrote:

> Hello Everyone,
>
> Hope this email finds you in good health.
>
> I have started upgrading fims web-app from angular v4 to v7 to solve the
> errors I faced when writing unit test. Here,
> https://issues.apache.org/jira/browse/FINCN-102
>
> I have created a Jira ticket :
> https://issues.apache.org/jira/browse/FINCN-154 to keep track.
> Here, is the link to my github repository :
> https://github.com/kengneruphine/fineract-cn-fims-web-app/tree/angular-7-upgrade
> with the new branch I created to contain the upgrade.
>
> Can a new branch be created on the Apache repository for me to push the
> changes there so as to enable other people to contribute?
>
> Right now, am facing some errors with ngrx and here is the link to the
> paste bin containing  the errors : https://pastebin.com/uvZLCwy5.
>
> Please, Mark can you help with the errors above?
>
> Thanks
> Ruphine Kengne
>
>

Re: Fineract CN Fims Web App: Angular 7 Upgrade

2019-05-07 Thread Patrick Finken 
Hey Ruphine, usually this error is due to compatibility issues.
'OpaqueToken' has been replaced in angular by 'InjectionToken' (don't
remember which version)
Try to update  @ngx-translate   to the latest version.

Patrick

On Tue, 7 May 2019 at 09:52, Ruphine Kengne  wrote:

> Hello Everyone,
>
> Hope this email finds you in good health.
>
> I have started upgrading fims web-app from angular v4 to v7 to solve the
> errors I faced when writing unit test. Here,
> https://issues.apache.org/jira/browse/FINCN-102
>
> I have created a Jira ticket :
> https://issues.apache.org/jira/browse/FINCN-154 to keep track.
> Here, is the link to my github repository :
> https://github.com/kengneruphine/fineract-cn-fims-web-app/tree/angular-7-upgrade
> with the new branch I created to contain the upgrade.
>
> Can a new branch be created on the Apache repository for me to push the
> changes there so as to enable other people to contribute?
>
> Right now, am facing some errors with ngrx and here is the link to the
> paste bin containing  the errors : https://pastebin.com/uvZLCwy5.
>
> Please, Mark can you help with the errors above?
>
> Thanks
> Ruphine Kengne
>
>

-- 
Patrick Finken,
Principal Consultant

Fineract CN Fims Web App: Angular 7 Upgrade

2019-05-07 Thread Ruphine Kengne 
Hello Everyone,

Hope this email finds you in good health.

I have started upgrading fims web-app from angular v4 to v7 to solve the
errors I faced when writing unit test. Here,
https://issues.apache.org/jira/browse/FINCN-102

I have created a Jira ticket :
https://issues.apache.org/jira/browse/FINCN-154 to keep track.
Here, is the link to my github repository :
https://github.com/kengneruphine/fineract-cn-fims-web-app/tree/angular-7-upgrade
with the new branch I created to contain the upgrade.

Can a new branch be created on the Apache repository for me to push the
changes there so as to enable other people to contribute?

Right now, am facing some errors with ngrx and here is the link to the
paste bin containing  the errors : https://pastebin.com/uvZLCwy5.

Please, Mark can you help with the errors above?

Thanks
Ruphine Kengne
ERROR in node_modules/@ngx-translate/core/src/translate.service.d.ts(1,24): 
error TS2305: Module '"../../../@angular/core/core"' has no exported member 
'OpaqueToken'.
src/app/accounting/accounts/account.detail.component.ts(57,34): error TS2339: 
Property 'combineLatest' does not exist on type 'typeof Observable'.
src/app/accounting/store/account/effects/route.effects.ts(33,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/account/effects/route.effects.ts(39,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/account/effects/route.effects.ts(45,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/account/task/effects/route.effects.ts(33,28): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/index.ts(99,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store'.
src/app/accounting/store/ledger/effects/route.effects.ts(32,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/ledger/effects/route.effects.ts(38,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/ledger/journal-entry/effects/route.effects.ts(33,26): 
error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/ledger/transaction-type/effects/route.effects.ts(33,26):
 error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/ledger/transaction-type/effects/route.effects.ts(39,26):
 error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/payroll/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/common/date/fims-date.pipe.ts(27,14): error TS2415: Class 
'DisplayFimsDate' incorrectly extends base class 'DatePipe'.
  Types have separate declarations of a private property 'locale'.
src/app/common/store/form.reducer.ts(37,25): error TS2339: Property 'payload' 
does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(71,35): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(89,32): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(94,35): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(107,35): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(120,35): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/search.reducer.ts(63,51): error TS2339: Property 'payload' 
does not exist on type 'Action'.
src/app/common/store/search.reducer.ts(73,51): error TS2339: Property 'payload' 
does not exist on type 'Action'.
src/app/customers/cases/case.detail.component.ts(48,49): error TS2345: Argument 
of type '{}' is not assignable to parameter of type 'FimsPermission[]'.
  Type '{}' is missing the following properties from type 'FimsPermission[]': 
length, pop, push, concat, and 25 more.
src/app/customers/cases/case.detail.component.ts(51,8): error TS2339: Property 
'map' does not exist on type 'OperatorFunction<{} | FimsCase, { hasPermission: 
any; isCreatedOrPending: boolean; }>'.
src/app/customers/cases/case.list.component.ts(79,49): error TS2345: Argument 
of type '{}' is not assignable to parameter of type 'FimsPermission[]'.
src/app/customers/cases/case.list.component.ts(82,8): error TS2339: Property 
'map' does not exist on type 'OperatorFunction'.
src/app/customers/cases/store/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/cases/store/effects/route.effects.ts(39,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/cases/store/index.ts(74,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store'.
src/app/customers/deposits/store/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' d