Re: Rates Module PR Review and Use Case

[Awasum Yannick]

Thanks Mike, Please go ahead...This is long overdue.



On Sun, Mar 1, 2020 at 1:44 PM Michael Vorburger  wrote:

> I'd like to finally merge Angel's
> https://github.com/apache/fineract/pull/592.
>
> Does anyone have any objections? Without hearing objections, I'll merge
> that PR in 2 weeks from today.
>
>
> On Thu, 12 Dec 2019, 08:40 Michael Vorburger,  wrote:
>
>> On Fri, Jul 19, 2019 at 8:53 PM Awasum Yannick  wrote:
>>
>>> Is someone interested to look into this.
>>>
>>> Angel, i think you could merge your PR and also send in PRs for the UI.
>>> Make sure you update the user manual and documentation on how to use this
>>> feature.
>>>
>>
>> I just noticed that this old PR (
>> https://github.com/apache/fineract/pull/592) from Angel was *STILL* not
>> merged - really sorry about this Angel, I know from my own experience in
>> open source that it can be very frustrating if one puts in the time to
>> raise a PR which then gets ignored - we still have "some room for
>> improvement" in this regard as a community... ;-)
>>
>> I've just rebased this PR, but it now fails to build due to something
>> minor (see comment on PR). If you'd still be willing to address that, I'd
>> be very happy to finally merge this PR ASAP, even without any further
>> functional review, as 6 months (!) seem much more than enough for any
>> interested party having any objections to this to speak up.
>>
>> PS: As 2019 draws a close, let us all try to wrap up all pending PRs, and
>> either merge or close anything that's clearly abandoned? (One can always
>> raise new ones.)
>>
>>
>>> On Sat, Jun 29, 2019 at 3:29 PM Awasum Yannick 
>>> wrote:
>>>
 Hi All,

 Angel Cajas has put in alot of work to work on this PR and addressed
 numerous feedback.
 https://github.com/apache/fineract/pull/592

 Is there anyone willing to review the above.

 I would have been able to review the feature but am not familiar with
 the use case.

 Is there a UI or Spec doc for this feature which will ease review?

 Santosh, Ed, are you both in a position to review this PR and see if
 you could merge. Or will everyone be comfortable if Angel merged this into
 develop afterall, Angel is a committer.


 Thanks.
 Awasum

>>>

Re: Rates Module PR Review and Use Case

[Michael Vorburger]

I'd like to finally merge Angel's
https://github.com/apache/fineract/pull/592.

Does anyone have any objections? Without hearing objections, I'll merge
that PR in 2 weeks from today.


On Thu, 12 Dec 2019, 08:40 Michael Vorburger,  wrote:

> On Fri, Jul 19, 2019 at 8:53 PM Awasum Yannick  wrote:
>
>> Is someone interested to look into this.
>>
>> Angel, i think you could merge your PR and also send in PRs for the UI.
>> Make sure you update the user manual and documentation on how to use this
>> feature.
>>
>
> I just noticed that this old PR (
> https://github.com/apache/fineract/pull/592) from Angel was *STILL* not
> merged - really sorry about this Angel, I know from my own experience in
> open source that it can be very frustrating if one puts in the time to
> raise a PR which then gets ignored - we still have "some room for
> improvement" in this regard as a community... ;-)
>
> I've just rebased this PR, but it now fails to build due to something
> minor (see comment on PR). If you'd still be willing to address that, I'd
> be very happy to finally merge this PR ASAP, even without any further
> functional review, as 6 months (!) seem much more than enough for any
> interested party having any objections to this to speak up.
>
> PS: As 2019 draws a close, let us all try to wrap up all pending PRs, and
> either merge or close anything that's clearly abandoned? (One can always
> raise new ones.)
>
>
>> On Sat, Jun 29, 2019 at 3:29 PM Awasum Yannick  wrote:
>>
>>> Hi All,
>>>
>>> Angel Cajas has put in alot of work to work on this PR and addressed
>>> numerous feedback.
>>> https://github.com/apache/fineract/pull/592
>>>
>>> Is there anyone willing to review the above.
>>>
>>> I would have been able to review the feature but am not familiar with
>>> the use case.
>>>
>>> Is there a UI or Spec doc for this feature which will ease review?
>>>
>>> Santosh, Ed, are you both in a position to review this PR and see if you
>>> could merge. Or will everyone be comfortable if Angel merged this into
>>> develop afterall, Angel is a committer.
>>>
>>>
>>> Thanks.
>>> Awasum
>>>
>>

Re: Rates Module PR Review and Use Case

[Michael Vorburger]

On Fri, Jul 19, 2019 at 8:53 PM Awasum Yannick  wrote:

> Is someone interested to look into this.
>
> Angel, i think you could merge your PR and also send in PRs for the UI.
> Make sure you update the user manual and documentation on how to use this
> feature.
>

I just noticed that this old PR (https://github.com/apache/fineract/pull/592)
from Angel was *STILL* not merged - really sorry about this Angel, I know
from my own experience in open source that it can be very frustrating if
one puts in the time to raise a PR which then gets ignored - we still have
"some room for improvement" in this regard as a community... ;-)

I've just rebased this PR, but it now fails to build due to something minor
(see comment on PR). If you'd still be willing to address that, I'd be very
happy to finally merge this PR ASAP, even without any further functional
review, as 6 months (!) seem much more than enough for any interested party
having any objections to this to speak up.

PS: As 2019 draws a close, let us all try to wrap up all pending PRs, and
either merge or close anything that's clearly abandoned? (One can always
raise new ones.)


> On Sat, Jun 29, 2019 at 3:29 PM Awasum Yannick  wrote:
>
>> Hi All,
>>
>> Angel Cajas has put in alot of work to work on this PR and addressed
>> numerous feedback.
>> https://github.com/apache/fineract/pull/592
>>
>> Is there anyone willing to review the above.
>>
>> I would have been able to review the feature but am not familiar with the
>> use case.
>>
>> Is there a UI or Spec doc for this feature which will ease review?
>>
>> Santosh, Ed, are you both in a position to review this PR and see if you
>> could merge. Or will everyone be comfortable if Angel merged this into
>> develop afterall, Angel is a committer.
>>
>>
>> Thanks.
>> Awasum
>>
>>

Re: Rates Module PR Review and Use Case

[Awasum Yannick]

Is someone interested to look into this.

Angel, i think you could merge your PR and also send in PRs for the UI.
Make sure you update the user manual and documentation on how to use this
feature.

On Sat, Jun 29, 2019 at 3:29 PM Awasum Yannick  wrote:

> Hi All,
>
> Angel Cajas has put in alot of work to work on this PR and addressed
> numerous feedback.
> https://github.com/apache/fineract/pull/592
>
> Is there anyone willing to review the above.
>
> I would have been able to review the feature but am not familiar with the
> use case.
>
> Is there a UI or Spec doc for this feature which will ease review?
>
> Santosh, Ed, are you both in a position to review this PR and see if you
> could merge. Or will everyone be comfortable if Angel merged this into
> develop afterall, Angel is a committer.
>
>
> Thanks.
> Awasum
>
>

Rates Module PR Review and Use Case

[Awasum Yannick]

Hi All,

Angel Cajas has put in alot of work to work on this PR and addressed
numerous feedback.
https://github.com/apache/fineract/pull/592

Is there anyone willing to review the above.

I would have been able to review the feature but am not familiar with the
use case.

Is there a UI or Spec doc for this feature which will ease review?

Santosh, Ed, are you both in a position to review this PR and see if you
could merge. Or will everyone be comfortable if Angel merged this into
develop afterall, Angel is a committer.


Thanks.
Awasum

RE: Rates module

[Angel Cajas]

Hello Ed,

Thanks for taking some time to see this topic. We have received your comments 
and we will start to work on the requested changes as soon as possible.

Angel

-Original Message-
From: Ed Cable  
Sent: lunes, 30 de julio de 2018 6:51 p. m.
To: Dev ; Shruthi M R 
Cc: Adriana Pinto 
Subject: Re: Rates module

Hello Angel,

Thank you for raising this on the list again. I had been meaning to reach out 
to you and your team to ensure we get your contributions into one of the 
forthcoming releases.

I've cc'd Shruthi who can take the lead on reviewing but invite all community 
members (not just committers) to review and provided feedback on changes made.

Ed

On Mon, Jul 30, 2018 at 4:16 PM Angel Cajas  wrote:

> Hi ,
>
> I created an issue some time ago to add some previously defined rates 
> to calculate the minimum and maximum nominal rate for a loan.
> I committed and pushed those changes to a forked repository and crated 
> a new a pull request on the dev branch of this repository:
> https://github.com/apache/fineract.
> I hope that I can get your feedback about the changes I did.
>
> Thanks for your attention
>


--
*Ed Cable*
President/CEO, Mifos Initiative
edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649

*Collectively Creating a World of 3 Billion Maries | *http://mifos.org 
<http://facebook.com/mifos>  <http://www.twitter.com/mifos>

Re: Rates module

[Shruthi M R]

Hi Angel,

I have reviewed the PR and kindly check the comments.

Can you please share the community- app PR for the same.
If not present can you show us how it works in your system?


Thank You,

*Shruthi M R*
Senior Software Engineer - Conflux Technologies
shru...@confluxtechnologies.com | Skype: Shruthi Rajaram | Mobile:
+91-8277012716

On Tue, Jul 31, 2018 at 6:20 AM, Ed Cable  wrote:

> Hello Angel,
>
> Thank you for raising this on the list again. I had been meaning to reach
> out to you and your team to ensure we get your contributions into one of
> the forthcoming releases.
>
> I've cc'd Shruthi who can take the lead on reviewing but invite all
> community members (not just committers) to review and provided feedback on
> changes made.
>
> Ed
>
> On Mon, Jul 30, 2018 at 4:16 PM Angel Cajas  wrote:
>
>> Hi ,
>>
>> I created an issue some time ago to add some previously defined rates to
>> calculate the minimum and maximum nominal rate for a loan.
>> I committed and pushed those changes to a forked repository and crated a
>> new a pull request on the dev branch of this repository:
>> https://github.com/apache/fineract.
>> I hope that I can get your feedback about the changes I did.
>>
>> Thanks for your attention
>>
>
>
> --
> *Ed Cable*
> President/CEO, Mifos Initiative
> edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
>
> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
>   
>
>

Re: Rates module

[Ed Cable]

Hello Angel,

Thank you for raising this on the list again. I had been meaning to reach
out to you and your team to ensure we get your contributions into one of
the forthcoming releases.

I've cc'd Shruthi who can take the lead on reviewing but invite all
community members (not just committers) to review and provided feedback on
changes made.

Ed

On Mon, Jul 30, 2018 at 4:16 PM Angel Cajas  wrote:

> Hi ,
>
> I created an issue some time ago to add some previously defined rates to
> calculate the minimum and maximum nominal rate for a loan.
> I committed and pushed those changes to a forked repository and crated a
> new a pull request on the dev branch of this repository:
> https://github.com/apache/fineract.
> I hope that I can get your feedback about the changes I did.
>
> Thanks for your attention
>


-- 
*Ed Cable*
President/CEO, Mifos Initiative
edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649

*Collectively Creating a World of 3 Billion Maries | *http://mifos.org
  

Rates module

[Angel Cajas]

Hi ,

I created an issue some time ago to add some previously defined rates to 
calculate the minimum and maximum nominal rate for a loan.
I committed and pushed those changes to a forked repository and crated a new a 
pull request on the dev branch of this repository: 
https://github.com/apache/fineract.
I hope that I can get your feedback about the changes I did.

Thanks for your attention