[jira] [Resolved] (FLEX-16004) DateFormatter return empty string when modifies properties of DateBase for non US
[ https://issues.apache.org/jira/browse/FLEX-16004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-16004. -- Resolution: Fixed Fix Version/s: Apache Flex 4.10.0 Fixed DateFormatter so that Date.toString format is correctly recognised which was the basic issue. User code has some binding issues. DateFormatter return empty string when modifies properties of DateBase for non US - Key: FLEX-16004 URL: https://issues.apache.org/jira/browse/FLEX-16004 Project: Apache Flex Issue Type: Bug Components: Formatters Affects Versions: Adobe Flex SDK 3.1 (Release) Environment: Affected OS(s): Windows Affected OS(s): Windows XP Language Found: English Reporter: Adobe JIRA Labels: easyfix Fix For: Apache Flex 4.10.0 Attachments: teste.mxml Steps to reproduce: 1. Compile and run attached MXML file Actual Results: Empty String when modifies properties of DateBase for non US (I'm Brazilian) on initApp method. If I don't work fine. Expected Results: Dates formatted correctly. Workaround (if any): To use labelFunction on AdvancedDataGrid instead property formatter. Or, extends AdvancedDataGridColumn overriding itemToLabel using applyFormatting with parameter Object (or Date) instead String. Date.toString always returns US format instead format setted in DateBase. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLEX-14718) Sorting null values
[ https://issues.apache.org/jira/browse/FLEX-14718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-14718. -- Resolution: Cannot Reproduce Fixed in earlier version of the SDK. Sorting null values --- Key: FLEX-14718 URL: https://issues.apache.org/jira/browse/FLEX-14718 Project: Apache Flex Issue Type: Bug Components: mx: DataGrid Affects Versions: Adobe Flex SDK 2.0.1 (Release) Environment: Affected OS(s): Windows Affected OS(s): Windows XP Browser: Firefox 2.x Language Found: Japanese Reporter: Adobe JIRA Labels: easyfix, easytest This bug reappears. https://bugs.adobe.com/jira/browse/SDK-10865 Please try an attached sample with a debugging player. Steps to reproduce: 1.Execute an Flex Application.(gridsortsample.mxml) 2.Click DataGridHeaderbirthday.(Once or twice) The suggestion of the revision. Please change the 557th line of SortField.as as follows.(private function nullCompare) if (typeLeft is Date || typeRight is Date) - if (left is Date || right is Date) Probably I think it to be all right in this details:FxUG in Japan http://www.fxug.net/modules/xhnewbb/viewtopic.php?topic_id=1843post_id=7663#forumpost7663 My development environment Flex Builder 2.0.1(Flex SDK 2.0.1 hotfix3) Eclipse Plug-in -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLEX-26719) [flex_next] Much slower instantiation of visual components in SDK 4
[ https://issues.apache.org/jira/browse/FLEX-26719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean reassigned FLEX-26719: Assignee: (was: Justin Mclean) [flex_next] Much slower instantiation of visual components in SDK 4 --- Key: FLEX-26719 URL: https://issues.apache.org/jira/browse/FLEX-26719 Project: Apache Flex Issue Type: Bug Components: .Unspecified - Framework Affects Versions: Adobe Flex SDK 4.1 (Release) Environment: Affected OS(s): All OS Platforms Affected OS(s): All OS Platforms Browser: Firefox 3.x Language Found: English Reporter: Adobe JIRA Priority: Critical Steps to reproduce: 1. Build a simple Flex MX application, which creates a large number of visual components (or use the sample). 2. Make sure to set Halo theme in SDK 4 application. 3. Compile and run it with SDK 3.5 and SDK 4, noticing time it takes from starting creating components till creation is complete. 4. Do the same as in 3. only this time set Spark theme in SDK 4 MX application. 5. Build equivalent pure-Spark SDK 4 application (or use the sample) and compare times. For more details see: http://forums.adobe.com/thread/786472?tstart=0 Actual Results: Under SDK 4 with Halo Theme it takes 30-40% more time to create components (may vary across environments). On more complex real MX Halo application (up to 500 visual elements per complex component) the observed difference was up to x3-x4. Under SDK 4 with Spark Theme it takes 300-400% (!!!) more time to do the same. Pure Spark SDK 4 application with Spark Theme is as slow as SDK 4 MX one with Spark Theme. Expected Results: Time to instantiate visual components should be about the same under any SDK going up from version 3, otherwise upgrading existing applications becomes problematic due to worsening user experience. Same is expected from different Themes. Pure Spark application should be as fast if not faster than equivalent MX code. Workaround (if any): Redesign complex components to defer instantiation of widgets for as long as possible. Reduce number of containers. Move as much as possible code from MXML into AS, prefer AS-based skins over MXML. Sample MX application: ?xml version=1.0 encoding=utf-8? mx:Application xmlns:mx=http://www.adobe.com/2006/mxml; layout=vertical minWidth=955 minHeight=600 mx:Script ![CDATA[ import flash.utils.getTimer; import mx.containers.HBox; import mx.controls.CheckBox; import mx.events.FlexEvent; protected function button1_clickHandler(event:MouseEvent):void { holder.removeAllChildren(); var start:int = getTimer(); var holdAll:VBox = new VBox(); holdAll.addEventListener(FlexEvent.CREATION_COMPLETE, function():void { var end:Number = getTimer(); info.text = (end - start).toString(); }); for (var i:int = 0; i 5; i++) { var vb:VBox = new VBox(); var lbl:Label = new Label(); lbl.text = VBox + i.toString(); vb.addChild(lbl); for (var j:int = 0; j 5; j++) { var c:HBox = new HBox(); for (var k:int = 0; k 10; k++) { var comp:CheckBox = new CheckBox(); comp.label = k.toString(); comp.width = 100; c.addChild(comp); } vb.addChild(c); } holdAll.addChild(vb); } holder.addChild(holdAll); } ]] /mx:Script mx:Button label=Add Complex Component width=300 click=button1_clickHandler(event)/ mx:Label id=info text=Time will be here / mx:VBox id=holder /mx:VBox /mx:Application Sample Spark application: ?xml version=1.0 encoding=utf-8? s:Application xmlns:fx=http://ns.adobe.com/mxml/2009; xmlns:s=library://ns.adobe.com/flex/spark xmlns:mx=library://ns.adobe.com/flex/mx minWidth=955 minHeight=600 s:layout s:VerticalLayout horizontalAlign=center verticalAlign=top / /s:layout fx:Declarations !-- Place non-visual elements (e.g., services, value objects) here -- /fx:Declarations fx:Script ![CDATA[ import flash.utils.getTimer; import
[jira] [Resolved] (FLEX-23151) currency formatter remove -ve sign after formatting
[ https://issues.apache.org/jira/browse/FLEX-23151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-23151. -- Resolution: Cannot Reproduce Fixed in earlier version of the SDK currency formatter remove -ve sign after formatting --- Key: FLEX-23151 URL: https://issues.apache.org/jira/browse/FLEX-23151 Project: Apache Flex Issue Type: Bug Components: MXML Components Affects Versions: Adobe Flex SDK 3.2 (Release) Environment: Affected OS(s): Windows Affected OS(s): Windows Browser: Firefox 3.x Language Found: English Reporter: Adobe JIRA Steps to reproduce: 1. put -ve value in textinput, on focusout its formats correctly 2. again focus in textinput. 3. on focus out this time it removes - ve sign. Actual Results: formatted value without -ve sign. Expected Results: there should be -ve sign after formatting. Workaround (if any): you need to manually put -ve sign after formatting if its negative. PS: I need currency that can be negative value in my project. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLEX-14871) CurrencyValidator not work with ',' decimal separator
[ https://issues.apache.org/jira/browse/FLEX-14871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-14871. -- Resolution: Won't Fix Having decimal and currency separator the same is not supported. CurrencyValidator not work with ',' decimal separator - Key: FLEX-14871 URL: https://issues.apache.org/jira/browse/FLEX-14871 Project: Apache Flex Issue Type: Bug Components: mx: General Affects Versions: Adobe Flex SDK 3.0 (Release) Environment: Affected OS(s): Windows Affected OS(s): Windows XP Browser: Internet Explorer 7.x Language Found: English Reporter: Adobe JIRA Labels: easytest Steps to reproduce: 1. Create a new project with: n.1 TextInput, n.1 Button and n.1 CurrencyValidator 2. Setup decimalSeparator attribute of CurrencyValidator with this char: , mx:TextInput id=importo textAlign=right text=0,00/mx:TextInput mx:Button y=0 label=OK id=submit / mx:CurrencyValidator id=importoV source={importo} property=text trigger={submit} triggerEvent=click decimalSeparator=',' required=true/ Actual Results: Decimal separator ',' is not accepted Expected Results: Decimal separator ',' is accepted Workaround (if any): -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLEX-30481) Flash Builder premium License automation with FlexMonkey
[ https://issues.apache.org/jira/browse/FLEX-30481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-30481. -- Resolution: Won't Fix Can't fix not Apache Flex SDK issue. Flash Builder premium License automation with FlexMonkey - Key: FLEX-30481 URL: https://issues.apache.org/jira/browse/FLEX-30481 Project: Apache Flex Issue Type: Bug Components: Descriptive Programming Affects Versions: Adobe Flex SDK Previous Environment: Affected OS(s): Windows Affected OS(s): Windows Language Found: English Reporter: Adobe JIRA Steps to reproduce: 1. Create an application with SDK 3.6 on Flash builder 4.5 Premium licensed version on Windows 7 2. Compile it with FlexMonkey Libraries to enable automation 3. Record more than 30 actions with Flex Monkey Actual Results: Message : License not present. With trial version only limited records are allowed Expected Results: Unlimited recording should be allowed Workaround (if any): Working on some Windows xp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Odd SDK code for the day
Hi, In mx:Label we have: mx_internal function getMinimumText(t:String):String { // If the text is null, empty, or a single character, // make the measured size big enough to hold // a capital and decending character using the current font. if (!t || t.length 2) t = Wj; return t; } The explanation makes sense ie says what exactly it does but why does it do this? It means that width of 9 greater than width of 99 as it called by measure. https://issues.apache.org/jira/browse/FLEX-17549 Thanks, Justin
[jira] [Commented] (FLEX-17549) According to mx:Label, 9 is larger than 99
[ https://issues.apache.org/jira/browse/FLEX-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13652808#comment-13652808 ] Justin Mclean commented on FLEX-17549: -- Used to measure baseline in other places in the SDK. Not sure that it's needed here. According to mx:Label, 9 is larger than 99 -- Key: FLEX-17549 URL: https://issues.apache.org/jira/browse/FLEX-17549 Project: Apache Flex Issue Type: Bug Components: mx: Label Affects Versions: Adobe Flex SDK 3.0 (Release) Environment: Affected OS(s): All OS Platforms Affected OS(s): All OS Platforms Language Found: English Reporter: Adobe JIRA Steps to reproduce: 1. Create a Label with a text of one character, like 9 Actual Results: The measured width is way larger than it should be. For example, Label.text=9 is larger than Label.text=99. Expected Results: The measured width should reflect the text value. Workaround (if any): Extend Label to override the getMinimumText function, which replaces the client text value by an internal constant string (Wj) if the client text value is less than two characters long. I can manage to do just that, but since I spent the last hour looking at my own code only to finally figure out that the problem was this Label.getMinimumText thing, I would be delighted to read an explanation about it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [DISCUSS] Github based Whiteboard proposal
Hi, Sorry for the delay but yeah, totally in line with Om. -Fred -Message d'origine- From: OmPrakash Muppirala Sent: Wednesday, May 08, 2013 7:42 PM To: dev@flex.apache.org Subject: Re: [DISCUSS] Github based Whiteboard proposal On Wed, May 8, 2013 at 9:33 AM, Alex Harui aha...@adobe.com wrote: I added webdoublefx at gmail dot com. Do we want to have a strict naming convention for the whiteboards and restrict it to whiteboard_apacheid? What would be the pros and cons? Yes for strict naming convention. No for restricting it to just whiteboard_apacheid. I would vote for a convention like: whiteboard_apacheid_projectname. With GitHub, we get unlimited amount of space and unlimited number of repos. There is no need to restrict ourselves to one repo per committer. I dont see any pros with restricting. Fred, do you want _developerToolSuite added to the name because you may want a different whiteboard for a different topic later? Why is it hard to manage separate topics in folders in a single whiteboard repo? I can think of a scenario where a committer forks the flex-sdk (example: whiteboard_bigosmallm_flex-sdk) from the github mirror, make changes, get some community involvement, etc. When all pull requests are resolved, a simple patch can be generated and applied to our Apache git repo. This workflow makes life so much easier. Thanks, Om -Alex On 5/8/13 2:54 AM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Thanks Om, 2 things though: - The email address to add is webdoublefx at gmail dot com - I would rather prefer my repo with the name whiteboard_fthomas_developerToolSuite -Fred -Message d'origine- From: OmPrakash Muppirala Sent: Wednesday, May 08, 2013 9:26 AM To: dev@flex.apache.org Subject: Re: [DISCUSS] Github based Whiteboard proposal I have added you to the apacheflex github organization. Your whiteboard repo is available at: https://github.com/apacheflex/whiteboard_doublefx You should have received a notification. Let me know if you dint receive anything. There is a CONTRIBUTING.md file at the root of your repo which has instructions on how to contribute to Apache/Apache Flex. Lets just go with your existing email id on github for now instead of your apache alias? It will make lives easier for committers if they do not have to change their existing email ids on GitHub. If this works with Frederic, Alex, can you please add doublefx@gmail.comto the commits@f.a.o list? BTW, I can add any PMC members to the organization's owners account. Please send me your github account if you are interested. Thanks, Om On Tue, May 7, 2013 at 8:25 PM, Frédéric THOMAS webdoubl...@hotmail.comwrote: Sure, it is doublefx like in https://github.com/doublefx but I'm pretty sure I'll have to add another email address somewhere, my committer alias is based on my hotmail account, my github one on my gmail account, from what I read before, I should be able to add my apache one somewhere, right ? I'll read what links Dasa provided about it tomorrow, I mean in few hours and let you know except if you know already what I have to do... Btw, thanks for your great job inquiring about it ! -Fred -Message d'origine- From: OmPrakash Muppirala Sent: Wednesday, May 08, 2013 5:09 AM To: dev@flex.apache.org Subject: Re: [DISCUSS] Github based Whiteboard proposal On May 7, 2013 7:50 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: It's ok for me, I want try Awesome! Can you please send me your github id? Thanks, Om -Message d'origine- From: OmPrakash Muppirala Sent: Tuesday, May 07, 2013 7:15 PM To: dev@flex.apache.org Subject: Re: [DISCUSS] Github based Whiteboard proposal Okay, is it time for us to test this proposal by implementing a couple of whiteboard repos? Anyone committer wants to volunteer? Thanks, Om On Mon, May 6, 2013 at 5:10 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Mon, May 6, 2013 at 5:02 PM, Alex Harui aha...@adobe.com wrote: OK. Just wondering, if a committer already has a github account under a different email address, what do they do? -Alex GitHub lets you add multiple emails to the github account. It will be up to the committer to switch the 'default' email id which the post-commit email hook uses when sending out emails. I think Dasa had sent a couple of relevant github wiki pages a few emails ago about this. Thanks, Om On 5/6/13 4:03 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Mon, May 6, 2013 at 3:48 PM, Alex Harui aha...@adobe.com wrote: Om, Can you update the proposal as to whether you have to use your a.o email or if allowing aliases works? -Alex I have posted the proposal here: https://cwiki.apache.org/**confluence/display/FLEX/** Proposal+-+Github+based+White https://cwiki.apache.org/confluence/display/FLE X/Proposal+-+Github+based+White board All apache.org emails are
Re: Odd SDK code for the day
It was done to try to get ascenders and descenders factored into the height. On 5/9/13 12:53 AM, Justin Mclean jus...@classsoftware.com wrote: Hi, In mx:Label we have: mx_internal function getMinimumText(t:String):String { // If the text is null, empty, or a single character, // make the measured size big enough to hold // a capital and decending character using the current font. if (!t || t.length 2) t = Wj; return t; } The explanation makes sense ie says what exactly it does but why does it do this? It means that width of 9 greater than width of 99 as it called by measure. https://issues.apache.org/jira/browse/FLEX-17549 Thanks, Justin -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: Odd SDK code for the day
Hi, It was done to try to get ascenders and descenders factored into the height. Understand but then the width is then wrong. It this case the height isn't the issue. It's used in other part of the SDK when the height is important ie to calculate min height or where the baseline is but seems a little inconsistent from the quick glance I took. Just search for Wj it turns up in about a dozen places. Justin
Re: In AIR, would WindowedSystemManager not be used no longer?
Realy!? Since when? 2013/5/9 Alex Harui aha...@adobe.com Adobe Flex is the same way. On 5/8/13 8:52 AM, pepe.f...@gmail.com pepe.f...@gmail.com wrote: Hello I checked WindowedApplication#systemManager, it was SystemManager but not WindowedSystemManager. Was this changed? Or WindowedApplication#systemManager was SystemManager since Adobe Flex? thanks Shigeru Nakagaki -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: In AIR, would WindowedSystemManager not be used no longer?
On 5/9/13 8:05 AM, pepe.f...@gmail.com pepe.f...@gmail.com wrote: Realy!? Since when? I don't know without digging. It could be forever. Is it important to know when? WindowedSystemManager is still used for other Windows in an AIR app. 2013/5/9 Alex Harui aha...@adobe.com Adobe Flex is the same way. On 5/8/13 8:52 AM, pepe.f...@gmail.com pepe.f...@gmail.com wrote: Hello I checked WindowedApplication#systemManager, it was SystemManager but not WindowedSystemManager. Was this changed? Or WindowedApplication#systemManager was SystemManager since Adobe Flex? thanks Shigeru Nakagaki -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: Odd SDK code for the day
On 5/9/13 6:38 AM, Justin Mclean jus...@classsoftware.com wrote: Hi, It was done to try to get ascenders and descenders factored into the height. Understand but then the width is then wrong. It this case the height isn't the issue. It's used in other part of the SDK when the height is important ie to calculate min height or where the baseline is but seems a little inconsistent from the quick glance I took. Just search for Wj it turns up in about a dozen places. Justin Yup, not defending, just explaining its purpose. (and I thought we used to have ^ in there as well. Feel free to put in a better mechanism, but it might cost you a few cycles. I think we decided it was a trade-off on how often folks need to know the size of single-character strings. Quite frankly, I don't recall if this was done because of some old player bug or whether the player really does still return a lower textHeight for a string like vs W^j on all platforms and on all embedded font rendering subsystems. It could be that this technique is no longer needed. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
[flex-sdk] Checkintest broken
I just synced up and checkintests is failing in SparkTextInputTest1. Is anybody else having this issue? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: 480 DPI density mobile support
On Wed, May 8, 2013 at 12:49 AM, Justin Mclean jus...@classsoftware.comwrote: HI, If you let me know the related files, I can take a stab at it. It's everything under frameworks/projects/mobiletheme/src/spark/skins/mobile/mobile480 in the 480dpi branch, files there are just a copy of the the 320 dpi files. Free free to delete everything in that directory and start from scratch if you want. Thanks, Justin I wrote a small tool to upconvert the 320dpi to 420dpi. Essentially I scaled up each first level child element in every skin by a factor of 1.5. Anyone see any problems with this logic? I did some random testing and the new skins look okay to my naked eye. But I want to do more thorough testing. What would be the best way to test these new skins? Can I check it into the 480dpi branch for others to test as well? Thanks, Om
Re: 480 DPI density mobile support
On 5/9/13 12:38 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Wed, May 8, 2013 at 12:49 AM, Justin Mclean jus...@classsoftware.comwrote: HI, If you let me know the related files, I can take a stab at it. It's everything under frameworks/projects/mobiletheme/src/spark/skins/mobile/mobile480 in the 480dpi branch, files there are just a copy of the the 320 dpi files. Free free to delete everything in that directory and start from scratch if you want. Thanks, Justin I wrote a small tool to upconvert the 320dpi to 420dpi. Essentially I scaled up each first level child element in every skin by a factor of 1.5. Anyone see any problems with this logic? Seems like a reasonable first start. In theory, making a single pixel line that was on a pixel boundary become 1.5 pixels wide should cause the colors in the pixels that are now half covered to be less intense than the full covered pixels. My eyes have never been good enough to see it even on a desktop monitor, but we have had bugs filed about that sort of thing in the past. However, at 480dpi, I'm not sure anyone can see it. It might have been better to convert 240 dpi assets by a factor of 2. But again, it may not really matter. The other theoretical flaw is in the line-thickness and font area in general. A 24px T is not guaranteed to cover the same pixels as a 12px or 18px T scaled up. Again, not clear humans can see that at this density, but some folks seem to have much more sensitivity to these things than me. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: git commit: [flex-asjs] [refs/heads/develop] - RadioButtons for jQuery. RadioButtons cannot be programmatically added due to a known jQuery bug (documented in the RadioButton.js file).
Excellent. One question though: if you took out jquery.Application, how do the Jquery JS files get injected? -Alex On 5/9/13 1:33 PM, p...@apache.org p...@apache.org wrote: Updated Branches: refs/heads/develop 0991467eb - 114aeec95 RadioButtons for jQuery. RadioButtons cannot be programmatically added due to a known jQuery bug (documented in the RadioButton.js file). Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/114aeec9 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/114aeec9 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/114aeec9 Branch: refs/heads/develop Commit: 114aeec95635a765abc6e527517de984cd2dfadd Parents: 0991467 Author: Peter Ent p...@apache.org Authored: Thu May 9 16:33:01 2013 -0400 Committer: Peter Ent p...@apache.org Committed: Thu May 9 16:33:01 2013 -0400 -- frameworks/as/jquery-manifest.xml |1 - .../apache/flex/html/staticControls/RadioButton.as |6 + .../as/src/org/apache/flex/jquery/Application.as | 43 .../flex/jquery/staticControls/RadioButton.as |4 + .../org/apache/flex/html/staticControls/Label.js | 14 ++ .../apache/flex/html/staticControls/RadioButton.js | 16 ++ .../src/org/apache/flex/jquery/Application.js | 114 --- .../flex/jquery/staticControls/RadioButton.js | 158 --- 8 files changed, 169 insertions(+), 187 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/114aeec9/frameworks/as/j query-manifest.xml -- diff --git a/frameworks/as/jquery-manifest.xml b/frameworks/as/jquery-manifest.xml index cdb9dd5..d760aff 100644 --- a/frameworks/as/jquery-manifest.xml +++ b/frameworks/as/jquery-manifest.xml @@ -21,7 +21,6 @@ componentPackage -component id=Application class=org.apache.flex.jquery.Application/ component id=TextButton class=org.apache.flex.jquery.staticControls.TextButton/ component id=CheckBox class=org.apache.flex.jquery.staticControls.CheckBox/ component id=RadioButton class=org.apache.flex.jquery.staticControls.RadioButton/ http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/114aeec9/frameworks/as/s rc/org/apache/flex/html/staticControls/RadioButton.as -- diff --git a/frameworks/as/src/org/apache/flex/html/staticControls/RadioButton.as b/frameworks/as/src/org/apache/flex/html/staticControls/RadioButton.as index 0aee02b..a6caf5b 100644 --- a/frameworks/as/src/org/apache/flex/html/staticControls/RadioButton.as +++ b/frameworks/as/src/org/apache/flex/html/staticControls/RadioButton.as @@ -19,6 +19,7 @@ package org.apache.flex.html.staticControls { import flash.display.DisplayObject; + import flash.display.DisplayObjectContainer; import flash.display.SimpleButton; import flash.events.MouseEvent; import flash.utils.Dictionary; @@ -111,6 +112,11 @@ package org.apache.flex.html.staticControls IValueToggleButtonModel(model).selectedValue = newValue; } + public function addToParent(p:DisplayObjectContainer):void + { + p.addChild(this); + } + public function initModel():void { if (getBeadByType(IValueToggleButtonModel) == null) http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/114aeec9/frameworks/as/s rc/org/apache/flex/jquery/Application.as -- diff --git a/frameworks/as/src/org/apache/flex/jquery/Application.as b/frameworks/as/src/org/apache/flex/jquery/Application.as deleted file mode 100644 index 5801d07..000 --- a/frameworks/as/src/org/apache/flex/jquery/Application.as +++ /dev/null @@ -1,43 +0,0 @@ -/ /// -// -// Licensed to the Apache Software Foundation (ASF) under one or more -// contributor license agreements. See the NOTICE file distributed with -// this work for additional information regarding copyright ownership. -// The ASF licenses this file to You under the Apache License, Version 2.0 -// (the License); you may not use this file except in compliance with -// the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an AS IS BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the
Re: 480 DPI density mobile support
On Thu, May 9, 2013 at 2:02 PM, Alex Harui aha...@adobe.com wrote: On 5/9/13 12:38 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Wed, May 8, 2013 at 12:49 AM, Justin Mclean jus...@classsoftware.comwrote: HI, If you let me know the related files, I can take a stab at it. It's everything under frameworks/projects/mobiletheme/src/spark/skins/mobile/mobile480 in the 480dpi branch, files there are just a copy of the the 320 dpi files. Free free to delete everything in that directory and start from scratch if you want. Thanks, Justin I wrote a small tool to upconvert the 320dpi to 420dpi. Essentially I scaled up each first level child element in every skin by a factor of 1.5. Anyone see any problems with this logic? Seems like a reasonable first start. In theory, making a single pixel line that was on a pixel boundary become 1.5 pixels wide should cause the colors in the pixels that are now half covered to be less intense than the full covered pixels. My eyes have never been good enough to see it even on a desktop monitor, but we have had bugs filed about that sort of thing in the past. However, at 480dpi, I'm not sure anyone can see it. It might have been better to convert 240 dpi assets by a factor of 2. But again, it may not really matter. I inspected the differences between the 160, 240 and 320 dpi assets. It seems like 160 and 240 have the same elements but only the width/height, etc. changes. Whereas, the 320 dpi assets, more number of elements per graphic layer have been introduced. I think the same logic was applied when the 320dpi assets were created. They could have taken the 160dpi assets and doubled them, but they went ahead and made more complex changes so that they are more accurate. For example, you can look at the ActionBarBackground.fxg file in the three current dpis to see the difference. Because of this, I think using the 320 dpi assets as a base and scaling them by 1.5 makes more sense. The other theoretical flaw is in the line-thickness and font area in general. A 24px T is not guaranteed to cover the same pixels as a 12px or 18px T scaled up. Again, not clear humans can see that at this density, but some folks seem to have much more sensitivity to these things than me. Good point, but I have not seen an instance of RichText (or TextGraphic) in these fxg files. Any other text nodes I should be looking for? All that said, I would love to see the original files (.fla or .ai) for these graphics. Are you sure you dint skip those binaries when processing the original code donation? Thanks, Om -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: 480 DPI density mobile support
On 5/9/13 2:55 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: Any other text nodes I should be looking for? All that said, I would love to see the original files (.fla or .ai) for these graphics. Are you sure you dint skip those binaries when processing the original code donation? I don't think so. The files donated came from [1]. The history there shows FXG files being checked in and no .fla or .ai or anything like that. But we might have missed something so feel free to snoop around there and see if you can find the originals. [1] http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/ -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: 480 DPI density mobile support
HI, I wrote a small tool to upconvert the 320dpi to 420dpi. Nice. Can I check it into the 480dpi branch for others to test as well? Sure. Always good if code is in the open. Thanks, Justin
Re: [flex-sdk] Checkintest broken
HI, I just synced up and checkintests is failing in SparkTextInputTest1. Is anybody else having this issue? Passes for me on OSX, just running ant checkingtests right? Justin
Re: Odd SDK code for the day
HI, Yup, not defending, just explaining its purpose. :-) Feel free to put in a better mechanism, but it might cost you a few cycles. I think the mechanism is right to work out the height and baseline but widths of labels should be able to be a single character. Think I just note the reason and move on for now - there's other more important bugs to fix. Thanks, Justin
Re: [flex-sdk] Checkintest broken
On 5/9/13 4:12 PM, Justin Mclean jus...@classsoftware.com wrote: HI, I just synced up and checkintests is failing in SparkTextInputTest1. Is anybody else having this issue? Passes for me on OSX, just running ant checkingtests right? Hmm. Ok, I'll dig deeper. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
[jira] [Updated] (FLEX-24223) Validation on ListBase, triggerEvent IndexChangeEvent.CHANGE, leaves the ErrorSkin a step behind errorString
[ https://issues.apache.org/jira/browse/FLEX-24223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean updated FLEX-24223: - Labels: easytest (was: ) Validation on ListBase, triggerEvent IndexChangeEvent.CHANGE, leaves the ErrorSkin a step behind errorString Key: FLEX-24223 URL: https://issues.apache.org/jira/browse/FLEX-24223 Project: Apache Flex Issue Type: Bug Components: Spark: List Affects Versions: Adobe Flex SDK 4.0 (Release) Environment: Affected OS(s): All OS Platforms Affected OS(s): All OS Platforms Browser: Other (specify version) Language Found: English Reporter: Adobe JIRA Labels: easytest If you add a validator to check that a ListBase has a selectedIndex, or has selectedIndices (you need a custom validator) and use IndexChangeEvent.CHANGE as the trigger event the ErrorSkin is always a step behind the errorString property. For instance if you validating a selectedIndex you can use a NumberValidator making sure that the value isn't negative. If you validate the ListBase with no selectedIndex is shows an error as you would expect, if you then select an item, the triggerEvent fires and the ListBase is validated again. This time it will pass the validation and the errorString will be set to , but the ErrorSkin still shows due to the invalidation process and commitProperties no running again immediately when the errorString has been set. Clicking on another item in the ListBase will then remove the ErrorSkin as should have happened previously. If the selectedItem is now deselected, the errorString is set to a value, but no ErrorSkin is displayed, again due to commitProperties no being ran. Workarounds are to extend the components you want to validate and handle the errorString yourself (i.e. ButtonBar, List etc..), or to call invalidateProperties a frame later (using callLater) from inside the validator, meaning commitProperties is ran and the errorString is handled correctly. Using ButtonBars/Lists in forms that require validation is something that should be quite common. For instance it's much easier to use a ButtonBar or List to lay out and managed 20 RadioButtons using a RadioButtonItemRenderer, or I have a MultipleSelectionButtonBar class that the same also applies for CheckBoxItemRenderers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLEX-20609) TileList RTE when unexpected key pressed
[ https://issues.apache.org/jira/browse/FLEX-20609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean resolved FLEX-20609. -- Resolution: Cannot Reproduce Fix Version/s: Apache Flex 4.10.0 Probably fixed in previous version of the SDK. TileList RTE when unexpected key pressed Key: FLEX-20609 URL: https://issues.apache.org/jira/browse/FLEX-20609 Project: Apache Flex Issue Type: Bug Components: mx: TileList Affects Versions: Adobe Flex SDK Previous Environment: Affected OS(s): All OS Platforms Affected OS(s): All OS Platforms Language Found: English Reporter: Adobe JIRA Fix For: Apache Flex 4.10.0 Steps to reproduce: 1. Create a TileList 2. Press a letter key Actual Results: RTE TypeError: Error #1009: Cannot access a property or method of a null object reference. at mx.controls.listClasses::ListBase/findStringLoop()[E:\dev\beta1\frameworks\projects\framework\src\mx\controls\listClasses\ListBase.as:8839] at mx.controls.listClasses::ListBase/findString()[E:\dev\beta1\frameworks\projects\framework\src\mx\controls\listClasses\ListBase.as:8824] at mx.controls.listClasses::ListBase/findKey()[E:\dev\beta1\frameworks\projects\framework\src\mx\controls\listClasses\ListBase.as:8697] at mx.controls.listClasses::TileBase/keyDownHandler()[E:\dev\beta1\frameworks\projects\framework\src\mx\controls\listClasses\TileBase.as:2594] Expected Results: Nothing happens Workaround (if any): -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-23486) mx:List / selectedItemsCompareFunction property is not applied correctly
[ https://issues.apache.org/jira/browse/FLEX-23486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653462#comment-13653462 ] Justin Mclean commented on FLEX-23486: -- No RTE in Apache Flex 4.9.1 however it non functioning ie same item in other list item doesn't get selected. Suggested fix fixes issue. mx:List / selectedItemsCompareFunction property is not applied correctly Key: FLEX-23486 URL: https://issues.apache.org/jira/browse/FLEX-23486 Project: Apache Flex Issue Type: Bug Components: mx: List Affects Versions: Adobe Flex SDK 3.6 (Release) Environment: Affected OS(s): All OS Platforms Browser: Firefox 3.x Language Found: English Reporter: Adobe JIRA Labels: easyfix, easytest Note: issue affects several version of Flex SDK, first noticed in 3.4, but same problem exists in latest stable build of 4.0 as well. Steps to reproduce: 1. Use mx:List control with dataProvider containing non-primitive items (like Date, for simplest case) 2. Use selectedItemsCompareFunction on mx:List to compare items during selection 3. Set selectedItems as an array of objects with references different to ones used in dataProvider Actual Results: Runtime exception thrown: TypeError: Error #1010: A term is undefined and has no properties. at mx.controls.listClasses::ListBase/setSelectionDataLoop()[C:\autobuild\3.4.0\frameworks\projects\framework\src\mx\controls\listClasses\ListBase.as:6473] at mx.controls.listClasses::ListBase/commitSelectedItems()[C:\autobuild\3.4.0\frameworks\projects\framework\src\mx\controls\listClasses\ListBase.as:6364] at mx.controls.listClasses::ListBase/set selectedItems()[C:\autobuild\3.4.0\frameworks\projects\framework\src\mx\controls\listClasses\ListBase.as:2942] at ListsCompare/updateLeft()[C:\Documents and Settings\sav\Adobe Flash Builder Beta 2\FileDownload\src\ListsCompare.mxml:22] at ListsCompare/__lstRight_change()[C:\Documents and Settings\sav\Adobe Flash Builder Beta 2\FileDownload\src\ListsCompare.mxml:37] Expected Results: selection is applied correctly Reason and possible resolution: Actually bug fix is super easy. The problem itself lies in fact that List temporary stores UID-to-index map of selected items in one function function commitSelectedItems(items:Array):void {...} and afterward applies it incorrectly in another function setSelectionDataLoop(items:Array, index:int, useFind:Boolean = true):void {...} Namely, the following lines causes the problem (from setSelectionDataLoop): if (compareFunction(data, item)) { uid = itemToUID(data); // ISSUE IS HERE -- must be itemToUID(item) selectionDataArray[proposedSelectedItemIndexes[uid]] = new ListBaseSelectionData(data, index, false); ... } I.e. proposedSelectedItemIndexes is indexed by UID of objects from selectedItems but here it is accessed by UID of objects from dataProvider. Workaround (if any): Given the fact that comparator is invoked right before call to itemToUID and comparator is never used in any other place, mx:List may be replaced with custom class with the following trick applied: package { import mx.controls.List; public class MyList extends List { override public function set selectedItemsCompareFunction(value:Function):void { super.selectedItemsCompareFunction = value == null ? null : function(a:*, b:*):Boolean { isComparatorCalled = true; latestComparatorParam = b; return value(a, b); }; } private var isComparatorCalled:Boolean = false; private var latestComparatorParam:* = null; override protected function itemToUID(data:Object):String { if (!isComparatorCalled) return super.itemToUID(data); else { var param:* = latestComparatorParam; isComparatorCalled = false; latestComparatorParam = null; return super.itemToUID(param); } } } } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLEX-23365) DataGrid (commitEditedItemPosition) - Error #1010: A term is undefined and has no properties.
[ https://issues.apache.org/jira/browse/FLEX-23365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Mclean updated FLEX-23365: - Labels: easytest (was: ) DataGrid (commitEditedItemPosition) - Error #1010: A term is undefined and has no properties. - Key: FLEX-23365 URL: https://issues.apache.org/jira/browse/FLEX-23365 Project: Apache Flex Issue Type: Bug Components: mx: DataGrid Affects Versions: Adobe Flex SDK 3.1 (Release) Environment: Affected OS(s): All OS Platforms Affected OS(s): All OS Platforms Browser: Firefox 3.x Language Found: English Reporter: Adobe JIRA Labels: easytest Steps to reproduce: 1. Create an editable DataGrid with allowMultipleSelection = true. 2. Add a button handler that will remove the selected rows from the datagrid using the selected indices and then refresh the collection. 3. Select multiple rows at the bottom for delete such that the current item editor is in a column that is in the last row of the DG. 4. Delete the rows and tab back to the datagrid. Actual Results: TypeError: Error #1010: A term is undefined and has no properties. at mx.controls::DataGrid/commitEditedItemPosition() at mx.controls::DataGrid/updateDisplayList() at mx.controls.listClasses::ListBase/validateDisplayList() at mx.managers::LayoutManager/validateDisplayList() at mx.managers::LayoutManager/doPhasedInstantiation() at Function/http://adobe.com/AS3/2006/builtin::apply() at mx.core::UIComponent/callLaterDispatcher2() at mx.core::UIComponent/callLaterDispatcher() Expected Results: No exception. Workaround (if any): Unknown This appears to be happening because the flag bEditedItemPositionChanged is true and there is no way to turn it off. It will be turned off by DataGrid when commitEditedItemPosition() changes the item being edited to _proposedEditedItemPosition. I tried setting editedItemPosition to both null and undefined but still the same error. Short of subclassing DataGrid and doing a more thorough analysis, the fix for this is unknown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [Poll] Apache Flex next version number
With all the new components and features, it definitely deserves a version bump to 4.10! -- Original Message -- Received: Thu, 09 May 2013 11:48:04 PM EDT From: Justin Mclean jus...@classsoftware.com To: dev@flex.apache.org Subject: [Poll] Apache Flex next version number Hi, Assuming we start working on a new release in the near future what should the next version number be? 1. Apache Flex 4.10.0 2. Apache Flex 4.9.5 3. Apache Flex 4.9.2 4. Something else? Take a look at the RELEASE_NOTES to have a rough idea of whats new. https://fisheye6.atlassian.com/browse/flex-sdk/RELEASE_NOTES?r=7e30183fe73422b376adb869330d18b7bfc3737a Thanks, Justin
Re: [Poll] Apache Flex next version number
On May 9, 2013 8:55 PM, Tianzhen Lin tang...@usa.net wrote: With all the new components and features, it definitely deserves a version bump to 4.10! Agreed! 4.10 has a nice ring to it. On a related note, can we do away with the 'experimental' moniker for the new components? It will be hard to change once we release it and folks start using them in their projects. Thanks, Om -- Original Message -- Received: Thu, 09 May 2013 11:48:04 PM EDT From: Justin Mclean jus...@classsoftware.com To: dev@flex.apache.org Subject: [Poll] Apache Flex next version number Hi, Assuming we start working on a new release in the near future what should the next version number be? 1. Apache Flex 4.10.0 2. Apache Flex 4.9.5 3. Apache Flex 4.9.2 4. Something else? Take a look at the RELEASE_NOTES to have a rough idea of whats new. https://fisheye6.atlassian.com/browse/flex-sdk/RELEASE_NOTES?r=7e30183fe73422b376adb869330d18b7bfc3737a Thanks, Justin
Re: [Poll] Apache Flex next version number
I like 4.10, but has anyone tested that the various versioning code is converting the 10 to a number so comparisons work? On 5/9/13 9:02 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On May 9, 2013 8:55 PM, Tianzhen Lin tang...@usa.net wrote: With all the new components and features, it definitely deserves a version bump to 4.10! Agreed! 4.10 has a nice ring to it. On a related note, can we do away with the 'experimental' moniker for the new components? It will be hard to change once we release it and folks start using them in their projects. Thanks, Om -- Original Message -- Received: Thu, 09 May 2013 11:48:04 PM EDT From: Justin Mclean jus...@classsoftware.com To: dev@flex.apache.org Subject: [Poll] Apache Flex next version number Hi, Assuming we start working on a new release in the near future what should the next version number be? 1. Apache Flex 4.10.0 2. Apache Flex 4.9.5 3. Apache Flex 4.9.2 4. Something else? Take a look at the RELEASE_NOTES to have a rough idea of whats new. https://fisheye6.atlassian.com/browse/flex-sdk/RELEASE_NOTES?r=7e30183fe73422b 376adb869330d18b7bfc3737a Thanks, Justin -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [Poll] Apache Flex next version number
On 5/10/2013 10:46 AM, Justin Mclean wrote: Take a look at the RELEASE_NOTES to have a rough idea of whats new. https://fisheye6.atlassian.com/browse/flex-sdk/RELEASE_NOTES?r=7e30183fe73422b376adb869330d18b7bfc3737a man, that is one impressive load of work. you guys are like freaking bug-fixing machines ;-)
Experimental components
Hi, On a related note, can we do away with the 'experimental' moniker for the new components? Until they be fully tested/completed I think they should stay there - some are better than other I know but there may be issues. Anyone want to write mustella/flexunit tests for them? :-) Thanks, Justin
[jira] [Created] (FLEX-33543) Check that 4.10.0 works as a version number
Justin Mclean created FLEX-33543: Summary: Check that 4.10.0 works as a version number Key: FLEX-33543 URL: https://issues.apache.org/jira/browse/FLEX-33543 Project: Apache Flex Issue Type: Test Reporter: Justin Mclean If 4.10.0 is treated as a string not a number version numbering comparison may not work. Need to double check where and how the SDK is doing version checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[FalconJX][FlexJS] Container added to FlexJSOverlay
Hi, I added a Container class and simple Horizontal and Vertical layouts to the FlexJSOverlay. The StockQuote example has been updated to show how to use them. Volunteers welcome to provide alternative layouts, and Container variants like Panel. Thanks, -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
[jira] [Commented] (FLEX-33543) Check that 4.10.0 works as a version number
[ https://issues.apache.org/jira/browse/FLEX-33543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653548#comment-13653548 ] Justin Mclean commented on FLEX-33543: -- Versions are stared as uints in FlexVersion.as and compatibility comparisons are done using numbers. I would also expect some mustella tests to fail if it though it was the 4.1 SDK. Is there any way to be 100% certain? Check that 4.10.0 works as a version number --- Key: FLEX-33543 URL: https://issues.apache.org/jira/browse/FLEX-33543 Project: Apache Flex Issue Type: Test Reporter: Justin Mclean If 4.10.0 is treated as a string not a number version numbering comparison may not work. Need to double check where and how the SDK is doing version checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira