[jira] [Commented] (FLUME-2941) Integrate checkstyle for test classes
[ https://issues.apache.org/jira/browse/FLUME-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368809#comment-15368809 ] Hudson commented on FLUME-2941: --- FAILURE: Integrated in Flume-trunk-hbase-1 #172 (See [https://builds.apache.org/job/Flume-trunk-hbase-1/172/]) FLUME-2941. Integrate checkstyle for test classes (mpercy: [http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git=commit=cfbf1156858af9ae26975fefc94594d91c8cd3f4]) * flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java * flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannelConcurrency.java * flume-ng-core/src/test/java/org/apache/flume/serialization/TestDurablePositionTracker.java * flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannelTransaction.java * flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java * flume-checkstyle/src/main/resources/flume/checkstyle.xml * flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/client/RoundRobinListTest.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/CountingSinkRunner.java * flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/CipherProviderTestSuite.java * flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventQueueBackingStoreFactory.java * flume-tools/src/test/java/org/apache/flume/tools/TestFileChannelIntegrityTool.java * flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java * flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java * flume-ng-auth/src/test/java/org/apache/flume/auth/TestFlumeAuthenticator.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestAESCTRNoPaddingProvider.java * flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelProcessor.java * flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java * flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/util/ZooKeeperLocal.java * flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java * flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestJCEFileKeyProvider.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java * flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRollback.java * flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexExtractorInterceptorPassThroughSerializer.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java * flume-ng-core/src/test/java/org/apache/flume/tools/TestVersionInfo.java * flume-ng-node/src/test/java/org/apache/flume/node/TestPropertiesFileConfigurationProvider.java * flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java * flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractZooKeeperConfigurationProvider.java * flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java * flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirEventReader.java * flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java * flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannel.java * flume-ng-core/src/test/java/org/apache/flume/serialization/TestFlumeEventAvroEventSerializer.java * flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/MockEventUtils.java * flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockDataStream.java * flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java * flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestUtil.java * flume-ng-sdk/src/test/java/org/apache/flume/api/TestThriftRpcClient.java *
[jira] [Commented] (FLUME-2941) Integrate checkstyle for test classes
[ https://issues.apache.org/jira/browse/FLUME-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368629#comment-15368629 ] ASF subversion and git services commented on FLUME-2941: Commit cfbf1156858af9ae26975fefc94594d91c8cd3f4 in flume's branch refs/heads/trunk from [~mpercy] [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=cfbf115 ] FLUME-2941. Integrate checkstyle for test classes Also make test code conform to style guidelines. Additionally, this patch makes style violations fatal to the build. This patch is whitespace-only from a code perspective. After stripping line numbers, the generated test bytecode before and after these changes is identical. Code review: https://reviews.apache.org/r/49830/ Reviewed by Hari. > Integrate checkstyle for test classes > - > > Key: FLUME-2941 > URL: https://issues.apache.org/jira/browse/FLUME-2941 > Project: Flume > Issue Type: Improvement >Reporter: Lior Zeno >Assignee: Mike Percy >Priority: Minor > Fix For: v1.7.0 > > > We should add the maven-checkstyle-plugin to the build process. This plugin > can fail a build if the code does not honor the style of our project. This > way we can make sure that we have one common style in the code. In addition, > reviewers can focus on design, correctness, performance and other important > coding aspects other than style issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2941) Integrate checkstyle for test classes
[ https://issues.apache.org/jira/browse/FLUME-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368628#comment-15368628 ] Mike Percy commented on FLUME-2941: --- Thanks for the review Hari! I am about to commit this. > Integrate checkstyle for test classes > - > > Key: FLUME-2941 > URL: https://issues.apache.org/jira/browse/FLUME-2941 > Project: Flume > Issue Type: Improvement >Reporter: Lior Zeno >Assignee: Mike Percy >Priority: Minor > Fix For: v1.7.0 > > > We should add the maven-checkstyle-plugin to the build process. This plugin > can fail a build if the code does not honor the style of our project. This > way we can make sure that we have one common style in the code. In addition, > reviewers can focus on design, correctness, performance and other important > coding aspects other than style issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2941) Integrate checkstyle for test classes
[ https://issues.apache.org/jira/browse/FLUME-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368610#comment-15368610 ] Hari Shreedharan commented on FLUME-2941: - +1. Please go ahead and commit! > Integrate checkstyle for test classes > - > > Key: FLUME-2941 > URL: https://issues.apache.org/jira/browse/FLUME-2941 > Project: Flume > Issue Type: Improvement >Reporter: Lior Zeno >Assignee: Mike Percy >Priority: Minor > Fix For: v1.7.0 > > > We should add the maven-checkstyle-plugin to the build process. This plugin > can fail a build if the code does not honor the style of our project. This > way we can make sure that we have one common style in the code. In addition, > reviewers can focus on design, correctness, performance and other important > coding aspects other than style issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
