date:20161006

Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get security properties from system properties

2016-10-06 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52621/#review151737
---


Ship it!




Ship It!

- Kirk Lund


On Oct. 6, 2016, 11:03 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52621/
> ---
> 
> (Updated Oct. 6, 2016, 11:03 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * adding more tests
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  8e4c15d4707ee6a6d48ab8be26a161e2a2660055 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithAuthenticatorTest.java
>  c6cbf88c31362444f113785cdd217fdac8265461 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithSecurityManagerTest.java
>  49475e0c0296287405d43dfb9d29dcd8e45305d4 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  PRE-CREATION 
>   geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52621/diff/
> 
> 
> Testing
> ---
> 
> revert back to the old way of getting the security properties since this 
> throws off some tests. Precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get security properties from system properties

2016-10-06 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52621/
---

(Updated Oct. 6, 2016, 11:03 p.m.)


Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

* adding more tests


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 8e4c15d4707ee6a6d48ab8be26a161e2a2660055 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithAuthenticatorTest.java
 c6cbf88c31362444f113785cdd217fdac8265461 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithSecurityManagerTest.java
 49475e0c0296287405d43dfb9d29dcd8e45305d4 
  
geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
 PRE-CREATION 
  geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52621/diff/


Testing
---

revert back to the old way of getting the security properties since this throws 
off some tests. Precheckin running


Thanks,

Jinmei Liao

Review Request 52621: GEM-1032: GMSAuthenticator needs to get security properties from system properties

2016-10-06 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52621/
---

Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

* adding more tests


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 8e4c15d4707ee6a6d48ab8be26a161e2a2660055 
  
geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
 PRE-CREATION 
  geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52621/diff/


Testing
---

revert back to the old way of getting the security properties since this throws 
off some tests. Precheckin running


Thanks,

Jinmei Liao

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

2016-10-06 Thread Jared Stewart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151724
---


Ship it!




Ship It!

- Jared Stewart


On Oct. 6, 2016, 6:34 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> ---
> 
> (Updated Oct. 6, 2016, 6:34 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk 
> Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1570: upgrade spring libraries and related libraries
> 
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
> * update the NOTICE files
> 
> 
> Diffs
> -
> 
>   geode-assembly/src/main/dist/NOTICE 
> 1924007f6c4822f59e0a830acf4e2b01f67170ef 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
>  0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
>  a9d90ed5489a9ab6b936674369b5e5a870651738 
>   geode-assembly/src/test/resources/expected_jars.txt 
> 939464a92a3f1846b8fb9b9d1faa75dad5133289 
>   geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java
>  9e7b7bf17920a9dc42905bab4ccb4590ca20223a 
>   
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
>  435b426627deea6c67ecd79bc014ec97774e2ebf 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
>  425f5a5aa76c8219678164ebbb012d1361519bc7 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
>  f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
>  51abb3f39902938149fb67a416f571ba31b75d77 
>   geode-pulse/src/main/webapp/Login.html 
> f22490f4df098c0b12dadeefcb1855a51efc6281 
>   geode-pulse/src/main/webapp/META-INF/NOTICE 
> 40f9fc875d6bc53d073061495738f636ad60433c 
>   geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml 
> cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe 
>   geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 
> 924dd50f579a6e4e306b94f4a7fd88e87f978add 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java
>  a77e0cacdcde69f47fbd13c588601072c432ee0d 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java
>  a4f14f89ea739e7390565d652fc5affa6e1326c6 
>   geode-web-api/build.gradle 3ea652b65456168689250f35be553c2eeda193d9 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java
>  ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java
>  1fcffbd4eee26fee890f158794727647145a1914 
>   geode-web-api/src/main/webapp/META-INF/NOTICE 
> 2f4da6e85a2daa75e136bbc80e62768193f65db9 
>   geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml 
> c75d975c4313f953cce5ac7f5a8cd8a228718a8c 
>   geode-web/src/main/webapp/META-INF/NOTICE 
> dd46891056a99365494ac212fec8ef8b3dd0a201 
>   geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 
> 3b1d1658ea2414190852cc1268fd9f1beccf4d20 
>   gradle/dependency-resolution.gradle 
> 91d1755848ba9ce23fab3190555c2906bcffd97b 
>   gradle/dependency-versions.properties 
> 65fd2ee1d46156781ee70165aac578c5ca14490a 
> 
> Diff: https://reviews.apache.org/r/52571/diff/
> 
> 
> Testing
> ---
> 
> precheckin running.
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Bruce Schuchardt

Thanks everyone.  I'm going to keep the framework out of Geode, at least 
for now.   We can pick up the discussion again when we have a 1.0.0 
Geode release to test against.


Le 10/6/2016 à 1:38 PM, Udo Kohlmeyer a écrit :
I believe that a backwards compatibility framework is required. Even 
if just to confirm the compatibility between supported Geode versions.


If this framework were to be used/extended by any user of the Geode 
ecosystem, then it becomes their responsibility to maintain that 
extension.


--Udo


On 7/10/2016 3:31 AM, Mark Bretl wrote:

-1 for this

I do understand the intent and reason behind this, however, in 
addition to
the reasons Anthony provided, I do not believe this community should 
carry
the burden of testing compatibility with proprietary/commercial 
software.
Even though Geode has its history in GemFire, I can only see the 
community
supporting official Geode releases. It would set a bad precedent to 
allow

for any part of the Geode code ( source or test ) to depend on any
commercial code.

If any company wants to make sure their software works with Geode, it is
their responsibility.

My $.02,

--Mark

On Thu, Oct 6, 2016 at 9:12 AM, Bruce Schuchardt 


wrote:


Yes, dist.gemstone.com.


Le 10/6/2016 à 9:08 AM, Dick Cavender a écrit :


Only on initial setup/access to repo.pivotal.io is the EULA acceptance
required. After that you should be able to pull from any repo there 
without
interaction but you will need to provide the creds as part of the 
pull.


Are you instead using dist.gemstone.com for the older jars which is 
the

original repo that lives in the spring s3 repo


On 10/6/2016 7:48 AM, Bruce Schuchardt wrote:


Thanks Anthony.

I thought there was some interest in supporting old GemFire 
clients and
WAN.  Is there no way to download it without a login/EULA?  I'm 
currently
using a different repo but maybe that's only available in 
Pivotal's network.


As far as M3 goes, do you think there would be any value in testing
against it?  I don't want to introduce new tests unless they are 
helpful.


Le 10/5/2016 à 5:31 PM, Anthony Baker a écrit :

Given that the official Pivotal maven repo [1] is locked behind a 
login
and a EULA I think this might not work so well.  The license 
compatibility

issues would need to be explored as well.

How would you feel about testing backwards compatibility against
1.0.0-incubating.M3?

Anthony

[1] http://commercial-repo.pivotal.io

On Oct 5, 2016, at 4:17 PM, Bruce Schuchardt 


wrote:

We now have a backward-compatibility module but it's not well 
tested.

I'd
like to add tests to this module that run against GemFire jars
downloaded
from the Pivotal maven repository.  I've already implemented the
framework
and some smoke tests but want to know how people feel about the 
tests
downloading something proprietary to test against and whether 
failures

would be something the community cares about.

If we don't want this I'll keep it out of the repo until we have a
1.0.0
release to test against.

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Udo Kohlmeyer

I believe that a backwards compatibility framework is required. Even if 
just to confirm the compatibility between supported Geode versions.


If this framework were to be used/extended by any user of the Geode 
ecosystem, then it becomes their responsibility to maintain that extension.


--Udo


On 7/10/2016 3:31 AM, Mark Bretl wrote:

-1 for this

I do understand the intent and reason behind this, however, in addition to
the reasons Anthony provided, I do not believe this community should carry
the burden of testing compatibility with proprietary/commercial software.
Even though Geode has its history in GemFire, I can only see the community
supporting official Geode releases. It would set a bad precedent to allow
for any part of the Geode code ( source or test ) to depend on any
commercial code.

If any company wants to make sure their software works with Geode, it is
their responsibility.

My $.02,

--Mark

On Thu, Oct 6, 2016 at 9:12 AM, Bruce Schuchardt 
wrote:


Yes, dist.gemstone.com.


Le 10/6/2016 à 9:08 AM, Dick Cavender a écrit :


Only on initial setup/access to repo.pivotal.io is the EULA acceptance
required. After that you should be able to pull from any repo there without
interaction but you will need to provide the creds as part of the pull.

Are you instead using dist.gemstone.com for the older jars which is the
original repo that lives in the spring s3 repo


On 10/6/2016 7:48 AM, Bruce Schuchardt wrote:


Thanks Anthony.

I thought there was some interest in supporting old GemFire clients and
WAN.  Is there no way to download it without a login/EULA?  I'm currently
using a different repo but maybe that's only available in Pivotal's network.

As far as M3 goes, do you think there would be any value in testing
against it?  I don't want to introduce new tests unless they are helpful.

Le 10/5/2016 à 5:31 PM, Anthony Baker a écrit :


Given that the official Pivotal maven repo [1] is locked behind a login
and a EULA I think this might not work so well.  The license compatibility
issues would need to be explored as well.

How would you feel about testing backwards compatibility against
1.0.0-incubating.M3?

Anthony

[1] http://commercial-repo.pivotal.io

On Oct 5, 2016, at 4:17 PM, Bruce Schuchardt 

wrote:

We now have a backward-compatibility module but it's not well tested.
I'd
like to add tests to this module that run against GemFire jars
downloaded
from the Pivotal maven repository.  I've already implemented the
framework
and some smoke tests but want to know how people feel about the tests
downloading something proprietary to test against and whether failures
would be something the community cares about.

If we don't want this I'll keep it out of the repo until we have a
1.0.0
release to test against.

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Jacob Barrett

-1
Completely agree with Mark on this.


On Thu, Oct 6, 2016 at 9:31 AM Mark Bretl  wrote:

> -1 for this
>
> I do understand the intent and reason behind this, however, in addition to
> the reasons Anthony provided, I do not believe this community should carry
> the burden of testing compatibility with proprietary/commercial software.
> Even though Geode has its history in GemFire, I can only see the community
> supporting official Geode releases. It would set a bad precedent to allow
> for any part of the Geode code ( source or test ) to depend on any
> commercial code.
>
> If any company wants to make sure their software works with Geode, it is
> their responsibility.
>
> My $.02,
>
> --Mark
>
> On Thu, Oct 6, 2016 at 9:12 AM, Bruce Schuchardt 
> wrote:
>
> > Yes, dist.gemstone.com.
> >
> >
> > Le 10/6/2016 à 9:08 AM, Dick Cavender a écrit :
> >
> >> Only on initial setup/access to repo.pivotal.io is the EULA acceptance
> >> required. After that you should be able to pull from any repo there
> without
> >> interaction but you will need to provide the creds as part of the pull.
> >>
> >> Are you instead using dist.gemstone.com for the older jars which is the
> >> original repo that lives in the spring s3 repo
> >>
> >>
> >> On 10/6/2016 7:48 AM, Bruce Schuchardt wrote:
> >>
> >>> Thanks Anthony.
> >>>
> >>> I thought there was some interest in supporting old GemFire clients and
> >>> WAN.  Is there no way to download it without a login/EULA?  I'm
> currently
> >>> using a different repo but maybe that's only available in Pivotal's
> network.
> >>>
> >>> As far as M3 goes, do you think there would be any value in testing
> >>> against it?  I don't want to introduce new tests unless they are
> helpful.
> >>>
> >>> Le 10/5/2016 à 5:31 PM, Anthony Baker a écrit :
> >>>
>  Given that the official Pivotal maven repo [1] is locked behind a
> login
>  and a EULA I think this might not work so well.  The license
> compatibility
>  issues would need to be explored as well.
> 
>  How would you feel about testing backwards compatibility against
>  1.0.0-incubating.M3?
> 
>  Anthony
> 
>  [1] http://commercial-repo.pivotal.io
> 
>  On Oct 5, 2016, at 4:17 PM, Bruce Schuchardt 
> > wrote:
> >
> > We now have a backward-compatibility module but it's not well tested.
> > I'd
> > like to add tests to this module that run against GemFire jars
> > downloaded
> > from the Pivotal maven repository.  I've already implemented the
> > framework
> > and some smoke tests but want to know how people feel about the tests
> > downloading something proprietary to test against and whether
> failures
> > would be something the community cares about.
> >
> > If we don't want this I'll keep it out of the repo until we have a
> > 1.0.0
> > release to test against.
> >
> 
> >>>
> >>
> >
>

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

2016-10-06 Thread Anthony Baker


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151712
---



NOTICE changes look good!

- Anthony Baker


On Oct. 6, 2016, 6:34 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> ---
> 
> (Updated Oct. 6, 2016, 6:34 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk 
> Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1570: upgrade spring libraries and related libraries
> 
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
> * update the NOTICE files
> 
> 
> Diffs
> -
> 
>   geode-assembly/src/main/dist/NOTICE 
> 1924007f6c4822f59e0a830acf4e2b01f67170ef 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
>  0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
>  a9d90ed5489a9ab6b936674369b5e5a870651738 
>   geode-assembly/src/test/resources/expected_jars.txt 
> 939464a92a3f1846b8fb9b9d1faa75dad5133289 
>   geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java
>  9e7b7bf17920a9dc42905bab4ccb4590ca20223a 
>   
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
>  435b426627deea6c67ecd79bc014ec97774e2ebf 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
>  425f5a5aa76c8219678164ebbb012d1361519bc7 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
>  f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
>  51abb3f39902938149fb67a416f571ba31b75d77 
>   geode-pulse/src/main/webapp/Login.html 
> f22490f4df098c0b12dadeefcb1855a51efc6281 
>   geode-pulse/src/main/webapp/META-INF/NOTICE 
> 40f9fc875d6bc53d073061495738f636ad60433c 
>   geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml 
> cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe 
>   geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 
> 924dd50f579a6e4e306b94f4a7fd88e87f978add 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java
>  a77e0cacdcde69f47fbd13c588601072c432ee0d 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java
>  a4f14f89ea739e7390565d652fc5affa6e1326c6 
>   geode-web-api/build.gradle 3ea652b65456168689250f35be553c2eeda193d9 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java
>  ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java
>  1fcffbd4eee26fee890f158794727647145a1914 
>   geode-web-api/src/main/webapp/META-INF/NOTICE 
> 2f4da6e85a2daa75e136bbc80e62768193f65db9 
>   geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml 
> c75d975c4313f953cce5ac7f5a8cd8a228718a8c 
>   geode-web/src/main/webapp/META-INF/NOTICE 
> dd46891056a99365494ac212fec8ef8b3dd0a201 
>   geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 
> 3b1d1658ea2414190852cc1268fd9f1beccf4d20 
>   gradle/dependency-resolution.gradle 
> 91d1755848ba9ce23fab3190555c2906bcffd97b 
>   gradle/dependency-versions.properties 
> 65fd2ee1d46156781ee70165aac578c5ca14490a 
> 
> Diff: https://reviews.apache.org/r/52571/diff/
> 
> 
> Testing
> ---
> 
> precheckin running.
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

2016-10-06 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/
---

(Updated Oct. 6, 2016, 6:34 p.m.)


Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk 
Lund, and Dan Smith.


Repository: geode


Description
---

GEODE-1570: upgrade spring libraries and related libraries

* upgrade the spring related libraries
* rafactored the tests to get rid of redundant code
* update the NOTICE files


Diffs (updated)
-

  geode-assembly/src/main/dist/NOTICE 1924007f6c4822f59e0a830acf4e2b01f67170ef 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
 a9d90ed5489a9ab6b936674369b5e5a870651738 
  geode-assembly/src/test/resources/expected_jars.txt 
939464a92a3f1846b8fb9b9d1faa75dad5133289 
  geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java
 9e7b7bf17920a9dc42905bab4ccb4590ca20223a 
  
geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
 435b426627deea6c67ecd79bc014ec97774e2ebf 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
 425f5a5aa76c8219678164ebbb012d1361519bc7 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
 f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
 51abb3f39902938149fb67a416f571ba31b75d77 
  geode-pulse/src/main/webapp/Login.html 
f22490f4df098c0b12dadeefcb1855a51efc6281 
  geode-pulse/src/main/webapp/META-INF/NOTICE 
40f9fc875d6bc53d073061495738f636ad60433c 
  geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml 
cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe 
  geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 
924dd50f579a6e4e306b94f4a7fd88e87f978add 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java 
a77e0cacdcde69f47fbd13c588601072c432ee0d 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java
 a4f14f89ea739e7390565d652fc5affa6e1326c6 
  geode-web-api/build.gradle 3ea652b65456168689250f35be553c2eeda193d9 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java
 ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java
 1fcffbd4eee26fee890f158794727647145a1914 
  geode-web-api/src/main/webapp/META-INF/NOTICE 
2f4da6e85a2daa75e136bbc80e62768193f65db9 
  geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml 
c75d975c4313f953cce5ac7f5a8cd8a228718a8c 
  geode-web/src/main/webapp/META-INF/NOTICE 
dd46891056a99365494ac212fec8ef8b3dd0a201 
  geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 
3b1d1658ea2414190852cc1268fd9f1beccf4d20 
  gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b 
  gradle/dependency-versions.properties 
65fd2ee1d46156781ee70165aac578c5ca14490a 

Diff: https://reviews.apache.org/r/52571/diff/


Testing
---

precheckin running.


Thanks,

Jinmei Liao

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

2016-10-06 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/
---

(Updated Oct. 6, 2016, 6:31 p.m.)


Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk 
Lund, and Dan Smith.


Repository: geode


Description (updated)
---

GEODE-1570: upgrade spring libraries and related libraries

* upgrade the spring related libraries
* rafactored the tests to get rid of redundant code
* update the NOTICE files


Diffs (updated)
-

  geode-assembly/src/main/dist/NOTICE 1924007f6c4822f59e0a830acf4e2b01f67170ef 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
 df146a6b8a3c539d50f036a5adaea5f486e8a7d6 
  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityEndpointsDUnitTest.java
 PRE-CREATION 
  geode-assembly/src/test/resources/expected_jars.txt 
939464a92a3f1846b8fb9b9d1faa75dad5133289 
  geode-core/build.gradle b2e5a4efd9114db0b9c49c8541cf1cc72c2644fe 
  
geode-core/src/main/java/org/apache/geode/management/internal/JettyHelper.java 
089dbacb056da84d6d6ceb36dad6f09b9ce73890 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java
 9e7b7bf17920a9dc42905bab4ccb4590ca20223a 
  
geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
 435b426627deea6c67ecd79bc014ec97774e2ebf 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
 425f5a5aa76c8219678164ebbb012d1361519bc7 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
 f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4 
  
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
 51abb3f39902938149fb67a416f571ba31b75d77 
  geode-pulse/src/main/webapp/Login.html 
f22490f4df098c0b12dadeefcb1855a51efc6281 
  geode-pulse/src/main/webapp/META-INF/NOTICE 
40f9fc875d6bc53d073061495738f636ad60433c 
  geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml 
cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe 
  geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 
3756df7d082d6b2d084c6a4b4446a6a9384d558c 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/testbed/driver/PulseUITest.java
 a2365a2dfa3e221fa50664c3f8d96fae2bd93c86 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java
 5024250f8ff3867e0f527d7ef5fbbd501e2d64ee 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java 
a77e0cacdcde69f47fbd13c588601072c432ee0d 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java
 a4f14f89ea739e7390565d652fc5affa6e1326c6 
  geode-web-api/build.gradle 9e93bb92829acff56f39fdfccacdfae90e21ceeb 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
 e94998b5ea358acf75162aa402170c6dbf298951 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 a4f58b97fe5b54809f7d33684fa52b0908fb216f 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
 b3128848a13325d6aae791a119665dbdb2e281d1 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
 c31292bbf2928956592b3040be5cbc7dae9677f7 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
 dd7731670b4e6310aa2eb474ef0057bb0f55e8d5 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
 4f059a4283ac6dd72cc0f5207aaae37c6d2b872a 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthentication.java
 PRE-CREATION 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java
 PRE-CREATION 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthority.java
 PRE-CREATION 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityConfiguration.java
 PRE-CREATION 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java
 ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java
 1fcffbd4eee26fee890f158794727647145a1914 
  geode-web-api/src/main/webapp/META-INF/NOTICE 
2f4da6e85a2daa75e136bbc80e62768193f65db9 
  geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml 
c24e74a96c4c132e3b62ce4789aa3cff441cc977 
  geode-web-api/src/main/webapp/WEB-INF/web.xml 
956294a5a799b2b86acd4da90b510239cecdba5e

Re: Hibernate module and Geode 1.0 ?

2016-10-06 Thread Dave Barnes

So, what form should the JIRA ticket assume?
(a) Move HIbernate from develop to a feature branch, or
(b) Merge Hibernate code to develop (as a future task, cf GEODE-1416 for
how the NC was handled)

After somebody (which I can do, if you like) creates a ticket for the code,
I'll create a subtask for moving the accompanying docs.

On Thu, Oct 6, 2016 at 9:34 AM, Joey McAllister 
wrote:

> +1 for moving to a feature branch.
>
> On Thu, Oct 6, 2016 at 9:32 AM Mark Bretl  wrote:
>
> > +1 for feature branch as well.
> >
> > --Mark
> >
> > On Thu, Oct 6, 2016 at 9:30 AM, Dan Smith  wrote:
> >
> > > +1 for moving it to a feature branch.
> > >
> > > -Dan
> > >
> > > On Wed, Oct 5, 2016 at 2:40 PM, Jason Huynh  wrote:
> > > > Bumping to see if we have come to a decision on whether we want to
> move
> > > > this to a feature branch and get rid of it for 1.0 or post 1.0,
> > > especially
> > > > now that the 1.0 release branch has been cut
> > > >
> > > > On Fri, Sep 23, 2016 at 5:22 PM Anthony Baker 
> > wrote:
> > > >
> > > > Likewise!  Geode provides an L2 cache for Hibernate.  That is, an
> > > > application that is using Hibernate could plug in Geode for caching.
> > > > Specifically, we implement Hibernate’s cache interfaces like
> > > CacheProvider,
> > > > RegionFactory, etc.
> > > >
> > > > There are build-time dependencies on several hibernate jars
> > > > (hibernate-annotations, hibernate-core,
> hibernate-commons-annotations).
> > > No
> > > > hibernate source code or jars are shipped with any release.
> > > >
> > > > Docs:
> > > > http://geode.docs.pivotal.io/docs/tools_modules/hibernate_
> > > cache/chapter_overview.html
> > > >
> > > > Code:
> > > > https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> > > git;a=tree;f=extensions/geode-modules-hibernate;h=
> > > be8b9355934f824b9d4565ec6bfaa5d17a117f45;hb=HEAD
> > > >
> > > > ~/working/apache-geode-1.0.0-incubating.M3$ unzip -l
> > > > tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip
> > > > Archive:
> > > > tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip
> > > >   Length Date   TimeName
> > > >     
> > > > 0  08-01-16 17:01   lib/
> > > >114497  08-01-16 16:58   lib/geode-modules-1.0.0-
> incubating.M3.jar
> > > > 56960  08-01-16 17:01
> > > >  lib/geode-modules-hibernate-1.0.0-incubating.M3.jar
> > > >     ---
> > > >171457   3 files
> > > >
> > > > ~/working/apache-geode-1.0.0-incubating.M3$ jar tvf
> > > > lib/geode-modules-hibernate-1.0.0-incubating.M3.jar
> > > >  0 Mon Aug 01 17:01:40 PDT 2016 META-INF/
> > > >139 Mon Aug 01 17:01:40 PDT 2016 META-INF/MANIFEST.MF
> > > >  28210 Mon Jul 25 21:52:24 PDT 2016 META-INF/LICENSE
> > > >584 Fri Jul 08 12:51:12 PDT 2016 META-INF/NOTICE
> > > >  0 Mon Aug 01 17:01:40 PDT 2016 com/
> > > >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/
> > > >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/
> > > >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/
> > > >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/
> > > hibernate/
> > > >   1210 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/EnumType.class
> > > >   5707 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/GemFireCache.class
> > > >   1700 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/GemFireCacheListener.class
> > > >   7084 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/GemFireCacheProvider.class
> > > >   1104 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/
> GemFireQueryCacheFactory.class
> > > >   9529 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/GemFireRegionFactory.class
> > > >  0 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/internal/
> > > >   1020 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/internal/Access$1.class
> > > >   9535 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/internal/Access.class
> > > >343 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/internal/
> > > ClientServerRegionFactoryDelegate$1.class
> > > >   1508 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/internal/
> > > ClientServerRegionFactoryDelegate$LocatorHolder.class
> > > >   9639 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/internal/
> > > ClientServerRegionFactoryDelegate.class
> > > >   9739 Mon Aug 01 17:01:40 PDT 2016
> > > > com/gemstone/gemfire/modules/hibernate/internal/
> CollectionAccess.class
> > > >   2409 Mon Aug 01 17:01:40 PDT 2016
> > > >
> >

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

2016-10-06 Thread Jared Stewart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151676
---



My previous issues were due to applying this patch to DEVELOP rather than 
release/1.0.0-incubating.

- Jared Stewart


On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> ---
> 
> (Updated Oct. 5, 2016, 9:06 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk 
> Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1570: upgrade spring libraries and related libraries
> 
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
>  0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
>  a9d90ed5489a9ab6b936674369b5e5a870651738 
>   geode-assembly/src/test/resources/expected_jars.txt 
> 939464a92a3f1846b8fb9b9d1faa75dad5133289 
>   geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java
>  9e7b7bf17920a9dc42905bab4ccb4590ca20223a 
>   
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
>  435b426627deea6c67ecd79bc014ec97774e2ebf 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
>  425f5a5aa76c8219678164ebbb012d1361519bc7 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
>  f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4 
>   
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
>  51abb3f39902938149fb67a416f571ba31b75d77 
>   geode-pulse/src/main/webapp/Login.html 
> f22490f4df098c0b12dadeefcb1855a51efc6281 
>   geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml 
> cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe 
>   geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 
> 924dd50f579a6e4e306b94f4a7fd88e87f978add 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java
>  a77e0cacdcde69f47fbd13c588601072c432ee0d 
>   
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java
>  a4f14f89ea739e7390565d652fc5affa6e1326c6 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java
>  ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java
>  1fcffbd4eee26fee890f158794727647145a1914 
>   geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml 
> c75d975c4313f953cce5ac7f5a8cd8a228718a8c 
>   geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 
> 3b1d1658ea2414190852cc1268fd9f1beccf4d20 
>   gradle/dependency-resolution.gradle 
> 91d1755848ba9ce23fab3190555c2906bcffd97b 
>   gradle/dependency-versions.properties 
> 65fd2ee1d46156781ee70165aac578c5ca14490a 
> 
> Diff: https://reviews.apache.org/r/52571/diff/
> 
> 
> Testing
> ---
> 
> precheckin running.
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Hibernate module and Geode 1.0 ?

2016-10-06 Thread Joey McAllister

+1 for moving to a feature branch.

On Thu, Oct 6, 2016 at 9:32 AM Mark Bretl  wrote:

> +1 for feature branch as well.
>
> --Mark
>
> On Thu, Oct 6, 2016 at 9:30 AM, Dan Smith  wrote:
>
> > +1 for moving it to a feature branch.
> >
> > -Dan
> >
> > On Wed, Oct 5, 2016 at 2:40 PM, Jason Huynh  wrote:
> > > Bumping to see if we have come to a decision on whether we want to move
> > > this to a feature branch and get rid of it for 1.0 or post 1.0,
> > especially
> > > now that the 1.0 release branch has been cut
> > >
> > > On Fri, Sep 23, 2016 at 5:22 PM Anthony Baker 
> wrote:
> > >
> > > Likewise!  Geode provides an L2 cache for Hibernate.  That is, an
> > > application that is using Hibernate could plug in Geode for caching.
> > > Specifically, we implement Hibernate’s cache interfaces like
> > CacheProvider,
> > > RegionFactory, etc.
> > >
> > > There are build-time dependencies on several hibernate jars
> > > (hibernate-annotations, hibernate-core, hibernate-commons-annotations).
> > No
> > > hibernate source code or jars are shipped with any release.
> > >
> > > Docs:
> > > http://geode.docs.pivotal.io/docs/tools_modules/hibernate_
> > cache/chapter_overview.html
> > >
> > > Code:
> > > https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> > git;a=tree;f=extensions/geode-modules-hibernate;h=
> > be8b9355934f824b9d4565ec6bfaa5d17a117f45;hb=HEAD
> > >
> > > ~/working/apache-geode-1.0.0-incubating.M3$ unzip -l
> > > tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip
> > > Archive:
> > > tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip
> > >   Length Date   TimeName
> > >     
> > > 0  08-01-16 17:01   lib/
> > >114497  08-01-16 16:58   lib/geode-modules-1.0.0-incubating.M3.jar
> > > 56960  08-01-16 17:01
> > >  lib/geode-modules-hibernate-1.0.0-incubating.M3.jar
> > >     ---
> > >171457   3 files
> > >
> > > ~/working/apache-geode-1.0.0-incubating.M3$ jar tvf
> > > lib/geode-modules-hibernate-1.0.0-incubating.M3.jar
> > >  0 Mon Aug 01 17:01:40 PDT 2016 META-INF/
> > >139 Mon Aug 01 17:01:40 PDT 2016 META-INF/MANIFEST.MF
> > >  28210 Mon Jul 25 21:52:24 PDT 2016 META-INF/LICENSE
> > >584 Fri Jul 08 12:51:12 PDT 2016 META-INF/NOTICE
> > >  0 Mon Aug 01 17:01:40 PDT 2016 com/
> > >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/
> > >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/
> > >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/
> > >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/
> > hibernate/
> > >   1210 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/EnumType.class
> > >   5707 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/GemFireCache.class
> > >   1700 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/GemFireCacheListener.class
> > >   7084 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/GemFireCacheProvider.class
> > >   1104 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/GemFireQueryCacheFactory.class
> > >   9529 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/GemFireRegionFactory.class
> > >  0 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/
> > >   1020 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/Access$1.class
> > >   9535 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/Access.class
> > >343 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/
> > ClientServerRegionFactoryDelegate$1.class
> > >   1508 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/
> > ClientServerRegionFactoryDelegate$LocatorHolder.class
> > >   9639 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/
> > ClientServerRegionFactoryDelegate.class
> > >   9739 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/CollectionAccess.class
> > >   2409 Mon Aug 01 17:01:40 PDT 2016
> > >
> com/gemstone/gemfire/modules/hibernate/internal/EntityRegionWriter.class
> > >240 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/EntityVersion.class
> > >964 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/EntityVersionImpl.class
> > >   2446 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/EntityWrapper.class
> > >   5001 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/GemFireBaseRegion.class
> > >   2563 Mon Aug 01 17:01:40 PDT 2016
> > > com/gemstone/gemfire/modules/hibernate/internal/
> >

Re: Hibernate module and Geode 1.0 ?

2016-10-06 Thread Mark Bretl

+1 for feature branch as well.

--Mark

On Thu, Oct 6, 2016 at 9:30 AM, Dan Smith  wrote:

> +1 for moving it to a feature branch.
>
> -Dan
>
> On Wed, Oct 5, 2016 at 2:40 PM, Jason Huynh  wrote:
> > Bumping to see if we have come to a decision on whether we want to move
> > this to a feature branch and get rid of it for 1.0 or post 1.0,
> especially
> > now that the 1.0 release branch has been cut
> >
> > On Fri, Sep 23, 2016 at 5:22 PM Anthony Baker  wrote:
> >
> > Likewise!  Geode provides an L2 cache for Hibernate.  That is, an
> > application that is using Hibernate could plug in Geode for caching.
> > Specifically, we implement Hibernate’s cache interfaces like
> CacheProvider,
> > RegionFactory, etc.
> >
> > There are build-time dependencies on several hibernate jars
> > (hibernate-annotations, hibernate-core, hibernate-commons-annotations).
> No
> > hibernate source code or jars are shipped with any release.
> >
> > Docs:
> > http://geode.docs.pivotal.io/docs/tools_modules/hibernate_
> cache/chapter_overview.html
> >
> > Code:
> > https://git-wip-us.apache.org/repos/asf?p=incubator-geode.
> git;a=tree;f=extensions/geode-modules-hibernate;h=
> be8b9355934f824b9d4565ec6bfaa5d17a117f45;hb=HEAD
> >
> > ~/working/apache-geode-1.0.0-incubating.M3$ unzip -l
> > tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip
> > Archive:
> > tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip
> >   Length Date   TimeName
> >     
> > 0  08-01-16 17:01   lib/
> >114497  08-01-16 16:58   lib/geode-modules-1.0.0-incubating.M3.jar
> > 56960  08-01-16 17:01
> >  lib/geode-modules-hibernate-1.0.0-incubating.M3.jar
> >     ---
> >171457   3 files
> >
> > ~/working/apache-geode-1.0.0-incubating.M3$ jar tvf
> > lib/geode-modules-hibernate-1.0.0-incubating.M3.jar
> >  0 Mon Aug 01 17:01:40 PDT 2016 META-INF/
> >139 Mon Aug 01 17:01:40 PDT 2016 META-INF/MANIFEST.MF
> >  28210 Mon Jul 25 21:52:24 PDT 2016 META-INF/LICENSE
> >584 Fri Jul 08 12:51:12 PDT 2016 META-INF/NOTICE
> >  0 Mon Aug 01 17:01:40 PDT 2016 com/
> >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/
> >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/
> >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/
> >  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/
> hibernate/
> >   1210 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/EnumType.class
> >   5707 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/GemFireCache.class
> >   1700 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/GemFireCacheListener.class
> >   7084 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/GemFireCacheProvider.class
> >   1104 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/GemFireQueryCacheFactory.class
> >   9529 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/GemFireRegionFactory.class
> >  0 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/
> >   1020 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/Access$1.class
> >   9535 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/Access.class
> >343 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/
> ClientServerRegionFactoryDelegate$1.class
> >   1508 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/
> ClientServerRegionFactoryDelegate$LocatorHolder.class
> >   9639 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/
> ClientServerRegionFactoryDelegate.class
> >   9739 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/CollectionAccess.class
> >   2409 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/EntityRegionWriter.class
> >240 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/EntityVersion.class
> >964 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/EntityVersionImpl.class
> >   2446 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/EntityWrapper.class
> >   5001 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/GemFireBaseRegion.class
> >   2563 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/
> GemFireCollectionRegion.class
> >   7702 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/
> GemFireEntityRegion.class
> >   3058 Mon Aug 01 17:01:40 PDT 2016
> > com/gemstone/gemfire/modules/hibernate/internal/
> GemFireQueryResultsRegion.class
> >   2547 Mon Aug 01 17:01:40 PDT 2016
> >

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Mark Bretl

-1 for this

I do understand the intent and reason behind this, however, in addition to
the reasons Anthony provided, I do not believe this community should carry
the burden of testing compatibility with proprietary/commercial software.
Even though Geode has its history in GemFire, I can only see the community
supporting official Geode releases. It would set a bad precedent to allow
for any part of the Geode code ( source or test ) to depend on any
commercial code.

If any company wants to make sure their software works with Geode, it is
their responsibility.

My $.02,

--Mark

On Thu, Oct 6, 2016 at 9:12 AM, Bruce Schuchardt 
wrote:

> Yes, dist.gemstone.com.
>
>
> Le 10/6/2016 à 9:08 AM, Dick Cavender a écrit :
>
>> Only on initial setup/access to repo.pivotal.io is the EULA acceptance
>> required. After that you should be able to pull from any repo there without
>> interaction but you will need to provide the creds as part of the pull.
>>
>> Are you instead using dist.gemstone.com for the older jars which is the
>> original repo that lives in the spring s3 repo
>>
>>
>> On 10/6/2016 7:48 AM, Bruce Schuchardt wrote:
>>
>>> Thanks Anthony.
>>>
>>> I thought there was some interest in supporting old GemFire clients and
>>> WAN.  Is there no way to download it without a login/EULA?  I'm currently
>>> using a different repo but maybe that's only available in Pivotal's network.
>>>
>>> As far as M3 goes, do you think there would be any value in testing
>>> against it?  I don't want to introduce new tests unless they are helpful.
>>>
>>> Le 10/5/2016 à 5:31 PM, Anthony Baker a écrit :
>>>
 Given that the official Pivotal maven repo [1] is locked behind a login
 and a EULA I think this might not work so well.  The license compatibility
 issues would need to be explored as well.

 How would you feel about testing backwards compatibility against
 1.0.0-incubating.M3?

 Anthony

 [1] http://commercial-repo.pivotal.io

 On Oct 5, 2016, at 4:17 PM, Bruce Schuchardt 
> wrote:
>
> We now have a backward-compatibility module but it's not well tested.
> I'd
> like to add tests to this module that run against GemFire jars
> downloaded
> from the Pivotal maven repository.  I've already implemented the
> framework
> and some smoke tests but want to know how people feel about the tests
> downloading something proprietary to test against and whether failures
> would be something the community cares about.
>
> If we don't want this I'll keep it out of the repo until we have a
> 1.0.0
> release to test against.
>

>>>
>>
>

Re: Hibernate module and Geode 1.0 ?

2016-10-06 Thread Dan Smith

+1 for moving it to a feature branch.

-Dan

On Wed, Oct 5, 2016 at 2:40 PM, Jason Huynh  wrote:
> Bumping to see if we have come to a decision on whether we want to move
> this to a feature branch and get rid of it for 1.0 or post 1.0, especially
> now that the 1.0 release branch has been cut
>
> On Fri, Sep 23, 2016 at 5:22 PM Anthony Baker  wrote:
>
> Likewise!  Geode provides an L2 cache for Hibernate.  That is, an
> application that is using Hibernate could plug in Geode for caching.
> Specifically, we implement Hibernate’s cache interfaces like CacheProvider,
> RegionFactory, etc.
>
> There are build-time dependencies on several hibernate jars
> (hibernate-annotations, hibernate-core, hibernate-commons-annotations).  No
> hibernate source code or jars are shipped with any release.
>
> Docs:
> http://geode.docs.pivotal.io/docs/tools_modules/hibernate_cache/chapter_overview.html
>
> Code:
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tree;f=extensions/geode-modules-hibernate;h=be8b9355934f824b9d4565ec6bfaa5d17a117f45;hb=HEAD
>
> ~/working/apache-geode-1.0.0-incubating.M3$ unzip -l
> tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip
> Archive:
> tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip
>   Length Date   TimeName
>     
> 0  08-01-16 17:01   lib/
>114497  08-01-16 16:58   lib/geode-modules-1.0.0-incubating.M3.jar
> 56960  08-01-16 17:01
>  lib/geode-modules-hibernate-1.0.0-incubating.M3.jar
>     ---
>171457   3 files
>
> ~/working/apache-geode-1.0.0-incubating.M3$ jar tvf
> lib/geode-modules-hibernate-1.0.0-incubating.M3.jar
>  0 Mon Aug 01 17:01:40 PDT 2016 META-INF/
>139 Mon Aug 01 17:01:40 PDT 2016 META-INF/MANIFEST.MF
>  28210 Mon Jul 25 21:52:24 PDT 2016 META-INF/LICENSE
>584 Fri Jul 08 12:51:12 PDT 2016 META-INF/NOTICE
>  0 Mon Aug 01 17:01:40 PDT 2016 com/
>  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/
>  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/
>  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/
>  0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/hibernate/
>   1210 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/EnumType.class
>   5707 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/GemFireCache.class
>   1700 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/GemFireCacheListener.class
>   7084 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/GemFireCacheProvider.class
>   1104 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/GemFireQueryCacheFactory.class
>   9529 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/GemFireRegionFactory.class
>  0 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/
>   1020 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/Access$1.class
>   9535 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/Access.class
>343 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/ClientServerRegionFactoryDelegate$1.class
>   1508 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/ClientServerRegionFactoryDelegate$LocatorHolder.class
>   9639 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/ClientServerRegionFactoryDelegate.class
>   9739 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/CollectionAccess.class
>   2409 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/EntityRegionWriter.class
>240 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/EntityVersion.class
>964 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/EntityVersionImpl.class
>   2446 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/EntityWrapper.class
>   5001 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/GemFireBaseRegion.class
>   2563 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/GemFireCollectionRegion.class
>   7702 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/GemFireEntityRegion.class
>   3058 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/GemFireQueryResultsRegion.class
>   2547 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/KeyWrapper.class
>   2911 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/NonStrictReadWriteAccess.class
>   1670 Mon Aug 01 17:01:40 PDT 2016
> com/gemstone/gemfire/modules/hibernate/internal/ReadOnlyAccess.class
>   1121 Mon Aug 01 17:01:40 PDT 2016
>

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Bruce Schuchardt


Yes, dist.gemstone.com.

Le 10/6/2016 à 9:08 AM, Dick Cavender a écrit :
Only on initial setup/access to repo.pivotal.io is the EULA acceptance 
required. After that you should be able to pull from any repo there 
without interaction but you will need to provide the creds as part of 
the pull.


Are you instead using dist.gemstone.com for the older jars which is 
the original repo that lives in the spring s3 repo



On 10/6/2016 7:48 AM, Bruce Schuchardt wrote:

Thanks Anthony.

I thought there was some interest in supporting old GemFire clients 
and WAN.  Is there no way to download it without a login/EULA?  I'm 
currently using a different repo but maybe that's only available in 
Pivotal's network.


As far as M3 goes, do you think there would be any value in testing 
against it?  I don't want to introduce new tests unless they are 
helpful.


Le 10/5/2016 à 5:31 PM, Anthony Baker a écrit :
Given that the official Pivotal maven repo [1] is locked behind a 
login and a EULA I think this might not work so well.  The license 
compatibility issues would need to be explored as well.


How would you feel about testing backwards compatibility against 
1.0.0-incubating.M3?


Anthony

[1] http://commercial-repo.pivotal.io

On Oct 5, 2016, at 4:17 PM, Bruce Schuchardt 
 wrote:


We now have a backward-compatibility module but it's not well 
tested.  I'd
like to add tests to this module that run against GemFire jars 
downloaded
from the Pivotal maven repository.  I've already implemented the 
framework

and some smoke tests but want to know how people feel about the tests
downloading something proprietary to test against and whether failures
would be something the community cares about.

If we don't want this I'll keep it out of the repo until we have a 
1.0.0

release to test against.

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Dick Cavender

Only on initial setup/access to repo.pivotal.io is the EULA acceptance 
required. After that you should be able to pull from any repo there 
without interaction but you will need to provide the creds as part of 
the pull.


Are you instead using dist.gemstone.com for the older jars which is the 
original repo that lives in the spring s3 repo



On 10/6/2016 7:48 AM, Bruce Schuchardt wrote:

Thanks Anthony.

I thought there was some interest in supporting old GemFire clients 
and WAN.  Is there no way to download it without a login/EULA?  I'm 
currently using a different repo but maybe that's only available in 
Pivotal's network.


As far as M3 goes, do you think there would be any value in testing 
against it?  I don't want to introduce new tests unless they are helpful.


Le 10/5/2016 à 5:31 PM, Anthony Baker a écrit :
Given that the official Pivotal maven repo [1] is locked behind a 
login and a EULA I think this might not work so well.  The license 
compatibility issues would need to be explored as well.


How would you feel about testing backwards compatibility against 
1.0.0-incubating.M3?


Anthony

[1] http://commercial-repo.pivotal.io

On Oct 5, 2016, at 4:17 PM, Bruce Schuchardt 
 wrote:


We now have a backward-compatibility module but it's not well 
tested.  I'd
like to add tests to this module that run against GemFire jars 
downloaded
from the Pivotal maven repository.  I've already implemented the 
framework

and some smoke tests but want to know how people feel about the tests
downloading something proprietary to test against and whether failures
would be something the community cares about.

If we don't want this I'll keep it out of the repo until we have a 
1.0.0

release to test against.

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Bruce Schuchardt


Thanks Anthony.

I thought there was some interest in supporting old GemFire clients and 
WAN.  Is there no way to download it without a login/EULA?  I'm 
currently using a different repo but maybe that's only available in 
Pivotal's network.


As far as M3 goes, do you think there would be any value in testing 
against it?  I don't want to introduce new tests unless they are helpful.


Le 10/5/2016 à 5:31 PM, Anthony Baker a écrit :

Given that the official Pivotal maven repo [1] is locked behind a login and a 
EULA I think this might not work so well.  The license compatibility issues 
would need to be explored as well.

How would you feel about testing backwards compatibility against 
1.0.0-incubating.M3?

Anthony

[1] http://commercial-repo.pivotal.io


On Oct 5, 2016, at 4:17 PM, Bruce Schuchardt  wrote:

We now have a backward-compatibility module but it's not well tested.  I'd
like to add tests to this module that run against GemFire jars downloaded
from the Pivotal maven repository.  I've already implemented the framework
and some smoke tests but want to know how people feel about the tests
downloading something proprietary to test against and whether failures
would be something the community cares about.

If we don't want this I'll keep it out of the repo until we have a 1.0.0
release to test against.

Jenkins build is back to normal : Geode-release #30

2016-10-06 Thread Apache Jenkins Server

See

Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get security properties from system properties

Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get security properties from system properties

Review Request 52621: GEM-1032: GMSAuthenticator needs to get security properties from system properties

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

Re: backward compatibility testing against GemFire 8.x WAN/clients

Re: backward compatibility testing against GemFire 8.x WAN/clients

Re: backward compatibility testing against GemFire 8.x WAN/clients

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

Re: Hibernate module and Geode 1.0 ?

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

Re: Hibernate module and Geode 1.0 ?

Re: Hibernate module and Geode 1.0 ?

Re: backward compatibility testing against GemFire 8.x WAN/clients

Re: Hibernate module and Geode 1.0 ?

Re: backward compatibility testing against GemFire 8.x WAN/clients

Re: backward compatibility testing against GemFire 8.x WAN/clients

Re: backward compatibility testing against GemFire 8.x WAN/clients

Jenkins build is back to normal : Geode-release #30

20 matches

Site Navigation

Mail list logo

Footer information