[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540764 ] Joe Bohn commented on GERONIMO-3586: IIUC the client is actually running on a particular server and hence a particular container. The client can only retrieve information for that container. Therefore, it provides no value for a client to have extraneous interfaces available to it for another container. It is the monitoring console (also running on a particular server/container) that is the integration point for multiple containers. However, the monitoring console itself does not access the stats directly. So it would seem to me that a monitoring client is by design always limited to one container and it provides no value to have excess interfaces available for another container. I won't press the point much further, but I still don't see value in the client having access to interfaces that it cannot utilize. So it makes sense to me that we consolidate the container specific classes under the container plugin (the intent behind GERONIMO-3587). monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540793 ] Viet Hung Nguyen commented on GERONIMO-3586: the mrc-server needs the container specific classes in its classloader because although I am generically using the object Stats to get all of the stats from different components, the object that is actually there is really of type JettyWebConnectorStatsImpl. So all *Stats*Impl* classes have to be visible within mrc-server's domain. If not, I will get a ClassNotFoundException. For the instance of Tomcat, it works fine because mrc-server depends on MEJB which depends on G-management, which is where the Tomcat stuff is located. However, since Jetty is still in G-jetty6 and nothing depends on it, it fails to be visible by the mrc-server. This is why I believe we should restructure our directories, plus it's good to have consistency in our structure. Additionally, I think what Joe meant was that the monitoring console can reside on a different server, and regardless of what container that server is running, it will never see anything Jetty or Tomcat specific because that stuff is all taken care of by the mrc-server. The mrc-server is the only piece of this puzzle that needs to look at the Tomcat and Jetty specific items. monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540888 ] Joe Bohn commented on GERONIMO-3586: This probably isn't worth the effort to argue further. We're just going around in circles. Just to clarify ... the monitoring console (by this I mean just the UI) does not need the container specific stats classes (and I didn't intend to imply that it did). It is the server code (what I called the monitoring client earlier) that needs the container specific stats classes. I still don't see a situation where the server would require both the tomcat and jetty stats classes since it will always be working with a specific server/container. Yes, splitting these would require 2 versions of the server. We already require 2 versions of the UI code because of the need to run in each container (just as there are 2 plugins for the web console itself). I'm not thrilled with the proposed organization but I won't lose any sleep over it either. I'll cancel GERONIMO-3587. monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540811 ] Anita Kulshreshtha commented on GERONIMO-3586: -- For the instance of Tomcat, it works fine because mrc-server depends on MEJB which depends on G-management, which is where the Tomcat stuff is located. However, since Jetty is still in G-jetty6 and nothing depends on it, it fails to be visible by the mrc-server. This is a perfect example of why the Jetty*Stats and Jetty*StatsImpl classes should be in g-management and not in g-jetty6. Otherwise we will need two versions of Monitoring console (client, mrc-server,..). Though you could use JSR77 to get all the info you need from any StatsImpl, e.g. if a StatsImpl (could be a Jetty*StatsImpl) has a statistic named XYX, it will have a method named getXYZ. Using this you could get all Statistics in the StatsImpl. The mrc-server also consumes too many resources, in its current form it can not be loaded in the same JVM as the server to be monitored. monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540787 ] Anita Kulshreshtha commented on GERONIMO-3586: -- The code in the sandbox is still a work in progress. In a realistic situation the monitoring console (aka client in sandbox) will NEVER be loaded in the same server (JVM) as the server it is supposed to monitor. As for the monitoring plugin, the mrc-server should not need any container specific class. That is the spirit of JSR77. May I ask where these classes are needed? monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540915 ] Prasad Kashyap commented on GERONIMO-3586: -- This is a delicate fine line. I think I understand Anita's pov that monitoring and management does not pull down container-specific anything and hence the code can co-exist in a single plugin. However the fact remains that container specific code has to be executed at runtime to make this work. Case in point, Jetty*Stats and Jetty*StatsImpl. Now, we have sorta established an unwritten convention where we have (tried to) split the container-specific code into their own plugins for all scopes, compile and/or runtime. With other related work items we are very close to creating a flexible server with a very small footprint. A server can now be really tailor-made to every individual user/server instance. So in light of this, it makes sense to split the container specific code into their own plugins to avoid dead-weight. Or, maybe I'm still not getting what Anita is trying to convey . monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540957 ] Anita Kulshreshtha commented on GERONIMO-3586: -- Prasad, The (tomcat) Stats and StatsImpl in question are _management_ interfaces. There is NO CONTAINER SPECIFIC code in them. They do not need container code to compile. These are no different than EJBStats, JTAStats or many other Stats in g-management package. The same should be true for Jetty. This is why I propose that we move the Jetty*Stats* to g-managemnt. Joe, We need to distinguish between the server the tool is running on and the server that is being monitored. Yes we can have two versions of the tool (just like console). But that does not mean that a tool running on tomcat can not monitor a server instance running on Jetty. An important difference between admin console and monitoring console is that admin console administers the server it resides on, but a realistic monitoring console NEVER monitors the server it resides in. I hope this is helpful. monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540545 ] Anita Kulshreshtha commented on GERONIMO-3586: -- Viet, The mrc-server code should not need to refer to any specific stats or statsImpl. Could you please elaborate why you need to know about them? However we do need to move the Jetty*Stats and Jetty*StatsImpl to geronimo-management (o.a.g.management.geronimo.stats) module. monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540549 ] Joe Bohn commented on GERONIMO-3586: Anita, I just opened GERONIMO-3587 (https://issues.apache.org/jira/browse/GERONIMO-3587) to move the tomcat specific items from management to Tomcat thinking that it makes sense to keep Tomcat items with Tomcat and likewise for Jetty and use interfaces to provide common access. However, I can see that you are thinking the other way. I must be missing something obvious ... can you help me understand your perspective? Thanks, Joe monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3586) monitoring plugin: collecting agent should have separate jetty and tomcat plugins
[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540569 ] Anita Kulshreshtha commented on GERONIMO-3586: -- Joe, Please see my comment https://issues.apache.org/jira/browse/GERONIMO-3587#action_12540550. These are management interfaces . Although they do know about the specifics of the containers, they do not need the container itself. A monitoring console will use this information to monitor any g instance i.e. jetty or tomcat, irrespective of what the monitoring console itself is running on. monitoring plugin: collecting agent should have separate jetty and tomcat plugins - Key: GERONIMO-3586 URL: https://issues.apache.org/jira/browse/GERONIMO-3586 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1 Environment: windows Reporter: Viet Hung Nguyen Assignee: Jarek Gawor Attachments: geronimo-3586.patch The collecting agent plugin needs to have separate jetty and tomcat plugins in order to accommodate for the differences in container specific dependencies on stats implementation (.e.g JettyContainerStatsImpl and JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not a problem; however, as a plugin, it is more tied down to having to specify all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
