[GitHub] [griffin] lipzhu commented on a change in pull request #597: [GRIFFIN-362] Add postgresql and oracle driver into dependencies.
lipzhu commented on a change in pull request #597: URL: https://github.com/apache/griffin/pull/597#discussion_r786393569 ## File path: measure/pom.xml ## @@ -53,6 +53,8 @@ under the License. 2.3.0 2.1.0 2.10.0 +9.4.1212.jre7 Review comment: > @lipzhu is there a valid JIRA ticket for this feature? If not then please create one, link it to this PR and also add a valid description to the PR. > > Most of the PRs follow this process. Ref: #593 @chitralverma Thanks for you review, this PR try to resolve https://issues.apache.org/jira/browse/GRIFFIN-362. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (GRIFFIN-362) Oracle connection for Apache Griffin
[ https://issues.apache.org/jira/browse/GRIFFIN-362?focusedWorklogId=710228=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710228 ] ASF GitHub Bot logged work on GRIFFIN-362: -- Author: ASF GitHub Bot Created on: 18/Jan/22 03:35 Start Date: 18/Jan/22 03:35 Worklog Time Spent: 10m Work Description: lipzhu commented on a change in pull request #597: URL: https://github.com/apache/griffin/pull/597#discussion_r786393569 ## File path: measure/pom.xml ## @@ -53,6 +53,8 @@ under the License. 2.3.0 2.1.0 2.10.0 +9.4.1212.jre7 Review comment: > @lipzhu is there a valid JIRA ticket for this feature? If not then please create one, link it to this PR and also add a valid description to the PR. > > Most of the PRs follow this process. Ref: #593 @chitralverma Thanks for you review, this PR try to resolve https://issues.apache.org/jira/browse/GRIFFIN-362. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 710228) Time Spent: 0.5h (was: 20m) > Oracle connection for Apache Griffin > > > Key: GRIFFIN-362 > URL: https://issues.apache.org/jira/browse/GRIFFIN-362 > Project: Griffin > Issue Type: Bug > Components: accuracy-batch >Affects Versions: 0.6.0 > Environment: Dev >Reporter: Praveen Kurup >Priority: Blocker > Attachments: image-2021-04-27-23-07-33-681.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > Hello Team, > We are doing a POC using Apache griffin for data quality projects. > We have a requirement to check data quality between Oracle and Hive tables. > Hive connection is working fine, but we are not able to establish Oracle > connection. > I would like to understand if Apache Griffin supports jdbc Oracle connection > using oracle.jdbc.driver.OracleDriver driver. I tried using Mysql jdbc > connection template to pass Oracle connection details, however it didn't > work. I am getting below error: > {color:#FF}ERROR griffin: JDBC driver oracle.jdbc.driver.OracleDriver > provided is not found in class path{color} > {color:#FF}java.lang.ClassNotFoundException: > oracle.jdbc.driver.OracleDriver{color} > {color:#FF}!image-2021-04-27-23-07-33-681.png|width=385,height=154!{color} > {color:#172b4d}Please let me know if there is any way to establish Oracle > database connectivity from Griffin.{color} > {color:#172b4d}Also, please share if there are any documentations available > to achieve the same.{color} > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (GRIFFIN-367) Deployment guide doc update
[ https://issues.apache.org/jira/browse/GRIFFIN-367?focusedWorklogId=709952=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709952 ] ASF GitHub Bot logged work on GRIFFIN-367: -- Author: ASF GitHub Bot Created on: 17/Jan/22 14:11 Start Date: 17/Jan/22 14:11 Worklog Time Spent: 10m Work Description: chitralverma commented on a change in pull request #596: URL: https://github.com/apache/griffin/pull/596#discussion_r786042592 ## File path: service/pom.xml ## @@ -385,7 +385,6 @@ under the License. false false -../target Review comment: @lipzhu please update the docs instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 709952) Time Spent: 50m (was: 40m) > Deployment guide doc update > --- > > Key: GRIFFIN-367 > URL: https://issues.apache.org/jira/browse/GRIFFIN-367 > Project: Griffin > Issue Type: Improvement >Reporter: Zhu, Lipeng >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > Update deployment guide. > # Move the service-${version}.tar.gz from parent target folder to service > module target. > # Remove the diff change history for hive-site.xml. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [griffin] chitralverma commented on a change in pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
chitralverma commented on a change in pull request #596: URL: https://github.com/apache/griffin/pull/596#discussion_r786042592 ## File path: service/pom.xml ## @@ -385,7 +385,6 @@ under the License. false false -../target Review comment: @lipzhu please update the docs instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (GRIFFIN-362) Oracle connection for Apache Griffin
[ https://issues.apache.org/jira/browse/GRIFFIN-362?focusedWorklogId=709951=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709951 ] ASF GitHub Bot logged work on GRIFFIN-362: -- Author: ASF GitHub Bot Created on: 17/Jan/22 14:07 Start Date: 17/Jan/22 14:07 Worklog Time Spent: 10m Work Description: chitralverma commented on a change in pull request #597: URL: https://github.com/apache/griffin/pull/597#discussion_r786035047 ## File path: measure/pom.xml ## @@ -53,6 +53,8 @@ under the License. 2.3.0 2.1.0 2.10.0 +9.4.1212.jre7 Review comment: This version is compiled with java7 and is from 2016. Please use a more recent and stable version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 709951) Time Spent: 20m (was: 10m) > Oracle connection for Apache Griffin > > > Key: GRIFFIN-362 > URL: https://issues.apache.org/jira/browse/GRIFFIN-362 > Project: Griffin > Issue Type: Bug > Components: accuracy-batch >Affects Versions: 0.6.0 > Environment: Dev >Reporter: Praveen Kurup >Priority: Blocker > Attachments: image-2021-04-27-23-07-33-681.png > > Time Spent: 20m > Remaining Estimate: 0h > > Hello Team, > We are doing a POC using Apache griffin for data quality projects. > We have a requirement to check data quality between Oracle and Hive tables. > Hive connection is working fine, but we are not able to establish Oracle > connection. > I would like to understand if Apache Griffin supports jdbc Oracle connection > using oracle.jdbc.driver.OracleDriver driver. I tried using Mysql jdbc > connection template to pass Oracle connection details, however it didn't > work. I am getting below error: > {color:#FF}ERROR griffin: JDBC driver oracle.jdbc.driver.OracleDriver > provided is not found in class path{color} > {color:#FF}java.lang.ClassNotFoundException: > oracle.jdbc.driver.OracleDriver{color} > {color:#FF}!image-2021-04-27-23-07-33-681.png|width=385,height=154!{color} > {color:#172b4d}Please let me know if there is any way to establish Oracle > database connectivity from Griffin.{color} > {color:#172b4d}Also, please share if there are any documentations available > to achieve the same.{color} > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [griffin] chitralverma commented on a change in pull request #597: [GRIFFIN-362] Add postgresql and oracle driver into dependencies.
chitralverma commented on a change in pull request #597: URL: https://github.com/apache/griffin/pull/597#discussion_r786035047 ## File path: measure/pom.xml ## @@ -53,6 +53,8 @@ under the License. 2.3.0 2.1.0 2.10.0 +9.4.1212.jre7 Review comment: This version is compiled with java7 and is from 2016. Please use a more recent and stable version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (GRIFFIN-362) Oracle connection for Apache Griffin
[ https://issues.apache.org/jira/browse/GRIFFIN-362?focusedWorklogId=709948=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709948 ] ASF GitHub Bot logged work on GRIFFIN-362: -- Author: ASF GitHub Bot Created on: 17/Jan/22 14:03 Start Date: 17/Jan/22 14:03 Worklog Time Spent: 10m Work Description: chitralverma commented on pull request #597: URL: https://github.com/apache/griffin/pull/597#issuecomment-1014578475 @lipzhu is there a valid JIRA ticket for this feature? If not then please create one, link it to this PR and also add a valid description to the PR. Most of the PRs follow this process. Ref: https://github.com/apache/griffin/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 709948) Remaining Estimate: 0h Time Spent: 10m > Oracle connection for Apache Griffin > > > Key: GRIFFIN-362 > URL: https://issues.apache.org/jira/browse/GRIFFIN-362 > Project: Griffin > Issue Type: Bug > Components: accuracy-batch >Affects Versions: 0.6.0 > Environment: Dev >Reporter: Praveen Kurup >Priority: Blocker > Attachments: image-2021-04-27-23-07-33-681.png > > Time Spent: 10m > Remaining Estimate: 0h > > Hello Team, > We are doing a POC using Apache griffin for data quality projects. > We have a requirement to check data quality between Oracle and Hive tables. > Hive connection is working fine, but we are not able to establish Oracle > connection. > I would like to understand if Apache Griffin supports jdbc Oracle connection > using oracle.jdbc.driver.OracleDriver driver. I tried using Mysql jdbc > connection template to pass Oracle connection details, however it didn't > work. I am getting below error: > {color:#FF}ERROR griffin: JDBC driver oracle.jdbc.driver.OracleDriver > provided is not found in class path{color} > {color:#FF}java.lang.ClassNotFoundException: > oracle.jdbc.driver.OracleDriver{color} > {color:#FF}!image-2021-04-27-23-07-33-681.png|width=385,height=154!{color} > {color:#172b4d}Please let me know if there is any way to establish Oracle > database connectivity from Griffin.{color} > {color:#172b4d}Also, please share if there are any documentations available > to achieve the same.{color} > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [griffin] chitralverma commented on pull request #597: [GRIFFIN-362] Add postgresql and oracle driver into dependencies.
chitralverma commented on pull request #597: URL: https://github.com/apache/griffin/pull/597#issuecomment-1014578475 @lipzhu is there a valid JIRA ticket for this feature? If not then please create one, link it to this PR and also add a valid description to the PR. Most of the PRs follow this process. Ref: https://github.com/apache/griffin/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (GRIFFIN-367) Deployment guide doc update
[ https://issues.apache.org/jira/browse/GRIFFIN-367?focusedWorklogId=709887=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709887 ] ASF GitHub Bot logged work on GRIFFIN-367: -- Author: ASF GitHub Bot Created on: 17/Jan/22 12:00 Start Date: 17/Jan/22 12:00 Worklog Time Spent: 10m Work Description: whhe commented on a change in pull request #596: URL: https://github.com/apache/griffin/pull/596#discussion_r785921305 ## File path: service/pom.xml ## @@ -385,7 +385,6 @@ under the License. false false -../target Review comment: > The service-${version}.tar.gz location is not align with the Documention in https://github.com/apache/griffin/blob/master/griffin-doc/deploy/deploy-guide.md, or we can update the documentation to remove the confuse. > > > > > It's easy to build Griffin, just run maven command mvn clean install. Successfully building, you can get service-${version}.tar.gz and measure-${version}.jar from target folder in **service** and **measure** module. You're right. I think it's better to update the doc, and the following commands should also be modified at the same time. ```bash cd $GRIFFIN_INSTALL_DIR tar -zxvf service-${version}.tar.gz ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 709887) Time Spent: 40m (was: 0.5h) > Deployment guide doc update > --- > > Key: GRIFFIN-367 > URL: https://issues.apache.org/jira/browse/GRIFFIN-367 > Project: Griffin > Issue Type: Improvement >Reporter: Zhu, Lipeng >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Update deployment guide. > # Move the service-${version}.tar.gz from parent target folder to service > module target. > # Remove the diff change history for hive-site.xml. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [griffin] whhe commented on a change in pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
whhe commented on a change in pull request #596: URL: https://github.com/apache/griffin/pull/596#discussion_r785921305 ## File path: service/pom.xml ## @@ -385,7 +385,6 @@ under the License. false false -../target Review comment: > The service-${version}.tar.gz location is not align with the Documention in https://github.com/apache/griffin/blob/master/griffin-doc/deploy/deploy-guide.md, or we can update the documentation to remove the confuse. > > > > > It's easy to build Griffin, just run maven command mvn clean install. Successfully building, you can get service-${version}.tar.gz and measure-${version}.jar from target folder in **service** and **measure** module. You're right. I think it's better to update the doc, and the following commands should also be modified at the same time. ```bash cd $GRIFFIN_INSTALL_DIR tar -zxvf service-${version}.tar.gz ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (GRIFFIN-367) Deployment guide doc update
[ https://issues.apache.org/jira/browse/GRIFFIN-367?focusedWorklogId=709852=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709852 ] ASF GitHub Bot logged work on GRIFFIN-367: -- Author: ASF GitHub Bot Created on: 17/Jan/22 11:09 Start Date: 17/Jan/22 11:09 Worklog Time Spent: 10m Work Description: lipzhu commented on a change in pull request #596: URL: https://github.com/apache/griffin/pull/596#discussion_r785865424 ## File path: service/pom.xml ## @@ -385,7 +385,6 @@ under the License. false false -../target Review comment: The service-${version}.tar.gz location is not align with the Documention in https://github.com/apache/griffin/blob/master/griffin-doc/deploy/deploy-guide.md, or we can update the documentation to remove the confuse. >>>It's easy to build Griffin, just run maven command mvn clean install. Successfully building, you can get service-${version}.tar.gz and measure-${version}.jar from target folder in **service** and **measure** module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 709852) Time Spent: 0.5h (was: 20m) > Deployment guide doc update > --- > > Key: GRIFFIN-367 > URL: https://issues.apache.org/jira/browse/GRIFFIN-367 > Project: Griffin > Issue Type: Improvement >Reporter: Zhu, Lipeng >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > Update deployment guide. > # Move the service-${version}.tar.gz from parent target folder to service > module target. > # Remove the diff change history for hive-site.xml. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [griffin] lipzhu commented on a change in pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
lipzhu commented on a change in pull request #596: URL: https://github.com/apache/griffin/pull/596#discussion_r785865424 ## File path: service/pom.xml ## @@ -385,7 +385,6 @@ under the License. false false -../target Review comment: The service-${version}.tar.gz location is not align with the Documention in https://github.com/apache/griffin/blob/master/griffin-doc/deploy/deploy-guide.md, or we can update the documentation to remove the confuse. >>>It's easy to build Griffin, just run maven command mvn clean install. Successfully building, you can get service-${version}.tar.gz and measure-${version}.jar from target folder in **service** and **measure** module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (GRIFFIN-367) Deployment guide doc update
[ https://issues.apache.org/jira/browse/GRIFFIN-367?focusedWorklogId=709847=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709847 ] ASF GitHub Bot logged work on GRIFFIN-367: -- Author: ASF GitHub Bot Created on: 17/Jan/22 10:57 Start Date: 17/Jan/22 10:57 Worklog Time Spent: 10m Work Description: whhe commented on a change in pull request #596: URL: https://github.com/apache/griffin/pull/596#discussion_r785853228 ## File path: service/pom.xml ## @@ -385,7 +385,6 @@ under the License. false false -../target Review comment: Why move it? I think it's appropriate to put the deployment package at root directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 709847) Time Spent: 20m (was: 10m) > Deployment guide doc update > --- > > Key: GRIFFIN-367 > URL: https://issues.apache.org/jira/browse/GRIFFIN-367 > Project: Griffin > Issue Type: Improvement >Reporter: Zhu, Lipeng >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update deployment guide. > # Move the service-${version}.tar.gz from parent target folder to service > module target. > # Remove the diff change history for hive-site.xml. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [griffin] whhe commented on a change in pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
whhe commented on a change in pull request #596: URL: https://github.com/apache/griffin/pull/596#discussion_r785853228 ## File path: service/pom.xml ## @@ -385,7 +385,6 @@ under the License. false false -../target Review comment: Why move it? I think it's appropriate to put the deployment package at root directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GRIFFIN-366) How to specify fixed ports for Driver and Executor in Spark jobs in Griffin
[ https://issues.apache.org/jira/browse/GRIFFIN-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477114#comment-17477114 ] Zhu, Lipeng commented on GRIFFIN-366: - [https://github.com/apache/griffin/blob/master/measure/src/main/resources/env-batch.json#L5] > How to specify fixed ports for Driver and Executor in Spark jobs in Griffin > --- > > Key: GRIFFIN-366 > URL: https://issues.apache.org/jira/browse/GRIFFIN-366 > Project: Griffin > Issue Type: Bug > Components: Service Module >Affects Versions: 0.6.0 >Reporter: carson >Priority: Major > > The communication port between Driver and Executor is random,and due to > network restrictions, I want to configure a fixed port. Where can I configure > it please? > I notice that spark support it by using : > spark.driver.port=1spark.blockManager.port=2spark.port.maxRetries=999 > to configure the port . but I dont know how to add these in Griffin -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GRIFFIN-362) Oracle connection for Apache Griffin
[ https://issues.apache.org/jira/browse/GRIFFIN-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477101#comment-17477101 ] Zhu, Lipeng commented on GRIFFIN-362: - Add oracle driver in your dependency when build measure module. [https://github.com/apache/griffin/pull/597] > Oracle connection for Apache Griffin > > > Key: GRIFFIN-362 > URL: https://issues.apache.org/jira/browse/GRIFFIN-362 > Project: Griffin > Issue Type: Bug > Components: accuracy-batch >Affects Versions: 0.6.0 > Environment: Dev >Reporter: Praveen Kurup >Priority: Blocker > Attachments: image-2021-04-27-23-07-33-681.png > > > Hello Team, > We are doing a POC using Apache griffin for data quality projects. > We have a requirement to check data quality between Oracle and Hive tables. > Hive connection is working fine, but we are not able to establish Oracle > connection. > I would like to understand if Apache Griffin supports jdbc Oracle connection > using oracle.jdbc.driver.OracleDriver driver. I tried using Mysql jdbc > connection template to pass Oracle connection details, however it didn't > work. I am getting below error: > {color:#FF}ERROR griffin: JDBC driver oracle.jdbc.driver.OracleDriver > provided is not found in class path{color} > {color:#FF}java.lang.ClassNotFoundException: > oracle.jdbc.driver.OracleDriver{color} > {color:#FF}!image-2021-04-27-23-07-33-681.png|width=385,height=154!{color} > {color:#172b4d}Please let me know if there is any way to establish Oracle > database connectivity from Griffin.{color} > {color:#172b4d}Also, please share if there are any documentations available > to achieve the same.{color} > -- This message was sent by Atlassian Jira (v8.20.1#820001)