[REPORT] HttpComponents
## Description: - The Apache HttpComponents project is responsible for creating and maintaining a toolset of low-level Java components focused on HTTP and associated protocols ## Issues: - There are no issues requiring board attention at this time. - There are several casual contributors to the project. We are in the process of evaluating one contributor for committership. A formal vote is expected soon ## Activity: - The repos got migrated to GitBox. The team is still working toward completing HttpCore 5.0 and HttpClient 5.0 BETA development phase and reaching GA milestone. ## Health report: - Overall the project remains active. Although established in late 2007 the project remains stable and active as seen by JIRA and Emails. - The number of emails could be seen as low, but it is stable like the state of the project, and we still have interested people contributing. ## PMC changes: - Currently 9 PMC members. - No new PMC members added in the last 3 months - Last PMC addition was Michael Osipov on Mon Aug 24 2015 ## Committer base changes: - Currently 19 committers. - No new committers added in the last 3 months - Last committer addition was Ryan Schmitt at Wed Nov 14 2018 ## Releases: - HttpClient 4.5.7 GA was released on Thu Jan 24 2019 - HttpClient 5.0-beta3 was released on Mon Dec 17 2018 - HttpCore 4.4.11 GA was released on Mon Jan 21 2019 - HttpCore 5.0-beta6 was released on Thu Dec 06 2018 -- Asankha C. Perera SLAppForge https://slappforge.com AdroitLogic, https://www.adroitlogic.com https://medium.com/@asankha - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] rschmitt commented on a change in pull request #106: Immutable HttpEntity classes
rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256973407
##
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
##
@@ -91,33 +100,33 @@ private void createBytes(final Serializable ser) throws
IOException {
}
@Override
-public InputStream getContent() throws IOException, IllegalStateException {
+public final InputStream getContent() throws IOException,
IllegalStateException {
if (this.objSer == null) {
createBytes(this.objRef);
Review comment:
Based on this (apparent) lazy initialization path, this class is not
currently immutable in any sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] rschmitt commented on a change in pull request #106: Immutable HttpEntity classes
rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256969017
##
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/InputStreamEntity.java
##
@@ -31,87 +31,52 @@
import java.io.InputStream;
import java.io.OutputStream;
+import org.apache.hc.core5.annotation.Contract;
+import org.apache.hc.core5.annotation.ThreadingBehavior;
import org.apache.hc.core5.http.ContentType;
import org.apache.hc.core5.util.Args;
/**
- * A streamed, non-repeatable entity that obtains its content from
- * an {@link InputStream}.
+ * A streamed, non-repeatable entity that obtains its content from an {@link
InputStream}.
*
* @since 4.0
*/
+@Contract(threading = ThreadingBehavior.IMMUTABLE_CONDITIONAL)
Review comment:
I don't really see how an `InputStream` wrapper could be regarded as
immutable, unless `IMMUTABLE_CONDITIONAL` specifically means "immutable" in the
Java Memory Model sense (all final fields, not made visible to other threads
during construction), which has significantly weaker guarantees than true
immutability.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] rschmitt commented on a change in pull request #106: Immutable HttpEntity classes
rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256966826
##
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/ByteBufferEntity.java
##
@@ -34,85 +34,79 @@
import java.nio.channels.Channels;
import java.nio.channels.WritableByteChannel;
+import org.apache.hc.core5.annotation.Contract;
+import org.apache.hc.core5.annotation.ThreadingBehavior;
import org.apache.hc.core5.http.ContentType;
import org.apache.hc.core5.util.Args;
/**
* An entity that delivers the contents of a {@link ByteBuffer}.
*/
+@Contract(threading = ThreadingBehavior.IMMUTABLE_CONDITIONAL)
Review comment:
I think this is a stretch, considering that you're mutating the supplied
`ByteBuffer` without duplicating it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] rschmitt commented on a change in pull request #106: Immutable HttpEntity classes
rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256972993
##
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
##
@@ -59,29 +62,35 @@
*stored in an internal buffer
* @throws IOException in case of an I/O error
*/
-public SerializableEntity(final Serializable ser, final boolean bufferize)
throws IOException {
-super();
+public SerializableEntity(
+final Serializable ser, final boolean bufferize, final ContentType
contentType,
+final String contentEncoding) throws IOException {
+super(contentType, contentEncoding);
Args.notNull(ser, "Source object");
if (bufferize) {
createBytes(ser);
+this.objRef = null;
Review comment:
I don't understand what's happening here. Why are you nulling this field out
after `createBytes` has assigned it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
Re: Re: Re: Formal code reviews and PRs
On Thu, 2019-02-14 at 16:27 +0100, Michael Osipov wrote: > > Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr > > Von: "Oleg Kalnichevski" > > An: "HttpComponents Project" > > Betreff: Re: Re: Formal code reviews and PRs > > > > On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote: > > > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > > > > > That sounds nice. > > > > > > > > > > Can we agree to add trivial changes to master directly, for > > > > > example, > > > > > if I > > > > > want to Javadoc a previously undocumented method? > > > > > > > > > > > > > I disagree rather strongly, especially if we want to keep > > > > master > > > > branch > > > > protected. Even trivial changes can break the build and > > > > introduce > > > > style > > > > violations. > > > > > > That's fair. That would mean we have a multibranch pipeline setup > > > on > > > Jenkins. > > > Do we? If it doesn't fail there, it should be good for a PR or > > > merge. > > > totally > > > fine by me. > > > > > > > We have got Travis-CI right now and the multibranch pipeline setup > > on > > ASF Jenkins is something I would like to look into. > > You shall be able to shamelessly steal the config from Maven TLP and > modify it. > Shameless stealing is what I intend to do when it comes to good practices in CI. Oleg > - > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
Re: Re: Re: Formal code reviews and PRs
> Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr > Von: "Oleg Kalnichevski" > An: "HttpComponents Project" > Betreff: Re: Re: Formal code reviews and PRs > > On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote: > > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > > > > That sounds nice. > > > > > > > > Can we agree to add trivial changes to master directly, for > > > > example, > > > > if I > > > > want to Javadoc a previously undocumented method? > > > > > > > > > > I disagree rather strongly, especially if we want to keep master > > > branch > > > protected. Even trivial changes can break the build and introduce > > > style > > > violations. > > > > That's fair. That would mean we have a multibranch pipeline setup on > > Jenkins. > > Do we? If it doesn't fail there, it should be good for a PR or merge. > > totally > > fine by me. > > > > We have got Travis-CI right now and the multibranch pipeline setup on > ASF Jenkins is something I would like to look into. You shall be able to shamelessly steal the config from Maven TLP and modify it. - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
Re: Re: Formal code reviews and PRs
On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote: > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > > > That sounds nice. > > > > > > Can we agree to add trivial changes to master directly, for > > > example, > > > if I > > > want to Javadoc a previously undocumented method? > > > > > > > I disagree rather strongly, especially if we want to keep master > > branch > > protected. Even trivial changes can break the build and introduce > > style > > violations. > > That's fair. That would mean we have a multibranch pipeline setup on > Jenkins. > Do we? If it doesn't fail there, it should be good for a PR or merge. > totally > fine by me. > We have got Travis-CI right now and the multibranch pipeline setup on ASF Jenkins is something I would like to look into. Oleg > > > Gary > > > > > > On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski < > > > ol...@apache.org> > > > wrote: > > > > > > > Folks > > > > > > > > Since HttpComponents migration to GitBox I have been committing > > > > all > > > > my > > > > code changes to a feature branch and leaving them sit there for > > > > a > > > > day > > > > or two prior to merging them to a development branch (master or > > > > stable > > > > version branches). > > > > > > > > If there is anyone interested in doing formal code reviews of > > > > my > > > > changes please do let me know. I'll start raising PRs at GitHub > > > > for > > > > all > > > > my feature branches. > > > > > > > > Cheers > > > > > > > > Oleg > > > > > > > > > > > > - > > > > > > > > > > > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
Re: Re: Formal code reviews and PRs
> On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > > That sounds nice. > > > > Can we agree to add trivial changes to master directly, for example, > > if I > > want to Javadoc a previously undocumented method? > > > > I disagree rather strongly, especially if we want to keep master branch > protected. Even trivial changes can break the build and introduce style > violations. That's fair. That would mean we have a multibranch pipeline setup on Jenkins. Do we? If it doesn't fail there, it should be good for a PR or merge. totally fine by me. > > Gary > > > > On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski > > wrote: > > > > > Folks > > > > > > Since HttpComponents migration to GitBox I have been committing all > > > my > > > code changes to a feature branch and leaving them sit there for a > > > day > > > or two prior to merging them to a development branch (master or > > > stable > > > version branches). > > > > > > If there is anyone interested in doing formal code reviews of my > > > changes please do let me know. I'll start raising PRs at GitHub for > > > all > > > my feature branches. > > > > > > Cheers > > > > > > Oleg > > > > > > > > > - > > > > > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
Re: Re: Formal code reviews and PRs
Absolutely! > Gesendet: Donnerstag, 14. Februar 2019 um 15:14 Uhr > Von: "Gary Gregory" > An: "HttpComponents Project" > Betreff: Re: Formal code reviews and PRs > > That sounds nice. > > Can we agree to add trivial changes to master directly, for example, if I > want to Javadoc a previously undocumented method? > > Gary > > On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski wrote: > > > Folks > > > > Since HttpComponents migration to GitBox I have been committing all my > > code changes to a feature branch and leaving them sit there for a day > > or two prior to merging them to a development branch (master or stable > > version branches). > > > > If there is anyone interested in doing formal code reviews of my > > changes please do let me know. I'll start raising PRs at GitHub for all > > my feature branches. > > > > Cheers > > > > Oleg > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] ok2c commented on a change in pull request #136: HTTPCLIENT-1968
ok2c commented on a change in pull request #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#discussion_r256863307
##
File path: httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java
##
@@ -45,6 +46,51 @@
*/
public class URIUtils {
+/**
+ * Flags that control how URI is being rewritten.
+ *
+ * @since 5.7.8
+ */
+public enum UriFlag {
+DROP_FRAGMENT,
+NORMALIZE
+}
+
+/**
+ * Empty set of uri flags.
+ *
+ * @since 5.7.8
+ */
+public static final EnumSet NO_FLAGS =
EnumSet.noneOf(UriFlag.class);
+
+/**
+ * Set of uri flags containing {@link UriFlag#DROP_FRAGMENT}.
+ *
+ * @since 5.7.8
+ */
+public static final EnumSet DROP_FRAGMENT =
EnumSet.of(UriFlag.DROP_FRAGMENT);
+
+/**
+ * Set of uri flags containing {@link UriFlag#NORMALIZE}.
+ *
+ * @since 5.7.8
+ */
+public static final EnumSet NORMALIZE =
EnumSet.of(UriFlag.NORMALIZE);
+
+/**
+ * Set of uri flags containing {@link UriFlag#DROP_FRAGMENT} and {@link
UriFlag#NORMALIZE}.
+ *
+ * @since 5.7.8
+ */
+public static final EnumSet DROP_FRAGMENT_AND_NORMALIZE =
EnumSet.of(UriFlag.DROP_FRAGMENT, UriFlag.NORMALIZE);
+
+/**
+ * These uri flags are to be used in deprecated codebase only, and are set
to mimic "legacy" behaviour.
+ *
+ * @since 5.7.8
+ */
+public static final EnumSet LEGACY_BEHAVIOR =
DROP_FRAGMENT_AND_NORMALIZE;
Review comment:
@cstamas Could the term `LEGACY` be avoided here? As far as I am concerned
this is the intended default behavior.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] ok2c commented on a change in pull request #136: HTTPCLIENT-1968
ok2c commented on a change in pull request #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#discussion_r256864710
##
File path:
httpclient/src/main/java/org/apache/http/impl/client/DefaultRedirectStrategy.java
##
@@ -183,10 +190,23 @@ public URI getLocationURI(
/**
* @since 4.1
+ * @deprecated (4.5.8) use {@link #createLocationURI(String, boolean)}
*/
+@Deprecated
protected URI createLocationURI(final String location) throws
ProtocolException {
+return SENTINEL_URI;
+}
+
+/**
+ * @since 4.5.8
+ */
+protected URI createLocationURI(final String location, final boolean
normalizeUri) throws ProtocolException {
Review comment:
@cstamas I think no normalization is required here at this point. The
decision whether of not the request URI requires normalization can be deferred
until the request execution. This would eliminate the need for
`createLocationURI` deprecation, the sentinel URI and lots of other things.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
Re: Formal code reviews and PRs
On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > That sounds nice. > > Can we agree to add trivial changes to master directly, for example, > if I > want to Javadoc a previously undocumented method? > I disagree rather strongly, especially if we want to keep master branch protected. Even trivial changes can break the build and introduce style violations. Oleg > Gary > > On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski > wrote: > > > Folks > > > > Since HttpComponents migration to GitBox I have been committing all > > my > > code changes to a feature branch and leaving them sit there for a > > day > > or two prior to merging them to a development branch (master or > > stable > > version branches). > > > > If there is anyone interested in doing formal code reviews of my > > changes please do let me know. I'll start raising PRs at GitHub for > > all > > my feature branches. > > > > Cheers > > > > Oleg > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-572) Move examples to the src/test folders for each module
[ https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768297#comment-16768297 ] ASF subversion and git services commented on HTTPCORE-572: -- Commit 6b5d218c440804abb7663c7b88e58629e630f392 in httpcomponents-core's branch refs/heads/master from Gary Gregory [ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=6b5d218 ] Merge pull request #105 from apache/HTTPCORE-572 [HTTPCORE-572] Move examples to the src/test folders for each module. > Move examples to the src/test folders for each module > - > > Key: HTTPCORE-572 > URL: https://issues.apache.org/jira/browse/HTTPCORE-572 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: Examples >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > I think it would be better if our examples lived in a .examples. package > under the src/test folder. The advantages are: > > - Examples would always be compiled by Maven and IDEs > - Examples would end up living in the test jar, which would be handy for > testing certain use-cases. In my case, testing using our static file server > and proxy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
Re: Formal code reviews and PRs
That sounds nice. Can we agree to add trivial changes to master directly, for example, if I want to Javadoc a previously undocumented method? Gary On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski wrote: > Folks > > Since HttpComponents migration to GitBox I have been committing all my > code changes to a feature branch and leaving them sit there for a day > or two prior to merging them to a development branch (master or stable > version branches). > > If there is anyone interested in doing formal code reviews of my > changes please do let me know. I'll start raising PRs at GitHub for all > my feature branches. > > Cheers > > Oleg > > > - > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > >
[jira] [Commented] (HTTPCORE-572) Move examples to the src/test folders for each module
[ https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768296#comment-16768296 ] ASF subversion and git services commented on HTTPCORE-572: -- Commit 916ebd6bd658d5e38aadedd819eae390e50bd0c5 in httpcomponents-core's branch refs/heads/master from Gary Gregory [ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=916ebd6 ] [HTTPCORE-572] Move examples to the src/test folders for each module. > Move examples to the src/test folders for each module > - > > Key: HTTPCORE-572 > URL: https://issues.apache.org/jira/browse/HTTPCORE-572 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: Examples >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > I think it would be better if our examples lived in a .examples. package > under the src/test folder. The advantages are: > > - Examples would always be compiled by Maven and IDEs > - Examples would end up living in the test jar, which would be handy for > testing certain use-cases. In my case, testing using our static file server > and proxy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-572) Move examples to the src/test folders for each module
[ https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768298#comment-16768298 ] ASF subversion and git services commented on HTTPCORE-572: -- Commit 6b5d218c440804abb7663c7b88e58629e630f392 in httpcomponents-core's branch refs/heads/master from Gary Gregory [ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=6b5d218 ] Merge pull request #105 from apache/HTTPCORE-572 [HTTPCORE-572] Move examples to the src/test folders for each module. > Move examples to the src/test folders for each module > - > > Key: HTTPCORE-572 > URL: https://issues.apache.org/jira/browse/HTTPCORE-572 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: Examples >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > I think it would be better if our examples lived in a .examples. package > under the src/test folder. The advantages are: > > - Examples would always be compiled by Maven and IDEs > - Examples would end up living in the test jar, which would be handy for > testing certain use-cases. In my case, testing using our static file server > and proxy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] garydgregory merged pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module.
garydgregory merged pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module. URL: https://github.com/apache/httpcomponents-core/pull/105 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] ok2c commented on issue #136: HTTPCLIENT-1968
ok2c commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463641012 @cstamas One of `TestFutureRequestExecutionService` tests appears to fail intermittently due to a race condition. It is certainly unrelated to your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-572) Move examples to the src/test folders for each module
[ https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768284#comment-16768284 ] ASF subversion and git services commented on HTTPCORE-572: -- Commit 916ebd6bd658d5e38aadedd819eae390e50bd0c5 in httpcomponents-core's branch refs/heads/HTTPCORE-572 from Gary Gregory [ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=916ebd6 ] [HTTPCORE-572] Move examples to the src/test folders for each module. > Move examples to the src/test folders for each module > - > > Key: HTTPCORE-572 > URL: https://issues.apache.org/jira/browse/HTTPCORE-572 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: Examples >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > I think it would be better if our examples lived in a .examples. package > under the src/test folder. The advantages are: > > - Examples would always be compiled by Maven and IDEs > - Examples would end up living in the test jar, which would be handy for > testing certain use-cases. In my case, testing using our static file server > and proxy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module.
garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move
examples to the src/test folders for each module.
URL:
https://github.com/apache/httpcomponents-core/pull/105#discussion_r256826050
##
File path: pom.xml
##
@@ -185,7 +185,15 @@
${basedir}/target/site/examples
- src/examples
+
src/test/java/org/apache/hc/core5/http/examples
Review comment:
I must have messed up the squashing. I think it is easier to squash in GH
when you merge. Can we do it that way?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-572) Move examples to the src/test folders for each module
[ https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768172#comment-16768172 ] ASF subversion and git services commented on HTTPCORE-572: -- Commit 26f9b594b8d1137709d764bac4cf44df555d29a1 in httpcomponents-core's branch refs/heads/HTTPCORE-572 from Gary Gregory [ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=26f9b59 ] Merge branch 'HTTPCORE-572' of https://gitbox.apache.org/repos/asf/httpcomponents-core into HTTPCORE-572 > Move examples to the src/test folders for each module > - > > Key: HTTPCORE-572 > URL: https://issues.apache.org/jira/browse/HTTPCORE-572 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: Examples >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > I think it would be better if our examples lived in a .examples. package > under the src/test folder. The advantages are: > > - Examples would always be compiled by Maven and IDEs > - Examples would end up living in the test jar, which would be handy for > testing certain use-cases. In my case, testing using our static file server > and proxy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-572) Move examples to the src/test folders for each module
[ https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768170#comment-16768170 ] ASF subversion and git services commented on HTTPCORE-572: -- Commit 161cd8b0d544b5cf7f8473f07c8b01580319e4a7 in httpcomponents-core's branch refs/heads/HTTPCORE-572 from Gary Gregory [ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=161cd8b ] [HTTPCORE-572] Move examples to the src/test folders for each module. > Move examples to the src/test folders for each module > - > > Key: HTTPCORE-572 > URL: https://issues.apache.org/jira/browse/HTTPCORE-572 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: Examples >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > I think it would be better if our examples lived in a .examples. package > under the src/test folder. The advantages are: > > - Examples would always be compiled by Maven and IDEs > - Examples would end up living in the test jar, which would be handy for > testing certain use-cases. In my case, testing using our static file server > and proxy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-572) Move examples to the src/test folders for each module
[ https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768171#comment-16768171 ] ASF subversion and git services commented on HTTPCORE-572: -- Commit 26f9b594b8d1137709d764bac4cf44df555d29a1 in httpcomponents-core's branch refs/heads/HTTPCORE-572 from Gary Gregory [ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=26f9b59 ] Merge branch 'HTTPCORE-572' of https://gitbox.apache.org/repos/asf/httpcomponents-core into HTTPCORE-572 > Move examples to the src/test folders for each module > - > > Key: HTTPCORE-572 > URL: https://issues.apache.org/jira/browse/HTTPCORE-572 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: Examples >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > I think it would be better if our examples lived in a .examples. package > under the src/test folder. The advantages are: > > - Examples would always be compiled by Maven and IDEs > - Examples would end up living in the test jar, which would be handy for > testing certain use-cases. In my case, testing using our static file server > and proxy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas edited a comment on issue #136: HTTPCLIENT-1968
cstamas edited a comment on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463617176 @ok2c Seems Travis build failed but it is still OK for me (and Travis was OK before squash), is there some concurrency problem in UTs? ``` [INFO] --- maven-bundle-plugin:3.5.1:install (default-install) @ httpclient-osgi --- [INFO] Installing org/apache/httpcomponents/httpclient-osgi/4.5.8-SNAPSHOT/httpclient-osgi-4.5.8-SNAPSHOT.jar [INFO] Writing OBR metadata [INFO] [INFO] Reactor Summary for Apache HttpComponents Client 4.5.8-SNAPSHOT: [INFO] [INFO] Apache HttpComponents Client ... SUCCESS [ 2.315 s] [INFO] Apache HttpClient .. SUCCESS [ 31.340 s] [INFO] Apache HttpClient Mime . SUCCESS [ 2.958 s] [INFO] Apache HttpClient Fluent API ... SUCCESS [ 3.021 s] [INFO] Apache HttpClient Cache SUCCESS [ 12.242 s] [INFO] Apache HttpClient Windows features . SUCCESS [ 2.831 s] [INFO] Apache HttpClient OSGi bundle .. SUCCESS [ 4.976 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:00 min [INFO] Finished at: 2019-02-14T13:55:32+01:00 [INFO] cstamas@Urnebes ~/Worx/apache-httpcomponents/httpcomponents-client (HTTPCLIENT-1968)$ ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463614970 @ok2c Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] ok2c commented on issue #136: HTTPCLIENT-1968
ok2c commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463603475 @cstamas Could you please squash all commits into a single one? I will go over the changes one more time and will merge the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463594991 @ok2c Sure, but that would mean that we need to reimplement `java.net.URI#resolve(java.net.URI)` in body of `org.apache.http.client.utils.URIUtils#resolve(java.net.URI, java.net.URI)` method, something I see out of the scope of this PR. IMO, for now this PR is ok, and allows people to step over and upgrade their client. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] ok2c commented on issue #136: HTTPCLIENT-1968
ok2c commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463588140 @cstamas One can get actual `RequestConfig` settings from the execution `HttpContext` at any point of request execution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463586677 Not a complete solution: IF relative redirects happens (and are allowed), `java.net.URI#resolve(java.net.URI)` is being used that WILL normalize, despite the setting in `RequestConfig` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on a change in pull request #136: HTTPCLIENT-1968
cstamas commented on a change in pull request #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#discussion_r256782190
##
File path: httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java
##
@@ -129,7 +129,8 @@ public static URI createURI(
public static URI rewriteURI(
final URI uri,
final HttpHost target,
-final boolean dropFragment) throws URISyntaxException {
+final boolean dropFragment,
Review comment:
Ack, that would really pave the path to have more versatile uri utils
will do
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] ok2c commented on issue #105: [HTTPCORE-572] Move examples to the src/test folders for each module.
ok2c commented on issue #105: [HTTPCORE-572] Move examples to the src/test folders for each module. URL: https://github.com/apache/httpcomponents-core/pull/105#issuecomment-463533637 @garydgregory Looks good. Could you please squash the commit though? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
