Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2016-06-20 Thread Takanobu Asanuma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40867/#review138763
---




ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1992)


I forgot to add a log when useBypass is true. I will add it in the next 
patch.


- Takanobu Asanuma


On 6月 21, 2016, 2:10 a.m., Takanobu Asanuma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40867/
> ---
> 
> (Updated 6月 21, 2016, 2:10 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> This is a WIP patch for HIVE-11527
> 
> * I added a new configuration whose name is 
> hive.server2.webhdfs.bypass.enabled. The default is false. When this value is 
> true, clients use the bypass.
> 
> * I still have not considered security such as Kerberos and SSL at present.
> 
> * I have not implement Statement#setFetchSize for bypass yet.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1e0ffa4 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java 
> 84644d1 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java 
> 0c313a2 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java 
> 637e51a 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 8ac040e 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 92fdbca 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 2263192 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java dff1815 
>   service-rpc/if/TCLIService.thrift 5a9a785 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h d23b3cd 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 0f53cb2 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java
>  31472c8 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java
>  7101fa5 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java
>  1aa3f94 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java
>  c6279dc 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java
>  1eaeee6 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java
>  14d50ed 
>   service-rpc/src/gen/thrift/gen-php/Types.php a6a257f 
>   service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py fcd330f 
>   service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 71148a0 
>   service/src/java/org/apache/hive/service/cli/CLIService.java ed52b4a 
>   service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java bfd7135 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> d48b92c 
>   
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 
> 2f18231 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 3bf40eb 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 
> 78ff388 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 7341635 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 8bc3d94 
> 
> Diff: https://reviews.apache.org/r/40867/diff/
> 
> 
> Testing
> ---
> 
> I have tested few simple queries and they worked well. But I think there are 
> some problems for some queries. I'm going to test more queries and fix bugs. 
> I'm also going to add unit tests.
> 
> 
> Thanks,
> 
> Takanobu Asanuma
> 
>

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2016-06-20 Thread Takanobu Asanuma 


> On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote:
> >

I modified some codes in the latest patch.


> On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 57
> > 
> >
> > Use ReflectionUtils that exists within Hive ?
> > The hadoop one is not a public class.
> > I know that we use the hadoop one in other parts, but that is something 
> > we should move away from.

I fixed it to use Hive ReflectionUtils.


> On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 536
> > 
> >
> > Wouldn't it be more performant to use LazyBinarySimpleSerde ?

Excuse me, what is LazyBinarySimpleSerde?


> On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 1972
> > 
> >
> > We should log if the bypass is kicking in or not , and the reason for 
> > disabling it.
> > There are so many cases where it gets disabled, it would be hard to 
> > debug in a production environment what the reason is.

I fixed it to log the reasons. Since I am not a native speaker of English, 
please let me know if my English expressions are mistaken.


> On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote:
> > service-rpc/if/TCLIService.thrift, line 277
> > 
> >
> > There is already typeDesc, why do we need typeName

It is to handle complex column types. typeDesc does not have enough infomation 
for complex column types. For example, "struct" is regarded as 
"struct". On the other hand, typename has detailed infomation as is.


- Takanobu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40867/#review138347
---


On 6月 21, 2016, 2:10 a.m., Takanobu Asanuma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40867/
> ---
> 
> (Updated 6月 21, 2016, 2:10 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> This is a WIP patch for HIVE-11527
> 
> * I added a new configuration whose name is 
> hive.server2.webhdfs.bypass.enabled. The default is false. When this value is 
> true, clients use the bypass.
> 
> * I still have not considered security such as Kerberos and SSL at present.
> 
> * I have not implement Statement#setFetchSize for bypass yet.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1e0ffa4 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java 
> 84644d1 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java 
> 0c313a2 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java 
> 637e51a 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 8ac040e 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 92fdbca 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 2263192 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java dff1815 
>   service-rpc/if/TCLIService.thrift 5a9a785 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h d23b3cd 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 0f53cb2 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java
>  31472c8 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java
>  7101fa5 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java
>  1aa3f94 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java
>  c6279dc 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java
>  1eaeee6 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java
>  14d50ed 
>   service-rpc/src/gen/thrift/gen-php/Types.php a6a257f 
>   service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py fcd330f 
>   service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 71148a0 
>   service/src/java/org/apache/hive/service/cli/CLIService.java ed52b4a 
>   service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java bfd7135 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> d48b92c 
>   
>

Re: Review Request 48500: HIVE-13982

2016-06-20 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48500/
---

(Updated June 21, 2016, 3:44 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-13982
https://issues.apache.org/jira/browse/HIVE-13982


Repository: hive-git


Description
---

HIVE-13982


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java
 9cb62c8b4cf16f0d39a8184a0df52dc6e5dea458 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelCollationPropagator.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
 353d8db41af10512c94c0700a9bb06a07d660190 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForASTConv.java
 1a543fb1c8a9c2fb5b89aba211f0dd8910aeb048 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java
 1c3eb8155defa99a223ccf4ee4b072abb40a 
  ql/src/test/queries/clientpositive/limit_pushdown2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/reduce_deduplicate_extended2.q 
PRE-CREATION 
  ql/src/test/results/clientpositive/bucket_groupby.q.out 
867fad43686d69dfd77cc5accc5d9d09f4364301 
  ql/src/test/results/clientpositive/limit_pushdown2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/lineage3.q.out 
12ae13e388b3cb9c051cb419b75682fa4296d211 
  ql/src/test/results/clientpositive/perf/query45.q.out 
04f9b02b019b6cf591dee48964a73fdb4a4b285f 
  ql/src/test/results/clientpositive/reduce_deduplicate_extended2.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/vectorization_14.q.out 
cb3d9a4da84a379e00550ce7e31893b304d5e560 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out 
1871c7e443cf775b09badc4cbf4b86e23ad9e525 
  ql/src/test/results/clientpositive/tez/explainuser_2.q.out 
553066039881f225634c08d93a9054df5636e5d2 
  ql/src/test/results/clientpositive/tez/vector_groupby_reduce.q.out 
7f00b064e5a91b45282823e2725e11ab7f508b01 
  ql/src/test/results/clientpositive/tez/vectorization_14.q.out 
2a598332207f4540defa21a107642aa0502e1a58 
  ql/src/test/results/clientpositive/vector_groupby_reduce.q.out 
bc23b365b02b505d0f8e79cdacca3449bf46ead3 
  ql/src/test/results/clientpositive/vectorization_14.q.out 
6d4f13a23de5c184cd100af07ac19f24ba9fac4a 

Diff: https://reviews.apache.org/r/48500/diff/


Testing
---


Thanks,

Jesús Camacho Rodríguez

[jira] [Created] (HIVE-14069) update curator version to 2.10.0

2016-06-20 Thread Thejas M Nair (JIRA) 
Thejas M Nair created HIVE-14069:


 Summary: update curator version to 2.10.0 
 Key: HIVE-14069
 URL: https://issues.apache.org/jira/browse/HIVE-14069
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2, Metastore
Reporter: Thejas M Nair
Assignee: Thejas M Nair


curator-2.10.0 has several bug fixes over current version (2.6.0), updating 
would help improve stability.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

2016-06-20 Thread Takanobu Asanuma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40867/
---

(Updated 6月 21, 2016, 2:10 a.m.)


Review request for hive.


Changes
---

I updated the patch based on Thejas's advice.


Repository: hive-git


Description
---

This is a WIP patch for HIVE-11527

* I added a new configuration whose name is 
hive.server2.webhdfs.bypass.enabled. The default is false. When this value is 
true, clients use the bypass.

* I still have not considered security such as Kerberos and SSL at present.

* I have not implement Statement#setFetchSize for bypass yet.


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1e0ffa4 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java 
84644d1 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java 
0c313a2 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java 
637e51a 
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 8ac040e 
  jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 92fdbca 
  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 2263192 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java dff1815 
  service-rpc/if/TCLIService.thrift 5a9a785 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h d23b3cd 
  service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 0f53cb2 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java
 31472c8 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java
 7101fa5 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java
 1aa3f94 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java
 c6279dc 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java
 1eaeee6 
  
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java
 14d50ed 
  service-rpc/src/gen/thrift/gen-php/Types.php a6a257f 
  service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py fcd330f 
  service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 71148a0 
  service/src/java/org/apache/hive/service/cli/CLIService.java ed52b4a 
  service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java bfd7135 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java d48b92c 
  service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 
2f18231 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
3bf40eb 
  service/src/java/org/apache/hive/service/cli/session/HiveSession.java 78ff388 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
7341635 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
8bc3d94 

Diff: https://reviews.apache.org/r/40867/diff/


Testing
---

I have tested few simple queries and they worked well. But I think there are 
some problems for some queries. I'm going to test more queries and fix bugs. 
I'm also going to add unit tests.


Thanks,

Takanobu Asanuma

[jira] [Created] (HIVE-14068) make more effort to find hive-site.xml

2016-06-20 Thread Sergey Shelukhin (JIRA) 
Sergey Shelukhin created HIVE-14068:
---

 Summary: make more effort to find hive-site.xml
 Key: HIVE-14068
 URL: https://issues.apache.org/jira/browse/HIVE-14068
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin


It pretty much doesn't make sense to run Hive w/o the config, so we should make 
more effort to find one if it's missing on the classpath, or the classloader 
does not return it for some reason (e.g. classloader ignores some permission 
issues; explicitly looking for the file may expose them better)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14067) Rename pendingCount to activeCalls in HiveSessionImpl for easier understanding.

2016-06-20 Thread zhihai xu (JIRA) 
zhihai xu created HIVE-14067:


 Summary: Rename pendingCount to activeCalls in HiveSessionImpl  
for easier understanding.
 Key: HIVE-14067
 URL: https://issues.apache.org/jira/browse/HIVE-14067
 Project: Hive
  Issue Type: Improvement
  Components: HiveServer2
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Trivial


Rename pendingCount to activeCalls in HiveSessionImpl  for easier understanding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14066) LLAP: Orc encoded data reader should support complex types

2016-06-20 Thread Prasanth Jayachandran (JIRA) 
Prasanth Jayachandran created HIVE-14066:


 Summary: LLAP: Orc encoded data reader should support complex types
 Key: HIVE-14066
 URL: https://issues.apache.org/jira/browse/HIVE-14066
 Project: Hive
  Issue Type: Bug
Affects Versions: 2.2.0
Reporter: Prasanth Jayachandran
Assignee: Prasanth Jayachandran


Currently LLAP encoded data reader does not support complex types. Now that ORC 
supports reading complex vectors we should support in LLAP as well. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14065) Provide an API for making Hive read-only for a short period

2016-06-20 Thread Colin Patrick McCabe (JIRA) 
Colin Patrick McCabe created HIVE-14065:
---

 Summary: Provide an API for making Hive read-only for a short 
period
 Key: HIVE-14065
 URL: https://issues.apache.org/jira/browse/HIVE-14065
 Project: Hive
  Issue Type: Improvement
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe


HIVE-7973 added a notification log which allows clients to do incremental 
replication of the Hive metastore.  However, it is a challenge to get the 
initial state of the Hive database.  Using existing APIs may give us an 
inconsistent state.  For example, if a Hive table is renamed while we're 
loading all tables, we may miss that information.

The easiest way to fix this would be to provide an API for making Hive 
read-only for a short period.  This locking API would come with a timeout so 
that if the locker failed, the system would not stay down.  It would return an 
ID which uniquely identified the lock instance.  The read-only lock itself 
could be implemented by taking all the ZooKeeper locks.  The RPC for removing 
the lock would return back a status indicating whether the lock had timed out 
before being removed or not.  If it had timed out, we could retry our snapshot 
loading process with a longer timeout period.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14063) beeline to auto connect to the HiveServer2

2016-06-20 Thread Vihang Karajgaonkar (JIRA) 
Vihang Karajgaonkar created HIVE-14063:
--

 Summary: beeline to auto connect to the HiveServer2
 Key: HIVE-14063
 URL: https://issues.apache.org/jira/browse/HIVE-14063
 Project: Hive
  Issue Type: Improvement
  Components: Beeline
Reporter: Vihang Karajgaonkar
Assignee: Vihang Karajgaonkar
Priority: Minor


Currently one has to give an jdbc:hive2 url in order for Beeline to connect a 
hiveserver2 instance. It would be great if Beeline can get the info somehow 
(from a properties file at a well-known location?) and connect automatically if 
user doesn't specify such a url. If the properties file is not present, then 
beeline would expect user to provide the url and credentials using !connect or 
./beeline -u .. commands

While Beeline is flexible (being a mere JDBC client), most environments would 
have just a single HS2. Having users to manually connect into this via either 
"beeline ~/.propsfile" or -u or !connect statements is lowering the experience 
part.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14064) beeline to auto connect to the HiveServer2

2016-06-20 Thread Vihang Karajgaonkar (JIRA) 
Vihang Karajgaonkar created HIVE-14064:
--

 Summary: beeline to auto connect to the HiveServer2
 Key: HIVE-14064
 URL: https://issues.apache.org/jira/browse/HIVE-14064
 Project: Hive
  Issue Type: Improvement
  Components: Beeline
Reporter: Vihang Karajgaonkar
Assignee: Vihang Karajgaonkar
Priority: Minor


Currently one has to give an jdbc:hive2 url in order for Beeline to connect a 
hiveserver2 instance. It would be great if Beeline can get the info somehow 
(from a properties file at a well-known location?) and connect automatically if 
user doesn't specify such a url. If the properties file is not present, then 
beeline would expect user to provide the url and credentials using !connect or 
./beeline -u .. commands

While Beeline is flexible (being a mere JDBC client), most environments would 
have just a single HS2. Having users to manually connect into this via either 
"beeline ~/.propsfile" or -u or !connect statements is lowering the experience 
part.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14062) Changes from HIVE-13502 overwritten by HIVE-13566

2016-06-20 Thread Naveen Gangam (JIRA) 
Naveen Gangam created HIVE-14062:


 Summary: Changes from HIVE-13502 overwritten by HIVE-13566
 Key: HIVE-14062
 URL: https://issues.apache.org/jira/browse/HIVE-14062
 Project: Hive
  Issue Type: Bug
  Components: Beeline
Affects Versions: 2.1.0
Reporter: Naveen Gangam
Assignee: Naveen Gangam


Appears that changes from HIVE-13566 overwrote the changes from HIVE-13502. I 
will confirm with the author that it was inadvertent before I re-add it. Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14061) Add unit test for kerberos support in Hive streaming

2016-06-20 Thread Wei Zheng (JIRA) 
Wei Zheng created HIVE-14061:


 Summary: Add unit test for kerberos support in Hive streaming
 Key: HIVE-14061
 URL: https://issues.apache.org/jira/browse/HIVE-14061
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 2.2.0
Reporter: Wei Zheng
Assignee: Wei Zheng






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14060) Hive: Remove bogus "localhost" from Hive splits

2016-06-20 Thread Gopal V (JIRA) 
Gopal V created HIVE-14060:
--

 Summary: Hive: Remove bogus "localhost" from Hive splits
 Key: HIVE-14060
 URL: https://issues.apache.org/jira/browse/HIVE-14060
 Project: Hive
  Issue Type: Bug
  Components: Tez
Affects Versions: 2.1.0, 2.2.0
Reporter: Gopal V
Assignee: Gopal V


On remote filesystems like Azure, GCP and S3, the splits contain a filler 
location of "localhost".

This is worse than having no location information at all - on large clusters 
yarn waits upto 200[1] seconds for heartbeat from "localhost" before allocating 
a container.

To speed up this process, the split affinity provider should scrub the bogus 
"localhost" from the locations and allow for the allocation of "*" containers 
instead on each heartbeat.

[1] - yarn.scheduler.capacity.node-locality-delay=40 x heartbeat of 5s



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 48771: HIVE-13590: Kerberized HS2 with LDAP auth enabled fails in multi-domain LDAP case

2016-06-20 Thread Sergio Pena 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48771/#review138670
---


Ship it!




Ship It!

- Sergio Pena


On June 16, 2016, 2:33 a.m., Chaoyu Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48771/
> ---
> 
> (Updated June 16, 2016, 2:33 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13590
> https://issues.apache.org/jira/browse/HIVE-13590
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Hive should not use Hadoop security (e.g. kerberos) related APIs such as 
> KerberosName etc to process user logged in via other SASL mechanism such as 
> LDAP.
> 
> 
> Diffs
> -
> 
>   
> itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcNonKrbSASLWithMiniKdc.java
>  1c1beda 
>   service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java ab8806c 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 8bc3d94 
>   
> shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
>  8a4786c 
> 
> Diff: https://reviews.apache.org/r/48771/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> PreCommit test
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-20 Thread Szehon Ho 


> On June 17, 2016, 10:20 p.m., Szehon Ho wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, 
> > line 3179
> > 
> >
> > I actually meant here to get rid of these checks as well (in the two 
> > checkLimitNumberOfPartitionByX methods)
> 
> Sergio Pena wrote:
> I did that before, but I prefered to not do the extra call to 
> 'get_num_partitions_by_filter' and 'get_num_partitions_by_expr' if partition 
> limit is not enabled. Any idea how to avoid it?

Ok, should we get rid of the check inside checkLImitNumberOfPartitions then?  
(if (!isPartitionLimitEnabled)) line 3196


- Szehon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48233/#review138113
---


On June 17, 2016, 3:18 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48233/
> ---
> 
> (Updated June 17, 2016, 3:18 p.m.)
> 
> 
> Review request for hive, Mohit Sabharwal and Naveen Gangam.
> 
> 
> Bugs: HIVE-13884
> https://issues.apache.org/jira/browse/HIVE-13884
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The patch verifies the # of partitions a table has before fetching any from 
> the metastore. I
> t checks that limit from 'hive.limit.query.max.table.partition'.
> 
> A limitation added here is that the variable must be on hive-site.xml in 
> order to work, and it does not accept to set this through beeline because 
> HiveMetaStore.java does not read the variables set through beeline. I think 
> it is better to keep it this way to avoid users changing the value on fly, 
> and crashing the metastore.
> 
> Another change is that EXPLAIN commands won't be executed either. EXPLAIN 
> commands need to fetch partitions in order to create the operator tree. If we 
> allow EXPLAIN to do that, then we may have the same OOM situations for large 
> partitions.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> cc950089cf52a0344e1be0c42309d521fb8cb4d6 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> c0827ea9d47e569d9697649a7e16d196de3de14d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
> c135179b97354108f842a5ca2de0c6f0ef28b7fc 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> da188d33d6194740ba9ecb37a6e533ecf1ec6906 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 
> a6d3f5385b33b8a4e31ee20ca5cb8f58c97c8702 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
> 31f0d7b89670b8a749bbe8a7ff2b4ff9f059a8e2 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  3152e77c3c7152ac4dbe7e779ce35f28044fe3c9 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  86a243609b23e2ca9bb8849f0da863a95e477d5c 
> 
> Diff: https://reviews.apache.org/r/48233/diff/
> 
> 
> Testing
> ---
> 
> Waiting for HiveQA.
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: [VOTE] Apache Hive 2.1.0 Release Candidate 3

2016-06-20 Thread Jesus Camacho Rodriguez 
Thanks to everyone who has tested the release candidate and given
their comments and votes.

The tally is as follows.

4 +1s:
Prasanth Jayachandran
Gunther Hagleitner
Sushanth Sowmyan
Jason Dere

No 0s or -1s.

Therefore I am delighted to announce that the proposal to release
Apache Hive 2.1.0 has passed! We'll now roll the release out to the
mirrors.

In addition, I have created HIVE-14059 to fix the issue with the
missing headers for the 2 files (thanks for catching that one
Sushanth).






On 6/17/16, 3:54 PM, "Jason Dere"  wrote:

>Checked signatures, ran build and a few tests.
>+1
>
>From: Sushanth Sowmyan 
>Sent: Friday, June 17, 2016 3:30 PM
>To: dev@hive.apache.org
>Subject: Re: [VOTE] Apache Hive 2.1.0 Release Candidate 3
>
>Actually, to be more explicit, per Thejas' case of the top level
>license taking precedence, this RC has my +1.
>
>On Fri, Jun 17, 2016 at 3:28 PM, Sushanth Sowmyan  wrote:
>> I will happily rescind my -1 and even convert it to a +1 if the top
>> level license does hold. I thought that the RAT check was a necessary
>> blocker.
>>
>> (Although, if the top level license does cover across the board, we
>> may want to open a new discussion on whether having a license
>> requirement for every source file is necessary in the first place, and
>> tweak the definition of the rat check so it does not fail it in this
>> case.)
>>
>> On Fri, Jun 17, 2016 at 3:20 PM, Thejas Nair  wrote:
>>> I don't think the missing headers for 2 files mandates a respin of
>>> this RC .  It is not really a case of 'incompatible' license or code
>>> that shouldn't be shipped.
>>> We have a top level license file that covers the entire project,
>>> including these files.
>>> IMO, We should fix it if there is a new RC for some other reason. But
>>> this alone doesn't seem to make new RC necessary.
>>>
>>> Sushanth, Can you please reconsider your -1 ?
>>>
>>>
>>> On Fri, Jun 17, 2016 at 3:06 PM, Sushanth Sowmyan  
>>> wrote:
 -1, terribly sorry I didn't check for this earlier, but the RAT check
 fails for this.

 If you run mvn apache-rat:check , then you see the following issue:

 Unapproved licenses:

   
 /Users/sush/t/rel/apache-hive-2.1.0-src/common/src/java/org/apache/hive/common/util/DateParser.java
   
 /Users/sush/t/rel/apache-hive-2.1.0-src/common/src/test/org/apache/hive/common/util/TestDateParser.java

 Basically, these two files are missing the apache license header. We
 need to add them in.

 All other things are good, though. It has the oracle fix I asked for
 in RC2, md5s and signatures check out, compilation works on source
 package, and I'm able to run the hive binary from the binary package.
 I also tried a number of tests, and I've run a rat test on the release

 On Thu, Jun 16, 2016 at 6:02 PM, Jesus Camacho Rodriguez
  wrote:
> Apache Hive 2.1.0 Release Candidate 3 is available here:
>
> http://people.apache.org/~jcamacho/hive-2.1.0-rc3
>
> Maven artifacts are available here:
>
> https://repository.apache.org/content/repositories/orgapachehive-1057/
>
> Source tag for RC3 is at:
> https://github.com/apache/hive/releases/tag/release-2.1.0-rc3
>
>
> Voting will conclude in 72 hours.
>
> Hive PMC Members: Please test and vote.
>
> Thanks.
>
>
>
>
>

[jira] [Created] (HIVE-14059) Missing license headers for two files

2016-06-20 Thread Jesus Camacho Rodriguez (JIRA) 
Jesus Camacho Rodriguez created HIVE-14059:
--

 Summary: Missing license headers for two files
 Key: HIVE-14059
 URL: https://issues.apache.org/jira/browse/HIVE-14059
 Project: Hive
  Issue Type: Bug
Affects Versions: 2.1.0, 2.2.0
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez
Priority: Minor


As noted by [~sushanth], two files are missing the Apache headers:

{noformat}
/Users/sush/t/rel/apache-hive-2.1.0-src/common/src/java/org/apache/hive/common/util/DateParser.java

/Users/sush/t/rel/apache-hive-2.1.0-src/common/src/test/org/apache/hive/common/util/TestDateParser.java
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14058) UPDATE statement with condition on extended column causes ArraysIndexOutOfBoundsException

2016-06-20 Thread Hong Dai Thanh (JIRA) 
Hong Dai Thanh created HIVE-14058:
-

 Summary: UPDATE statement with condition on extended column causes 
ArraysIndexOutOfBoundsException
 Key: HIVE-14058
 URL: https://issues.apache.org/jira/browse/HIVE-14058
 Project: Hive
  Issue Type: Bug
 Environment: HDP 2.4.2/Hive 1.2.1
Reporter: Hong Dai Thanh
 Attachments: hive-site.xml

Create a transactional table, insert some data into the table. Then we extend 
the schema of the table by adding a column at the end, and add data to the 
table with the extended schema.

{code}
drop table if exists test purge;

create table test (
  a int,
  b int
)
clustered by (a) into 10 buckets
stored as orc
tblproperties ('transactional' = 'true');

insert into test values (1, 1), (2, 2), (3, 3);
insert into test values (4, 4), (5, 5), (6, 6);


alter table test add columns (c int);

insert into test values (10, 10, 10), (11, 11, 11), (12, 12, 12);
{code}

Whenever we run any {{UPDATE}} statement with a condition on the added column, 
for example:

{code}
update test set c = b where c is null;
update test set c = 0 where c is null;
update test set c = c + 1 where c is not null;
update test set c = 0 where c >= 11;
update test set c = c + 1 where c >= 11;
update test set b = b + 1 where c >= 11;
{code}

{{ArrayIndexOutOfBoundsException}} occurs.

Full stack trace below:

{code}
ERROR : Vertex failed, vertexName=Map 1, 
vertexId=vertex_1466049070874_0069_1_00, diagnostics=[Task failed, 
taskId=task_1466049070874_0069_1_00_00, diagnostics=[TaskAttempt 0 failed, 
info=[Error: Failure while running task:java.lang.RuntimeException: 
java.lang.RuntimeException: java.io.IOException: 
java.lang.ArrayIndexOutOfBoundsException: 9
at 
org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:173)
at 
org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:139)
at 
org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:344)
at 
org.apache.tez.runtime.task.TezTaskRunner$TaskRunnerCallable$1.run(TezTaskRunner.java:181)
at 
org.apache.tez.runtime.task.TezTaskRunner$TaskRunnerCallable$1.run(TezTaskRunner.java:172)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1709)
at 
org.apache.tez.runtime.task.TezTaskRunner$TaskRunnerCallable.callInternal(TezTaskRunner.java:172)
at 
org.apache.tez.runtime.task.TezTaskRunner$TaskRunnerCallable.callInternal(TezTaskRunner.java:168)
at org.apache.tez.common.CallableWithNdc.call(CallableWithNdc.java:36)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.RuntimeException: java.io.IOException: 
java.lang.ArrayIndexOutOfBoundsException: 9
at 
org.apache.hadoop.mapred.split.TezGroupedSplitsInputFormat$TezGroupedSplitsRecordReader.initNextRecordReader(TezGroupedSplitsInputFormat.java:196)
at 
org.apache.hadoop.mapred.split.TezGroupedSplitsInputFormat$TezGroupedSplitsRecordReader.next(TezGroupedSplitsInputFormat.java:142)
at 
org.apache.tez.mapreduce.lib.MRReaderMapred.next(MRReaderMapred.java:113)
at 
org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.pushRecord(MapRecordSource.java:61)
at 
org.apache.hadoop.hive.ql.exec.tez.MapRecordProcessor.run(MapRecordProcessor.java:328)
at 
org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:150)
... 14 more
Caused by: java.io.IOException: java.lang.ArrayIndexOutOfBoundsException: 9
at 
org.apache.hadoop.hive.io.HiveIOExceptionHandlerChain.handleRecordReaderCreationException(HiveIOExceptionHandlerChain.java:97)
at 
org.apache.hadoop.hive.io.HiveIOExceptionHandlerUtil.handleRecordReaderCreationException(HiveIOExceptionHandlerUtil.java:57)
at 
org.apache.hadoop.hive.ql.io.HiveInputFormat.getRecordReader(HiveInputFormat.java:253)
at 
org.apache.hadoop.mapred.split.TezGroupedSplitsInputFormat$TezGroupedSplitsRecordReader.initNextRecordReader(TezGroupedSplitsInputFormat.java:193)
... 19 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 9
at 
org.apache.hadoop.hive.ql.io.orc.RecordReaderImpl$SargApplier.pickRowGroups(RecordReaderImpl.java:730)
at 
org.apache.hadoop.hive.ql.io.orc.RecordReaderImpl.pickRowGroups(RecordReaderImpl.java:777)
at 
org.apache.hadoop.hive.ql.io.orc.RecordReaderImpl.readStripe(RecordReaderImpl.java:803)
at

Re: Review Request 48656: HIVE-13958: Support prohibiting string to decimal auto-casts.

2016-06-20 Thread Takuma Wakamori 


> On 6月 15, 2016, 8:09 a.m., Sergey Shelukhin wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java, 
> > line 265
> > 
> >
> > between should have a fixed number of arguments (3 IIRC), not a 
> > variable list

Updated to use fixed number of arguments.


- Takuma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48656/#review137610
---


On 6月 20, 2016, 6:31 p.m., Takuma Wakamori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48656/
> ---
> 
> (Updated 6月 20, 2016, 6:31 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-13958: Support prohibiting string to decimal auto-casts.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1e0ffa48f343ee11d78ae3a1de9f05ef4fee8eb0 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 
> aef46da4564808fd2c17fdd0a1cab442366587a3 
>   ql/src/test/queries/clientnegative/compare_double_bigint.q 
> 8ee4b277cbf729e6134e8f10dc6c76d1e4cd3482 
>   ql/src/test/queries/clientnegative/compare_double_bigint_between.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_double_bigint_in.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_string_bigint.q 
> 810f65d4d2b448b99cdb8907c016e36b1d9e276e 
>   ql/src/test/queries/clientnegative/compare_string_bigint_between.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_string_bigint_in.q PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_double_bigint_between.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_double_bigint_in.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_string_bigint_between.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_string_bigint_in.q.out 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48656/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Takuma Wakamori
> 
>

Re: Review Request 48656: HIVE-13958: Support prohibiting string to decimal auto-casts.

2016-06-20 Thread Takuma Wakamori 


> On 6月 15, 2016, 8:10 a.m., Sergey Shelukhin wrote:
> > ql/src/test/queries/clientnegative/compare_double_bigint_between.q, line 1
> > 
> >
> > this should not be necessary in all these files; the strict check for 
> > compares is on by default (or should be, if it's not). mapred.mode is 
> > deprecated.

Removed `set hive.mapred.mode=strict;` line.
However, the strict check for compares is *off* by deafult.
I changed the default value of `hive.mapred.mode` to `null` to make 
`hive.strict.checks.type.safety` is correctly referenced.


- Takuma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48656/#review137612
---


On 6月 20, 2016, 6:31 p.m., Takuma Wakamori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48656/
> ---
> 
> (Updated 6月 20, 2016, 6:31 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-13958: Support prohibiting string to decimal auto-casts.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1e0ffa48f343ee11d78ae3a1de9f05ef4fee8eb0 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 
> aef46da4564808fd2c17fdd0a1cab442366587a3 
>   ql/src/test/queries/clientnegative/compare_double_bigint.q 
> 8ee4b277cbf729e6134e8f10dc6c76d1e4cd3482 
>   ql/src/test/queries/clientnegative/compare_double_bigint_between.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_double_bigint_in.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_string_bigint.q 
> 810f65d4d2b448b99cdb8907c016e36b1d9e276e 
>   ql/src/test/queries/clientnegative/compare_string_bigint_between.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/compare_string_bigint_in.q PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_double_bigint_between.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_double_bigint_in.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_string_bigint_between.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/compare_string_bigint_in.q.out 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48656/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Takuma Wakamori
> 
>

Re: Review Request 48656: HIVE-13958: Support prohibiting string to decimal auto-casts.

2016-06-20 Thread Takuma Wakamori 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48656/
---

(Updated 6月 20, 2016, 6:31 p.m.)


Review request for hive.


Repository: hive-git


Description
---

HIVE-13958: Support prohibiting string to decimal auto-casts.


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
1e0ffa48f343ee11d78ae3a1de9f05ef4fee8eb0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 
aef46da4564808fd2c17fdd0a1cab442366587a3 
  ql/src/test/queries/clientnegative/compare_double_bigint.q 
8ee4b277cbf729e6134e8f10dc6c76d1e4cd3482 
  ql/src/test/queries/clientnegative/compare_double_bigint_between.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/compare_double_bigint_in.q PRE-CREATION 
  ql/src/test/queries/clientnegative/compare_string_bigint.q 
810f65d4d2b448b99cdb8907c016e36b1d9e276e 
  ql/src/test/queries/clientnegative/compare_string_bigint_between.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/compare_string_bigint_in.q PRE-CREATION 
  ql/src/test/results/clientnegative/compare_double_bigint_between.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/compare_double_bigint_in.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/compare_string_bigint_between.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/compare_string_bigint_in.q.out 
PRE-CREATION 

Diff: https://reviews.apache.org/r/48656/diff/


Testing
---


Thanks,

Takuma Wakamori