Re: SSL toolkit detection in acinclude.m4
On 11/06/2008 08:57 PM, Rainer Jung wrote: > Ruediger Pluem schrieb: >> On 11/06/2008 05:50 PM, Rainer Jung wrote: >>> Rainer Jung schrieb: Plüm, Rüdiger, VF-Group schrieb: > Rainer does the patch fix your issues on Solaris? I'll test once more without the save-related parts of the patch and let you know. >>> I now removed the changes for INCLUDES and LDFLAGS and only kept the >>> additional `$apr_config --libs`. That works fine. >> Thanks for testing Rainer. Just for clarification: In fact you used the >> following patch in your successful test. >> >> Index: acinclude.m4 >> === >> --- acinclude.m4(Revision 711951) >> +++ acinclude.m4(Arbeitskopie) >> @@ -447,10 +447,10 @@ >> pkglookup="`$PKGCONFIG --libs-only-L --libs-only-other openssl`" >> APR_ADDTO(LDFLAGS, [$pkglookup]) >>else >> -ap_ssltk_libs="-lssl -lcrypto" >> +ap_ssltk_libs="-lssl -lcrypto `$apr_config --libs`" >>fi >> else >> - ap_ssltk_libs="-lssl -lcrypto" >> + ap_ssltk_libs="-lssl -lcrypto `$apr_config --libs`" >> fi >>fi >>APR_SETVAR(SSL_LIBS, [$ap_ssltk_libs]) >> >> Correct? > > Exactly, should have included it in my response directly. Sorry. No problem. I updated PR46018 (https://issues.apache.org/bugzilla/show_bug.cgi?id=46018) and will wait some time for feedback. After that I will commit. Regards Rüdiger
Re: SSL toolkit detection in acinclude.m4
Ruediger Pluem schrieb: > > On 11/06/2008 05:50 PM, Rainer Jung wrote: >> Rainer Jung schrieb: >>> Plüm, Rüdiger, VF-Group schrieb: Rainer does the patch fix your issues on Solaris? >>> I'll test once more without the save-related parts of the patch and let >>> you know. >> I now removed the changes for INCLUDES and LDFLAGS and only kept the >> additional `$apr_config --libs`. That works fine. > > Thanks for testing Rainer. Just for clarification: In fact you used the > following patch in your successful test. > > Index: acinclude.m4 > === > --- acinclude.m4(Revision 711951) > +++ acinclude.m4(Arbeitskopie) > @@ -447,10 +447,10 @@ > pkglookup="`$PKGCONFIG --libs-only-L --libs-only-other openssl`" > APR_ADDTO(LDFLAGS, [$pkglookup]) >else > -ap_ssltk_libs="-lssl -lcrypto" > +ap_ssltk_libs="-lssl -lcrypto `$apr_config --libs`" >fi > else > - ap_ssltk_libs="-lssl -lcrypto" > + ap_ssltk_libs="-lssl -lcrypto `$apr_config --libs`" > fi >fi >APR_SETVAR(SSL_LIBS, [$ap_ssltk_libs]) > > Correct? Exactly, should have included it in my response directly. Sorry.
Re: SSL toolkit detection in acinclude.m4
On 11/06/2008 05:50 PM, Rainer Jung wrote: > Rainer Jung schrieb: >> Plüm, Rüdiger, VF-Group schrieb: >>> Rainer does the patch fix your issues on Solaris? >> I'll test once more without the save-related parts of the patch and let >> you know. > > I now removed the changes for INCLUDES and LDFLAGS and only kept the > additional `$apr_config --libs`. That works fine. Thanks for testing Rainer. Just for clarification: In fact you used the following patch in your successful test. Index: acinclude.m4 === --- acinclude.m4(Revision 711951) +++ acinclude.m4(Arbeitskopie) @@ -447,10 +447,10 @@ pkglookup="`$PKGCONFIG --libs-only-L --libs-only-other openssl`" APR_ADDTO(LDFLAGS, [$pkglookup]) else -ap_ssltk_libs="-lssl -lcrypto" +ap_ssltk_libs="-lssl -lcrypto `$apr_config --libs`" fi else - ap_ssltk_libs="-lssl -lcrypto" + ap_ssltk_libs="-lssl -lcrypto `$apr_config --libs`" fi fi APR_SETVAR(SSL_LIBS, [$ap_ssltk_libs]) Correct? Regards Rüdiger
Re: SSL toolkit detection in acinclude.m4
Rainer Jung schrieb: > Plüm, Rüdiger, VF-Group schrieb: >> Rainer does the patch fix your issues on Solaris? > I'll test once more without the save-related parts of the patch and let > you know. I now removed the changes for INCLUDES and LDFLAGS and only kept the additional `$apr_config --libs`. That works fine. Regards, Rainer
Re: SSL toolkit detection in acinclude.m4
Plüm, Rüdiger, VF-Group schrieb: >>> On 10/16/2008 12:04 PM, Rainer Jung wrote: Ruediger Pluem wrote: > While investigating PR46018 I came across the following in >>> acinclude.m4 > dnl Run header and version checks > saved_CPPFLAGS="$CPPFLAGS" > saved_LIBS="$LIBS" > if test "x$ap_ssltk_base" != "x"; then > APR_ADDTO(CPPFLAGS, [-I$ap_ssltk_base/include]) > APR_ADDTO(INCLUDES, [-I$ap_ssltk_base/include]) > APR_ADDTO(LDFLAGS, [-L$ap_ssltk_base/lib]) > > > Is there any reason why we only save / restore CPPFLAGS >>> and LIBS and > not INCLUDES and LDFLAGS which are also modified? > > The next thing I don't get is why we do not add >>> `$apr_config --libs` > to LIBS > any longer (since r669924). This causes -ldl to miss and thus the > checks to fail > (I guess only if there is no pkgconfig file). Yes, I ran into a similar issue, when compiling 2.2.10 >>> against static openssl libs on Solaris, having no pkgconfig. Then you need >>> to add -ldl, -lnsl, -lsocket during the configure tests, because >>> otherwise tehy fail. That was not necessary until 2.2.9. >>> Any further comments, ideas how to fix this? >> I added a possible fix to the PR >> (https://issues.apache.org/bugzilla/attachment.cgi?id=22826). >> Does somebody mind checking if this is the correct thing to do? > > Rainer does the patch fix your issues on Solaris? The additional `$apr_config --libs` seems fine to fix the issue during configure itself. Saving INCLUDES and LDFLAGS break the build. Without saving, entries are added to EXTRA_INCLUDES and EXTRA_LDFLAGS in build/config_vars.mk. Those entries are needed to build ab and mod_ssl and to link them. For the linking issue one could instead of adding the SSL-specifix -L... to EXTRA_LDFLAGS add them to ab_LDADD and to MOD_SSL_LDADD: it seems not to be needed for anything else. Since both of those vars include SSL_LIBS, it could also go in there. The include flag is harder, since at the moment the build system does ot include a component specific include variable (like ab_INCADD or MOD_SSL_INCADD). So now we know, why INCLUDES and LDFLAGS where not saved in configure ;) I'll test once more without the save-related parts of the patch and let you know. Regards, Rainer
Re: SSL toolkit detection in acinclude.m4
Plüm, Rüdiger, VF-Group schrieb: > > >> -Ursprüngliche Nachricht- >> Von: "Plüm, Rüdiger, VF-Group" >> Gesendet: Dienstag, 4. November 2008 13:24 >> An: dev@httpd.apache.org >> Betreff: Re: SSL toolkit detection in acinclude.m4 >> >> >> >>> -Ursprüngliche Nachricht- >>> Von: Ruediger Pluem >>> Gesendet: Samstag, 25. Oktober 2008 15:18 >>> An: dev@httpd.apache.org >>> Betreff: Re: SSL toolkit detection in acinclude.m4 >>> >>> >>> >>> On 10/16/2008 12:04 PM, Rainer Jung wrote: >>>> Ruediger Pluem wrote: >>>>> While investigating PR46018 I came across the following in >>> acinclude.m4 >>>>> dnl Run header and version checks >>>>> saved_CPPFLAGS="$CPPFLAGS" >>>>> saved_LIBS="$LIBS" >>>>> if test "x$ap_ssltk_base" != "x"; then >>>>> APR_ADDTO(CPPFLAGS, [-I$ap_ssltk_base/include]) >>>>> APR_ADDTO(INCLUDES, [-I$ap_ssltk_base/include]) >>>>> APR_ADDTO(LDFLAGS, [-L$ap_ssltk_base/lib]) >>>>> >>>>> >>>>> Is there any reason why we only save / restore CPPFLAGS >>> and LIBS and >>>>> not INCLUDES and LDFLAGS which are also modified? >>>>> >>>>> The next thing I don't get is why we do not add >>> `$apr_config --libs` >>>>> to LIBS >>>>> any longer (since r669924). This causes -ldl to miss and thus the >>>>> checks to fail >>>>> (I guess only if there is no pkgconfig file). >>>> Yes, I ran into a similar issue, when compiling 2.2.10 >>> against static >>>> openssl libs on Solaris, having no pkgconfig. Then you need >>> to add -ldl, >>>> -lnsl, -lsocket during the configure tests, because >>> otherwise tehy fail. >>>> That was not necessary until 2.2.9. >>> Any further comments, ideas how to fix this? >> I added a possible fix to the PR >> (https://issues.apache.org/bugzilla/attachment.cgi?id=22826). >> Does somebody mind checking if this is the correct thing to do? > > Rainer does the patch fix your issues on Solaris? I'm in New Orleans. Will be able to test remotely but only later. Will report back in 24 hours. Regards, Rainer
Re: SSL toolkit detection in acinclude.m4
> -Ursprüngliche Nachricht- > Von: "Plüm, Rüdiger, VF-Group" > Gesendet: Dienstag, 4. November 2008 13:24 > An: dev@httpd.apache.org > Betreff: Re: SSL toolkit detection in acinclude.m4 > > > > > -Ursprüngliche Nachricht- > > Von: Ruediger Pluem > > Gesendet: Samstag, 25. Oktober 2008 15:18 > > An: dev@httpd.apache.org > > Betreff: Re: SSL toolkit detection in acinclude.m4 > > > > > > > > On 10/16/2008 12:04 PM, Rainer Jung wrote: > > > Ruediger Pluem wrote: > > >> While investigating PR46018 I came across the following in > > acinclude.m4 > > >> > > >> dnl Run header and version checks > > >> saved_CPPFLAGS="$CPPFLAGS" > > >> saved_LIBS="$LIBS" > > >> if test "x$ap_ssltk_base" != "x"; then > > >> APR_ADDTO(CPPFLAGS, [-I$ap_ssltk_base/include]) > > >> APR_ADDTO(INCLUDES, [-I$ap_ssltk_base/include]) > > >> APR_ADDTO(LDFLAGS, [-L$ap_ssltk_base/lib]) > > >> > > >> > > >> Is there any reason why we only save / restore CPPFLAGS > > and LIBS and > > >> not INCLUDES and LDFLAGS which are also modified? > > >> > > >> The next thing I don't get is why we do not add > > `$apr_config --libs` > > >> to LIBS > > >> any longer (since r669924). This causes -ldl to miss and thus the > > >> checks to fail > > >> (I guess only if there is no pkgconfig file). > > > > > > Yes, I ran into a similar issue, when compiling 2.2.10 > > against static > > > openssl libs on Solaris, having no pkgconfig. Then you need > > to add -ldl, > > > -lnsl, -lsocket during the configure tests, because > > otherwise tehy fail. > > > That was not necessary until 2.2.9. > > > > Any further comments, ideas how to fix this? > > I added a possible fix to the PR > (https://issues.apache.org/bugzilla/attachment.cgi?id=22826). > Does somebody mind checking if this is the correct thing to do? Rainer does the patch fix your issues on Solaris? Regards Rüdiger
Re: SSL toolkit detection in acinclude.m4
> -Ursprüngliche Nachricht- > Von: Ruediger Pluem > Gesendet: Samstag, 25. Oktober 2008 15:18 > An: dev@httpd.apache.org > Betreff: Re: SSL toolkit detection in acinclude.m4 > > > > On 10/16/2008 12:04 PM, Rainer Jung wrote: > > Ruediger Pluem wrote: > >> While investigating PR46018 I came across the following in > acinclude.m4 > >> > >> dnl Run header and version checks > >> saved_CPPFLAGS="$CPPFLAGS" > >> saved_LIBS="$LIBS" > >> if test "x$ap_ssltk_base" != "x"; then > >> APR_ADDTO(CPPFLAGS, [-I$ap_ssltk_base/include]) > >> APR_ADDTO(INCLUDES, [-I$ap_ssltk_base/include]) > >> APR_ADDTO(LDFLAGS, [-L$ap_ssltk_base/lib]) > >> > >> > >> Is there any reason why we only save / restore CPPFLAGS > and LIBS and > >> not INCLUDES and LDFLAGS which are also modified? > >> > >> The next thing I don't get is why we do not add > `$apr_config --libs` > >> to LIBS > >> any longer (since r669924). This causes -ldl to miss and thus the > >> checks to fail > >> (I guess only if there is no pkgconfig file). > > > > Yes, I ran into a similar issue, when compiling 2.2.10 > against static > > openssl libs on Solaris, having no pkgconfig. Then you need > to add -ldl, > > -lnsl, -lsocket during the configure tests, because > otherwise tehy fail. > > That was not necessary until 2.2.9. > > Any further comments, ideas how to fix this? I added a possible fix to the PR (https://issues.apache.org/bugzilla/attachment.cgi?id=22826). Does somebody mind checking if this is the correct thing to do? Regards Rüdiger
Re: SSL toolkit detection in acinclude.m4
On 10/16/2008 12:04 PM, Rainer Jung wrote: > Ruediger Pluem wrote: >> While investigating PR46018 I came across the following in acinclude.m4 >> >> dnl Run header and version checks >> saved_CPPFLAGS="$CPPFLAGS" >> saved_LIBS="$LIBS" >> if test "x$ap_ssltk_base" != "x"; then >> APR_ADDTO(CPPFLAGS, [-I$ap_ssltk_base/include]) >> APR_ADDTO(INCLUDES, [-I$ap_ssltk_base/include]) >> APR_ADDTO(LDFLAGS, [-L$ap_ssltk_base/lib]) >> >> >> Is there any reason why we only save / restore CPPFLAGS and LIBS and >> not INCLUDES and LDFLAGS which are also modified? >> >> The next thing I don't get is why we do not add `$apr_config --libs` >> to LIBS >> any longer (since r669924). This causes -ldl to miss and thus the >> checks to fail >> (I guess only if there is no pkgconfig file). > > Yes, I ran into a similar issue, when compiling 2.2.10 against static > openssl libs on Solaris, having no pkgconfig. Then you need to add -ldl, > -lnsl, -lsocket during the configure tests, because otherwise tehy fail. > That was not necessary until 2.2.9. Any further comments, ideas how to fix this? Regards Rüdiger
Re: SSL toolkit detection in acinclude.m4
Ruediger Pluem wrote: While investigating PR46018 I came across the following in acinclude.m4 dnl Run header and version checks saved_CPPFLAGS="$CPPFLAGS" saved_LIBS="$LIBS" if test "x$ap_ssltk_base" != "x"; then APR_ADDTO(CPPFLAGS, [-I$ap_ssltk_base/include]) APR_ADDTO(INCLUDES, [-I$ap_ssltk_base/include]) APR_ADDTO(LDFLAGS, [-L$ap_ssltk_base/lib]) Is there any reason why we only save / restore CPPFLAGS and LIBS and not INCLUDES and LDFLAGS which are also modified? The next thing I don't get is why we do not add `$apr_config --libs` to LIBS any longer (since r669924). This causes -ldl to miss and thus the checks to fail (I guess only if there is no pkgconfig file). Yes, I ran into a similar issue, when compiling 2.2.10 against static openssl libs on Solaris, having no pkgconfig. Then you need to add -ldl, -lnsl, -lsocket during the configure tests, because otherwise tehy fail. That was not necessary until 2.2.9. Regards, Rainer
