Re: ASF Headers including Year ...
Hi Xiangdong, I think it's just dangerous as people tend to be lazy. So as soon as the build fails cause rat is complainng, it's easier to just call license:format than to fix thngs and then you could also overwrite headers you didn't want to overwrite. I would opt for removing it ... it will not prevent it's usage, but it will make is less obvious such a tool exists ;-) Chris Am 19.01.19, 12:44 schrieb "Xiangdong Huang" : Hi Chris, The license-maven-plugin is not attached on any phase of Maven, so the plugin does not add headers automatically until some user calls `mvn license:format`. The plugin is just for adding hundreds of files in one breath. We can remove the plugin now if most of you think it is needless. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Christofer Dutz 于2019年1月19日周六 下午7:23写道： > Hi all, > > In general I think it's problematic to have headers automatically changed, > especially by an automated tool.. > > Think of such a tool like a device that stamps "This is the property of > XYZ" on everything in your house ... now you borrow something from a friend > and as soon as you bring it home: *bam* the tool slams it's "This belongs > to XYZ" on it > Imagine how your friend will like that? > > Sometimes code gets added from outside the project, which is absolutely > fine as long as it's under a license, which is compatible with the ASF > license. But only as long as the header is left as is. > > I am not a lawyer, but as far as I understood it, only the authors of a > piece of code are allowed to change the headers ... an automated tools > doesn't qualify for that. > > Chris > > > > Am 19.01.19, 12:13 schrieb "Xiangdong Huang" : > > Hi all, > > I have modify the header of all files > > 1. Now the header is totally the same with > https://www.apache.org/legal/src-headers.html#headers > 2. apache-rat-plugin is enabled, and `mvn apache-rat:check` is passed. > > If anyone wants to create a new java file, I suggest you modify your > IDE > template to generate the header. > > Notice that the license-maven-plugin (com.mycila) which is added by Yi > Xu > is still enable. So, you can remove all the headers by running `mvn > license:remove` and then add asf header on each file by `mvn > license:format`. > You need to do this if you reformat source codes to follow Google Java > Style (each line has 100 characters, but each line in current header > has > less than 100 characters). > > I commit the changes to another branch `fix_license`. Please approve > the PR > if there is no problem. > > Best, > --- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > Justin Mclean 于2019年1月19日周六 上午3:49写道： > > > Hi, > > > > I think you can solve that by just adding “.git" to RAT exclusions. > [1] > > > > Thanks, > > Justin > > > > 1. http://creadur.apache.org/rat/apache-rat/ > > > > > > >
Re: ASF Headers including Year ...
Hi Chris, The license-maven-plugin is not attached on any phase of Maven, so the plugin does not add headers automatically until some user calls `mvn license:format`. The plugin is just for adding hundreds of files in one breath. We can remove the plugin now if most of you think it is needless. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Christofer Dutz 于2019年1月19日周六 下午7:23写道： > Hi all, > > In general I think it's problematic to have headers automatically changed, > especially by an automated tool.. > > Think of such a tool like a device that stamps "This is the property of > XYZ" on everything in your house ... now you borrow something from a friend > and as soon as you bring it home: *bam* the tool slams it's "This belongs > to XYZ" on it > Imagine how your friend will like that? > > Sometimes code gets added from outside the project, which is absolutely > fine as long as it's under a license, which is compatible with the ASF > license. But only as long as the header is left as is. > > I am not a lawyer, but as far as I understood it, only the authors of a > piece of code are allowed to change the headers ... an automated tools > doesn't qualify for that. > > Chris > > > > Am 19.01.19, 12:13 schrieb "Xiangdong Huang" : > > Hi all, > > I have modify the header of all files > > 1. Now the header is totally the same with > https://www.apache.org/legal/src-headers.html#headers > 2. apache-rat-plugin is enabled, and `mvn apache-rat:check` is passed. > > If anyone wants to create a new java file, I suggest you modify your > IDE > template to generate the header. > > Notice that the license-maven-plugin (com.mycila) which is added by Yi > Xu > is still enable. So, you can remove all the headers by running `mvn > license:remove` and then add asf header on each file by `mvn > license:format`. > You need to do this if you reformat source codes to follow Google Java > Style (each line has 100 characters, but each line in current header > has > less than 100 characters). > > I commit the changes to another branch `fix_license`. Please approve > the PR > if there is no problem. > > Best, > --- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > Justin Mclean 于2019年1月19日周六 上午3:49写道： > > > Hi, > > > > I think you can solve that by just adding “.git" to RAT exclusions. > [1] > > > > Thanks, > > Justin > > > > 1. http://creadur.apache.org/rat/apache-rat/ > > > > > > >
Re: ASF Headers including Year ...
Hi all, In general I think it's problematic to have headers automatically changed, especially by an automated tool.. Think of such a tool like a device that stamps "This is the property of XYZ" on everything in your house ... now you borrow something from a friend and as soon as you bring it home: *bam* the tool slams it's "This belongs to XYZ" on it Imagine how your friend will like that? Sometimes code gets added from outside the project, which is absolutely fine as long as it's under a license, which is compatible with the ASF license. But only as long as the header is left as is. I am not a lawyer, but as far as I understood it, only the authors of a piece of code are allowed to change the headers ... an automated tools doesn't qualify for that. Chris Am 19.01.19, 12:13 schrieb "Xiangdong Huang" : Hi all, I have modify the header of all files 1. Now the header is totally the same with https://www.apache.org/legal/src-headers.html#headers 2. apache-rat-plugin is enabled, and `mvn apache-rat:check` is passed. If anyone wants to create a new java file, I suggest you modify your IDE template to generate the header. Notice that the license-maven-plugin (com.mycila) which is added by Yi Xu is still enable. So, you can remove all the headers by running `mvn license:remove` and then add asf header on each file by `mvn license:format`. You need to do this if you reformat source codes to follow Google Java Style (each line has 100 characters, but each line in current header has less than 100 characters). I commit the changes to another branch `fix_license`. Please approve the PR if there is no problem. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean 于2019年1月19日周六 上午3:49写道： > Hi, > > I think you can solve that by just adding “.git" to RAT exclusions. [1] > > Thanks, > Justin > > 1. http://creadur.apache.org/rat/apache-rat/ > >
Re: ASF Headers including Year ...
Hi all, I have modify the header of all files 1. Now the header is totally the same with https://www.apache.org/legal/src-headers.html#headers 2. apache-rat-plugin is enabled, and `mvn apache-rat:check` is passed. If anyone wants to create a new java file, I suggest you modify your IDE template to generate the header. Notice that the license-maven-plugin (com.mycila) which is added by Yi Xu is still enable. So, you can remove all the headers by running `mvn license:remove` and then add asf header on each file by `mvn license:format`. You need to do this if you reformat source codes to follow Google Java Style (each line has 100 characters, but each line in current header has less than 100 characters). I commit the changes to another branch `fix_license`. Please approve the PR if there is no problem. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean 于2019年1月19日周六 上午3:49写道： > Hi, > > I think you can solve that by just adding “.git" to RAT exclusions. [1] > > Thanks, > Justin > > 1. http://creadur.apache.org/rat/apache-rat/ > >
Re: ASF Headers including Year ...
Hi, I think you can solve that by just adding “.git" to RAT exclusions. [1] Thanks, Justin 1. http://creadur.apache.org/rat/apache-rat/
Re: ASF Headers including Year ...
I use rat plugin and run `mvn clean rat:check`, it failed and its output is: [ERROR] Failed to execute goal org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check (default-cli) on project root: Too many unapproved licenses: 63 -> [Help 1] I check rat file under target directory, there are many files which should be ignored during the check of rat-plugin but it seems that rat plugin still marked them with no asf header. Does anyone encounter the same problem? * Files with AL headers will be marked L Binary files (which do not require AL headers) will be marked B Compressed archives will be marked A Notices, licenses etc will be marked N !? .checkstyle !? .git/config !? .git/description !? .git/HEAD !? .git/hooks/applypatch-msg.sample !? .git/hooks/commit-msg.sample !? .git/hooks/post-update.sample !? .git/hooks/pre-applypatch.sample !? .git/hooks/pre-commit.sample !? .git/hooks/pre-push.sample !? .git/hooks/pre-rebase.sample !? .git/hooks/pre-receive.sample !? .git/hooks/prepare-commit-msg.sample !? .git/hooks/update.sample B .git/index On 1/19/2019 01:05，徐毅 wrote： Can rat-Maven-plugin append header to java file? I check the document, it seems that rat plugin is used to check header? Xu Yi On 1/19/2019 00:52，Christofer Dutz wrote： Generally I had already setup everything correctly for Apache incubator projects, so just place the header Justin posted and use that. And probably replace the header plugin with the rat-Maven-plugin. Chris Outlook for Android<https://aka.ms/ghei36> herunterladen From: Justin Mclean Sent: Friday, January 18, 2019 5:50:49 PM To: dev@iotdb.apache.org Subject: Re: ASF Headers including Year ... Hi, Does maven provide some plugins to append header? Please take care when doing this you do not want to replace any 3rd parties files headers, they must be left intact. Thanks, Justin
Re: ASF Headers including Year ...
Can rat-Maven-plugin append header to java file? I check the document, it seems that rat plugin is used to check header? Xu Yi On 1/19/2019 00:52，Christofer Dutz wrote： Generally I had already setup everything correctly for Apache incubator projects, so just place the header Justin posted and use that. And probably replace the header plugin with the rat-Maven-plugin. Chris Outlook for Android<https://aka.ms/ghei36> herunterladen From: Justin Mclean Sent: Friday, January 18, 2019 5:50:49 PM To: dev@iotdb.apache.org Subject: Re: ASF Headers including Year ... Hi, Does maven provide some plugins to append header? Please take care when doing this you do not want to replace any 3rd parties files headers, they must be left intact. Thanks, Justin
Re: ASF Headers including Year ...
Generally I had already setup everything correctly for Apache incubator projects, so just place the header Justin posted and use that. And probably replace the header plugin with the rat-Maven-plugin. Chris Outlook for Android<https://aka.ms/ghei36> herunterladen From: Justin Mclean Sent: Friday, January 18, 2019 5:50:49 PM To: dev@iotdb.apache.org Subject: Re: ASF Headers including Year ... Hi, > Does maven provide some plugins to append header? Please take care when doing this you do not want to replace any 3rd parties files headers, they must be left intact. Thanks, Justin
Re: ASF Headers including Year ...
Hi, > Does maven provide some plugins to append header? Please take care when doing this you do not want to replace any 3rd parties files headers, they must be left intact. Thanks, Justin
Re: ASF Headers including Year ...
Hi Does maven provide some plugins to append header? I used the following plugin before, but it will add line break character which cannot pass code style check. com.mycila license-maven-plugin 3.0 | | 徐毅 | | xuyith...@126.com | 签名由网易邮箱大师定制 On 1/19/2019 00:30，Justin Mclean wrote： HI, That the wrong header. You need to use this header[1], it explicitly doesn't contain a copyright line. Thanks, Justin 1. https://www.apache.org/legal/src-headers.html#headers
Re: ASF Headers including Year ...
HI, That the wrong header. You need to use this header[1], it explicitly doesn't contain a copyright line. Thanks, Justin 1. https://www.apache.org/legal/src-headers.html#headers
Re: ASF Headers including Year ...
Yeah, that's for lawyers. :-) On 1/18/2019 9:30 AM, Christofer Dutz wrote: > Hi Kevin, > > Well if you set the Inception-Year in the pom, > maven generates this line in the generated artifacts. > I have never seen the year appear in every file header. > > Chris > > > > Am 18.01.19, 15:28 schrieb "Kevin A. McGrail" : > > On 1/18/2019 9:17 AM, Christofer Dutz wrote: > > Hi all, > > > > as I was setting up things so Jenkins will build the project, I noticed > that you have some strange plugin in the build that enforces headers quite > strictly. > > I don’t have any objections to that, however it marked my usual ASF > headers as invalid because they didn’t have the first line in them. > > > > Currently your header looks like this: > > > > Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org) > > > > Licensed to the Apache Software Foundation (ASF) under one > > or more contributor license agreements. See the NOTICE file > > distributed with this work for additional information > > regarding copyright ownership. The ASF licenses this file > > to you under the Apache License, Version 2.0 (the > > "License"); you may not use this file except in compliance > > with the License. You may obtain a copy of the License at > > > > http://www.apache.org/licenses/LICENSE-2.0 > > > > Unless required by applicable law or agreed to in writing, software > > distributed under the License is distributed on an "AS IS" BASIS, > > WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > > See the License for the specific language governing permissions and > > limitations under the License. > > > > I would strongly suggest to remove the first line. It’s equivalent can > be automatically generated by a maven plugin and the way it is, I think it > would require changing each file in the repo every year. I doubt this is what > you want to do. > > > > What do you others think? (Especially the other mentors) > > > > Chris > > I would defer to VP Legal to see what they say. > > At my firm, we always use 4 elements: > The Copyright Symbol > The Year of the Creation > The Name of the Author > A Rights Statement > > For example, Copyright © 1997-2019 Peregrine Computer Consultants > Corporation. > All Rights Reserved. > > Regards, > > KAM > > -- > Kevin A. McGrail > VP Fundraising, Apache Software Foundation > Chair Emeritus Apache SpamAssassin Project > https://www.linkedin.com/in/kmcgrail - 703.798.0171 > > > -- Kevin A. McGrail VP Fundraising, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: ASF Headers including Year ...
I just had a look at PLC4X. So we have the inception.year set in the pom and every artifact maven builds and hereby every artifact we release contains a META-INF/NOTICE file with this content: -- PLC4J: Utils: WireShark Utils Copyright 2017-2019 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). -- Where the first year is taken from the pom and the second is just the current year. Chris Am 18.01.19, 15:30 schrieb "Christofer Dutz" : Hi Kevin, Well if you set the Inception-Year in the pom, maven generates this line in the generated artifacts. I have never seen the year appear in every file header. Chris Am 18.01.19, 15:28 schrieb "Kevin A. McGrail" : On 1/18/2019 9:17 AM, Christofer Dutz wrote: > Hi all, > > as I was setting up things so Jenkins will build the project, I noticed that you have some strange plugin in the build that enforces headers quite strictly. > I don’t have any objections to that, however it marked my usual ASF headers as invalid because they didn’t have the first line in them. > > Currently your header looks like this: > > Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org) > > Licensed to the Apache Software Foundation (ASF) under one > or more contributor license agreements. See the NOTICE file > distributed with this work for additional information > regarding copyright ownership. The ASF licenses this file > to you under the Apache License, Version 2.0 (the > "License"); you may not use this file except in compliance > with the License. You may obtain a copy of the License at > > http://www.apache.org/licenses/LICENSE-2.0 > > Unless required by applicable law or agreed to in writing, software > distributed under the License is distributed on an "AS IS" BASIS, > WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > See the License for the specific language governing permissions and > limitations under the License. > > I would strongly suggest to remove the first line. It’s equivalent can be automatically generated by a maven plugin and the way it is, I think it would require changing each file in the repo every year. I doubt this is what you want to do. > > What do you others think? (Especially the other mentors) > > Chris I would defer to VP Legal to see what they say. At my firm, we always use 4 elements: The Copyright Symbol The Year of the Creation The Name of the Author A Rights Statement For example, Copyright © 1997-2019 Peregrine Computer Consultants Corporation. All Rights Reserved. Regards, KAM -- Kevin A. McGrail VP Fundraising, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: ASF Headers including Year ...
Hi Kevin, Well if you set the Inception-Year in the pom, maven generates this line in the generated artifacts. I have never seen the year appear in every file header. Chris Am 18.01.19, 15:28 schrieb "Kevin A. McGrail" : On 1/18/2019 9:17 AM, Christofer Dutz wrote: > Hi all, > > as I was setting up things so Jenkins will build the project, I noticed that you have some strange plugin in the build that enforces headers quite strictly. > I don’t have any objections to that, however it marked my usual ASF headers as invalid because they didn’t have the first line in them. > > Currently your header looks like this: > > Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org) > > Licensed to the Apache Software Foundation (ASF) under one > or more contributor license agreements. See the NOTICE file > distributed with this work for additional information > regarding copyright ownership. The ASF licenses this file > to you under the Apache License, Version 2.0 (the > "License"); you may not use this file except in compliance > with the License. You may obtain a copy of the License at > > http://www.apache.org/licenses/LICENSE-2.0 > > Unless required by applicable law or agreed to in writing, software > distributed under the License is distributed on an "AS IS" BASIS, > WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > See the License for the specific language governing permissions and > limitations under the License. > > I would strongly suggest to remove the first line. It’s equivalent can be automatically generated by a maven plugin and the way it is, I think it would require changing each file in the repo every year. I doubt this is what you want to do. > > What do you others think? (Especially the other mentors) > > Chris I would defer to VP Legal to see what they say. At my firm, we always use 4 elements: The Copyright Symbol The Year of the Creation The Name of the Author A Rights Statement For example, Copyright © 1997-2019 Peregrine Computer Consultants Corporation. All Rights Reserved. Regards, KAM -- Kevin A. McGrail VP Fundraising, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: ASF Headers including Year ...
On 1/18/2019 9:17 AM, Christofer Dutz wrote: > Hi all, > > as I was setting up things so Jenkins will build the project, I noticed that > you have some strange plugin in the build that enforces headers quite > strictly. > I don’t have any objections to that, however it marked my usual ASF headers > as invalid because they didn’t have the first line in them. > > Currently your header looks like this: > > Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org) > > Licensed to the Apache Software Foundation (ASF) under one > or more contributor license agreements. See the NOTICE file > distributed with this work for additional information > regarding copyright ownership. The ASF licenses this file > to you under the Apache License, Version 2.0 (the > "License"); you may not use this file except in compliance > with the License. You may obtain a copy of the License at > > http://www.apache.org/licenses/LICENSE-2.0 > > Unless required by applicable law or agreed to in writing, software > distributed under the License is distributed on an "AS IS" BASIS, > WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > See the License for the specific language governing permissions and > limitations under the License. > > I would strongly suggest to remove the first line. It’s equivalent can be > automatically generated by a maven plugin and the way it is, I think it would > require changing each file in the repo every year. I doubt this is what you > want to do. > > What do you others think? (Especially the other mentors) > > Chris I would defer to VP Legal to see what they say. At my firm, we always use 4 elements: The Copyright Symbol The Year of the Creation The Name of the Author A Rights Statement For example, Copyright © 1997-2019 Peregrine Computer Consultants Corporation. All Rights Reserved. Regards, KAM -- Kevin A. McGrail VP Fundraising, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: ASF Headers including Year ...
Hi, We have a asf.header file in our project, we use this as asf header in codes. Maybe we omit some files to use header like "Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org)". Are there many files use old header? I can help to delete them. Thanks Xu Yi On 1/18/2019 22:17，Christofer Dutz wrote： Hi all, as I was setting up things so Jenkins will build the project, I noticed that you have some strange plugin in the build that enforces headers quite strictly. I don’t have any objections to that, however it marked my usual ASF headers as invalid because they didn’t have the first line in them. Currently your header looks like this: Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org) Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. I would strongly suggest to remove the first line. It’s equivalent can be automatically generated by a maven plugin and the way it is, I think it would require changing each file in the repo every year. I doubt this is what you want to do. What do you others think? (Especially the other mentors) Chris
ASF Headers including Year ...
Hi all, as I was setting up things so Jenkins will build the project, I noticed that you have some strange plugin in the build that enforces headers quite strictly. I don’t have any objections to that, however it marked my usual ASF headers as invalid because they didn’t have the first line in them. Currently your header looks like this: Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org) Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. I would strongly suggest to remove the first line. It’s equivalent can be automatically generated by a maven plugin and the way it is, I think it would require changing each file in the repo every year. I doubt this is what you want to do. What do you others think? (Especially the other mentors) Chris
