Re: [ANN] Apache Isis version 1.16.1 Released

[Andi Huber]

Great work Dan!


On 23.02.2018 00:00, Dan Haywood wrote:
> The Apache Isis team is pleased to announce the release of Apache Isis
> v1.16.1.
>
> This is primarily a bugfix release.  Nevertheless there are a couple of new
> features:
> * checkboxes for parented collections.  The selected rows are used as the
> defaults for any associated actions with collection parameters
> * infrastructure to enable replaying of commands from master to slave (for
> regression testing).  This is used by the (non-ASF) command module.
>
> Full release notes are available on the Apache Isis website at [1].
>
> You can access this release directly from the Maven central repo [2].
> Alternatively, download the release and build it from source [3].
>
> Enjoy!
>
> --The Apache Isis team
>
> [1]
> http://isis.apache.org/release-notes/release-notes.html#_release-notes_1.16.1
> [2] http://search.maven.org
> [3] http://isis.apache.org/downloads.html
>

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373768#comment-16373768
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit d14dc6cb0409f5d233c700fc7dd02286b92979e0 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d14dc6c ]

ISIS-1813: updates html template for website and root index.html


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373765#comment-16373765
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 8a058940b35349f2b9eb040f9895059cf2eb0577 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8a05894 ]

ISIS-1813: updates website for 1.16.1


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373767#comment-16373767
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit db99f6df298b0ea6a5cc6207e38eb342dfa3fad6 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=db99f6d ]

ISIS-1813: bumps navbar to 1.16.1


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373769#comment-16373769
 ] 

ASF subversion and git services commented on ISIS-1870:
---

Commit a5050329b62602127708a256d287235659c6ce94 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a505032 ]

ISIS-1870: fixes compile issue


> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373766#comment-16373766
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 9d00defd8cd71ea6dd3d7359f64188e6ff79ea57 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9d00def ]

ISIS-1813: updates the procedure for publishing website


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373764#comment-16373764
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 9006c35152ef59af9897bb3df462d0b5f6124df6 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9006c35 ]

ISIS-1813: recreating helloworld archetype


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1870.
---
Resolution: Fixed

> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373748#comment-16373748
 ] 

ASF subversion and git services commented on ISIS-1870:
---

Commit 55f7f7c00b01b5227e4bcd5c2f1d20c4dad3d0a0 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=55f7f7c ]

ISIS-1870: fixes shiro unit tests


> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reassigned ISIS-1870:
-

Assignee: Dan Haywood

> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373681#comment-16373681
 ] 

ASF subversion and git services commented on ISIS-1870:
---

Commit 4b94310ccf0be83dff2014e4dd39b0ad4a458881 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4b94310 ]

ISIS-1870: fixes wrapper factory tests


> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373640#comment-16373640
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 9d00defd8cd71ea6dd3d7359f64188e6ff79ea57 in isis's branch 
refs/heads/release-1.16.1-RC2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9d00def ]

ISIS-1813: updates the procedure for publishing website


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373641#comment-16373641
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit db99f6df298b0ea6a5cc6207e38eb342dfa3fad6 in isis's branch 
refs/heads/release-1.16.1-RC2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=db99f6d ]

ISIS-1813: bumps navbar to 1.16.1


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373642#comment-16373642
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit d14dc6cb0409f5d233c700fc7dd02286b92979e0 in isis's branch 
refs/heads/release-1.16.1-RC2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d14dc6c ]

ISIS-1813: updates html template for website and root index.html


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ANN] Apache Isis version 1.16.1 Released

[Dan Haywood]

The Apache Isis team is pleased to announce the release of Apache Isis
v1.16.1.

This is primarily a bugfix release.  Nevertheless there are a couple of new
features:
* checkboxes for parented collections.  The selected rows are used as the
defaults for any associated actions with collection parameters
* infrastructure to enable replaying of commands from master to slave (for
regression testing).  This is used by the (non-ASF) command module.

Full release notes are available on the Apache Isis website at [1].

You can access this release directly from the Maven central repo [2].
Alternatively, download the release and build it from source [3].

Enjoy!

--The Apache Isis team

[1]
http://isis.apache.org/release-notes/release-notes.html#_release-notes_1.16.1
[2] http://search.maven.org
[3] http://isis.apache.org/downloads.html

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373555#comment-16373555
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 8a058940b35349f2b9eb040f9895059cf2eb0577 in isis's branch 
refs/heads/release-1.16.1-RC2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8a05894 ]

ISIS-1813: updates website for 1.16.1


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1813) Release tasks for 1.16.1

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1813.
-
Resolution: Fixed

> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[RESULT] [VOTE] Apache Isis Core release 1.16.1

[Dan Haywood]

The vote has completed with the following result :

  +3 (binding): .Andi Huber, Kevin Meyer, Dan Haywood

The vote is SUCCESSFUL.

I'll now go ahead and complete the post-release activities.

Re: [VOTE] Apache Isis Core release 1.16.1 RC2

[Dan Haywood]

ok, we're at +3 and 4 days have elapsed, so I'm gonna close this vote.
Will announce results on separate thread.


On Wed, 21 Feb 2018 at 11:45 Óscar Bou - GOVERTIS 
wrote:

>
> Hi Dan!
>
> Tried yesterday but had this message and wanted to investigate it further
> (on MacOS High Sierra):
>
> ———
>
> Enabling offline mode. Use './verify-isis-release.sh --online' to use
> online mode.
> ./verify-isis-release.sh: line 91: -L: command not found
> No downloader found.. exitting..
>
> ———
>
>
> El 21 feb 2018, a las 12:36, Dan Haywood 
> escribió:
>
> Adding my +1 also.
>
> 72 hours are due to expire later on today.  We have +3, but is anyone else
> intending to check the release?
>
> Thx
> Dan
>
>
> On Mon, 19 Feb 2018 at 22:03 Kevin Meyer  wrote:
>
> Hi,
>
> +1
>
> I've only been able to do a partial test (won't be back at my test system
> till Saturday).
>
> Cheers,
> Kevin
>
> On 18 February 2018 17:37:09 CET, Dan Haywood <
> d...@haywood-associates.co.uk> wrote:
>
> I've cut a release (RC2) for Apache Isis Core and the two archetypes:
>
> * Core 1.16.1
> * HelloWorld Archetype 1.16.1
> * SimpleApp Archetype 1.16.1
>
> The source code artifacts have been uploaded to staging repositories on
> repository.apache.org:
>
> *
>
>
> http://repository.apache.org/content/repositories/orgapacheisis-1066/org/apache/isis/core/isis/1.16.1/isis-1.16.1-source-release.zip
>
> *
>
>
> http://repository.apache.org/content/repositories/orgapacheisis-1067/org/apache/isis/archetype/helloworld-archetype/1.16.1/helloworld-archetype-1.16.1-source-release.zip
>
> *
>
>
> http://repository.apache.org/content/repositories/orgapacheisis-1067/org/apache/isis/archetype/simpleapp-archetype/1.16.1/simpleapp-archetype-1.16.1-source-release.zip
>
>
> For each zip there is a corresponding signature file (append .asc to
> the
> zip's url).
>
> In the source code repo the code has been tagged as isis-1.16.1-RC2,
> helloworld-archetype-1.16.1-RC2 and simpleapp-archetype-1.16.1-RC2; see
> https://github.com/apache/isis/tags
>
> For instructions on how to verify the release (build from binaries
> and/or
> use in Maven directly), see
> https://isis.apache.org/guides/cgcom/cgcom.html#_cgcom_verifying-releases
>
> NB: the above instructions are in the process of being improved.  To
> build
> from source, use:
>
> mvn clean install -Dskip.git
>
> Please verify the release and cast your vote.  The vote will be open
> for a
> minimum of 72 hours.
>
> [ ] +1
> [ ]  0
> [ ] -1
>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>
>
>
> Óscar Bou Bou
> Socio - IT & GRC Management Services Director
> m: +34 620 267 520 <+34%20620%2026%2075%2020>
> s:  www.govertis.com e: o@govertis.com
>
> LinkedIn: https://www.linkedin.com/in/oscarbou
> Twitter:  @oscarbou 
>
>
>
> Este mensaje y los ficheros anexos son confidenciales. Los mismos
> contienen información reservada que no puede ser difundida. Si usted ha
> recibido este correo por error, tenga la amabilidad de eliminarlo de su
> sistema y avisar al remitente mediante reenvío a su dirección electrónica;
> no deberá copiar el mensaje ni divulgar su contenido a ninguna persona.
>
> Su dirección de correo electrónico junto a sus datos personales constan en
> un fichero titularidad de GOVERTIS ADVISORY SERVICES, S.L. cuya finalidad
> es la de mantener el contacto con Ud. Si quiere saber de qué información
> disponemos de Ud., modificarla, y en su caso, cancelarla, puede hacerlo
> enviando un escrito al efecto, acompañado de una fotocopia de su D.N.I. a
> la siguiente dirección: GOVERTIS ADVISORY SERVICES, S.L. Avda Cortes
> Valencianas, 58 – 8º - 6ª. 46015 - Valencia
> ,
>  y Paseo de la Castellana, 153, 28045 - MADRID
> .
> Asimismo, es su responsabilidad comprobar que este mensaje o sus archivos
> adjuntos no contengan virus informáticos, y en caso que los tuvieran
> eliminarlos.
>
>

Re: Testing seems broken!

[Dan Haywood]

On Thu, 22 Feb 2018 at 13:53 Andi Huber  wrote:

> Update:
>
> It seems for test-inclusion surefire defaults to a naming-convention
> [6], which we clearly do not always follow:
>
>   * |Test*|
>   * |*Test|
>   * |*TestCase|
>
> However, we are able to override this behavior and include all tests
> regardless of naming. I've pushed the updated pom.xml to 'master'
> (2.0.0-M1). We have some tests to  fix now, that went 'hidden' previously.
>
> This might be a candidate do be back-ported to 1.16.x.
>
>
I'm hoping there won't be any more 1.16.x or 1.17 releases, so let's not
bother backporting.

Onwards and upwards!

Cheers
Dan


> Cheers, Andi!
>
> [6]
>
> https://stackoverflow.com/questions/6178583/maven-does-not-find-junit-tests-to-run
>
> On 22.02.2018 11:21, Andi Huber wrote:
> > Hi folks,
> >
> > I've found a strange discrepancy between tests our surefire maven plugin
> > discovers compared to what eclipse discovers. Eclipse discovers more
> > tests, which is a rather *SEVERE* issue regarding our current surefire
> > setup!
> >
> > I've opened an issue [1] to investigate this.
> >
> > I already fixed all failing tests (as picked up by eclipse, but not with
> > surefire) within the 'core/metamodel' [2].
> >
> > That lead to the discovery of 2 bugs [3][4] in 'master' and a
> > discrepancy between doc and code [5].
> >
> > Cheers, Andi!
> >
> > [1] https://issues.apache.org/jira/browse/ISIS-1869
> >
> > [2] https://issues.apache.org/jira/browse/ISIS-1866
> >
> > [3]
> >
> https://github.com/apache/isis/commit/dd9588d9e76b21dca07eb36956eca1f462d90fb7
> >
> > [4]
> >
> https://github.com/apache/isis/commit/2d1c331d8dfe59381014ce5f07df0733c496020e
> >
> > [5]
> >
> https://github.com/apache/isis/commit/d938728320057c01bb078fb0650cfb0a5bef4249
> >
> >
> >
>
>

Re: Active branches rebased

[Dan Haywood]

Thanks, Andi, appreciate the work you're doing paying back some of our
technical debt!

Cheers,
Dan.


On Thu, 22 Feb 2018, 19:54 Andi Huber,  wrote:

> Hi folks,
>
> I've again re-based '2.0.0-M2' on top of today's 'master' (=2.0.0-M1)
> and branch 'ISIS-1779-jax-rs-2' re-based on top of '2.0.0-M2'.
>
> Cheers, Andi!
>

Active branches rebased

[Andi Huber]

Hi folks,

I've again re-based '2.0.0-M2' on top of today's 'master' (=2.0.0-M1)
and branch 'ISIS-1779-jax-rs-2' re-based on top of '2.0.0-M2'.

Cheers, Andi!

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373335#comment-16373335
 ] 

ASF subversion and git services commented on ISIS-1756:
---

Commit 06c07d50ec3ed55ebb44c49da3ef6ac3574907cd in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=06c07d5 ]

ISIS-1756 backporting proper life-cycling from jax-rs-2 branch

> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Sub-task
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373327#comment-16373327
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit fa340f3ccda0b14c8bac88e61de5f1e51ace in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fa3 ]

ISIS-1744: removes work-around code for prior to DN 5.1.5


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373329#comment-16373329
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit a3c108ad229126f860de65de4526b77e55055175 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a3c108a ]

ISIS-1841 use _Context to store Isis default class loader

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1637#comment-1637
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit 723505c37c40a6f0319409e3d829734348b62d41 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=723505c ]

ISIS-1841 remove unused import

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373334#comment-16373334
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit c98701c48660e18f34783d11b188cbecc3b122f9 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c98701c ]

ISIS-1744 updating DN versions

datanucleus-core.version 5.1.6  datanucleus-api-jdo.version 5.1.4
datanucleus-jdo-query.version 5.0.4
datanucleus-rdbms.version 5.1.6


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373326#comment-16373326
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit 488f8257db1b966a0328837caf730f2121f2effc in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=488f825 ]

ISIS-1744: updates to DN 5.1.5


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1779) Transition to JAX-RS 2.0 Client API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373336#comment-16373336
 ] 

ASF subversion and git services commented on ISIS-1779:
---

Commit 3d7b6fd96c88945651ce039015c4af04e124441a in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3d7b6fd ]

ISIS-1779 introduce resteasy legacy layer

introduces o.a.i.viewer.legacy.RestEasyLegacy
as a resteasy legacy layer to ease transition

replaces jboss-jaxrs-api_2.0_spec (1.0.0.Final)
with jboss-jaxrs-api (3.0.12.Final)

adding a lot of TODO markers

replace org.jboss.resteasy.client.core.executors.ApacheHttpClient4Executor
with new o.a.i.viewer.legacy.ClientExecutor

> Transition to JAX-RS 2.0 Client API
> ---
>
> Key: ISIS-1779
> URL: https://issues.apache.org/jira/browse/ISIS-1779
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: RestfulObjects
>Affects Versions: 1.15.1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Dedicated Branch
> dev/2.0.0/ISIS-1779-jax-rs-2
> It seems JEE 8 servers (compliant with JAX-RS 2.1 API) conflict with 
> deployment of resteasy-jaxrs.version 3.x (which is JAX-RS 2.0 API) 
> and JEE 7 servers (compliant with JAX-RS 2.0 API) conflict with deployment of 
> resteasy-jaxrs.version 4.x (which is JAX-RS 2.1 API).
> So by now there is no easy way to package a war file with resteasy included, 
> that will run on both JEE 7 and 8.
> I've successfully tested 
> 4.0.0.Beta1 on glassfish 5,
> 3.0.17.Final on glassfish 4,
> 3.1.4.Final on glassfish 4.
> Note: transitioning resteasy-jaxrs from 3.0.x to any higher version involves 
> removal of deprecated classes in
> org.jboss.resteasy.client.*, which we are using it in 
> core/viewer-resfulobjects-applib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373328#comment-16373328
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit 42081eb60be8ee7fdd0d0e84927b03971600c8b6 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=42081eb ]

ISIS-1811: updates versions to 2.0.0-M2-SNAPSHOT


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373330#comment-16373330
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit efdf1180691dc60856ad00d635ccf4190f7dacf5 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=efdf118 ]

ISIS-1841 clean up Internal API after rebase/merge

refactor persistence capable type finding into its own package private
helper class

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373331#comment-16373331
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit ca1ea6673b99dd7a592a55879e09bb1b792a58f0 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ca1ea66 ]

ISIS-1841 remove unnecessary null-check + simplify

Note: _Reflect (Internal API) guarantees discovered classes to be non-null

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373302#comment-16373302
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit c98701c48660e18f34783d11b188cbecc3b122f9 in isis's branch 
refs/heads/dev/2.0.0-M2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c98701c ]

ISIS-1744 updating DN versions

datanucleus-core.version 5.1.6  datanucleus-api-jdo.version 5.1.4
datanucleus-jdo-query.version 5.0.4
datanucleus-rdbms.version 5.1.6


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373300#comment-16373300
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit ca1ea6673b99dd7a592a55879e09bb1b792a58f0 in isis's branch 
refs/heads/dev/2.0.0-M2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ca1ea66 ]

ISIS-1841 remove unnecessary null-check + simplify

Note: _Reflect (Internal API) guarantees discovered classes to be non-null

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373297#comment-16373297
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit 42081eb60be8ee7fdd0d0e84927b03971600c8b6 in isis's branch 
refs/heads/dev/2.0.0-M2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=42081eb ]

ISIS-1811: updates versions to 2.0.0-M2-SNAPSHOT


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373298#comment-16373298
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit a3c108ad229126f860de65de4526b77e55055175 in isis's branch 
refs/heads/dev/2.0.0-M2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a3c108a ]

ISIS-1841 use _Context to store Isis default class loader

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373303#comment-16373303
 ] 

ASF subversion and git services commented on ISIS-1756:
---

Commit 06c07d50ec3ed55ebb44c49da3ef6ac3574907cd in isis's branch 
refs/heads/dev/2.0.0-M2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=06c07d5 ]

ISIS-1756 backporting proper life-cycling from jax-rs-2 branch

> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Sub-task
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373299#comment-16373299
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit efdf1180691dc60856ad00d635ccf4190f7dacf5 in isis's branch 
refs/heads/dev/2.0.0-M2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=efdf118 ]

ISIS-1841 clean up Internal API after rebase/merge

refactor persistence capable type finding into its own package private
helper class

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373301#comment-16373301
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit 723505c37c40a6f0319409e3d829734348b62d41 in isis's branch 
refs/heads/dev/2.0.0-M2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=723505c ]

ISIS-1841 remove unused import

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373296#comment-16373296
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit fa340f3ccda0b14c8bac88e61de5f1e51ace in isis's branch 
refs/heads/dev/2.0.0-M2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fa3 ]

ISIS-1744: removes work-around code for prior to DN 5.1.5


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373295#comment-16373295
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit 488f8257db1b966a0328837caf730f2121f2effc in isis's branch 
refs/heads/dev/2.0.0-M2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=488f825 ]

ISIS-1744: updates to DN 5.1.5


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1767) JEE 7+ Support

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373294#comment-16373294
 ] 

ASF subversion and git services commented on ISIS-1767:
---

Commit 13e2820a3d31ef490112c409de4f89a05e17ca84 in isis's branch 
refs/heads/dev/2.0.0-M2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=13e2820 ]

ISIS-1767: fixes dependency convergence issue with com.sun.mail


> JEE 7+ Support
> --
>
> Key: ISIS-1767
> URL: https://issues.apache.org/jira/browse/ISIS-1767
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Collective tasks for Java EE 7+ support.
> Designated branch ...
> {code}dev/2.0.0/ISIS-1767-jee-7{code}
> +Tests+
> * *Server*: JEE 7+ implementation (or similar), launched with JDK8 (Version 
> 1.8.0_152); for deployment we use the HelloWorld artifact 1.15.1 with minor 
> modifications
> * *fat-war*: deploy all dependencies with single war (hsqldb in memory)
> * *skinny-war*: prepare container with shared libraries and shared domain 
> objects, deploy only a subset of domain classes with single war (hsqldb in 
> memory)
> * *restEasy*: check whether restEasy responds
> * managed connection pool (*con.pool*): use mysql db connection pool managed 
> by the JEE container and provided via JNDI
> * domain events (*dom.events*): test whether domain events are emitted and 
> handled using AxonFramework's SimpleEventBus
> * *swagger-ui*: test whether the static index.html from swagger-ui is served 
> and verify that a request for '//restful/swagger/private' 
> returns a JSON, that has the 'basePath' set to '//restful'
> * *redeploy*: test whether all previous tests succeed if we do a 
> deploy-undeploy-deploy process
> ||Server  ||fat-war ||skinny-war  
>||restEasy   ||con.pool   ||dom.events 
>   ||swagger-ui||redeploy||
> |Payara (full 4.1.2.173)  |{color:green}*OK*{color} 
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Payara (web 4.1.2.173)   |{color:green}*OK*{color} 
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Glassfish (full 4.1.2)   |*OK*(1)  |*OK*(1)  
>|{color:green}*OK*{color}|todo
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Glassfish (web 5.0.1 beta)|{color:green}*OK*{color}
> |{color:green}*OK*{color}|*OK*(5)|todo   
> |{color:green}*OK*{color}|{color:green}*OK*{color}|todo|
> |Glassfish (full 5.0) |{color:red}*FAILED*(2){color}|todo 
>|todo|todo|todo
> |todo|todo|
> |Wildfly (full 11.0.0)|{color:red}*FAILED*(3){color}|todo 
>|todo|todo|todo
> |todo|todo|
> |TomEE (plume 7.0.4)  |*OK*(4)  |todo 
>|{color:green}*OK*{color}|todo|todo
> |todo|todo|
> Notes:
> (1) 
> Guava version conflict: GF 4.2.1 has Guava-13, Isis has Guava-19; 
> WORKAROUND modify your glassfish installation ...
> * in glassfish/modules/ replace guava.jar with that which comes packaged with 
> Payara-4.1.2.173 (Guava-19)
> * you need to clear the OSGI cache: delete the folder 
> glassfish/domains/domainXXX/osgi-cache/felix
> (2)
> ON-HOLD waiting for GF 5.0.1 release!
> class-loading issues with Hibernate Validator, though library is included in 
> war ... java.lang.ClassNotFoundException: org.joda.time.ReadableInstant;
> using patch https://github.com/hibernate/hibernate-validator/pull/857/files 
> does not help: introduces new class-loading issues;
> (3)
> class-loading issues, though library is included in war ... 
> javax.persistence.PersistenceException: WFLYJPA0057: PersistenceProvider 
> 'org.apache.isis.core.webapp.jee.PersistenceUnitNoopProvider' not found;
> (4) 
> requires CXF to be disabled, see 
> https://stackoverflow.com/questions/41496204/tomee-7-0-2-how-to-disable-cxf-rs
>  
> throws exceptions on undeploy
> (5)
> JAX-RS API version clash
> requires 4.0.0.Beta1
> see https://issues.apache.org/jira/browse/ISIS-1779
> (6)   
> successfully tested against DN-5.1.5-SNAPSHOT (dedicated issue 
> https://issues.apache.org/jira/browse/ISIS-1754)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373266#comment-16373266
 ] 

ASF subversion and git services commented on ISIS-1870:
---

Commit b0858dfd3fae294a9664ea9b9e06b9fca87a7188 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b0858df ]

ISIS-1870 proper test tearDown, tests still fail

> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373255#comment-16373255
 ] 

ASF subversion and git services commented on ISIS-1870:
---

Commit 5a574cc60aeeaad0fe3d94429446cd34724f1af5 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5a574cc ]

ISIS-1870 fix MediaType parsing related tests

> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373210#comment-16373210
 ] 

ASF subversion and git services commented on ISIS-1870:
---

Commit 8d3a7e154589469a5264b04494769b394125f8e0 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8d3a7e1 ]

ISIS-1870 fix MediaType parser errors on initialization

> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373011#comment-16373011
 ] 

ASF subversion and git services commented on ISIS-1870:
---

Commit dbe845847aa97ad3752116df049f2d00f7650a25 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=dbe8458 ]

ISIS-1870 fix errors (mock setup)

> Fix JUnit Tests previously not picked up by surefire
> 
>
> Key: ISIS-1870
> URL: https://issues.apache.org/jira/browse/ISIS-1870
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> These modules have failing tests ...
> * core/security-shiro
> * core/viewer-restfulobjects-applib
> * core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1306) Enable graph visualisation in Wicket Viewer

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-1306:
-
Fix Version/s: 3.0.0

> Enable graph visualisation in Wicket Viewer
> ---
>
> Key: ISIS-1306
> URL: https://issues.apache.org/jira/browse/ISIS-1306
> Project: Isis
>  Issue Type: Wish
>  Components: Core: Viewer: Wicket
>Reporter: Vladimir Nisevic
>Priority: Minor
> Fix For: 3.0.0
>
>
> Would be nice to have possibility to visualize graphs with. e.g 
> http://graphviz.org/ or maybe with http://visjs.org/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (ISIS-1306) Enable graph visualisation in Wicket Viewer

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber reopened ISIS-1306:
--

On 2nd thought, I'll keep this suggestion open.

I do like the idea and maybe we'll find a solution that is generic enough to 
cover many use-cases ...

> Enable graph visualisation in Wicket Viewer
> ---
>
> Key: ISIS-1306
> URL: https://issues.apache.org/jira/browse/ISIS-1306
> Project: Isis
>  Issue Type: Wish
>  Components: Core: Viewer: Wicket
>Reporter: Vladimir Nisevic
>Priority: Minor
>
> Would be nice to have possibility to visualize graphs with. e.g 
> http://graphviz.org/ or maybe with http://visjs.org/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ISIS-1870) Fix JUnit Tests previously not picked up by surefire

[Andi Huber (JIRA)]

Andi Huber created ISIS-1870:


 Summary: Fix JUnit Tests previously not picked up by surefire
 Key: ISIS-1870
 URL: https://issues.apache.org/jira/browse/ISIS-1870
 Project: Isis
  Issue Type: Bug
  Components: Core
Reporter: Andi Huber
 Fix For: 2.0.0-M1


These modules have failing tests ...
* core/security-shiro
* core/viewer-restfulobjects-applib
* core/viewer-restfulobjects-server



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-1869) Surefire does not pick up all relevant tests

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber resolved ISIS-1869.
--
Resolution: Resolved

included all tests regardless of naming unless explicitly excluded

changes directly pushed to master

> Surefire does not pick up all relevant tests
> 
>
> Key: ISIS-1869
> URL: https://issues.apache.org/jira/browse/ISIS-1869
> Project: Isis
>  Issue Type: Bug
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> ||Module  ||Surefire Tests via Maven plugin   ||Eclipse running Junit 
> Tests on src/test/java||
> |core/unittestsupport |Tests run: 32, Failures: 0, Errors: 0, Skipped: 2  
> |Tests run: 51, Failures: 0, Errors: 0, Skipped: 3|
> |core/applib  |Tests run: 303, Failures: 0, Errors: 0, Skipped: 0 |Tests 
> run: 354, Failures: 0, Errors: 0, Skipped: 1|
> |core/metamodel   |Tests run: 828, Failures: 0, Errors: 0, Skipped: 12
> |Tests run: 1319, Failures: 0, Errors: 0, Skipped: 21|
> |core/runtime |Tests run: 83, Failures: 0, Errors: 0, Skipped: 0  |Tests 
> run: 111, Failures: 0, Errors: 0, Skipped: 0|
> |core/wrapper |Tests run: 3, Failures: 0, Errors: 0, Skipped: 0   |n.a.|
> |core/security-shiro  |Tests run: 2, Failures: 0, Errors: 0, Skipped: 0   
> |Tests run: 15, Failures: *4*, Errors: *4*, Skipped: 0|
> |core/viewer-restfulobjects-applib|Tests run: 16, Failures: 0, Errors: 0, 
> Skipped: 0  |Tests run: 169, Failures: 0, Errors: *9*, Skipped: 0|
> |core/viewer-restfulobjects-rendering |Tests run: 3, Failures: 0, Errors: 0, 
> Skipped: 0   |Tests run: 74, Failures: *2*, Errors: 0, Skipped: 0|
> |core/viewer-restfulobjects-server|Tests run: 8, Failures: 0, Errors: 0, 
> Skipped: 0   |Tests run: 32, Failures: *2*, Errors: *12*, Skipped: 0|
> |core/viewer-wicket-model |Tests run: 4, Failures: 0, Errors: 0, Skipped: 
> 0   |Tests run: 11, Failures: 0, Errors: 0, Skipped: 7|
> |core/viewer-wicket-ui|Tests run: 36, Failures: 0, Errors: 0, 
> Skipped: 0  |Tests run: 55, Failures: 0, Errors: 0, Skipped: 0|
> |core/viewer-wicket-impl  |Tests run: 0, Failures: 0, Errors: 0, Skipped: 
> 0   |Tests run: 33, Failures: 0, Errors: 0, Skipped: 7|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ISIS-1869) Surefire does not pick up all relevant tests

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber reassigned ISIS-1869:


Assignee: Andi Huber

> Surefire does not pick up all relevant tests
> 
>
> Key: ISIS-1869
> URL: https://issues.apache.org/jira/browse/ISIS-1869
> Project: Isis
>  Issue Type: Bug
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> ||Module  ||Surefire Tests via Maven plugin   ||Eclipse running Junit 
> Tests on src/test/java||
> |core/unittestsupport |Tests run: 32, Failures: 0, Errors: 0, Skipped: 2  
> |Tests run: 51, Failures: 0, Errors: 0, Skipped: 3|
> |core/applib  |Tests run: 303, Failures: 0, Errors: 0, Skipped: 0 |Tests 
> run: 354, Failures: 0, Errors: 0, Skipped: 1|
> |core/metamodel   |Tests run: 828, Failures: 0, Errors: 0, Skipped: 12
> |Tests run: 1319, Failures: 0, Errors: 0, Skipped: 21|
> |core/runtime |Tests run: 83, Failures: 0, Errors: 0, Skipped: 0  |Tests 
> run: 111, Failures: 0, Errors: 0, Skipped: 0|
> |core/wrapper |Tests run: 3, Failures: 0, Errors: 0, Skipped: 0   |n.a.|
> |core/security-shiro  |Tests run: 2, Failures: 0, Errors: 0, Skipped: 0   
> |Tests run: 15, Failures: *4*, Errors: *4*, Skipped: 0|
> |core/viewer-restfulobjects-applib|Tests run: 16, Failures: 0, Errors: 0, 
> Skipped: 0  |Tests run: 169, Failures: 0, Errors: *9*, Skipped: 0|
> |core/viewer-restfulobjects-rendering |Tests run: 3, Failures: 0, Errors: 0, 
> Skipped: 0   |Tests run: 74, Failures: *2*, Errors: 0, Skipped: 0|
> |core/viewer-restfulobjects-server|Tests run: 8, Failures: 0, Errors: 0, 
> Skipped: 0   |Tests run: 32, Failures: *2*, Errors: *12*, Skipped: 0|
> |core/viewer-wicket-model |Tests run: 4, Failures: 0, Errors: 0, Skipped: 
> 0   |Tests run: 11, Failures: 0, Errors: 0, Skipped: 7|
> |core/viewer-wicket-ui|Tests run: 36, Failures: 0, Errors: 0, 
> Skipped: 0  |Tests run: 55, Failures: 0, Errors: 0, Skipped: 0|
> |core/viewer-wicket-impl  |Tests run: 0, Failures: 0, Errors: 0, Skipped: 
> 0   |Tests run: 33, Failures: 0, Errors: 0, Skipped: 7|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Testing seems broken!

[Andi Huber]

Update:

It seems for test-inclusion surefire defaults to a naming-convention
[6], which we clearly do not always follow:

  * |Test*|
  * |*Test|
  * |*TestCase|

However, we are able to override this behavior and include all tests
regardless of naming. I've pushed the updated pom.xml to 'master'
(2.0.0-M1). We have some tests to  fix now, that went 'hidden' previously.

This might be a candidate do be back-ported to 1.16.x.

Cheers, Andi!

[6]
https://stackoverflow.com/questions/6178583/maven-does-not-find-junit-tests-to-run

On 22.02.2018 11:21, Andi Huber wrote:
> Hi folks,
>
> I've found a strange discrepancy between tests our surefire maven plugin
> discovers compared to what eclipse discovers. Eclipse discovers more
> tests, which is a rather *SEVERE* issue regarding our current surefire
> setup!
>
> I've opened an issue [1] to investigate this.
>
> I already fixed all failing tests (as picked up by eclipse, but not with
> surefire) within the 'core/metamodel' [2].
>
> That lead to the discovery of 2 bugs [3][4] in 'master' and a
> discrepancy between doc and code [5].
>
> Cheers, Andi!
>
> [1] https://issues.apache.org/jira/browse/ISIS-1869
>
> [2] https://issues.apache.org/jira/browse/ISIS-1866
>
> [3]
> https://github.com/apache/isis/commit/dd9588d9e76b21dca07eb36956eca1f462d90fb7
>
> [4]
> https://github.com/apache/isis/commit/2d1c331d8dfe59381014ce5f07df0733c496020e
>
> [5]
> https://github.com/apache/isis/commit/d938728320057c01bb078fb0650cfb0a5bef4249
>
>
>

[jira] [Commented] (ISIS-1869) Surefire does not pick up all relevant tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372819#comment-16372819
 ] 

ASF subversion and git services commented on ISIS-1869:
---

Commit 813597e1a4fa287dbb08aa5e7b975190cdec47d0 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=813597e ]

ISIS-1869 fix surefire setup

include all tests regardless of naming unless explicitly excluded

also update surefire plugin version to the latest available

> Surefire does not pick up all relevant tests
> 
>
> Key: ISIS-1869
> URL: https://issues.apache.org/jira/browse/ISIS-1869
> Project: Isis
>  Issue Type: Bug
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> ||Module  ||Surefire Tests via Maven plugin   ||Eclipse running Junit 
> Tests on src/test/java||
> |core/unittestsupport |Tests run: 32, Failures: 0, Errors: 0, Skipped: 2  
> |Tests run: 51, Failures: 0, Errors: 0, Skipped: 3|
> |core/applib  |Tests run: 303, Failures: 0, Errors: 0, Skipped: 0 |Tests 
> run: 354, Failures: 0, Errors: 0, Skipped: 1|
> |core/metamodel   |Tests run: 828, Failures: 0, Errors: 0, Skipped: 12
> |Tests run: 1319, Failures: 0, Errors: 0, Skipped: 21|
> |core/runtime |Tests run: 83, Failures: 0, Errors: 0, Skipped: 0  |Tests 
> run: 111, Failures: 0, Errors: 0, Skipped: 0|
> |core/wrapper |Tests run: 3, Failures: 0, Errors: 0, Skipped: 0   |n.a.|
> |core/security-shiro  |Tests run: 2, Failures: 0, Errors: 0, Skipped: 0   
> |Tests run: 15, Failures: *4*, Errors: *4*, Skipped: 0|
> |core/viewer-restfulobjects-applib|Tests run: 16, Failures: 0, Errors: 0, 
> Skipped: 0  |Tests run: 169, Failures: 0, Errors: *9*, Skipped: 0|
> |core/viewer-restfulobjects-rendering |Tests run: 3, Failures: 0, Errors: 0, 
> Skipped: 0   |Tests run: 74, Failures: *2*, Errors: 0, Skipped: 0|
> |core/viewer-restfulobjects-server|Tests run: 8, Failures: 0, Errors: 0, 
> Skipped: 0   |Tests run: 32, Failures: *2*, Errors: *12*, Skipped: 0|
> |core/viewer-wicket-model |Tests run: 4, Failures: 0, Errors: 0, Skipped: 
> 0   |Tests run: 11, Failures: 0, Errors: 0, Skipped: 7|
> |core/viewer-wicket-ui|Tests run: 36, Failures: 0, Errors: 0, 
> Skipped: 0  |Tests run: 55, Failures: 0, Errors: 0, Skipped: 0|
> |core/viewer-wicket-impl  |Tests run: 0, Failures: 0, Errors: 0, Skipped: 
> 0   |Tests run: 33, Failures: 0, Errors: 0, Skipped: 7|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Testing seems broken!

[Andi Huber]

Hi folks,

I've found a strange discrepancy between tests our surefire maven plugin
discovers compared to what eclipse discovers. Eclipse discovers more
tests, which is a rather *SEVERE* issue regarding our current surefire
setup!

I've opened an issue [1] to investigate this.

I already fixed all failing tests (as picked up by eclipse, but not with
surefire) within the 'core/metamodel' [2].

That lead to the discovery of 2 bugs [3][4] in 'master' and a
discrepancy between doc and code [5].

Cheers, Andi!

[1] https://issues.apache.org/jira/browse/ISIS-1869

[2] https://issues.apache.org/jira/browse/ISIS-1866

[3]
https://github.com/apache/isis/commit/dd9588d9e76b21dca07eb36956eca1f462d90fb7

[4]
https://github.com/apache/isis/commit/2d1c331d8dfe59381014ce5f07df0733c496020e

[5]
https://github.com/apache/isis/commit/d938728320057c01bb078fb0650cfb0a5bef4249

[jira] [Created] (ISIS-1869) Surefire does not pick up all relevant tests

[Andi Huber (JIRA)]

Andi Huber created ISIS-1869:


 Summary: Surefire does not pick up all relevant tests
 Key: ISIS-1869
 URL: https://issues.apache.org/jira/browse/ISIS-1869
 Project: Isis
  Issue Type: Bug
Reporter: Andi Huber
 Fix For: 2.0.0-M1


||Module||Surefire Tests via Maven plugin   ||Eclipse running Junit 
Tests on src/test/java||
|core/unittestsupport   |Tests run: 32, Failures: 0, Errors: 0, Skipped: 2  
|Tests run: 51, Failures: 0, Errors: 0, Skipped: 3|
|core/applib|Tests run: 303, Failures: 0, Errors: 0, Skipped: 0 |Tests 
run: 354, Failures: 0, Errors: 0, Skipped: 1|
|core/metamodel |Tests run: 828, Failures: 0, Errors: 0, Skipped: 12|Tests 
run: 1319, Failures: 0, Errors: 0, Skipped: 21|
|core/runtime   |Tests run: 83, Failures: 0, Errors: 0, Skipped: 0  |Tests 
run: 111, Failures: 0, Errors: 0, Skipped: 0|
|core/wrapper   |Tests run: 3, Failures: 0, Errors: 0, Skipped: 0   |n.a.|
|core/security-shiro|Tests run: 2, Failures: 0, Errors: 0, Skipped: 0   
|Tests run: 15, Failures: *4*, Errors: *4*, Skipped: 0|
|core/viewer-restfulobjects-applib  |Tests run: 16, Failures: 0, Errors: 0, 
Skipped: 0  |Tests run: 169, Failures: 0, Errors: *9*, Skipped: 0|
|core/viewer-restfulobjects-rendering   |Tests run: 3, Failures: 0, Errors: 0, 
Skipped: 0   |Tests run: 74, Failures: *2*, Errors: 0, Skipped: 0|
|core/viewer-restfulobjects-server  |Tests run: 8, Failures: 0, Errors: 0, 
Skipped: 0   |Tests run: 32, Failures: *2*, Errors: *12*, Skipped: 0|
|core/viewer-wicket-model   |Tests run: 4, Failures: 0, Errors: 0, Skipped: 
0   |Tests run: 11, Failures: 0, Errors: 0, Skipped: 7|
|core/viewer-wicket-ui  |Tests run: 36, Failures: 0, Errors: 0, Skipped: 0  
|Tests run: 55, Failures: 0, Errors: 0, Skipped: 0|
|core/viewer-wicket-impl|Tests run: 0, Failures: 0, Errors: 0, Skipped: 
0   |Tests run: 33, Failures: 0, Errors: 0, Skipped: 7|




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1866) Metamodel: 38 JUnit Test Failures

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1866.

Resolution: Fixed

all failing metamodel tests either fixed or removed

> Metamodel: 38 JUnit Test Failures
> -
>
> Key: ISIS-1866
> URL: https://issues.apache.org/jira/browse/ISIS-1866
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
> Attachments: metamodel_junit_failures.txt
>
>
> Eclipse discovers 1325 JUnit tests, 18 are skipped (ignored) and 38 do fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1868) Eclipse fails to build the schema module

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1868.

Resolution: Fixed

updated plugin versions in schema's pom.xml

changes directly pushed to master

> Eclipse fails to build the schema module
> 
>
> Key: ISIS-1868
> URL: https://issues.apache.org/jira/browse/ISIS-1868
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ISIS-1868) Eclipse fails to build the schema module

[Andi Huber (JIRA)]

Andi Huber created ISIS-1868:


 Summary: Eclipse fails to build the schema module
 Key: ISIS-1868
 URL: https://issues.apache.org/jira/browse/ISIS-1868
 Project: Isis
  Issue Type: Bug
  Components: Core
Reporter: Andi Huber
Assignee: Andi Huber
 Fix For: 2.0.0-M1






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: 1.16.1, branch ISIS-1852_parallel_stream_patch

[Dan Haywood]

On Sun, 18 Feb 2018 at 18:55 Andreas Huber  wrote:

> Hi Dan!
>
>
> BTW: Can't wait to use your new ISIS-1585 (Allow objects in parented
> collections to be selected)! ;)
>
>
With this feature I now think that the concept of bulk actions should be
deprecated - instead, return a view model and put an action with collection
parameter on it, associated with the appropriate parented collection.

I don't propose that we remove bulk actions for Isis 2.0.0, but I've
started adding @Deprecated in the source code.

Cheers
Dan






> Cheers,
> Andi
>
>
>