[jira] [Commented] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033830#comment-17033830
]
Tobias Bocanegra commented on JCRVLT-407:
-
I would assume that the filename's prefix is resolved using the namespace
declaration of it's XML, or its {{.content.xml}} if it's a directory, so:
{{_jcr2_content/.content.xml}}, or {{_jcr2_example.xml}}
we could add expanded format support for filenames, but it would look very
ugly
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033825#comment-17033825
]
Konrad Windszus commented on JCRVLT-407:
Well, this is what this bug is about :-) There is one catch though and this is
the one being outlined in
https://issues.apache.org/jira/browse/JCRVLT-407?focusedCommentId=17033702&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17033702.
If the node name being given by the jcr:root node is using a namespace as
well, it is unclear who is defining the prefix to URL mapping as the node name
is only given via the filename (and not via an XML element). Which prefixes are
supported for filenames? Are expanded forms supported for file names supported
as well? In
https://jackrabbit.apache.org/filevault/vaultfs.html#Filename_escaping there is
only documentation for qualified forms! How is it supposed to behave? Where is
the prefix/URL mapping supposed to come from in this case?
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033817#comment-17033817
]
Tobias Bocanegra commented on JCRVLT-407:
-
well, then it's a bug :-) the {{ni.name}} should be converted to expanded form,
then everything should work.
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033813#comment-17033813
]
Konrad Windszus edited comment on JCRVLT-407 at 2/10/20 5:59 PM:
-
The problem is that you use the qualified form
(https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form)
in
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050.
This takes the prefix from the XML (i.e. jcr2). This can obviously not work
during import as the JCR only knows about prefix "jcr" (for the very same
namespace url).
was (Author: kwin):
The problem is that you use the qualified form
(https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form)
in
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050.
This takes the prefix from the XML (i.e. jcr2). This can obviously not work
during import!
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033813#comment-17033813
]
Konrad Windszus commented on JCRVLT-407:
The problem is that you use the qualified form
(https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form)
in
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050.
This takes the prefix from the XML (i.e. jcr2). This can obviously not work
during import!
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033809#comment-17033809
]
Tobias Bocanegra edited comment on JCRVLT-407 at 2/10/20 5:55 PM:
--
I still don't understand why this is a problem. the nodes and properties are
created using the session namespaces [0]. so even if the docview has a {{jcr2}}
prefix, it should endup as {{jcr:content}} node.
if this doesn't work, it's a bug.
[0]
https://github.com/apache/jackrabbit-filevault/blob/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1047
was (Author: tripod):
I still don't understand why this is a problem. the nodes and properties are
created using the session namespaces [0]. so even if the docview has a {{jcr2}}
prefix, it should endup as {{jcr:content}} node.
if this doesn't work, it's a but.
[0]
https://github.com/apache/jackrabbit-filevault/blob/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1047
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033809#comment-17033809
]
Tobias Bocanegra commented on JCRVLT-407:
-
I still don't understand why this is a problem. the nodes and properties are
created using the session namespaces [0]. so even if the docview has a {{jcr2}}
prefix, it should endup as {{jcr:content}} node.
if this doesn't work, it's a but.
[0]
https://github.com/apache/jackrabbit-filevault/blob/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1047
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033803#comment-17033803
]
Konrad Windszus edited comment on JCRVLT-407 at 2/10/20 5:48 PM:
-
Just take the following file
{code}
http://www.jcp.org/jcr/1.0"; xmlns:rep="internal"
jcr2:primaryType="nt:unstructured">
{code}
IMHO the namespace prefix in the repository should be independent of the prefix
used in the XML (which is already supported for property names, but not yet for
node names).
was (Author: kwin):
Just take the following file
{code}
http://www.jcp.org/jcr/1.0"; xmlns:rep="internal"
jcr2:primaryType="nt:unstructured">
{code}
IMHO the namespace prefix in the repository should be independent of the prefix
used in the XML (which is already supported for property names, but not yet for
node names).
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033803#comment-17033803
]
Konrad Windszus commented on JCRVLT-407:
Just take the following file
{code}
http://www.jcp.org/jcr/1.0"; xmlns:rep="internal"
jcr2:primaryType="nt:unstructured">
{code}
IMHO the namespace prefix in the repository should be independent of the prefix
used in the XML (which is already supported for property names, but not yet for
node names).
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033798#comment-17033798
]
Tobias Bocanegra commented on JCRVLT-407:
-
I don't understand the problem. can you provide an example?
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033702#comment-17033702
]
Konrad Windszus commented on JCRVLT-407:
The problem is the artificial {{jcr:root}} element, because in that case the
node name comes from the file name. The file names only support the qualified
form, but not the expanded one, and there is basically no URL namespace
registry containing mapping between prefixes and namespace urls. [~tripod] What
is your view on that? Should that be another deviation from the standard
document view which is supposed to be documented in
https://jackrabbit.apache.org/filevault/docview.html. Which prefixes are
supported then in file names?
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: JCR 2.0 System View -> sv:name: expanded or qualified form?
On 10.02.2020 16:01, Konrad Windszus wrote: Hi, in the context of https://issues.apache.org/jira/browse/JCRVLT-407 I am currently looking into details how node names can be given in the System View format (https://docs.adobe.com/docs/en/spec/jcr/2.0/7_Export.html#7.2%20System%20View) Although not explicitly stated in the JSR, it seems that the values for the "sv:name" attribute should always be the qualified form (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form) rather than the expanded form (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form). That would also enforce every node namespace prefix to be registered in the XML (would be in line with 7.2.1 from the JSR). On the other hand for the qualified form it wouldn't make any sense to be forced to declare the namespace (with an unused prefix) in the SysView XML as well. Can someone shed some light on this? Thanks, Konrad Well, the requirement to declare all namespaces upfront is kind of unrealistic. It implies that between the time when serialization starts and complete node traversal no new namespace prefixes are added. The spec seems to be vague and just says "JCR name"; I believe that includes expanded names as well. We may need more tests in Oak. Best regards, Julian
JCR 2.0 System View -> sv:name: expanded or qualified form?
Hi, in the context of https://issues.apache.org/jira/browse/JCRVLT-407 I am currently looking into details how node names can be given in the System View format (https://docs.adobe.com/docs/en/spec/jcr/2.0/7_Export.html#7.2%20System%20View) Although not explicitly stated in the JSR, it seems that the values for the "sv:name" attribute should always be the qualified form (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form) rather than the expanded form (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form). That would also enforce every node namespace prefix to be registered in the XML (would be in line with 7.2.1 from the JSR). On the other hand for the qualified form it wouldn't make any sense to be forced to declare the namespace (with an unused prefix) in the SysView XML as well. Can someone shed some light on this? Thanks, Konrad
Jackrabbit-trunk - Build # 2785 - Unstable
The Apache Jenkins build system has built Jackrabbit-trunk (build #2785) Status: Unstable Check console output at https://builds.apache.org/job/Jackrabbit-trunk/2785/ to view the results.
[jira] [Updated] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-407:
---
Description:
Currently any DocView files is processed by the DocViewSAXImporter which
creates in the end nodes in the repository via
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
only contained there in its qualifed (i.e. prefixed) form
(https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
In case the XML uses other prefixes than the underlying JCR the namespaces
won't be correctly resolved, as the node creation happens in
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
with just the qualified form.
I would propose that the DocView node uses the expanded form
(https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
for node names, similar to property names!
was:
Currently any DocView files is processed by the DocViewSAXImporter which
creates in the end nodes in the repository via
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
only contained there in its qualifed (i.e. prefixed) name. In case the XML uses
other prefixes than the underlying JCR the namespaces won't be correctly
resolved, as the node creation happens in
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
with just the prefixed format (but not with the expanded namespace URI).
I would propose that the DocView node uses the expanded format for node names,
similar to DocViewProperty names!
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.2%20Qualified%20Form).
> In case the XML uses other prefixes than the underlying JCR the namespaces
> won't be correctly resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the qualified form.
> I would propose that the DocView node uses the expanded form
> (https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form)
> for node names, similar to property names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
[
https://issues.apache.org/jira/browse/JCRVLT-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-407:
---
Description:
Currently any DocView files is processed by the DocViewSAXImporter which
creates in the end nodes in the repository via
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
only contained there in its qualifed (i.e. prefixed) name. In case the XML uses
other prefixes than the underlying JCR the namespaces won't be correctly
resolved, as the node creation happens in
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
with just the prefixed format (but not with the expanded namespace URI).
I would propose that the DocView node uses the expanded format for node names,
similar to DocViewProperty names!
was:Currently any DocView files is processed by the DocViewSAXImporter which
creates in the end nodes in the repository via
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
only contained there in its qualifed (i.e. prefixed) name. In case the XML uses
other prefixes than the underlying JCR the namespaces won't be correctly
resolved, as the node creation happens in
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
with just the prefixed format (but not with the expanded namespace URI).
> DocView XML: Proper namespace support for node names during import
> --
>
> Key: JCRVLT-407
> URL: https://issues.apache.org/jira/browse/JCRVLT-407
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
>Affects Versions: 3.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.4
>
>
> Currently any DocView files is processed by the DocViewSAXImporter which
> creates in the end nodes in the repository via
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
> That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
> only contained there in its qualifed (i.e. prefixed) name. In case the XML
> uses other prefixes than the underlying JCR the namespaces won't be correctly
> resolved, as the node creation happens in
> https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
> with just the prefixed format (but not with the expanded namespace URI).
> I would propose that the DocView node uses the expanded format for node
> names, similar to DocViewProperty names!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (JCRVLT-407) DocView XML: Proper namespace support for node names during import
Konrad Windszus created JCRVLT-407:
--
Summary: DocView XML: Proper namespace support for node names
during import
Key: JCRVLT-407
URL: https://issues.apache.org/jira/browse/JCRVLT-407
Project: Jackrabbit FileVault
Issue Type: Bug
Components: vlt
Affects Versions: 3.4.2
Reporter: Konrad Windszus
Fix For: 3.4.4
Currently any DocView files is processed by the DocViewSAXImporter which
creates in the end nodes in the repository via
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L800.
That just takes {{DocViewNode}} as parameter. Unfortunately the node name is
only contained there in its qualifed (i.e. prefixed) name. In case the XML uses
other prefixes than the underlying JCR the namespaces won't be correctly
resolved, as the node creation happens in
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1050
with just the prefixed format (but not with the expanded namespace URI).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Jackrabbit 2.21.0 Release Plan
Hi, I'm planning to cut Jackrabbit 2.21.0 on tomorrow. The list of open issues scheduled for 2.210 is empty: https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%202.21.0%20AND%20project%20%3D%20JCR%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC The candidate release notes are here: https://svn.apache.org/repos/asf/jackrabbit/trunk/RELEASE-NOTES.txt If there are any objections please let me know. Best regards, Julian
[jira] [Resolved] (JCR-4530) jackrabbit-core: avoid use of deprecated commons-collections Buffers
[ https://issues.apache.org/jira/browse/JCR-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4530. - Fix Version/s: 2.21.0 Resolution: Fixed trunk: [r1873852|http://svn.apache.org/r1873852] > jackrabbit-core: avoid use of deprecated commons-collections Buffers > > > Key: JCR-4530 > URL: https://issues.apache.org/jira/browse/JCR-4530 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: core >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.21.0, 2.22 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JCR-4530) jackrabbit-core: avoid use of deprecated commons-collections Buffers
[ https://issues.apache.org/jira/browse/JCR-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4530: Labels: candidate_jcr_2_20 (was: ) > jackrabbit-core: avoid use of deprecated commons-collections Buffers > > > Key: JCR-4530 > URL: https://issues.apache.org/jira/browse/JCR-4530 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: core >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_jcr_2_20 > Fix For: 2.21.0, 2.22 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JCR-4530) jackrabbit-core: avoid use of deprecated commons-collections Buffers
[ https://issues.apache.org/jira/browse/JCR-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4530: Fix Version/s: 2.22 > jackrabbit-core: avoid use of deprecated commons-collections Buffers > > > Key: JCR-4530 > URL: https://issues.apache.org/jira/browse/JCR-4530 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: core >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.22 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JCR-4530) jackrabbit-core: avoid use of deprecated commons-collections Buffers
[ https://issues.apache.org/jira/browse/JCR-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4530: Summary: jackrabbit-core: avoid use of deprecated commons-collections Buffers (was: jack-core: avoid use of deprecated commons-collections Buffers) > jackrabbit-core: avoid use of deprecated commons-collections Buffers > > > Key: JCR-4530 > URL: https://issues.apache.org/jira/browse/JCR-4530 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: core >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JCR-4530) jack-core: avoid use of deprecated commons-collections Buffers
Julian Reschke created JCR-4530: --- Summary: jack-core: avoid use of deprecated commons-collections Buffers Key: JCR-4530 URL: https://issues.apache.org/jira/browse/JCR-4530 Project: Jackrabbit Content Repository Issue Type: Task Components: core Reporter: Julian Reschke Assignee: Julian Reschke -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JCR-4529) Update tomcat dependency to 8.5.50
[ https://issues.apache.org/jira/browse/JCR-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4529: Labels: candidate_jcr_2_20 (was: ) > Update tomcat dependency to 8.5.50 > -- > > Key: JCR-4529 > URL: https://issues.apache.org/jira/browse/JCR-4529 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: jackrabbit-webapp >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_jcr_2_20 > Fix For: 2.21.0, 2.22 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (JCR-4529) Update tomcat dependency to 8.5.50
[ https://issues.apache.org/jira/browse/JCR-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4529. - Resolution: Fixed trunk: [r1873846|http://svn.apache.org/r1873846] > Update tomcat dependency to 8.5.50 > -- > > Key: JCR-4529 > URL: https://issues.apache.org/jira/browse/JCR-4529 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: jackrabbit-webapp >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.21.0, 2.22 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JCR-4529) Update tomcat dependency to 8.5.50
Julian Reschke created JCR-4529: --- Summary: Update tomcat dependency to 8.5.50 Key: JCR-4529 URL: https://issues.apache.org/jira/browse/JCR-4529 Project: Jackrabbit Content Repository Issue Type: Task Components: jackrabbit-webapp Reporter: Julian Reschke Assignee: Julian Reschke Fix For: 2.21.0, 2.22 -- This message was sent by Atlassian Jira (v8.3.4#803005)
