[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432878825
##
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
##
@@ -283,32 +285,58 @@ public boolean isErrorDetected() {
* @param sampler {@link HTTPSamplerBase}
* @param request {@link HttpRequestHdr}
*/
-protected void computeSamplerName(HTTPSamplerBase sampler,
-HttpRequestHdr request) {
-String prefix = request.getPrefix();
+protected void computeSamplerName(HTTPSamplerBase sampler, HttpRequestHdr
request) {
+String prefix = request.getPrefix(); // ppp
Review comment:
ppp is "ppp"refix name" i use this string to test (look at the screen
shot for the description of the modification and the test).
I could rename ppp with pn for Prefix Name.
nnn is "nnn"ame i use this string to test the naming request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432878825
##
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
##
@@ -283,32 +285,58 @@ public boolean isErrorDetected() {
* @param sampler {@link HTTPSamplerBase}
* @param request {@link HttpRequestHdr}
*/
-protected void computeSamplerName(HTTPSamplerBase sampler,
-HttpRequestHdr request) {
-String prefix = request.getPrefix();
+protected void computeSamplerName(HTTPSamplerBase sampler, HttpRequestHdr
request) {
+String prefix = request.getPrefix(); // ppp
Review comment:
ppp is "ppp"refix name" i use this string to test (look at the screen
shot for the description of the modification and the test).
I could rename pp with pn for Prefix Name.
nnn is "nnn"ame i use this string to test the naming request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432878825
##
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
##
@@ -283,32 +285,58 @@ public boolean isErrorDetected() {
* @param sampler {@link HTTPSamplerBase}
* @param request {@link HttpRequestHdr}
*/
-protected void computeSamplerName(HTTPSamplerBase sampler,
-HttpRequestHdr request) {
-String prefix = request.getPrefix();
+protected void computeSamplerName(HTTPSamplerBase sampler, HttpRequestHdr
request) {
+String prefix = request.getPrefix(); // ppp
Review comment:
ppp is "ppp"refix name" i use this string to test (look at the screen
shot for the description of the modification and the test).
nnn is "nnn"ame i use this string to test the naming request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432879807
##
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/AbstractSamplerCreator.java
##
@@ -86,30 +75,49 @@ public AbstractSamplerCreator() {
/**
* @return int request number
*/
-protected static int getRequestNumber() {
+public int getRequestNumber() {
Review comment:
The method need to be public not protected (same package)
This method return value from a static value but i don't see why this method
need to be static.
Other methods are not static.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571: URL: https://github.com/apache/jmeter/pull/571#discussion_r432877736 ## File path: xdocs/usermanual/component_reference.xml ## @@ -6720,13 +6719,34 @@ Both Chrome and Internet Explorer use the same trust store for certificates. By default it also removes If-Modified-Since and If-None-Match headers. These are used to determine if the browser cache items are up to date; when recording one normally wants to download all the content. -To change which additional headers are removed, define the JMeter property proxy.headers.remove +To change which additional headers are removed, define the JMeter property proxy.heade'rs.remove Review comment: I don't change this line, i get it from a previous version before the modification, but you are rigth, the correct proxy.headers.remove This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432879192
##
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java
##
@@ -442,6 +483,12 @@ public void actionPerformed(ActionEvent action) {
}
} else if (command.equals(ACTION_RESTART)) {
model.stopProxy();
+// what is the last number for numbering samplers, ex : 96
+int iRequestNumber = model.getRequestNumberFromSamplerCreator();
Review comment:
I use prefix i for Integer or s for String for local variables but i
could change to requestNumber
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571:
URL: https://github.com/apache/jmeter/pull/571#discussion_r432878825
##
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
##
@@ -283,32 +285,58 @@ public boolean isErrorDetected() {
* @param sampler {@link HTTPSamplerBase}
* @param request {@link HttpRequestHdr}
*/
-protected void computeSamplerName(HTTPSamplerBase sampler,
-HttpRequestHdr request) {
-String prefix = request.getPrefix();
+protected void computeSamplerName(HTTPSamplerBase sampler, HttpRequestHdr
request) {
+String prefix = request.getPrefix(); // ppp
Review comment:
ppp is "ppp"refix name" i use this string to test (look at the image for
the description of the modification and the test.
nnn is "nnn"ame i use this string to test the naming request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571: URL: https://github.com/apache/jmeter/pull/571#discussion_r432877834 ## File path: xdocs/usermanual/component_reference.xml ## @@ -6720,13 +6719,34 @@ Both Chrome and Internet Explorer use the same trust store for certificates. By default it also removes If-Modified-Since and If-None-Match headers. These are used to determine if the browser cache items are up to date; when recording one normally wants to download all the content. -To change which additional headers are removed, define the JMeter property proxy.headers.remove +To change which additional headers are removed, define the JMeter property proxy.heade'rs.remove as a comma-separated list of headers. Add a blank assertion to each sampler? Use Regex Matching when replacing variables? If checked replacement will use word boundaries, i.e. it will only replace word matching values of variable, not part of a word. A word boundary follows Perl5 definition and is equivalent to \b. More information below in the paragraph about "User Defined Variable replacement". Add a prefix to sampler name during recording (Prefix mode). Or replace sampler name by user chosen name (Transaction name) -Inactivity time between two requests needed to consider them in two separate groups. + Select the numbering mode for sampler name + + Without numbering no numbering, ex : '/a.png' Review comment: ok i will use e.g. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jmeter] vdaburon commented on a change in pull request #571: Add prefix or suffix sampler numbering for HTTP Test Script Recorder
vdaburon commented on a change in pull request #571: URL: https://github.com/apache/jmeter/pull/571#discussion_r432877736 ## File path: xdocs/usermanual/component_reference.xml ## @@ -6720,13 +6719,34 @@ Both Chrome and Internet Explorer use the same trust store for certificates. By default it also removes If-Modified-Since and If-None-Match headers. These are used to determine if the browser cache items are up to date; when recording one normally wants to download all the content. -To change which additional headers are removed, define the JMeter property proxy.headers.remove +To change which additional headers are removed, define the JMeter property proxy.heade'rs.remove Review comment: I don't change this line, i get it from a previous version before the modiifcation, but you are rigth, the correct proxy.headers.remove This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
