Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[ziming deng]

The KIP is accepted with 4 binding votes (Chirs, Divij Vaidya, David and Luke) 
and 4 unbinding votes(Kamal, Federico, Andrew and Николай Ижиков).
Thank you all !

> On Jan 24, 2024, at 20:44, Николай Ижиков  wrote:
> 
> +1 (non-binding)
> 
>> 24 янв. 2024 г., в 12:48, Chris Egerton  написал(а):
>> 
>> Thanks Ziming! +1 (binding)
>> 
>> On Wed, Jan 24, 2024, 03:23 ziming deng  wrote:
>> 
>>> Thank you for reminding this, David,
>>> 
>>> I have mentioned this in the [Compatibility] section as a following work.
>>> 
>>> --,
>>> Best,
>>> Ziming
>>> 
 On Jan 23, 2024, at 15:17, David Jacot 
>>> wrote:
 
 Hi Chris, Ziming,
 
 Thanks for the clarification. I am glad that it does not impact the tool.
 It may be worth adding a note about it in the KIP to avoid the same
 question in the future.
 
 Otherwise, I am +1 (binding). Thanks for driving this!
 
 Best,
 David
 
 On Tue, Jan 23, 2024 at 6:07 AM ziming deng 
 wrote:
 
> Hello David,
> 
> Thanks for reminding this, as Chirs explained, the tools I’m trying to
> update only support set/delete configs, and I’m just make a way for
> append/subtract configs in the future, so this would not be affected by
> KAFKA-10140, and it would be a little overkill to support
>>> append/subtract
> configs or solve KAFKA-10140 here, so let’s leave it right now, I'm
>>> happy
> to pick it after finishing this KIP.
> 
> --,
> Ziming
> 
>> On Jan 22, 2024, at 18:23, David Jacot 
> wrote:
>> 
>> Hi Ziming,
>> 
>> Thanks for driving this. I wanted to bring KAFKA-10140
>>  to your attention.
> It
>> looks like the incremental API does not work for configuring plugins. I
>> think that we need to cover this in the KIP.
>> 
>> Best,
>> David
>> 
>> On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
>> andrew_schofield_j...@outlook.com> wrote:
>> 
>>> +1 (non-binding)
>>> 
>>> Thanks,
>>> Andrew
>>> 
 On 22 Jan 2024, at 07:29, Federico Valeri 
> wrote:
 
 +1 (non binding)
 
 Thanks.
 
 On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
> 
> Hi Ziming,
> 
> +1(binding) from me.
> 
> Thanks.
> Luke
> 
> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
> kamal.chandraprak...@gmail.com> wrote:
> 
>> +1 (non-binding)
>> 
>> On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
> dengziming1...@gmail.com>
>> wrote:
>> 
>>> Hello everyone,
>>> I'd like to initiate a vote for KIP-1011.
>>> This KIP is about replacing alterConfigs with
> incrementalAlterConfigs
>>> when updating broker configs using kafka-configs.sh, this is
>>> similar
>>> to
>>> what we have done in KIP-894.
>>> 
>>> KIP link:
>>> KIP-1011: Use incrementalAlterConfigs when updating broker configs
> by
>>> kafka-configs.sh - Apache Kafka - Apache Software Foundation
>>> <
>>> 
> 
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
 
>>> cwiki.apache.org
>>> <
>>> 
> 
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
 
>>> [image: favicon.ico]
>>> <
>>> 
> 
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
 
>>> <
>>> 
> 
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
 
>>> 
>>> Discussion thread:
>>> 
>>> 
>>> lists.apache.org
>>> >> >> >> 
>>> 
>>> --,
>>> Best,
>>> Ziming
>>> 
>>> 
>>> 
> 
> 
>>> 
>>> 
> 

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Николай Ижиков]

+1 (non-binding)

> 24 янв. 2024 г., в 12:48, Chris Egerton  написал(а):
> 
> Thanks Ziming! +1 (binding)
> 
> On Wed, Jan 24, 2024, 03:23 ziming deng  wrote:
> 
>> Thank you for reminding this, David,
>> 
>> I have mentioned this in the [Compatibility] section as a following work.
>> 
>> --,
>> Best,
>> Ziming
>> 
>>> On Jan 23, 2024, at 15:17, David Jacot 
>> wrote:
>>> 
>>> Hi Chris, Ziming,
>>> 
>>> Thanks for the clarification. I am glad that it does not impact the tool.
>>> It may be worth adding a note about it in the KIP to avoid the same
>>> question in the future.
>>> 
>>> Otherwise, I am +1 (binding). Thanks for driving this!
>>> 
>>> Best,
>>> David
>>> 
>>> On Tue, Jan 23, 2024 at 6:07 AM ziming deng 
>>> wrote:
>>> 
 Hello David,
 
 Thanks for reminding this, as Chirs explained, the tools I’m trying to
 update only support set/delete configs, and I’m just make a way for
 append/subtract configs in the future, so this would not be affected by
 KAFKA-10140, and it would be a little overkill to support
>> append/subtract
 configs or solve KAFKA-10140 here, so let’s leave it right now, I'm
>> happy
 to pick it after finishing this KIP.
 
 --,
 Ziming
 
> On Jan 22, 2024, at 18:23, David Jacot 
 wrote:
> 
> Hi Ziming,
> 
> Thanks for driving this. I wanted to bring KAFKA-10140
>  to your attention.
 It
> looks like the incremental API does not work for configuring plugins. I
> think that we need to cover this in the KIP.
> 
> Best,
> David
> 
> On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
> andrew_schofield_j...@outlook.com> wrote:
> 
>> +1 (non-binding)
>> 
>> Thanks,
>> Andrew
>> 
>>> On 22 Jan 2024, at 07:29, Federico Valeri 
 wrote:
>>> 
>>> +1 (non binding)
>>> 
>>> Thanks.
>>> 
>>> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
 
 Hi Ziming,
 
 +1(binding) from me.
 
 Thanks.
 Luke
 
 On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
 kamal.chandraprak...@gmail.com> wrote:
 
> +1 (non-binding)
> 
> On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
 dengziming1...@gmail.com>
> wrote:
> 
>> Hello everyone,
>> I'd like to initiate a vote for KIP-1011.
>> This KIP is about replacing alterConfigs with
 incrementalAlterConfigs
>> when updating broker configs using kafka-configs.sh, this is
>> similar
>> to
>> what we have done in KIP-894.
>> 
>> KIP link:
>> KIP-1011: Use incrementalAlterConfigs when updating broker configs
 by
>> kafka-configs.sh - Apache Kafka - Apache Software Foundation
>> <
>> 
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
>>> 
>> cwiki.apache.org
>> <
>> 
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
>>> 
>> [image: favicon.ico]
>> <
>> 
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
>>> 
>> <
>> 
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
>>> 
>> 
>> Discussion thread:
>> 
>> 
>> lists.apache.org
>> >> 
>> >> 
>> >> 
>> 
>> 
>> --,
>> Best,
>> Ziming
>> 
>> 
>> 
 
 
>> 
>> 

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Chris Egerton]

Thanks Ziming! +1 (binding)

On Wed, Jan 24, 2024, 03:23 ziming deng  wrote:

> Thank you for reminding this, David,
>
> I have mentioned this in the [Compatibility] section as a following work.
>
> --,
> Best,
> Ziming
>
> > On Jan 23, 2024, at 15:17, David Jacot 
> wrote:
> >
> > Hi Chris, Ziming,
> >
> > Thanks for the clarification. I am glad that it does not impact the tool.
> > It may be worth adding a note about it in the KIP to avoid the same
> > question in the future.
> >
> > Otherwise, I am +1 (binding). Thanks for driving this!
> >
> > Best,
> > David
> >
> > On Tue, Jan 23, 2024 at 6:07 AM ziming deng 
> > wrote:
> >
> >> Hello David,
> >>
> >> Thanks for reminding this, as Chirs explained, the tools I’m trying to
> >> update only support set/delete configs, and I’m just make a way for
> >> append/subtract configs in the future, so this would not be affected by
> >> KAFKA-10140, and it would be a little overkill to support
> append/subtract
> >> configs or solve KAFKA-10140 here, so let’s leave it right now, I'm
> happy
> >> to pick it after finishing this KIP.
> >>
> >> --,
> >> Ziming
> >>
> >>> On Jan 22, 2024, at 18:23, David Jacot 
> >> wrote:
> >>>
> >>> Hi Ziming,
> >>>
> >>> Thanks for driving this. I wanted to bring KAFKA-10140
> >>>  to your attention.
> >> It
> >>> looks like the incremental API does not work for configuring plugins. I
> >>> think that we need to cover this in the KIP.
> >>>
> >>> Best,
> >>> David
> >>>
> >>> On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
> >>> andrew_schofield_j...@outlook.com> wrote:
> >>>
>  +1 (non-binding)
> 
>  Thanks,
>  Andrew
> 
> > On 22 Jan 2024, at 07:29, Federico Valeri 
> >> wrote:
> >
> > +1 (non binding)
> >
> > Thanks.
> >
> > On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
> >>
> >> Hi Ziming,
> >>
> >> +1(binding) from me.
> >>
> >> Thanks.
> >> Luke
> >>
> >> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
> >> kamal.chandraprak...@gmail.com> wrote:
> >>
> >>> +1 (non-binding)
> >>>
> >>> On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
> >> dengziming1...@gmail.com>
> >>> wrote:
> >>>
>  Hello everyone,
>  I'd like to initiate a vote for KIP-1011.
>  This KIP is about replacing alterConfigs with
> >> incrementalAlterConfigs
>  when updating broker configs using kafka-configs.sh, this is
> similar
>  to
>  what we have done in KIP-894.
> 
>  KIP link:
>  KIP-1011: Use incrementalAlterConfigs when updating broker configs
> >> by
>  kafka-configs.sh - Apache Kafka - Apache Software Foundation
>  <
> 
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >
>  cwiki.apache.org
>  <
> 
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >
>  [image: favicon.ico]
>  <
> 
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >
>  <
> 
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >
> 
>  Discussion thread:
> 
> 
>  lists.apache.org
>   >
>   >
>   >
> 
> 
>  --,
>  Best,
>  Ziming
> 
> 
> 
> >>
> >>
>
>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[ziming deng]

Thank you for reminding this, David,

I have mentioned this in the [Compatibility] section as a following work.

--,
Best,
Ziming

> On Jan 23, 2024, at 15:17, David Jacot  wrote:
> 
> Hi Chris, Ziming,
> 
> Thanks for the clarification. I am glad that it does not impact the tool.
> It may be worth adding a note about it in the KIP to avoid the same
> question in the future.
> 
> Otherwise, I am +1 (binding). Thanks for driving this!
> 
> Best,
> David
> 
> On Tue, Jan 23, 2024 at 6:07 AM ziming deng 
> wrote:
> 
>> Hello David,
>> 
>> Thanks for reminding this, as Chirs explained, the tools I’m trying to
>> update only support set/delete configs, and I’m just make a way for
>> append/subtract configs in the future, so this would not be affected by
>> KAFKA-10140, and it would be a little overkill to support append/subtract
>> configs or solve KAFKA-10140 here, so let’s leave it right now, I'm happy
>> to pick it after finishing this KIP.
>> 
>> --,
>> Ziming
>> 
>>> On Jan 22, 2024, at 18:23, David Jacot 
>> wrote:
>>> 
>>> Hi Ziming,
>>> 
>>> Thanks for driving this. I wanted to bring KAFKA-10140
>>>  to your attention.
>> It
>>> looks like the incremental API does not work for configuring plugins. I
>>> think that we need to cover this in the KIP.
>>> 
>>> Best,
>>> David
>>> 
>>> On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
>>> andrew_schofield_j...@outlook.com> wrote:
>>> 
 +1 (non-binding)
 
 Thanks,
 Andrew
 
> On 22 Jan 2024, at 07:29, Federico Valeri 
>> wrote:
> 
> +1 (non binding)
> 
> Thanks.
> 
> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
>> 
>> Hi Ziming,
>> 
>> +1(binding) from me.
>> 
>> Thanks.
>> Luke
>> 
>> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
>> kamal.chandraprak...@gmail.com> wrote:
>> 
>>> +1 (non-binding)
>>> 
>>> On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
>> dengziming1...@gmail.com>
>>> wrote:
>>> 
 Hello everyone,
 I'd like to initiate a vote for KIP-1011.
 This KIP is about replacing alterConfigs with
>> incrementalAlterConfigs
 when updating broker configs using kafka-configs.sh, this is similar
 to
 what we have done in KIP-894.
 
 KIP link:
 KIP-1011: Use incrementalAlterConfigs when updating broker configs
>> by
 kafka-configs.sh - Apache Kafka - Apache Software Foundation
 <
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> 
 cwiki.apache.org
 <
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> 
 [image: favicon.ico]
 <
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> 
 <
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> 
 
 Discussion thread:
 
 
 lists.apache.org
 
 
 
 
 
 --,
 Best,
 Ziming
 
 
 
>> 
>> 

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[ziming deng]

Hello Ismael,
I have tested it locally to verified again that this issue only affect 
append/subtract, I also commented in the JIRA ticket to clarify this.

Best,
Ziming


> On Jan 23, 2024, at 23:07, Ismael Juma  wrote:
> 
> Hi Ziming,
> 
> Have you verified that the issue only impacts append/subtract? The way I
> read the JIRA is that the issue currently affects all operations for
> plugins, but it can be fixed to only affect append/subtract (where it would
> be harder to fix). It would be good to verify the current state.
> 
> Ismael
> 
> On Mon, Jan 22, 2024 at 9:07 PM ziming deng 
> wrote:
> 
>> Hello David,
>> 
>> Thanks for reminding this, as Chirs explained, the tools I’m trying to
>> update only support set/delete configs, and I’m just make a way for
>> append/subtract configs in the future, so this would not be affected by
>> KAFKA-10140, and it would be a little overkill to support append/subtract
>> configs or solve KAFKA-10140 here, so let’s leave it right now, I'm happy
>> to pick it after finishing this KIP.
>> 
>> --,
>> Ziming
>> 
>>> On Jan 22, 2024, at 18:23, David Jacot 
>> wrote:
>>> 
>>> Hi Ziming,
>>> 
>>> Thanks for driving this. I wanted to bring KAFKA-10140
>>>  to your attention.
>> It
>>> looks like the incremental API does not work for configuring plugins. I
>>> think that we need to cover this in the KIP.
>>> 
>>> Best,
>>> David
>>> 
>>> On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
>>> andrew_schofield_j...@outlook.com> wrote:
>>> 
 +1 (non-binding)
 
 Thanks,
 Andrew
 
> On 22 Jan 2024, at 07:29, Federico Valeri 
>> wrote:
> 
> +1 (non binding)
> 
> Thanks.
> 
> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
>> 
>> Hi Ziming,
>> 
>> +1(binding) from me.
>> 
>> Thanks.
>> Luke
>> 
>> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
>> kamal.chandraprak...@gmail.com> wrote:
>> 
>>> +1 (non-binding)
>>> 
>>> On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
>> dengziming1...@gmail.com>
>>> wrote:
>>> 
 Hello everyone,
 I'd like to initiate a vote for KIP-1011.
 This KIP is about replacing alterConfigs with
>> incrementalAlterConfigs
 when updating broker configs using kafka-configs.sh, this is similar
 to
 what we have done in KIP-894.
 
 KIP link:
 KIP-1011: Use incrementalAlterConfigs when updating broker configs
>> by
 kafka-configs.sh - Apache Kafka - Apache Software Foundation
 <
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> 
 cwiki.apache.org
 <
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> 
 [image: favicon.ico]
 <
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> 
 <
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> 
 
 Discussion thread:
 
 
 lists.apache.org
 
 
 
 
 
 --,
 Best,
 Ziming
 
 
 
>> 
>> 

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Ismael Juma]

Hi Ziming,

Have you verified that the issue only impacts append/subtract? The way I
read the JIRA is that the issue currently affects all operations for
plugins, but it can be fixed to only affect append/subtract (where it would
be harder to fix). It would be good to verify the current state.

Ismael

On Mon, Jan 22, 2024 at 9:07 PM ziming deng 
wrote:

> Hello David,
>
> Thanks for reminding this, as Chirs explained, the tools I’m trying to
> update only support set/delete configs, and I’m just make a way for
> append/subtract configs in the future, so this would not be affected by
> KAFKA-10140, and it would be a little overkill to support append/subtract
> configs or solve KAFKA-10140 here, so let’s leave it right now, I'm happy
> to pick it after finishing this KIP.
>
> --,
> Ziming
>
> > On Jan 22, 2024, at 18:23, David Jacot 
> wrote:
> >
> > Hi Ziming,
> >
> > Thanks for driving this. I wanted to bring KAFKA-10140
> >  to your attention.
> It
> > looks like the incremental API does not work for configuring plugins. I
> > think that we need to cover this in the KIP.
> >
> > Best,
> > David
> >
> > On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
> > andrew_schofield_j...@outlook.com> wrote:
> >
> >> +1 (non-binding)
> >>
> >> Thanks,
> >> Andrew
> >>
> >>> On 22 Jan 2024, at 07:29, Federico Valeri 
> wrote:
> >>>
> >>> +1 (non binding)
> >>>
> >>> Thanks.
> >>>
> >>> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
> 
>  Hi Ziming,
> 
>  +1(binding) from me.
> 
>  Thanks.
>  Luke
> 
>  On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
>  kamal.chandraprak...@gmail.com> wrote:
> 
> > +1 (non-binding)
> >
> > On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
> dengziming1...@gmail.com>
> > wrote:
> >
> >> Hello everyone,
> >> I'd like to initiate a vote for KIP-1011.
> >> This KIP is about replacing alterConfigs with
> incrementalAlterConfigs
> >> when updating broker configs using kafka-configs.sh, this is similar
> >> to
> >> what we have done in KIP-894.
> >>
> >> KIP link:
> >> KIP-1011: Use incrementalAlterConfigs when updating broker configs
> by
> >> kafka-configs.sh - Apache Kafka - Apache Software Foundation
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >>>
> >> cwiki.apache.org
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >>>
> >> [image: favicon.ico]
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >>>
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >>>
> >>
> >> Discussion thread:
> >>
> >>
> >> lists.apache.org
> >> 
> >> 
> >> 
> >>
> >>
> >> --,
> >> Best,
> >> Ziming
> >>
> >>
> >>
>
>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Divij Vaidya]

+1 (binding)

I have participated in the discussion for this and looked at the most
recent version of this KIP. It looks good to me.

--
Divij Vaidya



On Tue, Jan 23, 2024 at 8:17 AM David Jacot 
wrote:

> Hi Chris, Ziming,
>
> Thanks for the clarification. I am glad that it does not impact the tool.
> It may be worth adding a note about it in the KIP to avoid the same
> question in the future.
>
> Otherwise, I am +1 (binding). Thanks for driving this!
>
> Best,
> David
>
> On Tue, Jan 23, 2024 at 6:07 AM ziming deng 
> wrote:
>
> > Hello David,
> >
> > Thanks for reminding this, as Chirs explained, the tools I’m trying to
> > update only support set/delete configs, and I’m just make a way for
> > append/subtract configs in the future, so this would not be affected by
> > KAFKA-10140, and it would be a little overkill to support append/subtract
> > configs or solve KAFKA-10140 here, so let’s leave it right now, I'm happy
> > to pick it after finishing this KIP.
> >
> > --,
> > Ziming
> >
> > > On Jan 22, 2024, at 18:23, David Jacot 
> > wrote:
> > >
> > > Hi Ziming,
> > >
> > > Thanks for driving this. I wanted to bring KAFKA-10140
> > >  to your attention.
> > It
> > > looks like the incremental API does not work for configuring plugins. I
> > > think that we need to cover this in the KIP.
> > >
> > > Best,
> > > David
> > >
> > > On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
> > > andrew_schofield_j...@outlook.com> wrote:
> > >
> > >> +1 (non-binding)
> > >>
> > >> Thanks,
> > >> Andrew
> > >>
> > >>> On 22 Jan 2024, at 07:29, Federico Valeri 
> > wrote:
> > >>>
> > >>> +1 (non binding)
> > >>>
> > >>> Thanks.
> > >>>
> > >>> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
> > 
> >  Hi Ziming,
> > 
> >  +1(binding) from me.
> > 
> >  Thanks.
> >  Luke
> > 
> >  On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
> >  kamal.chandraprak...@gmail.com> wrote:
> > 
> > > +1 (non-binding)
> > >
> > > On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
> > dengziming1...@gmail.com>
> > > wrote:
> > >
> > >> Hello everyone,
> > >> I'd like to initiate a vote for KIP-1011.
> > >> This KIP is about replacing alterConfigs with
> > incrementalAlterConfigs
> > >> when updating broker configs using kafka-configs.sh, this is
> similar
> > >> to
> > >> what we have done in KIP-894.
> > >>
> > >> KIP link:
> > >> KIP-1011: Use incrementalAlterConfigs when updating broker configs
> > by
> > >> kafka-configs.sh - Apache Kafka - Apache Software Foundation
> > >> <
> > >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> > >>>
> > >> cwiki.apache.org
> > >> <
> > >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> > >>>
> > >> [image: favicon.ico]
> > >> <
> > >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> > >>>
> > >> <
> > >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> > >>>
> > >>
> > >> Discussion thread:
> > >>
> > >>
> > >> lists.apache.org
> > >>  >
> > >>  >
> > >>  >
> > >>
> > >>
> > >> --,
> > >> Best,
> > >> Ziming
> > >>
> > >>
> > >>
> >
> >
>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[David Jacot]

Hi Chris, Ziming,

Thanks for the clarification. I am glad that it does not impact the tool.
It may be worth adding a note about it in the KIP to avoid the same
question in the future.

Otherwise, I am +1 (binding). Thanks for driving this!

Best,
David

On Tue, Jan 23, 2024 at 6:07 AM ziming deng 
wrote:

> Hello David,
>
> Thanks for reminding this, as Chirs explained, the tools I’m trying to
> update only support set/delete configs, and I’m just make a way for
> append/subtract configs in the future, so this would not be affected by
> KAFKA-10140, and it would be a little overkill to support append/subtract
> configs or solve KAFKA-10140 here, so let’s leave it right now, I'm happy
> to pick it after finishing this KIP.
>
> --,
> Ziming
>
> > On Jan 22, 2024, at 18:23, David Jacot 
> wrote:
> >
> > Hi Ziming,
> >
> > Thanks for driving this. I wanted to bring KAFKA-10140
> >  to your attention.
> It
> > looks like the incremental API does not work for configuring plugins. I
> > think that we need to cover this in the KIP.
> >
> > Best,
> > David
> >
> > On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
> > andrew_schofield_j...@outlook.com> wrote:
> >
> >> +1 (non-binding)
> >>
> >> Thanks,
> >> Andrew
> >>
> >>> On 22 Jan 2024, at 07:29, Federico Valeri 
> wrote:
> >>>
> >>> +1 (non binding)
> >>>
> >>> Thanks.
> >>>
> >>> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
> 
>  Hi Ziming,
> 
>  +1(binding) from me.
> 
>  Thanks.
>  Luke
> 
>  On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
>  kamal.chandraprak...@gmail.com> wrote:
> 
> > +1 (non-binding)
> >
> > On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
> dengziming1...@gmail.com>
> > wrote:
> >
> >> Hello everyone,
> >> I'd like to initiate a vote for KIP-1011.
> >> This KIP is about replacing alterConfigs with
> incrementalAlterConfigs
> >> when updating broker configs using kafka-configs.sh, this is similar
> >> to
> >> what we have done in KIP-894.
> >>
> >> KIP link:
> >> KIP-1011: Use incrementalAlterConfigs when updating broker configs
> by
> >> kafka-configs.sh - Apache Kafka - Apache Software Foundation
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >>>
> >> cwiki.apache.org
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >>>
> >> [image: favicon.ico]
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >>>
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >>>
> >>
> >> Discussion thread:
> >>
> >>
> >> lists.apache.org
> >> 
> >> 
> >> 
> >>
> >>
> >> --,
> >> Best,
> >> Ziming
> >>
> >>
> >>
>
>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[ziming deng]

Hello David,

Thanks for reminding this, as Chirs explained, the tools I’m trying to update 
only support set/delete configs, and I’m just make a way for append/subtract 
configs in the future, so this would not be affected by KAFKA-10140, and it 
would be a little overkill to support append/subtract configs or solve 
KAFKA-10140 here, so let’s leave it right now, I'm happy to pick it after 
finishing this KIP.

--,
Ziming

> On Jan 22, 2024, at 18:23, David Jacot  wrote:
> 
> Hi Ziming,
> 
> Thanks for driving this. I wanted to bring KAFKA-10140
>  to your attention. It
> looks like the incremental API does not work for configuring plugins. I
> think that we need to cover this in the KIP.
> 
> Best,
> David
> 
> On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
> andrew_schofield_j...@outlook.com> wrote:
> 
>> +1 (non-binding)
>> 
>> Thanks,
>> Andrew
>> 
>>> On 22 Jan 2024, at 07:29, Federico Valeri  wrote:
>>> 
>>> +1 (non binding)
>>> 
>>> Thanks.
>>> 
>>> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
 
 Hi Ziming,
 
 +1(binding) from me.
 
 Thanks.
 Luke
 
 On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
 kamal.chandraprak...@gmail.com> wrote:
 
> +1 (non-binding)
> 
> On Mon, Jan 22, 2024 at 8:34 AM ziming deng 
> wrote:
> 
>> Hello everyone,
>> I'd like to initiate a vote for KIP-1011.
>> This KIP is about replacing alterConfigs with incrementalAlterConfigs
>> when updating broker configs using kafka-configs.sh, this is similar
>> to
>> what we have done in KIP-894.
>> 
>> KIP link:
>> KIP-1011: Use incrementalAlterConfigs when updating broker configs by
>> kafka-configs.sh - Apache Kafka - Apache Software Foundation
>> <
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
>>> 
>> cwiki.apache.org
>> <
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
>>> 
>> [image: favicon.ico]
>> <
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
>>> 
>> <
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
>>> 
>> 
>> Discussion thread:
>> 
>> 
>> lists.apache.org
>> 
>> 
>> 
>> 
>> 
>> --,
>> Best,
>> Ziming
>> 
>> 
>> 

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Chris Egerton]

Hi David,

I've only briefly skimmed KAFKA-10140 but it seems that it may only apply
to append/subtract operations on list-type properties. If my understanding
is correct then this shouldn't be a problem for the KIP since we only use
the set/delete operations in the kafka-configs.sh script. If the scope of
the issue extends beyond those operations, then I agree that changes are
warranted to the KIP.

Cheers,

Chris

On Mon, Jan 22, 2024 at 5:23 AM David Jacot 
wrote:

> Hi Ziming,
>
> Thanks for driving this. I wanted to bring KAFKA-10140
>  to your attention. It
> looks like the incremental API does not work for configuring plugins. I
> think that we need to cover this in the KIP.
>
> Best,
> David
>
> On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
> andrew_schofield_j...@outlook.com> wrote:
>
> > +1 (non-binding)
> >
> > Thanks,
> > Andrew
> >
> > > On 22 Jan 2024, at 07:29, Federico Valeri 
> wrote:
> > >
> > > +1 (non binding)
> > >
> > > Thanks.
> > >
> > > On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
> > >>
> > >> Hi Ziming,
> > >>
> > >> +1(binding) from me.
> > >>
> > >> Thanks.
> > >> Luke
> > >>
> > >> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
> > >> kamal.chandraprak...@gmail.com> wrote:
> > >>
> > >>> +1 (non-binding)
> > >>>
> > >>> On Mon, Jan 22, 2024 at 8:34 AM ziming deng <
> dengziming1...@gmail.com>
> > >>> wrote:
> > >>>
> >  Hello everyone,
> >  I'd like to initiate a vote for KIP-1011.
> >  This KIP is about replacing alterConfigs with
> incrementalAlterConfigs
> >  when updating broker configs using kafka-configs.sh, this is similar
> > to
> >  what we have done in KIP-894.
> > 
> >  KIP link:
> >  KIP-1011: Use incrementalAlterConfigs when updating broker configs
> by
> >  kafka-configs.sh - Apache Kafka - Apache Software Foundation
> >  <
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> > >
> >  cwiki.apache.org
> >  <
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> > >
> >  [image: favicon.ico]
> >  <
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> > >
> >  <
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> > >
> > 
> >  Discussion thread:
> > 
> > 
> >  lists.apache.org
> >  
> >  
> >  
> > 
> > 
> >  --,
> >  Best,
> >  Ziming
> >
> >
> >
>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[David Jacot]

Hi Ziming,

Thanks for driving this. I wanted to bring KAFKA-10140
 to your attention. It
looks like the incremental API does not work for configuring plugins. I
think that we need to cover this in the KIP.

Best,
David

On Mon, Jan 22, 2024 at 10:13 AM Andrew Schofield <
andrew_schofield_j...@outlook.com> wrote:

> +1 (non-binding)
>
> Thanks,
> Andrew
>
> > On 22 Jan 2024, at 07:29, Federico Valeri  wrote:
> >
> > +1 (non binding)
> >
> > Thanks.
> >
> > On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
> >>
> >> Hi Ziming,
> >>
> >> +1(binding) from me.
> >>
> >> Thanks.
> >> Luke
> >>
> >> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
> >> kamal.chandraprak...@gmail.com> wrote:
> >>
> >>> +1 (non-binding)
> >>>
> >>> On Mon, Jan 22, 2024 at 8:34 AM ziming deng 
> >>> wrote:
> >>>
>  Hello everyone,
>  I'd like to initiate a vote for KIP-1011.
>  This KIP is about replacing alterConfigs with incrementalAlterConfigs
>  when updating broker configs using kafka-configs.sh, this is similar
> to
>  what we have done in KIP-894.
> 
>  KIP link:
>  KIP-1011: Use incrementalAlterConfigs when updating broker configs by
>  kafka-configs.sh - Apache Kafka - Apache Software Foundation
>  <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >
>  cwiki.apache.org
>  <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >
>  [image: favicon.ico]
>  <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >
>  <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh
> >
> 
>  Discussion thread:
> 
> 
>  lists.apache.org
>  
>  
>  
> 
> 
>  --,
>  Best,
>  Ziming
>
>
>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Andrew Schofield]

+1 (non-binding)

Thanks,
Andrew

> On 22 Jan 2024, at 07:29, Federico Valeri  wrote:
>
> +1 (non binding)
>
> Thanks.
>
> On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
>>
>> Hi Ziming,
>>
>> +1(binding) from me.
>>
>> Thanks.
>> Luke
>>
>> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
>> kamal.chandraprak...@gmail.com> wrote:
>>
>>> +1 (non-binding)
>>>
>>> On Mon, Jan 22, 2024 at 8:34 AM ziming deng 
>>> wrote:
>>>
 Hello everyone,
 I'd like to initiate a vote for KIP-1011.
 This KIP is about replacing alterConfigs with incrementalAlterConfigs
 when updating broker configs using kafka-configs.sh, this is similar to
 what we have done in KIP-894.

 KIP link:
 KIP-1011: Use incrementalAlterConfigs when updating broker configs by
 kafka-configs.sh - Apache Kafka - Apache Software Foundation
 
 cwiki.apache.org
 
 [image: favicon.ico]
 
 

 Discussion thread:


 lists.apache.org
 
 
 


 --,
 Best,
 Ziming

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Federico Valeri]

+1 (non binding)

Thanks.

On Mon, Jan 22, 2024 at 7:03 AM Luke Chen  wrote:
>
> Hi Ziming,
>
> +1(binding) from me.
>
> Thanks.
> Luke
>
> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
> kamal.chandraprak...@gmail.com> wrote:
>
> > +1 (non-binding)
> >
> > On Mon, Jan 22, 2024 at 8:34 AM ziming deng 
> > wrote:
> >
> >> Hello everyone,
> >> I'd like to initiate a vote for KIP-1011.
> >> This KIP is about replacing alterConfigs with incrementalAlterConfigs
> >> when updating broker configs using kafka-configs.sh, this is similar to
> >> what we have done in KIP-894.
> >>
> >> KIP link:
> >> KIP-1011: Use incrementalAlterConfigs when updating broker configs by
> >> kafka-configs.sh - Apache Kafka - Apache Software Foundation
> >> 
> >> cwiki.apache.org
> >> 
> >> [image: favicon.ico]
> >> 
> >> 
> >>
> >> Discussion thread:
> >>
> >>
> >> lists.apache.org
> >> 
> >> 
> >> 
> >>
> >>
> >> --,
> >> Best,
> >> Ziming
> >>
> >

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Luke Chen]

Hi Ziming,

+1(binding) from me.

Thanks.
Luke

On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash <
kamal.chandraprak...@gmail.com> wrote:

> +1 (non-binding)
>
> On Mon, Jan 22, 2024 at 8:34 AM ziming deng 
> wrote:
>
>> Hello everyone,
>> I'd like to initiate a vote for KIP-1011.
>> This KIP is about replacing alterConfigs with incrementalAlterConfigs
>> when updating broker configs using kafka-configs.sh, this is similar to
>> what we have done in KIP-894.
>>
>> KIP link:
>> KIP-1011: Use incrementalAlterConfigs when updating broker configs by
>> kafka-configs.sh - Apache Kafka - Apache Software Foundation
>> 
>> cwiki.apache.org
>> 
>> [image: favicon.ico]
>> 
>> 
>>
>> Discussion thread:
>>
>>
>> lists.apache.org
>> 
>> 
>> 
>>
>>
>> --,
>> Best,
>> Ziming
>>
>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

[Kamal Chandraprakash]

+1 (non-binding)

On Mon, Jan 22, 2024 at 8:34 AM ziming deng 
wrote:

> Hello everyone,
> I'd like to initiate a vote for KIP-1011.
> This KIP is about replacing alterConfigs with incrementalAlterConfigs when
> updating broker configs using kafka-configs.sh, this is similar to what we
> have done in KIP-894.
>
> KIP link:
> KIP-1011: Use incrementalAlterConfigs when updating broker configs by
> kafka-configs.sh - Apache Kafka - Apache Software Foundation
> 
> cwiki.apache.org
> 
> [image: favicon.ico]
> 
> 
>
> Discussion thread:
>
>
> lists.apache.org
> 
> 
> 
>
>
> --,
> Best,
> Ziming
>