Re: [VOTE] Switch to GitHub pull requests for new contributions
Ewen, This is quite useful. I used the command that is suggested in the ASFBot comment: git pull https://github.com/[contribuer-name]/kafka KAFKA- to apply the patch locally. But this would actually better I think, just that it requires installing hub first. Maybe we can add this to the wiki as well? Guozhang On Thu, Jul 23, 2015 at 9:32 PM, Ewen Cheslack-Postava e...@confluent.io wrote: +1 (non-binding) One other thing that might be worth mentioning in The Review Process section is the hub tool: https://hub.github.com/ I only ever use one feature, but it's immensely useful if you're reviewing PRs on Github. You can just copy the URL into a command to checkout the PR branch: hub checkout https://github.com/apache/kafka/pull/95 -Ewen On Wed, Jul 22, 2015 at 1:26 PM, Ismael Juma ism...@juma.me.uk wrote: Hi, On 22 Jul 2015 19:32, Jiangjie Qin j...@linkedin.com.invalid wrote: +1 (non binding) Can we have a wiki for procedure and let people verify the steps? After that we can update the Apache project page. Yes, I linked to the page in the original message: https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes Committers and contributors have provided feedback in previous discussions in the mailing list. Further improvements are welcome, of course. Also see KAFKA-2321 and KAFKA-2349 for updates to the website and GitHub's CONTRIBUTING.md. Ismael -- Thanks, Ewen -- -- Guozhang
Re: [VOTE] Switch to GitHub pull requests for new contributions
Hi Ewen, On Fri, Jul 24, 2015 at 5:32 AM, Ewen Cheslack-Postava e...@confluent.io wrote: One other thing that might be worth mentioning in The Review Process section is the hub tool: https://hub.github.com/ I only ever use one feature, but it's immensely useful if you're reviewing PRs on Github. You can just copy the URL into a command to checkout the PR branch: hub checkout https://github.com/apache/kafka/pull/95 This is a good point. Maybe worth adding some information on the wiki page for committers? https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review Best, Ismael
Re: [VOTE] Switch to GitHub pull requests for new contributions
Thank you for voting. 72 hours have elapsed and the vote has passed with 4 binding +1s. There were also 8 non-binding +1s. I removed the In Progress warning from: https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes It would be good for a committer to review (and eventually merge) the changes in the following two JIRA tickets: * https://issues.apache.org/jira/browse/KAFKA-2349 * https://issues.apache.org/jira/browse/KAFKA-2321 To be clear, this vote doesn't affect existing contributions in Review Board and JIRA. That is still an acceptable way to contribute. It is likely that people will move to the new way gradually and organically. At some point, a separate discussion may be started about requiring the new way, but let's see how it goes. Best, Ismael On Tue, Jul 21, 2015 at 12:28 PM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 (non-binding) One other thing that might be worth mentioning in The Review Process section is the hub tool: https://hub.github.com/ I only ever use one feature, but it's immensely useful if you're reviewing PRs on Github. You can just copy the URL into a command to checkout the PR branch: hub checkout https://github.com/apache/kafka/pull/95 -Ewen On Wed, Jul 22, 2015 at 1:26 PM, Ismael Juma ism...@juma.me.uk wrote: Hi, On 22 Jul 2015 19:32, Jiangjie Qin j...@linkedin.com.invalid wrote: +1 (non binding) Can we have a wiki for procedure and let people verify the steps? After that we can update the Apache project page. Yes, I linked to the page in the original message: https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes Committers and contributors have provided feedback in previous discussions in the mailing list. Further improvements are welcome, of course. Also see KAFKA-2321 and KAFKA-2349 for updates to the website and GitHub's CONTRIBUTING.md. Ismael -- Thanks, Ewen
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 (non binding) Can we have a wiki for procedure and let people verify the steps? After that we can update the Apache project page. On Tue, Jul 21, 2015 at 5:38 PM, Edward Ribeiro edward.ribe...@gmail.com wrote: +1 (non binding) On Tue, Jul 21, 2015 at 7:36 PM, Jay Kreps j...@confluent.io wrote: +1 -Jay On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
Re: [VOTE] Switch to GitHub pull requests for new contributions
Hi, On 22 Jul 2015 19:32, Jiangjie Qin j...@linkedin.com.invalid wrote: +1 (non binding) Can we have a wiki for procedure and let people verify the steps? After that we can update the Apache project page. Yes, I linked to the page in the original message: https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes Committers and contributors have provided feedback in previous discussions in the mailing list. Further improvements are welcome, of course. Also see KAFKA-2321 and KAFKA-2349 for updates to the website and GitHub's CONTRIBUTING.md. Ismael
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 . I think phasing out a good idea but rather than x months we should move to github PRs for any new JIRAs that are not already in review board. For the JIRA’s that are in review board we can continue to use that until they merged in. -Harsha On July 21, 2015 at 8:11:17 AM, Ashish Singh (asi...@cloudera.com) wrote: +1 non-binding. A suggestion, we should try to phase out old system of reviews gradually, instead of forcing it over a night. Maybe a time bound switch? We can say like in x months from now we will completely move to PRs? On Tuesday, July 21, 2015, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes -- Ashish h
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 (binding) Agree with Ismael. We may not want to rush to push the PR right away. Having said that, if it works well with say, 10 patches, I'd consider that enough to require the new JIRAs to submit patches using the PRs instead. Thanks, Neha On Tue, Jul 21, 2015 at 8:19 AM, Sriharsha Chintalapani harsh...@fastmail.fm wrote: +1 . I think phasing out a good idea but rather than x months we should move to github PRs for any new JIRAs that are not already in review board. For the JIRA’s that are in review board we can continue to use that until they merged in. -Harsha On July 21, 2015 at 8:11:17 AM, Ashish Singh (asi...@cloudera.com) wrote: +1 non-binding. A suggestion, we should try to phase out old system of reviews gradually, instead of forcing it over a night. Maybe a time bound switch? We can say like in x months from now we will completely move to PRs? On Tuesday, July 21, 2015, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes -- Ashish h -- Thanks, Neha
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 non-binding. A suggestion, we should try to phase out old system of reviews gradually, instead of forcing it over a night. Maybe a time bound switch? We can say like in x months from now we will completely move to PRs? On Tuesday, July 21, 2015, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes -- Ashish h
Re: [VOTE] Switch to GitHub pull requests for new contributions
On Tue, Jul 21, 2015 at 4:11 PM, Ashish Singh asi...@cloudera.com wrote: +1 non-binding. A suggestion, we should try to phase out old system of reviews gradually, instead of forcing it over a night. I agree. Maybe a time bound switch? We can say like in x months from now we will completely move to PRs? Not sure if we need this to start with. Maybe we just encourage the new way for new contributions and update the documentation and see how it goes. If the transition is a bit slow, we can have a discussion about setting a time bound. Best, Ismael
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 (non binding) On Tue, Jul 21, 2015 at 7:36 PM, Jay Kreps j...@confluent.io wrote: +1 -Jay On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 non-binding On Tue, Jul 21, 2015 at 11:19 AM, Neha Narkhede n...@confluent.io wrote: +1 (binding) Agree with Ismael. We may not want to rush to push the PR right away. Having said that, if it works well with say, 10 patches, I'd consider that enough to require the new JIRAs to submit patches using the PRs instead. Thanks, Neha On Tue, Jul 21, 2015 at 8:19 AM, Sriharsha Chintalapani harsh...@fastmail.fm wrote: +1 . I think phasing out a good idea but rather than x months we should move to github PRs for any new JIRAs that are not already in review board. For the JIRA’s that are in review board we can continue to use that until they merged in. -Harsha On July 21, 2015 at 8:11:17 AM, Ashish Singh (asi...@cloudera.com) wrote: +1 non-binding. A suggestion, we should try to phase out old system of reviews gradually, instead of forcing it over a night. Maybe a time bound switch? We can say like in x months from now we will completely move to PRs? On Tuesday, July 21, 2015, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes -- Ashish h -- Thanks, Neha -- Grant Henke Solutions Consultant | Cloudera ghe...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 On Tue, Jul 21, 2015 at 9:31 AM, Grant Henke ghe...@cloudera.com wrote: +1 non-binding On Tue, Jul 21, 2015 at 11:19 AM, Neha Narkhede n...@confluent.io wrote: +1 (binding) Agree with Ismael. We may not want to rush to push the PR right away. Having said that, if it works well with say, 10 patches, I'd consider that enough to require the new JIRAs to submit patches using the PRs instead. Thanks, Neha On Tue, Jul 21, 2015 at 8:19 AM, Sriharsha Chintalapani harsh...@fastmail.fm wrote: +1 . I think phasing out a good idea but rather than x months we should move to github PRs for any new JIRAs that are not already in review board. For the JIRA’s that are in review board we can continue to use that until they merged in. -Harsha On July 21, 2015 at 8:11:17 AM, Ashish Singh (asi...@cloudera.com) wrote: +1 non-binding. A suggestion, we should try to phase out old system of reviews gradually, instead of forcing it over a night. Maybe a time bound switch? We can say like in x months from now we will completely move to PRs? On Tuesday, July 21, 2015, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes -- Ashish h -- Thanks, Neha -- Grant Henke Solutions Consultant | Cloudera ghe...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke -- -- Guozhang
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 (binding) on using PRs. It sounds like we need additional discussion on how the transition will happen. Maybe move that to a separate thread, to keep the vote easy to follow. On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 (non-binding) Thanks Parth On 7/21/15, 10:24 AM, Gwen Shapira gshap...@cloudera.com wrote: +1 (binding) on using PRs. It sounds like we need additional discussion on how the transition will happen. Maybe move that to a separate thread, to keep the vote easy to follow. On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Chang es
Re: [VOTE] Switch to GitHub pull requests for new contributions
+1 -Jay On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull requests for new contributions In a previous discussion[1], everyone that participated was in favour. It's also worth reading the Contributing Code Changes wiki page[2] (if you haven't already) to understand the flow. A number of pull requests have been merged in the last few weeks to test this flow and I believe it's working well enough. As usual, there is always room for improvement and I expect is to tweak things as time goes on. The main downside of using GitHub pull requests is that we don't have write access to https://github.com/apache/kafka. That means that we rely on commit hooks to close integrated pull requests (the merge script takes care of formatting the message so that this happens) and the PR creator or Apache Infra to close pull requests that are not integrated. Regarding existing contributions, I think it's up to the contributor to decide whether they want to resubmit it as a pull request or not. I expect that there will be a transition period where the old and new way will co-exist. But that can be discussed separately. The vote will run for 72 hours. +1 (non-binding) from me. Best, Ismael [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 [2] https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
