Re: Review Request 59048: Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server
> On May 15, 2017, 6:40 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > > Lines 1054 (patched) > > <https://reviews.apache.org/r/59048/diff/1/?file=1710363#file1710363line1054> > > > > Can we add test case to check the max limit ? Yes.Doing that. > On May 15, 2017, 6:40 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java > > Line 58 (original), 59 (patched) > > <https://reviews.apache.org/r/59048/diff/1/?file=1710365#file1710365line59> > > > > Should we have this in InMemory result Set construtor instead or get it > > from a static method (since this is a server level config and should not be > > overridable via query or session params) ? Open to discussion ... I think in that case we need to change every implementation. Also, by design this can't be overwritten by the query conf as it is a a server conf. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59048/#review174926 ------- On May 8, 2017, 12:44 p.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59048/ > --- > > (Updated May 8, 2017, 12:44 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: lens-981 > https://issues.apache.org/jira/browse/lens-981 > > > Repository: lens > > > Description > --- > > See LENS-981 > > > Diffs > - > > lens-api/src/main/resources/lens-errors.conf 43de1e9 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 7fd487c > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > 535065d > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java > 805b0c1 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java > 774f1ee > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensServerAPIErrorCode.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > 2a34c68 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > e70d290 > lens-server/src/main/resources/lensserver-default.xml 28b1db2 > > > Diff: https://reviews.apache.org/r/59048/diff/1/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Review Request 59048: Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59048/ --- Review request for lens and Puneet Gupta. Bugs: lens-981 https://issues.apache.org/jira/browse/lens-981 Repository: lens Description --- See LENS-981 Diffs - lens-api/src/main/resources/lens-errors.conf 43de1e9 lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7fd487c lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 535065d lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 805b0c1 lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java 774f1ee lens-server-api/src/main/java/org/apache/lens/server/api/error/LensServerAPIErrorCode.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 2a34c68 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java e70d290 lens-server/src/main/resources/lensserver-default.xml 28b1db2 Diff: https://reviews.apache.org/r/59048/diff/1/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1413) Estimates failing with Task rejection errors
[ https://issues.apache.org/jira/browse/LENS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1413: -- Status: Patch Available (was: Open) > Estimates failing with Task rejection errors > > > Key: LENS-1413 > URL: https://issues.apache.org/jira/browse/LENS-1413 > Project: Apache Lens > Issue Type: Bug > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1413.patch > > > # Cancel estimates for other drivers when the estimate pool queue is full. > # Return the appropriate error message -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1413) Estimates failing with Task rejection errors
[ https://issues.apache.org/jira/browse/LENS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1413: -- Attachment: LENS-1413.patch > Estimates failing with Task rejection errors > > > Key: LENS-1413 > URL: https://issues.apache.org/jira/browse/LENS-1413 > Project: Apache Lens > Issue Type: Bug > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1413.patch > > > # Cancel estimates for other drivers when the estimate pool queue is full. > # Return the appropriate error message -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 58604: Handle Estimates failing with task rejection errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/ --- (Updated April 24, 2017, 11:43 a.m.) Review request for lens. Bugs: LENS-1413 https://issues.apache.org/jira/browse/LENS-1413 Repository: lens Description --- 1. Cancel estimates for other drivers when the estimate pool queue is full. 2. Return the appropriate error message Diffs (updated) - lens-api/src/main/resources/lens-errors.conf 236d678 lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 14a31e2 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c6fbeda lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 7e9133e lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 7d8c977 lens-server/src/test/resources/lens-site.xml 334a9c4 Diff: https://reviews.apache.org/r/58604/diff/4/ Changes: https://reviews.apache.org/r/58604/diff/3-4/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 58604: Handle Estimates failing with task rejection errors
> On April 21, 2017, 9:34 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > > Lines 1716 (patched) > > <https://reviews.apache.org/r/58604/diff/1/?file=1697059#file1697059line1716> > > > > Not sure if logging the driver name makes sense. Also Should we log > > this as error or warning is debatable ? hmm. I guess logging does not hurt.. we can see which ones were rejected and which ones were cancelled. > On April 21, 2017, 9:34 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > > Lines 1722 (patched) > > <https://reviews.apache.org/r/58604/diff/1/?file=1697059#file1697059line1722> > > > > can we use for(RewriteEstimateRunnable r : runnables) instead ? uh. In this loop we are fetching from two lists. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/#review172619 ----------- On April 21, 2017, 12:10 p.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58604/ > --- > > (Updated April 21, 2017, 12:10 p.m.) > > > Review request for lens. > > > Bugs: LENS-1413 > https://issues.apache.org/jira/browse/LENS-1413 > > > Repository: lens > > > Description > --- > > 1. Cancel estimates for other drivers when the estimate pool queue is full. > 2. Return the appropriate error message > > > Diffs > - > > lens-api/src/main/resources/lens-errors.conf 236d678 > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > 14a31e2 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c6fbeda > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 7e9133e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7d8c977 > lens-server/src/test/resources/lens-site.xml 334a9c4 > > > Diff: https://reviews.apache.org/r/58604/diff/3/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 58604: Handle Estimates failing with task rejection errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/ --- (Updated April 21, 2017, 12:10 p.m.) Review request for lens. Bugs: LENS-1413 https://issues.apache.org/jira/browse/LENS-1413 Repository: lens Description --- 1. Cancel estimates for other drivers when the estimate pool queue is full. 2. Return the appropriate error message Diffs (updated) - lens-api/src/main/resources/lens-errors.conf 236d678 lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 14a31e2 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c6fbeda lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 7e9133e lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 7d8c977 lens-server/src/test/resources/lens-site.xml 334a9c4 Diff: https://reviews.apache.org/r/58604/diff/3/ Changes: https://reviews.apache.org/r/58604/diff/2-3/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 58604: Handle Estimates failing with task rejection errors
> On April 21, 2017, 11:49 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > > Lines 68 (patched) > > <https://reviews.apache.org/r/58604/diff/2/?file=1697178#file1697178line68> > > > > Should not be going into Cube errors, should be moved to > > LensServerErrorCode. > > > > And accordingly change error code and position in lens-errors sure. > On April 21, 2017, 11:49 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > > Lines 1988 (patched) > > <https://reviews.apache.org/r/58604/diff/2/?file=1697181#file1697181line2100> > > > > why is it only 10, when 20 threads are launched? Typo. > On April 21, 2017, 11:49 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > > Lines 1989 (patched) > > <https://reviews.apache.org/r/58604/diff/2/?file=1697181#file1697181line2101> > > > > Should we be joining for all vs interrupt them and join? Interrupting > > would reduce test time. Only few threads will go to FailQueryDriver. Interrupting might not simulate the rejection error. > On April 21, 2017, 11:49 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > > Lines 1991 (patched) > > <https://reviews.apache.org/r/58604/diff/2/?file=1697181#file1697181line2103> > > > > Add assert for howmany failed as well. number of failures are not totally deterministic. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/#review172628 --- On April 21, 2017, 11:40 a.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58604/ > --- > > (Updated April 21, 2017, 11:40 a.m.) > > > Review request for lens. > > > Bugs: LENS-1413 > https://issues.apache.org/jira/browse/LENS-1413 > > > Repository: lens > > > Description > --- > > 1. Cancel estimates for other drivers when the estimate pool queue is full. > 2. Return the appropriate error message > > > Diffs > - > > lens-api/src/main/resources/lens-errors.conf 236d678 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > babe3de > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c6fbeda > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 7e9133e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7d8c977 > lens-server/src/test/resources/lens-site.xml 334a9c4 > > > Diff: https://reviews.apache.org/r/58604/diff/2/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 58604: Handle Estimates failing with task rejection errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/ --- (Updated April 21, 2017, 11:40 a.m.) Review request for lens. Bugs: LENS-1413 https://issues.apache.org/jira/browse/LENS-1413 Repository: lens Description --- 1. Cancel estimates for other drivers when the estimate pool queue is full. 2. Return the appropriate error message Diffs (updated) - lens-api/src/main/resources/lens-errors.conf 236d678 lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java babe3de lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c6fbeda lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 7e9133e lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 7d8c977 lens-server/src/test/resources/lens-site.xml 334a9c4 Diff: https://reviews.apache.org/r/58604/diff/2/ Changes: https://reviews.apache.org/r/58604/diff/1-2/ Testing --- Thanks, Lavkesh Lahngir
Review Request 58604: Handle Estimates failing with task rejection errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/ --- Review request for lens. Bugs: LENS-1413 https://issues.apache.org/jira/browse/LENS-1413 Repository: lens Description --- 1. Cancel estimates for other drivers when the estimate pool queue is full. 2. Return the appropriate error message Diffs - lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 92724c6 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c6fbeda lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 7d8c977 lens-server/src/test/resources/lens-site.xml 334a9c4 Diff: https://reviews.apache.org/r/58604/diff/1/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: 0001-LENS-1410.patch > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-LENS-1410.patch, LENS-1410.1.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: (was: LENS-1410.patch) > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.1.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: LENS-1410.1.patch > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.1.patch, LENS-1410.patch, LENS-1410.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: (was: LENS-1410.patch) > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.1.patch, LENS-1410.patch, LENS-1410.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 58338: LENS-1410
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58338/ --- (Updated April 19, 2017, 6:57 a.m.) Review request for lens and Amareshwari Sriramadasu. Bugs: LENS-1410 https://issues.apache.org/jira/browse/LENS-1410 Repository: lens Description --- A string filer for getting for partition api must tbe provided Diffs (updated) - lens-api/src/main/resources/lens-errors.conf 94505ef lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 9ea887a lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java befe4e6 lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java f176078 lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java d98c4c5 lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9ba1eb1 lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77 lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 064da01 Diff: https://reviews.apache.org/r/58338/diff/4/ Changes: https://reviews.apache.org/r/58338/diff/3-4/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: LENS-1391.1.patch > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.1.patch, LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: (was: LENS-1391.patch) > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 58496: Review comments on the MaxCoveringFactResolver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58496/ --- Review request for lens and Puneet Gupta. Bugs: LENS-1391 https://issues.apache.org/jira/browse/LENS-1391 Repository: lens Description --- Comments and cleanup Diffs - lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 1c0d356 lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java a9bd164 lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 34180d1 lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java d95cf27 lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 064da01 Diff: https://reviews.apache.org/r/58496/diff/1/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: (was: LENS-1391.patch) > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: (was: LENS-1391.patch) > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: (was: LENS-1391.patch) > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: LENS-1391.patch > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch, LENS-1391.patch, LENS-1391.patch, > LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: LENS-1391.patch > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch, LENS-1391.patch, LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: (was: LENS-1391.patch) > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch, LENS-1391.patch, LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: LENS-1391.patch > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch, LENS-1391.patch, LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: LENS-1391.patch > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch, LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: LENS-1410.patch > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.patch, LENS-1410.patch, LENS-1410.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 58338: LENS-1410
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58338/ --- (Updated April 12, 2017, 2:25 p.m.) Review request for lens and Amareshwari Sriramadasu. Bugs: LENS-1410 https://issues.apache.org/jira/browse/LENS-1410 Repository: lens Description --- A string filer for getting for partition api must tbe provided Diffs (updated) - lens-api/src/main/resources/lens-errors.conf 29e24cf lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 9ea887a lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java f176078 lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 571b481 lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9d823da lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77 Diff: https://reviews.apache.org/r/58338/diff/3/ Changes: https://reviews.apache.org/r/58338/diff/2-3/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: LENS-1410.patch > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.patch, LENS-1410.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 58338: LENS-1410
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58338/ --- (Updated April 11, 2017, 11:58 a.m.) Review request for lens and Amareshwari Sriramadasu. Bugs: LENS-1410 https://issues.apache.org/jira/browse/LENS-1410 Repository: lens Description --- A string filer for getting for partition api must tbe provided Diffs (updated) - lens-api/src/main/resources/lens-errors.conf 29e24cf lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 571b481 lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9d823da lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77 Diff: https://reviews.apache.org/r/58338/diff/2/ Changes: https://reviews.apache.org/r/58338/diff/1-2/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: (was: LENS-1410.patch) > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: LENS-1410.patch > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.patch, LENS-1410.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 58338: LENS-1410
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58338/ --- Review request for lens and Amareshwari Sriramadasu. Bugs: LENS-1410 https://issues.apache.org/jira/browse/LENS-1410 Repository: lens Description --- A string filer for getting for partition api must tbe provided Diffs - lens-api/src/main/resources/lens-errors.conf 29e24cf lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 571b481 lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9d823da Diff: https://reviews.apache.org/r/58338/diff/1/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Status: Patch Available (was: Open) > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1410) Make the filter while getting a list of partitions mandatory
[ https://issues.apache.org/jira/browse/LENS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1410: -- Attachment: LENS-1410.patch > Make the filter while getting a list of partitions mandatory > - > > Key: LENS-1410 > URL: https://issues.apache.org/jira/browse/LENS-1410 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1410.patch > > > Make the filter while getting a list of partitions mandatory -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1409) Remove Unknown.log file before lens startup
[ https://issues.apache.org/jira/browse/LENS-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1409: -- Attachment: default_query_id.patch > Remove Unknown.log file before lens startup > --- > > Key: LENS-1409 > URL: https://issues.apache.org/jira/browse/LENS-1409 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: default_query_id.patch > > > unknown.log is created and appended if queryId is not defined. it is reaching > a large size. We can delete it while lens-server startup. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1409) Remove Unknown.log file before lens startup
[ https://issues.apache.org/jira/browse/LENS-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1409: -- Status: Patch Available (was: Open) > Remove Unknown.log file before lens startup > --- > > Key: LENS-1409 > URL: https://issues.apache.org/jira/browse/LENS-1409 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: default_query_id.patch > > > unknown.log is created and appended if queryId is not defined. it is reaching > a large size. We can delete it while lens-server startup. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 58302: remove unknown.log before lens startup
> On April 11, 2017, 6:41 a.m., Amareshwari Sriramadasu wrote: > > Can you update the verification done? I Built this locally and tested. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58302/#review171527 --- On April 11, 2017, 9:12 a.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58302/ > --- > > (Updated April 11, 2017, 9:12 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-1409 > https://issues.apache.org/jira/browse/LENS-1409 > > > Repository: lens > > > Description > --- > > Clean up task before startup > > > Diffs > - > > tools/conf/server/logback.xml 5173321 > tools/scripts/lens-ctl 6e1d363 > > > Diff: https://reviews.apache.org/r/58302/diff/2/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 58302: remove unknown.log before lens startup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58302/ --- (Updated April 11, 2017, 9:12 a.m.) Review request for lens and Amareshwari Sriramadasu. Bugs: LENS-1409 https://issues.apache.org/jira/browse/LENS-1409 Repository: lens Description --- Clean up task before startup Diffs (updated) - tools/conf/server/logback.xml 5173321 tools/scripts/lens-ctl 6e1d363 Diff: https://reviews.apache.org/r/58302/diff/2/ Changes: https://reviews.apache.org/r/58302/diff/1-2/ Testing --- Thanks, Lavkesh Lahngir
Review Request 58302: remove unknown.log before lens startup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58302/ --- Review request for lens and Amareshwari Sriramadasu. Bugs: LENS-1409 https://issues.apache.org/jira/browse/LENS-1409 Repository: lens Description --- Clean up task before startup Diffs - tools/conf/server/logback.xml 5173321 tools/scripts/lens-ctl 6e1d363 Diff: https://reviews.apache.org/r/58302/diff/1/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Status: Patch Available (was: Open) > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381
[ https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1391: -- Attachment: LENS-1391.patch > Review comments for MaxCoveringFactResolver and LeastPartitionResolver On > branch lens-1381 > -- > > Key: LENS-1391 > URL: https://issues.apache.org/jira/browse/LENS-1391 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Attachments: LENS-1391.patch > > > Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1393) Update the javax mail version to current
[ https://issues.apache.org/jira/browse/LENS-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1393: -- Status: Patch Available (was: Open) > Update the javax mail version to current > > > Key: LENS-1393 > URL: https://issues.apache.org/jira/browse/LENS-1393 > Project: Apache Lens > Issue Type: Task > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1393.patch > > > Sending mail with the older version of javax mail was causing threads to > stuck because of connection timeout to the mail server was not honored. > Updating to the new version solves the problem. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/ --- (Updated Feb. 21, 2017, 12:12 p.m.) Review request for lens. Bugs: LENS-1391 https://issues.apache.org/jira/browse/LENS-1391 Repository: lens Description --- MaxCoveringFactResolver and LeastPartitionResolver review comments Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java c7f2047 lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 153df24 lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4664cde lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java fca86ec Diff: https://reviews.apache.org/r/56858/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/ --- (Updated Feb. 21, 2017, 11:19 a.m.) Review request for lens. Bugs: LENS-1391 https://issues.apache.org/jira/browse/LENS-1391 Repository: lens Description --- MaxCoveringFactResolver and LeastPartitionResolver review comments Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java c7f2047 lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 153df24 lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4664cde lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java fca86ec Diff: https://reviews.apache.org/r/56858/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver
> On Feb. 21, 2017, 7:11 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java, > > line 156 > > <https://reviews.apache.org/r/56858/diff/1/?file=1640583#file1640583line156> > > > > Removed ? This is being calculated unnecessary. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/#review166126 --- On Feb. 21, 2017, 10:10 a.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56858/ > --- > > (Updated Feb. 21, 2017, 10:10 a.m.) > > > Review request for lens. > > > Bugs: LENS-1391 > https://issues.apache.org/jira/browse/LENS-1391 > > > Repository: lens > > > Description > --- > > MaxCoveringFactResolver and LeastPartitionResolver review comments > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > c7f2047 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 153df24 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 4664cde > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fca86ec > > Diff: https://reviews.apache.org/r/56858/diff/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
[jira] [Created] (LENS-1393) Update the javax mail version to current
Lavkesh Lahngir created LENS-1393: - Summary: Update the javax mail version to current Key: LENS-1393 URL: https://issues.apache.org/jira/browse/LENS-1393 Project: Apache Lens Issue Type: Task Components: server Reporter: Lavkesh Lahngir Assignee: Lavkesh Lahngir Sending mail with the older version of javax mail was causing threads to stuck because of connection timeout to the mail server was not honored. Updating to the new version solves the problem. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/ --- (Updated Feb. 21, 2017, 10:10 a.m.) Review request for lens. Bugs: LENS-1391 https://issues.apache.org/jira/browse/LENS-1391 Repository: lens Description --- MaxCoveringFactResolver and LeastPartitionResolver review comments Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java c7f2047 lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 153df24 lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4664cde lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java fca86ec Diff: https://reviews.apache.org/r/56858/diff/ Testing --- Thanks, Lavkesh Lahngir
Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/ --- Review request for lens. Bugs: LENS-1391 https://issues.apache.org/jira/browse/LENS-1391 Repository: lens Description --- MaxCoveringFactResolver and LeastPartitionResolver review comments Diffs - lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java c7f2047b57ebc26244891d9bc48ad18ab0176fdd lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 153df245cd2b79ee29991f98df36f57e4e029d2f lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4664cde1786c2e6217a0d7aa7a26d1cc248bf532 lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 Diff: https://reviews.apache.org/r/56858/diff/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Created] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On brach lens-1381
Lavkesh Lahngir created LENS-1391: - Summary: Review comments for MaxCoveringFactResolver and LeastPartitionResolver On brach lens-1381 Key: LENS-1391 URL: https://issues.apache.org/jira/browse/LENS-1391 Project: Apache Lens Issue Type: Task Components: server Reporter: Lavkesh Lahngir Assignee: Lavkesh Lahngir Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1390) Bug fixes after LENS-1386
[ https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1390: -- Status: Patch Available (was: Open) > Bug fixes after LENS-1386 > - > > Key: LENS-1390 > URL: https://issues.apache.org/jira/browse/LENS-1390 > Project: Apache Lens > Issue Type: Bug > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1390.patch > > > Few necessary fixes to complete Lens-1386 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1390) Bug fixes after LENS-1386
[ https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1390: -- Attachment: LENS-1390.patch > Bug fixes after LENS-1386 > - > > Key: LENS-1390 > URL: https://issues.apache.org/jira/browse/LENS-1390 > Project: Apache Lens > Issue Type: Bug > Components: server > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1390.patch > > > Few necessary fixes to complete Lens-1386 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (LENS-1390) Bug fixes after LENS-1386
Lavkesh Lahngir created LENS-1390: - Summary: Bug fixes after LENS-1386 Key: LENS-1390 URL: https://issues.apache.org/jira/browse/LENS-1390 Project: Apache Lens Issue Type: Bug Components: server Reporter: Lavkesh Lahngir Assignee: Lavkesh Lahngir Few necessary fixes to complete Lens-1386 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1386) Add support for separate tables for update periods in one storage
[ https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1386: -- Status: Patch Available (was: Open) > Add support for separate tables for update periods in one storage > - > > Key: LENS-1386 > URL: https://issues.apache.org/jira/browse/LENS-1386 > Project: Apache Lens > Issue Type: Task > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1386.patch > > > Xsd and Metastore changes: > (1) New Xsd construct > (2) Create Fact Changes > (3) CubeMetastoreClient changes for update period table name > (4) Validation that TableDescription should only be available at either table > level or at update period level -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (LENS-1386) Add support for separate tables for update periods in one storage
[ https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1386: -- Attachment: LENS-1386.patch > Add support for separate tables for update periods in one storage > - > > Key: LENS-1386 > URL: https://issues.apache.org/jira/browse/LENS-1386 > Project: Apache Lens > Issue Type: Task > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: LENS-1386.patch > > > Xsd and Metastore changes: > (1) New Xsd construct > (2) Create Fact Changes > (3) CubeMetastoreClient changes for update period table name > (4) Validation that TableDescription should only be available at either table > level or at update period level -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/ --- (Updated Feb. 19, 2017, 4:26 a.m.) Review request for lens. Changes --- Final version with test cases fixes and review comments Bugs: LENS-1386 https://issues.apache.org/jira/browse/LENS-1386 Repository: lens Description --- A new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod Diffs (updated) - lens-api/src/main/resources/cube-0.1.xsd f438f48 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e21dc2a lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43 lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 0e6a4a1 Diff: https://reviews.apache.org/r/55712/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
> On Feb. 15, 2017, 4:17 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 2528 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632298#file1632298line2528> > > > > Please avoid using exceptions in normal flow. Why would > > getFactTable().getTablePrefix() throw exception? In the addpartitions() flow, the parent table can be a dimension which means the getFactTable() call will throw an exception. > On Feb. 15, 2017, 4:17 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > line 653 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632302#file1632302line653> > > > > Please avoid using exception in normal flow. This is added because of checkFactStorage() method. Because you could get dimention table also. > On Feb. 15, 2017, 4:17 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java, > > line 1877 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632304#file1632304line1877> > > > > What are these table names are for? These are set inside Storagetabledesc's location path. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review165641 --- On Feb. 13, 2017, 6:47 p.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > --- > > (Updated Feb. 13, 2017, 6:47 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > --- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 0e6a4a1 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
> On Feb. 14, 2017, 11:53 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 384 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632298#file1632298line384> > > > > If we are calling this for each updatePeriod separately even if the > > table is same for all updatePeriods, it can have huge impact on the time it > > takes to create timelines and requires huge memory to put all partitions. I will add a condition if (!uniqueStorageTables.contains(storageTableName)) then only fetch partitions. > On Feb. 14, 2017, 11:53 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 499 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632298#file1632298line499> > > > > no more required? what was it doing earlier which is not required now? The method code is merged with loadTimeLines() > On Feb. 14, 2017, 11:53 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 948 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632298#file1632298line948> > > > > Seems javadoc is wrong Yeah.. correcting it. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review165474 --- On Feb. 13, 2017, 6:47 p.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > --- > > (Updated Feb. 13, 2017, 6:47 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > --- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 0e6a4a1 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/ --- (Updated Feb. 13, 2017, 6:47 p.m.) Review request for lens. Changes --- Test cases added Bugs: LENS-1386 https://issues.apache.org/jira/browse/LENS-1386 Repository: lens Description --- A new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod Diffs (updated) - lens-api/src/main/resources/cube-0.1.xsd f438f48 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e21dc2a lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43 lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 0e6a4a1 Diff: https://reviews.apache.org/r/55712/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/ --- (Updated Feb. 4, 2017, 12:03 a.m.) Review request for lens. Changes --- Checkstyle changes Bugs: LENS-1386 https://issues.apache.org/jira/browse/LENS-1386 Repository: lens Description --- A new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod Diffs (updated) - lens-api/src/main/resources/cube-0.1.xsd f438f48 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e21dc2a lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43 Diff: https://reviews.apache.org/r/55712/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/ --- (Updated Jan. 31, 2017, 1:53 p.m.) Review request for lens. Changes --- Updated TimeLineCache and addded test case Bugs: LENS-1386 https://issues.apache.org/jira/browse/LENS-1386 Repository: lens Description --- A new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod Diffs (updated) - lens-api/src/main/resources/cube-0.1.xsd f438f48 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e21dc2a lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43 Diff: https://reviews.apache.org/r/55712/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
> On Jan. 24, 2017, 8:39 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java, > > line 111 > > <https://reviews.apache.org/r/55712/diff/2/?file=1612879#file1612879line111> > > > > Should this map be populated for Facts which are created before this > > feature as well? > > Amareshwari Sriramadasu wrote: > Reopening this, as i dont see any changes associated We can use this map to get storage_table_prefix when the storage name and updateperiod is given. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review162787 ----------- On Jan. 24, 2017, 2:57 p.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > --- > > (Updated Jan. 24, 2017, 2:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > --- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
> On Jan. 25, 2017, 8:16 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 344 > > <https://reviews.apache.org/r/55712/diff/3/?file=1613661#file1613661line344> > > > > If the method is returning Map of UpdatePeriod to PartitionTimeLine, I > > think updatePeriod should not passed as param. > > > > The method should populate the timeline for all updatePeriod, if > > required by pulling from different tables corresponding to each > > updatePeriod. Then we should pass the table name prefix which is the key of PartitionTimelineCache. > On Jan. 25, 2017, 8:16 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java, line 245 > > <https://reviews.apache.org/r/55712/diff/3/?file=1613663#file1613663line245> > > > > why commented? It's not being used. > On Jan. 25, 2017, 8:16 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 191 > > <https://reviews.apache.org/r/55712/diff/3/?file=1613661#file1613661line191> > > > > Seems updatePeriod can be null here. looking at the following check > > says so. If the update period is null then the storage table name prefix will be the same as storage name. - Lavkesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review162925 --- On Jan. 24, 2017, 2:57 p.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > --- > > (Updated Jan. 24, 2017, 2:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > --- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > - > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > --- > > > Thanks, > > Lavkesh Lahngir > >
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/ --- (Updated Jan. 24, 2017, 2:57 p.m.) Review request for lens. Bugs: LENS-1386 https://issues.apache.org/jira/browse/LENS-1386 Repository: lens Description --- A new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod Diffs (updated) - lens-api/src/main/resources/cube-0.1.xsd f438f48 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e21dc2a lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43 Diff: https://reviews.apache.org/r/55712/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/ --- (Updated Jan. 23, 2017, 2:51 p.m.) Review request for lens. Bugs: LENS-1386 https://issues.apache.org/jira/browse/LENS-1386 Repository: lens Description --- A new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod Diffs (updated) - lens-api/src/main/resources/cube-0.1.xsd f438f48 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e21dc2a lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43 Diff: https://reviews.apache.org/r/55712/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 55712: Fact Schema change to support all update periods in one storage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/ --- (Updated Jan. 19, 2017, 12:08 p.m.) Review request for lens. Summary (updated) - Fact Schema change to support all update periods in one storage Bugs: LENS-1386 https://issues.apache.org/jira/browse/LENS-1386 Repository: lens Description (updated) --- A new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod Diffs - lens-api/src/main/resources/cube-0.1.xsd f438f48 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43 Diff: https://reviews.apache.org/r/55712/diff/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1386) Fact Schema change to support all update periods in one storage
[ https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1386: -- Summary: Fact Schema change to support all update periods in one storage (was: Vertica Fact Schema change to support all update periods in one storage) > Fact Schema change to support all update periods in one storage > --- > > Key: LENS-1386 > URL: https://issues.apache.org/jira/browse/LENS-1386 > Project: Apache Lens > Issue Type: Task > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > > Xsd and Metastore changes: > (1) New Xsd construct > (2) Create Fact Changes > (3) CubeMetastoreClient changes for update period table name > (4) Validation that TableDescription should only be available at either table > level or at update period level -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 55712: Vertica Fact Schema change to support all update periods in one storage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/ --- Review request for lens. Bugs: LENS-1386 https://issues.apache.org/jira/browse/LENS-1386 Repository: lens Description --- An new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod Diffs - lens-api/src/main/resources/cube-0.1.xsd f438f48 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92 lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2 lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43 Diff: https://reviews.apache.org/r/55712/diff/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Created] (LENS-1386) Vertica Fact Schema change to support all update periods in one storage
Lavkesh Lahngir created LENS-1386: - Summary: Vertica Fact Schema change to support all update periods in one storage Key: LENS-1386 URL: https://issues.apache.org/jira/browse/LENS-1386 Project: Apache Lens Issue Type: Task Reporter: Lavkesh Lahngir Assignee: Lavkesh Lahngir Xsd and Metastore changes: (1) New Xsd construct (2) Create Fact Changes (3) CubeMetastoreClient changes for update period table name (4) Validation that TableDescription should only be available at either table level or at update period level -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1383) Add support for multiple table descriptors inside a storage.
[ https://issues.apache.org/jira/browse/LENS-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1383: -- Summary: Add support for multiple table descriptors inside a storage. (was: Add support for multiple table descriptor inside a storage. ) > Add support for multiple table descriptors inside a storage. > - > > Key: LENS-1383 > URL: https://issues.apache.org/jira/browse/LENS-1383 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1383) Add support for multiple table descriptor inside a storage.
Lavkesh Lahngir created LENS-1383: - Summary: Add support for multiple table descriptor inside a storage. Key: LENS-1383 URL: https://issues.apache.org/jira/browse/LENS-1383 Project: Apache Lens Issue Type: New Feature Reporter: Lavkesh Lahngir Assignee: Lavkesh Lahngir -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1376) Retry framework for queries should separate server retries and driver retries
Lavkesh Lahngir created LENS-1376: - Summary: Retry framework for queries should separate server retries and driver retries Key: LENS-1376 URL: https://issues.apache.org/jira/browse/LENS-1376 Project: Apache Lens Issue Type: Bug Reporter: Lavkesh Lahngir -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (LENS-1375) ImmediateRetryHandler.hasExhaustedRetries() should return true when failcount is equal to number of retries
[ https://issues.apache.org/jira/browse/LENS-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir reassigned LENS-1375: - Assignee: Lavkesh Lahngir > ImmediateRetryHandler.hasExhaustedRetries() should return true when failcount > is equal to number of retries > --- > > Key: LENS-1375 > URL: https://issues.apache.org/jira/browse/LENS-1375 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1375) ImmediateRetryHandler.hasExhaustedRetries() should return true when failcount is equal to number of retries
Lavkesh Lahngir created LENS-1375: - Summary: ImmediateRetryHandler.hasExhaustedRetries() should return true when failcount is equal to number of retries Key: LENS-1375 URL: https://issues.apache.org/jira/browse/LENS-1375 Project: Apache Lens Issue Type: Bug Reporter: Lavkesh Lahngir -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures
[ https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1371: -- Attachment: 0001-Retry-policy.patch > Add a substring based retry policy for failures > --- > > Key: LENS-1371 > URL: https://issues.apache.org/jira/browse/LENS-1371 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, > 0001-Retry-policy.patch, 0001-Retry-policy.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures
[ https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1371: -- Status: Patch Available (was: Open) > Add a substring based retry policy for failures > --- > > Key: LENS-1371 > URL: https://issues.apache.org/jira/browse/LENS-1371 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, > 0001-Retry-policy.patch, 0001-Retry-policy.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures
[ https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1371: -- Status: Patch Available (was: Open) > Add a substring based retry policy for failures > --- > > Key: LENS-1371 > URL: https://issues.apache.org/jira/browse/LENS-1371 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, > 0001-Retry-policy.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures
[ https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1371: -- Status: Open (was: Patch Available) > Add a substring based retry policy for failures > --- > > Key: LENS-1371 > URL: https://issues.apache.org/jira/browse/LENS-1371 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, > 0001-Retry-policy.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures
[ https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1371: -- Attachment: 0001-Retry-policy.patch > Add a substring based retry policy for failures > --- > > Key: LENS-1371 > URL: https://issues.apache.org/jira/browse/LENS-1371 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, > 0001-Retry-policy.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures
[ https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1371: -- Attachment: 0001-Retry-policy.patch > Add a substring based retry policy for failures > --- > > Key: LENS-1371 > URL: https://issues.apache.org/jira/browse/LENS-1371 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures
[ https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1371: -- Attachment: 0001-Retry-patch.patch > Add a substring based retry policy for failures > --- > > Key: LENS-1371 > URL: https://issues.apache.org/jira/browse/LENS-1371 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Retry-patch.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures
[ https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1371: -- Status: Patch Available (was: Open) > Add a substring based retry policy for failures > --- > > Key: LENS-1371 > URL: https://issues.apache.org/jira/browse/LENS-1371 > Project: Apache Lens > Issue Type: New Feature > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Retry-patch.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1352) Write JDBC driver Retry policy to recover queries lost after lens restart
[ https://issues.apache.org/jira/browse/LENS-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1352: -- Issue Type: Sub-task (was: Task) Parent: LENS-1371 > Write JDBC driver Retry policy to recover queries lost after lens restart > - > > Key: LENS-1352 > URL: https://issues.apache.org/jira/browse/LENS-1352 > Project: Apache Lens > Issue Type: Sub-task >Reporter: Rajat Khandelwal > Assignee: Lavkesh Lahngir > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1353) Write HiveDriver retry policy to recover queries lost due to hive server restart
[ https://issues.apache.org/jira/browse/LENS-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1353: -- Issue Type: Sub-task (was: Task) Parent: LENS-1371 > Write HiveDriver retry policy to recover queries lost due to hive server > restart > > > Key: LENS-1353 > URL: https://issues.apache.org/jira/browse/LENS-1353 > Project: Apache Lens > Issue Type: Sub-task >Reporter: Rajat Khandelwal > Assignee: Lavkesh Lahngir > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1371) Add a substring based retry policy for failures
Lavkesh Lahngir created LENS-1371: - Summary: Add a substring based retry policy for failures Key: LENS-1371 URL: https://issues.apache.org/jira/browse/LENS-1371 Project: Apache Lens Issue Type: New Feature Reporter: Lavkesh Lahngir Assignee: Lavkesh Lahngir -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52982: Adding a message based retry policy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52982/ --- (Updated Oct. 25, 2016, 12:38 p.m.) Review request for lens. Repository: lens Description --- If any one of the configured messages are found then the retry will happen Diffs (updated) - lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6 lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java 01da25d lens-server-api/src/main/java/org/apache/lens/server/api/retry/ImmediateRetryHandler.java c1c0126 lens-server-api/src/main/java/org/apache/lens/server/api/retry/SubstringMessagePolicyDecider.java PRE-CREATION lens-server-api/src/test/java/org/apache/lens/server/api/retry/TestSubStringMessagePolicyDecider.java PRE-CREATION src/site/apt/admin/hivedriver-config.apt b1a25c3 src/site/apt/admin/jdbcdriver-config.apt c64d6ee Diff: https://reviews.apache.org/r/52982/diff/ Testing --- Thanks, Lavkesh Lahngir
Re: Review Request 52040: Handling data delay
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52040/ --- (Updated Oct. 21, 2016, 8:56 a.m.) Review request for lens. Changes --- Rebased with the master Bugs: LENS-1327 https://issues.apache.org/jira/browse/LENS-1327 Repository: lens Description --- A instance goes to waiting state when there is some data missing. They are retried after some time. Diffs (updated) - lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java 4f3409c lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 3d2605e lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6 lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 5f472fc lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 1db8136 lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 73277de lens-server/src/main/resources/lensserver-default.xml 8e5fe8a lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java e698e2b lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java 03f5d9b src/site/apt/admin/config.apt f22fc0c Diff: https://reviews.apache.org/r/52040/diff/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1327) Handle Data delay for scheduled jobs
[ https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1327: -- Attachment: 0001-data-delay.patch > Handle Data delay for scheduled jobs > > > Key: LENS-1327 > URL: https://issues.apache.org/jira/browse/LENS-1327 > Project: Apache Lens > Issue Type: Sub-task > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-Data-dealy.patch, 0001-data-delay.patch, > data-delay.patch, data-delay.patch, data-delay.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1361: -- Status: Patch Available (was: Open) > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-DB-fixes.patch, ignore-db.patch, ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52982: Adding a message based retry policy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52982/ --- (Updated Oct. 20, 2016, 12:57 p.m.) Review request for lens. Changes --- Added test cases Repository: lens Description --- If any one of the configured messages are found then the retry will happen Diffs (updated) - lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4f352a6e57dd81b6ae84cca221a345ebb6 lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f lens-server-api/src/main/java/org/apache/lens/server/api/retry/ConfiguredPolicyDecider.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java 01da25d12393615cfb4e4680c97c7445df0bbe83 lens-server-api/src/main/java/org/apache/lens/server/api/retry/ImmediateRetryHandler.java c1c0126ae9ac89cb4a50fe5948075094f10cb518 lens-server-api/src/test/java/org/apache/lens/server/api/retry/TestConfiguredPolicyDecider.java PRE-CREATION src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 src/site/apt/admin/jdbcdriver-config.apt c64d6ee0d4ac1dff9fadd02826e67a8e4839d99f Diff: https://reviews.apache.org/r/52982/diff/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1361: -- Attachment: 0001-DB-fixes.patch > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: 0001-DB-fixes.patch, ignore-db.patch, ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588586#comment-15588586 ] Lavkesh Lahngir commented on LENS-1361: --- Init() should throw an error if there are errors. Table creation will not throw an error, that will result in internal server error while API calls. > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: ignore-db.patch, ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1361: -- Attachment: ignore-db.patch > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: ignore-db.patch, ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1361: -- Attachment: (was: ignore-db.patch) > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1361: -- Status: Open (was: Patch Available) > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1361: -- Attachment: ignore-db.patch > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: ignore-db.patch, ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52982: Adding a message based retry policy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52982/ --- (Updated Oct. 18, 2016, 2:48 p.m.) Review request for lens. Repository: lens Description --- If any one of the configured messages are found then the retry will happen Diffs (updated) - lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb20b9d6b82292c4483d860ea14c8104c5c lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4f352a6e57dd81b6ae84cca221a345ebb6 lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6ca126f0a3535974352adf97e7a495838f lens-server-api/src/main/java/org/apache/lens/server/api/retry/ConfiguredPolicyDecider.java PRE-CREATION src/site/apt/admin/hivedriver-config.apt b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 src/site/apt/admin/jdbcdriver-config.apt c64d6ee0d4ac1dff9fadd02826e67a8e4839d99f Diff: https://reviews.apache.org/r/52982/diff/ Testing --- Thanks, Lavkesh Lahngir
[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1361: -- Status: Patch Available (was: In Progress) > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lavkesh Lahngir updated LENS-1361: -- Attachment: ignore-db.patch > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (LENS-1361) Ignore DB failure while scheduler startup.
[ https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1361 started by Lavkesh Lahngir. - > Ignore DB failure while scheduler startup. > -- > > Key: LENS-1361 > URL: https://issues.apache.org/jira/browse/LENS-1361 > Project: Apache Lens > Issue Type: Bug > Reporter: Lavkesh Lahngir > Assignee: Lavkesh Lahngir > Attachments: ignore-db.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
