Re: [VOTE] Break up lens code into two sub projects
+1 Rajat Khandelwal On Wed, 28 Aug, 2019, 17:18 Puneet Gupta, wrote: > +1 from me. > > On Wed, 28 Aug, 2019, 4:42 PM Amareshwari Sriramdasu, < > amareshw...@apache.org> wrote: > > > +1 from my side. > > > > On Wed, Aug 28, 2019 at 4:41 PM Amareshwari Sriramdasu < > > amareshw...@apache.org> wrote: > > > > > Hi, > > > > > > After the discussion on Lens roadmap thread, calling this vote to get > > > consensus from developers of Lens for the proposal. > > > > > > Lens codebase can be broken down into two sub projects : one for > > metastore > > > and other for query. Query service can have dependency on metastore > > > service. This shall help these subprojects evolve separately. > > > > > > To achieve the same we shall do 2.8 release from current master with > all > > > changes for current stack. Move master to 3.0 with refactored code of > > > subprojects, which can be build separately. > > > > > > Lens developers, do cast your vote for the above > > > > > > [+1] if you approve > > > [0] if no opinion > > > [-] if you are not approving, with reasons. > > > > > > Do express your comments as well. > > > > > > Thanks > > > Amareshwari > > > > > > > > > > > >
Re: [DISCUSS] Lens Migration from Git-wip to Gitbox
+1 On Mon, Jan 7, 2019 at 10:59 AM Rajitha R wrote: > Hi All, > > ASF infra has decided to move all git repositories from > git-wip-us.apache.org URL to gitbox.apache.org with the former service > being decommisioned. > > This mail is to get a consensus from all of you regarding the migration. > > Please vote within next 24 hours, which can help me in raising the Infra > jira before the published timeline. > > [ ] +1 approve > [ ] 0 no opinion > [ ] -1 disapprove (and reason why) > > +1 from my side for the activity. > > For folks looking for more details, please refer this link : > > https://blogs.apache.org/infra/entry/relocation-of-apache-git-repositories > > Regards, > Rajitha.R > -- Rajat Khandelwal On Mon, Jan 7, 2019 at 10:59 AM Rajitha R wrote: > Hi All, > > ASF infra has decided to move all git repositories from > git-wip-us.apache.org URL to gitbox.apache.org with the former service > being decommisioned. > > This mail is to get a consensus from all of you regarding the migration. > > Please vote within next 24 hours, which can help me in raising the Infra > jira before the published timeline. > > [ ] +1 approve > [ ] 0 no opinion > [ ] -1 disapprove (and reason why) > > +1 from my side for the activity. > > For folks looking for more details, please refer this link : > > https://blogs.apache.org/infra/entry/relocation-of-apache-git-repositories > > Regards, > Rajitha.R > -- Rajat Khandelwal
Re: Report for November, 2018
+1 On Thu 15 Nov, 2018, 18:57 Raghavendra Singh, wrote: > +1 > > On Thu, Nov 15, 2018 at 6:47 PM Raju Bairishetti wrote: > > > +1 LGTM > > > > On Wed, Nov 14, 2018 at 10:19 PM Puneet Gupta > > wrote: > > > > > +1. Looks good to me . > > > > > > On Wed, Nov 7, 2018 at 8:02 PM Amareshwari Sriramdasu < > > > amareshw...@apache.org> wrote: > > > > > > > Hi, > > > > > > > > Have updated draft report for November,2018 at > > > > https://cwiki.apache.org/confluence/display/LENS/November%2C2018. > > Please > > > > review and let me know your comments. > > > > > > > > Thanks > > > > Amareshwari > > > > > > > > > > > > > -- > > > > -- > > Thanks, > > Raju Bairishetti > > > > -- > _ > The > information contained in this communication is intended solely for the use > of the individual or entity to whom it is addressed and others authorized > to receive it. It may contain confidential or legally privileged > information. If you are not the intended recipient you are hereby notified > that any disclosure, copying, distribution or taking any action in > reliance > on the contents of this information is strictly prohibited and may be > unlawful. If you have received this communication in error, please notify > us immediately by responding to this email and then delete it from your > system. The firm is neither liable for the proper and complete > transmission > of the information contained in this communication nor for any delay in > its > receipt. >
Re: Review Request 67898: Adding serialversionUID in BackoffretryHandlers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67898/#review206043 --- Ship it! Ship It! - Rajat Khandelwal On July 12, 2018, 9:07 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67898/ > --- > > (Updated July 12, 2018, 9:07 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-1523 > https://issues.apache.org/jira/browse/LENS-1523 > > > Repository: lens > > > Description > --- > > Adding serialversionUID in BackoffretryHandlers > > > Diffs > - > > > lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java > be3fc52 > > lens-server-api/src/main/java/org/apache/lens/server/api/retry/ImmediateRetryHandler.java > cea9df3 > lens_bk d0d9adf > > > Diff: https://reviews.apache.org/r/67898/diff/1/ > > > Testing > --- > > > Thanks, > > Rajitha R > >
[jira] [Updated] (LENS-1518) Missing self for ignore cert variable in query.py file
[ https://issues.apache.org/jira/browse/LENS-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1518: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Missing self for ignore cert variable in query.py file > -- > > Key: LENS-1518 > URL: https://issues.apache.org/jira/browse/LENS-1518 > Project: Apache Lens > Issue Type: Bug > Components: client >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar >Priority: Major > Attachments: Lens-1518.patch > > > Self is missing for variable corresponding to ignore cert. This is causing > python query builder to fail while creating request object. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LENS-1518) Missing self for ignore cert variable in query.py file
[ https://issues.apache.org/jira/browse/LENS-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499965#comment-16499965 ] Rajat Khandelwal commented on LENS-1518: Committed. Thanks [~ankitkailaswar] > Missing self for ignore cert variable in query.py file > -- > > Key: LENS-1518 > URL: https://issues.apache.org/jira/browse/LENS-1518 > Project: Apache Lens > Issue Type: Bug > Components: client >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar >Priority: Major > Attachments: Lens-1518.patch > > > Self is missing for variable corresponding to ignore cert. This is causing > python query builder to fail while creating request object. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 67432: changes for Python3 compatibility issues with python client and ignore cert fo self signed cert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67432/#review204246 --- Ship it! Ship It! - Rajat Khandelwal On June 4, 2018, 2:42 p.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67432/ > --- > > (Updated June 4, 2018, 2:42 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > Fix of urlparse import in auth.py to make compatibiliy with Python 2 and 3. > Jira : https://issues.apache.org/jira/browse/LENS-1517 > And > Fir for ignore cert variable in query.py > Jira : https://issues.apache.org/jira/browse/LENS-1518 > > > Diffs > - > > contrib/clients/python/lens/client/auth.py fccc75c9 > contrib/clients/python/lens/client/query.py 8b0616b6 > contrib/clients/python/setup.py 5c64067e > > > Diff: https://reviews.apache.org/r/67432/diff/1/ > > > Testing > --- > > Tested with Python 2.7.12 and Python 3.5.2 by Michael McCarthy for Lens-1517. > Tested with Python 2.7 for Lens-1518 and queried on self signed and ca signed > cert. > > > Thanks, > > Ankit Kailaswar > >
[jira] [Commented] (LENS-1517) Python3 compatibility issues with python client
[
https://issues.apache.org/jira/browse/LENS-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499773#comment-16499773
]
Rajat Khandelwal commented on LENS-1517:
+1
> Python3 compatibility issues with python client
> ---
>
> Key: LENS-1517
> URL: https://issues.apache.org/jira/browse/LENS-1517
> Project: Apache Lens
> Issue Type: Bug
> Components: python-client
>Affects Versions: 3.0, 2.8
> Environment: Python 3.5.2
> Commit: c6423ae01a4776383f0edcd8591124ac643b9e3e
>Reporter: Michael McCarthy
>Assignee: Michael McCarthy
>Priority: Major
>
> Using the python client in Python3 fails on import:
> {noformat}
> from lens.client import LensClient
> ---
> ImportError Traceback (most recent call last)
> in ()
> > 1 from lens.client import LensClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/__init__.py
> in ()
> 15 # limitations under the License.
> 16 #
> ---> 17 from .main import LensClient
> 18
> 19 __all__ = ['LensClient']
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/main.py
> in ()
> 18
> 19 from six import string_types
> ---> 20 from .log import LensLogClient
> 21 from .session import LensSessionClient
> 22 from .query import LensQueryClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/log.py
> in ()
> 15 # limitations under the License.
> 16 #
> ---> 17 from .auth import SpnegoAuth
> 18 import requests
> 19
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/auth.py
> in ()
> 19 import subprocess
> 20 import threading
> ---> 21 from urlparse import urlparse
> 22
> 23
> ImportError: No module named 'urlparse'
> {noformat}
> This appears to be due to the fact that in Python3, {{urlparse}} is
> {{urllib.parse}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LENS-1517) Python3 compatibility issues with python client
[
https://issues.apache.org/jira/browse/LENS-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499419#comment-16499419
]
Rajat Khandelwal commented on LENS-1517:
Hi Michael. The solution you posted seems like a hack to me. Can you look at
http://python-future.org/compatible_idioms.html#urllib-module and update patch?
> Python3 compatibility issues with python client
> ---
>
> Key: LENS-1517
> URL: https://issues.apache.org/jira/browse/LENS-1517
> Project: Apache Lens
> Issue Type: Bug
> Components: python-client
>Affects Versions: 3.0, 2.8
> Environment: Python 3.5.2
> Commit: c6423ae01a4776383f0edcd8591124ac643b9e3e
>Reporter: Michael McCarthy
>Assignee: Michael McCarthy
>Priority: Major
>
> Using the python client in Python3 fails on import:
> {noformat}
> from lens.client import LensClient
> ---
> ImportError Traceback (most recent call last)
> in ()
> > 1 from lens.client import LensClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/__init__.py
> in ()
> 15 # limitations under the License.
> 16 #
> ---> 17 from .main import LensClient
> 18
> 19 __all__ = ['LensClient']
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/main.py
> in ()
> 18
> 19 from six import string_types
> ---> 20 from .log import LensLogClient
> 21 from .session import LensSessionClient
> 22 from .query import LensQueryClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/log.py
> in ()
> 15 # limitations under the License.
> 16 #
> ---> 17 from .auth import SpnegoAuth
> 18 import requests
> 19
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/auth.py
> in ()
> 19 import subprocess
> 20 import threading
> ---> 21 from urlparse import urlparse
> 22
> 23
> ImportError: No module named 'urlparse'
> {noformat}
> This appears to be due to the fact that in Python3, {{urlparse}} is
> {{urllib.parse}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Review Request 66081: Kerberos authentication in lens
> On March 21, 2018, 1:58 a.m., Ankit Kailaswar wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java > > Lines 36 (patched) > > <https://reviews.apache.org/r/66081/diff/1/?file=1976384#file1976384line36> > > > > If we try to extend RetryingThriftCLIServiceClient then it forces us to > > override all member functions since we cant access private data members of > > base class in derived class. we are doing it now anyhow but invokeInternal > > in base class refer to inner protected class "InvocationResult" if we try > > to overide invokeinternal then we are force to use "InvocationResult" in > > our implementation. since this class is inner protected class it cant be > > accessed from outside the class. This problem can be solved by extending > > InvocationResult. This require initialising base class in derived class's > > constructor causing same issue of not been able to use class outside > > package. > > Rajat Khandelwal wrote: > This can be solved by making the package of this class > `org.apache.hive.service.cli.thrift`. Also the method `invokeInternal` and member `base` will need to be copied. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66081/#review199570 --- On March 21, 2018, 2:13 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66081/ > ------- > > (Updated March 21, 2018, 2:13 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and > Puneet Gupta. > > > Repository: lens > > > Description > --- > > https://issues.apache.org/jira/browse/LENS-1506 > > This patch contains code changes to enable kerberos authentication for > 1. lens to hive > 2. lens to metastore > 3. lens to hdfs > > code changes are as follows, > 1. new http thrift client for hive driver to support sasl transport for > kerberozied hive server. > 2. cron to update KDC ticket before it expires. > > > Diffs > - > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 2eb94aa7 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java > 54885f77 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > d5273be8 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > b9fcdd8b > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 31ac358d > > > Diff: https://reviews.apache.org/r/66081/diff/2/ > > > Testing > --- > > unit testing > > > Thanks, > > Ankit Kailaswar > >
Re: Review Request 66081: Kerberos authentication in lens
> On March 21, 2018, 1:58 a.m., Ankit Kailaswar wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java > > Lines 36 (patched) > > <https://reviews.apache.org/r/66081/diff/1/?file=1976384#file1976384line36> > > > > If we try to extend RetryingThriftCLIServiceClient then it forces us to > > override all member functions since we cant access private data members of > > base class in derived class. we are doing it now anyhow but invokeInternal > > in base class refer to inner protected class "InvocationResult" if we try > > to overide invokeinternal then we are force to use "InvocationResult" in > > our implementation. since this class is inner protected class it cant be > > accessed from outside the class. This problem can be solved by extending > > InvocationResult. This require initialising base class in derived class's > > constructor causing same issue of not been able to use class outside > > package. This can be solved by making the package of this class `org.apache.hive.service.cli.thrift`. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66081/#review199570 --- On March 21, 2018, 2:13 a.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66081/ > ------- > > (Updated March 21, 2018, 2:13 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and > Puneet Gupta. > > > Repository: lens > > > Description > --- > > https://issues.apache.org/jira/browse/LENS-1506 > > This patch contains code changes to enable kerberos authentication for > 1. lens to hive > 2. lens to metastore > 3. lens to hdfs > > code changes are as follows, > 1. new http thrift client for hive driver to support sasl transport for > kerberozied hive server. > 2. cron to update KDC ticket before it expires. > > > Diffs > - > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 2eb94aa7 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java > 54885f77 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > d5273be8 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > b9fcdd8b > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 31ac358d > > > Diff: https://reviews.apache.org/r/66081/diff/2/ > > > Testing > --- > > unit testing > > > Thanks, > > Ankit Kailaswar > >
Re: [VOTE] Release of Apache Lens 2.7.1
+1 On Wed, Jan 31, 2018 at 1:50 PM, Siddharth Raj Jain < siddharth@inmobi.com> wrote: > +1 > > On Wed, Jan 24, 2018 at 12:33 PM, Raju Bairishetti <r...@apache.org> > wrote: > > > Hi everyone, > > > > I propose the following RC to be released as official Apache Lens > 2.7.1 > > release. > > > > The commit id is 865d20267e8128134bb981f1db9dab9108661061: > > http://git-wip-us.apache.org/repos/asf/lens/commit/865d2026 > > > > This corresponds to the tag: apache-lens-2.7.1: > > https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h= > > refs/tags/apache-lens-2.7.1 > > > > Release archives (tar.gz/zip) signature and checksums are here: > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.1-rc0/ > > > > You can find the KEYS file here: > > https://dist.apache.org/repos/dist/dev/lens/KEYS > > > > The release candidate consists of the following source distribution > archive > > apache-lens-2.7.1-source-release.zip: > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7. > > 1-rc0/apache-lens-2.7.1-source-release.zip > > > > In addition, the following supplementary binary distributions are > provided > > for user convenience at the same location: apache-lens-2.7.1-bin.tar.gz > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7. > > 1-rc0/apache-lens-2.7.1-bin.tar.gz > > > > the licensing of bundled bits in the archives are documented at > > https://cwiki.apache.org/confluence/display/LENS/ > Licensing+in+Apache+Lens > > > > Nexus staging url: > > https://repository.apache.org/content/repositories/orgapachelens-1012 > > > > Release notes available at > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > projectId=12315923=12336851 > > > > Vote will be open for at least 72 hours > > > > [ ] +1 approve > > [ ] 0 no opinion > > [ ] -1 disapprove (and reason why) > > > > +1 from my side for the release. > > > > For folks not familiar with vetting a release, please refer to > > > > http://incubator.apache.org/guides/releasemanagement.html#check-list > > > > -- > > Thanks, > > Raju Bairishetti, > > www.lazada.com > > > > -- > _ > The information contained in this communication is intended solely for the > use of the individual or entity to whom it is addressed and others > authorized to receive it. It may contain confidential or legally privileged > information. If you are not the intended recipient you are hereby notified > that any disclosure, copying, distribution or taking any action in reliance > on the contents of this information is strictly prohibited and may be > unlawful. If you have received this communication in error, please notify > us immediately by responding to this email and then delete it from your > system. The firm is neither liable for the proper and complete transmission > of the information contained in this communication nor for any delay in its > receipt. > -- Rajat Khandelwal Tech Lead -- _ The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email and then delete it from your system. The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.
Re: Review Request 64767: Look ahead time partitions made configurable [LENS-1496]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64767/#review194324 --- Ship it! Ship It! - Rajat Khandelwal On Dec. 21, 2017, 3:16 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64767/ > --- > > (Updated Dec. 21, 2017, 3:16 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1496 > https://issues.apache.org/jira/browse/LENS-1496 > > > Repository: lens > > > Description > --- > > Currently Lens only allows for Look ahead in the last partition. This needs > to be made configurable. > > > Diffs > - > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > eeaa3af > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 3ee66ee > lens-cube/src/main/resources/olap-query-conf.xml b389d6a > lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java > 75f2abd > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 9b54957 > > > Diff: https://reviews.apache.org/r/64767/diff/1/ > > > Testing > --- > > > Thanks, > > Rajitha R > >
[jira] [Updated] (LENS-1487) Incorrect handling of array columns in python client
[ https://issues.apache.org/jira/browse/LENS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1487: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Incorrect handling of array columns in python client > > > Key: LENS-1487 > URL: https://issues.apache.org/jira/browse/LENS-1487 > Project: Apache Lens > Issue Type: Bug > Components: client > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.8 > > Attachments: LENS-1487.2017-11-21_16:17:11.patch > > > The client is splitting the list on every character. It should be splitting > on comma. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1487) Incorrect handling of array columns in python client
[ https://issues.apache.org/jira/browse/LENS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262116#comment-16262116 ] Rajat Khandelwal commented on LENS-1487: Committed myself. > Incorrect handling of array columns in python client > > > Key: LENS-1487 > URL: https://issues.apache.org/jira/browse/LENS-1487 > Project: Apache Lens > Issue Type: Bug > Components: client > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.8 > > Attachments: LENS-1487.2017-11-21_16:17:11.patch > > > The client is splitting the list on every character. It should be splitting > on comma. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1487) Incorrect handling of array columns in python client
[ https://issues.apache.org/jira/browse/LENS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1487: --- Fix Version/s: 2.8 > Incorrect handling of array columns in python client > > > Key: LENS-1487 > URL: https://issues.apache.org/jira/browse/LENS-1487 > Project: Apache Lens > Issue Type: Bug > Components: client > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.8 > > Attachments: LENS-1487.2017-11-21_16:17:11.patch > > > The client is splitting the list on every character. It should be splitting > on comma. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1487) Incorrect handling of array columns in python client
[ https://issues.apache.org/jira/browse/LENS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1487: --- Status: Patch Available (was: Open) > Incorrect handling of array columns in python client > > > Key: LENS-1487 > URL: https://issues.apache.org/jira/browse/LENS-1487 > Project: Apache Lens > Issue Type: Bug > Components: client > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1487.2017-11-21_16:17:11.patch > > > The client is splitting the list on every character. It should be splitting > on comma. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1487) Incorrect handling of array columns in python client
[ https://issues.apache.org/jira/browse/LENS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260564#comment-16260564 ] Rajat Khandelwal commented on LENS-1487: Small enough diff. Attaching directly > Incorrect handling of array columns in python client > > > Key: LENS-1487 > URL: https://issues.apache.org/jira/browse/LENS-1487 > Project: Apache Lens > Issue Type: Bug > Components: client > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1487.2017-11-21_16:17:11.patch > > > The client is splitting the list on every character. It should be splitting > on comma. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1487) Incorrect handling of array columns in python client
[ https://issues.apache.org/jira/browse/LENS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1487: --- Attachment: LENS-1487.2017-11-21_16:17:11.patch > Incorrect handling of array columns in python client > > > Key: LENS-1487 > URL: https://issues.apache.org/jira/browse/LENS-1487 > Project: Apache Lens > Issue Type: Bug > Components: client > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1487.2017-11-21_16:17:11.patch > > > The client is splitting the list on every character. It should be splitting > on comma. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (LENS-1487) Incorrect handling of array columns in python client
Rajat Khandelwal created LENS-1487: -- Summary: Incorrect handling of array columns in python client Key: LENS-1487 URL: https://issues.apache.org/jira/browse/LENS-1487 Project: Apache Lens Issue Type: Bug Components: client Reporter: Rajat Khandelwal Assignee: Rajat Khandelwal The client is splitting the list on every character. It should be splitting on comma. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1469) Support drop partition(s) for specific update periods
[ https://issues.apache.org/jira/browse/LENS-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1469: --- Fix Version/s: 2.8 > Support drop partition(s) for specific update periods > - > > Key: LENS-1469 > URL: https://issues.apache.org/jira/browse/LENS-1469 > Project: Apache Lens > Issue Type: New Feature > Components: client, server >Reporter: Amit Khanna >Assignee: Amit Khanna > Fix For: 2.8 > > Attachments: LENS-1469.patch > > > Facilitate dropping partitions based on update period. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1469) Support drop partition(s) for specific update periods
[ https://issues.apache.org/jira/browse/LENS-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1469: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Support drop partition(s) for specific update periods > - > > Key: LENS-1469 > URL: https://issues.apache.org/jira/browse/LENS-1469 > Project: Apache Lens > Issue Type: New Feature > Components: client, server >Reporter: Amit Khanna >Assignee: Amit Khanna > Fix For: 2.8 > > Attachments: LENS-1469.patch > > > Facilitate dropping partitions based on update period. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1469) Support drop partition(s) for specific update periods
[ https://issues.apache.org/jira/browse/LENS-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218211#comment-16218211 ] Rajat Khandelwal commented on LENS-1469: Committed. Thanks [~Amit khanna] > Support drop partition(s) for specific update periods > - > > Key: LENS-1469 > URL: https://issues.apache.org/jira/browse/LENS-1469 > Project: Apache Lens > Issue Type: New Feature > Components: client, server >Reporter: Amit Khanna >Assignee: Amit Khanna > Fix For: 2.8 > > Attachments: LENS-1469.patch > > > Facilitate dropping partitions based on update period. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (LENS-1469) Support drop partition(s) for specific update periods
[ https://issues.apache.org/jira/browse/LENS-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal reassigned LENS-1469: -- Assignee: Amit Khanna > Support drop partition(s) for specific update periods > - > > Key: LENS-1469 > URL: https://issues.apache.org/jira/browse/LENS-1469 > Project: Apache Lens > Issue Type: New Feature > Components: client, server >Reporter: Amit Khanna >Assignee: Amit Khanna > Attachments: LENS-1469.patch > > > Facilitate dropping partitions based on update period. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61881/#review189159 --- lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 432 (patched) <https://reviews.apache.org/r/61881/#comment266089> Won't this cause issues While reading sessions back? As the count of sessions persisted is written as `SESSION_MAP.size()`. It'll try to read that many session objects. What will happen if some of the sessions are not written at all? - Rajat Khandelwal On Oct. 17, 2017, 5:37 p.m., Ankit Kailaswar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61881/ > --- > > (Updated Oct. 17, 2017, 5:37 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1461 > https://issues.apache.org/jira/browse/LENS-1461 > > > Repository: lens > > > Description > --- > > Persist process for Session service should not fail if any session in > invalid. Persist service should ignore these session and continue persisting > state of other session instead of failing. > > > Diffs > - > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > b480d140 > > > Diff: https://reviews.apache.org/r/61881/diff/2/ > > > Testing > --- > > > Thanks, > > Ankit Kailaswar > >
Re: Review Request 62013: LENS-1469- Support drop partition(s) for specific update periods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62013/#review189158 --- Ship it! Ship It! - Rajat Khandelwal On Aug. 31, 2017, 7:17 p.m., Amit Khanna wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62013/ > --- > > (Updated Aug. 31, 2017, 7:17 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-1469 > https://issues.apache.org/jira/browse/LENS-1469 > > > Repository: lens > > > Description > --- > > Facilitate dropping partitions based on update period. > > > Diffs > - > > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > 8a05952 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 9d16533 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 0a8635c > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 0af6a34 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > ab24033 > > > Diff: https://reviews.apache.org/r/62013/diff/1/ > > > Testing > --- > > Unit Tests to check whether it is successfully dropping only those partitions > associated with provided update period. > > > Thanks, > > Amit Khanna > >
[jira] [Commented] (LENS-1473) Cubevirtualfact table relative start time has incorrect config field name
[ https://issues.apache.org/jira/browse/LENS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155532#comment-16155532 ] Rajat Khandelwal commented on LENS-1473: Committed. Thanks [~rajitha.r] > Cubevirtualfact table relative start time has incorrect config field name > - > > Key: LENS-1473 > URL: https://issues.apache.org/jira/browse/LENS-1473 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.8 > > Attachments: LENS-1473.patch > > > Cubevirtualfact table relative start time has incorrect config field name -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1473) Cubevirtualfact table relative start time has incorrect config field name
[ https://issues.apache.org/jira/browse/LENS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1473: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Cubevirtualfact table relative start time has incorrect config field name > - > > Key: LENS-1473 > URL: https://issues.apache.org/jira/browse/LENS-1473 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.8 > > Attachments: LENS-1473.patch > > > Cubevirtualfact table relative start time has incorrect config field name -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1473) Cubevirtualfact table relative start time has incorrect config field name
[ https://issues.apache.org/jira/browse/LENS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1473: --- Fix Version/s: 2.8 > Cubevirtualfact table relative start time has incorrect config field name > - > > Key: LENS-1473 > URL: https://issues.apache.org/jira/browse/LENS-1473 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Fix For: 2.8 > > Attachments: LENS-1473.patch > > > Cubevirtualfact table relative start time has incorrect config field name -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 62120: LENS-1473 : Cubevirtualfact table relative start time has incorrect config field name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62120/#review184666 --- Ship it! Ship It! - Rajat Khandelwal On Sept. 6, 2017, 6:15 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62120/ > --- > > (Updated Sept. 6, 2017, 6:15 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > --- > > Cubevirtualfact table relative start time has incorrect config field name > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > ce2a1a6 > > > Diff: https://reviews.apache.org/r/62120/diff/1/ > > > Testing > --- > > > Thanks, > > Rajitha R > >
[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154014#comment-16154014
]
Rajat Khandelwal commented on LENS-1472:
Committed myself.
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1472.01.patch, LENS-1472.02.patch
>
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1472:
---
Fix Version/s: 2.8
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1472.01.patch, LENS-1472.02.patch
>
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1472:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1472.01.patch, LENS-1472.02.patch
>
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153425#comment-16153425
]
Rajat Khandelwal commented on LENS-1471:
Committed myself.
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch,
> LENS-1471.03.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via {{retain}} method
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1471:
---
Fix Version/s: 2.8
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch,
> LENS-1471.03.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via {{retain}} method
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1471:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch,
> LENS-1471.03.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via {{retain}} method
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Re: Review Request 62063: LENS-1472: Populate sample metastore on example db is failing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62063/
---
(Updated Sept. 4, 2017, 7:05 p.m.)
Review request for lens.
Bugs: LENS-1472
https://issues.apache.org/jira/browse/LENS-1472
Repository: lens
Description
---
{noformat}
Error Message: Internal Server Error.:
MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
is not a directory or unable to create one)
at
org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
at
org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
at
org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
at
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
at
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
{noformat}
Diffs
-
lens-dist/src/main/assembly/bin-dist.xml
c3f8f17d71e52249af4859b656ec3bed07cf5fc2
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java
4fc15a62bcea0e2e87e4b5e47adb3962aa695982
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java
e5a397b6476cea48b5646c8f376940986cb23c81
lens-examples/src/main/resources/sales-aggr-fact2-local4.data PRE-CREATION
Diff: https://reviews.apache.org/r/62063/diff/2/
Testing (updated)
---
rajat.khandelwal@IM1258-X1 client :) $bin/run-examples.sh
Error: Unknown or unspecified command ''
Usage: bin/run-examples.sh sample-metastore [-db dbname] --conf
bin/run-examples.sh populate-metastore [-db dbname] --conf
bin/run-examples.sh runqueries [-db dbname] --conf
rajat.khandelwal@IM1258-X1 client :( $bin/run-examples.sh sample-metastore -db
blah
Created DB storages
Created sample metastore!
Database:blah
Storages:[cluster1, local, mydb]
Cubes:[sales, cube11, sample_cube, cube22, cube33]
Dimensions:[sample_dim2, city, product, sample_db_dim, interests, sample_dim,
customer, customer_interests]
Fact tables:[sales_aggr_continuous_fact, fact2, fact1, sales_raw_fact,
sales_aggr_fact2, sales_aggr_fact1, rawfact]
Dimension tables:[city_table, customer_interests_table, dim_table, dim_table2,
dim_table4, dim_table3, customer_table, city_subset, product_table,
interests_table, product_db_table]
Segmentations:[seg1]
rajat.khandelwal@IM1258-X1 client :) $bin/run-examples.sh populate-metastore
-db blah
Added partition from:dim1-local-part.xml
Added partition from:dim2-local-part.xml
Added partition from:dim4-local-part.xml
Added partitions from:product-local-parts.xml
Added partition from:city-local-part.xml
Added partition from:customer-local-part.xml
Added partition from:customer-interests-local-part.xml
Added partition from:interests-local-part.xml
Added partition from:fact1-local-part1.xml
Added partition from:fact1-local-part2.xml
Added partition from:fact1-local-part3.xml
Added partition from:fact2-local-part1.xml
Added partition from:fact2-local-part2.xml
Added partition from:fact2-local-part3.xml
Added partition from:raw-local-part1.xml
Added partition from:raw-local-part2.xml
Added partition from:raw-local-part3.xml
Added partition from:raw-local-part4.xml
Added partition from:raw-local-part5.xml
Added partition from:raw-local-part6.xml
Added partitions from:sales-raw-local-parts.xml
Added partitions from:sales-aggr-fact1-local-parts.xml
Added partitions from:sales-aggr-fact2-local-parts.xml
Added partitions from:sales-aggr-fact1-mydb-parts.xml
Added partitions from:sales-aggr-fact2-mydb-parts.xml
Thanks,
Rajat Khandelwal
[jira] [Updated] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1472:
---
Attachment: LENS-1472.02.patch
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch, LENS-1472.02.patch
>
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152619#comment-16152619
]
Rajat Khandelwal commented on LENS-1472:
Taking patch from reviewboard and attaching
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch, LENS-1472.02.patch
>
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Re: Review Request 62063: LENS-1472: Populate sample metastore on example db is failing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62063/
---
(Updated Sept. 4, 2017, 7:01 p.m.)
Review request for lens.
Bugs: LENS-1472
https://issues.apache.org/jira/browse/LENS-1472
Repository: lens
Description
---
{noformat}
Error Message: Internal Server Error.:
MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
is not a directory or unable to create one)
at
org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
at
org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
at
org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
at
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
at
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
{noformat}
Diffs (updated)
-
lens-dist/src/main/assembly/bin-dist.xml
c3f8f17d71e52249af4859b656ec3bed07cf5fc2
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java
4fc15a62bcea0e2e87e4b5e47adb3962aa695982
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java
e5a397b6476cea48b5646c8f376940986cb23c81
lens-examples/src/main/resources/sales-aggr-fact2-local4.data PRE-CREATION
Diff: https://reviews.apache.org/r/62063/diff/2/
Changes: https://reviews.apache.org/r/62063/diff/1-2/
Testing
---
Thanks,
Rajat Khandelwal
[jira] [Updated] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1472:
---
Attachment: LENS-1472.01.patch
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch
>
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152581#comment-16152581
]
Rajat Khandelwal commented on LENS-1472:
Taking patch from reviewboard and attaching
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch
>
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1472:
---
Status: Patch Available (was: In Progress)
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch
>
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Review Request 62063: LENS-1472: Populate sample metastore on example db is failing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62063/
---
Review request for lens.
Bugs: LENS-1472
https://issues.apache.org/jira/browse/LENS-1472
Repository: lens
Description
---
{noformat}
Error Message: Internal Server Error.:
MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
is not a directory or unable to create one)
at
org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
at
org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
at
org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
at
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
at
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
{noformat}
Diffs
-
lens-dist/src/main/assembly/bin-dist.xml
c3f8f17d71e52249af4859b656ec3bed07cf5fc2
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java
e5a397b6476cea48b5646c8f376940986cb23c81
lens-examples/src/main/resources/sales-aggr-fact2-local4.data PRE-CREATION
Diff: https://reviews.apache.org/r/62063/diff/1/
Testing
---
Thanks,
Rajat Khandelwal
[jira] [Work started] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on LENS-1472 started by Rajat Khandelwal.
--
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing
[
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152580#comment-16152580
]
Rajat Khandelwal commented on LENS-1472:
Created https://reviews.apache.org/r/62063/
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
> Issue Type: Bug
> Components: examples
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> {noformat}
> Error Message: Internal Server Error.:
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
> is not a directory or unable to create one)
> at
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
> at
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
> at
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
> at
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
> at
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152579#comment-16152579
]
Rajat Khandelwal commented on LENS-1471:
Taking patch from reviewboard and attaching
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch,
> LENS-1471.03.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via {{retain}} method
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1471:
---
Attachment: LENS-1471.03.patch
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch,
> LENS-1471.03.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via {{retain}} method
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Re: Review Request 62060: LENS-1471: JoinCandidate's children should not share same storage candidate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62060/
---
(Updated Sept. 4, 2017, 6:20 p.m.)
Review request for lens.
Bugs: LENS-1471
https://issues.apache.org/jira/browse/LENS-1471
Repository: lens
Description
---
The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set
exclusive measure phrase indices, and that is done via truncate method of list.
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\])
== \[\]}}, it ends up answering no measures at all
Diffs (updated)
-
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
1cff4a424fddb7e124531837ce29a5d8ed97d49c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
27835b371c51579ae35d526fc6245f6cf5c7ffb4
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java
510ea0c5b1edf1dd60b5380ba3b2a47844ed2219
Diff: https://reviews.apache.org/r/62060/diff/3/
Changes: https://reviews.apache.org/r/62060/diff/2-3/
Testing
---
Thanks,
Rajat Khandelwal
[jira] [Created] (LENS-1472) Populate sample metastore on example db is failing
Rajat Khandelwal created LENS-1472:
--
Summary: Populate sample metastore on example db is failing
Key: LENS-1472
URL: https://issues.apache.org/jira/browse/LENS-1472
Project: Apache Lens
Issue Type: Bug
Components: examples
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal
{noformat}
Error Message: Internal Server Error.:
MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
is not a directory or unable to create one)
at
org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
at
org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
at
org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
at
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
at
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1471:
---
Attachment: LENS-1471.02.patch
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via {{retain}} method
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152490#comment-16152490
]
Rajat Khandelwal commented on LENS-1471:
Taking patch from reviewboard and attaching
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via {{retain}} method
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Re: Review Request 62060: LENS-1471: JoinCandidate's children should not share same storage candidate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62060/
---
(Updated Sept. 4, 2017, 4:55 p.m.)
Review request for lens.
Bugs: LENS-1471
https://issues.apache.org/jira/browse/LENS-1471
Repository: lens
Description
---
The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set
exclusive measure phrase indices, and that is done via truncate method of list.
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\])
== \[\]}}, it ends up answering no measures at all
Diffs (updated)
-
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
1cff4a424fddb7e124531837ce29a5d8ed97d49c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
27835b371c51579ae35d526fc6245f6cf5c7ffb4
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java
510ea0c5b1edf1dd60b5380ba3b2a47844ed2219
Diff: https://reviews.apache.org/r/62060/diff/2/
Changes: https://reviews.apache.org/r/62060/diff/1-2/
Testing
---
Thanks,
Rajat Khandelwal
[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1471:
---
Description: The issue is in Join candidates of the kind
{{Join\[Union\[a,b\]; Union\[a,c\]\]}}. If the instance of {{a}} is shared in
different trees of a JoinCandidate, the rewritten query will be wrong.
JoinCandidate's children set exclusive measure phrase indices, and that is done
via {{retain}} method of list. So let's say union1 is answering {{\[0,1\]}}
measures and union2 is answering {{\[2,3\]}} measures, and since
{{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
no measures at all (was: The issue is in Join candidates of the kind
{{Join\[Union\[a,b\]; Union\[a,c\]\]}}. If the instance of {{a}} is shared in
different trees of a JoinCandidate, the rewritten query will be wrong.
JoinCandidate's children set exclusive measure phrase indices, and that is done
via truncate method of list. So let's say union1 is answering {{\[0,1\]}}
measures and union2 is answering {{\[2,3\]}} measures, and since
{{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
no measures at all)
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via {{retain}} method
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Review Request 62060: LENS-1471: JoinCandidate's children should not share same storage candidate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62060/
---
Review request for lens.
Bugs: LENS-1471
https://issues.apache.org/jira/browse/LENS-1471
Repository: lens
Description
---
The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set
exclusive measure phrase indices, and that is done via truncate method of list.
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\])
== \[\]}}, it ends up answering no measures at all
Diffs
-
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
1cff4a424fddb7e124531837ce29a5d8ed97d49c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
27835b371c51579ae35d526fc6245f6cf5c7ffb4
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java
510ea0c5b1edf1dd60b5380ba3b2a47844ed2219
Diff: https://reviews.apache.org/r/62060/diff/1/
Testing
---
Thanks,
Rajat Khandelwal
[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1471:
---
Attachment: LENS-1471.01.patch
> JoinCandidate's children should not share same storage candidate
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via truncate method of
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1471:
---
Status: Patch Available (was: In Progress)
> JoinCandidate's children should not share same storage candidate
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via truncate method of
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152474#comment-16152474
]
Rajat Khandelwal commented on LENS-1471:
Taking patch from reviewboard and attaching
> JoinCandidate's children should not share same storage candidate
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via truncate method of
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Work started] (LENS-1471) JoinCandidate's children should not share same storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on LENS-1471 started by Rajat Khandelwal.
--
> JoinCandidate's children should not share same storage candidate
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via truncate method of
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1471:
---
Summary: JoinCandidate's children should not share same instance of a
storage candidate (was: JoinCandidate's children should not share same
storage candidate )
> JoinCandidate's children should not share same instance of a storage
> candidate
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via truncate method of
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same storage candidate
[
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152472#comment-16152472
]
Rajat Khandelwal commented on LENS-1471:
Created https://reviews.apache.org/r/62060/
> JoinCandidate's children should not share same storage candidate
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
> Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children
> set exclusive measure phrase indices, and that is done via truncate method of
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is
> answering {{\[2,3\]}} measures, and since
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering
> no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (LENS-1471) JoinCandidate's children should not share same storage candidate
Rajat Khandelwal created LENS-1471:
--
Summary: JoinCandidate's children should not share same storage
candidate
Key: LENS-1471
URL: https://issues.apache.org/jira/browse/LENS-1471
Project: Apache Lens
Issue Type: Bug
Components: cube
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal
The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set
exclusive measure phrase indices, and that is done via truncate method of list.
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\])
== \[\]}}, it ends up answering no measures at all
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152121#comment-16152121
]
Rajat Khandelwal commented on LENS-1439:
Committed myself.
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.7, 2.8
>
> Attachments: LENS-1439.01.patch, LENS-1439.01.patch,
> LENS-1439.02.patch
>
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1439:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.7, 2.8
>
> Attachments: LENS-1439.01.patch, LENS-1439.01.patch,
> LENS-1439.02.patch
>
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1439:
---
Fix Version/s: 2.8
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.7, 2.8
>
> Attachments: LENS-1439.01.patch, LENS-1439.01.patch,
> LENS-1439.02.patch
>
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151799#comment-16151799
]
Rajat Khandelwal commented on LENS-1468:
Committed myself.
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1468.01.patch, LENS-1468.02.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1468:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1468.01.patch, LENS-1468.02.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1468:
---
Fix Version/s: 2.8
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.8
>
> Attachments: LENS-1468.01.patch, LENS-1468.02.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147361#comment-16147361
]
Rajat Khandelwal commented on LENS-1468:
Taking patch from reviewboard and attaching
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch, LENS-1468.02.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1468:
---
Attachment: LENS-1468.02.patch
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch, LENS-1468.02.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Re: Review Request 61992: LENS-1468: Expressions in having clauses are not getting rewritten properly for join queries
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61992/
---
(Updated Aug. 30, 2017, 8:22 p.m.)
Review request for lens.
Bugs: LENS-1468
https://issues.apache.org/jira/browse/LENS-1468
Repository: lens
Description
---
The issue is not seen in test cases yet since somehow the order of child
candidates in {{JoinCandidate}} has been fixed. We have observed the order
being non-deterministic in production. And in one ordering, having clause works
fine and in another it doesn't. Will be adding test cases to reproduce this
issue and the fix as well.
Diffs (updated)
-
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java
8906fae1915e71a38e18f42145825afcfe1a1d0b
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
993aa4cbf26d4771bbe714c95abc471534802780
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java
9dc7ee67deb7495f99b53b01839722fb42446d03
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
cf29dff9058aa98bccff9d986fb3756438b50b83
lens-cube/src/test/resources/schema/cubes/base/basecube.xml
6bb5eb9c0cefbec3bf85bf245a3d25b9b4c67b6e
lens-cube/src/test/resources/schema/cubes/derived/der2.xml
337e7f450f96a3b1459556655680388ae2445f25
Diff: https://reviews.apache.org/r/61992/diff/2/
Changes: https://reviews.apache.org/r/61992/diff/1-2/
Testing
---
This is the output of the newly added test case after reverting code fixes:
```
java.lang.AssertionError: having1: HAVING (((sum((basecube.alias1)) +
sum((basecube.alias3)) + sum((basecube.alias4))) > 0) and
((floor(sum((basecube.alias1))) + 0) > 10))
having2: HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) +
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))
expected [HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) +
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))]
but found [HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) +
sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))]
Expected :HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) +
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))
Actual :HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) +
sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))
```
Thanks,
Rajat Khandelwal
Re: Review Request 61992: LENS-1468: Expressions in having clauses are not getting rewritten properly for join queries
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61992/
---
(Updated Aug. 30, 2017, 8:03 p.m.)
Review request for lens.
Bugs: LENS-1468
https://issues.apache.org/jira/browse/LENS-1468
Repository: lens
Description
---
The issue is not seen in test cases yet since somehow the order of child
candidates in {{JoinCandidate}} has been fixed. We have observed the order
being non-deterministic in production. And in one ordering, having clause works
fine and in another it doesn't. Will be adding test cases to reproduce this
issue and the fix as well.
Diffs
-
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java
8906fae1915e71a38e18f42145825afcfe1a1d0b
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
993aa4cbf26d4771bbe714c95abc471534802780
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java
9dc7ee67deb7495f99b53b01839722fb42446d03
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
cf29dff9058aa98bccff9d986fb3756438b50b83
lens-cube/src/test/resources/schema/cubes/base/basecube.xml
6bb5eb9c0cefbec3bf85bf245a3d25b9b4c67b6e
lens-cube/src/test/resources/schema/cubes/derived/der2.xml
337e7f450f96a3b1459556655680388ae2445f25
Diff: https://reviews.apache.org/r/61992/diff/1/
Testing (updated)
---
This is the output of the newly added test case after reverting code fixes:
```
java.lang.AssertionError: having1: HAVING (((sum((basecube.alias1)) +
sum((basecube.alias3)) + sum((basecube.alias4))) > 0) and
((floor(sum((basecube.alias1))) + 0) > 10))
having2: HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) +
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))
expected [HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) +
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))]
but found [HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) +
sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))]
Expected :HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) +
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))
Actual :HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) +
sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))
```
Thanks,
Rajat Khandelwal
[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147317#comment-16147317
]
Rajat Khandelwal commented on LENS-1468:
Taking patch from reviewboard and attaching
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1468:
---
Attachment: LENS-1468.01.patch
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1468:
---
Status: Patch Available (was: In Progress)
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Work started] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on LENS-1468 started by Rajat Khandelwal.
--
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
[
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147315#comment-16147315
]
Rajat Khandelwal commented on LENS-1468:
Created https://reviews.apache.org/r/61992/
> Expressions in having clauses are not getting rewritten properly for join
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
>
> The issue is not seen in test cases yet since somehow the order of child
> candidates in {{JoinCandidate}} has been fixed. We have observed the order
> being non-deterministic in production. And in one ordering, having clause
> works fine and in another it doesn't. Will be adding test cases to reproduce
> this issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries
Rajat Khandelwal created LENS-1468:
--
Summary: Expressions in having clauses are not getting rewritten
properly for join queries
Key: LENS-1468
URL: https://issues.apache.org/jira/browse/LENS-1468
Project: Apache Lens
Issue Type: Bug
Components: cube
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal
The issue is not seen in test cases yet since somehow the order of child
candidates in {{JoinCandidate}} has been fixed. We have observed the order
being non-deterministic in production. And in one ordering, having clause works
fine and in another it doesn't. Will be adding test cases to reproduce this
issue and the fix as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1467: --- Resolution: Fixed Status: Resolved (was: Patch Available) > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1467.01.patch, LENS-1467.02.patch, > LENS-1467.03.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147048#comment-16147048 ] Rajat Khandelwal commented on LENS-1467: Committed myself. > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1467.01.patch, LENS-1467.02.patch, > LENS-1467.03.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1467: --- Fix Version/s: 2.7 > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1467.01.patch, LENS-1467.02.patch, > LENS-1467.03.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1465) Sync queries blocking threads
[ https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1465: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Sync queries blocking threads > - > > Key: LENS-1465 > URL: https://issues.apache.org/jira/browse/LENS-1465 > Project: Apache Lens > Issue Type: Bug > Components: server > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1465.01.patch > > > Sync queries taking more time than timeout are blocking threads due to a > deadlock. Each sync query is blocking one thread from jdbc execution pool and > one thread from query completion pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1465) Sync queries blocking threads
[ https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1465: --- Fix Version/s: 2.7 > Sync queries blocking threads > - > > Key: LENS-1465 > URL: https://issues.apache.org/jira/browse/LENS-1465 > Project: Apache Lens > Issue Type: Bug > Components: server > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1465.01.patch > > > Sync queries taking more time than timeout are blocking threads due to a > deadlock. Each sync query is blocking one thread from jdbc execution pool and > one thread from query completion pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1465) Sync queries blocking threads
[ https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147046#comment-16147046 ] Rajat Khandelwal commented on LENS-1465: Committed myself. > Sync queries blocking threads > - > > Key: LENS-1465 > URL: https://issues.apache.org/jira/browse/LENS-1465 > Project: Apache Lens > Issue Type: Bug > Components: server > Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1465.01.patch > > > Sync queries taking more time than timeout are blocking threads due to a > deadlock. Each sync query is blocking one thread from jdbc execution pool and > one thread from query completion pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart
[ https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1464: --- Resolution: Fixed Status: Resolved (was: Patch Available) > One or two queued queries failing with ConcurrentModificationException on > restart > -- > > Key: LENS-1464 > URL: https://issues.apache.org/jira/browse/LENS-1464 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Rajat Khandelwal > Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1464.01.patch, LENS-1464.02.patch, > LENS-1464.03.patch > > > Happens because of synchronizations issues. If two queries are simultaneously > launching, both try to add resources to hive driver. One of those queries can > fail then. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart
[ https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147043#comment-16147043 ] Rajat Khandelwal commented on LENS-1464: Committed myself. > One or two queued queries failing with ConcurrentModificationException on > restart > -- > > Key: LENS-1464 > URL: https://issues.apache.org/jira/browse/LENS-1464 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Rajat Khandelwal > Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1464.01.patch, LENS-1464.02.patch, > LENS-1464.03.patch > > > Happens because of synchronizations issues. If two queries are simultaneously > launching, both try to add resources to hive driver. One of those queries can > fail then. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146971#comment-16146971 ] Rajat Khandelwal commented on LENS-1467: Taking patch from reviewboard and attaching > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1467.01.patch, LENS-1467.02.patch, > LENS-1467.03.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1467: --- Attachment: LENS-1467.03.patch > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1467.01.patch, LENS-1467.02.patch, > LENS-1467.03.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61942/ --- (Updated Aug. 30, 2017, 3:11 p.m.) Review request for lens. Bugs: LENS-1467 https://issues.apache.org/jira/browse/LENS-1467 Repository: lens Description --- "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed together, which is wrong. Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 8b9583aa62ce3fc0ed94b2b849f12ee48fa16a9b lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 494b08e3b04bcdfea3de449f3740589cc481ba38 lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 866149641fbc2d00263fbe9679b1e89f5325e601 lens-cube/src/test/java/org/apache/lens/cube/parse/CubeQueryContextTest.java PRE-CREATION Diff: https://reviews.apache.org/r/61942/diff/3/ Changes: https://reviews.apache.org/r/61942/diff/2-3/ Testing --- Thanks, Rajat Khandelwal
[jira] [Updated] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart
[ https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1464: --- Attachment: LENS-1464.03.patch > One or two queued queries failing with ConcurrentModificationException on > restart > -- > > Key: LENS-1464 > URL: https://issues.apache.org/jira/browse/LENS-1464 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Rajat Khandelwal > Assignee: Rajat Khandelwal > Attachments: LENS-1464.01.patch, LENS-1464.02.patch, > LENS-1464.03.patch > > > Happens because of synchronizations issues. If two queries are simultaneously > launching, both try to add resources to hive driver. One of those queries can > fail then. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart
[ https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146945#comment-16146945 ] Rajat Khandelwal commented on LENS-1464: Taking patch from reviewboard and attaching > One or two queued queries failing with ConcurrentModificationException on > restart > -- > > Key: LENS-1464 > URL: https://issues.apache.org/jira/browse/LENS-1464 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Rajat Khandelwal > Assignee: Rajat Khandelwal > Attachments: LENS-1464.01.patch, LENS-1464.02.patch, > LENS-1464.03.patch > > > Happens because of synchronizations issues. If two queries are simultaneously > launching, both try to add resources to hive driver. One of those queries can > fail then. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61934/ --- (Updated Aug. 30, 2017, 2:53 p.m.) Review request for lens. Bugs: LENS-1464 https://issues.apache.org/jira/browse/LENS-1464 Repository: lens Description --- Happens because of synchronizations issues. If two queries are simultaneously launching, both try to add resources to hive driver. One of those queries can fail then. Diffs (updated) - lens-server/pom.xml 34a781953918816f68ae51778bacb01996e2483e lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java e70d2905a435f696f62239b1dc30eaa476dc229c Diff: https://reviews.apache.org/r/61934/diff/3/ Changes: https://reviews.apache.org/r/61934/diff/2-3/ Testing --- Thanks, Rajat Khandelwal
[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1467: --- Attachment: LENS-1467.02.patch > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1467.01.patch, LENS-1467.02.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61942/ --- (Updated Aug. 29, 2017, 12:09 p.m.) Review request for lens. Bugs: LENS-1467 https://issues.apache.org/jira/browse/LENS-1467 Repository: lens Description --- "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed together, which is wrong. Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 8b9583aa62ce3fc0ed94b2b849f12ee48fa16a9b lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 494b08e3b04bcdfea3de449f3740589cc481ba38 lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 866149641fbc2d00263fbe9679b1e89f5325e601 lens-cube/src/test/java/org/apache/lens/cube/parse/CubeQueryContextTest.java PRE-CREATION Diff: https://reviews.apache.org/r/61942/diff/2/ Changes: https://reviews.apache.org/r/61942/diff/1-2/ Testing --- Thanks, Rajat Khandelwal
[jira] [Work started] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1467 started by Rajat Khandelwal. -- > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1467.01.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143796#comment-16143796 ] Rajat Khandelwal commented on LENS-1467: Taking patch from reviewboard and attaching > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1467.01.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143794#comment-16143794 ] Rajat Khandelwal commented on LENS-1467: Created https://reviews.apache.org/r/61942/ > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1467.01.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
[ https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated LENS-1467: --- Attachment: LENS-1467.01.patch > CubeQueryContext.getAllFilters is returning incorrect list of filters in case > there is an "OR" in the filters > - > > Key: LENS-1467 > URL: https://issues.apache.org/jira/browse/LENS-1467 > Project: Apache Lens > Issue Type: Bug > Components: cube >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Attachments: LENS-1467.01.patch > > > "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed > together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61942/ --- Review request for lens. Bugs: LENS-1467 https://issues.apache.org/jira/browse/LENS-1467 Repository: lens Description --- "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed together, which is wrong. Diffs - lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 8b9583aa62ce3fc0ed94b2b849f12ee48fa16a9b lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 494b08e3b04bcdfea3de449f3740589cc481ba38 lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 866149641fbc2d00263fbe9679b1e89f5325e601 lens-cube/src/test/java/org/apache/lens/cube/parse/CubeQueryContextTest.java PRE-CREATION Diff: https://reviews.apache.org/r/61942/diff/1/ Testing --- Thanks, Rajat Khandelwal
[jira] [Created] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters
Rajat Khandelwal created LENS-1467: -- Summary: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters Key: LENS-1467 URL: https://issues.apache.org/jira/browse/LENS-1467 Project: Apache Lens Issue Type: Bug Components: cube Reporter: Rajat Khandelwal Assignee: Rajat Khandelwal "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed together, which is wrong. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
