[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163018#comment-15163018 ] Deepak Barr commented on LENS-879: -- Should we close this just like that ? > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Fix For: 2.5 > > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050329#comment-15050329 ] Amareshwari Sriramadasu commented on LENS-879: -- [~ajayyadava], Thanks for taking this up. As per http://lens.apache.org/developer/contribute.html#Submit_patch, we are only attaching the patches to jira once the review gets a ship it, sothat developer can save time in uploading in multiple places. You can go through other guidelines in contributor doc as well for your upcoming patches. > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050425#comment-15050425 ] Rajat Khandelwal commented on LENS-879: --- I believe that attaching patch just for the reason of checking pre-commit results is not a good idea. That would be a misuse of pre-commit job. As a contributor you should be confident about the validity of your patch. I believe the Pre-commit job is to help the committers. The committers have to be sure that the patch is valid and is not breaking anything before committing. Pre-commit job is automating that manual effort. We don't attach patches with every revision posted in reviewboard because * too much noise in email * It's anyway duplicate of something present somewhere else. Whatever be the use of the patch file, can be obtained from reviewboard. * Once committed, earlier patches are useless. I'd say even the committed patch is useless, but the "degree of uselessness" is more :P. The patch that is uploaded on jira is supposed to be a snapshot of the approved patch on reviewboard in case more patches are added on reviewboard later. ** It's a previous version ** Of a useless file ** While being present somewhere else too > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050366#comment-15050366 ] Ajay Yadava commented on LENS-879: -- I was not sure about the git metadata information getting saved in the patch once it's uploaded to the reviewboard. Sometimes for large features it's useful for me to revert back to a particular commit id inside the patch. Another reason was to leverage the precommit build to see if I am making some mistakes and fix them early. Does Hadoop QA also pull the diff from reviewboard and run or is it run only at the end after Ship It? I can skip it if it is producing too much noise on the mailing lists. > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050399#comment-15050399 ] Hadoop QA commented on LENS-879: Applied patch: [LENS-879-v4.patch|https://issues.apache.org/jira/secure/attachment/12776752/LENS-879-v4.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/211/ > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050542#comment-15050542 ] Ajay Yadava commented on LENS-879: -- I was curious about the metadata like git commits(in case multiple commits are there), commit message etc. I tested it by downloading from reviewboard and it retains all the metadata. Thanks! > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050498#comment-15050498 ] Ajay Yadava commented on LENS-879: -- Thanks for the detailed response, appreciate it. My intention was not to propose a change in the workflow but just to get some clarifications. Just for a fresh perspective I will put my views here: I think instead of making the build a committer's prerogative, opening it for contributors will be much helpful. I think same is reflected when most Apache Projects run it on Patch Available queue and not on JIRAs which have "Ship It" or "+1". It is also not about contributor's confidence in patch, uploading your work in open for criticism from everyone requires more confidence. 1. It also provides a sandbox environment for contributors to test their changes with the latest of the trunk. It might be the case that the patch passed on my machine, but fails on Jenkins because of some timing issues in tests. Discovering that issue early is very useful as it might require non trivial changes in design and will cause another round of review from scratch for my patch. 2. It is also not useless as it provides a history of changes over time. If duplication is the concern then probably switching to github workflow for apache is a much better model. 3. It forces some idiosyncratic workflows for LENS e.g. the issues for which the patch is available doesn't have status as "Patch Available". It can also eliminate the need to copy paste the build status and also allow committers to be doubly sure about the quality of patch. All that said, these are just my personal views. As I said earlier also, intention was to just get some clarifications on build/metadata and not propose a new workflow. I am happy to stop posting my patches on JIRA and save some clicks :) > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050536#comment-15050536 ] Hadoop QA commented on LENS-879: Applied patch: [LENS-879-v5.patch|https://issues.apache.org/jira/secure/attachment/12776762/LENS-879-v5.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/212/ > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050894#comment-15050894 ] Hudson commented on LENS-879: - SUCCESS: Integrated in Lens-Commit-Java8 #64 (See [https://builds.apache.org/job/Lens-Commit-Java8/64/]) LENS-879 : Adds Base framework for scheduler (amareshwari: rev 7e9e47ea66109470327607fafb26045080fc969d) * lens-server/src/main/resources/lensserver-default.xml * lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java * pom.xml * src/site/apt/admin/config.apt * lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java * lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java * lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java * lens-api/src/main/resources/scheduler-job-0.1.xsd * lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java * lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java * lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java * lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java * lens-examples/src/main/resources/example-job.xml * lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java * lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java * lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Fix For: 2.5 > > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050917#comment-15050917 ] Hudson commented on LENS-879: - UNSTABLE: Integrated in Lens-Commit #1149 (See [https://builds.apache.org/job/Lens-Commit/1149/]) LENS-879 : Adds Base framework for scheduler (amareshwari: rev 7e9e47ea66109470327607fafb26045080fc969d) * lens-server/src/main/resources/lensserver-default.xml * lens-examples/src/main/resources/example-job.xml * lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java * lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java * lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java * lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java * lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java * src/site/apt/admin/config.apt * lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java * pom.xml * lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java * lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java * lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java * lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java * lens-api/src/main/resources/scheduler-job-0.1.xsd * lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Fix For: 2.5 > > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050913#comment-15050913 ] Amareshwari Sriramadasu commented on LENS-879: -- I feel adding comments on jira is no harm for patches on review board. Otherwise, it can add comments on review board it self, if that can be done. But isn't precommit build triggered with making jira "Patch Available"? Will that introduce an additional step of raising request and making jira PA ? > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Fix For: 2.5 > > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050953#comment-15050953 ] Rajat Khandelwal commented on LENS-879: --- We might have to move away from PreCommit-Admin job which does the bookkeeping of jira-attachment-job. It can add comments on reviewboard, as it will be contextual. But triggering mechanism still needs to be changed. > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Fix For: 2.5 > > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046903#comment-15046903 ] Rajat Khandelwal commented on LENS-879: --- Failure due to LENS-891, reproduced and fixed, Still in review though. > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046900#comment-15046900 ] Hadoop QA commented on LENS-879: Applied patch: [LENS-879-v3.patch|https://issues.apache.org/jira/secure/attachment/12776318/LENS-879-v3.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/209/ > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, > LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030216#comment-15030216 ] Hadoop QA commented on LENS-879: Applied patch: [LENS-879-v2.patch|https://issues.apache.org/jira/secure/attachment/12774662/LENS-879-v2.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/205/ > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027082#comment-15027082 ] Hadoop QA commented on LENS-879: Applied patch: [LENS-879-v1.patch|https://issues.apache.org/jira/secure/attachment/12774367/LENS-879-v1.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/200/ > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879-v1.patch, LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-879) Base framework for Scheduler.
[ https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024398#comment-15024398 ] Hadoop QA commented on LENS-879: Applied patch: [LENS-879.patch|https://issues.apache.org/jira/secure/attachment/12774050/LENS-879.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/189/ > Base framework for Scheduler. > - > > Key: LENS-879 > URL: https://issues.apache.org/jira/browse/LENS-879 > Project: Apache Lens > Issue Type: Sub-task > Components: server >Reporter: Ajay Yadava >Assignee: Ajay Yadava > Attachments: LENS-879.patch > > > Add interfaces for scheduler service and xsd for job. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
